13828 Commits

Author	SHA1	Message	Date
Salman Ahmed	039ab83a46	Disable beatmap options button when none selected	2022-11-17 04:00:23 +03:00
Salman Ahmed	0e46614c57	Revert beatmap option button state changes	2022-11-17 03:57:01 +03:00
Salman Ahmed	7a28a7f2a0	Move IGameplaySettings override to compose screen to keep test mode unaffected	2022-11-17 01:45:16 +03:00
cdwcgt	e1a21e0cf9	create a task to export to avoid block main thread ... Code quality and remove some #nullable disable	2022-11-17 01:08:06 +09:00
Dean Herbert	ee6fffec5f	Fix combo colour normalisation setting not applying to editor test play	2022-11-16 17:54:49 +09:00
nanashi-1	5d8d8ffce5	fix naming	2022-11-16 10:09:51 +08:00
nanashi-1	55edd6c907	add space	2022-11-16 09:58:49 +08:00
nanashi-1	1fb8357e93	change disabledAlpha from readonly to const	2022-11-16 09:58:32 +08:00
nanashi-1	9101ad0cbd	fixed naming	2022-11-16 09:42:40 +08:00
nanashi-1	5973bb1956	AddButton now returns the button	2022-11-15 20:57:31 +08:00
nanashi-1	1186ed3e32	add disable	2022-11-15 20:56:18 +08:00
nanashi-1	e8d170e772	disable certain options when no beatmap is selected	2022-11-15 20:55:55 +08:00
Dean Herbert	489dca79a1	Remove upper limit for pooling	2022-11-15 12:31:25 +09:00
Dean Herbert	308ed1abd1	Fix number of judgements shown potentially exceeding upper limit	2022-11-15 12:31:25 +09:00
Dean Herbert	59a8603728	Ensure flowing animation starts correctly from zero	2022-11-15 12:04:40 +09:00
Dean Herbert	aef6ee23eb	Apply pooling support to ColourHitErrorMeter	2022-11-15 12:04:40 +09:00
Dean Herbert	a86b50d62a	Apply nullability to BarHitErrorMeter	2022-11-15 11:33:27 +09:00
Dean Herbert	576f462f59	Add pooling support to BarHitErrorMeter	2022-11-15 11:33:27 +09:00
maromalo	1911120afe	Merge branch 'master' into long-standard	2022-11-12 09:52:11 -03:00
Thomas Müller-Höhne	fa8e38d9d6	Target rounded fragment shader ... Compatibility with osu-framework change https://github.com/ppy/osu-framework/pull/5512	2022-11-12 17:18:23 +09:00
Dan Balasescu	db25e9e9c8	Merge branch 'master' into combo-colour-brightness-limit	2022-11-11 15:31:28 +09:00
Dan Balasescu	94772a9cda	Merge pull request #21147 from peppy/fix-timeline-editor-crash ... Fix editor hard crash when beatmap file specified out-of-range timeline zoom value	2022-11-10 22:59:55 +09:00
Dan Balasescu	606d42c679	Merge pull request #21184 from peppy/skinnable-things-cleanup ... Skinnable class naming pass	2022-11-10 12:52:08 +09:00
Dan Balasescu	051f7f4c68	Merge pull request #21173 from peppy/toggle-hit-markers ... Add the ability to toggle off hit marker displays in the editor	2022-11-10 12:23:53 +09:00
Dean Herbert	3547c04002	Merge branch 'master' into skinnable-things-cleanup	2022-11-10 12:09:32 +09:00
Piggey	0011f4e7be	fix comment lol	2022-11-09 19:59:04 +01:00
Piggey	4fbc240aa1	Merge remote-tracking branch 'origin/gameplay-leaderboard-fix' into gameplay-leaderboard-fix	2022-11-09 19:53:56 +01:00
Piggey	ab53fb17d3	change displayed text from #? to -	2022-11-09 19:53:36 +01:00
Dean Herbert	1aa0e40f2f	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
Dean Herbert	e75c3b3f94	Rename SkinnableTarget to GlobalSkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	c908969d9b	Rename ISkinComponent to ISkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	4457648b1c	Fix editor playing too many sounds when user performs a manual seek during playback	2022-11-09 17:42:33 +09:00
Dawid Sośnia	9549e55ef8	Merge branch 'ppy:master' into gameplay-leaderboard-fix	2022-11-08 20:04:13 +01:00
Piggey	d48c56818f	change positionText to display "#?" if tracked score is being 51st on the leaderboard	2022-11-08 20:02:21 +01:00
Dean Herbert	4448fcb3c8	Override combo colour brightness normalisation setting only in editor	2022-11-08 18:29:10 +09:00
Dean Herbert	ada039151b	Add the ability to toggle off hit marker displays in the editor	2022-11-08 18:07:06 +09:00
Dean Herbert	9650ae1329	Limit editor background dim to 75% maximum	2022-11-08 17:20:37 +09:00
Dean Herbert	349d262c18	Remove commented unbind	2022-11-08 17:19:48 +09:00
Dean Herbert	b166e477c2	Merge branch 'master' into editor-background	2022-11-08 17:18:34 +09:00
Salman Ahmed	1465d043f4	Merge branch 'master' into song-select-transition-improvement	2022-11-08 03:36:19 +03:00
Dean Herbert	f6d93fcd5a	Fix editor hard crash when beatmap file specified out-of-range timeline zoom value	2022-11-07 12:54:02 +09:00
Dean Herbert	391840404d	Play exiting transition in both directions	2022-11-07 11:59:43 +09:00
maromalo	8eef2ba8de	quality shenanigans	2022-11-06 20:12:26 -03:00
maromalo	b7ef9b176d	Make score type consistent	2022-11-06 19:59:27 -03:00
Bartłomiej Dach	84179fb087	Merge branch 'master' into combo-colour-brightness-limit	2022-11-05 16:48:56 +01:00
Dean Herbert	4f14ae4e34	Adjust transition effect for main menu backgrounds	2022-11-04 17:45:14 +09:00
Dean Herbert	2b934e0bea	Increase delay for changing background on returning to main menu	2022-11-04 17:45:13 +09:00
Dean Herbert	c40c70509e	Improve song select transition to gameplay	2022-11-04 15:24:37 +09:00
Dean Herbert	486515ed90	Merge pull request #20758 from frenzibyte/maintain-common-mod-selection ... Maintain selection of common mods when switching rulesets	2022-11-03 20:08:32 +09:00
Dean Herbert	e336d486a6	Merge pull request #21093 from peppy/auto-skip-multiple-times ... Fix automated skip not skipping more than once when required	2022-11-03 15:46:56 +09:00
Dean Herbert	20dd405c2b	Merge branch 'master' into maintain-common-mod-selection	2022-11-03 15:32:40 +09:00
Dan Balasescu	fc191807c6	Fix velocity test failing with no audio device	2022-11-03 13:59:22 +09:00
Dean Herbert	4154be6cda	Adjust auto-skip to skip multiple times if necessary	2022-11-03 13:52:29 +09:00
Dean Herbert	aef3c7918c	Add total skip count to SkipOverlay	2022-11-03 13:52:24 +09:00
Dean Herbert	3ec9686e58	Fix test failures and rename configuration value to match better	2022-11-02 18:15:18 +09:00
Dean Herbert	0e502de8b4	Rename field to match usage	2022-11-02 18:04:42 +09:00
Dean Herbert	c3eb0c6330	Merge branch 'master' into editor-background	2022-11-02 17:43:38 +09:00
cdwcgt	9884618290	rename editorDim to editorBackgroundDim	2022-11-02 15:12:15 +09:00
cdwcgt	d6b8439121	add xmldoc for DimAmount	2022-11-02 15:11:49 +09:00
Dean Herbert	37300ba9e2	Standardise "Visual Settings" components to fix mismatched paddings and labels	2022-11-02 14:01:57 +09:00
Dean Herbert	50b6fe4acb	Localise new label	2022-11-02 14:01:03 +09:00
Dean Herbert	61fc3c8cc0	Add setting to visual settings toolbox	2022-11-02 13:58:34 +09:00
Dean Herbert	d8aa06ea92	Standardise "Visual Settings" components to fix mismatched paddings and labels	2022-11-02 13:55:56 +09:00
Dean Herbert	2a88409dfe	Fix time snap of sliders not matching when SV is not 1.0x ... This regressed with https://github.com/ppy/osu/pull/20850 because the function was used in other places which expect it to factor slider velocity into the equation. Rather than reverting, I've added a new argument, as based on the method naming alone it was hard to discern whether SV should actually be considered. The reason for the change in #20850 was to avoid the SV coming in from a reference object which may not have a correct SV in the first place. In such cases, passing `false` to the function will give the expected behaviour.	2022-11-01 15:12:58 +09:00
Dean Herbert	9ea2bd84bd	Merge pull request #21018 from andy840119/reuse-the-function-in-timeline-class ... Reuse function in the timeline class	2022-10-30 23:49:02 +09:00
Dean Herbert	1035b5fb19	Fix hold to pause button not working when HUD is hidden	2022-10-30 21:38:45 +09:00
andy840119	a753369d3e	Reuse function TimeAtPosition() and PositionAtTime().	2022-10-30 17:21:50 +08:00
D.Headley	21d68bfb84	Delete unused button	2022-10-28 16:40:21 +02:00
Joseph Madamba	87328dd1f5	Fix bar hit error meter labels not clearing when setting to none	2022-10-27 23:59:01 -07:00
Dan Balasescu	51d8392e7f	Merge pull request #20982 from peppy/remove-obsoleted-simple ... Clean up various obsoleted code	2022-10-28 14:36:04 +09:00
Dean Herbert	42eafe318c	Remove various simple obsoletions	2022-10-28 13:20:58 +09:00
Dean Herbert	71970d83cf	Remove obsoleted ShowProgressGraph global setting ... This was moved to the component itself.	2022-10-28 12:47:45 +09:00
Joseph Madamba	0efbae6e70	Fix osu! logo drag area being a square	2022-10-26 18:33:07 -07:00
cdwcgt	6991195d69	let editor dim different from gameplay dim	2022-10-26 15:22:57 +09:00
Dean Herbert	2016d33055	Offset start of distance snap grid drawing if reference object's start time doesn't align ... Closes #20938.	2022-10-26 13:11:26 +09:00
Dean Herbert	7249542167	Merge pull request #20912 from LittleEndu/carousel-do-not-select-random ... Make beatmap carousel select nearest to selection when selection was filtered	2022-10-26 11:40:56 +09:00
Dean Herbert	d9d083752a	Clamp backwards index to total current items to fix edge case of item removal	2022-10-26 11:03:11 +09:00
Bartłomiej Dach	f5ca447b8e	Rename one more "{duplicate -> clone}" reference	2022-10-25 21:34:41 +02:00
Bartłomiej Dach	bcdf24b972	Merge branch 'master' into add-editor-object-clone	2022-10-25 21:33:52 +02:00
Dean Herbert	cf3bf41b49	Harden and simplify logic to avoid weird issues	2022-10-25 18:57:15 +09:00
Dean Herbert	22ea9a8ab4	Add early return of carousel group has no items	2022-10-25 13:34:22 +09:00
cdwcgt	f9c6190426	Add DimAmount for UserDimContainer	2022-10-25 13:00:53 +09:00
Dean Herbert	2456a18bc1	Rewrite implementation to avoid duplicated LINQ returns	2022-10-25 12:48:17 +09:00
Dean Herbert	4d4f6e25ba	Rename to "clone" instead of "duplicate"	2022-10-25 11:43:23 +09:00
Dean Herbert	1e579e06f8	Fix duplicate working incorrectly if there is no selection currently made	2022-10-25 11:42:12 +09:00
Endrik Tombak	5a118cfdc3	Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection ... Conflicts: osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs	2022-10-24 21:40:48 +03:00
cdwcgt	a2682b3ce3	background dim settings for editor ... View -> Background Dim follow `DimLevel` and `BlurLevel` Co-Authored-By: Dead_Bush_Sanpai <DeadBushSanpai@yandex.com>	2022-10-24 23:55:33 +09:00
cdwcgt	de881cc5cb	useless #nullable disable	2022-10-24 23:17:28 +09:00
Dean Herbert	1d5df15027	Add ability to use Shift+Number to set current beat divisor in editor	2022-10-24 15:20:15 +09:00
Dean Herbert	e72a71a28e	Add simple editor "duplicate objects" key binding	2022-10-24 14:01:34 +09:00
Dean Herbert	849b50a38f	Use ToUpperInvariant for added safety ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-10-21 00:16:33 +09:00
Dean Herbert	6b26547d03	Merge pull request #20835 from frenzibyte/improve-hide-mouse-on-keyboard ... Improve automatic cursor hiding logic and limit to gameplay screen	2022-10-20 11:44:20 +09:00
Dean Herbert	2f8a4fd2d0	Merge branch 'master' into remove-current-item	2022-10-20 10:02:09 +09:00
Dean Herbert	77b25c4a5c	Merge pull request #20788 from frenzibyte/handle-submitting-player-request-timeout ... Fix potential exception in `SubmittingPlayer` token retrieval on request timeout	2022-10-20 09:51:57 +09:00
Salman Ahmed	4bf4938b72	Keep cursor hiding feature to gameplay screens for now	2022-10-20 03:44:58 +03:00
Dean Herbert	372a655be1	Ensure placement uses currently selected bank	2022-10-19 21:39:51 +09:00
Dean Herbert	50e24ddd87	Add icon and radio button logic	2022-10-19 21:35:08 +09:00
Dean Herbert	9222cb379f	Add sample bank suport to editor selection handler	2022-10-19 20:53:18 +09:00
Dean Herbert	fbad33bef7	Adjust durations and make start off screen	2022-10-18 15:01:53 +09:00
Dean Herbert	84688b53a1	Merge branch 'fix-editor-padding' into player-loader-improvements	2022-10-18 14:52:59 +09:00
Dean Herbert	6a7f6c76ff	Fix osu! editor padding being applied to toolboxes ... The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.	2022-10-18 14:32:00 +09:00
Dean Herbert	0f809dcaa7	Merge branch 'master' into player-loader-improvements	2022-10-18 14:22:55 +09:00
Dean Herbert	516320edd9	Merge branch 'master' into handle-submitting-player-request-timeout	2022-10-17 18:51:13 +09:00
Dan Balasescu	4220d6b3fc	Merge pull request #20780 from outfoxxed/fix-hiterror-icons ... Fix hit error bar icon orientation	2022-10-17 18:48:31 +09:00
Dean Herbert	1e7b8cd227	Fix formatting issues	2022-10-17 13:22:06 +09:00
Salman Ahmed	ae05f374a2	Fix potential invalid operation exception in SubmittingPlayer token retrieval	2022-10-17 03:26:29 +03:00
outfoxxed	85de802793	Only create hit error bar icon containers once ... Move icon container creation to BDL, and only recreate the contained icon when `recreateLabels` is called	2022-10-16 11:47:21 -07:00
outfoxxed	d6030891a2	Reuse existing code in hit error bar fix ... Use `UprightAspectMaintainingContainer` instead of a local fix for hit error bar orientation	2022-10-16 10:06:38 -07:00
outfoxxed	cd1885a17b	Fix hit error bar icon orientation ... Icons now keep their original orientation when the hit error bar is flipped	2022-10-16 02:55:10 -07:00
Salman Ahmed	324c749383	Merge branch 'master' into player-loader-improvements	2022-10-15 03:07:15 +03:00
Salman Ahmed	ba72f13f54	Merge branch 'master' into hide-mouse-on-keyboard-input	2022-10-14 22:26:30 +03:00
Dan Balasescu	10aabfc650	Merge pull request #20739 from peppy/settings-toolbox ... Adjust visuals of settings toolboxes (gameplay loading screen and editor)	2022-10-14 20:31:05 +09:00
Dan Balasescu	dcb6357964	Add ability to remove the current item in multiplayer	2022-10-14 20:23:55 +09:00
Dan Balasescu	525f98c158	Fix max combo missing from playlists results screen	2022-10-14 18:01:54 +09:00
Salman Ahmed	01c65d3cc1	Remove seemingly unnecessary/leftover code	2022-10-14 02:16:36 +03:00
Dean Herbert	3645269108	Improve logo transition and reduce delay of exiting player loader in optimal conditions	2022-10-13 17:29:47 +09:00
Dean Herbert	b33935e392	Fix player loading screen settings scaling in ... This always looked weird, and from the looks of the structure was probably unintentional from the start (it is in the logo tracking container for whatever reason).	2022-10-13 17:12:36 +09:00
Dean Herbert	15f9697c9f	Roughly update design of editor buttons	2022-10-13 16:57:25 +09:00
Dean Herbert	0f4a2a6059	Improve feel of settings toolbox group	2022-10-13 16:36:19 +09:00
Dean Herbert	c3902728f6	Reorganise beatmap snap control to work better in compact mode	2022-10-13 15:47:54 +09:00
Dean Herbert	a525b3f9f8	Reorder and rename toggle checkboxes to fit better	2022-10-13 15:44:33 +09:00
Dean Herbert	f6f5d33f53	Add slight padding to playfield (roughly matches stable)	2022-10-13 15:44:23 +09:00
Dean Herbert	ebc1088457	Merge pull request #20729 from frenzibyte/update-local-confirmation-dialog ... Request user confirmation on updating locally-modified beatmaps	2022-10-13 12:36:37 +09:00
Dean Herbert	c9b4cacc20	Merge pull request #20724 from mk56-spn/Highest_Combo_Counter ... Add "longest combo" counter to HUD components.	2022-10-13 12:26:49 +09:00
Salman Ahmed	964ed01abb	Add confirmation dialog for updating locally modified beatmaps	2022-10-13 02:40:15 +03:00
Dean Herbert	19f3810020	Revert namespace change ... Let's not	2022-10-12 18:50:47 +09:00
Dan Balasescu	9473c350b5	Merge pull request #20266 from cdwcgt/catch-combo-hide ... Fade out CatchComboDisplay when hide HUD	2022-10-12 16:59:07 +09:00
Dario Headley	b72c8970eb	Max Combo Counter added	2022-10-12 09:50:01 +02:00
Dan Balasescu	300888b423	Merge pull request #20720 from peppy/fix-welcome-intro-delay ... Fix incorrect delay for non-theme music on "welcome" intro	2022-10-12 16:15:54 +09:00
Dean Herbert	d2d589a156	Expose HUD state via Player	2022-10-12 15:11:52 +09:00
Dean Herbert	1d6d047a69	Merge branch 'master' into master	2022-10-12 14:52:07 +09:00
Dean Herbert	d6998c810c	Fix incorrect delay for non-theme music on "welcome" intro	2022-10-12 14:51:14 +09:00
Dean Herbert	db148d145b	Fix incorrect offset logic for beatmaps without a preview point specified	2022-10-12 14:47:37 +09:00
Dean Herbert	ab24e87013	Merge branch 'master' into improve-drag-selection	2022-10-12 13:20:17 +09:00
Dean Herbert	a5948e7680	Merge pull request #20704 from ekrctb/scrolling-drag-box ... Anchor editor drag box on time (catch, mania)	2022-10-12 11:48:05 +09:00
ekrctb	fcb9e2cc00	Refactor blueprint container drag code	2022-10-11 22:39:53 +09:00
Salman Ahmed	9b45a9cf76	Rename various cursor symbols ... - `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor` - `MenuCursor` -> `MenuCursorContainer	2022-10-11 16:21:01 +03:00
Dan Balasescu	cc0ca470f1	Merge pull request #20702 from peppy/update-prefer-no-video ... Fix beatmap update button not respecting user "prefer no video" setting	2022-10-11 19:36:14 +09:00
Dan Balasescu	88e82d3154	Merge pull request #20681 from peppy/fix-hidden-hud-interaction ... Fix HUD components being interactive even when the HUD is visually hidden	2022-10-11 17:19:27 +09:00
NotGumballer91	d18466d740	Fix delay inconsistency in IntroCircles.cs	2022-10-11 16:16:57 +08:00
NotGumballer91	5baad52a9e	Fix unintended delay on osu!theme	2022-10-11 16:15:56 +08:00
Dean Herbert	f41b79688f	Avoid casting by accepting all Playfields but throwing on a bad choice	2022-10-11 16:54:41 +09:00
Dean Herbert	a44ba579c5	Fix beatmap update button not respecting user "prefer no video" setting ... Closes #20701.	2022-10-11 14:27:40 +09:00
ekrctb	6ab29a62d0	Anchor drag box on time (catch, mania) ... Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.	2022-10-11 14:23:17 +09:00
ekrctb	1a24762f9b	Improve drag box selection logic ... `AllowDeselectionDuringDrag` is remove. Instead, selected hit objects are not automatically deselected when clock is seeked to a later time (the hit object is dead). Update drag box selection even if mouse is not moved (in case clock is running or scroll wheel is used).	2022-10-11 14:11:45 +09:00
Dean Herbert	cb21126623	Merge pull request #20586 from ekrctb/time-based-selection ... Use hit object time for timeline drag selection instead of relying on blueprint	2022-10-11 13:20:15 +09:00
NotGumballer91	ef840e98cf	Update IntroCircles.cs	2022-10-11 01:49:53 +08:00
NotGumballer91	8a4f2efa14	Update IntroScreen.cs	2022-10-11 01:49:49 +08:00
NotGumballer91	9a3689b6e9	Update IntroCircles.cs	2022-10-10 21:04:14 +08:00
Dean Herbert	20adc522b9	Fix HUD components being interactive even when the HUD is visually hidden	2022-10-10 16:05:41 +09:00
Dan Balasescu	c18d4afdcc	Merge branch 'master' into fix-leaderboard-first-place-fade	2022-10-07 19:55:16 +09:00
Dan Balasescu	57e4d6cc4a	Merge pull request #20562 from peppy/fix-score-submission-crash ... Fix potential crash when score submission token retrival fails	2022-10-07 19:24:35 +09:00
ekrctb	6164e0896a	Don't reselect already selected items in SelectAll	2022-10-07 10:46:07 +09:00
ekrctb	29cc554632	Ensure blueprint is added for selected hit object	2022-10-06 13:59:54 +09:00
ekrctb	0d448e6cc8	Fix items without blueprints are not deselected	2022-10-06 13:50:56 +09:00
ekrctb	b0213c29e9	Use mid time instead of start time ... It is closer to the old blueprint-based behavior	2022-10-05 22:19:22 +09:00
ekrctb	6753f6b01a	Move AllowDeselectionDuringDrag down ... Because it is now ignored in the timeline implementation anyways	2022-10-05 22:14:11 +09:00
ekrctb	3108c42ece	Fix inspect issues	2022-10-05 22:04:43 +09:00
ekrctb	00b3d97f69	Improve timeline selection performance ... But selecting a large number of hit objects is still very slow because all DHOs must be added and also `AddBlueprintFor` has quadratic behaviors	2022-10-05 21:58:05 +09:00
ekrctb	0613388aaa	Make sure all selected items get deleted	2022-10-05 21:58:05 +09:00
ekrctb	0ffde02f79	Use hit object time for timeline selection	2022-10-05 21:51:01 +09:00
ekrctb	8d29e9e76b	Move selection logic from DragBox to BlueprintContainer	2022-10-05 21:51:01 +09:00
Dean Herbert	276021dd85	Remove now unnecessary ScheduleAfterChildren	2022-10-05 14:20:01 +09:00
Dean Herbert	c7d645b086	Merge branch 'master' into fix-gameplay-leaderboard-overlap	2022-10-05 14:15:50 +09:00
Dean Herbert	75b9bf2cf9	Merge branch 'master' into intel-exclusive-warning	2022-10-04 19:02:01 +09:00
Dean Herbert	d9f678d942	Change song select random key binding to not handle key repeat	2022-10-03 18:16:54 +09:00
Dean Herbert	42aac16b37	Adjust leaderboard score panels sizing based on accuracy/combo width	2022-10-03 18:12:36 +09:00
Dean Herbert	65369e96eb	Ensure token retrieval failure logic only runs once	2022-10-03 17:29:46 +09:00
Dean Herbert	c4dd23ed15	Log token retrieval failures even when gameplay is allowed to continue	2022-10-03 17:29:34 +09:00
Dean Herbert	4dbac917fc	Merge pull request #20547 from nanashi-1/solo-gameplay-leaderboard-max-combo ... Display highest combo rather than current combo for local play on leaderboard	2022-10-03 16:57:05 +09:00
Salman Ahmed	a810afafb3	Reschedule results display delegate to avoid potential softlocks in the future	2022-10-02 15:37:56 +03:00
Salman Ahmed	59728b0ccb	Fix results display delegate potentially cancelled while not exiting	2022-10-02 15:30:06 +03:00
nanashi-1	2493468800	display highest combo instead of current combo	2022-10-02 18:40:31 +08:00
Dean Herbert	cbbca616c1	Merge branch 'master' into fix-leaderboard-first-place-fade	2022-09-28 17:58:45 +09:00
Dean Herbert	9b3778f226	Merge pull request #20507 from smoogipoo/fix-multiplayer-tests ... Fix failing multiplayer tests	2022-09-28 17:41:55 +09:00
Dan Balasescu	715b1f64f3	Merge pull request #20518 from peppy/fix-leaderboard-wobble ... Fix leaderboard wobble when in first place	2022-09-28 17:03:31 +09:00
Dean Herbert	cdcc8494c9	Fix fade being applied for too long when leaderboard scrolls to start	2022-09-28 16:10:19 +09:00
Dean Herbert	c8643ed265	Set ClampExtension to zero to stop jittering	2022-09-28 15:58:00 +09:00
Dean Herbert	8edb1cb98a	Add test coverage of current score staying on screen	2022-09-28 15:57:50 +09:00
Dan Balasescu	a0d05f5bb7	Merge pull request #20501 from peppy/fix-editor-initial-performance ... Fix editor performance being sub-par on beatmap load	2022-09-27 21:34:04 +09:00
Dan Balasescu	da8d94c4b4	Fix test failures due to scheduled operations	2022-09-27 20:24:44 +09:00
Dean Herbert	58217b6839	Fix weird conditional	2022-09-27 20:09:21 +09:00
Dan Balasescu	8642ed7631	Merge pull request #20504 from peppy/fix-playlist-connectivity-crash ... Fix potential crash when losing network connectivity in multiplayer/playlists screens	2022-09-27 18:36:24 +09:00
Dean Herbert	3ece7205ed	Fix potential crash when losing network connectivity at online play screen ... Addresses #20448.	2022-09-27 17:52:34 +09:00
Dean Herbert	0296685c74	Start key counter / gameplay leaderboard hidden to avoid initial fade out	2022-09-27 17:25:24 +09:00
Dean Herbert	a9088d9231	Add assert/log output when too many ticks are being displayed	2022-09-27 17:18:46 +09:00
Dean Herbert	e227519b09	Don't attempt to render timeline ticks until DrawWidth is above zero	2022-09-27 17:18:46 +09:00
Dean Herbert	ccae721af2	Ensure ZoomableScrollContainer content isn't shown until zoom is set	2022-09-27 17:07:11 +09:00
Dean Herbert	9dc0eb7fd0	Remove unused static	2022-09-27 17:04:56 +09:00
Dean Herbert	320f134634	Use same logic as KeyCounterDisplay	2022-09-27 15:01:18 +09:00
nanashi-1	5d18001d75	move config	2022-09-26 21:11:38 +08:00
nanashi-1	4295d9c169	revert	2022-09-26 21:11:14 +08:00
nanashi-1	ee4d1b2d58	add config visibility	2022-09-26 20:13:07 +08:00
Dan Balasescu	c969afcb71	Merge branch 'master' into leaderboard-nrt	2022-09-26 17:12:19 +09:00
Dan Balasescu	28470bd5c0	Merge pull request #20486 from peppy/gameplay-leaderboard-nrt ... Apply NRT to `GameplayLeaderboard` hierarchy	2022-09-26 17:11:51 +09:00
Dan Balasescu	426ab176d6	Merge pull request #20418 from peppy/fix-leaderboard-crash ... Fix intermittent leaderboard crash due to request finishing after drawable is disposed	2022-09-26 17:10:32 +09:00
Dean Herbert	20da1051d9	Apply NRT to GameplayLeaderboard hierarchy ... Just some cleanup work that I wanted to do as part of my last changes.	2022-09-26 16:21:24 +09:00
Dean Herbert	5fc836d1f0	Apply NRT to BeatmapLeaderboard / MatchLeaderboard	2022-09-26 16:17:28 +09:00
Dean Herbert	32d56fe3a9	Use request cancellation and IsDisposed guard instead of more Schedule	2022-09-26 16:02:33 +09:00
o-dasher	feadac1f79	Cleanup all other leftover binding instantiation	2022-09-25 16:02:40 -04:00
Dean Herbert	0fa5e1b28e	Fix intermittent leaderboard crash due to request finishing after drawable is disposed	2022-09-23 20:18:44 +09:00
Dean Herbert	a65a76f7de	Fix off-thread drawable mutation in multiplayer settings overlay when an error occurs ... Closes #20413.	2022-09-23 20:05:32 +09:00
Dan Balasescu	1d1012e196	Merge pull request #20286 from peppy/gameplay-leaderboards ... Add basic gameplay leaderboard display	2022-09-22 21:16:12 +09:00
Dan Balasescu	6a0047b7a2	Update location of FullscreenCapability bindable	2022-09-22 21:01:23 +09:00
Dan Balasescu	445e026a32	Merge pull request #20389 from peppy/fix-gameplay-leaderboard-layout ... Fix gameplay leaderboard sometimes not showing up	2022-09-22 20:51:54 +09:00
Dean Herbert	8f7a306d81	Inline comment regarding margin necessity	2022-09-22 19:53:16 +09:00
Dean Herbert	f0dcda9acc	Decrease precision of spacing setting	2022-09-22 15:49:02 +09:00
Dean Herbert	26d98323ff	Fix bindable flow, code quality, everything	2022-09-22 15:45:23 +09:00
Dean Herbert	0f663deda0	Fix changing shape causing alpha to be permanently reset to zero	2022-09-22 15:24:57 +09:00
Dean Herbert	ae70b2c32f	Fix other weirdness in variable and description naming	2022-09-22 15:21:27 +09:00
Dean Herbert	19db7c5977	Remove "Opacity" setting ... This should be implemented at a higher level	2022-09-22 15:19:01 +09:00
Dean Herbert	f3898da37a	Rename judgement count to not mention "shape"	2022-09-22 15:18:20 +09:00
Dean Herbert	7d93fa9f65	Merge branch 'master' into Colour_hit_meter_improved	2022-09-22 15:11:58 +09:00
Dean Herbert	5b73f24864	Fix outdated scores being held by BeatmapLeaderboard after external beatmap switch	2022-09-21 15:21:32 +09:00
Dean Herbert	29c4d06d36	Merge branch 'fix-gameplay-leaderboard-layout' into gameplay-leaderboards	2022-09-21 14:58:58 +09:00
Dean Herbert	b04871f40a	Animate scroll for a better visual experience	2022-09-21 14:51:12 +09:00
Dean Herbert	087ca59ebb	Add extra margin space to flow equal to height of leaderboard ... This ensures the content is always on screen, but also accounts for the fact that scroll operations without animation were actually forcing the local score to a location it can't usually reside at. Basically, the local score was in the scroll extension region (due to always trying to scroll the local player to the middle of the display, but there being no other content below the local player to scroll up by).	2022-09-21 14:51:12 +09:00
Dean Herbert	4385001d28	Fix solo leaderboard seeing imported score via realm subscription flow	2022-09-21 13:59:11 +09:00
Dean Herbert	a8338c4efd	Add local score after existing scores to avoid initial re-sort	2022-09-21 13:38:40 +09:00
Dean Herbert	4492a26b59	Merge branch 'master' into argon-skin	2022-09-21 13:00:16 +09:00
Dan Balasescu	8bf196d561	Merge pull request #20354 from peppy/default-skin-refactor ... Rename default skin to make way for new version	2022-09-21 11:48:38 +09:00
Dan Balasescu	7f15dc6e6c	Merge pull request #20321 from HiddenNode/fix_graph_info_overlap ... Fix Progress bar info text overlapping with progress graph	2022-09-20 19:30:51 +09:00
Dan Balasescu	80d8eedb7c	Merge pull request #20366 from peppy/fix-nullable-download-progress ... Fix multiplayer crashes due to incorrect download state	2022-09-20 17:16:11 +09:00
Dean Herbert	68c040175a	Ensure Leaderboard.Scores is updated immediately via request flow	2022-09-20 17:02:57 +09:00
Dean Herbert	b5771ece41	Reduce the amount by which clicking the mute notification incraeses volume	2022-09-20 13:00:08 +09:00
Dean Herbert	a9c120c214	Reduce volume requirement for showing muted notification to 1%	2022-09-20 12:46:35 +09:00
Dean Herbert	1c02fa8399	Update comment to not mention horizontal plane	2022-09-20 00:08:06 +09:00
Dean Herbert	46db3ad96d	Move implementation to individual classes	2022-09-20 00:06:02 +09:00
Dean Herbert	0f7b38f4c3	Add new default skin "argon"	2022-09-19 23:16:46 +09:00
Dean Herbert	0ac28cbecc	Fix potential crash from missing DownloadProgress	2022-09-18 23:42:16 +09:00
Dean Herbert	1914c41d0d	Merge pull request #20353 from Drison64/fix-timelineZoom-zero ... EditorBeatmap's TimelineZoom should never be zero	2022-09-18 18:06:26 +09:00
Dan Balasescu	2dcaf7cfd8	Fix memory leak due to missing event unbind	2022-09-18 14:25:31 +09:00
Ryuki	ecf71df8a2	Change CornerRadius Max Value	2022-09-18 00:04:56 +02:00
Drison64	c075d3de08	Create a test and a check if initial zoom value of ZoomableScrollContainer is in range	2022-09-17 22:43:40 +02:00
Ryuki	c1077d909c	Basic avatar HUD implementation	2022-09-17 21:09:34 +02:00
Ondřej Vajďák	9d94343317	Update osu.Game/Screens/Edit/Compose/Components/Timeline/Timeline.cs ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-09-17 19:51:44 +02:00
Drison64	c8768eb399	Changed == to <= on TimelineZoom check	2022-09-17 19:00:50 +02:00
Drison64	3c7ea5c8fa	Update	2022-09-17 18:57:09 +02:00
Dean Herbert	41e69fbca6	Remove "default" prefix from naming	2022-09-18 00:15:26 +09:00
Dean Herbert	51841988bf	Rename references to DefaultSkin to have Triangles suffix	2022-09-17 23:57:25 +09:00
HiddenNode	2dfa89c62e	Clean up	2022-09-17 15:05:25 +01:00
Drison64	0b6a77bc8b	EditorBeatmap's TimelineZoom should never be zero	2022-09-17 15:59:42 +02:00
HiddenNode	d580b07063	Refactor update condition logic	2022-09-17 14:40:36 +01:00
HiddenNode	e3d5ba5301	Check if graph DrawSize changed	2022-09-17 11:44:25 +01:00
HiddenNode	0d76f4501d	Revert "Set InvalidationSource to Self" ... This reverts commit 2092008251.	2022-09-17 10:10:20 +01:00
Dean Herbert	4c4fdfd153	Provide scores directly to Player instance rather than relying on DI	2022-09-16 18:15:17 +09:00
Dean Herbert	0227eddda1	Merge branch 'master' into gameplay-leaderboards	2022-09-16 15:44:58 +09:00
Dan Balasescu	d9499abc33	Refactor to avoid passing around bindables	2022-09-16 13:14:25 +09:00
Drison64	4f208416be	Fixed irresponsiveness of score panel timestamp to time format	2022-09-16 13:50:18 +14:00
HiddenNode	2092008251	Set InvalidationSource to Self	2022-09-15 11:16:00 +01:00
HiddenNode	8286ab0d04	Revert "Fix SongProgress invalidating too often" ... This reverts commit 2b4b14ca99.	2022-09-15 11:11:58 +01:00
Dean Herbert	40a60f7145	Remove all entity framework code and migrations	2022-09-15 16:58:58 +09:00
Dean Herbert	eb18d3661d	Merge pull request #20309 from mk56-spn/dead_class_removal ... Unused class KeyCounterState.cs Removal	2022-09-15 03:38:39 +09:00
Mk-56spn	d6db82283a	Removes unused class	2022-09-14 18:01:29 +02:00
Dean Herbert	fcf54f1bc8	Fix gameplay leaderboard not being sorted correctly in tie situations	2022-09-14 14:18:12 +09:00
Dean Herbert	8a6977213a	Fix displayed scores in gameplay leaderboard not tracking display mode changes	2022-09-14 14:02:35 +09:00
Dean Herbert	b4e6a20846	Fix song select status prefix matching no longer working ... Regressed in #19275 due to weird logic. Closes #20289.	2022-09-14 12:59:05 +09:00
Dean Herbert	81b5e4a865	Fix back-to-front condition on leaderboard always show configuration	2022-09-13 19:57:40 +09:00
Dean Herbert	94693a4667	Fix oversight when making interface implementation explicit	2022-09-13 19:55:57 +09:00
Dean Herbert	e15a25ea49	Fix leaderboard positioning logic to actually consider elements on the left side	2022-09-13 18:45:11 +09:00
Dean Herbert	678eec1c67	Move LeaderboardFlow to HUDOverlay to share positioning logic	2022-09-13 18:45:11 +09:00
Dean Herbert	5894d2f0bc	Ensure gameplay leaderboard hides with rest of HUD when it should	2022-09-13 18:45:11 +09:00
Dean Herbert	6d167070f8	Add back DI leaderboard retrieval via bindable pathway	2022-09-13 18:45:11 +09:00
Dean Herbert	70e6b595f1	Refactor SoloGameplayLeaderboard to not read scores via DI ... Also allows updating scores if they arrive late.	2022-09-13 18:00:21 +09:00
Dean Herbert	d2b80645ab	Change Leaderboard to use IUser instead of APIUser	2022-09-13 18:00:21 +09:00
Dean Herbert	d251c0b2ac	Move leaderboard implementation to Player itself	2022-09-13 18:00:21 +09:00
Dean Herbert	368faa0084	Make constructor protected in base implementation	2022-09-13 18:00:21 +09:00
Dean Herbert	4c669e2bce	Track local Player.Score's user rather than using APIProvider	2022-09-13 18:00:21 +09:00
Salman Ahmed	3490b16056	Add simplified SoloGameplayLeaderboard implementation ... Note that this doesn't support waiting until leaderboard finishes fetching scores.	2022-09-13 18:00:21 +09:00
Dean Herbert	27a81dfb9f	Merge pull request #20270 from OliBomby/fix-selectionblueprint-order ... Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes	2022-09-13 17:18:58 +09:00
Dan Balasescu	0e2155303e	Merge branch 'master' into fix-song-progress-invalidations	2022-09-13 16:07:05 +09:00
Dean Herbert	f53507828c	Rename event to be more generic (and add comprehensive xmldoc)	2022-09-13 14:59:30 +09:00
Dean Herbert	ac034bffeb	Fix potential crash if multiplayer spectator load is aborted early	2022-09-13 14:21:54 +09:00
OliBomby	fd48249eef	fix with new event	2022-09-13 02:20:52 +02:00
OliBomby	718f8c4ee2	revert the fix	2022-09-13 01:09:42 +02:00
OliBomby	8400de4b2e	invoking hitobject updated before invoking removed	2022-09-12 17:50:11 +02:00
Dean Herbert	2b4b14ca99	Fix SongProgress invalidating too often ... This regressed with https://github.com/ppy/osu/pull/19556. Rather than try and figure whether that new container needs to handle size differently, this is a simple solution. Height was taken from a runtime check (maxes out at about 14.5). Closes #20235.	2022-09-12 20:06:53 +09:00
Dean Herbert	cb6d02ec3a	Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset ... Remove the nullable disable annotation in the ruleset class	2022-09-12 19:07:23 +09:00
Dan Balasescu	4b37330316	Merge pull request #20248 from acid-chicken/fix/stats/td ... Fix new hit distribution graph didn't account for size changes	2022-09-12 18:11:18 +09:00
Dan Balasescu	3cfacb5e39	Merge pull request #20257 from peppy/update-button-show-login ... Show login overlay when attempting to update a beatmap while logged out	2022-09-12 17:51:45 +09:00
Acid Chicken (硫酸鶏)	4f298db066	fix(osu.Game): reset Y axis of the bars in hit distribution graph at the first drawing	2022-09-12 16:25:29 +09:00
Acid Chicken (硫酸鶏)	0d0e2e7bcc	fix(osu.Game): bars in hit distribution graph stretching in the opposite direction when DrawHeight is less than DrawWidth	2022-09-12 16:20:33 +09:00
Dan Balasescu	31225066a1	Merge pull request #19308 from frenzibyte/top-rank-badge-order ... Fix best rank badge not handling legacy scores properly	2022-09-12 16:20:21 +09:00
Dean Herbert	94f8197e22	Show login overlay when attempting to update a beatmap while logged out	2022-09-12 16:15:14 +09:00
Dean Herbert	96951057df	Avoid using bindables	2022-09-12 15:56:06 +09:00
Dean Herbert	bcd2445d9b	Move helper functions down in file	2022-09-12 15:50:10 +09:00
Dean Herbert	0755289ec3	Apply NRT to HitEventTimingDistributionGraph	2022-09-12 15:48:50 +09:00
Acid Chicken (硫酸鶏)	ac324c63e2	fix(osu.Game): handle size changes in timing distribution graph	2022-09-12 04:46:32 +09:00
Mk-56spn	c00bf61273	Framework change adressed	2022-09-10 21:24:29 +02:00
MK56	8661dc3c93	Merge branch 'ppy:master' into Colour_hit_meter_improved	2022-09-10 21:16:23 +02:00
Mk-56spn	f6aef73f9e	fixed shape bindable not working, test creation, removal of Clear(), adjusted settings names	2022-09-10 20:30:43 +02:00
andy840119	3d7367a842	Move the CreateConvertibleReplayFrame() into the base ruleset class for avoid api breaking change in the customized ruleset.	2022-09-10 11:07:23 +08:00
andy840119	e62999fb16	Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset ... # Conflicts: # osu.Game.Rulesets.Catch/CatchRuleset.cs # osu.Game.Rulesets.Osu/OsuRuleset.cs # osu.Game.Rulesets.Taiko/TaikoRuleset.cs # osu.Game/Rulesets/Ruleset.cs	2022-09-10 10:40:12 +08:00
Salman Ahmed	95062c2cc8	Remove center origin specification to avoid single-frame layout issues	2022-09-09 19:42:58 +03:00
Salman Ahmed	dd10a06e3d	Merge branch 'master' into top-rank-badge-order	2022-09-09 19:38:44 +03:00
solstice23	823078ed2d	Merge branch 'master' into search-filter	2022-09-09 23:12:37 +08:00
Dean Herbert	602ffebd54	Apply NRT and fix code style	2022-09-09 23:29:04 +09:00
Dean Herbert	d961b96897	Merge branch 'master' into search-filter	2022-09-09 23:25:54 +09:00
Dean Herbert	27f745b980	Merge branch 'master' into fix_progress_bar_info	2022-09-09 17:34:13 +09:00
Dean Herbert	05797cb9e5	Fix enum to STRING????????? conversion (and use bindable flow)	2022-09-09 16:30:08 +09:00
Dean Herbert	f1fa442287	Merge pull request #19599 from ItsShamed/kps ... Add clicks/second counter to HUD	2022-09-09 01:50:12 +09:00
Dean Herbert	6945c43e0d	Merge pull request #20178 from smoogipoo/fix-match-creation-beatmap-select ... Fix several weird scenarios with online play song selection	2022-09-08 23:07:09 +09:00
Dean Herbert	45239fc737	Update TrueGameplayRate accessing	2022-09-08 23:03:15 +09:00
Dean Herbert	d4afc3629c	Merge branch 'master' into kps	2022-09-08 23:00:36 +09:00
Dan Balasescu	9aab502adc	Merge pull request #20157 from peppy/true-gameplay-rate ... Refactor `TrueGameplayRate` to account for only gameplay adjustments, no matter what	2022-09-08 19:54:32 +09:00
Dan Balasescu	4fc03998a1	Merge pull request #20189 from peppy/fix-playlist-item-download-button-visibility ... Fix playlist items showing download button briefly during initial display	2022-09-08 19:47:35 +09:00
Dean Herbert	096d1c3ff3	Merge pull request #20143 from acid-chicken/feat/stats/colored-td ... Show judgement colours in hit distribution graph	2022-09-08 19:15:40 +09:00
Dean Herbert	13d9b2188b	Merge pull request #20145 from smoogipoo/multiple-countdowns ... Implement support for multiple active countdowns in multiplayer	2022-09-08 19:15:30 +09:00
Dean Herbert	a98c6b2c1f	Add comment metioning why we need to use DrawableRuleset lookup	2022-09-08 19:14:23 +09:00
Mk-56spn	07c16224d2	Fix Main file issues	2022-09-08 11:58:14 +02:00
Dean Herbert	5c2fb3e434	Simplify calculation method	2022-09-08 18:22:53 +09:00
Dean Herbert	d463bd2f3f	Merge pull request #20130 from Exanc/master ... Display 0 stars instead of infinity for the minimum star slider	2022-09-08 17:51:32 +09:00
Dean Herbert	c6521e4c72	Rename ordering helper method	2022-09-08 17:50:27 +09:00
Dan Balasescu	76eae73fa4	Revert unintended change	2022-09-08 17:41:23 +09:00
Dan Balasescu	c61c596c1f	Expose as readonly IAggregateAudioAdjustment	2022-09-08 17:37:02 +09:00
Dan Balasescu	b559d4ecdf	Rename GameplayAdjustments -> AdjustmentsFromMods	2022-09-08 17:14:06 +09:00
Dean Herbert	ed81297611	Fix playlist items showing download button briefly during initial local presence checks	2022-09-08 17:10:45 +09:00
Dan Balasescu	b0b4da533a	Expose gameplay adjustments via MultiSpectatorPlayer instead	2022-09-08 16:59:20 +09:00
Dean Herbert	d523a2ac33	Rename default value field and make private	2022-09-08 15:53:08 +09:00
Dean Herbert	9ead5e59d3	Fix incorrectly displaying minimum value in placeholder messaging	2022-09-08 15:51:15 +09:00
Salman Ahmed	50923b6e5b	Move track assignment below	2022-09-08 00:25:55 +03:00
Acid Chicken (硫酸鶏)	267465df18	chore(osu.Game): combine Osu.Colour.{Draw,Text}ForHitResult into OsuColour.ForHitResult	2022-09-07 23:34:46 +09:00
Acid Chicken (硫酸鶏)	b560b6f745	refactor(osu.Game): arrange the code for the timing distribution graph	2022-09-07 23:29:10 +09:00
Dan Balasescu	83c0cb1acc	Fix beatmap set to null after exiting song select	2022-09-07 21:34:29 +09:00
Dan Balasescu	fcea244537	Remove initial selection from OnlinePlaySongSelect ... This stuff never really worked anyway - every case except with an already created multiplayer room was broken anyway.	2022-09-07 21:34:29 +09:00
Dan Balasescu	208bd0f391	Give OnlinePlaySongSelect a reference PlaylistItem	2022-09-07 21:34:29 +09:00
Dean Herbert	6a03b4e0de	Merge branch 'master' into true-gameplay-rate	2022-09-07 20:01:03 +09:00
Dan Balasescu	cb9bae1f5c	Enable NRT	2022-09-07 19:54:55 +09:00
Dean Herbert	e6b449fe0b	Fix case of zero rate calculating a zero true gameplay rate	2022-09-07 19:23:44 +09:00
Dean Herbert	1be3b74ff3	Fix multiplayer spectator not getting gameplay adjustments applied	2022-09-07 19:12:34 +09:00
Dean Herbert	fa15502384	Move full track adjustment flow inside MasterGameplayClockContainer	2022-09-07 19:12:16 +09:00
Dean Herbert	75d0deef72	Apply proposed changes to remove inheritance from MasterGameplayClockContainer	2022-09-07 17:49:05 +09:00
Dean Herbert	99ef0c95fe	Simplify children assignment	2022-09-07 16:51:51 +09:00
Dean Herbert	f3bda4e040	Fix weird edge case of nullability in CarouselRoot ... A bit unfortunately, but it's what we get for having ctor level bindings..	2022-09-07 14:27:25 +09:00
Dean Herbert	e18b524f8e	Fix missing null checks on selectedBeatmap fields in BeatmapCarousel	2022-09-07 14:12:35 +09:00
Dean Herbert	241d33d415	Apply NRT to BeatmapCarousel	2022-09-07 14:07:53 +09:00
Acid Chicken (硫酸鶏)	3003fc1061	refactor(osu.Game): improve code quality	2022-09-07 02:29:15 +09:00
Salman Ahmed	90207b6032	Merge branch 'master' into feature/EditorDeleteDiff	2022-09-06 18:48:06 +03:00
Dean Herbert	66c44f5913	Delegate interface to valid target	2022-09-06 22:26:46 +09:00
Dean Herbert	bc1212f4e6	Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method	2022-09-06 22:26:46 +09:00
Dean Herbert	db15bd56e8	Invalidate working beatmap cache when calling DeleteDifficultyImmediately rather than in editor code	2022-09-06 18:12:47 +09:00
Acid Chicken (硫酸鶏)	b109e5de6c	chore(osu.Game): align height of bars on timing distribution graph to basalHeight first and combine their transitions into each one	2022-09-06 00:04:10 +09:00
Dean Herbert	266eb758aa	Use new flow to calcaulate TrueGameplayRate	2022-09-05 23:37:49 +09:00
Dean Herbert	7084aeee05	Add method flow to reset applied adjustments	2022-09-05 23:22:38 +09:00
Dean Herbert	e33486a766	Implement IAdjustableAudioComponent in MasterGameplayClockContainer	2022-09-05 23:20:02 +09:00
Dan Balasescu	2923c10cd8	Rewrite rooms to store multiple active countdowns ... Update test to the new structure	2022-09-05 19:03:26 +09:00
Dean Herbert	57954bb8f5	Enable nullability on TimelineHitObjectBlueprint	2022-09-05 14:50:43 +09:00
Mk-56spn	aace334fb3	Fix some test issues	2022-09-05 04:49:48 +02:00
Dan Balasescu	07d4a025b0	Merge pull request #20109 from frenzibyte/online-play-room-status-inconsistency ... Fix room status dropdown placement inconsistent between multiplayer and playlists	2022-09-05 11:19:56 +09:00
Exanc	4ea7ca4c07	Slight tweak to the StarsSlider ... - MinimumStarsSlider now shows "0" when at it's minimum - Modified and NoResultsPlaceholder the tooltip to stay consistent with the changes	2022-09-05 00:09:20 +02:00
Acid Chicken (硫酸鶏)	7e77c9e8b4	chore(osu.Game): only the first result should be white at zero position on HitEventTimingDistributionGraph	2022-09-05 04:44:27 +09:00
Acid Chicken (硫酸鶏)	b67fd3d880	chore(osu.Game): split transform duration of bars on HitTimingDistributionGraph	2022-09-05 03:45:51 +09:00
Acid Chicken (硫酸鶏)	0af6b3dc0f	chore(osu.Game): colorize bars by OD on HitEventTimingDistributionGraph	2022-09-05 02:02:38 +09:00
Acid Chicken (硫酸鶏)	5f0832ead7	refactor(osu.Game): separate OsuColour.ForHitResult by usage	2022-09-05 01:58:57 +09:00
Mk-56spn	0c6d8efa28	Large code refactor, Implementation of shapes option drop down	2022-09-04 17:24:12 +02:00
Salman Ahmed	e8fa872f61	Fix room status dropdown position inconsistent on online-play screens	2022-09-03 16:14:21 +03:00
Mk-56spn	51061c3a12	Bug fixing and parameter adjustments	2022-09-03 01:27:22 +02:00
Mk-56spn	534c40e18e	Initial version	2022-09-02 23:07:30 +02:00
Dean Herbert	bc5340e33a	Merge branch 'master' into fix_progress_bar_info	2022-09-02 18:00:35 +09:00
Dean Herbert	4f18105e9d	Ensure next beatmap selected matches the menu ordering	2022-09-02 17:57:00 +09:00
Dean Herbert	840d1c4cd5	Disable delete difficulty menu item when only one difficulty is present	2022-09-02 17:14:48 +09:00
Dean Herbert	9fd8067e11	Tidy up dialog and deletion flow	2022-09-02 17:07:09 +09:00
Dean Herbert	605108c938	Refactor/rename deletion method to read better	2022-09-02 16:59:01 +09:00
Dean Herbert	b388428e1c	Merge branch 'master' into feature/EditorDeleteDiff	2022-09-02 16:48:38 +09:00
Dean Herbert	6a35b233e5	Merge branch 'master' into remove-dispose-updates	2022-09-01 23:03:19 +09:00
Dean Herbert	1524623624	Fix back-to-front filter logic ... Was copied across from a place which was checking for `match` and applied verbatim to a place that was `filter`. Which are polar opposites.	2022-09-01 19:59:27 +09:00
HiddenNode	4a630b5384	Implemented SizePreservingSpriteText	2022-08-31 22:05:06 +01:00
Dan Balasescu	c852c54055	Consume auto skip setting during play	2022-08-31 20:24:15 +09:00
Dan Balasescu	b5ec7d06dd	Add auto-skip setting ... Default to auto skip	2022-08-31 20:24:06 +09:00
Dan Balasescu	000412c50f	Merge pull request #20014 from peppy/fix-resume-skip-forward ... Fix gameplay skipping forward during resume operation	2022-08-31 16:30:37 +09:00
Dan Balasescu	ccc08b816c	Merge pull request #20030 from peppy/notification-design-update ... Update notification overlay design	2022-08-31 16:06:59 +09:00
Dean Herbert	7337d4c1aa	Merge branch 'master' into kps	2022-08-31 15:41:42 +09:00
Dan Balasescu	2bf74d2b38	Merge pull request #20039 from peppy/fix-skip-button-permanent-display ... Fix skip button getting stuck on screen for certain beatmaps	2022-08-31 14:17:39 +09:00
Dean Herbert	cfc7c32aff	Merge pull request #20009 from frenzibyte/fix-back-to-front-comparison ... Adjust weirdly back-to-front fallback comparison in `HitObjectOrderedSelectionContainer`	2022-08-31 14:14:10 +09:00
Dean Herbert	51346e0154	Fix skip button getting stuck on screen for certain beatmaps ... Closes #20034.	2022-08-31 13:22:51 +09:00
Dean Herbert	3d93e0ded1	Merge branch 'master' into fix-resume-skip-forward	2022-08-31 12:16:15 +09:00
Dean Herbert	09aa3e065d	Move colouring to full icon content rather than background	2022-08-30 18:06:48 +09:00
Dean Herbert	5d41fdfc89	Remove unnecessary usage of DrawableAudioMixer in ScorePanel	2022-08-30 15:05:21 +09:00
Dean Herbert	27ad224f13	Remove probably unnecessary Seek on start	2022-08-30 01:21:44 +09:00
Dean Herbert	1bff540381	Remove debug changes	2022-08-29 22:14:07 +09:00
Dan Balasescu	0491addbbd	Merge pull request #19974 from peppy/no-gameplay-clock-editor-offset ... Fix editor not applying offsets	2022-08-29 21:10:29 +09:00
Dean Herbert	82b9e1f0eb	Merge pull request #20011 from smoogipoo/scoring-refactor ... Refactor scoring to remove async methods / simplify	2022-08-29 19:55:27 +09:00
Dean Herbert	75531d2d62	Fix gameplay skipping forward during resume operation	2022-08-29 19:51:16 +09:00
Salman Ahmed	f2378d3fde	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-29 11:23:22 +03:00
Dean Herbert	2dafa041a7	Account for offset being applied to editor clock time in TestSceneEditorClock	2022-08-29 16:42:50 +09:00
Dean Herbert	105aa01e7d	Update usages of RemoveInternal	2022-08-29 15:57:40 +09:00
Dean Herbert	a215d009fe	Update Remove/RemoveRange/RemoveAll calls in line with framework changes	2022-08-29 15:57:40 +09:00
Dan Balasescu	423f6f90f2	Remove async calls from ScoreManager	2022-08-29 15:34:08 +09:00
Salman Ahmed	3ff2058975	Fix back-to-front fallback comparison in HitObjectOrderedSelectionContainer	2022-08-29 09:23:53 +03:00
Dan Balasescu	c0b13c7e1f	Refactor ScoreProcessor ComputeScore() methods	2022-08-29 13:51:10 +09:00
Dan Balasescu	cf6bb3b030	Merge pull request #19958 from peppy/fix-fail-freq-stuck ... Ensure fail animation sequence isn't run after the player exit sequence has started	2022-08-27 00:58:41 +09:00
Dean Herbert	b9d9bf3004	Merge pull request #19938 from frenzibyte/fix-multi-spectator-results-screen ... Fix multi-spectator potentially getting stuck for passed players	2022-08-26 21:53:17 +09:00
Salman Ahmed	a3e595a9aa	Update comment to include inserted indices	2022-08-26 14:51:19 +03:00
Salman Ahmed	81c0a641b4	Fix selection fallback path not updated to check inserted indices	2022-08-26 14:51:08 +03:00
Salman Ahmed	f38194fb40	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-26 14:35:19 +03:00
Dean Herbert	217fa00a72	Bring logic up-to-date	2022-08-26 19:32:49 +09:00
Dean Herbert	a146db0e35	Merge branch 'master' into carousel-perform-selection	2022-08-26 19:29:00 +09:00
Dean Herbert	cd90536e4b	Remove Track access in Timeline	2022-08-26 18:25:48 +09:00
Dean Herbert	12d6d6793c	Move EditorClock processing to Update and always decouple	2022-08-26 18:08:43 +09:00
Dean Herbert	31e459364b	Use FramedBeatmapClock in EditorClock	2022-08-26 17:28:58 +09:00
Dean Herbert	ed0843aa84	Reword xmldoc regarding final clock source to read better	2022-08-26 16:46:22 +09:00
Dean Herbert	2c780eab5f	Merge branch 'master' into fix_progress_bar_info	2022-08-26 16:14:21 +09:00
Dean Herbert	23efec6505	Fix naming and comment typos	2022-08-26 15:57:36 +09:00
Dean Herbert	9862b79b47	Fix typo in long comment	2022-08-26 15:20:09 +09:00
HiddenNode	d98357aa57	Made text inside SongProgressInfo scale.	2022-08-26 01:30:44 +01:00
Dean Herbert	a546aa2673	Clamp SpectatorPlayerClock's elapsed calculation to avoid player clocks getting too far ahead	2022-08-25 21:33:33 +09:00
Dean Herbert	3a17c6df08	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-25 16:24:55 +09:00
Dean Herbert	a6ed589db4	Remove guard against RemoveFilters running more than once ... It turns out this is required to remove some filters immediate, and some later. Weird.	2022-08-25 14:47:33 +09:00
Dean Herbert	ad3dd1c700	Fix a couple of oversights regarding track nullability	2022-08-25 14:45:00 +09:00
Dean Herbert	ec60e16439	Apply NRT to FailAnimation	2022-08-25 14:35:42 +09:00
Dean Herbert	8f4a953d11	Ensure fail animation sequence isn't run after the player exit sequence has started	2022-08-25 14:26:42 +09:00
Dean Herbert	4c45f7d938	Ensure FailAnimation can't be Started after filters are already removed	2022-08-25 14:26:20 +09:00
Ryuki	5cddc7ed1f	Code cleanup (CPS)	2022-08-24 17:13:23 +02:00
Dean Herbert	f3847b90fd	Tidy up attach logic	2022-08-24 19:36:01 +09:00
Dean Herbert	5129716612	Merge branch 'master' into kps	2022-08-24 18:18:45 +09:00
Dean Herbert	2af8c4a2ea	Merge pull request #19904 from novialriptide/add-date-created-sort ... Add date submitted sorting	2022-08-24 17:43:28 +09:00
Dean Herbert	27b57947e4	Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity	2022-08-24 17:13:14 +09:00
Dean Herbert	5f01f461b3	Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock	2022-08-24 17:13:14 +09:00
Dean Herbert	af56cd0126	Fix merge breakage	2022-08-24 16:52:36 +09:00
Dean Herbert	5079e0d83d	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-24 16:52:10 +09:00
Salman Ahmed	e378c5b866	Remove no longer necessary switch case	2022-08-24 10:50:40 +03:00
Salman Ahmed	8f4a2b4936	Separate passed/failed states from calling EndGameplay	2022-08-24 10:36:13 +03:00
Andrew Hong	a8867d4245	Merge branch 'master' into add-date-created-sort	2022-08-24 03:23:27 -04:00
Dean Herbert	7f9246637a	Simplify MultiSpectatorScreen hierarchy construction	2022-08-24 16:08:48 +09:00
Dean Herbert	7c1fc4814e	Remove unused CreateMasterGameplayClockContainer method	2022-08-24 16:03:38 +09:00
Dean Herbert	871365bbb0	Inline ReadyToStart action binding for added safety	2022-08-24 16:03:38 +09:00
Dean Herbert	6c50f618a3	Don't use bindable flow for masterState	2022-08-24 16:03:38 +09:00
Dean Herbert	683d49c608	Move MasterClockState handling in to SpectatorSyncManager	2022-08-24 16:03:38 +09:00
Dean Herbert	d33d705684	Make WaitingOnFrames non-bindable	2022-08-24 16:03:38 +09:00
Dean Herbert	d05d8aeb22	Simplify interface implementations	2022-08-24 16:03:38 +09:00
Dean Herbert	2f5be6efca	Tidy up ProcessFrame and privatise const	2022-08-24 16:03:38 +09:00
Dean Herbert	b564c34dbc	Don't process master clock (is a noop)	2022-08-24 16:03:38 +09:00
Salman Ahmed	2fa8b61f3c	Handle completion user state updates during spectating	2022-08-24 10:02:21 +03:00
Dean Herbert	b4eede61fb	Use readonly instead of get-only	2022-08-24 15:28:18 +09:00
Dean Herbert	0b271fe4b3	Fix incorrect IsRunning value	2022-08-24 15:27:31 +09:00
Dean Herbert	b6254a1f25	Remove unnecessary casting	2022-08-24 15:23:31 +09:00
Dean Herbert	a86fc6f248	Change running state of SpectatorPlayerClock using IsRunning	2022-08-24 15:17:56 +09:00
Dean Herbert	0c9a4ec13c	Don't expose MasterClock in SpectatorClockSyncManager	2022-08-24 15:13:08 +09:00
Dean Herbert	995e6664b6	Rename spectator clock sync classes	2022-08-24 15:13:08 +09:00
Dean Herbert	31f657fe01	Remove ISpectatorPlayerClock interface ... Too many levels of redirection. One interface with one implementation is not useful, IMO.	2022-08-24 15:12:57 +09:00
Dean Herbert	882dd93942	Remove ISyncManager interface ... Too many levels of redirection. One interface with one implementation is not useful, IMO.	2022-08-24 15:12:57 +09:00
Dean Herbert	22963ab951	Fix multiplayer spectator getting stuck	2022-08-24 15:12:57 +09:00
Dean Herbert	ec31f37ff7	Accept MasterGameplayClockContainer rather than generic clock	2022-08-24 14:51:14 +09:00
Dean Herbert	85fbe7abca	Fix multiplayer spectator getting stuck	2022-08-24 13:11:53 +09:00
Andrew Hong	3cedd1cd1c	Merge branch 'master' into add-date-created-sort	2022-08-23 12:00:30 -04:00
Dean Herbert	29fed0c4a3	Avoid setting the source clock until gameplay is ready to start ... Without this change, the audio track may audibly seek during load proceedings.	2022-08-23 18:34:17 +09:00
Dean Herbert	ec61a94dc9	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-23 17:36:06 +09:00
Dean Herbert	553897f2f0	Remove AddClock method to CreateManagedClock	2022-08-23 13:52:43 +09:00
Dean Herbert	1191b6c080	Remove unused Source_Set implementation on ISpectatorPlayerClock	2022-08-23 13:44:41 +09:00
Andrew Hong	55f1b43329	Removed check	2022-08-22 13:41:36 -04:00
HiddenNode	1098e24c40	Improved UprightUnscaledContainer	2022-08-22 14:24:52 +01:00
Dan Balasescu	c59298f0ce	Enable NRT	2022-08-22 21:55:04 +09:00
Dean Herbert	489e172a76	Simplify track start/stop/paused tracking	2022-08-22 19:43:18 +09:00
Dan Balasescu	5d3d8681d4	Invert creation of clocks in multi spectator	2022-08-22 19:14:06 +09:00
Andrew Hong	bcab7aea26	Merge branch 'master' into add-date-created-sort	2022-08-22 04:02:46 -04:00
Andrew Hong	c2036d3893	Moved filter exclusion	2022-08-22 03:39:46 -04:00
Andrew Hong	09ef13908c	Adjust to reviews	2022-08-22 03:20:27 -04:00
Dean Herbert	058d67f8e8	Merge pull request #19695 from naoei/ruleset-localization ... Change most ruleset-accessible string types to Localisable strings	2022-08-22 16:13:23 +09:00
Dan Balasescu	0815b01b75	Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation ... Fix selecting preset containing Difficulty Adjust automatically opening customisation panel	2022-08-22 15:44:00 +09:00
Dean Herbert	e6b669db8e	Elaborate with example of GameplayClockContainer managing its own Stop state	2022-08-22 14:14:44 +09:00
Dean Herbert	af2e82d7d5	Move operation of setting GameplayClockContainer.StartTime to Reset call	2022-08-22 14:11:06 +09:00
Andrew Hong	c6a739f5a8	Add date submitted sorting	2022-08-21 23:09:33 -04:00
Ryuki	5cf54a788a	Code cleanup for CPS counter	2022-08-21 16:00:58 +02:00
naoei	29ef1c8db8	Check if StatisticItem.Name is null or empty	2022-08-20 21:48:53 -04:00
naoei	9386d352b8	Make StatisticItem.Name not nullable	2022-08-20 21:48:35 -04:00
Nao	189a407cb1	Merge branch 'master' into ruleset-localization	2022-08-20 21:39:10 -04:00
Dean Herbert	8566e93c72	Guard against SubmittingPlayer potentially getting stuck waiting on request forever	2022-08-20 17:19:17 +09:00
Dean Herbert	da407aa827	Merge branch 'master' into kps	2022-08-20 15:24:58 +09:00
Dean Herbert	cbdd870ecf	Merge pull request #19693 from its5Q/editor-localisation ... Add localisation support for beatmap editor setup	2022-08-20 11:51:57 +09:00
Dean Herbert	7bf318541c	Reword comment to hopefully read better	2022-08-19 20:57:55 +09:00
Dean Herbert	3f0da14065	Delay start operation by one frame to allow children to see initial start time	2022-08-19 17:39:51 +09:00
its5Q	4c24d8ed58	Improve string consistency	2022-08-19 03:17:05 +10:00
Dean Herbert	3eb1cda6aa	Reorganise call order of Start / Reset to make more sense	2022-08-19 01:46:36 +09:00
Ryuki	3de35a1518	Update calculator and tests to match changes on clocks	2022-08-18 18:40:02 +02:00
Dean Herbert	1d774f3f12	Remove redundant ProcessFrame calls ... Of note, I'm not sure whether the `IsPaused` check was meaningful, but it's not reimplemented in the new `FramedBeatmapClock`.	2022-08-19 01:39:02 +09:00
Dean Herbert	7bc96431a7	Remove unnecessary virtual spec from GameplayClockContainer.Seek	2022-08-19 01:39:01 +09:00
Dean Herbert	0e228791c0	Remove unnecessary Reset call in MultiSpectatorScreen	2022-08-19 01:39:01 +09:00
Dean Herbert	43879633db	Ensure setting a StartTime on a GameplayClockContainer always resets to the new time	2022-08-18 18:54:10 +09:00
Dean Herbert	343efa1d11	Split OffsetCorrectionClock out of MasterGameplayClockContainer	2022-08-18 18:54:10 +09:00
Dean Herbert	2c6fd1ec6e	Fix `GameplayClockContainer potentially resetting external seeks	2022-08-18 18:54:10 +09:00
Dean Herbert	6003afafc7	Use FramedBeatmapClock in GameplayClockContainer	2022-08-18 18:54:10 +09:00
Dean Herbert	9735728cf6	Reverse conditionals to better define intent in addSourceClockAdjustments	2022-08-18 15:08:09 +09:00
Bartłomiej Dach	d06959e1dd	Update incorrect xmldoc	2022-08-17 22:03:35 +02:00
Dean Herbert	e7ddbc41c8	Merge branch 'master' into no-gameplay-clock	2022-08-17 22:21:10 +09:00
Dan Balasescu	0cf3c5570a	Merge pull request #19800 from peppy/fix-editor-ear-rape ... Fix slider ticks playing back at infinite rate while making changes to a slider in the editor	2022-08-17 15:50:58 +09:00
Dean Herbert	20256aad11	Merge branch 'master' into no-gameplay-clock	2022-08-17 15:21:20 +09:00
Dean Herbert	21b364cd77	Fix nullref in tests as initialBeatmap may be null	2022-08-17 14:48:00 +09:00
Dean Herbert	6b9dec5996	Restore original event flow to allow for OnSuspend case to work correctly	2022-08-17 14:32:21 +09:00
Dean Herbert	8ce50e98a6	Move delegate debounce logic to Editor itself	2022-08-17 14:04:57 +09:00
Dan Balasescu	8b5ac55fca	Remove newline	2022-08-17 13:48:06 +09:00
Dean Herbert	d9346abb9c	Tweak intro timings more and ensure non-theme tracks play from preview point	2022-08-17 13:20:40 +09:00
Dean Herbert	37799e3b31	Allow preparing preview point without looping	2022-08-17 13:20:24 +09:00
Bartłomiej Dach	1861f34427	Merge branch 'master' into editor-setup-no-state-change	2022-08-16 21:46:43 +02:00
Dan Balasescu	24fd411720	Merge pull request #19594 from BlauFx/improve_retry_behaviour ... Skip song intro on quick restart	2022-08-16 20:18:12 +09:00
Dean Herbert	5ac314077a	Improve intro timings when not using osu! theme ... Roughly as proposed in https://github.com/ppy/osu/discussions/19687.	2022-08-16 18:19:30 +09:00
Dean Herbert	ee153a345c	Add a few more overlooked beatmap save states on setup screen modifications	2022-08-16 16:31:56 +09:00
Dean Herbert	5238a5c115	Merge branch 'master' into editor-setup-no-state-change	2022-08-16 16:28:29 +09:00
Dean Herbert	9d2c2b71cf	Change conditional to check for insertions in addition to modifications ... It is possible that the import process itself marks the previous beatmaps as deleted due to an overlap in metadata or otherwise.	2022-08-16 16:21:36 +09:00
Dean Herbert	c8fdfd298c	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-16 16:04:32 +09:00
Dean Herbert	ea50936d71	Fix slider ticks playing back at infinite rate while making changes to a slider in the editor	2022-08-16 15:27:58 +09:00
its5Q	e870ac6456	Fix code quality for CI	2022-08-16 15:51:54 +10:00
Dean Herbert	63819648df	Fix up flow of actual skip operation	2022-08-16 14:40:02 +09:00
Dean Herbert	9a1a7bae89	Make test actually test things	2022-08-16 14:40:02 +09:00
Dean Herbert	6761f869f9	Modify flow to avoid weird bindable and value resetting	2022-08-16 14:17:35 +09:00
Dean Herbert	c9baadcf88	Merge branch 'master' into improve_retry_behaviour	2022-08-16 13:06:04 +09:00
Bartłomiej Dach	5ff2e41a55	Add preset column to mod select test scene	2022-08-15 18:38:37 +02:00
its5Q	797a8da996	Replace osu-web strings with new strings and merge to single file	2022-08-16 01:14:16 +10:00
Dean Herbert	61a8873266	Ensure GameplayClockContainer's FramedClock is always non-null	2022-08-15 20:22:36 +09:00
Dean Herbert	1696a905ba	Reduce exposed properties in GameplayClockContainer	2022-08-15 20:22:36 +09:00
Dean Herbert	704568ae3b	Remove remaining usage of GameplayClock	2022-08-15 20:22:36 +09:00
Dean Herbert	27569e2ed5	Remove FrameStableClock (and redirect usages to FrameStabilityContainer)	2022-08-15 19:19:19 +09:00
Dean Herbert	cc982d374c	Cache self rather than GameplayClock	2022-08-15 18:30:53 +09:00
Dean Herbert	c5f8529d20	Mark unused methods as NotImplemented for safety	2022-08-15 18:30:53 +09:00
Dean Herbert	f81c7644b4	Make GameplayClockContainer also an IGameplayClock and expose to remaining tests	2022-08-15 18:30:53 +09:00
Dean Herbert	c8764cb333	Move all usage of GameplayClock to IGameplayClock	2022-08-15 18:30:53 +09:00
Dean Herbert	6d78218142	Update usages of GameplayClockContainer.GameplayClock to access properties directly	2022-08-15 18:08:49 +09:00
Dean Herbert	224f3eaa84	Make GameplayClockContainer non-abstract and use in MultiSpectatorPlayer	2022-08-15 18:08:49 +09:00
Dean Herbert	623e90a7b2	Fix div-by-zero in SongProgress when no object duration could be calculated	2022-08-15 15:05:35 +09:00
naoei	18ce784ae0	Allow StatisticItem's name param to be nullable	2022-08-14 14:51:35 -04:00
Ryuki	2aa3a1b50d	Rename all "KeysPerSecond" usages to "ClicksPerSecond"	2022-08-14 20:12:11 +02:00
Ryuki	9dc806506e	Make ActionListener and KeysPerSecondCalculator not rely on events to add timestamps	2022-08-14 19:31:14 +02:00
Ryuki	d5f10cbb9d	Revert 787dee24 and initialize calculator in HUDOverlay	2022-08-14 18:53:00 +02:00
Bartłomiej Dach	05ddfe7522	Merge branch 'master' into editor-setup-no-state-change	2022-08-14 18:21:31 +02:00
Ryuki	e08f71797e	Change displayed metric from "KPS" to "clicks/s"	2022-08-13 04:27:26 +02:00
Ryuki	9b252b1d81	Make KeysPerSecondCalculator dependency in HUDOverlay nullable	2022-08-11 11:58:30 +02:00
Ryuki	d29cba80e9	Remove useless comment in KeysPerSecondCounter	2022-08-11 11:01:16 +02:00
Ryuki	787dee249d	Move KeysPerSecondCalculator instantiation from HUDOverlay to Player ... This prevents messing with *future* Skin (de)serialization	2022-08-11 10:37:16 +02:00
Ryuki	3c6461b9e4	Remove KPS acronym usage	2022-08-11 10:01:39 +02:00
Ryuki	0a94fb4039	Make KPS counter strictly depending only on KPS calculator ... `KeysPerSecondCounter` now depends on `KeysPerSecondCalculator` via the `BackgroundDependencyLoaderAttribute` method, making it appear only in a gameplay context without requiring `GameplayClock` without using it.	2022-08-11 00:46:39 +02:00
Ryuki	46e372cb99	Add more readiness checks in KeysPerSecondCalculator	2022-08-11 00:43:15 +02:00
Ryuki	9e80d3f71c	Re-adjust timespan conditions in KeysPerSecondCalculator	2022-08-11 00:42:22 +02:00
naoei	6e13cf82e8	Don't render statistic header if display string is null	2022-08-10 16:05:34 -04:00
naoei	8cb2e11766	Change most ruleset-accessible string types to Localisable strings	2022-08-10 15:51:11 -04:00
its5Q	2499b7f0cd	Add localisation support for beatmap editor setup	2022-08-11 03:53:20 +10:00
Dean Herbert	ac99c1ad69	Migrate the majority of existing file lookups to use new extension methods	2022-08-10 16:01:16 +09:00
Dean Herbert	a5081826b7	Handle cancellation at more points during Player initialisation ... As discussed in discord, this will help avoid null references during cancellation which can otherwise be quite confusing to debug.	2022-08-09 23:25:19 +09:00
Dan Balasescu	41af03dec5	Merge pull request #19597 from frenzibyte/hotfix-multi-spectator-results-screen ... Fix multi-spectator potentially getting stuck for passed players (hotfix)	2022-08-09 21:11:10 +09:00
Ryuki	b52a07c16a	Use DI to provide dependencies for KPS Calculator and improve input ... gathering KPS Calculator now uses DI to retrieve the clocks. Using `HUDOverlay` it is now cached for `KeysPerSecondCounter`s to resolve it. This also allows to make an "Attach" flow like `KeyCounter`.	2022-08-08 21:54:06 +02:00
BlauFx	0afa3a5ec8	Fix xml doc	2022-08-08 21:20:09 +02:00
BlauFx	f6e65cf1af	Improve implementation	2022-08-08 20:53:05 +02:00
BlauFx	fac2596eee	Change type from BindableBool to IBindable<bool>	2022-08-08 13:38:52 +02:00
BlauFx	cd68134565	Call skip method directly	2022-08-08 13:10:28 +02:00
Dean Herbert	cbe5cb5d03	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-08 18:01:26 +09:00
Dean Herbert	f1691882e2	Fix incorrect argument passing to ToMod	2022-08-08 12:56:18 +09:00
Dean Herbert	e1189da824	Merge branch 'master' into irenderer-glwrapper	2022-08-08 12:31:53 +09:00
Bartłomiej Dach	839409d7ac	Add preset column to solo mod select overlay	2022-08-07 16:20:31 +02:00
HiddenNode	ed86255e2b	Use UprightUnscaledContainer instead of KeepUprightAndUnscaled	2022-08-07 13:20:22 +01:00
BlauFx	bb344e064f	Add xml docs	2022-08-07 13:31:26 +02:00
BlauFx	09230304a4	Improve implementation	2022-08-07 13:20:29 +02:00
Ryuki	b2557a8d2d	Refactor KPS ... - Remove '#nullable disable' in KeysPerSecondCalculator and KeysPerSecondCounter - Remove KeysPerSecondCalculator IDisposable implementation - Make KeysPerSecondCalculator static instance initialized once by KeysPerSecondCounters - Auto transfer dependencies from KeysPerSecondCounter to KeysPerSecondCalculator using Resolved properties - Add internal reset logic to KeysPerSecondCalculator and make it independent from Player - Use GameplayClock.TrueGameplayRate to get real-time rate. If 0 then it defaults to the last non 0 rate if no such mod is enabled	2022-08-07 00:53:00 +02:00
Bartłomiej Dach	a0d093be5c	Extract common implementation of delete dialog	2022-08-06 21:04:12 +02:00
BlauFx	bd43a9e96e	Add missing type specification	2022-08-06 18:49:07 +02:00
BlauFx	fa6d55b5b5	Remove redundant lambda signature parentheses	2022-08-06 18:47:11 +02:00
BlauFx	0d418559bc	Skip song intro only in case of a quick restart	2022-08-06 17:02:45 +02:00
BlauFx	e411a2d187	Revert reduced wait time commit	2022-08-06 15:12:36 +02:00
Salman Ahmed	84ef24c341	Fix multi-spectator potentially getting stuck for passed players	2022-08-06 05:41:26 +03:00
BlauFx	445f921756	Move IsSkippable event into load method	2022-08-05 23:21:03 +02:00
BlauFx	d8d7423698	Reduce "wait time" in case restarting the map	2022-08-05 23:04:43 +02:00
BlauFx	99e07aa09a	Skip intro if the map gets restarted	2022-08-05 23:01:52 +02:00
BlauFx	6717f0606c	Add property to SkipOverlay	2022-08-05 23:00:37 +02:00
Ryuki	0886137e39	Prevent KeysPerSecondCounter from NRE when no instance is initialized	2022-08-05 21:03:00 +02:00
HiddenNode	b46bc5d65b	Remove empty line	2022-08-05 14:57:33 +01:00
Ryuki	24c29b7e2f	Do not add KPS calculation when gameplay rate is 0	2022-08-05 15:51:07 +02:00
HiddenNode	0243f8d6ac	Clean up	2022-08-05 14:28:15 +01:00
HiddenNode	12ef99a1a1	Fix text position	2022-08-05 12:56:08 +01:00
Dan Balasescu	802dc90cb1	Adjust using directives for vertices	2022-08-05 20:37:33 +09:00
Dan Balasescu	c4b9b2a14b	Merge branch 'master' into irenderer-glwrapper	2022-08-05 20:35:06 +09:00
Ryuki	42d1bdfc95	Move KPS calculation to a standalone class	2022-08-05 04:17:01 +02:00
Salman Ahmed	7c45c571a0	Merge branch 'master' into more-beat-sync-dependence	2022-08-03 20:22:42 +03:00
Dean Herbert	a32149fda1	Convert interface methods to extension methods	2022-08-03 20:07:55 +09:00
Dean Herbert	6ad6561e1c	Fix LegacySongProgress incorrectly blocking mouse input from gameplay ... Closes #19555.	2022-08-03 17:42:29 +09:00
HiddenNode	dbb77705da	Merge branch 'fix_text_orientation' into fix_progress_bar_info	2022-08-02 19:00:43 +01:00
HiddenNode	bc21a2ed56	Remove unnecessary using directive	2022-08-02 17:41:17 +01:00
HiddenNode	78a98cdb9c	Prevent TextSprites inside SongProgressInfo from being stretched or flipped	2022-08-02 17:37:31 +01:00
Dean Herbert	de186f67e0	Limit metadata updates to once per frame	2022-08-02 22:02:30 +09:00
Dan Balasescu	b4e55f7309	Apply IRenderer changes	2022-08-02 19:50:57 +09:00
Dan Balasescu	a2a913ab52	Merge branch 'irenderer-batches' into irenderer-textures	2022-08-02 19:25:08 +09:00
Dean Herbert	258ad7c6b9	Tidy up kiai time access	2022-08-02 18:18:40 +09:00
Dean Herbert	cc4cde2c79	Improve IBeatSyncProvider interface and reduce beatmap track dependence	2022-08-02 17:59:18 +09:00
Dean Herbert	efa3c3b757	Fix multiple cases of mutations at editor setup screen not triggering a state save	2022-08-02 16:47:37 +09:00
Dan Balasescu	fc0914bf77	Merge pull request #19536 from frenzibyte/playlists-settings-leak ... Fix playlist settings reference leak due to unsafe binding	2022-08-02 13:30:55 +09:00
HiddenNode	df85bd74d7	Keep TextSprites in SongProgressInfo upright	2022-08-01 21:46:37 +01:00
Dean Herbert	c0e5f11c90	Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability ... Fix newly imported beatmaps not using correct comparer for sorting	2022-08-02 02:20:51 +09:00
Salman Ahmed	7e9d11ee24	Enable NRT on playlists settings overlay	2022-08-01 20:15:08 +03:00
Salman Ahmed	c851e3d8f3	Fix playlist settings reference leak due to unsafe callback binding	2022-08-01 20:08:18 +03:00
Salman Ahmed	fc7fc3d673	Fix newly imported beatmaps not using correct comparer for sorting	2022-08-01 19:13:57 +03:00
Dean Herbert	01cc9bd7ef	Merge pull request #19479 from frenzibyte/carousel-update-on-resume ... Fix song select not updating selected beatmap card on editor resume	2022-08-02 00:48:18 +09:00
Joseph Madamba	1dbb2a4d37	Fix online play screen only accounting for current sub screen onexiting blocks	2022-08-01 07:57:30 -07:00
Dan Balasescu	d4eec9122f	Merge pull request #19516 from peppy/fix-editor-track-disposal-crash ... Fix editor potentially playing a track post-disposal	2022-08-01 18:12:21 +09:00
Dan Balasescu	1d27c4f020	Merge pull request #19504 from peppy/skin-serialisation-test-coverfage ... Add test coverage of deserialisation of skin layouts	2022-08-01 17:17:16 +09:00
Dean Herbert	6e7c298aaf	Fix changes to audio / background not triggering an editor state change	2022-08-01 16:53:49 +09:00
Dean Herbert	2f60f91a0e	Fix editor potentially using a track post-disposal ... This changes the editor to track the current track as it is *loaded* by `MusicController`, rather than haphazardly following the current global `WorkingBeatmap` (with a potentially unloaded track) or relying on local immediate-load behaviour (as implemented in `ResourcesSection`).	2022-08-01 16:53:49 +09:00
Dean Herbert	5b98a73edc	Apply nullability to SkinComponentToolbox and split out reflection method to get all skinnable components	2022-08-01 14:04:08 +09:00
notmyname	fa3b9ee32f	remove unneded guard	2022-07-31 23:42:20 +02:00
notmyname	57b43e0065	Stop capturing arrow keys on Playlist	2022-07-31 19:12:29 +02:00
Ryuki	89855cc1d6	Change KPS Counter implementation base and add better replay integration ... The counter implementaiton is now list based, and will not invalidate previous hits by removing them but by testing if they are within the 1 second span, allowing better integration with replays and spectators.	2022-07-31 01:29:57 +02:00
Salman Ahmed	faefda9143	Fix song select not updating selected beatmap card on editor resume	2022-07-30 19:47:42 +03:00
Susko3	38a8b9cf0a	Add battery info for desktop platforms	2022-07-30 14:26:19 +02:00
Dean Herbert	43e612f6d4	Merge pull request #19455 from peppy/confirm-playlist-discard ... Add confirmation dialog when about to discard a playlist	2022-07-30 19:17:49 +09:00
Salman Ahmed	8ca8484f0e	Fix failing tests	2022-07-30 11:49:33 +03:00
Salman Ahmed	369ab10212	Fix exit confirmation dialog not blocking all exit cases	2022-07-30 11:00:31 +03:00
Salman Ahmed	2500e5c533	Merge branch 'master' into fix-summary-kiai-ranges	2022-07-29 19:38:28 +03:00
Dan Balasescu	09979d44aa	Apply DrawNode batching changes	2022-07-29 23:32:09 +09:00
Dean Herbert	acf9ad1429	Apply nullability to EffectPointVisualisation	2022-07-29 23:26:38 +09:00
Salman Ahmed	3bc1774c87	Merge branch 'master' into pie-chart-progress	2022-07-29 16:54:59 +03:00
Salman Ahmed	905bbdc8ee	Remove caching of GameplayClockContainer in favour of GameplayClock ... Also fixes `SongProgress` being displayed in skin editor on non-gameplay screens, due to `GameplayClock` not marked as a required dependency.	2022-07-29 16:45:29 +03:00
Dan Balasescu	155dac55d0	Apply DrawNode parameter changes	2022-07-29 22:33:34 +09:00
Salman Ahmed	3f72e76348	Expose StartTime from gameplay clock	2022-07-29 16:18:05 +03:00
Dean Herbert	8f1e3b0154	Fix editor summary timeline not responding to kiai changes correctly	2022-07-29 19:31:49 +09:00
Dean Herbert	9d457535c6	Add confirmation dialog when about to discard a playlist ... The confirmation will only show if items have been added to the playlist. Closes https://github.com/ppy/osu/issues/19444.	2022-07-29 17:11:37 +09:00
Dean Herbert	eb92c35335	Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering ... Move spectator begin/end playing to SubmittingPlayer	2022-07-29 16:09:50 +09:00
Ryuki	2df24019fd	Merge branch 'master' into kps	2022-07-28 18:38:09 +02:00
Ryuki	b2e7da5aa0	Add basic Queue based implementation of KPS	2022-07-28 18:37:12 +02:00
Dean Herbert	3005ff1b9f	Merge branch 'master' into pie-chart-progress	2022-07-28 22:19:27 +09:00
Dan Balasescu	11e0022fad	Merge branch 'master' into realm-collections	2022-07-28 21:00:08 +09:00
Dan Balasescu	ce694123eb	Move spectator begin/end playing to SubmittingPlayer	2022-07-28 20:44:04 +09:00
Dean Herbert	86c2b7e449	Apply nullability to DefaultSongProgress and clean up more stuff	2022-07-28 18:37:17 +09:00
Dean Herbert	ea027eda46	Move initial show to base implementation and add transition for legacy version	2022-07-28 18:29:49 +09:00
Dean Herbert	d5e5761892	Fix DefaultSongProgress graph not resetting if time is in intro	2022-07-28 18:25:24 +09:00
Dean Herbert	7108553883	Tidy up various things everywhere	2022-07-28 18:25:14 +09:00
Nitrous	0d36907cad	apply code quality fixes	2022-07-28 15:30:45 +08:00
Nitrous	bca3994d91	set FirstHitTime and LastHitTime once	2022-07-28 15:25:12 +08:00
Nitrous	db62d4be3a	apply suggestions ... - refactor `SongProgress` - make`UpdateProgress` more readable - enable NRT on new classes - refactor `TestSceneSongProgress` to use `GameplayClockContainer`	2022-07-28 15:15:41 +08:00
Dean Herbert	525e4a2019	Fix crash in DrawableRoomPlaylistItem context menu creation due to incorrect enumeration casting	2022-07-28 15:51:18 +09:00
Dean Herbert	ad482b8afc	Tidy up naming of collection dropdowns	2022-07-28 13:57:21 +09:00
Dean Herbert	67c7f324ee	Simplify CollectionFilterDropdown filter flow weirdness	2022-07-28 13:57:21 +09:00
Nitrous	9088caa377	move LegacyComboCounter to osu.Game.Skinning	2022-07-28 08:36:26 +08:00
Nitrous	45c11f2b7b	account for gameplay start time	2022-07-28 08:01:38 +08:00
Micahel Kelly	dd315ff97b	Adds hard-delete for a beatmap diff	2022-07-27 21:21:16 +10:00
Dean Herbert	438067a18b	Convert realm data propagation to more correctly use Live<T> ... wip	2022-07-27 19:35:09 +09:00
Dean Herbert	41393616d8	Replace BeatmapCollection with RealmBeatmapCollection	2022-07-27 19:35:09 +09:00
Dean Herbert	9c543fef48	Remove CollectionManager	2022-07-27 18:45:33 +09:00
Micahel Kelly	3febd6d644	Dialogue touchups	2022-07-27 19:23:55 +10:00
Micahel Kelly	e6fad601cc	Adds delete difficulty option to editor	2022-07-27 19:15:43 +10:00
Nitrous	37e642b0bd	make SongProgress abstract ... - move unrelated logic to `DefaultSongProgress` - make `LegacySongProgress` inherit `SongProgress`	2022-07-27 15:19:21 +08:00
Dean Herbert	e6a3659581	Guard against NewModifiedIndices being empty	2022-07-27 14:23:47 +09:00
Dean Herbert	24d75612e2	Always attempt to follow selection, even if difficulty name / metadata change	2022-07-27 14:18:53 +09:00
Dean Herbert	8105d4854a	Fix beatmap carousel not maintaining selection if currently selected beatmap is updated	2022-07-27 13:33:48 +09:00
Dan Balasescu	bc60552694	Merge pull request #19402 from peppy/debugger-attached-audio-warning-disable ... Don't show audio playback issue notification if debugger is attached	2022-07-26 18:49:33 +09:00
Dan Balasescu	8f7dff5c2c	Merge pull request #19378 from peppy/beatmap-update-test ... Add separate beatmap update flow to handle edge cases better	2022-07-26 18:49:20 +09:00
Dean Herbert	e782590b3c	Don't show audio playback issue notification if debugger is attached ... I've hit this countless times recently when debugging during the startup procedure.	2022-07-26 18:20:46 +09:00
Dean Herbert	6ff44ed2c6	Merge pull request #19399 from frenzibyte/carousel-order-stability ... Maintain sort stability by using carousel item ID as a fallback	2022-07-26 17:33:30 +09:00
Dean Herbert	7f75184a01	Merge branch 'master' into beatmap-update-test	2022-07-26 17:27:36 +09:00
Dan Balasescu	412d42b907	Merge pull request #19393 from peppy/fix-statistics-panel ... Avoid potential realm fetch after disposal in `StatisticsPanel`	2022-07-26 16:32:59 +09:00
Salman Ahmed	a4f6f2b9eb	Make item ID comparer static	2022-07-26 09:55:37 +03:00
Dean Herbert	8370ca9765	Add ImportAsUpdate method to IModelImporter to avoid otehr changes	2022-07-26 15:49:04 +09:00
Salman Ahmed	693ac8750c	Remove remaining uses of "child" terminology in non-drawable components	2022-07-26 09:43:47 +03:00
Salman Ahmed	d7ef4170be	Maintain sort stability by using carousel item ID as fallback	2022-07-26 09:40:41 +03:00
Dean Herbert	4efe09e7c2	Merge pull request #19377 from frenzibyte/fix-timeline-tests ... Fix intermittent timeline zoom test failures	2022-07-26 15:18:35 +09:00
Dean Herbert	99bdf41717	Avoid potential realm fetch after disposal in StatisticsPanel ... As seen at https://github.com/ppy/osu/runs/7513799859?check_suite_focus=true.	2022-07-26 15:12:23 +09:00
Dan Balasescu	1b2158ff04	Remove unused method	2022-07-26 14:15:59 +09:00
Dean Herbert	ef10145d6f	Rename MenuCursorContainer and clean up code	2022-07-26 14:11:52 +09:00
Dean Herbert	b7f6413bce	Fix old version of beatmap potentially not being deleted during update flow ... This can happen if the online IDs are not present in the `.osu` files. Previously this was only working due to the early logic in the import process (that relies on matching all online IDs perfectly).	2022-07-25 19:51:19 +09:00
Salman Ahmed	48bcf57066	Mark SetupZoom and parameterless ZoomableScrollContainer ctor as protected	2022-07-25 12:07:50 +03:00
Salman Ahmed	07c6b44864	Fix Timeline attempting to setup zoom with unloaded track	2022-07-25 12:07:50 +03:00
Salman Ahmed	123930306b	Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load	2022-07-25 12:07:50 +03:00
Salman Ahmed	fa9daa6899	Fix TestSceneReplayRecorder not using score provided by gameplay state	2022-07-25 05:21:27 +03:00
solstice23	aaad2e474c	Refactor the multiple regex checks in criteria parsing	2022-07-23 21:43:27 +08:00
solstice23	63210d5662	Merge branch 'master' into search-filter	2022-07-23 18:13:53 +08:00
solstice23	3f2c341369	Simplify length parsing	2022-07-23 18:13:19 +08:00
Salman Ahmed	3aecd288e2	Enable NRT on TopLocalRank	2022-07-23 09:27:03 +03:00
Salman Ahmed	1d0306810a	Fix TopLocalRank not handling legacy scores properly	2022-07-23 09:24:38 +03:00
Salman Ahmed	727fe76b60	Fix TopLocalRank hacking around presence to hide on null rank ... Fixed this here because that blocks `Schedule` from running, and I don't want to add another override to the `IsPresent` flag.	2022-07-23 09:22:22 +03:00
Dean Herbert	db632c0d6e	Inline rolling duration	2022-07-23 02:38:00 +09:00
Dean Herbert	475679ca66	Fix DI failure	2022-07-23 02:27:47 +09:00
Dean Herbert	bb46ba66e0	Simplify TotalScoreCounter tick playback logic	2022-07-23 02:27:17 +09:00
Dean Herbert	9f045209b9	Simplify score panel balance adjustment	2022-07-23 02:09:08 +09:00
Jamie Taylor	62d4d4b055	Add dynamic panning fun to score panel sfx	2022-07-22 21:03:47 +09:00
Jamie Taylor	89da21b6de	Add total score counter sfx	2022-07-22 21:03:47 +09:00
Jamie Taylor	6ce8e74e6b	Add panel appearance sounds	2022-07-22 21:03:46 +09:00
Dean Herbert	63fe4f265f	Merge pull request #19263 from frenzibyte/fix-failed-score-statistics ... Populate failed scores with "miss" results for all remaining hitobjects	2022-07-22 20:16:16 +09:00
Dean Herbert	bfafb4480e	Merge pull request #19296 from smoogipoo/fix-timeline-focus-point ... Fix timeline zoom focus point when using zoom buttons	2022-07-22 17:43:36 +09:00
Dan Balasescu	1d69090301	Merge pull request #19295 from frenzibyte/filter-control-available-area ... Fix sorting mode not filling up to usable area in filter control	2022-07-22 17:20:40 +09:00
Dan Balasescu	e1df50c8ff	Fix timeline zoom focus point when using buttons	2022-07-22 17:03:05 +09:00
Dean Herbert	72916d708c	Merge pull request #19294 from peppy/fix-timeline-feedback-loop ... Fix timeline `alt`+`scroll` zoom not correctly zooming to current mouse position	2022-07-22 16:05:38 +09:00
Dean Herbert	1774a96455	Merge pull request #19278 from Cwazywierdo/timeline-relative-zoom ... Make editor timeline zoom relative to song length	2022-07-22 15:37:47 +09:00
Dean Herbert	6eb42d08ce	Fix timeline zoom receiving feedback from bindable changes ... This causes the focal point zooming to not work (as the focal point is lost). There's no need to handle ongoing changes to `BeatmapInfo.TimelineZoom` because it is not a property which is changed at runtime.	2022-07-22 15:25:57 +09:00
solstice23	7c222505e9	Simplify length parsing	2022-07-22 14:24:17 +08:00
Salman Ahmed	3b913bb9ad	Fix sorting mode not filling up to usable area in filter control	2022-07-22 09:15:48 +03:00
Dean Herbert	4cec9a085a	Combine both calls to use same pathway	2022-07-22 14:59:20 +09:00
Dean Herbert	f713253d1b	Fix formatting inconsistencies in empty ctors	2022-07-22 14:00:29 +09:00
LukynkaCZE	ed94d7fce8	Fix requested changes	2022-07-22 02:46:17 +02:00
Adam Baker	997fe00cdc	Fix zoom delta math	2022-07-21 17:29:13 -05:00
Adam Baker	d69dc457ba	Extract zoom delta method	2022-07-21 17:28:43 -05:00
LukynkaCZE	ebe386c288	Merge branch 'ppy:master' into editor-save-toast	2022-07-22 00:25:23 +02:00
solstice23	b36e23c0da	Simplify the regex expression	2022-07-22 03:30:31 +08:00
solstice23	ae0902ca86	Fix lax in search criteria parsing	2022-07-22 02:55:11 +08:00
solstice23	0dcb3644f5	Merge branch 'master' into search-filter	2022-07-22 01:32:25 +08:00
Adam Baker	a4f071fe53	Make zoom sensitivity relative to containers max zoom	2022-07-21 08:26:48 -05:00
solstice23	6baaef432f	Add colon parsing support in search length criteria	2022-07-21 18:49:13 +08:00
solstice23	a5a8fac66f	Add multiple units support in search length criteria	2022-07-21 18:24:31 +08:00
Dean Herbert	fc0c9f76bd	Fix UpdateBeatmapSetButton intermittent test failure ... Carousel would only expire items when off-screen. This meant that for a case (like a test) where items are generally always on-screen, `UpdateBeatmapSet` calls would result in panels remaining hidden but not cleaned up.	2022-07-21 16:24:48 +09:00
Dean Herbert	3cfe624af1	Fix one more missed method with incorrect terminology	2022-07-21 16:16:41 +09:00
Dean Herbert	a05d7f4d8c	Change carousel terminology to not use Children / InternalChildren	2022-07-21 16:06:06 +09:00
Dean Herbert	07e1763a70	Tweak velocity a bit more (and simplify in multiple places)	2022-07-21 14:25:11 +09:00
Salman Ahmed	ad09e728fd	Move Passed assignment inside FailScore	2022-07-21 08:12:06 +03:00
TacoGuyAT	2f16174d3d	Changed control points set to private; Cleanup	2022-07-21 07:25:44 +03:00
TacoGuyAT	d6c3a52494	Added missing braces	2022-07-21 06:38:33 +03:00
TacoGuyAT	ed8e065a86	Logo triangles speed and beat sync tweaks	2022-07-21 06:13:45 +03:00
Salman Ahmed	0f0b19da4a	Populate score with remaining "miss" statistics on fail/exit	2022-07-21 06:01:36 +03:00
Dan Balasescu	7dfc18a0e3	Merge pull request #19208 from frenzibyte/remove-score-multiplier-on-custom-mod-settings ... Remove score multiplier on difficulty-increasing mods with customised settings	2022-07-20 20:12:59 +09:00
Dan Balasescu	2b399ec7ad	Merge branch 'master' into date-submitted-ranked	2022-07-20 18:36:57 +09:00
Dan Balasescu	de29078db2	Remove nullable disables	2022-07-20 15:16:40 +09:00
Dan Balasescu	f9c02c34b6	Merge branch 'master' into beatmap-update-online-flow	2022-07-20 15:15:51 +09:00
Salman Ahmed	6ce6f6f7df	Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings	2022-07-20 08:57:43 +03:00
Adam Baker	cecf654a7b	Update osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerMatchSubScreen.cs ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-07-19 18:58:59 -05:00
Salman Ahmed	ae6aab2555	Merge branch 'master' into edit-map-carousel	2022-07-20 02:43:47 +03:00
LukynkaCZE	5987acfbca	Fixed code formatting	2022-07-19 22:59:25 +02:00
LukynkaCZE	a00da279b7	Beatmap Editor Save Toast	2022-07-19 21:38:23 +02:00
Salman Ahmed	4210ec6502	Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings	2022-07-19 19:21:26 +03:00
Adam Baker	4164f260b3	Fix code quality errors	2022-07-19 08:12:12 -05:00
Dean Herbert	30daa0fd44	Add ranked and submitted date storage and filtering	2022-07-19 19:55:56 +09:00
Dean Herbert	17046b0553	Add basic handling of download failures	2022-07-19 19:01:23 +09:00
Dean Herbert	a16bf35581	Rename button class and add basic progress display	2022-07-19 18:29:36 +09:00
Dean Herbert	da360af15a	Fix vertical centering of button	2022-07-19 18:29:36 +09:00
Dean Herbert	eaf4f6dbb7	Add beatmap update button	2022-07-19 18:29:36 +09:00
Adam Baker	5008a73774	Make add item button open to the last beatmap in queue	2022-07-19 02:04:19 -05:00
Dan Balasescu	c07f78409e	Merge pull request #19189 from peppy/peform-actions-after-reconnect ... Fix creating multiplayer game during server migration not joining new room correctly	2022-07-19 14:46:29 +09:00
Adam Baker	59018ab5ba	Fix multiplayer queue edit button opening to the wrong beatmap	2022-07-18 23:21:16 -05:00
Bartłomiej Dach	6f37487528	Replace calls to defective Humanizer methods with correct version	2022-07-18 22:34:58 +02:00
Salman Ahmed	2befcfedbb	Merge branch 'master' into fix-multiplayer-participant-panel-null-ruleset	2022-07-18 12:24:47 +03:00
Dean Herbert	b8c90266de	Merge pull request #19209 from 3stantedja/make-contracted-stats-titlecase ... Make sure stats name are title-cased when score panel is contracted	2022-07-18 16:26:20 +09:00
Dean Herbert	a7f19cc796	Merge pull request #19137 from frenzibyte/country-enum ... Replace `Country` class with enumeration	2022-07-18 16:12:24 +09:00
Salman Ahmed	e86a35fe33	Fix NRE on footer button mods	2022-07-18 10:09:14 +03:00
Dean Herbert	a036632c8b	Fix potential crash when attempting to create mod display using null ruleset	2022-07-18 15:30:21 +09:00
Dean Herbert	21bf7ee448	Turn on nullability in ParticipantPanel	2022-07-18 15:27:55 +09:00
Salman Ahmed	100c53f9ef	Country -> CountryCode	2022-07-18 08:40:34 +03:00
Salman Ahmed	eddae7b143	Fix mod overlay and footer not updating multiplayer on settings change	2022-07-18 07:38:56 +03:00
Fyra Tedja	6ad7723d60	Make sure stats name are title-cased when score panel is contracted	2022-07-17 22:13:08 -06:00
Dean Herbert	55a8a3563b	Change MultiplayerMatchSubScreen to not immediately leave the room on connection loss ... Instead, we can rely on `MultiplayerClient.Room` going `null`.	2022-07-17 21:19:10 +09:00
tsunyoku	bbb2398a8b	change retry button icon from ArrowCircleLeft to Redo	2022-07-17 00:46:29 +01:00
Salman Ahmed	e62049f4a9	Update various usages of Country inline with new enum	2022-07-16 05:04:24 +03:00
Salman Ahmed	e6236ba088	Update save score button to check availability after import ... Previously was relying on whether `SaveReplay` returns null, but since I've changed it to use the standard "prepare score for import" path, the button has to check for local availability after import since that path doesn't return null on fail.	2022-07-15 23:39:52 +03:00
Salman Ahmed	6285442b7d	Fix failed scores not prepared before import	2022-07-15 22:57:12 +03:00
Salman Ahmed	8f7b3cf11a	Merge branch 'master' into Save-Score-Failed	2022-07-15 22:10:19 +03:00
Salman Ahmed	838e9ec12e	Merge branch 'master' into placeholder-fixes	2022-07-15 20:22:25 +03:00
Dean Herbert	cbbc8fdfb1	Merge pull request #19126 from peppy/lazer-leaderboards ... Show leaderboard scores from new data source	2022-07-16 01:53:16 +09:00
Dean Herbert	2beed6d7b7	Allow failed scores to fail in replay playback	2022-07-15 20:45:48 +09:00
Dean Herbert	d325c534ab	Check whether score is already imported and show correct state for save button	2022-07-15 20:45:37 +09:00
Dean Herbert	cf38b15332	Merge pull request #19124 from frenzibyte/song-select-metadata-search ... Change clicking source/tags on song select to filter instead of searching online	2022-07-15 19:16:31 +09:00
Dean Herbert	0200ef1d48	Make delegate firing more safe to being set later than BDL	2022-07-15 19:06:44 +09:00
Dean Herbert	0e788ac714	Simplify bindable logic greatly	2022-07-15 19:02:12 +09:00
Dean Herbert	8a48cb701d	Tidy up implementation and remove unnecessary enum	2022-07-15 19:02:04 +09:00
Dean Herbert	ab6665d88c	Merge branch 'master' into Save-Score-Failed	2022-07-15 18:02:58 +09:00
Dean Herbert	e12e480393	Only expose bindable string rather than full textbox	2022-07-15 18:01:35 +09:00
Dean Herbert	ba0a158740	Show search online prompt even when no beatmaps are available locally	2022-07-15 17:50:10 +09:00
Dean Herbert	c8c79d2185	Standardise HasReplay implementation (and remove from persisting to realm)	2022-07-15 16:14:21 +09:00
Dan Balasescu	c1dd1cfead	Merge pull request #19082 from peppy/api-solo-score-model ... Add and consume `SoloScoreInfo`	2022-07-15 15:20:18 +09:00
Salman Ahmed	7e80a71020	Replace download tracker with local querying	2022-07-15 08:16:36 +03:00
Salman Ahmed	86d019c2b2	Enable NRT on BeatmapDetails	2022-07-15 06:52:06 +03:00
Salman Ahmed	97c3eea3aa	Fix beatmap details source and tags not filtering on song select	2022-07-15 06:51:50 +03:00
Salman Ahmed	a85a70c472	Fix potential nullref in ContextMenuItems	2022-07-14 05:04:28 +03:00
Salman Ahmed	036e64382f	Add beatmap details menu item to playlist items	2022-07-14 03:41:47 +03:00
Salman Ahmed	102d0415f1	Merge branch 'master' into drawable-playlist-item-collection	2022-07-14 00:10:49 +03:00
Dean Herbert	7ac04d0478	Fix potential crash when exiting editor test mode	2022-07-14 01:00:18 +09:00
Dan Balasescu	7ed05277f8	Merge pull request #19098 from peppy/last-played ... Add "last played" sort mode to song select	2022-07-13 22:44:50 +09:00
Dean Herbert	937692604e	Remove mention of autoplay mod for now	2022-07-13 22:37:20 +09:00
Dan Balasescu	afaf8f5189	Merge pull request #19105 from peppy/fix-editor-disposed-track ... Fix audio and background file equality incorrectly comparing `BeatmapSet.Hash`	2022-07-13 22:34:36 +09:00
Dean Herbert	6950223a7d	Fix drawable mutation from disposal thread	2022-07-13 19:19:14 +09:00
Dean Herbert	952d97c66e	Update comment regarding LoadTrack safety	2022-07-13 19:02:22 +09:00
Dean Herbert	fc274629f8	Add "last played" sort mode to song select ... Note that this will consider the most recent play of any beatmap in beatmap set groups for now, similar to other sort methods.	2022-07-13 16:43:43 +09:00
Dean Herbert	ab3ec80159	Update LastPlayed on gameplay starting in a SubmittingPlayer	2022-07-13 16:43:43 +09:00
Dean Herbert	f956955d4d	Combine ScoreInfo construction helper methods	2022-07-12 18:00:25 +09:00
Dan Balasescu	bd6f8bde9f	Merge pull request #19079 from peppy/fix-audio-playback-disposed ... Fix potential crash during shutdown sequence if intro playback was aborted	2022-07-12 17:29:23 +09:00
Dean Herbert	cad18ebc58	Reword comment to better explain what we are guarding against	2022-07-12 16:46:19 +09:00
Dean Herbert	cafe30fc4d	Fix potential crash during shutdown sequence if intro playback was aborted ... Fixes one of the audio related `ObjectDisposedException`s (https://sentry.ppy.sh/organizations/ppy/issues/92/events/12f282f048cb4a4fae85810e8a70b68d/?project=2&query=is%3Aunresolved&sort=freq&statsPeriod=7d). Ran into this while testing locally. See `IntroScreen.ensureEventuallyArrivingAtMenu` for the related cause of this happening (forced continuing to next screen if the intro doesn't load in time).	2022-07-12 15:20:30 +09:00
Dean Herbert	b52ea16133	Show basic error message when score submission fails	2022-07-12 15:10:59 +09:00
Dan Balasescu	d82d50e308	Merge pull request #19065 from Ludio235/master ... Fix playlist room creation screen pushing content on opening dropdowns	2022-07-12 13:22:38 +09:00
Dan Balasescu	3ca10ac02c	Merge pull request #19063 from Joehuu/fix-samples-cancel-exit ... Fix editor playing object samples while paused after cancelling exit	2022-07-12 12:51:27 +09:00
為什麼	6a643cb6ea	Use Debug.Assert instead.	2022-07-12 09:41:19 +08:00
Dean Herbert	0434c10914	Use global WorkingBeatmap in PlayerArea for the time being	2022-07-11 02:57:44 +09:00
Dean Herbert	8116a4b6f6	Fix multiplayer spectator crash due to track potentially not being loaded in time	2022-07-11 02:51:40 +09:00
為什麼	857377e145	Move CreateConvertibleReplayFrame() into legacy ruleset interface because technically only legacy ruleset use it to convert the legacy frame. ... But seems some of the customized ruleset use it for save the replay frame.	2022-07-10 10:15:27 +08:00
Ludio235	52aef09cd6	Update PlaylistsRoomSettingsOverlay.cs	2022-07-10 02:05:40 +00:00
Joseph Madamba	834bb1f187	Fix editor playing object samples while paused after cancelling exit	2022-07-09 12:14:39 -07:00
cdwcgt	d2406242ae	rename updateTooltip to updateState	2022-07-09 00:38:17 +09:00
cdwcgt	91f471ebe0	disabled button instead of shake ... removed `ShakeContainer`	2022-07-09 00:37:53 +09:00
cdwcgt	a38c6704c2	Use ContinueWith, Check is Task empty	2022-07-09 00:23:32 +09:00
Dean Herbert	5651eca06c	Merge branch 'master' into custom-ruleset-score-import	2022-07-08 19:03:47 +09:00
Dean Herbert	e4ebab92c6	Rename lots of weird variables	2022-07-08 18:37:03 +09:00
Dean Herbert	f3a6e646a6	Merge branch 'master' into Save-Score-Failed	2022-07-08 18:32:13 +09:00
Dean Herbert	eab3eba70e	Move event handlers to LoadComplete	2022-07-08 15:09:16 +09:00
Dean Herbert	1e159eb328	Add back fade to black duration ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-07-08 10:43:50 +09:00
Salman Ahmed	67fa15f231	Remove no longer required context menu container in ParticipantsList	2022-07-08 01:42:55 +03:00
Salman Ahmed	7b08501eaf	Cover online-play room screens with context menu containers	2022-07-08 01:42:11 +03:00
Salman Ahmed	1d0f2e359a	Add collection context menu to room playlist items	2022-07-08 01:40:53 +03:00
Salman Ahmed	a94fb62be3	Split collection toggle menu item to own class	2022-07-08 01:39:45 +03:00
Salman Ahmed	07a08d28c6	Rename parameter and default to 0	2022-07-07 23:31:06 +03:00
Dean Herbert	15d070668d	Move intro screen background to base implementation and use colour fading	2022-07-08 02:12:01 +09:00
Dean Herbert	216150b52d	Avoid always loading new background at MainMenu ... This was meant to be an optimisation to allow the background to load while the intro is playing, but as the current default intro loads a background itself, this was rarely the case and also counter-productive as it would bypass the equality check and start a second load sequence.	2022-07-08 02:12:01 +09:00
Dean Herbert	789904ccd1	Avoid reloading background unnecessariyl when not yet loaded	2022-07-08 02:12:01 +09:00
Dean Herbert	9d730f8440	Fix custom rulesets not importing scores at all ... Replaces the error with the ability to import, minus replays. Closes https://github.com/ppy/osu/issues/17350 (arguably, but let's go with it for now).	2022-07-07 14:49:23 +09:00
Dean Herbert	e1b434b5dc	Fix song select placeholder not showing convert hint for custom rulesets	2022-07-07 14:46:51 +09:00
Susko3	4c3789ec5d	Split into a function	2022-07-05 11:15:37 +02:00
Susko3	bb0f212448	Trigger the initial cookie with midi and joysticks	2022-07-05 00:38:18 +02:00
Dan Balasescu	9bf91835b6	Merge pull request #18962 from peppy/slider-range-control ... Move star difficulty filter to song select	2022-07-03 21:58:00 +09:00
Dan Balasescu	724fd19038	Remove nullable disables	2022-07-03 21:15:13 +09:00
Dan Balasescu	1ccfd69690	Merge pull request #18978 from peppy/send-beatmap-hash-to-server ... Send beatmap hash to server on solo score request	2022-07-03 13:18:17 +09:00
Dean Herbert	052a786eff	Only show hover effect on one nub at a time	2022-07-03 03:06:03 +09:00
Dean Herbert	7d8ea5e286	Remove unnecessary proxying	2022-07-03 02:59:10 +09:00
Dean Herbert	2a1777fa85	Merge branch 'master' into fix-player-star-difficulty-display	2022-07-02 18:57:46 +09:00
Salman Ahmed	19d300e311	Fix player loader not accepting star difficulty updates after display	2022-07-02 09:17:38 +03:00
Dean Herbert	a03abc747b	Tidy up comments and simplify bounding box centre logic	2022-07-02 12:58:34 +09:00
Dean Herbert	1fd9c64803	Change song select FooterButton sound	2022-07-02 12:48:33 +09:00
Dean Herbert	634b6cdbbe	Send beatmap has to server on solo score request ... Right now, the client does nothing to ensure a beatmap is in a valid state before requesting to submit a score. There is further work to be done client-side so it is more aware of this state (already handled for playlists, but not for the solo gameplay loop), but the solution I have in mind for that is a bit more involved. This is not used server-side yet, but I want to get this sending so we can start using it for some very basic validation. Will resolve the basic portion of #11922 after implemented server-side.	2022-07-02 12:16:17 +09:00
Dan Balasescu	3b1842a2c2	Merge pull request #18835 from peppy/beatmap-update-flow ... Split out beatmap update tasks to `BeatmapUpdater` and invoke from editor save flow	2022-07-01 20:28:04 +09:00
Dean Herbert	6baccad058	Merge pull request #18821 from ggliv/locked-room-filter ... Add room access type filter to multiplayer lounge screen	2022-07-01 19:37:43 +09:00
Dean Herbert	b829884861	Merge pull request #18963 from peppy/more-placeholder-suggestions ... Add difficulty filter reset to song select "no results" suggestions	2022-07-01 17:55:23 +09:00
Dean Herbert	b460a52faf	Merge pull request #18966 from smoogipoo/fix-flaky-multiplayer-test ... Fix test sometimes referencing old ModSelect object	2022-07-01 17:55:06 +09:00
Dean Herbert	e213c1a4ef	Rename enum to explicitly mention it is a filter	2022-07-01 17:27:03 +09:00
Dean Herbert	9911c6cbf0	Merge branch 'master' into locked-room-filter	2022-07-01 17:17:01 +09:00
Dan Balasescu	58c9bb031f	Apply PR reviews/fixes	2022-07-01 16:51:15 +09:00
Dan Balasescu	c22e77e481	Fix test sometimes referencing old ModSelect object	2022-07-01 16:46:27 +09:00
Dean Herbert	58e25a3a01	Fix potential crash in BeatmapLeaderboard during rapid refresh operations	2022-07-01 15:42:35 +09:00
Dean Herbert	3e0f4e7609	Add test coverage of difficulty filter reset	2022-07-01 15:28:55 +09:00
Dean Herbert	f3af612133	Suggest removing difficulty filter if no matches found at song select	2022-07-01 15:18:04 +09:00
Dean Herbert	545df0a8e8	Display difficulty on nub	2022-07-01 15:17:26 +09:00
Dean Herbert	cb9947b1c9	Align song select components a bit better	2022-07-01 15:17:12 +09:00
Dean Herbert	32139ac13f	Tidy up implementation and add basic visual test	2022-07-01 15:16:58 +09:00
Dean Herbert	d54f7fc728	Move slider range control to song select	2022-07-01 14:41:36 +09:00
cdwcgt	33209ecd25	remove useless value change	2022-06-30 19:51:58 +09:00
Dean Herbert	aab4dcefbd	Remove unnecessary invalidation handling flow	2022-06-30 17:13:26 +09:00
Dean Herbert	98938821e5	Merge branch 'master' into beatmap-update-flow	2022-06-30 16:44:17 +09:00
cdwcgt	fd0d8b1ce3	Add button state, fix async issues, watch replay method ... Most borrowed from `ReplayDownloadButton`	2022-06-29 22:50:47 +09:00
Salman Ahmed	e3eba58cb6	Catch in triangles intro	2022-06-29 13:37:42 +03:00
Dean Herbert	6bfd351dec	Add logging of GameplayClockContainer seeks	2022-06-28 15:23:29 +09:00
Dean Herbert	569fde4b47	Add messages to all InvalidOperationExceptions ... Without this, they can be very non-descript and hard to track down	2022-06-28 01:34:25 +09:00
Dan Balasescu	d43b980a17	Merge pull request #18872 from peppy/add-working-beatmap-changed-logging ... Add various logging of global `WorkingBeatmap` state changes	2022-06-27 21:34:05 +09:00
Dean Herbert	aa7d54f8b6	Add logging for various cases of SongSelect.FinaliseSelection being aborted	2022-06-27 20:10:17 +09:00
Dean Herbert	50c1c066de	Add various logging of global WorkingBeatmap state changes	2022-06-27 18:41:31 +09:00
Dean Herbert	0ba29b6fa6	Use currentScreen instead to make sure the screen we care about is loaded	2022-06-27 18:28:00 +09:00
Dean Herbert	5a7d339cc8	Centralise and harden editor-ready-for-use check ... Not only does this combine the check into one location, but it also adds a check on the global `WorkingBeatmap` being updated, which is the only way I can see the following failure happening: ```csharp 05:19:07 osu.Game.Tests: osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.TestAddAudioTrack 05:19:07 Failed TestAddAudioTrack [161 ms] 05:19:07 Error Message: 05:19:07 TearDown : System.NullReferenceException : Object reference not set to an instance of an object. 05:19:07 Stack Trace: 05:19:07 --TearDown 05:19:07 at osu.Game.Database.ModelManager`1.<>c__DisplayClass7_0.<AddFile>b__0(TModel managed) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36 05:19:07 at osu.Game.Database.ModelManager`1.<>c__DisplayClass8_0.<performFileOperation>b__0(Realm realm) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 49 05:19:07 at osu.Game.Database.RealmExtensions.Write(Realm realm, Action`1 function) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\RealmExtensions.cs:line 14 05:19:07 at osu.Game.Database.ModelManager`1.performFileOperation(TModel item, Action`1 operation) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 46 05:19:07 at osu.Game.Database.ModelManager`1.AddFile(TModel item, Stream contents, String filename) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36 05:19:07 at osu.Game.Screens.Edit.Setup.ResourcesSection.ChangeAudioTrack(FileInfo source) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Screens\Edit\Setup\ResourcesSection.cs:line 115 05:19:07 at osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.<TestAddAudioTrack>b__13_0() in C:\BuildAgent\work\ecd860037212ac52\osu.Game.Tests\Visual\Editing\TestSceneEditorBeatmapCreation.cs:line 101 05:19:07 at osu.Framework.Testing.Drawables.Steps.AssertButton.checkAssert() 05:19:07 at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered) 05:19:07 at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition) ```	2022-06-27 16:22:01 +09:00
Dean Herbert	31a447fda0	Update parameter discards	2022-06-24 21:26:19 +09:00
Dean Herbert	30eebf3511	Merge branch 'master' into c-sharp-10	2022-06-24 21:22:33 +09:00
Dean Herbert	7692bac35a	Simplify refetch (and ensure to invalidate after processing)	2022-06-24 21:02:38 +09:00
Dean Herbert	66a01d1ed2	Allow song select to refresh the global WorkingBeatmap after an external update	2022-06-24 21:02:38 +09:00
Bartłomiej Dach	26c5b59f6d	Replace usages of string.To{Lower,Upper}()	2022-06-24 11:57:45 +02:00
Dean Herbert	8912f07745	Merge branch 'master' into difficulty-icon-refactor-pass	2022-06-24 16:34:35 +09:00
Dean Herbert	f71f6302fd	Remove unnecessary null casts	2022-06-24 14:50:11 +09:00
Dean Herbert	28837693e5	Nuke calculating everything ... The whole component is pointless so I'm just going to nuke for now I guess. Kind of makes the whole refactor effort pointless but oh well? To expand on this, the implementation was actually incorrect as pointed out at https://github.com/ppy/osu/pull/18819#pullrequestreview-1017886035.	2022-06-24 14:24:06 +09:00
Bartłomiej Dach	04d69010b5	Split overlong conditional to local function	2022-06-23 18:03:07 +02:00
Bartłomiej Dach	bea70988bc	Remove unnecessary #nullable disable	2022-06-23 17:57:22 +02:00
Gabe Livengood	454eff43c5	publicity -> accesstype	2022-06-23 11:40:25 -04:00
Gabe Livengood	d67c482c48	move publicity filter to multi exclusively	2022-06-23 11:36:08 -04:00
Gabe Livengood	9a15adbfff	add an all option to publicity filter	2022-06-23 11:24:28 -04:00
Gabe Livengood	2def6d809b	refactor to use enum dropdown	2022-06-23 11:02:27 -04:00
Dean Herbert	ef258122d2	Move GetDifficultyRating helper method to StarDifficulty	2022-06-23 19:51:58 +09:00
Dean Herbert	01da6f20b3	Tidy up all remaining usages	2022-06-23 19:27:35 +09:00
Dean Herbert	7dec530ca5	Split out simple DifficultyIcon with no calculation overhead and update usages	2022-06-23 19:27:35 +09:00
Dean Herbert	4a2ca4394b	Remove unused ModeTypeInfo class	2022-06-23 19:27:35 +09:00
Gabe Livengood	bf5a7e3f2a	add locked room filter	2022-06-22 17:01:28 -04:00
Dean Herbert	97fcf8cec9	Merge pull request #18668 from smoogipoo/editor-controlpoint-undo-redo	2022-06-23 04:02:24 +09:00
Dean Herbert	b660119de7	Merge pull request #18796 from bdach/mod-overlay/legacy-key-bindings ... Add setting option to toggle between mod overlay hotkey styles	2022-06-22 20:28:18 +09:00
Jamie Taylor	950551f4fd	Fix metronome arm being stuck white when paused 'close enough' to center	2022-06-22 15:33:42 +09:00
cdwcgt	bff35cb348	Shake button when replay already save	2022-06-22 01:19:20 +09:00
cdwcgt	f2eb7e0551	Use better design and fix some problem ... Let saveReplay async but still void Make failed score's rank = F	2022-06-21 19:06:38 +08:00
Bartłomiej Dach	73124d2b1f	Encapsulate mod hotkey selection logic in strategy pattern	2022-06-21 12:49:01 +02:00
Dean Herbert	b7b7de115f	Merge pull request #18744 from nekodex/new-metronome-sfx ... New audio feedback for metronome	2022-06-21 17:16:41 +09:00
Dean Herbert	7d988da2c7	Merge pull request #18788 from peppy/editor-seek-constant-while-playing ... Change editor seek-while-playing modifier to be BPM agnostic	2022-06-21 15:28:46 +09:00
Dean Herbert	a40ad6f784	Add slight transform when resetting arm from almost-zero	2022-06-21 15:07:35 +09:00
Dean Herbert	82c4d855d4	Rename sample variable to be easier to discern from other fields	2022-06-21 15:05:17 +09:00
Dean Herbert	16a9e18815	Adjust timing of latch to be more in sync with visuals	2022-06-21 15:02:53 +09:00
Dean Herbert	7b46d38318	Move colour fade back to where it was	2022-06-21 15:02:43 +09:00
Dean Herbert	3b79c632f5	Merge branch 'master' into new-metronome-sfx	2022-06-21 14:58:58 +09:00
Dean Herbert	42701757c3	Fix latch reset logic	2022-06-21 14:52:57 +09:00
Dean Herbert	22cb8b0d43	Merge pull request #18768 from smoogipoo/spectator-reset-speed-at-end ... Reset spectator speed after the last frame is reached	2022-06-21 14:41:08 +09:00
Dean Herbert	88f450e1d0	Remove accidental nullable enable spec	2022-06-21 14:40:21 +09:00
Dean Herbert	72c0fc3fec	Merge pull request #18753 from frenzibyte/prevent-mistimed-metronome-beats ... Fix metronome playing mistimed beat sounds on editor clock resume	2022-06-21 13:48:42 +09:00
Dean Herbert	c61e90d768	Change editor seek-while-playing modifier to be BPM agnostic	2022-06-21 13:07:50 +09:00
Dan Balasescu	046b848bcd	Split group selection to separate method	2022-06-21 12:53:06 +09:00
Salman Ahmed	f103de4efb	Merge branch 'master' into spectator-reset-speed-at-end	2022-06-21 06:37:58 +03:00
Dan Balasescu	b3e5642dfd	Use WaitingOnFrames instead	2022-06-21 12:23:43 +09:00
Dan Balasescu	93ce6fc981	Remove redundant diff processing	2022-06-21 12:11:44 +09:00
Dan Balasescu	9763a58392	Change to use ReferenceEquals	2022-06-21 12:05:52 +09:00
cdwcgt	43ead5820a	deal with test	2022-06-21 00:54:50 +09:00
Dan Balasescu	e0c82d11ab	Convert == usages to ReferenceEquals	2022-06-20 16:56:19 +09:00
Dan Balasescu	ca287d0936	Fix group deselected when table is recreated	2022-06-20 16:56:19 +09:00
Dan Balasescu	a922ea9b01	Fix selection by directly comparing control points ... Previously, all control points would get replaced, which led to performance issues that was worked around in this PR. By comparing control points, we're able to get good performance without requiring the workaround.	2022-06-20 15:29:29 +09:00
Dean Herbert	a6c8a832aa	Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask)	2022-06-20 15:14:57 +09:00
Dan Balasescu	468e5fcbed	Merge branch 'master' into editor-controlpoint-undo-redo	2022-06-20 13:47:01 +09:00
Bartłomiej Dach	3ab8158b92	Do not try to set ruleset from beatmap if it's a dummy	2022-06-19 20:08:39 +02:00
Bartłomiej Dach	93b3ede2a0	Always use beatmap ruleset in editor gameplay test mode ... Fixes cases where opening a convertible beatmap (so any osu! beatmap) with the game-global ruleset being set to anything but osu! would result in opening the editor gameplay test mode with the game-global ruleset rather than the beatmap's.	2022-06-19 19:30:40 +02:00
cdwcgt	9a6f4ef76d	Save score button on failed screen	2022-06-19 23:59:37 +09:00
Dan Balasescu	98d69c846c	Reset spectator speed at last frame	2022-06-19 17:12:20 +09:00
Salman Ahmed	a2e17941e5	Merge branch 'master' into timing-offset-adjust-seek-only-at-start	2022-06-19 01:27:44 +03:00
Bartłomiej Dach	2a95715652	Merge branch 'master' into fix-input-regression	2022-06-18 19:44:53 +02:00
Dean Herbert	3902dc64f0	Fix adjusting offset via button seeking to timing point's offset unexpectedly ... This was added with the intention of tracking the offset when already at the start (the most common case when you're using the tap timing wizard), but was also seeking when the user may be much further beyond or before it. Addresses https://github.com/ppy/osu/discussions/18741#discussioncomment-2975051.	2022-06-19 01:35:45 +09:00
Dean Herbert	3fa8c19acd	Merge branch 'master' into latency-certifier/hidden-cursor	2022-06-19 00:31:11 +09:00
Salman Ahmed	a5e5172b91	Fix BlueprintContainer eating input from skin editor buttons	2022-06-18 18:28:36 +03:00
Bartłomiej Dach	5917c70127	Merge branch 'master' into multi-song-select-operation	2022-06-18 11:58:13 +02:00
Bartłomiej Dach	f6a3047596	Merge branch 'master' into editor-metadata-name-unification	2022-06-18 10:22:52 +02:00
Dan Balasescu	77e7e4ecb2	Fix selection being blocked after early return	2022-06-18 14:28:30 +09:00
Salman Ahmed	204348f327	Fix metronome playing mistimed beat sounds on editor clock resume	2022-06-18 04:49:44 +03:00
Salman Ahmed	8a1d11fefb	Cancel previous metronome sound playback on pause	2022-06-18 04:07:21 +03:00
Dan Balasescu	e04df371d1	Merge branch 'master' into multi-song-select-operation	2022-06-18 08:51:24 +09:00
Dean Herbert	4bc26dbb48	Merge pull request #18743 from smoogipoo/nullable-by-default ... Enable NRT by default	2022-06-17 23:18:35 +09:00
Dean Herbert	5d93db1522	Merge pull request #18726 from peppy/disclaimer-stop-handling-after-suspend ... Fix `Disclaimer` screen handling user change events after initial display	2022-06-17 18:28:06 +09:00
Dean Herbert	1900480d51	Inline animation method	2022-06-17 17:06:06 +09:00
Dan Balasescu	869db52540	Tie loading layer to ongoing operation state	2022-06-17 17:05:23 +09:00
Dean Herbert	e51babdb96	Change heart animation flow to be more correct	2022-06-17 17:01:11 +09:00
Jamie Taylor	1f78a4fadd	New audio feedback for metronome	2022-06-17 16:56:09 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Bartłomiej Dach	6ff6a3f5b3	Rename and document chooserPath	2022-06-16 21:51:31 +02:00
Salman Ahmed	db02cb81c5	Fix file chooser path not opening home directory initially	2022-06-16 20:48:17 +03:00
Salman Ahmed	f7a27b412a	Revert "Let latency certifier buttons steal hover from area" ... This reverts commit beb0331640.	2022-06-16 20:35:30 +03:00
Salman Ahmed	8e088140b2	Reword comment since IRequireHighFrequencyMousePosition isn't the issue	2022-06-16 20:09:10 +03:00
Salman Ahmed	beb0331640	Let latency certifier buttons steal hover from area	2022-06-16 20:00:30 +03:00
Salman Ahmed	ed6817ae6a	Allow switching between latency and menu cursor using IProvideCursor	2022-06-16 19:46:31 +03:00
Salman Ahmed	52538dc708	Refactor LatencyCursorContainer to become a cursor container	2022-06-16 19:46:04 +03:00
Salman Ahmed	47d0ecf5e8	Merge branch 'master' into editor-metadata-name-unification	2022-06-16 18:53:23 +03:00
Salman Ahmed	6aee689586	Fix previous file lookup not using metadata properties	2022-06-16 18:50:38 +03:00
Salman Ahmed	f1081db953	Fix background/track implicitly renamed on initial load	2022-06-16 18:48:32 +03:00
Dean Herbert	89533fa33d	Fix Disclaimer screen handling user change events after initial display ... Unnecessary overhead, but also should resolve a production hard crash.	2022-06-16 15:40:20 +09:00
Bartłomiej Dach	f88c568c8d	Update flag sizes after switch to twemoji assets ... The old flags used a size of 150x100, while the new assets based on twemoji use a size of 150x108. Update existing usages to match this new aspect ratio better.	2022-06-15 21:45:47 +02:00
Salman Ahmed	2c35b1404b	Use FileInfo as current bindable type	2022-06-15 19:29:09 +03:00
Salman Ahmed	1ff070f5ff	Decouple LabelledFileChooser from LabelledTextBoxWithPopover	2022-06-15 17:45:31 +03:00
Dean Herbert	7571ab6c63	Merge branch 'master' into new-dialog-sfx	2022-06-15 19:47:00 +09:00
Dean Herbert	7a2919975a	Fix sound clash when exiting a multiplayer room with confirmation	2022-06-15 18:48:22 +09:00
Dan Balasescu	d89c80ace2	Block operations during beatmap selection in match	2022-06-15 18:44:16 +09:00
Dean Herbert	1520ccf865	Fix double back sound due to sub screen presence in multiplayer/playlists	2022-06-15 18:44:16 +09:00
Dean Herbert	c27e5d1216	Fix editor still playing back sound when exiting with confirmation	2022-06-15 18:44:02 +09:00
Dean Herbert	be2b4e68b9	Don't play player exit sound when restarting	2022-06-15 17:49:18 +09:00
Dean Herbert	713cff3403	Don't play editor exit sound when changing difficulties	2022-06-15 17:49:09 +09:00
Dean Herbert	fd4529aa7c	Play editor exit sound if no confirmation buttons were shown during exit process	2022-06-15 17:37:54 +09:00
Dean Herbert	7ac5019c08	Fix intro screens playing exit sounds	2022-06-15 17:37:30 +09:00
Dean Herbert	6136e4e27a	Don't play exit sound if screen is in a non-resumable state when exiting	2022-06-15 17:37:25 +09:00
Dean Herbert	87bf53485a	Merge pull request #18649 from frenzibyte/selection-context-outside-bounds ... Fix context menus not appearing when clicking outside of editor playfield's bounds	2022-06-15 17:08:09 +09:00
Salman Ahmed	6a8cf514e0	Update background/track file chooser to not display filename	2022-06-15 09:52:13 +03:00
Jamie Taylor	5e3ccf7087	Don't play 'back' sample when exiting Editor	2022-06-15 15:41:28 +09:00
Jamie Taylor	6b744a14b0	Move 'back' sample playback from OnResuming to OnExiting	2022-06-15 15:41:28 +09:00
Salman Ahmed	f3f0960335	Use unified filename for background and track during editor import	2022-06-15 09:02:48 +03:00
Salman Ahmed	d3feb07bc1	Split zoom updating to named method with value as optional	2022-06-15 07:57:16 +03:00
Salman Ahmed	268a7e1334	Fix ZoomableScrollContainer attempting to update zoom with overlapping range	2022-06-15 05:43:41 +03:00
Salman Ahmed	36599d1174	Merge branch 'master' into fix-hit-error-when-not-visible	2022-06-14 22:47:11 +03:00
Dean Herbert	6be4209458	Fix AlwaysPresent specification in wrong container	2022-06-15 01:04:43 +09:00
Dan Balasescu	cc7943dfb1	Merge pull request #18687 from peppy/editor-repeat-behaviour-change-collapsing ... Fix timing adjustment repeat buttons firing one change per repeat invocation	2022-06-14 20:24:13 +09:00
Dean Herbert	c30644328c	Fix timing adjustment repeat buttons firing one change per repeat invocation	2022-06-14 19:21:02 +09:00
Dean Herbert	aeca138930	Fix ctrl-z in editor also seeking to start in addition to undo	2022-06-14 18:48:57 +09:00
Dean Herbert	a20e43c2ae	Ensure containers which are being used to hide HUD elements still update for now ... I don't think this is necessarily a final solution (as this means all HUD elements are adding overhead even when not visible), but this will make the implementations much easier for the time being. I've checked and can't notice any perceivable overhead in profiling so we should be fine for now.	2022-06-14 18:22:25 +09:00
Salman Ahmed	fa4930c586	Remove no longer necessary ReceivePositionalInputAt overrides in timeline components	2022-06-14 00:19:47 +03:00
Salman Ahmed	c49b8e4a5c	Allow BlueprintContainer and SelectionHandler to receive input outside bounds	2022-06-14 00:19:15 +03:00
Salman Ahmed	9fc04924eb	Revert "Provide context menu items at BlueprintContainer for out-of-bounds support" ... This reverts commit 85fc218edf.	2022-06-14 00:02:02 +03:00
Dean Herbert	bd9ea9bd6f	Revert most unnecessary changes ... Turns out `AlwaysPresent` at top level is actually enough. This reverts commit 86163d2225.	2022-06-13 23:58:14 +09:00
Dan Balasescu	f680f4d26b	Apply refactorings from review	2022-06-13 17:36:32 +09:00
Dean Herbert	f997886142	Add scrolling gameplay visualisation mode to latency certifier	2022-06-13 17:18:32 +09:00
Dan Balasescu	c178e5d592	Add explanatory comment	2022-06-13 16:58:43 +09:00
Dan Balasescu	a8286bdf04	Fix assertion failures	2022-06-13 16:56:08 +09:00
Dan Balasescu	285e5abb41	Fix incorrect fallback value	2022-06-13 16:55:46 +09:00
Dean Herbert	86163d2225	Fix hit error meters not updating visual state when hidden ... It is an expectation of users that when the HUD is shown after a period of being hidden, it will visually reflect the state based on recent judgements. To achieve this, I've added `AlwaysPresent` and moved the transform application to the meter level, rather than at a child level. If this is seen as a bad direction, `AlwaysPresent` can be applied to the drawable children and the transforms can be moved back. Also of note, `ColourHitErrorMeter` is pretty weird. The flow class could potentially be removed and reduce `AlwaysPresent` usage by one. Can do that refactor as part of this PR if preferred. Closes #18624.	2022-06-13 16:38:57 +09:00
Dean Herbert	17eaf7bb5c	Add failing test coverage showing hit meters don't update when not visible	2022-06-13 16:36:22 +09:00
Dan Balasescu	5a18547342	Compare by char ... Co-authored-by: Berkan Diler <berkan.diler1@ingka.ikea.com>	2022-06-13 15:58:11 +09:00
Dan Balasescu	776e7c0c71	Work around performance issues	2022-06-13 15:45:08 +09:00
Dan Balasescu	7e7716f942	Support undo/redo for control points	2022-06-13 15:45:08 +09:00
Salman Ahmed	85fc218edf	Provide context menu items at BlueprintContainer for out-of-bounds support	2022-06-11 20:53:53 +03:00
Dan Balasescu	12ff98001d	Merge pull request #18635 from peppy/latency-comparer-more-modes ... Add multiple display modes (including circle gameplay) to latency certification	2022-06-12 00:59:36 +09:00
Dan Balasescu	486f762f44	Fix inspection by removing unstable rate code	2022-06-12 00:13:36 +09:00
Dean Herbert	af353c37c0	Don't show UR for now	2022-06-11 23:54:11 +09:00
Salman Ahmed	419b5791c9	Move circle duration to constant	2022-06-11 16:08:24 +03:00
Dean Herbert	8d53ed64a3	Fix mode cycling and add test coverage	2022-06-11 21:36:43 +09:00
Dean Herbert	0c333e5c08	Link directly to methodology section ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-06-11 21:34:00 +09:00
Dean Herbert	c697dc90e4	Hide settings at results screen	2022-06-11 21:32:02 +09:00
Dean Herbert	d130e7ebff	Remove ScrollingGameplay class for now	2022-06-11 21:30:33 +09:00
Dean Herbert	68da9f0386	Add explicit precision for BPM adjustment ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-06-11 21:27:44 +09:00
Salman Ahmed	06f070c3ec	Fix latency certifier potentially reporting infinite mouse polling rate	2022-06-11 14:58:16 +03:00
Dean Herbert	096d6df868	Fix regression in testing and setting logic	2022-06-10 20:33:21 +09:00
Dean Herbert	8ce545ff9d	Fix visuals in circle gameplay and greedy hover	2022-06-10 20:25:33 +09:00
Dean Herbert	b956a916c1	Make units sane	2022-06-10 20:21:03 +09:00
Dean Herbert	213ccfb743	Improve explanation text and add link to wiki	2022-06-10 20:14:12 +09:00
Dean Herbert	18f74b2840	Move settings and bindables to a sane location	2022-06-10 20:04:51 +09:00
Dean Herbert	837958b254	Remove scrolling gameplay mode for now	2022-06-10 19:43:09 +09:00
Dean Herbert	ef5c1a1ecb	Improve visuals of circle gameplay mode	2022-06-10 19:42:25 +09:00
Dean Herbert	a6fd61c444	Default to circle gameplay mode	2022-06-10 19:42:25 +09:00
Dean Herbert	41d16c613d	Fix being able to hit way too early using keyboard	2022-06-10 19:42:25 +09:00
Dean Herbert	2f1c331f65	Move shared logic to LatencySampleComponent and implement key support for circle gameplay	2022-06-10 19:42:25 +09:00
Dean Herbert	7f4a54096f	Fix circles in the future being hittable	2022-06-10 19:42:25 +09:00
Dean Herbert	ba14d646c3	Add static configuration	2022-06-10 19:42:25 +09:00
Dean Herbert	5deaa42e9f	Stop music on entering latency certification screen	2022-06-10 19:42:25 +09:00
Dean Herbert	5c7d29cd31	Remove dependency on game-wide audio	2022-06-10 19:42:25 +09:00
Dean Herbert	d46739ff0b	Add circle gameplay test coverage	2022-06-10 19:42:25 +09:00
Dean Herbert	c657ef2722	Add ability to adjust spacing	2022-06-10 19:42:25 +09:00
Dean Herbert	e9547542ea	Add circle gameplay	2022-06-10 19:42:25 +09:00
Dean Herbert	53eb5c176c	Create setup for adding other visual display modes	2022-06-10 19:42:25 +09:00
Dan Balasescu	e5d6dc1ba5	Merge pull request #18606 from peppy/latency-comparer ... Add latency certifier system	2022-06-10 19:41:44 +09:00
Dean Herbert	e0644f2726	Simplify flow of progression to be linear	2022-06-10 15:19:10 +09:00
Dean Herbert	5541ebc76b	Revert OsuButton changes	2022-06-10 15:02:26 +09:00
Dan Balasescu	c9dfffbc0e	Merge pull request #18619 from peppy/fix-collection-performance ... Fix performance overhead of large collections	2022-06-10 15:01:31 +09:00
Dean Herbert	eb16de9c71	Use upper-case "Hz"	2022-06-10 14:38:04 +09:00
Dean Herbert	f71343c880	Fix box colour getting stuck when changing active mode	2022-06-10 14:28:46 +09:00
Dean Herbert	5b8bd24140	Simplify text when reaching maximum supported level ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-06-10 14:25:15 +09:00
Dean Herbert	69b856bd58	Rename rounds variables to hopefully read better	2022-06-10 14:23:24 +09:00
Dean Herbert	613814c26c	Make TargetFrameRate nullable	2022-06-10 14:18:35 +09:00
Dean Herbert	4a5e86e451	Rename Beatmaps to BeatmapHashes for clarity	2022-06-10 14:03:51 +09:00
Dean Herbert	70ebfbcf5e	Add recommendation text and adjust weightings to read better	2022-06-09 19:26:24 +09:00
Dan Balasescu	6e450b7350	Explicitly handle operation cancelled exceptions	2022-06-09 14:35:53 +09:00
Dan Balasescu	ec03dc16db	Don't trigger notification when user quit	2022-06-09 14:13:14 +09:00
Dan Balasescu	bfde334e77	Allow beatmaps to load endlessly when entering Player	2022-06-09 14:03:21 +09:00
Dean Herbert	187086e4ec	Merge pull request #18609 from ALANVF/settings-delete-skin ... Add button to delete the current skin	2022-06-08 19:18:59 +09:00
Dean Herbert	42cd7d9e6e	Change CollectionManager to only store MD5 hashes instead of full BeatmapInfo	2022-06-08 18:23:09 +09:00
Dan Balasescu	f8594acb1d	Cleanup dialog implementation	2022-06-08 18:17:43 +09:00
Dan Balasescu	3a90aa0b9b	Fix code styling	2022-06-08 17:57:59 +09:00
Dan Balasescu	c43670fcd9	Merge pull request #18603 from peppy/fix-import-dialog ... Add placeholder when no results are visible at song select	2022-06-08 15:22:31 +09:00
Dean Herbert	cd649f7d97	Merge branch 'master' into multiplayer-leaderboard-user-mods-2	2022-06-08 13:39:42 +09:00
theangryepicbanana	6c05329144	Close #5820 (Ability to delete a single skin)	2022-06-07 18:01:40 -04:00
Dean Herbert	b924aa3296	Fix tests failing when run headless	2022-06-08 00:36:19 +09:00
Dean Herbert	228683e956	Fix nullability of dialogOverlay dependency	2022-06-07 23:48:34 +09:00
Dean Herbert	2e0b888410	Fix song select carousel invalidating every frame during global overlay dimming	2022-06-07 23:46:53 +09:00
Dean Herbert	9da99a0ddf	Rename to latency certifier	2022-06-07 23:34:55 +09:00
Dean Herbert	1a1dfaeae6	Update framework	2022-06-07 23:27:59 +09:00
Dean Herbert	95dea00725	Tidy up code and namespaces	2022-06-07 23:10:08 +09:00
Dean Herbert	058760253a	Add test coverage of certification flow	2022-06-07 23:02:15 +09:00
Dean Herbert	c1ef59ab03	Add more comprehensive certification flow (and remove "difficulty" terminology)	2022-06-07 22:52:24 +09:00
Dean Herbert	0561e9cc75	Fix mouse focus not always working	2022-06-07 20:45:37 +09:00
Dean Herbert	f2524fc3d7	Increase separator width	2022-06-07 20:42:19 +09:00
Dean Herbert	60d7060baa	Add tab focus support	2022-06-07 20:28:42 +09:00
Dean Herbert	00a6cbe53f	Allow using J/K to move box as well	2022-06-07 20:03:49 +09:00
Dean Herbert	146225d87e	Fix multiple issues with layout and text	2022-06-07 20:02:26 +09:00
Dean Herbert	43a04010a7	Add display of polling rate	2022-06-07 19:43:33 +09:00
Dean Herbert	2e7a966218	Add proper frame rate limiting and fix mouse cursor missing at results	2022-06-07 19:31:56 +09:00
Dean Herbert	c0e88d9577	Add better messaging and pass/fail cutoff	2022-06-07 19:06:54 +09:00
Dean Herbert	3fc8ac0ec7	Add key bindings everywhere	2022-06-07 18:27:42 +09:00
Dean Herbert	a175defefd	Add difficulty levels	2022-06-07 18:11:54 +09:00
Dean Herbert	3bd8bbd297	Add explanatory text	2022-06-07 17:36:34 +09:00
Dean Herbert	c323c67d7d	Allow increasing confidence by playing longer	2022-06-07 17:28:31 +09:00
Dean Herbert	0adeccbf03	Add full latency testing flow	2022-06-07 17:28:31 +09:00
Dean Herbert	f8524c3af4	Use VisibilityContainer to avoid too many animations triggering	2022-06-07 17:25:06 +09:00
Dean Herbert	a04af1ca5f	Enable nullable and add hinting at convert filter criteria	2022-06-07 17:25:06 +09:00
Dean Herbert	0d32c94104	Add initial implementation of beatmap carousel no-results-placeholder	2022-06-07 17:25:06 +09:00
Dean Herbert	df9174ec00	Remove import popup dialog from song select ... This has been replaced in spirit by the first run overlay.	2022-06-07 16:45:27 +09:00
Dan Balasescu	476a05cafb	Merge pull request #18599 from hlysine/fix-score-panel-diff-name-overflow ... Truncate difficulty name in score panel	2022-06-07 14:16:02 +09:00
Henry Lin	ef5d601f67	Fix difficulty name overflow in score panel	2022-06-07 12:05:03 +08:00
Dean Herbert	cd0e0fe70f	Fix skin editor not accounting for aspect ratios in base-game sizing logic	2022-06-06 18:02:42 +09:00
Dan Balasescu	b897e1464f	Merge pull request #18462 from frenzibyte/fix-timeline-zooming ... Fix timeline objects disappearing prematurely on wide-screens	2022-06-05 11:49:44 +09:00
Joseph Madamba	4b54fedd88	Add back hide common string using new ToSentence() extension method	2022-06-03 20:09:20 -07:00
Joseph Madamba	b342aad24a	Revert/fix some incorrectly used sorting localisation	2022-06-03 19:56:33 -07:00
Jamie Taylor	6115275bc2	Use 'default' sampleset for toolbar and repurpose 'toolbar' select sample temporarily	2022-06-03 22:33:06 +09:00
Jamie Taylor	365819865e	Remove 'submit' sample usages	2022-06-03 22:31:35 +09:00
Dan Balasescu	fcf51a6f51	Merge pull request #18530 from peppy/add-cloen-button ... Change text on timing group add button when it is going to clone instead	2022-06-03 22:23:04 +09:00
Dean Herbert	debd1a59b0	Merge pull request #18539 from frenzibyte/repeating-button-behaviour ... Share repeat implementation in `TimingAdjustButton` for timeline zoom buttons	2022-06-03 18:18:23 +09:00
Dan Balasescu	1c738e22ae	Merge pull request #18523 from peppy/tap-button ... Add tap for BPM button	2022-06-03 18:11:10 +09:00
Dean Herbert	cd3edc869c	Remove unnecessary nesting of IconButton and update design a touch	2022-06-03 17:00:00 +09:00
Dean Herbert	e779b460e4	Use Component instead of CompositeDrawable	2022-06-03 16:49:08 +09:00
Dean Herbert	678229fdab	Merge pull request #18536 from bdach/safe-file-chooser-textbox-disposal ... Improve safety of file chooser textbox disposal	2022-06-03 13:50:41 +09:00
Dan Balasescu	dd93fc283b	Merge pull request #18531 from peppy/track-groups-better ... Improve group tracking logic to avoid switching which point type unnecessarily	2022-06-03 13:04:54 +09:00
Salman Ahmed	b51e0a5047	Share button repeating logic with TimelineButton for better UX	2022-06-03 05:23:49 +03:00
Salman Ahmed	efbde06c11	Split button repeating logic from TimingAdjustButton to own component	2022-06-03 05:23:49 +03:00
Salman Ahmed	21385655fe	Fix ZoomableScrollContainer not updating on parent size changes	2022-06-03 02:34:10 +03:00
Salman Ahmed	60fb5d5e6c	Revert "Fix timeline objects disappearing prematurely on wide-screens" ... This reverts commit 02baf9a97a.	2022-06-03 02:03:04 +03:00
Salman Ahmed	8471b24659	Merge branch 'master' into fix-timeline-zooming	2022-06-03 02:00:09 +03:00
Bartłomiej Dach	87ec2e490d	Merge branch 'master' into deselect-control-group	2022-06-03 00:47:06 +02:00
Bartłomiej Dach	59ffc8b08e	Merge branch 'master' into multiplayer-leaderboard-user-mods-2	2022-06-02 20:45:10 +02:00
Bartłomiej Dach	cf9b78ea2a	Improve safety of FileChooserLabelledTextBox disposal	2022-06-02 20:38:14 +02:00
Bartłomiej Dach	ec24b32fa6	Add NRT coverage for FileChooserLabelledTextBox	2022-06-02 20:36:28 +02:00
Dean Herbert	ad3c093a08	Improve group tracking logic to avoid switching which point type unnecessarily	2022-06-02 18:33:09 +09:00
Dean Herbert	2fa4d46f73	Change text on timing group add button when it is going to clone instead ... Also disables the button when it would otherwise have no effect.	2022-06-02 18:28:16 +09:00
Dean Herbert	0b125ade4c	Allow clicking away to deselect the current control point group	2022-06-02 18:18:18 +09:00
Dean Herbert	5a0f716bf2	Fix timing screen crash when attempting to add group to self ... Closes #18527.	2022-06-02 18:14:28 +09:00
Dean Herbert	ee4beefd95	Increase max taps to 128 for now ... Will revisit this in the future with a more sound algorithm.	2022-06-02 17:27:52 +09:00
Dean Herbert	e75609dfb9	Increase taps to consider for better results for longer tap periods	2022-06-02 17:03:48 +09:00
Dean Herbert	4abfb35611	Improve light rotational alignment and increase light count to 8	2022-06-02 16:58:14 +09:00
Dan Balasescu	4d9a77bdc0	Stop using Drawable.Clock altogether	2022-06-02 15:02:50 +09:00
Dan Balasescu	2209a009f9	Don't process clock	2022-06-02 14:48:55 +09:00
Dean Herbert	060372a129	Split out transition length constants	2022-06-02 13:16:31 +09:00
Dean Herbert	15f8d318eb	Add note about glow code (please look away)	2022-06-02 13:13:00 +09:00
Dean Herbert	ac3793f340	Move inline class to end and apply NRT	2022-06-02 13:10:50 +09:00
Dean Herbert	d99d37c0a6	Apply current track rate to calculated BPM	2022-06-02 13:06:18 +09:00
Dean Herbert	943e904c71	Fix reset happening on mouse down instead of mouse up ... Also some reorganisation of file content for legibility	2022-06-02 12:58:44 +09:00
Dean Herbert	0c493dd359	Add key binding for tap button	2022-06-02 12:58:44 +09:00
Dean Herbert	781a1527b1	Adjust button metrics and move surrounding buttons to be more integrated	2022-06-02 12:58:43 +09:00
Dean Herbert	d4e88441ec	Adjust metrics to make timing section fit better in editor	2022-06-02 11:57:06 +09:00
Dean Herbert	f3f7e28353	Ignore initial taps as they are generally inaccurate	2022-06-02 11:57:06 +09:00
Dean Herbert	b88bce9b8b	Restart track playback when tapping to time	2022-06-02 11:57:06 +09:00
Dean Herbert	96ccd29bdc	Don't play metronome click when tapping for timing	2022-06-02 11:57:06 +09:00
Dean Herbert	d47a3bb8e4	Use NRT and transfer BPM	2022-06-02 11:57:06 +09:00
Dean Herbert	a2d177d7d2	Add BPM display and tracking	2022-06-02 11:57:06 +09:00
Dean Herbert	3c7a04256f	Add glow	2022-06-02 11:57:06 +09:00
Dean Herbert	c3ba7b2c3b	Add lights	2022-06-02 11:57:06 +09:00
Dean Herbert	d12f6ea221	Add basics of tap button	2022-06-02 11:57:06 +09:00
Dean Herbert	453259df62	Merge pull request #18516 from peppy/metronome-sound ... Add metronome sound	2022-06-02 07:38:42 +09:00
Dean Herbert	6b297bc6ed	Merge pull request #18502 from peppy/editor-timing-follow-current-time ... Add automatic control point tracking to the timing screen	2022-06-02 07:37:03 +09:00
Bartłomiej Dach	c0001d7f00	Merge branch 'master' into metronome-sound	2022-06-01 22:32:48 +02:00
Bartłomiej Dach	d3b51c7387	Merge branch 'master' into editor-waveform-display-lock	2022-06-01 21:56:01 +02:00
Bartłomiej Dach	0723709bec	Merge branch 'master' into editor-offset-bpm-adjust-buttons	2022-06-01 21:25:18 +02:00
Bartłomiej Dach	801e11d841	Apply performance regression fix to effect section too	2022-06-01 20:25:56 +02:00
Bartłomiej Dach	6b709de2c2	Remove unused using directive	2022-06-01 20:18:02 +02:00
Bartłomiej Dach	a5d515dd0c	Merge branch 'master' into editor-new-control-point-is-bettert	2022-06-01 19:48:17 +02:00
Dean Herbert	534e8f8fac	Only switch to found group if non-null	2022-06-01 20:20:48 +09:00
Dean Herbert	a4ec32b499	Add button sound effect	2022-06-01 18:15:16 +09:00
Dean Herbert	93b8c90ecc	Apply frequency adjust to channel rather than sample for safety	2022-06-01 18:04:13 +09:00
Dean Herbert	0472881078	Fix null check only covering one of two calls	2022-06-01 18:03:03 +09:00
Dean Herbert	187acb0718	Simplify linq tracking logic	2022-06-01 17:57:53 +09:00
Dean Herbert	1293bbdbd9	Remove unnecessary null checks on Text property	2022-06-01 17:46:33 +09:00
Dean Herbert	8c54bd46bb	Rename button to more appropriate name	2022-06-01 17:46:05 +09:00
Dean Herbert	b03b0c9303	Merge branch 'master' into editor-offset-bpm-adjust-buttons	2022-06-01 17:45:16 +09:00
Dean Herbert	c55c3325a4	Remove unused using statements	2022-06-01 17:43:40 +09:00
Dean Herbert	f3fd5bbfc1	Increase flash delay and ensure text is always shown immediately on lock	2022-06-01 16:05:29 +09:00
Dean Herbert	58ba92772c	Reword comment to read better ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-06-01 16:01:34 +09:00
Dean Herbert	eac014738f	Merge branch 'master' into editor-bottom-bar-shadow	2022-06-01 14:55:50 +09:00
Dean Herbert	6042cf1a3b	Add metronome sound ... Placeholder pending follow-up from @nekodex (which as discussed should probably have a second sound for the metronome locking into "stopped" position).	2022-06-01 14:43:39 +09:00
Dean Herbert	25941f6187	Use DeepClone instead of reflection call ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-06-01 10:47:45 +09:00
Dean Herbert	bc22079fdc	Fix row selected colour flicker when changing offset rapidly	2022-05-31 22:02:30 +09:00
Dean Herbert	8240b645b4	Copy attribute types from currently selected control point to new placements	2022-05-31 21:50:12 +09:00
Dean Herbert	f99bcb23a0	Automatically make first control point added to beatmap have timing data	2022-05-31 21:50:08 +09:00
Dean Herbert	a940676fc2	Add adjustment buttons	2022-05-31 21:31:20 +09:00
Dan Balasescu	eaeb66547e	Revert comment removal	2022-05-31 19:58:45 +09:00
Dean Herbert	475cc8174f	Fix off-by-one display issue when adjusting offset	2022-05-31 18:41:44 +09:00
Dean Herbert	94194a04f2	Animate adjustments	2022-05-31 18:41:44 +09:00
Dean Herbert	51014b8748	Ensure offset changes are correctly tracked by the display, even when locked	2022-05-31 18:41:44 +09:00
Dean Herbert	c8f21ee8b2	Change WaveformComparisonDisplay to centre around a time offset rather than beat	2022-05-31 18:41:44 +09:00
Dean Herbert	6bc68ada43	Add ability to lock the WaveformComparison display to a current location	2022-05-31 18:41:44 +09:00
Dean Herbert	c0804803fd	Add background to main waveform row	2022-05-31 18:35:52 +09:00
Dean Herbert	655780fd98	Fix regression in bpm textbox binding logic	2022-05-31 18:27:18 +09:00
Dean Herbert	ebb83a5e49	Add TODO about scroll behaviour which is missing	2022-05-31 15:10:55 +09:00
Dean Herbert	cf5da44492	Add automatic control point tracking to the timing screen	2022-05-31 15:00:30 +09:00
Dean Herbert	27efeb7d4e	Fix TimingSection performing a beatmap save when switching bound timing points	2022-05-31 14:58:49 +09:00
Dan Balasescu	22d998dc2a	Use new score processor in MultiplayerGameplayLeaderboard	2022-05-30 19:26:26 +09:00
Dan Balasescu	a052e09ac3	Send ScoreProcessor statistics in SpectatorState	2022-05-30 19:26:26 +09:00
Dan Balasescu	c97b477485	Fix inverted operation order	2022-05-30 19:11:54 +09:00
Dan Balasescu	be998cdb0a	Merge pull request #18477 from frenzibyte/fix-timeline-context-menu ... Fix context menu no longer opening for hitobjects in timeline	2022-05-30 11:49:06 +09:00
Bartłomiej Dach	c892ec83ef	Fix wrong sizing of editor timeline ticks	2022-05-29 20:15:17 +02:00
Salman Ahmed	9cc5df9b13	Fix context menu no longer open on hitobjects in timeline	2022-05-29 15:23:32 +03:00
Salman Ahmed	02baf9a97a	Fix timeline objects disappearing prematurely on wide-screens	2022-05-28 17:45:38 +03:00
Bartłomiej Dach	1641918c51	Revert "Avoid throwing unobserved exception when PerformancePointsCounter requests timed attributes" ... This reverts commit 19b655d75b.	2022-05-28 15:23:28 +02:00
Dean Herbert	62266c72ea	Merge pull request #18448 from frenzibyte/editor-metronome-rate ... Fix metronome speed not adjusted on different playback rates	2022-05-28 10:58:51 +09:00
Dean Herbert	4f2910cdb1	Merge pull request #18445 from frenzibyte/editor-background-colour ... Darken background colour in "setup" and "verify" screens	2022-05-28 10:56:22 +09:00
Dean Herbert	68684f5fe7	Merge pull request #18446 from frenzibyte/editor-row-attribute-background ... Update row attribute background colour to fit screen	2022-05-28 10:53:50 +09:00
Dean Herbert	93a8092da6	Increase usable width slightly further	2022-05-28 10:51:39 +09:00
Salman Ahmed	e12d188dad	Fix metronome speed not adjusted on different playback rates	2022-05-28 04:10:39 +03:00
Salman Ahmed	d12e4928e6	Increase editor verify settings width to give more breathing space	2022-05-28 03:09:04 +03:00
Salman Ahmed	e71d907164	Update row attribute background colour to fit screen	2022-05-28 02:20:04 +03:00
Salman Ahmed	eec9248cde	Darken background colour in "setup" and "verify" screens	2022-05-28 02:10:18 +03:00
Salman Ahmed	aee3e2a4ed	Add shadow effect to editor's bottom bar	2022-05-28 01:58:55 +03:00
Dean Herbert	03d9ca0d8d	Merge pull request #18437 from peppy/fa-playlist-category ... Add featured artist playlist category	2022-05-28 01:28:21 +09:00
Bartłomiej Dach	e511c1dfff	Merge branch 'master' into use-normalised-precise-scrolling	2022-05-27 16:55:13 +02:00
Bartłomiej Dach	a94432f3bd	Fix drawable room border colour not matching badge	2022-05-27 16:40:15 +02:00
Dean Herbert	883c6f1eb3	Update colour of spotlights playlist to match new specs	2022-05-27 20:26:35 +09:00
Dean Herbert	ef47b380c6	Add featured artist playlist category	2022-05-27 20:18:46 +09:00
Dean Herbert	d94315ee3f	Fix potential crash from unsafe drawable mutation in scoreboard update code	2022-05-27 20:03:30 +09:00
Joseph Madamba	e551a53601	Fix checkmarks not showing on editor stateful menu items	2022-05-26 21:45:30 -07:00
Bartłomiej Dach	e7a266e742	Merge branch 'master' into fix-multiplayer-race	2022-05-26 20:43:20 +02:00
Dan Balasescu	0224947de0	Add comment about how starting gameplay works	2022-05-26 20:09:47 +09:00
Dan Balasescu	3915b8e414	Fix multiplayer race condition when starting gameplay	2022-05-26 20:01:33 +09:00
Dean Herbert	fb586fe0b2	Merge branch 'master' into editor-bottom-bar-new-design	2022-05-26 18:32:28 +09:00
Dean Herbert	7f4ea5d522	Use left alignment and remove hacky text positioning code	2022-05-26 18:12:28 +09:00
Bartłomiej Dach	f0303d76e8	Split off "select all mods" button to separate class	2022-05-25 22:18:30 +02:00
Dean Herbert	acd554d918	Update time info and add bpm	2022-05-25 23:54:59 +09:00
Dean Herbert	2c61a9d3d1	Update bottom bar components to new design language (mostly)	2022-05-25 23:54:59 +09:00
Dean Herbert	8791e3b9ef	Split BottomBar out of Editor	2022-05-25 23:54:59 +09:00
Dean Herbert	463b8130c8	Update editor screen switcher to match new design language	2022-05-25 22:31:27 +09:00
Dean Herbert	206f2ca208	Rename screen switcher control to be in line with naming expectations	2022-05-25 22:20:33 +09:00
Dean Herbert	c4cae7f677	Update EditorMenuBar to match new design language	2022-05-25 22:19:24 +09:00
Dan Balasescu	fb22801afb	Merge pull request #18388 from peppy/editor-timing-waveforms ... Add waveform comparison view to editor timing screen	2022-05-25 20:15:25 +09:00
Dean Herbert	f1d4902be5	Remove unnecessary bindable cast	2022-05-25 19:25:23 +09:00
Dan Balasescu	f468d1eb16	Merge branch 'master' into editor-tidy-up	2022-05-25 11:58:34 +09:00
Bartłomiej Dach	5f6baaca13	Merge branch 'master' into editor-beat-divisor-size-static	2022-05-24 23:17:02 +02:00
Dan Balasescu	25f35b3408	Merge pull request #18394 from peppy/editor-beat-divisor-on-mouse-down ... Handle beat divisor input on mouse down, rather than mouse up	2022-05-24 19:06:14 +09:00
Dan Balasescu	46b2f1ecc2	Merge pull request #18392 from peppy/editor-remove-triangle-button-usage ... Remove `TriangleButton` usage in editor	2022-05-24 18:51:02 +09:00
Dean Herbert	0bcf8c846c	Change editor colour scheme to aquamarine	2022-05-24 18:43:22 +09:00
Dean Herbert	648cee7106	Remove editor screen transitions for now	2022-05-24 18:43:22 +09:00
Dean Herbert	3f5ccd4db8	Update timing screen sections to newer design metrics	2022-05-24 18:43:22 +09:00
Dean Herbert	c02ec05056	Remove remaining usage of EditorRoundedScreen	2022-05-24 18:43:22 +09:00
Dean Herbert	1d196262d0	Remove unused OnTimelineLoaded flow	2022-05-24 18:43:22 +09:00
Dean Herbert	a905731053	Update timeline colours and paddings to match new designs	2022-05-24 18:43:22 +09:00
Dean Herbert	17206bbebf	Update screen padding and colouring to better match new designs	2022-05-24 18:43:22 +09:00
Dean Herbert	a2bfd0ba41	Merge branch 'editor-remove-triangle-button-usage' into editor-combined	2022-05-24 18:43:02 +09:00
Dean Herbert	741cfcc614	Merge branch 'editor-beat-divisor-on-mouse-down' into editor-combined	2022-05-24 18:43:01 +09:00
Dean Herbert	3ace5f135e	Adjust marker to match design proportions	2022-05-24 18:26:01 +09:00
Dean Herbert	3c2e57bf00	Update BeatDivisorControl to better match new designs and metrics	2022-05-24 18:26:01 +09:00
Dean Herbert	e6087f5f5b	Handle beat divisor input on mouse down, rather than mouse up ... It felt way too unresponsive.	2022-05-24 18:16:19 +09:00
Dean Herbert	4a88affd03	Move beat divisor tick size retrieval to static methods	2022-05-24 18:15:20 +09:00
Dean Herbert	a346990a8c	Remove TriangleButton usage in editor	2022-05-24 18:13:09 +09:00
Dean Herbert	1137545d4a	Fix Timeline potentially not updating visuals to correct state on first display	2022-05-24 18:11:05 +09:00
Dean Herbert	49a2173646	Avoid needlessly updating display (and add better documentation on chosen scale)	2022-05-24 14:36:44 +09:00
Dean Herbert	4fcdcef166	Add indexing on each wavefrom row	2022-05-24 14:36:44 +09:00
Dean Herbert	c1720c128d	Dim rows which are not part of the active control point (and offset centre)	2022-05-24 14:36:44 +09:00
Dean Herbert	7040dec013	Fix disabled bindable woes by not using TimingControlPoint.DEFAULT	2022-05-24 14:36:44 +09:00
Dean Herbert	588c5d1583	Add initial waveform comparison display	2022-05-24 14:36:44 +09:00
Susko3	88217e0c98	Adjust ScrollDelta usages to account for normalised IsPrecise values	2022-05-23 20:22:27 +02:00
Dan Balasescu	7d0470794b	Merge pull request #18353 from frenzibyte/spectator-catch-up-work-alt ... Disallow multi-spectator player clocks from being started/stopped externally	2022-05-23 13:59:54 +09:00
Dan Balasescu	e3c1c78b17	Merge pull request #18348 from maromalo/mod-key-multiplayer ... Add toggle mod hotkey support in multiplayer room	2022-05-23 13:45:02 +09:00
Dan Balasescu	f111d33b25	Merge pull request #18339 from peppy/editor-timing ... Add first pieces of editor timing UI	2022-05-23 11:12:22 +09:00
Dean Herbert	9c3d0dafbd	Remove implementation at Player level ... Turns out this isn't required in the end due to implementation at `MasterGameplayClockContainer`.	2022-05-23 02:00:21 +09:00
Dean Herbert	c9ea87e6be	Revert easing for now	2022-05-23 00:03:42 +09:00
Dean Herbert	007582afb9	Remove unused usings resulting from namespace move	2022-05-22 23:55:33 +09:00
Dean Herbert	eabf578282	Use interface to convey beat sync information	2022-05-22 22:44:54 +09:00
maromalo	fc25d248ad	Test coverage + no virtual	2022-05-21 18:16:29 -03:00
Salman Ahmed	27da293b40	Make catch-up spectator clocks running state immutable externally	2022-05-21 17:12:04 +03:00
Dean Herbert	9a780bcad3	Remove unused using	2022-05-21 21:56:05 +09:00
Dean Herbert	376549ce09	Use ToLocalisableString instead of CurrentCulture	2022-05-21 21:48:51 +09:00
maromalo	2bd4c126d3	Blank line ... Forgot to save.	2022-05-21 05:07:24 -03:00
maromalo	a7aa36a825	Add OnPressed to button	2022-05-21 04:55:42 -03:00
Dean Herbert	982856a8b2	Merge branch 'localisable-filter-items' into update-framework	2022-05-21 15:17:51 +09:00
Salman Ahmed	84a3cee452	Apply rate multiplier outside BPM rounding	2022-05-20 18:04:12 +03:00
Dean Herbert	4633eed78c	Merge branch 'master' into localisable-filter-items	2022-05-20 23:55:16 +09:00
Salman Ahmed	596853da8f	Fix song select potentially displaying BPM range with equal min/max values	2022-05-20 17:53:28 +03:00
Dean Herbert	8db80b92bb	Fix metronome not using EditorBeatmap causing editor updates to not propagate immediately	2022-05-20 23:24:57 +09:00
Dean Herbert	82eb5fd2c9	Add centre line on weight	2022-05-20 17:30:04 +09:00
Dean Herbert	2e21d75b10	Move metronome into own class and rename to avoid conflict with mod sounds	2022-05-20 17:30:04 +09:00
Dean Herbert	cf97f4e409	Add centre marker	2022-05-20 17:30:04 +09:00
Dean Herbert	4712e512d7	Apply edge smoothness and make weight more accented	2022-05-20 17:30:04 +09:00
Dean Herbert	8487d2c48a	Interpolate bpm label and fix incorrect angle logic	2022-05-20 17:30:04 +09:00
Dean Herbert	21072a26ef	Add locking wedge	2022-05-20 17:30:04 +09:00
Dean Herbert	79878a4ec2	Metrics adjust and labelling	2022-05-20 17:30:04 +09:00
Dean Herbert	cf1ef28f72	Add taper and more correctly shaped weight	2022-05-20 17:30:04 +09:00
Dean Herbert	42179568f3	Initial animation pass on metronome	2022-05-20 17:30:04 +09:00
Dean Herbert	ce7be940e2	Setup basics for control and test	2022-05-20 17:30:04 +09:00
Dan Balasescu	64a371638e	Merge pull request #18236 from peppy/snap-unification ... Add `enum` to snap method as alternative to multiple nested invocations	2022-05-20 11:35:05 +09:00
Dean Herbert	363e7a6f53	Simplify toolbar hiding logic in FirstRunSetupOverlay ... Rather than fiddling around with the activation modes, this seems like a much cleaner way to make things work. Closes https://github.com/ppy/osu/issues/18277.	2022-05-19 16:42:48 +09:00
Dean Herbert	83e781d5a1	Allow localisation of PlaceholderText	2022-05-17 17:42:46 +09:00
Dean Herbert	17e0105c2c	Fix interaction with popover when textbox is disabled	2022-05-17 17:33:54 +09:00
Dean Herbert	3ff0399281	Split out LabelledTextBoxWithPopover for reuse	2022-05-17 17:33:54 +09:00
Dan Balasescu	a633501687	Change FilterTerms to use LocalisableString	2022-05-16 14:09:37 +09:00
Dean Herbert	328561f5c8	Merge pull request #18263 from frenzibyte/spotlight-beatmap-badge ... Add support for "spotlight" label in beatmap overlay/listing	2022-05-15 12:32:20 +09:00
Dean Herbert	b6575c216b	Allow selecting all mods at free mod select using ctrl+a	2022-05-15 03:25:14 +09:00
Dean Herbert	8a01050168	Refactor mod select button initialisation to allow shared usage of deselect button	2022-05-15 03:16:43 +09:00
Salman Ahmed	88ba84ac9c	Replace Pill with Badge everywhere	2022-05-14 20:52:38 +03:00
Bartłomiej Dach	ab5c736da1	Merge branch 'master' into editor-readability	2022-05-13 21:10:48 +02:00
Dean Herbert	c4871ebcf4	Add editor track traversal keys (Z-V)	2022-05-14 02:50:51 +09:00
Dean Herbert	f22ff4e087	Remove editor animation toggling (replaced by overlap markers)	2022-05-12 19:28:56 +09:00
Dean Herbert	c0abce918f	Add enum to snap method as alternative to mutliple nested invocations	2022-05-12 16:19:07 +09:00
Dan Balasescu	c54ca937c5	Fix CI inspections	2022-05-12 14:55:20 +09:00
Dean Herbert	f51607521c	Fix distance snap providing zero-distance snaps incorrectly	2022-05-12 13:11:55 +09:00
Dean Herbert	5800d7e99d	Merge pull request #18220 from frenzibyte/control-popover-focus ... Focus textbox upon opening control point popovers	2022-05-11 19:41:25 +09:00
Dan Balasescu	52c8382138	Merge pull request #18221 from peppy/multiplayer-leaderboard-hiding ... Change multiplayer leaderboard to always hide during gameplay unless holding-for-HUD	2022-05-11 18:43:55 +09:00
Dean Herbert	d05cd69087	Change multiplayer leaderboard to always hide during gameplay unless holding-for-HUD	2022-05-11 16:12:54 +09:00
Dean Herbert	1c36995606	Expose HoldingForHUD state from HUDOverlay as bindable	2022-05-11 16:09:16 +09:00
Salman Ahmed	96db530de6	Focus textbox on control point popovers	2022-05-11 09:55:34 +03:00
Salman Ahmed	24432dffc4	Add support for focusing intermediate slider-textbox component	2022-05-11 09:53:04 +03:00
Salman Ahmed	0b597e712e	Fix timeline not handling mouse down events	2022-05-11 09:39:27 +03:00
Bartłomiej Dach	76c63f1d0a	Rename ModSelect{Screen -> Overlay} in place of removed old design	2022-05-10 22:56:50 +02:00
Bartłomiej Dach	4a3447f59f	Remove old free mod select overlay	2022-05-10 21:45:57 +02:00
Dean Herbert	a578f7a406	Force nested screens to load synchronously	2022-05-10 18:21:35 +09:00
Dan Balasescu	a16f2349aa	Fix next queued item not selecting after gameplay	2022-05-09 17:55:42 +09:00
Dean Herbert	ab1d46b71c	Merge pull request #17270 from frenzibyte/multiplayer-disable-adaptive-speed ... Disable mod "Adaptive Speed" in multiplayer	2022-05-09 17:31:47 +09:00
Salman Ahmed	2f3ac61b47	Revert "Replace vertical scrolling in results screen with size-preserving container" ... This reverts commit 298c2a1828.	2022-05-09 10:35:14 +03:00
Salman Ahmed	422531d8ec	Revert "Remove no longer required constant" ... This reverts commit 6f4cdccf6c.	2022-05-09 10:35:13 +03:00
Salman Ahmed	3407a299ef	Revert "Revert scale locking changes for now" ... This reverts commit e4521b1fff.	2022-05-09 10:35:12 +03:00
Salman Ahmed	e4521b1fff	Revert scale locking changes for now	2022-05-09 10:16:57 +03:00
Salman Ahmed	6f4cdccf6c	Remove no longer required constant	2022-05-08 16:20:26 +03:00
Salman Ahmed	7f1ad149d5	Remove no longer necessary horizontal scroll blocker	2022-05-08 16:04:24 +03:00
Salman Ahmed	298c2a1828	Replace vertical scrolling in results screen with size-preserving container	2022-05-08 16:03:57 +03:00
Bartłomiej Dach	cbd1169495	Move cache declarations of ISamplePlaybackDisabler to interface	2022-05-08 10:38:58 +02:00
Bartłomiej Dach	9ae019eb39	Move ISamplePlaybackDisabler to more general namespace	2022-05-08 10:38:58 +02:00
Dean Herbert	0d32bf91eb	Hardcode hide key handling in ModSelectScreen	2022-05-08 01:35:11 +09:00
Bartłomiej Dach	9a56f6db44	Merge branch 'mod-overlay/back-button' into mod-overlay/integration	2022-05-07 13:15:13 +02:00
Salman Ahmed	d4c9de8596	Move button width in mod select to constant	2022-05-07 13:23:48 +03:00
Salman Ahmed	a44e21d1b2	Merge branch 'master' into mod-overlay/localisation-strings	2022-05-07 12:13:28 +03:00
Bartłomiej Dach	e7e7486a8e	Merge branch 'mod-overlay/back-button' into mod-overlay/integration	2022-05-07 10:59:30 +02:00
Salman Ahmed	db04bcf1ce	Merge branch 'master' into distance-snap-grid-current-tiume	2022-05-07 11:47:38 +03:00
Bartłomiej Dach	6ad990dfc3	Add basic localisation strings for new mod select	2022-05-07 10:17:24 +02:00
Bartłomiej Dach	4ff96f82be	Dim other buttons if customisation panel is open	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	852e4a9766	Add select/deselect all buttons to free mod select screen	2022-05-07 09:29:33 +02:00
Bartłomiej Dach	202a603d72	Merge branch 'master' into distance-snap-grid-current-tiume	2022-05-07 08:49:30 +02:00
Dean Herbert	dd63657dfb	Merge pull request #18065 from huoyaoyuan/code-style ... Enforce code style analysis shipped with .NET SDK	2022-05-07 14:58:19 +09:00
Dean Herbert	71758390b5	Fix time based distance grid alpha not correctly accounting for distance spacing multiplier	2022-05-07 13:37:36 +09:00
Salman Ahmed	723fce8174	Move inverting value to happen outside clamp ... Looks to have no effect, but makes sense to happen outside instead.	2022-05-06 18:54:13 +03:00
Salman Ahmed	d78f1d158d	Use GetEndTime() instead of StartTime ... Companion to 246479bf34	2022-05-06 18:51:35 +03:00
Salman Ahmed	112496204d	Make nested class private	2022-05-06 18:50:28 +03:00
Salman Ahmed	3077d398ef	Merge branch 'master' into distance-snap-grid-current-tiume	2022-05-06 18:20:22 +03:00
Salman Ahmed	144d33f0d2	Merge branch 'master' into distance-snapping-test	2022-05-06 17:29:27 +03:00
Bartłomiej Dach	56fa5c9db1	Merge branch 'master' into editor-drag-box	2022-05-06 15:22:39 +02:00
Bartłomiej Dach	29a3ab7e7a	Halve drag box padding ... Allows the drag box borders to collapse in on themselves to a single line if the drag selection has zero width or height.	2022-05-06 15:21:35 +02:00
Dean Herbert	fad1f727bb	Fix editor drag box visuals	2022-05-06 20:34:44 +09:00
Dean Herbert	69592722f8	Highlight distance snap grid rings that are close to the current time value	2022-05-06 18:30:46 +09:00
Dean Herbert	118e58888b	Rename incorrectly named variable (radius is not diameter)	2022-05-06 17:51:51 +09:00
Dean Herbert	37cbc79283	Fix clamping logic to always clamp to the last displayed tick	2022-05-06 17:09:38 +09:00
Dean Herbert	684fef7f8c	Fix MaxIntervals incorrectly factoring distance spacing multipiler into snap calculation	2022-05-06 17:09:02 +09:00
Bartłomiej Dach	f5026bbbeb	Bind to button's activation delay directly	2022-05-06 10:04:36 +02:00
Bartłomiej Dach	f39fcee41b	Remove commented-out code	2022-05-06 10:04:00 +02:00
Dean Herbert	246479bf34	Fix snap extent not working correctly on sliders (and providing incorrect time values)	2022-05-06 15:54:37 +09:00
Dean Herbert	32b40bdabf	Rename DistanceBetweenTick to be plural	2022-05-06 15:45:36 +09:00
Dean Herbert	78959a6e05	Add animation to denote a dangerous player exit	2022-05-06 15:02:22 +09:00
Dean Herbert	1c4aa12585	Rename non-descript Button nested class	2022-05-06 14:45:53 +09:00
Dean Herbert	a11771c11b	Better encapsulate exposed bindables of HoldToConfirmContainer	2022-05-06 14:45:53 +09:00
Dean Herbert	be960eb092	Move dangerous hold specification to base class	2022-05-06 14:34:31 +09:00
Dean Herbert	0d8e42b941	Merge branch 'master' into exit-multiplayer-is-dangerous	2022-05-06 14:25:18 +09:00
Dean Herbert	641584a049	Merge branch 'master' into multiplayer-disable-adaptive-speed	2022-05-06 14:00:44 +09:00
Bartłomiej Dach	34cf4c6a38	Fix mod overlay not closing on toggle hotkey	2022-05-05 22:16:56 +02:00
Bartłomiej Dach	0caea77176	Fix mod selects not hiding when their owner screens exit	2022-05-05 22:16:55 +02:00
Bartłomiej Dach	a56eab2c47	Extract interface for overlay management	2022-05-05 22:16:55 +02:00
Bartłomiej Dach	66473972da	Use new user mod select design in multiplayer lobby	2022-05-05 22:16:55 +02:00
Bartłomiej Dach	4eefbd5bc2	Use new free mod select design in room creation flow	2022-05-05 22:16:54 +02:00
Bartłomiej Dach	ac08498f35	Use plum colour scheme in multiplayer to match rest of multiplayer screens	2022-05-05 22:16:54 +02:00
Bartłomiej Dach	1744d7e4f0	Fix new mod select overlay dimming itself	2022-05-05 22:16:54 +02:00
Bartłomiej Dach	407db7ff9d	Replace old mod select overlay with new design	2022-05-05 22:16:54 +02:00
Dean Herbert	5029710de7	Merge branch 'master' into distance-snapping-test	2022-05-05 22:00:40 +09:00
Bartłomiej Dach	a859ca0b89	Merge branch 'master' into playlist-keyboard-traversal	2022-05-05 14:45:58 +02:00
Salman Ahmed	8501a41619	Bring back separate bool properties as non-cascading	2022-05-05 14:37:38 +03:00
Bartłomiej Dach	a9eae3a544	Merge branch 'master' into snapping-tidy-distance	2022-05-05 13:15:24 +02:00
Dan Balasescu	39d10487b9	Merge branch 'master' into snapping-tidy-distance	2022-05-05 19:55:55 +09:00
Salman Ahmed	542bb54ba0	Merge branch 'master' into beatmap-selection-keybinding	2022-05-05 13:44:08 +03:00
Dean Herbert	e83604a1fc	Merge branch 'master' into cache-at-interface	2022-05-05 18:54:24 +09:00
Dean Herbert	b9d8b7e413	Fix end time extent not being accounted for in new snap implementation	2022-05-05 18:49:12 +09:00
Dean Herbert	b2e9be70a5	Rewrite CircularDistanceSnapGrid snapping implementation to use snap provider	2022-05-05 17:52:36 +09:00
Dean Herbert	4c884aea5d	Fix CircularDistanceSnapGrid returning an incorrect time value when distance spacing is not 1.0	2022-05-05 17:09:14 +09:00
Dean Herbert	786c7f14d3	Expose DistanceSpacingMultiplier to distance	2022-05-05 17:08:53 +09:00
Dean Herbert	de9b3d33eb	Rename misleading DistanceSpacing variable	2022-05-05 17:08:09 +09:00
Dean Herbert	4226583afd	Merge branch 'cache-at-interface'	2022-05-05 16:52:03 +09:00
Dean Herbert	19cf9dc20b	Merge branch 'snapping-tidy-distance'	2022-05-05 16:51:32 +09:00
Dean Herbert	1c6a233cc0	Move snap provider caching to interfaces	2022-05-05 16:44:37 +09:00
Dean Herbert	b411b59006	Move IPlacementHandler caching to interface	2022-05-05 16:43:02 +09:00
Dean Herbert	977e6d8a80	Add xmldoc for IDistanceSnapProvider and related properties	2022-05-05 16:25:45 +09:00
Salman Ahmed	ac6342ff8d	Add workaround for item scrolling issue	2022-05-05 10:16:16 +03:00
Dean Herbert	f6fc926f1a	Add xmldoc and rename methods in IPositionSnapProvider for legibility	2022-05-05 15:58:21 +09:00
Salman Ahmed	f28978b856	Handle against playlists which disallow selection ... `SelectedItem.Disabled` is also not checked against in the select-via-click flow inside `DrawableRoomPlaylistItem` (only `AllowSelection` is checked).	2022-05-05 05:48:35 +03:00
Salman Ahmed	464b3af5f3	Rename local correctly	2022-05-05 05:42:20 +03:00
Salman Ahmed	20e277d2e5	Apply proposed naming changes	2022-05-04 17:12:17 +03:00
Salman Ahmed	e9ecf26b6a	Merge branch 'master' into multiplayer-disable-adaptive-speed	2022-05-04 17:12:03 +03:00
Salman Ahmed	e294069e2f	Merge branch 'master' into beatmap-selection-keybinding	2022-05-04 16:48:49 +03:00
Salman Ahmed	9416346c94	Globalise beatmap selection key bindings as "group" selection	2022-05-04 16:46:32 +03:00
Bartłomiej Dach	e6fdef2d7a	Fix test failures due to selection/item collection desyncs	2022-05-04 13:51:47 +02:00
Bartłomiej Dach	0405c1c34a	Ensure selected playlist item is always scrolled into view	2022-05-04 13:15:26 +02:00
Dean Herbert	5f11ff564b	Merge branch 'master' into mod-overlay/test-coverage-parity	2022-05-04 19:40:56 +09:00
Bartłomiej Dach	3b04daddaa	Fix self-reference in region name	2022-05-04 12:36:43 +02:00
Dean Herbert	df1f4aecdc	Add support for traversing playlist items using next/previous bindings ... Addresses https://github.com/ppy/osu/discussions/18061.	2022-05-04 19:09:44 +09:00
Dean Herbert	df530cb5ab	Add highlighting to the position snap grid edges in addition to centre lines	2022-05-04 13:49:04 +09:00
Dean Herbert	0bb90c7b07	Fix gridline centering and ensure lines are always rendered using a fixed screen-space width	2022-05-04 13:41:55 +09:00
Salman Ahmed	d52a1a5d23	Add key binding for beatmap selection in song select	2022-05-04 03:52:10 +03:00
Bartłomiej Dach	e3641213e1	Always hide unimplemented mods on mod select screen	2022-05-03 21:45:40 +02:00
Dean Herbert	2896612c5c	Make exiting multiplayer a dangerous operation, requiring hold	2022-05-03 16:06:04 +09:00
Dean Herbert	04fb0f5e63	Merge pull request #18063 from GSculerlor/split-searchbox ... Split `SearchTextBox` implementation for reusability	2022-05-03 14:12:44 +09:00
Huo Yaoyuan	5513710b2e	Fix IDE0055	2022-05-03 13:09:19 +08:00
Huo Yaoyuan	7cf4dabe29	Fix IDE0005 and IDE0034	2022-05-03 13:09:19 +08:00
Dean Herbert	faeefc5e18	Merge pull request #16576 from frenzibyte/osu-distance-spacing ... Add "distance spacing" support in editor for osu! ruleset	2022-05-03 12:15:18 +09:00
Ganendra Afrasya	81be69e72e	Update search textbox implementation to use BasicSearchTextBox instead	2022-05-03 06:18:42 +07:00
Dean Herbert	4442ed89b5	Merge pull request #17586 from Joehuu/move-difficulty-graph-toggle ... Move difficulty graph toggle to individual skin settings	2022-05-03 00:59:02 +09:00
Bartłomiej Dach	2b4a49e17f	Merge branch 'master' into move-difficulty-graph-toggle	2022-05-02 16:38:25 +02:00
Dean Herbert	c4c62ff4e7	Fix countdown sounds playing every minute, rather than only on the last minute	2022-05-02 22:46:14 +09:00
Salman Ahmed	18852b2509	Fix footer random button autosizing to text length	2022-05-02 15:36:22 +03:00
Dean Herbert	5c04ab18ec	Merge pull request #18011 from frenzibyte/rewind-shift-click ... Allow rewinding random in song select with "Shift + Left Click"	2022-04-29 23:10:29 +09:00
Salman Ahmed	856ca96b66	Allow right-clicking to rewind on random button	2022-04-29 10:12:24 +03:00
Salman Ahmed	a9d67d3e92	Change random button text when holding shift key	2022-04-29 10:10:21 +03:00
Dean Herbert	1f1845d69b	Merge branch 'master' into multiplayer-force-start-2	2022-04-29 14:45:40 +09:00
Salman Ahmed	173a6188eb	Add back float cast to distance spacing computation	2022-04-29 08:41:37 +03:00
Salman Ahmed	fef94d49f4	Revert "Convert data type of DistanceSpacing to float" ... This reverts commit 7aaa88cac2.	2022-04-29 08:02:07 +03:00
Salman Ahmed	7e3d1511c6	Hide "Rank Achieved" sorting mode until it's supported	2022-04-29 07:47:10 +03:00
Dean Herbert	c4495dafb6	Merge branch 'master' into move-difficulty-graph-toggle	2022-04-29 13:44:47 +09:00
Dan Balasescu	22e9620211	Don't block clicks when dragging osu! logo	2022-04-29 12:09:11 +09:00
Dean Herbert	6ccbdc85a3	Improve setting description text ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-04-29 11:56:46 +09:00
Salman Ahmed	fa5c05120c	Allow rewinding random in song select with Shift + Left Click	2022-04-28 20:06:27 +03:00
Dean Herbert	32ad216669	Allow dragging the osu! logo ... Logic borrowed from `NowPlayingOverlay`.	2022-04-28 22:58:34 +09:00
Dan Balasescu	1d8ac6917d	Send Loaded state from PlayerLoader on update thread	2022-04-28 20:10:47 +09:00
Salman Ahmed	691bec6f16	Use LocalisableString.Interpolate instead of invalid TranslatableStrings	2022-04-28 11:38:40 +03:00
Salman Ahmed	abb88b0907	Move distance spacing application to DistanceSnapGrid	2022-04-28 10:54:38 +03:00
Salman Ahmed	7aaa88cac2	Convert data type of DistanceSpacing to float	2022-04-28 10:24:36 +03:00
Dean Herbert	3c45746ba1	Add back schedule for safety	2022-04-28 14:29:57 +09:00
Dean Herbert	7c1b0b41ff	Fix migration not working correctly when applying on a default skin	2022-04-28 14:19:24 +09:00
Salman Ahmed	2e8372fe90	Minor cleanup ... Just from reading diff.	2022-04-28 07:14:43 +03:00
Salman Ahmed	59cf3ff50f	Move distancing methods from IPositionSnapProvider to IDistanceSnapProvider	2022-04-28 05:48:45 +03:00
Dean Herbert	7a23363d74	Add migration of song progress setting from config to component	2022-04-27 18:10:58 +09:00
Dean Herbert	e6bb5e84ec	Merge branch 'master' into move-difficulty-graph-toggle	2022-04-27 17:22:25 +09:00
Salman Ahmed	e646233722	Use correct translation for "Accuracy" label in break overlay	2022-04-26 19:16:36 +03:00
Dan Balasescu	9911584fe1	Merge pull request #17977 from peppy/show-during-gameplay-improvement ... Change conditions for HUD being shown to include pause/fail states	2022-04-26 12:55:31 +09:00
Dean Herbert	8ab3636f87	Change conditions for HUD being shown to include pause/fail states ... As proposed in https://github.com/ppy/osu/discussions/17975. Feels pretty good to me, and probably how it should have been implemented from the start.	2022-04-26 12:09:21 +09:00
Salman Ahmed	f958010d29	Fix AccuracyCircle storing accuracy values in float	2022-04-26 04:52:48 +03:00
Dean Herbert	07462384e8	Merge pull request #17930 from peppy/fix-song-select-music-control ... Fix nested song select in first-run dialog fiddling with global audio	2022-04-24 19:18:27 +09:00
Dean Herbert	c5e8f1d4ab	Merge pull request #17958 from peppy/fix-hide-case ... Remove localisation of "hide" string to fix incorrect case	2022-04-24 17:38:49 +09:00
Dean Herbert	999b4505d1	Remove localisation of "hide" string to fix incorrect case	2022-04-24 16:37:11 +09:00
Salman Ahmed	70a93c0e7e	Move DistanceSpacingMultiplier bindable to its own IDistanceSnapProvider interface	2022-04-24 08:33:00 +03:00
Salman Ahmed	4f8f27a58b	Merge branch 'master' into osu-distance-spacing	2022-04-24 05:23:30 +03:00
Susko3	e89441951c	Allow any key to trigger the initial osu! cookie	2022-04-23 18:33:43 +02:00
Dan Balasescu	b293d3923c	Merge branch 'master' into multiplayer-force-start-2	2022-04-23 01:03:55 +09:00
Dean Herbert	bcdd1fb183	Fix nested song select in first-run dialog fiddling with global audio	2022-04-22 18:37:40 +09:00
Bartłomiej Dach	8c6864727e	Merge branch 'master' into first-run-setup	2022-04-21 22:14:57 +02:00
Dean Herbert	832d37b2c2	Update screen transition events to use new event args	2022-04-22 00:52:44 +09:00
Dan Balasescu	ef1955d8ab	Make buttons only respond to MatchStartCountdown	2022-04-21 23:14:37 +09:00
Dan Balasescu	41355384bd	Add support for gameplay abort/force start	2022-04-21 23:14:37 +09:00
Dan Balasescu	08d250fe58	Rename MatchStarted() -> GameplayStarted()	2022-04-21 22:39:24 +09:00
Dan Balasescu	8c3b541312	Add state for when user is ready for gameplay	2022-04-21 22:35:52 +09:00
Dean Herbert	7d8cf1bbb6	Merge branch 'master' into first-run-setup	2022-04-21 15:49:39 +09:00
Dean Herbert	5c0e5eb6f4	Merge pull request #17899 from Joehuu/localise-most-strings ... Use existing web localisation for most hardcoded strings	2022-04-21 14:48:12 +09:00
Dean Herbert	848366416e	Revert string type changes in MetadataLineInfo	2022-04-21 14:10:58 +09:00
Joseph Madamba	5e5c8e78a6	Use existing web localisation for most hardcoded strings	2022-04-20 16:31:11 -07:00
Dean Herbert	4466e15bfc	Rename AllowConfiguration to AllowCustomisation and simplify drawable addition	2022-04-20 23:17:29 +09:00
Dean Herbert	b722ff8dc5	Merge branch 'master' into mod-overlay/extension-points	2022-04-20 23:17:04 +09:00
Dean Herbert	d46329f55a	Remove unused dependency	2022-04-20 12:51:55 +09:00
chickensalt	f5863c2030	remove unused import	2022-04-20 13:40:02 +10:00
chickensalt	4f80651606	implement 2a3a0c1 for playlists as well	2022-04-20 10:33:06 +10:00
chickensalt	2a3a0c1cd3	remove notification on trying to multi when logged out ... fixes #17877	2022-04-19 18:44:20 +10:00
Dean Herbert	17eaa44af1	Ensure notifications don't interrupt the first run setup process	2022-04-19 17:40:35 +09:00
Dean Herbert	c4bade0995	Expose MainMenu buttons	2022-04-19 16:36:39 +09:00
Salman Ahmed	94335c2938	Update further usages to cache/resolve via interface	2022-04-19 00:18:10 +03:00
Dan Balasescu	bb8b94f8ad	Merge branch 'master' into i-notification-overlay	2022-04-19 06:03:56 +09:00
Dan Balasescu	94e892df1c	Merge pull request #17862 from peppy/i-dialog-overlay ... Split out `IDialogOverlay` to allow for easier testing	2022-04-19 05:24:05 +09:00
Dean Herbert	043599081b	Split out INotificationOverlay to allow for easier testing	2022-04-18 20:14:01 +09:00
Dean Herbert	e315313266	Split out IDialogOverlay to allow for easier testing	2022-04-18 18:36:26 +09:00
Dean Herbert	2202863e1a	Split out IPerformFromScreenRunner to allow for easier testing	2022-04-18 17:49:28 +09:00
Dean Herbert	90093c1d9d	Combine private skin variable into exposed one	2022-04-18 13:32:37 +09:00
Salman Ahmed	2cb217e06c	Fix editor legacy beatmap skins not receiving transformer	2022-04-18 06:59:58 +03:00
Salman Ahmed	338d94626e	Expose underlying skin of EditorBeatmapSkin	2022-04-18 06:44:39 +03:00
Bartłomiej Dach	7eebc20124	Add replacements for mod overlays used by game	2022-04-17 23:28:51 +02:00
Jamie Taylor	ef5ed262ca	Add pitch randomisation to the OsuLogo hover sample	2022-04-15 20:38:47 +09:00
Jamie Taylor	8e6c015856	Use a fallback sample when a MainMenuButton doesn't provide a click sample	2022-04-15 20:38:30 +09:00
Dan Balasescu	2abdbe53e7	Cleanup whitespace	2022-04-14 18:55:12 +09:00
Dan Balasescu	9de4d416e2	Merge branch 'master' into fix-spectator-seeks	2022-04-14 18:54:52 +09:00
Dan Balasescu	494955aff1	Resolve inspection issues	2022-04-14 13:11:11 +09:00
Dean Herbert	fbf0e5a45c	Remove startFromSkipTarget parameter and update usages that required said behaviour	2022-04-13 14:25:43 +09:00
Dean Herbert	a59c6013c7	Rename latestGameplayStartTime to skipTargetTime	2022-04-13 14:03:52 +09:00
Dean Herbert	d4286255a0	Expose and set GameplayStartTime directly, rather than via Reset parameter	2022-04-13 13:58:44 +09:00
Dean Herbert	017f3852c8	Replace incorrectly chosen ??= with ??	2022-04-13 13:32:36 +09:00
Dean Herbert	9c68b3edc5	Merge branch 'master' into fix-spectator-seeks	2022-04-13 12:33:41 +09:00
Dean Herbert	282fccb4c8	Fix typo in xmldoc ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-04-13 12:24:47 +09:00
Dean Herbert	8b1cee75fa	Use BindableLong instead of BindableInt for user score tracking	2022-04-12 14:13:07 +09:00
Dean Herbert	0ba95a4483	Ensure all users are shown on leaderboard (even when API lookup fails)	2022-04-12 11:54:30 +09:00
Dean Herbert	ebee9e6888	Fix MultiplayerGameplayLeaderboard not immediately updating totals on scoring mode change	2022-04-12 11:27:27 +09:00
Dan Balasescu	37976c569a	Merge pull request #17762 from peppy/fix-unobserved-exceptions ... Avoid throwing unobserved exception when `PerformancePointsCounter` requests timed attributes	2022-04-11 14:50:12 +09:00
Dean Herbert	cb6e557212	Fix MasterGameplayClockContainer having incorrect rate-based offsets immediately after LoadComplete ... I've attempted to explain why this is required using inline comments. There's also further conversation at https://github.com/ppy/osu/pull/17302#issuecomment-1091850927.	2022-04-11 14:11:26 +09:00
Dean Herbert	808f0ecb74	Ensure running state is updated before performing Seek in GameplayClockContainer.Reset	2022-04-11 14:10:50 +09:00
Dean Herbert	2b74dbca28	Fix potential crash in DrawableRoom due to lack of null check on post-lookup beatmap	2022-04-11 13:44:34 +09:00
Dean Herbert	19b655d75b	Avoid throwing unobserved exception when PerformancePointsCounter requests timed attributes	2022-04-11 13:30:21 +09:00
Dean Herbert	24c2d465a9	Move null assert in MultiplayerPlayer on to update thread	2022-04-08 14:53:14 +09:00
Dean Herbert	eb0653fa7b	Merge pull request #17698 from Joehuu/fix-replay-button-local-being-disabled ... Fix replay button being disabled when available locally but not online	2022-04-07 14:18:02 +09:00
Joseph Madamba	358931842f	Move enabled setting to each case	2022-04-06 21:22:56 -07:00
Jamie Taylor	8a73831115	Add MP lobby 'warning' SFX for the final seconds of countdown	2022-04-07 13:12:33 +09:00
Joseph Madamba	4432a93d09	Fix replay button being disabled when available locally but not online	2022-04-06 20:43:56 -07:00
Dan Balasescu	4b3569ea79	Merge pull request #17576 from peppy/fix-multiplayer-unobserved ... Centralise exception handling of `MultiplayerClient` calls	2022-04-07 09:09:55 +09:00
Dean Herbert	c42ef43faa	Ensure intro beatmap has protected flag set ... In cases this isn't set, the beatmap has likely entered a bad state. Closes https://github.com/ppy/osu/issues/17659.	2022-04-06 16:46:53 +09:00
Dean Herbert	2b8a5833dd	Fix back-to-front conditional check	2022-04-06 15:13:02 +09:00
Dean Herbert	a3695c7e97	Merge branch 'master' into fix-spectator-seeks	2022-04-06 12:58:43 +09:00
Dean Herbert	c540810943	Merge branch 'master' into fix-multiplayer-unobserved	2022-04-06 11:33:10 +09:00
Dean Herbert	01da3924cc	Simplify IsCurrentScreen check to only apply to relevant call	2022-04-06 11:32:35 +09:00
Dan Balasescu	c973d33bfd	Merge pull request #17604 from nekodex/mp-countdown-sfx ... Add SFX for multiplayer lobby countdown timer	2022-04-05 16:40:26 +09:00
Dean Herbert	3d8ae0465f	Reword comment slightly	2022-04-05 15:51:04 +09:00
Dean Herbert	8e543204cd	Remove debounce logic (not required after switching to Update clock time)	2022-04-05 15:49:47 +09:00
Dean Herbert	5f415cbe53	Full potential null reference and add better commentary on countdown scheduling	2022-04-05 15:48:18 +09:00
Dean Herbert	d0f83885ce	Appease the CI	2022-04-05 13:20:34 +09:00
Dean Herbert	31bf0c4a9b	Disable "final" sample in countdown for the time being	2022-04-05 13:16:06 +09:00
Dean Herbert	174dc1641c	Fix multiple issues with timekeeping ... - Using realtime (`DateTimeOffset.Now`) meant that values would be changing in the same frame, causing misfirings or incorrect displays - No debounce on sample playback meant that scheduling edge cases could potentially cause samples to be played more than once.	2022-04-05 11:49:58 +09:00
Dean Herbert	3ca365ad7f	Merge branch 'master' into dangerous-delete-actions	2022-04-05 10:55:01 +09:00
Ame	32c89f8643	Handle repeated OnPressed() on FooterButton (without FooterButtonRandom)	2022-04-05 00:33:41 +02:00
CenTdemeern1	9a07a95d39	Make several delete confirmation buttons dangerous buttons ... Includes: - Mass deletion - Beatmap deletion - Local score deletion	2022-04-04 19:22:53 +02:00
Dean Herbert	64ba24c4f7	Merge branch 'master' into mp-countdown-sfx	2022-04-05 01:04:57 +09:00
Dan Balasescu	cbcbcd1a4a	Merge pull request #17643 from peppy/stable-countdown ... Stabilise countdown updates to be based on when whole seconds change	2022-04-04 22:19:06 +09:00
Dean Herbert	0abebe4d23	Stabilise countdown updates to be based on when whole seconds change	2022-04-04 14:41:32 +09:00
Jamie Taylor	0f4b75ab15	Add multiplayer lobby countdown SFX	2022-04-01 21:33:57 +09:00
Dan Balasescu	16d4544ff9	Prevent reloads when playlist item order changes	2022-04-01 17:06:37 +09:00
Dean Herbert	01829cf2d8	Move SkinnableInfo error handling to lower level ... Handling was recently added to handle the usage in `Skin.GetDrawableCompoent`, but it turns out this is also required for `DrawableExtensions.ApplySkinnableInfo` which can throw in a similar fashion. Found while working on sprite support for the editor, where this becomes an actual issue (ie. switching to a branch where the new sprite support is not present can cause unexpected crashes).	2022-04-01 14:30:04 +09:00
Joseph Madamba	d0873d67e1	Move difficulty graph toggle to individual skin settings	2022-03-31 18:56:57 -07:00
Bartłomiej Dach	e14d5b8adb	Remove unused using directives	2022-03-31 21:20:30 +02:00
CenTdemeern1	a6875383fc	Rebind SaveState() to bpmTextEntry	2022-03-31 21:06:05 +02:00
CenTdemeern1	52d723aaa6	Remove BPM slider	2022-03-31 20:11:07 +02:00
Dean Herbert	0b6db31511	Guard other multiplayer client calls with exception handling	2022-03-31 19:45:38 +09:00
Dean Herbert	e0c125a628	Replace existing usage with helper method	2022-03-31 19:27:45 +09:00
Dean Herbert	ef5e37c47a	Fix multiplayer sounds playing too much after gameplay ... Regressed in https://github.com/ppy/osu/pull/15936. Closes #17295.	2022-03-31 16:18:28 +09:00
Dean Herbert	ad14b7cac5	Merge pull request #17565 from smoogipoo/fix-gameplay-leaderboard-allocations ... Remove ScoreInfo allocations in multiplayer leaderboard	2022-03-31 15:48:14 +09:00
Joseph Madamba	36c02573a8	Fix osu! logo being clicked when exiting via cmd-q on initial state	2022-03-30 21:26:30 -07:00
Salman Ahmed	9c19ae1df8	Remove no longer necessary ruleset field	2022-03-31 06:40:38 +03:00
Dan Balasescu	6e94a9780b	Remove ScoreInfo allocations in multi leaderboard	2022-03-31 12:23:00 +09:00
Bartłomiej Dach	436dec68c9	Use provided extension method instead of reimplementing locally	2022-03-30 22:04:54 +02:00
Bartłomiej Dach	9621a7f9cb	Merge branch 'master' into fix-autoplay-mod-user-id	2022-03-30 21:41:45 +02:00
Salman Ahmed	0f144f6801	Merge branch 'master' into fix-countdown-refresh	2022-03-30 16:26:12 +03:00
Dan Balasescu	b60c253831	Merge pull request #17556 from peppy/fix-multiplayer-unobserved ... Fix `MultiplayerMatchSongSelect` potentially attempting to exit when not the current screen	2022-03-30 21:10:11 +09:00
Dean Herbert	671386ba6c	Fix MultiplayerMatchSongSelect potentially attempting to exit when not the current screen	2022-03-30 20:36:12 +09:00
Dan Balasescu	cb1ee05539	Merge pull request #17555 from peppy/remove-source-from-wedge ... Remove song source from main wedge display	2022-03-30 18:57:25 +09:00
Dean Herbert	f9f6248101	Simplify string bindings	2022-03-30 17:59:45 +09:00
Dean Herbert	bc0b982102	Remove song source from main wedge display ... This was definitely added at someone's request, since I wouldn't have put it here. But it's displayed below in the details section already and also not displayed in the updated "wedge" in the new design. See https://github.com/ppy/osu/discussions/17537 for discussion.	2022-03-30 17:59:40 +09:00
Dean Herbert	99f141d396	Merge pull request #17546 from frenzibyte/autoplay-cinema-incompatibility ... Mark both "Autoplay" and "Cinema" mods as mutually exclusive	2022-03-30 16:41:07 +09:00
Sebastian Krajewski	cb62d3d4b9	Remove skin dependency as component is reinitialized on skin change	2022-03-30 01:09:05 +02:00
Sebastian Krajewski	7582c943a4	Use In/Out instead of {In/Out}Quad	2022-03-30 00:48:59 +02:00
Salman Ahmed	cef1b93471	Improve behaviour of "Autoplay" shortcut during gameplay start ... This also opens up the way to adding shortcut for "Cinema" mod (Ctrl+Shift+Enter), but will leave adding that until there's a demand for it.	2022-03-30 01:07:48 +03:00
Dean Herbert	ea9495eb74	Update all existing calls to extension method with correct fallback handling	2022-03-29 16:51:30 +09:00
Dean Herbert	8948bcce19	Restructure transforms slightly	2022-03-29 13:18:31 +09:00
Dan Balasescu	375a752e24	Fix countdown timer not refreshing on new countdown	2022-03-29 11:27:26 +09:00
Sebastian Krajewski	caf641e1ab	Remove redundant ClearTransforms	2022-03-28 23:50:35 +02:00
Sebastian Krajewski	981ef735cf	Always start small pop out from its initial size	2022-03-28 19:57:59 +02:00
Sebastian Krajewski	e3289bb080	Don't scale big pop out as much	2022-03-28 19:33:00 +02:00
Sebastian Krajewski	265b2111ef	Remove comment	2022-03-28 18:08:51 +02:00
Sebastian Krajewski	001a98e069	Fix LegacyComboCounter not unsubscribing from skin	2022-03-28 18:08:35 +02:00
Sebastian Krajewski	05a978ce8c	Update LegacyComboCounter layout and scaling	2022-03-28 16:36:37 +02:00
Dean Herbert	01980effe2	Merge pull request #17449 from smoogipoo/countdown-button-ux ... Improve multiplayer ready button/countdown button UX	2022-03-27 13:42:10 +09:00
Dean Herbert	1edf1d8f40	Merge pull request #17464 from smoogipoo/fix-logo-thread-safety ... Fix LogoVisualisation draw thread safety	2022-03-27 09:50:42 +09:00
Bartłomiej Dach	f400249f32	Fix multiplayer match settings overlay dropdown Z-ordering	2022-03-26 18:28:38 +01:00
Dan Balasescu	6384531317	Fix LogoVisualisation draw thread safety	2022-03-27 01:43:47 +09:00
Dean Herbert	5725cc36ff	Add animation to countdown button when countdown is active	2022-03-26 14:29:53 +09:00
Dean Herbert	03f24c8b58	Merge branch 'master' into countdown-button-ux	2022-03-26 10:34:51 +09:00
Dean Herbert	a30d6256f4	Merge pull request #17447 from peppy/countdown-button-icon ... Use more appropriate icon on countdown button (and give tooltip)	2022-03-26 10:20:07 +09:00
Dean Herbert	f92a31cd39	Merge pull request #17402 from smoogipoo/multiplayer-auto-countdown ... Add multiplayer auto-start countdown timer	2022-03-25 20:31:14 +09:00
Dan Balasescu	11ee78b395	Merge branch 'master' into countdown-button-icon	2022-03-25 19:40:25 +09:00
Dan Balasescu	3986dfd160	Merge pull request #17444 from peppy/fix-countdown-counting ... Update multiplayer countdown button text more often	2022-03-25 19:40:04 +09:00
Dean Herbert	f989158a31	Add back playlist availability control (because it's hooked up half way?)	2022-03-25 19:20:16 +09:00
Dan Balasescu	9963efce51	Improve ready/countdown button UX	2022-03-25 18:40:32 +09:00
Dean Herbert	320110f179	Remove "room visibility" from playlists settings to match	2022-03-25 18:37:46 +09:00
Dean Herbert	b13408aed0	Add back "room visibility" control commented out for now	2022-03-25 18:37:20 +09:00
Dan Balasescu	3ad092d808	Always show the countdown button when host	2022-03-25 18:29:00 +09:00
Dean Herbert	463091bde2	Use more appropriate icon on countdown button (and give tooltip)	2022-03-25 18:25:48 +09:00
Dean Herbert	aa9e642e40	Merge branch 'master' into pin-multiplayer-host	2022-03-25 16:49:35 +09:00
Dean Herbert	4a30b6ef56	Update multiplayer countdown button text more often ... At once a second, it regularly skips whole seconds (because scheduler isn't guaranteed to run exactly as often as specified). 10 updates a second seems amicable and less noticeable to my eye.	2022-03-25 16:25:20 +09:00
Dean Herbert	b1f0f89fdd	Simplify AutoStart and Host checks	2022-03-25 15:41:01 +09:00
Dean Herbert	416b57ea69	Fix main menu buttons handling keys when super (cmd) is held	2022-03-25 15:13:22 +09:00
Dean Herbert	816fcae3a1	Rename Button to MainMenuButton to differentiate better	2022-03-25 15:12:39 +09:00
Bartłomiej Dach	878e8d21a3	Remove assertion to fix "expression always true" inspection	2022-03-24 21:51:10 +01:00
Dan Balasescu	1abf3f7bf4	Fix cancel tooltip showing for autostart countdowns	2022-03-24 20:25:17 +09:00
Dan Balasescu	40eca0fbe2	Merge branch 'master' into multiplayer-auto-countdown	2022-03-24 18:11:51 +09:00
Dean Herbert	2d58feebb1	Guard against potential null CurrentItem in ParticipantPanel	2022-03-24 17:54:21 +09:00
Dean Herbert	e3f8bc0588	Revert Availability to private	2022-03-24 17:15:17 +09:00
Dan Balasescu	528ffea38d	Fix incorrect event binding	2022-03-24 17:11:08 +09:00
Dean Herbert	8ca9cbc866	Set a more correct initial value for pauseFreqAdjust ... As the `GameplayClock` now starts paused, this value needs to match to ensure things work correctly. For a better explanation of how we got here, see discussion at https://github.com/ppy/osu/pull/17302#discussion_r830017735.	2022-03-24 14:50:00 +09:00
Dan Balasescu	96a447f68b	Rename Multiplayer prefix to button classes	2022-03-24 14:28:38 +09:00
Dan Balasescu	90c7945bca	Re-remove PopoverButton class with better test fix	2022-03-24 14:26:31 +09:00
Dean Herbert	6f529cf7a4	Merge branch 'master' into fix-spectator-seeks	2022-03-24 14:24:20 +09:00
Dan Balasescu	547418e47e	Revert "Remove PopoverButton class" ... This reverts commit 6b712be97d.	2022-03-24 11:15:51 +09:00
Dan Balasescu	34a367b369	Merge branch 'master' into multiplayer-countdown-timers-2	2022-03-23 15:40:50 +09:00
Dan Balasescu	a83a90e675	Rename countdown Delay -> Duration	2022-03-23 15:21:16 +09:00
Dan Balasescu	f7c0047206	Send time remaining in countdowns instead	2022-03-23 15:19:43 +09:00
Dan Balasescu	d4ad4ac9db	Limit countdown updates to once per second	2022-03-23 10:50:05 +09:00
Dan Balasescu	6b712be97d	Remove PopoverButton class	2022-03-23 10:40:38 +09:00
Dan Balasescu	9138aaf780	Split MultiplayerReadyButton	2022-03-23 10:38:56 +09:00
Dan Balasescu	1ffa1e1219	Merge pull request #17400 from nagilson/screen-mod-retention ... Fix mods from single player carrying over to multiplayer	2022-03-23 08:36:15 +09:00
Dan Balasescu	8591630e5c	Merge branch 'master' into editor-exit-harsh-blocking	2022-03-23 07:06:25 +09:00
Bartłomiej Dach	f3aad77239	Remove unused local variable	2022-03-22 22:00:24 +01:00
Bartłomiej Dach	a38bafab91	Remove unused using directive	2022-03-22 22:00:05 +01:00
Bartłomiej Dach	8647bebdca	Merge branch 'master' into hold-to-discard-changes	2022-03-22 20:37:43 +01:00
Dean Herbert	ff8352b749	Merge branch 'master' into screen-mod-retention	2022-03-22 17:27:26 +09:00
Dean Herbert	61ddf1e6cf	Disallow exiting the editor without saving (unless explicitly confirming)	2022-03-22 15:42:56 +09:00
Dean Herbert	f95bd89166	Revert editor exit behaviour to exit without changes for now	2022-03-22 14:46:57 +09:00
Dan Balasescu	23be0f1be9	Remove availability picker for now	2022-03-22 14:34:06 +09:00
Dan Balasescu	d0fee53e1f	Implement auto countdown timers ... Change to using TimeSpan	2022-03-22 14:34:06 +09:00
Dan Balasescu	4630aa15cc	Apply refactorings according to reviews	2022-03-22 12:54:19 +09:00
NAGILSON	17b639b404	Implement suggested change to wipe mods on multiplayer screen	2022-03-21 22:42:17 -04:00
Dan Balasescu	aea03ca21d	Merge pull request #17359 from frenzibyte/fix-score-panel-max-combo ... Improve method of retrieving beatmap maximum combo for results score panels	2022-03-22 06:28:30 +09:00
Dean Herbert	d811a70f4b	Change button types on editor exit dialog to match purpose ... Addresses https://github.com/ppy/osu/discussions/17363.	2022-03-21 16:06:59 +09:00
Salman Ahmed	5c1e11c153	Merge branch 'master' into queue-list-counter	2022-03-21 05:01:09 +03:00
Salman Ahmed	2a78042038	GetBeatmapMaximumComboAsync -> GetMaximumAchievableComboAsync	2022-03-20 16:18:53 +03:00
Salman Ahmed	add9f3ec91	Rename multiplayer mod usages to make more sense	2022-03-20 13:12:24 +03:00
Salman Ahmed	70e943fbcc	ModUsage.Solo -> ModUsage.User	2022-03-20 06:36:51 +03:00
Salman Ahmed	e1d22e58bf	Simplify queue count text logic	2022-03-20 06:25:14 +03:00
Salman Ahmed	7529d6fc00	Bind queue items during playlist initialization ... Along with where the other bindables are bound together (only bind, not listening).	2022-03-20 06:23:44 +03:00
Salman Ahmed	eca7975864	Compute the beatmap maximum achievable combo instead of Beatmap.MaxCombo	2022-03-20 05:38:14 +03:00
hwabis	ef823d58a7	address frenzibyte review (refactor bindable flow, clean up CI stuff)	2022-03-19 13:05:35 -04:00
Salman Ahmed	9afe82a0d5	Fix potentially null drawable call to SetLayoutPosition	2022-03-19 14:54:58 +03:00
Bartłomiej Dach	b7d5a628bc	Merge branch 'master' into fix-spectator-seeks-hot	2022-03-19 11:39:01 +01:00
Dean Herbert	a903aee17e	Use schedule to workaround seek issue instead	2022-03-19 18:00:14 +09:00
Dean Herbert	cf2212e794	Revert "Fix spectator not starting from correct seek point (hotfix)" ... This reverts commit 2b59eff465.	2022-03-19 17:20:54 +09:00
Dean Herbert	2b59eff465	Fix spectator not starting from correct seek point (hotfix)	2022-03-19 15:14:25 +09:00
Dean Herbert	dae5569e36	Use nullable in PlayerLoader	2022-03-19 15:06:22 +09:00
Dean Herbert	da76358ee0	Expose the loading player in PlayerLoader	2022-03-19 15:06:22 +09:00
Salman Ahmed	b99541fb5e	Revert "Swap placements of "hold for menu" and key counter" ... This reverts commit 5bcb7c167c.	2022-03-19 08:08:07 +03:00
hwabis	5d16519a82	make code prettier	2022-03-18 23:41:55 -04:00
Salman Ahmed	ad9b119e3d	Reduce "hold for menu" radius of visibility	2022-03-19 05:04:54 +03:00
Salman Ahmed	486be83177	Calculate position adjustment distance in local parent space	2022-03-19 05:04:13 +03:00
Salman Ahmed	5bcb7c167c	Swap placements of "hold for menu" and key counter	2022-03-19 05:02:22 +03:00
Salman Ahmed	0adad3a599	Handle potential null room hosts	2022-03-19 04:01:35 +03:00
hwabis	5a5629eb5a	(works now) use BindValueChanged to set the Queue text	2022-03-18 20:47:45 -04:00
hwabis	5e5fbc496e	(still not working) try bindables instead of int	2022-03-18 20:32:37 -04:00
hwabis	d9b2a29c6d	(not working yet) add MultiplayerPlaylistTabControl, "Queue ({count})"	2022-03-18 20:02:26 -04:00
hwabis	faa36c78e5	put count and tabs into new fillflowcontainer	2022-03-18 12:55:00 -04:00
Dean Herbert	fc75aa0807	Merge pull request #17324 from frenzibyte/score-panel-max-combo ... Display beatmap maximum combo next to score combo in results panel	2022-03-18 22:59:38 +09:00
Salman Ahmed	fa8eb1feec	Update score panel to check for all combo-breaking statistics	2022-03-18 15:23:14 +03:00
Dan Balasescu	04f4e81852	Rename start countdown request	2022-03-18 21:05:19 +09:00
Dean Herbert	ed90dc6d6b	Fix centering of labels using Height instead of location to better handle rotations	2022-03-18 20:17:04 +09:00
Dean Herbert	bd488d139d	Better centre text labels for hit error meter	2022-03-18 20:11:05 +09:00