10029 Commits

Author	SHA1	Message	Date
Dan Balasescu	cbee72897a	Merge pull request #21654 from Susko3/use-localisable-strings-for-dates-and-times ... Use `LocalisableString`s for date and time formats	2022-12-16 16:17:14 +09:00
Dean Herbert	232f590ba3	Merge pull request #21628 from peppy/go-hard-file-writes ... Use hard links on windows when importing beatmaps from a legacy osu! install	2022-12-16 14:52:57 +09:00
Susko3	0f34d908c7	Use LocalisableStrings for date and time formats	2022-12-16 00:05:47 +01:00
Dean Herbert	9813bc9544	Reword disclaimer and fix translation keys	2022-12-15 22:46:31 +09:00
cdwcgt	6ef5b2733f	Export instead of ExportCurrentSkin	2022-12-15 21:41:15 +09:00
Dean Herbert	d2b98b803d	Turn on featured artist filter by default and add disclaimer when toggling for the first time	2022-12-15 18:42:47 +09:00
Dean Herbert	0763b86236	Add more padding around text in dialog popups	2022-12-15 17:32:27 +09:00
Dean Herbert	78bc94d3cb	Set featured artists filter to enabled by default	2022-12-15 16:57:39 +09:00
Dean Herbert	a7f3e13946	Fix MultipleSelectionFilter not correctly handling initial selection	2022-12-15 16:56:09 +09:00
Dean Herbert	f4316a9827	Fix incorrect grammar in hard link explanation text ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-12-14 11:30:01 +09:00
Dean Herbert	b8904fe747	Move ImportParameters to better home	2022-12-13 21:41:26 +09:00
Dean Herbert	cb16d62700	Hook up ImportParameter flow with IModelImporter caller methods	2022-12-13 21:29:32 +09:00
Andrei Zavatski	15bd82add8	Fix DrawableUsername being affected	2022-12-12 18:24:49 +03:00
Dean Herbert	02b3bbf0d3	Merge pull request #21616 from Joehuu/changelog-build-masking ... Fix changelog single build dates disappearing before being off screen	2022-12-12 18:28:48 +09:00
Dean Herbert	05b5949810	Use explicit casts	2022-12-12 17:38:39 +09:00
Dean Herbert	e2d8909e73	Add link to change folder location if it isn't on the same drive as import path	2022-12-12 13:44:09 +09:00
Dean Herbert	726943cb14	Add information attempting to explain hard links to the end user	2022-12-12 13:44:09 +09:00
Dean Herbert	d8de99bbe4	Check for hard link support in first run overlay	2022-12-12 13:44:09 +09:00
Dean Herbert	731184eb39	Revert "Merge pull request #21614 from EVAST9919/button-fix" ... This reverts commit 4bd196684f, reversing changes made to a1d22ef77a.	2022-12-12 13:43:01 +09:00
Joseph Madamba	e76c56b03b	Fix changelog single build dates disappearing before being off screen	2022-12-11 20:10:06 -08:00
Andrei Zavatski	1332568796	Fix SettingsButton receiving input at padded area	2022-12-12 03:10:13 +03:00
cdwcgt	e02b8cb199	Group export methods into their respective managers	2022-12-11 18:30:24 +09:00
cdwcgt	a1fc33668c	Merge branch 'master' into export	2022-12-09 23:40:26 +09:00
Bartłomiej Dach	5857471915	Merge branch 'master' into nominated-ranked-beatmaps	2022-12-07 23:54:25 +01:00
Dean Herbert	62b0436bcf	Reverse depth of profile sections to allow for overflowing expanded beatmap cards ... Closes #21554.	2022-12-07 16:38:17 +09:00
Joseph Madamba	56e94e49a3	Display nominated ranked beatmaps in user profile	2022-12-06 23:36:11 -08:00
Dean Herbert	49f5ac57b8	Fix first run beatmap screen button colours looking incorrect with new triangle effect ... Addresses #21500.	2022-12-03 18:48:54 +09:00
ansel	1763618488	Fix spinner presense check & field click	2022-11-30 13:58:03 +03:00
ansel	43628903a7	Make spinner bigger	2022-11-30 13:57:09 +03:00
ansel	1cc7ffce39	Keep button's text	2022-11-30 13:40:47 +03:00
ansel	bedc771e99	Remove useless check	2022-11-30 13:32:01 +03:00
ansel	a8422961dc	Rename button spinner prop again	2022-11-30 13:30:57 +03:00
ansel	5ea824534b	Use default button	2022-11-30 13:25:59 +03:00
ansel	642e0ac718	Increase footer height to look better with default buttons	2022-11-30 13:25:18 +03:00
ansel	956acbc86f	Use fixed width	2022-11-30 13:11:54 +03:00
Dean Herbert	4a747182b4	Merge branch 'master' into comment-editor-1	2022-11-30 17:22:59 +09:00
Dean Herbert	f7b7b58718	Adjust colour and tween to feel better	2022-11-30 16:20:01 +09:00
Dean Herbert	24ee363563	Only hover when hovering actual text	2022-11-30 16:18:36 +09:00
Dean Herbert	80b0e4a99d	Rename Colour to avoid conflict with Drawable.Colour	2022-11-30 16:15:50 +09:00
Dean Herbert	7fca5ee28d	Move DrawableUsername into own file ... It's too large at this point to be a nested class.	2022-11-30 16:15:50 +09:00
Dean Herbert	6524914dbd	Merge branch 'master' into chat-profile-highlight-v2	2022-11-30 16:00:52 +09:00
ansel	e30d97c94e	Comments	2022-11-29 14:39:59 +03:00
ansel	84aaf5fedf	Change ways to access submit button state	2022-11-29 14:37:35 +03:00
ansel	6c126f5223	Remove useless local actions on click	2022-11-29 14:25:51 +03:00
Dean Herbert	61c702c02e	Add new IDependencyInjectionCandidate interface to non-drawable cached classes	2022-11-29 14:45:26 +09:00
Bartłomiej Dach	8f78d6179b	Fix multiple issues with settings items unhiding on search	2022-11-29 14:41:49 +09:00
Bartłomiej Dach	24deb5f5f4	Remove all unnecessary usage of IHasFilterableChildren	2022-11-29 14:40:52 +09:00
ansel	16962d9a57	Localize deleted string	2022-11-29 07:02:02 +03:00
ansel	a4819e5c9c	Localize actions	2022-11-29 07:01:52 +03:00
ansel	472d9274b6	Reorder members	2022-11-29 06:23:25 +03:00
ansel	af0ee9dbd6	Make spinner a little bigger	2022-11-29 06:19:54 +03:00
ansel	894fb98fa2	Rebase CommitButton to RoundedButton	2022-11-29 06:17:02 +03:00
ansel	a874345da0	Rebase CancelButton to RoundedButton	2022-11-29 05:46:30 +03:00
ansel	d20dc3668e	Enable nullability	2022-11-29 05:17:44 +03:00
ansel	8b033bf9f7	Allow localisable strings	2022-11-29 05:13:54 +03:00
Alden Wu	8ec4dd046e	Fix InspectCode errors	2022-11-28 18:06:44 -08:00
Alden Wu	0cb7c94c21	Merge branch 'master' of https://github.com/ppy/osu into chat-profile-highlight-v2	2022-11-28 17:59:15 -08:00
Alden Wu	c2d8ffc225	Refactor ChatLine username drawable creation	2022-11-28 17:50:12 -08:00
Bartłomiej Dach	894ef15e79	Merge branch 'master' into update-framework	2022-11-26 16:19:36 +01:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Dean Herbert	2b2beadd06	Merge branch 'master' into update-framework	2022-11-25 01:00:08 +09:00
Dean Herbert	53b03df93d	Combine TriangleButton and RoundedButton classes	2022-11-24 16:26:57 +09:00
Dean Herbert	bea2acc60e	Remove local specifications of triangle colouring	2022-11-24 16:18:15 +09:00
Dean Herbert	40f706155f	Update RoundedButton to have new triangles design	2022-11-24 16:18:15 +09:00
Bartłomiej Dach	2f67199b1c	Merge branch 'master' into fix-missing-day-separator	2022-11-23 18:40:44 +01:00
Dean Herbert	b381b4fd2d	Merge branch 'master' into update-framework	2022-11-24 01:27:58 +09:00
Dean Herbert	5467097387	Fix adjacent day separators potentially being left behind after pending message resolution	2022-11-23 18:49:51 +09:00
Dean Herbert	172e798847	Merge pull request #21228 from Terochi/recent-messages-implementation ... Add ability to view chat send history in input box	2022-11-23 14:58:42 +09:00
Bartłomiej Dach	76bb529cfa	Add test for local echo adding day separator	2022-11-22 16:46:21 +01:00
Alden Wu	a2b505f4c0	Use a direct Lighten instead of >1f Color4 values	2022-11-22 00:31:22 -08:00
Alden Wu	4084a2b066	Highlight ChatLine username on hover	2022-11-21 18:57:59 -08:00
Bartłomiej Dach	8dbe31a172	Merge branch 'master' into higher-aspect-ratio-max	2022-11-21 19:51:39 +01:00
cdwcgt	c509c5be40	impossible null	2022-11-21 19:45:30 +09:00
cdwcgt	e37d30a373	refactor based on reviews ... removed LegacyExportManager Separated the method of CreateZip method and the default export method	2022-11-21 18:58:01 +09:00
Dean Herbert	981264b011	Avoid crashing when a system audio device provides a null name	2022-11-21 14:51:41 +09:00
Dean Herbert	e53b4321ff	Ensure two day separators are not added in a row	2022-11-21 14:01:10 +09:00
Dean Herbert	fa7b45dfb1	Fix chat day separator not being added on pending message resolution ... Closes #21316.	2022-11-21 13:52:14 +09:00
Dean Herbert	c7ae837687	Increase maximum aspect ratio for tablet settings to 23:9 / 2.55	2022-11-21 12:45:54 +09:00
Dean Herbert	92aea22cd3	Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup ... Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-21 12:16:56 +09:00
vegguid	a431b793b9	Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-20 23:18:19 +01:00
Bartłomiej Dach	0c671a2a82	Merge branch 'master' into fix-tablet-aspect-ratio-values	2022-11-19 14:32:24 +01:00
cdwcgt	4e457871f3	impossible null and remove storage	2022-11-19 01:03:22 +09:00
cdwcgt	4b29941b47	add LegacyExportManager	2022-11-18 20:00:00 +09:00
Dean Herbert	06ce8130c2	Apply changes in line with framework NRT updates	2022-11-18 18:13:15 +09:00
Dan Balasescu	e4fc14faee	Merge pull request #21270 from peppy/auto-advance-bindings ... Auto-advance binding for ruleset key bindings	2022-11-18 16:19:54 +09:00
Dean Herbert	e658efbefa	Fix being able to bind two non-modifier keys to the same binding	2022-11-18 15:34:41 +09:00
Dan Balasescu	1b1fed723d	Merge pull request #21269 from peppy/fix-key-bindings-keyword ... Move "keybindings" keyword to correct section	2022-11-18 14:05:08 +09:00
Dan Balasescu	551192b413	Refactor a bit for readability	2022-11-18 13:55:37 +09:00
Dan Balasescu	a776622ce0	Merge pull request #21284 from peppy/now-playing-overlay-texture-reduction ... Fix `NowPlayingOverlay` loading background texture too early (and permanently)	2022-11-18 12:09:16 +09:00
Dan Balasescu	baa4fd56e2	Merge pull request #21279 from peppy/news-load-unload ... Fix news post images never unloading from memory after first display	2022-11-18 11:56:13 +09:00
Dan Balasescu	13fe0d3491	Merge pull request #21278 from peppy/overlay-header-texture-reduction ... Avoid loading overlay headers until first open	2022-11-18 11:53:46 +09:00
Dean Herbert	b53f9baf6a	Fix NowPlayingOverlay loading background texture too early (and permanently)	2022-11-18 11:21:12 +09:00
Dean Herbert	93c2280754	Fix supporter filters text not being set correctly	2022-11-18 10:35:05 +09:00
Dean Herbert	b37e9c0266	Fix news post images never unloading from memory after first display	2022-11-18 00:01:53 +09:00
Dean Herbert	73e4827d36	Avoid loading overlay headers until first open ... Also switches them to use non-atlased target as they won't benefit much from atlasing.	2022-11-17 23:55:43 +09:00
Dean Herbert	63c1855511	Avoid loading beatmap listing placeholders until required	2022-11-17 23:42:21 +09:00
Dean Herbert	a3e8cc1663	Mark beatmap listing placeholder textures as large	2022-11-17 23:41:35 +09:00
Terochi	3d4962e181	Added functioning tests.	2022-11-17 13:07:06 +01:00
Terochi	6d83af01e2	Moved and renamed MessageHistoryTextBox.cs for better fit.	2022-11-17 13:07:06 +01:00
Dragon	b9590320b7	Moved implementation to ChatRecentTextBox.cs and derived ChatTextBox.cs and StandAloneChatDisplay.cs from it.	2022-11-17 13:07:06 +01:00
Dragon	a1af663682	Implemented previous messages lookup in the ChatTextBox.cs	2022-11-17 13:07:06 +01:00
Dean Herbert	d1b2116400	Auto-advance binding for ruleset key bindings	2022-11-17 15:23:20 +09:00
Dean Herbert	bd2e0dc82b	Move "keybindings" keyword to correct section ... Without this, things like tablet settings would show when searching for bindings, even though these settings have nothing to do with key bindings.	2022-11-17 15:09:42 +09:00
cdwcgt	e1a21e0cf9	create a task to export to avoid block main thread ... Code quality and remove some #nullable disable	2022-11-17 01:08:06 +09:00
Dean Herbert	bb762d8131	Fix "reset to full area" button not always working correctly	2022-11-16 15:45:26 +09:00
Samaoo	4ff17cb4bd	remove unused using directive	2022-11-12 08:52:33 +01:00
Samaoo	7a860fb460	address reviews	2022-11-12 08:49:03 +01:00
Samaoo	268011be9e	use MathF	2022-11-11 17:56:50 +01:00
Samaoo	173f557376	fix tablet aspect ratio values	2022-11-11 17:14:34 +01:00
Dan Balasescu	db25e9e9c8	Merge branch 'master' into combo-colour-brightness-limit	2022-11-11 15:31:28 +09:00
Susko3	5b1e39abd5	Fix parsing of Language when using default system locale	2022-11-10 22:56:24 +01:00
Samaoo	be81c658af	move tablet area calculations to functions	2022-11-09 20:14:01 +01:00
Samaoo	533a2db5ea	fix inaccurate tablet area dimensions when applying aspect ratio	2022-11-09 18:48:47 +01:00
Joseph Madamba	76df61504f	Remove unnecessary timestamp update ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2022-11-06 19:45:59 -08:00
Joseph Madamba	61ec0ba566	Make chat line timestamp adjust to 24-hour time setting	2022-11-06 19:28:01 -08:00
Joseph Madamba	b977fc8181	Use autosize instead of max width on fixed width timestamps	2022-11-06 19:28:01 -08:00
Dean Herbert	ee68f33e3c	Merge pull request #21109 from frenzibyte/fix-beatmap-duplicating-again ... Fix beatmap cards still potentially showing twice in listing	2022-11-06 18:46:31 +09:00
Bartłomiej Dach	84179fb087	Merge branch 'master' into combo-colour-brightness-limit	2022-11-05 16:48:56 +01:00
Salman Ahmed	ee6f036c44	Add note about using ExceptBy once it's available	2022-11-04 19:35:24 +03:00
Salman Ahmed	ce5aacb760	Filter out duplicated cards using custom equality comparer instead	2022-11-04 19:27:35 +03:00
Joseph Madamba	e11d44d14f	Add url clicking support to profile badges	2022-11-03 18:12:32 -07:00
Dean Herbert	f6c376c090	Minor refactoring	2022-11-03 20:29:27 +09:00
Dean Herbert	1edde8f73c	Merge branch 'master' into disabled-button-sfx	2022-11-03 20:27:41 +09:00
Jamie Taylor	59bbd9c460	Fix some components using wrong sample set	2022-11-03 17:47:49 +09:00
Jamie Taylor	f1c17129eb	Add support for 'disabled' sample variation to HoverClickSounds	2022-11-03 17:47:49 +09:00
Dean Herbert	56ef519cc2	Move PopoverContainer into OnlineOverlay to ensure correct colours	2022-11-03 15:43:06 +09:00
Dean Herbert	e6c45b8ab5	Merge branch 'master' into comment-report	2022-11-03 15:35:42 +09:00
Dean Herbert	3ec9686e58	Fix test failures and rename configuration value to match better	2022-11-02 18:15:18 +09:00
Dan Balasescu	db34f238c0	Fix inverted condition	2022-11-02 15:47:30 +09:00
Dan Balasescu	e5f53b1ad8	Use Interlocked.Exhange() instead ... Increment isn't correct since it returns the post-incremented value. It also always increments.	2022-11-02 15:18:48 +09:00
Dean Herbert	e761c0395d	Fix multiple notifications arriving for imports in edge cases	2022-11-02 14:47:56 +09:00
Dean Herbert	50b6fe4acb	Localise new label	2022-11-02 14:01:03 +09:00
Dean Herbert	99ba7c29dd	Change range to 0-100% and rename to "normalisation"	2022-11-02 13:47:11 +09:00
Dean Herbert	2f3c80f884	Remove toggle and change method of application to blend with original colour	2022-11-02 13:08:29 +09:00
Dean Herbert	27af91003b	Merge branch 'master' into combo-colour-brightness-limit	2022-11-01 17:50:26 +09:00
Joseph Madamba	d56786b5ff	Fix toolbar visual bug when toggling clock displays	2022-10-29 15:25:16 -07:00
ansel	9df96aab38	Remove local popover containers	2022-10-28 22:17:45 +03:00
Dean Herbert	f46a9d683a	Fix null reference in headless tests	2022-10-28 18:07:25 +09:00
Dean Herbert	f9d2c30c3e	Add user toggle for application of safe areas	2022-10-28 14:05:45 +09:00
Dean Herbert	14c7cbde38	Fix toggle mute (and volume meter traversal) handling repeat key presses ... Closes #20953.	2022-10-27 11:41:00 +09:00
Joseph Madamba	8505848b1a	Scroll beatmap listing to top when searching via tags/source	2022-10-25 18:06:49 -07:00
Salman Ahmed	b0a4cd4f30	Inline content creation in base add method	2022-10-22 03:43:14 +03:00
Salman Ahmed	6c82bc36ed	Encapsulate report logic inside button implementation ... Avoids complicating the `DrawableComment` class, and allows for isolated testability.	2022-10-22 02:48:27 +03:00
Salman Ahmed	9b5e35d599	Remove dependency on DrawableComment from report popover and simplify logic ... Allows for testing the button and popover in isolation.	2022-10-22 02:47:33 +03:00
Salman Ahmed	081cf1cc47	Adjust comment report popover design	2022-10-22 02:45:31 +03:00
ansel	15aeb4a137	Display text in buttons flow instead of toast	2022-10-21 17:25:41 +03:00
Dean Herbert	447d420c99	Fix adjusting volume via settings playing tick samples twice	2022-10-21 21:03:39 +09:00
Jamie Taylor	7b1edff2b3	Add unique hover/select samples to settings sidebar buttons	2022-10-21 18:06:38 +09:00
ansel	81bdf716ef	Change test	2022-10-20 19:56:00 +03:00
ansel	0ef903230c	Make report button a separate component	2022-10-20 18:47:42 +03:00
ansel	da4f04ace7	Make dropdown not resize	2022-10-20 18:22:55 +03:00
ansel	635900085c	Disable button when there is no text	2022-10-20 18:12:20 +03:00
ansel	ed39481932	Use another string for title	2022-10-20 18:11:35 +03:00
ansel	57320074a0	Fix accidental breakage of changelog layout	2022-10-20 01:24:36 +03:00
Dean Herbert	6b42f1931a	Remove autosize easing in SettingsToolboxGroup ... It just feels like unnecessary motion.	2022-10-18 15:01:26 +09:00
ansel	3258a41ca3	Merge branch 'comment-report' of https://github.com/Feodor0090/osu into comment-report	2022-10-17 20:41:46 +03:00
ansel	cd77ae062e	Localize the button	2022-10-17 20:41:23 +03:00
ansel	797acf334f	Show username in popup	2022-10-17 20:41:13 +03:00
Feodor0090	6efe7b5334	Merge branch 'master' into comment-report	2022-10-17 16:08:13 +03:00
ansel	ceb4d624b5	Delete wip form	2022-10-17 13:43:35 +03:00
ansel	ffa22d8a68	Update popover not to use labelled drawables	2022-10-17 13:42:17 +03:00
ansel	d7e5bcbd3c	Add popover containers to overlays	2022-10-17 13:41:46 +03:00
ansel	7ed26369a3	Make a new report form, closer to web	2022-10-17 12:41:57 +03:00
Bartłomiej Dach	d0a495717e	Merge branch 'master' into comment-copy-link	2022-10-16 19:56:06 +02:00
ansel	4a8d976cb4	Use api's endpoint	2022-10-16 20:20:34 +03:00
ansel	ba595ab8fa	Display toast instead of notification	2022-10-16 19:57:21 +03:00
ansel	9822a092c4	Add localization for enum	2022-10-16 19:50:55 +03:00
Aki	91358f4a6a	Implement tablet button bindings	2022-10-15 15:16:14 +08:00
Feodor0090	fb046e31c1	Merge branch 'master' into comment-report	2022-10-14 16:57:23 +03:00
ansel	dc0aa2295a	Add test	2022-10-14 16:51:48 +03:00
ansel	3e9fd4c08c	Implement reporting flow	2022-10-14 16:26:25 +03:00
ansel	c65a8a83f3	Add basic UI for reporting	2022-10-14 15:52:09 +03:00
Dean Herbert	32c3e35762	Change background colour to a lighter tint to avoid clash with slider bars	2022-10-14 19:38:27 +09:00
Dean Herbert	2404bb42b9	Use 10% alpha rather than 0% when toolbox is not hovered	2022-10-14 19:33:49 +09:00
Dan Balasescu	8a88339e78	Allow combo colour normalisation to be disabled	2022-10-14 14:37:24 +09:00
ansel	8a47628fe1	Use spacer drawable instead of spacing on links container	2022-10-14 00:04:13 +03:00
ansel	295e6f5a68	Move toast to it's namespace	2022-10-13 23:57:25 +03:00
ansel	34ff072a9b	Change text	2022-10-13 22:47:48 +03:00
ansel	a0cca391f6	Add copy link button to comments	2022-10-13 22:18:26 +03:00
Dean Herbert	a93c350ca8	Start settings panels without background visible	2022-10-13 17:11:56 +09:00
Dean Herbert	6608ada925	Fix test failures due to missing colour provider dependency	2022-10-13 17:05:11 +09:00
Dean Herbert	0f4a2a6059	Improve feel of settings toolbox group	2022-10-13 16:36:19 +09:00
Dan Balasescu	4149235e63	Limit minimum brightness of combo colours	2022-10-13 14:05:33 +09:00
Dean Herbert	e43c8e84b0	Use Show instead of Alpha=1	2022-10-12 15:48:42 +09:00
Dean Herbert	47fe4eb0bd	Merge branch 'master' into comment-deletion	2022-10-12 15:48:26 +09:00
Dean Herbert	195ece02c6	Merge branch 'master' into update-displays-in-setting	2022-10-12 14:37:49 +09:00
Daniel Källberg	63e651130a	Grouped localisation strings	2022-10-11 10:59:07 +02:00
Daniel Källberg	9c611019b3	Toolbar localisation	2022-10-11 09:30:32 +02:00
Dean Herbert	6f6290a21a	Use async flow for storing key binding changes to realm	2022-10-11 15:37:22 +09:00
Salman Ahmed	a9aba74351	Add markdown country flag support	2022-10-08 21:50:25 +03:00
ansel	c384093802	Update main test and add failure scenario test	2022-10-08 18:53:41 +03:00
ansel	b697200460	Properly modify comment visual state on deletion	2022-10-08 18:41:08 +03:00
ansel	4e7c30504f	Schedule action buttons visibility changes	2022-10-08 17:15:10 +03:00
ansel	abf56c27a1	Do not requere dialog overlay	2022-10-08 17:11:09 +03:00
Joseph Madamba	b27e70ca47	Fix language settings dropdown not updating when changing language in first run setup	2022-10-06 21:11:00 -07:00
Dean Herbert	e9ab465da6	Merge branch 'master' into localisation-settings	2022-10-06 13:22:08 +09:00
Dean Herbert	4f084664ac	Merge branch 'master' into comment-deletion	2022-10-05 14:34:50 +09:00
Dean Herbert	75b9bf2cf9	Merge branch 'master' into intel-exclusive-warning	2022-10-04 19:02:01 +09:00
Susko3	efc9bed4f0	Use IWindow.DisplaysChanged to update displays	2022-10-03 23:52:04 +02:00
Susko3	31fefc1ee2	Add nullable annotation to LayoutSettings	2022-10-03 23:23:02 +02:00
Susko3	e98b4b4fbd	Make updateDisplayModeDropdowns regular method	2022-10-03 23:14:21 +02:00
ansel	85adfc2df7	Fix DI type	2022-09-28 18:26:36 +03:00
ansel	636befb499	Add visual feedback for deleting process	2022-09-28 17:49:37 +03:00
ansel	ae0d62838b	Move API and DO to fields	2022-09-27 22:46:23 +03:00
ansel	58d9509ce6	Apply NRT to Comment	2022-09-27 22:45:05 +03:00
ansel	60ee813e45	Implement delete button	2022-09-27 18:33:16 +03:00
ansel	31a7ba3f91	Add delete button	2022-09-27 18:23:15 +03:00
Dan Balasescu	ec30050f2c	Merge pull request #20502 from peppy/forward-toasts-on-gameplay ... Flush toast tray on entering gameplay	2022-09-27 18:35:54 +09:00
Dan Balasescu	5a28174448	Merge pull request #20488 from nanashi-1/toggle-score-overlay ... Add toggle for solo gameplay leaderboard	2022-09-27 18:09:55 +09:00
Dean Herbert	461ba64bfa	Flush toast tray on entering a no-notification section	2022-09-27 17:32:53 +09:00
Dean Herbert	c61f5403ab	Increase delay back slightly on notifications posting after disabled period	2022-09-27 17:32:30 +09:00
Dean Herbert	bac3108aea	Remove unnecessary keywords	2022-09-27 14:29:59 +09:00
Dan Balasescu	aa3956cfbb	Merge pull request #20495 from Feodor0090/playlist-overflow-fix ... Fix playlist overlay overflowing at high UI scales	2022-09-27 13:53:14 +09:00
nanashi-1	dc051a8b79	add gameplay leaderboard config	2022-09-26 20:08:58 +08:00
Dan Balasescu	e5894ccd6f	Merge pull request #20478 from peppy/fix-progress-notification-fling ... Fix progress notifications being able to be flung (and cancelled)	2022-09-26 18:21:12 +09:00
Dan Balasescu	f2eed881bd	Merge pull request #20480 from peppy/fix-drawable-mutation-tablet-settings ... Fix potential crash from incorrect drawable mutation in tablet settings display	2022-09-26 18:16:52 +09:00
Dan Balasescu	525de8c140	Merge pull request #20479 from peppy/fix-drawable-mutation-misc ... Fix potential crash on game exit due to incorrect scheduling of realm change handler	2022-09-26 18:02:28 +09:00
Dean Herbert	4e9b25d8b0	Move MusicController binds to LoadComplete for added thread safety	2022-09-26 15:42:37 +09:00
Dean Herbert	43c16cb613	Fix potential crash from incorrect drawable mutation in tablet settings display	2022-09-26 15:10:02 +09:00
Dean Herbert	4bd96108c0	Fix crash on game exit due to incorrect scheduling of realm change handler	2022-09-26 14:45:17 +09:00
Dean Herbert	b6dd8168d2	Fix progress notifications being able to be flung	2022-09-26 14:33:12 +09:00
ansel	5d0b2d34c9	Make playlist to always be in screen bounds	2022-09-24 23:35:06 +03:00
ansel	6c8e587344	Move margin value to constant	2022-09-24 21:52:16 +03:00
Dean Herbert	8a7526aaa3	Merge pull request #20344 from frenzibyte/better-tablet-notifications ... Improve tablet error/warning notifications messaging	2022-09-22 22:45:27 +09:00
Dan Balasescu	6a0047b7a2	Update location of FullscreenCapability bindable	2022-09-22 21:01:23 +09:00
Dan Balasescu	70bab81282	Merge pull request #20377 from peppy/argon-skin ... Add new default "argon" skin	2022-09-22 14:50:43 +09:00
Dan Balasescu	2b8b138079	Add "keybindings" search term to settings	2022-09-21 18:46:28 +09:00
Dean Herbert	4492a26b59	Merge branch 'master' into argon-skin	2022-09-21 13:00:16 +09:00
Dan Balasescu	8bf196d561	Merge pull request #20354 from peppy/default-skin-refactor ... Rename default skin to make way for new version	2022-09-21 11:48:38 +09:00
Salman Ahmed	dcfb6a2f06	Fix progress notifications no longer blocking close on click	2022-09-21 00:15:50 +03:00
アズタケ	d22d009fb3	fix review points. items not included in this localization were reverted.	2022-09-20 14:02:11 +09:00
Dean Herbert	bd28c6f96d	Merge branch 'master' into localisation-settings	2022-09-19 23:37:26 +09:00
Dean Herbert	0f7b38f4c3	Add new default skin "argon"	2022-09-19 23:16:46 +09:00
Salman Ahmed	a413c7a3e6	Merge branch 'master' into fix-notification-count	2022-09-19 02:08:20 +03:00
Dean Herbert	41e69fbca6	Remove "default" prefix from naming	2022-09-18 00:15:26 +09:00
Dean Herbert	1c4e02fae8	Explicitly order default skins in dropdown to get correct order	2022-09-18 00:12:43 +09:00
Salman Ahmed	877165eb98	Allow specifying icon colour on simple notifications	2022-09-16 16:21:43 +03:00
アズタケ	81d582c051	fix review points and fine tuning	2022-09-16 21:08:25 +09:00
Dan Balasescu	e95983cdb4	Merge branch 'master' into fix-skin-flow	2022-09-16 20:15:51 +09:00
アズタケ	c0e2ba419e	Localize non-localizable setting items	2022-09-16 18:31:02 +09:00
Dean Herbert	38d8d457d9	Add back second completion post attempt for case when notification overlay isn't loaded yet	2022-09-16 17:54:44 +09:00
Dean Herbert	0d24fda4b9	Fire Notification.Closed immediately to ensure off-screen notifications are closed	2022-09-16 16:36:56 +09:00
Dan Balasescu	f86bbaae30	Merge branch 'master' into mods-effect-displays	2022-09-15 21:17:58 +09:00
Salman Ahmed	efebe55d22	Display certain sort criterias based on selected category and query	2022-09-15 04:30:09 +03:00
Salman Ahmed	de7dd29d79	Add "Nominations" and "Updated" sorting criteria in beatmap listing	2022-09-15 03:57:05 +03:00
Joseph Madamba	85e3a681b1	Fix notification overlay toast tray background absorbing input from behind	2022-09-13 21:07:30 -07:00
Dan Balasescu	ef6d60ffe9	Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards ... Fix beatmap listing potentially showing duplicate beatmap cards	2022-09-14 10:25:24 +09:00
Salman Ahmed	04dbb6fc1b	Add inline comment	2022-09-14 00:49:02 +03:00
Dean Herbert	d368f37c3a	Remove redundant second Current set operation	2022-09-13 13:50:59 +09:00
Salman Ahmed	07f577a0c6	Fix beatmap listing potentially showing duplicate beatmap cards	2022-09-13 01:39:21 +03:00
ansel	8cbc0502ae	Inline CalculateEffect	2022-09-12 15:51:18 +03:00
Dean Herbert	88107108ee	Add ability to flick notifications to the right to store for later	2022-09-12 20:20:57 +09:00
Dean Herbert	802c5629c0	Merge branch 'master' into notification-fling	2022-09-12 20:09:21 +09:00
Dean Herbert	f31deaef7c	Simplify skin bindable flow ... Now, nothing touches the configuration apart from `OsuGame`, making everything else flow better and avoid weird cyclic set bugs. Closes https://github.com/ppy/osu/issues/20234.	2022-09-12 19:51:50 +09:00
Dan Balasescu	5bd0be14ed	Merge pull request #20259 from peppy/fix-changelog-crash ... Fix potential crash when opening changelog overlay if entry has no URL	2022-09-12 19:47:21 +09:00
Dean Herbert	cb6d02ec3a	Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset ... Remove the nullable disable annotation in the ruleset class	2022-09-12 19:07:23 +09:00
Dean Herbert	d92e000fe6	Fix flinging a notification not correctly running Close	2022-09-12 19:00:03 +09:00
Dean Herbert	4ee3e8f087	Don't play fling animation when activating a notification	2022-09-12 18:57:18 +09:00
Dean Herbert	58c1ea0321	Fix potential crash when opening changelog overlay if entry has no URL	2022-09-12 17:51:15 +09:00
Dean Herbert	d561fcb126	Don't trigger fling animation when Close is triggered by non-user action	2022-09-12 16:54:25 +09:00
Dean Herbert	5a02e1e713	Use padding instead of FillFlow.Spacing to avoid artifact during animation	2022-09-12 16:46:45 +09:00
Dean Herbert	a506178571	Make bounding box shrink faster to allow for rapid flinging	2022-09-12 16:39:46 +09:00
Dan Balasescu	bcbc867694	Merge branch 'master' into mods-effect-displays	2022-09-12 16:35:28 +09:00
Dean Herbert	931049aec1	Merge branch 'master' into notification-dismiss	2022-09-12 16:27:41 +09:00
Dean Herbert	bd3673baa9	Fix being able to drag after already closing a notification	2022-09-12 16:25:32 +09:00
Dean Herbert	8e6b2796eb	Merge branch 'master' into notification-fling	2022-09-12 16:19:36 +09:00
Dean Herbert	2476cf8fb3	Adjust movement to look less sudden when snapping back to Y=0	2022-09-12 15:37:48 +09:00
Dean Herbert	e06a0f7300	Fix dragged state not being exposed correctly	2022-09-12 15:21:01 +09:00
Dean Herbert	92beb6cbe7	Hide notification read light when in a toast state ... Also adds test coverage of read state and light.	2022-09-12 15:17:45 +09:00
Dean Herbert	60b0b909a5	Move update icon to background to avoid colour collission with progress spinner	2022-09-12 14:58:46 +09:00
Dean Herbert	9ef23c79ce	Disallow forwarding during a drag operation	2022-09-11 22:05:44 +09:00
Dean Herbert	a56cadcf90	Ensure drag position is reset when transferred to tray	2022-09-11 22:03:29 +09:00
Dean Herbert	b5a2f7003e	Disallow flinging when not in toast state	2022-09-11 21:47:45 +09:00
Dean Herbert	d6f90e3b9f	Add basic fling-to-dismiss support	2022-09-11 21:32:22 +09:00
ansel	324a3723a5	Rewrite DMD	2022-09-10 23:23:04 +03:00
ansel	3f93ec8538	Expose counter to inheritors	2022-09-10 23:20:28 +03:00
ansel	667854b034	Make effect display have a built-in counter	2022-09-10 23:18:48 +03:00
Dean Herbert	a9094c6b03	Add test coverage of clicking close button to dismiss	2022-09-10 15:18:32 +09:00
Dean Herbert	efe3b1aa7b	Allow dismissing notifications without performing action using middle / right click	2022-09-10 15:10:37 +09:00
ansel	b056cac10a	Remove generic and add default implementation for CalculateEffect	2022-09-10 08:34:29 +03:00
andy840119	1398a7e11e	Property should accept the nullable state.	2022-09-10 10:46:40 +08:00
Salman Ahmed	5e4e3dfc2c	Fix markdown container not rendering certain text correctly	2022-09-10 02:55:20 +03:00
Dean Herbert	6e52dbb266	Update IsDisplayingToasts to check the flow count directly	2022-09-06 17:30:24 +09:00
Dean Herbert	9e3228aa65	Fix completion notification not being posted if completion occurs during NotificationOverlay load	2022-09-06 04:07:49 +09:00
Dean Herbert	510972e3ad	Avoid reference counting by using height calculation for IsPresent instead ... The reference counting was to guarantee performance (zero allocations) when the notification overlay was not required, but adds extra complexity. Instead, the toast tray now uses its ongoing height calculation as a metric for presence.	2022-09-05 19:38:09 +09:00
Dean Herbert	0514c96191	Fix incorrect count tracking when notification is manually disposed	2022-09-05 19:26:40 +09:00
Dean Herbert	229e1a8ef7	Fix notification overlay being present when it doesn't need to	2022-09-05 19:13:58 +09:00
Dean Herbert	f754686521	Remove necessity of AlwaysPresent for ProgressUpdate completion posting	2022-09-05 19:13:58 +09:00
Dean Herbert	0d4ee6bd80	Centralise ability to fetch all toast tray notifications (including animating ones)	2022-09-05 18:42:20 +09:00
Dean Herbert	eca7b8f988	Fix completion notifications not always showing as toasts	2022-09-05 18:39:11 +09:00
Dean Herbert	4fa6707bf0	Set all progress notifications to non-important	2022-09-05 18:29:35 +09:00
Dean Herbert	7eaa4c5ccd	Update new usages of Remove / RemoveInternal	2022-09-01 23:05:34 +09:00
Dean Herbert	6a35b233e5	Merge branch 'master' into remove-dispose-updates	2022-09-01 23:03:19 +09:00
Dan Balasescu	afe2862df4	Merge branch 'master' into toast-notification-tray	2022-08-31 16:07:11 +09:00
Dan Balasescu	ccc08b816c	Merge pull request #20030 from peppy/notification-design-update ... Update notification overlay design	2022-08-31 16:06:59 +09:00
Dean Herbert	8b9ccc66b7	Update ProgressNotification font spec to match other notifications	2022-08-31 12:49:28 +09:00
Dean Herbert	85442fe032	Adjust dismiss button background colour to avoid conflict with background	2022-08-31 12:48:30 +09:00
Dean Herbert	7c72c6b43f	Fix unread count potentially missing notifications in a transforming state	2022-08-31 12:46:43 +09:00
Dean Herbert	0558dae917	Mark toasts as read when closing the overlay for added safety ... I'm not sure how the read status will play out going forward so I'm just adding this to keep things conforming for now.	2022-08-31 12:46:04 +09:00
Dean Herbert	9eb615f942	Fix remaining test failures by strengthening PlayerLoader tests ... - Click using `TriggerClick` as notifications move around quite a bit. - Ensure any notifications from a previous test method are cleaned up.	2022-08-31 01:40:30 +09:00
Dean Herbert	31a9980686	Update remaining test expectations with new behaviour	2022-08-31 00:57:30 +09:00
Dean Herbert	a62ba9e0d9	Remove notification blocking behaviour of first run setup	2022-08-31 00:57:18 +09:00
Dean Herbert	ed11b1ba6f	Improve forwarding flow to not use piling delegates	2022-08-31 00:40:53 +09:00
Dean Herbert	224ab29ef4	Don't dismiss toasts while hovered (and adjust timings slightly)	2022-08-30 21:19:51 +09:00
Dean Herbert	403fc18976	Fix notification completion events not being run when overlay not visible	2022-08-30 21:13:43 +09:00
Dean Herbert	a7110666a0	Play notification appear sample immediately	2022-08-30 21:13:43 +09:00
Dean Herbert	95ce78a50c	Reduce notification post delay now that it's less important	2022-08-30 21:13:43 +09:00
Dean Herbert	b8300ae60a	Add toast notification tray	2022-08-30 21:13:43 +09:00
Dean Herbert	7b006f1f22	Add flash when a new notification is displayed to draw attention	2022-08-30 20:34:27 +09:00
Dean Herbert	60413e3e7b	Enable masking for main content to avoid underlap with close button on word wrap failure.	2022-08-30 19:17:41 +09:00
Dean Herbert	6b71b4656d	Remove ProgressNotification vertical movement and delay	2022-08-30 19:16:59 +09:00
Dean Herbert	d600058c98	Assert non-null in ProfileHeader to appease r#	2022-08-30 18:09:10 +09:00
Dean Herbert	c846bf20a7	Add background hover and adjust remaining metrics	2022-08-30 18:06:48 +09:00
Dean Herbert	bea12ab3c2	Rename NotificationContent to MainContent	2022-08-30 18:06:48 +09:00
Dean Herbert	09aa3e065d	Move colouring to full icon content rather than background	2022-08-30 18:06:48 +09:00
Dean Herbert	0f203531d9	Allow customising the "close" button icon	2022-08-30 18:06:48 +09:00
Dean Herbert	1484ae19f0	Initial design update pass	2022-08-30 18:06:48 +09:00
Dean Herbert	b8fda1a16f	Apply NRT to notification classes ... and tidy things up a bit.	2022-08-30 15:57:10 +09:00
ansel	545e0bbcef	Adjust inheritors and test	2022-08-29 22:49:25 +03:00
ansel	5343c26452	Control colour via Current bindable	2022-08-29 22:48:27 +03:00
ansel	7faeed88b0	Add ability to override width of value area	2022-08-29 22:08:43 +03:00
Dean Herbert	a215d009fe	Update Remove/RemoveRange/RemoveAll calls in line with framework changes	2022-08-29 15:57:40 +09:00
Dan Balasescu	423f6f90f2	Remove async calls from ScoreManager	2022-08-29 15:34:08 +09:00
ansel	039f009562	Inherit difficulty multiplier display from ModsEffectDiplay	2022-08-27 20:26:05 +03:00
ansel	3e828c3416	Move base layout from DifficultyMultiplierDisplay to another class	2022-08-27 20:11:38 +03:00
Dean Herbert	6dc859973b	Merge branch 'master' into fix-playlist-overlay-test-failures	2022-08-26 20:25:53 +09:00
Bartłomiej Dach	968f656585	Merge branch 'master' into copyexternalurl-dialog	2022-08-24 21:21:11 +02:00
Dean Herbert	6a0d23cf96	Nest dialog class and apply NRT	2022-08-24 17:39:22 +09:00
Dean Herbert	9f9deef438	Reword slightly	2022-08-24 17:37:41 +09:00
Andrew Hong	9ee26c575d	Made button blue	2022-08-24 04:04:44 -04:00
Andrew Hong	b24513038c	Add popupdialog button to copy url	2022-08-24 03:35:19 -04:00
Andrew Hong	edd50dc05b	Add profile url context menu to user container	2022-08-24 03:07:03 -04:00
Dean Herbert	c840977acb	Fix filtering potentially not running after new items added	2022-08-23 20:42:20 +09:00
Dean Herbert	058d67f8e8	Merge pull request #19695 from naoei/ruleset-localization ... Change most ruleset-accessible string types to Localisable strings	2022-08-22 16:13:23 +09:00
Dan Balasescu	0815b01b75	Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation ... Fix selecting preset containing Difficulty Adjust automatically opening customisation panel	2022-08-22 15:44:00 +09:00
Dean Herbert	d199b3b100	Update GetVariantName to also support localisation	2022-08-22 14:51:00 +09:00
Dan Balasescu	e1fa959f0b	Fix language change removing mod column bold text	2022-08-22 13:00:47 +09:00
Bartłomiej Dach	aa15e84bea	Adjust rounding in mod select difficulty multiplier to match song select footer ... The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would cause the difficulty multiplier to use a different midpoint rounding strategy than `double.ToString()`, which is the one that the song select footer relies on. For example, a value of 0.015 would be rounded down to 0.01 by `double.ToString()`, but rounded up to 0.02 by `BindableDouble`. Fix the discrepancy by just deleting the `Precision` spec. Since the value of the bindable would go through `ToLocalisableString(@"N2")` anyway, it was redundant as is. Fixes #19889.	2022-08-21 23:15:49 +02:00
Bartłomiej Dach	3d14b14cfe	Use alternative method for checking panel readiness to eliminate bool flag	2022-08-17 21:56:11 +02:00
Bartłomiej Dach	3109066e34	Rename {Requires -> Pending}Configuration	2022-08-16 22:45:24 +02:00
Bartłomiej Dach	6bfdfeb153	Refactor mod panel selection logic to avoid overwriting	2022-08-16 22:41:35 +02:00
Bartłomiej Dach	10daac6752	Only open mod customisation panel on explicit selection of single mod	2022-08-15 20:38:23 +02:00
Bartłomiej Dach	f860bc11ee	Fix several schedule-related issues arising from new column addition	2022-08-15 20:38:16 +02:00
Bartłomiej Dach	5ff2e41a55	Add preset column to mod select test scene	2022-08-15 18:38:37 +02:00
Nao	c940f5abcb	Merge branch 'master' into ruleset-localization	2022-08-14 15:17:44 -04:00
naoei	45e9eda9e7	Localise hit result name	2022-08-14 14:57:02 -04:00
basseX	383afe04f3	Remove not needed override	2022-08-14 15:15:36 +02:00
basseX	932becc4b2	Remove CommentMarkdownTextFlowContainer and rather use base-class OsuMarkdownTextFlowContainer	2022-08-14 10:11:49 +02:00
basseX	b05acb0073	Make CommentMarkdownTextFlowContainer render images	2022-08-13 21:32:24 +02:00
Dean Herbert	b76e5757e1	Fix InSelectedCollection not being applied to newly imported beatmaps	2022-08-12 15:06:34 +09:00
Dean Herbert	5111bad86c	Refactor TestScenePlaylistOverlay to use realm for testing ... Removes the dual-purpose flow which existed only for testing.	2022-08-12 15:06:34 +09:00
Dan Balasescu	1721a91168	Merge pull request #19661 from peppy/overlay-key-binding-organisation ... Reorganise global bindings and split out overlay bindings to make things easier to find	2022-08-10 21:18:28 +09:00
Dan Balasescu	76fea25668	Merge pull request #19646 from its5Q/settings-localisation ... Add missing localisation for settings enums	2022-08-10 18:51:52 +09:00
Dan Balasescu	888c4c8e08	Merge pull request #19662 from peppy/startup-correct-username ... Use a placeholder user with the correct username during login process	2022-08-10 13:09:37 +09:00
its5Q	abca3d1b2a	Prefix common strings for context	2022-08-10 00:35:19 +10:00
Dean Herbert	beb3d41f0c	Fix unsafe usage of APIAccess.LocalUser in BeatmapListingOverlay	2022-08-09 17:11:44 +09:00
Dean Herbert	a71c2bbe28	Split overlay toggles into own section in key bindings ... Things were getting hard to find..	2022-08-09 17:01:38 +09:00
Dean Herbert	32852e5b21	Fix potentially thread-unsafe LocalUser usage	2022-08-09 16:01:04 +09:00
Dean Herbert	5d8bd1de28	Share localised strings with expanded display message	2022-08-09 15:57:16 +09:00
Dean Herbert	3f8cedff3a	Add tooltips showing current connecting status	2022-08-09 15:51:27 +09:00
Dean Herbert	c35b4ef914	Display connecting / failing states on toolbar user display	2022-08-09 15:51:10 +09:00
Bartłomiej Dach	f74fb3491e	Use alternative implementation of preset panel cleanup	2022-08-08 21:08:54 +02:00
Bartłomiej Dach	a0a6e1faee	Fix spurious sample playbacks from already-removed panels	2022-08-08 20:30:55 +02:00
Bartłomiej Dach	f21a51aa24	Simplify mirror copy of task logic in ModColumn	2022-08-08 19:20:50 +02:00
Bartłomiej Dach	00333fb0d2	Change ?? false test to == true for legibility	2022-08-08 19:19:13 +02:00
its5Q	5080d62e77	Add missing localisation for settings enums	2022-08-08 21:51:23 +10:00
Dean Herbert	070d156e89	Simplify task logic in ModPresetColumn	2022-08-08 16:13:52 +09:00
Bartłomiej Dach	7d6efaebbe	Add maintenance settings section for mod presets	2022-08-07 16:20:31 +02:00
Bartłomiej Dach	839409d7ac	Add preset column to solo mod select overlay	2022-08-07 16:20:31 +02:00
Bartłomiej Dach	b318bbd5e6	Allow non-homogenous column types in mod select overlay	2022-08-07 16:20:31 +02:00
Bartłomiej Dach	0287c49ca8	Implement user selection logic for mod presets	2022-08-07 16:20:20 +02:00
Bartłomiej Dach	b1dcd7821c	Automatically toggle preset panels if selected mods match	2022-08-07 15:30:20 +02:00
Dean Herbert	4a95638756	Merge branch 'master' into mod-overlay/delete-preset	2022-08-07 12:34:25 +09:00
Dean Herbert	5946124278	Merge pull request #19612 from bdach/mod-overlay/common-delete-dialog ... Unify implementations of deletion dialogs	2022-08-07 12:18:03 +09:00
Bartłomiej Dach	9b3183b2b4	Implement mod preset deletion flow	2022-08-06 21:58:55 +02:00
Bartłomiej Dach	a0d093be5c	Extract common implementation of delete dialog	2022-08-06 21:04:12 +02:00
Bartłomiej Dach	ab1b38242f	Reorder enum cases to match web order	2022-08-06 18:34:30 +02:00
Bartłomiej Dach	6a9c30c47a	Fix some more wrong icon colours	2022-08-06 18:34:00 +02:00
Bartłomiej Dach	2ba127b6fc	Fix wrong icon for approval event	2022-08-06 18:30:49 +02:00
Bartłomiej Dach	f1e0dd2da3	Match approval type-dependent icon appearance with web	2022-08-06 18:29:24 +02:00
Bartłomiej Dach	f3ecd73e0b	Add references to web source in recent activity icon	2022-08-06 18:23:15 +02:00
LukynkaCZE	3000d9b9c6	Inline everything in RecentActivityIcon	2022-08-06 07:16:34 +02:00
LukynkaCZE	bd27995c71	Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section	2022-08-06 05:55:51 +02:00
Dean Herbert	6823282604	Fix PlayButton potentially not disposing an unused PreviewTrack during load	2022-08-05 14:15:27 +09:00
Bartłomiej Dach	ca1b4689cb	Automatically focus name textbox upon add preset popover open	2022-08-03 21:26:35 +02:00
Bartłomiej Dach	159d3b032c	Rename locals for legibility	2022-08-03 21:23:31 +02:00
Bartłomiej Dach	82d3fbd51b	Split AddPresetPopover to separate file	2022-08-03 21:22:55 +02:00
Bartłomiej Dach	add2971eb4	Implement preset creation flow with test coverage	2022-08-02 22:05:54 +02:00
Bartłomiej Dach	7251389e43	Add localisations for add preset button	2022-08-02 22:05:34 +02:00
Bartłomiej Dach	059a465fe8	Add border to popover for better visual contrast	2022-08-02 22:03:33 +02:00
Bartłomiej Dach	1b3074d098	Implement popover for creating mod presets	2022-08-02 22:03:33 +02:00
Bartłomiej Dach	085080576a	Add button for creating new mod presets	2022-08-02 22:03:32 +02:00
Dean Herbert	34ffc51c51	Avoid clearing chat overlay textbox when pressing "back" key binding ... Generally this is expected behaviour for usages of focused text boxes (ie. to clear search content), but not so much here. Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395.	2022-08-02 13:56:03 +09:00
notmyname	6686b09549	Hide F rank from beatmap overlay	2022-08-01 18:54:00 +02:00
Salman Ahmed	2a127c6ef8	Merge branch 'master' into fix-tags-overflow	2022-08-01 12:40:43 +03:00
Gutyina Gergő	c65747d1b8	Use masking instead of scrollable container to prevent tags overflow	2022-08-01 10:36:53 +02:00
Dean Herbert	2f60f91a0e	Fix editor potentially using a track post-disposal ... This changes the editor to track the current track as it is *loaded* by `MusicController`, rather than haphazardly following the current global `WorkingBeatmap` (with a potentially unloaded track) or relying on local immediate-load behaviour (as implemented in `ResourcesSection`).	2022-08-01 16:53:49 +09:00
Bartłomiej Dach	85f77abee1	Fix code quality inspection about ambiguous equality	2022-07-31 23:53:46 +02:00
Bartłomiej Dach	345f103119	Migrate mod preset column to use realm	2022-07-31 23:53:45 +02:00
Gutyina Gergő	98214beb6c	Prevent overflow on beatmap info using scrollable container	2022-07-31 21:24:41 +02:00
Dan Balasescu	aa03df905f	Merge pull request #19441 from peppy/test-working-beatmap-unfuck ... Reduce calls to `LoadTrack` by implicitly running on test/dummy classes	2022-07-28 22:05:25 +09:00
Dean Herbert	a21aee4e9c	Reduce calls to LoadTrack by implicitly running on test/dummy classes	2022-07-28 18:11:40 +09:00
Dean Herbert	ca68574473	Make NotificationOverlay dependency optional in CollectionSettings	2022-07-28 14:35:27 +09:00
Dean Herbert	ad482b8afc	Tidy up naming of collection dropdowns	2022-07-28 13:57:21 +09:00
Dean Herbert	438067a18b	Convert realm data propagation to more correctly use Live<T> ... wip	2022-07-27 19:35:09 +09:00
Dean Herbert	41393616d8	Replace BeatmapCollection with RealmBeatmapCollection	2022-07-27 19:35:09 +09:00
Dean Herbert	9c543fef48	Remove CollectionManager	2022-07-27 18:45:33 +09:00
Dean Herbert	c30e8047ab	Merge pull request #19375 from novialriptide/contextmenu-external-beatmap ... Add ContextMenu to beatmap external link	2022-07-26 19:06:10 +09:00
Dean Herbert	1539fa704b	Always allow selecting the top-most button using the select binding	2022-07-26 17:46:23 +09:00
Andrew Hong	003aec86ae	Rearrange sizeaxes	2022-07-26 04:27:22 -04:00
Dean Herbert	ee0c67e114	Add ability to make cursor show even during touch input ... I completely disagree with this from a UX perspective, but it's come up so often that I figure we should just let users bone themselves.	2022-07-26 14:08:00 +09:00
Andrew Hong	a8e315abf0	Refactor	2022-07-25 17:16:33 -04:00
LukynkaCZE	a7c92fe5d6	Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section	2022-07-25 14:56:00 +02:00
Andrew Hong	fcf767e28b	Add contextmenu to beatmap external link	2022-07-25 04:07:33 -04:00
Salman Ahmed	4d90e6bbac	Flip method to read better	2022-07-25 10:03:06 +03:00
Salman Ahmed	e402e919ab	Display placeholder for user profile scores	2022-07-25 09:40:20 +03:00
Salman Ahmed	f54cee0270	Display placeholder for leaderboard top scores	2022-07-25 09:18:04 +03:00
Salman Ahmed	91d1c9686c	Separate unprocessed PP placeholder to own class	2022-07-25 09:07:51 +03:00
Salman Ahmed	54eb2b98a9	Display exclamation triangle on scores with unprocessed PP	2022-07-25 07:30:57 +03:00
Salman Ahmed	3beb1da3de	Merge branch 'master' into beatmap-overlay-null-pp	2022-07-25 07:18:03 +03:00
Bartłomiej Dach	446485f804	Move localisation string to common location	2022-07-24 23:30:52 +02:00
Bartłomiej Dach	8af9cfbe40	Add readonly modifier	2022-07-24 23:29:18 +02:00
Bartłomiej Dach	6a67d76d7c	Add basic mod preset column implementation	2022-07-24 16:39:04 +02:00
Bartłomiej Dach	b2f8934117	Extract base mod select column presentation logic	2022-07-24 16:39:03 +02:00
Salman Ahmed	7c477e6f22	Fix beatmap overlay leaderboard not handling null PP scores properly	2022-07-24 04:20:49 +03:00
LukynkaCZE	1aa0d49d81	Code Quality	2022-07-23 12:27:24 +02:00
LukynkaCZE	9db06fafd0	Fix code formatting	2022-07-23 12:16:11 +02:00
LukynkaCZE	33b442d5d0	Add missing icons to UserProfileRecentSection	2022-07-23 12:06:30 +02:00
Salman Ahmed	2829a7e836	Merge branch 'master' into beatmap-overlay-modded-stats	2022-07-23 10:38:13 +03:00
Salman Ahmed	661c79baf6	Add explanatory comment	2022-07-23 10:16:11 +03:00
Adam Baker	06462c13dd	Overwrite IBindable<ReadOnlyList<Mod>> cache in BeatmapSetOverlay ... Implement fix as suggested	2022-07-22 23:15:24 -05:00
Adam Baker	d451bc8fda	Revert commits ... This reverts commit 28586c704d. This reverts commit d9d35bb847.	2022-07-22 22:25:49 -05:00
Bartłomiej Dach	f3ceabc53f	Rename ModSelect{Overlay -> }Panel	2022-07-22 19:17:22 +02:00
Adam Baker	d9d35bb847	Set BeatmapSetHeaderContent details to not show modded values	2022-07-22 05:43:56 -05:00
Bartłomiej Dach	a3090003de	Add tooltip showing contents of mod preset	2022-07-21 23:29:21 +02:00
Bartłomiej Dach	bdff7f1ef4	Implement basic appearance of mod preset panels	2022-07-21 23:29:21 +02:00
Bartłomiej Dach	6cd18fad99	Fix code inspections after base panel class extraction	2022-07-21 23:29:08 +02:00
Bartłomiej Dach	d796b7d53c	Extract base mod select overlay panel presentation logic	2022-07-21 22:37:00 +02:00
Dan Balasescu	7dfc18a0e3	Merge pull request #19208 from frenzibyte/remove-score-multiplier-on-custom-mod-settings ... Remove score multiplier on difficulty-increasing mods with customised settings	2022-07-20 20:12:59 +09:00
Dean Herbert	62133fa069	Merge pull request #19246 from frenzibyte/fix-wiki-navigation ... Fix wiki overlay not handling path redirection properly	2022-07-20 20:08:11 +09:00
Salman Ahmed	5e933cb466	Improve comment wording ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2022-07-20 09:43:32 +03:00
Salman Ahmed	474c1a8a7a	Fix wiki overlay not handling path redirection properly	2022-07-20 09:06:11 +03:00
Salman Ahmed	6ce6f6f7df	Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings	2022-07-20 08:57:43 +03:00
Salman Ahmed	1270abdf42	Highlight perfect slider tick/end values in beatmap info leaderboards	2022-07-20 00:53:10 +03:00
Salman Ahmed	4210ec6502	Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings	2022-07-19 19:21:26 +03:00
Salman Ahmed	89653b74c7	Only add setting tracker when customisation is permitted	2022-07-19 19:21:16 +03:00
Salman Ahmed	b5c7d07ba8	Merge branch 'master' into fix-user-profile-overlay	2022-07-18 10:27:33 +03:00
Dean Herbert	a7f19cc796	Merge pull request #19137 from frenzibyte/country-enum ... Replace `Country` class with enumeration	2022-07-18 16:12:24 +09:00
Salman Ahmed	e4d11febc5	Remove no longer necessary fallback	2022-07-18 09:47:40 +03:00
Salman Ahmed	84c1c26a7f	Merge branch 'master' into fix-user-profile-overlay	2022-07-18 09:45:25 +03:00
Salman Ahmed	018da74fe8	Replace default with CountryCode.Unknown	2022-07-18 08:54:35 +03:00
Salman Ahmed	100c53f9ef	Country -> CountryCode	2022-07-18 08:40:34 +03:00
Salman Ahmed	eddae7b143	Fix mod overlay and footer not updating multiplayer on settings change	2022-07-18 07:38:56 +03:00
Salman Ahmed	b33f8aa0fc	Fix "Start Chat" on multiplayer/playlist chat not opening overlay	2022-07-18 06:45:00 +03:00
Salman Ahmed	7e4ce89981	Include mod settings in profile score mod icons	2022-07-18 04:03:18 +03:00
tsunyoku	a5d7075ef1	simplify beatmap metadata logic in DrawableProfileScore	2022-07-17 18:10:47 +01:00
Dean Herbert	4e8bf1da52	Don't sent ruleset configuration failures to sentry	2022-07-18 01:23:46 +09:00
tsunyoku	7a6666996f	rename item to model in CreateDrawableItem	2022-07-17 14:50:53 +01:00
tsunyoku	486fbd2531	create instance of BeatmapInfo for use in ScoreBeatmapMetadataContainer	2022-07-17 14:47:04 +01:00
tsunyoku	7135329c8c	remove `PaginatedProfileScoreSubsectio, revert profile score drawables	2022-07-17 14:22:27 +01:00
tsunyoku	3a8b5d48b9	update PaginatedScoreContainer to use new class and format	2022-07-17 14:09:14 +01:00
tsunyoku	ef4237c4ac	create special subsection class for paginated profile scores	2022-07-17 14:08:31 +01:00
tsunyoku	e8d88e29c6	change DrawableProfileScore and DrawableProfileWeightedScore to take SoloScoreInfo and APIBeatmap instead of APIScore	2022-07-17 14:08:04 +01:00
Salman Ahmed	4968859e69	Rename placeholder display flag property to make sense	2022-07-16 06:07:53 +03:00
Salman Ahmed	e62049f4a9	Update various usages of Country inline with new enum	2022-07-16 05:04:24 +03:00
Salman Ahmed	838e9ec12e	Merge branch 'master' into placeholder-fixes	2022-07-15 20:22:25 +03:00
Dean Herbert	cf38b15332	Merge pull request #19124 from frenzibyte/song-select-metadata-search ... Change clicking source/tags on song select to filter instead of searching online	2022-07-15 19:16:31 +09:00
Dean Herbert	437e01427c	Fix beatmap listing not entering correct search mode when arriving before LoadComplete	2022-07-15 17:53:44 +09:00
Dan Balasescu	c1dd1cfead	Merge pull request #19082 from peppy/api-solo-score-model ... Add and consume `SoloScoreInfo`	2022-07-15 15:20:18 +09:00
Salman Ahmed	eafa11555a	Allow specifying custom search action to metadata sections	2022-07-15 06:41:03 +03:00
Dean Herbert	cd085cbd97	Merge pull request #19114 from frenzibyte/fix-potential-dialog-test-failure ... Fix dialog overlay potentially pushing dialog while not loaded	2022-07-15 12:34:19 +09:00
Salman Ahmed	aea786ea0c	Fix minor typo	2022-07-15 05:56:49 +03:00
Dean Herbert	08396ba486	Adjust colouring to avoid weird banding during transition period	2022-07-14 14:47:25 +09:00
Dean Herbert	5dff48a1e0	Fix button selection animation not playing smoothly when new glyphs are loaded	2022-07-14 14:40:25 +09:00
Dean Herbert	5c6b4e498d	Protect against a potential early call to LanguageButton.Selected	2022-07-14 14:31:59 +09:00
Dean Herbert	227871e8df	Refactor hide logic a touch for better readability	2022-07-14 14:00:33 +09:00
Salman Ahmed	dccd81dbc7	Use BindValueChanged to handle changes between push time and schedule execution	2022-07-14 07:07:32 +03:00
Salman Ahmed	b96faedbe6	Fix dialog overlay hiding early-pushed dialog on initial PopOut call	2022-07-14 07:06:57 +03:00
Salman Ahmed	c59784c49f	Always schedule popup dialog push	2022-07-14 07:06:03 +03:00
Salman Ahmed	1222123541	Rename method and parameter	2022-07-14 07:05:19 +03:00
Salman Ahmed	3def8428aa	Make scheduling more legible	2022-07-14 06:06:58 +03:00
Salman Ahmed	f83d413b33	Fix dialog overlay potentially pushing dialog while not loaded	2022-07-14 06:05:03 +03:00
Dean Herbert	3b554140db	Use grid container to avoid layout changes when changing language	2022-07-13 23:22:55 +09:00
Dean Herbert	0db1caf591	Add language selection to first run overlay	2022-07-13 23:22:55 +09:00
Dean Herbert	f956955d4d	Combine ScoreInfo construction helper methods	2022-07-12 18:00:25 +09:00
Dean Herbert	1bef2d7b39	Add and consume SoloScoreInfo	2022-07-12 18:00:25 +09:00
Dan Balasescu	7086779cf4	Merge pull request #19026 from peppy/async-track-operations ... Use fire-and-forget async operations on global track	2022-07-07 19:45:03 +09:00
Dean Herbert	d88fd8a5b0	Allow searching for "skins" to find current skin setting	2022-07-07 18:26:04 +09:00
Dean Herbert	7ef03dd2cb	Use fire-and-forget async operations on global track ... This avoids any blocking overhead caused by a backlogged audio thread. Test seem to pass so might be okay? Note that order is still guaranteed due to the `ensureUpdateThread` queueing system framework-side.	2022-07-07 17:15:45 +09:00
Dean Herbert	6fb00d84f9	Apply NRT to LoginForm and remove nullability of IAPIProvider	2022-07-06 01:29:00 +09:00
Dean Herbert	3a68f386a8	Add forgotten password link to login form	2022-07-06 01:25:04 +09:00
Dan Balasescu	9bf91835b6	Merge pull request #18962 from peppy/slider-range-control ... Move star difficulty filter to song select	2022-07-03 21:58:00 +09:00
Salman Ahmed	9b833524c0	Merge branch 'master' into add-realm-blocking-logging	2022-07-02 12:41:36 +03:00
Dean Herbert	a03abc747b	Tidy up comments and simplify bounding box centre logic	2022-07-02 12:58:34 +09:00
Dean Herbert	4fd47b5fa0	Add more verbose logging to realm blocking process	2022-07-02 12:36:56 +09:00
Jamie Taylor	9d28d5f8ee	Update SFX for mod overlay show/hide	2022-07-01 20:43:12 +09:00
Salman Ahmed	5880b824d0	Simplify description logic for overlay tab items	2022-07-01 11:30:51 +03:00
Salman Ahmed	7f9ef6c23f	Merge branch 'master' into fix-overlay-header-tab-item-localisable-string	2022-07-01 11:27:00 +03:00
Dean Herbert	d54f7fc728	Move slider range control to song select	2022-07-01 14:41:36 +09:00
Salman Ahmed	87e3b44181	Ensure icon is loaded inside try-catch	2022-06-29 13:37:42 +03:00
Dean Herbert	6c64cea057	Catch a second location	2022-06-29 18:56:15 +09:00
Dean Herbert	569fde4b47	Add messages to all InvalidOperationExceptions ... Without this, they can be very non-descript and hard to track down	2022-06-28 01:34:25 +09:00
Dan Balasescu	6c6de9ce53	Fix typo	2022-06-27 20:40:02 +09:00
Dean Herbert	50c1c066de	Add various logging of global WorkingBeatmap state changes	2022-06-27 18:41:31 +09:00
Dean Herbert	31a447fda0	Update parameter discards	2022-06-24 21:26:19 +09:00
Dean Herbert	30eebf3511	Merge branch 'master' into c-sharp-10	2022-06-24 21:22:33 +09:00
Bartłomiej Dach	26c5b59f6d	Replace usages of string.To{Lower,Upper}()	2022-06-24 11:57:45 +02:00
Dean Herbert	f71f6302fd	Remove unnecessary null casts	2022-06-24 14:50:11 +09:00
Dean Herbert	d9c1a9d71f	Use new property to specify no tooltip, rather than passing only ruleset	2022-06-24 14:06:18 +09:00
Dean Herbert	7dec530ca5	Split out simple DifficultyIcon with no calculation overhead and update usages	2022-06-23 19:27:35 +09:00
Dean Herbert	b660119de7	Merge pull request #18796 from bdach/mod-overlay/legacy-key-bindings ... Add setting option to toggle between mod overlay hotkey styles	2022-06-22 20:28:18 +09:00
Dan Balasescu	b81c7c7951	Merge pull request #18804 from Joehuu/online-view-chat-overlay ... Add back online view container to chat overlay	2022-06-22 14:41:06 +09:00
Dan Balasescu	ff440fc1a4	Fix too many buttons inside condition	2022-06-22 13:44:41 +09:00
Dan Balasescu	321920bc85	Remove one more nullable disable	2022-06-22 13:44:41 +09:00
Dan Balasescu	1018c9852d	Cleanup nullability	2022-06-22 13:44:41 +09:00
Dan Balasescu	23254d2ff2	Fix broken files	2022-06-22 13:44:41 +09:00
Joseph Madamba	07e0cd53a4	Add back online view container to chat overlay	2022-06-21 19:23:16 -07:00
Joseph Madamba	50728f3fbc	Fix overlay header tab item not working with localisable string	2022-06-21 18:31:09 -07:00
Supersonicboss1	4aa86b0a80	fixed duplicates and cleaned up code	2022-06-21 23:41:25 +01:00
Supersonicboss1	e4931f977c	improved UI of maintenance section in settings	2022-06-21 23:00:03 +01:00
Bartłomiej Dach	7013909322	Remove unnecessary protected virtual	2022-06-21 16:43:04 +02:00
Bartłomiej Dach	f564ed589f	Alter sequential hotkey style to always use visible index ... Previous behaviour was once mentioned off-hand as unintuitive.	2022-06-21 15:22:18 +02:00
Bartłomiej Dach	9e5cc89edb	Fix classic hotkeys toggling filtered mods	2022-06-21 15:01:33 +02:00
Bartłomiej Dach	da1814e7c3	Restructure everything to fix free mod overlay issue	2022-06-21 14:48:41 +02:00
Bartłomiej Dach	7b7b8c1892	Implement behaviour for classic selection style	2022-06-21 14:24:30 +02:00
Bartłomiej Dach	234120ff43	Forward entire event to IModHotkeyHandler ... Required for shift handling in the classic implementation.	2022-06-21 13:37:17 +02:00
Bartłomiej Dach	658f5341c7	Set up flow for switching between hotkey styles	2022-06-21 13:34:58 +02:00
Bartłomiej Dach	5abd8a07d2	Add setting for changing mod select hotkey style	2022-06-21 13:33:17 +02:00
Bartłomiej Dach	73124d2b1f	Encapsulate mod hotkey selection logic in strategy pattern	2022-06-21 12:49:01 +02:00
Bartłomiej Dach	ee96d84ffa	Merge branch 'master' into input-settings	2022-06-20 22:55:43 +02:00
Dean Herbert	6515b249ec	Change data migration to do an immediate exit, rather than attempted exit	2022-06-19 12:39:58 +09:00
Dean Herbert	50e40756c4	Rename GracefullyExit to AttemptExit	2022-06-19 12:34:44 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Salman Ahmed	e4ddf03ad6	Fix toolbar music button handling keys while not hovered	2022-06-16 20:22:57 +03:00
Bartłomiej Dach	9c4f6d2ce0	Merge branch 'master' into first-run-setup-notification-interruption	2022-06-16 15:14:40 +02:00
Dean Herbert	251923c106	Convert NotificationOverlay to NRT	2022-06-16 17:28:08 +09:00
Dean Herbert	6b30ee0950	Tidy up DI and binding logic	2022-06-16 17:26:43 +09:00
Bartłomiej Dach	f88c568c8d	Update flag sizes after switch to twemoji assets ... The old flags used a size of 150x100, while the new assets based on twemoji use a size of 150x108. Update existing usages to match this new aspect ratio better.	2022-06-15 21:45:47 +02:00
Salman Ahmed	e7dcbddbeb	Fix potential null reference	2022-06-15 18:53:49 +03:00
Salman Ahmed	026bad7fc4	Use notification processing mode logic instead	2022-06-15 18:13:24 +03:00
Dean Herbert	7571ab6c63	Merge branch 'master' into new-dialog-sfx	2022-06-15 19:47:00 +09:00
Dean Herbert	584345a97e	Merge pull request #18693 from frenzibyte/toolbar-volume-control ... Add basic volume control support in toolbar music button	2022-06-15 17:50:10 +09:00
Dean Herbert	b3aa4fcf02	Adjust a channel rather than the overall sample	2022-06-15 17:33:07 +09:00
Dean Herbert	94aa2248ca	Move filter reset to more appropriate location	2022-06-15 17:32:21 +09:00
Dean Herbert	1f1633ddc2	Remove Update method processing of samples in PopupDialogDangerousButton	2022-06-15 16:50:23 +09:00
Salman Ahmed	583619b915	Use GlobalAction.DecreaseVolume instead	2022-06-15 10:21:27 +03:00
Dean Herbert	873806c2ea	Add keyboard adjustment support	2022-06-15 15:58:22 +09:00
Dean Herbert	3df9d7c9e1	Add a bit more animation when adjusting	2022-06-15 15:56:59 +09:00
Dean Herbert	5eb56ab814	Ensure Master volume is updated when scrolling on toolbar button	2022-06-15 15:41:40 +09:00
Jamie Taylor	af87722be8	Add audio feedback for 'Dangerous' dialog buttons	2022-06-15 15:41:27 +09:00
Jamie Taylor	930ec2a197	Add specific samples for dialog 'Ok' and 'Cancel' buttons	2022-06-15 15:41:27 +09:00
Salman Ahmed	ddeee09a51	Fix important notifications interrupting first-run setup	2022-06-15 03:40:05 +03:00
Salman Ahmed	1f31e3fb51	Add volume UI to toolbar music button	2022-06-14 22:15:12 +03:00
Salman Ahmed	7f23677972	Add volume control support via toolbar music button	2022-06-14 22:15:12 +03:00
Dean Herbert	49ec2572b8	Allow scrolling overflow of ruleset buttons in the toolbar	2022-06-15 01:43:10 +09:00
Salman Ahmed	d89c11e49e	Allow Toolbar to block scroll input from passing through	2022-06-14 19:10:13 +03:00
Dean Herbert	77fcf35d1d	Remove unlimited frame limiter warning ... This should not be required now that we have a 1,000 Hz limiter in place.	2022-06-13 15:40:27 +09:00
Dan Balasescu	e5d6dc1ba5	Merge pull request #18606 from peppy/latency-comparer ... Add latency certifier system	2022-06-10 19:41:44 +09:00
Dan Balasescu	c9dfffbc0e	Merge pull request #18619 from peppy/fix-collection-performance ... Fix performance overhead of large collections	2022-06-10 15:01:31 +09:00
Dean Herbert	c625c929e5	Update button text to match new terminology	2022-06-10 14:16:56 +09:00
Dean Herbert	4a5e86e451	Rename Beatmaps to BeatmapHashes for clarity	2022-06-10 14:03:51 +09:00
Dean Herbert	3b229624dd	Simplify contains check to use LINQ the whole way	2022-06-10 14:02:58 +09:00
Dan Balasescu	bc7262a3dd	Merge pull request #18627 from Joehuu/always-show-mod-selector-beatmap-info ... Always show mod selector on beatmap info leaderboards regardless of supporter	2022-06-09 18:18:12 +09:00
Joseph Madamba	f3371e8bc8	Always show mod selector on beatmap info leaderboards regardless of supporter	2022-06-08 13:22:49 -07:00
Jai Sharma	c2ed41d097	Remove CanBeNull specification from DI attributes	2022-06-08 15:10:19 +01:00
Jai Sharma	04b434b8ce	Update ChatLine timestamp and message colours	2022-06-08 14:04:01 +01:00
Jai Sharma	dfa31df2af	Use #nullable enable in ChatLine	2022-06-08 14:04:01 +01:00
Dean Herbert	c22bffaa01	Fix filter failure when no collection is selected	2022-06-08 19:30:18 +09:00
Dean Herbert	187086e4ec	Merge pull request #18609 from ALANVF/settings-delete-skin ... Add button to delete the current skin	2022-06-08 19:18:59 +09:00
Dean Herbert	42cd7d9e6e	Change CollectionManager to only store MD5 hashes instead of full BeatmapInfo	2022-06-08 18:23:09 +09:00
Dan Balasescu	3a90aa0b9b	Fix code styling	2022-06-08 17:57:59 +09:00
Dean Herbert	5157a78ae6	Isolate nested sample screens from main game to avoid toolbar interactions	2022-06-08 16:53:06 +09:00
theangryepicbanana	6c05329144	Close #5820 (Ability to delete a single skin)	2022-06-07 18:01:40 -04:00
Jai Sharma	2f635fa854	Refactor ChatLine and fix DrawableChannel flow padding ... Refactors `ChatLine` component to use more sensible override properties and layout using grid container. Moves creation of username component into its own method to simplify BDL. Updates padding of base `DrawableChannel` flow padding. Removes usage of `ChatOverlayDrawableChannel` since it's overrides are no longer needed. Updates usage of `StandAloneChatDisplay` to use new override properties of `DrawableChannel`.	2022-06-07 22:35:45 +01:00
Dean Herbert	9da99a0ddf	Rename to latency certifier	2022-06-07 23:34:55 +09:00
Dean Herbert	95dea00725	Tidy up code and namespaces	2022-06-07 23:10:08 +09:00
Dean Herbert	20cfa5d83f	Add button to access latency comparer from game	2022-06-07 17:28:31 +09:00
Bartłomiej Dach	4df7711af8	Merge branch 'master' into volume-metre-keyboard-fix	2022-06-06 23:45:42 +02:00
Dean Herbert	b104b7a90d	Rename method to mention "all"	2022-06-06 20:12:20 +09:00
Dean Herbert	cb383d4bdc	Merge branch 'master' into delete-all-beatmap-videos-sbs	2022-06-06 20:08:05 +09:00
Jai Sharma	c0aaeff2b3	Update DaySeparator to use new design throughout ... Moves `DaySeparator` chat component to it's own file and update it to match new chat design. Makes use of several virtual attributes that can be overridden to update spacing and layout in other usage contexts. Remove redundant usage of `ChatOverlayDaySeparator`, since the new design is now part of the base class. Create `StandAloneDaySeparator` to use in `StandAloneChatDisplay` which overrides attributes to match correct spacing and layout for its design. Ensure that `DrawableChannel.CreateDaySeparator` returns type of `DaySeparator` instead of `Drawable`.	2022-06-04 18:02:14 +01:00
Joseph Madamba	58c8562cb0	Fix username placeholder text casing and missing localisation on registration form	2022-06-03 20:09:20 -07:00
Dean Herbert	d0e098fbcd	Allow using arrow keys to navigate volume controls when controls are already visible	2022-06-04 01:04:46 +09:00
Dean Herbert	712253a35b	Make non-localisable strings in VolumeMeter verbatim	2022-06-04 01:04:23 +09:00
Dean Herbert	64616a6d73	Remove completely gimped implementation in VolumeMeter	2022-06-04 00:18:54 +09:00
Jamie Taylor	6115275bc2	Use 'default' sampleset for toolbar and repurpose 'toolbar' select sample temporarily	2022-06-03 22:33:06 +09:00
Jamie Taylor	2878bb592f	Use more appropriate sounds for certain components	2022-06-03 22:32:12 +09:00
Jamie Taylor	365819865e	Remove 'submit' sample usages	2022-06-03 22:31:35 +09:00
Salman Ahmed	cd999cf7ac	Fix back-to-front conditional	2022-06-03 10:51:20 +03:00
Salman Ahmed	1a835f0622	Add warning note when running fullscreen on macOS	2022-06-03 10:32:59 +03:00
Dean Herbert	5bd9d88219	Fix tutorial download state not matching correctly when already available locally ... Closes https://github.com/ppy/osu/issues/18468. This doesn't stop the tutorial from downloading a second time, but at least displays the correct status afterwards. Avoiding the download is a bit more involved and requires a change to the flow. Probably not worth it just yet. To test, recommend switching to production environment, as dev server doesn't have correct metadata for tutorial resulting in weirdness.	2022-06-02 16:34:24 +09:00
Dean Herbert	42598ce22a	Refactor warning to notice in method names and usages	2022-06-01 16:51:58 +09:00
Dean Herbert	f7110116de	Only display exclusive fullscreen hinting on windows	2022-05-31 14:04:56 +09:00
Dean Herbert	53844d3df1	Refactor settings item "warning" text to allow non-warning state	2022-05-31 14:01:42 +09:00
Dan Balasescu	99ee3a7d8d	Merge branch 'master' into detect-exclusive-fullscreen	2022-05-31 09:42:42 +09:00
Dean Herbert	1d5a156c15	Merge pull request #18427 from sw1tchbl4d3r/currently_playing_search ... Add search bar for the `CurrentlyPlayingDisplay`	2022-05-30 23:03:00 +09:00
Dean Herbert	f65d2db77f	Remove "V2" suffix from ChatOverlay components	2022-05-30 17:54:09 +09:00
Dan Balasescu	5f9a69e5c2	Add localisation	2022-05-30 17:19:03 +09:00
Dan Balasescu	dea7a27553	Adjust wording, add text for capable state	2022-05-30 17:18:29 +09:00
Dean Herbert	9e678101cf	Merge pull request #18442 from jai-x/new-chat-announce-channel ... Display Announce type channels separately in new chat overlay	2022-05-30 16:53:15 +09:00
Dean Herbert	5478ac21ea	Merge branch 'master' into currently_playing_search	2022-05-30 16:48:53 +09:00
Jai Sharma	8f596520f3	Remove old chat overlay components	2022-05-29 20:08:43 +01:00
Bartłomiej Dach	e329c160b3	Simplify channel retrieval expression	2022-05-29 18:58:27 +02:00
Bartłomiej Dach	e69f8716cd	Fix incorrect indent size	2022-05-29 18:56:37 +02:00
Bartłomiej Dach	f9f8a32380	Merge branch 'master' into new-chat-announce-channel	2022-05-29 18:55:43 +02:00
Dean Herbert	7c97719db1	Move Schedule to only drawable pieces	2022-05-29 21:28:09 +09:00
Dean Herbert	c7570fbce5	Fix potential ObjectDisposedException on realm notification in SkinSection	2022-05-29 15:15:03 +09:00
sw1tchbl4d3	ede3ab9dc0	Add OnFocus handler to CurrentlyPlayingDisplay	2022-05-28 12:04:44 +02:00
Salman Ahmed	06832a4baf	Fix beatmap badge colours not updated inline with recent changes	2022-05-28 01:05:43 +03:00
sw1tchbl4d3	cd84200ad9	Add HoldFocus and ReleaseFocusOnCommit attributes to searchbar	2022-05-27 21:23:37 +02:00
Jai Sharma	c5845f307a	Code quality	2022-05-27 20:12:00 +01:00
Dean Herbert	254039b8fe	Address remaining code quality concerns	2022-05-28 04:01:51 +09:00
Jai Sharma	e950c8c1d0	Refactor ChannelList to use new ChannelGroup class for each type of channel	2022-05-27 19:46:53 +01:00
Jai Sharma	320b6ca631	Display Announce type channels separately in new chat overlay	2022-05-27 16:18:22 +01:00
Bartłomiej Dach	e511c1dfff	Merge branch 'master' into use-normalised-precise-scrolling	2022-05-27 16:55:13 +02:00
sw1tchbl4d3	e2951d70d1	Address code style issues	2022-05-27 16:38:54 +02:00
sw1tchbl4d3	e1fd37fd44	Use new padding constant where appropriate	2022-05-27 12:40:31 +02:00
sw1tchbl4d3	6a0cf26722	Make text localisable and add padding constant	2022-05-27 12:36:43 +02:00
sw1tchbl4d3	7c459faaf0	Remove unneeded search_bar_width and more	2022-05-27 10:05:59 +02:00
sw1tchbl4d3	4967d03606	Update currently playing search bar to resemble existing UI	2022-05-27 09:58:40 +02:00
Joseph Madamba	105d581f24	Use existing web localisation for chat strings	2022-05-26 22:23:03 -07:00
Joseph Madamba	3554563114	Fix beatmap info scores container not hiding when there's no leaderboard	2022-05-26 19:50:54 -07:00
Joseph Madamba	2b5aa35b56	Fix beatmap info status pill being incorrect on multiple status beatmaps	2022-05-26 17:52:17 -07:00
sw1tchbl4d3	a8e453e660	Remove now unnecessary username filter check	2022-05-27 00:43:29 +02:00
sw1tchbl4d3	de5b60ab66	Move filtering from manual loops to SearchContainer	2022-05-27 00:40:23 +02:00
sw1tchbl4d3	3183621d3d	Add search bar for the CurrentlyPlayingDisplay	2022-05-26 22:57:24 +02:00
Dean Herbert	a98d0cf0d8	Simplify channel filter method	2022-05-26 18:48:11 +09:00
Dean Herbert	b2607196b8	Merge branch 'master' into new-chat-integrate	2022-05-26 18:38:26 +09:00
Dan Balasescu	08935cff86	Detect exclusive fullscreen on Windows	2022-05-26 18:37:04 +09:00
Noah M	b550cbc5a3	Fix failing code quality checks	2022-05-25 17:01:30 -05:00
Bartłomiej Dach	a1b8fa0992	Disable "select all mods" button if all are selected	2022-05-25 23:06:12 +02:00
Bartłomiej Dach	071e158a29	Expose available mod state outwardly as a bindable	2022-05-25 23:06:12 +02:00
Bartłomiej Dach	f0303d76e8	Split off "select all mods" button to separate class	2022-05-25 22:18:30 +02:00
Bartłomiej Dach	a3f2962558	Disable "deselect all mods" button if none are selected	2022-05-25 22:15:02 +02:00
Bartłomiej Dach	a4bd399b0c	Split off "deselect all mods" button to separate class	2022-05-25 22:14:45 +02:00
Jai Sharma	f94afa5f8c	Code quality	2022-05-25 18:28:18 +01:00
Jai Sharma	997fc716e8	Split out the channel list labels from the channel list item flow	2022-05-25 15:15:46 +01:00
Jai Sharma	c0da05dda0	Use an array of channels to exclude from the overlay	2022-05-25 15:15:26 +01:00
Jai Sharma	cd90d29315	Ensure channel traversal shortcut scrolls channel list item into view	2022-05-25 12:37:28 +01:00
Jai Sharma	4a36f3aa4c	Ensure channel traversal shortcut is using visual order	2022-05-25 12:29:04 +01:00
Dean Herbert	49ab031e75	Allow traversing in both directions using ctrl-tab shortcuts	2022-05-25 18:42:49 +09:00
Dean Herbert	a92089c443	Change filter method to consider all non-system channels as joinable	2022-05-25 18:42:33 +09:00
Dan Balasescu	79c8752bb4	Merge pull request #18408 from peppy/first-run-ui-scale-first ... Move UI scale setup to the beginning of the first run setup	2022-05-25 12:56:03 +09:00
Dean Herbert	de5d2df100	Move UI scale setup to the beginning of the first run setup	2022-05-25 12:19:26 +09:00
Dan Balasescu	f468d1eb16	Merge branch 'master' into editor-tidy-up	2022-05-25 11:58:34 +09:00
Jai Sharma	f6810d3f59	Add keyboard shortcuts to ChatOverlayV2 with tests	2022-05-24 23:05:25 +01:00
Bartłomiej Dach	61c093c109	Merge branch 'master' into rounded-button-colour-default	2022-05-24 22:47:47 +02:00
Jai Sharma	fce527b0df	Schedule channel manager bindable events to ensure they happen after the first poll	2022-05-24 21:25:27 +01:00
Bartłomiej Dach	2dd0b3f8d9	Merge branch 'master' into fix-mod-panel-click-area	2022-05-24 21:52:37 +02:00
Dean Herbert	0bcf8c846c	Change editor colour scheme to aquamarine	2022-05-24 18:43:22 +09:00
Dean Herbert	f00dd27fcd	Move OverlayColourProvider provisioning of RoundedButton to SettingsButton for now	2022-05-24 18:11:54 +09:00
Joseph Madamba	1f935cacf4	Add spotlighted beatmaps filter to beatmap listing	2022-05-23 18:47:04 -07:00
Joseph Madamba	ed0b841df0	Fix incorrect left/right clicking area of mod panels	2022-05-23 18:29:26 -07:00
apollo-dw	eae2378466	Add WIP to search filters	2022-05-24 01:49:07 +01:00
Jai Sharma	58d39734d0	Integrate ChatOverlayV2 into main game	2022-05-23 21:02:47 +01:00
Susko3	88217e0c98	Adjust ScrollDelta usages to account for normalised IsPrecise values	2022-05-23 20:22:27 +02:00
Dean Herbert	7d93778355	Merge pull request #18290 from jai-x/new-chat-remove-selector-item ... Use dummy channel to show selector and remove `ChannelListSelector`	2022-05-23 15:49:00 +09:00
Dean Herbert	d84119ac06	Merge pull request #18343 from frenzibyte/waveform-test-beatmap-failure ... Fix `WaveformTestBeatmap`s potentially providing disposed track	2022-05-22 21:21:28 +09:00
Jai Sharma	fb06b7658b	Merge branch 'master' into new-chat-remove-selector-item	2022-05-21 17:30:06 +01:00
Dean Herbert	4633eed78c	Merge branch 'master' into localisable-filter-items	2022-05-20 23:55:16 +09:00
Salman Ahmed	abf9039109	Use == instead of ??	2022-05-20 16:08:31 +03:00
Salman Ahmed	c78d90ccbd	Refactor track transferring logic for ability to override and disallow	2022-05-20 14:43:07 +03:00
Jai Sharma	c37d1e4fae	Ensure current channel is set to the ChannelListingChannel when it becomes null	2022-05-19 11:45:39 +01:00
Dean Herbert	136ecb45e2	Rename dummy channel and move to a nested class inside the ChannelListing itself	2022-05-19 19:26:14 +09:00
Dean Herbert	63c9776365	Fix oversight in bindable logic in new overlay class	2022-05-19 19:24:18 +09:00
Dean Herbert	363e7a6f53	Simplify toolbar hiding logic in FirstRunSetupOverlay ... Rather than fiddling around with the activation modes, this seems like a much cleaner way to make things work. Closes https://github.com/ppy/osu/issues/18277.	2022-05-19 16:42:48 +09:00
Dean Herbert	d187ca2d8c	Merge pull request #18246 from jai-x/new-chat-cache-loaded-channels ... Add drawable channel caching to new chat overlay	2022-05-19 15:15:47 +09:00
Dean Herbert	a443200d0d	Make dependency nullable to allow for safer disposal unbinding	2022-05-19 13:49:52 +09:00
Noah M	0ef9406787	Fix deleteBeatmapVideosButton not being reenabled ... My bad	2022-05-18 16:35:14 -05:00
Noah M	617382a56f	Split off MassVideoDeleteConfirmationDialog into its own file	2022-05-18 15:20:57 -05:00
Salman Ahmed	5d3878a737	Add test coverage for slow-loading channels	2022-05-18 22:58:39 +03:00
Jai Sharma	371738b047	Check against the loaded drawable channel	2022-05-18 20:00:42 +01:00
Dean Herbert	0cee90e156	Add common strings for missing localisable content	2022-05-18 21:32:57 +09:00
Dean Herbert	d54e1503c7	Rename interaction toggle method	2022-05-18 21:32:57 +09:00
Dean Herbert	fa09270e62	Remove left-over todo	2022-05-18 21:32:57 +09:00
Noah M	69351d2cdf	Implement button to delete all beatmap videos	2022-05-18 01:20:57 -05:00
Jai Sharma	4015042e36	Ensure close button component is not stored as a Drawable	2022-05-18 01:35:39 +01:00
Bartłomiej Dach	c2555a91c7	Merge branch 'master' into first-run-screen-import-from-stable	2022-05-17 22:52:01 +02:00
Bartłomiej Dach	10b881dbf7	Merge branch 'master' into first-run-screen-button-ux	2022-05-17 22:27:49 +02:00
Jai Sharma	932442e242	Use null for empty grid cells in ChannelListItem	2022-05-17 18:52:19 +01:00
Dean Herbert	062ffe64ac	Remove delay on pop in	2022-05-17 18:21:19 +09:00
Dean Herbert	bf00b062ad	Add full localisation of import beatmaps screen	2022-05-17 17:58:24 +09:00
Dean Herbert	f4e0ad8c4c	Fix drag drop of osu! folder not working as expected	2022-05-17 17:51:28 +09:00
Dean Herbert	c0de1f96ff	Tidy up interaction toggling and add progress message	2022-05-17 17:33:54 +09:00
Dean Herbert	03d3900a02	Fix incorrect default state of checkboxes	2022-05-17 17:33:54 +09:00
Dean Herbert	adc7b61240	Switch directory selector to use a semi-shared popover implementation	2022-05-17 17:33:54 +09:00
Dean Herbert	e2ea98693f	Tidy up buttons and text	2022-05-17 17:33:54 +09:00
Dean Herbert	4af1a788d1	Add locate stable button / screen	2022-05-17 15:55:53 +09:00
Dean Herbert	1593f05ff3	Tidy up checkbox implementation	2022-05-17 15:55:53 +09:00
Dean Herbert	13e70eab51	Allow cancellation of count operations and bypassing interactive location logic	2022-05-17 15:55:53 +09:00
Dean Herbert	1666d13d26	Add item counts to import screen	2022-05-17 15:55:53 +09:00
Dean Herbert	4412fec41a	Add import from stable screen	2022-05-17 15:55:52 +09:00
Dean Herbert	ef5b2233d7	Improve the first run progress button to show loading and completion status	2022-05-17 15:23:13 +09:00
Dan Balasescu	a633501687	Change FilterTerms to use LocalisableString	2022-05-16 14:09:37 +09:00
Jai Sharma	ae5b6c3e10	Use dummy channel to show selector and remove ChannelListSelector ... Add dummy channel `DummySelectorChannel` which should be set as the current channel in the channel manager when the selector in the chat overlay should be shown. Refactors the `ChannelListItem` to not show mention pill and close button when the channel is the dummy selector channel. Ensure that the `ChannelList` selects the dummy channel on clicking the selector item. Removes `ChannelListSelector` as it is no longer needed. Removes the `setCurrent` parameter from `ChannelManager.JoinChannel` method as it is no longer needed.	2022-05-15 20:24:49 +01:00
Bartłomiej Dach	170df01b46	Adjust difficulty multiplier scale transition on mod overlay ... The previous transition was supposed to be a center-anchored elastic scale-in, but this didn't work as intended - because the multiplier ended up inside of an auto-sized right-aligned container, the animation itself would end up being anchored right. Attempts to remove the scale transition resulted in a rather jarring-looking result, so swap out the elastic scale-in for a sweep-in effect from the top, to match the header and avoid introducing too many directions of movement. Delay values tweaked "to taste" - can be adjusted further if there is an alternative set of values that feels better.	2022-05-15 20:44:50 +02:00
Dean Herbert	328561f5c8	Merge pull request #18263 from frenzibyte/spotlight-beatmap-badge ... Add support for "spotlight" label in beatmap overlay/listing	2022-05-15 12:32:20 +09:00
Salman Ahmed	4bb06873d5	Move badge hierarchy declaration to constructor for safer access	2022-05-14 21:54:56 +03:00
Dean Herbert	8a01050168	Refactor mod select button initialisation to allow shared usage of deselect button	2022-05-15 03:16:43 +09:00
Salman Ahmed	1878578196	Move todo comment to subclasses	2022-05-14 21:05:34 +03:00
Salman Ahmed	441957e18e	Convert get-only virtual properties to avoid DI order dependency	2022-05-14 21:05:34 +03:00
Salman Ahmed	88ba84ac9c	Replace Pill with Badge everywhere	2022-05-14 20:52:38 +03:00
Dean Herbert	a759cf2dab	Add key binding to deselect all mods ... Defaults to `Backspace`.	2022-05-15 02:51:58 +09:00
Salman Ahmed	2878a6dcbe	Integrate spotlight beatmap badge in info overlay	2022-05-14 19:47:10 +03:00
Salman Ahmed	56d6cb5764	Add "spotlight" beatmap badge	2022-05-14 19:46:50 +03:00
Salman Ahmed	c8bea6273b	Abstractify beatmap badge logic to own class	2022-05-14 19:46:37 +03:00
Jai Sharma	bd68ffa805	Fix textbox focus test in ChatOverlayV2	2022-05-14 12:16:00 +01:00
Jai Sharma	2163a78b7f	Ensure drawable channels removed from the cache are disposed	2022-05-14 00:15:09 +01:00
Jai Sharma	f88e416d1a	Ensure the wrong drawable channel isn't shown after load	2022-05-13 23:39:09 +01:00
Jai Sharma	9f5351e5a1	Add drawable channel caching to new chat overlay	2022-05-12 23:58:41 +01:00
Dean Herbert	8760e5d884	Merge branch 'master' into new-chat-drawable-channel	2022-05-12 22:36:19 +09:00
Dan Balasescu	5f2d9bf04c	Merge pull request #18211 from frenzibyte/audio-adjustment-breakage-alt ... Fix mods potentially adjusting track while not selected	2022-05-12 15:44:19 +09:00
Salman Ahmed	82c4a5fe9f	Merge branch 'master' into new-chat-visibility-behaviour	2022-05-12 09:04:24 +03:00
Dean Herbert	3d64dc53a6	Merge branch 'master' into audio-adjustment-breakage-alt	2022-05-12 14:18:28 +09:00
Dean Herbert	6ba0760b17	Merge branch 'master' into new-chat-visibility-behaviour	2022-05-12 13:59:35 +09:00
Dean Herbert	1d38e5bd33	Add notes about weird local handling in ChannelListSelector	2022-05-12 13:58:10 +09:00
Dean Herbert	2dfed6eda1	Remove selectorActive bindable completely	2022-05-12 13:53:57 +09:00
Jai Sharma	db371ab068	Use CurrentChannel == null to show the channel selector	2022-05-11 22:52:15 +01:00
Bartłomiej Dach	981ead68bf	Ensure local mods are constructed in time for Pop{In,Out}()	2022-05-11 22:31:27 +02:00
Bartłomiej Dach	93539160ad	Remove no-longer-necessary guard	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	2266a5c9a0	Remove no-longer-necessary ModColumn.Filter	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	1c0166367d	Fix remaining column operations being coupled to drawables	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	b5a9f1310a	Fix select/deselect all toggle not working correctly after changes	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	52bbce12f1	Fix not being able to set AvailableMods before loaded	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	fc24a56478	Add protection from recursive updates from external selection	2022-05-11 22:31:25 +02:00
Bartłomiej Dach	83ba06e7af	Extract helper property for accessing all mods	2022-05-11 22:31:25 +02:00
Bartłomiej Dach	11ae1da65a	Hoist reference replacement logic to overlay level	2022-05-11 22:26:47 +02:00
Bartłomiej Dach	05a21fbbe0	Hoist ModState to overlay level	2022-05-11 22:26:21 +02:00
Bartłomiej Dach	e86444c4bf	Hoist ModState to column level	2022-05-11 22:03:49 +02:00
Bartłomiej Dach	74599c9c62	Use ModState in mod panels	2022-05-11 22:03:48 +02:00
Bartłomiej Dach	478cfc0b87	Split model class for mod state	2022-05-11 22:03:48 +02:00
Bartłomiej Dach	ddb2d4eef5	Rename FreeModSelect{Screen -> Overlay} reference in inline comment	2022-05-11 18:06:09 +02:00
Bartłomiej Dach	a104277e7f	Rename ModSelect{Screen -> Overlay}Strings	2022-05-11 18:01:33 +02:00
Bartłomiej Dach	76c63f1d0a	Rename ModSelect{Screen -> Overlay} in place of removed old design	2022-05-10 22:56:50 +02:00
Bartłomiej Dach	33634cba1e	Remove old mod buttons	2022-05-10 21:58:22 +02:00
Bartłomiej Dach	8b0ece1c09	Remove old mod section	2022-05-10 21:55:54 +02:00
Bartłomiej Dach	dfd97701d7	Remove old mod settings container & related controls	2022-05-10 21:53:42 +02:00
Bartłomiej Dach	128468e13d	Remove old base mod select overlay	2022-05-10 21:52:30 +02:00
Bartłomiej Dach	24c59e2f2f	Remove old user mod select overlay	2022-05-10 21:52:17 +02:00
Salman Ahmed	9446be2511	Remove unnecessary UnbindAdjustments call ... It is not necessary given that `CurrentTrack` already removes all adjustments first.	2022-05-10 20:49:44 +03:00
Salman Ahmed	36a7644164	Reinstantiate mod adjustments layer for safety against previous mods	2022-05-10 20:46:33 +03:00
Salman Ahmed	725ff93f34	Define local adjustments component for mods in MusicController ... Isolates `CurrentTrack` from being directly adjusted by the mod, which could lead to issues depending on how the mod adds adjustments (i.e. `ModTimeRamp`, which adds adjustments based on changes to a setting bindable).	2022-05-10 18:24:29 +03:00
Dan Balasescu	42fe708225	Fix inspection	2022-05-10 19:56:21 +09:00
Dean Herbert	a578f7a406	Force nested screens to load synchronously	2022-05-10 18:21:35 +09:00
Dean Herbert	a93c63b2b5	Add loading spinner when loading first run screens	2022-05-10 18:21:35 +09:00
Dean Herbert	25c6226ca9	Adjust transition length for a more seamless screen change	2022-05-10 18:21:35 +09:00
Dean Herbert	493798ae5e	Fix nested ui scale example screens no longer fitting	2022-05-10 18:21:35 +09:00
Dean Herbert	63b9e01d38	Fix behaviour screen using old style buttons	2022-05-10 18:21:35 +09:00
Dean Herbert	61313b69ec	Standardise font sizes in first run overlay screens	2022-05-10 18:21:35 +09:00
Dean Herbert	e5204e565d	Move horizontal padding to content level to better align scrollbar	2022-05-10 18:21:35 +09:00
Dean Herbert	bcce9c5e67	Limit the width of first run overlay content	2022-05-10 18:21:35 +09:00
Dean Herbert	9aadc274bf	Show first run dialog on first run of the game	2022-05-10 18:21:35 +09:00
Dan Balasescu	8ccf2ee075	Add inline comment	2022-05-10 15:07:08 +09:00
Dan Balasescu	2b7eeadac0	Workaround bad performance when selecting all freemods	2022-05-10 14:48:41 +09:00
Dan Balasescu	886a4815fa	Merge pull request #18180 from frenzibyte/fix-toolbox-double-tap ... Fix `SettingsToolboxGroup` not clearing transforms before updating autosize	2022-05-10 13:48:02 +09:00
Jai Sharma	2481201a73	Fix selector dismissal behaviour during user actions	2022-05-09 22:58:46 +01:00
Salman Ahmed	96ea4ee7b3	Add explanatory comment	2022-05-09 23:49:05 +03:00
Bartłomiej Dach	626fcd5d35	Merge branch 'master' into column-flow-cq	2022-05-09 19:22:29 +02:00
Jai Sharma	d4cc2bd7dd	Ensure channel selector is dismissed when the current channel is changed	2022-05-09 12:11:25 +01:00
Salman Ahmed	702c6ae658	Fix SettingsToolboxGroup not clearing transforms before updating autosize	2022-05-09 13:49:31 +03:00
Dean Herbert	1c63c27fdf	Merge branch 'master' into new-chat-drawable-channel	2022-05-09 18:23:00 +09:00
Dan Balasescu	e9cc3ab54a	Merge pull request #18164 from Joehuu/fix-exit-dialog-bad-state ... Fix popup dialog potentially not clicking last button when dismissed	2022-05-09 17:22:03 +09:00
Jai Sharma	623e2c94ae	Adjust padding	2022-05-09 00:32:22 +01:00
Jai Sharma	aeb2984989	Move ChatOverlayDrawableChannel to it's own file	2022-05-09 00:31:22 +01:00
Jai Sharma	5f80e344c3	Update day separator date text to right align against username	2022-05-09 00:15:08 +01:00
Joseph Madamba	21e1f4546a	Fix popup dialog potentially not clicking last button when dismissed	2022-05-08 14:40:30 -07:00
Joseph Madamba	172d14bcc6	Improve code quality of mod column flow container	2022-05-08 11:40:14 -07:00
Bartłomiej Dach	d964b4f23c	Fix uneven spacing when some mod columns are hidden	2022-05-08 15:40:21 +02:00
Bartłomiej Dach	6bdcf893b7	Move alpha management closer to screen level ... Felt bad messing with alpha at the column level.	2022-05-08 15:40:10 +02:00
Bartłomiej Dach	92ccec20d7	Hide mod columns if all mods within are filtered out	2022-05-08 14:53:59 +02:00
Dean Herbert	b8cb2c1b82	Increase scroll amount slightly	2022-05-08 19:57:03 +09:00
Dean Herbert	778497b9e2	Scroll mod select slightly into view on first display	2022-05-08 18:58:54 +09:00
Bartłomiej Dach	b92d95a17a	Fix mod panels playing samples when hidden at a higher level	2022-05-08 10:39:49 +02:00
Bartłomiej Dach	81ca534f87	Implement ISamplePlaybackDisabler in mod select	2022-05-08 10:39:49 +02:00
Dean Herbert	230c4e27b8	Simplify and centralise hiding logic for mod overlay ... Behaviourally, this also always toggles via button triggering to add the button flash animation.	2022-05-08 13:03:28 +09:00
Jai Sharma	8da7bbd322	Code quality	2022-05-07 23:30:46 +01:00
Jai Sharma	c0643cae75	Create ChatOverlayDaySeparator and use in ChatOverlayDrawableChannel	2022-05-07 23:24:34 +01:00
Jai Sharma	f4acfbd0df	Change return type of CreateDaySeparator to Drawable	2022-05-07 22:23:46 +01:00
Jai Sharma	bec28c5b28	Remove virtual ColourInfo properties from DaySeparator	2022-05-07 22:16:11 +01:00
Bartłomiej Dach	46d3220c07	Isolate sample screens from global mods bindable ... Fixes scenario wherein entering the first run setup overlay, exiting at the "UI scale" step (which shows a song select), then moving to actua song select and trying to select a mod would lead to a crash. The crash was caused by two active mod screen instances attempting to swap the global mod bindable's mod instances for ones they owned. This logic - while generally problematic and hard to maintain - was fixing several issues with mod reference management and setting copying, so I'm letting it live another day. This change will mean that the song select preview on the "UI scale" step will not receive the same mods that the actual game has enabled. That said, it already doesn't use the same beatmap or ruleset, so this looks fine to break.	2022-05-07 21:44:58 +02:00
Dean Herbert	2278da563e	Add various xmldoc for nested classes	2022-05-08 02:03:28 +09:00
Dean Herbert	03c80d9197	Reorder methods / properties in ModSelectScreen for legibility	2022-05-08 01:58:37 +09:00
Dean Herbert	1d27ef18dc	Add xmldoc for IsValidMod	2022-05-08 01:49:29 +09:00
Dean Herbert	0d32bf91eb	Hardcode hide key handling in ModSelectScreen	2022-05-08 01:35:11 +09:00
Bartłomiej Dach	0c2b4a6c0b	Fix invalid IsLoaded check ... Would fail when `availableMods` would be changed from a different thread while the columns aren't loaded.	2022-05-07 15:44:22 +02:00
Bartłomiej Dach	528342411e	Merge branch 'master' into mod-overlay/integration	2022-05-07 13:52:19 +02:00
Bartłomiej Dach	fe69bd7ed9	Merge branch 'master' into change-mod-scroll-behaviour	2022-05-07 13:29:02 +02:00
Bartłomiej Dach	9a56f6db44	Merge branch 'mod-overlay/back-button' into mod-overlay/integration	2022-05-07 13:15:13 +02:00
Bartłomiej Dach	a716f62a6a	Flash back button when keyboard back binding is pressed	2022-05-07 13:01:36 +02:00
Salman Ahmed	d4c9de8596	Move button width in mod select to constant	2022-05-07 13:23:48 +03:00
Salman Ahmed	8ee3fdd0aa	Change mod scrolling behaviour to not scroll horizontally on columns/settings	2022-05-07 12:15:11 +03:00
Bartłomiej Dach	fd75963ca2	Dismiss mod select if select binding is pressed	2022-05-07 11:01:05 +02:00
Bartłomiej Dach	e7e7486a8e	Merge branch 'mod-overlay/back-button' into mod-overlay/integration	2022-05-07 10:59:30 +02:00
Bartłomiej Dach	b72cf4cd5d	Merge branch 'mod-overlay/localisation-strings' into mod-overlay/back-button	2022-05-07 10:58:09 +02:00
Bartłomiej Dach	f761d4d4d4	Reuse "select/deselect all" localisable string on column toggle	2022-05-07 10:56:03 +02:00
Bartłomiej Dach	fa0a256f48	Add localisable string for difficulty multiplier display	2022-05-07 10:48:15 +02:00
Bartłomiej Dach	271d64fd54	Add back button to mod select overlays	2022-05-07 10:17:32 +02:00
Bartłomiej Dach	6ad990dfc3	Add basic localisation strings for new mod select	2022-05-07 10:17:24 +02:00
Bartłomiej Dach	4ff96f82be	Dim other buttons if customisation panel is open	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	18e4c3ed0f	Update mod columns even if they're not present/offscreen ... Important to make "select/deselect all" operations work on all columns simultaneously, even if they're offscreen. Unfortunately by the nature of how the existing selection animation works, it is hard-tied to the update loop, so we need to compensate.	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	9514a5cef7	Only load panels asynchronously outside of BDL	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	9f96dd47d1	Remove schedule in panel load ... It was causing selection/deselection of all mods to work improperly if a select/deselect all operation was requested before the panel was scrolled into view. In general the schedule was an over-optimisation - the game-global set of available mods shouldn't be changing so often as to warrant such an aggressive debounce.	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	852e4a9766	Add select/deselect all buttons to free mod select screen	2022-05-07 09:29:33 +02:00
Bartłomiej Dach	0b95594f60	Add some more padding between footer and column scroll	2022-05-07 09:29:33 +02:00
Bartłomiej Dach	0c6de331f3	Move footer button padding to a higher level	2022-05-07 09:29:32 +02:00
Dean Herbert	dd63657dfb	Merge pull request #18065 from huoyaoyuan/code-style ... Enforce code style analysis shipped with .NET SDK	2022-05-07 14:58:19 +09:00
Jai Sharma	6fc808be22	Code quality	2022-05-06 23:17:59 +01:00
Jai Sharma	9d62206176	Update new chat overlay day separator colours and spacing ... Updates the `DaySeparator` component to have separately settable colours for the text and the lines. Updates existing overrides of the `DaySeparator` to use the new colour setter. Create new `ChatOverlayDrawableChannel` with adjusted spacing and new `DaySeparator` colours.	2022-05-06 23:06:18 +01:00
Bartłomiej Dach	8c73ed7207	Fix sequence equality check not using reference comparison	2022-05-06 21:47:04 +02:00
Bartłomiej Dach	621f746789	Do not modify selected mods through panel state change during external update	2022-05-06 21:47:04 +02:00
Bartłomiej Dach	c199b8fcb6	Simplify state management in ModColumn ... Bad sign when you can't follow your own code. All of the various state changing methods were flattened into one because it was too hard to follow what was calling what and why.	2022-05-06 21:46:16 +02:00
Salman Ahmed	1409f8ca96	Merge branch 'master' into fix-toolbox-expansion	2022-05-06 18:00:01 +03:00
Bartłomiej Dach	c533c93ffd	Remove leftover border thickness spec in mod settings area ... Was never supposed to be there, it was a vestige of a previous design iteration that went by unnoticed.	2022-05-06 15:34:49 +02:00
Bartłomiej Dach	e527574ede	Merge branch 'master' into fix-toolbox-expansion	2022-05-06 13:47:36 +02:00
Dean Herbert	98eab9668d	Merge pull request #18119 from bdach/mod-overlay/broken-hover ... Fix mod panels not hovering correctly after closing customisation area via mouse on new mod select	2022-05-06 20:42:33 +09:00
Bartłomiej Dach	e9d52aa954	Remove not-accessed field	2022-05-06 13:09:37 +02:00
Bartłomiej Dach	a915b7333c	Remove unused using directive	2022-05-06 13:08:54 +02:00
Dean Herbert	88c190f3e3	Change colour denoting expanded state to be gray rather than yellow ... I always found the yellow colour very non-descript in this case. Gray seems to work better?	2022-05-06 19:45:17 +09:00
Dean Herbert	b432885e5f	Tidy up ordering of SettingsToolboxGroup	2022-05-06 19:39:09 +09:00
Dean Herbert	59add66632	Remove unnecessary autosize workaround (was fixed long ago)	2022-05-06 19:39:00 +09:00
Dean Herbert	949e30c4b4	Remove auto-expansion of individual toolbox groups when parent expanding container expands	2022-05-06 19:36:41 +09:00
Bartłomiej Dach	08fd0ea086	Fix click-to-return container still handling hover when inactive	2022-05-06 12:28:53 +02:00
Dean Herbert	be960eb092	Move dangerous hold specification to base class	2022-05-06 14:34:31 +09:00
Dean Herbert	0d8e42b941	Merge branch 'master' into exit-multiplayer-is-dangerous	2022-05-06 14:25:18 +09:00
Jai Sharma	0974de8fb0	Use BindableFloat for chat height	2022-05-05 23:13:32 +01:00
Jai Sharma	16a6c11bc8	Clamp maximum and minimum height the chat overlay can be resized to	2022-05-05 21:40:37 +01:00
Bartłomiej Dach	34cf4c6a38	Fix mod overlay not closing on toggle hotkey	2022-05-05 22:16:56 +02:00
Bartłomiej Dach	a56eab2c47	Extract interface for overlay management	2022-05-05 22:16:55 +02:00
Bartłomiej Dach	ac08498f35	Use plum colour scheme in multiplayer to match rest of multiplayer screens	2022-05-05 22:16:54 +02:00
Bartłomiej Dach	79e1b93b30	Close customisation area on escape press before exiting	2022-05-05 19:17:36 +02:00
Bartłomiej Dach	2cc56a4b19	Fix hidden issue with automatic customisation panel show logic ... Doesn't cause tests to fail headless, but they do fail in the test browser.	2022-05-05 19:17:36 +02:00
Dean Herbert	9d48bb41c9	Merge branch 'master' into new-chat-overlay	2022-05-05 23:12:31 +09:00
Jai Sharma	5ea6f62951	Ensure RelativePositionAxes is set in BDL for animations to work	2022-05-05 14:20:33 +01:00
Dan Balasescu	e46f99bdba	Merge branch 'master' into dialog-overlay-thread-woes	2022-05-05 20:57:51 +09:00
Dean Herbert	97221d2ef1	Tidy up initialisation	2022-05-05 19:24:18 +09:00
Dean Herbert	e54f5e2d92	Adjust value change variables to avoid e usage	2022-05-05 19:22:20 +09:00
Dean Herbert	74505ba166	Remove ! usage (also seems to fix height saving/loading)	2022-05-05 19:22:12 +09:00
Dean Herbert	25ea660b0b	Replace HandlePositionalInput override with simple hover effect	2022-05-05 19:13:48 +09:00
Dean Herbert	4efaa41670	Merge branch 'master' into new-chat-overlay	2022-05-05 18:57:00 +09:00
Dean Herbert	f6a6a11391	Remove DialogOverlay local fades (is already managed by PopupDialogs themselves)	2022-05-05 15:02:23 +09:00
Dean Herbert	326ff3b6e9	Fix CurrentDialog being updated twice, unsafe variable access	2022-05-05 14:55:05 +09:00
Dean Herbert	a27fcda9f1	Fix failing tests due to CurrentDialog being unexpectedly not set after Push	2022-05-05 01:52:39 +09:00
Salman Ahmed	e294069e2f	Merge branch 'master' into beatmap-selection-keybinding	2022-05-04 16:48:49 +03:00
Salman Ahmed	9416346c94	Globalise beatmap selection key bindings as "group" selection	2022-05-04 16:46:32 +03:00
Jai Sharma	1a85e1267b	Ensure focus is directed to ChatTextBox from ChatOverlay and add tests	2022-05-04 14:43:40 +01:00
Dean Herbert	ddab3c6d80	Tidy up state variables	2022-05-04 21:00:11 +09:00
Dean Herbert	383245f43a	Fix dialoged pushed to DialogOverlay too early potentially doing cross-thread transforms ... As seen at https://github.com/ppy/osu/runs/6287700705?check_suite_focus=true.	2022-05-04 20:23:36 +09:00
Dean Herbert	3eead5a6a3	Rename FlushAnimation to FlushPendingSelections to better match purpose	2022-05-04 19:40:08 +09:00
Jai Sharma	60999e83e0	Ensure ChatTextBox takes/leaves focus on chat overlay pop in/out	2022-05-03 22:33:36 +01:00
Jai Sharma	c17edb2848	Add padding to text in ChatTextBar to separate it from the textbox	2022-05-03 22:32:51 +01:00
Jai Sharma	50aee8b665	Ensure ChannelListSelector text also turns white when selected	2022-05-03 22:32:01 +01:00
Bartłomiej Dach	f5fa41356e	Rewrite mod instance management again to pass tests	2022-05-03 22:31:34 +02:00
Bartłomiej Dach	970361676b	Fix setting items not creating if mods initially not empty	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	e3641213e1	Always hide unimplemented mods on mod select screen	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	f91ee4b042	Reset panel mod instance settings to defaults on deselect	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	7c04bf5c53	Refactor mod reference management to meet test expectations	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	fe59f4ae58	Fix multiselection operation not flushing on close	2022-05-03 21:45:39 +02:00
Bartłomiej Dach	746a4a7403	Fix mod column using wrong equality type	2022-05-03 21:45:39 +02:00
Dean Herbert	2896612c5c	Make exiting multiplayer a dangerous operation, requiring hold	2022-05-03 16:06:04 +09:00
Dean Herbert	04fb0f5e63	Merge pull request #18063 from GSculerlor/split-searchbox ... Split `SearchTextBox` implementation for reusability	2022-05-03 14:12:44 +09:00
Huo Yaoyuan	7cf4dabe29	Fix IDE0005 and IDE0034	2022-05-03 13:09:19 +08:00
Dean Herbert	faeefc5e18	Merge pull request #16576 from frenzibyte/osu-distance-spacing ... Add "distance spacing" support in editor for osu! ruleset	2022-05-03 12:15:18 +09:00
Ganendra Afrasya	81be69e72e	Update search textbox implementation to use BasicSearchTextBox instead	2022-05-03 06:18:42 +07:00
Jai Sharma	a931b1ecc3	Show selected channel text as white in ChannelListItem	2022-05-02 22:32:25 +01:00
Jai Sharma	7f8e00c1e3	Change "Add more channels" to sentence case in "ChannelList"	2022-05-02 21:22:47 +01:00
Jai Sharma	1473762e25	Don't wrap "chatting in.." text in ChatTextBar	2022-05-02 20:57:39 +01:00
Jai Sharma	e6f1ac6bec	Ensure "chatting in..." text is aligned with chat message	2022-05-02 20:45:38 +01:00
Bartłomiej Dach	2b4a49e17f	Merge branch 'master' into move-difficulty-graph-toggle	2022-05-02 16:38:25 +02:00
Dean Herbert	c3e0ba5c8d	Fix clicking anywhere in the beatmap overlay dismissing it	2022-05-02 20:27:00 +09:00
Salman Ahmed	337ee8f4c7	Merge branch 'master' into fix-first-run-ui-scale-applying-rate-adjust	2022-05-02 12:14:24 +03:00
Dean Herbert	53d65e8215	Merge pull request #18021 from frenzibyte/overlay-ruleset-selector-redesign ... Update overlay ruleset selector inline with osu-web design	2022-05-02 17:53:01 +09:00
Dean Herbert	4b30d0e59b	Fix first-run overlay's song select applying track adjustments ... Closes https://github.com/ppy/osu/issues/18041.	2022-05-02 17:42:57 +09:00
Jai Sharma	4bd1d09148	Remove blank line	2022-05-01 12:20:11 +01:00
Jai Sharma	de393f735f	Implement basic layout and behaviour of new chat overlay ... Provides initial implementation of new chat overlay in component `ChatOverlayV2`. Contains only the basic functionality required for a functioning chat overlay according to the new design with the intent of added the rest of the functionality in subsequent PRs. Backports existing tests for the current chat overlay except for ones testing keyboard shortcuts (since they haven't been added) and tab closing behaviour (since no tabs).	2022-04-30 23:59:47 +01:00
Salman Ahmed	ba5da8a52a	Fix tooltips not shown on selected tab	2022-04-30 15:37:44 +03:00
Salman Ahmed	c7ab9a8928	Add ruleset tab item tooltips	2022-04-30 15:37:44 +03:00
Salman Ahmed	3996972867	Remove unnecessary f suffix	2022-04-30 12:23:08 +03:00
Dean Herbert	27ee990359	Update first-run overlay footer buttons to use new sheared design	2022-04-29 23:45:17 +09:00
Salman Ahmed	9ea3e244e7	Adjust ruleset tab item content spacing to match web ... Not too noticeable, but better match web in any case.	2022-04-29 12:48:09 +03:00
Salman Ahmed	4016fe1e19	Adjust profile ruleset selector to new design ... Looks weird with `AlwaysPresent`.	2022-04-29 12:19:55 +03:00
Salman Ahmed	3829d27845	Update overlay ruleset selector design	2022-04-29 12:19:22 +03:00
Salman Ahmed	fef94d49f4	Revert "Convert data type of DistanceSpacing to float" ... This reverts commit 7aaa88cac2.	2022-04-29 08:02:07 +03:00
Salman Ahmed	ef56dc07b5	Hide "modding" tab in user profile until it's implemented	2022-04-29 07:47:10 +03:00
Dean Herbert	c4495dafb6	Merge branch 'master' into move-difficulty-graph-toggle	2022-04-29 13:44:47 +09:00
Dan Balasescu	fc21de8138	Merge pull request #18008 from peppy/add-tutorial ... Add first run "beatmaps" screen	2022-04-29 13:10:45 +09:00
Dean Herbert	652e022fd6	Merge pull request #17973 from bdach/mod-overlay/dim-columns-offscreen ... Dim offscreen columns on new mod select overlay	2022-04-29 11:55:27 +09:00
Dean Herbert	845e7dba95	Reduce padding slightly to restore usability of UI scale screen	2022-04-29 11:27:14 +09:00
Dean Herbert	a75051cd00	Merge branch 'master' into add-tutorial	2022-04-29 11:25:17 +09:00
Bartłomiej Dach	96f6c918a8	Merge branch 'master' into first-run-behaviour-screen	2022-04-29 00:55:30 +02:00
Bartłomiej Dach	a748ad6426	Merge branch 'master' into first-run-header	2022-04-28 22:19:35 +02:00
Dean Herbert	a50dd2ae93	Fix rider failures in nullable	2022-04-28 20:15:40 +09:00
Dean Herbert	f300b62877	Add ScrollIntoView method which accepts an offset to allow usage in mod select	2022-04-28 20:03:54 +09:00
Dean Herbert	34457078eb	Merge pull request #18005 from nekodex/fix-missing-sfx ... Fix some missing/incorrect UI SFX	2022-04-28 19:45:59 +09:00
Dean Herbert	694f33b827	Add localisation of beatmaps screen	2022-04-28 19:33:16 +09:00
Dean Herbert	b6896376e7	Better signal when no beatmaps are loaded	2022-04-28 19:08:16 +09:00
Dean Herbert	88bfd5dece	Show current beatmap count on beatmap screen	2022-04-28 19:01:21 +09:00
Dean Herbert	4e0d70cbf4	Internalise bindable and progress handling to ensure transforms don't go backwards	2022-04-28 19:01:21 +09:00
Dean Herbert	9f6597695c	Only mark stable import complete if it actually completes	2022-04-28 19:01:21 +09:00
Dean Herbert	c860eb46b0	Split out button implementation into its own class	2022-04-28 19:01:21 +09:00
Dean Herbert	081275e0b9	Adjust text and layout	2022-04-28 19:01:21 +09:00
Dean Herbert	3c0bdcaf38	Rename screen, add tests and add stable import step	2022-04-28 19:01:21 +09:00
Dean Herbert	58399a5113	Add tutorial download support and improve the visuals "slightly"	2022-04-28 19:01:21 +09:00
Dean Herbert	973dd4bfa9	Add initial flow for download button / progress display	2022-04-28 19:01:21 +09:00
Dean Herbert	b042f1cad5	Add screen to perform bundled beatmap downloads	2022-04-28 19:01:21 +09:00
Dean Herbert	94a393c9d7	Merge branch 'master' into first-run-header	2022-04-28 19:00:12 +09:00
Salman Ahmed	691bec6f16	Use LocalisableString.Interpolate instead of invalid TranslatableStrings	2022-04-28 11:38:40 +03:00
Jamie Taylor	92cac0b74e	Fix TabControls using the wrong sample	2022-04-28 17:30:24 +09:00
Salman Ahmed	be2d616e34	Fix localisation use cases not falling back to default(LocalisableString) ... Previously such use cases have been returning `null` values just fine since `GetLocalisableString` was returning `LocalisableFormattableString`, and these null values were wrapped in `LocalisableString`s implicitly, therefore not requiring an explicit fallback string and `null` doesn't break anything.	2022-04-28 11:21:00 +03:00
Salman Ahmed	7aaa88cac2	Convert data type of DistanceSpacing to float	2022-04-28 10:24:36 +03:00
Dean Herbert	f3a0e2ed55	Increase fade duration	2022-04-28 14:59:39 +09:00
Dean Herbert	d0ccd6f895	Merge branch 'master' into first-run-header	2022-04-27 19:26:02 +09:00
Dean Herbert	e6bb5e84ec	Merge branch 'master' into move-difficulty-graph-toggle	2022-04-27 17:22:25 +09:00
Dean Herbert	1a345c06c6	Fix regression in nested scroll behaviour due to the top level scroll container's type changing	2022-04-27 17:10:27 +09:00
Dean Herbert	b29af28028	Fix mod panels not ignoring super key presses ... Most other usages have this included. Noticed that the panel was changing state when exiting the game using cmd-w. Would probably be nice to have an exposed `HasAnyModifierPressed` helper property.	2022-04-27 16:55:17 +09:00
Dean Herbert	18e6629161	Merge branch 'master' into first-run-behaviour-screen	2022-04-27 16:02:57 +09:00
Dean Herbert	0354dd5ce6	Add comment regarding section initialisation in ScreenBehaviour	2022-04-27 16:02:39 +09:00
Dean Herbert	0343687b85	Make apply default methods more explicit in behaviour	2022-04-27 15:59:39 +09:00
Bartłomiej Dach	a849bfcf60	Rewrite dim test to pass headless ... Unfortunately neuters the test a touch, but alas.	2022-04-26 23:11:41 +02:00
Bartłomiej Dach	921e8af3b0	Use more lenient column bounds for checking active state	2022-04-26 22:54:54 +02:00
Bartłomiej Dach	21377d2a4d	Fix inactive columns flickering on and off mid-scroll	2022-04-26 22:43:58 +02:00
Bartłomiej Dach	94d07e147f	Move dimming logic to custom scroll container	2022-04-26 22:37:40 +02:00
Bartłomiej Dach	e9c9c764ca	Fix column dim state changing when scrolling past extent	2022-04-26 22:26:58 +02:00
Bartłomiej Dach	13a36f2e51	Scroll to column when mouse is released rather than pressed	2022-04-26 22:01:24 +02:00
Bartłomiej Dach	b0d6e16658	Invert data flow in column dim implementation	2022-04-26 21:57:19 +02:00
Dean Herbert	280cd048f6	Fix joystick settings changing enabled state of config level bindables ... Just copied what we had in place for the mouse sensitivity setting. For tablet settings I believe I avoided this by just hiding the settings when not enabled. Might be a better way forward, but this is simplest for now. Run `TestSceneSettingsPanel` twice to get a crash without this change.	2022-04-26 17:31:28 +09:00
Dean Herbert	01fdb771ee	Add header text to first run setup screens	2022-04-26 16:22:41 +09:00
Dean Herbert	942f4e8ac2	Merge branch 'first-run-show-get-started' into first-run-behaviour-screen	2022-04-26 16:10:16 +09:00
Dean Herbert	a078440012	Show last step on back button as well	2022-04-26 16:03:17 +09:00
Dean Herbert	2c836e2d63	Fix scrollbar overlapping content	2022-04-26 15:55:32 +09:00
Dean Herbert	37ae39f5fe	Move "Next" localisation to common strings	2022-04-26 15:48:40 +09:00
Dean Herbert	71aa7c813e	Fix regressed logic for applying classic defaults	2022-04-26 15:33:39 +09:00
Dean Herbert	b41e273086	Convert function weirdness to property + bool	2022-04-26 15:06:27 +09:00
Bartłomiej Dach	e13d0d02ae	Use better way of calculating whether columns are fully on screen	2022-04-25 23:08:05 +02:00
Bartłomiej Dach	e384e074fb	Fix asymmetric margin of column scroll	2022-04-25 23:08:05 +02:00
Bartłomiej Dach	09c08248c4	Fix bounce when scrolling to first/last column	2022-04-25 23:08:05 +02:00
Bartłomiej Dach	ebc8429495	Dim offscreen columns & scroll to them if clicked	2022-04-25 23:08:04 +02:00
Dean Herbert	5e48b37569	Show "Get Started" text on first run button	2022-04-25 23:59:07 +09:00
Dean Herbert	07462384e8	Merge pull request #17930 from peppy/fix-song-select-music-control ... Fix nested song select in first-run dialog fiddling with global audio	2022-04-24 19:18:27 +09:00
Dean Herbert	d92c905600	Actually use exposed property	2022-04-24 18:15:35 +09:00
Dean Herbert	83970f009c	Merge branch 'master' into settings-filter-regression-fix-2	2022-04-24 17:40:25 +09:00
Dean Herbert	176d263252	Merge pull request #17942 from maromalo/master ... Add joystick/gamepad deadzone setting	2022-04-24 17:39:48 +09:00
Dean Herbert	c5e8f1d4ab	Merge pull request #17958 from peppy/fix-hide-case ... Remove localisation of "hide" string to fix incorrect case	2022-04-24 17:38:49 +09:00
Dean Herbert	66b47d22d7	Also fix case of login form username/password	2022-04-24 17:11:25 +09:00
Dean Herbert	1b2467d3ed	Disable first run screen from appearing on startup until it is more complete	2022-04-24 16:35:41 +09:00
Dean Herbert	2200067c52	Display deadzone as percentage and simplify surrounding code	2022-04-24 16:31:20 +09:00
Salman Ahmed	8ed39009fd	Encapsulate distance spacing control handling to a "distance toolbox composite" ... Encapsulated in a way which can allow further extensibility for the right-side area of toolboxes.	2022-04-24 08:33:03 +03:00
Salman Ahmed	4f8f27a58b	Merge branch 'master' into osu-distance-spacing	2022-04-24 05:23:30 +03:00
maromalo	5addcbf460	Changed KeyboardStep to 0.01	2022-04-23 13:16:20 -03:00
Dean Herbert	5d0842ac44	Add a few more classic defaults to missed settings	2022-04-23 21:53:47 +09:00
maromalo	6a87dfdabb	More Code Quality ... Double whoops.	2022-04-23 02:14:41 -03:00
maromalo	23ef1e194d	Code Quality ... Whoops.	2022-04-23 01:52:59 -03:00
maromalo	85c47e1ba7	Merge branch 'ppy:master' into master	2022-04-23 00:17:40 -03:00
maromalo	27f3499330	Add joystick/gamepad deadzone setting ... Also splits joystick/gamepad into a new sub-section.	2022-04-23 00:17:00 -03:00
Bartłomiej Dach	98b7b156c7	Merge branch 'master' into first-run-setup-sheared-overlay	2022-04-23 00:32:07 +02:00
Salman Ahmed	7be2596312	Fix MatchingFilter being false by default	2022-04-22 23:50:58 +03:00
Bartłomiej Dach	e246357b36	Merge branch 'master' into sheared-overlay-container-click-away	2022-04-22 22:26:35 +02:00
Salman Ahmed	5120faa830	Merge branch 'master' into mod-overlay/incompatibility-panels-clickable	2022-04-22 22:19:42 +03:00
Salman Ahmed	4c7c611218	Fix settings overlay not invalidating presence on filter change	2022-04-22 20:34:00 +03:00
Dean Herbert	1caee38768	Add first-run "behaviour" screen to allow users a choice of more familiar UX	2022-04-22 18:06:56 +09:00
Dean Herbert	e0b9ab022d	Add classic default values against setting controls	2022-04-22 18:05:24 +09:00
Dean Herbert	2a043aa6de	Add a method of finding and applying settings with classic default value	2022-04-22 18:04:43 +09:00
Dean Herbert	7258a09748	Allow SettingsSections to exit without a parent SettingsPanel	2022-04-22 18:04:07 +09:00
Dan Balasescu	b1cf917b49	Merge pull request #17823 from peppy/settings-filter-fixes ... Fix incorrect settings state if searching too quickly (during load process)	2022-04-22 16:38:41 +09:00
Dean Herbert	f735d381a7	Merge branch 'master' into mod-overlay/incompatibility-panels-clickable	2022-04-22 16:26:46 +09:00
Salman Ahmed	33d516eecb	Move guest participation beatmap up to below loved	2022-04-22 09:28:29 +03:00
Dean Herbert	82a1d1cc2e	Fix multiplier display not blocking input	2022-04-22 15:22:58 +09:00
Salman Ahmed	40d823bf69	Use localised string for guest participation beatmaps header	2022-04-22 09:18:46 +03:00
Salman Ahmed	2c21bd89e7	Display beatmap guest participations in user profile	2022-04-22 07:56:01 +03:00
Salman Ahmed	a9ea0ab91b	Add support for fetching user guest participations	2022-04-22 07:55:39 +03:00
Bartłomiej Dach	b7c11cdb8e	Deselect old incompatible mods if any on user mod select screen	2022-04-21 23:49:30 +02:00
Bartłomiej Dach	32722adba9	Allow mod panels to be clicked in incompatible state	2022-04-21 23:37:01 +02:00
Bartłomiej Dach	8fe4443029	Update screen method signatures to match framework API changes	2022-04-21 22:29:23 +02:00
Bartłomiej Dach	8c6864727e	Merge branch 'master' into first-run-setup	2022-04-21 22:14:57 +02:00
Dean Herbert	749b86f0f4	Use new framework exposed event instead of schedule	2022-04-22 00:55:17 +09:00
Dean Herbert	119a81849c	Merge branch 'update-framework' into settings-filter-fixes	2022-04-22 00:55:15 +09:00
Dean Herbert	832d37b2c2	Update screen transition events to use new event args	2022-04-22 00:52:44 +09:00
Dean Herbert	ed6481f708	Also rename Welcome to WelcomeTitle to match other usages	2022-04-21 19:55:51 +09:00
Dean Herbert	1f967ecba3	Update string keys and change "setup" to "set up" to fix grammar	2022-04-21 19:52:28 +09:00
Dean Herbert	d17c16d904	Merge branch 'master' into first-run-setup	2022-04-21 19:50:26 +09:00
Dean Herbert	55270df6fc	Merge pull request #17833 from jai-x/new-chat-channel-list ... Implement `ChannelList` for new chat design	2022-04-21 16:34:35 +09:00
Dean Herbert	0b81ae9de2	Convert to using sheared overlay container ... Add better click-to-dismiss logic for sheader overlays	2022-04-21 16:28:44 +09:00
Dean Herbert	5c21a55e00	Merge branch 'sheared-overlay-container-click-away' into first-run-setup-sheared-overlay	2022-04-21 16:28:33 +09:00
Dean Herbert	0f4b40ab15	Add better click-to-dismiss logic for sheared overlays	2022-04-21 16:27:27 +09:00
Dean Herbert	7d8cf1bbb6	Merge branch 'master' into first-run-setup	2022-04-21 15:49:39 +09:00
Dan Balasescu	54ca4b9d36	Remove unused using	2022-04-21 15:34:14 +09:00
Dean Herbert	5c0e5eb6f4	Merge pull request #17899 from Joehuu/localise-most-strings ... Use existing web localisation for most hardcoded strings	2022-04-21 14:48:12 +09:00
Dean Herbert	9f525ee267	Revert localisation of spectate/watch button	2022-04-21 14:09:51 +09:00
Dean Herbert	56d8de23e2	Replace horse with "more suitable" icon ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-04-21 12:18:54 +09:00
Joseph Madamba	5e5c8e78a6	Use existing web localisation for most hardcoded strings	2022-04-20 16:31:11 -07:00
Jai Sharma	5319bce772	Revert DI usage of ChannelSelectorState in favour of directly binding BindableBool SelectorActive	2022-04-20 21:05:33 +01:00
Jai Sharma	e596c9d171	Use Bindable<ChannelSelectorState> to control selector active visibility	2022-04-20 19:12:43 +01:00
Dean Herbert	4466e15bfc	Rename AllowConfiguration to AllowCustomisation and simplify drawable addition	2022-04-20 23:17:29 +09:00
Dean Herbert	b722ff8dc5	Merge branch 'master' into mod-overlay/extension-points	2022-04-20 23:17:04 +09:00
Dean Herbert	8c2d70e93f	Disable forward button when already at end	2022-04-20 17:50:31 +09:00
Dean Herbert	65b2db5e71	Move shear constant to overlay (this is going to likely be used everywhere ever)	2022-04-20 16:30:58 +09:00
Dean Herbert	e17f224793	Fix padding mismatches	2022-04-20 16:28:52 +09:00
Dean Herbert	5c7ff363ce	Move title/description to correct class	2022-04-20 16:08:00 +09:00
Dean Herbert	2ee37aeceb	Reduce nesting and usage of GridContainer	2022-04-20 16:01:15 +09:00
Dean Herbert	1032dc235d	Rename PopupScreenTitle to ShearedOverlayHeader	2022-04-20 16:01:15 +09:00
Dean Herbert	8d31b0bc01	Split out the base design of sheared overlay into its own abstract class ... This will allow for reuse with the first-run overlay.	2022-04-20 15:50:16 +09:00
Dean Herbert	66373bf038	Move back button enable handling to shared method	2022-04-20 14:50:41 +09:00
Dean Herbert	9797e2d887	Rename showLastStep method to avoid ambiguity	2022-04-20 14:49:17 +09:00
Dean Herbert	488fc9db67	Reverse content colours to match design spec	2022-04-20 14:48:51 +09:00
Bartłomiej Dach	f82d58fa6a	Merge branch 'master' into update-paginated-profile-items-count	2022-04-19 22:17:26 +02:00
Jai Sharma	44c822f34d	Use normal OsuScrollContainer for ChannelList	2022-04-19 16:56:55 +01:00
Dean Herbert	ce70c10afa	Tidy up unused dependencies	2022-04-19 18:00:39 +09:00
Dean Herbert	17eaa44af1	Ensure notifications don't interrupt the first run setup process	2022-04-19 17:40:35 +09:00
Dean Herbert	e2da1d76ca	Only show first run setup once per install	2022-04-19 16:59:25 +09:00
Dean Herbert	3378c91901	Fix double applied padding	2022-04-19 16:59:04 +09:00
Dean Herbert	1490502d4c	Improve overall usability of scale adjust screen	2022-04-19 16:59:04 +09:00
Dean Herbert	c27831145c	Add scroll and flow at the FirstRunSetupScreen level	2022-04-19 16:37:29 +09:00
Dean Herbert	6d534046ff	Add keyboard traversal support for first run dialog (and tidy up step traversal logic)	2022-04-19 14:57:15 +09:00
Dean Herbert	e67cc293b8	Add localisation support for all new strings	2022-04-19 14:53:01 +09:00
Dean Herbert	5dc3805005	Fix stack nullability	2022-04-19 14:53:01 +09:00
Dean Herbert	02f8367d66	Improve animation when showing/hiding first run overlay	2022-04-19 14:53:01 +09:00
Dean Herbert	2682373bf2	Use existing blocking / exit logic provided by OsuFocusedOverlayContainer	2022-04-19 14:53:01 +09:00
Dean Herbert	9074eb283d	Show a notification instead of blocking exit of wizard	2022-04-19 14:53:01 +09:00
Dean Herbert	3ea4eabdb6	Ensure button text is updated on going backwards	2022-04-19 14:53:01 +09:00
Dean Herbert	fb7dc89503	Ensure wizard returns to initial screen after completion	2022-04-19 14:53:01 +09:00
Dean Herbert	6716621444	Re-fix clicking inside display also dismissing	2022-04-19 14:53:01 +09:00
Dean Herbert	11395c40b7	Add button to access first run setup on demand	2022-04-19 14:53:01 +09:00
Dean Herbert	ea52fab5b1	Tidy up dependencies and test naming	2022-04-19 14:53:01 +09:00
Dean Herbert	56c4283764	Only exit dialog from click if outside the dialog content	2022-04-19 14:53:01 +09:00
Dean Herbert	288f759bb4	Add test coverage of navigation	2022-04-19 14:53:01 +09:00
Dean Herbert	07da1cd731	Move buttons to top level and add backwards navigation	2022-04-19 14:53:01 +09:00
Dean Herbert	3b94e01fe6	Improve layout of ui scale step	2022-04-19 14:53:01 +09:00
Dean Herbert	e064f2f23e	Improve general layout and allow overlay to be displayed without dependencies for now	2022-04-19 14:53:01 +09:00
Dean Herbert	c2df3465b2	Add ui scaling setup screen, kind of	2022-04-19 14:53:01 +09:00
Dean Herbert	ae07b2b512	Initial setup	2022-04-19 14:53:01 +09:00
Dean Herbert	83e89b3e80	Add unread count to INotificationOverlay and fix toolbar button DI logic	2022-04-19 11:16:45 +09:00
Salman Ahmed	c858ec2483	Pagination -> `PaginationParameters	2022-04-19 02:48:34 +03:00
Salman Ahmed	96d4369cc8	Introduce Pagination and simplify paginated API requests	2022-04-19 02:04:23 +03:00
Dan Balasescu	bb8b94f8ad	Merge branch 'master' into i-notification-overlay	2022-04-19 06:03:56 +09:00
Dan Balasescu	94e892df1c	Merge pull request #17862 from peppy/i-dialog-overlay ... Split out `IDialogOverlay` to allow for easier testing	2022-04-19 05:24:05 +09:00
Salman Ahmed	f08449e432	Update paginated profile subsections to display items inline with web	2022-04-18 23:04:21 +03:00
Salman Ahmed	1fc28552b5	Minor reword inline comment	2022-04-18 21:07:20 +03:00
Salman Ahmed	16a0efc562	Cache IDialogOverlay as its type in interface	2022-04-18 21:06:27 +03:00
Dean Herbert	5d5e46ede7	Fix rider incompetency	2022-04-18 23:10:07 +09:00
Dean Herbert	aaf5577e6a	Remove unnecessary canBeNull specification	2022-04-18 21:48:46 +09:00
Dean Herbert	d29312e070	Fix rider incompetency	2022-04-18 21:47:47 +09:00
Dean Herbert	043599081b	Split out INotificationOverlay to allow for easier testing	2022-04-18 20:14:01 +09:00
Dean Herbert	e315313266	Split out IDialogOverlay to allow for easier testing	2022-04-18 18:36:26 +09:00
Dean Herbert	2202863e1a	Split out IPerformFromScreenRunner to allow for easier testing	2022-04-18 17:49:28 +09:00
Bartłomiej Dach	0d5ce336f4	Hide mod customisation toggle if customisation not permitted	2022-04-17 23:28:53 +02:00
Bartłomiej Dach	881df7663d	Fix filter not taking effect if applied before panel load completion	2022-04-17 23:28:53 +02:00
Bartłomiej Dach	8af865a1c5	Fix incompatibility panel using reference equality	2022-04-17 23:28:53 +02:00
Bartłomiej Dach	ffb5c1e86c	Tweak colours on incompatibility displaying mod panel	2022-04-17 23:28:52 +02:00
Bartłomiej Dach	20c17b8c98	Make base mod select screen abstract	2022-04-17 23:28:51 +02:00
Bartłomiej Dach	7eebc20124	Add replacements for mod overlays used by game	2022-04-17 23:28:51 +02:00
Bartłomiej Dach	67c44db8d5	Add extension points required for replacing old mod overlay	2022-04-17 23:28:51 +02:00
Jai Sharma	47c8b8010f	Use semibold font weight for ChannelListItemFlow label	2022-04-16 23:03:03 +01:00
Jai Sharma	2f41cddb00	Remove redundant Expire call	2022-04-16 23:03:03 +01:00
Jai Sharma	36aea9009e	Move ChannelList scrollbar to the right	2022-04-16 23:03:03 +01:00
Jai Sharma	4a0c5a0781	Remove hover override for ChannelListScrollContainer	2022-04-16 23:02:54 +01:00
Bartłomiej Dach	15c54b38c1	Merge branch 'master' into fix-popup-dialog-handling-exit-sequence	2022-04-16 19:01:18 +02:00
Jai Sharma	b6631fb9f9	Add newline for base class call	2022-04-15 22:22:20 +01:00
Jai Sharma	a0a2f8118e	Code quality fixes	2022-04-15 22:05:20 +01:00
Jai Sharma	f1dd319fd9	Implement ChannelList for new chat design ... Reference design: https://www.figma.com/file/f8b2dHp9LJCMOqYP4mdrPZ/Client%2FChat?node-id=1%3A297 Adds new component `ChannelList` which makes up the sidebar channel selector of the new chat design. Contains two separate fill flows for public and private `ChannelItem` child components. Exposed bindable `SelectorActive` to indicate current state of the "Add more channels" button. Requires `Bindable<Channel>` from parent component. Renames and updates the `TestSceneChannelListItem` to `TestSceneChannelList` to make use of new component and having both tests seemed redundant.	2022-04-15 15:44:38 +01:00
Dean Herbert	423fae52f7	Add back base.IsPresent call	2022-04-15 10:19:36 +09:00
Dean Herbert	c57a918bbb	Mark settings elements as matching filter by default to handle cases where no filtering is provided	2022-04-14 23:02:00 +09:00
Salman Ahmed	da098d071f	Merge branch 'master' into settings-inactive-dim	2022-04-14 15:52:51 +03:00
Dean Herbert	b088959045	Reduce settings fade in duration to higher alpha/colour cross-talk	2022-04-14 21:17:06 +09:00
Dean Herbert	9240148c8e	Avoid initial fade of dim layer	2022-04-14 21:16:54 +09:00
Dean Herbert	f19208a245	Move dim layer to top and only apply dimming at one location	2022-04-14 21:04:52 +09:00
Dean Herbert	316c0845ec	Fix current section not being correct after early search	2022-04-14 20:36:49 +09:00
Dean Herbert	9c7af98982	Fix alpha cross-talk causing settings to potentially not filter when they should	2022-04-14 20:35:00 +09:00
Dean Herbert	296420ae08	Fix settings textbox focus operation running too late	2022-04-14 20:14:02 +09:00
Salman Ahmed	59bb6b8f7c	Add background dim effect to inactive settings sections	2022-04-14 13:43:12 +03:00
Salman Ahmed	566a20a623	Add keyword "delay" to hold-to-confirm activation time setting	2022-04-14 13:27:12 +03:00
Dean Herbert	1fdf742d38	Fix potentially incorrect button being pressed during PopupDialog hide due to flag set too late	2022-04-14 17:51:50 +09:00
Dean Herbert	f9d9e6aa61	Ensure popup dialogs are hidden before running any associated actions	2022-04-14 16:19:34 +09:00
Dan Balasescu	494955aff1	Resolve inspection issues	2022-04-14 13:11:11 +09:00
Salman Ahmed	bad30d9e60	Fix dialog dangerous button being clickable at edges	2022-04-11 21:05:37 +03:00
Salman Ahmed	134d9b5ddf	Perform Show() at the bottom of the method ... Probably not affecting behaviour, but makes more sense.	2022-04-08 19:28:04 +03:00
Dean Herbert	57fb8616b8	Fix potential null reference when attempting to highlight a message before overlay has been displayed	2022-04-09 00:31:00 +09:00
Dean Herbert	ae1e126837	Make HighlightMessage implicitly show chat overlay	2022-04-09 00:30:28 +09:00
Bartłomiej Dach	e658b63dbc	Merge branch 'master' into clock	2022-04-07 20:27:23 +02:00
Salman Ahmed	a616f5bc2a	Fix regressed digital clock width conditional	2022-04-07 19:24:15 +03:00
Salman Ahmed	c323020fcf	Fix Use24HourDisplay conditional flipped	2022-04-07 15:56:28 +03:00
Dean Herbert	b2c0eaeab4	Make string read better	2022-04-07 18:20:15 +09:00
Dean Herbert	555aee7b6a	Remove incorrect and pointless complexity to width changes	2022-04-07 18:16:14 +09:00
Dean Herbert	7530fe5adf	Move default specification to configuration initial value	2022-04-07 18:13:23 +09:00
Dean Herbert	37509e04a9	Rename variable and fix inspections	2022-04-07 18:11:30 +09:00
Perry MacMurray	2525ec0d18	Switch 24H toggle from UI settings to language settings	2022-04-05 17:07:58 -04:00
Perry MacMurray	9d475f7b33	Add config in settings for forcing 24H time, determines default off CurrentCulture	2022-04-05 16:21:28 -04:00
Bartłomiej Dach	9c91e6d8f5	Merge branch 'master' into mod-overlay/full-screen	2022-04-05 21:29:40 +02:00
Perry MacMurray	74706f72e6	Add 12-hour display setting (TODO add toggle)	2022-04-05 15:10:55 -04:00
Dean Herbert	ac799aaf7a	Add missing newline	2022-04-05 19:25:47 +09:00
Dean Herbert	32daf64a31	Use newly exposed framework helper function to find closest parent	2022-04-05 19:24:34 +09:00
Dean Herbert	631aa2a6ec	Remove left padding to allow left-most column to exist further to the.. left	2022-04-05 18:44:25 +09:00
Dean Herbert	54715885af	Adjust animation metrics slightly	2022-04-05 18:41:01 +09:00
Dean Herbert	7a1820e6bb	Fix multiplier display resetting transformations	2022-04-05 18:40:48 +09:00
Dean Herbert	9fdeb20537	Animate individual ModColumns during togle of oerlay	2022-04-05 18:27:34 +09:00
Dean Herbert	901032bfa2	Animate multiplier display	2022-04-05 18:25:27 +09:00
Dan Balasescu	2b59f76b2d	Merge pull request #17596 from peppy/skin-editor-sprites ... Allow importing sprites into a skin via drag-and-drop	2022-04-05 17:38:58 +09:00
Dean Herbert	497e5e3a36	Slightly adjust scroll handling and also apply to ModSettingsContainer	2022-04-05 17:19:33 +09:00
Dean Herbert	a408776734	Limit FillFlow of columns to applicable direction	2022-04-05 17:15:05 +09:00
Dean Herbert	388322cd61	Speed up customisation panel toggle a bit	2022-04-05 16:56:24 +09:00
Dean Herbert	58e9147b12	Simplify and better comment nested scroll conditionals	2022-04-05 16:48:25 +09:00
Dean Herbert	f156cb797d	Improve nested scroll behaviour	2022-04-05 16:46:09 +09:00
Dean Herbert	23dad7bdc4	Move scroll view padding to content level ... Without doing this, there is a non-masked but also non-interactive area to the left or right of the view.	2022-04-05 16:43:00 +09:00
Bartłomiej Dach	9b367d645d	Always play pop in sequence	2022-04-04 20:02:47 +02:00
CenTdemeern1	9a07a95d39	Make several delete confirmation buttons dangerous buttons ... Includes: - Mass deletion - Beatmap deletion - Local score deletion	2022-04-04 19:22:53 +02:00
Dean Herbert	57b8c32f25	Remove unused fields	2022-04-04 20:42:14 +09:00
Dean Herbert	bc53adb72a	Adjust customisation transition slightly	2022-04-04 15:50:40 +09:00
Dean Herbert	b5df350007	Adjust pop in/out transitions	2022-04-04 15:45:44 +09:00
Dean Herbert	d6625413fa	Merge pull request #17617 from ajiiisai/proper-toggable-shortcuts-for-overlays ... Make overlay shortcuts able to be toggled instead of repeatable	2022-04-04 13:46:42 +09:00
Bartłomiej Dach	cd776d21a6	Fix propagation of selected mods to columns	2022-04-03 20:12:34 +02:00
Bartłomiej Dach	e46c2df409	Add testing for customisation panel show/hide logic	2022-04-03 20:12:33 +02:00
Bartłomiej Dach	293ef44836	Implement new mod select screen	2022-04-03 20:12:33 +02:00
Bartłomiej Dach	1393e3628b	Invert operands for better readability	2022-04-03 15:24:00 +02:00
Dean Herbert	969f7e121a	Merge pull request #17545 from jai-x/new-chat-textbox ... Implement `ChatTextBox` for new chat design	2022-04-03 22:12:12 +09:00
Bartłomiej Dach	970b1951ac	Rewrite logic slightly to better convey meaning of textbox clear	2022-04-03 14:26:08 +02:00
Jai Sharma	94fa5e2ef2	Use Action<string> for event OnChatMessageCommitted & clear textbox internally	2022-04-02 21:58:54 +01:00
Ame	35629e9be8	General fix for ToolbarButton toggle repetition	2022-04-02 20:45:00 +02:00
Bartłomiej Dach	28ba437d24	Merge branch 'master' into sucess-rate-tooltip	2022-04-02 19:31:45 +02:00
Jai Sharma	9e152cd3fd	Fix code quality issues	2022-04-02 17:27:44 +01:00
Jai Sharma	2297073b7e	Use OnChatMessageCommit & OnSearchTermsChanged events in ChatTextBar	2022-04-02 17:15:19 +01:00
Jai Sharma	b9421d1415	Simplify text clear and placeholder change in ChatTextBox	2022-04-02 17:14:27 +01:00
Salman Ahmed	beb8426d3b	Save beatmap listing card size to game config	2022-04-02 18:36:49 +03:00
Salman Ahmed	ced5be33e6	Display pass/play count in success rate percentage tooltip	2022-04-02 18:08:57 +03:00
Dean Herbert	6afed5e865	Fix new SettingsItem attribute not playing well with non-Drawables	2022-04-01 16:01:33 +09:00
Dean Herbert	66f5eae530	Hook up a dropdown to show all available sprites for the current skin	2022-04-01 15:01:43 +09:00
Joseph Madamba	d0873d67e1	Move difficulty graph toggle to individual skin settings	2022-03-31 18:56:57 -07:00
CenTdemeern1	86d262a355	Merge branch 'ppy:master' into clock-button	2022-03-31 23:08:30 +02:00
CenTdemeern1	bdb21b17f7	Fix my code according to the changes @bdach requested	2022-03-31 20:39:26 +02:00
CenTdemeern1	c64a90b39e	Remove a newline to comply with codefactor	2022-03-31 17:21:50 +02:00
CenTdemeern1	f1aa60c0f1	Make the clock feel more like a button	2022-03-31 16:26:53 +02:00
Dean Herbert	0a34ce2509	Increase font weight for runtime clock ... Fonts this small are required to be `SemiBold` by design guidelines. Somehow missed this.	2022-03-31 19:07:30 +09:00
Dean Herbert	e8a295a61b	Add test coverage of textbox focus in settings panels when switching between nested panels	2022-03-31 15:24:21 +09:00
Jai Sharma	fff30e8a6e	Simplify show/hide of text and search in ChatTextBar	2022-03-30 21:02:12 +01:00
Bartłomiej Dach	9621a7f9cb	Merge branch 'master' into fix-autoplay-mod-user-id	2022-03-30 21:41:45 +02:00
Jai Sharma	eec3fef7a6	Remove the enter box in ChatTextBar	2022-03-30 20:25:23 +01:00
Dean Herbert	975883da5c	Move all usages of client.realm filename to a single const	2022-03-30 13:34:48 +09:00
Jai Sharma	e7d2d94eee	Fix code quality issues in ChatTextBar	2022-03-30 02:16:50 +01:00
Jai Sharma	f049d7cb67	Implement ChatTextBox for new chat design ... Reference design: https://www.figma.com/file/f8b2dHp9LJCMOqYP4mdrPZ/Client%2FChat?node-id=1%3A297 Adds new component `ChatTextBox`. Exposes `BindableBool` `ShowSearch` to change text input behaviour between normal and search behaviour. Adds new component `ChatTextBar`. Exposes `BindableBool` `ShowSearch` which toggles between showing current chat channel or search icon. Additionally binds to child `ChatTextBox` components. Requires a cached `Bindable<Channel>` instance to be managed by a parent component.	2022-03-29 22:33:38 +01:00
Dean Herbert	4741679a94	Change confirmation message to be more clear about intentions ... Co-authored-by: Henry Lin <henry.ys.lin@gmail.com>	2022-03-29 19:03:50 +09:00
Dean Herbert	1fb3d11591	Add ability to "migrate" data to another folder which has an existing install ... Until now, migrating would always attempt to move files. There's a chance that a user is reinstalling osu! but has their data at a custom location. We want to allow the chance for them to continue using the external data. This seems like the easiest way to make it work. Would be nice if we had a `Game.Restart()` method, but maybe this is enough for now? Note that further down the road we will probably prompt the user to potentially select a custom install path (including one with existing data) before osu! gets to writing anything.	2022-03-29 18:04:31 +09:00
Dean Herbert	dc7dc7f65a	Update UserProfileOverlay and ClickableAvatar to treat system users more correctly	2022-03-28 22:57:16 +09:00
Salman Ahmed	b6822f8190	Remove redundant/outdated Origin line	2022-03-26 14:55:19 +03:00
Dean Herbert	9b7b897b3c	Adjust padding to fit better	2022-03-26 20:34:50 +09:00
Dean Herbert	ab8db3b7dc	Move nested classes to own files	2022-03-26 20:34:17 +09:00
Dean Herbert	4ddf3cb1d9	Add ability to cycle between clock display modes	2022-03-26 19:18:41 +09:00
Dean Herbert	97e9049a2c	Adjust metrics and colours to better match the actual toolbar	2022-03-26 18:56:40 +09:00
Dean Herbert	252d1924e7	Adjust metrics for better legibility at small sizes	2022-03-26 18:13:33 +09:00
Dean Herbert	999ae88af2	Show game time display in clock	2022-03-26 18:13:20 +09:00
Dean Herbert	e8f5a8e3d6	Refactor hands for legibility (visual and code)	2022-03-26 18:13:13 +09:00
Dean Herbert	0d8a7246dd	Add basic implementation of clock	2022-03-26 18:13:13 +09:00
Dean Herbert	1acfbf490b	Merge branch 'master' into mod-overlay/settings-area	2022-03-25 17:37:39 +09:00
Dean Herbert	2938f44e6c	Update PresentExternally usages in line with framework changes	2022-03-24 23:41:07 +09:00
Bartłomiej Dach	8647bebdca	Merge branch 'master' into hold-to-discard-changes	2022-03-22 20:37:43 +01:00
Bartłomiej Dach	8192fb47fe	Merge branch 'master' into skin-editor-eat-input	2022-03-22 19:22:48 +01:00
Dean Herbert	f95bd89166	Revert editor exit behaviour to exit without changes for now	2022-03-22 14:46:57 +09:00
Dan Balasescu	aea03ca21d	Merge pull request #17359 from frenzibyte/fix-score-panel-max-combo ... Improve method of retrieving beatmap maximum combo for results score panels	2022-03-22 06:28:30 +09:00
Dean Herbert	2f18c512cd	Convert SkinEditorOverlay to an OverlayContainer to allow it to block input	2022-03-21 17:33:56 +09:00
Dean Herbert	b42081dd9b	Add DangerousButton for use in popup dialogs	2022-03-21 16:06:45 +09:00
Dean Herbert	3bb01fd595	Fix close button animation not being applied correct on mouse down due to conflicting scales	2022-03-21 14:41:57 +09:00
Dean Herbert	7ca3beb7cc	Also add fade to ChannelItem selected box	2022-03-21 14:41:42 +09:00
Dean Herbert	428e439f40	Remove space between '#' and channel name ... This was in flyte's design (he was following discord) but doesn't feel too correct when it's not aligned with anything else. We can revisit this if/when we have better glyphs to represent channel types.	2022-03-21 14:36:56 +09:00
Dean Herbert	16caf2d30b	Add slight animation when highlighting an unread channel	2022-03-21 14:34:54 +09:00
Dean Herbert	692362131e	Add animation when mention pill appears (or a new message arrives)	2022-03-21 14:31:51 +09:00
Dean Herbert	11b050b66b	Add slight fade when hovering ChannelListItems	2022-03-21 14:28:14 +09:00
Dean Herbert	9eda2f2df1	Remove box surrounding close button	2022-03-21 14:25:29 +09:00
Dean Herbert	f922a6b556	Rename renaming button/pill classes	2022-03-21 14:15:22 +09:00
Dean Herbert	812343b410	Merge branch 'master' into new-chat-channel-control	2022-03-21 14:14:02 +09:00
Salman Ahmed	b9859f9f21	Obsolete BeatmapInfo.MaxCombo and suppress in usages	2022-03-20 16:30:29 +03:00
Jai Sharma	f3702fbefb	Pass correct params to UpdateableAvatar ctor in ChannelListItem	2022-03-19 22:20:17 +00:00
Jai Sharma	ba5a43b526	Rename ControlItem -> ChannelListItem and associated classes	2022-03-19 21:49:14 +00:00
Jai Sharma	653bb47dd5	Use UpdateableAvatar and remove redundant ControlItemAvatar class	2022-03-19 21:36:11 +00:00
Jai Sharma	5373c3066f	Use OsuAnimatedButton as base for ControlItemClose	2022-03-19 21:23:32 +00:00
Jai Sharma	a293e0c766	Remove redundant ControlItemText class	2022-03-19 16:44:58 +00:00
Dean Herbert	dfda093f4b	Rename icon creation method	2022-03-18 14:03:52 +09:00
Dean Herbert	5d940ded09	Fix incorrect usage of nullable in ControlItemMention	2022-03-18 13:59:03 +09:00
Dean Herbert	d1fd14e287	Add missing nullable	2022-03-18 13:57:36 +09:00
Salman Ahmed	7aae9bbd1b	Improve channel bindable logic in ChatOverlay to avoid potential nullrefs	2022-03-17 08:31:38 +03:00
Bartłomiej Dach	624f9fc774	Implement mod settings area component	2022-03-16 23:13:11 +01:00
Bartłomiej Dach	b21fa78cbf	Move dependencies out of fields to BDL args where possible	2022-03-16 21:55:36 +01:00
Dean Herbert	603527d72d	Fix potential crash when highlighting chat messages ... Test failed locally in `TestPublicChannelMention`. This test seems to specify that the same message may arrive twice with the same ID, so rather than overthinking this one I propose we just use `FirstOrDefault`. ```csharp TearDown : System.AggregateException : One or more errors occurred. (Sequence contains more than one matching element) ----> System.InvalidOperationException : Sequence contains more than one matching element --TearDown at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions) at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken) at osu.Framework.Extensions.TaskExtensions.WaitSafely(Task task) at osu.Framework.Testing.TestScene.checkForErrors() --InvalidOperationException at System.Linq.ThrowHelper.ThrowMoreThanOneMatchException() at System.Linq.Enumerable.TryGetSingle[TSource](IEnumerable`1 source, Func`2 predicate, Boolean& found) at System.Linq.Enumerable.SingleOrDefault[TSource](IEnumerable`1 source, Func`2 predicate) at osu.Game.Overlays.Chat.DrawableChannel.<processMessageHighlighting>b__14_0() in /Users/dean/Projects/osu/osu.Game/Overlays/Chat/DrawableChannel.cs:line 102 at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal() ```	2022-03-16 18:38:06 +09:00
Jai Sharma	e38d9eafa0	Use BindTarget instead of caching for ControlItem unread flow	2022-03-15 22:37:15 +00:00
Jai Sharma	49b74d7867	Use BindTarget instead of caching for ControlItem mentions bindable flow	2022-03-15 22:33:36 +00:00
Jai Sharma	481b8fe80b	Use Orange1 for ControlItemMention background colour	2022-03-15 22:22:32 +00:00
Jai Sharma	7621e779fa	Move ControlItem Action assignments into BDL	2022-03-15 22:19:58 +00:00
Jai Sharma	73a0373b4e	Code quality fixes	2022-03-14 21:56:56 +00:00
Jai Sharma	ec61b88ec2	Adjust ControlItem padding	2022-03-14 21:39:57 +00:00
Jai Sharma	75958bf270	Refactor ControlItemText to use bindable flow for unread state	2022-03-14 21:32:30 +00:00
Jai Sharma	b01a809d55	Refactor ControlItemMention to use bindable flow	2022-03-14 21:26:33 +00:00
Jai Sharma	1f0f6990f0	Use ColourProvider.Content1 for ControlItemText colour	2022-03-14 21:16:28 +00:00
Jai Sharma	3aa343b987	Use OsuColour.YellowLight for ControlItemMention background	2022-03-14 21:14:33 +00:00
Jai Sharma	9621ef9437	Use OsuColour.Red1 for ControlItemClose hover colour	2022-03-14 21:10:39 +00:00
Jai Sharma	e91af664ef	Adjust ControlItemAvatar placeholder animation and colour	2022-03-14 20:37:54 +00:00
Jai Sharma	12472593cc	Mark required dependencies as non-nullable	2022-03-14 20:14:04 +00:00
Jai Sharma	c0d82dfb41	Code quality fixes	2022-03-14 19:42:55 +00:00
Jai Sharma	39c30516d0	Implement ChannelControlItem for new chat design ... Adds new component `ChannelControlItem` and it's child components to be used as the clickable control in the new chat sidebar for joined channels. Has public properties `HasUnread` and `MentionCount` to control the display of the channel having unread messages or mentions of the user. Channel select/join requests are exposed via `OnRequestSelect` and `OnRequestLeave` events respectively which should be handled by a parent component. Requires a cached `Bindable<Channel>` instance to be managed by a parent component. Requires a cached `OveralayColourScheme` instance to be provided by a parent component.	2022-03-14 18:55:27 +00:00
Salman Ahmed	53c57661c7	Move implementtaion detail to inline comment	2022-03-11 18:34:22 +03:00
Salman Ahmed	5b70139b33	Avoid running message highlight processing more than once	2022-03-11 18:32:49 +03:00
Salman Ahmed	cc87563d57	Merge branch 'master' into chat-mention-highlight	2022-03-11 17:51:22 +03:00
Salman Ahmed	d07e3101ea	Improve message highlight handling in DrawableChannel	2022-03-10 23:07:15 +03:00
Salman Ahmed	a31611bdec	Improve channel switching flow in HighlightMessage	2022-03-10 23:07:15 +03:00
Salman Ahmed	5315ff794a	Handle non-existing channels on message highlighting gracefully	2022-03-10 21:29:32 +03:00
Salman Ahmed	717ddbba4e	Fix skin components toolbox not autosizing properly	2022-03-10 16:30:20 +03:00
Dean Herbert	46f2db1712	Move ChannelListingItem spacing into item so input is always handled by an item in the list ... Without this change, there would be a couple of pixels between each list item where nothing would be hovered. This is a pretty annoying UX which we should be avoiding we possible.	2022-03-10 15:58:57 +09:00
Dean Herbert	1a187d4dec	Add animation to checkbox when joning/leaving a channel	2022-03-10 15:54:42 +09:00
Dean Herbert	0155519343	Merge branch 'master' into new-chat-channel-listing	2022-03-10 15:49:06 +09:00
Dean Herbert	022dd88aef	Merge branch 'master' into chat-mention-highlight	2022-03-10 14:23:23 +09:00
Salman Ahmed	b25c37ce62	Instantiate highlight background container on animation ... Also removes the necessity of scheduling as it actually never worked as intended, `Scheduler` will still update even when the chat line is masked away, and the animation will never be held anyways. The new duration of the animation should be enough for long scrolls either way.	2022-03-10 03:49:42 +03:00
Salman Ahmed	cf9671cafb	Increase highlight delay to 1500ms	2022-03-10 02:50:15 +03:00
Salman Ahmed	80c0df6af5	Scroll chat line to channel center ... We may eventually want that encapsulated within `ScrollIntoView`, as it would also come in handy for `GameplayLeaderboard`.	2022-03-10 02:50:15 +03:00
Salman Ahmed	93cf93943f	Schedule chat line highlight after children to handle non-loaded lines	2022-03-10 02:48:33 +03:00
Salman Ahmed	2d8983383a	Revert newMessagesArrived changes and always schedule highlight ... In the case a message arrives and the chat overlay is hidden, clicking on the mention notification will not work as the `HighlightedMessage` bindable callback will execute before the scheduled `newMessagesArrived` logic (which was hanging since the message arrived until the chat overlay became open because of the notification). Simplify things by always scheduling the `HighlightedMessage` bindable callback.	2022-03-10 01:11:27 +03:00
Jai Sharma	b67f9269f9	Remove NewChat namespace	2022-03-09 18:13:56 +00:00
Dean Herbert	affcf5180b	Merge pull request #17161 from smoogipoo/fix-listing-score-conversion ... Fix scores not being recalculated in beatmap overlay	2022-03-09 13:32:45 +09:00
Dean Herbert	58aef25ad5	Merge pull request #17152 from bdach/mod-overlay/difficulty-multiplier ... Implement difficulty multiplier display for new mod select design	2022-03-09 12:11:16 +09:00
Jai Sharma	7daa2d0ea4	Use correct fonts and colours in ChannelListingItem	2022-03-09 00:36:19 +00:00
Jai Sharma	7dd51a9c4a	Reorder class attributes	2022-03-09 00:12:44 +00:00
Jai Sharma	a3477c3841	Implement ChannelListing for new chat design ... Adds components `ChannelListing` and `ChannelListing` item with visual test. Essentially a more simplified version of the existing `ChannelSelectionOverlay` component. Correctly implements `IFilterable` behaviour to filter child channel items. Channel joined state is based on the underlying `Joined` bindable of the `Channel` class. Channel join/leave events are exposed via `OnRequestJoin` and `OnRequestLeave` events which should be handled by parent component. Requires a cached `OverlayColourScheme` instance to be provided by the parent overlay component when added.	2022-03-08 22:30:58 +00:00
Dean Herbert	a2ef086c1f	Fix potential crash on rare incorrect firing of skin dropdown update methods ... As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847. There's a chance that the dropdown is not populated by the time `updateSelectedSkinFromConfig` is fired via an external means (config changes).	2022-03-09 01:08:13 +09:00
Dan Balasescu	f5cd967635	Fix scores not being recalculated in beatmap listing	2022-03-08 19:07:39 +09:00
Salman Ahmed	5e0882df8d	Simplify message highlighting transforms	2022-03-08 04:00:11 +03:00
Salman Ahmed	d74064b94b	Use Equals instead of reference equality operator	2022-03-08 03:56:27 +03:00
Salman Ahmed	f645869958	Update ChannelManager.CurrentChannel directly to handle non-loaded chat scenario ... `currentChannel` gets instantiated once the chat overlay is open, while `HighlightMessage` could be called while the chat overlay has never been open. This will all be rewritten with the new chat overlay design anyways, so should be fine for now.	2022-03-08 03:42:18 +03:00
Salman Ahmed	7f47be4680	Refactor message highlighting logic to rely on a Channel data bindable	2022-03-08 03:19:37 +03:00
Salman Ahmed	22a2ef42c5	Check channel ID on message highlight using currentDrawableChannel	2022-03-08 01:22:47 +03:00
Bartłomiej Dach	643f68e844	Better annotate initial rolling counter value set	2022-03-07 23:11:20 +01:00
Bartłomiej Dach	019f4d965d	Show two decimal digits on mod multiplier rather than one	2022-03-07 22:55:55 +01:00
Bartłomiej Dach	c25d7a1c75	Use rolling counter for multiplier display	2022-03-07 22:50:51 +01:00
Bartłomiej Dach	78a3b5961e	Implement basic difficulty multiplier display	2022-03-07 22:50:51 +01:00
Salman Ahmed	f4fa80c1e3	Add support to highlight messages in chat overlay	2022-03-07 05:10:49 +03:00
Salman Ahmed	30b38345aa	Add ability to highlight chat lines	2022-03-07 05:08:36 +03:00
Salman Ahmed	a13a087f5d	Add xmldoc to trackNewContent to explain its purpose	2022-03-06 23:51:27 +03:00
Salman Ahmed	9ec0e74813	Move scrolling to UpdateAfterChildren to avoid scheduling ... At least that's what I believe "let FillFlow update to new size" means.	2022-03-06 23:50:58 +03:00
Salman Ahmed	9bc1f3f014	Further refactor and simplify ChannelScrollContainer	2022-03-06 23:34:12 +03:00
Salman Ahmed	5b3ffb12b7	Refactor channel scrolling container to handle manual scrolls resiliently	2022-03-05 23:27:07 +03:00
Dean Herbert	6264dd266d	Merge pull request #17087 from peppy/combine-time-slider-implementation ... Centralise implementation of slider bars which display millisecond time values	2022-03-05 23:48:26 +09:00
Bartłomiej Dach	346cec3577	Merge branch 'add-offset-adjust-tooltip-text' into combine-time-slider-implementation	2022-03-05 14:58:56 +01:00
Bartłomiej Dach	38abfbf4d1	Merge branch 'master' into add-display-choice-dropdown	2022-03-05 14:39:59 +01:00
Bartłomiej Dach	1e34aca984	Rename method to better fit purpose	2022-03-05 14:38:15 +01:00
Dean Herbert	524b8e02ef	Revert "Update all usages of OsuSlider.TooltipText overrides to instead implement GetTooltipText" ... This reverts commit abba49fd8f.	2022-03-05 22:37:36 +09:00
Dean Herbert	bbc2b36117	Merge branch 'master' into add-offset-adjust-tooltip-text	2022-03-05 22:37:04 +09:00
Dean Herbert	6673e456c5	Merge pull request #17090 from miniriley2012/wiki-locale-fix ... Fix wiki links containing locale not loading when opened from chat.	2022-03-04 19:36:14 +09:00
Salman Ahmed	3fdc7ed9d2	Remove brackets surrounding one-line statements	2022-03-04 10:14:19 +03:00
Salman Ahmed	129c290ca0	Dispose cancellation token source on disposal	2022-03-04 10:01:07 +03:00
Salman Ahmed	76c293b9e9	Fix cancellation token source recreated on every medal	2022-03-04 10:00:56 +03:00
Riley Quinn	8491bab77c	Replace string locale with Language	2022-03-04 00:57:13 -06:00
Riley Quinn	81a49057ec	Fix wiki links containing locale not loading when opened from chat.	2022-03-03 23:38:51 -06:00
Dean Herbert	33862fc0db	Centralise implementation of slider bars which display millisecond time values	2022-03-04 12:25:19 +09:00
Dean Herbert	7854a0a913	Use double instead of float for UIHoldActivationDelay configuration value ... All times use double, so let's also use double here.	2022-03-04 12:22:56 +09:00
Dean Herbert	abba49fd8f	Update all usages of OsuSlider.TooltipText overrides to instead implement GetTooltipText	2022-03-04 12:16:05 +09:00
Dean Herbert	3a37e6e8b1	Fix profile badges potentially showing on incorrect profile when switching users ... Closes https://github.com/ppy/osu/issues/17081.	2022-03-04 12:01:00 +09:00
Dean Herbert	9c43500ad3	Add ability for player loading screen settings to scroll ... As we add more items here this is going to become necessary. Until the design no doubt gets changed.	2022-03-03 16:23:31 +09:00
Dean Herbert	c06703d662	Add ability to select which display the game runs on	2022-03-02 18:29:07 +09:00
Bartłomiej Dach	899b95e61b	Do not delay inital mod update by a frame	2022-02-28 21:46:58 +01:00
Bartłomiej Dach	e8701f46f1	Add xmldoc to Filter to explain usage	2022-02-28 21:39:21 +01:00
Bartłomiej Dach	6cc972aa6a	Fix test failures by waiting for panel load	2022-02-28 21:36:13 +01:00
Dean Herbert	4a555d067d	Change ModPanel to not handle OnMouseDown to allow drag scrolling in ModColumn	2022-02-28 14:32:50 +09:00
Bartłomiej Dach	774952adda	Rescale components from figma to real dimensions	2022-02-27 23:08:31 +01:00
Bartłomiej Dach	16c6b9b3b3	Add keyboard selection support to mod column	2022-02-27 22:51:29 +01:00
Bartłomiej Dach	b690df05de	Hide multiselection checkbox if everything is filtered	2022-02-27 22:51:29 +01:00
Bartłomiej Dach	a83f96b026	Add filtering support to mod column	2022-02-27 22:51:29 +01:00
Bartłomiej Dach	a80b4334ff	Tweak layout of column display for better spacing	2022-02-27 22:51:28 +01:00
Bartłomiej Dach	53e8072632	Port multiselection from previous design	2022-02-27 22:51:28 +01:00
Bartłomiej Dach	f40bd39487	Add toggle all checkbox to column display	2022-02-27 22:51:28 +01:00
Bartłomiej Dach	2e04a83554	Implement column display for new mod design	2022-02-27 22:51:27 +01:00
Dan Balasescu	a86bc344da	Merge pull request #16977 from peppy/pause-at-results ... Allow pausing audio via hotkey at multiplayer lobby and results screen	2022-02-25 19:13:06 +09:00
Bartłomiej Dach	c189cc5d00	Remove unused using directive	2022-02-24 21:01:37 +01:00
Dean Herbert	401cf2a955	Allow pausing game-wide audio via hotkey as long as LocalUserPlaying is not set ... `Player` seems to handle this correctly locally already, which is to say if the user attempts to toggle the pause state incorrectly, it will still recover. The logic stoppic this operation was only in the key binding handler, which meant it was already possible from the now playing overlay this whole time, so I *think* this should be quite safe.	2022-02-24 16:00:14 +09:00
Dean Herbert	435bdd0b4a	Combine and simplify state management logic ... This makes a few changes to bring things into a better shape during mouse interactions with the mod panels: - Dragging away from the panel now works in line with other buttons (ie. `OsuButton`) - Hovering now uses a lightened version of the current state, rather than always using the active colour. I think this feels better. - Mouse down now uses a transform point of 0.5. This is to give the button a feeling of one of those latching light switches which resists until reaching a point of overcoming the spring and switching state. I think 0.4 (non-active) and 0.6 (from active) may work better, but left at 0.5 for simplicity of implementation and I think it's good enough? - Border always uses the gradiented version. I did this for simplicity of implementation, but also think it looks better. - Adjusted transform durations to feel better to me.	2022-02-24 15:25:30 +09:00
Dean Herbert	6e8daa06fa	Merge branch 'master' into mod-overlay/panel	2022-02-24 14:34:59 +09:00
Bartłomiej Dach	713f89a59c	Implement incompatibility-displaying variant of mod panel	2022-02-23 23:19:06 +01:00
Bartłomiej Dach	bbe2dfa458	Move out incompatibility displaying tooltip to own class	2022-02-23 23:18:15 +01:00
Bartłomiej Dach	8a0aba6c59	Implement mod panel for new mod select screen	2022-02-23 23:18:14 +01:00
Bartłomiej Dach	29d77a29aa	Merge branch 'master' into startup-protocol-handling	2022-02-23 21:10:27 +01:00
Bartłomiej Dach	1a358698fb	Merge branch 'master' into startup-protocol-handling	2022-02-22 22:42:16 +01:00
Dean Herbert	6de4e05e49	Fix current selection not being correctly maintained when BeatmapPicker updates its display	2022-02-22 17:17:08 +09:00
Dean Herbert	e744840d07	Ensure old results are cleared from beatmap overlay on logout	2022-02-22 14:56:04 +09:00
Dean Herbert	d6032a2335	Fix beatmap overlay not re-fetching results after login	2022-02-22 14:55:52 +09:00
Dean Herbert	fc1877b6fa	Move to extension method and revert logic to match previous implementation	2022-02-21 13:42:26 +09:00
Dean Herbert	79408f6afc	Add xmldoc and clean up ScoreboardTimeUtils extension methods a touch	2022-02-21 13:30:58 +09:00
Dean Herbert	abe1a3990a	Merge branch 'master' into leaderboard-score-timeref	2022-02-21 12:11:10 +09:00
Bartłomiej Dach	36a00c1ee2	Remove static OverlayColourProviders	2022-02-20 21:09:08 +01:00
Bartłomiej Dach	ce0db9d4db	Remove all references to static OverlayColourProviders	2022-02-20 21:09:08 +01:00
Bartłomiej Dach	79ba37bbab	Add Colour0 to OverlayColourProvider	2022-02-20 21:09:08 +01:00
Bartłomiej Dach	2592f0900d	Add comments about OverlayColourProvider vs OsuColour distinction	2022-02-20 21:08:58 +01:00
Susko3	acf226bb58	Merge branch 'master' into input-settings	2022-02-19 21:28:40 +01:00
dekrain	15ed9ec4fa	Merge scoreboard and leaderboard implementations together	2022-02-19 20:47:02 +01:00
Salman Ahmed	b66566e96d	Use explicit culture info rather than null	2022-02-16 10:35:57 +03:00
Salman Ahmed	7654584e40	Allow using SizeSlider on different value types	2022-02-16 03:25:03 +03:00
Salman Ahmed	f7edf25d4c	Remove no longer required property	2022-02-16 03:23:02 +03:00
Dan Balasescu	ea5bb46fb8	Merge branch 'master' into net6	2022-02-16 00:40:04 +09:00
Salman Ahmed	f5d0eb41cb	Update further ChangeFocus usages	2022-02-15 02:42:39 +03:00
Salman Ahmed	9504942cfd	Add test case for distance spacing hotkeys scrolling behaviour	2022-02-15 02:21:53 +03:00
Bartłomiej Dach	4bd58cfde1	Update one more custom transform with BorderColour type change	2022-02-14 18:52:19 +01:00
Dean Herbert	b9d9fc56af	Move files to UI namespace	2022-02-14 17:51:39 +09:00
Dean Herbert	80ba06b0e3	Merge branch 'master' into expandable-controls	2022-02-14 16:57:45 +09:00
Susko3	214b2724de	Merge branch 'master' into input-settings ... # Conflicts: # osu.Game/OsuGameBase.cs # osu.iOS/OsuGameIOS.cs	2022-02-12 11:48:46 +01:00
Salman Ahmed	ccd6648961	Update pinned score container header to use localised title	2022-02-11 09:22:09 +03:00
Salman Ahmed	4f7003928a	Add score container for pinned scores in ranks section	2022-02-10 21:32:18 +03:00
Dean Herbert	eda213e4de	Merge pull request #16827 from smoogipoo/spectator-state-rework ... Add user state to SpectatorState, allowing multiplayer to continue to results	2022-02-11 01:48:47 +09:00
Dean Herbert	44f2d8a448	Allow game folder migration to fail gracefully when cleanup cannot completely succeed	2022-02-10 19:30:26 +09:00
Dean Herbert	88bb9d4237	Fix migration errors not outputting the call stack to logs	2022-02-10 15:50:03 +09:00
Dean Herbert	c242a63b11	Fix playlist overlay null reference when attempting an empty selection ... As reported at https://github.com/ppy/osu/discussions/16829.	2022-02-09 10:16:45 +09:00
Dan Balasescu	886d1d2df6	Refactorings	2022-02-08 21:29:43 +09:00
Salman Ahmed	bbef12e72c	Refactor ExpandingControlContainer to no longer rely on controls	2022-02-04 05:45:12 +03:00
Dean Herbert	b2efce2656	Merge branch 'master' into expandable-controls	2022-02-03 19:23:34 +09:00
Dan Balasescu	81a22dbd29	Add back playing users list	2022-02-02 23:19:43 +09:00
Dan Balasescu	fcbba3d948	Rename PlayingUserStates -> WatchingUserStates	2022-02-02 23:11:29 +09:00
Dan Balasescu	f4210f7a30	Rework spectator components to use new user state	2022-02-01 21:53:25 +09:00
Dan Balasescu	502e6af008	Remove PlayingUsers list from SpectatorClient	2022-02-01 14:42:30 +09:00
Dean Herbert	9005bce0fa	Add "counter" keyword for key overlay setting	2022-01-31 16:37:51 +09:00
Dean Herbert	b7d8c9bf06	Fix a couple of cases of incorrect equality checks in the case both values are null	2022-01-28 14:29:56 +09:00
Salman Ahmed	2cc69d6b19	Replace IsControlDragged with an abstract ShouldBeExpanded	2022-01-27 15:57:56 +03:00
Dan Balasescu	b3f2392358	Resolve compilation error due to removed method	2022-01-26 19:04:18 +09:00
Dan Balasescu	cdca1285ab	Merge branch 'master' into playlist-overlay-optimisations	2022-01-26 19:01:33 +09:00
Dean Herbert	45636ce04b	Remove collection ToLive helper method to avoid confusion	2022-01-26 18:26:37 +09:00
Dean Herbert	d1a2256262	Refactor SkinSection to avoid unnecessary realm queries	2022-01-26 17:48:11 +09:00
Salman Ahmed	a34b8fc4d0	Merge branch 'master' into expandable-controls	2022-01-26 10:36:22 +03:00
Salman Ahmed	161ff45f8c	Resolve further UI-related issues	2022-01-26 10:36:18 +03:00
Salman Ahmed	eb83b7fe0a	Update existing implementation with changes	2022-01-26 10:18:17 +03:00
Salman Ahmed	6998266770	Add simplified implementation of an expandable slider	2022-01-26 10:18:06 +03:00
Salman Ahmed	b5e6352137	Revert SettingsItem<T>-related changes	2022-01-26 09:31:35 +03:00
Dean Herbert	9532454e2a	Remove ILive remnants	2022-01-26 15:12:07 +09:00
Dean Herbert	ba46827ac0	Merge branch 'master' into playlist-overlay-optimisations	2022-01-26 15:11:14 +09:00
Dan Balasescu	8f85f32f2b	Merge pull request #16619 from peppy/live-no-interface ... Remove `ILive<>` interface (and use `abstract Live<>` instead)	2022-01-26 14:54:14 +09:00
Dean Herbert	cd71ec0edd	Remove ILive<> interface (and use abstract Live<> instead)	2022-01-26 13:38:56 +09:00
Dean Herbert	7ca73f7e6d	Don't auto-unblock realm when user has manually pressed unblock button	2022-01-26 12:51:09 +09:00
Dean Herbert	dda513dd08	Change PlaylistOverlay to use ILive	2022-01-26 12:19:59 +09:00
Dean Herbert	64914c45a4	Remove unnecessary realm query helper method	2022-01-26 11:53:50 +09:00
Dean Herbert	cdef67ccd0	Log posted notifications ... To help with test failures and the likes.	2022-01-25 23:38:48 +09:00
Dean Herbert	1a776a9587	Completely remove subscription from MusicController	2022-01-25 16:53:02 +09:00
Dean Herbert	2a786f9ec0	Load text only after it comes on screen (and tidy up selection handling logic)	2022-01-25 16:51:21 +09:00
Dean Herbert	ace2bd2208	Apply some initial optimisations to PlaylistItem	2022-01-25 16:51:21 +09:00
Dean Herbert	8a4f3a7ce0	Reimplement subscription logic in PlaylistOverlay directly	2022-01-25 16:51:21 +09:00
Dean Herbert	958cfde608	Stop detaching and exposing beatmaps from MusicController	2022-01-25 16:51:21 +09:00
Dean Herbert	d7342880f5	Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications	2022-01-25 13:09:48 +09:00
Dean Herbert	e23b10e6a5	Update remaining cases of clashing variable name in realm.Run(realm..	2022-01-25 13:04:05 +09:00
Bartłomiej Dach	da771044a7	Merge branch 'master' into realm-clean-up	2022-01-24 19:15:31 +01:00
Dean Herbert	3bc86ee68f	Merge branch 'master' into music-controller-less-population	2022-01-24 20:44:37 +09:00
Dean Herbert	6eb2c28e41	Rename RealmContextFactory to RealmAccess	2022-01-24 20:38:07 +09:00
Dean Herbert	b0919722ac	Guard against potential exception while blocking realm	2022-01-24 18:25:48 +09:00
Dean Herbert	40aa873190	Rename register methods to better explain their purpose	2022-01-24 14:37:36 +09:00
Dean Herbert	d7a9c5fd41	Add settings buttons to allow temporarily blocking realm access	2022-01-24 14:36:57 +09:00
Dean Herbert	351c766ea1	Fix one remaining instance of realm query as property	2022-01-23 23:20:03 +09:00
Dean Herbert	e9e3e024a1	Update all usages of QueryAsyncWithNotifications to use new Register pathway	2022-01-23 20:28:04 +09:00
Salman Ahmed	648e7f6bbc	Handle controls with dragging state wrapped in underlying components ... I'm not 100% sure about this approach but it'll do for now.	2022-01-23 05:41:16 +03:00
Salman Ahmed	f4c7a332c3	Add IExpandable support for SettingsItem<T>	2022-01-23 05:41:16 +03:00
Salman Ahmed	326f12f847	Add IExpandable support for SettingsToolboxGroup	2022-01-23 05:41:16 +03:00
Salman Ahmed	62a2bccd76	Abstractify expansion logic from ExpandingButtonContainer	2022-01-23 05:41:16 +03:00
Dean Herbert	287d70d728	Merge branch 'realm-stable-subscriptions' into music-controller-less-population	2022-01-22 14:37:39 +09:00
Dean Herbert	6a076a684e	Merge branch 'realm-context-use-update-when-feasible' into realm-stable-subscriptions	2022-01-22 13:14:25 +09:00
Dean Herbert	25dbe6b27c	Fix unused null assignment	2022-01-22 12:58:30 +09:00
Dean Herbert	7025191fdd	Move target field outside of Run usage ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-01-22 12:02:44 +09:00
Salman Ahmed	81b07dee56	Introduce IExpandable interface	2022-01-21 18:41:19 +03:00
Dean Herbert	ad3a01dc06	Use a more reliable method of reviving the update thread realm after blocking	2022-01-21 22:44:56 +09:00
Dean Herbert	a86c0014fe	Remove unnecessary exception/check	2022-01-21 20:07:43 +09:00
Dean Herbert	63226f7def	Remove pointless initial MusicController beatmap set population ... Looks to pass tests and all usages look safe enough.	2022-01-21 20:05:35 +09:00
Dean Herbert	1f157d729d	Update existing subscriptions to new style ... Fix missing detach calls in `MusicController`	2022-01-21 20:05:03 +09:00
Dean Herbert	114c9e8c1f	Update all usages of CreateContext to use either Run or Write	2022-01-21 17:27:08 +09:00
Dean Herbert	a5d2047f05	Fix various cases of creating realm contexts from update thread when not necessary	2022-01-21 01:44:56 +09:00
Dan Balasescu	4f86a2cb61	Merge pull request #16525 from bdach/beatmap-listing-overflow-and-scrolling ... Improve usability of expanded card content on beatmap listing	2022-01-20 14:14:44 +09:00
Bartłomiej Dach	b8184a3005	Fix news sidebar assuming returned posts are always from given year	2022-01-19 23:13:30 +01:00
Bartłomiej Dach	4cad5890c6	Add test coverage for news sidebar showing wrong headers	2022-01-19 23:12:35 +01:00
Bartłomiej Dach	33ab356dc5	Fix expanded card content being clipped on beatmap listing overlay	2022-01-19 22:10:05 +01:00
Dean Herbert	d10d657073	Merge pull request #16421 from Susko3/textbox-AllowIme-false ... Add `AllowIme => false` to text boxes where applicable	2022-01-18 18:02:47 +09:00
Dean Herbert	39c9c4985b	Merge branch 'master' into textbox-AllowIme-false	2022-01-18 17:03:51 +09:00
Dean Herbert	1b62a685f3	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-18 15:07:59 +09:00
Dan Balasescu	e9c96908d5	Merge pull request #16481 from peppy/fix-scores-container-tests ... Rewrite `TestSceneScoresContainer` to work again	2022-01-17 20:39:14 +09:00
Dean Herbert	12fd279b7d	Add test to check full flow of rebinding gameplay key bindings ... Addresses a regression found in realm PR that was not covered by tests.	2022-01-17 16:00:17 +09:00
Dean Herbert	51ade3251d	Improve ScoresContainer loading overlay logic to work better with tests	2022-01-17 15:15:39 +09:00
Dean Herbert	88bf406c22	Fix null reference in equality comparison causing beatmap set overlay to crash	2022-01-17 13:05:55 +09:00
Dean Herbert	5601f6f1fe	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-17 12:29:02 +09:00
Susko3	6e4214de4d	Move VersionManager from osu.Desktop to osu.Game	2022-01-15 19:42:38 +01:00
Susko3	037e56f13e	Add Android mouse settings	2022-01-15 14:53:41 +01:00
Susko3	f3eaa95041	Move input handler settings creation to OsuGameBase	2022-01-15 14:53:41 +01:00
Bartłomiej Dach	03e4ec4214	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-15 14:45:42 +01:00
Susko3	19467e58c1	Remove unused params from BDL methods	2022-01-15 01:06:39 +01:00
Dean Herbert	3a95425a9e	Remove left-over methods in MusicController	2022-01-14 19:55:49 +09:00
Dean Herbert	51251e3204	Fix CI reported warnings	2022-01-12 22:39:00 +09:00
Dean Herbert	017285b694	Update MusicController to handle deletions more correctly	2022-01-12 17:49:11 +09:00
Dean Herbert	72656ae01e	Fix beatmap restore/undelete flows	2022-01-12 17:49:11 +09:00
Dean Herbert	46206f70d6	Fix beatmap mass deletion flow	2022-01-12 17:49:11 +09:00
Dean Herbert	e8dcbaf29a	Fix intro screen hitting null reference if intro beatmap is unavailable	2022-01-12 17:49:11 +09:00
Dean Herbert	c33e163178	Bind ruleset to toolbar later for safety	2022-01-12 17:49:10 +09:00
Dean Herbert	3811bd8520	Fix some null inspections	2022-01-12 17:00:16 +09:00
Dean Herbert	33060990b7	Temporarily disable WorkingBeatmapCache and fix multiple invalid data flows	2022-01-12 17:00:16 +09:00
Dean Herbert	1d536fd0bc	Start introducing ILive	2022-01-12 17:00:16 +09:00
Dean Herbert	abd72c496b	"Update" MusicController	2022-01-12 17:00:16 +09:00
Dean Herbert	00e3af3366	Update model manager and many related classes to get things compiling again	2022-01-12 17:00:00 +09:00
Dean Herbert	4f6a05ce3d	Reimplement all query methods	2022-01-12 16:57:27 +09:00
Dean Herbert	53792811b2	more fixes (almost compiles, except ruleset and manager)	2022-01-12 16:57:27 +09:00
Dean Herbert	3ecd889fef	Replace EF RulesetStore with realm version ... Pass full EF context factory to `RealmContextFactory` for migration purposes	2022-01-12 16:39:36 +09:00
Dean Herbert	11e07c1137	Add button to compact realm on demand ... In general we're doing things correctly so the realm file shouldn't expand (unless mass deletions are made from it), but this is a nice way to manually confirm the behaviour. Sometimes if using realm studio with osu! running, for instance, the realm file size can blow out of proportion. This will recover from such cases. Note that calling `RealmFactory.Compact` itself is not enough, as it will fail unless all instances of the realm have been closed.	2022-01-12 15:22:36 +09:00
Susko3	a0842838e7	Add AllowIme => false where applicable ... Also adds `AllowWordNavigation => false` to password text box.	2022-01-12 00:15:17 +01:00
r00ster	a8c3fdd383	Update outdated OpenTabletDriver FAQ links	2022-01-11 16:11:07 +01:00
Dan Balasescu	af9fad00c3	Merge branch 'master' into async-deadlock-safety	2022-01-10 16:11:09 +09:00
Bartłomiej Dach	2e9ba40ae2	Add references to web implementation wrt property used	2022-01-09 14:46:15 +01:00
Bartłomiej Dach	12c8243a9b	Fade out inactive player rows on user ranking table	2022-01-09 14:42:26 +01:00
Bartłomiej Dach	9e84e31eac	Add score time to beatmap set overlay scoreboard table	2022-01-07 19:18:16 +01:00
Bartłomiej Dach	87f7c7e691	Implement scoreboard-specific time formatting	2022-01-07 19:18:16 +01:00
Bartłomiej Dach	881fa2b86b	Add basic test scene for scoreboard time	2022-01-07 19:18:16 +01:00
Dean Herbert	3cd996eb4a	Merge branch 'master' into async-deadlock-safety	2022-01-07 17:28:59 +09:00
Bartłomiej Dach	8f744c99ee	Fix settings toolbox toggle button starting in incorrect state ... While displaying replays, the colour of the toolbox toggle button would not match the actual state of the rest of the toolbox, i.e. both buttons would be white, even though the "playback settings" section was expanded and as such should have a yellow toggle button. In the case of the replay player, the failure scenario was as follows: 1. `SettingsToolboxGroup` calls `updateExpanded()` in its BDL to update the initial state of the toolbox, including the toggle button colour, by adding a colour fade transform. 2. An ancestor of both the toolbox groups - `PlayerSettingsOverlay`, which is a `VisibilityContainer` - calls `FinishTransforms(true)` in its `LoadCompleteAsync()`, therefore instantly applying the colour from point (1) to the toggle button instantly. 3. However, `IconButton` inherits from `OsuAnimatedButton`. And `OsuAnimatedButton` changes its colour in `LoadComplete()`, therefore undoing the instant application from point (2). This conjunction of circumstances is instrumental to reproducing the bug, because if the `FinishTransforms(true)` call wasn't there, point (3) wouldn't matter - the transform would get applied at some indeterminate point in the future, ignoring the write from `OsuAnimatedButton`. As for the fix, move the `updateExpanded()` call in `SettingsToolboxGroup` to `LoadComplete()` to avoid the above unfortunate order. Applying initial visual state in `LoadComplete()` is the idiomatic style of doing things these days anyhow.	2022-01-06 20:45:56 +01:00
Dean Herbert	e02863f780	Avoid accessing DrawWidth from invalidation	2022-01-07 01:24:30 +09:00
Dean Herbert	f703c5f038	Add comment and reduce how often ChildrenOfType is invoked in ExpandingButtonContainer	2022-01-06 23:38:54 +09:00
Dean Herbert	5aca2dd4ce	Hide header text when it won't fit in the toolbox group	2022-01-06 23:08:50 +09:00
Dean Herbert	690b425380	Move enum local to usage	2022-01-06 22:56:56 +09:00
Dean Herbert	00177a3ae1	Update usages to new naming	2022-01-06 22:54:43 +09:00
Dean Herbert	3ea7588a91	Update continuation usages to use GetCompletedResult	2022-01-06 22:53:07 +09:00
Dean Herbert	cea9cab4dc	Use ExpandingButtonContainer in editor composer	2022-01-06 21:10:45 +09:00
Dean Herbert	5baaf356aa	Split out SettingsToolboxGroup from PlayerSettingsGroup	2022-01-06 21:05:00 +09:00
Dean Herbert	77980196c5	Split out expanding container logic from settings sidebar	2022-01-06 21:02:29 +09:00
Dean Herbert	39650ce7e9	Merge pull request #16307 from peppy/beatmap-listing-bottom-padding ... Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds	2022-01-04 14:14:42 +09:00
Dean Herbert	73b40e6833	Replace usage of .Result with .WaitSafelyForResult	2022-01-04 11:51:41 +09:00
Bartłomiej Dach	de33b420ab	Add safety against performing operation on non-alive foundContent	2022-01-03 20:02:46 +01:00
Bartłomiej Dach	586f158920	Remove initial foundContent value ... It always is replaced on the first search anyway, and just remains forever in the overlay otherwise.	2022-01-03 19:52:42 +01:00
Bartłomiej Dach	6650a468e0	Fix and simplify very broken beatmap listing content swap-out logic ... The beatmap listing content swap-out logic was already a source of several problems, and several attempts of fixing it were made. But as it turns out it was terminally broken in several aspects. * The `BypassAutoSizeAxes` juggling was finicky and ugly, and didn't really look much different than an instant fade. Therefore, all fade durations and manipulations of `BypassAutoSizeAxes` are removed. * The transform sequence juggling the `BypassAutoSizeAxes` manipulations was enqueued on the content which is being in the process of fading out. That was partially fixed in 25e38560, but as it turns out, that only works if `lastContent` is one of the two placeholder drawables (results not found / supporter required to use filter). It would not work if `lastContent` is a `ReverseChildIDFillFlowContainer` with cards from a previous search in it.	2022-01-03 19:51:46 +01:00
Bartłomiej Dach	ef9f56e585	Fix bad check if content is placeholder ... The `lastContent == foundContent` check, last touched in a49a4329, is terminally broken, as it would always be false. `foundContent` is mutated when a new card load task is started in `onSearchFinished()`, which is *before* the aforementioned check. The code prior to a49a4329 was checking against the two static reused placeholder drawables which was the correct check to apply, and this commit reverts to using a variant of that check.	2022-01-03 19:51:20 +01:00
Bartłomiej Dach	97439c3df1	Rename method to reflect what it actually does	2022-01-03 19:30:17 +01:00
Bartłomiej Dach	7c246670b4	Add padding to bottom of spotlights ranking view to avoid hovered panels exceeding visible bounds	2022-01-03 18:43:20 +01:00
Dean Herbert	b9851b278d	Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds ... Closes https://github.com/ppy/osu/issues/16120.	2022-01-03 13:18:28 +09:00
Dean Herbert	6356180b6a	Remove unnecessary code and fix double nesting causing filtering to not work	2022-01-03 12:53:58 +09:00
Dean Herbert	bb54f438aa	Merge branch 'master' into positional-sounds-strength-adjustment	2022-01-03 12:40:56 +09:00
Joseph Madamba	7de43e3aba	Fix most open compound words in identifiers being closed	2021-12-27 20:26:28 -08:00
Joseph Madamba	98524d60a4	Fix clear identifier typos	2021-12-27 20:26:28 -08:00
Dan Balasescu	d36fe3af09	Merge pull request #16238 from peppy/fix-incorrect-delegate-capture ... Fix incorrect delegate capture leading to slow leak of audio tracks	2021-12-24 21:34:04 +09:00
Dean Herbert	2ee3e61983	Merge branch 'master' into beatmap-card/extra-on-listing	2021-12-24 19:02:51 +09:00
Dean Herbert	cc7089c3f4	Cancel more liberally	2021-12-24 19:00:09 +09:00
Dean Herbert	d602aebebb	Add missing cancellation token and rename load task variable to match purpose	2021-12-24 18:58:31 +09:00
Dean Herbert	842d508aee	Fix incorrect delgate capture leading to slow leak of audio tracks ... During profile, it was found that the `Completed` delegate was incorrectly also capturing `lastTrack`, leading to an unexpected reference chain that led to a memory leak over a long period of time. This solves the issue by moving the delegate construction to its own method, where it won't capture the other variables.	2021-12-24 18:39:29 +09:00
Bartłomiej Dach	5cbaa028eb	Use extracted ruleset config cache implementation in DI	2021-12-23 19:02:10 +01:00
Bartłomiej Dach	a49a4329ee	Add capability to switch between card sizes	2021-12-23 15:55:37 +01:00
Bartłomiej Dach	d0427ec85f	Add support card size tab control to beatmap listing	2021-12-23 15:55:37 +01:00
Bartłomiej Dach	1876617d8e	Implement beatmap card size tab control	2021-12-23 15:55:36 +01:00
Bartłomiej Dach	25e38560ce	Fix placeholder drawables on beatmap listing not always hiding correctly ... `BeatmapListingOverlay.addContentToPlaceholder()`, in order to make transitions between different beatmap listing content (whether it is actual cards, or placeholders for no beatmaps found/supporter-specific filters chosen), would set `BypassAutoSizeAxes = Y` on content as it is fading out, to make the transition smoother. The property in question was supposed to be getting restored to `None` on the next show. In testing scenarios, it sometimes turned out that this wasn't the case, therefore making the placeholders effectively not show - while they were present and fully opaque, they would be the only child of an auto-sized container with `BypassAutoSizeAxes = Y`, so the parent auto-sized to a zero height, which logically follows from the premise, but is not what was desired. This in turn was caused by the fact that the `BypassAutoSizeAxes = Y` set was scheduled, and sometimes it would be scheduled in such a way that the drawable would cease to be present on the next frame due to its alpha being past the cutoff point of 0.0001. Therefore the scheduled set would not execute until the *next* time the placeholder was shown, therefore causing the bug. Fix by ensuring that the placeholder drawables are always present if their schedulers have any tasks enqueued, on top of the usual checks of alpha and scale performed via the base implementation.	2021-12-22 15:05:23 +01:00
Bartłomiej Dach	88d4e95ad8	Rename BeatmapCard{ => Normal}	2021-12-21 08:26:21 +01:00
Bartłomiej Dach	a6ccbafc77	Fix rank graph showing for unranked users	2021-12-19 13:40:22 +01:00
mk-56	fd5af1fbe7	Code refactor and name changes ... cleaned code up with Jetbrains i hope it suffices	2021-12-17 13:16:06 +01:00
Bartłomiej Dach	54790bb758	Merge branch 'master' into fix-realm-post-storage-migration-failure	2021-12-17 00:19:46 +01:00
Dean Herbert	aa0813ff05	Merge pull request #16109 from smoogipoo/chat-overlay-multiplayer-removal ... Don't show multiplayer channels in chat overlay	2021-12-16 17:39:45 +09:00
Dan Balasescu	3f1d747b7a	Merge pull request #16090 from peppy/fix-scroll-speed-toast-sample-spam ... Fix toast popups spamming samples when adjusting osu!mania scroll speed during gameplay	2021-12-16 17:31:36 +09:00
Dan Balasescu	488374b4a2	Don't show multiplayer channels in chat overlay	2021-12-16 16:41:47 +09:00
Susko3	643cee4f83	Merge branch 'master' into number-textbox-only-numbers	2021-12-15 09:13:19 +01:00
Susko3	b326ccc196	Move logic to framework and update all usages	2021-12-15 07:13:24 +01:00
Dean Herbert	0c11fe7413	Fix toast popups spamming samples when adjusting osu!mania scroll speed during gameplay ... Not the most robust of fixes, but as per the reasoning described in the issue thread, a proper fix will take considerably more effort. This intends to fix the issue first and foremost, as it sounds so bad I'd want to mute my sound before adjusting currently. Closes #15718.	2021-12-15 12:45:23 +09:00
Dean Herbert	441b7baa93	Provide a realm factory to usages of ToLive/RealmLive	2021-12-14 14:26:34 +09:00
Dean Herbert	bff02bedbf	Rename APIScoreInfo to APIScore	2021-12-10 16:11:49 +09:00
Dean Herbert	bf1418bafc	Use OnlineID instead of legacy IDs for equality and lookups	2021-12-10 16:11:48 +09:00
Susko3	0b0ff36154	Allow only number characters parseable by int.TryParse ... char.IsNumber() is too broad, allowing full width and other numbers.	2021-12-07 20:06:22 +01:00
Dean Herbert	d6e68feadc	Merge pull request #15948 from bdach/beatmap-card/difficulty-dropdown ... Add difficulty dropdown to beatmap card	2021-12-07 23:40:06 +09:00
Bartłomiej Dach	999bba439f	Clarify usages of reverse child ID flow with inline comments	2021-12-06 21:02:40 +01:00
Dean Herbert	452fa93444	Merge branch 'master' into realm-integration/skins-rebase	2021-12-06 15:21:02 +09:00
Bartłomiej Dach	af10223ac4	Add reverse fill flows & depth specs at usage sites for correct Z-ordering	2021-12-05 20:07:46 +01:00
Bartłomiej Dach	38702beabf	Merge branch 'master' into i-ruleset-store	2021-12-04 15:05:39 +01:00
Dan Balasescu	4145a16d5b	Merge pull request #15920 from peppy/clean-up-unused-resolves ... Clean up unused resolved properties	2021-12-03 20:08:48 +09:00
Dean Herbert	1eed2436e6	Clean up unused resolved properties	2021-12-03 18:49:49 +09:00
Dean Herbert	2acf46154a	Remove many unused resolutions of RulesetStore	2021-12-03 18:16:29 +09:00
Dean Herbert	e75e209053	Cache and consume IRulesetStore where feasible	2021-12-03 18:16:01 +09:00
Dean Herbert	aaa46960b3	Reword mouse wheel disable setting to better explain its purpose	2021-12-03 17:18:07 +09:00
Dean Herbert	e855a49833	Add test coverage of default skin edit and export	2021-12-02 14:01:18 +09:00
Dean Herbert	0a14acfd83	Fix incorrect conditional on export/mutate feasability of skin	2021-12-02 13:41:58 +09:00
Dean Herbert	65f0a80c97	Merge branch 'master' into realm-integration/skins-rebase	2021-12-02 13:37:20 +09:00
Dean Herbert	c82195390f	Update usage of SubscribeForNotifications	2021-12-02 13:24:16 +09:00
Dean Herbert	8ce7467e97	Fix ordering of skins in dropdown being reverse of expected	2021-12-01 12:50:47 +09:00
Dean Herbert	03e1305b3f	Fix toast display potentially causing a child mutation before load complete	2021-12-01 01:55:17 +09:00
Dean Herbert	6877867467	Make default fallback logic more robust	2021-11-29 18:28:25 +09:00
Dean Herbert	0d18c83d75	Simplify deletion by adding always present conditionals to Delete method	2021-11-29 18:28:25 +09:00
Dean Herbert	f6a3709060	Store default skins to database	2021-11-29 18:28:25 +09:00
Dean Herbert	c629a7a36f	Fix random selection and avoid using legacy events for handling skin import/deletion	2021-11-29 18:28:25 +09:00
Dean Herbert	744a5b33f5	Rewrite SkinSection to use realm subscriptions and databased defaults	2021-11-29 18:28:25 +09:00
Dean Herbert	3db5646fa8	Create Guid constants for system skins (and store skin choice to configuration as guid)	2021-11-29 18:28:25 +09:00
mk-56	c3fb793762	Fixed the problems that were brought up and deleted the old bind logic	2021-11-28 14:06:53 +01:00
mk-56	ff9c68dd6a	cleanup	2021-11-28 03:28:35 +01:00
MK56	753c1c7fea	Merge branch 'ppy:master' into positional-sounds-strength-adjustment	2021-11-28 02:59:36 +01:00
mk-56	eaa464e548	Initial implementation of adjustable positional hitobject audio strength	2021-11-28 02:58:08 +01:00
Dean Herbert	51a7c60eec	Merge pull request #15835 from bdach/off-thread-transforms-unbind ... Fix instances of components adding off-thread transforms on unbind	2021-11-28 09:27:43 +09:00
Bartłomiej Dach	db49d99cc0	Ensure correct disabled ruleset callback scheduling in ruleset selector	2021-11-27 15:28:23 +01:00
Bartłomiej Dach	05f7ea6b6d	Remove mentions of "panel" and "direct" from names of old download buttons	2021-11-27 15:08:03 +01:00
Bartłomiej Dach	a043d1e427	Move old beatmap download button to more general namespace	2021-11-27 15:06:57 +01:00
Bartłomiej Dach	251ab183a0	Move beatmap play button nearer its only remaining usage	2021-11-27 15:04:05 +01:00
Bartłomiej Dach	7419682334	Move icon pill to beatmap card-specific namespace	2021-11-27 15:01:48 +01:00
Bartłomiej Dach	6773877a40	Remove no-longer-used beatmap panels	2021-11-27 15:00:06 +01:00
Bartłomiej Dach	f4b7db5a7b	Ensure correct disabled beatmap callback scheduling in now playing overlay	2021-11-27 14:36:34 +01:00
Dean Herbert	89b4e5cffb	Rename mass deletion confirmation dialog	2021-11-26 18:18:45 +09:00
Bartłomiej Dach	ec2265d5bb	Use beatmap cards in spotlights layout	2021-11-25 22:30:47 +01:00
Bartłomiej Dach	42b09fd1ec	Use beatmap cards in user profile overlay	2021-11-25 22:30:47 +01:00
Bartłomiej Dach	0f9ebe3d5d	Use beatmap cards in beatmap listing overlay	2021-11-25 22:30:46 +01:00
Dan Balasescu	f712aeee01	Merge pull request #15795 from peppy/realm-integration/separate-download-flow ... Split out download logic from main manager classes	2021-11-25 20:59:23 +09:00
Dan Balasescu	d3a4890c31	Merge branch 'master' into realm-integration/stable-export-flow	2021-11-25 19:06:18 +09:00
Dean Herbert	e2ebcf7a26	Remove unnecessary manager parameter ... Confused why I added this in the first place..	2021-11-25 18:36:03 +09:00
Dean Herbert	716543b5b3	Move beatmap download logic out of BeatmapManager	2021-11-25 17:29:41 +09:00
Dean Herbert	79459c1aeb	Fix typo in class and variable names	2021-11-25 17:12:15 +09:00
Dean Herbert	cc1b91e4bd	Split out legacy model export logic into LegacyModelExporter classes	2021-11-25 16:41:12 +09:00
Dean Herbert	9dcb20a821	Rename Stable to Legacy and add xmldoc	2021-11-25 15:39:05 +09:00
Dean Herbert	183b95cbc2	Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus ... This variable is used at more than just a set level.	2021-11-24 18:42:49 +09:00
Dan Balasescu	8ce5324c8b	Merge pull request #15772 from peppy/remove-model-list-inits ... Initialise `BeatmapSet.Beatmaps` list at construction time	2021-11-24 16:41:19 +09:00
Dean Herbert	a7853fc9cc	Fix cases of known-non-null	2021-11-24 14:26:25 +09:00
Dan Balasescu	84268c3d85	Merge branch 'master' into realm-ruleset-keybinding-short-name	2021-11-24 13:48:48 +09:00
Dan Balasescu	6183d1cd46	Merge pull request #15769 from peppy/model-equality-consistency ... Update cases where equality can be used instead of primary key equality	2021-11-24 13:45:57 +09:00
Dean Herbert	729f681938	Update cases where equality can be used instead of primary key equality	2021-11-24 12:49:57 +09:00
Dean Herbert	0eea026afb	Remove null checks on CreateInstance() calls	2021-11-24 12:23:09 +09:00
Bartłomiej Dach	0d409fa33e	Merge branch 'master' into realm-ruleset-keybinding-short-name	2021-11-23 20:18:58 +01:00
Dan Balasescu	fd4d5e98a7	Merge pull request #15745 from bdach/settings-number-box-stack-overflow ... Fix crashes on trying to play back replays of seeded mods with seed value over 1 billion	2021-11-23 16:36:05 +09:00
Dean Herbert	0989d6a92e	Merge branch 'realm-ruleset-setting-short-name' into realm-ruleset-keybinding-short-name	2021-11-23 14:55:40 +09:00
Dean Herbert	feb983d5bd	Rename Debug namespace to avoid collisions	2021-11-23 13:09:41 +09:00
Bartłomiej Dach	4a9f080f3c	Accept full range of int in SettingsNumberBox ... This fixes stack overflow exceptions that would arise when a `Current.Value` of 1 billion or more was set on a `SettingsNumberBox`. The stack overflow was caused by the "maximum 9 digits" spec. If a value technically within `int` bounds, but larger than 1 billion (in the range [1,000,000,000; 2,147,483,647], to be more precise), a feedback loop between the setting control's `Current` and its inner text box's `Current` would occur, wherein the last digit would be trimmed and then re-appended again forevermore. To resolve, remove the offending spec and rely on `int.TryParse` entirely to be able to discern overflow range. Additionally, UX of the text box is slightly changed to notify when the `int` range is exceeded with a red flash. This behaviour would not have been possible to implement without recent framework-side fixes to text box (removal of text set scheduling).	2021-11-22 20:49:14 +01:00
Dean Herbert	d94b27a8a2	Switch realm ruleset key bindings to use ruleset's ShortName as key	2021-11-22 18:52:30 +09:00
Dan Balasescu	698b6c4242	Merge pull request #15668 from peppy/key-repeat ... Update `KeyBindingContainer` usage to block key repeat where applicable	2021-11-18 15:21:35 +09:00
Dean Herbert	db4e4c982c	Add hover effect to supporter button	2021-11-18 13:35:42 +09:00
Dean Herbert	66c307e0ee	Remove usage of key repeat helper method	2021-11-18 13:13:36 +09:00
Dean Herbert	3de8125eac	Update UI cases where repeat should not be handled	2021-11-18 13:13:36 +09:00
Joseph Madamba	cd5e379c48	Link osu!supporter icon to its web page	2021-11-17 14:43:34 -08:00
Dean Herbert	726a0cc091	Merge branch 'master' into beatmap-collection-inteface-types	2021-11-16 15:31:10 +09:00
Dean Herbert	68e2699043	Fix oversight in playlist matching logic	2021-11-16 12:35:18 +09:00
Dean Herbert	285b161da7	Update other usages of online ID comparisons to use new extension method	2021-11-15 14:44:08 +09:00
Dean Herbert	a4c11e8813	Use extension method to compare online IDs	2021-11-15 14:34:50 +09:00
Bartłomiej Dach	58bad0ab25	Merge branch 'master' into fix-setting-header-text-overflow	2021-11-12 20:34:07 +01:00
Bartłomiej Dach	cb2d1f3f04	Use horizontally symmetrical padding rather than margin	2021-11-12 20:28:42 +01:00
Dean Herbert	6a098a8634	Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface	2021-11-12 17:46:24 +09:00
Bartłomiej Dach	a1b55d6490	Add failing test case	2021-11-09 13:34:36 +01:00
Lucas A	b7e7b0f850	Trim whitespace.	2021-11-08 21:42:51 +01:00
Lucas A	e6f39c4cad	Fix settings header text overflowing with some locales.	2021-11-08 21:38:01 +01:00
Susko3	8a23b648fe	Move HoverClickSounds to the clickable button	2021-11-08 14:32:00 +01:00
Dean Herbert	49c26a465c	Debounce and schedule updates to key combinations	2021-11-08 18:29:11 +09:00
Dean Herbert	b4225804ed	Add missing null check	2021-11-08 18:26:12 +09:00
Dean Herbert	f5842e7587	Shorten variable names	2021-11-08 18:24:37 +09:00
Dean Herbert	82f24b0502	Revert "Change font to default" ... This reverts commit cc286f165d.	2021-11-08 18:16:06 +09:00
Dean Herbert	3183b20e2f	Merge branch 'master' into use-ReadableKeyCombinationProvider	2021-11-08 18:15:49 +09:00
Dean Herbert	8b85c2c8de	Merge pull request #15491 from peppy/remove-stupid-weak-reference-bindable-events ... Revert weird event flow in model manager/importers	2021-11-08 15:19:58 +09:00
Susko3	cc286f165d	Change font to default ... Non-english letters look tiny with size 10 and don't fit into the look.	2021-11-08 06:56:57 +01:00
Susko3	c3069ad002	Change to use ReadableKeyCombinationProvider ... Changes all usages of `KeyCombination.ReadableString()` to `ReadableKeyCombinationProvider.GetReadableString()`. Subscribing to `KeymapChanged` is only required in `KeyButton`. All other places query `GetReadableString()` every time.	2021-11-08 06:55:26 +01:00
Dan Balasescu	1c40d5bc08	Merge branch 'master' into remove-stupid-weak-reference-bindable-events	2021-11-08 14:41:32 +09:00
Dean Herbert	6b6dd93e9e	Fix LinkFlowContainer not creating user links supporting full IUser specification	2021-11-08 14:17:47 +09:00
Dean Herbert	dede0e56ce	Merge branch 'master' into user-lookup-by-username-cleanup	2021-11-08 13:38:26 +09:00
Dean Herbert	78aef9ce86	Merge branch 'master' into remove-stupid-weak-reference-bindable-events	2021-11-08 13:35:49 +09:00
Bartłomiej Dach	6d30248cef	Merge branch 'master' into use-class-rename	2021-11-07 15:41:00 +01:00
Dean Herbert	0ecf5f201c	Rename User to APIUser and move to correct namespace	2021-11-07 11:26:01 +09:00
Bartłomiej Dach	6a1c27d67a	Merge branch 'master' into fix-more-null	2021-11-06 15:36:15 +01:00
Bartłomiej Dach	c40f887492	Remove unnecessary local variable	2021-11-06 15:20:29 +01:00
Salman Ahmed	34c8e53e94	Merge branch 'master' into update-cached-buffered-container-usage	2021-11-06 09:38:55 +03:00
Dean Herbert	bc17446055	Merge branch 'master' into user-lookup-by-username-cleanup	2021-11-06 14:38:30 +09:00
Salman Ahmed	51e7b9950e	Define local current bindable to bind value change instead	2021-11-05 18:07:14 +03:00
Dean Herbert	54f72d68ca	Revert weird event flow in model manager/importers	2021-11-05 19:12:49 +09:00
Salman Ahmed	f013a1e37f	Move CreateContent() to BDL	2021-11-05 10:13:42 +03:00
Dean Herbert	6399c695e8	Update usages of BufferedContainer in line with framework changes	2021-11-05 15:54:49 +09:00
Salman Ahmed	3a3ec1436b	Re-enable possible null refernece exception inspections and move code	2021-11-05 09:14:50 +03:00
Dean Herbert	9f9ef570ee	Also propagate Status in temporary BeatmapInfo usage	2021-11-05 14:44:58 +09:00
Dean Herbert	b1f1cc0bf3	Perform all user profile displays using an IUser interface	2021-11-05 13:55:34 +09:00
Dean Herbert	ba74dd93b2	Remove weird fetchOnline logic	2021-11-05 13:55:34 +09:00
Salman Ahmed	f528488aa2	Mark as non-null and move current bind to BDL instead	2021-11-05 05:42:19 +03:00
Salman Ahmed	4245af28e1	Disable other false-positive null inspections with comment	2021-11-05 04:50:58 +03:00
Salman Ahmed	36d99a2e34	Move action to private named method to avoid null inspection	2021-11-05 03:51:08 +03:00
Dean Herbert	b9983add15	Rename User to APIUser and move to correct namespace	2021-11-04 18:21:31 +09:00
Dean Herbert	08d94f864f	Update ScoresContainer to not use ToBeatmapInfo	2021-11-04 17:09:53 +09:00
Dean Herbert	5a078da4d9	Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues	2021-11-04 16:50:14 +09:00
Dean Herbert	8f459e6ce8	Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues	2021-11-04 16:44:17 +09:00
Bartłomiej Dach	494d582830	Fix PlaylistItem attempting to read from OsuColour dependency too early	2021-11-02 23:19:45 +01:00
Bartłomiej Dach	e4e8390a8a	Update ScreenEntry colour usage to update correctly on language change	2021-11-02 21:42:03 +01:00
Bartłomiej Dach	d218e7d935	Remove manual romanisation handling in PlaylistItem	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	ed00cd9fc5	Remove simple localisable .ToString() calls	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	11de924704	Use LocalisableStrings where possible to leverage localisable text flow	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	98367fc482	Update usages of GetLocalised{-> Bindable}String	2021-11-02 21:42:01 +01:00
Dean Herbert	47914c49ba	Fix missed null consideration	2021-11-03 04:54:36 +09:00
Dean Herbert	392559ae3e	Fix beatmap download notifications not showing beatmap name correctly	2021-11-03 03:23:41 +09:00
Dean Herbert	caa9d8997b	Merge branch 'master' into score-refactor/less-create-score-info	2021-11-01 22:59:11 +09:00
Bartłomiej Dach	793c384ecd	Remove unnecessary null-conditional access	2021-11-01 12:02:37 +01:00
Bartłomiej Dach	5dcff7d8b7	Merge branch 'master' into score-refactor/less-create-score-info	2021-11-01 11:41:20 +01:00
Dean Herbert	b21e0e7efb	Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays	2021-11-01 18:07:51 +09:00
Bartłomiej Dach	f5feed138d	Merge branch 'master' into score-refactor/isolated-serialisation	2021-11-01 09:43:51 +01:00
Dean Herbert	63c9512ab1	Update dashboard components to use APIBeatmapSet	2021-11-01 16:04:01 +09:00
Dean Herbert	b98faf6159	Merge branch 'master' into score-refactor/isolated-serialisation	2021-11-01 15:49:25 +09:00
Dean Herbert	21e0074d3b	Add missing AddInternal call for BeatmapSetHeaderContent's download tracker	2021-11-01 14:43:32 +09:00
Dean Herbert	19feae4a8e	Merge branch 'master' into beatmap-refactor/download-tracker	2021-11-01 13:15:36 +09:00
Bartłomiej Dach	8053b2c320	Merge branch 'master' into score-refactor/isolated-serialisation	2021-10-30 15:07:34 +02:00
Dean Herbert	e9473db77c	Reorder to have video settings next to renderer ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-10-30 20:37:55 +09:00
Opelkuh	4d988340eb	Add hardware acceleration toggle	2021-10-30 01:02:53 +02:00
Dean Herbert	5311fe2d02	Merge branch 'master' into beatmap-refactor/beatmap-overlays	2021-10-29 22:37:29 +09:00
Dean Herbert	a16c8f1ebc	Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet	2021-10-29 18:50:55 +09:00
Dean Herbert	8ad33d43d0	Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays	2021-10-29 18:01:17 +09:00
Dean Herbert	31403daa20	Change DrawableProfileScore to use APIScoreInfo	2021-10-29 15:14:52 +09:00
Dean Herbert	3f030cebf4	Remove local score copying in GetScoresRequest to allow APIScoreInfo.Beatmap to be APIBeatmap	2021-10-29 14:14:25 +09:00
Dean Herbert	817369903a	Rename API score classes	2021-10-29 13:40:56 +09:00
Bartłomiej Dach	6f863ca204	Adjust game-side text flow containers to part-based model	2021-10-29 06:34:08 +02:00
Dean Herbert	3b095e1626	Merge branch 'master' into beatmap-refactor/download-tracker	2021-10-29 11:50:54 +09:00
Dan Balasescu	e5a7589859	Merge pull request #15317 from peppy/beatmap-refactor/uncontested ... Update `UpdateableBeatmapBackgroundSprite` to accept `IBeatmapInfo`	2021-10-28 17:24:49 +09:00
Dean Herbert	1e1f8c472a	Add icons to various progress notification states	2021-10-28 16:34:12 +09:00
Dean Herbert	7245baba69	Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases	2021-10-28 00:50:45 +09:00
Dean Herbert	746d6a4c16	Fix some oversights and test failures	2021-10-27 23:42:27 +09:00
Dean Herbert	f014ceaead	Update remaining usages of download tracking	2021-10-27 21:00:46 +09:00
Dean Herbert	6339064dbd	Remove old versions of DownloadTrackingComposite	2021-10-27 21:00:46 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Dean Herbert	5e5b86a1f4	Merge pull request #15156 from Susko3/use-ShowFileInNativeExplorer ... Update usages of `OpenInNativeExplorer` to use `PresentFileExternally` / `PresentExternally`	2021-10-26 15:53:03 +09:00
Dan Balasescu	efe6763226	Merge branch 'master' into move-online-beatmap-metrics	2021-10-26 14:24:40 +09:00
Dean Herbert	53ff0802cb	Merge branch 'master' into use-ShowFileInNativeExplorer	2021-10-26 13:58:30 +09:00
Bartłomiej Dach	6802e9ec10	Remove FixedWidth and add AutoSizeAxes specs to all usages	2021-10-25 20:24:48 +02:00
Dean Herbert	2c308f3008	Rename BeatmapMetrics to APIFailTimes	2021-10-25 15:34:41 +09:00
Dean Herbert	045dd94a6e	Move online metrics out of BeatmapSetInfo model	2021-10-25 15:12:39 +09:00
Bartłomiej Dach	5ab3337a10	Update beatmap set status pill appearance	2021-10-24 20:40:34 +02:00
Susko3	51c5d0aec7	Update to be in line with framework changes	2021-10-24 13:21:41 +02:00
Dean Herbert	c701579c69	Refactor BeatmapMetadataContainer and usages to use interface types	2021-10-22 21:38:50 +09:00
Dean Herbert	69e7810dad	Enable nullable and switch classes to structs	2021-10-21 18:54:36 +09:00
Dean Herbert	32d01f022f	Rename usages which rely on online backing	2021-10-21 16:58:42 +09:00
smoogipoo	2c979d6420	Merge branch 'master' into localise-toasts	2021-10-20 15:04:07 +09:00
Dean Herbert	37841ca3aa	Remove incorrect ToString calls causing localisation to not actually apply	2021-10-20 10:41:34 +09:00
Bartłomiej Dach	80da153697	Recolour a few other existing dropdowns with same hover & selection colours	2021-10-19 22:47:18 +02:00
Bartłomiej Dach	ef03787fe0	Split dropdown accent colour into hover and selection colours	2021-10-19 22:09:51 +02:00
Dean Herbert	c97cfdd978	Merge branch 'master' into localise-toasts	2021-10-19 16:37:14 +09:00
Bartłomiej Dach	6d9d85685f	Fix settings item having zero height	2021-10-18 23:30:38 +02:00
Bartłomiej Dach	88a1b31fae	Remove grid usage in SettingsItem	2021-10-18 22:07:32 +02:00
Bartłomiej Dach	6c3637a62a	Remove grid usage in KeyBindingRow	2021-10-18 22:07:30 +02:00
Bartłomiej Dach	830f49bca6	Remove doubled-up opacity specification	2021-10-18 19:43:48 +02:00
Bartłomiej Dach	2a41e8bd1f	Remove unneeded extra padding from settings number box	2021-10-17 21:50:04 +02:00
Bartłomiej Dach	552fc1dc8a	Adjust key binding rows to accommodate new default value indicator	2021-10-17 21:50:04 +02:00
Bartłomiej Dach	f422ebb281	Adjust SettingsItem to accommodate new default value indicator	2021-10-17 21:50:03 +02:00
Bartłomiej Dach	818f35c35f	Restyle default value indicator	2021-10-17 21:50:03 +02:00
Bartłomiej Dach	ed2f9dd443	Adjust settings slider spacings	2021-10-15 00:31:06 +02:00
Dean Herbert	06249c4ab2	Fix incorrect usages of Scheduler.AddOnce	2021-10-14 17:52:19 +09:00
Bartłomiej Dach	d205483a36	Revert ThemedDropdown-related changes	2021-10-13 21:57:50 +02:00
Bartłomiej Dach	a2f3a7cba8	Add "themed" dropdown variant and use in settings sidebar	2021-10-12 21:58:43 +02:00
Bartłomiej Dach	1fba932e84	Adjust settings dropdown spacings	2021-10-12 21:41:33 +02:00
Dan Balasescu	cabbb1697a	Merge pull request #15054 from peppy/settings-ordering ... Initial settings usability pass	2021-10-12 22:00:30 +09:00
Dean Herbert	24b87cf655	Change some icons to be more descriptive (still placeholder)	2021-10-12 15:09:59 +09:00
Dean Herbert	59202d27c7	Add some missing labels	2021-10-12 15:09:59 +09:00
Dean Herbert	5ca1d1d12c	Reorder graphics settings and move gameplay related pieces out	2021-10-12 15:09:59 +09:00
Dean Herbert	c4347de57e	Move ruleset settings to own section	2021-10-12 14:58:43 +09:00
Dean Herbert	8285f065c2	Reorganise gameplay settings into more sections	2021-10-12 14:58:43 +09:00
Dean Herbert	1d3d67c5f1	Move gameplay cursor settings to gameplay section	2021-10-12 13:56:10 +09:00
Dean Herbert	a986870a99	Reorder sections to be more in line with how often they are adjusted	2021-10-12 13:41:35 +09:00
Dean Herbert	e058214346	Merge branch 'master' into fix-audio-filter-test-failures	2021-10-12 12:06:12 +09:00
Bartłomiej Dach	ff382259ca	Use rounded buttons in tablet rotation preset settings	2021-10-11 23:17:09 +02:00
Joseph Madamba	4fc84e71cd	Localise more toast related strings	2021-10-11 01:02:26 -07:00
Dean Herbert	484a95229e	Update toast implementations temporarily to expedite getting tests back in line	2021-10-11 16:36:04 +09:00
Joseph Madamba	af9bb6f277	Fix padding of shortcut in toast when widest	2021-10-10 19:37:46 -07:00
Joseph Madamba	7b37b15976	Localise some music action toasts	2021-10-10 19:36:50 -07:00
Joseph Madamba	545cfc7bf1	Localise tracked setting toasts	2021-10-10 19:35:25 -07:00
Bartłomiej Dach	b30dd2d4ed	Use rounded button in settings sidebar	2021-10-10 21:45:41 +02:00
Dean Herbert	49b341daff	Remove HoverTarget shared state update path ... Felt quite convoluted to follow. Have just duplicated the single shared line instead.	2021-10-10 11:55:47 +09:00
Dean Herbert	ccc6d8ff40	Improve the animation of the active indicator	2021-10-10 11:34:01 +09:00
Bartłomiej Dach	fe26d8e8df	Share sidebar colouring logic by splitting out SidebarIconButton	2021-10-10 00:34:12 +02:00
Bartłomiej Dach	b8616bf910	Adjust appearance of keybinding subpanel	2021-10-10 00:34:12 +02:00
Bartłomiej Dach	855a74b8a0	Adjust vertical spacings in individual subsections	2021-10-10 00:34:11 +02:00
Bartłomiej Dach	e23a54f1e6	Adjust setting section appearance & spacings	2021-10-10 00:31:01 +02:00
Bartłomiej Dach	4c293b637f	Restyle settings panel header	2021-10-09 23:40:15 +02:00
Bartłomiej Dach	315581f4c8	Adjust horizontal spacing in settings panel	2021-10-09 23:40:15 +02:00
Bartłomiej Dach	f6df93f013	Introduce basic parts of colour scheme to settings sidebar	2021-10-09 23:40:14 +02:00
Dan Balasescu	9be56829c9	Merge pull request #14935 from Susko3/fix-SettingsTextBox-using-null-as-default ... Fix usages of `SettingsTextBox` having `null` as the default	2021-10-08 18:36:02 +09:00
Dean Herbert	9dc035757f	Fix weird textbox behaviour when entering a random mod seed overflowing int backing	2021-10-08 14:01:36 +09:00
Dean Herbert	2856aef4eb	Add exception to catch any incorrect defaults of Bindable<string>	2021-10-08 13:52:38 +09:00
Dean Herbert	e578046b20	Rename Filter -> AudioFilter	2021-10-07 18:50:08 +09:00
Dean Herbert	0348c6c7e5	Apply some renaming and code quality fixes	2021-10-07 18:49:22 +09:00
Dean Herbert	f98dd1b811	Merge branch 'master' into popup-filter-effect	2021-10-07 18:40:21 +09:00
Jamie Taylor	266e62794e	Tweak cutoff effect for new Q value	2021-10-06 11:52:05 +09:00
Dan Balasescu	4bbff2ebf7	Merge branch 'master' into new-interfaces	2021-10-06 11:38:17 +09:00