h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 08:02:55 +08:00
Code Issues Releases Wiki Activity

Reinstantiate mod adjustments layer for safety against previous mods

Browse Source
This commit is contained in:
Salman Ahmed 2022-05-10 20:46:31 +03:00
parent a0f1c48e80
commit 36a7644164
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Overlays/MusicController.cs
View File

@ -377,7 +377,7 @@ namespace osu.Game.Overlays
}
}
private readonly AudioAdjustments modTrackAdjustments = new AudioAdjustments();
private AudioAdjustments modTrackAdjustments;
/// <summary>
/// Resets the adjustments currently applied on <see cref="CurrentTrack"/> and applies the mod adjustments if <see cref="AllowTrackAdjustments"/> is <c>true</c>.
@ -393,18 +393,19 @@ namespace osu.Game.Overlays
CurrentTrack.RemoveAllAdjustments(AdjustableProperty.Tempo);
CurrentTrack.RemoveAllAdjustments(AdjustableProperty.Volume);
modTrackAdjustments.RemoveAllAdjustments(AdjustableProperty.Balance);
modTrackAdjustments.RemoveAllAdjustments(AdjustableProperty.Frequency);
modTrackAdjustments.RemoveAllAdjustments(AdjustableProperty.Tempo);
modTrackAdjustments.RemoveAllAdjustments(AdjustableProperty.Volume);
var applicableToTrack = mods.Value.OfType<IApplicableToTrack>();
if (!allowTrackAdjustments || !applicableToTrack.Any())
CurrentTrack.UnbindAdjustments(modTrackAdjustments);
{
if (modTrackAdjustments != null)
{
CurrentTrack.UnbindAdjustments(modTrackAdjustments);
modTrackAdjustments = null;
}
}
else
{
CurrentTrack.BindAdjustments(modTrackAdjustments);
CurrentTrack.BindAdjustments(modTrackAdjustments = new AudioAdjustments());
foreach (var mod in applicableToTrack)
mod.ApplyToTrack(modTrackAdjustments);