h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-26 11:53:09 +08:00
Code Issues Releases Wiki Activity
52,636 Commits 6 Branches 666 Tags 366 MiB
8c162585b8
Commit Graph

6649 Commits

Author SHA1 Message Date
Dean Herbert
38cc1ce098 Add missing ruleset in test scores 2022-01-12 18:51:30 +09:00
Dean Herbert
34aa1bf21d Sanitise and remove some usages of Detach which are no longer required 2022-01-12 17:49:11 +09:00
Dean Herbert
e0c59f4b3c Localise EF context factory usage to migration only 2022-01-12 17:49:11 +09:00
Dean Herbert
7dba3c3551 Fix most remaining test issues 2022-01-12 17:49:11 +09:00
Dean Herbert
b7ee6d1866 Add protections against test null refs when beatmap load fails 2022-01-12 17:49:11 +09:00
Dean Herbert
dc9ea4adeb Remove incorrect test assertion 2022-01-12 17:49:11 +09:00
Dean Herbert
dd19487eb8 Fix custom import process in TestSceneDrawableRoomPlaylist not working with realm 2022-01-12 17:49:11 +09:00
Dean Herbert
6613a7e4ae Fix another case of test ruleset without overriding ShortName primary key 2022-01-12 17:49:11 +09:00
Dean Herbert
cd88ccab4f Fix TestScenePlaySongSelect failure due to detach clone depth 2022-01-12 17:49:11 +09:00
Dean Herbert
9e2ca583a3 Fix incorrect realm factory isolation in TestScenePlaySongSelect 2022-01-12 17:49:11 +09:00
Dean Herbert
ac3b7aa893 Fix more incorrect test access to ILive 2022-01-12 17:49:10 +09:00
Dean Herbert
8e79898e26 Fix a couple of minor issues with TestSceneBeatmapRecommendations 2022-01-12 17:49:10 +09:00
Dean Herbert
5cbd731864 Add RulesetInfo hashcode implementation and tidy up equality 2022-01-12 17:49:10 +09:00
Dean Herbert
605898ec53 Add missing "non-null" elements missing from some tests 2022-01-12 17:49:10 +09:00
Dean Herbert
4b690703b3 Remove unnecessary DI dependencies from cache test 2022-01-12 17:49:10 +09:00
Dean Herbert
41d90cd0b5 Fix beatmap carousel test failures 2022-01-12 17:49:10 +09:00
Dean Herbert
8ecfb9172e Fix multiple tests with incorrect access to beatmap imports 2022-01-12 17:49:10 +09:00
Dean Herbert
43c7b0d2c8 Fix unsupported realm operations in multiple tests 2022-01-12 17:49:10 +09:00
Dean Herbert
fa7dddcf3c Fix TestScenePresentScore sharing metadata/difficulty across multiple beatmaps 2022-01-12 17:00:17 +09:00
Dean Herbert
6251713796 Add missing Ruleset in ReplayRecorder tests 2022-01-12 17:00:17 +09:00
Dean Herbert
e74a5022c9 Fix multiple tests via null checks and changing ToLive to Detach 
flow
 2022-01-12 17:00:17 +09:00
Dean Herbert
52ca649159 Fix results screen test failures due to relation query 2022-01-12 17:00:17 +09:00
Dean Herbert
de076678fe Fix some remaining test failures 2022-01-12 17:00:16 +09:00
Dean Herbert
3811bd8520 Fix some null inspections 2022-01-12 17:00:16 +09:00
Dean Herbert
1f9318265e Update ToLive usages in line with recent changes 2022-01-12 17:00:16 +09:00
Dean Herbert
31a3161189 Make tests compile again 2022-01-12 17:00:16 +09:00
Dean Herbert
3152d2d8a0 "Update" BeatmapCarousel 2022-01-12 17:00:16 +09:00
Dean Herbert
00e3af3366 Update model manager and many related classes to get things compiling again 2022-01-12 17:00:00 +09:00
Dean Herbert
4f6a05ce3d Reimplement all query methods 2022-01-12 16:57:27 +09:00
Dean Herbert
53792811b2 more fixes (almost compiles, except ruleset and manager) 2022-01-12 16:57:27 +09:00
Dean Herbert
b8cd3cdbbc Various updates to ruleset and primary key usages to move closer to realm support 2022-01-12 16:57:13 +09:00
Dean Herbert
116f35c52a Remove EF FileStore 2022-01-12 16:39:36 +09:00
Dean Herbert
e6fdd0e969 Miscellaneous fixes that don't fit elsewhere 2022-01-12 16:39:36 +09:00
Dean Herbert
2cb97dd599 Remove unnecessary assigns of EF foreign ID fields in tests 2022-01-12 16:39:36 +09:00
Dean Herbert
6a671b0a52 Remove unnecessary assigns of BeatmapSetInfo.Metadata 2022-01-12 16:39:36 +09:00
Dean Herbert
fda529de26 Update usages of APIUser to RealmUser 2022-01-12 16:39:36 +09:00
Dean Herbert
213d89b479 Update null fallback cases involving OnlineID 2022-01-12 16:39:36 +09:00
Dean Herbert
37673f4cf8 Update sets of BeatmapSet.Metadata to instead create a Beatmap 2022-01-12 16:39:36 +09:00
Dean Herbert
e6f6558ddf Update mock model usage to set GUIDs instead of ints 2022-01-12 16:39:36 +09:00
Bartłomiej Dach
970e0cc85a
Merge branch 'master' into beatmap-background-with-storyboard-stopping 2022-01-11 21:39:49 +01:00
Bartłomiej Dach
e91d3dd8b4
Add failing test for incorrect sample control point time after paste 2022-01-11 21:34:22 +01:00
Dan Balasescu
60e42bf45e Add lenience to fix test failures 2022-01-11 23:01:17 +09:00
Dan Balasescu
3cb5f43f77 Fix incorrect action returned for wiki links in DEBUG mode 2022-01-11 17:46:49 +09:00
Dan Balasescu
269df08fc9 Make ChatLink tests into proper unit test methods 2022-01-11 17:42:02 +09:00
Dan Balasescu
af9fad00c3 Merge branch 'master' into async-deadlock-safety 2022-01-10 16:11:09 +09:00
Dan Balasescu
928023fabb
Merge pull request #16362 from bdach/multiplayer-wrong-ruleset 
Fix multiplayer starting gameplay using last picked item ruleset rather than actual current item ruleset
 2022-01-10 15:10:27 +09:00
Bartłomiej Dach
82d6639a3b
Decouple rankings table test from online API 2022-01-09 14:42:19 +01:00
Bartłomiej Dach
446962446e
Add test coverage for correct revert of mods when play starts at song select 2022-01-08 14:50:58 +01:00
Bartłomiej Dach
3dd5705a81
Add test coverage for correct revert of mods after new item is queued 2022-01-08 14:50:58 +01:00
Bartłomiej Dach
50077f05bd
Add test coverage for correct revert of ruleset when play starts at song select 2022-01-08 14:50:57 +01:00
Bartłomiej Dach
f026973b19
Add failing test for ruleset incorrectly applying from latest picked item 2022-01-08 14:50:54 +01:00
Bartłomiej Dach
881fa2b86b
Add basic test scene for scoreboard time 2022-01-07 19:18:16 +01:00
Dean Herbert
3cd996eb4a Merge branch 'master' into async-deadlock-safety 2022-01-07 17:28:59 +09:00
Dean Herbert
00177a3ae1 Update usages to new naming 2022-01-06 22:54:43 +09:00
Bartłomiej Dach
66613cbaa4
Wait for async continuation in score submission test 
The previous assert step was optimistically assuming that the async
continuation that writes the value of
`FakeImportingPlayer.ImportedScore` always completes before it, but
that's not necessarily true even if the continuation is instant (it is
still subject to things like task scheduling and TPL thread pool
limits).

To ensure no spurious failures, swap out the assert step for an until
step instead.
 2022-01-06 13:09:25 +01:00
Bartłomiej Dach
84765b99b3
Handle score submission request in submission test scene 
Was previously not handled at all, therefore displaying request failures
in the test log output. While that was mostly a red herring and
shouldn't have caused any actual *test* failures, it is still better to
handle this explicitly in a realistic manner.
 2022-01-06 12:57:26 +01:00
Dean Herbert
5ed69338a6 Add omission of pages when there are too many 2022-01-04 19:05:14 +09:00
Dean Herbert
86f72b71b1 Prepare tests and general structure to support omission of pages 2022-01-04 18:46:44 +09:00
Dean Herbert
5a11ee7810 Use OverlayColourProvider and fix font weight 2022-01-04 18:14:42 +09:00
Dean Herbert
d10b8c79b3 Remove pointless test coverage of DrawablePage 2022-01-04 17:53:24 +09:00
Dean Herbert
ee4f5c0e79 Rename button classes to make more sense 2022-01-04 17:52:40 +09:00
Dean Herbert
1c899e4402 Fix post-merge issues 2022-01-04 16:46:42 +09:00
Dean Herbert
69e7ee0f48
Merge branch 'master' into page-selector 2022-01-04 16:44:22 +09:00
Dean Herbert
73b40e6833 Replace usage of .Result with .WaitSafelyForResult 2022-01-04 11:51:41 +09:00
Dean Herbert
031a40af6a Replace usages of Wait with WaitSafely 2022-01-04 11:51:41 +09:00
Dean Herbert
f6b1405fa0
Merge branch 'master' into fix-listing-terminal-breakage 2022-01-04 11:49:02 +09:00
Bartłomiej Dach
7cdba2f7c3
Add test coverage of score submission if player is exited during import 2022-01-03 22:00:47 +01:00
Bartłomiej Dach
2660f41339
Add failing test case for old cards not expiring correctly 2022-01-03 19:28:14 +01:00
Dean Herbert
04d8fd3a58 Improve reliability of TestStoryboardSkipOutro 
Aims to resolve failures as seen at
https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true.

Have run quite a lot locally with no failures (while removing the skip step 100% fails).
 2022-01-01 15:32:39 +09:00
Dean Herbert
f53a675ca3 Fix TestSceneMultiSpectatorLeaderboard not waiting for user population 2021-12-31 00:48:31 +09:00
Joseph Madamba
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
Joseph Madamba
98524d60a4 Fix clear identifier typos 2021-12-27 20:26:28 -08:00
Bartłomiej Dach
ef763e9bd7
Add failing test for storyboard not tracking current track 2021-12-27 12:28:49 +01:00
Bartłomiej Dach
34b0101ff4
Add visual test coverage of "hidden by ruleset" combo option 2021-12-26 16:49:18 +01:00
Dean Herbert
8ad53138a6
Merge pull request #16234 from smoogipoo/fix-initial-button-colour 
Fix OsuAnimatedButton animating when initially disabled
 2021-12-25 15:34:40 +09:00
Dean Herbert
2ee3e61983
Merge branch 'master' into beatmap-card/extra-on-listing 2021-12-24 19:02:51 +09:00
Dan Balasescu
c973739b08 Fix OsuButton event binding + inital-enablement colour 2021-12-24 11:56:12 +09:00
Dan Balasescu
03d159d723 Refactor OsuAnimatedButton test scene 2021-12-24 11:56:12 +09:00
Bartłomiej Dach
5cbaa028eb
Use extracted ruleset config cache implementation in DI 2021-12-23 19:02:10 +01:00
Bartłomiej Dach
27c5cc5bd8
Add testing for beatmap card size switching 2021-12-23 15:55:51 +01:00
Bartłomiej Dach
1876617d8e
Implement beatmap card size tab control 2021-12-23 15:55:36 +01:00
Dean Herbert
d31c9db08b Adjust testing methodology to improve reliability of mosue wheel volume adjust tests 
There was previously a potential in headless runs for timing
discrepancies to cause the volume to never get adjusted.

As seen at https://github.com/peppy/osu/runs/4604610951?check_suite_focus=true.
 2021-12-23 13:25:24 +09:00
Dan Balasescu
e1b539fa9e
Merge pull request #16213 from peppy/working-beatmap-live 
Tidy up `WorkingBeatmap`
 2021-12-23 13:02:37 +09:00
Bartłomiej Dach
02fa1c21b7
Adjust existing placeholder test to demonstrate failure case 2021-12-22 15:03:20 +01:00
Dean Herbert
f3f491374b Remove unused load checks 2021-12-22 18:17:00 +09:00
Dean Herbert
967419c9ac Remove BeatmapSetInfo and Metadata from interface 
There were very few accesses to this, and after realm they should all be
done via the `BeatmapInfo`, so let's remove this.
 2021-12-22 18:17:00 +09:00
Dean Herbert
cfdfe81afb
Merge pull request #16205 from smoogipoo/fix-multiplayer-tests 
Fix multiplayer test failures when checking for parted room
 2021-12-22 13:42:05 +09:00
Dean Herbert
a88800c99a
Merge pull request #16198 from smoogipoo/fix-current-item-before-population 
Fix delete button showing on current item before beatmap retrieval
 2021-12-22 13:15:07 +09:00
Dan Balasescu
24c6f8fafa Fix multiplayer test failures when checking for parted room 2021-12-22 12:55:37 +09:00
Dan Balasescu
ee64ab6383 Fix delete button test failures 
Can be tested by adding a Thread.Sleep() in
DrawableRoomPlaylistItem.load().
 2021-12-22 09:55:19 +09:00
Dean Herbert
0bda7892f7
Merge pull request #16197 from bdach/beatmap-card/renames 
Rename beatmap card-related classes
 2021-12-21 18:51:34 +09:00
Dan Balasescu
e2f8c71081 Fix test 2021-12-21 18:38:31 +09:00
Dan Balasescu
a53c67b2ea
Merge pull request #16194 from peppy/fix-results-screen-wait-test 
Fix intermittent test failures on `TestSceneResultsScreen` due to long delay step
 2021-12-21 16:56:49 +09:00
Bartłomiej Dach
88d4e95ad8
Rename BeatmapCard{ => Normal} 2021-12-21 08:26:21 +01:00
Dean Herbert
2707b2fbda
Merge pull request #16012 from bdach/beatmap-card/extra 
Implement "extra" beatmap card size
 2021-12-21 15:40:33 +09:00
Dean Herbert
c0a8758839 Fix intermittent test failures on TestSceneResultsScreen due to long delay step 
Using real time delays of 3 seconds doesn't play well with headless runs.
 2021-12-21 15:15:05 +09:00
Dan Balasescu
a8cd96278d
Merge pull request #16189 from peppy/fix-beatmap-listing-overlay-test-failure 
Fix intermittent failures on `TestSceneBeatmapListingOverlay`
 2021-12-21 15:11:25 +09:00
Dean Herbert
0f8a6a3f64 Fix intermittent failures on TestSceneBeatmapListingOverlay 
In the specific method, there was no wait step after the initial fetch
(unlike all of the rest), meaning the fetch may not have finished in
time for the follow-up steps.

As seen at
https://github.com/ppy/osu/runs/4588058438?check_suite_focus=true.
 2021-12-21 14:12:06 +09:00
Dean Herbert
bb3f375958 Add note about local button clicking usage 2021-12-21 13:49:51 +09:00
Dean Herbert
aad55ef89e Remove unused method in TestSceneMultiplayerQueueList 2021-12-21 13:49:51 +09:00
Dean Herbert
9aff646ff4 Centralise all multiplayer button clicking test logic 
This adds the "wait for enabled" check in a way that can be easily
reused, as it keeps getting missed in test implementations.

This particular commit hopefully fixes
https://github.com/ppy/osu/runs/4583845033?check_suite_focus=true.
 2021-12-21 13:49:51 +09:00
Bartłomiej Dach
f1a03aced5
Merge branch 'master' into beatmap-card/extra 2021-12-20 15:49:00 +01:00
Bartłomiej Dach
0b7daf542f
Merge branch 'master' into fix-song-select-test-failure 2021-12-20 11:36:49 +01:00
Bartłomiej Dach
f492cf84d9
Ensure presence of at least 1 difficulty for each ruleset 2021-12-20 11:34:39 +01:00
Bartłomiej Dach
d8be455a43
Merge branch 'master' into fix-ready-button-test 2021-12-20 11:02:43 +01:00
Dean Herbert
ec0a6735eb Rename TestMultiplayerScreenStack to TestMultiplayerComponents 2021-12-20 18:24:59 +09:00
Dean Herbert
6907a9a3cc Name some screen stacks for better logging context 2021-12-20 18:24:14 +09:00
Dean Herbert
87051d5d61 Add better defined steps to TestLoseHostWhileReady ready button test 
Not 100% sure this will solve the issue but it's worth a try. The button
state checks are using `Until` everywhere else so this brings the test
in line with the standards.

As seen
https://github.com/ppy/osu/runs/4579641456?check_suite_focus=true.
 2021-12-20 17:47:06 +09:00
Dean Herbert
5c8e317a6e Chooser earlier items in song select tests to avoid potentially not having enough 2021-12-20 17:11:15 +09:00
Dean Herbert
af78a3e99d Fix weird loop logic 2021-12-20 17:09:08 +09:00
Dean Herbert
d79602a912 Add wait step to TestScenePlaylistResultScreen explicitly for screen load 2021-12-20 16:58:36 +09:00
Dean Herbert
2e47c4e25d
Merge pull request #16164 from smoogipoo/fix-intermittent-background-test 
Fix intermittent background screen test failures
 2021-12-20 14:00:53 +09:00
Dan Balasescu
9316abc278 Better fix for intermittent multiplayer tests 2021-12-20 13:10:13 +09:00
Dan Balasescu
11f3ec0cb5 Wait for previous screen to be hidden in test 2021-12-20 12:44:23 +09:00
Bartłomiej Dach
097402677d
Add test for ranked/unranked user display 2021-12-19 13:40:22 +01:00
Bartłomiej Dach
c112177559
Bring profile header test in line with modern conventions 
- Removed online code that didn't work anyway after the introduction of
  the development web instance.

- Removed some weird test steps.

- Fixed online/offline test steps not working at all due to identical
  user ID.
 2021-12-19 13:40:21 +01:00
Bartłomiej Dach
883fcf2604
Fix tests 2021-12-17 11:45:01 +01:00
Bartłomiej Dach
c6d0b5d200
Merge branch 'master' into beatmap-card/extra-wip 2021-12-17 11:11:36 +01:00
Bartłomiej Dach
54790bb758
Merge branch 'master' into fix-realm-post-storage-migration-failure 2021-12-17 00:19:46 +01:00
Dan Balasescu
488374b4a2 Don't show multiplayer channels in chat overlay 2021-12-16 16:41:47 +09:00
Bartłomiej Dach
cbb65e1e07
Merge branch 'master' into beatmap-card-expanded-state-fix 2021-12-15 22:20:30 +01:00
Dean Herbert
9e82a3e79a Merge branch 'master' into forego-resetting-spectate-state 2021-12-15 18:05:06 +09:00
Dan Balasescu
18d7b79207 Don't reset spectating state if gameplay is finished 2021-12-15 17:40:30 +09:00
Dean Herbert
39a0a21132 Add test coverage of same scenario without deletion 2021-12-15 17:30:09 +09:00
Dan Balasescu
d22e1b9001 Add another until step to guard against async test issues 2021-12-15 17:00:06 +09:00
Dan Balasescu
740a6f16c7 Fix exception when updating the room's visual playlist 2021-12-15 16:53:25 +09:00
Dean Herbert
e9187cc3cf Add failing test showing expanded state being unexpectedly lost 2021-12-15 16:26:19 +09:00
Dan Balasescu
2cea39a92a
Merge pull request #16083 from peppy/fix-online-availability-after-reimport 
Fix `OnlinePlayBeatmapAvailabilityTracker` failng after modified reimport of existing beatmap
 2021-12-15 08:31:02 +09:00
Dan Balasescu
da00c020be Remove whitespace 2021-12-15 07:33:49 +09:00
Bartłomiej Dach
00154fe86d
Merge branch 'master' into fix-menu-background-desync 2021-12-14 21:31:10 +01:00
Dean Herbert
0950d8d327 Add back PlaylistRoomCreation test 
Was spiritually removed in https://github.com/ppy/osu/pull/16045.

This implementation is mostly taken from that PR's comment thread
verbatim, and now works due to the associated changes to
`OnlinePlayBeatmapAvailabilityTracker`.
 2021-12-14 19:16:52 +09:00
Dean Herbert
04551ea61e
Merge pull request #16080 from smoogipoo/fix-storyboard-start-time 
Fix incorrect storyboard life time start with looping commands
 2021-12-14 18:33:56 +09:00
Dean Herbert
cebfeb5220
Merge pull request #16045 from smoogipoo/multiplayer-local-beatmap-query 
Rework multiplayer's current item tracking
 2021-12-14 18:33:30 +09:00
Dean Herbert
25a056dfad Remove pointless/broken test steps 
These aren't accurate and are tested via a more accurate means directly
above.
 2021-12-14 16:40:50 +09:00
Dean Herbert
b6a272e31a Add failing test coverage of BackgroundScreeNDefault's beatmap background tracking when active/non-active 2021-12-14 16:40:34 +09:00
Dan Balasescu
eb3050b2ac Fix incorrect test 2021-12-14 15:08:00 +09:00
Dean Herbert
441b7baa93 Provide a realm factory to usages of ToLive/RealmLive 2021-12-14 14:26:34 +09:00
Dan Balasescu
6e3558b222 Remove weird test 2021-12-14 06:38:57 +09:00
Dean Herbert
309290a3c9 Use new method in more places that can benefit from it 2021-12-13 16:56:43 +09:00
Dean Herbert
654b47c7ec Move "excess mods" test behaviour to local usages 
There were only two of these, so it doesn't make sense to add extra
complexity in the test resources class.
 2021-12-13 16:41:30 +09:00
Dean Herbert
99ac71c1fe Simplify usages where the ruleset being used is osu! ruleset 2021-12-13 16:37:20 +09:00
Dean Herbert
b0d14526ea Move test ScoreInfo creation to TestResources 
The main goal here is to remove the inheritance, since realm doesn't
like that. Unfortunate that we can't use object initialisers in a few of
these places, but no real way around that.
 2021-12-13 16:34:50 +09:00
Dean Herbert
3ea07b426b
Merge branch 'master' into multiplayer-local-beatmap-query 2021-12-13 13:27:34 +09:00
Dan Balasescu
2cd2b10ce1 Fix results sometimes showing incorrect score position 2021-12-13 06:54:57 +09:00
Dan Balasescu
bf3abb2455
Merge branch 'master' into multiplayer-local-beatmap-query 2021-12-12 16:37:41 +09:00
Dan Balasescu
9f792fec49 Fix test failures from async item loading 2021-12-12 16:11:48 +09:00
Dan Balasescu
99cd36d2f6 Resolve some test failures due to async population 2021-12-11 22:52:08 +09:00
Dan Balasescu
25b274c323 Fix starting gameplay too early after import 2021-12-11 22:47:50 +09:00
Dan Balasescu
1aac978a7b
Merge pull request #16029 from peppy/editor-mod-reset 
Fix editor not resetting mods when entering
 2021-12-11 20:20:11 +09:00
Dan Balasescu
cdb8237a4b
Merge branch 'master' into pre-realm-score-tidy 2021-12-11 19:25:39 +09:00
Dan Balasescu
6057037e35 Move playlist item beatmap population to MatchSubScreen 2021-12-10 20:08:59 +09:00
Dean Herbert
5e9510be36 Add test coverage of editor resetting mods on entering 2021-12-10 18:57:33 +09:00
Dean Herbert
bff02bedbf Rename APIScoreInfo to APIScore 2021-12-10 16:11:49 +09:00
Dean Herbert
dbb08f7d46 Use OnlineID for set operations 2021-12-10 16:11:48 +09:00
Dean Herbert
bf1418bafc Use OnlineID instead of legacy IDs for equality and lookups 2021-12-10 16:11:48 +09:00
Dean Herbert
261847bbec Avoid touching ScoreInfo.User directly 2021-12-10 15:39:29 +09:00
Dean Herbert
50bf2f368d
Merge branch 'master' into host-enqueue-2 2021-12-10 14:09:19 +09:00
Dean Herbert
1952819db2
Merge pull request #16019 from smoogipoo/cleanup-playlist-item-buttons 
Cleanup duplicated classes in DrawableRoomPlaylistItem
 2021-12-10 12:01:26 +09:00
Dan Balasescu
35a208a478
Merge pull request #15999 from peppy/restore-user-volume-muted-notification 
Fix the unmute notification potentially overwriting user's volume levels unnecessarily
 2021-12-10 02:58:59 +09:00
Dan Balasescu
a445dcd2c6 Fix incorrect test namespace 2021-12-10 02:09:31 +09:00
Dan Balasescu
671582a925 Allow host to enqeue items and items to be edited 2021-12-10 01:15:19 +09:00
Dan Balasescu
048a495115 Add edit button to DrawableRoomPlaylistItem 2021-12-10 01:08:54 +09:00
Dan Balasescu
05aa9635a8 Privatise button again 2021-12-10 00:38:18 +09:00
Dan Balasescu
f9af239ed9 Cleanup duplicated classes in DrawableRoomPlaylistItem 2021-12-09 23:56:49 +09:00
Dean Herbert
538a822760
Merge branch 'master' into multiplayer-playlist-deletion 2021-12-09 19:04:06 +09:00
Dean Herbert
b393f83028
Merge pull request #16009 from smoogipoo/cleanup-drawable-playlist 
Cleanup DrawableRoomPlaylist and DrawableRoomPlaylistItem
 2021-12-09 18:54:16 +09:00
Dean Herbert
dfe19f3509 Minor code reformatting 2021-12-09 17:53:40 +09:00
Dan Balasescu
1a0945daba Siplify condition, allow host to always remove items 2021-12-09 14:33:50 +09:00
Dan Balasescu
25620d1eef Merge branch 'cleanup-drawable-playlist' into multiplayer-playlist-deletion 2021-12-09 14:01:04 +09:00
Bartłomiej Dach
3ecfaa532c
Add source field to extra beatmap card 2021-12-08 22:56:28 +01:00
Bartłomiej Dach
a32492cdd5
Duplicate BeatmapCard{-> Extra} as blueprint for extra card size 2021-12-08 22:53:51 +01:00
Dan Balasescu
aec36adf6c Fix test failures 2021-12-09 04:22:34 +09:00
Dan Balasescu
c34c580ad4 Add client-side + interface implementation 2021-12-09 03:08:59 +09:00
Dan Balasescu
3b4833ca8e A bit of cleanup + xmldocs on classes/members 2021-12-09 01:40:16 +09:00
Dan Balasescu
26f6c5e5a5 Remove ctor params from PlaylistsRoomPlaylist 2021-12-09 01:16:37 +09:00
Dan Balasescu
3be4d8b68d Remove ctor params from DrawableRoomPlaylist/DrawablePlaylistItem 2021-12-09 01:04:56 +09:00
Dean Herbert
8d9c37a825 Merge branch 'master' into primary-key-consistency 2021-12-08 21:34:38 +09:00
Dan Balasescu
beb5d61a42 Separate playlist item deletion to Playlists-specific class 2021-12-08 20:50:25 +09:00
Dean Herbert
a969fe3ef8 Add test coverage showing intended UX of user's volume levels being retained when unmuting 2021-12-08 13:37:47 +09:00
Dean Herbert
724d72b975
Merge pull request #15988 from bdach/fix-team-versus-test-failure 
Fix test failures in team versus test
 2021-12-08 11:54:00 +09:00
Bartłomiej Dach
7720a1b69b
Fix test to wait for drawable ruleset load before attempting paste 2021-12-07 21:10:45 +01:00
Bartłomiej Dach
e9694dc74e
Wait for match type changes in team versus test 2021-12-07 20:40:10 +01:00
Dean Herbert
d6e68feadc
Merge pull request #15948 from bdach/beatmap-card/difficulty-dropdown 
Add difficulty dropdown to beatmap card
 2021-12-07 23:40:06 +09:00
Dan Balasescu
5ffe702dd6 Add match type and queue mode to multiplayer room panels 2021-12-07 18:57:13 +09:00
Dean Herbert
9033169177
Merge pull request #15951 from peppy/fix-failing-recorder-tests-w 
Fix intermittent test failures in scenes using `SpectatorClient`
 2021-12-06 18:40:27 +09:00
Dan Balasescu
568364b604 Fix indentation 2021-12-06 17:38:57 +09:00
Dean Herbert
cf34b3f70e
Merge pull request #15859 from peppy/realm-integration/skins-rebase 
Use realm for skins
 2021-12-06 17:12:23 +09:00
Dean Herbert
0d3d22d3e1 Update TestSceneReplayReocorder to be safer about disposal 2021-12-06 17:09:12 +09:00
Dean Herbert
50a5f52f92 Remove duplicated test scene (see TestSceeneReplayRecorder) 2021-12-06 17:09:11 +09:00
Dean Herbert
d58b85b381 Refactor TestScenSpectatorPlayback to properly clean up without async disposal 2021-12-06 17:09:11 +09:00
Dean Herbert
452fa93444 Merge branch 'master' into realm-integration/skins-rebase 2021-12-06 15:21:02 +09:00
Dean Herbert
0fa1a96e9d
Wait for beatmap sets to finish loading to avoid test failures 
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
 2021-12-06 15:03:17 +09:00
Dean Herbert
a76cfbea21 Add test coverage of incorrect beatmap being used in multiplayer when match started from song select 2021-12-06 14:03:33 +09:00
Bartłomiej Dach
af35652b8b
Disable beatmap card expansion on solo spectator screen 2021-12-05 20:07:58 +01:00
Bartłomiej Dach
a07f8c74dc
Add basic structure for composable card dropdown 2021-12-05 15:26:37 +01:00
ColdVolcano
86c908c657 Add test coverage 2021-12-05 03:53:36 -06:00
Bartłomiej Dach
38702beabf
Merge branch 'master' into i-ruleset-store 2021-12-04 15:05:39 +01:00
Dean Herbert
517a344bcc
Merge branch 'master' into new-multiplayer-playlist 2021-12-04 13:16:09 +09:00
Dan Balasescu
d5803e541b Give playlist items a PlayedAt date 2021-12-03 20:25:51 +09:00
Dan Balasescu
4145a16d5b
Merge pull request #15920 from peppy/clean-up-unused-resolves 
Clean up unused resolved properties
 2021-12-03 20:08:48 +09:00
Dean Herbert
1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
Dean Herbert
2acf46154a Remove many unused resolutions of RulesetStore 2021-12-03 18:16:29 +09:00
Dean Herbert
e75e209053 Cache and consume IRulesetStore where feasible 2021-12-03 18:16:01 +09:00
Dean Herbert
2927b235de Add test coverage of mouse wheel scroll adjusting volume 2021-12-03 17:18:07 +09:00
Dan Balasescu
10932dd282 Remove now unnecessary test 2021-12-02 22:58:25 +09:00
Dean Herbert
ec700e9142 Remove unused using statement 2021-12-02 14:01:57 +09:00
Dean Herbert
e855a49833 Add test coverage of default skin edit and export 2021-12-02 14:01:18 +09:00
Dean Herbert
65f0a80c97 Merge branch 'master' into realm-integration/skins-rebase 2021-12-02 13:37:20 +09:00
Dan Balasescu
89c47708a1 Merge branch 'master' into new-multiplayer-playlist 2021-12-01 21:35:23 +09:00
Dan Balasescu
f9b4e6f004 Add test considering expired items 2021-12-01 21:35:23 +09:00
Dan Balasescu
e87b0003fb Fix queue mode not being bound to in all cases 2021-12-01 21:35:23 +09:00
Dan Balasescu
ad35f3434b Fix queue list not considering expired items 2021-12-01 21:35:23 +09:00
Dan Balasescu
1152c4e8e9 Fix tests 2021-12-01 21:35:22 +09:00
Dan Balasescu
95050d6597 Extract class to file 2021-12-01 21:35:22 +09:00
Dan Balasescu
11c137cf83 Ignore test 2021-12-01 21:35:22 +09:00
Dan Balasescu
0b3cc47a51 Fix list not repopulating on new room 2021-12-01 21:35:22 +09:00
Dan Balasescu
a4cd22d5a9 Clear lists on room leave 2021-12-01 21:35:22 +09:00
Dan Balasescu
fc8c8685b8 Add playlist queue tests 2021-12-01 21:35:22 +09:00
Dan Balasescu
e0ca1af9b8 Remove ctor params 2021-12-01 21:35:22 +09:00
Dan Balasescu
bfd2dc28c8 Rename QueueList -> MultiplayerQueueList 2021-12-01 21:35:22 +09:00
Dan Balasescu
01108016a7 Add reorder test 2021-12-01 21:35:22 +09:00
Dan Balasescu
89d22824c3 Fix incorrect comment 2021-12-01 21:35:22 +09:00
Dan Balasescu
7e800659aa Fix incorrect assertion 2021-12-01 21:35:22 +09:00
Dan Balasescu
48a181af1f Fix test button display 2021-12-01 21:35:22 +09:00
Dan Balasescu
ef170471f0 Merge branch 'master' into new-multiplayer-playlist 2021-12-01 21:35:22 +09:00
Dan Balasescu
68bb49fc1e Add QueueList tests 2021-12-01 21:33:48 +09:00
Dan Balasescu
0cb35e8b18 Separate out QueueList 2021-12-01 21:33:48 +09:00
Dan Balasescu
17bc0b51aa Merge branch 'playlist-item-add-owner' into new-multiplayer-playlist 2021-12-01 21:33:48 +09:00
Dan Balasescu
942e48ffbd Merge branch 'master' into new-multiplayer-playlist 2021-12-01 21:33:11 +09:00
Dan Balasescu
c38537a51a Initial implementation of MultiplayerPlaylist 2021-12-01 21:32:56 +09:00
Dan Balasescu
7d0135063e
Merge pull request #15875 from peppy/fix-match-type-propagation 
Fix match type not being propagated correctly to other users' settings
 2021-12-01 11:23:28 +09:00
Bartłomiej Dach
de034b4d9c
Fix test failures due to wrong asserts & uninitialised playlist 
* The "create room" button was disabled headless due to not specifying
  the imported beatmap. In visual tests it seems to work due to
  selecting from the local database randomly.

* The test asserts are brought in line with expectations.
 2021-11-30 20:57:08 +01:00
Bartłomiej Dach
b74b09eb3a
Add extra until step to make cause of potential failures more obvious 2021-11-30 20:56:11 +01:00
Dean Herbert
dda7142f48 Fix double screen exit in multiplayer song select tests potentially causing failure 2021-12-01 02:06:40 +09:00
Dean Herbert
8de06803a8
Fix incorrect test step text 
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
 2021-11-30 17:16:30 +09:00
Dean Herbert
049d9ce5ef Add test coverage of match type propagating to other users' settings 2021-11-30 17:09:32 +09:00
Dean Herbert
1ff0326f8e Merge branch 'master' into realm-integration/skins-rebase 2021-11-30 15:50:10 +09:00
Dean Herbert
a73919917c Fix intermittent test failures in TestScenBeatmapInfoWedge due to async load 
https://github.com/ppy/osu/runs/4358685294?check_suite_focus=true

Occurs due to the wedge content also reloading on ruleset change, which
wasn't being accounted for. In a fail case, the content would change
during the "select beatmap" step's async load wait, causing incorrect
results.

51a353e12d/osu.Game/Screens/Select/BeatmapInfoWedge.cs (L70)
 2021-11-30 12:32:09 +09:00
Bartłomiej Dach
0fc4d6dc2a
Implement beatmap card difficulty list 2021-11-29 22:04:09 +01:00
Dean Herbert
f6a3709060 Store default skins to database 2021-11-29 18:28:25 +09:00
Dean Herbert
23146d59d1 Use ILive for current skin 2021-11-29 18:28:25 +09:00
Dean Herbert
2a9c7c00c8 Update tests and file access code 2021-11-29 18:28:25 +09:00
Bartłomiej Dach
05f7ea6b6d
Remove mentions of "panel" and "direct" from names of old download buttons 2021-11-27 15:08:03 +01:00
Bartłomiej Dach
a043d1e427
Move old beatmap download button to more general namespace 2021-11-27 15:06:57 +01:00
Bartłomiej Dach
567c985da0
Remove beatmap panel test scene 2021-11-27 14:56:27 +01:00
Dan Balasescu
e1445dcb05 Only show owner in match subscreen 2021-11-26 17:40:45 +09:00
Dan Balasescu
e9a19aacd7 Fix tests by requiring host 2021-11-26 17:23:50 +09:00
Dan Balasescu
8541db1e85 Merge branch 'master' into playlist-item-add-owner 2021-11-26 17:13:23 +09:00
Dan Balasescu
1f5d95666e Add owner avatar to multiplayer items 2021-11-25 23:15:29 +09:00
Dean Herbert
7a3c69544b
Merge pull request #15799 from smoogipoo/fix-songselect-test-failures-2 
Fix SongSelect-related test failures
 2021-11-25 23:01:06 +09:00
Dan Balasescu
d0c0b7ce47 Fix intermittent beatmap thumbnail test 2021-11-25 22:05:39 +09:00
Dan Balasescu
09dd054283 Fix SongSelect-related test failures 2021-11-25 21:11:13 +09:00
Dan Balasescu
f712aeee01
Merge pull request #15795 from peppy/realm-integration/separate-download-flow 
Split out download logic from main manager classes
 2021-11-25 20:59:23 +09:00
Dean Herbert
a2ab9f457d Move score download logic out of ScoreManager 2021-11-25 17:33:04 +09:00
Dean Herbert
e6cfe44652 Fix occasional test failure due to default value oversight in TestSceneBeatmapCarousel 2021-11-25 16:29:06 +09:00
Dean Herbert
1533e245de
Merge pull request #15767 from bdach/beatmap-card/track-preview 
Add preview track playback function to beatmap card
 2021-11-25 12:08:03 +09:00
Bartłomiej Dach
1907b42f82
Use constant online IDs in tests to avoid preview not working randomly 2021-11-24 20:34:33 +01:00
Dan Balasescu
132bb59203 Update working beatmap when returning to match 2021-11-24 19:56:02 +09:00
Dan Balasescu
e176083898
Merge pull request #15781 from peppy/beatmap-set-status 
Rename `BeatmapSetOnlineStatus` to `BeatmapOnlineStatus`
 2021-11-24 19:25:29 +09:00
Dean Herbert
b739b6a725
Merge branch 'master' into beatmap-card/track-preview 2021-11-24 18:54:25 +09:00
Dean Herbert
183b95cbc2 Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus 
This variable is used at more than just a set level.
 2021-11-24 18:42:49 +09:00
Dean Herbert
0fe27cc8a1 Replace one more usage 2021-11-24 18:29:33 +09:00
Dean Herbert
7603f7eb36 Fix a few incorrectly updated arguments 2021-11-24 18:14:18 +09:00
Dean Herbert
0c819b9cfb Combine all test data BeatmapSetInfo creation into a single method 2021-11-24 18:07:32 +09:00
Dan Balasescu
74b6c33fab
Merge pull request #15778 from peppy/ruleset-info-id-usage 
Update usages of `RulesetInfo.ID` to use `OnlineID` instead
 2021-11-24 16:55:28 +09:00
Dan Balasescu
8ce5324c8b
Merge pull request #15772 from peppy/remove-model-list-inits 
Initialise `BeatmapSet.Beatmaps` list at construction time
 2021-11-24 16:41:19 +09:00
Dean Herbert
f283770f34 Update mock RulesetInfo usage to set OnlineID instead of ID 2021-11-24 15:50:26 +09:00
Dean Herbert
44c34ca7b2 Revert changes causing BeatmapSet.Metadata to be expectedly null in some tests 2021-11-24 14:52:08 +09:00
Dan Balasescu
cf17c51df2
Merge pull request #15770 from peppy/fix-incorrect-id-usage-in-tests 
Fix incorrect usage of `ID` in `TestSceneMultiplayerResults`
 2021-11-24 13:51:30 +09:00
Dean Herbert
8c60f37508 Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment 2021-11-24 13:27:37 +09:00
Dean Herbert
b1f3e98045 Fix incorrect usage of ID in TestSceneMultiplayerResults 2021-11-24 13:05:51 +09:00
Dean Herbert
729f681938 Update cases where equality can be used instead of primary key equality 2021-11-24 12:49:57 +09:00
Dean Herbert
049f25a133
Merge pull request #15757 from smoogipoo/fix-multiplayer-tests 
Fix several intermittent multiplayer test failures
 2021-11-24 09:32:01 +09:00
Bartłomiej Dach
1a1603f0db
Implement preview track playback 2021-11-23 23:17:30 +01:00
Bartłomiej Dach
9164f006aa
Implement basic behaviour of play button 2021-11-23 22:44:09 +01:00
Bartłomiej Dach
b44db9f5e5
Add test scene for thumbnail component 2021-11-23 22:44:08 +01:00
Dan Balasescu
a521d1b835 Wait for ready button to be enabled first 2021-11-23 17:09:38 +09:00
Dan Balasescu
fd4d5e98a7
Merge pull request #15745 from bdach/settings-number-box-stack-overflow 
Fix crashes on trying to play back replays of seeded mods with seed value over 1 billion
 2021-11-23 16:36:05 +09:00
Dan Balasescu
6363833fb3 Revert unnecessary changes 2021-11-23 16:17:09 +09:00
Dan Balasescu
69a9fc9732 Fix a few more multiplayer test timeouts 
These can be tested by adding a `Task.Delay(3000);` at the end of the
`MultiplayerClient.JoinRoom` task. The reason is typically that
`Client.Room` becomes not-null but the join task still hasn't completed
yet, so e.g. the ready button is still disabled.
 2021-11-23 16:07:03 +09:00
Bartłomiej Dach
b596a0204c
Rewrite overflow test step for legibility 2021-11-23 06:43:17 +01:00
Dan Balasescu
10bd7176e0 Fix potential test failure in TestSceneMultiplayerReadyButton 
Couldn't exactly reproduce https://github.com/ppy/osu/runs/4294316800,
but I found a similar issue via:

```diff
diff --git a/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs b/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs
index 84b63a5733..29cac9b061 100644
--- a/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs
+++ b/osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerReadyButton.cs
@@ -3,6 +3,7 @@

 using System;
 using System.Linq;
+using System.Threading;
 using System.Threading.Tasks;
 using NUnit.Framework;
 using osu.Framework.Allocation;
@@ -81,6 +82,8 @@ private void load(GameHost host, AudioManager audio)

                         await Client.ToggleReady();

+                        Thread.Sleep(1000);
+
                         readyClickOperation.Dispose();
                     });
                 }
```
 2021-11-23 14:07:55 +09:00
Dean Herbert
e580fc5abc
Merge pull request #15735 from peppy/remove-ruleset-info-inheritance 
Remove subclassing of `RulesetInfo`
 2021-11-23 10:18:32 +09:00
Bartłomiej Dach
dced6a2e68
Add extended test coverage for desired input handling 2021-11-22 20:39:44 +01:00
Bartłomiej Dach
2350806b4c
Add failing test case for number box stack overflow scenario 2021-11-22 20:26:45 +01:00
Dean Herbert
001f7c36f3 Use Equals in carousel tests for better realm compatibility 2021-11-22 17:20:21 +09:00
Dean Herbert
b9923e5396 Remove subclassing of RulesetInfo 2021-11-22 16:39:17 +09:00
Dan Balasescu
f64d20ed71 Fix APIRoom queue mode not updated on change 2021-11-22 13:46:01 +09:00
Dean Herbert
bbb3abbc61
Merge branch 'master' into multi-queueing-modes 2021-11-22 12:32:47 +09:00
Dan Balasescu
cad6d1d25d Adjust test to match new logic 2021-11-22 11:20:19 +09:00
Dan Balasescu
53dbbd6d64 Compare playlist item IDs instead in tests 2021-11-22 11:17:32 +09:00
Dan Balasescu
4b498c7bd6 Merge branch 'master' into multi-queueing-modes 2021-11-22 07:46:45 +09:00
Dean Herbert
c0962b1c4f
Merge branch 'master' into beatmap-card/download-button 2021-11-21 20:04:26 +09:00
Bartłomiej Dach
65cb011bac
Merge branch 'master' into beatmap-card/download-button 2021-11-20 18:49:11 +01:00
Bartłomiej Dach
297de27a6a
Use BindTarget from card rather than caching & resolving download tracker 2021-11-20 18:48:26 +01:00
Bartłomiej Dach
15feb17da8
Change difficulty cache storage type to nullable 
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
 2021-11-20 17:00:50 +01:00
Dean Herbert
83b4625bd5 Replace existing cases with new helper method 2021-11-19 22:15:41 +09:00
Dan Balasescu
de0e8ad822 Merge branch 'master' into multi-queueing-modes 2021-11-19 18:58:15 +09:00
Dan Balasescu
4e625b78e2 Update queue mode names 2021-11-19 18:28:43 +09:00
Dan Balasescu
a6a786b167 Remove namespacing of queue tests 2021-11-19 15:43:11 +09:00
Dean Herbert
0c289bf8e5 Remove pointless namespace 2021-11-19 14:46:53 +09:00
Dean Herbert
6dc6ca1bbb Fix potential null reference in FadeAccessibleBackground test class 2021-11-19 14:03:07 +09:00
Dean Herbert
cb2547a6be Merge branch 'master' into multi-queueing-modes 2021-11-19 13:20:57 +09:00
Bartłomiej Dach
8a1d6757af
Merge branch 'master' into beatmap-card/download-button 2021-11-18 22:37:35 +01:00
Bartłomiej Dach
412abf30d9
Refactor buttons again to work with latest design guidelines 2021-11-18 22:34:40 +01:00
Dan Balasescu
1dacc50ecb Merge branch 'master' into multi-queueing-modes 2021-11-18 15:16:27 +09:00
Dean Herbert
d7b178ea37 Update test scenes which should not handle key repeat 2021-11-18 13:13:36 +09:00
Dan Balasescu
e4aec3f519
Merge pull request #15648 from peppy/playlist-show-invalid-beatmaps 
Highlight invalid playlist items during room creation
 2021-11-17 22:24:22 +09:00
Dean Herbert
a4953b5658 Update some remaining test usage of database ID 2021-11-17 20:56:57 +09:00
Dean Herbert
7c2e79f911 Update all simple cases of switching to IWorkingBeatmap 2021-11-17 20:56:57 +09:00
Dan Balasescu
f9e3d9bb92
Merge branch 'master' into i-working-beatmap/difficulty-calculator 2021-11-16 17:46:38 +09:00
Dean Herbert
2d125893fc Add tests and disable selection on invalid items 2021-11-16 17:23:52 +09:00
Dean Herbert
79e26b0703
Merge branch 'master' into fix-beatmap-recommendations-test 2021-11-16 16:19:47 +09:00
Dan Balasescu
29d0d5badf Rename QueueModes -> QueueMode 2021-11-16 14:53:10 +09:00
Dean Herbert
4856180912 Use new helper method 2021-11-15 19:19:53 +09:00
Dean Herbert
86b8fd3720 Fix TestSceneBeatmapRecommendations testing with an online ID of 0 2021-11-15 19:19:53 +09:00
Dean Herbert
62d670a3ca Update DifficultyCalculator to take an IWorkingBeatmap 2021-11-15 19:16:48 +09:00
Dan Balasescu
5e2ccd5c85 Merge branch 'master' into multi-queueing-modes 2021-11-15 15:26:34 +09:00
Dean Herbert
5471994450
Merge branch 'master' into sample-point-multiple 2021-11-15 14:13:58 +09:00
Dean Herbert
fdbb59fd1d
Merge branch 'master' into gameplay-test/share-clock-state 2021-11-15 13:49:17 +09:00
Dean Herbert
5be22916bb Add test coverage against frequency ramp increasing between fail animation and fail screen 2021-11-14 14:41:17 +09:00
Bartłomiej Dach
ca239ca40a
Add failing test case for sharing clock state with gameplay test 2021-11-13 22:10:59 +01:00
Bartłomiej Dach
73ca1d39a2
Improve sample bank text box UX in case of multiple selection 2021-11-13 21:59:44 +01:00
Bartłomiej Dach
76baf08140
Expand test coverage with desired bank text box placeholder behaviour 2021-11-13 21:59:44 +01:00
Bartłomiej Dach
3fee6b0938
Add support for setting sample bank & volume for multiple objects at once 2021-11-13 21:24:59 +01:00
Bartłomiej Dach
9cf45e418a
Add failing test coverage for setting sample bank on multiple objects 2021-11-13 21:24:58 +01:00
Bartłomiej Dach
6ba154129b
Add failing test coverage for setting sample volume on multiple objects 2021-11-13 18:14:50 +01:00
Bartłomiej Dach
9800cd4903
Add test coverage for sample control point piece operation 2021-11-13 18:14:50 +01:00
Dean Herbert
983d5a6cb8
Merge branch 'master' into difficulty-point-multiple 2021-11-13 23:47:12 +09:00
Bartłomiej Dach
b58fe2d80a
Restructure card to use single tracker at the top level 2021-11-13 15:39:03 +01:00
Bartłomiej Dach
be3f225d4b
Update in line with Online{BeatmapSet -> }ID changes 2021-11-13 15:01:37 +01:00
Bartłomiej Dach
c38c95b373
Merge branch 'master' into beatmap-card/download-button 2021-11-13 14:59:59 +01:00
Bartłomiej Dach
5f2a789a6d
Ensure editor clock is stopped before testing gameplay 2021-11-13 14:01:00 +01:00
Bartłomiej Dach
eb8c5292d5
Ensure editor background is dimmed after return from gameplay test 2021-11-13 13:50:57 +01:00
Bartłomiej Dach
a5ba3bd012
Move gameplay test pieces to own namespace 2021-11-13 13:39:17 +01:00
Bartłomiej Dach
e55e2a1697
Allow to adjust slider velocity on multiple objects simultaneously 2021-11-12 23:32:11 +01:00
Bartłomiej Dach
b8b86cbd2a
Add failing tests for desired multiple selection behaviour 2021-11-12 23:32:11 +01:00
Bartłomiej Dach
7ba93aac27
Add test coverage for difficulty point piece operation 2021-11-12 22:16:09 +01:00
Dan Balasescu
6fb2ccbb86 Add failing test ensuring room is updated after join 2021-11-13 02:32:00 +09:00
Dan Balasescu
060b4fa526 Fix failing multiplayer player test 2021-11-13 02:01:48 +09:00
Dan Balasescu
3b24ec3643 Merge branch 'master' into multi-queueing-modes 2021-11-12 22:16:04 +09:00
Dean Herbert
692e846acd Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface 2021-11-12 17:52:44 +09:00
Dean Herbert
6a098a8634 Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
Dean Herbert
62600f1390
Merge branch 'master' into editor-gameplay-test 2021-11-12 14:14:06 +09:00
Bartłomiej Dach
459ec7b3bf
Fix test failures due to missing dependencies 2021-11-11 20:54:37 +01:00
Bartłomiej Dach
c465bcb821
Ensure track is stopped on player completion 2021-11-11 20:54:36 +01:00
Bartłomiej Dach
385df51b06
Ensure editor test player is exited on completion 2021-11-11 20:54:36 +01:00
Bartłomiej Dach
6ce1a78723
Add test coverage for basic gameplay testing scenarios 2021-11-11 20:54:36 +01:00
Bartłomiej Dach
32b5a736c8
Add preview gameplay button to bottom editor bar 2021-11-11 17:12:21 +01:00
Bartłomiej Dach
dbdbfc4723
Add failing test case for PP counter not initially updating 2021-11-11 16:33:31 +01:00
Dan Balasescu
5c8c121446 Update behaviour to match server (removing playlist items) + tests 2021-11-11 23:39:15 +09:00
Dan Balasescu
07a7b4bcdc Merge branch 'master' into multi-queueing-modes 2021-11-11 22:19:30 +09:00
Bartłomiej Dach
9bad912dd0
Add failing test case 2021-11-11 13:22:06 +01:00
Dan Balasescu
4db2ad1cb3
Merge branch 'master' into rename-ef-model-properties 2021-11-11 19:12:54 +09:00
Dean Herbert
51a353e12d Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
Dean Herbert
ebe58cee11 Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface 2021-11-11 17:19:46 +09:00
Bartłomiej Dach
f38d6ef8db
Add failing test steps 2021-11-11 09:01:50 +01:00
Dean Herbert
8371307709
Merge branch 'master' into editor-clipboard-refactor 2021-11-11 01:09:39 +09:00
Bartłomiej Dach
91baaa73f3
Show download progress on card body rather than in button 2021-11-10 16:03:48 +01:00
Bartłomiej Dach
5e31e890ae
Extract class for clipboard contents for DI purposes 2021-11-10 12:36:23 +01:00
Bartłomiej Dach
343318c6f9
Merge branch 'master' into display-string 2021-11-10 11:10:38 +01:00
smoogipoo
35a5182ebf Merge branch 'master' into multi-queueing-modes 2021-11-10 15:01:13 +09:00
Dean Herbert
52c740b377 Add failing test showing team display display failure 2021-11-10 13:44:31 +09:00
Bartłomiej Dach
410e9159d1
Fix test failures due to missing dependencies 2021-11-09 19:54:38 +01:00
Bartłomiej Dach
03a315b9f5
Fix missing beatmap in replay download test scene 
Was causing nullrefs in `GetDisplayTitle()`.
 2021-11-09 14:33:06 +01:00
Dean Herbert
3b485b5f37 Rewrite PreviewTrackManager to avoid constructing TrackBass locally 
This paves the way for the framework code quality change
(https://github.com/ppy/osu-framework/pull/4873) which stops exposing
the constructor.

Most of the restructuring here is required to give `PreviewTrackManager`
an adjustable target to apply the global mute.
 2021-11-09 17:38:12 +09:00
Bartłomiej Dach
74c37e248d
Merge branch 'master' into master 2021-11-09 08:40:52 +01:00
Bartłomiej Dach
2186b51676
Implement detailed download button behaviour 2021-11-08 22:18:14 +01:00
Bartłomiej Dach
a60cceeda6
Implement basic appearance of download button 2021-11-08 22:18:14 +01:00
Bartłomiej Dach
c65e7a4436
Add test coverage for download button 2021-11-08 22:17:56 +01:00
Bartłomiej Dach
f4b8dee2d0
Update favourite statistic value on favourite button clicks 2021-11-08 11:53:54 +01:00
Bartłomiej Dach
5cb533004d
Add test coverage for favourite button 2021-11-08 11:53:53 +01:00
smoogipoo
c716051530 Merge branch 'master' into multi-queueing-modes 2021-11-08 19:19:50 +09:00
Dean Herbert
8b85c2c8de
Merge pull request #15491 from peppy/remove-stupid-weak-reference-bindable-events 
Revert weird event flow in model manager/importers
 2021-11-08 15:19:58 +09:00
Dean Herbert
a2dfb5fd8c
Merge pull request #15513 from bdach/beatmap-card/statistics 
Add statistics display to beatmap card
 2021-11-08 14:45:56 +09:00
Dan Balasescu
1c40d5bc08
Merge branch 'master' into remove-stupid-weak-reference-bindable-events 2021-11-08 14:41:32 +09:00
Dean Herbert
dede0e56ce
Merge branch 'master' into user-lookup-by-username-cleanup 2021-11-08 13:38:26 +09:00
Dean Herbert
78aef9ce86
Merge branch 'master' into remove-stupid-weak-reference-bindable-events 2021-11-08 13:35:49 +09:00
Dean Herbert
1589b50d6e Merge branch 'master' into beatmap-card/statistics 2021-11-08 13:28:31 +09:00
Dean Herbert
43f87844e2 Add text to test cards to better explain their purpose 2021-11-08 13:27:04 +09:00
Dean Herbert
62600b47b1 Merge branch 'master' into user-class-cleanup 2021-11-08 12:51:12 +09:00
Bartłomiej Dach
0e09edfce2
Do not show nomination info if hype info not present to match web 2021-11-07 21:33:42 +01:00
Bartłomiej Dach
1f405a7e71
Display extended statistics on card hover 2021-11-07 21:33:41 +01:00
Bartłomiej Dach
04c2a9cd59
Display basic statistics on card hover 2021-11-07 21:03:06 +01:00
Bartłomiej Dach
6d30248cef
Merge branch 'master' into use-class-rename 2021-11-07 15:41:00 +01:00
Dean Herbert
0ecf5f201c Rename User to APIUser and move to correct namespace 2021-11-07 11:26:01 +09:00
Bartłomiej Dach
6a1c27d67a
Merge branch 'master' into fix-more-null 2021-11-06 15:36:15 +01:00
Dean Herbert
b8fb22b769 Add missing test coverage of score import process being tracked correctly 2021-11-06 16:45:55 +09:00
Chinmay Patil
77e853ce25 Optimized UR Counter and removed redundant code 2021-11-05 12:16:58 -06:00
Dean Herbert
54f72d68ca Revert weird event flow in model manager/importers 2021-11-05 19:12:49 +09:00
smoogipoo
7bbb2a7a67 Fix post-merge issues 2021-11-05 15:57:32 +09:00
smoogipoo
e6deb0c873 Merge branch 'master' into multi-queueing-modes 2021-11-05 15:57:25 +09:00
Salman Ahmed
b723975767 Replace pragma with add/remove => throw 2021-11-05 09:10:38 +03:00
Dean Herbert
ba74dd93b2 Remove weird fetchOnline logic 2021-11-05 13:55:34 +09:00
Dean Herbert
1f5ca122b0 Merge branch 'master' into user-class-cleanup 2021-11-05 13:55:22 +09:00
Dean Herbert
ead64282dd Split out a couple more nested classes 2021-11-05 13:40:44 +09:00
Dan Balasescu
acb06d4a99
Merge branch 'master' into beatmap-refactor/remove-online-info 2021-11-05 12:46:02 +09:00
Salman Ahmed
2764ad90ea
Merge branch 'master' into fix-more-null 2021-11-05 05:14:22 +03:00
Salman Ahmed
af6ae1cce5 Remove hacky code with explicit pragma disable 2021-11-05 03:49:35 +03:00
Bartłomiej Dach
9246adc349
Add failing test coverage for labelled drawable description visible 2021-11-04 21:43:20 +01:00
Chinmay Patil
8923561b05 Removed Unnessicary class in the Test file, and optimized UR counter 2021-11-04 14:27:48 -06:00
Dean Herbert
7049d0de66 Merge branch 'master' into beatmap-refactor/remove-online-info 2021-11-05 01:16:11 +09:00
Chinmay Patil
a76878e053 A bit more formatting 2021-11-04 09:52:16 -06:00
Chinmay Patil
c568888500 Edited to remove unessicary blank lines 2021-11-04 09:47:52 -06:00
Chinmay Patil
223efe55d5 Added Tests for UR counter 2021-11-04 09:23:29 -06:00
Dean Herbert
ed07ee8c61 Update all existing usages of AuthorString/AuthorId 
Unfortunately the getters need to be left in place else EF breaks.
 2021-11-04 18:59:37 +09:00
Dan Balasescu
45dcf187b9
Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended 2021-11-04 18:59:04 +09:00
Dean Herbert
86540d1fb6 Update existing usages of Author as string to access Username directly 2021-11-04 18:57:54 +09:00
Dean Herbert
b9983add15 Rename User to APIUser and move to correct namespace 2021-11-04 18:21:31 +09:00
Dean Herbert
d2831b1152 Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2 2021-11-04 17:09:50 +09:00
Dean Herbert
77be610b26 Revert "Clean up DirectDownloadButton test scene" 
This reverts commit baabe99f78.
 2021-11-04 17:09:20 +09:00
Dean Herbert
5a078da4d9 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:50:14 +09:00
Dean Herbert
8f459e6ce8 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:44:17 +09:00
Dean Herbert
baabe99f78 Clean up DirectDownloadButton test scene 2021-11-04 16:28:29 +09:00
Dean Herbert
0f4f1349db Merge branch 'master' into editor-context-menu-on-select 2021-11-04 15:59:06 +09:00
Dean Herbert
9c926e5514 Remove BeatmapSetInfo.OnlineInfo and all usages 2021-11-04 15:23:04 +09:00
Dean Herbert
66f4516eee Allow creating sample API models without specifying a ruleset 2021-11-04 15:23:04 +09:00
Dean Herbert
d1e6d1cb98 Update some other missed incorrect null/empty usages 2021-11-04 14:50:43 +09:00
Bartłomiej Dach
6e33fa088f
Add test case for drawable room with too long beatmap name 2021-11-03 17:32:53 +01:00
Bartłomiej Dach
cf7545e36c
Merge branch 'master' into beatmap-card-basics 2021-11-03 00:11:03 +01:00
Dean Herbert
1bfa1365a0 Rename "null user" tests to better explain purpose 2021-11-02 17:13:37 +09:00
Dean Herbert
e472656b37 Add test coverage of room participants updating on room join 2021-11-02 17:13:37 +09:00
Bartłomiej Dach
5962f16b1c
Implement basic card appearance 2021-11-01 19:41:11 +01:00
Bartłomiej Dach
d82564aab6
Add test scene for beatmap cards 2021-11-01 19:41:10 +01:00
Dean Herbert
caa9d8997b Merge branch 'master' into score-refactor/less-create-score-info 2021-11-01 22:59:11 +09:00
Bartłomiej Dach
0d65493b56
Mark test usages of Ruleset.CreateInstance() as returning non-null 2021-11-01 12:12:21 +01:00
Bartłomiej Dach
5dcff7d8b7
Merge branch 'master' into score-refactor/less-create-score-info 2021-11-01 11:41:20 +01:00
smoogipoo
887fa54988 Add FFA queueing mode tests 2021-11-01 19:25:47 +09:00
smoogipoo
1564048d8d Add one more test 2021-11-01 18:55:42 +09:00
smoogipoo
3db199292f Fix queue mode not passed from room to settings overlay 2021-11-01 18:52:57 +09:00
smoogipoo
65b920e4c1 Merge branch 'master' into multi-queueing-modes 2021-11-01 18:37:16 +09:00
Dean Herbert
b21e0e7efb Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays 2021-11-01 18:07:51 +09:00
Bartłomiej Dach
6a44cf3ff1
Add missing beatmap spec in test scene 2021-11-01 09:44:08 +01:00
Bartłomiej Dach
f5feed138d
Merge branch 'master' into score-refactor/isolated-serialisation 2021-11-01 09:43:51 +01:00
Dean Herbert
90a0a5e0b7 Fix attempting to set properties of null BeatmapSets in tests 2021-11-01 17:12:15 +09:00
Dean Herbert
63c9512ab1 Update dashboard components to use APIBeatmapSet 2021-11-01 16:04:01 +09:00
Dean Herbert
269a8df0ec Fix HasReplay not being corrrectly implemented by APIScoreInfo 2021-11-01 13:20:37 +09:00
Bartłomiej Dach
8053b2c320
Merge branch 'master' into score-refactor/isolated-serialisation 2021-10-30 15:07:34 +02:00
Dean Herbert
bb9769aa17 Fix null ruleset in another place 2021-10-29 20:12:12 +09:00
Dean Herbert
22c2f48e4d Fix more null rulesets 2021-10-29 19:05:42 +09:00
Dean Herbert
a16c8f1ebc Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet 2021-10-29 18:50:55 +09:00
Dean Herbert
993a28b37e Merge branch 'beatmap-refactor/difficulty-icons' into beatmap-refactor/beatmap-overlays 2021-10-29 18:35:26 +09:00
Dean Herbert
04acc7601c Fix one more missed case 2021-10-29 18:35:15 +09:00
Dean Herbert
07e3ced315 Fix test scene and remove "impossible" nullable coalesce 2021-10-29 18:22:23 +09:00
Dean Herbert
8ad33d43d0 Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays 2021-10-29 18:01:17 +09:00
Dean Herbert
3598adb344 Fix test implementing old version of class 2021-10-29 17:04:56 +09:00
smoogipoo
7c6b3cb080 Rename test scene 2021-10-29 16:45:40 +09:00
smoogipoo
2408011c81 Don't replace identical playlist items 2021-10-29 16:44:51 +09:00
smoogipoo
e667ef4eea Add basic tests 2021-10-29 15:44:48 +09:00
Dean Herbert
31403daa20 Change DrawableProfileScore to use APIScoreInfo 2021-10-29 15:14:52 +09:00
Dean Herbert
17a83f701a Store mods as APIMods for the time being 2021-10-29 15:13:49 +09:00
smoogipoo
746f4a49c1 Add base test scene 2021-10-29 13:56:07 +09:00
Dean Herbert
1944c255a7 Implement score interfaces 2021-10-29 13:49:30 +09:00
Dean Herbert
817369903a Rename API score classes 2021-10-29 13:40:56 +09:00
smoogipoo
f076b72fbe Merge branch 'master' into multi-queueing-modes 2021-10-29 10:48:16 +09:00
smoogipoo
c96b07c625 Remove unnecessary/wrong code 2021-10-28 18:24:04 +09:00
smoogipoo
2b3e63470d Merge branch 'master' into always-unique-test-online-ids 2021-10-28 18:23:45 +09:00
Dan Balasescu
6e79a0947a
Merge pull request #15340 from peppy/add-number-setting-source-test 
Add visual test for `SettingsNumberBox` usage in settings source context
 2021-10-28 18:19:45 +09:00
Dean Herbert
4f4f2503aa
Merge pull request #15335 from smoogipoo/cleanup-multiplayer-screen-tests 
Clean up multiplayer-screen tests by removing intermediate screen
 2021-10-28 17:28:26 +09:00
Dean Herbert
c0848486d6 Add missing test coverage for attempt count display 2021-10-28 17:27:16 +09:00
Dean Herbert
8076e22e70 Replace weird import handling 2021-10-28 17:27:16 +09:00
Dan Balasescu
b21f42ec76
Merge branch 'master' into add-number-setting-source-test 2021-10-28 17:25:52 +09:00
Dan Balasescu
e5a7589859
Merge pull request #15317 from peppy/beatmap-refactor/uncontested 
Update `UpdateableBeatmapBackgroundSprite` to accept `IBeatmapInfo`
 2021-10-28 17:24:49 +09:00
Dean Herbert
b096bf6cd1 Ensure all test beatmaps have unique OnlineIDs to avoid import conflicts 
The order of operation of imports means that the already-imported
instances are considered most correct (they have usually been populated
using an online source, although that is skipped in tests), so on two
consecutive test imports in a test scene, the second will lose its
online IDs completely.

This aims to ensure that all test beatmaps will have online IDs, which
is the general expected behaviour.
 2021-10-28 16:56:31 +09:00
Dean Herbert
6f5040722a Merge branch 'master' into beatmap-refactor/uncontested 2021-10-28 16:37:26 +09:00
Dean Herbert
1e1f8c472a Add icons to various progress notification states 2021-10-28 16:34:12 +09:00
Dean Herbert
dce19cf7e4 Add visual test for SettingsNumberBox usage in settings source context 2021-10-28 15:42:06 +09:00
smoogipoo
e2c08fb2e5 Create room by clicking button 2021-10-28 15:41:59 +09:00
smoogipoo
b0b27a47d5 Rename test scene 2021-10-28 15:28:16 +09:00
smoogipoo
cf15282077 Merge branch 'master' into fix-playlists-room-subscreen-tests 2021-10-28 15:26:48 +09:00
Dean Herbert
56e3a42abe Remove unused using statement 2021-10-28 15:14:29 +09:00
smoogipoo
0e293471c2 Clean up multiplayer-screen tests by removing intermediate screen 2021-10-28 14:29:49 +09:00
Dean Herbert
aaabaaa5dd
Merge pull request #15320 from smoogipoo/fix-online-play-request-handling 
Fix online play request handling in tests
 2021-10-28 14:24:00 +09:00
smoogipoo
1213c5553a Remove forgotten attribute 2021-10-28 13:16:50 +09:00
Bartłomiej Dach
798349243f
Cache test request handler in screen navigation test 2021-10-27 20:38:52 +02:00
Bartłomiej Dach
cd04ca1240
Remove unused using statement 2021-10-27 20:35:19 +02:00
Dean Herbert
7245baba69 Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases 2021-10-28 00:50:45 +09:00
smoogipoo
72bb72a559 Fix a case of missed base.SetUpSteps() 2021-10-27 20:56:11 +09:00
smoogipoo
a87d8d0359 Fix dependency missing in a few TestScenes 
Hopefully these are rather temporary cases until a better solution is
found for these dependency-loading screens.
 2021-10-27 20:47:40 +09:00
smoogipoo
48f280440c Fix incorrect clearing of room 2021-10-27 19:36:43 +09:00
smoogipoo
f3dba49aae Rename room managers 2021-10-27 19:36:32 +09:00
Dean Herbert
d19580cf60 Fix incorrectly changed difficulty count in recently updated test 2021-10-27 16:44:11 +09:00
smoogipoo
676070946c Fix missed base.SetUpSteps() 2021-10-27 15:25:26 +09:00
Dean Herbert
58237f6fee Fix weird import flows 2021-10-27 14:26:37 +09:00
Dean Herbert
84bb3a962b Centralise room "creation" 2021-10-27 14:11:57 +09:00
Dean Herbert
c4a253cc75 Replace local instantiation of TestBeatmap with helper method 2021-10-27 13:55:14 +09:00
Dean Herbert
2bc2420012 Rename test scene 
It's not testing the sub-screen. It's testing creating playlists.
 2021-10-27 13:54:21 +09:00
Dean Herbert
95837990f3 Apply some second-pass inspections that appeared after previous changes 2021-10-27 13:09:30 +09:00
Dean Herbert
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
Bartłomiej Dach
3de994449d
Add support for changing dimensions of difficulty spectrum display 2021-10-26 23:06:52 +02:00
Bartłomiej Dach
1a77e98537
Implement difficulty spectrum display 2021-10-26 23:06:52 +02:00
Jason Won
c633e2e952 only propagate unmodified right click 2021-10-26 16:24:53 -04:00
Jason Won
4efa1f23bb fix context menu test 2021-10-26 15:29:50 -04:00
Jason Won
f64fa65fd5 right click on unselected object shows context menu 2021-10-26 14:52:15 -04:00
Dean Herbert
b259192a8a Add failing test coverage showing hitobject local control points are defaults 2021-10-26 16:06:03 +09:00
Dan Balasescu
f687ed8599
Merge pull request #15283 from peppy/test-api-beatmap-set 
Add ability to make test `APIBeatmapSet`s from test scenes
 2021-10-26 15:34:19 +09:00
Dan Balasescu
7b8982c87c
Merge pull request #15302 from peppy/fix-multiplayer-chat-escape-focus 
Fix gameplay chat display not losing focus on escape key press
 2021-10-26 15:34:05 +09:00
Dan Balasescu
efe6763226
Merge branch 'master' into move-online-beatmap-metrics 2021-10-26 14:24:40 +09:00
Dean Herbert
6c38028d06 Fix gameplay chat display not losing focus on escape key press 
Closes #15293.
 2021-10-26 13:55:08 +09:00
Dan Balasescu
1e3c84b34b
Merge branch 'master' into use-beatmap-interfaces-more-uncontested 2021-10-26 13:51:55 +09:00
Bartłomiej Dach
5a03e1736e
Merge branch 'master' into update-beatmap-set-status-pill-appearance 2021-10-25 20:26:49 +02:00
Bartłomiej Dach
6802e9ec10
Remove FixedWidth and add AutoSizeAxes specs to all usages 2021-10-25 20:24:48 +02:00
Dean Herbert
2c308f3008 Rename BeatmapMetrics to APIFailTimes 2021-10-25 15:34:41 +09:00
Dean Herbert
20baae9094 Move online metrics out of BeatmapInfo model 2021-10-25 15:32:18 +09:00
Dean Herbert
045dd94a6e Move online metrics out of BeatmapSetInfo model 2021-10-25 15:12:39 +09:00
Dean Herbert
94175bfb4a Update PreviewTrackManager to use IBeatmapSetInfo 2021-10-25 14:25:01 +09:00
Dean Herbert
19312435d0 Add ability to make test APIBeatmaps from test scenes 
Allow tests to create a sample `APIBeatmapSet`

One step towards removing calls to `ToBeatmap` / `ToBeatmapSet`.
 2021-10-25 14:18:13 +09:00
Bartłomiej Dach
feedd53a53
Add support for setting fixed size of status pill 2021-10-24 21:37:00 +02:00
Bartłomiej Dach
207ccc4756
Add test scene for beatmapset online status pill display 2021-10-24 20:35:26 +02:00
Bartłomiej Dach
00732822c3
Replace insufficiently specific exception type 
Resolves compilation failures for the newly-added Android build-only CI
job caused by inspection CA2201 ("Exception type System.Exception is not
sufficiently specific").
 2021-10-24 17:45:39 +02:00
Dan Balasescu
c6ca0e5895
Merge branch 'master' into fix-password-popover-focus 2021-10-22 22:52:46 +09:00
smoogipoo
d7a98097a1 Make DrawableRoomPlaylist handle expired items 2021-10-22 21:04:52 +09:00
Dean Herbert
32d01f022f Rename usages which rely on online backing 2021-10-21 16:58:42 +09:00
Dean Herbert
0706ad70fb Move BeatmapSetOnlineInfo to an interface type 2021-10-21 16:58:42 +09:00
Bartłomiej Dach
a7f3beabe3
Modify OsuTextBox test scene to test against colour provider 2021-10-20 22:49:23 +02:00
Dean Herbert
fd01a226db
Remove redundant parenthesis 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2021-10-20 18:11:33 +09:00
smoogipoo
116ce09e49 Merge branch 'master' into multi-queueing-modes 2021-10-20 17:27:25 +09:00
Andrei Zavatski
0f8d270442 Remove online part since it doesn't really check anything 2021-10-20 11:27:24 +03:00
Andrei Zavatski
faabc75a3e Fix failing test 2021-10-20 10:54:08 +03:00
Andrei Zavatski
6f38e6166d Fix and improve TestSceneUserProfilePreviousUsernames 2021-10-20 10:32:00 +03:00
Bartłomiej Dach
6c18d46443
Add test scene for demonstrating OsuDropdown appearance 2021-10-19 22:09:50 +02:00
Dean Herbert
7cf4395875 Merge branch 'master' into default-value-indicator 2021-10-19 16:23:02 +09:00
Dean Herbert
32cbf6e54b Add test coverage ensuring password popover keeps focus 2021-10-19 15:53:29 +09:00
Dean Herbert
8944b1dd78 Add basic test coverage of DrawableLoungeRoom 2021-10-19 15:36:27 +09:00
Dean Herbert
f7ec135b9b Fix TestSceneLoungeRoomsContainer crashing on selecting a room with a password 2021-10-19 15:36:27 +09:00
Bartłomiej Dach
95ed9a431c
Add test coverage for no submission for ruleset with null ID 2021-10-19 00:06:07 +02:00
Bartłomiej Dach
cc9727ec11
Merge branch 'master' into default-value-indicator 2021-10-18 22:07:58 +02:00
Bartłomiej Dach
88a1b31fae
Remove grid usage in SettingsItem 2021-10-18 22:07:32 +02:00
Dan Balasescu
8643c725cc
Merge pull request #15175 from peppy/fail-animation-flash-controlled-by-setting 
Don't flash screen red on fail if the user has disabled red tinting
 2021-10-18 15:27:10 +09:00
Dean Herbert
762949f49f Don't flash screen red on fail if the user has disabled red tinting 2021-10-18 14:20:38 +09:00
Dean Herbert
50bde0fe38 Refactor test to better keep existing toggle values 
I also changed the type of the button to `float` because it was mentally
hard to parse a default button that is tracking a `bool` state. Probably
not what we want for a test like this.
 2021-10-18 13:53:28 +09:00
Dean Herbert
0d992a0493 Add failing test showing epilepsy warning is not fading on early exit 2021-10-18 13:30:24 +09:00
Bartłomiej Dach
f422ebb281
Adjust SettingsItem to accommodate new default value indicator 2021-10-17 21:50:03 +02:00
Bartłomiej Dach
818f35c35f
Restyle default value indicator 2021-10-17 21:50:03 +02:00
5ln
3529f34c98
Multi: Hide mods when spectating or Beatmap isn't Locally Available. 
Signed-off-by: 5ln <xnafumie@gmail.com>
 2021-10-18 02:01:50 +08:00
Bartłomiej Dach
b34086a792
Add failing test case for incorrect RulesetID population in submission flow 2021-10-16 16:10:42 +02:00
Bartłomiej Dach
29ec498f6c
Add failing test case for player sending wrong ruleset ID to spectator server 2021-10-16 13:34:24 +02:00
smoogipoo
6cc8184041 Make test scene create room immediately 2021-10-15 20:17:43 +09:00
Dan Balasescu
3604a762d0
Merge branch 'master' into fix-editor-difficulty-name-update 2021-10-15 16:58:01 +09:00
Dean Herbert
c9d8645341 Fix startup import test waiting on potentially incorrect notification type 2021-10-15 13:26:31 +09:00
Dean Herbert
ec5c967e71 Add test coverage of SettingsCheckbox 2021-10-15 12:13:24 +09:00
Dean Herbert
b15137ecdc Add test coverage of slider bars with colour provider applied 2021-10-15 11:48:08 +09:00
Dean Herbert
874d722820
Merge branch 'master' into fix-editor-difficulty-name-update 2021-10-15 11:14:45 +09:00
Dean Herbert
02d29097a2 Switch away from metadata screen before making any changes in test logic 2021-10-15 11:14:03 +09:00
Dean Herbert
ad0732484f Just wait for metadata section to be loaded 2021-10-14 22:12:38 +09:00
Dan Balasescu
fb9c3fe72e
Merge pull request #14619 from peppy/no-more-difficulty-control-points-info 
Move `DifficultyControlPoint`s to be specified at a per-`HitObject` level
 2021-10-14 17:24:32 +09:00
smoogipoo
0fd5fa17c0 Add more thorough check 2021-10-14 16:50:38 +09:00
Dean Herbert
119e9ad83e Fix multiplayer gameplay flow test scene failures due to button not being ready 2021-10-14 15:58:42 +09:00
Dean Herbert
464bcd2b24
Merge pull request #15070 from bdach/dropdown-refresh 
Refresh dropdown appearance & add themed variant to settings sidebar
 2021-10-14 14:40:58 +09:00
Dean Herbert
2e0a2a28ab Check mutations at each point in the process (and also check artist/title) 2021-10-14 14:40:20 +09:00
Dean Herbert
3964e5c448 Fix test failure due to retyped class 2021-10-14 14:11:12 +09:00
Dean Herbert
b6c5797394 Fix AudioFilter test not stopping track on forced exit 2021-10-14 12:55:02 +09:00
Dean Herbert
8d479bbe56
Merge branch 'master' into fix-editor-difficulty-name-update 2021-10-14 10:17:01 +09:00
Dan Balasescu
e49f1f6e6b
Merge branch 'master' into no-more-difficulty-control-points-info 2021-10-13 20:17:57 +09:00
Dan Balasescu
d88daf0cc2
Merge pull request #15073 from peppy/fix-player-loader-low-pass 
Improve `PlayerLoader` audio and visual transitions
 2021-10-13 17:01:49 +09:00
Dean Herbert
29dfe33465 Rewrite AudioFilter to be easier to follow (and fix tests) 2021-10-13 15:17:20 +09:00
Dean Herbert
02689a1b60 Use actual BeatmapInfo rather than PlayableBeatmap.BeatmapInfo for editor writes 2021-10-13 14:50:12 +09:00
Dean Herbert
26a1e40d24 Fix storyboard outro during fail test not being lenient enough 2021-10-13 13:48:57 +09:00
Dean Herbert
b37096f440 Avoid using bindable for AudioFilter cutoff 
It doesn't play nicely with screen exiting, as it is automatically
unbound during the exit process. Easiest to just avoid using this for
now.
 2021-10-13 13:25:55 +09:00
Dean Herbert
f69a56a26a Add test coverage of startup import sequence 2021-10-13 12:19:10 +09:00
Bartłomiej Dach
3ceee176e6
Merge branch 'master' into frame-stability-container-direction-flip 2021-10-12 18:34:04 +02:00
Bartłomiej Dach
8dcfc3dd7e
Replace no-op seeks with wait steps 2021-10-12 18:31:20 +02:00
smoogipoo
91c286b1ad Fix intermittent TestScenePlaySongSelect test failures 2021-10-12 22:07:57 +09:00
Dan Balasescu
f76b58e843
Merge pull request #15055 from peppy/fix-taiko-convert-woes 
Fix `BeatmapConverter` not cloning deeply enough
 2021-10-12 21:07:39 +09:00
Dean Herbert
79ac64a088 Split out editor save steps to try and catch test failure 2021-10-12 19:40:35 +09:00
Bartłomiej Dach
55bd7d2512 Add failing coverage for saving difficulty params from editor 2021-10-12 16:43:56 +09:00
Dan Balasescu
696193198a
Merge pull request #15049 from bdach/settings-panel-rounded-buttons 
Update appearance of buttons in settings sidebar
 2021-10-12 09:32:52 +09:00
Bartłomiej Dach
ff382259ca
Use rounded buttons in tablet rotation preset settings 2021-10-11 23:17:09 +02:00
Bartłomiej Dach
b1ad3161dd
Add failing test case for frame stable clock direction flip scenario 2021-10-11 21:25:02 +02:00
Dean Herbert
a16ffd2976
Merge pull request #14999 from smoogipoo/fix-score-async 
Fix intermittent playlist results screen test failures
 2021-10-11 10:44:04 +09:00
Bartłomiej Dach
21ee24ea6d
Add rounded button variant 2021-10-10 21:45:41 +02:00
Bartłomiej Dach
237c063015
Fix typo in multipleIncrementMods variable name 2021-10-09 14:26:32 +02:00
smoogipoo
bc37cb6f43 Merge branch 'master' into no-more-difficulty-control-points-info 2021-10-08 18:41:17 +09:00
smoogipoo
f199d6c521 Fix another related test failure 2021-10-08 15:26:25 +09:00
smoogipoo
d6ac6a5cd6 Fix intermittent results screen test failures 2021-10-08 15:18:01 +09:00
Dean Herbert
42d3fe8f02 Merge branch 'master' into fix-SettingsTextBox-using-null-as-default 2021-10-08 13:37:28 +09:00
Dan Balasescu
f8e50731b7
Merge pull request #14991 from peppy/intro-tests-no-menu-load 
Allow intro screens to be created without loading a `MainMenu`
 2021-10-07 20:48:54 +09:00
Dean Herbert
ba84da6ef8 Tidy up test scene 2021-10-07 20:08:28 +09:00
Dean Herbert
b88d4f1913 Fix weird edge case in TestSceneIntroWelcome 2021-10-07 19:58:34 +09:00
Dean Herbert
ef64c64f0b
Merge branch 'master' into popup-filter-effect 2021-10-07 18:56:07 +09:00
Dean Herbert
e578046b20 Rename Filter -> AudioFilter 2021-10-07 18:50:08 +09:00
Dean Herbert
0348c6c7e5 Apply some renaming and code quality fixes 2021-10-07 18:49:22 +09:00
Dan Balasescu
bece807857
Merge pull request #14980 from peppy/difficulty-move-to-beatmap 
Copy `BaseDifficulty` to `Beatmap<T>` and move the majority of write operations across
 2021-10-07 18:43:44 +09:00
Dean Herbert
f98dd1b811
Merge branch 'master' into popup-filter-effect 2021-10-07 18:40:21 +09:00
Dean Herbert
189358240d Fix intro tests and move steps out of constructor 2021-10-07 18:39:48 +09:00
Dan Balasescu
7074021d1f
Merge branch 'master' into test-scene-osu-game-fix-async-disposal-contention 2021-10-07 17:47:11 +09:00
smoogipoo
e586fee091 Remove unused usings 2021-10-07 17:46:30 +09:00
Dan Balasescu
0e0779e45b
Merge pull request #14988 from peppy/remove-gameplay-mod-bindable-storage 
Remove local overridden storage of `Mods` in `Player`
 2021-10-07 17:36:23 +09:00
Dan Balasescu
d50443fdf2
Merge branch 'master' into difficulty-move-to-beatmap 2021-10-07 16:50:10 +09:00
Dean Herbert
7e0379441c Change TestSceneOsuGame to use OsuGameTestScene to avoid async disposal deadlock 
The original implementation was done so in a way that the nested `OsuGame` would be disposed via the async queue, causing a deadlock for 10-20s during test runs. `OsuGameTestScene` was already fixed to avoid this, so consuming it here seems like the easy fix.
 2021-10-07 16:18:48 +09:00
Dean Herbert
0bd5136a29 Fix TestOverlayClosing occasionally failing due to running too fast 2021-10-07 15:55:29 +09:00
Dean Herbert
697f53c445 Fix test failure due to reference of Player.Mods 2021-10-07 15:00:47 +09:00
Jamie Taylor
fc0c3e8758
Attach filters at load time 2021-10-06 17:32:28 +09:00
smoogipoo
456cfd62bf Fix intermittent score panel test failure 2021-10-06 16:46:27 +09:00
Dean Herbert
4ca97bc60a
Merge branch 'master' into difficulty-move-to-beatmap 2021-10-06 16:14:21 +09:00
Dean Herbert
b339c149d8 Copy BaseDifficulty to Beatmap<T> and move all write operations across 2021-10-06 15:10:45 +09:00
Dean Herbert
6e797ddcac Add test coverage of creating, saving and loading a new beatmap 2021-10-06 12:55:04 +09:00
Dan Balasescu
9491e5a547
Merge pull request #14954 from peppy/rename-result-response 
Rename `APIRequest.Result` to `Response`
 2021-10-06 10:52:33 +09:00
Dan Balasescu
007e5f174c
Merge pull request #14959 from peppy/add-screen-test-debug 
Add various logging output in an atttempt to figure multiplayer test failure
 2021-10-06 10:11:50 +09:00
Dan Balasescu
4e13af6524
Merge pull request #14957 from peppy/fix-song-select-test-failure 
Fix `TestDifficultyIconSelectingForDifferentRuleset` potentially failing due to async load
 2021-10-06 10:10:57 +09:00
Dan Balasescu
23f9b7a740
Merge pull request #14958 from peppy/fix-delete-local-score-test-failure 
Fix delete local score test not waiting for "fetch" to complete
 2021-10-06 10:09:26 +09:00
Dean Herbert
d6f25e07cc Add assert coverage of non-downloadable states 2021-10-06 05:49:18 +09:00
Dean Herbert
31c0c7a888 Remove pointless (and incorrect) click step 2021-10-06 05:49:04 +09:00
Dean Herbert
1a784b788d
Fix incorrect load state check 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2021-10-06 05:31:07 +09:00
Dean Herbert
777763a550 Add more comprehensive (and failing) test coverage of replay download button 2021-10-06 05:29:00 +09:00
Bartłomiej Dach
12da27cde7
Add test coverage for loading process on channel join 2021-10-05 20:52:40 +02:00
Dean Herbert
6f7b8293af
Merge pull request #14919 from smoogipoo/realtime-pp-display 
Implement real-time PP counter
 2021-10-05 20:50:03 +09:00
Dean Herbert
98fef6ece2 Handle judgement reverts with actual display updates 2021-10-05 19:08:30 +09:00
Dean Herbert
e6efdae7c9 Add various logging output in an atttempt to figure multiplayer test failure 2021-10-05 18:53:20 +09:00
Dean Herbert
5d708b612d Fix delete local score test not waiting for "fetch" to complete 
Even though this is a completely local operation in this case, there's
still a level of asynchronous operation which was recent introduced with
the score ordering:

853cf6feaa/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs (L159)

This means there is a brief period where the `Scores` property is null,
after `Reset()` is called in the re-fetch procedure.
 2021-10-05 18:17:22 +09:00
Dean Herbert
94153e8bba Fix TestDifficultyIconSelectingForDifferentRuleset potentially failing due to async load 2021-10-05 18:06:24 +09:00
Dean Herbert
0859c336de Also dim counter during initial calculation phase 2021-10-05 17:24:36 +09:00
Dean Herbert
04538a69e4 Add assert tests 2021-10-05 17:10:24 +09:00
Dean Herbert
eeb5f3d519 Add basic test scene 2021-10-05 16:51:43 +09:00
Dean Herbert
b41fa41c85 Rename APIRequest.Result to Response 2021-10-05 14:28:56 +09:00
smoogipoo
86df4919f7 Fix skin fallbacks test 2021-10-05 11:06:26 +09:00
Dean Herbert
57c5be39d3 Merge branch 'master' into remove-local-realm-thread-switch-handling 2021-10-04 20:52:44 +09:00
smoogipoo
031c5a441e Merge branch 'master' into realtime-pp-display 2021-10-04 20:19:37 +09:00
Dan Balasescu
4bd1083388
Merge pull request #14903 from peppy/importer-returns-live 
Add `ILive<T>` and use as return type of `Import` methods
 2021-10-04 20:16:32 +09:00
smoogipoo
4871db2f86 Merge branch 'master' into importer-returns-live 2021-10-04 19:42:36 +09:00
Dean Herbert
853cf6feaa Rename last remaining BeatmapInfo Beatmap usage 2021-10-04 17:35:53 +09:00
Dan Balasescu
5937a93e2d
Merge pull request #14949 from peppy/login-error-display 
Show login failure messages on login form
 2021-10-04 17:23:11 +09:00
Dean Herbert
ae5d1e8ac0 Merge branch 'master' into remove-local-realm-thread-switch-handling 2021-10-04 17:17:10 +09:00
Dean Herbert
916342c837 Merge branch 'master' into importer-returns-live 2021-10-04 16:24:26 +09:00
smoogipoo
69c2b7dc59 Merge branch 'master' into rename-beatmap-info-beatmap-fields 2021-10-04 16:03:22 +09:00
Dan Balasescu
aa1bfc16d2
Merge pull request #14929 from peppy/gameplay-state 
Replace `GameplayBeatmap` with `GameplayState`
 2021-10-04 15:56:44 +09:00
Dean Herbert
266b4c7124 Expose login errors from IAPIProvider and show on the login form 2021-10-04 15:40:24 +09:00
Dean Herbert
c8419ebedb
Merge pull request #14946 from bdach/torus-alternate 
Add alternate Torus font
 2021-10-04 11:47:11 +09:00
Bartłomiej Dach
67d08a3eee
Add test scene for previewing Torus alternates 2021-10-04 00:26:41 +02:00
Bartłomiej Dach
f05cb6bb5b
Add test case covering reset section button hiding 2021-10-03 13:53:26 +02:00
Dean Herbert
ec61c3c5ee Rename all remaining cases 2021-10-03 00:55:29 +09:00
Dean Herbert
973c31132b Rename BeatmapInfo variables which were named beatmap for clarity 2021-10-02 12:45:34 +09:00
Susko3
6d6fda8337 Fix some usages of SettingsTextBox using a bindable with null as default 2021-10-01 19:55:22 +02:00
Dean Herbert
32afd3f426 Replace all basic usages 2021-10-02 02:22:23 +09:00
Jamie Taylor
2a4a376b87
Refactor Filter to behave closer to a Transformable 2021-10-02 01:32:47 +09:00
smoogipoo
4e3d9da22d Increase test lenience 2021-10-01 22:58:40 +09:00
Dean Herbert
ca7346e01f Add test coverage 2021-10-01 00:34:09 +09:00
Dean Herbert
a2e61883e3 Initial push to use ILive in import process 2021-09-30 22:55:25 +09:00
Jamie Taylor
1304b55c41
Move visual test to correct namespace 2021-09-30 15:19:15 +09:00
smoogipoo
18ab6747f7 Fix tests 2021-09-30 12:01:28 +09:00
smoogipoo
67d847fbd3 Add room status text to DrawableRoom 2021-09-29 20:24:49 +09:00
smoogipoo
d89577b2e7 Add host to DrawableRoomParticipantsList 2021-09-29 19:34:40 +09:00
smoogipoo
73ee82ee2b Rename RecentParticipantsList -> DrawableRoomParticipantsList 2021-09-29 19:15:58 +09:00
Dan Balasescu
625711e6d2
Merge pull request #14776 from peppy/fix-pause-with-audio-offset 
Avoid accounting for the pause pitch adjust effect when "fixing" hardware offset adjustments
 2021-09-28 18:44:22 +09:00
Dean Herbert
46bafb6252 Merge branch 'master' into no-more-difficulty-control-points-info 2021-09-28 13:53:56 +09:00
Bartłomiej Dach
1a1fc00b44
Add failing test case 2021-09-27 20:54:29 +02:00
Dean Herbert
41fb3371e5
Merge branch 'master' into blueprint-container-sorting 2021-09-27 14:12:09 +09:00
Bartłomiej Dach
81d160c85a
Add test covering expected UX of range selection 2021-09-26 19:27:47 +02:00
Bartłomiej Dach
0de7db5840
Add test coverage for timeline selection logic 2021-09-26 19:20:55 +02:00
Bartłomiej Dach
7caa0a81ec
Rename TestScene{Editor -> Composer}Selection 
In line with an upcoming split in functionality between the composer
blueprint container and the timeline blueprint container.
 2021-09-26 17:22:58 +02:00
Bartłomiej Dach
ce70d1082d
Add failing test for "ghost timeline blueprint" 2021-09-26 15:29:00 +02:00
Bartłomiej Dach
0057400bb7
Rename test scene to reflect its new purpose 2021-09-26 15:09:30 +02:00
Bartłomiej Dach
4aadff3fd7
Add failing test for incorrect composer selection 2021-09-26 15:08:43 +02:00
Dean Herbert
dcadf3b81d Add failing test coverage of some dialogs being held on to 2021-09-23 19:18:51 +09:00
Dean Herbert
60c9e9f704
Merge pull request #14805 from bdach/rectangular-snap-grid 
Add rectangular snap grid to osu! editor composer
 2021-09-22 00:12:03 +09:00
Bartłomiej Dach
761548e533
Merge branch 'master' into 14470-ur-not-updating 2021-09-20 22:07:33 +02:00
Bartłomiej Dach
4e094b2127
Implement grid size toggling matching stable 2021-09-19 20:26:02 +02:00
sh0ckR6
93ca615c02
Add tests for clearing HitErrorMeter 
Works with both `BarHitErrorMeter` and `ColourHitErrorMeter`
 2021-09-19 14:15:22 -04:00
Bartłomiej Dach
56e80a0706
Add rectangular position snap grid 2021-09-19 18:07:19 +02:00
Opelkuh
366dbf5c3d Add test for time jumps 2021-09-19 15:35:03 +02:00
Opelkuh
761da45f6a Revert af4c3727d77a16e2534df9bbf452336b5c544342 2021-09-19 14:00:56 +02:00
Opelkuh
1d7d779f66 Merge branch 'master' into add-legacy-star-particles 2021-09-19 04:34:35 +02:00
Opelkuh
3f8454cb76 Remove abstract from ParticleSpewer 2021-09-19 03:19:16 +02:00
Opelkuh
ef530ed87c Normalize particle velocity based on max duration 2021-09-18 23:45:58 +02:00
Opelkuh
846cde53b3 Add RelativePositionAxes support 2021-09-18 22:54:12 +02:00
Dan Balasescu
90f1592d15
Merge pull request #14783 from peppy/login-feedback 
Move login panel related files to own namespace and tidy up class nesting
 2021-09-17 19:02:23 +09:00
Dean Herbert
e49d8d0878 Add test coverage of login dialog 2021-09-17 18:36:09 +09:00
Dean Herbert
a1f587f2c5 Add failing test coverage of password entry textbox not regaining focus 2021-09-17 18:25:25 +09:00
Dean Herbert
45caeb84d3 Fix incorrect type specification when restoring bindable value 2021-09-17 16:28:47 +09:00
Dean Herbert
2c071a4d22 Add test coverage of pausing with a large audio offset 2021-09-17 15:43:38 +09:00
Dean Herbert
fde7c88999
Merge branch 'master' into update-framework 2021-09-16 22:49:02 +09:00
Dean Herbert
b399f910e4 Merge branch 'fix-osu-game-test-scene' into update-framework 2021-09-16 22:46:52 +09:00
Dean Herbert
df786afb24
Merge pull request #14763 from kj415j45/localisation-settings-GlobalAction 
Add localisation for Settings-KeyBindings-GlobalActions
 2021-09-16 21:08:00 +09:00
smoogipoo
f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
kj415j45
18e7d86dd4
Resolve test failure after localizing 2021-09-16 17:08:19 +08:00
Dean Herbert
2df4073946 SpawnParticle -> CreateParticle (and set time outside of virtual call) 
Allows easier overriding (no need to call the `base.CreateParticle` call
and worry about overwriting the time value.
 2021-09-16 16:52:46 +09:00
Dean Herbert
da0667365b
Merge branch 'master' into inheritable-allow-track-adjust 2021-09-16 16:35:11 +09:00
Dean Herbert
fa693bb8a8 Move MusicController adjustment set to inside OsuScreen itself (and result nullable) 2021-09-16 16:08:09 +09:00
Dan Balasescu
43379a2eaa
Merge pull request #14752 from peppy/realm-settings 
Move (ruleset) settings to realm
 2021-09-16 14:05:41 +09:00
AbstractQbit
9057be1a02 Remove unused usings 2021-09-16 01:30:53 +03:00
AbstractQbit
3cd3e133ce Move AllowTrackAdjustments test to TestSceneOsuScreenStack 2021-09-16 01:24:50 +03:00
AbstractQbit
30c458c662 Oops, fix not compiling test 2021-09-15 21:34:41 +03:00
Dean Herbert
931e873a7e
Merge branch 'master' into inheritable-allow-track-adjust 2021-09-15 22:26:13 +09:00
AbstractQbit
1181317c72 Fix issues found by code quality ci 2021-09-15 12:01:56 +03:00
AbstractQbit
9b101ea9eb Add a test for AllowTrackAdjustments 2021-09-15 11:40:23 +03:00
smoogipoo
cdb44d7239 Fix match footer test scene not working in visual testing 2021-09-15 17:16:11 +09:00
Dean Herbert
ac377a2e3c Remove unused SettingsStore 2021-09-15 16:31:13 +09:00
Dean Herbert
623377772c
Merge branch 'master' into fix-spectator-random-mod 2021-09-15 13:55:28 +09:00
Dean Herbert
a2dcef7c0a Use local (or barebones BeatmapInfo) where feasible 2021-09-15 13:40:05 +09:00
smoogipoo
4b3ab42ffd Ensure beatmap is populated 2021-09-15 13:18:46 +09:00
Dean Herbert
1ba716d9f1
Merge pull request #14737 from bdach/editor-difficulty-switch-shared-state 
Preserve current time and clipboard contents when switching between difficulties
 2021-09-15 12:38:56 +09:00
Bartłomiej Dach
7b9e501fa0
Merge branch 'master' into 14421-multi-password-error-handling 2021-09-14 22:58:20 +02:00
Dean Herbert
67750e6e1a Fix subsequent navigation tests failing due to escape key not being released 2021-09-14 15:08:43 +09:00
Dean Herbert
6851e0000d Add test coverage 2021-09-14 14:06:24 +09:00
Opelkuh
b009772206 Fix code inspect failure 2021-09-13 21:44:28 +02:00
Opelkuh
224244801f Remove Particles namespace 2021-09-13 21:44:27 +02:00
Opelkuh
7327603fc8 Fix outdated test step description 2021-09-13 21:44:26 +02:00
Opelkuh
cfcb46034c Remove ParticleJet 2021-09-13 21:44:23 +02:00
Opelkuh
328c9a5dd0 Change ParticleSpewer.Active to a Bindable 2021-09-13 21:44:18 +02:00
Opelkuh
1a60ce164e Add ParticleJet 2021-09-13 21:44:16 +02:00
Bartłomiej Dach
cbb9ff1c49
Only run prompt-for-save test logic when relevant 2021-09-13 21:04:28 +02:00
Bartłomiej Dach
79d0f4835e
Add failing tests for preserving clipboard content 2021-09-13 21:03:30 +02:00
Bartłomiej Dach
80e54d51f2
Add failing test for preserving editor clock time 2021-09-13 20:56:36 +02:00
Dean Herbert
e8d4e2e6da Fix tests being blocked by notification overlay popup 2021-09-13 19:38:53 +09:00
Dean Herbert
24ae530a80 Add test coverage of double dispose of OsuGame 2021-09-13 19:04:13 +09:00
Dean Herbert
aa71e3f3d4 Update nested game tests in line with framework changes 2021-09-13 19:04:13 +09:00
Dean Herbert
65fdceee79
Merge branch 'master' into editor-test-scenes-through-loader 2021-09-13 14:02:55 +09:00
Dan Balasescu
d9b4fae4e5
Merge branch 'master' into chat-command 2021-09-13 13:32:44 +09:00
Bartłomiej Dach
eae5d62fa5
Store editor beatmap locally before editor exit 2021-09-12 15:50:41 +02:00
Bartłomiej Dach
22fa9a303e
Expose test helper for switching between difficulties 2021-09-12 13:55:48 +02:00
Bartłomiej Dach
5ae2f41930
Make difficulty switching test scene use EditorTestScene 2021-09-12 13:26:05 +02:00
Bartłomiej Dach
3467b1f60c
Retouch chat command test slightly 2021-09-12 13:00:52 +02:00
Davran Dilshat
eeaa8a8380 code quality 2021-09-11 16:47:20 +01:00
Davran Dilshat
605933c467 typo 2021-09-11 16:23:17 +01:00
Davran Dilshat
7924a990a3 add tests for /chat command 2021-09-11 16:22:35 +01:00
Bartłomiej Dach
addba43e7d
Merge branch 'master' into fix-password-popover-back-button 2021-09-11 14:18:25 +02:00
Dean Herbert
5a06954665 Add test coverage of game exit scenario 2021-09-10 18:23:00 +09:00
Dan Balasescu
f4b1d8b9d1
Merge pull request #14704 from peppy/modicon-imod-support 
Update `LeaderboardModSelector` to avoid creating mod instances
 2021-09-10 16:43:32 +09:00
Dean Herbert
309460e505
Merge pull request #14675 from ekrctb/featured-artist-markers 
Add featured artist markers to beatmap listing and overlay
 2021-09-10 14:30:33 +09:00
Dan Balasescu
2d2c63dde7
Merge branch 'master' into modicon-imod-support 2021-09-10 13:30:05 +09:00
Dan Balasescu
78a83e0903
Merge pull request #14698 from peppy/fix-beatmap-overlay-hide 
Fix beatmap listing overlay not hiding via keyboard control when scrolled
 2021-09-10 13:18:37 +09:00
Dan Balasescu
80f49ec5fd
Merge branch 'master' into cached-all-mods 2021-09-10 12:47:22 +09:00
Dean Herbert
464797fecf Allow ModIcon to be constructed using an IMod 2021-09-10 12:43:12 +09:00
Dean Herbert
9cf79a80c2 Replace many more calls to CreateAllMods with more specific calls 2021-09-10 12:04:55 +09:00
Dean Herbert
cf633973a9 Refactor exposed mod retrieval methods for better safety 2021-09-10 11:09:13 +09:00
Bartłomiej Dach
32de13cb96
Use consistent assertions for checking placeholder presence 2021-09-09 21:33:02 +02:00
Dean Herbert
3865988e48 Add test coverage for back button support in password popover 2021-09-10 02:15:13 +09:00
Dean Herbert
2e00c71842 Add failing test coverage 2021-09-10 01:57:33 +09:00
ekrctb
a2c2646230 Use a counter instead of RNG 2021-09-09 19:36:47 +09:00
ekrctb
210640af09 Fix overlay not refreshed in TestSceneBeatmapSetOverlay 2021-09-09 12:39:40 +09:00
Dean Herbert
199f5235a3
Merge branch 'master' into fix-score-panel-list-keyboard-nav 2021-09-09 12:12:16 +09:00
Dean Herbert
6fc46792d3 Fix test regressions 2021-09-09 00:39:54 +09:00
Dean Herbert
7ed995fbc5 Add test with many rooms displayed 2021-09-08 20:52:14 +09:00
ekrctb
8745d299dc Add visual tests for featured artist markers 2021-09-08 13:27:57 +09:00
Bartłomiej Dach
2097889ce1
Add failing test case 2021-09-07 21:12:48 +02:00
Dean Herbert
c43ac8c946
Merge pull request #14660 from ekrctb/search-featured-artists 
Add "featured artists" filter to beatmap listing
 2021-09-07 20:58:13 +09:00
Dean Herbert
fa62c846c5
Merge pull request #14603 from smoogipoo/score-ordering 
Fix scores not being ordered correctly on leaderboards
 2021-09-07 19:18:37 +09:00
Dean Herbert
1aa95de530 Merge branch 'master' into score-ordering 2021-09-07 17:45:38 +09:00
Dean Herbert
d922210d2f Fix TestSceneDeleteLocalScore not properly comparing post-delete scores 2021-09-07 16:46:27 +09:00
ekrctb
b6c80f04b0 Add "featured artists" filter to beatmap search 2021-09-07 16:44:45 +09:00
Dean Herbert
f3d2d93aa1 Remove stray newline 2021-09-07 16:09:22 +09:00
smoogipoo
c9325cc419 Fix results screen test scene 2021-09-07 14:15:23 +09:00
Bartłomiej Dach
d13e00ed42
Merge branch 'master' into editor-new-change-diff 2021-09-06 21:42:32 +02:00
Bartłomiej Dach
73f742509a
Merge branch 'master' into tablet-area-validity-fix 2021-09-06 21:15:17 +02:00
Dean Herbert
766d789845 Rename ApproachRate to ScrollSpeed for now (to reduce complexity/confusion) 2021-09-06 21:06:13 +09:00
Dean Herbert
0500cd578a Merge branch 'master' into no-more-difficulty-control-points-info 2021-09-06 21:06:12 +09:00
smoogipoo
20100b8894 Fix a few test failures 2021-09-06 20:20:52 +09:00
Dean Herbert
6f482c3602 Add test coverage of sharper aspect ratio 2021-09-06 14:14:42 +09:00
Dean Herbert
458cde832d Avoid using SSDQ for validity computation 2021-09-06 14:11:13 +09:00
Bartłomiej Dach
7012a1d934
Fix issues with main menu -> editor loader transition 2021-09-05 21:48:11 +02:00
Bartłomiej Dach
74a129dc27
Test switching difficulties after discarding changes 2021-09-05 21:48:11 +02:00
Bartłomiej Dach
382269b362
Test staying on same difficulty due to unsaved changes 2021-09-05 21:48:10 +02:00
Bartłomiej Dach
c72523bc14
Add basic test for difficulty switching 2021-09-05 21:48:10 +02:00
Dean Herbert
7c60c6a733
Merge pull request #14571 from rednir/get-user-from-username 
Add ability to open user profile links with username instead of user ID
 2021-09-06 00:15:09 +09:00
Davran Dilshat
7f9b80e3e5 add tests for ShowUser() username overload 2021-09-05 15:11:41 +01:00
Dean Herbert
6e4efdd1b1 Add test coverage for per-ruleset setup screens 2021-09-05 13:40:58 +09:00
Dean Herbert
f76f12d361
Fix incorrect test step name 
Co-authored-by: PercyDan <50285552+PercyDan54@users.noreply.github.com>
 2021-09-05 11:14:28 +09:00
Dean Herbert
94b34a5474 Add test coverage of invalid cases too 2021-09-05 00:46:22 +09:00
Dean Herbert
7b26e480e6 Add extended tests 2021-09-04 22:55:14 +09:00
Dean Herbert
8d44f059ec Add test coverage of failing validity checks 2021-09-04 15:35:54 +09:00
Dean Herbert
d587dc6203 Populate new approach rate where required 2021-09-03 17:11:12 +09:00
Dean Herbert
d4e5a612ea Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time 
This allows fetching the correct `DifficultyControlPoint` from the
hitobject. Nothing more.
 2021-09-03 17:11:12 +09:00
Dean Herbert
a3d9ab1e2e Move approach rate to EffectControlPoint 2021-09-03 16:58:16 +09:00
Dean Herbert
7688ea7057 Merge branch 'master' into score-ordering 2021-09-02 19:19:52 +09:00
Dan Balasescu
6c649b7bbe
Merge branch 'master' into no-more-sample-control-points-info 2021-09-02 18:09:05 +09:00
Dean Herbert
f223be0760
Merge branch 'master' into score-ordering 2021-09-02 14:45:59 +09:00
smoogipoo
df7480e68c Fix bindable implementation being synchronous 2021-09-01 20:56:23 +09:00
smoogipoo
f7c1177cc9 Fix ScorePanelList nullref when scores are added too soon 2021-09-01 20:35:06 +09:00
Dean Herbert
ef64c05af8
Merge pull request #14533 from frenzibyte/move-incompatibility-icon 
Move mod incompatibility logic to "local player" mod select overlays
 2021-09-01 18:12:27 +09:00
Dean Herbert
9e21f5a59c Rename LocalPlayer to User in mod select prefixes 2021-09-01 17:22:52 +09:00
Dean Herbert
edf29e405b
Merge pull request #14581 from bdach/setup-screen-countdown-settings 
Add countdown settings to setup screen
 2021-09-01 15:35:46 +09:00
Dean Herbert
c70ac5e5c2
Merge branch 'master' into privatise-toolbar-offset 2021-09-01 14:54:15 +09:00
Bartłomiej Dach
1e4fa87648
Merge branch 'master' into setup-screen-countdown-settings 2021-08-31 22:43:18 +02:00
Bartłomiej Dach
5dc938cc9f
Update tests to match expectations 2021-08-31 22:41:47 +02:00
Bartłomiej Dach
b969398e2d
Merge branch 'master' into adjust-triangle-speed 2021-08-31 20:44:09 +02:00
Dean Herbert
ce0d7cce2d Merge branch 'remove-ijsonserializable' into no-more-sample-control-points-info 2021-08-31 14:40:54 +09:00
Dean Herbert
529a9a6ff8 Adjust minimum triangle movement speed to avoid "static" triangles in logo 
Closes #14584.
 2021-08-31 14:08:23 +09:00
Joseph Madamba
570d36fde7 Make toolbar handle mouse events instead 2021-08-30 20:53:43 -07:00
Bartłomiej Dach
ddf9d2aa6c
Add test coverage 2021-08-30 22:55:58 +02:00
Bartłomiej Dach
89429021c9
Add test scene for labelled dropdowns 2021-08-30 21:37:15 +02:00
Salman Ahmed
6154642075
Merge branch 'master' into local-popover-containers 2021-08-30 15:44:29 +03:00
Dean Herbert
015df282fe Simplify copy operations 2021-08-30 18:32:55 +09:00
Joseph Madamba
7bb2269eba Add overlay closing behavior test 2021-08-29 22:27:56 -07:00
Dean Herbert
4dd60e3299 Merge branch 'master' into taiko-drum-refacor 2021-08-30 14:12:52 +09:00
Dan Balasescu
7be825f470
Merge pull request #14488 from frenzibyte/multi-spectator-player-leaving 
Gray out and stop player instances who quit during multi-spectator sessions
 2021-08-30 12:04:19 +09:00
Bartłomiej Dach
2efe82a18d
Remove popover container from manual input manager test scene 2021-08-28 20:20:42 +02:00
Salman Ahmed
eb90cedc9b Fix editor screen test scenes not updated to show their screens 2021-08-28 20:09:35 +03:00
Salman Ahmed
1650fbb8be Add failing test steps 2021-08-27 13:24:37 +03:00
Salman Ahmed
b7a0316194 Shorten test player count to 4 for less steps 2021-08-27 13:14:56 +03:00
Dean Herbert
97f27897b1 Add test coverage of mass multiplayer event firing 2021-08-27 18:57:35 +09:00
Dean Herbert
33aa48bcf6 Merge branch 'master' into lobby-sounds 2021-08-27 18:46:12 +09:00
Dean Herbert
23414b0c63 Combine test scene to avoid huge copy paste 2021-08-27 18:44:44 +09:00
Dean Herbert
34d185d846 Convert final step to until step to avoid unnecessary delays 2021-08-27 18:39:36 +09:00
Dean Herbert
f078a9d2bf Fix incorrect step type 2021-08-26 17:17:39 +09:00
Dean Herbert
982c4eff14 Merge branch 'master' into taiko-drum-refacor 2021-08-26 17:13:14 +09:00
Jamie Taylor
e341f471b0
Add lobby sfx for join/leave/kick/ready/unready events 2021-08-26 15:29:22 +09:00
Dean Herbert
6dcd9427ac Remove bindable usage in PathControlPoint 
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.

I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
 2021-08-26 12:33:53 +09:00
Salman Ahmed
5acaafa708 Make end accept one user ID rather than unnecessarily an array 2021-08-25 18:28:25 +03:00
Salman Ahmed
998abcbf31 Replace occurences of Enumerable.Range(PLAYER_1_ID, ...) with a method 2021-08-25 18:25:31 +03:00
Salman Ahmed
c32168c61f Add failing test case 2021-08-25 17:03:34 +03:00
Dean Herbert
7e6e2a7e29 Remove unused assignment 2021-08-25 17:39:06 +09:00
Salman Ahmed
13acdb5f19 Add test coverage 2021-08-25 11:31:02 +03:00
Dean Herbert
fc85ae0e34 Add test coverage 2021-08-25 16:56:44 +09:00
Bartłomiej Dach
e503182a8d
Merge branch 'master' into activity-on-multiplayer-screens 2021-08-24 18:50:55 +02:00
Dean Herbert
568a8ee97e
Merge branch 'master' into fix-hud-test-failure-2 2021-08-24 16:54:48 +09:00
Dean Herbert
08f757a584
Merge pull request #14474 from smoogipoo/fix-multi-crash 
Fix crash when entering multiplayer gameplay
 2021-08-24 16:20:18 +09:00
smoogipoo
342f2d756d Fix test not working intermittently 2021-08-24 15:18:05 +09:00
Dean Herbert
4bbc98737f Fix english in test steps 2021-08-24 14:39:03 +09:00
Dean Herbert
8cd972a9fe Merge branch 'master' into pinned-comment 2021-08-24 14:37:31 +09:00
smoogipoo
b719887810 Fix test compile errors 2021-08-24 13:34:23 +09:00
smoogipoo
df170afbc4 Fix multiplayer crashing when entering gameplay 2021-08-24 13:22:06 +09:00
smoogipoo
c2974cfc65 Add full multiplayer gameplay flow test 2021-08-24 13:20:01 +09:00
smoogipoo
956c1cc216 Merge branch 'master' into activity-on-multiplayer-screens 2021-08-24 12:33:34 +09:00
Dean Herbert
3c9718339c
Merge pull request #14444 from frenzibyte/decouple-ruleset-bindables 
Decouple rankings overlay's ruleset selector from the game-wide ruleset bindable
 2021-08-24 11:58:13 +09:00
Salman Ahmed
9d807656f2 Add more complete test coverage of decoupling 2021-08-23 21:08:59 +03:00
Salman Ahmed
e33c3fcdbf Add test coverage for new changes 2021-08-23 13:53:03 +03:00
Salman Ahmed
6931721864 Revert test coverage 2021-08-23 12:39:27 +03:00
Salman Ahmed
79aea1fb78 Fix test overlay ruleset selectors not surrounded with overlay colour providers 2021-08-23 11:44:52 +03:00
Dean Herbert
eaa4d479ac
Merge pull request #14408 from smoogipoo/remove-current-room 
Remove the global "selected room" from online screens
 2021-08-23 17:29:31 +09:00
Salman Ahmed
391c4e529c Add test coverage for all added features 2021-08-23 11:12:48 +03:00
smoogipoo
4f3a5fbad5 Fix test failure 2021-08-23 14:29:15 +09:00
Bartłomiej Dach
e4a8f72167
Add failing test case 2021-08-22 19:16:43 +02:00
Salman Ahmed
318f830cd2 Expand test coverage for different scaling modes 
Intentionally not using `[Values]` as the scale modes can be applied to
the running game instance directly, rather than recreating it all over
again.

The same could be said for the notification overlay but not sure, seems
like something that should be considered at an `OsuGameTestScene` level
instead (whether the same game instance can be reused for further
testing).
 2021-08-21 04:19:55 +03:00
Dean Herbert
e13b516f31 Fix excess blank lines 2021-08-20 22:26:38 +09:00
smoogipoo
ceb07826d7 Merge branch 'master' into remove-current-room 2021-08-20 21:10:41 +09:00
Dan Balasescu
0aea39f5f1
Merge branch 'master' into temporary-directory-test-storage 2021-08-20 20:41:54 +09:00
Dean Herbert
b9ff94485d Revert usage of OsuGameTestScene for TestSceneOsuGame 
Turns out we likely don't want this, as it means the testing user (using
a visual test browser) will not have access to their beatmaps. Can
revisit at a future date if the temporary files are still an issue.
 2021-08-20 19:45:54 +09:00
Endrik Tombak
cbee379f62 Test scrolled to section top is visible 2021-08-20 12:30:49 +03:00
smoogipoo
610a162271 Merge branch 'master' into remove-current-room 2021-08-20 16:23:36 +09:00
Dean Herbert
98357d51da
Merge pull request #14323 from minetoblend/editor-seek 
Prevent seeking before mp3 start time while editor is playing
 2021-08-20 13:28:20 +09:00
Dan Balasescu
c95bf735fe
Merge branch 'master' into multiplayer-chat 2021-08-20 11:54:42 +09:00
Dean Herbert
7021133029 Merge branch 'master' into temporary-directory-test-storage 2021-08-20 11:54:33 +09:00
Dan Balasescu
580136a5e9
Merge branch 'master' into fix-lounge-loading 2021-08-20 10:51:30 +09:00
Bartłomiej Dach
5f1948d040
Add failing test case 2021-08-19 22:40:35 +02:00
Dean Herbert
e25592f325
Merge branch 'master' into fix-lounge-loading 2021-08-19 20:01:47 +09:00
Dean Herbert
2b0f2a6db9
Merge pull request #14355 from frenzibyte/mod-settings-difficulty-cache 
Update star difficulty bindables on mod settings change
 2021-08-19 20:00:48 +09:00
Dean Herbert
b09105e5a7
Merge pull request #14381 from smoogipoo/match-subscreen-redesign 
Update layout of multiplayer room screens
 2021-08-19 19:36:21 +09:00
smoogipoo
00be7f4cca Make RoomsContainer/DrawableRoom not resolve via DI 2021-08-19 16:52:54 +09:00
smoogipoo
c31af96f1d Pass room into RoomSettingsOverlay 2021-08-19 16:41:21 +09:00
smoogipoo
1fd746524d Remove realtime room category, fix end-date showing for realtime 2021-08-19 16:09:28 +09:00
Dean Herbert
6d00ea3375 Allow toggling focus via binding 2021-08-19 14:19:59 +09:00
Dean Herbert
786beb9759 Fix missing initial state test step 2021-08-19 14:14:47 +09:00
Salman Ahmed
65c0ae757b Merge spectrum test case 2021-08-19 07:18:18 +03:00
Salman Ahmed
102320f8ae Merge branch 'master' into mod-settings-difficulty-cache 2021-08-19 06:35:13 +03:00
Salman Ahmed
47ef33e731 Fix playlists lounge sub screen test potentially failing 2021-08-19 06:28:31 +03:00
Salman Ahmed
b984780d6a Merge branch 'master' into fix-lounge-loading 2021-08-19 06:26:15 +03:00
Salman Ahmed
49bc3a8250 Refactor playlists room manager to handle dummy API requests 2021-08-19 06:25:47 +03:00
Bartłomiej Dach
2e43f38d8a
Merge branch 'master' into settings-delayed-load 2021-08-18 22:53:34 +02:00
smoogipoo
eadf02933a Split lounge-specific implementation from DrawableRoom 2021-08-18 20:56:44 +09:00
smoogipoo
63af67f61b Cleanup around footers 2021-08-18 20:25:48 +09:00
Dean Herbert
fc3fa4f241 Merge branch 'master' into settings-delayed-load 2021-08-18 18:51:25 +09:00
Dean Herbert
28e2b6cec7 Add transform test for fun 2021-08-18 18:34:09 +09:00
Dean Herbert
1faf789f0e Allow expanding chat using key binding even when it is hidden 2021-08-18 18:25:21 +09:00
Dean Herbert
2099298444 Disallow clicking on chat textbox during gameplay 2021-08-18 17:30:50 +09:00
Dean Herbert
9d2664cbb1 Merge branch 'master' into star-rating-display-v2 2021-08-18 17:22:33 +09:00
Salman Ahmed
74d6c26520 Refactor star rating display layout with flexibility in mind 2021-08-18 11:03:35 +03:00
smoogipoo
5faf2df9b4 Revert unintentional change 2021-08-18 16:56:42 +09:00
smoogipoo
6dc96fdb83 Disable edit button in playlists 2021-08-18 16:56:42 +09:00
Dean Herbert
4725b802b0 Share OsuGameTestScene with implementations across template projects 2021-08-18 16:53:32 +09:00
Dean Herbert
2758a83d55 Fix TestSettingsMigration's usage of RecycleLocalStorage 2021-08-18 16:39:10 +09:00
smoogipoo
f3bc9c3e45 Merge branch 'master' into match-subscreen-redesign 2021-08-18 15:19:29 +09:00
Salman Ahmed
6ed3e469f7 Fix wrong attribute used for setup method 2021-08-18 06:50:01 +03:00
Salman Ahmed
f592350856 Fix config pollution in HUD overlay test scene 2021-08-18 04:59:08 +03:00
Marvin Schürz
2296ee6059 Add test coverage 2021-08-17 16:56:06 +02:00
Dan Balasescu
eaf7bd72fc
Merge branch 'master' into multiplayer-chat 2021-08-17 20:08:01 +09:00
Dean Herbert
1b49e92e99 Merge branch 'master' into settings-delayed-load 2021-08-17 17:42:23 +09:00
smoogipoo
5d72c5911a Rename MatchSettingsOverlay and related classes 
Because "match" is a multiplayer-only concept.
 2021-08-17 17:14:28 +09:00
smoogipoo
4b198d14eb Initial refactor of RoomSubScreen 2021-08-17 17:05:20 +09:00
Dean Herbert
72dd18732d Fix regressed tests 2021-08-17 16:37:18 +09:00
Dean Herbert
a901fca54a
Merge branch 'master' into multi-polling-request-refactor 2021-08-17 16:23:46 +09:00
Dean Herbert
6a2d82c81a Add test coverage 2021-08-17 16:17:31 +09:00
Dean Herbert
0d283aa6a3 Expose LocalUserPlaying from Player 2021-08-17 16:16:49 +09:00
Dean Herbert
e3b29df299 Add test scene for MultiplayerPlayer 2021-08-17 16:16:49 +09:00
smoogipoo
f4b7ee5c7f Merge branch 'master' into hide-player-settings-overlay 2021-08-17 13:44:33 +09:00
Salman Ahmed
eb6c6830bc Add visual test slider for changing star difficulty in beatmap wedge 2021-08-17 05:46:14 +03:00
smoogipoo
5214731dc1 Refactor test a bit 2021-08-17 09:45:10 +09:00
smoogipoo
b672d4b936 Refactor RequestHandlingMultiplayerRoomManager to avoid confusion 2021-08-17 09:43:37 +09:00
smoogipoo
352949069a Move filter to LoungeSubScreen 2021-08-17 09:36:43 +09:00
smoogipoo
6320768a67 Merge branch 'master' into multi-polling-request-refactor 2021-08-17 08:44:56 +09:00
Dean Herbert
677f5aff9e Fix test failures 2021-08-16 23:30:50 +09:00
Dean Herbert
4b975ca10d Add better test coverage of SettingsPanel 2021-08-16 18:55:50 +09:00
Salman Ahmed
6653a78e65 Add test coverage 2021-08-16 12:48:49 +03:00
Dean Herbert
8555a465ac
Merge pull request #14318 from bdach/editor-colours-save 
Add support for saving edited combo colours and displaying them in composer
 2021-08-16 17:07:53 +09:00
Salman Ahmed
67bac207cf Cover kicking a multiplayer room user with null User 2021-08-16 09:37:31 +03:00
Salman Ahmed
f82ed64aa7 Fix participant panel null user test no longer functioning properly 
I guess the changes that involved `MultiplayerTestScene` having a test
user lookup cache caused this test case to false-pass silently.

Added an explicit assert which ensures the added user indeed has a null
`User` value.
 2021-08-16 09:07:00 +03:00
Salman Ahmed
53c3eccfb5 Force HUD visibility mode to "Always" during testing 2021-08-16 07:21:37 +03:00
smoogipoo
08d347f10b Merge branch 'master' into multi-polling-request-refactor 2021-08-16 13:12:08 +09:00
Salman Ahmed
9d99741663 Add failing test case 2021-08-16 06:56:59 +03:00
smoogipoo
3db0b69f92 Throw not implemented exceptions 2021-08-16 12:44:12 +09:00
Nathan Alo
cc3468b4ab apply suggestions 
- make `UserActivity.InGame` and derive that to `InSoloGame` and `InMultiplayerGame`
- rename `SoloGame` to `InSoloGame`
- rename `MultiplayerGame` to `InMultiplayerGame`
 2021-08-16 06:32:33 +08:00
Bartłomiej Dach
6108451449
Retrieve separated skin instance from working beatmap for editing 2021-08-15 21:18:09 +02:00
Bartłomiej Dach
3648e0ca26
Merge branch 'master' into auto-restart 2021-08-15 15:04:50 +02:00
Bartłomiej Dach
f9e2e80874
Add testing for auto-restart behaviour 2021-08-15 15:04:14 +02:00
Dean Herbert
a10ba17b64
Merge pull request #14250 from peppy/leaderboard-limit-player-count 
Add ability for gameplay leaderboard scroll when too many users are displayed
 2021-08-14 14:08:18 +09:00
Bartłomiej Dach
8f3fedade3
Merge branch 'master' into multiplayer-team-vs-results 2021-08-13 21:30:44 +02:00
Bartłomiej Dach
2e9ab78275
Split test scene into two to follow class split 2021-08-13 21:30:26 +02:00
Gagah Pangeran Rosfatiputra
4494ff55e3
fix pinned drawable comment test 2021-08-14 00:17:45 +07:00
Gagah Pangeran Rosfatiputra
48b84db7b9
add no comment and single comment test 2021-08-13 23:59:36 +07:00
Gagah Pangeran Rosfatiputra
1c32993fe5
initialize pinned comments in test offline comment 2021-08-13 23:03:42 +07:00
smoogipoo
1c0ffd4621 Merge branch 'master' into multi-polling-request-refactor 2021-08-13 22:24:01 +09:00
smoogipoo
d57508853e Merge branch 'master' into multi-polling-request-refactor 2021-08-13 22:04:31 +09:00
smoogipoo
44b3e3bfac Merge branch 'master' into fix-playlists-cross-ruleset-entry 2021-08-13 21:58:15 +09:00
Salman Ahmed
1fed9193f8 Revert reverted segment to fix failure 2021-08-13 15:24:10 +03:00
Salman Ahmed
c32ba9e38f Remove arbitrarily-set wait step with until step instead, keeping the comment 2021-08-13 15:06:11 +03:00
Gagah Pangeran Rosfatiputra
e3f91413cf
add pinned comment test case for comment container 2021-08-13 18:53:31 +07:00
Salman Ahmed
7cf6b551d3 Replace until step with wait step with explanatory comment 2021-08-13 13:01:17 +03:00
smoogipoo
fbadc4897e Remove test scene 2021-08-13 18:28:20 +09:00
Salman Ahmed
f5cea0cacd Fix failing test and rename to match new behaviour 2021-08-13 12:12:20 +03:00
smoogipoo
8910781bcd Move listing polling component to LoungeSubScreen 2021-08-13 17:39:09 +09:00
Dean Herbert
c1d67976e6 Rename const, add xmldoc and make protected 2021-08-13 16:29:36 +09:00
Dean Herbert
bb36d1614f
Merge branch 'master' into improve-screen-offsetting 2021-08-13 16:23:02 +09:00
Dean Herbert
df24f7a81e
Merge pull request #14256 from smoogipoo/multiplayer-header-redesign 
Update multiplayer header to the latest designs
 2021-08-13 16:16:25 +09:00
Dean Herbert
732dcd30c7 Merge branch 'master' into multiplayer-team-vs-results 2021-08-13 16:03:10 +09:00
Dean Herbert
bf024fbd21
Merge branch 'master' into fix-playlists-cross-ruleset-entry 2021-08-13 15:06:37 +09:00
Gagah Pangeran Rosfatiputra
ff860b90a9
add pinned test case for drawable comment 2021-08-13 12:57:30 +07:00
Dean Herbert
699a61500a
Merge pull request #14264 from smoogipoo/fix-multi-spectate-test-failure 
Fix multiplayer spectating test failures
 2021-08-13 14:53:11 +09:00
Dean Herbert
dfb68904d7
Merge pull request #14266 from smoogipoo/fix-multi-navigation-test-failure 
Fix multiplayer navigation test failure
 2021-08-13 14:52:51 +09:00
Dean Herbert
92d4c9224a Merge branch 'master' into fix-playlists-cross-ruleset-entry 2021-08-13 14:28:14 +09:00
smoogipoo
755b6460b6 Fix multiplayer navigation test failure 2021-08-13 14:05:44 +09:00
smoogipoo
8fc0edb283 Fix some multiplayer test failures 2021-08-13 13:54:52 +09:00
Salman Ahmed
fc22e806f4 Cover newly hidden/expired elements in existing test 2021-08-13 07:30:24 +03:00
smoogipoo
2850f6ce95 Privatise counter again 2021-08-13 13:24:05 +09:00
smoogipoo
ee034874bb Merge branch 'master' into remove-comments-page 2021-08-13 13:17:13 +09:00
Salman Ahmed
1892db7f37 Add test coverage 2021-08-13 06:38:28 +03:00
smoogipoo
7aa361d772 Remove now-incorrect test 2021-08-13 09:02:19 +09:00
Bartłomiej Dach
70005cb39d
Merge branch 'master' into multiplayer-team-vs-results 2021-08-12 20:39:48 +02:00
Bartłomiej Dach
53b4cdfb02
Handle ties in team vs. results screen 2021-08-12 20:38:24 +02:00
Bartłomiej Dach
d9190607e4
Add test coverage for both teams winning 2021-08-12 20:21:53 +02:00
Bartłomiej Dach
f06f13215b
Split off multiplayer team results screen to separate class 
The previous version tried to keep both normal multiplayer and team
multiplayer results as one screen, but didn't check that team-specific
components aren't null in `LoadComplete()`.

To decrease number of conditional, split off the team results screen to
a separate implementation, and choose one or the other at push time in
`MultiplayerPlayer`, depending on team count.
 2021-08-12 20:01:31 +02:00
Bartłomiej Dach
d08d22e3e9
Ensure tests wait for screen load 2021-08-12 19:57:05 +02:00
Dean Herbert
00ca066c39
Merge pull request #14202 from gagahpangeran/changelog-supporter 
Add supporter promo section in changelog overlay
 2021-08-13 00:33:57 +09:00
Dean Herbert
8249ce7988
Merge branch 'master' into multiplayer-header-redesign 2021-08-12 21:00:46 +09:00
smoogipoo
83703e4283 Add colour provider to online play dependencies 2021-08-12 20:08:14 +09:00
smoogipoo
047b37788b Merge online play filter control with the lounge subscreen 2021-08-12 19:48:15 +09:00
Dean Herbert
7b66616dc4 Simplify logic and test/fix edge case 2021-08-12 19:47:26 +09:00
Dean Herbert
8a67304b9f Fix recent participants hidden user logic not handling edge case correctly 
Hiding just one user never makes sense, so this will now always show up
to the required circle count until two users are required to be hidden.
This will make the listing more consistent with the width requirement
spec.
 2021-08-12 19:47:26 +09:00
Dean Herbert
512382987e Add colour provider for multiplayer usage 2021-08-12 19:47:26 +09:00
Dean Herbert
5f3ceaf0ad
Merge branch 'master' into lounge-redesign 2021-08-12 16:31:14 +09:00
Dean Herbert
e84224f64c Rename AddPlayer method now that there's no conflict 2021-08-12 16:20:37 +09:00
Dean Herbert
68dbbc17e8 Add support for automatic scrolling in gameplay leaderboard 2021-08-12 16:20:37 +09:00
smoogipoo
14fe2eea2a Add empty step to multiplayer TestEmpty() test 2021-08-12 16:20:08 +09:00
Dean Herbert
f4591b01d7 Add test step to show leaderboard in expanded state by default 2021-08-12 15:21:00 +09:00
Dean Herbert
b713ba1bd4 Add test coverage 2021-08-12 15:12:48 +09:00
Dean Herbert
524128441e Mark PollingComponent test as headless 2021-08-12 15:03:05 +09:00
Dan Balasescu
60e988aac3
Merge branch 'master' into multiplayer-kick-support 2021-08-12 11:46:56 +09:00
smoogipoo
9393c6351d Fix another potential test case failure 2021-08-12 11:08:52 +09:00
smoogipoo
531fba8f39 Fix potential test case failure 2021-08-12 11:05:31 +09:00
smoogipoo
5d0b92e28c Fix multi spectator test not showing teams 2021-08-12 10:38:20 +09:00
smoogipoo
c160e50f4f Merge branch 'master' into multiplayer-team-vs-leaderboard 2021-08-12 10:27:31 +09:00
smoogipoo
0f5bea235c Merge branch 'master' into lounge-redesign 2021-08-11 18:15:34 +09:00