h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-13 10:33:07 +08:00
Code Issues Releases Wiki Activity

Remove arbitrarily-set wait step with until step instead, keeping the comment

Browse Source
This commit is contained in:
Salman Ahmed 2021-08-13 15:06:11 +03:00
parent 7cf6b551d3
commit c32ba9e38f
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game.Tests/Visual/Multiplayer/TestSceneMultiSpectatorScreen.cs
View File

@ -95,10 +95,8 @@ namespace osu.Game.Tests.Visual.Multiplayer
AddUntilStep("wait for players to load", () => spectatorScreen.AllPlayersLoaded);
// components wrapped in skinnable target containers load asynchronously, potentially taking more than one frame to load.
// wait once to properly execute the assert.
AddWaitStep("wait for async load", 1);
AddAssert("all interactive elements removed", () => this.ChildrenOfType<Player>().All(p =>
// therefore use until step rather than direct assert to account for that.
AddUntilStep("all interactive elements removed", () => this.ChildrenOfType<Player>().All(p =>
!p.ChildrenOfType<PlayerSettingsOverlay>().Any() &&
!p.ChildrenOfType<HoldForMenuButton>().Any() &&
!p.ChildrenOfType<SongProgressBar>().Single().ShowHandle));