1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-12 02:27:25 +08:00
osu-lazer/osu.Game.Tests/Visual
Bartłomiej Dach 15feb17da8
Change difficulty cache storage type to nullable
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
2021-11-20 17:00:50 +01:00
..
Audio Fix AudioFilter test not stopping track on forced exit 2021-10-14 12:55:02 +09:00
Background Fix potential null reference in FadeAccessibleBackground test class 2021-11-19 14:03:07 +09:00
Beatmaps Update favourite statistic value on favourite button clicks 2021-11-08 11:53:54 +01:00
Collections Provide game-wide resources via IStorageResourceProvider 2021-05-31 18:57:47 +09:00
Colours Add visual test scene 2021-08-03 15:02:18 +03:00
Components Rewrite PreviewTrackManager to avoid constructing TrackBass locally 2021-11-09 17:38:12 +09:00
Editing Update all simple cases of switching to IWorkingBeatmap 2021-11-17 20:56:57 +09:00
Gameplay Update test scenes which should not handle key repeat 2021-11-18 13:13:36 +09:00
Menus Update all simple cases of switching to IWorkingBeatmap 2021-11-17 20:56:57 +09:00
Mods Add testing for auto-restart behaviour 2021-08-15 15:04:14 +02:00
Multiplayer Add tests and disable selection on invalid items 2021-11-16 17:23:52 +09:00
Navigation Update all simple cases of switching to IWorkingBeatmap 2021-11-17 20:56:57 +09:00
Online Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface 2021-11-12 17:52:44 +09:00
Playlists Add tests and disable selection on invalid items 2021-11-16 17:23:52 +09:00
Ranking Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
Settings Add visual test for SettingsNumberBox usage in settings source context 2021-10-28 15:42:06 +09:00
SongSelect Change difficulty cache storage type to nullable 2021-11-20 17:00:50 +01:00
UserInterface Update DifficultyCalculator to take an IWorkingBeatmap 2021-11-15 19:16:48 +09:00
TestMultiplayerScreenStack.cs Remove unused using statement 2021-10-28 15:14:29 +09:00
TestSceneOsuScreenStack.cs Move MusicController adjustment set to inside OsuScreen itself (and result nullable) 2021-09-16 16:08:09 +09:00