1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 06:57:39 +08:00
osu-lazer/osu.Game.Tests/Visual/SongSelect
Bartłomiej Dach 15feb17da8
Change difficulty cache storage type to nullable
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
2021-11-20 17:00:50 +01:00
..
TestSceneAdvancedStats.cs Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface 2021-11-11 17:19:46 +09:00
TestSceneBeatmapCarousel.cs Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface 2021-11-12 17:52:44 +09:00
TestSceneBeatmapDetails.cs Remove BeatmapSetInfo.OnlineInfo and all usages 2021-11-04 15:23:04 +09:00
TestSceneBeatmapInfoWedge.cs Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
TestSceneBeatmapLeaderboard.cs Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
TestSceneBeatmapMetadataDisplay.cs Change difficulty cache storage type to nullable 2021-11-20 17:00:50 +01:00
TestSceneBeatmapOptionsOverlay.cs Reorder buttons to match stable 2020-09-14 11:23:41 -07:00
TestSceneBeatmapRecommendations.cs Use new helper method 2021-11-15 19:19:53 +09:00
TestSceneFilterControl.cs Fix test failure due to retyped class 2021-10-14 14:11:12 +09:00
TestScenePlaySongSelect.cs Update some remaining test usage of database ID 2021-11-17 20:56:57 +09:00
TestSceneSongSelectFooter.cs Add test coverage for song select footer area 2021-04-07 18:29:31 +09:00
TestSceneUserTopScoreContainer.cs Rename User to APIUser and move to correct namespace 2021-11-04 18:21:31 +09:00