h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-18 00:00:40 +08:00
Code Issues Releases Wiki Activity

Adjust testing methodology to improve reliability of mosue wheel volume adjust tests

Browse Source 
There was previously a potential in headless runs for timing
discrepancies to cause the volume to never get adjusted.

As seen at https://github.com/peppy/osu/runs/4604610951?check_suite_focus=true.
This commit is contained in:
Dean Herbert
2021-12-23 13:25:23 +09:00
Unverified
parent e1b539fa9e
commit d31c9db08b
1 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Tests/Visual/Navigation/TestSceneMouseWheelVolumeAdjust.cs
+14 -8
View File
@@ -25,8 +25,11 @@ namespace osu.Game.Tests.Visual.Navigation
public void TestAdjustVolumeFromMainMenu()
{
// First scroll makes volume controls appear, second adjusts volume.
AddRepeatStep("Adjust volume using mouse wheel", () => InputManager.ScrollVerticalBy(5), 2);
AddUntilStep("Volume is above zero", () => Game.Audio.AggregateVolume.Value > 0);
AddUntilStep("Adjust volume using mouse wheel", () =>
{
InputManager.ScrollVerticalBy(5);
return Game.Audio.AggregateVolume.Value > 0;
});
}
[Test]
@@ -35,7 +38,11 @@ namespace osu.Game.Tests.Visual.Navigation
loadToPlayerNonBreakTime();
// First scroll makes volume controls appear, second adjusts volume.
AddRepeatStep("Adjust volume using mouse wheel", () => InputManager.ScrollVerticalBy(5), 2);
AddUntilStep("Adjust volume using mouse wheel", () =>
{
InputManager.ScrollVerticalBy(5);
return Game.Audio.AggregateVolume.Value > 0;
});
AddAssert("Volume is above zero", () => Game.Audio.Volume.Value > 0);
}
@@ -47,7 +54,7 @@ namespace osu.Game.Tests.Visual.Navigation
loadToPlayerNonBreakTime();
// First scroll makes volume controls appear, second adjusts volume.
AddRepeatStep("Adjust volume using mouse wheel", () => InputManager.ScrollVerticalBy(5), 2);
AddRepeatStep("Adjust volume using mouse wheel", () => InputManager.ScrollVerticalBy(5), 10);
AddAssert("Volume is still zero", () => Game.Audio.Volume.Value == 0);
}
@@ -59,14 +66,13 @@ namespace osu.Game.Tests.Visual.Navigation
loadToPlayerNonBreakTime();
// First scroll makes volume controls appear, second adjusts volume.
AddRepeatStep("Adjust volume using mouse wheel holding alt", () =>
AddUntilStep("Adjust volume using mouse wheel holding alt", () =>
{
InputManager.PressKey(Key.AltLeft);
InputManager.ScrollVerticalBy(5);
InputManager.ReleaseKey(Key.AltLeft);
}, 2);
AddAssert("Volume is above zero", () => Game.Audio.Volume.Value > 0);
return Game.Audio.AggregateVolume.Value > 0;
});
}
private void loadToPlayerNonBreakTime()