h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 10:18:22 +08:00
Code Issues Releases Wiki Activity

Fix HasReplay not being corrrectly implemented by APIScoreInfo

Browse Source
This commit is contained in:
Dean Herbert 2021-11-01 13:20:37 +09:00
parent b63a90966b
commit 269a8df0ec
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Tests/Visual/Gameplay/TestSceneReplayDownloadButton.cs
View File

@ -136,7 +136,7 @@ namespace osu.Game.Tests.Visual.Gameplay
{
OnlineID = 2553163309,
OnlineRulesetID = 0,
Replay = replayAvailable,
HasReplay = replayAvailable,
User = new User
{
Id = 39828,

6
osu.Game/Online/API/Requests/Responses/APIScoreInfo.cs
View File

@ -26,13 +26,11 @@ namespace osu.Game.Online.API.Requests.Responses
[JsonProperty(@"user")]
public User User { get; set; }
public bool HasReplay { get; set; }
[JsonProperty(@"id")]
public long OnlineID { get; set; }
[JsonProperty(@"replay")]
public bool Replay { get; set; }
public bool HasReplay { get; set; }
[JsonProperty(@"created_at")]
public DateTimeOffset Date { get; set; }
@ -97,7 +95,7 @@ namespace osu.Game.Online.API.Requests.Responses
Date = Date,
PP = PP,
RulesetID = OnlineRulesetID,
Hash = Replay ? "online" : string.Empty, // todo: temporary?
Hash = HasReplay ? "online" : string.Empty, // todo: temporary?
Rank = Rank,
Ruleset = ruleset,
Mods = mods,