3053 Commits

Author	SHA1	Message	Date
Dean Herbert	70e5d4495a	Merge branch 'master' into ingame-leaderboard-general-implementation	2020-12-15 15:14:56 +09:00
Dean Herbert	ae22f75406	Bind replay recording score to judgement changes	2020-12-14 17:33:33 +09:00
Dean Herbert	1793385e96	Pass a score to the replay recorder to allow reading more general scoring data	2020-12-14 16:52:14 +09:00
Dean Herbert	0d7f53b0b9	Fix gameplay loading too fast the first time entering a beatmap	2020-12-14 14:21:21 +09:00
Bartłomiej Dach	d457926523	Merge branch 'master' into fix-player-load-stuck-at-empty-screen	2020-12-11 20:49:27 +01:00
Dean Herbert	2dd5911256	Rename method to better match purpose	2020-12-11 14:44:01 +09:00
Dean Herbert	01bd765384	Simplify pause handling by moving transform logic to bindable change event	2020-12-10 17:42:47 +09:00
Dean Herbert	679a550d83	Fix single threaded seeking not working due to unnecessary seek call	2020-12-10 17:42:28 +09:00
Dean Herbert	437c0506ce	Refactor to allow for special disposal handling to still work	2020-12-10 16:56:56 +09:00
Dean Herbert	67dd7be71a	Move cancelLoad call to OnResuming ... This has no real effect; it just feels more readable to me.	2020-12-10 16:34:59 +09:00
Dean Herbert	491ab74059	Schedule pushWhenLoaded once ever ... Previously it was being scheduled another time each OnResume, resulting in more and more calls as a user retries the same beatmap multiple times. To simplify things I've decided to just schedule once ever. This means that on resuming there's no 400ms delay any more, but in testing this isn't really an issue (load time is still high enough that it will never really be below that anyway). Even if gameplay was to load faster, the animation should gracefully proceed.	2020-12-10 16:33:30 +09:00
Dean Herbert	cc996ec7fc	Ensure player is consumed at the point of scheduled push running the first time	2020-12-10 16:32:14 +09:00
Dean Herbert	a147b7186d	Remove unnecessary call to updateVisibility	2020-12-01 14:01:34 +09:00
Dean Herbert	63ff722963	Fix code formatting	2020-12-01 14:00:54 +09:00
Ryan Zmuda	e102f2e8fa	Moved enum to bottom, change defualt bind to Shift-Tab, Fixed Notification	2020-11-30 21:38:16 -05:00
Ryan Zmuda	9145557522	Revert "Revert "forgot to remove something... sorry"" ... This reverts commit 6478bed431.	2020-11-29 23:15:12 -05:00
Ryan Zmuda	6478bed431	Revert "forgot to remove something... sorry" ... This reverts commit a780a8bbd8.	2020-11-29 23:14:43 -05:00
Ryan Zmuda	a780a8bbd8	forgot to remove something... sorry	2020-11-29 21:52:58 -05:00
Ryan Zmuda	3994cf082d	add keybind for in game overlay	2020-11-29 20:59:02 -05:00
Dean Herbert	3346c06aca	Rename variable/text to be more verbose as to toggle purpose	2020-11-26 20:04:44 +09:00
Dean Herbert	1d82557d9f	Avoid blocking global actions when skip overlay is not actually active	2020-11-24 15:42:14 +09:00
Dean Herbert	72b8eef36e	Add ability to pause/resume replay playback	2020-11-24 15:41:56 +09:00
Dean Herbert	2db42f8e67	Remove default allowRetry parameter value from ResultsScreen	2020-11-20 14:35:44 +09:00
Bartłomiej Dach	b344a13734	Add support for previewing tracks on spectator screen	2020-11-14 17:08:27 +01:00
Bartłomiej Dach	d55eae55ad	Merge branch 'master' into fix-combo-break-rewind-replay	2020-11-13 21:46:32 +01:00
Bartłomiej Dach	405407ff9e	Merge branch 'master' into fix-combo-break-sounds	2020-11-13 21:07:34 +01:00
Dean Herbert	4b5743d993	Fix combo break sound not playing after rewind	2020-11-13 13:38:14 +09:00
Dean Herbert	43626573df	Fix combo break sounds playing when seeking	2020-11-13 13:36:19 +09:00
smoogipoo	6f7a1dd57d	Merge branch 'master' into hitobject-pooling-base	2020-11-11 17:09:18 +09:00
Dean Herbert	11cf04eed1	Fix frames potentially getting added to spectator replay in wrong format ... The way spectator currently works, the `Spectator` screen is responsible for adding new frames to the replay, even when it has a child (`SpectatorPlayer`) present. There was a possibility that a new play had already started, and on returning to the Spectator screen (to initialise the new play) there would be a brief period where the Player instance is still reading from the replay, the `userBeganPlaying` call had not yet finished initialising the new target replay, and `userSentFrames` is run (asynchronously), writing frames to the previous replay using the incorrect ruleset instance). To make this work, it doesn't `Schedule` frame addition to the replay (making things a bit unsafe). Changing this itself isn't such a simple one to do, so I instead opted to fix this via locking. Closes https://github.com/ppy/osu/issues/10777.	2020-11-11 13:39:43 +09:00
smoogipoo	66213f2ed0	Add pooling support to DrawableRuleset + Playfield	2020-11-10 23:56:32 +09:00
Dean Herbert	07166ec819	Fix a couple of remaining unnecessary casts	2020-11-06 13:29:47 +09:00
Dean Herbert	1b2bd6a8c9	Remove redundant base call	2020-11-03 20:10:13 +09:00
Dean Herbert	3e29e468ea	Ensure "start watching" button starts in a disabled state	2020-11-03 20:06:42 +09:00
Dean Herbert	414f65c1ef	Merge branch 'master' into spectator-listing	2020-11-02 15:48:21 +09:00
Dan Balasescu	04178e9458	Merge branch 'master' into spectator-replay-watcher	2020-11-02 14:54:51 +09:00
Dan Balasescu	1b53e6c782	Merge branch 'master' into sample-lookup-improvements	2020-11-02 13:04:35 +09:00
Bartłomiej Dach	716458344f	Ensure spectator player is unsubscribed to prevent leak	2020-11-01 16:13:19 +01:00
Bartłomiej Dach	b7696c85ad	Add more xmldocs	2020-11-01 15:23:03 +01:00
Dean Herbert	a088151e58	Merge branch 'spectator-replay-watcher' into spectator-listing	2020-10-31 16:22:10 +09:00
Dean Herbert	79aecc9a98	Merge branch 'master' into spectator-replay-watcher	2020-10-30 16:31:24 +09:00
Dan Balasescu	0ef1459f4b	Merge pull request #10621 from peppy/hud-momentary-visibility ... Add momentary HUD toggle	2020-10-30 15:40:54 +09:00
Dean Herbert	8928aa6d92	Add key binding to show HUD while held	2020-10-30 14:19:40 +09:00
Dean Herbert	b4eda65383	Commit missing pieces	2020-10-30 13:53:51 +09:00
Dean Herbert	9bb86ccb83	Change shift-tab to cycle available HUD visibility modes	2020-10-30 13:09:22 +09:00
Dean Herbert	2ea4aa0a37	Fix incorrect specification on some sample lookups	2020-10-30 11:59:41 +09:00
Dean Herbert	bca317b151	Remove excess using statement	2020-10-28 23:43:16 +09:00
Dean Herbert	e1bf751dac	Merge branch 'spectator-replay-watcher' into spectator-listing	2020-10-28 23:17:50 +09:00
Dean Herbert	5d02de29ca	Fix attempt to change ruleset/beatmap bindables while screen is not active	2020-10-28 22:50:45 +09:00
Dean Herbert	25ab3a5fea	Construct replay after being sure a ruleset is available to avoid nullrefs	2020-10-28 22:10:37 +09:00
Dean Herbert	dd2f44f393	Add basic "currently watching" text to player to signify that spectator is active	2020-10-28 19:43:06 +09:00
Dean Herbert	93fd913876	Add setting to allow automatically downloading during a spectating session	2020-10-28 19:43:06 +09:00
Dean Herbert	9807089834	Fix screen exit potentially occuring during transition	2020-10-28 19:43:06 +09:00
Dean Herbert	4df8119852	Add missing schedule	2020-10-28 19:43:06 +09:00
Dean Herbert	93e3e1a4db	Don't inherit ReplayPlayer to make results screen work correctly	2020-10-28 19:02:38 +09:00
Dean Herbert	344ff8f4bc	"Improve" visuals of spectator screen	2020-10-28 19:02:38 +09:00
Dean Herbert	2d73dfbe39	Add more safety around beatmap panel and button display logic	2020-10-28 19:02:38 +09:00
Dean Herbert	c97feb09bf	Allow continuing to automatically spectate user from results screen	2020-10-28 19:02:38 +09:00
Dean Herbert	16b0a7b33e	Add button flow to allow resuming watching after exiting manually	2020-10-28 19:02:38 +09:00
Dean Herbert	6169349f7c	Fix switching to new beatmap not working correctly	2020-10-28 17:44:11 +09:00
Dean Herbert	730cc645fb	Avoid reconstructing ruleset for each frame bundle	2020-10-28 16:33:52 +09:00
Dean Herbert	48b0357e7d	Fix "finished playing" events handled for potentially incorrect user	2020-10-28 16:11:14 +09:00
Dean Herbert	0a7f3dc19b	Avoid null reference on finalization ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-10-28 07:29:07 +09:00
Dean Herbert	d5e0fa322b	Fix a couple of inspections	2020-10-27 22:30:45 +09:00
Dean Herbert	2cacdaa11b	Add basic beatmap download and play flow	2020-10-27 19:28:34 +09:00
Dean Herbert	42b3aa3359	Fix spectating when starting from a point that isn't at the beginning of the beatmap	2020-10-27 18:58:37 +09:00
Dean Herbert	851d45d2eb	Add sane pausing logic	2020-10-27 18:58:37 +09:00
Dean Herbert	3ec3321a3d	Add missing space	2020-10-27 18:58:37 +09:00
Dean Herbert	b737a8bf6e	Add field to Replay denoting whether the full replay have been received or not	2020-10-27 18:58:37 +09:00
Dean Herbert	9bac8f3792	Add null check on replay as safety measure	2020-10-27 18:58:37 +09:00
Dean Herbert	ac4671c594	Add basic implementation of spectator screen	2020-10-27 18:58:37 +09:00
Dean Herbert	5fd97bd043	Add basic spectator screen	2020-10-27 18:58:37 +09:00
Dean Herbert	9cfb81589e	Use bindable flow instead	2020-10-27 14:10:12 +09:00
Dean Herbert	6853da459d	Move sample pausing logic out of FrameStabilityContainer	2020-10-27 13:54:33 +09:00
Dean Herbert	b86347dc81	Merge branch 'master' into spectator	2020-10-26 13:39:07 +09:00
Bartłomiej Dach	0542a45c43	Change to manual adjustment add/remove	2020-10-25 12:33:35 +01:00
Bartłomiej Dach	85e14f3f0c	Shorten fade duration to make fade out snappier	2020-10-25 00:40:11 +02:00
Bartłomiej Dach	e101ba5cba	Move volume manipulations to player loader	2020-10-25 00:40:11 +02:00
Bartłomiej Dach	73174961f0	Rework animation sequence for readability	2020-10-24 22:30:08 +02:00
Dean Herbert	4fca7675b0	Don't send spectate data when an autoplay mod is active	2020-10-23 14:47:21 +09:00
Dan Balasescu	bd4e0e1a60	Merge branch 'master' into epilepsy-warning	2020-10-20 17:43:37 +09:00
Dean Herbert	55d08fad5c	Remove unused field	2020-10-20 15:18:15 +09:00
Dean Herbert	7a68636f71	Adjust fade sequence and durations to feel better	2020-10-20 15:03:33 +09:00
Dean Herbert	4e57751ca1	Fix background dim application to avoid overdraw, transition smoother	2020-10-20 15:03:12 +09:00
Dean Herbert	80b1f816c7	Merge branch 'master' into hide-hud-during-break-time	2020-10-20 14:19:04 +09:00
Dean Herbert	c57fecd1fc	Update comment to make it clear this is a hack	2020-10-20 12:43:57 +09:00
Bartłomiej Dach	fd4bab85cf	Merge branch 'master' into epilepsy-warning	2020-10-20 01:06:46 +02:00
Bartłomiej Dach	05251c646e	Fade volume back up on pop out	2020-10-20 01:06:20 +02:00
Bartłomiej Dach	1fc22bdbff	Only show warning once on given map	2020-10-20 00:59:36 +02:00
Bartłomiej Dach	a164d330e5	Improve feel of transition	2020-10-20 00:51:31 +02:00
Bartłomiej Dach	6e50ae0458	Reformulate push sequence code	2020-10-20 00:22:30 +02:00
Bartłomiej Dach	8505903041	Move warning construction to load()	2020-10-20 00:08:05 +02:00
Bartłomiej Dach	aeca61eb3e	Split warning to separate file	2020-10-19 23:48:02 +02:00
Bartłomiej Dach	44279ed347	Remove unused using directive	2020-10-19 23:46:09 +02:00
Salman Ahmed	6e4b28ed1e	Different version of epilepsy warning display	2020-10-20 00:32:44 +03:00
Joehu	fef6e55b39	Remove unused using and field	2020-10-19 12:32:16 -07:00
Joehu	dbda18acea	Fix autoplay/replay settings going off screen on some legacy skins	2020-10-19 12:04:23 -07:00
Dan Balasescu	b5cadd6a2c	Merge pull request #10555 from peppy/fix-score-display-zero-padding ... Fix incorrect zero padding for classic scoring mode	2020-10-19 15:54:12 +09:00
Dean Herbert	ba99c5c134	Remove rolling delay on default combo counter	2020-10-19 14:39:02 +09:00
Dean Herbert	cb1784a846	Fix score displays using non-matching zero padding depending on user score display mode	2020-10-19 14:05:28 +09:00
Dan Balasescu	b7c12ff61e	Merge pull request #10530 from peppy/fix-catch-dual-combo-counter ... Fix osu!catch showing two combo counters for legacy skins	2020-10-16 23:52:14 +09:00
smoogipoo	dfbc0965e4	Merge branch 'master' into peppy/skinnable-health-display	2020-10-16 23:17:17 +09:00
Dean Herbert	8a3bce3cc3	Fix osu!catch showing two combo counters for legacy skins	2020-10-16 18:20:17 +09:00
Dean Herbert	a774de2270	Also add support in LegacyComboCounter	2020-10-16 17:52:22 +09:00
Dean Herbert	77bf050a80	Ignore IgnoreHits for flashiness	2020-10-16 17:24:43 +09:00
Dean Herbert	f0b15813e2	Add support for both legacy styles	2020-10-16 17:08:46 +09:00
Dean Herbert	a810f56ec8	Move "flash on hit only" logic to binding	2020-10-16 17:08:46 +09:00
Dean Herbert	c0a1f2158c	Add basic component structure for skinnable health displays	2020-10-16 17:08:46 +09:00
Dan Balasescu	583fdc3a95	Merge pull request #10510 from peppy/skinnable-accuracy-display ... Add legacy skinning support for accuracy display	2020-10-15 21:20:48 +09:00
Dan Balasescu	5d8cf87155	Merge pull request #10511 from peppy/bottom-error-display ... Add support for bottom-anchored hit error display	2020-10-15 20:51:09 +09:00
Dan Balasescu	70b050f212	Merge branch 'master' into skinnable-accuracy-display	2020-10-15 20:28:57 +09:00
Dan Balasescu	1ce0e83e59	Merge branch 'master' into skinnable-score-display	2020-10-15 19:16:03 +09:00
Dan Balasescu	93dfbd5d9e	Merge pull request #10505 from peppy/skin-disabler-refactor ... Move ISampleDisabler implementation to Player and FrameStabilityContainer	2020-10-15 19:14:52 +09:00
Dean Herbert	70806deba1	Add support for bottom-anchored hit error display	2020-10-15 19:14:02 +09:00
Dean Herbert	d76365ed1b	Make container readonly	2020-10-15 18:38:41 +09:00
Dan Balasescu	5640d33d1a	Merge branch 'master' into skin-disabler-refactor	2020-10-15 18:32:50 +09:00
Dean Herbert	6983978c98	Correct top-right element offset by finding the lower top anchor element	2020-10-15 18:30:44 +09:00
Dean Herbert	b31a3fbabb	Add test	2020-10-15 18:11:30 +09:00
Dean Herbert	254eba9008	Add and consume skinnable accuracy counter	2020-10-15 17:53:16 +09:00
Dean Herbert	90ff8ff050	Merge branch 'skinnable-combo-counter' into skinnable-score-display	2020-10-15 17:52:06 +09:00
Dean Herbert	37e9f331ad	Simplify score font lookup	2020-10-15 17:49:55 +09:00
Dean Herbert	43e5cb90e2	Merge branch 'skinnable-combo-counter' into skinnable-score-display	2020-10-15 17:30:29 +09:00
Dean Herbert	9f51327e4b	Fix completely incorrect default positioning logic	2020-10-15 17:29:40 +09:00
Dean Herbert	5b5ba7df93	Remove unused offset	2020-10-15 17:22:34 +09:00
Dean Herbert	d8d085ede9	Align top-right elements with lowest point in score display	2020-10-15 17:14:42 +09:00
Dean Herbert	74c031cfbb	Fix ModOverlay not including "UNRANKED" text in size	2020-10-15 17:14:42 +09:00
Dean Herbert	b210147c2e	Update combo counter to read from default score display's position correctly	2020-10-15 17:14:42 +09:00
Dean Herbert	950c47287c	Fix positioning of score display in HUD overlay	2020-10-15 17:14:42 +09:00
Dean Herbert	e1da64398e	Add and consume skinnable score counter	2020-10-15 17:14:42 +09:00
Dean Herbert	219cbec6bd	Split out DefaultScoreCounter and make ScoreCounter abstract	2020-10-15 16:32:30 +09:00
Dean Herbert	d5f2aab52e	Tidy up SkinnableComboCounter class slightly	2020-10-15 15:37:40 +09:00
Dean Herbert	e0210f5c4c	Ignore failed casts to make tests happy	2020-10-14 23:52:58 +09:00
Dean Herbert	e3eaba7b2c	Move ISampleDisabler implementation to Player and FrameStabilityContainer	2020-10-14 19:39:48 +09:00
Dean Herbert	ac4f56403d	Adjust size/position	2020-10-14 19:16:34 +09:00
Dean Herbert	7f5ea57bd4	Clean-up pass (best effort) on LegacyComboCounter	2020-10-14 19:16:34 +09:00
Dean Herbert	9bb8a43bce	Combine LegacyComboCounter and ComboCounter classes	2020-10-14 19:16:34 +09:00
Dean Herbert	fbbea48c8c	Add score text skinnability	2020-10-14 19:16:34 +09:00
Dean Herbert	2fce064e32	Add basic legacy combo counter and updating positioning logic	2020-10-14 19:16:34 +09:00
Dean Herbert	6a6718ebab	Allow bypassing origin/anchor setting of skinnable components ... It makes little sense to set these when using RelativeSizeAxes.Both	2020-10-14 19:16:34 +09:00
Dean Herbert	899bac6ca5	Rename catch combo counter for clarity	2020-10-14 19:16:34 +09:00
Dean Herbert	f5623ee21e	Setup skinnable combo counter component with default implementation	2020-10-14 19:16:34 +09:00
Dean Herbert	60603d2918	Add skin components and interfaces	2020-10-14 19:16:34 +09:00
Dean Herbert	98acf1e31d	Make field read only	2020-10-14 19:16:25 +09:00
Dean Herbert	a7f8e26e35	Adjust bottom-right elements positions based on song progress display	2020-10-14 18:51:53 +09:00
Dean Herbert	0cf3e90904	Update SongProgress height based on its dynamic height during resize	2020-10-14 18:44:22 +09:00
Dean Herbert	ace9fbc8d3	Confine available area for HUD components to excluse the song progress area	2020-10-14 18:44:22 +09:00
Dean Herbert	de6fe34361	Bind to local bindable and combine dual bindings	2020-10-11 21:51:48 +09:00
Dean Herbert	5fcdee6fd8	Remove cast and expose as IBindable	2020-10-11 21:46:55 +09:00
unknown	6a52c98a42	make IsBreakTime its own bindable and bind it to BreakTracker on load	2020-10-11 06:15:20 +08:00
unknown	7bbdd6ab25	expose break time bindable	2020-10-10 21:07:17 +08:00
Dean Herbert	8dddd8aff5	Merge pull request #9883 from swoolcock/confine-during-gameplay ... Add "During Gameplay" option for mouse confining	2020-10-08 20:25:27 +09:00
Dean Herbert	dbdb25ccf7	Move reset logic to OsuGame	2020-10-08 18:29:19 +09:00
Dean Herbert	43a575484a	Remove pointless comments	2020-10-08 18:29:09 +09:00
Dean Herbert	0f6eb9d4cb	Ensure music playback is stopped when retrying by any means	2020-10-07 17:40:54 +09:00
Shane Woolcock	2e0a9f53c1	Add test coverage	2020-10-07 17:52:39 +10:30
Shane Woolcock	8b8eb00bd7	Permit nulls rather than casting to OsuGame	2020-10-07 16:16:58 +10:30
Shane Woolcock	485bd962c7	Also reset LocalUserPlaying in OnSuspending	2020-10-07 16:15:17 +10:30
Shane Woolcock	7fff762dfc	Rename IsGameplay	2020-10-07 16:14:49 +10:30
Shane Woolcock	8847b88e65	Fix unit tests trying to resolve OsuGame	2020-10-07 11:44:41 +10:30
Shane Woolcock	ec12a21088	Merge branch 'master' into confine-during-gameplay ... # Conflicts: # osu.Game/Overlays/Settings/Sections/Input/MouseSettings.cs	2020-10-07 11:07:00 +10:30
Shane Woolcock	478f2dec96	Maintain the current gameplay state in OsuGame	2020-10-06 22:39:35 +10:30
Shane Woolcock	782fc1d60f	Use OsuGame.OverlayActivationMode rather than per-Player	2020-10-06 20:27:35 +10:30
Dean Herbert	d5782c95bd	Merge branch 'master' into confine-during-gameplay	2020-10-06 18:05:15 +09:00
Dean Herbert	9d7880afda	Make SettingsItem conform to IHasCurrentValue	2020-10-06 17:18:54 +09:00
Dean Herbert	e4710f82ec	Fix sample disabled status not being updated correctly from seek state	2020-10-05 14:27:51 +09:00
Shane Woolcock	a483dfd2d7	Allow confineMouseTracker to be null	2020-10-05 11:54:39 +10:30
Shane Woolcock	5859755886	Use current OverlayActivationMode to determine confine logic	2020-10-05 11:11:46 +10:30
Shane Woolcock	4b6f893408	Merge branch 'master' into confine-during-gameplay ... # Conflicts: # osu.Game/Configuration/OsuConfigManager.cs # osu.Game/OsuGame.cs # osu.Game/Screens/Play/Player.cs	2020-10-05 10:23:37 +10:30
Bartłomiej Dach	6f2b991b32	Ensure true gameplay rate is finite when paused externally	2020-10-04 14:54:51 +02:00
Bartłomiej Dach	1f0620ffd4	Replace assignment references to HitResult.Miss with Judgement.MinResult	2020-10-02 23:31:24 +02:00
Bartłomiej Dach	2b1ef16f89	Replace comparison references to HitResult.Miss with IsHit	2020-10-02 23:31:24 +02:00
Dean Herbert	367b35bb10	Merge branch 'master' into fix-storyboard-sample-pausing	2020-09-30 22:42:26 +09:00
Dean Herbert	b0f8e11bd4	Fix incorrect caching	2020-09-30 17:34:14 +09:00
Dean Herbert	7f579850dd	Merge branch 'master' into fix-editor-silence-on-seek	2020-09-30 17:03:23 +09:00
Dean Herbert	414c40d298	Reverse inheritance order of SkinnableSound's pause logic	2020-09-30 15:45:14 +09:00
Dean Herbert	136843c8e4	Make DrawableStoryboardSample a SkinnableSound ... Allows sharing pause logic with gameplay samples.	2020-09-29 14:25:39 +09:00
Dean Herbert	74e74e1c31	Fix pause loop sound not working because paused	2020-09-29 14:20:41 +09:00
Dean Herbert	c5f6b77bba	Add missing cached type	2020-09-29 13:42:17 +09:00
Dean Herbert	d6f3beffb6	Use existing bindable flow instead	2020-09-29 12:50:17 +09:00
Dean Herbert	4f0c0ea5f9	Fix hit samples playing while paused / seeking in the editor	2020-09-28 18:17:47 +09:00
Dean Herbert	26ba7d3100	Remove unused method (was moved to a more local location)	2020-09-25 13:20:19 +09:00
Dean Herbert	7df8b5bce7	Merge branch 'master' into fix-spinner-rpm-user-rate-adjust	2020-09-25 13:17:03 +09:00
Joehu	c5b684bd2e	Fix typo in log when beatmap fails to load	2020-09-23 00:30:20 -07:00
Dean Herbert	3276b9ae9c	Fix fail animation breaking on post-fail judgements	2020-09-22 15:08:53 +09:00
Dean Herbert	508278505f	Make local clock private	2020-09-21 19:40:57 +09:00
Dean Herbert	3f788da06d	Fix SPM changing incorrectly with playback rate changes	2020-09-21 19:39:54 +09:00
smoogipoo	06c49070b1	Remove player collection settings	2020-09-11 16:04:09 +09:00
Dean Herbert	d3957e6155	Move title specification for settings groups to constructor ... Using an abstract property was awkward for this as it is being consumed in the underlying constructor but could not be dynamically set in time from a derived class.	2020-09-09 18:50:31 +09:00
Lucas A	82e314da59	Fix merge conflicts.	2020-09-03 21:56:47 +02:00
Dan Balasescu	84b3604192	Merge branch 'master' into game-overlay-activation-mode	2020-09-03 13:34:22 +09:00
smoogipoo	7e1844ed77	Fix track adjusments being reset incorrectly	2020-09-01 18:07:19 +09:00
smoogipoo	26b4226b55	Fix ModTimeRamp not working	2020-09-01 16:55:10 +09:00
Dan Balasescu	f08e7828da	Merge branch 'master' into beatmap-track-rework	2020-09-01 16:06:38 +09:00
Lucas A	dd093f44d8	Cast base immutable bindable to mutable for testing purposes and make InitialOverlayActivationMode property protected	2020-08-31 11:26:55 +02:00
Dean Herbert	a171d0e292	Remove unused methods and classes	2020-08-31 18:14:22 +09:00
Dean Herbert	3b03116179	Remove unnecessary using statement	2020-08-21 16:45:59 +09:00
Dean Herbert	f7e4feee34	Update remaining Player components to use WorkingBeatmap again	2020-08-21 15:25:57 +09:00
Dean Herbert	357fb3a10e	Merge branch 'master' into beatmap-track-rework	2020-08-21 12:53:09 +09:00
Dean Herbert	5714c761eb	Merge pull request #9768 from frenzibyte/allow-counter-customize-sprite-text ... Allow providing custom sprite text for RollingCounter<T>	2020-08-20 00:14:48 +09:00
Salman Ahmed	8f1a71c6b1	Remove counter sprite attributes for not being of any reasonable use	2020-08-19 07:44:45 +03:00
Dean Herbert	93a8bc3d5a	Remove local reset method in GameplayClockContainer	2020-08-17 22:36:09 +09:00
Dean Herbert	d9debef156	Add explicit LoadTrack method	2020-08-17 15:38:16 +09:00
Lucas A	589d4eeb52	Remove setting.	2020-08-16 17:18:40 +02:00
Shane Woolcock	85b3fff9c8	Update mouse confine when gameplay state changes	2020-08-16 23:11:09 +09:30
Dean Herbert	71f4e753f0	Merge branch 'master' into beatmap-track-rework	2020-08-16 22:35:32 +09:00
Bartłomiej Dach	a426ff1d5b	Refactor gameplay menu overlay to fix regression	2020-08-15 14:18:50 +02:00
Dean Herbert	e465afa280	Merge branch 'master' into beatmap-track-rework	2020-08-14 20:02:43 +09:00
Dan Balasescu	b7ae70ff96	Merge branch 'master' into fix-skinnable-sound-mute	2020-08-14 19:01:32 +09:00
Lucas A	84cb36b6a8	Defer subscriptions for updateOverlayActivationMode() to OnEntering()	2020-08-13 10:57:18 +02:00
Dean Herbert	99bea6b8e9	Add missing null check (player construction is potentially delayed now)	2020-08-13 12:52:35 +09:00
Dean Herbert	27cd9e119a	Delay beatmap load until after transition has finished ... Previously the beatmap would begin loading at the same time the `PlayerLoader` class was. This can cause a horribly visible series of stutters, especially when a storyboard is involved. Obviously we should be aiming to reduce the stutters via changes to the beatmap load process (such as incremental storyboard loading, `DrawableHitObject` pooling, etc.) but this improves user experience tenfold in the mean time.	2020-08-13 12:04:32 +09:00
smoogipoo	c0031955c9	Update with further framework changes	2020-08-12 01:50:18 +09:00
smoogipoo	e47a1eb313	Use adjustable ITrack	2020-08-12 01:41:21 +09:00
smoogipoo	eec94e1f53	Make track not-null in GameplayClockContainer/FailAnimation	2020-08-12 00:51:43 +09:00
smoogipoo	c66a14e9c5	Remove beatmap from FailAnimation	2020-08-11 12:37:48 +09:00
Lucas A	f74e162bbc	Fix overlay activation mode being updated when player is not current screen.	2020-08-10 20:27:42 +02:00
Lucas A	052bb06c91	Add ability to open overlays during gameplay breaks.	2020-08-10 20:13:50 +02:00
Dean Herbert	365aae799e	Merge branch 'master' into fix-skinnable-sound-mute	2020-08-10 23:55:51 +09:00
Bartłomiej Dach	9a09f97478	Extract constant to avoid double initial value spec	2020-08-08 21:21:30 +02:00
Dean Herbert	e3105fd4c8	Add more resilient logic for whether to avoid playing SkinnableSound on no volume	2020-08-06 19:16:26 +09:00
smoogipoo	2e3ecf71c7	Pass track from Player to components	2020-08-06 18:31:08 +09:00
smoogipoo	5c05fe3988	Expose track from MusicController	2020-08-06 16:24:14 +09:00
smoogipoo	6e42b8219c	Move track to MusicController, compiles	2020-08-06 16:24:14 +09:00
smoogipoo	9a00ad48c6	Update components to use extension methods	2020-08-06 14:43:39 +09:00
Lucas A	71895964f4	Refactor overlay activation logic and reword tip.	2020-08-05 11:21:09 +02:00
Lucas A	30c7a6f6a7	Fix CI issue and use method instead of triggering change on bindable.	2020-08-03 21:33:18 +02:00
Lucas A	242a035f7e	Apply review suggestions.	2020-08-03 21:25:45 +02:00
Lucas A	25ebb8619d	Add tests.	2020-08-03 16:04:11 +02:00
Lucas A	fe97d472df	Enable back overlays when a replay is loaded.	2020-08-02 21:53:13 +02:00
Lucas A	f1ba576438	Disable overlay activation when in gameplay.	2020-08-02 21:34:35 +02:00
Joe Yuan	e795b1ea31	Failing effect displays vertically	2020-07-28 00:42:48 -07:00
Dean Herbert	ee05d5cb14	Remove no-longer-necessary play trigger on skin change	2020-07-23 09:06:15 +09:00
Dean Herbert	fea6389f69	Hide HUD elements during break time by default	2020-07-22 12:41:06 +09:00
Gagah Pangeran	95f52573f7	change font size	2020-07-21 15:58:25 +07:00
Gagah Pangeran	055e31ddd5	update minor	2020-07-20 18:37:02 +07:00
Gagah Pangeran	6a144fba80	add epilepsy warning in metadata display	2020-07-20 17:24:17 +07:00
Dean Herbert	a39c4236c7	Fix multiple issues and standardise transforms	2020-07-17 19:08:50 +09:00
Dean Herbert	aa992f2e34	Merge branch 'master' into Issue#9170	2020-07-17 18:29:40 +09:00
Joehu	ecbd8067e9	Add ability to seek replays/auto with arrow keys	2020-07-14 20:18:47 -07:00
Dan Balasescu	c49ce65326	Merge pull request #9540 from peppy/gameplay-pause-via-middle-mouse ... Allow pausing gameplay via middle mouse button	2020-07-14 21:13:31 +09:00
Dean Herbert	2626ab41c3	Add implicit braces for clarity	2020-07-14 20:15:31 +09:00
Dean Herbert	c7d3b025ad	Rename variable and change default to true	2020-07-14 20:11:54 +09:00
Dean Herbert	690f2fd482	Merge branch 'master' into always-combo-break	2020-07-14 20:11:02 +09:00
Dean Herbert	f442df75a9	Add missing released conditional	2020-07-13 09:00:10 +09:00
Dean Herbert	c1aafe83fa	Add note about future behaviour	2020-07-12 23:05:47 +09:00
Dean Herbert	08696b9bca	Allow pausing gameplay via middle mouse button	2020-07-12 23:03:03 +09:00
BananeVolante	f03303573e	formating	2020-07-08 13:54:22 +02:00
BananeVolante	e8f23e35a5	WIP : replaced TransformBindableTo by VolumeTo ... Currently, the VolumeTO calls taht use a fading does not do anything. calling VolumeTo calls pauseLoop.samplesContainer.TransformBindableTo(....), while i used to call pauseLoop.TransformBindableTo(....)	2020-07-03 14:33:42 +02:00
BananeVolante	ab1eb469af	removed unneeded null checks	2020-07-01 13:30:23 +02:00
BananeVolante	ab134c0ed7	removed unneeded information in a comment	2020-07-01 13:27:33 +02:00
BananeVolante	946fcf75ac	Merge branch 'master' of https://github.com/ppy/osu into Issue#9170 ... update local code	2020-07-01 13:06:44 +02:00
Dan Balasescu	0e80d6629b	Merge branch 'master' into red-tint	2020-06-30 15:44:22 +09:00
Bartłomiej Dach	678767918e	Centralise logic further	2020-06-28 23:32:04 +02:00
Bartłomiej Dach	3637bf2f9b	Clean up member order & access modifiers	2020-06-26 19:39:55 +02:00
Bartłomiej Dach	02f590309d	Add xmldoc for public property	2020-06-26 19:39:55 +02:00
Bartłomiej Dach	a63b6a3ddf	Simplify binding	2020-06-26 19:39:55 +02:00
Bartłomiej Dach	415e1c05ff	Simplify implementation	2020-06-26 19:39:55 +02:00
Bartłomiej Dach	3783fe8d6a	Rename fields for clarity	2020-06-26 19:39:53 +02:00
Power Maker	798e8e7a8d	Fix CI fail	2020-06-26 15:12:01 +02:00
Power Maker	efeaa1cc10	Make some changes, fix and add tests	2020-06-26 14:58:42 +02:00
Power Maker	97a212a7f6	Hide red tint based on "Show health display even when you can't fail" setting	2020-06-26 14:32:01 +02:00
BananeVolante	a4bb238c45	fixed bug preventing the pause loop from playing during the first pause after changing a skin	2020-06-26 14:07:27 +02:00
BananeVolante	7d2d6a52c9	now uses SkinnableSample instead of Drawable sample ... Still does not support switching skins after Pause overlay loading, there will be no sound for the first pause (works fine the the nexts) Also, the pause loop seems to play for approximately 1 second when exiting the screens via restart or quit finally, since SkinnableSound does not play a sound if its aggregate volume is at 0, i had turn up the volume a bit before playing the loop	2020-06-25 18:58:04 +02:00
BananeVolante	9e5cc1b7a2	added skin support for the pause loop	2020-06-25 13:26:42 +02:00
BananeVolante	2e8f30461f	play/stops music when entering the pause overlay, instead of letting it play silently in the background	2020-06-24 14:22:12 +02:00
BananeVolante	53107973a3	merged 2 lines ... Co-authored-by: Salman Ahmed <email@iisalman.me>	2020-06-24 14:01:13 +02:00
Dean Herbert	9119f41604	Merge branch 'master' into results-screen-statistics-overlapping-transition	2020-06-24 18:22:51 +09:00
Bartłomiej Dach	43be75d481	Merge branch 'master' into Issue#9170	2020-06-23 20:49:13 +02:00
BananeVolante	624ad65806	formating	2020-06-23 13:09:24 +02:00
Dean Herbert	a6c6e391ca	Fix player not exiting immediately on Alt-F4	2020-06-23 17:38:30 +09:00
BananeVolante	579d7cedcc	Merge branch 'master' of https://github.com/ppy/osu into Issue#9170 ... updated local source	2020-06-22 15:29:05 +02:00
BananeVolante	836386d03b	removed duplicate lines	2020-06-22 15:22:13 +02:00
BananeVolante	9dea96e5fd	added pause sound with fading	2020-06-22 14:02:21 +02:00
BananeVolante	a4eb6c81c5	undid changes to the file	2020-06-22 13:40:31 +02:00
smoogipoo	261adfc4e6	Create a local playable beatmap instead	2020-06-22 18:38:41 +09:00
smoogipoo	33fdd7466c	Merge branch 'master' into results-screen-statistics-overlapping-transition	2020-06-22 15:38:48 +09:00
smoogipoo	49bdd89775	Cleanup ReplayPlayer adjustments	2020-06-19 21:54:09 +09:00
Dean Herbert	290ae37346	Add assertion of only usage game-wide	2020-06-18 23:54:20 +09:00
Dean Herbert	7da56ec7fd	Add null check and xmldoc	2020-06-18 23:52:35 +09:00
Dean Herbert	add1265d53	Block screen suspend while gameplay is active	2020-06-18 23:48:00 +09:00
smoogipoo	9442fc00ac	Temporary hack to make replay player populate scores	2020-06-16 17:48:59 +09:00
Dean Herbert	17a70bf6ee	Add test coverage	2020-06-15 20:32:27 +09:00
BananeVolante	4e7d60b6ff	Merge branch 'master' of https://github.com/ppy/osu into Issue#9170 ... updated local source	2020-06-15 12:58:47 +02:00
Dean Herbert	0d53d0ffc8	Fix back-to-front math	2020-06-15 00:46:20 +09:00
Dean Herbert	7b95c55afb	Fix HardwareCorrectionOffsetClock breaking ElapsedTime readings	2020-06-14 11:33:59 +09:00
BananeVolante	04c1efe298	resolved issues with inspect code script	2020-06-13 14:33:55 +02:00
BananeVolante	794b8673e2	formated using dotnet format	2020-06-13 10:56:02 +02:00
BananeVolante	8b8f2dfda2	Removed duplicate samplepause.stop() calls, removed test lines ... Since restart() always call perform immediate exit when the function lead to a restart, there is no need to stop the pause sample in restart	2020-06-13 10:31:54 +02:00
BananeVolante	6fd8548f79	no longer crash if the restart sample isn't found	2020-06-13 10:13:41 +02:00
BananeVolante	2feaf2c74a	added music during pause	2020-06-12 19:17:52 +02:00
Dean Herbert	64550fe87c	Merge branch 'master' into fix-draining-in-between-break-sections	2020-06-02 16:06:08 +09:00
smoogipoo	de0b6ec9f1	Create abstract implementation	2020-05-26 17:00:41 +09:00
Dean Herbert	ce223a2bd8	Silence hit sounds while seeking	2020-05-21 11:08:06 +09:00
smoogipoo	e5de382760	Merge branch 'master' into storyboard-overlay-layer	2020-05-20 15:08:45 +09:00
smoogipoo	85088c9b3b	Privatise setter	2020-05-20 15:08:33 +09:00
Bartłomiej Dach	ce4301c5b8	Add overlay layer to player by proxying	2020-05-19 19:47:50 +02:00
smoogipoo	6d70f4b410	Merge branch 'master' into allowgameplayoverlays-hide-skip	2020-05-18 19:54:38 +09:00
smoogipoo	49ee05c3c4	Make into CompositeDrawable	2020-05-18 19:37:49 +09:00
Lucas A	4096463d02	Move SkipOverlay internal alpha manipulation to a nested container and adjust visual tests.	2020-05-15 19:43:01 +02:00
Dean Herbert	9b6525bb03	Fix applied platform/user offsets being incorrect when rate adjust mods are active	2020-05-15 18:44:47 +09:00
Lucas A	7874045b1f	Allow disabling SkipOverlay through AllowGameplayOverlays.	2020-05-12 23:05:56 +02:00
Dean Herbert	de50b725d5	Fix mod failure checks executing actual game logic	2020-05-12 20:08:35 +09:00
Dan Balasescu	6841bd5609	Merge branch 'master' into taiko-scroller	2020-05-11 11:10:55 +09:00
Bartłomiej Dach	ee2ff77b89	Merge branch 'master' into fix-draining-in-between-break-sections	2020-05-10 17:57:44 +02:00
Dean Herbert	c712e98f2b	Merge branch 'master' into publicly-expose-hud	2020-05-10 20:06:28 +09:00
Dean Herbert	9b8589583c	Merge branch 'master' into taiko-scroller	2020-05-08 19:10:39 +09:00
Lucas A	30dd158c33	Rename property to AllowGameplayOverlays and update XMLDoc accordingly.	2020-05-08 09:37:50 +02:00
Lucas A	83be5455d3	Disable the display of HUD through DisplayHud property.	2020-05-07 08:52:36 +02:00
Lucas A	aff74db80d	Publicly expose HUDOverlay in Player.	2020-05-05 10:40:10 +02:00
alex	0e2ccac33b	Add spaces to comments	2020-05-04 18:36:24 -07:00
Dean Herbert	cea6be5e52	Expose as JudgementResult instead of "passing" state	2020-05-03 23:55:44 +09:00
Bartłomiej Dach	8118747732	Make PeriodTracker actually immutable	2020-05-02 01:33:33 +02:00
Dean Herbert	ff1d63060d	Add and consume passing state in GameplayBeatmap	2020-05-01 20:08:18 +09:00
Salman Ahmed	6fa9feb15c	Merge remote-tracking branch 'upstream/master' into add-interval-list	2020-04-29 05:14:40 +03:00
Salman Ahmed	6e76e5900a	Rename is-in-any check method to a more legible name	2020-04-29 05:11:44 +03:00
Salman Ahmed	8d899f4e77	Apply changes to the BreakTracker and more adjustment	2020-04-29 05:11:43 +03:00
Dean Herbert	a91c63819b	Refactor updateCompletionState implementation for legibility and code share	2020-04-21 11:55:28 +09:00
Salman Ahmed	e12e3391fb	Base wait steps duration on the delay used for results display ... With `* 2` for safety of not potentially going to the next step and the delegate not executed yet.	2020-04-20 06:42:33 +03:00
Endrik Tombak	f893d523f5	User setting for always playing first combo break	2020-04-19 12:23:41 +03:00
Salman Ahmed	6d276890a7	Fix results screen pushed after rewinding in-between push delay	2020-04-19 05:59:56 +03:00
Salman Ahmed	7e64bec94f	Use HasCompleted in Player	2020-04-19 05:58:22 +03:00
Salman Ahmed	fc6c245de5	Replace all judged event logic with HasCompleted bindable	2020-04-19 05:36:04 +03:00
smoogipoo	f3dbddd75c	Update bindings in LoadComplete()	2020-04-14 15:52:38 +09:00
smoogipoo	b8b334ca27	Always unbind bindings	2020-04-14 15:21:56 +09:00
smoogipoo	3183827329	Reorder fields	2020-04-14 15:09:31 +09:00
smoogipoo	7d2d0785fd	Fix potential unsafe ordering of binds	2020-04-14 15:07:32 +09:00
smoogipoo	9619fb9f6a	Remove bind in Player	2020-04-14 15:00:36 +09:00
Salman Ahmed	9a29797a5b	Use IntervalList<double> for tracking break periods	2020-04-09 23:00:16 +03:00
Dean Herbert	c5005eb378	Adjust gradient size slightly and make const	2020-04-09 14:55:02 +09:00
Dean Herbert	5a78e74470	Use Lerp instead of ValueAt	2020-04-09 14:51:50 +09:00
Dean Herbert	c44957db3f	Change initial health to 1 to avoid false fail display	2020-04-09 14:49:09 +09:00
Dean Herbert	947745d87e	Change fail effect to be less distracting	2020-04-09 14:34:23 +09:00
Dean Herbert	4976f80b71	Move implementation to HUD	2020-04-09 14:31:25 +09:00
Dean Herbert	0e2d5213ce	Merge branch 'master' into low-hp-red-layer	2020-04-09 13:53:57 +09:00
Joehu	0f11ecce01	Make icons container private	2020-04-05 14:53:49 -07:00
Salman Ahmed	7fab07670e	Remove no longer necessary usage of IsBreakTime	2020-04-05 21:35:09 +03:00
Joehu	493b654011	Remove horizontal margin from mod display ... Can skew center alignment on fill flow containers. Fixes affected areas. Vector2(5, 0) is similar to MarginPadding { Left = 10 }.	2020-04-03 11:30:02 -07:00
smoogipoo	1f797207f7	Rework lookups to not require total playfield columns	2020-04-03 12:31:05 +09:00
Lucas A	1562612f41	Update visual tests and remove unessecary XMLDoc tag	2020-04-01 15:12:31 +02:00
Lucas A	ab01111c36	Fix merge conflicts.	2020-03-30 17:39:11 +02:00
Lucas A	3cae0cedee	Add a game setting to disable the layer	2020-03-30 12:59:39 +02:00
Dean Herbert	6e68b968f8	Hide "retry" button on results screen after watching a replay	2020-03-29 23:52:50 +09:00
Dean Herbert	4f5557096c	Fix auto mod results not displaying correctly	2020-03-29 22:51:28 +09:00
Dean Herbert	944926e950	Merge branch 'master' into fix-break-overlay-z-order	2020-03-28 13:04:19 +09:00
Dean Herbert	a317ef65b8	Remove default for argument	2020-03-28 12:18:28 +09:00
Bartłomiej Dach	3a3bfe9a5e	Reorder children to fix pause overlay z-order	2020-03-27 21:19:49 +01:00
Bartłomiej Dach	adc759771f	Hook up score processor in player	2020-03-27 19:47:42 +01:00
Dan Balasescu	5e1cb0e9e9	Merge branch 'master' into fix-minia-mod-replay-recording	2020-03-27 19:26:41 +09:00
Dean Herbert	f75c082601	Fix osu!mania replays recording incorrectly when key mod applied	2020-03-27 15:50:11 +09:00
Lucas A	00c1ff993a	Fix merge conflicts.	2020-03-26 15:48:18 +01:00
Lucas A	c1ac57e70f	Add back visual tests and add easing to alpha fade.	2020-03-26 12:14:44 +01:00
Dean Herbert	07462120e4	Split break tracking into its own component	2020-03-26 15:30:23 +09:00
Dean Herbert	d372ddaadd	Move break overlay to a location it is not affected by gameplay scale	2020-03-26 12:50:18 +09:00
Dean Herbert	800e395bc8	Merge branch 'master' into replay-recording	2020-03-25 20:20:59 +09:00
Dean Herbert	6d81da5419	Merge branch 'master' into video-offset	2020-03-25 11:28:59 +09:00
Dean Herbert	a7bfaad60f	More correctly handle rulesets which don't support replay recording	2020-03-24 15:44:39 +09:00
Dean Herbert	022465f546	Add encoding and import support	2020-03-24 14:51:52 +09:00
voidedWarranties	4bb15a8b93	Allow individual storyboard layers to disable masking	2020-03-23 22:51:37 -07:00
Dean Herbert	617149fb27	Implement in player	2020-03-23 20:06:18 +09:00
Dean Herbert	729e006c3a	Merge branch 'master' into video-offset	2020-03-21 20:03:46 +09:00
Dean Herbert	855f0a4253	Fix bracket style	2020-03-19 14:38:49 +09:00
Dean Herbert	17c3455b36	Fix potentially invalid push in player while already exiting	2020-03-19 14:10:59 +09:00
Lucas A	a4171253a3	Make LowHealthThreshold a field.	2020-03-18 21:45:01 +01:00
Lucas A	e9f224b5e8	Apply review suggestions	2020-03-18 21:16:54 +01:00
Lucas A	a1274a9eb0	Fix and add missing XMLDoc	2020-03-18 08:29:00 +01:00
Lucas A	ed4f9f8ba9	Bind every HealthDisplay on Player load	2020-03-17 22:57:47 +01:00
Lucas A	6b0c5bc65d	Rename to LowHealthLayer to FaillingLayer.	2020-03-17 22:32:07 +01:00
smoogipoo	3628814e4e	Merge branch 'fix-score-population' into results-screen	2020-03-17 17:48:39 +09:00
smoogipoo	1c4296f5e7	Implement the new results screen	2020-03-17 17:43:16 +09:00
smoogipoo	daa5e63d0d	Fix replay scores not being populated via player	2020-03-17 16:42:55 +09:00
Joehu	f7ea20a926	Limit font weight to bold	2020-03-16 16:32:25 -07:00
Lucas A	1aacd1aaa2	Initial implementation of LowHealthLayer	2020-03-16 21:04:59 +01:00
voidedWarranties	c27751050b	Switch back to strings and update setting labels	2020-03-12 23:29:11 -07:00
Dan Balasescu	1d556bfc5f	Merge branch 'master' into video-offset	2020-03-11 15:13:18 +09:00
voidedWarranties	6de244389b	Use OffsetClock instead of ManualClock	2020-03-10 22:50:20 -07:00
Dan Balasescu	5b8035052f	Merge branch 'master' into fix-hit-error-ticks-outside-bounds	2020-03-09 09:16:51 +09:00
voidedWarranties	22dd93a4f6	Code quality, read position offsets	2020-03-08 14:02:39 -07:00
Lucas A	0953751d24	Clamp relative position of judgement ticks in range [0;1]	2020-03-08 15:51:57 +01:00
voidedWarranties	48282dea8b	Remove individual setting to disable videos, fix tests	2020-03-07 22:08:38 -08:00
voidedWarranties	76c832518f	Render video as a part of the storyboard	2020-03-07 21:32:03 -08:00
voidedWarranties	d68d7edea3	Start background video playback based on provided offset	2020-03-07 14:08:13 -08:00
Dean Herbert	fa8e7adf07	Merge branch 'master' into fix-testscene-rate	2020-03-06 22:40:02 +09:00
Dean Herbert	a59c3d997d	Refactor implementation to better match what already existed	2020-03-06 18:00:17 +09:00
Dean Herbert	90dbb90470	Merge branch 'master' into disable-keycounter-breaks	2020-03-06 17:53:10 +09:00
Dean Herbert	ebc86c1075	Fix random test failure	2020-03-06 02:14:16 +09:00
Dan Balasescu	e77cefeabe	Merge branch 'master' into fix-volume-bninding-handling	2020-03-03 16:32:18 +09:00
smoogipoo	2e4adc056f	Fix potential deadlock during gameplay tests	2020-03-03 13:42:05 +09:00
naoey	3d344a076d	Add test for disabled keycounter, don't discard change event values	2020-03-03 06:17:25 +05:30
Dean Herbert	48f2f615cd	Merge branch 'master' into fix-volume-bninding-handling	2020-03-02 19:28:36 +09:00
Dean Herbert	489bf16bea	Add SelectNext and SelectPrevious global actions	2020-03-02 18:55:28 +09:00
Dean Herbert	dc79c11b6a	Merge branch 'master' into layout-rework	2020-03-02 16:36:48 +09:00
naoey	bca58ddb42	Make KeyCounter stop counting during breaks	2020-02-29 21:18:43 +05:30
Dean Herbert	f18a1cde53	Fix crash when reaching results screen on single threaded execution mode	2020-02-29 08:39:27 +09:00
Dean Herbert	ed2bdd7106	Fix stutter when showing game HUD after being hidden for a while	2020-02-26 20:45:57 +09:00
smoogipoo	da89798765	Merge remote-tracking branch 'origin/master' into layout-rework	2020-02-26 15:06:40 +09:00
smoogipoo	6c28fd21c7	osu-side changes	2020-02-24 20:52:15 +09:00
Dean Herbert	0c3286fa5e	Merge branch 'judgement-line-performance' into follow-point-performance	2020-02-23 05:36:22 +09:00
Dean Herbert	560cf21b12	Add lenience to comparison ... Noticed that they could still stack up on maps with hitcircles at the same point in time (centipede).	2020-02-23 05:29:17 +09:00
Dean Herbert	4949977d7e	Merge branch 'judgement-line-performance' into follow-point-performance	2020-02-23 05:14:21 +09:00
Dean Herbert	8dbcdebd28	Use LoadingLayer at player loading screen	2020-02-23 05:00:08 +09:00
Dean Herbert	e8ebb31517	Expire old judgement lines if too many exist	2020-02-23 03:53:51 +09:00
Dean Herbert	3daa49f1bd	Clean up old judgement lines if too many are already present	2020-02-23 03:39:12 +09:00
Dean Herbert	5aa5a1bbdd	Reduce transform time of judgement lines (visually looks almost the same)	2020-02-23 03:36:15 +09:00
Dean Herbert	92f6f0207c	Rename LoadingAnimation to LoadingSpinner	2020-02-21 15:33:31 +09:00
recapitalverb	7c9569c9a3	Merge branch 'master' into remove-duplicated-load	2020-02-15 12:10:34 +07:00
recapitalverb	c753cb46c5	Use [Resolved] wherever possible	2020-02-14 20:14:00 +07:00
Dan Balasescu	851e353093	Merge branch 'master' into fix-player-loader-focused-overlay-interaction	2020-02-14 20:36:38 +09:00
Dan Balasescu	45734f8e8d	Merge branch 'master' into player-loader-code-quality	2020-02-14 19:35:40 +09:00
Dean Herbert	4d4ec3515d	Fix player loading sequence continuing even when a priority overlay is visible	2020-02-14 19:16:08 +09:00
Dean Herbert	2808f8167d	Use more regions	2020-02-14 18:28:58 +09:00
Dean Herbert	b69d1ad678	Reorder and clean up PlayerLoader	2020-02-14 18:22:57 +09:00
Dean Herbert	be30ef3cca	Move BeatmapMetadataDisplay to its own class	2020-02-14 18:13:52 +09:00
Dean Herbert	884a5fbad4	Fix osu! gameplay cursor not adjusting to mod/convert circle size changes	2020-02-14 14:30:15 +09:00
smoogipoo	d4f14e552a	Improve extensibility of mod display expansion	2020-02-13 18:05:53 +09:00
Bartłomiej Dach	9bfd3a1a63	Make PercentageBreakInfoLine use FormatAccuracy	2020-02-08 00:11:19 +01:00
Dean Herbert	b7996f91fc	Update the windows platform offset to match stable	2020-02-07 17:51:38 +09:00
Salman Ahmed	4cd4055e7c	Rename to AlwaysVisible and add XMLDoc	2020-02-03 20:00:43 +03:00
Salman Ahmed	51ed289c59	Revert namings and behaviour changes	2020-02-03 19:59:58 +03:00
Salman Ahmed	351cb8ac1a	Rename Visible to HasReplayLoaded and change default value ... Doesn't make sense to be true by default	2020-02-03 15:47:52 +03:00
Salman Ahmed	4cdf4b223c	Rename to alwaysShow and add XMLDoc	2020-02-02 18:47:12 +03:00
Salman Ahmed	28e340c486	Inherit Container and fade the key flow instead of individual children	2020-02-02 18:46:27 +03:00
Salman Ahmed	6a11c3a8f9	Expose ConfigVisibility bindable for testing purposes	2020-02-02 14:48:07 +03:00
Salman Ahmed	abccf05155	Update visibility of each key counter instead of this container ... For isolating changing visibility of the key counter display based on config and internal values from just fading the container.	2020-02-02 14:47:14 +03:00
Dean Herbert	bea20efb64	Merge branch 'master' into mod_content_centering	2020-01-30 10:34:46 +09:00
Bartłomiej Dach	c9dda78ded	Refactor drawable hierarchy to center properly ... * Use FillFlowContainer.Spacing instead of manually applying margins. * Use Update() for calculating button padding to preserve it after mod button expansion and adjust FooterButtonRandom to use this method while avoiding flickering. * Expose mod display margin to clear it in the footer button.	2020-01-29 18:59:51 +01:00
unknown	aa264cd2a8	allow tooltip to show as percentage as needed	2020-01-28 12:32:30 +08:00
Dean Herbert	997b49f6dc	Change display to always show progress bar, only hiding seeking handle instead	2020-01-24 14:21:22 +09:00
Dean Herbert	da65fff48e	Merge remote-tracking branch 'upstream/master' into collapse-graph-option	2020-01-24 13:55:42 +09:00
Dean Herbert	eb5abcab8c	Rename and simplify circle logic	2020-01-24 12:01:40 +09:00
Dean Herbert	851b891285	Fix incorrect insert logic	2020-01-24 12:01:14 +09:00
Dean Herbert	c390348eab	Merge remote-tracking branch 'upstream/master' into colour-score-meter	2020-01-24 11:45:33 +09:00
Dean Herbert	8a7f7c5e46	Merge remote-tracking branch 'smoogipoo/void-key-up-returns' into update-framework	2020-01-22 22:57:56 +09:00
Dean Herbert	7c62cc3ac3	Merge remote-tracking branch 'smoogipoo/void-mouse-up-returns' into update-framework	2020-01-22 22:57:52 +09:00
smoogipoo	7b2f58eb30	Apply OnRelease method signature refactorings	2020-01-22 13:22:34 +09:00
smoogipoo	40f502c6d1	Apply input method signature refactorings	2020-01-20 19:35:37 +09:00
smoogipoo	1b1003bd73	Refactor	2020-01-20 18:31:25 +09:00
smoogipoo	bfb056c612	Apply input method signature refactorings	2020-01-20 18:17:21 +09:00
Dan Balasescu	03c778df75	Merge branch 'master' into update-framework	2020-01-09 19:02:26 +09:00
smoogipoo	91735ff367	Update MathUtils namespace usages	2020-01-09 13:43:44 +09:00
Bartłomiej Dach	f0fe3bc804	Pass bindable to BeatmapMetadataDisplay ... It was reported that mods selected in song select would show up during loading of replays which were recorded under a different set of mods. This was caused by BeatmapMetadataDisplay accepting a plain read-only value of the Mods bindable in PlayerLoader.load(), therefore making the mod value assignment in ReplayPlayerLoader.OnEntering() have no effect on that component. To resolve this issue, make BeatmapMetadataDisplay accept the higher-level bindable, bind to it locally and pass it down the hierarchy to ModDisplay.	2020-01-08 20:10:43 +01:00
Bartłomiej Dach	a3f7d3c445	Add failing test ... Add test case demonstrating the lack of update of the metadata display's mods upon setting the Mods property in PlayerLoader.	2020-01-08 19:55:35 +01:00
Dean Herbert	ca862124a5	Fix replay import from main menu causing a hard crash	2019-12-27 19:36:48 +09:00
Dean Herbert	b330aec03e	Drain starting at the first hitobject, not gameplay start	2019-12-27 16:16:30 +09:00
Dean Herbert	cac011edc1	Merge branch 'master' into hp-drain	2019-12-26 23:51:12 +09:00
Dean Herbert	033bb15500	Fix early-escape not continuing to results screen (#7362) ... Fix early-escape not continuing to results screen	2019-12-26 23:50:21 +09:00
Dean Herbert	a041f32072	Use cleaner solution via cancellation of older schedule	2019-12-26 19:05:32 +09:00
smoogipoo	8903f286ef	Fix escape not continuing to results screen	2019-12-26 18:27:48 +09:00
smoogipoo	522847987b	Implement break/gameplay start times	2019-12-26 15:00:58 +09:00
smoogipoo	b348abcd07	Only drain health in non-break times	2019-12-26 14:59:49 +09:00
smoogipoo	977fb3d1bf	Make processors and break overlay frame-stable	2019-12-26 14:59:49 +09:00
smoogipoo	a4b1c79e18	Initial implementation of HP drain	2019-12-26 14:59:49 +09:00
smoogipoo	90cb9d9162	Simplify scoreprocesor/healthprocessor implementations	2019-12-26 14:59:49 +09:00
smoogipoo	7414a6aadd	Merge remote-tracking branch 'huoyaoyuan/master' into health-processor ... # Conflicts: # osu.Game.Rulesets.Catch/CatchRuleset.cs # osu.Game.Rulesets.Mania/ManiaRuleset.cs # osu.Game.Rulesets.Taiko/TaikoRuleset.cs	2019-12-26 14:56:54 +09:00
smoogipoo	c7936e40d5	Protect against potential nullref	2019-12-23 19:13:36 +09:00
Andrei Zavatski	7a0d76ae77	Fix nullref	2019-12-22 03:41:19 +03:00
Andrei Zavatski	aded12af9e	Refactoor to avoid bindable usage	2019-12-22 03:30:17 +03:00
Andrei Zavatski	eb75c6c70f	Update FadeIn animation for new judgement	2019-12-22 03:17:56 +03:00
Andrei Zavatski	46501cf0ac	Use FillFlowContainer	2019-12-22 03:06:57 +03:00
Andrei Zavatski	14a77a8f16	Improve animations	2019-12-21 16:08:28 +03:00
Andrei Zavatski	b61aa660c6	Move colours to HitErrorMeter class	2019-12-21 14:52:53 +03:00
Andrei Zavatski	5e3c3f2a90	Make judgements work	2019-12-21 14:30:41 +03:00
Andrei Zavatski	5b115d8d8a	Implement basic logic	2019-12-21 13:41:50 +03:00
Salman Ahmed	7d090d6cd9	Fix key overlay appearing regardless of the setting	2019-12-19 17:52:58 +03:00
smoogipoo	76f2fb378f	Separate score and health parts of ScoreProcessor	2019-12-19 20:03:14 +09:00
Dean Herbert	e0ce87adca	Move CreateScoreProcessor() to Ruleset (#7244) ... Move CreateScoreProcessor() to Ruleset	2019-12-17 22:15:42 +09:00
Dan Balasescu	fd2785bab3	Merge branch 'master' into fxcop	2019-12-17 20:14:45 +09:00
smoogipoo	49bf8d27d1	Move CreateScoreProcessor() to Ruleset	2019-12-17 20:08:13 +09:00
Huo Yaoyuan	d5994ed484	CA2208: create exceptions correctly.	2019-12-17 13:00:10 +08:00
Huo Yaoyuan	ecfc6dfa3d	CA1825: use Array.Empty.	2019-12-17 12:59:48 +08:00
Dean Herbert	b5db927d93	Merge branch 'master' into cinema-mod	2019-12-17 12:56:06 +09:00
smoogipoo	6cf318c34b	Merge remote-tracking branch 'refs/remotes/origin/master' into improve-hud-hiding	2019-12-16 18:41:21 +09:00
smoogipoo	a276643a4b	Reorder health display and score elements	2019-12-16 18:41:14 +09:00
smoogipoo	83f77d9c35	Make the layout faster	2019-12-16 18:41:02 +09:00
Dean Herbert	59538bfd32	Merge branch 'global-available-mods' into adjustable-rate-mods	2019-12-13 21:57:27 +09:00
Dean Herbert	7559012fb7	Merge remote-tracking branch 'upstream/master' into lighten-playfield-during-breaks	2019-12-12 19:55:09 +09:00
Dean Herbert	d15f49f60f	Also hide the break overlay	2019-12-12 16:13:02 +09:00
Dean Herbert	37a94988a3	Merge branch 'improve-hud-hiding' into cinema-mod	2019-12-12 16:12:19 +09:00
Dean Herbert	94f3dbb2f6	Adjust transitions slightly	2019-12-12 16:09:50 +09:00
Dean Herbert	3ccfee64f6	Add HUDOverlay tests	2019-12-12 16:09:42 +09:00
smoogipoo	5861eca80d	Make DrawableRuleset take a converted beatmap	2019-12-12 15:58:11 +09:00
Dean Herbert	ffb5cdc6ae	Hide settings overlay along with other HUD-hidden content	2019-12-12 15:20:42 +09:00
Dean Herbert	ad2528d4d2	Hide key counter along with other hud elements ... Also tidies up HUD hide logic and protects against incorrect hiding.	2019-12-12 15:19:45 +09:00
Dean Herbert	9961fa7385	Merge branch 'master' into adjustable-rate-mods	2019-12-12 15:10:23 +09:00
Dean Herbert	a93d57b77e	Merge branch 'master' into lighten-playfield-during-breaks	2019-12-12 11:57:21 +09:00
Dean Herbert	d2ada90434	Merge branch 'master' into single-scoreprocessor	2019-12-12 11:36:45 +09:00
Albie	4a1c6db3ed	Merge branch 'master' into cinema-mod	2019-12-11 18:00:17 +00:00
Dan Balasescu	b77f9504d0	Merge branch 'master' into adjustable-rate-mods	2019-12-11 19:28:59 +09:00
smoogipoo	48f1dad4aa	Remove abstract ScoreProcessor class	2019-12-11 17:25:06 +09:00
Dean Herbert	75f9250645	Don't automatically pause when window is inactive if in break time	2019-12-11 15:46:07 +09:00
Dean Herbert	9ebad16436	Fix logic regression	2019-12-11 14:37:10 +09:00
Dean Herbert	77b9989e11	Fix some weird private field names	2019-12-11 14:10:35 +09:00
Salman Ahmed	53daa37eaa	Fix failing tests	2019-12-10 23:06:13 +03:00
Albie	a61f8cc2c3	Merge branch 'master' into cinema-mod	2019-12-10 17:06:53 +00:00
Salman Ahmed	38f1a8bc17	Bind UserDimContainer.IsBreakTime from Player	2019-12-10 15:14:47 +03:00
Dean Herbert	7fd52c21f5	Update mods and user adjust to use adjustments	2019-12-09 19:41:31 +09:00
Dean Herbert	d650bfb6d6	Remove unnecessary cast	2019-12-09 18:05:14 +09:00
Dean Herbert	eb074b7058	Allow mods to apply to track, not clock	2019-12-09 17:44:45 +09:00
Dan Balasescu	54798b134e	Add accessibility modifiers	2019-12-08 03:16:41 +09:00
Dean Herbert	48c6279e8b	Only undo adjustments in GameplayClockContainer if applied at least once	2019-12-06 13:49:22 +09:00
Dean Herbert	de23364608	Add failing test	2019-12-06 13:47:34 +09:00
Albie	7864899249	Merge branch 'master' into cinema-mod	2019-11-28 16:42:01 +00:00
smoogipoo	f504370867	Make player block exit if pausable	2019-11-28 15:58:26 +09:00
Dan Balasescu	c6a85a11bd	Merge branch 'master' into sharpen	2019-11-27 17:09:11 +09:00
Huo Yaoyuan	eba8657d38	Remove newly introduced redundant this.	2019-11-26 18:41:19 +08:00
Huo Yaoyuan	c0fe91a84c	Merge branch 'master' into sharpen	2019-11-26 18:21:50 +08:00
Albie	09158b6b08	Merge branch 'master' into cinema-mod	2019-11-26 06:57:47 +00:00
Dean Herbert	77ce9642ba	Add test coverage and simplify break time updating	2019-11-26 15:32:48 +09:00
Dean Herbert	a453129d44	Fix nullref in tests	2019-11-26 15:13:50 +09:00
Dan Balasescu	8a8e863c0e	Merge branch 'master' into intro-outro-break	2019-11-26 12:47:42 +09:00
Dean Herbert	fbebbab5db	Remove excess parenthesis	2019-11-25 22:37:07 +09:00
Dean Herbert	709ec1404f	Centralise End/StartTime retrieval to extension method	2019-11-25 19:09:14 +09:00
Dean Herbert	6b8983b489	Consider intro and outro time as "break" time	2019-11-25 19:02:11 +09:00
Albie	9fdbb2a58e	change name of interface and expose method instead of seperate values	2019-11-25 07:24:29 +00:00
Albie	9a8e3fe1da	add brackets	2019-11-24 07:44:35 +00:00
Albie	1d6665fe57	improve code quality using resharper and codefactor advice	2019-11-24 07:42:39 +00:00
Albie	b8e5796af5	add forced video/storyboard and disabled dim for mod inside new interface	2019-11-24 07:37:06 +00:00
Dean Herbert	83080c3b5f	Fix merge regression	2019-11-22 14:14:18 +09:00
Dan Balasescu	5d2a608be0	Merge branch 'master' into lead-in-fixes	2019-11-22 13:48:55 +09:00
Huo Yaoyuan	818553027b	Merge branch 'master' into sharpen	2019-11-21 23:42:46 +08:00
Dean Herbert	bd6831624a	Decouple skip button animations from gameplay clock	2019-11-21 19:51:22 +09:00
Dean Herbert	ffd0e17826	Merge branch 'skip-multiple-times' into lead-in-fixes	2019-11-21 19:01:28 +09:00
Dean Herbert	46a94821d4	Add support for consecutive skips	2019-11-21 18:59:55 +09:00
Dean Herbert	29d2374928	Add back skip button actuation count tests	2019-11-21 17:23:52 +09:00
Dean Herbert	2dd2e3d861	Add correct AudioLeadIn support	2019-11-21 16:55:18 +09:00
Dean Herbert	8369be90f2	Allow skip button to actuate more than once	2019-11-21 15:19:06 +09:00
Dean Herbert	c0b9bb5a12	Merge remote-tracking branch 'upstream/master' into lead-in-fixes	2019-11-21 14:22:17 +09:00
Berkan Diler	6cab517b2d	.NET Standard 2.1 implements Math.Clamp , use it instead of MathHelper.Clamp from osuTK.	2019-11-20 13:37:47 +01:00
Huo Yaoyuan	374ef6ff83	Merge branch 'master' into sharpen	2019-11-20 17:30:58 +08:00
Dean Herbert	eee5902851	Merge remote-tracking branch 'upstream/master' into lead-in-fixes	2019-11-15 14:05:31 +09:00
Huo Yaoyuan	87d40cf8d0	Resolve equals usages.	2019-11-13 22:35:50 +08:00
Huo Yaoyuan	7d7b9e36b2	Use compound assignment.	2019-11-12 19:53:50 +08:00
Huo Yaoyuan	ccc8aa6fa4	Apply brace style.	2019-11-11 20:13:13 +08:00
Dean Herbert	cd1dd0f898	Fix adjustments not being removed correctly on retry from pause	2019-11-06 10:38:04 +09:00
Dean Herbert	6dde755ef2	Merge branch 'master' into add-retry-button	2019-11-02 21:23:16 +09:00
Dean Herbert	fd13f0bc55	Move ReplayDownloadButton to correct namespace (#6689) ... Move ReplayDownloadButton to correct namespace	2019-11-02 21:22:23 +09:00
Dean Herbert	551032803d	Fix GameplayClockContainer operating on beatmap's track after s… (#6688) ... Fix GameplayClockContainer operating on beatmap's track after screen exited	2019-11-02 21:22:13 +09:00
Dan Balasescu	8a5d3ab40a	Merge branch 'master' into add-retry-button	2019-11-02 10:51:14 +09:00
Dean Herbert	daa0ebe2b5	Add xmldoc	2019-11-01 15:51:45 +09:00
Dean Herbert	14453da1d2	Centralise MakeCurrent call	2019-11-01 15:51:10 +09:00
Dean Herbert	84d17f3702	Add retry button	2019-11-01 15:41:51 +09:00
Dean Herbert	14fec6f1f3	Move ReplayDownloadButton to correct namespace	2019-11-01 15:06:36 +09:00
Dean Herbert	dcc8f6e827	Better group cancel conditional	2019-11-01 14:43:52 +09:00
Dean Herbert	d089e47a56	Merge branch 'master' into master	2019-11-01 14:15:57 +09:00
Dean Herbert	ac02bb005d	Fix GameplayClockContainer operating on beatmap's track after scren exited	2019-11-01 14:11:18 +09:00
Dean Herbert	3f192ca915	Fix song progress not displaying correctly (#6640) ... Fix song progress not displaying correctly Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2019-10-29 18:16:54 +09:00
Dean Herbert	46b44f4f99	Fix PlayerSettingsOverlay being shown by default	2019-10-28 18:37:58 +09:00
Dean Herbert	16e33e8bc7	Fix song progress not displaying correctly	2019-10-28 18:34:58 +09:00
nwabear	b0e21c2749	Fixed Issue #6442	2019-10-25 14:57:49 -05:00
smoogipoo	851773a842	Apply adjustments for framework changes	2019-10-23 14:04:06 +09:00
Joehu	ccc753a315	Make OverlayContainers with no blocking input VisibilityContainers	2019-10-14 16:27:59 -07:00
Dean Herbert	51bf600ea7	Use empty hitwindows instead of null	2019-10-09 19:08:31 +09:00
Dean Herbert	47c1f36f9d	Add ValidForResume check	2019-10-04 11:41:53 +08:00
Dean Herbert	71985c7ef1	Update fail logic to match	2019-10-04 11:23:42 +08:00
Joseph Madamba	d87f6d270b	Merge branch 'master' into fix-alt-f4-being-blocked-by-overlays	2019-10-03 08:43:31 -07:00
smoogipoo	636913a4a6	Refactor PlayerLoader changes	2019-10-03 19:22:41 +09:00
Joehu	a69b9f1148	Fix alt-f4 being blocked during gameplay	2019-10-02 11:16:31 -07:00
Craftplacer	4d4e846296	Merge branch 'master' into muted-notification	2019-10-02 17:31:34 +02:00
Craftplacer	6929847b08	Remove redundant override	2019-10-02 17:22:34 +02:00
HDragonHR	faf8fe132e	Change bindable int to float	2019-10-02 12:26:46 +08:00
Craftplacer	5f399add82	Resolve @iiSaLMaN 's suggested changes	2019-10-01 18:15:40 +02:00
Craftplacer	2ac5e0bfa0	Make use of SessionStatics	2019-10-01 17:39:01 +02:00
Dean Herbert	02c1f490f1	Merge branch 'master' into muted-notification	2019-09-28 20:33:32 +08:00
Dean Herbert	f4f5a7e9c8	Fix test regressions	2019-09-27 13:20:17 +08:00
Dean Herbert	b50ef8ffa4	Allow null NotificationManager	2019-09-27 13:15:33 +08:00
iiSaLMaN	2670a23e6f	Assign to field and move to load complete	2019-09-27 08:15:24 +03:00
iiSaLMaN	7904f77cd5	Bind event to activation delay change	2019-09-27 02:59:42 +03:00
iiSaLMaN	911094e790	Replace menu button text with "press for menu" on 0ms activation delay	2019-09-26 01:42:56 +03:00
Dean Herbert	f11156c2dc	Fix tests not working correctly	2019-09-25 19:30:25 +09:00
Craftplacer	9a687ae8e2	Merge branch 'master' into muted-notification	2019-09-23 01:59:37 +02:00
smoogipoo	db24cfbead	Merge remote-tracking branch 'origin/master' into auto-restart-mod-perfect ... # Conflicts: # osu.Game/Screens/Play/Player.cs	2019-09-19 17:57:04 +09:00
smoogipoo	c76e27549a	Remove spacing	2019-09-19 14:56:52 +09:00
iiSaLMaN	da4d83063e	Simplify LINQ expression	2019-09-19 08:31:11 +03:00
iiSaLMaN	e793854735	Invert BypassFail usage	2019-09-19 08:00:41 +03:00
iiSaLMaN	9de0bcae1e	Check for blocking fail mods by default	2019-09-19 07:58:54 +03:00
Craftplacer	c3221e1a36	Prepare classes for player loader test scene	2019-09-18 23:27:26 +02:00
iiSaLMaN	775b90e066	Bypass fail on replays	2019-09-18 22:49:48 +03:00
iiSaLMaN	ecd721e8c5	Add bypass fail property to Player	2019-09-18 22:49:28 +03:00
Dean Herbert	2fcc8c2d72	Simplify implementation, play fail animation during restart	2019-09-19 01:45:59 +09:00
Dean Herbert	ff3a7c1d13	Merge remote-tracking branch 'upstream/master' into auto-restart-mod-perfect	2019-09-19 01:36:29 +09:00
Dean Herbert	ec5f420818	Merge branch 'master' into key-counter-fixes	2019-09-17 22:56:34 +09:00
Dean Herbert	77947e8309	Fix rewind tests failing	2019-09-17 22:33:27 +09:00
Dean Herbert	38d85e44be	Merge branch 'master' into key-counter-fixes	2019-09-17 22:33:15 +09:00
smoogipoo	f0bcb2b933	Debounce user-requested replay seeks	2019-09-17 16:12:18 +09:00
Craftplacer	220fdd0a04	Make muteWarningShownOnce static ... ... so it will actually get an instance per osu session.	2019-09-16 06:56:52 +02:00
Craftplacer	cb033591c4	Merge branch 'master' into muted-notification	2019-09-15 17:59:27 +02:00
Craftplacer	ecce12981e	Use block body for constructor to fix remaining code inspection issue	2019-09-15 17:47:44 +02:00
Craftplacer	e3884658af	Resolve code inspection errors	2019-09-15 17:36:53 +02:00
Dean Herbert	2381b4c003	Move video behind storyboard	2019-09-16 00:20:56 +09:00
Craftplacer	ec788ac09d	Make notification only show up once per session	2019-09-15 17:20:07 +02:00
Craftplacer	811a08d18f	Use Bindable instead of bool	2019-09-15 16:50:01 +02:00
Craftplacer	00e46fdefe	Add check if game is muted by MuteButton	2019-09-15 16:32:23 +02:00
Craftplacer	4a10e6c44e	Use ResolvedAttribute for NotificationOverlay	2019-09-15 16:11:45 +02:00
Craftplacer	78931c8e23	Implement notification when user has track or master volume muted ... This took around under a hour to implement, it has the same behavior and content from osu!stable. A notification will show up when the user has either its master or track volume set to the minimum, clicking it will set it to the default values.	2019-09-15 15:59:46 +02:00
Andrei Zavatski	9febeb1f3d	Add black background	2019-09-14 06:32:00 +03:00
Andrei Zavatski	a36c808682	Use Fit FillFode	2019-09-14 06:28:59 +03:00
Andrei Zavatski	9a94405b3a	Fix video playback is stretched on client resize	2019-09-14 06:05:09 +03:00
Dan Balasescu	b10ce0b12d	Merge branch 'master' into key-counter-fixes	2019-09-13 19:43:33 +09:00
Andrei Zavatski	437e121056	Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-video	2019-09-13 13:39:58 +03:00
smoogipoo	cf2f841b4d	Fix player not correctly exiting after an unpause	2019-09-13 15:42:58 +09:00
Dean Herbert	831d04f339	Don't use gameplay clock in KeyCounter	2019-09-12 15:48:07 +09:00
Dean Herbert	0cdf125c1e	Handle key counter rewinding in a better way ... Use ElapsedFrameTime rather than storing state data	2019-09-12 15:42:14 +09:00
Dean Herbert	cb0cf6e2c5	Remove reset functions	2019-09-12 14:27:52 +09:00
Dean Herbert	158737e001	Remove FadeTime customisation ... Also adjusts fade transitions to feel better, especially in fast forward scenarios.	2019-09-12 14:27:29 +09:00
Dean Herbert	f9c969788a	Fix keys not reaching full brightness as soon as they should	2019-09-12 13:56:23 +09:00
Dean Herbert	3a18e9907b	Merge branch 'master' into ingame-leaderboard-general-implementation	2019-09-11 22:32:53 +09:00
Dean Herbert	88d0756107	Allow global actions to propagate through pause screen	2019-09-06 17:17:30 +09:00
Dean Herbert	f925e781a9	Refactor HitWindows for legibility	2019-09-06 15:24:14 +09:00
Dean Herbert	986ac08397	Fix pause menu keyboard navigation being affected by initial cu… (#6002) ... Fix pause menu keyboard navigation being affected by initial cursor hover	2019-09-05 17:27:48 +09:00
Dean Herbert	a1d7291ffa	Fix pause menu keyboard navigation being affected by initial cursor hover	2019-09-05 16:31:10 +09:00
smoogipoo	a87a1e6031	Don't redraw certain buffered containers on scale change	2019-09-04 19:38:12 +09:00
Dean Herbert	1802d2efaf	Merge remote-tracking branch 'upstream/master' into fix-gameplay-menu-button-hover-ani	2019-09-04 10:35:14 +09:00
Dean Herbert	4cad55cee6	Move hit windows lookup to DrawableRuleset	2019-09-03 13:05:03 +09:00
smoogipoo	0c73c5acf3	Expose full hitobject rather than hit windows	2019-09-02 17:14:40 +09:00
smoogipoo	f2bdf94a1d	Add HitWindows to JudgementResult to indicate timing errors	2019-09-02 16:28:14 +09:00
smoogipoo	0a89603e79	Fix hit error potentially not displaying with null hitwindows	2019-09-02 16:07:16 +09:00
Dean Herbert	7ca51d3866	Fix resume overlay being drawn below cursor ... Closes #5905.	2019-09-02 11:20:55 +09:00
Andrei Zavatski	94512fea8e	Apply naming suggestions	2019-08-31 16:20:33 +03:00
Andrei Zavatski	d2f7a653a8	Fix nullref	2019-08-31 16:10:07 +03:00
Andrei Zavatski	28b19e8d54	Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-video	2019-08-31 15:49:21 +03:00
Dean Herbert	1ddf292ad6	Fix vertical alignment of hit error display ticks ... Wasn't correctly centered before.	2019-08-31 12:20:50 +09:00
Andrei Zavatski	d4291556ee	Remove unused using	2019-08-31 02:57:14 +03:00
Andrei Zavatski	fd958ec1ab	Remove unused property accessor	2019-08-31 02:56:41 +03:00
Andrei Zavatski	fa3591e5ec	Add setting to turn on/off the video	2019-08-31 00:42:20 +03:00
Andrei Zavatski	5dd688a51b	Fix video doesn't use gameplay clock	2019-08-31 00:09:23 +03:00
Andrei Zavatski	d55be4d59c	Implement DimmableVideo component	2019-08-30 23:48:38 +03:00
Andrei Zavatski	58a0b4e19b	Add basic layout for player	2019-08-30 23:19:55 +03:00
Dean Herbert	8f5dc06d55	Merge remote-tracking branch 'upstream/master' into accuracy-bar	2019-08-30 20:18:25 +09:00
Dean Herbert	f1db6c7039	Fix likely nullref	2019-08-30 20:18:21 +09:00
smoogipoo	fc813347ac	Make JudgementLine private	2019-08-30 19:54:36 +09:00
smoogipoo	dfccc60361	Reorder HitErrorDisplay	2019-08-30 19:53:38 +09:00
smoogipoo	fab12fa9cd	Centre align the icons ... Seems to look better this way.	2019-08-30 19:53:38 +09:00
Dean Herbert	665fc95d49	Handle no hitobjects / no hitwindows (osu!catch)	2019-08-30 19:37:20 +09:00
Dean Herbert	80671cefd7	Final visual polish	2019-08-30 19:14:07 +09:00
Dean Herbert	c3abf0ccb7	Improve visuals	2019-08-30 18:50:38 +09:00
Dean Herbert	8fc177b743	Fix namespacing and hitwindow source	2019-08-30 18:46:42 +09:00
Dean Herbert	741bd0a5cf	Fix incorrect colour sizes and simplify alignment specification	2019-08-30 18:35:17 +09:00
Dean Herbert	54696eef39	Reverse display, add animation and reduce width	2019-08-30 17:06:23 +09:00
Dean Herbert	a73d672c2f	Tidy up judgement line logic (and fix it displaying at the wrong place)	2019-08-30 16:40:39 +09:00
Dean Herbert	6640161bc1	Simplify event propagation	2019-08-30 15:51:36 +09:00
Dean Herbert	bdbfa7bd2f	Fix class naming	2019-08-30 15:32:47 +09:00
Dean Herbert	835ee0aa2f	Code quality fixes	2019-08-30 15:29:13 +09:00
Joehu	73fd3cf03c	Fix gameplay menu button initial hover animation	2019-08-28 19:00:01 -07:00
Dean Herbert	7aeeb65ae7	Tidy up Player's container loading logic ... Fixes drawable ruleset being loaded before skin sources are finished, by loading them as a separate operation (to avoid children being loaded first).	2019-08-27 18:27:21 +09:00
Dean Herbert	5e362d10b1	Add ruleset-specific legacy skin providers ... This moves implementation of osu! skinnables to OsuLegacySkin.	2019-08-26 12:21:49 +09:00
Andrei Zavatski	0ccfaeb8d9	Simplify moving average	2019-08-21 10:13:59 +03:00
Andrei Zavatski	a5acc913ea	CI fixes	2019-08-21 09:58:47 +03:00
Andrei Zavatski	a994ad9c84	Use moving average to calculate arrow position	2019-08-21 09:40:15 +03:00
Andrei Zavatski	71cbc3525d	Add/remove displays only if necessary	2019-08-21 09:16:09 +03:00
Andrei Zavatski	f72edb8bf8	Add missing blank line	2019-08-20 09:03:31 +03:00
Andrei Zavatski	596ee150c6	Add xmldoc for not obvious const	2019-08-20 08:51:41 +03:00
Andrei Zavatski	9f64e09625	Move HitErrorDisplayOverlay back to the HUD	2019-08-20 08:45:51 +03:00
Andrei Zavatski	d337f9b482	DefaultHitErrorDisplay -> BarHitErrorDisplay	2019-08-20 08:03:17 +03:00
Andrei Zavatski	c4251d512e	Simplify bar building	2019-08-20 08:00:09 +03:00
Andrei Zavatski	415f180261	Delete extra semicolon	2019-08-19 22:53:28 +03:00
Andrei Zavatski	50c47568e4	Don't present Meh hit windows if it has no value	2019-08-19 22:45:27 +03:00
Andrei Zavatski	f1c3a60660	Add ability to select side	2019-08-19 22:04:27 +03:00
Andrei Zavatski	1bff103d32	CI fixes	2019-08-19 21:25:14 +03:00
Andrei Zavatski	6d3aa0520b	Make HitErrorDisplay an abstract class	2019-08-19 20:44:06 +03:00
Andrei Zavatski	70084b5553	Move HitErrorDisplay outside of the HUD	2019-08-19 20:28:03 +03:00
Andrei Zavatski	4c817b18b7	Use direct cast	2019-08-18 17:03:11 +03:00
Andrei Zavatski	dd6351b8ca	Apply suggested changes	2019-08-18 16:51:16 +03:00
Andrei Zavatski	6c60db550f	Fix crash if ruleset has no Meh hit windows	2019-08-18 16:24:13 +03:00
Andrei Zavatski	55cd1cecdf	Add missing blank line	2019-08-18 15:53:42 +03:00
Andrei Zavatski	8740ebd13f	Simplify layout	2019-08-18 15:45:18 +03:00
Andrei Zavatski	a59a14c9e6	Add setting to enable/disable hit error visibility	2019-08-18 15:01:04 +03:00
Andrei Zavatski	ee5568e596	Use Queue instead of List for stored Judgements	2019-08-18 14:43:34 +03:00
Andrei Zavatski	50133ba863	naming adjustments	2019-08-18 02:57:12 +03:00
Andrei Zavatski	906984ad95	Fix the math	2019-08-18 02:49:07 +03:00
Andrei Zavatski	f7024b513e	Visual improvements	2019-08-18 01:43:43 +03:00
Andrei Zavatski	94dbd6386f	Merge remote-tracking branch 'refs/remotes/ppy/master' into accuracy-bar	2019-08-18 01:14:27 +03:00
Dean Herbert	d0f2d22995	Merge branch 'master' into fix-storyboard-not-shown-on-disabled-user-dim	2019-08-12 05:46:15 +09:00
Andrei Zavatski	e7964c165f	Make judgement lines alive for a bit longer	2019-08-11 19:09:50 +03:00
Andrei Zavatski	3136d46c7f	Do not generate new judgement line on miss	2019-08-11 19:04:56 +03:00
Andrei Zavatski	5e0ac28ca8	Add basic colours	2019-08-11 18:30:03 +03:00
Andrei Zavatski	177a317a48	rename AccuracyBar to HitErrorDisplay	2019-08-11 18:11:49 +03:00
Andrei Zavatski	2a35c3c3e2	Calculate real position for judgement lines	2019-08-11 18:04:54 +03:00
Andrei Zavatski	0a255fe4d1	Add moving arrow	2019-08-11 16:38:03 +03:00
Andrei Zavatski	ed409d113b	Add judgement lines generator	2019-08-11 15:53:15 +03:00
Andrei Zavatski	fd334e0319	Implement basic layout for AccuracyBar	2019-08-11 14:57:21 +03:00
Dean Herbert	90b1fe81f3	Update cached usage in line with framework changes	2019-08-09 19:12:29 +09:00
iiSaLMaN	0fcc6c1676	Add DimLevel property	2019-08-08 22:13:48 +03:00
iiSaLMaN	bedb744a2e	Add parentheses	2019-08-08 17:11:26 +03:00
iiSaLMaN	88b9942b2a	Move EnableUserDim check to defualt value of ShowDimContent	2019-08-08 17:07:06 +03:00
Dean Herbert	2172c5a52b	Merge branch 'master' into use-bindable-break-time-in-player	2019-08-08 14:24:52 +09:00
Dean Herbert	7d42561da9	Remove linq usage in BreakOverlay update	2019-08-08 12:58:20 +09:00
Salman Ahmed	3f9f9e7bc9	Merge branch 'master' into use-bindable-break-time-in-player	2019-08-08 05:36:45 +03:00
Dean Herbert	99f5ca07ce	Remove redundant comment	2019-08-08 10:42:54 +09:00
Dean Herbert	40a33b3382	Move IsLoaded check to more correct place	2019-08-08 10:41:23 +09:00
Dean Herbert	a2e3ab6463	Merge branch 'master' into add-bindable-for-break-times	2019-08-08 10:13:14 +09:00
iiSaLMaN	ba269a49ee	Expose break fade duration and add it in the calculation	2019-08-07 16:59:35 +03:00
iiSaLMaN	d3657d82cd	Simplify final check for break time	2019-08-07 16:28:16 +03:00
iiSaLMaN	c2b3c28c79	Use IsBreakTime for checking if currently in a break ... Rather than iterating over all breaks to find which is in current time	2019-08-07 16:15:53 +03:00
Dean Herbert	dda078277a	Minor variable name changes	2019-08-06 23:05:12 +09:00
iiSaLMaN	2a68bb2749	onCompletionEvent -> pushResults	2019-08-06 14:11:43 +03:00
iiSaLMaN	dd701eaa62	Safely cancel the completion task on restart or immediate exit	2019-08-06 14:10:03 +03:00
iiSaLMaN	fdd00c0820	Remove position fading ... Unnecessary effect	2019-08-04 18:35:53 +03:00
iiSaLMaN	91f35dde58	Actual fix of position declaring bug	2019-08-04 18:27:49 +03:00
iiSaLMaN	9325c024bb	Add InitialPosition field	2019-08-04 18:26:01 +03:00
iiSaLMaN	5e4e150330	Use normal Action	2019-08-04 18:20:45 +03:00
iiSaLMaN	7675c679db	Fix reordering not declaring new position properly ... Small bug fix	2019-07-31 16:09:40 +03:00
iiSaLMaN	e6e315e07b	Expose current break index	2019-07-30 13:29:41 +03:00
iiSaLMaN	32498d5d50	Add xmldocs and return score items. ... Return for usage in later PR	2019-07-30 12:35:49 +03:00
iiSaLMaN	4874746525	Add OnScoreChange event ... For use in scrolling system on a later PR	2019-07-30 12:32:12 +03:00
iiSaLMaN	d467dd5747	Add simple implementation of in-game leaderboard	2019-07-29 06:51:44 +03:00
iiSaLMaN	5bf0277fd4	Remove unnecessary quick check ... Not saving for anything	2019-07-28 09:17:13 +03:00
iiSaLMaN	1dd3a66300	Remove unnecessary index resets	2019-07-28 09:16:19 +03:00
iiSaLMaN	95b568eb46	Remove unnecessary condition	2019-07-27 15:52:30 +03:00
iiSaLMaN	6c580ac9d5	Use while loops instead	2019-07-27 15:52:01 +03:00
Salman Ahmed	934439e138	Merge branch 'master' into add-bindable-for-break-times	2019-07-26 12:57:52 +03:00
iiSaLMaN	4c9e8527d8	Modify global index directly in the for loop ... Moves the global index to a near break if not in a break yet	2019-07-26 09:24:53 +03:00
iiSaLMaN	5a94a22314	Add a quick check if we're not in a break with current index	2019-07-26 09:17:39 +03:00
iiSaLMaN	3fa6804501	Use better loops for moving index ... Easy to read, suggested by peppy	2019-07-26 08:12:32 +03:00
iiSaLMaN	806d41daf4	Add function to reset break index	2019-07-26 08:11:13 +03:00
iiSaLMaN	91fa8a6552	Simplify null and any check	2019-07-26 08:09:18 +03:00
iiSaLMaN	44895c4b69	Use IReadOnlyList for break periods list	2019-07-26 05:41:10 +03:00
iiSaLMaN	b4c93b1777	Use lookup direction than 2 while loops	2019-07-26 05:11:01 +03:00
iiSaLMaN	a08d54eb06	Remove unnecessary checks	2019-07-26 03:11:59 +03:00
Shane Woolcock	1d6c321e14	Ensure we don't ping-pong nearestBreakIndex between breaks	2019-07-26 08:34:18 +09:30
Shane Woolcock	5e51012800	Rewrite updateBreakTimeBindable	2019-07-25 22:54:05 +09:30
iiSaLMaN	cdda264c49	Use global index and move it to find if break time ... Avoid using iterations	2019-07-25 12:28:21 +03:00
iiSaLMaN	5a55433d6c	Return if breaks are null ... Fixes a test	2019-07-25 11:53:32 +03:00
iiSaLMaN	172a9ce33a	Use a for loop instead of foreach ... avoid allocating an iterator	2019-07-25 11:40:45 +03:00
iiSaLMaN	9bd66b6e7a	Better xmldoc	2019-07-25 11:27:32 +03:00
iiSaLMaN	69d2f57f4f	Avoid using LINQ	2019-07-25 11:27:01 +03:00
iiSaLMaN	0ea0a10ca4	Expose as IBindable<bool>	2019-07-25 11:26:38 +03:00
iiSaLMaN	7b82d184bd	Add bindable boolean for break times	2019-07-25 11:07:53 +03:00
Dan Balasescu	986031e127	Merge branch 'master' into storyboard-clock-di	2019-07-12 23:14:12 +09:30
Dean Herbert	8b67f88d16	Don't expose dimmable container creation in player	2019-07-12 12:04:45 +09:00
Dean Herbert	46f7bb885b	Move classes to local namespaces ... Also renames test scene to more appropriate name.	2019-07-12 11:50:06 +09:00
Dean Herbert	ecbd0f7eff	Merge branch 'master' into fix-skip-button-clickability	2019-07-11 23:10:28 +09:00
David Zhao	6c0de0b436	Merge remote-tracking branch 'upstream/master' into storyboard-clock-di	2019-07-11 13:33:35 +09:00
David Zhao	321266e96f	Make UserDimContainer abstract	2019-07-11 13:17:28 +09:00
David Zhao	7929104b8a	move default into StoryboardContainer, fix load bug, remove comment	2019-07-10 12:24:05 +09:00
David Zhao	41afe89c0b	delete no longer needed bindable	2019-07-10 00:46:34 +09:00
Dean Herbert	27e79d56ec	Merge branch 'master' into collapse-graph-option	2019-07-09 23:40:43 +09:00
David Zhao	5bb21ecae0	remove storyboard region	2019-07-09 16:50:37 +09:00
David Zhao	89cb8a0cac	Move storyboard initialization to new StoryboardContainer	2019-07-09 16:23:59 +09:00
Dean Herbert	8a98aff318	Merge branch 'master' into replay-local-mods	2019-07-08 22:38:02 +09:00
Dean Herbert	54f5e6aedf	Add assertion and comment about lease logic	2019-07-08 22:37:39 +09:00
David Zhao	0cf4bf2352	Manually set clock for storyboard if loading before being given a parent	2019-07-08 18:46:12 +09:00
David Zhao	d489a77fe1	remove new container and comment	2019-07-08 17:57:29 +09:00
David Zhao	fbd300e664	Move ruleset into ReplayPlayerLoader as well	2019-07-08 17:37:20 +09:00
David Zhao	e78e326f34	remove unused using	2019-07-08 17:02:42 +09:00
David Zhao	ef22ab9340	remove bindable	2019-07-08 16:32:11 +09:00
David Zhao	6a86f62d17	Get mods from score info	2019-07-08 16:13:03 +09:00
David Zhao	5853a877c2	create base dependencies before caching, create player in playerloader	2019-07-08 15:40:10 +09:00
David Zhao	2747d7692b	Create ReplayPlayerLoader for local mod caching	2019-07-08 14:55:05 +09:00
Dean Herbert	8f2ec73626	Move logic inside of HUDOverlay ... Add vertical offset adjust.	2019-07-07 05:30:53 +09:00
Salman Ahmed	dfabed3d85	Merge branch 'master' into applicable-to-hud	2019-07-06 16:30:02 +03:00
Dan Balasescu	3a9f16ccf2	Merge branch 'master' into idle-still-starts	2019-07-06 00:08:59 +09:30
Unknown	d05512a12a	invert usage corresponding to previous description change	2019-07-05 09:16:50 +02:00
Unknown	ee44caf964	better setting description	2019-07-05 08:52:44 +02:00
Unknown	2d5fd7f1c4	remove unnecessarily setting value of bindable that was already bound to	2019-07-05 08:49:56 +02:00
Unknown	b425df6c75	various fixes ... - make AllowSeeking a Bindable which fixes incorrect initial position and removes unnecessary variables - make SongProgressInfo fixed height	2019-07-05 08:48:40 +02:00
Dean Herbert	b902457f8d	Allow PlayerLoader to proceed even if the mouse is hovering an overlay panel	2019-07-05 15:32:07 +09:00
Unknown	ed22c23f37	mask SongProgress	2019-07-05 08:30:32 +02:00
Unknown	e69160a0ce	fix graph not completely hiding	2019-07-05 08:05:18 +02:00
iiSaLMaN	d624157c45	Remove unnecessary fading	2019-07-05 05:17:36 +03:00
Unknown	608223cbb4	Add setting to collapse the song progress graph	2019-07-04 11:59:38 +02:00
Dean Herbert	db24ac28ec	Add tests	2019-07-04 16:53:08 +09:00
Dean Herbert	a20d5baa57	Fix skip button not being clickable after fade out	2019-07-04 16:21:01 +09:00
Dean Herbert	23acddcb56	Rename download buttons to avoid ambiguity	2019-07-03 12:02:35 +09:00
Salman Ahmed	8b4ef52c13	Revert unnecessary changes	2019-07-03 07:27:24 +03:00
naoey	eaa19d5a49	Remove unused/unnecessary fields	2019-07-02 16:13:47 +05:30
naoey	ee516d2515	Make direct panel download and replay buttons share UI	2019-07-02 15:55:30 +05:30
Dean Herbert	6539c6da17	Merge branch 'master' into watch-replays-4	2019-07-02 13:24:16 +09:00
Salman Ahmed	744e651a37	Merge branch 'master' into applicable-to-hud	2019-07-02 05:24:56 +03:00
Salman Ahmed	6a79349f4a	Move health display out of the visibility container	2019-07-02 02:19:59 +03:00
Dean Herbert	60ea3d4e1a	Fix skinning support for combobreak	2019-06-30 21:58:30 +09:00
naoey	bfcbb47b77	Clean up some more leftover code	2019-06-30 10:56:20 +05:30
welsar55	d6561531a3	Merge branch 'master' into combobreak	2019-06-29 11:55:10 -05:00
Welsar55	a22c166575	Make ComboEffects its own class	2019-06-29 11:28:40 -05:00
naoey	d8f6bbc90e	Disable replay button when replay is unavailable	2019-06-29 12:49:03 +05:30
naoey	7d9e215744	Code quality fixes	2019-06-29 12:29:12 +05:30
naoey	424711d24b	Fix replay button shake container ... - Add license headers - Slightly reduce bottom margin of button in score screen	2019-06-29 12:26:37 +05:30
naoey	bc52f76556	Move replay button to score card	2019-06-29 10:55:30 +05:30
Welsar55	a57218e50e	Move to LocalSkinOverride	2019-06-28 20:45:11 -05:00
iiSaLMaN	d37cefbad8	Implement IApplicableToHUD	2019-06-29 04:23:59 +03:00
naoey	53d6d74537	Update to match upstream changes	2019-06-28 09:33:13 +05:30
naoey	ab0bb8b678	Implement replay downloading with ArchiveDownloadModelManager	2019-06-28 09:33:13 +05:30
Welsar55	826699a7e7	Remove unneeded bindable	2019-06-26 12:16:44 -05:00
Welsar55	7dd1479050	Add combobreak sound	2019-06-26 00:20:33 -05:00
Dean Herbert	40cf573368	Fix pause not correctly showing pause screen	2019-06-25 23:15:58 +09:00
Dean Herbert	f9dad0f640	Merge remote-tracking branch 'upstream/master' into gamewide-backbutton	2019-06-25 20:23:49 +09:00
smoogipoo	8c96e4c1fa	Move back button to OsuGame	2019-06-25 18:33:08 +09:00
Dean Herbert	7bc7df2249	Reduce background brightness at PlayerLoader	2019-06-25 17:22:10 +09:00
Dean Herbert	f91467eddc	Fix licence header	2019-06-24 18:34:23 +09:00
Dean Herbert	fad1ced1b5	Add correct conditionals to allow exit	2019-06-24 18:15:27 +09:00
Dean Herbert	d70248338d	Merge remote-tracking branch 'upstream/master' into quickEscape	2019-06-24 18:14:48 +09:00
Dean Herbert	26d5c2d85a	Remove local implementation of bindable in OsuCheckbox	2019-06-17 19:37:24 +09:00
Dean Herbert	021d0273f9	Split out user activity from user status (#4619) ... Split out user activity from user status Co-authored-by: Dean Herbert <pe@ppy.sh>	2019-06-12 20:14:03 +09:00
Dean Herbert	20b43c20c8	Rename variables to remove redundant "screen" terminology	2019-06-12 16:33:15 +09:00
Dean Herbert	a9c229b1ec	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-06-12 16:00:35 +09:00
Lucas A	15893bbb75	Drop UserActivity prefix for subclasses nested in UserActivity + Change status messages.	2019-06-11 19:41:48 +02:00
Dean Herbert	606be3d7ce	Merge branch 'master' into backgrounded-beatmap-status-lookups	2019-06-12 00:22:47 +09:00
Dean Herbert	00ee45fe46	Merge remote-tracking branch 'origin/update-visibility-container' into update-framework	2019-06-11 19:36:13 +09:00
Dean Herbert	609a82bc94	Update VisibilityContainer usage in line with framework	2019-06-11 15:13:58 +09:00
Lucas A	141775d98c	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-06-10 21:41:00 +02:00
smoogipoo	f090e292c9	Move ArchiveModelManager import process to async flow	2019-06-10 13:42:22 +09:00
Dean Herbert	5c2ea0b1a7	Move dispose to end of file	2019-06-10 01:14:46 +09:00
Dean Herbert	d964f6ba9e	Tween track frequency on pause	2019-06-10 00:56:35 +09:00
Lucas A	a2bc5b538e	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-06-05 16:59:38 +02:00
Dean Herbert	9c214c3f0e	Add animation on failing	2019-06-04 16:13:16 +09:00
Dean Herbert	a2fbcb2bd3	Fix rebase regressions	2019-05-31 15:58:46 +09:00
Dean Herbert	e03a664970	Fix lead-in logic to match stable ... Also adds storyboard event priority support.	2019-05-31 15:51:19 +09:00
Dean Herbert	651706b10e	Account for user/system offsets when deciding on an initial seek time ... Closes #3043 Remove "AllowLeadIn" flag	2019-05-31 15:50:46 +09:00
Dean Herbert	4ca34bd5e8	Update osu! in line with audio subsystem refactor	2019-05-28 17:06:01 +09:00
Lucas A	a819dd764f	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-05-25 11:02:19 +02:00
Dean Herbert	359e5b71a5	Fix race condition causing player to never restart	2019-05-16 17:13:03 +09:00
Lucas A	55663b3576	Nest all UserActivities into UserActivity	2019-05-12 17:38:02 +02:00
Lucas A	5ac6bd8204	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-05-12 11:53:30 +02:00
Dean Herbert	038e49701e	Move conditional to within BreakPeriod	2019-05-12 16:25:25 +09:00
Dean Herbert	1391aa342c	Merge branch 'master' into break-pause	2019-05-12 16:15:24 +09:00
smoogipoo	bde2d552b6	Merge remote-tracking branch 'origin/master' into fix-more-pause-cases ... # Conflicts: # osu.Game.Tests/Visual/Gameplay/TestCasePause.cs	2019-05-10 22:16:59 +09:00
smoogipoo	01eb1a34a9	Remove unused variable	2019-05-10 22:15:33 +09:00
smoogipoo	d2479acbf2	Fix incorrect value being clamped	2019-05-10 18:04:58 +09:00
Dean Herbert	fdf67aaa11	Clamp values	2019-05-10 17:18:39 +09:00
smoogipoo	6a957ad27f	Fix pause triggered when already paused	2019-05-10 15:51:12 +09:00
smoogipoo	7c105fd99f	Fix testcase players pausing on window unfocus	2019-05-10 15:39:25 +09:00
Dean Herbert	9248e6290c	Use FrameStabilityClock to denote current position on song progress	2019-05-09 18:09:26 +09:00
Dean Herbert	5942072128	Add a tween when clicking to seek	2019-05-09 18:07:38 +09:00
Dean Herbert	9457a6128e	Fix game pausing when made inactive while watching a replay	2019-05-09 10:57:55 +09:00
Dean Herbert	0693290ad4	Merge remote-tracking branch 'upstream/master' into refactor-select-footer	2019-05-08 18:43:21 +09:00
Dean Herbert	bace829629	Add ability to avoid expand animation in ModDisplay	2019-05-08 18:42:26 +09:00
Lucas A	a5f758b977	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-05-07 18:27:14 +02:00
Dan Balasescu	288b3deb94	Merge branch 'master' into fix-rank-display	2019-05-07 15:00:51 +09:00
Dean Herbert	8bc313fb33	Merge branch 'master' into fix-new-inspections	2019-05-07 14:14:40 +09:00
Dean Herbert	c878d814f6	Merge branch 'master' into pause-via-inactive	2019-05-07 13:35:23 +09:00
Dean Herbert	f7a570d67a	Fix double confirmation	2019-05-07 13:34:06 +09:00
smoogipoo	d7c09e7dbd	Merge remote-tracking branch 'origin/master' into fix-new-inspections ... # Conflicts: # osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs # osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs # osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs # osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs # osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs # osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs # osu.Game/Graphics/OsuFont.cs # osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs # osu.Game/Overlays/Profile/Header/BadgeContainer.cs # osu.Game/Overlays/Profile/ProfileHeader.cs # osu.Game/Screens/Select/PlaySongSelect.cs # osu.Game/Skinning/LegacySkinDecoder.cs	2019-05-07 13:20:17 +09:00
Dan Balasescu	8b9cfadd64	Merge branch 'master' into fix-retry-sound	2019-05-07 12:37:22 +09:00
Lucas A	d5d31282e5	Rename InitialScreenStatus to InitialScreenActivity in Editor / Player classes	2019-05-05 20:55:42 +02:00
Dean Herbert	7fdc79dd68	Improve skip boundary logic to be closer to expectations ... Supersedes #4693. Closes #4676.	2019-05-05 20:20:41 +09:00
Dean Herbert	3e3f12f277	Use more local bindables	2019-05-04 17:53:17 +09:00
Dean Herbert	b9a39fb788	Fix instant pausing when game becomes inactive ... Resolves #4685.	2019-05-04 14:54:29 +09:00
Lucas A	a4a2ce5ec0	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-05-02 21:36:28 +02:00
Lucas A	5d4aa5a12e	Add ScreenStatus property to change the OsuScreen's status + Renamed old ScreenStatus property to InitialScreenStatus	2019-05-02 20:51:19 +02:00
iiSaLMaN	3b03ca802a	Merge branch 'master' into sh-xh-grading-2	2019-04-30 18:55:35 +03:00
Lucas A	7e42068a14	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-04-28 19:48:35 +02:00
Dean Herbert	5a9277ec0e	Merge branch 'master' into fix-retry-sound	2019-04-28 23:38:14 +09:00
Dean Herbert	db75516e79	Merge branch 'master' into fix-lead-in-issues	2019-04-27 21:01:21 +09:00
Dean Herbert	d40177f97c	Merge branch 'master' into drawnode-composability	2019-04-27 18:41:19 +09:00
iiSaLMaN	b08fb5136e	Merge branch 'master' into sh-xh-grading-2	2019-04-26 10:38:10 +03:00
Dean Herbert	a680a38e81	Merge pull request #4675 from nyquillerium/playerloader-tracking ... Prevent PlayerLoader from tracking the logo after it has been exited.	2019-04-26 13:21:13 +09:00
KingLuigi4932	4e0f21102b	Merge branch 'sh-xh-grading-2' of https://github.com/iiSaLMaN/osu into sh-xh-grading-2	2019-04-25 14:04:12 +03:00
KingLuigi4932	c6b3197dd0	Add AdjustRank and use it in Hidden Mod	2019-04-25 13:56:57 +03:00
smoogipoo	0bd35ab7bb	Turn on warnings, resolve issues	2019-04-25 17:36:17 +09:00
Dean Herbert	6fdcd98caa	Don't play screen "back" sample when retrying	2019-04-25 14:15:07 +09:00
David Zhao	8222923ab8	Only track logo if we're still the current screen	2019-04-24 16:20:51 +09:00
Dean Herbert	bb69330e9f	Call ProcessFrame on the userOffsetClock after a seek ... Without doing this, GameplayClock can be left in an incorrect state after a seek (due to the userOffsetClock being its own FramedClock).	2019-04-24 15:28:14 +09:00
Dean Herbert	efaedafc08	Fix (legacy) AudioLeadIn being used incorrectly. ... This lead-in is intended to specify a value before zero, not a value before the start time. Also removes an unnecessary ProcessFrame call (it happens within Seek itself).	2019-04-24 15:28:14 +09:00
Dan Balasescu	8fc0bf24c7	Merge branch 'master' into fix-hold-for-menu-icon	2019-04-22 18:57:43 +09:00
Dean Herbert	48e82d4b1c	Fix hold for menu button's icon being incorrect	2019-04-22 18:47:28 +09:00
Dean Herbert	6856571f17	Fix incorrect seek target	2019-04-22 18:45:58 +09:00
Dean Herbert	55c5ef898d	Remove delay on entering player	2019-04-22 18:29:58 +09:00
Dean Herbert	908eee9942	Fix pause tests	2019-04-22 18:29:51 +09:00
Dean Herbert	6f2bc943eb	Fix rank display on break info display	2019-04-21 12:04:15 +08:00
Lucas A	fe8c705f1b	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-04-20 09:42:32 +02:00
Dean Herbert	2d7b3094ba	Merge branch 'master' into player-mod-reinstantiation	2019-04-17 16:42:57 +08:00
smoogipoo	12b6bc48bd	Use .With() wherever possible	2019-04-17 17:24:09 +09:00
smoogipoo	09568be270	Merge remote-tracking branch 'origin/master' into facade-container ... # Conflicts: # osu.Game/Screens/Play/PlayerLoader.cs	2019-04-17 17:17:33 +09:00
smoogipoo	5a3d6a0258	Fix post-merge errors	2019-04-17 16:11:59 +09:00
Dean Herbert	bb539af1a0	Merge branch 'master' into player-mod-reinstantiation	2019-04-16 22:35:21 +08:00
Lucas A	5887008fb3	Merge branch 'master' into user-status-wiring	2019-04-15 11:43:53 +02:00
DrabWeb	c766631ad6	Check for breaks using GameplayClock time.	2019-04-13 11:39:22 -03:00
Lucas A	361c0ec9f2	Allow UserStatusSoloGame to provide metadata such as the ruleset the current beatmap is played in	2019-04-13 13:18:44 +02:00
Lucas A	da5d6cb1d4	Add Beatmap fields to UserStatusSoloGame & UserStatusEditing so they can carry metadata about the played / edited beatmap	2019-04-12 22:54:35 +02:00
smoogipoo	0222424aef	Make mods IReadOnlyList<Mod> gamewide ... Prevents potential multiple evaluations of enumerable.	2019-04-10 17:20:36 +09:00
smoogipoo	85d3ff4846	Merge remote-tracking branch 'origin/master' into no-workingbeatmap-mods ... # Conflicts: # osu.Game/Screens/Play/GameplayClockContainer.cs	2019-04-10 12:06:51 +09:00
smoogipoo	4310f07a5c	Rename SelectedMods -> Mods	2019-04-10 12:03:57 +09:00
smoogipoo	4c571acd67	Reinstantiate mods for every player	2019-04-09 13:33:16 +09:00
smoogipoo	c584967eb1	Remove mods from workingbeatmap	2019-04-09 12:59:32 +09:00
smoogipoo	772bef91fa	Merge remote-tracking branch 'Joehuu/master' into drawnode-composability ... # Conflicts: # osu.Game.Rulesets.Osu/UI/Cursor/OsuCursorContainer.cs	2019-04-08 23:01:12 +09:00
David Zhao	a690302d00	Apply reviews	2019-04-08 15:24:09 +09:00
DrabWeb	e76897d6a7	Fix ResumeContainers appearing when resuming during breaks.	2019-04-07 16:32:55 -03:00
Dean Herbert	46ecaf3d6c	Merge branch 'master' into facade-container	2019-04-05 21:14:21 +09:00
David Zhao	7047f305a1	Apply reviews, add safety for multiple facades	2019-04-05 12:02:47 +09:00
David Zhao	b2857384b8	Remove unnecessary logo assignment	2019-04-04 12:08:05 +09:00
David Zhao	15b2b6af7d	Clean up remaining assignments of logo relativePositionAxes	2019-04-04 11:28:36 +09:00
David Zhao	8a40b27e8f	Remove need for logo relativePositionAxes none	2019-04-03 20:32:53 +09:00
David Zhao	2ed945605e	Fix Axes.None requirement for FacadeContainer	2019-04-03 19:57:22 +09:00
Dean Herbert	efd7bea771	Add further xmldoc	2019-04-03 17:01:11 +09:00
Dean Herbert	50f8ab3dfb	Fix gameplay offset handling on seeks	2019-04-03 16:58:20 +09:00
Dean Herbert	f1952c0816	Update font awesome usage	2019-04-02 19:55:24 +09:00
smoogipoo	a56e29347f	Adjust namespaces	2019-04-02 14:51:28 +09:00
David Zhao	020be50f03	Merge remote-tracking branch 'upstream/master' into facade-container	2019-04-02 11:28:44 +09:00
Dean Herbert	c39c37a18d	Apply more missed cases	2019-04-01 12:44:46 +09:00
Dean Herbert	612db31c38	Apply newline additions	2019-04-01 12:16:32 +09:00
David Zhao	952a12bb19	Return logo relativepositionaxes on content out	2019-03-29 16:54:34 +09:00
Dean Herbert	6949c233bf	Merge remote-tracking branch 'upstream/master' into resume-cursor-2	2019-03-29 15:02:12 +09:00
Dean Herbert	202a0086cc	Merge branch 'master' into better-player-flags	2019-03-29 13:45:45 +09:00
Dean Herbert	fed58fba3a	Merge remote-tracking branch 'upstream/master' into resume-cursor-2	2019-03-29 12:14:28 +09:00
Dan Balasescu	d410054ec8	Merge branch 'master' into key-counter-display	2019-03-29 11:22:59 +09:00
Dean Herbert	7715606188	Merge branch 'master' into sprite-icon-compatibility	2019-03-29 11:15:34 +09:00
David Zhao	9d66a5e4b2	Ensure logo stops tracking before suspend animation	2019-03-28 16:29:35 +09:00
David Zhao	039e451ab1	ensure logo is where it already needs to be on resume	2019-03-28 16:14:28 +09:00
David Zhao	bfe44eb33d	Remove SizeForFlow magic number	2019-03-28 15:40:58 +09:00
David Zhao	061527a260	Add new automated tests for logofacade, reset interpolation	2019-03-27 20:04:01 +09:00
Dean Herbert	de80fc0eac	Update icon usage to match framework changes	2019-03-27 19:29:27 +09:00
David Zhao	2e3791be1c	Fix incorrect usage of LogoFacade	2019-03-27 18:11:12 +09:00
David Zhao	ca7a20585d	Apply reviews, delete playerloader test	2019-03-27 17:28:53 +09:00
David Zhao	384eee3395	Remove DI requirement for the Facade in PlayerLoader	2019-03-27 11:32:26 +09:00
David Zhao	3fe52be77f	Better tests, add documentation	2019-03-26 17:22:36 +09:00
Dean Herbert	a88f23e555	Convert remaining two flags to ctor parameters	2019-03-26 16:53:44 +09:00
Dean Herbert	83863d35c3	Remove AllowLeadIn flag	2019-03-26 16:35:00 +09:00
Dean Herbert	8658de5108	Rename KeyCounterCollection -> KeyCounterDisplay ... Also fix not working	2019-03-26 13:52:48 +09:00
Dean Herbert	b4d785c76c	Don't update gameplay loop while paused	2019-03-26 13:36:17 +09:00
Dean Herbert	256a579de0	Allow player to not pause on focus loss	2019-03-26 13:17:00 +09:00
Dean Herbert	b75ea295db	Rename KeyCounterCollection -> KeyCounterDisplay ... Also fix not working	2019-03-26 11:28:43 +09:00
David Zhao	35bf262d19	Merge remote-tracking branch 'upstream/master' into facade-container	2019-03-26 11:11:13 +09:00
David Zhao	a0f6718145	Better tests and implementation	2019-03-26 10:48:29 +09:00
Dean Herbert	245f463e3f	Don't update gameplay loop while paused	2019-03-25 20:31:55 +09:00
Dean Herbert	8ad4009c33	osu! resume overlay	2019-03-25 20:31:55 +09:00
David Zhao	d37968d88d	Add better test for facade containers	2019-03-24 15:18:38 +09:00
Dean Herbert	11b474e194	Handle released for safety	2019-03-24 12:19:09 +09:00
Dean Herbert	0d72104235	Refactor for formatting sanity	2019-03-24 12:03:06 +09:00
Dean Herbert	8ad19fc2d4	Merge branch 'master' into menu-globalaction-select	2019-03-24 11:58:52 +09:00
David Zhao	6e98a8dd7c	Initial implementation	2019-03-22 20:01:58 +09:00
David Zhao	e93311fdc9	DI facade	2019-03-22 19:01:32 +09:00
Dean Herbert	9e6cdd7bd5	Combine conditionals and clarify comment	2019-03-22 14:42:51 +09:00
Dean Herbert	5b8fd6822e	Move storyboard logic region down	2019-03-22 14:39:20 +09:00
Dean Herbert	15f9a6b9df	Merge remote-tracking branch 'upstream/master' into pause-logic-simplification	2019-03-21 16:04:18 +09:00
Dean Herbert	67a65b80fc	Merge branch 'master' into visual-settings-container	2019-03-20 20:48:30 +09:00
Dean Herbert	ba89bfee0c	Define explicit method to add background ... Also cleans up some redundant/misplaced comments.	2019-03-20 20:16:45 +09:00
Dean Herbert	8865d53992	Reword comment	2019-03-20 20:04:07 +09:00
David Zhao	2e9d823af4	Add comment regarding HandlePositionalInput	2019-03-20 19:59:54 +09:00
David Zhao	2ff7aa6c2e	Remove handle positional input	2019-03-20 19:49:37 +09:00
David Zhao	bc6e8ce7b4	Merge branch 'visual-settings-container' of https://github.com/nyquillerium/osu into visual-settings-container	2019-03-20 19:48:57 +09:00
Dean Herbert	01f795b046	Make restart public rather than reimplementing	2019-03-20 19:45:04 +09:00
David Zhao	8543e8c36f	Put loadcomplete next to other protected overrides	2019-03-20 19:42:39 +09:00
Dean Herbert	cda5bc28c8	Add proper comment	2019-03-20 19:41:20 +09:00
David Zhao	9013afe412	Query for input manager once	2019-03-20 19:35:40 +09:00
David Zhao	fbfef844de	Add test case for resuming PlayerLoader	2019-03-20 17:18:42 +09:00
David Zhao	a5916f995e	Use the previous conditional instead	2019-03-20 16:54:42 +09:00
David Zhao	e9034c8a30	Move blurring logic into Update instead	2019-03-20 16:50:47 +09:00
Dean Herbert	f43e7a880c	Merge remote-tracking branch 'upstream/master' into pause-logic-simplification	2019-03-20 15:27:06 +09:00
Dean Herbert	6f1610be79	Merge branch 'master' into ruleset-container-refactor	2019-03-20 14:55:58 +09:00
Dean Herbert	5f288650bf	Fix misses/typos	2019-03-20 14:49:33 +09:00
David Zhao	15637f9c4a	Rework instant blur logic such that updateVisuals doesn't need to be public	2019-03-20 14:17:35 +09:00
Dean Herbert	baea7230bc	Rename RulesetContainer to DrawableRuleset	2019-03-19 23:47:31 +09:00
Dean Herbert	68f28326a2	Refactor RulesetContainer for readability	2019-03-19 20:21:31 +09:00
David Zhao	a8e2072286	Make blurtarget private, improve documentation	2019-03-19 20:15:28 +09:00
David Zhao	dc26e90a8d	Remove unused usings	2019-03-19 13:16:06 +09:00
David Zhao	df37973e84	Move showstoryboard into player	2019-03-19 13:13:19 +09:00
David Zhao	27a92e017c	rename back to UserDimContainer	2019-03-19 13:06:14 +09:00
David Zhao	f1b2073bf6	Merge remote-tracking branch 'upstream/master' into visual-settings-container	2019-03-19 13:01:05 +09:00
Dean Herbert	4f075f4740	Add more comprehensive testing	2019-03-18 20:33:43 +09:00
Dean Herbert	9433a97747	Add resume requesting support and fix exit scenarios	2019-03-18 20:33:43 +09:00
Dean Herbert	536b5e0dab	Remove PausableGameplayContainer	2019-03-18 20:33:43 +09:00
Dean Herbert	f13003c53b	Simplify and localise storyboard logic in Player.cs	2019-03-18 20:33:43 +09:00
Dean Herbert	bcaff9f7b4	Add basic pause tests	2019-03-18 20:33:43 +09:00
Dean Herbert	465c95e952	Refactor pause logic so GameplayClockContainer is in control	2019-03-18 20:33:43 +09:00
Dean Herbert	14df9f94e2	Merge branch 'master' into fix-background-loading	2019-03-18 14:59:35 +09:00
Dan Balasescu	e0b3149e32	Merge branch 'master' into api-testability	2019-03-18 10:59:06 +09:00
David Zhao	8fc90bb9a0	Remove unused usings	2019-03-14 16:26:34 +09:00
David Zhao	8cdfb1fd61	Remove BlurrableBackgroundScreen, rework tests	2019-03-14 16:09:17 +09:00
David Zhao	8714902349	Handle all blurring directly from background	2019-03-14 14:02:46 +09:00
Dean Herbert	0042cc5337	Merge branch 'master' into mod-ramp-hotfix	2019-03-14 13:02:29 +09:00
David Zhao	de6d8fc637	Move user blurring into VIsualSettingsContainer	2019-03-13 18:25:22 +09:00
Dean Herbert	f0114d776d	Use interface to access API ... Allows for better testability.	2019-03-13 12:58:18 +09:00
Dean Herbert	c1a356161f	Allow use rate adjust to fallback to clock rate adjust	2019-03-12 18:14:01 +09:00
Dean Herbert	3c2d8cad0a	Add better async logic for ScreenWithBeatmapBackground	2019-03-12 17:32:40 +09:00
Dean Herbert	cdeaa80fea	Call ResetSpeedAdjustments before adjusting clock	2019-03-12 11:35:25 +09:00
Dean Herbert	13b3036ec6	Fix "wind" mods adjusting rate twice ... This is a hotfix for incorrect framework behaviour. Closes #4442	2019-03-12 02:45:45 +09:00
Dean Herbert	1be4c7b813	Fix excess newline	2019-03-12 02:23:23 +09:00
Dean Herbert	38e75421ab	Fix HoldForMenuButton getting stuck in a confirming state ... Closes #4446.	2019-03-12 02:21:34 +09:00
smoogipoo	d055b248ac	Remove blank line	2019-03-08 15:56:36 +09:00
smoogipoo	7c5ca67691	Merge remote-tracking branch 'origin/master' into gameplay-clock-container ... # Conflicts: # osu.Game/Screens/Play/Player.cs	2019-03-08 15:54:15 +09:00
Dean Herbert	ed8c9bc88a	Merge remote-tracking branch 'upstream/master' into gameplay-clock-container	2019-03-08 15:07:55 +09:00
Dean Herbert	42efea1e06	Apply review	2019-03-08 15:05:45 +09:00
Dean Herbert	64b6eaa844	Simplify inward bindings	2019-03-07 16:04:11 +09:00
Dean Herbert	58ef397f4f	Move all clock related gameplay logic inside GameplayClockContainer	2019-03-07 16:02:24 +09:00
Dean Herbert	ffe53411f6	Add back cursor proxying	2019-03-06 17:44:58 +09:00
Dean Herbert	acf518c208	Move cursor inside playfield	2019-03-06 17:41:54 +09:00
Dean Herbert	5411c63093	Fix menu cursor not displaying outside of gameplay scaling area	2019-03-06 17:14:08 +09:00
Dean Herbert	6b042eae94	Merge branch 'master' into fix-cursor-in-scale-container	2019-03-05 22:22:56 +09:00
Dean Herbert	8a6fa0915e	Merge branch 'master' into simplify-gameplay-clock	2019-03-05 20:22:46 +09:00
Dean Herbert	76ce3954a0	Rename PauseContainer	2019-03-05 19:30:55 +09:00
Dan Balasescu	fafc80818c	Fix typo ... Co-Authored-By: peppy <pe@ppy.sh>	2019-03-05 18:50:46 +09:00
Dean Herbert	fc0b297232	Fix menu cursor not displaying outside of gameplay scaling area	2019-03-05 18:06:24 +09:00
smoogipoo	c06dac5b1a	Remove null check (beatmap cannot be null)	2019-03-05 17:58:30 +09:00
smoogipoo	2fee7276ae	Combine creation + assignment	2019-03-05 17:58:05 +09:00
Dan Balasescu	bb6c83ab25	Merge branch 'master' into show-mods-on-loader	2019-03-05 17:46:35 +09:00
Dan Balasescu	fd147dae21	Merge branch 'master' into fix-disabled-set-crash	2019-03-05 17:25:13 +09:00
Dean Herbert	93c79023dc	Merge remote-tracking branch 'upstream/master' into simplify-gameplay-clock	2019-03-05 16:41:01 +09:00
Dean Herbert	4e33a98dbc	Move gameplay clock to own class	2019-03-05 13:53:47 +09:00
Dean Herbert	c5cd9972c4	Make restart private	2019-03-05 13:37:51 +09:00
Dean Herbert	01f1018d02	Tidy up clock logic using DI and a GameplayClock	2019-03-05 13:37:51 +09:00
Dean Herbert	5bb0511f0a	Fix SquareGraph not correctly filling columns when loaded with a non-zero time	2019-03-05 13:37:28 +09:00
LeNitrous	cf51c8aa31	attempt to comply with appveyor	2019-03-01 19:10:32 +08:00
LeNitrous	4e081fe1fc	Merge branch 'show-mods-on-loader' of https://github.com/LeNitrous/osu into show-mods-on-loader	2019-03-01 18:41:41 +08:00
Dean Herbert	30e820d107	Fix storyboard potentially being loaded many times	2019-02-28 20:36:00 +09:00
Dean Herbert	53eb0e7e4e	More formatting fixes	2019-02-28 20:30:23 +09:00
Dean Herbert	6861163226	Remove pointless method	2019-02-28 20:21:27 +09:00
David Zhao	e3338e94d1	Make test cases more compact, add two way toggles	2019-02-28 20:01:15 +09:00
Dan Balasescu	99812bd448	Apply suggestions from code review ... Co-Authored-By: nyquillerium <nyquill@ppy.sh>	2019-02-28 18:25:58 +09:00
Dean Herbert	b2872b47d0	Merge branch 'master' into UserDimLogic	2019-02-28 17:18:04 +09:00
David Zhao	69b1c76dce	Actually implement blurring fix	2019-02-28 16:51:17 +09:00
Dan Balasescu	3a1066ff02	Merge branch 'master' into toquantity-1	2019-02-28 15:57:51 +09:00
Joehu	2241e1af9d	Use ToQuantity for words with number prefixes	2019-02-27 21:55:45 -08:00