h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-18 18:27:45 +08:00
Code Issues Releases Wiki Activity

Fix "finished playing" events handled for potentially incorrect user

Browse Source
This commit is contained in:
Dean Herbert 2020-10-28 16:11:14 +09:00
parent 6eddd76bdc
commit 48b0357e7d
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Screens/Play/Spectator.cs
View File

@ -167,6 +167,16 @@ namespace osu.Game.Screens.Play
attemptStart();
}
private void userFinishedPlaying(int userId, SpectatorState state)
{
if (userId != targetUser.Id)
return;
if (replay == null) return;
replay.HasReceivedAllFrames = true;
}
private void attemptStart()
{
var resolvedRuleset = rulesets.AvailableRulesets.FirstOrDefault(r => r.ID == state.RulesetID)?.CreateInstance();
@ -216,13 +226,6 @@ namespace osu.Game.Screens.Play
api.Queue(req);
}
private void userFinishedPlaying(int userId, SpectatorState state)
{
if (replay == null) return;
replay.HasReceivedAllFrames = true;
}
protected override void Dispose(bool isDisposing)
{
base.Dispose(isDisposing);