h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-19 09:07:18 +08:00
Code Issues Releases Wiki Activity

Invert BypassFail usage

Browse Source
This commit is contained in:
iiSaLMaN 2019-09-19 08:00:41 +03:00
parent 9de0bcae1e
commit e793854735
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game.Tests/Visual/Gameplay/TestSceneReplay.cs
View File

@ -26,14 +26,14 @@ namespace osu.Game.Tests.Visual.Gameplay
{
AddUntilStep("score above zero", () => ((ScoreAccessibleReplayPlayer)Player).ScoreProcessor.TotalScore.Value > 0);
AddUntilStep("key counter counted keys", () => ((ScoreAccessibleReplayPlayer)Player).HUDOverlay.KeyCounter.Children.Any(kc => kc.CountPresses > 0));
AddAssert("cannot fail", () => ((ScoreAccessibleReplayPlayer)Player).BypassFail);
AddAssert("cannot fail", () => !((ScoreAccessibleReplayPlayer)Player).AllowFail);
}
private class ScoreAccessibleReplayPlayer : ReplayPlayer
{
public new ScoreProcessor ScoreProcessor => base.ScoreProcessor;
public new HUDOverlay HUDOverlay => base.HUDOverlay;
public new bool BypassFail => base.BypassFail;
public new bool AllowFail => base.AllowFail;
protected override bool PauseOnFocusLost => false;

4
osu.Game/Screens/Play/ReplayPlayer.cs
View File

@ -9,8 +9,8 @@ namespace osu.Game.Screens.Play
{
private readonly Score score;
// Block replays from failing. (see https://github.com/ppy/osu/issues/6108)
protected override bool BypassFail => true;
// Disallow replays from failing. (see https://github.com/ppy/osu/issues/6108)
protected override bool AllowFail => false;
public ReplayPlayer(Score score, bool allowPause = true, bool showResults = true)
: base(allowPause, showResults)