Dean Herbert
4e6a505a99
Add new icons and tooltips
2020-10-01 16:25:40 +09:00
Dean Herbert
78c5d57074
Add flip event flow and stop passing raw input events to handle methods
2020-10-01 16:25:29 +09:00
Dean Herbert
02f14ab4b0
Rename operation start/end to be more encompassing
2020-10-01 16:24:09 +09:00
Dean Herbert
b1f2bdd579
Add missing xmldoc
2020-10-01 13:47:49 +09:00
Dean Herbert
e0a0902a15
Ensure textbox always reverts to sane state on out-of-range failures
2020-10-01 13:06:24 +09:00
Dean Herbert
9d07dce5e4
Merge pull request #10251 from smoogipoo/additional-hit-results
2020-10-01 12:19:48 +09:00
Bartłomiej Dach
10ae93cc2e
Merge branch 'master' into more-textbox-entry
2020-09-30 23:54:00 +02:00
smoogipoo
fde00d3431
Make DifficultyIcon support dynamic star rating
2020-10-01 00:53:25 +09:00
Dan Balasescu
148e2769c8
Merge pull request #10304 from peppy/fix-control-point-bindable-updates
...
Fix control point timeline display not updating with changes
2020-09-30 23:30:35 +09:00
Dean Herbert
367b35bb10
Merge branch 'master' into fix-storyboard-sample-pausing
2020-09-30 22:42:26 +09:00
Dan Balasescu
6def54548b
Merge branch 'master' into fix-control-point-bindable-updates
2020-09-30 21:35:36 +09:00
Dan Balasescu
6dab5c2ceb
Merge branch 'master' into fix-editor-silence-on-seek
2020-09-30 21:33:15 +09:00
Dan Balasescu
7eb45990a4
Merge pull request #10302 from peppy/timing-screen-clean-up
...
Fix timing screen tests and add simple view of control points to timeline
2020-09-30 21:33:07 +09:00
Dan Balasescu
3af7e59103
Merge pull request #10289 from peppy/timeline-ux-improvements
...
Improve the usability of the editor timeline with combo colour and indices
2020-09-30 20:32:55 +09:00
Dean Herbert
fa742a2ef1
Update to consume framework fixes
2020-09-30 20:28:02 +09:00
Dean Herbert
df9d4bc2f0
Merge branch 'master' into fix-control-point-bindable-updates
2020-09-30 20:27:25 +09:00
Dean Herbert
a11c74d600
Update to consume framework fixes
2020-09-30 20:27:02 +09:00
Dean Herbert
f9d6aed2df
Merge branch 'master' into timing-screen-clean-up
2020-09-30 20:26:02 +09:00
Dean Herbert
5242f5648d
Fix timeline control point display not updating with changes
2020-09-30 18:34:13 +09:00
Dean Herbert
44fc0c6723
Fix default value of bpm being too high
2020-09-30 18:08:55 +09:00
Dean Herbert
bc943dee53
Add textbox entry for speed multiplier and volume
2020-09-30 17:52:12 +09:00
Dean Herbert
b0f8e11bd4
Fix incorrect caching
2020-09-30 17:34:14 +09:00
Dean Herbert
3422db1bb2
Use top-left colour for deciding the text colour (gradient was added in some cases)
2020-09-30 17:10:22 +09:00
Dean Herbert
7f579850dd
Merge branch 'master' into fix-editor-silence-on-seek
2020-09-30 17:03:23 +09:00
Dean Herbert
698042268f
Show control points in timing screen timeline
2020-09-30 17:00:42 +09:00
Dean Herbert
5b200a8ca4
Change default zoom of timing screen timeline to most zoomed out
2020-09-30 16:39:27 +09:00
Dean Herbert
a40c2ea5ee
Simplify control point group binding/update logic
2020-09-30 16:02:22 +09:00
Dean Herbert
414c40d298
Reverse inheritance order of SkinnableSound's pause logic
2020-09-30 15:45:14 +09:00
Dan Balasescu
466d37a450
Merge branch 'master' into fix-spinner-rpm-user-rate-adjust
2020-09-30 15:43:56 +09:00
Dean Herbert
59ce9fcab9
Merge branch 'master' into fix-editor-silence-on-seek
2020-09-30 15:35:55 +09:00
Dean Herbert
ae9e884a48
Fix header casing
2020-09-30 15:35:25 +09:00
Dean Herbert
d6c88ecd69
Merge branch 'master' into osu-selection-scaling
2020-09-30 15:09:04 +09:00
Dean Herbert
f1298bed79
Combine scale operations and tidy up scale drag handle construction
2020-09-30 15:08:56 +09:00
Dean Herbert
39b55a85df
Move a lot of the implementation to base SelectionHandler
2020-09-30 13:52:57 +09:00
Dean Herbert
f2c26c0927
Move information text underneath the selection box
2020-09-30 13:07:24 +09:00
Dean Herbert
1386c9fe66
Standardise time display formats across the editor
2020-09-30 12:45:43 +09:00
Lucas A
35f7de2084
Apply review suggestions.
2020-09-29 18:08:21 +02:00
Dean Herbert
a2e2cca396
Add proper change handler support
2020-09-29 20:08:56 +09:00
Dean Herbert
0a10e40ce0
Add scaling support to osu! editor
2020-09-29 20:08:56 +09:00
Dean Herbert
cd794eaa65
Add basic selection box with drag handles
2020-09-29 20:08:56 +09:00
Dean Herbert
6e1ea00443
Don't apply gradient to non-duration objects
2020-09-29 17:34:50 +09:00
Dean Herbert
c47652c97a
Add gradient to hide subtractive colour issues
...
Good thing is looks better than without.
2020-09-29 17:26:54 +09:00
Dean Herbert
8d8d45a0c0
Add combo index display support
2020-09-29 17:26:54 +09:00
Dean Herbert
f16fc29071
Add combo colour display support
2020-09-29 17:26:54 +09:00
Dean Herbert
53b3d23842
Expose HitObjectComposer for other components in the Compose csreen to use
2020-09-29 17:26:54 +09:00
Dean Herbert
136843c8e4
Make DrawableStoryboardSample a SkinnableSound
...
Allows sharing pause logic with gameplay samples.
2020-09-29 14:25:39 +09:00
Dean Herbert
74e74e1c31
Fix pause loop sound not working because paused
2020-09-29 14:20:41 +09:00
Dean Herbert
c5f6b77bba
Add missing cached type
2020-09-29 13:42:17 +09:00
Dean Herbert
d6f3beffb6
Use existing bindable flow instead
2020-09-29 12:50:17 +09:00
Dean Herbert
585b857a0c
Handle paused state correctly
2020-09-29 12:17:38 +09:00
Lucas A
6efc4c4250
Cache performance calculations to prevent recomputations.
2020-09-28 19:04:39 +02:00
Dean Herbert
4f0c0ea5f9
Fix hit samples playing while paused / seeking in the editor
2020-09-28 18:17:47 +09:00
Dean Herbert
fd58a24183
Merge branch 'master' into fix-spinner-rpm-user-rate-adjust
2020-09-28 17:45:48 +09:00
Dan Balasescu
2f5a2d3bba
Merge pull request #10277 from peppy/editor-implicit-autoplay
...
Add autoplay support to editor
2020-09-28 17:41:26 +09:00
Dan Balasescu
89c8fca3fa
Merge pull request #10270 from peppy/editor-fix-noop-states-saving
...
Avoid saving state changes if nothing has changed (via binary comparison)
2020-09-28 17:03:50 +09:00
Dan Balasescu
06ab33645e
Merge branch 'master' into editor-implicit-autoplay
2020-09-28 16:43:08 +09:00
Dan Balasescu
5cceb3c724
Merge pull request #10273 from peppy/editor-fix-missing-update-after-drag
...
Trigger a hitobject update after blueprint drag ends
2020-09-28 16:34:23 +09:00
Dean Herbert
7949eabaac
Remove left-over using
2020-09-28 15:49:45 +09:00
Dean Herbert
d9ac5866b6
Merge branch 'editor-default-hit-sample' into editor-implicit-autoplay
2020-09-28 15:48:37 +09:00
Dean Herbert
a4e9c85333
Trigger a hitobject update after blueprint drag ends
2020-09-28 15:37:06 +09:00
Dean Herbert
0ae2266b82
Fix new placement hitobjects in the editor not getting the default sample added
2020-09-28 15:36:13 +09:00
Dean Herbert
1aa8b400d4
Avoid unnecessary object updates from SelectionHandlers
2020-09-28 15:33:49 +09:00
Dean Herbert
3cf430f494
Avoid saving state changes if nothing has changed (via binary comparison)
2020-09-28 15:30:51 +09:00
Lucas A
ddede85704
Split performance calculation to its own class.
2020-09-27 12:44:29 +02:00
Lucas A
3cb9103fe0
Inherit PerformanceStatistic from CounterStatistic
2020-09-27 09:37:57 +02:00
Lucas A
4d94bf3163
Rename CalculateScorePerformance -> CalculatePerformance
2020-09-25 19:16:33 +02:00
Lucas A
77a9d92f42
Add dynamic pp calculation to score panels for local scores
2020-09-25 19:15:40 +02:00
smoogipoo
a07597c369
Adjust displays to use new results/orderings
2020-09-25 20:22:59 +09:00
Dean Herbert
b2261f03e2
Merge branch 'master' into fix-spinner-rpm-user-rate-adjust
2020-09-25 20:21:35 +09:00
Dan Balasescu
2280568d27
Merge pull request #10245 from peppy/editor-sample-addition-buttons
...
Add sample toggle buttons to toolbox
2020-09-25 20:09:10 +09:00
Dan Balasescu
93a137ed84
Merge pull request #10234 from peppy/editor-load-audio
...
Add audio track selection to editor setup screen
2020-09-25 19:58:23 +09:00
Dan Balasescu
cc41b4bb9e
Merge branch 'master' into editor-sample-addition-buttons
2020-09-25 19:39:12 +09:00
Dean Herbert
204024c76e
Merge branch 'master' into editor-load-audio
2020-09-25 18:32:51 +09:00
Dean Herbert
8e6bf516d9
Merge branch 'master' into editor-ternary-buttons
2020-09-25 18:30:59 +09:00
Dean Herbert
dbfa05d3b3
Fix placement object not getting updated with initial state
2020-09-25 18:00:17 +09:00
Dean Herbert
b561429f92
Add toolbar toggle buttons for hit samples
2020-09-25 17:53:41 +09:00
Dean Herbert
346d14d40b
Rename variables to match
2020-09-25 17:45:19 +09:00
Dean Herbert
22511c36c3
Ensure toggles are not instantiated more than once for safety
2020-09-25 17:43:09 +09:00
Dean Herbert
51cc644b7b
Fix set access to SelectionHandler
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2020-09-25 17:42:49 +09:00
Dean Herbert
b8e9f19b92
Move common HitSampleInfo lookup to static method
2020-09-25 17:30:31 +09:00
Dean Herbert
98c6027352
Remove unused using
2020-09-25 17:07:58 +09:00
Dean Herbert
ae68dcd962
Add ternary toggle buttons to editor toolbox selection
2020-09-25 16:38:12 +09:00
Dean Herbert
0f8551e9ea
Merge branch 'editor-ternary-states' into new-combo-toggle
2020-09-25 15:36:33 +09:00
Dean Herbert
a859fe78ee
Expose update ternary state method and use better state determination function
2020-09-25 15:32:36 +09:00
Dean Herbert
50290f3cb4
Rework ternary states to fix context menus not updating after already displayed
2020-09-25 15:10:13 +09:00
Dan Balasescu
e828cf1607
Merge branch 'master' into editor-load-audio
2020-09-25 14:49:54 +09:00
Dean Herbert
a6adf8334e
Use existing method to update combo state of selection
2020-09-25 14:19:35 +09:00
Dean Herbert
e009264f10
Add new combo toggle to main composer interface
2020-09-25 14:10:30 +09:00
Dean Herbert
26ba7d3100
Remove unused method (was moved to a more local location)
2020-09-25 13:20:19 +09:00
Dan Balasescu
952e84396a
Merge branch 'master' into editor-object-object-snapping
2020-09-25 13:17:30 +09:00
Dean Herbert
7df8b5bce7
Merge branch 'master' into fix-spinner-rpm-user-rate-adjust
2020-09-25 13:17:03 +09:00
Dean Herbert
ea971ecb90
Remove local file handling from SetupScreen
2020-09-25 13:16:30 +09:00
Dean Herbert
f047ff10bf
Remove local specification for file selector search path
2020-09-25 12:30:05 +09:00
Dean Herbert
b1e72c311e
Add null check because we can
2020-09-25 12:28:41 +09:00
Dean Herbert
a17eac3692
Rename reload method to not mention beatmap unnecessarily
2020-09-25 12:27:08 +09:00
Dean Herbert
44a6637c36
Use SingleOrDefault
2020-09-25 12:20:37 +09:00
Dean Herbert
b9196718b7
Merge branch 'master' into editor-object-object-snapping
2020-09-25 12:15:10 +09:00
Dean Herbert
011b176244
Add test coverage of audio track changing
2020-09-24 22:00:13 +09:00
Dean Herbert
cc9ae32811
Fix summary timeline not updating to new track length correctly
2020-09-24 21:05:29 +09:00
Dean Herbert
833ff1c1d7
Fix test failures due to editor dependency
2020-09-24 20:56:35 +09:00
Dean Herbert
7e7e2fd64a
Use bindable for track to fix rate adjustments not applying correctly
2020-09-24 20:56:35 +09:00
Dean Herbert
978f6edf38
Add basic track reloading support while inside the editor
2020-09-24 20:56:35 +09:00
Dean Herbert
65e6dd2ac3
Remove the previous audio file before adding a new one
2020-09-24 20:56:35 +09:00
Dean Herbert
4d714866cd
Add ability to actually import a new audio file to the beatmap / database
2020-09-24 20:56:35 +09:00
Dean Herbert
4b9581bca0
Add audio selection to song setup screen
2020-09-24 20:56:35 +09:00
Dean Herbert
158d307126
Avoid destroying editor screens when changing between modes
2020-09-24 17:03:54 +09:00
Dan Balasescu
ad30c20b8c
Merge pull request #10227 from peppy/editor-negative-current-time
...
Fix editor not showing sign when time goes negative
2020-09-24 16:27:05 +09:00
Dean Herbert
44be0ab762
Add basic osu! object to object snapping
2020-09-24 16:24:35 +09:00
Dan Balasescu
f84b5087bd
Merge pull request #10226 from peppy/results-fix-relayout-misalignment
...
Fix score panel being incorrectly vertically aligned on screen resize
2020-09-24 15:50:31 +09:00
Dan Balasescu
02d8355321
Merge pull request #10224 from peppy/results-statistics-replay-button
...
Add more descriptive description and download button when statistics not available
2020-09-24 14:31:38 +09:00
Dean Herbert
9c074e0ffb
Fix editor not showing sign when time goes negative
2020-09-24 13:10:54 +09:00
Dean Herbert
5612357574
Fix score panel being incorrectly vertically aligned on screen resize
2020-09-24 12:49:32 +09:00
Dean Herbert
fda6e88dd3
Fix braces style
2020-09-24 12:39:08 +09:00
Dean Herbert
cb903ec9e2
Fix extended statistics not being vertically centered
2020-09-24 12:21:46 +09:00
Dean Herbert
f4d2c2684d
Add more descriptive description and download button when statistics not available
2020-09-24 12:21:08 +09:00
Dan Balasescu
37af9e767f
Merge branch 'master' into fix-taiko-change-handling
2020-09-23 19:47:29 +09:00
Dan Balasescu
d1e41e41f7
Merge pull request #10214 from peppy/new-combo-editor-toggle
...
Add the ability to toggle new combo state from composer context menu
2020-09-23 19:46:55 +09:00
Dean Herbert
ccb3ef5020
Merge branch 'new-combo-editor-toggle' into fix-taiko-change-handling
2020-09-23 17:08:27 +09:00
Dean Herbert
02201d0ec6
Fix incorrect cast logic
2020-09-23 17:08:25 +09:00
Dean Herbert
487fc2a2c6
Add missing change handler scopings to taiko context menu operations
2020-09-23 16:58:22 +09:00
Dean Herbert
2d67faeb72
Add xmldoc
2020-09-23 16:40:56 +09:00
Dean Herbert
a1ec167982
Add the ability to toggle new combo state from composer context menu
2020-09-23 16:38:16 +09:00
Joehu
c5b684bd2e
Fix typo in log when beatmap fails to load
2020-09-23 00:30:20 -07:00
Dean Herbert
c38cd50723
Fix editor not using beatmap combo colours initially on load
2020-09-23 13:16:50 +09:00
Dean Herbert
80fb8f074c
Merge branch 'master' into add-editor-keybindings
2020-09-23 12:32:04 +09:00
Dean Herbert
3062fe4411
Add editor key bindings to switch between screens
2020-09-22 15:55:25 +09:00
Dean Herbert
3276b9ae9c
Fix fail animation breaking on post-fail judgements
2020-09-22 15:08:53 +09:00
Dean Herbert
508278505f
Make local clock private
2020-09-21 19:40:57 +09:00
Dean Herbert
3f788da06d
Fix SPM changing incorrectly with playback rate changes
2020-09-21 19:39:54 +09:00
Dean Herbert
1fcf443314
Ensure BeatmapProcessor.PostProcess is run before firing HitObjectUpdated events
2020-09-18 19:33:03 +09:00
Joehu
c6386ea605
Remember leaderboard mods filter selection in song select
2020-09-15 21:53:35 -07:00
Dean Herbert
3c70b3127c
Fix potential nullref in FilterControl during asynchronous load
2020-09-15 23:19:31 +09:00
Dan Balasescu
16ae83c499
Merge branch 'master' into editor-clipboard
2020-09-15 16:05:43 +09:00
Dan Balasescu
6cbff98295
Merge branch 'master' into add-collections-to-beatmap-options
2020-09-15 15:23:33 +09:00
Dean Herbert
2c7492d717
Add null check in SongSelect disposal for safety
2020-09-15 14:34:58 +09:00
Joehu
43daabc982
Remove unused using and move dialog to BDL
2020-09-14 12:10:00 -07:00
Joehu
c833f5fcc4
Reorder buttons to match stable
2020-09-14 11:23:41 -07:00
Joehu
57610ddad5
Fix beatmap options absorbing input from toolbar ruleset selector
2020-09-14 11:22:16 -07:00
Joehu
c30174cea3
Add manage collections button to beatmap options
2020-09-14 11:21:23 -07:00
Joehu
1a8a7ae7f8
Remove hardcoded key param from AddButton
2020-09-14 11:19:18 -07:00
Joehu
368aca015a
Move override methods to bottom
2020-09-14 11:18:00 -07:00
Bartłomiej Dach
a377cccb4d
Unsubscribe from track changed event on disposal
2020-09-14 17:10:35 +02:00
Bartłomiej Dach
6ed4c7caef
Merge branch 'master' into flaky-song-select-tests-v2
2020-09-14 16:42:40 +02:00
Dean Herbert
daf54c7eb9
Revert EditorBeatmap.Remove API
2020-09-14 17:55:41 +09:00
Dan Balasescu
3118f635f6
Merge branch 'master' into editor-fix-multiple-selection
2020-09-14 16:45:30 +09:00
Dean Herbert
62c55165d4
Merge branch 'editor-fix-multiple-selection' into editor-clipboard
2020-09-14 15:47:20 +09:00
Dean Herbert
b7a06524fb
Update comment to make more sense
2020-09-14 15:47:10 +09:00
Dean Herbert
75e4f224e5
Add back accidentally removed remove
2020-09-14 15:47:04 +09:00
Dean Herbert
692f2c8489
Simplify debounced update pathway
2020-09-14 14:58:00 +09:00
Dean Herbert
320e314356
Use minimum start time to handle SelectedHitObjects not being sorted
2020-09-13 22:53:30 +09:00
Dean Herbert
c573392bb2
Remove completed todo
2020-09-13 22:31:59 +09:00
Dean Herbert
0079d94676
Merge branch 'master' into editor-clipboard
2020-09-13 22:30:13 +09:00
Bartłomiej Dach
f17b2f1359
Ensure track is looping in song select immediately
2020-09-12 20:43:17 +02:00
Dean Herbert
5e108e1d6a
Merge branch 'master' into nowplaying-collections-filter
2020-09-12 21:33:07 +09:00
Dean Herbert
1a9f0ac16a
Select new objects
2020-09-12 21:23:12 +09:00
Dean Herbert
3854caae9b
Remove secondary schedule logic
2020-09-12 21:23:12 +09:00
Dean Herbert
81f30cd264
Select blueprint if object is already selected at the point of adding
2020-09-12 21:23:11 +09:00
Dean Herbert
2d9b0acabe
Fix empty selection via keyboard shortcuts crashing
2020-09-12 21:23:10 +09:00
Dean Herbert
001cd1194c
Consume BindCollectionChanged
2020-09-11 22:53:03 +09:00
Dean Herbert
94d929d8cd
Remove unnecessary contains checks
2020-09-11 22:03:19 +09:00
Dean Herbert
08be45c9e7
Merge branch 'master' into editor-clipboard
2020-09-11 20:35:05 +09:00
Dean Herbert
97b995246a
Merge branch 'editor-fix-multiple-selection' into editor-clipboard
2020-09-11 20:34:58 +09:00
Dean Herbert
22e6df02b6
Fix editor selected hitobjects containing the selection up to five times
2020-09-11 20:27:07 +09:00
Dean Herbert
2858296c25
Avoid editor confirm-save dialog looping infinitely when using keyboard shortcut to exit
...
Will now exit without saving if the keyboard shortcut is activated twice
in a row, as expected.
Closes #10136 .
2020-09-11 19:58:37 +09:00
Dean Herbert
de3d8e83e1
Add keyboard shortcuts
2020-09-11 19:55:41 +09:00
Dean Herbert
7d7401123c
Add initial implementation of editor clipboard
2020-09-11 19:54:20 +09:00
Dean Herbert
8e028dd88f
Fix incorrect ordering of ApplyDefaults for newly added objects
2020-09-11 19:54:11 +09:00
smoogipoo
06c49070b1
Remove player collection settings
2020-09-11 16:04:09 +09:00
smoogipoo
5b80a7db5f
Re-namespace collections dropdown
2020-09-11 16:01:01 +09:00
Dean Herbert
033bd82953
Merge branch 'master' into fix-filtercontrol-order
2020-09-11 13:07:41 +09:00
Dean Herbert
b594a2a507
Import collections on initial import-from-stable step
2020-09-11 11:16:00 +09:00
smoogipoo
314cd13b74
Fix song select filter ordering
2020-09-10 23:36:22 +09:00
Dean Herbert
18d96738a1
Fix hard crash on deleting a collection with no collection selected
2020-09-10 19:52:34 +09:00
Dean Herbert
ef44c7d063
Merge branch 'master' into score-recalc
2020-09-10 18:30:41 +09:00
Dean Herbert
4faddd0088
Merge branch 'master' into collection-database
2020-09-10 00:07:49 +09:00
Dan Balasescu
75ebfe41e0
Merge pull request #10102 from peppy/editor-prompt-for-save
...
Prompt to save changes when exiting the editor
2020-09-09 23:56:41 +09:00
smoogipoo
6b56c6e83f
Rename to CollectionMenuItem
2020-09-09 23:11:19 +09:00
smoogipoo
43525614ad
Store raw BeatmapCollection in filter control
2020-09-09 23:10:21 +09:00
Dean Herbert
af412947b2
Merge branch 'master' into collection-database
2020-09-09 22:59:46 +09:00
smoogipoo
be2d34d5dc
Merge branch 'master' into score-recalc
2020-09-09 21:31:31 +09:00
Dan Balasescu
53a9804455
Merge branch 'master' into add-editor-tool-icons
2020-09-09 21:21:56 +09:00
Dean Herbert
1803ecad80
Add cancel exit button
2020-09-09 20:04:25 +09:00
Dean Herbert
c6e72dabd3
Add test coverage
2020-09-09 20:04:25 +09:00
Dean Herbert
327179a81e
Expose unsaved changes state
2020-09-09 19:42:03 +09:00
Dean Herbert
6f067ff300
Only show confirmation if changes have been made since last save
2020-09-09 19:40:41 +09:00
Dean Herbert
ac0c4fcb8c
Add prompt to save beatmap on exiting editor
2020-09-09 19:31:19 +09:00
Dean Herbert
d3957e6155
Move title specification for settings groups to constructor
...
Using an abstract property was awkward for this as it is being consumed
in the underlying constructor but could not be dynamically set in time from a
derived class.
2020-09-09 18:50:31 +09:00
Dean Herbert
c9f5005efd
Add icons for editor toolbox tools
2020-09-09 18:40:01 +09:00
smoogipoo
37a659b2af
Refactor/add xmldocs
2020-09-09 17:36:47 +09:00
smoogipoo
1a023d2c88
Fix a few more tests
2020-09-09 16:33:48 +09:00
smoogipoo
0360f7d845
Move CollectionManager to OsuGame
2020-09-09 15:39:15 +09:00
smoogipoo
4ddf5f054b
Rename BeatmapCollectionManager -> CollectionManager
2020-09-09 15:31:08 +09:00
smoogipoo
117c7ec6b2
Merge branch 'master' into score-recalc
2020-09-09 14:38:36 +09:00
Dean Herbert
66d3bda962
Merge branch 'master' into collection-database
2020-09-08 23:18:47 +09:00
Dan Balasescu
53496aab33
Merge pull request #10090 from peppy/editor-song-setup
...
Add basic metadata info editing support to editor
2020-09-08 22:26:20 +09:00
Dan Balasescu
69f482f2cf
Merge pull request #10089 from peppy/fix-editor-multiple-screens
...
Avoid multiple editor screens potentially loading on top of each other
2020-09-08 21:26:10 +09:00
Dean Herbert
c38e7d796a
Fix tab key not working
2020-09-08 19:52:56 +09:00
Dean Herbert
b55b6e3746
Bring design somewhat in line with collections dialog
2020-09-08 19:52:56 +09:00
Dean Herbert
c8281b17bd
Remove editor screen fade (looks bad)
2020-09-08 19:52:56 +09:00
Dean Herbert
fe31edfa26
Add rudimentary saving logic
2020-09-08 19:52:56 +09:00
Dean Herbert
f43f8cf6b9
Add basic setup for song select screen
2020-09-08 19:52:56 +09:00
Dean Herbert
a501df954b
Avoid multiple editor screens potentially loading on top of each other
2020-09-08 19:52:05 +09:00
smoogipoo
a5e1e8d043
Rename More... to Manage...
2020-09-08 18:57:18 +09:00
smoogipoo
ae022d7559
Show all items in dropdown, set global max height
2020-09-08 18:55:53 +09:00
smoogipoo
4962213cc4
Rename manage collections filter/text
2020-09-08 18:42:55 +09:00
Dan Balasescu
68f3a1ea9a
Merge branch 'master' into collection-database
2020-09-08 18:30:01 +09:00
smoogipoo
f581df47c8
Add "New collection..." item to dropdown
2020-09-08 18:25:09 +09:00
Dean Herbert
c3123bf117
Rename drag blueprint selection method for discoverability
2020-09-08 17:22:59 +09:00
smoogipoo
1260e30cde
Make ShowDragHandle into a bindable
2020-09-08 16:36:36 +09:00
smoogipoo
c2da3d9c84
Fix button input and tests
2020-09-08 14:36:38 +09:00
smoogipoo
8a3c8a6185
Show button when selected or preselected
2020-09-08 14:03:49 +09:00
smoogipoo
32e3f5d091
Adjust button styling
2020-09-08 13:45:26 +09:00
Dean Herbert
8b770626fa
Add missing '...' from some popup menu items
2020-09-08 12:18:08 +09:00
Dean Herbert
b15bbc882a
Move items up in menu
2020-09-08 12:04:35 +09:00
Dean Herbert
3e5ea6c42f
Change "Add to" to "Collections"
...
Doesn't make send to be 'add to' when it can also remove
2020-09-08 12:00:00 +09:00
Dean Herbert
9e559cb9ac
Merge branch 'master' into editor-new-beatmap
2020-09-08 02:58:38 +09:00
smoogipoo
ca4423af74
Fix tests
2020-09-08 00:07:12 +09:00
smoogipoo
e37c04cb6d
Change back to solid icon
2020-09-08 00:04:03 +09:00
smoogipoo
a1214512bc
Add filter control tests
2020-09-07 23:57:49 +09:00
smoogipoo
98e9c4dc25
General refactorings
2020-09-07 21:08:48 +09:00
smoogipoo
c1d255a04c
Split filter control into separate class
2020-09-07 20:44:39 +09:00
smoogipoo
120dfd50a6
Fix collection names not updating in dropdown
2020-09-07 20:29:28 +09:00
smoogipoo
b91a376f0a
Split dropdown into separate file
2020-09-07 20:06:38 +09:00
smoogipoo
6cc4517600
Merge branch 'master' into collection-database
2020-09-07 20:03:11 +09:00
Dan Balasescu
f19d9a29c5
Merge pull request #10077 from peppy/editor-bpm-usability
...
Improve usability of BPM modifying in timing setup view
2020-09-07 20:02:49 +09:00
Dean Herbert
6b50d44dde
Merge branch 'master' into editor-new-beatmap
2020-09-07 18:43:16 +09:00
Dean Herbert
4792b44911
Merge branch 'master' into editor-new-beatmap
2020-09-07 18:42:51 +09:00
Dean Herbert
1468b9589f
Increase max sane BPM value
2020-09-07 18:20:47 +09:00
Dean Herbert
98676af7bb
Move default declarations for readability
2020-09-07 18:18:50 +09:00
Dean Herbert
86512d6e8d
Add BPM entry textbox
2020-09-07 18:18:50 +09:00
Dean Herbert
6091714f15
Limit BPM entry via slider to a sane range
2020-09-07 18:18:50 +09:00
Dean Herbert
4680728b9c
Merge branch 'master' into update-dcc-exclusions
2020-09-07 18:01:44 +09:00
Dan Balasescu
476c325626
Merge branch 'master' into gameplay-disable-overlays
2020-09-07 15:34:02 +09:00
smoogipoo
9ab6d584d3
Merge branch 'master' into editor-new-beatmap
2020-09-07 14:30:41 +09:00
Dan Balasescu
e17ccdfe9f
Merge branch 'master' into combo-colors
2020-09-07 13:55:41 +09:00
Bartłomiej Dach
f138b92078
Merge branch 'master' into editor-new-beatmap
2020-09-06 18:24:02 +02:00
Yao Chung Hu
96f39dd350
Merge remote-tracking branch 'upstream/master' into visible-playfield-boundary
2020-09-05 01:50:13 -05:00
smoogipoo
4b4dd02942
Make collection name a bindable
2020-09-05 04:43:59 +09:00
smoogipoo
345fb9d8e0
Rename classes
2020-09-05 03:55:43 +09:00
smoogipoo
ebd11ae0b7
Add a collection management dialog
2020-09-05 03:52:07 +09:00
smoogipoo
1143d5d992
Update class exclusion for dynamic compilation
2020-09-04 20:41:08 +09:00
Dan Balasescu
743c888986
Merge branch 'master' into expose-wedge-icons
2020-09-04 16:22:14 +09:00
Dan Balasescu
b631430a5b
Merge pull request #10045 from peppy/add-info-wedge-icons
...
Update and add missing beatmap statistic icons to info wedge
2020-09-04 16:22:01 +09:00
smoogipoo
4399f5976c
Fix global mods being retained by rooms
2020-09-04 15:20:55 +09:00
Dean Herbert
25e142965d
Strongly type and expose default beatmap information icon implementations for other rulesets
2020-09-04 15:01:32 +09:00
Dean Herbert
fba253f131
Take user argument in CreateNew method parameters
2020-09-04 13:17:43 +09:00
Dean Herbert
1f2f21e07a
Merge branch 'master' into editor-new-beatmap
2020-09-04 13:11:59 +09:00
Dean Herbert
cd253ab055
Further tweaks to get closer to design originals
2020-09-04 13:05:39 +09:00
Dean Herbert
d6b46936a0
Adjust sizing to match updated textures with less padding
2020-09-04 12:55:28 +09:00
Lucas A
82e314da59
Fix merge conflicts.
2020-09-03 21:56:47 +02:00
Dean Herbert
a99e7a1dc2
Merge branch 'master' into add-info-wedge-icons
2020-09-03 21:57:58 +09:00
Dan Balasescu
4d9a5f7ba8
Merge branch 'master' into update-icons
2020-09-03 20:19:51 +09:00
Dean Herbert
7a0c1411b6
Merge branch 'master' into timeshift-leaderboard-topscore
2020-09-03 18:11:04 +09:00
Dean Herbert
72cb65c22f
Update and add missing beatmap statistic icons to info wedge
2020-09-03 17:52:22 +09:00
Dean Herbert
942276d88f
Remove outdated SearchableList classes
2020-09-03 16:34:58 +09:00
Dean Herbert
4c011a88ce
Merge branch 'master' into update-framework
2020-09-03 15:08:18 +09:00
Dean Herbert
fe524ec491
Merge branch 'master' into update-framework
2020-09-03 14:58:32 +09:00
Dan Balasescu
cf89a6e1a4
Merge pull request #10043 from peppy/better-outro-music-fade
...
Improve music fade on game exit
2020-09-03 14:24:46 +09:00
Dan Balasescu
84b3604192
Merge branch 'master' into game-overlay-activation-mode
2020-09-03 13:34:22 +09:00
Dean Herbert
d849f7f2b5
Use the local user's username when saving a new beatmap
2020-09-03 13:20:23 +09:00
Dean Herbert
e032844570
Start with a fresh beatmap when entering editor from main menu
2020-09-03 13:20:23 +09:00
Dean Herbert
2f42c57f4b
Add safeties to ensure the current track doesn't loop or change
2020-09-03 13:15:23 +09:00
Dean Herbert
547c8090e5
Improve game exit music fade
2020-09-03 13:15:23 +09:00
Lucas A
754274a146
Fix and add XMLDoc
2020-09-02 20:55:26 +02:00
Lucas A
3fc6a74fdf
Expose an immutable bindable in interface.
2020-09-02 19:55:46 +02:00
smoogipoo
fca0324264
Disallow being able to add dummy beatmap
2020-09-02 23:34:38 +09:00
smoogipoo
d83264f538
Add max height
2020-09-02 22:56:13 +09:00
smoogipoo
7fcbc3a814
Respond to changes in beatmap
2020-09-02 22:06:17 +09:00
smoogipoo
661eac8f1d
Add add/remove button to dropdown items
2020-09-02 22:03:38 +09:00
smoogipoo
02a908752f
Fix stackoverflow
2020-09-02 21:52:56 +09:00
smoogipoo
5ebead2bfd
Prevent ValueChanged binds to external bindable
2020-09-02 21:44:07 +09:00
smoogipoo
d363a5d164
Add basic ordering
2020-09-02 21:19:15 +09:00
smoogipoo
094ddecc95
Add dropdowns to carousel items
2020-09-02 21:08:31 +09:00
smoogipoo
6d5e155106
Change to BindableList to notify of changes
2020-09-02 20:44:26 +09:00
smoogipoo
9dde37fe40
Hook up collection filter
2020-09-02 20:25:42 +09:00
smoogipoo
bb090a55e0
Add dropdown to filter control
2020-09-02 20:25:25 +09:00
Dean Herbert
6a765d2d76
Add smooth fading between audio tracks on transition
2020-09-02 20:04:56 +09:00
Dean Herbert
c964e4036e
Merge branch 'master' into update-framework
2020-09-02 15:49:19 +09:00
Dean Herbert
249ae5df1b
Merge branch 'master' into beatmap-track-rework
2020-09-02 15:24:46 +09:00
smoogipoo
7a6e02c558
Allow null rank
2020-09-02 14:28:31 +09:00
Craftplacer
c2ade44656
Change types back
2020-09-01 17:58:06 +02:00
Craftplacer
9835d98942
Merge remote-tracking branch 'upstream/master' into combo-colors
2020-09-01 17:39:35 +02:00
smoogipoo
7e1844ed77
Fix track adjusments being reset incorrectly
2020-09-01 18:07:19 +09:00
smoogipoo
26b4226b55
Fix ModTimeRamp not working
2020-09-01 16:55:10 +09:00
Dan Balasescu
f08e7828da
Merge branch 'master' into beatmap-track-rework
2020-09-01 16:06:38 +09:00
smoogipoo
9e3b809cab
Rename to user_score to match API
2020-09-01 15:42:47 +09:00
Dean Herbert
d1f79a6a48
Fix potentially incorrect zoom level getting set on very short audio
...
track
2020-09-01 15:41:36 +09:00
Dean Herbert
d45a1521a1
Update BindableList usages
2020-09-01 11:56:23 +09:00
Dean Herbert
44c02d7d58
Merge branch 'master' into wedge-star-difficulty
2020-09-01 09:33:28 +09:00
Bartłomiej Dach
876fd21230
Apply shear to right-anchored items
2020-08-31 19:31:47 +02:00
Bartłomiej Dach
2e2f26449d
Change anchoring to TopRight
2020-08-31 19:23:19 +02:00
Bartłomiej Dach
3ca2a7767a
Exclude misses and empty window hits from UR calculation
2020-08-31 14:29:37 +02:00
Bartłomiej Dach
3b22b891d1
Add failing test cases
2020-08-31 14:29:18 +02:00
smoogipoo
5e77e8cfcf
Reduce min size of chat
2020-08-31 20:21:57 +09:00
smoogipoo
61d580b6ba
Don't highlight top score
2020-08-31 20:17:23 +09:00
smoogipoo
8cf26979fb
Allow null user score
2020-08-31 20:16:28 +09:00
smoogipoo
6ed191786f
Add support for position
2020-08-31 20:01:59 +09:00
smoogipoo
77698ec31e
Add support for showing own top score in timeshift
2020-08-31 19:54:57 +09:00
smoogipoo
d1ceb81797
Rename request
2020-08-31 19:54:41 +09:00
smoogipoo
ed74c39b55
Move UserTopScoreContainer into base leaderboard
2020-08-31 19:54:22 +09:00
Bartłomiej Dach
88ae9ca91d
Merge branch 'master' into fix-unhide-hud-not-updating-stats
2020-08-31 11:48:19 +02:00
Dan Balasescu
cccf5b8a35
Merge pull request #10017 from peppy/fix-first-editor-scroll-wheel
...
Fix first scroll wheel in editor incorrectly advancing twice
2020-08-31 18:32:34 +09:00
Lucas A
dd093f44d8
Cast base immutable bindable to mutable for testing purposes and make InitialOverlayActivationMode property protected
2020-08-31 11:26:55 +02:00
Dean Herbert
a171d0e292
Remove unused methods and classes
2020-08-31 18:14:22 +09:00
Bartłomiej Dach
7d273d631b
Do not show star difficulty on wedge if zero
2020-08-31 11:05:42 +02:00
Dean Herbert
bee01bdd38
Fix first scroll wheel in editor incorrectly advancing twice
2020-08-31 18:01:16 +09:00
Bartłomiej Dach
4736845318
Add spacing between star rating and beatmap status
2020-08-31 10:56:06 +02:00
smoogipoo
c3bfce6ccf
Add star rating to beatmap wedge
2020-08-31 15:03:41 +09:00
Dean Herbert
abdb991923
Hide misses from timing distribution graph
2020-08-31 14:15:47 +09:00
Craftplacer
db413686bb
Add BeatmapSkin to EditorBeatmap
2020-08-30 21:12:45 +02:00
Craftplacer
b39ec74bb8
Scope down to IBeatmapSkin in EditorChangeHandler
2020-08-30 16:07:06 +02:00
Craftplacer
f5c82d41eb
Remove if-cast
2020-08-30 16:06:48 +02:00
Craftplacer
00b68b050c
Merge remote-tracking branch 'upstream/master' into combo-colors
2020-08-30 10:16:38 +02:00
Lucas A
03b7c8b889
Remove unneeded access modifier.
2020-08-29 19:39:50 +02:00
Lucas A
8de7744b52
Add back disabling of overlays on exiting game.
2020-08-29 19:34:53 +02:00
Lucas A
ad223bc460
Make game bindable immutable.
2020-08-29 19:34:53 +02:00
Lucas A
5949a281fc
Make Introduce bindable property OverlayActivationMode in OsuScreen
2020-08-29 19:34:35 +02:00
Joehu
0a643fd5e5
Fix replay download button always being disabled when initial score's replay is unavailable
2020-08-29 09:33:01 -07:00
smoogipoo
c1838902a6
Add to more places
2020-08-28 22:51:48 +09:00
Dan Balasescu
4765f989b6
Merge branch 'master' into unstable-rate
2020-08-28 16:02:13 +09:00
Dan Balasescu
de222ddc24
Merge pull request #9984 from Poliwrath/lingering-circles
...
Fix lingering small ring in circles! intro
2020-08-28 15:15:56 +09:00
Bartłomiej Dach
6846a245f4
Reapply lost anchoring fix
2020-08-27 20:51:28 +02:00
Bartłomiej Dach
ea1f07e311
Simplify/rename SimpleStatisticRow mess
2020-08-27 20:37:10 +02:00
Bartłomiej Dach
ce013ac9b4
Make statistic header optional
2020-08-27 20:18:53 +02:00
Bartłomiej Dach
f152e1b924
Revert IStatisticRow changes
2020-08-27 20:13:44 +02:00
Bartłomiej Dach
f8042e6fd3
Add fade to prevent jarring transitions
2020-08-26 22:34:28 +02:00
Bartłomiej Dach
c3197da3da
Adjust simple statistic item font sizes
2020-08-26 22:34:28 +02:00
Bartłomiej Dach
d81d538b7e
Move out row anchor/origin set to one central place
2020-08-26 22:34:27 +02:00
Bartłomiej Dach
5973e2ce4e
Add component for unstable rate statistic
2020-08-26 22:06:27 +02:00
Bartłomiej Dach
7c3368ecbe
Reintroduce SimpleStatisticRow as a data class
2020-08-26 19:33:33 +02:00
Bartłomiej Dach
f5e52c80b4
Rename {-> Drawable}SimpleStatisticRow
2020-08-26 19:25:59 +02:00
Bartłomiej Dach
927a2a3d2d
Introduce IStatisticRow interface
2020-08-26 19:19:42 +02:00
Poliwrath
edc15c965c
Update osu.Game/Screens/Menu/IntroSequence.cs
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-08-26 12:52:39 -04:00
Dean Herbert
f65991f31f
Revert some usages based on review feedback
2020-08-26 23:28:58 +09:00
Dean Herbert
b51db90147
Merge branch 'master' into beatmap-track-rework
2020-08-26 23:20:56 +09:00
Poliwrath
c50e495e03
fix lingering small ring in circles! intro
2020-08-26 02:49:55 -04:00
Bartłomiej Dach
f09f882cc7
Add component for displaying simple statistics on result screen
2020-08-25 22:51:40 +02:00
Bartłomiej Dach
29b4d98aac
Show retry/fail graph when either list is present
2020-08-24 20:41:50 +02:00
Bartłomiej Dach
cc6ae8e3bd
Fix crash if only one count list is received from API
2020-08-24 20:41:31 +02:00
Dean Herbert
dca307e933
Use beatmap directly in ReadyButton
2020-08-24 13:02:39 +09:00
Craftplacer
e6646b9877
Resolve review comments
2020-08-23 15:08:02 +02:00
Dean Herbert
122265ff0e
Revert non-track usage
2020-08-22 19:47:08 +09:00
Keijia
b5b2e523ad
change switch cases
2020-08-22 12:10:31 +03:00
Keijia
0b6185cd14
add "hp" filter keyword
2020-08-22 01:09:35 +03:00
Dean Herbert
f63d1ba612
Remove stray call to LoadTrack that was forgotten
2020-08-21 18:52:53 +09:00
Dean Herbert
1edafc39ba
Fix intro welcome playing double due to missing conditional
2020-08-21 18:33:24 +09:00
Dean Herbert
a47b8222b5
Restore multiplayer to use beatmap track
2020-08-21 17:11:29 +09:00
Dean Herbert
70697cf1a0
Restore remaining editor components to use Beatmap.Track
2020-08-21 17:11:29 +09:00
Dean Herbert
3b03116179
Remove unnecessary using statement
2020-08-21 16:45:59 +09:00
Dean Herbert
0ae460fb8f
Avoid beatmap load call in IntroScreen
2020-08-21 15:50:14 +09:00
Dean Herbert
f7e4feee34
Update remaining Player components to use WorkingBeatmap again
2020-08-21 15:25:57 +09:00
Dean Herbert
0b0ff62647
Switch timeline to use track directly from beatmap again
2020-08-21 14:49:34 +09:00
Dean Herbert
357fb3a10e
Merge branch 'master' into beatmap-track-rework
2020-08-21 12:53:09 +09:00
Dean Herbert
5714c761eb
Merge pull request #9768 from frenzibyte/allow-counter-customize-sprite-text
...
Allow providing custom sprite text for RollingCounter<T>
2020-08-20 00:14:48 +09:00
Salman Ahmed
ee9fa11d14
Use With(s => ...)
extension for better readability
2020-08-19 07:47:02 +03:00
Salman Ahmed
8f1a71c6b1
Remove counter sprite attributes for not being of any reasonable use
2020-08-19 07:44:45 +03:00
Dean Herbert
5ade1e8259
Merge branch 'master' into beatmap-track-rework
2020-08-18 13:03:49 +09:00
Dean Herbert
b969bc03e0
Add loading spinner while editor screen loads
2020-08-18 00:47:32 +09:00
Dean Herbert
93a8bc3d5a
Remove local reset method in GameplayClockContainer
2020-08-17 22:36:09 +09:00
Dean Herbert
d9debef156
Add explicit LoadTrack method
2020-08-17 15:38:16 +09:00
Dean Herbert
0c4aefb15e
Merge branch 'master' into beatmap-track-rework
2020-08-17 15:00:29 +09:00
Lucas A
589d4eeb52
Remove setting.
2020-08-16 17:18:40 +02:00
Dean Herbert
5d433c0b05
Fix a couple of new Resharper inspections
2020-08-16 23:11:29 +09:00
Dean Herbert
a6708c4286
Rename resolved variable in MainMenu
2020-08-16 23:04:54 +09:00
Shane Woolcock
85b3fff9c8
Update mouse confine when gameplay state changes
2020-08-16 23:11:09 +09:30
Dean Herbert
71f4e753f0
Merge branch 'master' into beatmap-track-rework
2020-08-16 22:35:32 +09:00
Craftplacer
cfd82104db
Minor changes and improvements
2020-08-16 01:00:28 +02:00
Craftplacer
48bdbb0cfb
Use existing field in Editor
2020-08-15 23:46:10 +02:00
voidedWarranties
f587781058
Allow LoungeSubScreen to be null (fix test)
2020-08-15 14:27:49 -07:00
Craftplacer
1448c9e381
Merge remote-tracking branch 'upstream/master' into combo-colors
2020-08-15 23:01:38 +02:00
voidedWarranties
7a33a6b08a
Merge remote-tracking branch 'upstream/master' into duplicate-multi-room
2020-08-15 13:07:12 -07:00
voidedWarranties
9e4b9188e1
Cache LoungeSubScreen, separate method, rename option
2020-08-15 13:06:16 -07:00
Craftplacer
c4a7fac760
Add required parameters and other various changes
2020-08-15 22:03:24 +02:00
Bartłomiej Dach
a426ff1d5b
Refactor gameplay menu overlay to fix regression
2020-08-15 14:18:50 +02:00
Dean Herbert
e465afa280
Merge branch 'master' into beatmap-track-rework
2020-08-14 20:02:43 +09:00
Dan Balasescu
b7ae70ff96
Merge branch 'master' into fix-skinnable-sound-mute
2020-08-14 19:01:32 +09:00
Dan Balasescu
626cd4042f
Merge branch 'master' into delay-beatmap-load
2020-08-14 15:09:30 +09:00
smoogipoo
0500d82b5b
Fix playlist items sharing mod instances
2020-08-13 19:48:41 +09:00
Lucas A
84cb36b6a8
Defer subscriptions for updateOverlayActivationMode() to OnEntering()
2020-08-13 10:57:18 +02:00
Dean Herbert
99bea6b8e9
Add missing null check (player construction is potentially delayed now)
2020-08-13 12:52:35 +09:00
Dean Herbert
27cd9e119a
Delay beatmap load until after transition has finished
...
Previously the beatmap would begin loading at the same time the
`PlayerLoader` class was. This can cause a horribly visible series of
stutters, especially when a storyboard is involved.
Obviously we should be aiming to reduce the stutters via changes to the
beatmap load process (such as incremental storyboard loading,
`DrawableHitObject` pooling, etc.) but this improves user experience
tenfold in the mean time.
2020-08-13 12:04:32 +09:00
Dean Herbert
429ad783cf
Merge branch 'update-framework' into beatmap-track-rework
2020-08-12 23:35:46 +09:00
Dean Herbert
05b06e7451
Merge branch 'master' into fix-skinnable-sound-mute
2020-08-12 22:01:04 +09:00
Craftplacer
69590113d6
Temporary changes
2020-08-12 06:40:21 +02:00
smoogipoo
c0031955c9
Update with further framework changes
2020-08-12 01:50:18 +09:00
smoogipoo
e47a1eb313
Use adjustable ITrack
2020-08-12 01:41:21 +09:00
smoogipoo
eec94e1f53
Make track not-null in GameplayClockContainer/FailAnimation
2020-08-12 00:51:43 +09:00
smoogipoo
070d71ec27
More cleanups
2020-08-12 00:48:38 +09:00
smoogipoo
7d35893ecd
Make MusicController non-nullable
2020-08-11 12:40:58 +09:00
smoogipoo
c66a14e9c5
Remove beatmap from FailAnimation
2020-08-11 12:37:48 +09:00
Dean Herbert
d1b106a3b5
Include mention of old releases in error message
2020-08-11 10:59:28 +09:00
Lucas A
f74e162bbc
Fix overlay activation mode being updated when player is not current screen.
2020-08-10 20:27:42 +02:00
Lucas A
052bb06c91
Add ability to open overlays during gameplay breaks.
2020-08-10 20:13:50 +02:00
Dean Herbert
365aae799e
Merge branch 'master' into fix-skinnable-sound-mute
2020-08-10 23:55:51 +09:00
Dean Herbert
1f84e54151
Improve messaging when timeshift token retrieval fails
...
Obviously not a final solution, but should better help self-compiling
(or unofficial package) users better understand why this is happening.
2020-08-10 20:16:16 +09:00
voidedWarranties
3a97ee4712
Context menu for duplicating multi rooms
2020-08-09 16:16:01 -07:00
Bartłomiej Dach
9a09f97478
Extract constant to avoid double initial value spec
2020-08-08 21:21:30 +02:00
smoogipoo
e87f50f74f
Rename method
2020-08-07 22:31:41 +09:00
smoogipoo
b08ebe6f81
More inspections (rider is broken)
2020-08-07 21:14:45 +09:00
smoogipoo
961c6dab54
Fix more inspections
2020-08-07 21:08:03 +09:00
smoogipoo
5002d69f69
Update inspections
2020-08-07 20:51:56 +09:00
smoogipoo
61b632516e
Ensure CurrentTrack is never null
2020-08-07 19:43:16 +09:00
Dean Herbert
e3105fd4c8
Add more resilient logic for whether to avoid playing SkinnableSound on no volume
2020-08-06 19:16:26 +09:00
smoogipoo
f8279dab32
Refactor MainMenu
2020-08-06 18:54:14 +09:00
smoogipoo
ef689d943a
Fix intros playing incorrectly
2020-08-06 18:54:08 +09:00
smoogipoo
2e3ecf71c7
Pass track from Player to components
2020-08-06 18:31:08 +09:00
smoogipoo
c8ebbc8594
Remove MusicController from EditorClock
2020-08-06 18:19:55 +09:00
smoogipoo
f058f5e977
Fix incorrect value being set
2020-08-06 16:24:14 +09:00
smoogipoo
5c05fe3988
Expose track from MusicController
2020-08-06 16:24:14 +09:00
smoogipoo
6e42b8219c
Move track to MusicController, compiles
2020-08-06 16:24:14 +09:00
smoogipoo
9a00ad48c6
Update components to use extension methods
2020-08-06 14:43:39 +09:00
Lucas A
71895964f4
Refactor overlay activation logic and reword tip.
2020-08-05 11:21:09 +02:00
Lucas A
30c7a6f6a7
Fix CI issue and use method instead of triggering change on bindable.
2020-08-03 21:33:18 +02:00
Lucas A
242a035f7e
Apply review suggestions.
2020-08-03 21:25:45 +02:00
Salman Ahmed
9d10658e3c
Allow providing custom sprite text for RollingCounter<T>
2020-08-03 20:14:17 +03:00
Lucas A
25ebb8619d
Add tests.
2020-08-03 16:04:11 +02:00
Dean Herbert
4d6f60edaf
Fix multiplayer match select forcing playback even when user paused
2020-08-03 22:43:50 +09:00
Lucas A
fe97d472df
Enable back overlays when a replay is loaded.
2020-08-02 21:53:13 +02:00
Lucas A
f1ba576438
Disable overlay activation when in gameplay.
2020-08-02 21:34:35 +02:00
smoogipoo
04b71a0c7c
Adjust xmldoc
2020-07-31 23:16:55 +09:00
smoogipoo
308f8bf9bf
Fix inverted naming
2020-07-31 23:11:42 +09:00
Dan Balasescu
d63f040477
Merge branch 'master' into multi-position
2020-07-31 23:10:25 +09:00
Dean Herbert
909b38a019
Merge branch 'master' into multi-pagination
2020-07-31 22:41:24 +09:00
smoogipoo
4f3795486d
Post-process responses to populate positions
2020-07-31 22:36:44 +09:00
smoogipoo
b361761d86
Add position display in contracted score panels
2020-07-31 22:02:25 +09:00
smoogipoo
f1e721e396
Rewrite test scene and add more tests
2020-07-31 21:39:50 +09:00
smoogipoo
17018ffa8b
Fix potentially triggering new requests too early
2020-07-31 21:33:04 +09:00
smoogipoo
a4a4c87612
Fix incorrect score id being used
2020-07-31 21:21:48 +09:00
smoogipoo
9966d4f3b3
Add more loading spinners
2020-07-31 19:57:05 +09:00
smoogipoo
6d728d27fc
Cleanup/consolidate indexing request
2020-07-31 19:11:56 +09:00
Dean Herbert
c4af19be76
Merge branch 'master' into send-exe-hash
2020-07-30 16:44:39 +09:00
Dean Herbert
e6a2409415
Merge branch 'master' into panel-load-debounce
2020-07-30 16:03:17 +09:00
Dean Herbert
5e8e9f1424
Merge branch 'master' into send-exe-hash
2020-07-30 15:32:10 +09:00
Dean Herbert
9e6d562872
Send in initial score request instead
2020-07-29 13:18:40 +09:00
Dean Herbert
2ca3c8a0ff
Merge pull request #9700 from ynjoe/vertical-failing-layer
2020-07-29 12:50:36 +09:00
Dean Herbert
6c7e806eac
Include executable hash when submitting multiplayer scores
2020-07-29 12:39:18 +09:00
smoogipoo
db91d1de50
Use response params in next page request
2020-07-28 21:45:12 +09:00
smoogipoo
9f6446d836
Add xmldocs + refactoring
2020-07-28 21:45:12 +09:00
smoogipoo
42e88c53d7
Embed behaviour into UserCoverBackground
2020-07-28 20:50:55 +09:00
smoogipoo
54d2f2c8cd
Delay loading of cover backgrounds in score panels
2020-07-28 20:34:09 +09:00
smoogipoo
255b733fe8
Merge branch 'master' into multi-pagination
2020-07-28 20:20:54 +09:00
Joe Yuan
e795b1ea31
Failing effect displays vertically
2020-07-28 00:42:48 -07:00
Dan Balasescu
33330701e1
Merge branch 'master' into osu-logo-no-update-transforms
2020-07-28 15:36:37 +09:00
Dean Herbert
cc0d5d74d7
Merge branch 'master' into Issue#9170
2020-07-28 13:36:42 +09:00
Dean Herbert
5b724d9659
Adjust damp base component to provide ample tweening
2020-07-27 15:10:32 +09:00
Dean Herbert
c1b9b847ec
Merge branch 'master' into grey-logo-animation
2020-07-27 14:10:52 +09:00
Dean Herbert
5e6f1f6fbf
Merge branch 'master' into osu-logo-no-update-transforms
2020-07-27 13:25:22 +09:00
Dean Herbert
d2aaba3918
Merge pull request #9637 from smoogipoo/beatmap-difficulty-manager
...
Add dynamic computation of beatmap difficulty
2020-07-24 16:53:17 +09:00
smoogipoo
877b985e90
Remove local cancellation token
2020-07-24 16:11:28 +09:00
smoogipoo
b10b99a670
Change method signatures to remove tracked/untracked
2020-07-24 13:52:43 +09:00
Dean Herbert
0d44769288
Merge branch 'master' into osu-logo-no-update-transforms
2020-07-24 10:36:37 +09:00
smoogipoo
76284a0f01
Move cancellation out of condition
2020-07-23 23:18:51 +09:00
Dan Balasescu
01edce7130
Merge pull request #9642 from peppy/score-panel-expanded-cover-background
...
Add user cover background to expanded version of score panel
2020-07-23 20:36:15 +09:00
Dean Herbert
ee05d5cb14
Remove no-longer-necessary play trigger on skin change
2020-07-23 09:06:15 +09:00
jorolf
50f72ac9cb
rename classes
2020-07-22 22:10:59 +02:00
smoogipoo
46ea775cfb
Implement paging
2020-07-22 20:24:55 +09:00
smoogipoo
f8401a76a2
Use show/index requests in results screen
2020-07-22 19:40:00 +09:00
smoogipoo
d9633fee64
Rename request
2020-07-22 18:47:09 +09:00
smoogipoo
0957c5f74c
Re-namespace multiplayer requests/responses
2020-07-22 18:34:04 +09:00
Dean Herbert
fea6389f69
Hide HUD elements during break time by default
2020-07-22 12:41:06 +09:00
Dean Herbert
cccb47e6e0
Add user cover background to expanded version of score panel
2020-07-22 11:29:23 +09:00
smoogipoo
107b5ca4f2
Add support for bindable retrieval
2020-07-21 23:13:04 +09:00
smoogipoo
599a15edb8
Merge branch 'master' into beatmap-difficulty-manager
2020-07-21 20:09:53 +09:00
Gagah Pangeran
95f52573f7
change font size
2020-07-21 15:58:25 +07:00
Gagah Pangeran
055e31ddd5
update minor
2020-07-20 18:37:02 +07:00
Gagah Pangeran
6a144fba80
add epilepsy warning in metadata display
2020-07-20 17:24:17 +07:00
Dean Herbert
20096f9aea
Remove remaining per-Update transform in OsuLogo to reduce allocations
2020-07-18 11:44:18 +09:00
Dean Herbert
c803d88e22
Merge branch 'master' into Issue#9170
2020-07-17 19:33:22 +09:00
Dean Herbert
a39c4236c7
Fix multiple issues and standardise transforms
2020-07-17 19:08:50 +09:00
Dean Herbert
aa992f2e34
Merge branch 'master' into Issue#9170
2020-07-17 18:29:40 +09:00
Dan Balasescu
288c0402ee
Merge branch 'master' into editor-show-selected-count
2020-07-17 18:00:35 +09:00
Dan Balasescu
96c12bdf61
Merge pull request #9591 from peppy/editor-fix-double-click
...
Fix editor double-click incorrectly firing when clicks target different hitobjects
2020-07-17 17:58:15 +09:00
Dean Herbert
b4b230288b
Shift hue of selection handler box to not collide with blueprints
2020-07-17 17:51:39 +09:00
Dean Herbert
ea6f257dc2
Add a display of count of selected objects in editor
2020-07-17 17:48:27 +09:00
Dean Herbert
222a22182e
Fix double-click incorrectly firing across disparate targets
2020-07-17 17:03:57 +09:00
Dean Herbert
039790ce4f
Perform next timing point check before ensuring movement
2020-07-17 16:40:02 +09:00
Dean Herbert
e96e558728
Fix reversing scroll direction not always behaving as expected
2020-07-17 16:03:23 +09:00
smoogipoo
9a52058a7a
Update carousel beatmap SR on mod/ruleset changes
2020-07-16 21:08:24 +09:00
smoogipoo
24f14751ce
Update beatmap details SR on ruleset/mod changes
2020-07-16 21:08:08 +09:00
jorolf
87f7d8744d
simplify transform
2020-07-15 12:40:46 +02:00
Dean Herbert
fe68e8276d
Merge branch 'master' into logo-shader
2020-07-15 19:06:35 +09:00
Dean Herbert
675544ec2f
Tidy up colour and variable usage
2020-07-15 19:03:59 +09:00
Dean Herbert
afae79662c
Merge pull request #9566 from Joehuu/seek-replay/auto-with-arrow-keys
2020-07-15 18:46:44 +09:00
Dean Herbert
0125a7ef3b
Fix single-frame glitch in SS grade display animation
2020-07-15 15:36:17 +09:00
Dan Balasescu
b1c06c1e90
Merge branch 'master' into fix-screens-blocking-home/altf4
2020-07-15 13:17:53 +09:00
smoogipoo
e2c043737d
Reword xmldoc to specify intended usage
2020-07-15 13:08:57 +09:00
smoogipoo
350a4a153b
Fix possible nullref
2020-07-15 12:59:31 +09:00
Joehu
ecbd8067e9
Add ability to seek replays/auto with arrow keys
2020-07-14 20:18:47 -07:00
Joehu
73e1bf0d89
Check sub screen's OnBackButton instead
2020-07-14 13:19:48 -07:00
Joehu
21ed9df1ea
Add xmldoc for OnBackButton
2020-07-14 13:14:59 -07:00
Dan Balasescu
c49ce65326
Merge pull request #9540 from peppy/gameplay-pause-via-middle-mouse
...
Allow pausing gameplay via middle mouse button
2020-07-14 21:13:31 +09:00
Dan Balasescu
3bae34653e
Merge branch 'master' into gameplay-pause-via-middle-mouse
2020-07-14 20:31:35 +09:00
Dean Herbert
2626ab41c3
Add implicit braces for clarity
2020-07-14 20:15:31 +09:00
Dean Herbert
c7d3b025ad
Rename variable and change default to true
2020-07-14 20:11:54 +09:00
Dean Herbert
690f2fd482
Merge branch 'master' into always-combo-break
2020-07-14 20:11:02 +09:00
Dan Balasescu
0e31982b4e
Merge pull request #9557 from peppy/fix-user-request-population
...
Fix some web requests retrieving the user too early
2020-07-14 17:56:31 +09:00
Joehu
36041fc245
Fix back button not working correctly with multi song select's mod select
2020-07-14 00:29:57 -07:00
Joehu
3573460d9c
Fix multiplayer screens blocking home and alt f4
2020-07-14 00:02:01 -07:00
Joehu
daa7430fd8
Fix statistics screen blocking retry, home, and alt f4
2020-07-14 00:00:43 -07:00
Joehu
4caf4d31d4
Fix mod select blocking home and alt f4 in song select
2020-07-14 00:00:10 -07:00
Joehu
1a2f5cb477
Add OnBackButton bool to OsuScreen
2020-07-13 23:59:20 -07:00
Dean Herbert
7fe69bb199
Fix some web requests retrieving the user too early
2020-07-14 13:07:17 +09:00
Dean Herbert
42dfc47fe3
Merge branch 'master' into legacy-background
2020-07-14 11:03:47 +09:00
Dean Herbert
f36c23928b
Merge branch 'master' into legacy-background
2020-07-14 11:02:24 +09:00
Dean Herbert
064814f70a
Merge branch 'master' into gameplay-pause-via-middle-mouse
2020-07-14 07:39:02 +09:00
Dean Herbert
ef3ab7a858
Merge branch 'master' into fix-carousel-filter-application
2020-07-13 17:05:45 +09:00
Joehu
79ea6dbd5c
Only allow link clicking and tooltips of multi room drawables when selected
2020-07-12 22:24:11 -07:00
Dean Herbert
0718e9e4b6
Update outdated comment
2020-07-13 13:08:41 +09:00
Dean Herbert
f442df75a9
Add missing released conditional
2020-07-13 09:00:10 +09:00
Dean Herbert
c1aafe83fa
Add note about future behaviour
2020-07-12 23:05:47 +09:00
Dean Herbert
08696b9bca
Allow pausing gameplay via middle mouse button
2020-07-12 23:03:03 +09:00
Dean Herbert
ab11a112b7
Fix correct filter criteria not being applied to beatmap carousel if beatmaps take too long to load
2020-07-12 22:33:41 +09:00
Joehu
fa0c2d7f84
Fix room name overflowing on multiplayer lounge
2020-07-10 10:42:41 -07:00
Yao Chung Hu
d40f209f4b
Move Playfield Border to OsuPlayfield Ruleset
2020-07-10 07:36:21 -05:00
Yao Chung Hu
0d95b768aa
Rename and Move EditorPlayfieldBorder to PlayfieldBorder for general purpose
2020-07-10 07:34:48 -05:00
Dan Balasescu
895c129151
Merge pull request #9492 from peppy/ensure-music-playing-mainmenu-lounge
...
Ensure music playing when returning to lounge or main menu
2020-07-10 21:23:24 +09:00
Dan Balasescu
6345af6f3b
Merge pull request #9494 from peppy/playlist-results-button
...
Replace large "show results" button with embedded button each playlist item
2020-07-10 20:58:12 +09:00
Dan Balasescu
be2c892c30
Merge branch 'master' into ensure-music-playing-mainmenu-lounge
2020-07-10 20:48:16 +09:00
Dean Herbert
d3367bb0f1
Remove unused public property
2020-07-10 20:32:47 +09:00
Dean Herbert
9556166c1b
Replace large "show results" button with embedded button each playlist item
2020-07-10 20:19:17 +09:00
smoogipoo
fe585611e7
Fix + simplify web request
2020-07-10 19:54:09 +09:00
Dean Herbert
64e8dce1ad
Highlight spotlight rooms with a different colour
2020-07-10 19:38:33 +09:00
Dean Herbert
cf3251a950
Default to showing all rooms
2020-07-10 19:38:13 +09:00
Dean Herbert
24132c7cf9
Merge branch 'master' into multiplayer-categories
2020-07-10 19:00:57 +09:00
Dean Herbert
1760cc2427
Fix behavioural regression by splitting methods out
2020-07-10 18:03:56 +09:00
smoogipoo
926279e39b
Implement category dropdown for multiplayer
2020-07-10 17:26:42 +09:00
Dean Herbert
44fdb5b82e
Ensure music starts when returning to lounge or main menu
2020-07-10 17:20:27 +09:00
smoogipoo
1f2689f7cb
Merge branch 'master' into un-nest-overlined-display
2020-07-10 15:37:43 +09:00
smoogipoo
2ed8d42d22
Remove whitespace
2020-07-10 15:37:13 +09:00
smoogipoo
a9faa11dcb
Add back playlist header
2020-07-10 15:37:08 +09:00
Dan Balasescu
14eaf75009
Merge branch 'master' into un-nest-overlined-display
2020-07-10 14:41:31 +09:00
Yao Chung Hu
321815f535
Add playfield bounds box with toggle and dim slider
2020-07-09 14:01:28 -05:00
Dean Herbert
973b6c680a
Merge branch 'master' into un-nest-overlined-display
2020-07-09 18:26:23 +09:00
Dean Herbert
115bb40816
Select via select action
2020-07-09 18:25:14 +09:00
Dean Herbert
601101147e
Allow keyboard selection of rooms at the multiplayer lounge
2020-07-09 18:25:14 +09:00
Dean Herbert
80f6f87e01
Scroll selected room into view on selection
2020-07-09 17:45:29 +09:00
Dean Herbert
69062a3ed1
Remove unused search container in lounge
2020-07-09 17:43:26 +09:00
Dean Herbert
f231b5925f
Add "show converted" checkbox to song select for convenience
2020-07-09 13:47:23 +09:00
Dean Herbert
bbbe8d6f68
Remove group selector for now, tidy up code somewhat
2020-07-09 13:47:11 +09:00
Dean Herbert
fd56db2156
Merge pull request #9467 from peppy/less-poo
2020-07-09 12:41:37 +09:00
Dean Herbert
efdf179906
Replace poo icon at disclaimer screen
2020-07-09 12:31:20 +09:00
Joehu
c10cf2ef49
Fix multi header title not aligning correctly when changing screens
2020-07-08 19:01:12 -07:00
BananeVolante
f03303573e
formating
2020-07-08 13:54:22 +02:00
Dean Herbert
35d3292200
Remove nesting of components inside overlined component
...
I think this makes things a bit more readable. The only weird case is
the transfer of details from the component to the `OverlinedHeader`, but
bindables make it not too bad.
2020-07-08 14:45:51 +09:00
Dean Herbert
4b4fcd39e3
Further layout adjustments based on fedback
2020-07-07 18:40:21 +09:00
Dean Herbert
4a1bea4874
Adjust layout to be two columns (and more friendly to vertical screens)
2020-07-07 18:28:43 +09:00
Dean Herbert
88b2a12c09
Reduce footer height to match back button
2020-07-07 17:38:42 +09:00
Dean Herbert
56a8b0d3f5
Merge branch 'master' into match-subscreen-redesign
2020-07-07 17:16:05 +09:00
Dean Herbert
3f3bfb1ffb
Minor reshuffling / recolouring
2020-07-06 23:51:16 +09:00
Dean Herbert
a650a5ec83
Move dialog classes to own file
2020-07-06 23:44:26 +09:00
Dean Herbert
f566787988
Merge branch 'master' into custom-storage-startup-exception
2020-07-06 23:32:39 +09:00
smoogipoo
ddac511c8c
Move start fresh button above
2020-07-06 22:41:51 +09:00
Dan Balasescu
8f792603ee
Apply suggestions from code review
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2020-07-06 22:40:45 +09:00
smoogipoo
1effe71ec2
Add dialog for storage options
2020-07-06 22:03:09 +09:00
jorolf
52b313f290
change textures
2020-07-04 19:06:26 +02:00
BananeVolante
e8f23e35a5
WIP : replaced TransformBindableTo by VolumeTo
...
Currently, the VolumeTO calls taht use a fading does not do anything.
calling VolumeTo calls pauseLoop.samplesContainer.TransformBindableTo(....), while i used to call pauseLoop.TransformBindableTo(....)
2020-07-03 14:33:42 +02:00
BananeVolante
3c2870ea4b
Merge branch 'master' of https://github.com/ppy/osu into Issue#9170
2020-07-03 14:00:32 +02:00
Shivam
4ded6d1913
Change background path with resource change
2020-07-03 11:36:03 +02:00
Joehu
718f06c690
Use Mod.AdjustRank() instead
2020-07-02 12:35:32 -07:00
Shivam
e80a5a085a
Make backgroundName local
2020-07-02 19:45:18 +02:00
Shivam
18e30a7fc4
Implement background switching based on the intro
...
Only the Welcome intro has its own unique background right now
2020-07-02 19:23:13 +02:00
BananeVolante
53947faec5
Merge branch 'master' of https://github.com/ppy/osu into Issue#9170
...
updated local code
2020-07-02 16:26:26 +02:00
Joehu
fa252d5e95
Fix score panel not showing silver s/ss badges on hd/fl plays
2020-07-01 17:37:38 -07:00
Joehu
5c1f1ab622
Fix avatar in score panel being unclickable when statistics panel is visible
2020-07-01 14:31:06 -07:00
BananeVolante
ab1eb469af
removed unneeded null checks
2020-07-01 13:30:23 +02:00
BananeVolante
ab134c0ed7
removed unneeded information in a comment
2020-07-01 13:27:33 +02:00
BananeVolante
946fcf75ac
Merge branch 'master' of https://github.com/ppy/osu into Issue#9170
...
update local code
2020-07-01 13:06:44 +02:00
Dean Herbert
ed20bdf2e9
Merge pull request #9403 from smoogipoo/fix-results-ui-scale
...
Fix scroll container height on smaller ui scales
2020-07-01 18:45:49 +09:00
Dean Herbert
4ae70f2679
Merge pull request #9393 from smoogipoo/improve-wedge-quality
...
Improve quality of song select beatmap wedge
2020-07-01 18:25:14 +09:00
smoogipoo
1701c844a6
Fix scroll container height on smaller ui scales
2020-06-30 16:36:53 +09:00
Dan Balasescu
0e80d6629b
Merge branch 'master' into red-tint
2020-06-30 15:44:22 +09:00
Derrick Timmermans
bb81f908fb
Exclude EmptyHitWindow from being considered in TimingDistributionGraph
2020-06-29 15:53:56 +08:00
smoogipoo
af7494b232
Improve quality of song select beatmap wedge
2020-06-29 13:58:35 +09:00
Shivam
444504f2b9
Expose MainMenu Track as internal get private set
2020-06-29 02:10:40 +02:00
Shivam
24dceb9f84
Make only "Welcome" loop
2020-06-29 01:41:47 +02:00
Shivam
270384e71e
Remove redundant get set
2020-06-29 00:59:44 +02:00
Shivam
5689f27987
Make sure it only loops for themed intros if true
2020-06-29 00:54:06 +02:00
Shivam
ffbce61ca8
Add the option to loop the intro in the main menu
2020-06-29 00:42:47 +02:00
Bartłomiej Dach
678767918e
Centralise logic further
2020-06-28 23:32:04 +02:00
jorolf
820056cc4e
update colours/transformations
2020-06-28 17:53:53 +02:00
Dean Herbert
6547e07e56
Merge pull request #9377 from smoogipoo/fix-unsafe-mod-deserialisation
...
Fix crash due to unsafe mod deserialisation
2020-06-29 00:02:29 +09:00
Dean Herbert
006adf0fb5
Change logic to ignore rooms completely after first error
2020-06-28 22:45:13 +09:00
Dean Herbert
e5a901cec7
Merge branch 'master' into results-screen-statistics-overlapping-transition
2020-06-28 22:14:22 +09:00
Bartłomiej Dach
3637bf2f9b
Clean up member order & access modifiers
2020-06-26 19:39:55 +02:00
Bartłomiej Dach
02f590309d
Add xmldoc for public property
2020-06-26 19:39:55 +02:00
Bartłomiej Dach
a63b6a3ddf
Simplify binding
2020-06-26 19:39:55 +02:00
Bartłomiej Dach
415e1c05ff
Simplify implementation
2020-06-26 19:39:55 +02:00
Bartłomiej Dach
3783fe8d6a
Rename fields for clarity
2020-06-26 19:39:53 +02:00
smoogipoo
e8d36bc3cb
Don't trigger the same exception multiple times
2020-06-27 00:23:23 +09:00
smoogipoo
c233dc4768
Add some global error handling
2020-06-27 00:16:16 +09:00
Power Maker
798e8e7a8d
Fix CI fail
2020-06-26 15:12:01 +02:00
Power Maker
efeaa1cc10
Make some changes, fix and add tests
2020-06-26 14:58:42 +02:00
Power Maker
97a212a7f6
Hide red tint based on "Show health display even when you can't fail" setting
2020-06-26 14:32:01 +02:00
BananeVolante
fdc9756b3f
Merge branch 'master' of https://github.com/ppy/osu into Issue#9170
2020-06-26 14:23:37 +02:00
BananeVolante
a4bb238c45
fixed bug preventing the pause loop from playing during the first pause after changing a skin
2020-06-26 14:07:27 +02:00
smoogipoo
099416b4c3
Move check inside next difficulty selection
2020-06-26 21:03:34 +09:00
smoogipoo
8f6d52550f
Fix potential exception if button is pressed before selection
2020-06-26 20:32:13 +09:00
smoogipoo
1b4c31a84f
Remove double schedule
2020-06-26 20:14:08 +09:00
smoogipoo
e3d654d33f
Cleanup
2020-06-26 20:14:02 +09:00
BananeVolante
7d2d6a52c9
now uses SkinnableSample instead of Drawable sample
...
Still does not support switching skins after Pause overlay loading,
there will be no sound for the first pause (works fine the the nexts)
Also, the pause loop seems to play for approximately 1 second when exiting the
screens via restart or quit
finally, since SkinnableSound does not play a sound if its aggregate
volume is at 0, i had turn up the volume a bit before playing the loop
2020-06-25 18:58:04 +02:00
smoogipoo
8d47c908ad
Remove breadcrumb fade
2020-06-25 22:28:45 +09:00
smoogipoo
44a8039e92
Reduce header further
2020-06-25 22:22:24 +09:00
smoogipoo
23f569351a
Add back missing beatmap results button
2020-06-25 22:22:19 +09:00
smoogipoo
b7f5a89f82
Reduce background fade opacity
2020-06-25 22:13:39 +09:00
smoogipoo
668105dd6e
Adjust boldening
2020-06-25 22:06:30 +09:00
smoogipoo
20092c58ff
Reduce spacing between recent participants tiles
2020-06-25 21:59:53 +09:00
smoogipoo
7c1dd43899
Re-style multiplayer header
2020-06-25 21:58:40 +09:00
Dean Herbert
d704a4597d
Use existing helper function for key repeat
2020-06-25 21:33:02 +09:00
smoogipoo
01fa664b7d
Add recent participants
2020-06-25 20:53:48 +09:00
smoogipoo
54f087b933
Re-layout match subscreen columns
2020-06-25 20:40:15 +09:00
BananeVolante
9e5cc1b7a2
added skin support for the pause loop
2020-06-25 13:26:42 +02:00
Dean Herbert
d7742766d0
Add key/press repeat support to carousel
2020-06-25 19:47:23 +09:00
Dean Herbert
b077a2856d
Merge branch 'master' into results-screen-statistics-overlapping-transition
2020-06-25 18:44:08 +09:00
jorolf
1409ace282
apply suggestions
2020-06-25 00:59:12 +02:00
jorolf
6f0ec36407
remove size from hue animation
2020-06-24 16:27:00 +02:00
BananeVolante
2e8f30461f
play/stops music when entering the pause overlay, instead of letting it play silently in the background
2020-06-24 14:22:12 +02:00
BananeVolante
9514a02eeb
Merge branch 'master' of https://github.com/ppy/osu into Issue#9170
2020-06-24 14:12:07 +02:00
jorolf
768e28faba
generalize and simplify animation
2020-06-24 14:11:38 +02:00
BananeVolante
53107973a3
merged 2 lines
...
Co-authored-by: Salman Ahmed <email@iisalman.me>
2020-06-24 14:01:13 +02:00
Viktor Rosvall
9e1bf71233
Added text explaining a second copy will be made
2020-06-24 11:29:38 +02:00
Dean Herbert
9119f41604
Merge branch 'master' into results-screen-statistics-overlapping-transition
2020-06-24 18:22:51 +09:00
Sebastian Krajewski
68f078c9e6
Replace logo-triangles.mp4 with shadered logo-triangles.png
2020-06-24 10:30:33 +02:00
Dean Herbert
ccb27082d5
Fix background appearing too late
2020-06-24 11:08:32 +09:00
Dean Herbert
4244024fc3
Merge branch 'master' into fallback-intro
2020-06-24 10:49:45 +09:00
Bartłomiej Dach
43be75d481
Merge branch 'master' into Issue#9170
2020-06-23 20:49:13 +02:00
Dan Balasescu
11446a7864
Merge pull request #9355 from peppy/update-framework
...
Update framework
2020-06-23 22:27:55 +09:00
Dan Balasescu
fd9ac3503f
Merge branch 'master' into fix-editor-drag-selection-while-playing
2020-06-23 21:56:31 +09:00
Dean Herbert
92cf2dd3bb
Merge pull request #9352 from smoogipoo/fix-editor-drag-exception
...
Fix exception when dragging after deleting object
2020-06-23 21:45:58 +09:00
Dean Herbert
9d753a4fc2
Update intro resource locations
2020-06-23 21:34:57 +09:00
Dean Herbert
5cdabbc8bb
Update access to FrequencyAmplitudes via span
2020-06-23 21:33:03 +09:00
Dean Herbert
14ad3835ff
Update naming
2020-06-23 21:27:01 +09:00
smoogipoo
e7238e25f9
Fix exception when dragging after deleting object
2020-06-23 20:36:09 +09:00
BananeVolante
624ad65806
formating
2020-06-23 13:09:24 +02:00
Dean Herbert
a5eac716ec
Make work for all editors based on track running state
2020-06-23 18:42:56 +09:00
Dean Herbert
53d542546e
Fix editor drag selection not continuing to select unless the mouse is moved
2020-06-23 18:04:50 +09:00
Dean Herbert
a6c6e391ca
Fix player not exiting immediately on Alt-F4
2020-06-23 17:38:30 +09:00
Dean Herbert
6bcc693c2f
Add ability to close statistics by clicking anywhere
2020-06-23 15:21:23 +09:00
Dean Herbert
49d3511063
Read amplitudes from piano reverb source
2020-06-23 13:55:44 +09:00
Dean Herbert
4554a7db33
Update naming
2020-06-23 13:49:18 +09:00
Dean Herbert
b289beca53
Fix samples being played too early
2020-06-23 13:33:33 +09:00
smoogipoo
1bf00e0c82
Schedule continuation
2020-06-22 23:22:49 +09:00
BananeVolante
579d7cedcc
Merge branch 'master' of https://github.com/ppy/osu into Issue#9170
...
updated local source
2020-06-22 15:29:05 +02:00
BananeVolante
836386d03b
removed duplicate lines
2020-06-22 15:22:13 +02:00
Dean Herbert
f60a80b263
Fix animations and general code quality
2020-06-22 21:35:52 +09:00
BananeVolante
9dea96e5fd
added pause sound with fading
2020-06-22 14:02:21 +02:00
BananeVolante
a4eb6c81c5
undid changes to the file
2020-06-22 13:40:31 +02:00
smoogipoo
ff2f3a8484
Fix div-by-zero errors with autoplay
2020-06-22 20:32:04 +09:00
smoogipoo
5c4df2e32c
Cancel load on dispose
2020-06-22 20:20:42 +09:00
smoogipoo
988baad16f
Expand statistics to fill more of the screen
2020-06-22 19:20:43 +09:00
smoogipoo
261adfc4e6
Create a local playable beatmap instead
2020-06-22 18:38:41 +09:00
Dean Herbert
8d3ed05848
Update welcome text sprite location
2020-06-22 17:42:54 +09:00
Dean Herbert
e3420dfad6
Merge branch 'master' into fallback-intro
2020-06-22 17:09:08 +09:00
smoogipoo
3ede095b9c
Apply refactorings from review
2020-06-22 15:42:55 +09:00
smoogipoo
33fdd7466c
Merge branch 'master' into results-screen-statistics-overlapping-transition
2020-06-22 15:38:48 +09:00
smoogipoo
037bd3b463
Fix possible nullref
2020-06-19 22:48:21 +09:00
smoogipoo
4cb49cd606
Add minimum height to the timing distribution graph
2020-06-19 22:21:34 +09:00
smoogipoo
486b899e8f
Rename method
2020-06-19 22:11:29 +09:00
smoogipoo
49bdd89775
Cleanup ReplayPlayer adjustments
2020-06-19 21:54:09 +09:00
smoogipoo
25abdc2903
General cleanups
2020-06-19 21:41:48 +09:00
smoogipoo
8aea8267fb
Add some padding
2020-06-19 20:58:05 +09:00
smoogipoo
5ce2c712d3
Fix statistics not being wrapped by containers
2020-06-19 20:53:43 +09:00
smoogipoo
34a8fcfd2f
Fix potential off-by-one
2020-06-19 20:53:30 +09:00
smoogipoo
83e6c3efdb
Adjust API for returning statistics
2020-06-19 20:31:52 +09:00
smoogipoo
1cbbd6b442
Move timing distribution graph to osu.Game
2020-06-19 20:03:18 +09:00
smoogipoo
a3ff25177a
Asyncify statistics load
2020-06-19 19:12:55 +09:00
smoogipoo
55196efe6e
Fix panel depth ordering
2020-06-19 18:02:54 +09:00
smoogipoo
ec16b0fc5a
Rework score panel tracking to fix visual edge cases
2020-06-19 17:28:35 +09:00
Dean Herbert
290ae37346
Add assertion of only usage game-wide
2020-06-18 23:54:20 +09:00
Dean Herbert
7da56ec7fd
Add null check and xmldoc
2020-06-18 23:52:35 +09:00
Dean Herbert
add1265d53
Block screen suspend while gameplay is active
2020-06-18 23:48:00 +09:00
smoogipoo
85a0f78600
Hide statistics panel on first exit
2020-06-18 22:48:52 +09:00
smoogipoo
53f507f51a
Fade background
2020-06-18 22:27:10 +09:00
smoogipoo
ecdfcb1955
Display placeholder if no statistics available
2020-06-18 22:21:30 +09:00
smoogipoo
6c8a24260b
Add padding
2020-06-18 17:06:05 +09:00
smoogipoo
c31a05977d
Re-implement statistics as a click-in panel
2020-06-18 16:50:45 +09:00
smoogipoo
725b2e540b
wip
2020-06-17 22:29:00 +09:00
smoogipoo
5e74985eda
Add scrolling capability to results screen
2020-06-17 19:28:40 +09:00
Shivam
693a760a19
Use RelativeSizeAxes for width
2020-06-16 15:44:59 +02:00
Shivam
d1086a49a3
Merge branch 'master' of https://github.com/ppy/osu into fallback-intro
2020-06-16 15:11:18 +02:00
smoogipoo
e7687a0927
Temporary placement inside results screen
2020-06-16 17:49:43 +09:00
smoogipoo
a2ddb4edb4
Change interface for creating statistic rows
2020-06-16 17:49:28 +09:00
smoogipoo
9442fc00ac
Temporary hack to make replay player populate scores
2020-06-16 17:48:59 +09:00
smoogipoo
89b54be673
Add initial implementation of the statistics panel
2020-06-15 22:45:18 +09:00
Dean Herbert
17a70bf6ee
Add test coverage
2020-06-15 20:32:27 +09:00
Dean Herbert
c3c5a99a22
Load imported scores to results screen rather than gameplay
2020-06-15 20:23:35 +09:00
BananeVolante
4e7d60b6ff
Merge branch 'master' of https://github.com/ppy/osu into Issue#9170
...
updated local source
2020-06-15 12:58:47 +02:00
Dan Balasescu
95d828cb1f
Merge pull request #9282 from peppy/fix-editor-timeline-drag-scroll
...
Fix drag scroll in editor timeline no longer working correctly
2020-06-15 11:47:09 +09:00
Dean Herbert
0d53d0ffc8
Fix back-to-front math
2020-06-15 00:46:20 +09:00
Dean Herbert
abe07b742e
Fix drag scroll in editor timeline no longer working correctly
2020-06-14 13:20:58 +09:00
Dean Herbert
7b95c55afb
Fix HardwareCorrectionOffsetClock breaking ElapsedTime readings
2020-06-14 11:33:59 +09:00
Shivam
4bfc16b4ce
Implement changes from review
...
Moves seeya back to the introscreen and uses a virtual string to change whenever it's needed and removed remainingTime()
2020-06-13 17:48:15 +02:00
BananeVolante
04c1efe298
resolved issues with inspect code script
2020-06-13 14:33:55 +02:00
BananeVolante
794b8673e2
formated using dotnet format
2020-06-13 10:56:02 +02:00
BananeVolante
8b8f2dfda2
Removed duplicate samplepause.stop() calls, removed test lines
...
Since restart() always call perform immediate exit when the function lead
to a restart, there is no need to stop the pause sample in restart
2020-06-13 10:31:54 +02:00
BananeVolante
6fd8548f79
no longer crash if the restart sample isn't found
2020-06-13 10:13:41 +02:00
BananeVolante
e8db2cfd6d
Merge branch 'master' of https://github.com/ppy/osu
...
updated local source
2020-06-12 19:31:26 +02:00
BananeVolante
2feaf2c74a
added music during pause
2020-06-12 19:17:52 +02:00
Shivam
81c392b841
Change hash to be lowercase and change sample directories
2020-06-12 15:57:23 +02:00
Dean Herbert
c0afe4c880
Merge branch 'master' into fallback-intro
2020-06-12 17:19:11 +09:00
smoogipoo
b7c1cfbe63
Adjust display to avoid overlaps
2020-06-11 15:07:14 +09:00
smoogipoo
7b012f1def
Fix test failures
2020-06-11 14:55:49 +09:00
smoogipoo
afa5b995f2
Merge branch 'fix-test-nullref' into timeshift-results-2
2020-06-11 14:05:05 +09:00
smoogipoo
88aed1d504
Merge branch 'master' into update-inspectcode-version
2020-06-09 20:12:39 +09:00
Dan Balasescu
527577d7c3
Merge pull request #9236 from MiraiSubject/logovisualisation-subclass
...
Move user and skin specific settings for LogoVisualisation to a subclass
2020-06-09 19:16:24 +09:00
smoogipoo
05b1edb9d8
Fix incorrect beatmap showing
2020-06-09 19:01:02 +09:00
smoogipoo
4fd5ff61eb
Add loading spinner
2020-06-09 18:53:55 +09:00
smoogipoo
44dd7d65be
Fix duplicate scores showing
2020-06-09 18:21:37 +09:00
smoogipoo
7f05c16c9f
Merge branch 'master' into timeshift-results-2
2020-06-09 15:59:13 +09:00
Dan Balasescu
1476412eaa
Merge branch 'master' into startup-safety
2020-06-09 13:55:33 +09:00
Dean Herbert
9d68a95f3f
Merge branch 'master' into multi-room-load-spinner
2020-06-09 10:56:56 +09:00
Shivam
a60bb5feac
Rename baseclass, add xmldoc & change access to internal
2020-06-08 23:45:40 +02:00
Shivam
0b6ae08c93
Removed unneeded properties
2020-06-08 21:31:03 +02:00
Shivam
d52e3f9386
Removed logovisualisation changes
...
Now depends on https://github.com/ppy/osu/pull/9236 for accent color changes to apply
2020-06-08 21:26:48 +02:00
Shivam
2a5e960025
Move user and skin specific settings to a subclass
2020-06-08 21:15:51 +02:00
Shivam
e821d787b4
Implement suggested changes
...
Note: LogoVisualisation is likely going to be needed in a separate PR to conform to the review.
2020-06-08 20:13:02 +02:00
Shivam
229a40e6e3
Code formatting fixed
...
Somehow slipped through after pushing
2020-06-08 15:39:15 +02:00
Shivam
f80cdeac5c
Change transforms to roughly match fallback visually
2020-06-08 15:31:30 +02:00
Dean Herbert
dd61d6ed04
Attempt to reimport intro if a bad state is detected
2020-06-08 14:48:42 +09:00
Dean Herbert
72ada020a2
Don't attempt to use virtual track for intro sequence clock
2020-06-08 13:42:16 +09:00
smoogipoo
bb89114b70
Show a loading spinner on multiplayer lounge loads
2020-06-05 20:52:27 +09:00
smoogipoo
caf94df0d0
Merge branch 'master' into multiplayer-beatmap-checksum
2020-06-05 19:16:05 +09:00
Dean Herbert
5d1770dec8
Merge pull request #9212 from smoogipoo/fix-scorepanel-input
...
Fix score panel not receiving input in some places
2020-06-05 00:26:02 +09:00
smoogipoo
afcefe01bf
Fix score panel not receiving input in some places
2020-06-04 21:48:55 +09:00
smoogipoo
5d7bb8cb4e
Change format of date on score panel
2020-06-04 21:33:38 +09:00
Shivam
d002c0c03f
Revert piano reverb to a separate sample
2020-06-03 11:39:08 +02:00
smoogipoo
f3b5149648
Move some suggestions to warnings, resolve issues
2020-06-03 16:48:44 +09:00
smoogipoo
3c07defa1a
Push to main multiplayer screen instead
2020-06-03 15:57:01 +09:00
Dan Balasescu
8131137fea
Merge branch 'master' into fix-results-crash
2020-06-03 15:19:30 +09:00
smoogipoo
22f4e9012c
Remove temporary code
2020-06-03 12:54:16 +09:00
smoogipoo
13622eff1f
Fix response value
2020-06-03 12:54:07 +09:00
Dean Herbert
5740fc2bd0
Merge pull request #9168 from Game4all/fix-ruleset-no-autoplay
...
Fix crash after using Ctrl+Enter when current ruleset doesn't have an autoplay mod
2020-06-03 12:50:57 +09:00
Dean Herbert
93572fc17d
Merge branch 'master' into present-recommended
2020-06-03 12:31:23 +09:00
Shane Woolcock
b174daa94a
Remove unused using
2020-06-03 11:58:56 +09:30
Shane Woolcock
96e3c6e8e8
Move check to SoloResultsScreen
2020-06-03 11:36:47 +09:30
Shane Woolcock
90213d079d
Include submission status in check
2020-06-03 10:48:27 +09:30
Shane Woolcock
f4f84ede6a
Fix results screen crashing for beatmaps with no online ID
2020-06-03 10:43:16 +09:30
Shivam
9cd66dcdef
Fix styling error
2020-06-02 21:54:39 +02:00
Shivam
b79773cdb1
Modify LogoVisualisation to allow color changes
...
Also change the color from blue to dark blue
2020-06-02 21:50:50 +02:00
Shivam
4ebc1d3721
Add original sprite and visualiser
...
Notes: This is using a modified version of welcome.osz to facilitate the visualiser and the animation of the sprite is not accurate.
2020-06-02 21:06:41 +02:00
Lucas A
275d95082a
Fix crash in testing environment.
2020-06-02 16:01:01 +02:00
Dean Herbert
a3e31adbf9
Merge pull request #9146 from peppy/taiko-editor
...
Implement osu!taiko editor
2020-06-02 21:49:20 +09:00
Lucas A
f63c66396f
Apply review suggestions.
2020-06-02 13:32:52 +02:00
Shivam
3d78ec90ac
Rename legacy to welcome to match osu-resources
2020-06-02 13:26:37 +02:00
Shivam
574e8444b0
Merge branch 'master' into fallback-intro
2020-06-02 13:15:58 +02:00
Shivam
888b90b426
Rename IntroFallback classes to IntroLegacy
...
This commit also renames files accordingly with https://github.com/ppy/osu-resources/pull/103
2020-06-02 13:14:50 +02:00
Shivam
19d73af90d
Implement basic intro sequence
2020-06-02 12:51:42 +02:00
Shivam
3ae97c9634
Change "Fallback" to "Welcome" visually
2020-06-02 11:25:57 +02:00
Shivam
2aadb9deba
Implement welcome and seeya samples
2020-06-02 11:05:18 +02:00
Dean Herbert
b58c22c36e
Merge branch 'master' into taiko-editor
2020-06-02 17:22:40 +09:00
smoogipoo
fac96f6ddd
Fix match beatmap not updating after re-download
2020-06-02 17:02:01 +09:00
Dean Herbert
64550fe87c
Merge branch 'master' into fix-draining-in-between-break-sections
2020-06-02 16:06:08 +09:00
smoogipoo
17e91695e0
Add checksum validation to the panel download buttons
2020-06-02 14:04:51 +09:00
smoogipoo
68fbe9f4c1
Add checksum validation to the ready/start button
2020-06-02 14:03:50 +09:00
Shivam
578c955658
Add fallback intro screen
2020-06-02 03:48:23 +02:00
Lucas A
e9b09373e7
Fix crashing if selected ruleset doesn't have an autoplay mod.
2020-06-01 17:41:04 +02:00
Dan Balasescu
e8a25fea1a
Merge branch 'master' into results-screen-horizontal-scroll
2020-06-01 17:34:20 +09:00
Dan Balasescu
64d1b4b11b
Merge branch 'master' into move-setter-to-duration
2020-06-01 15:55:48 +09:00
Dean Herbert
189ad61daa
Merge branch 'master' into taiko-editor
2020-05-31 22:42:34 +09:00
Dean Herbert
f2dadeeeb5
Allow horizontal scroll on results screen when not hovering expanded panel
2020-05-31 13:50:42 +09:00
Dean Herbert
d4b7c81f96
Merge branch 'master' into results-screen-condensed-panel
2020-05-30 23:13:52 +09:00
Dean Herbert
dd7dbfd548
Rename to IHasDuration
2020-05-29 16:45:47 +09:00
Dean Herbert
534dccc0c3
Move sett from EndTime to Duration
2020-05-29 16:45:47 +09:00
Dean Herbert
a2eec5d963
Fix strong bindable changes for DrumRolls
2020-05-29 16:45:47 +09:00
Dean Herbert
e8b43e8e1f
Merge branch 'master' into move-setter-to-duration
2020-05-29 16:04:23 +09:00
smoogipoo
a606f41297
Add button to open results
2020-05-28 22:25:00 +09:00
smoogipoo
ee59182989
Implement initial structure for room scores
2020-05-28 22:09:11 +09:00
smoogipoo
013461377e
Fix potential nullref
2020-05-28 21:46:02 +09:00
smoogipoo
47d5974f04
Improve results screen behaviour when changing selected score
2020-05-28 21:40:01 +09:00
smoogipoo
ad99d85468
Resolve several positioning errors
2020-05-28 21:29:16 +09:00
smoogipoo
666cbd0f40
Allow selected score to be programmatically changed
2020-05-28 21:09:03 +09:00
smoogipoo
a55ce26130
Allow null score
2020-05-28 20:46:17 +09:00
Dan Balasescu
74ad734270
Merge pull request #9125 from peppy/fix-save-causing-delete
...
Fix saving in the editor causing the current beatmap to change
2020-05-27 21:40:58 +09:00
Dean Herbert
9928bff664
Merge branch 'master' into results-screen-condensed-panel
2020-05-27 21:19:33 +09:00
Dean Herbert
9a060cfb3a
Allow drag selections to occur from outside the playfield
2020-05-27 20:44:15 +09:00
Dean Herbert
f989f1aa00
Change event flow to avoid firing store delete events on update
2020-05-27 16:08:47 +09:00
Dean Herbert
cbd563e80b
Rename to IHasDuration
2020-05-27 12:38:39 +09:00
Dean Herbert
b8e0a6f127
Move sett from EndTime to Duration
2020-05-27 12:37:44 +09:00
smoogipoo
c07a33b24f
Fix ctor accessibility
2020-05-26 17:31:50 +09:00
Dean Herbert
7e1e26de2a
Allow HandleMovement by default
2020-05-26 17:04:31 +09:00
smoogipoo
de0b6ec9f1
Create abstract implementation
2020-05-26 17:00:41 +09:00
smoogipoo
c86a003ef9
Adjust transition for smaller sizes
2020-05-26 16:27:41 +09:00
smoogipoo
906a317a3d
Reduce casting
2020-05-26 16:26:53 +09:00
smoogipoo
1768cbd131
Format score same as expanded panel
2020-05-26 15:56:56 +09:00
smoogipoo
51e74687f8
Merge branch 'editor-scrolling-playfield-support' of https://github.com/peppy/osu ; branch 'results-screen-condensed-panel' of https://github.com/smoogipoo/osu into results-screen-condensed-panel
2020-05-26 15:39:39 +09:00
Dean Herbert
d041de63ce
Allow SelectionHandler to provide custom context menu items without local hover check
2020-05-26 13:53:09 +09:00
Dean Herbert
decdc58de5
Merge branch 'editor-clock-cache' into editor-clock-transform
2020-05-24 12:55:47 +09:00
Dean Herbert
a3a9810344
Merge branch 'master' into editor-clock-cache
2020-05-23 00:44:04 +09:00
Dean Herbert
12d65f305f
Simplify and fix incorrect seeking
2020-05-22 22:11:55 +09:00
smoogipoo
d5ea076427
Merge branch 'master' into results-screen-condensed-panel
2020-05-22 20:45:39 +09:00
smoogipoo
80388feac4
Disable scroll user scroll controls in list
2020-05-22 20:39:02 +09:00
smoogipoo
6bcc4c95cc
Schedule api callback
2020-05-22 20:19:23 +09:00
Dean Herbert
1486a44b55
Merge branch 'editor-clock-cache' into editor-clock-transform
2020-05-22 19:51:02 +09:00
Dean Herbert
8b79e14225
Fix remaining test regressions
2020-05-22 19:49:49 +09:00
Dean Herbert
5ea33f4c04
Fix incorrect rounding in DragBar
2020-05-22 19:23:07 +09:00
Dean Herbert
866db629d6
Fix remaining test failures
2020-05-22 18:23:24 +09:00
Dean Herbert
d18eb663b1
Add tweening seek support to EditorClock
2020-05-22 16:47:52 +09:00
Dean Herbert
dd09d7830d
Cache and resolve editor clock as EditorClock in all cases
2020-05-22 16:44:06 +09:00
smoogipoo
899b9f8060
Fix incorrect sorting order
2020-05-21 22:26:04 +09:00
smoogipoo
45244683de
Fix scrolling (1-frame + maintain scroll position)
2020-05-21 22:07:06 +09:00
smoogipoo
d0f74c2b68
Refactor initial state
2020-05-21 20:48:25 +09:00
smoogipoo
7b82a5d792
Fix score order
2020-05-21 20:48:08 +09:00
smoogipoo
717869225e
Rework list to use a scroll container + add spacing
2020-05-21 19:51:36 +09:00
smoogipoo
b6a1d1a2fc
Improve transforms between state changes
2020-05-21 18:07:31 +09:00
smoogipoo
700b5e0c73
Adjust design
2020-05-21 17:47:27 +09:00
Dean Herbert
8a47e2431b
Move distance snap grid implementation to OsuHitObjectComposer
2020-05-21 17:13:22 +09:00
Dean Herbert
b1fd7da824
Merge branch 'master' into editor-position-snap
2020-05-21 15:47:20 +09:00
Dean Herbert
ce223a2bd8
Silence hit sounds while seeking
2020-05-21 11:08:06 +09:00
smoogipoo
acba1f3ad6
Integrate score panel list into results screen
2020-05-20 23:46:54 +09:00
smoogipoo
1b8d657ead
Implement score panel list
2020-05-20 23:46:47 +09:00
Dean Herbert
82d6549161
Pass down snap result and remove local TimeAt usage
2020-05-20 21:01:29 +09:00
Dean Herbert
23bf0d000e
Implement mania beat snapping support
2020-05-20 21:01:19 +09:00
Dean Herbert
ffb8d48fc3
Fix osu!mania editor placement regressions
2020-05-20 21:01:03 +09:00
Dean Herbert
c46bfc2532
Create SnapResult class to hold various snapping results
2020-05-20 21:00:47 +09:00
Dean Herbert
3354d48a38
Change snapping to be screen space coordinate based
2020-05-20 21:00:29 +09:00
smoogipoo
e5de382760
Merge branch 'master' into storyboard-overlay-layer
2020-05-20 15:08:45 +09:00
smoogipoo
85088c9b3b
Privatise setter
2020-05-20 15:08:33 +09:00
Bartłomiej Dach
ce4301c5b8
Add overlay layer to player by proxying
2020-05-19 19:47:50 +02:00
Dan Balasescu
a075529f93
Merge branch 'master' into fix-outwards-event-bindings
2020-05-20 00:07:30 +09:00
Dean Herbert
eee8af28f6
Merge pull request #9018 from Game4all/allowgameplayoverlays-hide-skip
...
Allow disabling SkipOverlay through AllowGameplayOverlays.
2020-05-19 19:22:51 +09:00
Dean Herbert
052ad79fc6
Convert dangerous events to IBindables
2020-05-19 16:44:22 +09:00
smoogipoo
3ee698cfa0
Fix being able to press enter to create matches
2020-05-19 12:39:09 +09:00
smoogipoo
6d70f4b410
Merge branch 'master' into allowgameplayoverlays-hide-skip
2020-05-18 19:54:38 +09:00
smoogipoo
49ee05c3c4
Make into CompositeDrawable
2020-05-18 19:37:49 +09:00
smoogipoo
e3c1112b5a
Initial integration into results screen
2020-05-16 19:00:20 +09:00
smoogipoo
8c5ccf574b
Add better fix for 1px bleed
2020-05-16 18:33:21 +09:00
smoogipoo
2bde4fc3ee
Initial implementation of contracted score panel
2020-05-16 18:20:19 +09:00
Lucas A
4096463d02
Move SkipOverlay internal alpha manipulation to a nested container and adjust visual tests.
2020-05-15 19:43:01 +02:00
Dean Herbert
9b6525bb03
Fix applied platform/user offsets being incorrect when rate adjust mods are active
2020-05-15 18:44:47 +09:00
Lucas A
7874045b1f
Allow disabling SkipOverlay through AllowGameplayOverlays.
2020-05-12 23:05:56 +02:00
Dean Herbert
de50b725d5
Fix mod failure checks executing actual game logic
2020-05-12 20:08:35 +09:00
Dean Herbert
a5c1b461f6
Fix null reference in difficulty recommender
2020-05-12 11:14:51 +09:00
Dan Balasescu
6841bd5609
Merge branch 'master' into taiko-scroller
2020-05-11 11:10:55 +09:00
Bartłomiej Dach
ee2ff77b89
Merge branch 'master' into fix-draining-in-between-break-sections
2020-05-10 17:57:44 +02:00
Dean Herbert
c712e98f2b
Merge branch 'master' into publicly-expose-hud
2020-05-10 20:06:28 +09:00
Dean Herbert
9b8589583c
Merge branch 'master' into taiko-scroller
2020-05-08 19:10:39 +09:00
smoogipoo
dcfef6b443
Add clear method to EditorBeatmap
2020-05-08 18:46:37 +09:00
Lucas A
30dd158c33
Rename property to AllowGameplayOverlays and update XMLDoc accordingly.
2020-05-08 09:37:50 +02:00
Lucas A
83be5455d3
Disable the display of HUD through DisplayHud property.
2020-05-07 08:52:36 +02:00
smoogipoo
401c516503
Expose searchable terms from beatmap info instead
2020-05-07 13:04:08 +09:00
smoogipoo
5186da8412
Fix potential song select nullref
2020-05-07 11:37:04 +09:00
Lucas A
aff74db80d
Publicly expose HUDOverlay in Player.
2020-05-05 10:40:10 +02:00
Dan Balasescu
0eae8d078b
Merge branch 'master' into master
2020-05-05 13:33:29 +09:00
alex
0e2ccac33b
Add spaces to comments
2020-05-04 18:36:24 -07:00
alex
c987af988c
Fix typo
2020-05-04 18:26:12 -07:00
Dean Herbert
06f58dd3e3
Ensure correct beatmap and ruleset when presenting a score from song select
2020-05-04 15:20:43 +09:00
Dan Balasescu
5767bcb8d7
Merge branch 'master' into add-interval-list
2020-05-04 02:00:14 +09:00
Dean Herbert
cea6be5e52
Expose as JudgementResult instead of "passing" state
2020-05-03 23:55:44 +09:00
Bartłomiej Dach
8118747732
Make PeriodTracker actually immutable
2020-05-02 01:33:33 +02:00
Endrik Tombak
1c04d58d6e
Fix recommender's incorrect usage of current ruleset
2020-05-01 19:44:35 +03:00
Bartłomiej Dach
623611d9dc
Simplify ruleset ordering
2020-05-01 17:15:35 +02:00
Bartłomiej Dach
9f091f3a56
Do not query API for custom rulesets
2020-05-01 17:02:28 +02:00
Dean Herbert
ff1d63060d
Add and consume passing state in GameplayBeatmap
2020-05-01 20:08:18 +09:00
Endrik Tombak
33a608fd15
Merge branch 'master' of https://github.com/ppy/osu into present-recommended
...
Conflicts:
osu.Game/Screens/Select/SongSelect.cs
2020-05-01 11:06:20 +03:00
Joehu
700214d249
Truncate beatmap title and artist on score panel
2020-04-30 22:13:38 -07:00
Dean Herbert
d470e092a3
Merge branch 'master' into fix-overlapping-object-undoredo
2020-05-01 10:45:29 +09:00
Dan Balasescu
5740563391
Merge pull request #8903 from peppy/carousel-loading-spinner
...
Show loading spinner when carousel is not ready to be displayed
2020-04-30 21:29:53 +09:00
Dean Herbert
53474c74ee
Merge pull request #8913 from smoogipoo/fix-mania-undo-redo-crash
...
Fix mania crashing on undo/redo
2020-04-30 21:03:38 +09:00
Dean Herbert
000c34dc26
Move recommender to field construction
2020-04-30 21:01:53 +09:00
smoogipoo
c96bc5c51c
Fix undo/redo behaving poorly with simultaneous objects
2020-04-30 20:39:41 +09:00
smoogipoo
9bec42bc7e
Fix mania crashing on undo/redo
2020-04-30 20:03:46 +09:00
Dean Herbert
21c6ac8c43
Allow closing the game during intro
2020-04-30 12:12:28 +09:00
Dean Herbert
cf4e79cf38
Show loading spinner when carousel is not ready to be displayed
2020-04-30 11:51:06 +09:00
Dean Herbert
064e5004ed
Merge branch 'master' into fix-mania-selection
2020-04-29 17:15:48 +09:00
Salman Ahmed
6fa9feb15c
Merge remote-tracking branch 'upstream/master' into add-interval-list
2020-04-29 05:14:40 +03:00
Salman Ahmed
6e76e5900a
Rename is-in-any check method to a more legible name
2020-04-29 05:11:44 +03:00
Salman Ahmed
8d899f4e77
Apply changes to the BreakTracker and more adjustment
2020-04-29 05:11:43 +03:00
Dean Herbert
cd22e5883d
Merge pull request #8883 from peppy/dont-use-internal-ef-linq
...
Avoid using internal EF methods in tests
2020-04-29 09:54:06 +09:00
Dean Herbert
119000f1ab
Reduce database includes where possible
2020-04-28 21:43:35 +09:00
Dean Herbert
c3a41c8476
Also avoid using internal TypeExtensions
2020-04-28 17:02:10 +09:00
smoogipoo
cebc0fc046
Attempt to fix multiple selection movements
2020-04-27 20:35:24 +09:00
smoogipoo
7f5a1d7f44
Merge branch 'master' into fix-mania-selection
2020-04-27 17:09:40 +09:00
smoogipoo
104c61d622
Remove unnecessary scale
2020-04-27 11:06:23 +09:00
Dean Herbert
48168dddce
Adjust editor timeline current marker to promote tick visibility
2020-04-27 10:54:32 +09:00
Endrik Tombak
657bf5ad86
Merge branch 'master' of https://github.com/ppy/osu into present-recommended
2020-04-25 10:13:57 +03:00
Dean Herbert
1c13fa6c61
Fix editor crashing when entering with no beatmap selected
2020-04-24 10:27:32 +09:00
smoogipoo
4ebb28d3e7
wip
2020-04-23 17:52:54 +09:00
smoogipoo
e1142b424d
Fix test failures
2020-04-22 18:14:21 +09:00
smoogipoo
9c22d2f1dd
Use platform bindings for editor actions
2020-04-22 17:41:24 +09:00
Dean Herbert
9b9b710ded
Move and rename remaining direct classes
2020-04-21 16:41:07 +09:00
Dean Herbert
1cec0575b7
Remove unused classes and replace overlay in game
2020-04-21 16:38:47 +09:00
smoogipoo
fcfb2b9026
Merge branch 'master' into fix-select-new-from-sub-screen
2020-04-21 14:36:53 +09:00
Dean Herbert
a91c63819b
Refactor updateCompletionState implementation for legibility and code share
2020-04-21 11:55:28 +09:00
Dean Herbert
5a2129da7c
Merge branch 'master' into allow-cancelling-completion
2020-04-21 11:22:37 +09:00
Dan Balasescu
3b3a7bdd85
Merge branch 'master' into scroll-to-center
2020-04-21 10:21:08 +09:00
Bartłomiej Dach
e3cd3cf1da
Convert to auto-properties
2020-04-20 21:43:07 +02:00
Bartłomiej Dach
9b6e26583b
Add xmldocs
2020-04-20 21:42:43 +02:00
Dean Herbert
ee1ccb8bcb
Fix in a slightly different and hopefully more understandable way
2020-04-20 14:03:55 +09:00
Salman Ahmed
e12e3391fb
Base wait steps duration on the delay used for results display
...
With `* 2` for safety of not potentially going to the next step and the delegate not executed yet.
2020-04-20 06:42:33 +03:00
Endrik Tombak
b57d709d15
Don't use Parent
2020-04-19 18:29:06 +03:00
Endrik Tombak
a8bfd21f3f
Merge branch 'master' of https://github.com/ppy/osu into scroll-to-center
2020-04-19 18:21:34 +03:00
Endrik Tombak
f893d523f5
User setting for always playing first combo break
2020-04-19 12:23:41 +03:00
Salman Ahmed
6d276890a7
Fix results screen pushed after rewinding in-between push delay
2020-04-19 05:59:56 +03:00
Salman Ahmed
7e64bec94f
Use HasCompleted in Player
2020-04-19 05:58:22 +03:00
Salman Ahmed
fc6c245de5
Replace all judged event logic with HasCompleted bindable
2020-04-19 05:36:04 +03:00
Endrik Tombak
4aaa00e321
Fix CI complaints
2020-04-17 20:33:12 +03:00
Endrik Tombak
1ac9ee5990
Optimize recommender (for custom rulesets)
2020-04-17 18:15:11 +03:00
Dean Herbert
5833a7ac91
Fix presenting new ruleset and beatmap at once causing wedge display desync
2020-04-17 18:56:17 +09:00
Dean Herbert
d62094cd4b
Fix carousel not correctly updating when selection changes to a new beatmap from a child screen
2020-04-16 18:10:35 +09:00
Dean Herbert
5ec8d49241
Merge pull request #8764 from smoogipoo/disable-undo-redo
...
Disable undo/redo menu items when they can't be performed
2020-04-16 13:47:23 +09:00
smoogipoo
9e2be6f2f4
Remove bindable to promote one-way access
2020-04-16 13:25:08 +09:00
Dean Herbert
03a74a4320
Apply same conditional check changes to DrawableCarouselBeatmapSet
2020-04-16 12:13:26 +09:00
Dean Herbert
91b13f91ea
Add exception disallowing potential edit when disabled at a property level
2020-04-16 12:11:12 +09:00
Dean Herbert
c4caf38feb
Simplify menu item checks (and add for other items)
2020-04-16 12:10:20 +09:00
Joehu
e2b28bfe88
Hide edit context menu item in multiplayer song select
2020-04-15 18:17:12 -07:00
Endrik Tombak
b5c1752f0a
Calculate best ruleset order only once
2020-04-15 18:14:51 +03:00
smoogipoo
ce21cfbb03
Use bindables in menu items
2020-04-15 16:17:34 +09:00
smoogipoo
e8c955ed9b
Add CanUndo/CanRedo bindables
2020-04-15 16:17:17 +09:00
Endrik Tombak
bbef94b4df
Reset best order on ruleset change
2020-04-14 18:56:20 +03:00
Endrik Tombak
00d1cf1ce2
Recommend from all rulesets
2020-04-14 18:42:18 +03:00
Endrik Tombak
dd6c9173da
Move DifficultyRecommender to OsuGameBase
2020-04-14 18:42:00 +03:00
smoogipoo
f3dbddd75c
Update bindings in LoadComplete()
2020-04-14 15:52:38 +09:00
smoogipoo
b8b334ca27
Always unbind bindings
2020-04-14 15:21:56 +09:00
smoogipoo
3183827329
Reorder fields
2020-04-14 15:09:31 +09:00
smoogipoo
7d2d0785fd
Fix potential unsafe ordering of binds
2020-04-14 15:07:32 +09:00
smoogipoo
9619fb9f6a
Remove bind in Player
2020-04-14 15:00:36 +09:00
Dan Balasescu
ac8a3efc46
Merge branch 'master' into low-hp-red-layer
2020-04-14 14:47:01 +09:00
Dan Balasescu
948e225e12
Merge branch 'master' into select-recommended
2020-04-14 13:59:03 +09:00
Endrik Tombak
d9c91fb943
Merge branch 'master' of https://github.com/ppy/osu into no-video-option
...
Conflicts:
osu.Game/Overlays/Direct/PanelDownloadButton.cs
2020-04-13 17:40:28 +03:00
Dean Herbert
2388799acf
Limit upper number of editor beatmap states saved to 50
2020-04-13 20:37:46 +09:00
Dean Herbert
0e88c28060
Merge branch 'editor-undo-redo' into more-change-state-support
2020-04-13 18:07:00 +09:00
Dean Herbert
6aab19413c
Rename differ to patcher, add xmldoc
2020-04-13 17:20:20 +09:00
Dean Herbert
bb53f96c71
Store states as byte[] instead of Streams
2020-04-13 17:18:50 +09:00
Dean Herbert
0c60dbe796
Merge branch 'master' into editor-undo-redo
2020-04-13 16:03:53 +09:00
Endrik Tombak
633b969017
Apply review suggestions
2020-04-12 21:57:35 +03:00
Endrik Tombak
b475316a4e
Simplify and comment
2020-04-12 20:40:08 +03:00
Endrik Tombak
63a1686dfb
Scroll to screen middle
2020-04-12 12:42:52 +03:00
Endrik Tombak
fc1d497a86
Change PlaylistDownloadButton default
2020-04-11 14:21:28 +03:00
Dean Herbert
73a3f1fe65
Remove unnecessary DI
2020-04-11 17:30:34 +09:00
Dean Herbert
7aac0e59a8
Reduce dictionary lookups
2020-04-11 17:13:35 +09:00
Dean Herbert
310cf830d4
Simplify api request logic
2020-04-11 17:13:35 +09:00
Dean Herbert
abea7b5299
Tidy up function passing, naming, ordering etc.
2020-04-11 17:13:35 +09:00
Dean Herbert
7f753f6b4d
Remove current ruleset from function call
2020-04-11 16:43:09 +09:00
Dean Herbert
a843793957
Un-nest class
2020-04-11 16:41:11 +09:00
Dean Herbert
ff591299e0
Merge branch 'master' into select-recommended
2020-04-11 16:40:07 +09:00
smoogipoo
4a87ac7840
Add support for sample changes
2020-04-10 13:53:09 +09:00
smoogipoo
ee7e2b0854
Fix editor beatmap potentially not updating hitobjects
2020-04-10 13:29:46 +09:00
Salman Ahmed
9a29797a5b
Use IntervalList<double> for tracking break periods
2020-04-09 23:00:16 +03:00
Endrik Tombak
deaf24f141
Fix oversight on null
2020-04-09 19:30:40 +03:00
Endrik Tombak
35f97dfc75
Style changes
2020-04-09 18:59:18 +03:00
Endrik Tombak
f40bdcd34e
Initial rewrite, moving API logic to SongSelect
2020-04-09 18:47:28 +03:00
smoogipoo
575b061dd7
Add change state support to more editor components
2020-04-09 22:02:42 +09:00
smoogipoo
2e33d38cd7
Merge branch 'master' into editor-undo-redo
2020-04-09 22:02:28 +09:00
Dean Herbert
cc0bcea6e5
Merge pull request #8693 from smoogipoo/editorbeatmap-update-cleanup
...
Cleanup handling of hitobject updates
2020-04-09 21:32:58 +09:00
smoogipoo
14eca3655b
Add change state handling to the editor
2020-04-09 21:22:07 +09:00
Dean Herbert
a457880eaa
Merge pull request #8695 from smoogipoo/fix-timeline-crash
...
Fix crash when trying to edit long beatmaps
2020-04-09 21:05:25 +09:00
smoogipoo
86243d463f
Add legacy beatmap diffing
2020-04-09 20:48:59 +09:00
smoogipoo
fde5cd34b2
Merge branch 'editorbeatmap-update-cleanup' into editor-undo-redo
2020-04-09 20:36:57 +09:00
smoogipoo
683302a77d
Fix crash when trying to edit long beatmaps
2020-04-09 20:25:26 +09:00
smoogipoo
ee6ea08cf8
Cleanup handling of hitobject updates
2020-04-09 20:16:44 +09:00
Dean Herbert
e10576325c
Merge branch 'master' into update-overlay-headers
2020-04-09 16:29:34 +09:00
Dean Herbert
260de77304
Merge branch 'master' into select-recommended
2020-04-09 15:30:35 +09:00
Dean Herbert
c5005eb378
Adjust gradient size slightly and make const
2020-04-09 14:55:02 +09:00
Dean Herbert
5a78e74470
Use Lerp instead of ValueAt
2020-04-09 14:51:50 +09:00
Dean Herbert
c44957db3f
Change initial health to 1 to avoid false fail display
2020-04-09 14:49:09 +09:00
Dean Herbert
947745d87e
Change fail effect to be less distracting
2020-04-09 14:34:23 +09:00
Dean Herbert
4976f80b71
Move implementation to HUD
2020-04-09 14:31:25 +09:00
Dean Herbert
0e2d5213ce
Merge branch 'master' into low-hp-red-layer
2020-04-09 13:53:57 +09:00
Dean Herbert
4bfc738f5b
Merge pull request #7639 from santerinogelainen/master
...
Add top rank to the beatmap carousel
2020-04-08 23:36:47 +09:00
Dean Herbert
61d8cfd224
Fix triangle intro video being out of time
2020-04-08 19:51:55 +09:00
Alchyr
737a3b608a
Correct spelling
2020-04-07 17:34:18 -07:00
smoogipoo
ed3e0a01e1
Re-namespace into song select
2020-04-07 15:31:22 +09:00
Joehu
57b6a91449
Remove unnecessary input override on footer button mods
...
Was used when it expanded on hover, but doesn't anymore.
2020-04-05 14:57:44 -07:00
Joehu
0f11ecce01
Make icons container private
2020-04-05 14:53:49 -07:00
Salman Ahmed
7fab07670e
Remove no longer necessary usage of IsBreakTime
2020-04-05 21:35:09 +03:00
Santeri Nogelainen
163de36777
Merge remote-tracking branch 'upstream/master'
2020-04-04 22:29:15 +03:00
Santeri Nogelainen
1e8badb14a
Move all logic to TopLocalRank and remove CarouselBeatmapRank
2020-04-04 22:28:36 +03:00
Joehu
88cc552534
Fix results star rating display not being centered when no mods are present
...
Needed or the spacing will apply to the fill flow container, causing alignment issues.
2020-04-03 11:30:22 -07:00
Joehu
493b654011
Remove horizontal margin from mod display
...
Can skew center alignment on fill flow containers.
Fixes affected areas. Vector2(5, 0) is similar to MarginPadding { Left = 10 }.
2020-04-03 11:30:02 -07:00
Dean Herbert
53c99d137a
Merge branch 'master' into mania-config-lookup-refactor
2020-04-03 22:22:59 +09:00
Dean Herbert
51db361c32
Update usages of Animation and Video in line with framework changes
2020-04-03 16:00:06 +09:00
smoogipoo
1f797207f7
Rework lookups to not require total playfield columns
2020-04-03 12:31:05 +09:00
Lucas A
1562612f41
Update visual tests and remove unessecary XMLDoc tag
2020-04-01 15:12:31 +02:00
Lucas A
ab01111c36
Fix merge conflicts.
2020-03-30 17:39:11 +02:00
Lucas A
3cae0cedee
Add a game setting to disable the layer
2020-03-30 12:59:39 +02:00
Dean Herbert
113660b621
Merge if statements
2020-03-30 18:56:35 +09:00
Dan Balasescu
ea1a2e1955
Merge branch 'master' into dont-retry-on-replay-results
2020-03-30 11:01:25 +09:00
Dan Balasescu
113bbe8c4d
Merge pull request #8488 from peppy/fix-autoplay-results-display
...
Fix auto mod results screen not displaying correctly
2020-03-30 11:01:16 +09:00
Dean Herbert
b47a532df3
Adjust code formatting slightly
2020-03-30 00:07:48 +09:00
Dean Herbert
6e68b968f8
Hide "retry" button on results screen after watching a replay
2020-03-29 23:52:50 +09:00
Dean Herbert
66a990cd5e
Remove redundant this
2020-03-29 23:50:16 +09:00
Dean Herbert
653480b2f8
Add regression test
2020-03-29 23:29:46 +09:00
Dean Herbert
4f5557096c
Fix auto mod results not displaying correctly
2020-03-29 22:51:28 +09:00
Endrik Tombak
b4f0500706
Invert logic
2020-03-28 20:21:21 +02:00
Endrik
2c27894527
Use All instead of ToList Any
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-03-28 19:58:33 +02:00
Santeri Nogelainen
6bde102207
Merge remote-tracking branch 'upstream/master'
2020-03-28 18:14:17 +02:00
Santeri Nogelainen
faa2b49be4
Fix namespace for CarouselBeatmapRank, make UpdateableRank in TopLocalRank readonly
2020-03-28 18:13:39 +02:00
Santeri Nogelainen
1c711147f3
Move all carousel rank logic into separate classes (TopLocalRank and CarouselBeatmapRank)
2020-03-28 17:22:01 +02:00
Endrik Tombak
87854fc4fa
Rename variable
2020-03-28 13:23:31 +02:00
Endrik Tombak
6a0c5c87aa
Use already existing variable
2020-03-28 13:06:03 +02:00
Endrik Tombak
fc3f9ff6fa
Don't use drawables for select next
2020-03-28 12:54:48 +02:00
Dean Herbert
944926e950
Merge branch 'master' into fix-break-overlay-z-order
2020-03-28 13:04:19 +09:00
Dean Herbert
a317ef65b8
Remove default for argument
2020-03-28 12:18:28 +09:00
Bartłomiej Dach
3a3bfe9a5e
Reorder children to fix pause overlay z-order
2020-03-27 21:19:49 +01:00
Bartłomiej Dach
adc759771f
Hook up score processor in player
2020-03-27 19:47:42 +01:00
Dan Balasescu
5e1cb0e9e9
Merge branch 'master' into fix-minia-mod-replay-recording
2020-03-27 19:26:41 +09:00
Dean Herbert
f75c082601
Fix osu!mania replays recording incorrectly when key mod applied
2020-03-27 15:50:11 +09:00
Endrik Tombak
bbbaaae3ee
Write tests
2020-03-26 19:18:16 +02:00
Endrik Tombak
ee112c6f50
Move and change logic
2020-03-26 18:42:08 +02:00
TheWildTree
83410315c6
Make fields private
2020-03-26 17:18:01 +01:00
TheWildTree
9a30ff5a00
Fix code quality issues
2020-03-26 16:11:58 +01:00
Lucas A
00c1ff993a
Fix merge conflicts.
2020-03-26 15:48:18 +01:00
Lucas A
c1ac57e70f
Add back visual tests and add easing to alpha fade.
2020-03-26 12:14:44 +01:00
Dean Herbert
07462120e4
Split break tracking into its own component
2020-03-26 15:30:23 +09:00
Dean Herbert
d372ddaadd
Move break overlay to a location it is not affected by gameplay scale
2020-03-26 12:50:18 +09:00
Endrik Tombak
2f5dc93d61
Select recommended difficulty
2020-03-26 00:19:54 +02:00
Dean Herbert
800e395bc8
Merge branch 'master' into replay-recording
2020-03-25 20:20:59 +09:00
Dan Balasescu
e7f32d951d
Merge pull request #8431 from peppy/fix-intro-tests
...
Fix intro tests not asserting pass or working at all
2020-03-25 19:25:26 +09:00
Dean Herbert
b1d4261402
Fix track looping state not being reset when entering editor from song select
...
Closes #8432 .
2020-03-25 15:50:19 +09:00
Dean Herbert
880d138a47
Fix intro tests not asserting pass or working at all
2020-03-25 15:12:19 +09:00
Dean Herbert
6d81da5419
Merge branch 'master' into video-offset
2020-03-25 11:28:59 +09:00
Dean Herbert
971249338d
Merge branch 'master' into storyboard-masking
2020-03-25 11:05:40 +09:00
TheWildTree
e85f45f911
Move old ScreenTitle to MultiHeaderTitle
2020-03-24 22:03:16 +01:00
Dean Herbert
4070b2b75f
Merge branch 'basic-replay-recorder' into replay-recording
2020-03-24 16:31:14 +09:00
Dean Herbert
a7bfaad60f
More correctly handle rulesets which don't support replay recording
2020-03-24 15:44:39 +09:00
Dean Herbert
022465f546
Add encoding and import support
2020-03-24 14:51:52 +09:00
voidedWarranties
4bb15a8b93
Allow individual storyboard layers to disable masking
2020-03-23 22:51:37 -07:00
Dean Herbert
2a1e7a7ff0
Merge branch 'master' into fix-select-filter-not-absorbing-input
2020-03-24 14:03:58 +09:00
Dan Balasescu
6279c78e3c
Merge branch 'master' into fix-keypad-autoplay-shortcut
2020-03-24 13:34:31 +09:00
Joehu
5bc5119389
Handle OnHover on song select filter and footer
2020-03-23 16:03:33 -07:00
Joehu
96d962ab30
Fix autoplay keyboard shortcut not working with keypad enter key
2020-03-23 11:25:40 -07:00
Joehu
96848405fd
Fix song select filter not absorbing input from carousel
2020-03-23 10:54:45 -07:00
Dean Herbert
617149fb27
Implement in player
2020-03-23 20:06:18 +09:00
Dean Herbert
47c7673c9e
Fix crash when holding a key down while entering player
2020-03-23 17:04:54 +09:00
Dan Balasescu
d0c7b49376
Merge branch 'master' into fix-carousel-root-selects-from-nothing
2020-03-23 11:34:04 +09:00
smoogipoo
448e5c0deb
Merge branch 'master' into fix-carousel-root-selects-from-nothing
2020-03-23 11:15:22 +09:00
Dan Balasescu
fb21c7d82d
Merge branch 'master' into fix-carousel-restore-previous-selection
2020-03-23 11:01:18 +09:00
Dean Herbert
febf9adabd
Merge pull request #8329 from Fuewburvpoa/MyBranch
...
Fix beat divisor control selecting invalid divisors on drag end
2020-03-22 02:21:13 +09:00
Dean Herbert
29009c85c0
Fix typo in comment
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-03-22 00:32:53 +09:00
Dean Herbert
729e006c3a
Merge branch 'master' into video-offset
2020-03-21 20:03:46 +09:00
Dean Herbert
9b60b535e5
Fix selection not occurring when switching from empty ruleset on first load
2020-03-20 15:01:26 +09:00
Dean Herbert
e64a100e8b
Merge branch 'master' into fix-carousel-restore-previous-selection
2020-03-20 13:03:18 +09:00
Dean Herbert
be4a97c289
Correctly bypass last selected when it is filtered
2020-03-20 13:01:24 +09:00
Dean Herbert
8f9e97b4cc
Fix carousel not remembering last selection correctly
2020-03-19 18:07:39 +09:00
Dean Herbert
855f0a4253
Fix bracket style
2020-03-19 14:38:49 +09:00
Dean Herbert
17c3455b36
Fix potentially invalid push in player while already exiting
2020-03-19 14:10:59 +09:00
Dean Herbert
c50784da93
Show 'D' rank badge on accuracy circle
2020-03-19 11:58:52 +09:00
Lucas A
a4171253a3
Make LowHealthThreshold a field.
2020-03-18 21:45:01 +01:00
Lucas A
e9f224b5e8
Apply review suggestions
2020-03-18 21:16:54 +01:00
Fuewburvpoa
648e9fa21f
Merge branch 'master' into MyBranch
2020-03-18 21:18:17 +02:00
Dean Herbert
90e1f6efbf
Merge pull request #8341 from smoogipoo/score-panel-scrolling
...
Make score panel scroll if off-screen
2020-03-18 19:00:48 +09:00
Dean Herbert
25983cfe0e
Merge pull request #8340 from smoogipoo/results-date-played
...
Add date played to score panel
2020-03-18 18:55:26 +09:00
Dean Herbert
6c45694f01
Merge pull request #8338 from smoogipoo/colourise-hit-statistics
...
Colourise results screen hit statistics
2020-03-18 18:55:10 +09:00
smoogipoo
1d211cb563
Make score panel scroll if off-screen
2020-03-18 18:28:42 +09:00
smoogipoo
63531a8564
Add date played to score panel
2020-03-18 17:59:44 +09:00
smoogipoo
66558ca8c5
Colourise hit result statistics
2020-03-18 17:26:17 +09:00
Dan Balasescu
e1e0c40020
Merge branch 'master' into fix-perfect-display
2020-03-18 17:04:52 +09:00
Dean Herbert
ed419216f0
Merge pull request #8323 from skielred/acc-circle-use-osucolour
...
Re-use colors defined for each rank in result screen accuracy circle
2020-03-18 16:29:24 +09:00
Lucas A
a1274a9eb0
Fix and add missing XMLDoc
2020-03-18 08:29:00 +01:00
Dean Herbert
fdcb60706b
Use TryGetValue to make tests happy
2020-03-18 15:49:24 +09:00
Dean Herbert
44cfed8af1
Fix perfect display showing when misses are present
2020-03-18 15:03:01 +09:00