h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-14 03:15:45 +08:00
Code Issues Releases Wiki Activity

Fix osu!mania editor placement regressions

Browse Source
This commit is contained in:
Dean Herbert 2020-05-20 18:32:36 +09:00
parent c46bfc2532
commit ffb8d48fc3
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Rulesets.Mania/Edit/ManiaHitObjectComposer.cs
View File

@ -63,7 +63,7 @@ namespace osu.Game.Rulesets.Mania.Edit
drawableRuleset.ScrollingInfo.TimeRange.Value,
hoc.DrawHeight);
return new SnapResult(targetPosition, targetTime);
return new SnapResult(screenSpacePosition, targetTime);
}
protected override DrawableRuleset<ManiaHitObject> CreateDrawableRuleset(Ruleset ruleset, IBeatmap beatmap, IReadOnlyList<Mod> mods = null)

2
osu.Game/Rulesets/Edit/HitObjectComposer.cs
View File

@ -269,7 +269,9 @@ namespace osu.Game.Rulesets.Edit
{
if (distanceSnapGrid == null) return new SnapResult(screenSpacePosition, null);
// TODO: move distance snap grid to OsuHitObjectComposer.
(Vector2 pos, double time) = distanceSnapGrid.GetSnappedPosition(distanceSnapGrid.ToLocalSpace(screenSpacePosition));
return new SnapResult(distanceSnapGrid.ToScreenSpace(pos), time);
}

4
osu.Game/Screens/Edit/Compose/Components/ComposeBlueprintContainer.cs
View File

@ -67,9 +67,9 @@ namespace osu.Game.Screens.Edit.Compose.Components
private void updatePlacementPosition(Vector2 screenSpacePosition)
{
Vector2 snappedPlayfieldPosition = composer.SnapScreenSpacePositionToValidTime(screenSpacePosition).ScreenSpacePosition;
var snapResult = composer.SnapScreenSpacePositionToValidTime(screenSpacePosition);
currentPlacement.UpdatePosition(ToScreenSpace(snappedPlayfieldPosition));
currentPlacement.UpdatePosition(snapResult.ScreenSpacePosition);
}
#endregion