osu-lazer

mirror of https://github.com/ppy/osu.git synced 2024-11-16 11:57:30 +08:00

Author	SHA1	Message	Date
Joseph Madamba	f80de08f24	Adjust `BeatmapSetsChanged` xmldoc Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-04-10 11:28:23 -07:00
Joseph Madamba	c7dea71793	Use existing `BeatmapSetsChanged` action	2023-04-10 11:26:18 -07:00
Bartłomiej Dach	73bd0feef5	Fix incorrectly implemented localisation	2023-04-10 15:03:33 +02:00
Bartłomiej Dach	6fec476147	Simplify snap implementation	2023-04-10 14:55:30 +02:00
Joseph Madamba	7f5b99c91b	Fix song select beatmap difficulty count not updating when deleting	2023-04-09 22:12:51 -07:00
cdwcgt	ce6a87b4a3	Merge remote-tracking branch 'upstream/master' into export	2023-04-09 15:02:47 +09:00
Dean Herbert	8d2e852ffd	Fix overbearing key down handling	2023-04-08 22:30:36 +09:00
Dean Herbert	a1fc4def1d	Remove redundant method override	2023-04-08 22:18:07 +09:00
Micha Lehmann	3c4a25e53f	Fix tooltip text not resetting when ending an editor rotation	2023-04-08 14:28:52 +02:00
Micha Lehmann	580d5745c0	Add "(snapped)" to the tooltip when snap-rotating in the editor	2023-04-08 14:15:49 +02:00
Dean Herbert	f72dd86b42	Fix code quality issues and avoid updating bindable twice per operation	2023-04-08 10:40:36 +09:00
Micha Lehmann	c827c2810b	Improve editor selection rotation value wrapping This fixes two issues the previous algorithm had: 1. A half-turn rotation used to show up as -180°. 2. Rotating more than 180° in one drag event would overwhelm it and cause the value to go outside its range. This comes at the cost of a negligible performance hit, since a division (modulo) is performed instead of just addition/subtraction.	2023-04-08 01:30:29 +02:00
Micha Lehmann	f1de560d57	Snap editor selection rotation when holding shift	2023-04-08 01:30:29 +02:00
Dean Herbert	0c71fa1bbd	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-06 23:39:57 +09:00
Dean Herbert	e6872629f3	Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable Don't show epilepsy warning when storyboards are disabled	2023-04-06 12:32:38 +09:00
tsrk	809b817e8e	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-05 22:57:36 +02:00
Bartłomiej Dach	ba753a8aac	Merge branch 'master' into update-skinnable-sound-before-playing	2023-04-05 22:56:25 +02:00
Bartłomiej Dach	6df7614b9d	Add tests for suppressing epilepsy warning when storyboard disabled	2023-04-05 20:56:50 +02:00
Bartłomiej Dach	432f698697	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-05 19:45:14 +02:00
Bartłomiej Dach	8cc425774b	Merge branch 'master' into fix-replay-fail-on-exit	2023-04-03 21:23:23 +02:00
Dean Herbert	b0c09df259	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-03 15:33:35 +09:00
Dean Herbert	4b294278d6	Merge branch 'master' into fix-ruleset-shader-caching	2023-03-31 20:04:55 +09:00
Dean Herbert	796cd9c916	Rewrite comment explaining early return on `checkScoreCompleted` given new usages	2023-03-31 02:36:17 +09:00
Dean Herbert	b25a59fd14	Rename `scoreCompleted` -> `checkScoreCompleted` to reflect the fact it doesn't always succeed	2023-03-31 02:30:04 +09:00
Dean Herbert	4dd0c2c7a5	Add assert ensuring we don't ever get to the results screen with an F rank Intentionally an assertion as I want tests to fail, but I don't want this to cause crashes for an end user if it does happen to occur.	2023-03-29 14:11:58 +09:00
Dean Herbert	a8bb2e33ac	Ensure all preconditions are checked before progressing to results screen after storyboard ends	2023-03-29 14:00:11 +09:00
Dean Herbert	aad540629f	Remove duplicate load rule from `ShaderPrecompiler`	2023-03-29 12:36:56 +09:00
Dean Herbert	5dfac02b11	Preload triangle shader on startup	2023-03-28 14:15:38 +09:00
Joseph Madamba	8b30c67580	Fix incorrect song select matching label by showing both beatmap and difficulty count for less ambiguity	2023-03-26 18:08:28 -07:00
Joseph Madamba	3e0bbb2432	Fix select beatmap button not highlighting when creating a multiplayer room using keyboard	2023-03-26 16:03:21 -07:00
Dean Herbert	c65a79614d	Don't show offset calibration controls when "relax" mod is active Closes https://github.com/ppy/osu/issues/22892.	2023-03-22 15:45:04 +09:00
Dean Herbert	425be20e46	Fix song select search textbox font size incorrectly having increased	2023-03-22 14:17:39 +09:00
Bartłomiej Dach	9ff9cd3b7f	Merge branch 'master' into skin-editor-cyclic-selection	2023-03-21 19:49:55 +01:00
Dean Herbert	e31a90e043	Don't cycle selection when more than one items are selected	2023-03-21 21:31:10 +09:00
Dean Herbert	5cb8160eee	Merge pull request #22773 from peppy/show-song-select-visible-beatmap-count Show count of visible beatmaps at song select	2023-03-21 18:22:29 +09:00
Bartłomiej Dach	ea8da69263	Fix importing beatmaps not changing count of visible beatmaps Reproduction steps: 1. Go to song select 2. Open beatmap listing 3. Import a beatmap that would fit the current filter criteria 4. The count of visible beatmaps does not change Fixed by updating the count on `BeatmapSetsChanged` too.	2023-03-20 20:53:53 +01:00
Bartłomiej Dach	695ee39b87	Privatise setter	2023-03-20 20:30:54 +01:00
Cootz	556964eae0	Merge branch 'master' into BitmapUpdatesOnScore	2023-03-16 12:16:42 +03:00
Dean Herbert	3b62f87b64	Ensure `Player` does not fail a score on exit if a replay is currently loaded	2023-03-16 17:14:20 +09:00
Dean Herbert	f21238f517	Adjust shadow to look better	2023-03-16 16:51:57 +09:00
Dean Herbert	cd102da3af	Move matches string inside text box	2023-03-16 16:34:31 +09:00
Dean Herbert	89b42ddd98	Don't localise beatmap count string for now	2023-03-16 15:02:38 +09:00
Terochi	edc6314634	Drank some coffee and figured out the fix	2023-03-15 10:49:59 +01:00
Dean Herbert	5f9b13a775	Rename `Add`/`AddRange` methods as they are no longer conflicting with `Container`	2023-03-15 18:02:41 +09:00
Dean Herbert	9e444af380	Use object initialisers and fix order of initialisation vs add	2023-03-15 18:02:26 +09:00
Terochi	b0f1a69523	Update the pauseLoop sample instantly on skin change	2023-03-15 09:05:34 +01:00
Dean Herbert	1cf870d956	Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection	2023-03-15 15:16:48 +09:00
Terochi	1d5e596615	Update `FailAnimation` to use `SkinnableSound`	2023-03-14 20:44:30 +01:00
Dean Herbert	6546f5968a	Merge branch 'master' into skin-editor-cyclic-selection	2023-03-14 20:43:56 +09:00
Dean Herbert	b46fc14e56	Merge pull request #22848 from Rovearix/Fix-Dragging-Preventing-Beatmap-Loading Prevent LoadingLayer from blocking loading	2023-03-14 20:42:10 +09:00
Dean Herbert	4cea29402b	Don't show epilepsy warning when storyboards are disabled I have more thoughts on this warning in general (which will likely see it removed or moved in the future) but this seems like a quick QOL fix for now. As mentioned in https://github.com/ppy/osu/discussions/22861.	2023-03-14 18:32:26 +09:00
Rovearix	9ac9287dbd	Switched the implementation to set the blockInput flag for the BeatmapMetadataDisplay's LoadingLayer. This prevents the UIEvents from being being handled in this case without modifying the class	2023-03-13 08:07:55 -04:00
Derrick Timmermans	febdca4547	Fix argon progress bar fill being oversized	2023-03-12 02:08:00 +01:00
Dan Balasescu	e327993d11	Merge pull request #22527 from Terochi/replay-length-extension Replay recording extension until results screen transition	2023-03-11 15:41:32 +09:00
tsrk	d806b85a30	revert: make `counters` an `IEnumerable` again As suggested by bdach as this would make the last two commits useless Refs: `5d15426`	2023-03-09 10:25:03 +00:00
Dean Herbert	4f7be332f3	Revert `isDraggingBlueprint` to field	2023-03-08 19:24:03 +09:00
Dean Herbert	245c3c025c	Refactor `endClickSelection` to reduce nesting	2023-03-08 19:23:32 +09:00
tsrk	5d15426c27	refactor: make `Counters` return a `Container`	2023-03-08 01:52:12 +00:00
tsrk	5b0db94a24	docs: add XMLDoc for methods in KCD	2023-03-08 00:58:54 +00:00
tsrk	44297a7d0a	refactor: make KCD a `CompositeDrawable`	2023-03-08 00:47:16 +00:00
Bartłomiej Dach	72695f7c90	Merge branch 'master' into omit-barline-in-timing-control-point	2023-03-07 22:46:24 +01:00
Bartłomiej Dach	6c5ccdfd90	Merge branch 'master' into optimise-search	2023-03-07 22:07:29 +01:00
Bartłomiej Dach	12af002c4d	Reorder and add xmldoc to `KeyCounter` members	2023-03-07 21:28:42 +01:00
Bartłomiej Dach	98f40b2679	Improve documentation of `InputTrigger`	2023-03-07 21:22:59 +01:00
Bartłomiej Dach	5213bfa5c9	Merge branch 'master' into make_skin_reset_dangerous	2023-03-07 21:06:44 +01:00
Bartłomiej Dach	cfafa8af8c	Merge branch 'master' into hud/player-components	2023-03-07 19:44:12 +01:00
Bartłomiej Dach	7ade525eef	Display corner radius setting as percentage	2023-03-07 19:43:52 +01:00
Dean Herbert	dc2945f4f8	Move avatar user loading to BDL also	2023-03-07 17:39:21 +09:00
Dean Herbert	5af41bb1c8	Move filter matching code into own method to simplify early returns	2023-03-07 17:24:17 +09:00
Dean Herbert	5e90b67be0	Move `GameplayState` usage to BDL	2023-03-07 17:01:29 +09:00
Dean Herbert	d98199961b	Adjust default sizing to fit a bit better with existing elements	2023-03-07 17:00:10 +09:00
Dean Herbert	6a7c4d0bf7	Remove `NRT` disables in new classes	2023-03-07 16:41:39 +09:00
Dean Herbert	97ba236eb1	Add basic xmldoc to `KeyCounter` classes	2023-03-07 16:41:39 +09:00
Dean Herbert	28520414aa	Move `KeyCounter` components to `HUD` namespace	2023-03-07 16:41:39 +09:00
Dean Herbert	15d65059b5	Tidy up `Add` method logic	2023-03-07 16:21:57 +09:00
Dean Herbert	8f6df5ea0f	Merge branch 'master' into gameplay/key-counter-abstraction	2023-03-07 16:09:45 +09:00
Dean Herbert	21bdbb20e6	Add optional support for cyclic selection to `BlueprintContainer`	2023-03-07 14:22:12 +09:00
tsrk	fc0e27fb15	style: use normalised `CornerRadius` values	2023-03-06 20:11:52 +00:00
tsrk	952814604e	style: fix late night oopsies	2023-03-06 20:06:56 +00:00
tsrk	3a240aaa5f	style: use 64 radius	2023-03-06 10:27:59 +00:00
Dean Herbert	87d0bef313	Use nullable comparison helper method instead of manual implementation	2023-03-06 15:16:32 +09:00
tsrk	07bde4990d	feat: implement `PlayerAvatar`	2023-03-05 23:17:39 +00:00
tsrk	654eacd449	feat(l10n): localise `CornerRadius`	2023-03-05 23:10:42 +00:00
tsrk	082bfe3621	refactor: `SkinnableAvatar` to `PlayerAvatar`	2023-03-05 23:09:02 +00:00
mk56-spn	908651cc11	make `ResetConfirmDialog` properly utilise its parent's logic Adjust name of `DeleteAction` to `DangerousAction`	2023-03-05 20:57:26 +01:00
OliBomby	70a925aab1	added extra early-returns	2023-03-04 16:49:33 +01:00
OliBomby	b90c389ff0	using List instead of Span in GetSearchableTerms	2023-03-04 15:42:35 +01:00
tsrk	d5ba5eed88	fix(SkinnableAvatar): init `avatar.CornerRadius`	2023-03-03 23:47:22 +00:00
tsrk	d39b8c7c23	fix(SkinnableAvatar): update outdated interface	2023-03-03 19:35:45 +00:00
Ruki	e75aa9138b	Merge branch 'ppy:master' into hud/avatar-thing	2023-03-03 20:03:56 +01:00
OliBomby	91d206e8d2	Optimised GetSearchableTerms Reduced memory allocations to 1	2023-03-03 19:21:50 +01:00
Dean Herbert	82293c0c86	Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes From a user's perspective, changing a sort / order mode shouldn't filter away results, but we were doing this. In terms of UX expectations, in stable this kind of scenario would results in a group being added to the end of son select with "Not ranked" or "Unknown". I think we should aim to match this eventually.	2023-03-03 16:36:18 +09:00
Dean Herbert	dc669835e2	Show count of visible beatmaps at song select	2023-03-03 15:28:51 +09:00
Dean Herbert	6ff1fb6b1a	Adjust sizing to allow for timing point information now being longer than before	2023-03-02 18:57:54 +09:00
Dean Herbert	044b0604b2	Move `OmitFirstBarLine` to `TimingControlPoint`	2023-02-28 19:29:31 +09:00
mk56-spn	90227a6496	Rename `DeleteConfirmationDialog.cs` into `DangerousActionDialog.cs`	2023-02-27 21:57:59 +01:00
tsrk	8c94b77de1	refactor(InputTrigger): move out of KCD I love JetBrains Rider.	2023-02-22 15:05:07 +00:00
tsrk	1beec71037	refactor(KeyCounterDisplay): apply suggestions I also took the freedom to add type checking, as we can't limit the usage of `Add()` since it's a Container. The exception thrown also advises of using the suggested `AddTrigger()` instead.	2023-02-22 14:58:27 +00:00
tsrk	42a5a06b9d	style(KeyCounter): fields and methods visiblity	2023-02-21 19:10:37 +00:00
tsrk	5bec2d7c52	style(KeyCounter): `forwardPlayback`	2023-02-21 19:02:56 +00:00
mk56-spn	299023fce0	Improve visibility of wedge shading in test scene and fix an issue with excessive roundness on said shadow.	2023-02-21 16:07:26 +01:00
Bartłomiej Dach	c9999bdeb1	Merge branch 'master' into skin-per-ruleset-layouts	2023-02-20 20:14:38 +01:00
Bartłomiej Dach	1ba1298850	Merge branch 'master' into blueprint-improve-visuals	2023-02-19 15:55:30 +01:00
Bartłomiej Dach	d9ca7102f0	Use more generic wording for future-proofing	2023-02-19 15:06:40 +01:00
Maximilian Kruse	723a043c43	naming change from Hitobject to HitObject	2023-02-19 10:18:22 +01:00
Maximilian Kruse	ddd37bb319	Add setting to disable automatic seeking after object placement	2023-02-18 19:43:45 +01:00
Bartłomiej Dach	6b9472c367	Merge branch 'master' into skin-per-ruleset-layouts	2023-02-17 22:58:38 +01:00
Bartłomiej Dach	8894a73b07	Merge branch 'master' into blueprint-improve-visuals	2023-02-17 21:40:16 +01:00
Bartłomiej Dach	6afa65bd3d	Merge branch 'master' into skinnable-clean-up-documentation	2023-02-17 20:59:18 +01:00
cdwcgt	e84e011d5d	Merge branch 'master' into export	2023-02-17 22:15:19 +09:00
Dean Herbert	a01c3090e4	Fix tests which rely on `HUDOverlay`'s `DrawableRuleset` being nullable	2023-02-17 19:27:09 +09:00
Dean Herbert	209d41ee9d	Use `RulesetInfo` instead of `Ruleset` in skin components lookup	2023-02-17 18:24:05 +09:00
Dean Herbert	16d94b4ea2	Improve visuals of skin blueprint	2023-02-17 18:19:46 +09:00
tsrk	8830e06588	fix: compilation	2023-02-17 09:17:11 +00:00
tsrk	c94e647e21	style(KeyCounterDisplay): remove type check	2023-02-17 09:09:56 +00:00
Dean Herbert	4cc6664dc7	Add optional ruleset identifier to `SkinComponentsContainerLookup`	2023-02-17 14:19:19 +09:00
tsrk	d0e8d65766	style(KeyCounter): rename `IsLit` to `IsActive`	2023-02-17 00:56:17 +00:00
tsrk	e3ca751027	refactor: make `FillFlowContainer` read-only	2023-02-16 23:17:47 +00:00
tsrk	c61fac578c	style(KeyCounter): rename methods and arguments As for the second suggestion in https://github.com/ppy/osu/pull/22654#discussion_r1109047998, I went with the first one as only one Trigger actually uses this argument for rewinding.	2023-02-16 23:15:03 +00:00
tsrk	ddd6c1a1c6	refactor(KeyCounter): address bindables issues `IsCounting` is back being an auto-property. `countPresses` is now encapsulated and being exposed as an `IBindable<int>` via `CountPresses`	2023-02-16 22:20:34 +00:00
tsrk	6340730427	refactor(KeyCounter): remove circularity	2023-02-16 21:59:39 +00:00
Bartłomiej Dach	ad5132ed41	Remove redundant conditional access qualifier It is impossible for the callback passed to `ApplyToBackground()` to receive a null reference. See `OsuScreen.ApplyToBackground()` - if the background to call the callback on were `null`, then an `InvalidOperationException` would be thrown instead.	2023-02-16 20:47:51 +01:00
Dean Herbert	394d368f16	Fix song select potentially updating background parameters when not the current screen	2023-02-16 18:45:22 +09:00
tsrk	74e7cc2056	feat: implement new design of key counter	2023-02-15 22:18:02 +00:00
tsrk	e9dcc257b4	reafactor: simplify type checking	2023-02-15 22:06:35 +00:00
tsrk	b0a2e69f95	style: nullable pass on `KeyCounterDisplay`	2023-02-15 22:06:10 +00:00
tsrk	076eb81b21	refactor: rename trigger classes Makes it better to understand their purpose	2023-02-15 21:46:13 +00:00
tsrk	a644fae364	style(KeyCounter): rename `(Un)lit` methods to `(Un)light`	2023-02-15 21:41:41 +00:00
tsrk	df0633858c	fix(KeyCounter): don't override Handle This caused the Keyboard inputs to register twice, which is not what we want.	2023-02-15 21:41:41 +00:00
tsrk	157bba7830	refactor: rename `Trigger` class to `InputTrigger`	2023-02-15 21:41:36 +00:00
Dean Herbert	a92e42bb84	Rename `SkinnableTargetContainer` to `SkinComponentsContainer` Also use full `SkinComponentsContainerLookup` instead of the sub-type. This will potentially be useful once we bring in per-ruleset targets.	2023-02-15 18:37:41 +09:00
Dean Herbert	d159d6b970	Rename `ISkinnableDrawable` to `ISerialisableDrawable`	2023-02-15 18:37:41 +09:00
Dean Herbert	6010dde86e	Move `SkinnableInfo` to better namespace	2023-02-15 18:23:10 +09:00
Dean Herbert	9ed068c1e6	Only apply dim changes when background blur is disabled	2023-02-15 14:16:34 +09:00
Dean Herbert	19e3c5d33c	Adjust song select background dimming to be more evenly applied	2023-02-15 13:59:24 +09:00
Dean Herbert	7aaaf7fca2	Combine and attempt to simplify the score import / preparation process further	2023-02-14 16:55:35 +09:00
Dean Herbert	8a206234f7	Merge branch 'master' into replay-length-extension	2023-02-14 16:42:26 +09:00
Dean Herbert	51d4ae5241	Merge branch 'master' into footer_V2_implementation	2023-02-14 14:00:53 +09:00
Dean Herbert	f0ebb920b9	Make `Action`s nullable	2023-02-14 13:54:00 +09:00
MK56	5006dbe3db	Update osu.Game/Screens/Select/FooterV2/FooterButtonV2.cs Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2023-02-14 00:07:02 +01:00
Bartłomiej Dach	939144fb6c	Merge pull request #22628 from EVAST9919/letterbox-no-containers Remove unnecessary containers in `LetterboxOverlay`	2023-02-13 23:54:48 +01:00
mk56-spn	ae9a17d76b	Add offset to `FooterButtonV2.cs` shadow	2023-02-13 22:20:41 +01:00
mk56-spn	be52d0a60c	Add note explaining shadow opacity pass ColourProvider in from test, instead of hard coding it in `FooterButtonV2.cs`	2023-02-13 22:18:34 +01:00
mk56-spn	61584ba63c	Fix corner_radius missing in some parts of `FooterButtonV2.cs`. Adjust shadow radius value to 5 to match figma.	2023-02-13 22:15:29 +01:00
mk56-spn	6e6421caea	Change FooterV2.cs colour to use `ColourProvider` instead of `OsuColour`. Remove unnecessary `FillFlowContainer`	2023-02-13 22:12:25 +01:00
Andrei Zavatski	2dee783401	Remove not needed containers	2023-02-13 15:14:25 +03:00
tsrk	aa2e0028ab	refactor: hide trigger presence from content	2023-02-13 10:59:10 +00:00
tsrk	11d0e185b8	refactor: separate impl of KeyCounterDisplay This allows for different layouts of display. Idk, maybe someone would want to mix both variants? (don't do this please). This commit is mostly prep for further changes.	2023-02-13 01:36:12 +00:00
tsrk	74a58fb674	refactor: separate things in KeyCounter To implement different different sources of input for KeyCounter, it is now possible to create a Trigger class (to inherit) instead of inheriting KeyCounter. This eases the creation of more input sources (like for tests) while allowing to implement different UI variants. That way, if another variant of the key counter needs to implemented (for whathever reason), this can be done by only inheriting KeyCounter and changing how things are arranged visually.	2023-02-13 01:24:27 +00:00
Joseph Madamba	cb51b9e350	Use existing `ModdingBeatmap` activity	2023-02-12 15:01:50 -08:00
Joseph Madamba	bbeef53569	Add `TestingBeatmap` activity	2023-02-12 13:11:42 -08:00
Joseph Madamba	afb66d8af4	Make user activity class names more specific	2023-02-12 12:32:17 -08:00
Bartłomiej Dach	774eae98cc	Merge branch 'master' into editor-select-timing-on-enter	2023-02-11 16:27:22 +01:00
Bartłomiej Dach	a3cc0d23b3	Fix typo in xmldoc	2023-02-11 16:26:32 +01:00
Dean Herbert	0c5dae5f26	Merge pull request #22529 from ItsShamed/dsc/presence Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`	2023-02-11 17:29:47 +09:00
Terochi	81c3e0da31	Fixed timeLeft counter in SongProgressInfo being out of bounds after rotation	2023-02-10 17:58:48 +01:00
Dean Herbert	6d876fdb9a	Automatically select the closest timing point on entering the timing screen	2023-02-10 17:48:56 +09:00
Dean Herbert	03e623d1d2	Move `ControlPointList` to own file	2023-02-10 17:37:31 +09:00
Dean Herbert	eccde923e5	Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability Improve readability of `AccuracyCircle`	2023-02-10 17:03:46 +09:00
Dean Herbert	cf009432cc	Centralise accuracy cutoff constants and add lookup helper methods	2023-02-09 15:41:58 +09:00
Walavouchey	57312279f0	adjust `RankNotch` gap size to match original value	2023-02-09 02:20:05 +01:00
Walavouchey	fd93bd3f50	move rank accuracy requirements to class-local constants	2023-02-09 00:46:24 +01:00
Walavouchey	ee40444fd3	use `Precision.AlmostEquals` for bounds check	2023-02-08 23:59:19 +01:00
Walavouchey	0531c010eb	display `RankBadge`s on on their sector centres the D `RankBadge` does this anyway. the A and S badges are slightly off centre to prevent overlap with the SS badge	2023-02-08 14:01:40 +01:00
Walavouchey	6ace6bfee1	ensure `AccuracyCircle` doesn't land in gaps created by `RankNotch`es	2023-02-08 13:20:53 +01:00
Dean Herbert	3a3c2e78a1	Merge branch 'master' into skin-editor-undo-support	2023-02-08 15:41:58 +09:00
Dean Herbert	b6809e156b	Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii Implement a sheared slider for the updated design	2023-02-08 15:01:00 +09:00
PC	7e127dafe2	Update reference	2023-02-07 11:52:47 +03:00
Dean Herbert	e162fd56da	Change the way initial state saving works in `EditorChangeHandler` to be closer to first change	2023-02-07 16:22:51 +09:00
tsrk	bc89f8dc5b	feat: add name and rulset verb display support	2023-02-06 12:44:00 +00:00
Cootz	2c7386db39	FIx score appearing on `BeatmapLeaderboard` and `TopLocalRank`	2023-02-06 15:14:14 +03:00
Dean Herbert	aaf3ad805c	Fix potential nullref in tests	2023-02-06 19:31:45 +09:00
Dean Herbert	b83c8443ea	Ensure pause sample loop is stopped on exiting player	2023-02-06 18:24:31 +09:00
Terochi	43f7665c9e	Improved readability again	2023-02-06 09:49:42 +01:00
Dean Herbert	c691a0d3af	Merge branch 'master' into sheared_slider_implementation_clean_ii	2023-02-06 17:49:33 +09:00
Dean Herbert	ddcc02fdfe	Merge pull request #22505 from Joehuu/fix-hover-click-sounds Fix some clickable elements having no hover and click sounds	2023-02-06 16:52:19 +09:00
Terochi	4f23e096d7	Improved readability	2023-02-06 07:59:37 +01:00
Dean Herbert	778b8a9bf7	Fix default settings not being serialised / state tracked correctly	2023-02-06 15:00:42 +09:00
Dean Herbert	e4b17588f5	Add missing xmldoc to new methods in `EditorChangeHandler`	2023-02-06 14:11:40 +09:00
Dean Herbert	10ab4d572a	Merge branch 'master' into skin-editor-undo-support	2023-02-06 13:46:50 +09:00
tsrk	bf273597ea	feat: actually support status also for Replays	2023-02-06 00:41:10 +00:00
tsrk	d5b2d9ce97	feat: add support for spectating status	2023-02-05 23:58:08 +00:00
Terochi	f58534f60c	Extended the length of replay at the end of map	2023-02-05 18:51:28 +01:00
Bartłomiej Dach	ef900bccdf	Merge branch 'master' into BPM_counter_fix	2023-02-04 23:44:58 +01:00
mk56-spn	38cc47d64e	Remove ```IsPresent``` usages	2023-02-04 16:52:30 +01:00
Bartłomiej Dach	cb7540564a	Merge pull request #22504 from peppy/fix-editor-positional-nudge-undo Fix beatmap editor positional nudging not being undoable	2023-02-04 15:52:34 +01:00
mk56-spn	88872cf1cf	Use ```GetTrueGameplayRate()``` to remove need for jank	2023-02-04 00:53:54 +01:00
mk56-spn	d9bee958dd	Stop ```BPMCounter.cs```'s value from going to 0 after failing.	2023-02-03 23:56:34 +01:00
Bartłomiej Dach	97afb83394	Merge branch 'master' into carousel	2023-02-03 22:15:44 +01:00
Bartłomiej Dach	63f7d326c2	Merge branch 'master' into fix-editor-positional-nudge-undo	2023-02-03 21:31:05 +01:00
Bartłomiej Dach	4bd43171e8	Merge branch 'master' into fix-skin-editor-padding-weirdness	2023-02-03 20:28:47 +01:00
mk56-spn	de37a0a000	enable pixelSnapping for the ```BufferedContainer``` in BeatmapInfoWedgeV2.cs	2023-02-03 19:53:04 +01:00
mk56-spn	5fc8f1d1be	Fix ```BeatmapInfoWedgeV2.cs``` starCounter needing janky rotation application	2023-02-03 19:52:01 +01:00
Dean Herbert	2cda277c09	Add a basic change handler to the skin editor	2023-02-03 18:57:50 +09:00
Dean Herbert	3345e34544	Move beatmap specific logic out of `EditorChangeHandler`	2023-02-03 17:53:54 +09:00
Joseph Madamba	5a76c1ab9c	Refactor `HoverSampleDebounceComponent` to inherit `Component`	2023-02-03 00:29:25 -08:00
Dean Herbert	b437501b0f	Fix beatmap editor positional nudging not being undoable	2023-02-03 17:28:58 +09:00
Dean Herbert	554f14151c	Apply NRT to `EditorChangeHandler`	2023-02-03 17:13:24 +09:00
Dean Herbert	b19047b90b	Fix skin editor component list having uneven padding	2023-02-03 16:55:51 +09:00
Dean Herbert	4ec46c7476	Merge branch 'master' into footer_V2_implementation	2023-02-03 16:30:16 +09:00
Dean Herbert	48f7e0163c	Adjust comments and formatting of comments	2023-02-03 16:27:20 +09:00
Dean Herbert	4248453616	Use `FinishTransforms` rather than manual duplication of background colour logic	2023-02-03 16:27:20 +09:00
Dean Herbert	a1200b8fe8	Adjust footer button colour handling to read better and take into account mouse down	2023-02-03 16:27:20 +09:00
Dean Herbert	cf8cfe0d2c	Move skin component localisations to namespaces	2023-02-03 15:34:57 +09:00
Dean Herbert	50559643bb	Fix incorrectly applied enum localisation	2023-02-03 15:27:11 +09:00
Dean Herbert	32207dc9dd	Merge branch 'master' into locale/skin-editor-components	2023-02-03 15:24:00 +09:00
Dean Herbert	f7094567d7	Rename and document method to limit scope	2023-02-03 15:04:47 +09:00
mk56-spn	80fd1a0bc7	Remove leftover comment regarding X axis offsets	2023-02-02 18:29:12 +01:00
mk56-spn	3f0ce75bf5	Rename NormalSliderBar.cs to RoundedSliderBar.cs	2023-02-02 17:24:45 +01:00
Dean Herbert	edecd2ee25	Merge branch 'master' into middle-click-replay-pause	2023-02-02 15:25:51 +09:00
Dean Herbert	91fbf388da	Use localisation strings from `ButtonSystem` for better consistency	2023-02-02 15:00:24 +09:00
Dean Herbert	500e9c7944	Refactor into a method rather than property	2023-02-02 14:53:58 +09:00
Dean Herbert	942e7729f3	Merge branch 'master' into carousel	2023-02-02 14:41:55 +09:00
tsrk	0fb6a63709	refactor: change namespacing to allow osu-localisation-analyzer to process all strings	2023-02-02 00:46:14 +00:00
tsrk	8645e705fd	feat: add localisation for Skin editor components	2023-02-01 23:48:05 +00:00
mk56-spn	27c52a45fc	Use inline lambda for scheduling	2023-01-30 16:13:55 +01:00
mk56-spn	92690afa5f	de-nest ```removeOldInfo()```	2023-01-30 16:12:26 +01:00
Ruki	96bd79a6f5	Merge branch 'ppy:master' into hud/avatar-thing	2023-01-30 15:43:29 +01:00
mk56-spn	c7d49bdc82	Update ```BeatmapInfoWedgeV2.cs`` `animation to be similar to exit transition in` ``SongSelect.cs``	2023-01-30 13:13:57 +01:00
mk56-spn	f5d579144b	Remove free mods button	2023-01-30 12:57:24 +01:00
mk56-spn	41f5e5143a	Remove ```onclick`` `and` ``mousedown``` override	2023-01-30 12:56:39 +01:00
mk56-spn	091cc155d3	Fix nub naming in OsuCheckbox.cs and associated classes	2023-01-26 16:10:02 +01:00
mk56-spn	a630f1113f	Rename nub object in NormalSliderBar.cs class	2023-01-26 15:03:51 +01:00
mk56-spn	374c3b56f6	Rename Nub.cs to NormalNub.cs	2023-01-26 15:03:11 +01:00
mk56-spn	3988131475	Rename OsuSliderBar.cs as NormalSliderBar.cs	2023-01-26 12:12:56 +01:00
Dean Herbert	e5d4979bc3	Fix default health bar having a very weird anchor point in the skin editor	2023-01-26 16:56:37 +09:00
Dean Herbert	e333e12b2e	Fix typo in settings enum (seriously)	2023-01-25 16:32:00 +09:00
Dean Herbert	3faab66f39	Merge branch 'master' into beatmapSelectionBlur	2023-01-25 16:32:00 +09:00
Dean Herbert	1a9ed1ac3f	Remove unnecessary `IgnoreUserSettings` value change	2023-01-25 16:28:06 +09:00
Jérémiah DÉCOMBE	e0a7559d85	variable naming + loc	2023-01-24 09:55:08 +01:00
Jérémiah DÉCOMBE	7ca2a431e6	changing song select background blur setting to boolean	2023-01-24 09:19:53 +01:00
Jérémiah DÉCOMBE	d783998c81	using BindValueChanged and IsCurrentScreen for setting binding	2023-01-24 09:09:05 +01:00
Dean Herbert	bb15ee50e0	Fix beatmap leaderboard potentially showing incorrect leaderboard	2023-01-24 13:52:59 +09:00
Jeremiah DECOMBE	c1876aac88	removing parameter name abbreviations	2023-01-24 00:36:38 +01:00
Jeremiah DECOMBE	b573e42cc2	BeatmapSelectionBackgroundBlurLevel renamed to SongSelectBackgroundBlurLevel	2023-01-24 00:08:11 +01:00
Jeremiah DECOMBE	26adc28943	missing blank line between methods	2023-01-23 23:15:37 +01:00
Jeremiah DECOMBE	f13a5465ba	variable naming and loc modifications	2023-01-23 23:07:50 +01:00
Bartłomiej Dach	7483967157	Merge branch 'master' into SliderEnd-Snap	2023-01-23 21:33:16 +01:00
Bartłomiej Dach	1f40b2daf6	Clean up xmldocs	2023-01-23 21:22:18 +01:00
mk56-spn	655242371b	Buffer wedge content to avoid opacity issues when showing / hiding	2023-01-23 17:00:46 +01:00
Jérémiah DÉCOMBE	6daa364779	adding setting to adjust blur of the background of the song select screen	2023-01-23 13:53:31 +01:00
Dean Herbert	e3932c077b	Merge pull request #22032 from frenzibyte/fix-potential-difficulty-failure-alt Fix advanced statistics display potentially performing invalid difficulty calculation	2023-01-23 15:39:47 +09:00
Bartłomiej Dach	06aa3f7798	Rename `Stop{SampleAndRemoveFilters -> }()` Now that just one method for stopping samples is left, let's just repurpose st as the general "stop global effects" method rather than have it there with a hyperspecific name. It also has good symmetry, as there already was a `Start()` method in the class.	2023-01-22 09:29:22 +01:00
Bartłomiej Dach	9e4e85e3e3	Inline `StopSample()` into `StopSampleAndRemoveFilters()` The first method no longer has any callers except for the second one.	2023-01-22 09:26:01 +01:00
Bartłomiej Dach	0edfd24410	Remove unnecessary sample stop in `Restart()` It is unnecessary, as a successful restart will exit the current player screen, and `OnExiting()` has another `StopSampleAndRemoveFilters()` call, which means that in the restart flow the sample was actually getting stopped twice. Standard exit flow is fine, it only stopped the sample once.	2023-01-22 09:24:12 +01:00
Matheus Filipe dos Santos Reinert	5b1a23c697	Replace RemoveFilters call with StopSampleAndRemoveFilters	2023-01-22 01:44:16 -03:00
Matheus Filipe dos Santos Reinert	2e1ba6ef49	Create StopSampleAndRemoveFilters method and change RemoveFilters to private	2023-01-22 01:43:40 -03:00
Matheus Filipe dos Santos Reinert	a746cbc6ed	Fix failSample still playing after player left FailOverlay	2023-01-22 01:14:33 -03:00
Dean Herbert	2ce32e3209	Refactor update logic to be easier to follow	2023-01-19 19:27:05 +09:00
mk56-spn	b22363ed8c	Fix JudgementCounterDisplay.cs max judgement always showing upon changing display mode	2023-01-19 10:31:02 +01:00
Dean Herbert	e58abf7d1a	Merge pull request #22284 from bdach/judgement-counter-broken Fix "show max judgement" setting not applying initially on judgement counter display	2023-01-19 09:09:06 +09:00
Bartłomiej Dach	b62ff8d644	Merge branch 'master' into skin/argon-song-progress-cleaner	2023-01-18 23:52:12 +01:00
Bartłomiej Dach	b8b7442eb8	Make `SongProgressInfo.ShowProgress` init-only (and remove duplicate init)	2023-01-18 23:35:40 +01:00
Wleter	f8d8a627b8	change property name	2023-01-18 22:00:39 +01:00
Bartłomiej Dach	769f8c6190	Fix `ShowMaxJudgement` callback conflicting with `JudgementCounter.Pop{In,Out}` Both `JudgementCounterDisplay` (via the `ShowMaxJudgement` callback) and the `JudgementCounter.Pop{In,Out}` methods were operating on the alpha of the `JudgementCounter`. This meant that if the counter display was created with max judgement initially hidden, it would be hidden by the `ShowMaxJudgement` callback first, but then _unhidden_ by `PopIn()`.	2023-01-18 21:46:28 +01:00
Wleter	40e99069fc	fix typos and newlines	2023-01-18 21:43:09 +01:00
Wleter	ab78dd0436	add collection of selection points.	2023-01-18 21:34:23 +01:00
Bartłomiej Dach	4a6f6300c5	Merge branch 'master' into fix-carousel-sort-change-after-play	2023-01-18 17:15:20 +01:00
Bartłomiej Dach	7ba448b13c	Update comment to match implementation	2023-01-18 17:12:57 +01:00
Wleter	c9375c056e	revert back name change	2023-01-18 15:54:24 +01:00
mk56-spn	0ac7cd7409	Expose star difficulty to wedge to allow updating starcounter and background colour internally.	2023-01-18 13:55:52 +01:00
Salman Ahmed	12fc5da143	Merge branch 'master' into frame-stable-cache	2023-01-18 14:16:46 +03:00
Dean Herbert	3b27774561	Remove `OnlineID` sort consideration	2023-01-18 19:21:02 +09:00
Dean Herbert	43a037c189	Merge pull request #21620 from mk56-spn/JudgementCounter Add a judgement counter to skin components	2023-01-18 18:43:49 +09:00
Dean Herbert	ecb4727aec	Fix formatting issues	2023-01-18 17:33:14 +09:00
Dean Herbert	4cfb059170	Merge branch 'frame-stable-cache' into skin/argon-song-progress-cleaner	2023-01-18 17:21:08 +09:00
Dean Herbert	04705504c5	Move cache to more appropriate location	2023-01-18 17:19:57 +09:00
Dean Herbert	67b40dd234	Adjust the seek effect to feel better	2023-01-18 17:09:39 +09:00
Dean Herbert	01558a9199	Tidy up height logic and allow hovering above bar for easier interaction	2023-01-18 17:09:29 +09:00
Dean Herbert	f3677ab33d	Simplify depth change logic	2023-01-18 16:38:21 +09:00
Dean Herbert	7d0388c55c	Cache `IFrameStableClock` in `Player` for easier access Allows directly referencing rather than going through `DrawableRuleset`. Helps with testing and implementation of the new song progress display (#22144).	2023-01-18 16:31:58 +09:00
Dean Herbert	42e9b2b48c	Tidy up clock logic in all `SongProgress` classes	2023-01-18 16:29:42 +09:00
Dean Herbert	8bfd853889	Fix missing comment	2023-01-18 16:11:14 +09:00
Dean Herbert	bfb75730a9	Prefix subclasses of `DefaultSongProgress` with `Default`	2023-01-18 15:45:16 +09:00
Dean Herbert	7266d8e10d	Move "show difficulty graph" settings back to respective implementations to avoid legacy version showing it	2023-01-18 15:31:55 +09:00
Dean Herbert	5a272b4bd6	Merge branch 'master' into skin/argon-song-progress-cleaner	2023-01-18 15:25:02 +09:00
Dean Herbert	742a026077	Add comment mentioning why reference clock fallback logic is required	2023-01-18 15:24:35 +09:00
Dean Herbert	e8770b84cd	Remove no longer necessary interface type	2023-01-18 15:23:55 +09:00
Dean Herbert	5429979049	Combine common code into `SongProgress` base class	2023-01-18 15:23:55 +09:00
Dean Herbert	afc12e0b83	Tidy up `ISongProgressBar` interface	2023-01-18 14:43:20 +09:00
Dean Herbert	4ad79a8a0a	Move `IsLoaded` check inside `BeatmapCarousel`	2023-01-18 12:00:47 +09:00
mk56-spn	92a755c5da	adjust colourbar to position itself in a more simple fashion	2023-01-17 22:16:59 +01:00
Wleter	788033e1b8	fix unnecessary newline	2023-01-17 21:13:54 +01:00
Bartłomiej Dach	6f11fbdeed	Merge branch 'master' into fix-carousel-sort-change-after-play	2023-01-17 20:46:06 +01:00
Wleter	b8e6a2d87b	filter currentEndPointPositions	2023-01-17 20:41:49 +01:00
tsrk	f1989ba24d	quality: remove unused `Darken` bindable boolean	2023-01-17 17:26:05 +00:00
Dean Herbert	8e1002b744	Fix song select potentially operating on `Carousel` before it is fully loaded Should fix test failures like https://github.com/ppy/osu/actions/runs/3939620830/jobs/6739690253.	2023-01-18 01:56:18 +09:00
tsrk	d91aa341e5	refactor(ArgonSongProgress): reorder layering and make density graph visible for past time	2023-01-17 13:16:56 +00:00
Dean Herbert	14649160e1	Adjust transform delay to make things feel more snappy	2023-01-17 18:39:21 +09:00
Dean Herbert	81aa7feeb5	Fix using `FadeTo` on a visibility container	2023-01-17 18:39:21 +09:00
Dean Herbert	48959c0212	Start name not visible to avoid pop out when hidden on startup	2023-01-17 18:35:19 +09:00
Dean Herbert	7d1fd24ab4	Start all counters hidden to fix pop out animation when some portions are hidden	2023-01-17 18:31:25 +09:00
Dean Herbert	448abf897a	Tidy up direction assignment	2023-01-17 18:31:08 +09:00
Dean Herbert	ca17993769	Don't use `OverlayContainer` (what)	2023-01-17 18:30:50 +09:00
Dean Herbert	181473c5fc	Rename flow to better match its purpose	2023-01-17 18:28:08 +09:00
Dean Herbert	35ad66eef9	Give flow container a type to avoid locally casting in every location	2023-01-17 18:27:33 +09:00
Dean Herbert	09c7ab3af6	Rename exposed settings to make more sense	2023-01-17 18:27:15 +09:00
Dean Herbert	f923dc5009	Use framework `Direction` instead of local enum It should be stable enough to use.	2023-01-17 18:27:15 +09:00
Dean Herbert	0a7d6948ca	Nest model class	2023-01-17 18:19:04 +09:00
Dean Herbert	b62b5714e8	Fix `TierColours` assignment	2023-01-17 18:07:11 +09:00
Dean Herbert	65bd2e74fd	Merge branch 'master' into skin/argon-song-progress-cleaner	2023-01-17 18:00:42 +09:00
MK56	a55ce9b586	Merge branch 'master' into JudgementCounter	2023-01-17 09:55:45 +01:00
Dean Herbert	53e7873f6c	Merge branch 'master' into fix-pause-gameplay-action-not-closing	2023-01-17 17:41:16 +09:00
Joseph Madamba	da0eb9b0cb	Simplify `TriggerClick`s in gameplay menu overlays	2023-01-17 00:34:52 -08:00
Dean Herbert	a9ac28b504	Add fallback sorts to `CarouselBeatmapSet` to ensure stable sorting	2023-01-17 16:40:25 +09:00
Joseph Madamba	8f7cb18217	Use `TriggerClick()` instead of calling `BackButton` action for pause gameplay	2023-01-16 23:36:28 -08:00
Dean Herbert	9acf22b2b1	Merge branch 'master' into song_select_nullability	2023-01-17 15:29:37 +09:00
Dean Herbert	ef35493864	Avoid need for weird null check by reordering initialisation process	2023-01-17 15:27:21 +09:00
Dean Herbert	a02556d2fa	Move hover logic to `SettingsToolboxGroup` to avoid expanded state clash	2023-01-17 14:43:22 +09:00
Dean Herbert	6a0bf89401	Merge branch 'master' into replay-menu-expanded-state-memory	2023-01-17 14:30:23 +09:00
mk56-spn	74b72e4ac0	Address issues that joehuu brought up	2023-01-16 22:46:18 +01:00
Dean Herbert	4224907f08	Merge pull request #22208 from Feodor0090/editor-loc Localise most visible parts of editor	2023-01-16 23:05:17 +09:00
OliBomby	832d033777	Fix merge issues	2023-01-16 01:09:04 +01:00
OliBomby	ab6bf6e1dc	Merge remote-tracking branch 'upstream/master' into carousel	2023-01-16 00:27:56 +01:00
OliBomby	1c0a650575	Fix typo	2023-01-16 00:17:26 +01:00
OliBomby	87ee9ab813	Added custom menu items in DrawableCarouselBeatmap	2023-01-16 00:13:12 +01:00
ansel	00acea59fc	Move some strings to common	2023-01-15 19:37:40 +03:00
mk56-spn	9a29c9ae26	remove hacky method to check if carousel is null	2023-01-15 15:32:53 +01:00
Dean Herbert	c5775aa452	Merge branch 'master' into song_select_nullability	2023-01-15 22:44:13 +09:00
Dean Herbert	4cf4a66858	Make `MusicController` a required dependency of `SongSelect`	2023-01-15 22:43:30 +09:00
Dean Herbert	f7af5a8115	Revert some formatting changes	2023-01-15 22:39:00 +09:00
ansel	5d2e09137c	Remove text padding in editor menu for now	2023-01-15 14:40:53 +03:00
ansel	8777d5349b	Use existing strings	2023-01-15 14:39:34 +03:00
ansel	87650044bb	Localise create/save dialog	2023-01-15 01:50:47 +03:00
ansel	78e562903d	Localise part of editor	2023-01-15 01:50:47 +03:00
ansel	24df23f420	Localise background header	2023-01-15 01:49:19 +03:00
ansel	76eefc7573	Add support for localisation where it was missing	2023-01-15 01:46:11 +03:00
integer	a68d4fe5d1	make expansion to not use scheduler	2023-01-14 21:18:51 +00:00
Dean Herbert	4906f37109	Merge pull request #22181 from frenzibyte/attempt-fix-song-select-test-failure Fix intermittent failure in beatmap carousel tests	2023-01-15 02:35:36 +09:00
integer	2831db53f7	fix wrong control flow on hover lost	2023-01-14 14:19:02 +00:00
ekrctb	e610d19d55	Merge branch 'master' into 18469	2023-01-14 19:53:08 +09:00
Dean Herbert	cfc8fd0aa1	Merge pull request #22188 from Feodor0090/nofs-locale Localise some notifications	2023-01-14 18:12:54 +09:00
ansel	77e8315ee2	Adjust naming	2023-01-14 02:30:10 +03:00
ansel	f70dedfd17	Enable nullability for design screen	2023-01-14 02:24:48 +03:00
ansel	4b42240fba	Enable nullability for setup screen	2023-01-14 02:24:28 +03:00
ansel	78adaa9b03	Enable nullability for timing screen	2023-01-14 02:23:21 +03:00
integer	c3c1d77e8e	make `PlayerSettingsGroup` expand on hover	2023-01-13 23:07:59 +00:00
integer	0b5c89d01f	revert additions to `SessionStatics`	2023-01-13 23:07:21 +00:00
ansel	515ada6815	Remove `CanBeNull` where it's no longer requered	2023-01-13 23:11:50 +03:00
ansel	a41a031909	Localise some notifications	2023-01-13 23:11:25 +03:00
Salman Ahmed	112cf403ec	Fix intermittent failure in certain beatmap carousel tests	2023-01-13 19:41:44 +03:00
Dylan Nantz	6028abff39	Code Quality	2023-01-13 10:16:52 -05:00
Dylan Nantz	5dd0aaccef	Merge branch 'master' of https://github.com/ppy/osu into 18469	2023-01-13 09:54:29 -05:00
Dylan Nantz	e38075c4ef	Use PlacementState to check juice stream placement	2023-01-13 09:37:23 -05:00
mk56-spn	a6b6fb864e	Make carousel non nullable and ensure pre load usages of methods that reference it are protected against failure	2023-01-13 13:10:29 +01:00
mk56-spn	403ca05e5e	Enable nullability for song select	2023-01-13 00:52:14 +01:00
ansel	2365b065a4	Enable nullability for editor components	2023-01-12 18:07:54 +03:00
Ruki	4439698867	Update osu.Game/Screens/Play/HUD/ArgonSongProgress.cs	2023-01-12 13:19:03 +01:00
Dean Herbert	d2309feec2	Merge branch 'master' into skin/argon-song-progress-cleaner	2023-01-12 19:49:27 +09:00
MK56	1597bcbb6f	Merge branch 'master' into JudgementCounter	2023-01-11 11:04:37 +01:00
Dean Herbert	df54410075	Fix skin fail sound not correctly playing Closes #21719. Tested using skin in issue thread.	2023-01-11 17:31:30 +09:00
Wleter	98ffcd33c7	Merge branch 'ppy:master' into SliderEnd-Snap	2023-01-10 21:22:13 +01:00
Wleter	88060a3ea0	add snapping for slider's end	2023-01-10 21:21:09 +01:00
Bartłomiej Dach	1eaabb5ca8	Merge branch 'master' into carousel_nullability_disabling_removal	2023-01-10 18:39:42 +01:00
Bartłomiej Dach	aab84d50eb	Remove boxing overhead in `CarouselItem` comparator	2023-01-10 18:35:06 +01:00
mk56-spn	880428046a	Fix margins on top right aligned elements.	2023-01-10 18:03:28 +01:00
mk56-spn	2a82f618ed	Add TODO for text margin const, added pertinent comments to known "issues"	2023-01-10 17:34:47 +01:00
mk56-spn	9afdfd7f06	small tweaks, container edge - effect addition..	2023-01-10 11:45:41 +01:00
mk56-spn	65c30d2c2e	Remove nullability disabling	2023-01-10 11:45:41 +01:00
mk56-spn	1698272eb8	Simplify passing data from BeatmapInfoWedgeV2.cs to subclass wedgeinfotext	2023-01-10 11:45:40 +01:00
mk56-spn	61caabaa8e	Add coloured star counter	2023-01-10 11:45:40 +01:00
mk56-spn	0199c19f74	Add a test scene and move colour bar to back and adjust positioning of it	2023-01-10 11:45:40 +01:00
mk56-spn	c646f8479b	Move stardifficulty logic to main BeatmapInfoWedge class instead of text subclass ( for use by background star rating colour bar )	2023-01-10 11:45:40 +01:00
mk56-spn	f561120295	Remove info labels, since they are no longer present in this component in thew new design	2023-01-10 11:45:40 +01:00
Dean Herbert	3210586eb6	Merge pull request #21519 from mk56-spn/variable_BPM_counter Add dynamic BPM counter to SkinEditor	2023-01-10 18:43:50 +09:00
Dean Herbert	60eeb4607c	Merge pull request #19528 from Joehuu/fix-op-non-current-onexiting Fix online play screen only accounting for current sub screen onexiting blocks	2023-01-10 18:43:19 +09:00
Dean Herbert	37d219a8ad	Fix comments, remove fixed width on "bpm" text and adjust baseline adjust slightly	2023-01-10 18:20:39 +09:00
Dean Herbert	85f542c3a8	Make `GameplayClock` `private`	2023-01-10 18:15:10 +09:00
Dean Herbert	3c93d0551c	Move setting up to be in line with other toggle	2023-01-10 18:07:15 +09:00
Dean Herbert	63ce5787e7	Start bars invisible	2023-01-10 18:06:45 +09:00
Dean Herbert	b7e845201f	Fix whitespace around `Debug.Assert`	2023-01-10 18:03:17 +09:00
Dean Herbert	d53dafa29f	Revert `Debug.Assert`	2023-01-10 17:52:28 +09:00
Dean Herbert	93038ce496	Use `OfType` instead of forceful nullability	2023-01-10 17:52:21 +09:00
tsrk	91cde5ffbf	feat(hud/gameplay): implement Argon variant of `SongProgress`	2023-01-09 21:59:48 +01:00
tsrk	5952cd08a2	feat(hud/gameplay): implement Argon song progress density graph (SegmentedGraph)	2023-01-09 21:58:53 +01:00
tsrk	28d2d766eb	refactor(hud/gameplay/SongProgressInfo): minor changes to text positioning, font and colour	2023-01-09 21:57:32 +01:00
tsrk	f6265197e8	feat(hud/gameplay): Add Argon variant of `SongProgressBar`	2023-01-09 21:56:29 +01:00
tsrk	0f1fe1d683	refactor(hud/gameplay/SongProgress): Add interface to designate `SongProgressBar`s	2023-01-09 21:48:53 +01:00
mk56-spn	602062f011	Address unclear naming issue	2023-01-09 21:04:51 +01:00
mk56-spn	6abbc7dc28	Further fix nullability	2023-01-09 20:59:28 +01:00
mk56-spn	d6f60db234	Add the ability to toggle the visibility of the main bar in BarHitErrorMeter.cs	2023-01-09 18:51:51 +01:00
mk56-spn	69260ca3c3	remove unnecessary usages of nullable forgiveness, add asserts for debugging	2023-01-09 18:36:55 +01:00
Dean Herbert	9d97c1a0bd	Merge branch 'master' into variable_BPM_counter	2023-01-09 19:26:34 +09:00
Dean Herbert	54b2fe9df3	Merge branch 'master' into fix-op-non-current-onexiting	2023-01-09 19:12:42 +09:00
Joseph Madamba	c2dd822e4a	Make pause overlay close with pause gameplay action	2023-01-08 14:12:09 -08:00
Bartłomiej Dach	2803c98612	Merge pull request #22047 from Feodor0090/wcd-length-fix Fix `WaveformComparisonDisplay` does not take into account start time of control points	2023-01-08 20:36:35 +01:00
Salman Ahmed	f2609820c1	Merge branch 'master' into fix-player-loader-logo-drag	2023-01-08 21:48:07 +03:00
Bartłomiej Dach	e08b7c615b	Merge branch 'master' into wcd-length-fix	2023-01-08 19:44:12 +01:00
Salman Ahmed	7dd0f892c8	Merge branch 'master' into fix-player-loader-logo-drag	2023-01-08 21:29:03 +03:00
mk56-spn	47fb467012	Remove nullable disabling in carousel	2023-01-08 19:02:48 +01:00
Bartłomiej Dach	9fd305a970	Merge branch 'master' into editor-bg-refresh	2023-01-08 18:57:04 +01:00
Dean Herbert	750b55d9b7	Update other events to have matching return types (and animate more)	2023-01-08 22:28:19 +09:00
Joseph Madamba	45bae5d424	Add middle mouse to toggle pause replay instead of using pause gameplay keybinds	2023-01-07 11:30:02 -08:00
Joseph Madamba	bae3a6851b	Block hover events behind logo even if action is null	2023-01-07 11:15:51 -08:00
ansel	aaeb43fbb2	Return older file if new one is null	2023-01-07 18:15:57 +03:00
Salman Ahmed	a65466bdac	Merge branch 'master' into previewTime	2023-01-07 15:07:09 +03:00
Salman Ahmed	abca13eb6c	Rewrite visualisation piece to bind once and without potential event leak	2023-01-07 14:40:15 +03:00
Salman Ahmed	904c76e437	Use sane `BeatmapInfo` for preview time mutation `EditorBeatmap.BeatmapInfo` is usually the correct instance for mutating properties that should persist in the database.	2023-01-07 14:23:36 +03:00
ansel	b47cef838c	Nullability	2023-01-07 03:08:02 +03:00
ansel	167ac8b5dd	Fix editor object being requered	2023-01-07 03:03:52 +03:00
Joseph Madamba	53d7dcefe5	Fix osu! logo not being draggable on player loader	2023-01-06 09:30:25 -08:00
ansel	9364c7775d	Refresh background on file change in editor	2023-01-06 19:26:30 +03:00
ansel	e90c698e62	Fix WCD does not take into account start time of control points	2023-01-06 16:35:39 +03:00
Dean Herbert	c0cfa66510	Merge pull request #21754 from Feodor0090/waveform-invalidate Reload waveform on track replacement in editor	2023-01-06 19:57:27 +08:00
Dean Herbert	938658649e	Merge pull request #22043 from frenzibyte/fix-solo-leaderboard-hyphen Fix gameplay leaderboard showing "-" on non-tracked scores	2023-01-06 18:12:00 +08:00
Dean Herbert	464f251c0c	Merge branch 'master' into beatmap-set-link-genre-language	2023-01-06 17:09:06 +08:00
Salman Ahmed	408356d05e	Fix gameplay leaderboard showing "-" on non-tracked scores	2023-01-06 12:06:47 +03:00
ansel	c6e2104ec2	Refresh waveforms instead of recreating the whole component	2023-01-06 03:46:49 +03:00
Salman Ahmed	88148567c0	Merge branch 'master' into fix-playlist-item-regressions	2023-01-05 15:31:27 +03:00
Salman Ahmed	8f37e69dc4	Schedule difficulty calculation to avoid performing with incomplete state updates	2023-01-05 12:52:08 +03:00
Salman Ahmed	39221a52da	Fix advanced statistics display using decoupled ruleset bindable for difficulty calculation	2023-01-05 12:52:08 +03:00
Joseph Madamba	5fb6f220e6	Fix playlist items not animating when rearranging	2023-01-03 11:10:02 -08:00
Joseph Madamba	5dfd4180c8	Fix playlist selecting random item when not allowed after deleting	2023-01-03 11:10:02 -08:00
Dean Herbert	beb3b96aca	Harden request equality checks	2023-01-04 01:44:00 +08:00
Dean Herbert	8f7ae0395a	Fix song select leaderboard potentially showing wrong scores on quick beatmap changes Closes #22002.	2023-01-03 00:55:09 +08:00
Joseph Madamba	d79ee29f29	Make replays pause with middle mouse button instead of exiting	2023-01-01 21:01:12 -08:00
Bartłomiej Dach	b689ad6d80	Fix changing preview point not prompting for save	2023-01-01 19:54:26 +01:00
Bartłomiej Dach	efdd557f3b	Adjust binding logic	2023-01-01 19:45:23 +01:00
Bartłomiej Dach	452ebddfd2	Adjust visual appearance of preview time part - Use slightly different hue of green to distinguish from difficulty control points. The colour is still not ideal, but picking a distinctive enough hue is pretty hard. - Place the preview time part at the bottom rather at the top. Not sure why it was at the top; not only could it overlap with the control points, but it also looked quite badly misaligned there when bookmarks were displayed at the bottom.	2023-01-01 19:42:55 +01:00
Bartłomiej Dach	a82f1a6abd	Adjust method naming and copy	2023-01-01 18:50:47 +01:00
Bartłomiej Dach	0e59b55a12	Merge branch 'master' into previewTime	2023-01-01 18:38:19 +01:00
Bartłomiej Dach	6509d3538c	Fix counter initially rolling down from 100% to 0% in minimum achievable mode	2022-12-30 21:13:41 +01:00
Bartłomiej Dach	7580ab78be	Move binding to `LoadComplete()`	2022-12-30 21:08:48 +01:00
Bartłomiej Dach	6d42cc5a36	Naming pass	2022-12-30 20:30:58 +01:00
cdwcgt	d60349c7c6	add description	2022-12-30 23:24:41 +09:00
cdwcgt	8beb168be9	remove nullable disabled	2022-12-30 23:24:20 +09:00
cdwcgt	784fe7ecf2	rename `AccType` to `AccuracyDisplay`	2022-12-30 23:06:10 +09:00
cdwcgt	23c485c763	readonly	2022-12-30 22:59:56 +09:00
cdwcgt	a91da2284d	safe way to pass bindable	2022-12-30 22:58:46 +09:00
cdwcgt	3c32a50c12	add new accuracy counter display	2022-12-30 21:19:46 +09:00
mk56-spn	680646d3a6	Make offsetting of bottom bar more readable	2022-12-29 12:02:08 +01:00
Bartłomiej Dach	3c0b8af8f1	Allow unsubscribing from solo statistics updates This is more of a safety item. To avoid potential duplicate key in dictionary errors (and also avoid being slightly memory-leaky), allow `SoloStatisticsWatcher` consumers to dispose of the subscriptions they take out.	2022-12-28 08:07:48 +01:00
Bartłomiej Dach	04f9a354c3	Convert `SoloResultsScreen` to NRT	2022-12-28 07:54:36 +01:00
Bartłomiej Dach	e90619244d	Fix incorrect accuracy display on overall ranking view	2022-12-27 19:51:51 +01:00
Dean Herbert	df6f2ad0a1	Merge pull request #21804 from bdach/hide-global-rankings-when-presenting-scores Only show global rankings on solo results screen when progressing from gameplay	2022-12-27 16:39:26 +08:00
integer	a0690e7ffb	replay menus remembers expanded state no messing with readonly fields	2022-12-27 00:13:46 +00:00
Bartłomiej Dach	01cf96e240	Only show global rankings on results screen when progressing from gameplay	2022-12-26 23:35:45 +01:00
Berkan Diler	c7ca4bbba5	Use generic Enum methods	2022-12-26 20:36:39 +01:00
Joseph Madamba	0dba25e0ab	Refactor to just exit sub screens until lounge sub screen Co-Authored-By: Salman Ahmed <frenzibyte@gmail.com>	2022-12-25 21:56:22 -08:00
Joseph Madamba	5232588a1f	Use `PerformFromScreen` to exit sub screens instead	2022-12-24 20:04:45 -08:00
Joseph Madamba	00ed5d6f92	Merge remote-tracking branch 'upstream/master' into fix-op-non-current-onexiting	2022-12-24 14:01:11 -08:00
Bartłomiej Dach	36a6f3685e	Don't show global rankings display when not logged in	2022-12-24 14:35:11 +01:00
Bartłomiej Dach	da519acb20	Add overall ranking display to solo results	2022-12-24 14:35:04 +01:00
Bartłomiej Dach	3abdf557ea	Add protected method for customising statistics panel rows	2022-12-24 14:35:00 +01:00
Bartłomiej Dach	600ada46be	Add protected method for customising statistics panel	2022-12-24 14:34:54 +01:00
Bartłomiej Dach	cf0b3ec879	Merge branch 'master' into score-stats-display	2022-12-24 14:32:08 +01:00
Bartłomiej Dach	83a50816b6	Remove unused constructor param	2022-12-24 10:44:38 +01:00
Bartłomiej Dach	4e5109a649	Use plain bindable flow instead of binding to watcher directly	2022-12-24 10:27:28 +01:00
Bartłomiej Dach	c7f248e13c	Implement overall ranking display for solo results screen	2022-12-24 00:30:38 +01:00
Joseph Madamba	494886ef92	Rename `Text` to `Metadata`	2022-12-23 11:11:15 -08:00
ansel	f25439e359	Move track change subscription to LoadComplete	2022-12-23 01:54:49 +03:00
Bartłomiej Dach	676d4a0d6d	Merge branch 'master' into fix-waveform-zoom-reload	2022-12-22 23:48:50 +01:00
Salman Ahmed	0cb9b79834	Fix `ZoomableScrollContainer` potentially not updating content width on setup	2022-12-23 00:56:38 +03:00
Salman Ahmed	30de9ba795	Dispose previous waveform on track reload	2022-12-23 00:35:59 +03:00
Berkan Diler	08d2fbeb8e	Use new ArgumentNullException.ThrowIfNull throw-helper API	2022-12-22 21:27:59 +01:00
ansel	20370bd5ae	Invalidate waveform on track load	2022-12-22 20:49:09 +03:00
ansel	d0645ce151	Rewrite waveform invalidation	2022-12-22 15:59:51 +03:00
ansel	f2e8776529	Bind to clock instead of music controller	2022-12-22 15:35:53 +03:00
ansel	a18ece8610	Listen for track reload in timing screen	2022-12-22 01:24:23 +03:00
ansel	7089bb6c23	Listen for track reload in timeline	2022-12-22 01:23:59 +03:00
ansel	66a02374da	Clear cached waveform on track change in editor	2022-12-22 01:23:24 +03:00
Bartłomiej Dach	6948035a3c	Ensure score submission attempt completion before notifying spectator server when exiting play early When a `SubmittingPlayer` gameplay session ends with the successful completion of a beatmap, `PrepareScoreForResultsAsync()` ensures that the score submission request is sent to and responded to by osu-web before calling `ISpectatorClient.EndPlaying()`. While previously this was mostly an implementation detail, this becomes important when considering that more and more server-side flows (replay upload, notifying about score processing completion) hook into `EndPlaying()`, and assume that by the point that message arrives at osu-spectator-server, the score has already been submitted and has been assigned a score ID that corresponds to the score submission token. As it turns out, in the early-exit path (when the user exits the play midway through, retries, or just fails), the same ordering guarantees were not provided. The score's submission ran concurrently to the spectator client `EndPlaying()` call, therefore creating a network race. osu-server-spectator components that implciitly relied on the ordering provided by the happy path, could therefore fail to unmap the score submission token to a score ID. Note that as written, the osu-server-spectator replay upload flow is not really affected by this, as it self-corrects by essentially polling the database and trying to unmap the score submission token to a score ID for up to 30 seconds. However, this change would have the benefit of reducing the polls required in such cases to just one DB retrieval.	2022-12-21 22:23:26 +01:00
Joseph Madamba	1d39e8d0ce	Refactor `MetadataSection` to use generics and inheritance	2022-12-21 10:18:47 -08:00
mk56-spn	626f4b0dfd	fix test failures, improve button logic	2022-12-19 16:35:20 +01:00
MK56	878e2f24c4	Merge branch 'master' into footer_V2_implementation	2022-12-19 13:19:23 +01:00
mk56-spn	407b0a0ad3	Address issues from Joehuu review	2022-12-19 11:30:23 +01:00
Dean Herbert	4a7d7c6ed9	Use `MaxBy` in all locations that can and update inspection level to match `dotnet-build`	2022-12-19 16:47:10 +09:00
Dean Herbert	b64a5cbda6	Merge branch 'master' into guard-url-protocols	2022-12-19 15:46:45 +09:00
Bartłomiej Dach	fea0895f16	Call spectator `EndPlaying()` immediately after score submission As it turns out, in current `master`, if a gameplay session ends normally (i.e. by the player completing the beatmap in full), then the spectator server `EndPlaying()` method will not be called until `SubmittingPlayer.OnExiting()`, which in practice turns out to be the moment where the user exits from the post-gameplay results screen back to song select. There is seemingly no reasonable cause for not calling this earlier. In fact the solo spectator flow looks more broken without this call than with, because without it the spectator view just hangs until the spectated player exits gameplay, and only then shows results, rather than do it upon normal gameplay completion.	2022-12-17 21:35:43 +01:00
mk56-spn	f3873b73e3	Clean up syntax for readability	2022-12-16 20:56:34 +01:00
Dean Herbert	ba54551313	Merge branch 'master' into guard-url-protocols	2022-12-16 18:23:16 +09:00
Dean Herbert	27c497145f	Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0	2022-12-16 18:16:26 +09:00
Jamie Taylor	d5b2c7dfe9	Clamp SFX panning on results screen	2022-12-16 17:19:07 +09:00
Dan Balasescu	cbee72897a	Merge pull request #21654 from Susko3/use-localisable-strings-for-dates-and-times Use `LocalisableString`s for date and time formats	2022-12-16 16:17:14 +09:00
Dean Herbert	232f590ba3	Merge pull request #21628 from peppy/go-hard-file-writes Use hard links on windows when importing beatmaps from a legacy osu! install	2022-12-16 14:52:57 +09:00
cdwcgt	a4d28aff6d	fix typo	2022-12-16 10:48:56 +09:00
cdwcgt	79e27c2d9d	`PreviewTimePart` will not show if preview time is -1	2022-12-16 10:44:07 +09:00
cdwcgt	f0246df1a9	only get;	2022-12-16 09:58:58 +09:00
Susko3	0f34d908c7	Use `LocalisableString`s for date and time formats	2022-12-16 00:05:47 +01:00
cdwcgt	c164744064	Add ability to set preview time	2022-12-16 01:03:30 +09:00
mk56-spn	0c177aa7de	Improve tests, simplify "updateDisplay" method	2022-12-15 16:12:34 +01:00
mk56-spn	9a235b3213	remove rolling duration, fix issue with loading	2022-12-15 15:21:03 +01:00
Dean Herbert	50dc76d579	Merge pull request #21618 from smoogipoo/multi-spec-only-local-results Only show local results in multi-spectator results screen	2022-12-14 14:00:02 +09:00
Dean Herbert	b8904fe747	Move `ImportParameters` to better home	2022-12-13 21:41:26 +09:00
Dean Herbert	cb16d62700	Hook up `ImportParameter` flow with `IModelImporter` caller methods	2022-12-13 21:29:32 +09:00
mk56-spn	edb46e422c	Fix "using" name in HUD overlay	2022-12-12 15:15:30 +01:00
mk56-spn	99d83315c1	change settings order	2022-12-12 15:10:45 +01:00
mk56-spn	8efe7528e3	change ruleset source to avoid issues with converted beatmaps	2022-12-12 15:10:10 +01:00
mk56-spn	4d592184ca	temp cmt	2022-12-12 11:53:07 +01:00
Dan Balasescu	7b48c91fe2	Only show local results in multi-spectator results screen	2022-12-12 18:56:43 +09:00
mk56-spn	58bf081096	Fix judgement counter not loading after first attempt in gameplay, Fix typo in Display	2022-12-12 10:52:55 +01:00
Dan Balasescu	caa0b7c290	Move score token to BeginPlaying	2022-12-12 13:59:27 +09:00
mk56-spn	f0c780f1f6	Fix tally header	2022-12-12 00:48:35 +01:00
mk56-spn	a107fca5d0	Hide "Full" option from counter flow directions	2022-12-12 00:33:28 +01:00
mk56-spn	161894da3b	Add more test checks and fix deserialisation test	2022-12-11 23:58:10 +01:00
mk56-spn	4c17b27273	Add Display, Counter, Tests	2022-12-11 23:47:17 +01:00
mk56-spn	f798951f09	Create Judgement Info struct	2022-12-11 22:09:14 +01:00
mk56-spn	ffbe68bd26	Add judgementTally to HUD overlay	2022-12-11 22:08:48 +01:00
cdwcgt	e02b8cb199	Group export methods into their respective managers	2022-12-11 18:30:24 +09:00
cdwcgt	a1fc33668c	Merge branch 'master' into export	2022-12-09 23:40:26 +09:00
Dan Balasescu	4a65f5c864	Add score token to spectator state	2022-12-09 19:09:51 +09:00
Loreos7	0aeee8d6ab	fix typo in today's tip	2022-12-07 17:47:37 +03:00
Dean Herbert	eea7984ba9	Remove triangle effect from latency certifier buttons	2022-12-07 14:53:56 +09:00
mk56-spn	fc630165fd	Adjust formatting of BPM text	2022-12-06 15:08:21 +01:00
Dan Balasescu	9ddc2f4804	Merge pull request #21523 from Feodor0090/rewind-click-fix Perform rewind with right click only if cursor didn't leave the button	2022-12-06 13:38:20 +09:00
ansel	b66409bd37	Perform rewind with right click only if cursor didn't leave the button	2022-12-05 23:38:45 +03:00
mk56-spn	f69c084969	Add roll duration	2022-12-05 17:08:00 +01:00
mk56-spn	b6a6db1160	Add dynamic BPM counter to SkinEditor	2022-12-05 12:29:23 +01:00
Andrei Zavatski	41f7dad8e9	Delete SmoothCircularProgress.cs	2022-12-03 16:40:41 +03:00
Andrei Zavatski	97b6d88f00	Remove SmoothCircularProgress usage in AccuracyCircle	2022-12-03 16:39:44 +03:00
mk56-spn	7373d79ba6	Use OsuColour instead of hex for button accent colour	2022-12-02 19:16:25 +01:00
mk56-spn	c5bad816db	Add button colouring whilst corresponding overlay is present	2022-12-02 18:44:21 +01:00
Dean Herbert	5a69656764	Merge pull request #21496 from peppy/fix-zero-length-spinners Fix being able to place zero-length spinners	2022-12-02 19:25:00 +09:00
Dan Balasescu	850931120d	Merge pull request #21479 from peppy/fix-wrong-last-hit-object-time Fix some components not accounting for final hold notes in osu!mania beatmaps	2022-12-02 18:12:00 +09:00
Dean Herbert	d1296a22ce	Update timeline blueprint's end time logic to better match new blueprint implementation	2022-12-02 17:57:15 +09:00
Dan Balasescu	a39bd634c4	Merge pull request #21405 from LumpBloom7/Editor-DrawableRuleset-Dependencies Provide DrawableRulesetDependencies from HitObjectComposer	2022-12-02 17:31:31 +09:00
Dan Balasescu	d684aa75b8	Merge pull request #21477 from peppy/fix-mania-timeline-blueprint-colour Fix osu!mania editor timeline showing bright-white blueprints	2022-12-02 16:55:29 +09:00
Dean Herbert	a2db0afe19	Avoid querying `GetLastObjectTime` twice in editor seek flow	2022-12-02 16:07:24 +09:00
Dean Herbert	8cf89fcb81	Use `Highlight1` instead of dull grey	2022-12-02 15:30:47 +09:00
mk56-spn	ea882f6874	Add disabled button dimming.	2022-12-01 22:31:14 +01:00
mk56-spn	55a21a75a4	Add hover lightening	2022-12-01 22:07:28 +01:00
mk56-spn	d7cea51551	Add functionality of Random button	2022-12-01 16:29:52 +01:00
mk56-spn	1530495e7c	Add button "accent" colour, bottom bar, icon, text	2022-12-01 15:34:09 +01:00
mk56-spn	774eb178a1	Add basic button design and footer button addition flow	2022-12-01 13:13:37 +01:00
mk56-spn	18b4317e99	Create Basic V2 footer and test	2022-12-01 11:57:50 +01:00
Dean Herbert	896f2d8f74	Fix multiple instances of last hitobject time being calculated incorrectly	2022-12-01 18:04:06 +09:00
Dean Herbert	f34a79b1a9	Set a better default colour for timeline blueprints when no colour information is available	2022-12-01 17:03:53 +09:00
Dean Herbert	bbf023cf68	Fix incorrect culture used when parsing timeline popup textbox content	2022-12-01 16:12:29 +09:00
Derrick Timmermans	5c8fce1c08	Remove extra blank line	2022-11-30 13:05:14 +01:00
Derrick Timmermans	6a61e70766	Expose Ruleset from HitObjectComposer instead	2022-11-30 12:17:58 +01:00
Dean Herbert	4215f4f5d7	Merge branch 'master' into Editor-DrawableRuleset-Dependencies	2022-11-30 17:42:46 +09:00
Dean Herbert	2a3b24d058	Avoid need for implicit null casting	2022-11-30 14:21:04 +09:00
Dean Herbert	0659c84341	Rename method to be more in line with project naming	2022-11-30 14:17:49 +09:00
Dean Herbert	63ba40ff39	Merge branch 'master' into control-point-scroll-into-view	2022-11-30 14:12:19 +09:00
Jai Sharma	7dbf379351	Don't use verbatim string literals	2022-11-29 18:22:07 +00:00
Derrick Timmermans	70c320b2e8	Provide ruleset dependencies only to Compose Placement Blueprints	2022-11-27 21:43:33 +01:00
mk56-spn	0aba119056	Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation # Conflicts: # osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs # osu.Game/Screens/Select/DifficultyRangeFilterControl.cs	2022-11-27 10:40:29 +01:00
Jai Sharma	218c04c174	Code quality	2022-11-27 03:23:08 +00:00
Jai Sharma	6000e14668	Correctly select issue row	2022-11-27 03:08:54 +00:00
Jai Sharma	3c56b9c93a	Add `OnRowSelected` event to `EditorTable`	2022-11-27 02:47:54 +00:00
Jai Sharma	792334a190	Move Control Group timing data into it's own component	2022-11-27 02:47:02 +00:00
Jai Sharma	b6d7bec240	Remove `#nullable disabled` from `EditorTable` and it's derived classes	2022-11-27 02:45:56 +00:00
Jai Sharma	1a914d0df7	Remove `#nullable disable` from `TimingScreen`	2022-11-27 02:43:22 +00:00
Bartłomiej Dach	894ef15e79	Merge branch 'master' into update-framework	2022-11-26 16:19:36 +01:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
mk56-spn	92ed2ed4ef	Refactor star "DifficultyRangeFilterControl" into generic range slider class	2022-11-26 12:19:08 +01:00
Bartłomiej Dach	73176a1315	Merge branch 'master' into triangle-button-v2	2022-11-25 18:35:59 +01:00
Bartłomiej Dach	bbbc1d0428	Darken colour of playlists create button To match `d0c4637683`.	2022-11-25 18:23:28 +01:00
Dean Herbert	d0c4637683	Lighten colour of multiplayer create game button	2022-11-25 20:18:21 +09:00
Bartłomiej Dach	fca3e7e39f	Merge branch 'master' into editor-seek-control-points	2022-11-24 21:53:47 +01:00
Dean Herbert	2b2beadd06	Merge branch 'master' into update-framework	2022-11-25 01:00:08 +09:00
Dean Herbert	6ad432b311	Use `RoundedButton` in more places	2022-11-24 16:33:01 +09:00
Dean Herbert	53b03df93d	Combine `TriangleButton` and `RoundedButton` classes	2022-11-24 16:26:57 +09:00
Dean Herbert	bea2acc60e	Remove local specifications of triangle colouring	2022-11-24 16:18:15 +09:00
Dean Herbert	37f725bfa2	Reverse directionality of up/down traversal keys to match scroll	2022-11-24 13:55:58 +09:00
Dean Herbert	b381b4fd2d	Merge branch 'master' into update-framework	2022-11-24 01:27:58 +09:00
Bartłomiej Dach	30f9cc46a7	Protect offset and bpm adjustments from null selection too	2022-11-23 17:25:43 +01:00
Dean Herbert	9b9b8a5977	Add ability to seek between control points in editor using down/up arrows Matches stable. Addresses #21376.	2022-11-23 15:59:32 +09:00
Dean Herbert	d146f86511	Fix crash when hitting 'T' to tap timing while no timing point is selected	2022-11-23 15:39:56 +09:00
Dean Herbert	de163b2bb5	Change song select to only allow volume adjusting if alt is held while scrolling	2022-11-22 19:48:55 +09:00
cdwcgt	e37d30a373	refactor based on reviews removed LegacyExportManager Separated the method of CreateZip method and the default export method	2022-11-21 18:58:01 +09:00
Dean Herbert	4a79141824	Merge pull request #21338 from RATCM/fix-leaderboard-filter Match leaderboard filter behaviour to web	2022-11-21 14:01:55 +09:00
Dean Herbert	dfa92b3de9	Merge pull request #21326 from bdach/fix-phantom-beatmap-sets Fix phantom beatmap sets appearing on carousel after delete/update	2022-11-21 13:25:14 +09:00
RATCM	f5fbb7c8de	Changed comments	2022-11-20 19:27:40 +01:00
RATCM	d20a357c0e	Fixed ordering bug	2022-11-20 19:24:51 +01:00
RATCM	9040dfbd4e	Match leaderboard filter behaviour to web	2022-11-20 17:39:46 +01:00
Bartłomiej Dach	1269afd0c5	Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu Hide scroll speed control from effects section on rulesets which don't support it	2022-11-20 16:17:55 +01:00
Bartłomiej Dach	7b274083d3	Fix phantom beatmap sets appearing on carousel after delete/update Regressed in `c40c70509e`. As it turns out, `item.Item.Filtered.Value` is not the only condition that should be checked to determine if a carousel item should be hidden or not - `item.Item.State.Value != CarouselItemState.Collapsed` should also be true. This was even available as the `item.Item.Visible` convenience property, which is used in this commit. Failing to check `item.Item.State.Value` led to setting non-zero alpha on collapsed carousel items, leading to phantom beatmap sets appearing, as the alpha was set in the entire carousel's `Update()` method, thus firing every frame.	2022-11-20 10:08:34 +01:00
Salman Ahmed	4b0ba86bd0	Identify scrolling rulesets using temporary `DrawableRuleset` instances	2022-11-20 04:12:52 +03:00
Bartłomiej Dach	c05c1625f2	Merge branch 'master' into editor-test-play-dont-retain-test-time	2022-11-19 12:09:04 +01:00
Salman Ahmed	60c424837b	Merge branch 'master' into disable-scroll-speed-on-osu	2022-11-19 12:13:45 +03:00
Salman Ahmed	2e3af97892	Remove unused using	2022-11-19 12:13:36 +03:00
Salman Ahmed	290369db47	Hide scroll speed slider on rulesets which don't support it	2022-11-19 06:42:27 +03:00
Salman Ahmed	016de2f5a0	Fix editor not always playing hitsounds with clock offsets applied	2022-11-19 05:15:22 +03:00
cdwcgt	4e457871f3	impossible null and remove storage	2022-11-19 01:03:22 +09:00
Dawid Sośnia	9ad484a0f4	Merge branch 'ppy:master' into gameplay-leaderboard-fix	2022-11-18 12:11:22 +01:00
cdwcgt	4b29941b47	add `LegacyExportManager`	2022-11-18 20:00:00 +09:00
Dean Herbert	06ce8130c2	Apply changes in line with framework NRT updates	2022-11-18 18:13:15 +09:00
Dan Balasescu	d8e99d811d	Merge pull request #21293 from frenzibyte/fix-timeline-extent-scrolling Fix timeline potentially scrolling at extents while not dragging	2022-11-18 16:19:30 +09:00
Dean Herbert	d59befc9d3	Fix initial visual state of positions before `sort` runs	2022-11-18 16:08:27 +09:00
Dean Herbert	aff218dfd5	Redirect through validity function rather than overriding `Sort`	2022-11-18 16:03:40 +09:00
Dean Herbert	20af8217f4	Tidy up bindable flow	2022-11-18 15:50:41 +09:00
Dean Herbert	e4f522aad1	Fix inspections / typos	2022-11-18 15:47:37 +09:00
Dean Herbert	d17c091d63	Move constant to a better location	2022-11-18 15:47:31 +09:00
Dean Herbert	3faa7f5f74	Merge branch 'master' into gameplay-leaderboard-fix	2022-11-18 15:44:30 +09:00
Salman Ahmed	90cd386323	Fix timeline potentially scrolling at extents while not dragging	2022-11-18 09:43:16 +03:00
Dan Balasescu	219d049edf	Merge pull request #21140 from maromalo/long-standard Standardise scores to `long` type	2022-11-18 15:26:33 +09:00
Dan Balasescu	57b8495c7a	Merge branch 'master' into long-standard	2022-11-18 14:24:04 +09:00
Dean Herbert	e4d134a820	Reduce time waited on a score submission token from 60 to 30s	2022-11-18 14:07:40 +09:00
Dean Herbert	1ff1738988	Merge pull request #21244 from nanashi-1/beatmapoptions-disabled Disable certain beatmap option buttons when there are no beatmaps selected	2022-11-18 12:55:07 +09:00
Dawid Sośnia	0dbf491872	Merge branch 'master' into gameplay-leaderboard-fix	2022-11-17 22:06:51 +01:00
Piggey	eb691266c1	cleanup	2022-11-17 21:50:39 +01:00
Dean Herbert	20d87fbed4	Eagerly dispose of triangles intro textures to avoid holding for full length of game session	2022-11-17 23:05:34 +09:00
Piggey	fa00fc5c6d	change scoresType to be a bindable	2022-11-17 13:27:56 +01:00
Piggey	dea2a6ed8d	override `sort()` function in `SoloGameplayLeaderboard`	2022-11-17 12:12:36 +01:00
nanashi-1	4773979e52	add condition	2022-11-17 16:15:34 +08:00
Dean Herbert	a4e713a61f	When returning to the editor after test play, use the original editor time rather than the point of exit	2022-11-17 12:36:24 +09:00
Dean Herbert	bfcd9e0f45	Don't seek to current editor location when location is close to (or before) the first object	2022-11-17 12:32:35 +09:00
Salman Ahmed	87b4fee10f	Remove leftover constant	2022-11-17 04:05:21 +03:00
Salman Ahmed	55beaf5d93	Revert buttons order change	2022-11-17 04:05:15 +03:00
Salman Ahmed	039ab83a46	Disable beatmap options button when none selected	2022-11-17 04:00:23 +03:00
Salman Ahmed	0e46614c57	Revert beatmap option button state changes	2022-11-17 03:57:01 +03:00
Salman Ahmed	7a28a7f2a0	Move `IGameplaySettings` override to compose screen to keep test mode unaffected	2022-11-17 01:45:16 +03:00
cdwcgt	e1a21e0cf9	create a task to export to avoid block main thread Code quality and remove some #nullable disable	2022-11-17 01:08:06 +09:00
Dean Herbert	ee6fffec5f	Fix combo colour normalisation setting not applying to editor test play	2022-11-16 17:54:49 +09:00
nanashi-1	5d8d8ffce5	fix naming	2022-11-16 10:09:51 +08:00
nanashi-1	55edd6c907	add space	2022-11-16 09:58:49 +08:00
nanashi-1	1fb8357e93	change `disabledAlpha` from `readonly` to `const`	2022-11-16 09:58:32 +08:00
nanashi-1	9101ad0cbd	fixed naming	2022-11-16 09:42:40 +08:00
nanashi-1	5973bb1956	AddButton now returns the button	2022-11-15 20:57:31 +08:00
nanashi-1	1186ed3e32	add disable	2022-11-15 20:56:18 +08:00
nanashi-1	e8d170e772	disable certain options when no beatmap is selected	2022-11-15 20:55:55 +08:00
Dean Herbert	489dca79a1	Remove upper limit for pooling	2022-11-15 12:31:25 +09:00
Dean Herbert	308ed1abd1	Fix number of judgements shown potentially exceeding upper limit	2022-11-15 12:31:25 +09:00
Dean Herbert	59a8603728	Ensure flowing animation starts correctly from zero	2022-11-15 12:04:40 +09:00
Dean Herbert	aef6ee23eb	Apply pooling support to `ColourHitErrorMeter`	2022-11-15 12:04:40 +09:00
Dean Herbert	a86b50d62a	Apply nullability to `BarHitErrorMeter`	2022-11-15 11:33:27 +09:00
Dean Herbert	576f462f59	Add pooling support to `BarHitErrorMeter`	2022-11-15 11:33:27 +09:00
maromalo	1911120afe	Merge branch 'master' into long-standard	2022-11-12 09:52:11 -03:00
Thomas Müller-Höhne	fa8e38d9d6	Target rounded fragment shader Compatibility with osu-framework change https://github.com/ppy/osu-framework/pull/5512	2022-11-12 17:18:23 +09:00
Dan Balasescu	db25e9e9c8	Merge branch 'master' into combo-colour-brightness-limit	2022-11-11 15:31:28 +09:00
Dan Balasescu	94772a9cda	Merge pull request #21147 from peppy/fix-timeline-editor-crash Fix editor hard crash when beatmap file specified out-of-range timeline zoom value	2022-11-10 22:59:55 +09:00
Dan Balasescu	606d42c679	Merge pull request #21184 from peppy/skinnable-things-cleanup Skinnable class naming pass	2022-11-10 12:52:08 +09:00
Dan Balasescu	051f7f4c68	Merge pull request #21173 from peppy/toggle-hit-markers Add the ability to toggle off hit marker displays in the editor	2022-11-10 12:23:53 +09:00
Dean Herbert	3547c04002	Merge branch 'master' into skinnable-things-cleanup	2022-11-10 12:09:32 +09:00
Piggey	0011f4e7be	fix comment lol	2022-11-09 19:59:04 +01:00
Piggey	4fbc240aa1	Merge remote-tracking branch 'origin/gameplay-leaderboard-fix' into gameplay-leaderboard-fix	2022-11-09 19:53:56 +01:00
Piggey	ab53fb17d3	change displayed text from `#?` to `-`	2022-11-09 19:53:36 +01:00
Dean Herbert	1aa0e40f2f	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
Dean Herbert	e75c3b3f94	Rename `SkinnableTarget` to `GlobalSkinLookup`	2022-11-09 17:46:43 +09:00
Dean Herbert	c908969d9b	Rename `ISkinComponent` to `ISkinLookup`	2022-11-09 17:46:43 +09:00
Dean Herbert	4457648b1c	Fix editor playing too many sounds when user performs a manual seek during playback	2022-11-09 17:42:33 +09:00
Dawid Sośnia	9549e55ef8	Merge branch 'ppy:master' into gameplay-leaderboard-fix	2022-11-08 20:04:13 +01:00
Piggey	d48c56818f	change `positionText` to display "#?" if tracked score is being 51st on the leaderboard	2022-11-08 20:02:21 +01:00
Dean Herbert	4448fcb3c8	Override combo colour brightness normalisation setting only in editor	2022-11-08 18:29:10 +09:00
Dean Herbert	ada039151b	Add the ability to toggle off hit marker displays in the editor	2022-11-08 18:07:06 +09:00
Dean Herbert	9650ae1329	Limit editor background dim to 75% maximum	2022-11-08 17:20:37 +09:00
Dean Herbert	349d262c18	Remove commented unbind	2022-11-08 17:19:48 +09:00
Dean Herbert	b166e477c2	Merge branch 'master' into editor-background	2022-11-08 17:18:34 +09:00
Salman Ahmed	1465d043f4	Merge branch 'master' into song-select-transition-improvement	2022-11-08 03:36:19 +03:00
Dean Herbert	f6d93fcd5a	Fix editor hard crash when beatmap file specified out-of-range timeline zoom value	2022-11-07 12:54:02 +09:00
Dean Herbert	391840404d	Play exiting transition in both directions	2022-11-07 11:59:43 +09:00
maromalo	8eef2ba8de	quality shenanigans	2022-11-06 20:12:26 -03:00
maromalo	b7ef9b176d	Make score type consistent	2022-11-06 19:59:27 -03:00
Bartłomiej Dach	84179fb087	Merge branch 'master' into combo-colour-brightness-limit	2022-11-05 16:48:56 +01:00
Dean Herbert	4f14ae4e34	Adjust transition effect for main menu backgrounds	2022-11-04 17:45:14 +09:00
Dean Herbert	2b934e0bea	Increase delay for changing background on returning to main menu	2022-11-04 17:45:13 +09:00
Dean Herbert	c40c70509e	Improve song select transition to gameplay	2022-11-04 15:24:37 +09:00
Dean Herbert	486515ed90	Merge pull request #20758 from frenzibyte/maintain-common-mod-selection Maintain selection of common mods when switching rulesets	2022-11-03 20:08:32 +09:00
Dean Herbert	e336d486a6	Merge pull request #21093 from peppy/auto-skip-multiple-times Fix automated skip not skipping more than once when required	2022-11-03 15:46:56 +09:00
Dean Herbert	20dd405c2b	Merge branch 'master' into maintain-common-mod-selection	2022-11-03 15:32:40 +09:00
Dan Balasescu	fc191807c6	Fix velocity test failing with no audio device	2022-11-03 13:59:22 +09:00
Dean Herbert	4154be6cda	Adjust auto-skip to skip multiple times if necessary	2022-11-03 13:52:29 +09:00
Dean Herbert	aef3c7918c	Add total skip count to `SkipOverlay`	2022-11-03 13:52:24 +09:00
Dean Herbert	3ec9686e58	Fix test failures and rename configuration value to match better	2022-11-02 18:15:18 +09:00
Dean Herbert	0e502de8b4	Rename field to match usage	2022-11-02 18:04:42 +09:00
Dean Herbert	c3eb0c6330	Merge branch 'master' into editor-background	2022-11-02 17:43:38 +09:00
cdwcgt	9884618290	rename `editorDim` to `editorBackgroundDim`	2022-11-02 15:12:15 +09:00
cdwcgt	d6b8439121	add xmldoc for DimAmount	2022-11-02 15:11:49 +09:00
Dean Herbert	37300ba9e2	Standardise "Visual Settings" components to fix mismatched paddings and labels	2022-11-02 14:01:57 +09:00
Dean Herbert	50b6fe4acb	Localise new label	2022-11-02 14:01:03 +09:00
Dean Herbert	61fc3c8cc0	Add setting to visual settings toolbox	2022-11-02 13:58:34 +09:00
Dean Herbert	d8aa06ea92	Standardise "Visual Settings" components to fix mismatched paddings and labels	2022-11-02 13:55:56 +09:00
Dean Herbert	2a88409dfe	Fix time snap of sliders not matching when SV is not 1.0x This regressed with https://github.com/ppy/osu/pull/20850 because the function was used in other places which expect it to factor slider velocity into the equation. Rather than reverting, I've added a new argument, as based on the method naming alone it was hard to discern whether SV should actually be considered. The reason for the change in #20850 was to avoid the SV coming in from a reference object which may not have a correct SV in the first place. In such cases, passing `false` to the function will give the expected behaviour.	2022-11-01 15:12:58 +09:00
Dean Herbert	9ea2bd84bd	Merge pull request #21018 from andy840119/reuse-the-function-in-timeline-class Reuse function in the timeline class	2022-10-30 23:49:02 +09:00
Dean Herbert	1035b5fb19	Fix hold to pause button not working when HUD is hidden	2022-10-30 21:38:45 +09:00
andy840119	a753369d3e	Reuse function `TimeAtPosition()` and `PositionAtTime()`.	2022-10-30 17:21:50 +08:00
D.Headley	21d68bfb84	Delete unused button	2022-10-28 16:40:21 +02:00
Joseph Madamba	87328dd1f5	Fix bar hit error meter labels not clearing when setting to none	2022-10-27 23:59:01 -07:00
Dan Balasescu	51d8392e7f	Merge pull request #20982 from peppy/remove-obsoleted-simple Clean up various obsoleted code	2022-10-28 14:36:04 +09:00
Dean Herbert	42eafe318c	Remove various simple obsoletions	2022-10-28 13:20:58 +09:00
Dean Herbert	71970d83cf	Remove obsoleted `ShowProgressGraph` global setting This was moved to the component itself.	2022-10-28 12:47:45 +09:00
Joseph Madamba	0efbae6e70	Fix osu! logo drag area being a square	2022-10-26 18:33:07 -07:00
cdwcgt	6991195d69	let editor dim different from gameplay dim	2022-10-26 15:22:57 +09:00
Dean Herbert	2016d33055	Offset start of distance snap grid drawing if reference object's start time doesn't align Closes #20938.	2022-10-26 13:11:26 +09:00
Dean Herbert	7249542167	Merge pull request #20912 from LittleEndu/carousel-do-not-select-random Make beatmap carousel select nearest to selection when selection was filtered	2022-10-26 11:40:56 +09:00
Dean Herbert	d9d083752a	Clamp backwards index to total current items to fix edge case of item removal	2022-10-26 11:03:11 +09:00
Bartłomiej Dach	f5ca447b8e	Rename one more "{duplicate -> clone}" reference	2022-10-25 21:34:41 +02:00
Bartłomiej Dach	bcdf24b972	Merge branch 'master' into add-editor-object-clone	2022-10-25 21:33:52 +02:00
Dean Herbert	cf3bf41b49	Harden and simplify logic to avoid weird issues	2022-10-25 18:57:15 +09:00
Dean Herbert	22ea9a8ab4	Add early return of carousel group has no items	2022-10-25 13:34:22 +09:00
cdwcgt	f9c6190426	Add DimAmount for UserDimContainer	2022-10-25 13:00:53 +09:00
Dean Herbert	2456a18bc1	Rewrite implementation to avoid duplicated LINQ returns	2022-10-25 12:48:17 +09:00
Dean Herbert	4d4f6e25ba	Rename to "clone" instead of "duplicate"	2022-10-25 11:43:23 +09:00
Dean Herbert	1e579e06f8	Fix duplicate working incorrectly if there is no selection currently made	2022-10-25 11:42:12 +09:00
Endrik Tombak	5a118cfdc3	Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection Conflicts: osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs	2022-10-24 21:40:48 +03:00
cdwcgt	a2682b3ce3	background dim settings for editor View -> Background Dim follow `DimLevel` and `BlurLevel` Co-Authored-By: Dead_Bush_Sanpai <DeadBushSanpai@yandex.com>	2022-10-24 23:55:33 +09:00
cdwcgt	de881cc5cb	useless #nullable disable	2022-10-24 23:17:28 +09:00
Dean Herbert	1d5df15027	Add ability to use `Shift`+`Number` to set current beat divisor in editor	2022-10-24 15:20:15 +09:00
Dean Herbert	e72a71a28e	Add simple editor "duplicate objects" key binding	2022-10-24 14:01:34 +09:00
Dean Herbert	849b50a38f	Use `ToUpperInvariant` for added safety Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-10-21 00:16:33 +09:00
Dean Herbert	6b26547d03	Merge pull request #20835 from frenzibyte/improve-hide-mouse-on-keyboard Improve automatic cursor hiding logic and limit to gameplay screen	2022-10-20 11:44:20 +09:00
Dean Herbert	2f8a4fd2d0	Merge branch 'master' into remove-current-item	2022-10-20 10:02:09 +09:00
Dean Herbert	77b25c4a5c	Merge pull request #20788 from frenzibyte/handle-submitting-player-request-timeout Fix potential exception in `SubmittingPlayer` token retrieval on request timeout	2022-10-20 09:51:57 +09:00
Salman Ahmed	4bf4938b72	Keep cursor hiding feature to gameplay screens for now	2022-10-20 03:44:58 +03:00
Dean Herbert	372a655be1	Ensure placement uses currently selected bank	2022-10-19 21:39:51 +09:00
Dean Herbert	50e24ddd87	Add icon and radio button logic	2022-10-19 21:35:08 +09:00
Dean Herbert	9222cb379f	Add sample bank suport to editor selection handler	2022-10-19 20:53:18 +09:00
Dean Herbert	fbad33bef7	Adjust durations and make start off screen	2022-10-18 15:01:53 +09:00
Dean Herbert	84688b53a1	Merge branch 'fix-editor-padding' into player-loader-improvements	2022-10-18 14:52:59 +09:00
Dean Herbert	6a7f6c76ff	Fix osu! editor padding being applied to toolboxes The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.	2022-10-18 14:32:00 +09:00
Dean Herbert	0f809dcaa7	Merge branch 'master' into player-loader-improvements	2022-10-18 14:22:55 +09:00
Dean Herbert	516320edd9	Merge branch 'master' into handle-submitting-player-request-timeout	2022-10-17 18:51:13 +09:00
Dan Balasescu	4220d6b3fc	Merge pull request #20780 from outfoxxed/fix-hiterror-icons Fix hit error bar icon orientation	2022-10-17 18:48:31 +09:00
Dean Herbert	1e7b8cd227	Fix formatting issues	2022-10-17 13:22:06 +09:00
Salman Ahmed	ae05f374a2	Fix potential invalid operation exception in `SubmittingPlayer` token retrieval	2022-10-17 03:26:29 +03:00
outfoxxed	85de802793	Only create hit error bar icon containers once Move icon container creation to BDL, and only recreate the contained icon when `recreateLabels` is called	2022-10-16 11:47:21 -07:00
outfoxxed	d6030891a2	Reuse existing code in hit error bar fix Use `UprightAspectMaintainingContainer` instead of a local fix for hit error bar orientation	2022-10-16 10:06:38 -07:00
outfoxxed	cd1885a17b	Fix hit error bar icon orientation Icons now keep their original orientation when the hit error bar is flipped	2022-10-16 02:55:10 -07:00
Salman Ahmed	324c749383	Merge branch 'master' into player-loader-improvements	2022-10-15 03:07:15 +03:00
Salman Ahmed	ba72f13f54	Merge branch 'master' into hide-mouse-on-keyboard-input	2022-10-14 22:26:30 +03:00
Dan Balasescu	10aabfc650	Merge pull request #20739 from peppy/settings-toolbox Adjust visuals of settings toolboxes (gameplay loading screen and editor)	2022-10-14 20:31:05 +09:00
Dan Balasescu	dcb6357964	Add ability to remove the current item in multiplayer	2022-10-14 20:23:55 +09:00
Dan Balasescu	525f98c158	Fix max combo missing from playlists results screen	2022-10-14 18:01:54 +09:00
Salman Ahmed	01c65d3cc1	Remove seemingly unnecessary/leftover code	2022-10-14 02:16:36 +03:00
Dean Herbert	3645269108	Improve logo transition and reduce delay of exiting player loader in optimal conditions	2022-10-13 17:29:47 +09:00
Dean Herbert	b33935e392	Fix player loading screen settings scaling in This always looked weird, and from the looks of the structure was probably unintentional from the start (it is in the logo tracking container for whatever reason).	2022-10-13 17:12:36 +09:00
Dean Herbert	15f9697c9f	Roughly update design of editor buttons	2022-10-13 16:57:25 +09:00
Dean Herbert	0f4a2a6059	Improve feel of settings toolbox group	2022-10-13 16:36:19 +09:00
Dean Herbert	c3902728f6	Reorganise beatmap snap control to work better in compact mode	2022-10-13 15:47:54 +09:00
Dean Herbert	a525b3f9f8	Reorder and rename toggle checkboxes to fit better	2022-10-13 15:44:33 +09:00
Dean Herbert	f6f5d33f53	Add slight padding to playfield (roughly matches stable)	2022-10-13 15:44:23 +09:00
Dean Herbert	ebc1088457	Merge pull request #20729 from frenzibyte/update-local-confirmation-dialog Request user confirmation on updating locally-modified beatmaps	2022-10-13 12:36:37 +09:00
Dean Herbert	c9b4cacc20	Merge pull request #20724 from mk56-spn/Highest_Combo_Counter Add "longest combo" counter to HUD components.	2022-10-13 12:26:49 +09:00
Salman Ahmed	964ed01abb	Add confirmation dialog for updating locally modified beatmaps	2022-10-13 02:40:15 +03:00
Dean Herbert	19f3810020	Revert namespace change Let's not	2022-10-12 18:50:47 +09:00
Dan Balasescu	9473c350b5	Merge pull request #20266 from cdwcgt/catch-combo-hide Fade out CatchComboDisplay when hide HUD	2022-10-12 16:59:07 +09:00
Dario Headley	b72c8970eb	Max Combo Counter added	2022-10-12 09:50:01 +02:00
Dan Balasescu	300888b423	Merge pull request #20720 from peppy/fix-welcome-intro-delay Fix incorrect delay for non-theme music on "welcome" intro	2022-10-12 16:15:54 +09:00
Dean Herbert	d2d589a156	Expose HUD state via `Player`	2022-10-12 15:11:52 +09:00
Dean Herbert	1d6d047a69	Merge branch 'master' into master	2022-10-12 14:52:07 +09:00
Dean Herbert	d6998c810c	Fix incorrect delay for non-theme music on "welcome" intro	2022-10-12 14:51:14 +09:00
Dean Herbert	db148d145b	Fix incorrect offset logic for beatmaps without a preview point specified	2022-10-12 14:47:37 +09:00
Dean Herbert	ab24e87013	Merge branch 'master' into improve-drag-selection	2022-10-12 13:20:17 +09:00
Dean Herbert	a5948e7680	Merge pull request #20704 from ekrctb/scrolling-drag-box Anchor editor drag box on time (catch, mania)	2022-10-12 11:48:05 +09:00
ekrctb	fcb9e2cc00	Refactor blueprint container drag code	2022-10-11 22:39:53 +09:00
Salman Ahmed	9b45a9cf76	Rename various cursor symbols - `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor` - `MenuCursor` -> `MenuCursorContainer	2022-10-11 16:21:01 +03:00
Dan Balasescu	cc0ca470f1	Merge pull request #20702 from peppy/update-prefer-no-video Fix beatmap update button not respecting user "prefer no video" setting	2022-10-11 19:36:14 +09:00
Dan Balasescu	88e82d3154	Merge pull request #20681 from peppy/fix-hidden-hud-interaction Fix HUD components being interactive even when the HUD is visually hidden	2022-10-11 17:19:27 +09:00
NotGumballer91	d18466d740	Fix delay inconsistency in IntroCircles.cs	2022-10-11 16:16:57 +08:00
NotGumballer91	5baad52a9e	Fix unintended delay on osu!theme	2022-10-11 16:15:56 +08:00
Dean Herbert	f41b79688f	Avoid casting by accepting all `Playfield`s but throwing on a bad choice	2022-10-11 16:54:41 +09:00
Dean Herbert	a44ba579c5	Fix beatmap update button not respecting user "prefer no video" setting Closes #20701.	2022-10-11 14:27:40 +09:00
ekrctb	6ab29a62d0	Anchor drag box on time (catch, mania) Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.	2022-10-11 14:23:17 +09:00
ekrctb	1a24762f9b	Improve drag box selection logic `AllowDeselectionDuringDrag` is remove. Instead, selected hit objects are not automatically deselected when clock is seeked to a later time (the hit object is dead). Update drag box selection even if mouse is not moved (in case clock is running or scroll wheel is used).	2022-10-11 14:11:45 +09:00
Dean Herbert	cb21126623	Merge pull request #20586 from ekrctb/time-based-selection Use hit object time for timeline drag selection instead of relying on blueprint	2022-10-11 13:20:15 +09:00
NotGumballer91	ef840e98cf	Update IntroCircles.cs	2022-10-11 01:49:53 +08:00
NotGumballer91	8a4f2efa14	Update IntroScreen.cs	2022-10-11 01:49:49 +08:00
NotGumballer91	9a3689b6e9	Update IntroCircles.cs	2022-10-10 21:04:14 +08:00
Dean Herbert	20adc522b9	Fix HUD components being interactive even when the HUD is visually hidden	2022-10-10 16:05:41 +09:00
Dan Balasescu	c18d4afdcc	Merge branch 'master' into fix-leaderboard-first-place-fade	2022-10-07 19:55:16 +09:00
Dan Balasescu	57e4d6cc4a	Merge pull request #20562 from peppy/fix-score-submission-crash Fix potential crash when score submission token retrival fails	2022-10-07 19:24:35 +09:00
ekrctb	6164e0896a	Don't reselect already selected items in SelectAll	2022-10-07 10:46:07 +09:00
ekrctb	29cc554632	Ensure blueprint is added for selected hit object	2022-10-06 13:59:54 +09:00
ekrctb	0d448e6cc8	Fix items without blueprints are not deselected	2022-10-06 13:50:56 +09:00
ekrctb	b0213c29e9	Use mid time instead of start time It is closer to the old blueprint-based behavior	2022-10-05 22:19:22 +09:00
ekrctb	6753f6b01a	Move `AllowDeselectionDuringDrag` down Because it is now ignored in the timeline implementation anyways	2022-10-05 22:14:11 +09:00
ekrctb	3108c42ece	Fix inspect issues	2022-10-05 22:04:43 +09:00
ekrctb	00b3d97f69	Improve timeline selection performance But selecting a large number of hit objects is still very slow because all DHOs must be added and also `AddBlueprintFor` has quadratic behaviors	2022-10-05 21:58:05 +09:00
ekrctb	0613388aaa	Make sure all selected items get deleted	2022-10-05 21:58:05 +09:00
ekrctb	0ffde02f79	Use hit object time for timeline selection	2022-10-05 21:51:01 +09:00
ekrctb	8d29e9e76b	Move selection logic from DragBox to BlueprintContainer	2022-10-05 21:51:01 +09:00
Dean Herbert	276021dd85	Remove now unnecessary `ScheduleAfterChildren`	2022-10-05 14:20:01 +09:00
Dean Herbert	c7d645b086	Merge branch 'master' into fix-gameplay-leaderboard-overlap	2022-10-05 14:15:50 +09:00
Dean Herbert	75b9bf2cf9	Merge branch 'master' into intel-exclusive-warning	2022-10-04 19:02:01 +09:00
Dean Herbert	d9f678d942	Change song select random key binding to not handle key repeat	2022-10-03 18:16:54 +09:00
Dean Herbert	42aac16b37	Adjust leaderboard score panels sizing based on accuracy/combo width	2022-10-03 18:12:36 +09:00
Dean Herbert	65369e96eb	Ensure token retrieval failure logic only runs once	2022-10-03 17:29:46 +09:00
Dean Herbert	c4dd23ed15	Log token retrieval failures even when gameplay is allowed to continue	2022-10-03 17:29:34 +09:00
Dean Herbert	4dbac917fc	Merge pull request #20547 from nanashi-1/solo-gameplay-leaderboard-max-combo Display highest combo rather than current combo for local play on leaderboard	2022-10-03 16:57:05 +09:00
Salman Ahmed	a810afafb3	Reschedule results display delegate to avoid potential softlocks in the future	2022-10-02 15:37:56 +03:00
Salman Ahmed	59728b0ccb	Fix results display delegate potentially cancelled while not exiting	2022-10-02 15:30:06 +03:00
nanashi-1	2493468800	display highest combo instead of current combo	2022-10-02 18:40:31 +08:00
Dean Herbert	cbbca616c1	Merge branch 'master' into fix-leaderboard-first-place-fade	2022-09-28 17:58:45 +09:00
Dean Herbert	9b3778f226	Merge pull request #20507 from smoogipoo/fix-multiplayer-tests Fix failing multiplayer tests	2022-09-28 17:41:55 +09:00
Dan Balasescu	715b1f64f3	Merge pull request #20518 from peppy/fix-leaderboard-wobble Fix leaderboard wobble when in first place	2022-09-28 17:03:31 +09:00
Dean Herbert	cdcc8494c9	Fix fade being applied for too long when leaderboard scrolls to start	2022-09-28 16:10:19 +09:00
Dean Herbert	c8643ed265	Set `ClampExtension` to zero to stop jittering	2022-09-28 15:58:00 +09:00
Dean Herbert	8edb1cb98a	Add test coverage of current score staying on screen	2022-09-28 15:57:50 +09:00
Dan Balasescu	a0d05f5bb7	Merge pull request #20501 from peppy/fix-editor-initial-performance Fix editor performance being sub-par on beatmap load	2022-09-27 21:34:04 +09:00
Dan Balasescu	da8d94c4b4	Fix test failures due to scheduled operations	2022-09-27 20:24:44 +09:00
Dean Herbert	58217b6839	Fix weird conditional	2022-09-27 20:09:21 +09:00
Dan Balasescu	8642ed7631	Merge pull request #20504 from peppy/fix-playlist-connectivity-crash Fix potential crash when losing network connectivity in multiplayer/playlists screens	2022-09-27 18:36:24 +09:00
Dean Herbert	3ece7205ed	Fix potential crash when losing network connectivity at online play screen Addresses #20448.	2022-09-27 17:52:34 +09:00
Dean Herbert	0296685c74	Start key counter / gameplay leaderboard hidden to avoid initial fade out	2022-09-27 17:25:24 +09:00
Dean Herbert	a9088d9231	Add assert/log output when too many ticks are being displayed	2022-09-27 17:18:46 +09:00
Dean Herbert	e227519b09	Don't attempt to render timeline ticks until `DrawWidth` is above zero	2022-09-27 17:18:46 +09:00
Dean Herbert	ccae721af2	Ensure `ZoomableScrollContainer` content isn't shown until zoom is set	2022-09-27 17:07:11 +09:00
Dean Herbert	9dc0eb7fd0	Remove unused static	2022-09-27 17:04:56 +09:00
Dean Herbert	320f134634	Use same logic as `KeyCounterDisplay`	2022-09-27 15:01:18 +09:00
nanashi-1	5d18001d75	move config	2022-09-26 21:11:38 +08:00
nanashi-1	4295d9c169	revert	2022-09-26 21:11:14 +08:00
nanashi-1	ee4d1b2d58	add config visibility	2022-09-26 20:13:07 +08:00
Dan Balasescu	c969afcb71	Merge branch 'master' into leaderboard-nrt	2022-09-26 17:12:19 +09:00
Dan Balasescu	28470bd5c0	Merge pull request #20486 from peppy/gameplay-leaderboard-nrt Apply NRT to `GameplayLeaderboard` hierarchy	2022-09-26 17:11:51 +09:00
Dan Balasescu	426ab176d6	Merge pull request #20418 from peppy/fix-leaderboard-crash Fix intermittent leaderboard crash due to request finishing after drawable is disposed	2022-09-26 17:10:32 +09:00
Dean Herbert	20da1051d9	Apply NRT to `GameplayLeaderboard` hierarchy Just some cleanup work that I wanted to do as part of my last changes.	2022-09-26 16:21:24 +09:00
Dean Herbert	5fc836d1f0	Apply NRT to `BeatmapLeaderboard` / `MatchLeaderboard`	2022-09-26 16:17:28 +09:00
Dean Herbert	32d56fe3a9	Use request cancellation and `IsDisposed` guard instead of more `Schedule`	2022-09-26 16:02:33 +09:00
o-dasher	feadac1f79	Cleanup all other leftover binding instantiation	2022-09-25 16:02:40 -04:00
Dean Herbert	0fa5e1b28e	Fix intermittent leaderboard crash due to request finishing after drawable is disposed	2022-09-23 20:18:44 +09:00
Dean Herbert	a65a76f7de	Fix off-thread drawable mutation in multiplayer settings overlay when an error occurs Closes #20413.	2022-09-23 20:05:32 +09:00
Dan Balasescu	1d1012e196	Merge pull request #20286 from peppy/gameplay-leaderboards Add basic gameplay leaderboard display	2022-09-22 21:16:12 +09:00
Dan Balasescu	6a0047b7a2	Update location of FullscreenCapability bindable	2022-09-22 21:01:23 +09:00
Dan Balasescu	445e026a32	Merge pull request #20389 from peppy/fix-gameplay-leaderboard-layout Fix gameplay leaderboard sometimes not showing up	2022-09-22 20:51:54 +09:00
Dean Herbert	8f7a306d81	Inline comment regarding margin necessity	2022-09-22 19:53:16 +09:00
Dean Herbert	f0dcda9acc	Decrease precision of spacing setting	2022-09-22 15:49:02 +09:00
Dean Herbert	26d98323ff	Fix bindable flow, code quality, everything	2022-09-22 15:45:23 +09:00
Dean Herbert	0f663deda0	Fix changing shape causing alpha to be permanently reset to zero	2022-09-22 15:24:57 +09:00
Dean Herbert	ae70b2c32f	Fix other weirdness in variable and description naming	2022-09-22 15:21:27 +09:00
Dean Herbert	19db7c5977	Remove "Opacity" setting This should be implemented at a higher level	2022-09-22 15:19:01 +09:00
Dean Herbert	f3898da37a	Rename judgement count to not mention "shape"	2022-09-22 15:18:20 +09:00
Dean Herbert	7d93fa9f65	Merge branch 'master' into Colour_hit_meter_improved	2022-09-22 15:11:58 +09:00
Dean Herbert	5b73f24864	Fix outdated scores being held by `BeatmapLeaderboard` after external beatmap switch	2022-09-21 15:21:32 +09:00
Dean Herbert	29c4d06d36	Merge branch 'fix-gameplay-leaderboard-layout' into gameplay-leaderboards	2022-09-21 14:58:58 +09:00
Dean Herbert	b04871f40a	Animate scroll for a better visual experience	2022-09-21 14:51:12 +09:00
Dean Herbert	087ca59ebb	Add extra margin space to flow equal to height of leaderboard This ensures the content is always on screen, but also accounts for the fact that scroll operations without animation were actually forcing the local score to a location it can't usually reside at. Basically, the local score was in the scroll extension region (due to always trying to scroll the local player to the middle of the display, but there being no other content below the local player to scroll up by).	2022-09-21 14:51:12 +09:00
Dean Herbert	4385001d28	Fix solo leaderboard seeing imported score via realm subscription flow	2022-09-21 13:59:11 +09:00
Dean Herbert	a8338c4efd	Add local score after existing scores to avoid initial re-sort	2022-09-21 13:38:40 +09:00
Dean Herbert	4492a26b59	Merge branch 'master' into argon-skin	2022-09-21 13:00:16 +09:00
Dan Balasescu	8bf196d561	Merge pull request #20354 from peppy/default-skin-refactor Rename default skin to make way for new version	2022-09-21 11:48:38 +09:00
Dan Balasescu	7f15dc6e6c	Merge pull request #20321 from HiddenNode/fix_graph_info_overlap Fix Progress bar info text overlapping with progress graph	2022-09-20 19:30:51 +09:00
Dan Balasescu	80d8eedb7c	Merge pull request #20366 from peppy/fix-nullable-download-progress Fix multiplayer crashes due to incorrect download state	2022-09-20 17:16:11 +09:00
Dean Herbert	68c040175a	Ensure `Leaderboard.Scores` is updated immediately via request flow	2022-09-20 17:02:57 +09:00
Dean Herbert	b5771ece41	Reduce the amount by which clicking the mute notification incraeses volume	2022-09-20 13:00:08 +09:00
Dean Herbert	a9c120c214	Reduce volume requirement for showing muted notification to 1%	2022-09-20 12:46:35 +09:00
Dean Herbert	1c02fa8399	Update comment to not mention horizontal plane	2022-09-20 00:08:06 +09:00
Dean Herbert	46db3ad96d	Move implementation to individual classes	2022-09-20 00:06:02 +09:00
Dean Herbert	0f7b38f4c3	Add new default skin "argon"	2022-09-19 23:16:46 +09:00
Dean Herbert	0ac28cbecc	Fix potential crash from missing `DownloadProgress`	2022-09-18 23:42:16 +09:00
Dean Herbert	1914c41d0d	Merge pull request #20353 from Drison64/fix-timelineZoom-zero EditorBeatmap's TimelineZoom should never be zero	2022-09-18 18:06:26 +09:00
Dan Balasescu	2dcaf7cfd8	Fix memory leak due to missing event unbind	2022-09-18 14:25:31 +09:00
Ryuki	ecf71df8a2	Change CornerRadius Max Value	2022-09-18 00:04:56 +02:00
Drison64	c075d3de08	Create a test and a check if initial zoom value of ZoomableScrollContainer is in range	2022-09-17 22:43:40 +02:00
Ryuki	c1077d909c	Basic avatar HUD implementation	2022-09-17 21:09:34 +02:00
Ondřej Vajďák	9d94343317	Update osu.Game/Screens/Edit/Compose/Components/Timeline/Timeline.cs Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-09-17 19:51:44 +02:00
Drison64	c8768eb399	Changed == to <= on TimelineZoom check	2022-09-17 19:00:50 +02:00
Drison64	3c7ea5c8fa	Update	2022-09-17 18:57:09 +02:00
Dean Herbert	41e69fbca6	Remove "default" prefix from naming	2022-09-18 00:15:26 +09:00
Dean Herbert	51841988bf	Rename references to `DefaultSkin` to have `Triangles` suffix	2022-09-17 23:57:25 +09:00
HiddenNode	2dfa89c62e	Clean up	2022-09-17 15:05:25 +01:00
Drison64	0b6a77bc8b	EditorBeatmap's TimelineZoom should never be zero	2022-09-17 15:59:42 +02:00
HiddenNode	d580b07063	Refactor update condition logic	2022-09-17 14:40:36 +01:00
HiddenNode	e3d5ba5301	Check if graph DrawSize changed	2022-09-17 11:44:25 +01:00
HiddenNode	0d76f4501d	Revert "Set InvalidationSource to Self" This reverts commit `2092008251`.	2022-09-17 10:10:20 +01:00
Dean Herbert	4c4fdfd153	Provide scores directly to `Player` instance rather than relying on DI	2022-09-16 18:15:17 +09:00
Dean Herbert	0227eddda1	Merge branch 'master' into gameplay-leaderboards	2022-09-16 15:44:58 +09:00
Dan Balasescu	d9499abc33	Refactor to avoid passing around bindables	2022-09-16 13:14:25 +09:00
Drison64	4f208416be	Fixed irresponsiveness of score panel timestamp to time format	2022-09-16 13:50:18 +14:00
HiddenNode	2092008251	Set InvalidationSource to Self	2022-09-15 11:16:00 +01:00
HiddenNode	8286ab0d04	Revert "Fix `SongProgress` invalidating too often" This reverts commit `2b4b14ca99`.	2022-09-15 11:11:58 +01:00
Dean Herbert	40a60f7145	Remove all entity framework code and migrations	2022-09-15 16:58:58 +09:00
Dean Herbert	eb18d3661d	Merge pull request #20309 from mk56-spn/dead_class_removal Unused class KeyCounterState.cs Removal	2022-09-15 03:38:39 +09:00
Mk-56spn	d6db82283a	Removes unused class	2022-09-14 18:01:29 +02:00
Dean Herbert	fcf54f1bc8	Fix gameplay leaderboard not being sorted correctly in tie situations	2022-09-14 14:18:12 +09:00
Dean Herbert	8a6977213a	Fix displayed scores in gameplay leaderboard not tracking display mode changes	2022-09-14 14:02:35 +09:00
Dean Herbert	b4e6a20846	Fix song select status prefix matching no longer working Regressed in #19275 due to weird logic. Closes #20289.	2022-09-14 12:59:05 +09:00
Dean Herbert	81b5e4a865	Fix back-to-front condition on leaderboard always show configuration	2022-09-13 19:57:40 +09:00
Dean Herbert	94693a4667	Fix oversight when making interface implementation explicit	2022-09-13 19:55:57 +09:00
Dean Herbert	e15a25ea49	Fix leaderboard positioning logic to actually consider elements on the left side	2022-09-13 18:45:11 +09:00
Dean Herbert	678eec1c67	Move `LeaderboardFlow` to `HUDOverlay` to share positioning logic	2022-09-13 18:45:11 +09:00
Dean Herbert	5894d2f0bc	Ensure gameplay leaderboard hides with rest of HUD when it should	2022-09-13 18:45:11 +09:00
Dean Herbert	6d167070f8	Add back DI leaderboard retrieval via bindable pathway	2022-09-13 18:45:11 +09:00
Dean Herbert	70e6b595f1	Refactor `SoloGameplayLeaderboard` to not read scores via DI Also allows updating scores if they arrive late.	2022-09-13 18:00:21 +09:00
Dean Herbert	d2b80645ab	Change `Leaderboard` to use `IUser` instead of `APIUser`	2022-09-13 18:00:21 +09:00
Dean Herbert	d251c0b2ac	Move leaderboard implementation to `Player` itself	2022-09-13 18:00:21 +09:00
Dean Herbert	368faa0084	Make constructor `protected` in base implementation	2022-09-13 18:00:21 +09:00
Dean Herbert	4c669e2bce	Track local `Player.Score`'s user rather than using `APIProvider`	2022-09-13 18:00:21 +09:00
Salman Ahmed	3490b16056	Add simplified `SoloGameplayLeaderboard` implementation Note that this doesn't support waiting until leaderboard finishes fetching scores.	2022-09-13 18:00:21 +09:00
Dean Herbert	27a81dfb9f	Merge pull request #20270 from OliBomby/fix-selectionblueprint-order Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes	2022-09-13 17:18:58 +09:00
Dan Balasescu	0e2155303e	Merge branch 'master' into fix-song-progress-invalidations	2022-09-13 16:07:05 +09:00
Dean Herbert	f53507828c	Rename event to be more generic (and add comprehensive xmldoc)	2022-09-13 14:59:30 +09:00
Dean Herbert	ac034bffeb	Fix potential crash if multiplayer spectator load is aborted early	2022-09-13 14:21:54 +09:00
OliBomby	fd48249eef	fix with new event	2022-09-13 02:20:52 +02:00
OliBomby	718f8c4ee2	revert the fix	2022-09-13 01:09:42 +02:00
OliBomby	8400de4b2e	invoking hitobject updated before invoking removed	2022-09-12 17:50:11 +02:00
Dean Herbert	2b4b14ca99	Fix `SongProgress` invalidating too often This regressed with https://github.com/ppy/osu/pull/19556. Rather than try and figure whether that new container needs to handle size differently, this is a simple solution. Height was taken from a runtime check (maxes out at about 14.5). Closes #20235.	2022-09-12 20:06:53 +09:00
Dean Herbert	cb6d02ec3a	Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset Remove the nullable disable annotation in the ruleset class	2022-09-12 19:07:23 +09:00
Dan Balasescu	4b37330316	Merge pull request #20248 from acid-chicken/fix/stats/td Fix new hit distribution graph didn't account for size changes	2022-09-12 18:11:18 +09:00
Dan Balasescu	3cfacb5e39	Merge pull request #20257 from peppy/update-button-show-login Show login overlay when attempting to update a beatmap while logged out	2022-09-12 17:51:45 +09:00
Acid Chicken (硫酸鶏)	4f298db066	fix(osu.Game): reset Y axis of the bars in hit distribution graph at the first drawing	2022-09-12 16:25:29 +09:00
Acid Chicken (硫酸鶏)	0d0e2e7bcc	fix(osu.Game): bars in hit distribution graph stretching in the opposite direction when `DrawHeight` is less than `DrawWidth`	2022-09-12 16:20:33 +09:00
Dan Balasescu	31225066a1	Merge pull request #19308 from frenzibyte/top-rank-badge-order Fix best rank badge not handling legacy scores properly	2022-09-12 16:20:21 +09:00
Dean Herbert	94f8197e22	Show login overlay when attempting to update a beatmap while logged out	2022-09-12 16:15:14 +09:00
Dean Herbert	96951057df	Avoid using bindables	2022-09-12 15:56:06 +09:00
Dean Herbert	bcd2445d9b	Move helper functions down in file	2022-09-12 15:50:10 +09:00
Dean Herbert	0755289ec3	Apply NRT to `HitEventTimingDistributionGraph`	2022-09-12 15:48:50 +09:00
Acid Chicken (硫酸鶏)	ac324c63e2	fix(osu.Game): handle size changes in timing distribution graph	2022-09-12 04:46:32 +09:00
Mk-56spn	c00bf61273	Framework change adressed	2022-09-10 21:24:29 +02:00
MK56	8661dc3c93	Merge branch 'ppy:master' into Colour_hit_meter_improved	2022-09-10 21:16:23 +02:00
Mk-56spn	f6aef73f9e	fixed shape bindable not working, test creation, removal of Clear(), adjusted settings names	2022-09-10 20:30:43 +02:00
andy840119	3d7367a842	Move the CreateConvertibleReplayFrame() into the base ruleset class for avoid api breaking change in the customized ruleset.	2022-09-10 11:07:23 +08:00
andy840119	e62999fb16	Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset # Conflicts: # osu.Game.Rulesets.Catch/CatchRuleset.cs # osu.Game.Rulesets.Osu/OsuRuleset.cs # osu.Game.Rulesets.Taiko/TaikoRuleset.cs # osu.Game/Rulesets/Ruleset.cs	2022-09-10 10:40:12 +08:00
Salman Ahmed	95062c2cc8	Remove center origin specification to avoid single-frame layout issues	2022-09-09 19:42:58 +03:00
Salman Ahmed	dd10a06e3d	Merge branch 'master' into top-rank-badge-order	2022-09-09 19:38:44 +03:00
solstice23	823078ed2d	Merge branch 'master' into search-filter	2022-09-09 23:12:37 +08:00
Dean Herbert	602ffebd54	Apply NRT and fix code style	2022-09-09 23:29:04 +09:00
Dean Herbert	d961b96897	Merge branch 'master' into search-filter	2022-09-09 23:25:54 +09:00
Dean Herbert	27f745b980	Merge branch 'master' into fix_progress_bar_info	2022-09-09 17:34:13 +09:00
Dean Herbert	05797cb9e5	Fix enum to STRING????????? conversion (and use bindable flow)	2022-09-09 16:30:08 +09:00
Dean Herbert	f1fa442287	Merge pull request #19599 from ItsShamed/kps Add clicks/second counter to HUD	2022-09-09 01:50:12 +09:00
Dean Herbert	6945c43e0d	Merge pull request #20178 from smoogipoo/fix-match-creation-beatmap-select Fix several weird scenarios with online play song selection	2022-09-08 23:07:09 +09:00
Dean Herbert	45239fc737	Update `TrueGameplayRate` accessing	2022-09-08 23:03:15 +09:00
Dean Herbert	d4afc3629c	Merge branch 'master' into kps	2022-09-08 23:00:36 +09:00
Dan Balasescu	9aab502adc	Merge pull request #20157 from peppy/true-gameplay-rate Refactor `TrueGameplayRate` to account for only gameplay adjustments, no matter what	2022-09-08 19:54:32 +09:00
Dan Balasescu	4fc03998a1	Merge pull request #20189 from peppy/fix-playlist-item-download-button-visibility Fix playlist items showing download button briefly during initial display	2022-09-08 19:47:35 +09:00
Dean Herbert	096d1c3ff3	Merge pull request #20143 from acid-chicken/feat/stats/colored-td Show judgement colours in hit distribution graph	2022-09-08 19:15:40 +09:00
Dean Herbert	13d9b2188b	Merge pull request #20145 from smoogipoo/multiple-countdowns Implement support for multiple active countdowns in multiplayer	2022-09-08 19:15:30 +09:00
Dean Herbert	a98c6b2c1f	Add comment metioning why we need to use `DrawableRuleset` lookup	2022-09-08 19:14:23 +09:00
Mk-56spn	07c16224d2	Fix Main file issues	2022-09-08 11:58:14 +02:00
Dean Herbert	5c2fb3e434	Simplify calculation method	2022-09-08 18:22:53 +09:00
Dean Herbert	d463bd2f3f	Merge pull request #20130 from Exanc/master Display 0 stars instead of infinity for the minimum star slider	2022-09-08 17:51:32 +09:00
Dean Herbert	c6521e4c72	Rename ordering helper method	2022-09-08 17:50:27 +09:00
Dan Balasescu	76eae73fa4	Revert unintended change	2022-09-08 17:41:23 +09:00
Dan Balasescu	c61c596c1f	Expose as readonly IAggregateAudioAdjustment	2022-09-08 17:37:02 +09:00
Dan Balasescu	b559d4ecdf	Rename GameplayAdjustments -> AdjustmentsFromMods	2022-09-08 17:14:06 +09:00
Dean Herbert	ed81297611	Fix playlist items showing download button briefly during initial local presence checks	2022-09-08 17:10:45 +09:00
Dan Balasescu	b0b4da533a	Expose gameplay adjustments via MultiSpectatorPlayer instead	2022-09-08 16:59:20 +09:00
Dean Herbert	d523a2ac33	Rename default value field and make `private`	2022-09-08 15:53:08 +09:00
Dean Herbert	9ead5e59d3	Fix incorrectly displaying minimum value in placeholder messaging	2022-09-08 15:51:15 +09:00
Salman Ahmed	50923b6e5b	Move track assignment below	2022-09-08 00:25:55 +03:00
Acid Chicken (硫酸鶏)	267465df18	chore(osu.Game): combine `Osu.Colour.{Draw,Text}ForHitResult` into `OsuColour.ForHitResult`	2022-09-07 23:34:46 +09:00
Acid Chicken (硫酸鶏)	b560b6f745	refactor(osu.Game): arrange the code for the timing distribution graph	2022-09-07 23:29:10 +09:00
Dan Balasescu	83c0cb1acc	Fix beatmap set to null after exiting song select	2022-09-07 21:34:29 +09:00
Dan Balasescu	fcea244537	Remove initial selection from OnlinePlaySongSelect This stuff never really worked anyway - every case except with an already created multiplayer room was broken anyway.	2022-09-07 21:34:29 +09:00
Dan Balasescu	208bd0f391	Give OnlinePlaySongSelect a reference PlaylistItem	2022-09-07 21:34:29 +09:00
Dean Herbert	6a03b4e0de	Merge branch 'master' into true-gameplay-rate	2022-09-07 20:01:03 +09:00
Dan Balasescu	cb9bae1f5c	Enable NRT	2022-09-07 19:54:55 +09:00
Dean Herbert	e6b449fe0b	Fix case of zero rate calculating a zero true gameplay rate	2022-09-07 19:23:44 +09:00
Dean Herbert	1be3b74ff3	Fix multiplayer spectator not getting gameplay adjustments applied	2022-09-07 19:12:34 +09:00
Dean Herbert	fa15502384	Move full track adjustment flow inside `MasterGameplayClockContainer`	2022-09-07 19:12:16 +09:00
Dean Herbert	75d0deef72	Apply proposed changes to remove inheritance from `MasterGameplayClockContainer`	2022-09-07 17:49:05 +09:00
Dean Herbert	99ef0c95fe	Simplify children assignment	2022-09-07 16:51:51 +09:00
Dean Herbert	f3bda4e040	Fix weird edge case of nullability in `CarouselRoot` A bit unfortunately, but it's what we get for having ctor level bindings..	2022-09-07 14:27:25 +09:00
Dean Herbert	e18b524f8e	Fix missing null checks on `selectedBeatmap` fields in `BeatmapCarousel`	2022-09-07 14:12:35 +09:00
Dean Herbert	241d33d415	Apply NRT to `BeatmapCarousel`	2022-09-07 14:07:53 +09:00
Acid Chicken (硫酸鶏)	3003fc1061	refactor(osu.Game): improve code quality	2022-09-07 02:29:15 +09:00
Salman Ahmed	90207b6032	Merge branch 'master' into feature/EditorDeleteDiff	2022-09-06 18:48:06 +03:00
Dean Herbert	66c44f5913	Delegate interface to valid target	2022-09-06 22:26:46 +09:00
Dean Herbert	bc1212f4e6	Change `NonGameplayAdjustments` to `GameplayAdjustments` and convert `TrueGameplayRate` to extension method	2022-09-06 22:26:46 +09:00
Dean Herbert	db15bd56e8	Invalidate working beatmap cache when calling `DeleteDifficultyImmediately` rather than in editor code	2022-09-06 18:12:47 +09:00
Acid Chicken (硫酸鶏)	b109e5de6c	chore(osu.Game): align height of bars on timing distribution graph to `basalHeight` first and combine their transitions into each one	2022-09-06 00:04:10 +09:00
Dean Herbert	266eb758aa	Use new flow to calcaulate `TrueGameplayRate`	2022-09-05 23:37:49 +09:00
Dean Herbert	7084aeee05	Add method flow to reset applied adjustments	2022-09-05 23:22:38 +09:00
Dean Herbert	e33486a766	Implement `IAdjustableAudioComponent` in `MasterGameplayClockContainer`	2022-09-05 23:20:02 +09:00
Dan Balasescu	2923c10cd8	Rewrite rooms to store multiple active countdowns Update test to the new structure	2022-09-05 19:03:26 +09:00
Dean Herbert	57954bb8f5	Enable nullability on `TimelineHitObjectBlueprint`	2022-09-05 14:50:43 +09:00
Mk-56spn	aace334fb3	Fix some test issues	2022-09-05 04:49:48 +02:00
Dan Balasescu	07d4a025b0	Merge pull request #20109 from frenzibyte/online-play-room-status-inconsistency Fix room status dropdown placement inconsistent between multiplayer and playlists	2022-09-05 11:19:56 +09:00
Exanc	4ea7ca4c07	Slight tweak to the StarsSlider - MinimumStarsSlider now shows "0" when at it's minimum - Modified and NoResultsPlaceholder the tooltip to stay consistent with the changes	2022-09-05 00:09:20 +02:00

... 17 18 19 20 21 ...

13828 Commits