h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-14 21:23:19 +08:00
Code Issues Releases Wiki Activity

Reverse directionality of up/down traversal keys to match scroll

Browse Source
This commit is contained in:
Dean Herbert 2022-11-24 13:55:58 +09:00
parent 9b9b8a5977
commit 37f725bfa2
2 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
osu.Game.Tests/Visual/Editing/TestSceneEditorSeeking.cs
View File

@ -124,17 +124,17 @@ namespace osu.Game.Tests.Visual.Editing
AddAssert("time is 0", () => EditorClock.CurrentTime == 0);
// already at first control point, noop
pressAndCheckTime(Key.Down, 0);
pressAndCheckTime(Key.Up, 2000);
pressAndCheckTime(Key.Up, 20000);
// at last control point, noop
pressAndCheckTime(Key.Up, 20000);
pressAndCheckTime(Key.Up, 0);
pressAndCheckTime(Key.Down, 2000);
pressAndCheckTime(Key.Down, 0);
pressAndCheckTime(Key.Down, 0);
pressAndCheckTime(Key.Down, 20000);
// at last control point, noop
pressAndCheckTime(Key.Down, 20000);
pressAndCheckTime(Key.Up, 2000);
pressAndCheckTime(Key.Up, 0);
pressAndCheckTime(Key.Up, 0);
}
private void pressAndCheckTime(Key key, double expectedTime)

5
osu.Game/Screens/Edit/Editor.cs
View File

@ -499,11 +499,12 @@ namespace osu.Game.Screens.Edit
seek(e, 1);
return true;
case Key.Down:
// Of those, these two keys are reversed from stable because it feels more natural (and matches mouse wheel scroll directionality).
case Key.Up:
seekControlPoint(-1);
return true;
case Key.Up:
case Key.Down:
seekControlPoint(1);
return true;