1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-24 04:52:56 +08:00
Commit Graph

5590 Commits

Author SHA1 Message Date
Dean Herbert
844152e1b1
Merge pull request #13861 from peppy/add-password-support
Add multiplayer room password support
2021-07-19 23:32:28 +09:00
Dan Balasescu
6e104fe084
Merge pull request #13894 from peppy/fix-beat-synced-container-alt
Fix multiple issues with `BeatSyncedContainer`
2021-07-19 23:19:20 +09:00
smoogipoo
7956f73f62 Move initial content into step 2021-07-19 22:31:53 +09:00
smoogipoo
57a99886d5 Fix password icon not disappearing when no password 2021-07-19 22:31:01 +09:00
smoogipoo
b7c2d6b1ab Merge branch 'master' into add-password-support 2021-07-19 22:23:09 +09:00
Dan Balasescu
f3bcaf7f11
Merge pull request #13929 from peppy/i-deep-cloneable
Create a deep clone of score for score submission purposes
2021-07-19 21:58:27 +09:00
smoogipoo
05295241b8 Add room joining tests 2021-07-19 20:55:14 +09:00
smoogipoo
2eec524f27 Fix password not copied from multiplayer client 2021-07-19 20:20:08 +09:00
smoogipoo
1b9d297911 Add test 2021-07-19 20:08:29 +09:00
Dan Balasescu
473011070f
Merge pull request #13908 from peppy/editor-disallow-placement-when-untimed
Fix editor composer allowing object placement without timing present
2021-07-19 18:37:19 +09:00
Dean Herbert
bde35d9f21 Rename radio button classes to be local to editor 2021-07-19 16:57:12 +09:00
Dean Herbert
3c028ce05c Add IDeepCloneable interface and update existing CreateCopy methods to use it 2021-07-19 12:54:17 +09:00
Dean Herbert
c6bc95767d Simplify popover hide logic and add test coverage 2021-07-17 22:31:47 +09:00
kj415j45
0183564810 Merge branch 'localisation-base' of https://github.com/kj415j45/osu into localisation-base 2021-07-17 21:19:14 +08:00
kj415j45
5b4a1ef70a Update test to match Breadcrumb change 2021-07-17 20:40:59 +08:00
Dean Herbert
567a94a28b Remove unused using statements 2021-07-17 15:35:08 +09:00
Dean Herbert
d609839ff6 Fix test not working due to popover container being too global 2021-07-17 15:04:00 +09:00
Dean Herbert
23ed77f2c6 Fix test failure under visual tests due to double firing 2021-07-17 14:34:55 +09:00
Dean Herbert
db4d64effb Rename incorrect step 2021-07-17 14:29:18 +09:00
Dean Herbert
50eed26bd1 Rename radio button item to label 2021-07-17 02:32:23 +09:00
Dean Herbert
eac9b1ec7e Disable toolbox composition buttons when beatmap is not timed 2021-07-17 02:30:13 +09:00
Dean Herbert
efdc8fa8a6
Fix incorrect step name
Co-authored-by: Henry Lin <henry.ys.lin@gmail.com>
2021-07-15 19:08:12 +09:00
Dean Herbert
b6996d647e Add ability to disable mistimed event firings 2021-07-15 16:22:48 +09:00
Dean Herbert
3197f599bb Add failing test showing OnNewBeat can execute far away from an actual beat 2021-07-15 16:01:46 +09:00
Dean Herbert
77bfe700e0 Add test coverage of idle beat 2021-07-15 14:59:57 +09:00
Dean Herbert
cab8b94132 Add failing test 2021-07-15 14:41:50 +09:00
Dean Herbert
a3129ad00e Refactor BeatSyncedContainer to support GameplayClock 2021-07-15 14:37:13 +09:00
Dean Herbert
8cc2d2e79e Update beat synced container tests to be usable 2021-07-15 14:37:13 +09:00
Dean Herbert
b5dd9403b1 Merge branch 'master' into add-password-support 2021-07-14 23:53:03 +09:00
smoogipoo
dfe7cc40a9 Move create room button into the lounge 2021-07-14 18:55:01 +09:00
smoogipoo
0e89bafd17 Add special category pill + secondary background 2021-07-14 16:48:53 +09:00
smoogipoo
c5977f3318 Merge branch 'master' into lounge-redesign 2021-07-14 12:47:16 +09:00
Bartłomiej Dach
9bec53bfa8 Implement osu!-side popover 2021-07-14 01:05:06 +02:00
Dean Herbert
8d82412b39
Merge pull request #13851 from gagahpangeran/autolink-md
Add autolink support in osu markdown container
2021-07-13 19:40:53 +09:00
smoogipoo
28ff92e34e Add test 2021-07-13 17:31:28 +09:00
Gagah Pangeran Rosfatiputra
1c69da09d3
Merge branch 'master' into autolink-md 2021-07-13 15:04:36 +07:00
smoogipoo
0cb80e105b Renamespace classes 2021-07-13 16:02:18 +09:00
smoogipoo
ab282b9e59 Remove RoomInspector from the lounge 2021-07-13 16:00:42 +09:00
smoogipoo
8c4a257742 Add recent participants 2021-07-13 15:10:44 +09:00
Dean Herbert
5a2667ae89 Merge branch 'master' into add-password-support 2021-07-13 14:27:59 +09:00
Dean Herbert
35b5f0462c Merge branch 'master' into add-password-support 2021-07-13 14:26:56 +09:00
Dean Herbert
35841fa4f7
Merge branch 'master' into fix-difficulty-bindable-bind-order 2021-07-13 13:42:53 +09:00
Dan Balasescu
ba5d884ab0
Merge pull request #13856 from peppy/fix-line-break
Fix one new incorrect formatting inspection from EAP6
2021-07-13 07:46:39 +09:00
Bartłomiej Dach
f3fe472a33 Add failing test case for reset to defaults 2021-07-12 22:25:21 +02:00
Dean Herbert
947460c3c5 Add test flow for joining passworded rooms via UI 2021-07-12 18:25:04 +09:00
Dean Herbert
a3e0168a46 Update tests 2021-07-12 18:25:04 +09:00
Dean Herbert
9f9d7f9125 Add remaining pieces of password flow (for osu-web join request) 2021-07-12 18:22:52 +09:00
Dean Herbert
3c49b46c5f Add lock overlay for rooms which are password protected 2021-07-12 18:22:52 +09:00
Dean Herbert
78c74e97d1 Change to alternative formatting 2021-07-12 18:08:19 +09:00
smoogipoo
aba09b20a5 Add host under room title 2021-07-12 16:28:22 +09:00
smoogipoo
4ac812de86 Add rank range pill 2021-07-12 16:15:26 +09:00
Dean Herbert
84b0a3290c Add multiplayer lounge test coverage 2021-07-12 15:49:19 +09:00
Dean Herbert
d5d7dd0e74
Merge pull request #13701 from frenzibyte/consume-bindable-current-factory
Fix `RestoreDefaultValueButton` not behaving correctly on number types
2021-07-12 14:49:00 +09:00
smoogipoo
ac26374a93 Merge branch 'master' into lounge-redesign 2021-07-12 13:54:42 +09:00
Dean Herbert
3642febbb6 Fix one new incorrect formatting inspection from EAP6 2021-07-12 12:35:40 +09:00
Dan Balasescu
0c52b26d23
Merge pull request #13824 from peppy/da-mod-refactor
Refactor `ModDifficultyAdjust` to more elegantly track user override status
2021-07-12 12:03:45 +09:00
Bartłomiej Dach
9e70136100 Adjust test case slightly 2021-07-11 17:26:00 +02:00
Salman Ahmed
6b8de2a10b Add test coverage for excluded cases in score submission 2021-07-11 03:35:35 +03:00
Salman Ahmed
a1f3adc320 Add simple test cases 2021-07-10 19:56:44 +03:00
Bartłomiej Dach
08cd17435c
Merge branch 'master' into fix-run-from-screen-test-failures 2021-07-10 13:37:20 +02:00
Gagah Pangeran Rosfatiputra
5cd11a02ba
add autolink test 2021-07-10 17:56:37 +07:00
Bartłomiej Dach
b705213ea9 Update test to match expectations after refactor 2021-07-10 11:44:32 +02:00
Bartłomiej Dach
6f89f8e572 Merge branch 'master' into da-mod-refactor 2021-07-10 11:41:54 +02:00
Dean Herbert
6ae631b03a Remove previous seek testing logic from common test scene 2021-07-09 16:52:03 +09:00
Dean Herbert
9083b28114 Add test coverage of seeking and pausing 2021-07-09 14:47:11 +09:00
Dean Herbert
51bd83b3f4 Update override matching test to match expectations 2021-07-09 13:30:14 +09:00
Dean Herbert
9786e1a932 Ensure run-from-screen song select reaches correct point in execution
Fixes issues as seen at
https://github.com/ppy/osu/runs/3023581865?check_suite_focus=true. Song
select may take a few frames to perform initial selection as there is a
bit of internal async logic. This ensures that the beatmap has been
updated before continuing with test execution.
2021-07-09 12:36:56 +09:00
Dean Herbert
7153983dd4 Add test coverage 2021-07-08 18:29:54 +09:00
Dean Herbert
533db01cc0 Add comprehensive tests of difficulty adjust settings 2021-07-08 17:49:00 +09:00
Dean Herbert
a6e94dd491 Add back extended limits support 2021-07-08 17:49:00 +09:00
Dean Herbert
c4313d6e96 Initial implementation of new flow (only working for approach rate) 2021-07-08 17:48:08 +09:00
Dean Herbert
e612d7568c
Merge pull request #13771 from LumpBloom7/volume-meter-switch
Add ability to navigate between volume meters via Alt+Left/Right arrows
2021-07-07 21:50:44 +09:00
Dean Herbert
83283a706e Add test scene 2021-07-07 20:51:13 +09:00
Dean Herbert
f7dc689832
Merge pull request #13804 from bdach/migrate-directory-selector
Migrate file/directory selectors to use framework component instead of local implementation
2021-07-07 20:10:26 +09:00
Dan Balasescu
09a5516cc6
Merge pull request #13811 from smoogipoo/remove-unused-using
Remove unused usings
2021-07-07 16:30:07 +09:00
Dan Balasescu
066d0a1ef1
Merge branch 'master' into migrate-directory-selector 2021-07-07 15:57:34 +09:00
Dan Balasescu
05c4e0254b
Merge pull request #13796 from peppy/fix-skin-providing-container
Rewrite `SkinProvidingContainer`
2021-07-07 15:43:24 +09:00
smoogipoo
faf95c7161 Remove unused usings 2021-07-07 15:35:14 +09:00
Dan Balasescu
34a867a335
Merge branch 'master' into fix-skin-providing-container 2021-07-07 15:00:35 +09:00
Dean Herbert
35672f372a Shorten test beatmap to avoid timeouts in score submission test 2021-07-07 14:58:01 +09:00
smoogipoo
8929aa0ca7 Initial redesign of DrawableRoom 2021-07-07 14:47:24 +09:00
smoogipoo
1a832a4e6b Add clickability to test 2021-07-07 14:47:24 +09:00
smoogipoo
33615646bd Rename DrawableRoom test scene 2021-07-07 14:47:24 +09:00
Bartłomiej Dach
f45418dde7 Replace game-side directory/file selector with framework extensions 2021-07-06 22:11:54 +02:00
Derrick Timmermans
4451598bcf
Fix remaining quality complaints 2021-07-06 15:17:19 +02:00
Derrick Timmermans
ffe18ebe51
Resolve build errors 2021-07-06 14:11:46 +02:00
smoogipoo
6bc0020825 Fix intermittent spectate button test failures 2021-07-06 20:28:55 +09:00
smoogipoo
b209868d96 Fix another potential failure 2021-07-06 17:57:24 +09:00
smoogipoo
8b12ec9586 Fix intermittent ready button test failures 2021-07-06 17:52:27 +09:00
Dean Herbert
d75d67577a Fix regressed tests 2021-07-06 17:37:34 +09:00
Dan Balasescu
32e6c9c5d3
Merge pull request #13786 from peppy/multiplayer-test-fixes
Fix multiplayer test failures due to leaderboard load process
2021-07-06 16:33:41 +09:00
Derrick Timmermans
d495196b66
Share item cycling logic with GameplayMenuOverlay 2021-07-05 19:22:55 +02:00
PercyDan54
e1c646b9b2
Remove redundant arguments 2021-07-05 23:52:39 +08:00
Dean Herbert
10e7c846e5 Add local UserLookupCache to avoid online requests being fired from multiplayer tests 2021-07-05 19:41:00 +09:00
Dean Herbert
9c2fed4806 Move setup steps to SetUpSteps and add empty test case 2021-07-05 19:10:27 +09:00
Henry Lin
3c37140426 Remove an unused local variable 2021-07-05 09:52:13 +08:00
Henry Lin
bfb603cfeb Change the test for unimplemented mod to use a mock ruleset and mod 2021-07-05 09:51:24 +08:00
Bartłomiej Dach
c143a50b73
Merge branch 'master' into fix-zero-hit-score-submit 2021-07-04 15:31:38 +02:00
Bartłomiej Dach
19f02dc3d9 Ensure tests with no token have at least one hit
Because submission can be prevented by both not having been issued a
correct submission token, and by not actually registering any hits in
gameplay, ensure that tests that don't receive a token register at least
one hit, to avoid potentially having test cases that test the "no token"
flow pass erroneously because they never had any hits in the first
place.
2021-07-04 14:34:52 +02:00
Dean Herbert
2a74b1c539 Add test coverage of new scenarios 2021-07-04 17:27:02 +09:00
Dean Herbert
ec71deec51 Remove some mentions of "lazer"
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
2021-07-04 12:41:27 +09:00
Dean Herbert
b0f257fa04
Merge pull request #13685 from gagahpangeran/wiki-image-block
Fix image overflow in wiki overlay
2021-07-02 20:21:20 +09:00
Dan Balasescu
9eb6ae4d45
Merge pull request #13721 from peppy/submit-on-player-exit
Submit scores on player exit
2021-07-02 18:25:26 +09:00
Dean Herbert
4e52aee5a0
Merge branch 'master' into wiki-image-block 2021-07-02 18:19:46 +09:00
Dan Balasescu
211c248692
Merge pull request #13744 from peppy/fix-async-void-calls
Fix some incorrectly invoked `async` calls
2021-07-02 18:10:30 +09:00
Dean Herbert
d67fc87dcb Add some basic testability of external colour setting 2021-07-02 17:24:15 +09:00
Dean Herbert
7b0f970e7d Fix ongoing operation being begun in an async context 2021-07-02 16:09:02 +09:00
Dean Herbert
f2d9d78455 Fix some incorrectly invoked async calls 2021-07-02 14:43:48 +09:00
Dean Herbert
30467191b2 Remove local handling of NoFail addition 2021-07-02 14:21:48 +09:00
Bartłomiej Dach
434c048d87 Merge branch 'master' into colour-picker 2021-07-02 01:03:00 +02:00
smoogipoo
4c95af4b16 Add star rating range display 2021-07-01 20:35:31 +09:00
Dean Herbert
a6323b7d87 Use APIException 2021-07-01 17:54:59 +09:00
Dean Herbert
74c63e15be Mark score failed on fail and exit 2021-07-01 17:48:09 +09:00
Dean Herbert
6e8d4e382e Add test coverage of token failure scenarios 2021-07-01 17:20:40 +09:00
Dean Herbert
397d2491b3 Update test scenes to actually cover submission logic 2021-07-01 16:55:44 +09:00
Dean Herbert
719852435f Fix intermittent PerformFromScreen test failures due to incorrect screen sequence
These tests were manually pushing the `PlayerLoader` / `Player`
instances to `SongSelect`, which bypasses safeties in place which avoid
the exact issue that came up in https://github.com/ppy/osu/runs/2951759236
(see `AllowSelection` flag specifically).
2021-07-01 15:10:29 +09:00
Bartłomiej Dach
583242d96d Add osu!-styled colour picker control 2021-06-30 23:25:50 +02:00
Dean Herbert
4a54e7cdb8 Add tests covering score preparation flow 2021-06-30 20:23:24 +09:00
smoogipoo
aa7405afa1 Increase number of sent frames to prevent timing issues 2021-06-30 20:16:57 +09:00
Dean Herbert
741ecbb2df Merge branch 'master' into spectator-start-at-end-2 2021-06-30 15:06:30 +09:00
Dean Herbert
4337577448 Remove unused private methods 2021-06-30 14:31:27 +09:00
Dean Herbert
a019f2cc5c
Merge branch 'master' into rework-multiplayer-test-scenes 2021-06-30 13:49:05 +09:00
Dean Herbert
825181121d
Merge branch 'master' into spectator-start-at-end-2 2021-06-30 01:50:14 +09:00
smoogipoo
331b7237ab Attempt to fix one more intermittent test failure 2021-06-29 23:02:20 +09:00
smoogipoo
6dd3c6fe93 Make MultiSpectatorScreen and tests more resillient to timing 2021-06-29 22:45:51 +09:00
smoogipoo
1b2d00f796 Trigger successes 2021-06-29 20:13:39 +09:00
smoogipoo
8e04d73b67 Merge branch 'rework-multiplayer-test-scenes' into spectator-start-at-end-2 2021-06-29 17:06:57 +09:00
smoogipoo
bcdf36e77b Merge branch 'master' into spectator-start-at-end-2 2021-06-29 15:53:58 +09:00
smoogipoo
92fa99700e Merge branch 'master' into rework-multiplayer-test-scenes 2021-06-29 15:39:59 +09:00
smoogipoo
06beeee4d8 Cleanup match header test 2021-06-29 15:39:01 +09:00
Gagah Pangeran Rosfatiputra
a1fe9df378
add test to check sprite image width 2021-06-29 10:14:51 +07:00
Dan Balasescu
697b07acb1
Merge branch 'master' into fix-beatmap-import-fk-failure 2021-06-29 11:36:31 +09:00
Gagah Pangeran Rosfatiputra
0e29ae037b
add wide image test 2021-06-28 20:50:29 +07:00
Gagah Pangeran Rosfatiputra
ab977d91f0
fix image test not load
looks like forgot to change this after `CurrentPath` shenanigan
2021-06-28 20:40:22 +07:00
Dean Herbert
f939e2603a Merge branch 'master' into localisable-tooltips 2021-06-28 15:29:42 +09:00
Dan Balasescu
9c0840268a
Merge pull request #13598 from JimmyC7834/supporter-only-filter-content
Add supporter required placeholder in beatmap listing overlay
2021-06-28 10:27:56 +09:00
Bartłomiej Dach
709e555566 Rename test steps for legibility 2021-06-26 20:27:15 +02:00
Bartłomiej Dach
b7c4fe2052 Rewrite test helpers to also handle clearing filters 2021-06-26 20:25:43 +02:00
Bartłomiej Dach
51888d0d5a Rename test methods 2021-06-26 20:24:42 +02:00
Bartłomiej Dach
50c27d2635 Update usages of IHasTooltip in line with framework localisation changes 2021-06-25 19:10:04 +02:00
smoogipoo
d035633f95 Load participants list after joining room 2021-06-25 20:56:13 +09:00
smoogipoo
3e5ae7ea58 Don't join room in participants test 2021-06-25 20:44:00 +09:00
smoogipoo
1ed61b9b98 Fix up dependencies class names 2021-06-25 20:11:38 +09:00
smoogipoo
57f2b4f812 Fix incorrect parent class 2021-06-25 20:09:03 +09:00
smoogipoo
04cc390c41 Fix TestSceneMultiplayer resolving the wrong client 2021-06-25 19:16:54 +09:00
smoogipoo
a27a647ae7 Rename RoomDependencies -> OnlinePlayDependencies 2021-06-25 18:07:47 +09:00
smoogipoo
c0d2b41d4c Move SpectatorClient into multiplayer dependencies 2021-06-25 17:55:16 +09:00
Dean Herbert
51dd7fc238
Merge pull request #13622 from aitani9/mod-settings-dropdown-height
Decrease the max dropdown height in mod settings
2021-06-25 17:42:47 +09:00
smoogipoo
7aefbe3da1 Move UserLookupCache inside dependencies 2021-06-25 17:37:02 +09:00
Dean Herbert
5883922177 Remove mod multiplier completely 2021-06-25 16:36:31 +09:00
smoogipoo
d6ab08c958 Remove manual dependencies in TestSceneMultiplayerGameplayLeaderboard 2021-06-25 15:30:28 +09:00
smoogipoo
81a812e216 Rework MultiplayerTestScene to make use of OnlinePlayTestScene 2021-06-25 15:00:10 +09:00
smoogipoo
aa5d22d04a Remove "test container", make everything go through OnlinePlayTestScene 2021-06-25 13:02:19 +09:00
smoogipoo
8fba7d2423 Remove MultiplayerTestScene inheritance from simple test scenes 2021-06-24 21:02:29 +09:00
smoogipoo
a21cf87b5f Split room manager and allow overrides 2021-06-24 19:14:05 +09:00
smoogipoo
5115299e9a Merge RoomManagerTestScene into OnlinePlaySubScreenTestScene 2021-06-24 19:09:31 +09:00
smoogipoo
a7b5c3bed1 Add OnlinePlaySubScreenTestScene 2021-06-24 17:01:28 +09:00
smoogipoo
4af119a407 Re-namespace 2021-06-24 16:29:06 +09:00
smoogipoo
c9ec4b9da4 Remove RoomTestScene inheritance from simple test scenes 2021-06-24 16:02:20 +09:00
Dean Herbert
cd6f175375 Ensure beatmap is reloaded before each playlist room test run 2021-06-24 13:29:06 +09:00
Dean Herbert
1bbfbb0d8e Fix test that never should have worked
This was only working by luck until now. It was "correctly" matching on
null online ID (see logic at
abc96057b2/osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs (L199-L207)).

Now it works by actually matching on the online ID.
2021-06-23 19:30:11 +09:00
Dean Herbert
151dfdfb79
Merge pull request #13627 from Joehuu/fix-multiplayer-exit-logic
Fix multiplayer leave dialog not working on all exit operations
2021-06-23 14:56:57 +09:00
Joseph Madamba
dc428da06c Fix test regression 2021-06-22 19:30:52 -07:00
Joseph Madamba
49000b9501 Add multiplayer leave navigation tests 2021-06-22 19:30:40 -07:00
Salman Ahmed
37f7486fb1 Fix potential null reference in LINQ method 2021-06-22 12:25:29 +03:00
Salman Ahmed
31cbb36a64 Implement FindProvider and AllSources properly on all test ISkinSources 2021-06-22 12:03:14 +03:00
Dean Herbert
0ad189e357 Expose skin sources via ISkinSource and revert to consuming based on hierarchy 2021-06-22 16:19:55 +09:00
Dean Herbert
1b0aadcc6f Merge branch 'master' into transformers-per-skin 2021-06-22 16:03:15 +09:00
JimmyC7834
0d17fb4259 fixed code 2021-06-22 13:53:21 +08:00
JimmyC7834
b42aedeb81 fixed code style 2021-06-21 14:43:54 +08:00
JimmyC7834
996503eb2d fixed filter text display, added visual tests 2021-06-20 21:23:54 +08:00
JimmyC7834
e7aeba8d03 added more visual tests 2021-06-20 18:28:43 +08:00
JimmyC7834
42fdfbb9a1 added visual tests 2021-06-20 17:17:07 +08:00
Dean Herbert
c369beeaaa Merge branch 'master' into realm-key-binding-store 2021-06-18 16:52:35 +09:00
Dean Herbert
246ab41cc6 Remove special casing for user exit during storyboard outro 2021-06-17 18:11:15 +09:00
Dean Herbert
4b45d8318e
Merge branch 'master' into transformers-per-skin 2021-06-16 16:37:28 +09:00
Dean Herbert
66efc3c4de
Merge branch 'master' into realm-key-binding-store 2021-06-16 13:23:13 +09:00
Bartłomiej Dach
30703d518c Add failing assert for seasonal background equality 2021-06-15 23:19:33 +02:00
Dean Herbert
acc06ca398 Merge branch 'master' into realm-key-binding-store 2021-06-16 02:14:58 +09:00
Dean Herbert
fcb0b8d825 Add test coverage 2021-06-14 15:06:33 +09:00
Dean Herbert
b06477a1f5 Split out tests into individual test methods 2021-06-14 14:35:24 +09:00
Dean Herbert
26312bf60a
Merge branch 'master' into chat-mention 2021-06-11 20:03:44 +09:00
smoogipoo
0a8daab4f7 Pause master clock when too far ahead 2021-06-11 19:15:53 +09:00
smoogipoo
e9ebbd298d Add a few more tests 2021-06-11 18:13:54 +09:00
Dean Herbert
16e3a19738 Fix notification overlay not being in correct place in test scene 2021-06-11 16:18:51 +09:00
Dean Herbert
f00967388a Refactor tests a bit 2021-06-11 16:17:42 +09:00
Bartłomiej Dach
417aaacc53 Add test coverage for romanised data transfer 2021-06-10 22:18:39 +02:00
smoogipoo
58d71e4aea Remove local "next frame" storage 2021-06-10 22:41:38 +09:00
Salman Ahmed
dde84e5cbd Merge branch 'master' into transformers-per-skin 2021-06-10 11:58:52 +03:00
Dean Herbert
5e80f454ce
Merge branch 'master' into results-screen-sfx 2021-06-10 17:25:35 +09:00
Dean Herbert
9a3ca09501
Merge pull request #13384 from bdach/fixed-label-width
Align label widths of editor setup screen controls
2021-06-10 14:55:49 +09:00
Dean Herbert
9044a20120 Merge branch 'master' into realm-key-binding-store 2021-06-10 13:58:08 +09:00
Gagah Pangeran Rosfatiputra
39e1f77d53
add image table with image content test 2021-06-10 09:37:33 +07:00
Dean Herbert
3d508f9266 Merge branch 'master' into results-screen-sfx 2021-06-10 11:28:35 +09:00
Salman Ahmed
6538d44708 Make SkinProvidingContainer able to perform lookup on multiple skins
Currently `protected` functionality for use in custom `SkinProvidingContainer`s, can be exposed to public constructors if it need to later on, but I'm not sure about doing that opposed to just nesting multiple `SkinProvidingContainer`.
2021-06-09 22:49:31 +03:00
Salman Ahmed
cf40282f1f Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource 2021-06-09 22:49:31 +03:00
Bartłomiej Dach
7fe878299f
Merge branch 'master' into wiki-article 2021-06-09 16:24:45 +02:00
Dean Herbert
b02b8ae2bc
Merge pull request #13381 from smoogipoo/improve-hit-error-judgements
Improve hit error judgement displays
2021-06-09 19:40:17 +09:00
Dean Herbert
8fda04c2d9 Merge branch 'master' into results-screen-sfx 2021-06-09 18:00:11 +09:00
Bartłomiej Dach
5487012060 Add test coverage for default skin background cycling 2021-06-09 07:48:16 +02:00
Bartłomiej Dach
f628ec25ef Add test coverage for keeping same background instance 2021-06-08 22:31:09 +02:00
Bartłomiej Dach
d86ace4d11 Add test coverage for skin background source 2021-06-08 22:03:59 +02:00
Bartłomiej Dach
88266eac63 Add option to fix label width of a LabelledDrawable 2021-06-08 16:57:32 +02:00
smoogipoo
c8e14d7710 Ignore non-scorable and bonus judgements 2021-06-08 23:09:23 +09:00
Dean Herbert
25af4dfa8a
Merge pull request #13375 from smoogipoo/fix-multi-nullref
Fix possible nullref when exiting song select too fast
2021-06-08 20:47:40 +09:00
smoogipoo
ab9290772b Fix a similar case with online play sub-screens 2021-06-08 17:54:54 +09:00
Dean Herbert
6017ef3825
Merge branch 'master' into fix-skin-sample-lookup 2021-06-08 17:37:36 +09:00
smoogipoo
490ab9e96a Fix typo 2021-06-08 17:09:03 +09:00
smoogipoo
7fa0ac6ed7 Fix possible nullref when exiting song select too fast 2021-06-08 17:03:50 +09:00
Dan Balasescu
791855dfa0
Merge branch 'master' into legacy-skin-default-fallback 2021-06-08 16:54:26 +09:00
Dean Herbert
95852ccdf8 Merge branch 'master' into results-screen-sfx 2021-06-08 15:14:31 +09:00
Bartłomiej Dach
1b4771655a Adjust test scene to avoid cross-test interference
* Move steps from ctor to a separate basic test.
* Wait for barrage to complete in basic test, as not doing so polluted
  state of other tests.
* Reset score processor after every test.
2021-06-07 13:16:07 +02:00
Bartłomiej Dach
37d062c7cd Add failing assertions to hit error meter test 2021-06-07 13:16:07 +02:00
Bartłomiej Dach
122a624b7f Remove bogus CatchHitWindows
`CatchHitWindows` were a vestige from the past, and were not actually
used anywhere except for the hit error meter test, giving off an
appearance that the hit error meter was working properly.
`CatchHitObject` actually specifies empty hit windows.
2021-06-07 13:16:07 +02:00
Bartłomiej Dach
b192c46316 Merge branch 'master' into wiki-article 2021-06-07 11:19:20 +02:00
Dean Herbert
729e05241f Add more test coverage 2021-06-07 17:32:10 +09:00
Dean Herbert
f677f9b5f4 Stop BackgroundScreenDefault from reloading beatmap background when already correct 2021-06-07 17:22:36 +09:00
Dean Herbert
d26c9a66c2 Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup 2021-06-07 12:01:19 +09:00
Craftplacer
248e90df6d
Add more request handling code 2021-06-05 15:55:58 +02:00
Craftplacer
5e44329e0b
Add DummyAPIAccess request handler
Make CreateChannelRequest.channel public
2021-06-05 14:43:26 +02:00
Craftplacer
39c3b08fc7
Merge remote-tracking branch 'upstream/master' into chat-mention 2021-06-05 11:18:06 +02:00
Craftplacer
6e40af756b
Add request handler for dummy API 2021-06-05 11:10:16 +02:00
Gagah Pangeran Rosfatiputra
5febbe4530
rename method add entry 2021-06-04 23:32:42 +07:00
Gagah Pangeran Rosfatiputra
a82eeb6daf
tidy up sidebar test 2021-06-04 16:00:26 +07:00
Gagah Pangeran Rosfatiputra
3bf70dea60
fix test to using heading block 2021-06-04 15:51:23 +07:00
Dean Herbert
06275a6a7d Merge branch 'master' into legacy-skin-default-fallback 2021-06-04 16:00:30 +09:00
Gagah Pangeran Rosfatiputra
6c1fede18e
add wiki sidebar test scene 2021-06-04 13:11:37 +07:00
Dean Herbert
23096c58bb
Merge branch 'master' into fix-spectator-frame-conversion 2021-06-04 15:06:15 +09:00
Jamie Taylor
49fbd35e91
remove sound design tool 2021-06-04 14:21:40 +09:00
Dan Balasescu
0ba493d598
Merge pull request #13318 from gagahpangeran/error-page-placeholder
Add error page placeholder for wiki overlay
2021-06-04 12:20:21 +09:00
Gagah Pangeran Rosfatiputra
34379b953a
change test scene response 2021-06-04 09:36:21 +07:00
Gagah Pangeran Rosfatiputra
b36c406a83
add test scene for error page 2021-06-03 19:48:04 +07:00
Bartłomiej Dach
e117f98bfa Rename test steps 2021-06-03 14:31:13 +02:00
Bartłomiej Dach
acb4873157 Merge branch 'master' into keyboard_shortcuts 2021-06-03 14:09:48 +02:00
Jamie Taylor
8dc595d201
move result screen samples to DefaultSkin 2021-06-03 18:35:27 +09:00
Jamie Taylor
9ad87ee5dc
add sfx for results screen + sound design tool 2021-06-03 18:34:22 +09:00
smoogipoo
c3280083a2 Merge branch 'master' into fix-spectator-frame-conversion 2021-06-03 17:42:01 +09:00
smoogipoo
3bc81fbb06 Fix spectator tests 2021-06-03 17:27:24 +09:00
smoogipoo
420df124b5 Add framestable-bypassing seek for spectator 2021-06-03 17:27:21 +09:00
Dean Herbert
b917d6d80c Update tests to check for correct platform action keys 2021-06-03 15:34:06 +09:00
Dean Herbert
4a5d8215f3
Merge branch 'master' into keyboard_shortcuts 2021-06-03 14:47:40 +09:00
Dean Herbert
66dd7b7705 Update test logic to allow gameplay to properly continue 2021-06-03 14:38:50 +09:00
Dan Balasescu
44b1102241
Merge branch 'master' into autoplay-pause-support 2021-06-03 13:26:00 +09:00
Dan Balasescu
c065f761c7
Merge branch 'master' into legacy-skin-default-fallback 2021-06-02 19:08:52 +09:00
Dean Herbert
5366e7f61e
Merge branch 'master' into remove-hud-component-lookup 2021-06-02 16:10:06 +09:00
Dean Herbert
f8ae70e562 Update existing function type rather than adding an override 2021-06-02 16:04:53 +09:00
Dean Herbert
45984f035b Make autoplay tests test via the ReplayPlayer code path 2021-06-02 11:49:06 +09:00
smoogipoo
8ee2b3a2d2 Merge branch 'master' into fix-scrolling-lifetime 2021-06-02 11:08:28 +09:00
Dean Herbert
e8aa5c4ecf Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup 2021-06-01 18:05:00 +09:00
Dean Herbert
cd139660ab Merge branch 'master' into legacy-skin-default-fallback 2021-06-01 18:04:54 +09:00
Dean Herbert
7a71cc1e82 Fix actually incorrect navigation test (can no longer retry from autoplay results) 2021-06-01 16:54:29 +09:00
Salman Ahmed
7c6400735f Merge branch 'master' into remove-hud-component-lookup 2021-06-01 10:17:52 +03:00
Salman Ahmed
cb38abab35 Add local logic for creating default/legacy implementation based on cell skin 2021-06-01 10:17:01 +03:00
Salman Ahmed
cd8e3f3a04 Revert "Group all skinnable test scenes to one TestSceneSkinnableHUDComponents"
This reverts commit d1272d5e13.
2021-06-01 09:57:43 +03:00
Dean Herbert
dce24e3d4d
Merge pull request #12950 from gagahpangeran/osu-wiki-overlay
Initial implementation of Wiki Overlay
2021-06-01 15:20:56 +09:00
Dean Herbert
00ffea5e2c Update tests to specify full absolute path 2021-06-01 14:38:30 +09:00
Dean Herbert
6ef9b346e1 Fix newly found inspections from 2021.1EAP1 2021-06-01 14:33:21 +09:00
Dean Herbert
00b3eea840 Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup 2021-05-31 21:39:04 +09:00
Dean Herbert
3ff9f9c89d Make FindProvider non-default 2021-05-31 21:29:47 +09:00
smoogipoo
c787c008a5 Fix test potentially not waiting for player to load 2021-05-31 20:21:26 +09:00
Dean Herbert
17fa2426d4 Merge branch 'master' into legacy-skin-resource-improvements 2021-05-31 19:36:09 +09:00
Dean Herbert
b16d10bd95 Provide game-wide resources via IStorageResourceProvider 2021-05-31 18:57:47 +09:00
Dean Herbert
d4cb70735d Merge branch 'master' into non-nullable-beatmapset-files 2021-05-31 18:19:57 +09:00
Dean Herbert
de0e51a81d Merge branch 'master' into fix-skin-sample-lookup 2021-05-31 15:27:39 +09:00
Salman Ahmed
02d18c7a49 Merge branch 'master' into remove-hud-component-lookup 2021-05-31 09:23:04 +03:00
ekrctb
771f3c48c0 Add failing test showing lifetime not recomputed with pooled objects 2021-05-31 14:48:52 +09:00
Dean Herbert
5925beaf21 Fix bindable lease failure in editor beatmap creation tests 2021-05-31 14:24:46 +09:00
Bartłomiej Dach
ab077c6656
Merge branch 'master' into non-nullable-beatmapset-files 2021-05-31 00:10:03 +02:00
Bartłomiej Dach
78213e09d4
Merge branch 'master' into editor-exit-stability 2021-05-30 23:03:50 +02:00
Gagah Pangeran Rosfatiputra
3c7f1ae996
Merge branch 'master' into osu-wiki-overlay 2021-05-30 20:27:12 +07:00
Dean Herbert
f35cf2d846
Merge branch 'master' into main-page-wiki 2021-05-30 21:01:05 +09:00
Dean Herbert
dac1a98d8a Merge branch 'master' into fix-skin-sample-lookup 2021-05-30 15:19:47 +09:00
Salman Ahmed
200fecc774 Fix missing using directive 2021-05-29 21:22:39 +03:00
Salman Ahmed
42618c713f
Merge branch 'master' into legacy-beatmap-skin-hud-fallback 2021-05-29 20:56:05 +03:00
Dean Herbert
951fc5ef6e Remove misleading comment and misplaced bug fix
This shouldn't be fixed in a test scene; the underlying issue should be
fixed in actual game code.
2021-05-29 15:39:13 +09:00
Dean Herbert
9b239e308b Merge branch 'master' into beatmap-skin 2021-05-29 15:36:43 +09:00
Dean Herbert
8652ac05db Merge branch 'editor-exit-stability' into non-nullable-beatmapset-files 2021-05-28 18:58:35 +09:00
Dean Herbert
ba80361c4c Fix tests that were previously doing reference comparisons 2021-05-28 18:38:50 +09:00
Dean Herbert
6268bbea85 Merge branch 'master' into fix-skin-sample-lookup 2021-05-28 14:47:35 +09:00
Dean Herbert
581a86b91a Revert "Revert "Fix editor tests failing due to empty files being specified""
This reverts commit 1af684c4b2.
2021-05-28 14:33:06 +09:00
Dean Herbert
f1b5aced6f Merge branch 'master' into editor-exit-stability 2021-05-28 14:32:32 +09:00
Dean Herbert
1af684c4b2 Revert "Fix editor tests failing due to empty files being specified"
This reverts commit fdbd421040.
2021-05-28 14:15:28 +09:00
Dan Balasescu
1ffafdd854
Merge branch 'master' into single-bind-reset-button 2021-05-27 23:55:28 +09:00
Dan Balasescu
1a0ace8d58
Merge branch 'master' into fix-slow-load-test-failure 2021-05-27 23:15:42 +09:00
Dan Balasescu
0a3d3bc006
Merge pull request #12958 from peppy/fix-invalid-ssdq-access
Fix `BeatmapCarousel` accessing `ScreenSpaceDrawQuad` of non-loaded children
2021-05-27 23:15:06 +09:00
Dan Balasescu
6ddb2062cf
Merge pull request #13214 from peppy/fix-multiplayer-leaderboard-test-failure
Fix test failure in `TestSceneMultiplayerGameplayLeaderboard`
2021-05-27 22:44:05 +09:00
Dean Herbert
121dd175e6 Fix test failure in TestSceneMultiplayerGameplayLeaderboard
The transfer of users was not accounting for the fact that the
`StartPlay` calls are now scheduled and not necessarily run in time.
2021-05-27 19:57:21 +09:00
Dean Herbert
bcf1e3db1e Fix test failures in TestSceneStoryboardWithOutro
Test was not accounting for the fact that the results may not have
loaded in time.
2021-05-27 19:45:55 +09:00
Gagah Pangeran Rosfatiputra
0b600db814
revert back main page test 2021-05-27 16:24:05 +07:00
Gagah Pangeran Rosfatiputra
820310543d
fix spacing style 2021-05-27 14:53:22 +07:00
Dean Herbert
aa23c4a4b9
Merge branch 'master' into keyboard_shortcuts 2021-05-27 16:30:34 +09:00
Gagah Pangeran Rosfatiputra
b55ac413e7
add many scenario of main page layout 2021-05-27 14:20:36 +07:00
Dean Herbert
5c44083856 Fix test potentially not waiting for drawable beatmaps to be loaded 2021-05-27 16:12:49 +09:00
Dean Herbert
c39ea85701 Fix TestSceneSkinnableSound not doing DI correctly 2021-05-27 15:42:25 +09:00
Dean Herbert
70a844ac10 Remove allowFallback parameters completely 2021-05-27 14:50:42 +09:00
Craftplacer
2166ab87c6
Change base type of tests
Fixes missing API property
2021-05-27 01:47:00 +02:00
Gagah Pangeran Rosfatiputra
649163e13b
Merge branch 'master' into main-page-wiki 2021-05-26 23:51:49 +07:00
Dean Herbert
74fc0a17d5 Remove unused using statement 2021-05-27 00:55:06 +09:00
Dean Herbert
c0a8382175 Remove local API construction 2021-05-27 00:12:22 +09:00
Dean Herbert
8e923a5d8f Instantiate immediately, rather than waiting for instantiation 2021-05-26 22:24:51 +09:00
Gagah Pangeran Rosfatiputra
fbfbd99223
change document url test to dev server 2021-05-26 19:20:39 +07:00
Dean Herbert
878079d3d7 Fix correct beatmap not being set if running test alone 2021-05-26 19:08:00 +09:00
Dean Herbert
a77de24746 Fix SlowLoadPlayer potentially not being instantiated in time for test 2021-05-26 18:58:18 +09:00
Dean Herbert
14a4095140 Merge branch 'master' into beatmap-skin 2021-05-26 18:39:47 +09:00
Dean Herbert
7c9383b586 Combine RestorableKeyBindingRow back into KeyBindingRow 2021-05-26 18:17:28 +09:00
Gagah Pangeran Rosfatiputra
71f77eb902
fix image test 2021-05-26 15:04:04 +07:00
Dean Herbert
98fa5b67d6
Merge branch 'master' into single-bind-reset-button 2021-05-26 17:01:16 +09:00
Dean Herbert
52ca2f4797 Merge branch 'master' into chat-mention 2021-05-26 16:00:26 +09:00
Swords
d5feb8353d Formatting, renaming 2021-05-25 21:37:08 +10:00
Swords
d9f5b578bf Restore class names 2021-05-25 21:08:40 +10:00
Dean Herbert
a249bb9e69 Merge branch 'master' into realm-key-binding-store 2021-05-25 17:18:33 +09:00
Dean Herbert
df703b68ec Merge branch 'master' into realm-key-binding-store 2021-05-25 13:41:48 +09:00
Gagah Pangeran Rosfatiputra
2e6d463901
add test link with title 2021-05-24 20:45:47 +07:00
Dean Herbert
37f6ceef79 Add test coverage 2021-05-24 21:57:04 +09:00
Swords
518999ffab Renaming files 2021-05-24 22:49:40 +10:00
Dean Herbert
29e1737f0d
Merge branch 'master' into mbd-beatmap-set-cover 2021-05-24 15:51:03 +09:00
Gagah Pangeran Rosfatiputra
0448f6fdb3
add main page markdown 2021-05-25 13:21:08 +07:00
Gagah Pangeran Rosfatiputra
b8a5b5aaf8
add test for image block and inline image 2021-05-23 17:22:31 +07:00
Salman Ahmed
afb33f1641 Remove no longer necessary test case 2021-05-21 20:21:50 +03:00
Dean Herbert
f335337e5d
Merge pull request #12851 from vininew921/applause-stops-on-score-switch
Fix applause sound stopping after switching scores
2021-05-21 18:49:59 +09:00
Dean Herbert
2958b9adf4 Merge branch 'master' into import-from-stable-select-location 2021-05-21 17:37:34 +09:00
Dean Herbert
1ca563e831 Merge branch 'master' into applause-stops-on-score-switch 2021-05-21 17:28:28 +09:00
Dean Herbert
8085a54205 Add test coverage of different grade types to TestSceneResultsScreen 2021-05-21 17:28:25 +09:00
Gagah Pangeran Rosfatiputra
49aa0f3a18
initial main page 2021-05-21 10:04:45 +07:00
Bartłomiej Dach
f35a07fee7 Rename method for better comprehension 2021-05-20 20:47:50 +02:00
Bartłomiej Dach
b521405ec8 Trim redundant string interpolation 2021-05-20 20:46:18 +02:00
Gagah Pangeran Rosfatiputra
092d0f9b76
add breadcrumb header test scene 2021-05-21 01:21:31 +07:00
Salman Ahmed
c0dfe37965 Remove unused using directive 2021-05-20 21:08:36 +03:00
Salman Ahmed
eaae9a1b67 Remove unrequired null conditional 2021-05-20 21:08:31 +03:00
Salman Ahmed
262a27610c Improve components assertion logic 2021-05-20 20:47:40 +03:00
Dan Balasescu
527847596e
Merge pull request #12884 from peppy/ternary-menu-item-refactor
Create base implementations of the two most common `TernaryStateMenuItem`s
2021-05-20 21:02:15 +09:00
Gagah Pangeran Rosfatiputra
1ad3aee126
add article page test wiki overlay 2021-05-20 17:49:20 +07:00
Dean Herbert
df5970fab4 Create base implementations of the two most common TernaryStateMenuItems 2021-05-20 19:34:53 +09:00
smoogipoo
a74405d0ed Merge branch 'master' into restructure-spectator-client 2021-05-20 18:53:42 +09:00
smoogipoo
9d07749959 Improve implementation of TestSpectatorClient
There was a lot of weirdness here, such as storing the playing users,
clearing the playing users from test scenes (!!), and storing the users
being wathed.
This was all a thing because the previous implementation overrode the
base method implementations, which is no longer a thing.
2021-05-20 17:41:46 +09:00
Dean Herbert
fdbd421040 Fix editor tests failing due to empty files being specified 2021-05-20 17:09:55 +09:00
Gagah Pangeran Rosfatiputra
1109970278
add more test for Wiki Header 2021-05-20 14:24:28 +07:00
smoogipoo
6beeb7f7c4 Rename SpectatorStreamingClient -> SpectatorClient 2021-05-20 15:55:07 +09:00
smoogipoo
d197a7f6f5 Rename multiplayer client classes 2021-05-20 15:39:45 +09:00
Dean Herbert
80a714a9c4
Merge pull request #12857 from Joehuu/dev-register-no-warning
Don't show warning screen when registering on dev server
2021-05-20 14:05:53 +09:00
Dean Herbert
f1fd40dcca Fix test not working for various reasons 2021-05-20 13:19:00 +09:00
Joseph Madamba
85a3027f1b Add failing test 2021-05-19 13:58:41 -07:00
Salman Ahmed
97c8499884 Add test coverage 2021-05-19 23:01:41 +03:00
Salman Ahmed
71da960000 Extract assert step addition out of assertion method 2021-05-19 22:53:22 +03:00
Salman Ahmed
21ca9c8431 Merge branch 'master' into beatmap-skin 2021-05-19 22:39:32 +03:00
Salman Ahmed
6fc06a10a1 Add extensible test scene for beatmap skins fallback instead 2021-05-19 21:52:29 +03:00
Dean Herbert
363aec8179 Merge branch 'master' into hit-error-skinnable 2021-05-20 01:51:45 +09:00
Dean Herbert
b33d5e7a7a Add new test and assertions to existing DialogOverlay test 2021-05-19 17:04:45 +09:00
Vinicius Barbosa
4f397ae7f5
Merge branch 'master' into applause-stops-on-score-switch 2021-05-19 09:52:31 +02:00
Andrei Zavatski
24af86689f Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-18 22:18:52 +03:00
Vinicius Barbosa
d05ffdf120 Added constants for delay value 2021-05-18 20:19:18 +02:00
Salman Ahmed
d1272d5e13 Group all skinnable test scenes to one TestSceneSkinnableHUDComponents 2021-05-18 12:38:06 +03:00
Dean Herbert
c885ad87d5 Update HitErrorDisplay tests 2021-05-18 15:12:29 +09:00
Dean Herbert
06389c08dc Add basic test to show data how one would expect it to be displayed 2021-05-18 13:11:22 +09:00
Bartłomiej Dach
400984457c Fix weird behaviour in test scene
Due to a callback set up in another place, clicking away from the 2022
year after launching the test scene would remove the 2022 button
(because the callback was returning metadata without it). For simplicity
just trim the 2022 year to make sure both test scenes use the same
consistent set of years.
2021-05-17 19:16:30 +02:00
Lucas A
ed4c025c7e Fix other tests and move TestPlaySongSelect class declaration. 2021-05-17 12:55:59 +02:00
Lucas A
fe11426238 Disable appearance of the stable import prompt waiting for user interaction in tests, which caused them to fail. 2021-05-17 12:55:59 +02:00
Dean Herbert
da0913ca2d Make SongProgress a skinnable component 2021-05-17 18:52:56 +09:00
Andrei Zavatski
fc6e65b7db
Delete TestSceneNewsSideBar.cs 2021-05-17 12:02:06 +03:00
Andrei Zavatski
01090de1fd Fix filenames does not match contained type 2021-05-17 11:55:55 +03:00
Andrei Zavatski
586c5c7365 Emulate year changes in the test scene 2021-05-17 11:36:53 +03:00
Dean Herbert
ae1e62288d Reorder tests to not have the first test show nothing 2021-05-17 16:16:50 +09:00
Dean Herbert
22561cda19 MonthDropdown -> MonthSection 2021-05-17 16:02:21 +09:00
Dean Herbert
50e2b5a327 SideBar -> Sidebar 2021-05-17 16:00:36 +09:00
Swords
264d8b9b86 Finishing requested changes, and tidy up 2021-05-16 14:48:00 +10:00
Andrei Zavatski
881d82ccb6 Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-15 19:08:48 +03:00
Swords
b5e1f78c06
Merge branch 'master' into single-bind-reset-button 2021-05-15 20:29:56 +10:00
Swords
c282f0e603 Fixing tests
For some reason moving the mouse and clicking doesn't work with "dotnet test", but works when you run the osu.Game.Tests project.
2021-05-15 19:42:33 +10:00
Dean Herbert
dc56250a3c
Merge branch 'master' into player-loader-star-rating 2021-05-15 15:39:57 +09:00
Dean Herbert
94b7e89ac0
Merge pull request #12747 from frenzibyte/current-star-rating
Allow changing current star difficulty of a `StarRatingDisplay`
2021-05-15 15:39:39 +09:00
Swords
ecc260030a
Merge branch 'master' into single-bind-reset-button 2021-05-15 12:05:42 +10:00
Swords
304caf8bdf Adding Requested changed 2021-05-15 11:24:08 +10:00
Bartłomiej Dach
7665bdfbbb Merge branch 'master' into null-assignment-warning-enable 2021-05-15 01:08:34 +02:00
Bartłomiej Dach
d581e0a252 Ignore possible nulls in NotifyCollectionChangedArgs
Safe to access by the virtue of the preceding case labels on
`args.Action`.  And they're in test code anyways.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
f2d0f7db99 Remove list null-checks in LogoTrackingContainer test
If the null-checks were tripped, the test would crash anyway. It is not
possible to call `.Any()` and get a valid result instead of an exception
on a null reference.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
1c92b3a8f5 De-duplicate star rating display creation in test 2021-05-14 22:03:44 +02:00
Swords
843da30f9d Reformatting 2021-05-15 01:52:16 +10:00
Swords
6a52622b3f Merge branch 'single-bind-reset-button' of https://github.com/holaswords/osu into single-bind-reset-button 2021-05-15 01:31:40 +10:00
Swords
1603b92211 Reformatting 2021-05-15 01:30:54 +10:00
Swords
85174793b1
Merge branch 'master' into single-bind-reset-button 2021-05-15 01:07:32 +10:00
Swords
0725088fde Well it works, just pretty ugly looking. 2021-05-15 01:01:17 +10:00
Salman Ahmed
93007c1635 Merge branch 'current-star-rating' into player-loader-star-rating 2021-05-14 16:06:00 +03:00
Salman Ahmed
6cc678f497 Remove nullability and transition support from star rating display 2021-05-14 16:05:40 +03:00
Salman Ahmed
db361efecf Add test beatmap difficulty cache with calc. blocking support 2021-05-14 15:53:56 +03:00
Salman Ahmed
34aab11ff3 Add null star rating display test case 2021-05-14 14:25:46 +03:00
Salman Ahmed
0655825057 Separate changing star rating display to own test 2021-05-14 14:25:13 +03:00
Dean Herbert
48672f8afd Add very basic test logic to ensure PlayerLoader is present for playlists 2021-05-14 15:02:36 +09:00
Andrei Zavatski
94543bf000 Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-13 16:00:46 +03:00
Dan Balasescu
d5b14b6b99
Merge branch 'master' into remove-skinnable-hud-classes 2021-05-13 21:06:48 +09:00
Dan Balasescu
746862dcb1
Merge pull request #12750 from peppy/skin-serialisation
Add skin editor saving / loading support
2021-05-13 20:58:03 +09:00
Dan Balasescu
a3869c02f4
Merge branch 'master' into fix-two-hovered-handles 2021-05-13 19:24:42 +09:00
Dean Herbert
c8b7cfc753 Merge branch 'skin-serialisation' into remove-skinnable-hud-classes 2021-05-13 19:05:08 +09:00
Dean Herbert
e0e9106921 Enable autoplay in skin editor tests 2021-05-13 14:55:11 +09:00
Dean Herbert
8b9ac86d4b Merge branch 'master' into skin-serialisation 2021-05-13 12:35:06 +09:00
smoogipoo
5b03092968 Fix possible test failure 2021-05-13 11:53:50 +09:00
Andrei Zavatski
13a956f6fc Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-12 20:08:17 +03:00
Dean Herbert
55e1f97f59 Remove unused using statement 2021-05-12 19:06:40 +09:00
Dean Herbert
0a895fff15 Remove remaining test usage of SkinnableXXX HUD components 2021-05-12 18:53:25 +09:00
Salman Ahmed
80e231d90a Add failing test case 2021-05-12 11:42:55 +03:00
Dean Herbert
c6f0a6aed3
Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen
Implement the multiplayer spectator screen
2021-05-12 17:24:35 +09:00
smoogipoo
273cd18b8a Use test streaming client in gameplay leaderboard test 2021-05-12 14:19:36 +09:00
smoogipoo
21fc0ba43b Combine test spectator streaming client implementations 2021-05-12 13:05:02 +09:00
Andrei Zavatski
085c3d067f Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-11 23:41:45 +03:00
Andrei Zavatski
b0297c6324 Fix incorrect no posts handling and add corresponding test 2021-05-11 20:52:11 +03:00
Andrei Zavatski
822d99e69f Remove pointless test scenes 2021-05-11 20:42:13 +03:00
Dean Herbert
048677846b Change HealthDisplay to be a CompositeDrawable 2021-05-11 23:10:30 +09:00
Andrei Zavatski
b79a0237a3 Fix TestSceneNewsYearsPanel error 2021-05-11 16:54:19 +03:00
Andrei Zavatski
c2ba16f977 Use relative sizing for MonthDropdown 2021-05-11 16:51:59 +03:00
Andrei Zavatski
208224cc0d CI fixes 2021-05-11 16:08:09 +03:00
Andrei Zavatski
705aad262a Rename MonthPanel to MonthDropdown 2021-05-11 15:42:40 +03:00
Andrei Zavatski
0a9c3c9413 Move metadata change logic to it's own method 2021-05-11 15:39:50 +03:00
Andrei Zavatski
9603712aa1 Cache metadata in NewsSideBar 2021-05-11 15:33:27 +03:00
Andrei Zavatski
82436334b2 Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-11 13:52:51 +03:00
smoogipoo
f5bc389998 Fix flaky tests 2021-05-11 19:31:32 +09:00
smoogipoo
bc4213eea1 Add test for changing back to idle on deletion 2021-05-11 19:26:58 +09:00
smoogipoo
7fe8737d94 Add failing tests 2021-05-11 19:21:44 +09:00
smoogipoo
811282a975 Add failing test 2021-05-11 19:01:41 +09:00
Dean Herbert
61ea3f2e64 Remove unnecessary test step creating needless skins 2021-05-11 18:39:15 +09:00
Dean Herbert
2396ba42a6 Change HealthDisplay to be a CompositeDrawable 2021-05-11 18:39:14 +09:00
Dean Herbert
004798d61d Update Legacy components to not require skin in ctor 2021-05-11 18:39:14 +09:00
smoogipoo
10a4a5decb Merge branch 'master' into multiplayer-spectator-screen 2021-05-11 17:33:09 +09:00
Dan Balasescu
7d9cdd3bc2
Merge branch 'master' into skin-components-list 2021-05-11 17:27:48 +09:00
Salman Ahmed
004ce95f33 Merge branch 'current-star-rating' into player-loader-star-rating 2021-05-11 09:53:10 +03:00
Dean Herbert
6bb52ebcf8
Merge pull request #12570 from frenzibyte/corner-rotation-controls
Add rotation controls to editor selection box corners
2021-05-10 23:09:44 +09:00
Andrei Zavatski
220eef0351 Remove overcomplicated date logic in MonthPanel 2021-05-10 17:00:18 +03:00
Andrei Zavatski
fbf8b198cd Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-10 16:47:15 +03:00
Dan Balasescu
e7355da201
Merge branch 'master' into osu-markdown 2021-05-10 20:02:04 +09:00
Dean Herbert
2ecd638f7f Merge branch 'master' into skin-components-list 2021-05-10 18:13:10 +09:00
Andrei Zavatski
0d243be457 CI fixes 2021-05-10 10:07:43 +03:00
Andrei Zavatski
4b97224932 Implement NewsSideBar component 2021-05-10 09:53:52 +03:00
Dean Herbert
97e72849af Fix regressed HitErrorDisplay behaviour (and localise binding to meter implementations) 2021-05-10 15:24:13 +09:00
Salman Ahmed
ca772b60b1 Use regular test steps rather than one-time set up and scheduling 2021-05-10 08:56:30 +03:00
Salman Ahmed
301dab1ce8 Refactor StarRatingDisplay to be mutable with a current bindable 2021-05-10 08:56:30 +03:00
Andrei Zavatski
7971a2ef48 Implement MonthPanel component 2021-05-10 08:47:00 +03:00
Andrei Zavatski
7ca3e13712 Implement basic years panel 2021-05-10 07:43:01 +03:00
Dean Herbert
52ce16f9f1
Merge branch 'master' into player-loader-star-rating 2021-05-10 12:46:10 +09:00
Dean Herbert
9ba412d27e Add the osu! logo to the test scene
Makes no sense to add a test intended to test visual behaviour with one
of the main elements missing. Not sure how you would be able to test the
flow with the logo's presence.
2021-05-10 12:44:08 +09:00
Dean Herbert
b7acf9de52 Make test work without manually clicking things 2021-05-10 12:36:56 +09:00
Dean Herbert
2b90bc4f1f Remove unnecessary ruleset switching steps 2021-05-10 12:35:37 +09:00
Dean Herbert
0c973feb53 Tidy up test scene 2021-05-10 12:34:21 +09:00
Dean Herbert
3c3500d070 Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces 2021-05-10 12:23:18 +09:00
Dean Herbert
1d38fa29b5 Remove unused using statement 2021-05-10 12:23:04 +09:00
Dean Herbert
1bbbe80420 Fix missing instances of HealthProcessor caching 2021-05-10 12:22:24 +09:00
Dean Herbert
132bb7832d Fix some regressions when updating test scenes 2021-05-10 12:06:33 +09:00
Dean Herbert
b274fdf20d Merge branch 'master' into skin-components-bind-outwards-health 2021-05-10 11:13:44 +09:00
Joseph Madamba
8964d51de9 Add ability to sort by source in song select 2021-05-09 14:10:38 -07:00
Dean Herbert
2bcf1ed306
Merge pull request #12715 from Cublibre/fix-early-exit-crash
Fix InvalidOperationException when exiting a map at the end
2021-05-09 23:21:19 +09:00
Bartłomiej Dach
eb716455b7
Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-09 12:13:18 +02:00
Andrei Zavatski
879c08e666 Use UntilStep instead of Assert to check button visibility 2021-05-09 10:06:36 +03:00
Andrei Zavatski
f0c1784d05 Use FirstOrDefault instead of First 2021-05-09 09:12:37 +03:00
Swords
1a465c60ca Rename Tests 2021-05-09 16:07:18 +10:00
Ibby
075350e125 Adding a reset button to individual keybinds 2021-05-09 15:51:17 +10:00
Andrei Zavatski
8868439ce4 Another approach to fix test scene failure 2021-05-09 06:49:12 +03:00
Andrei Zavatski
0818deac17 Fix potential test scene failure due to showMoreButton not being loaded in time 2021-05-09 06:06:34 +03:00
Christine Chen
ae2b5a0806 Actually test that player was exited 2021-05-08 22:42:14 -04:00
Andrei Zavatski
342c5a5938 Add tests to indicate the issue 2021-05-09 04:49:40 +03:00
Salman Ahmed
8fba655d2e Allow changing ruleset during test 2021-05-08 23:02:38 +03:00
Bartłomiej Dach
efb9164658 Restore previous test scene logic 2021-05-08 21:35:12 +02:00
Bartłomiej Dach
0bc6a026eb
Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-08 21:08:53 +02:00
Salman Ahmed
f701c331f2 Add initial fade in to the metadata display
Avoids first frame discrepancies from appearing in the test scene, those can be delt with later on, if needed.
2021-05-08 21:19:46 +03:00
Bartłomiej Dach
dec5400c0a
Merge branch 'master' into skin-components-bind-outwards-score-display 2021-05-08 19:58:19 +02:00
Bartłomiej Dach
9e0ea494fd
Merge branch 'master' into skin-components-bind-outwards 2021-05-08 19:04:56 +02:00
Christine Chen
25312b3e88 Don't restart completion delegate on exit, revert exit behavior to lazer 2021-05-08 11:47:44 -04:00
Salman Ahmed
ca55287dd0 Pass empty facade and replace random property with method instead 2021-05-08 18:43:45 +03:00
Salman Ahmed
3575d9847c Use regular test steps rather than one-time set up and scheduling 2021-05-08 18:21:29 +03:00
Salman Ahmed
d9605e8070 Remove test scene description 2021-05-08 18:18:23 +03:00
Salman Ahmed
26c0010fe6 Fix test not handling 0 beatmap sets 2021-05-08 13:03:50 +03:00
Salman Ahmed
dca5efc59a Remove no longer necessary ruleset info requirement 2021-05-08 13:00:39 +03:00
Salman Ahmed
0410edecaf Refactor StarRatingDisplay to be mutable with a current bindable 2021-05-08 12:55:34 +03:00
Salman Ahmed
b4801faf32 Pass ruleset info to constructor instead
Follows the way working beatmap is passed, not sure why mods are passed as a bindable though, don't wanna bother too much with that.
2021-05-08 11:57:13 +03:00
Salman Ahmed
169a283402 Add visual test scene 2021-05-08 11:47:18 +03:00
Christine Chen
8c564a69ed Fix InvalidOperationException when exiting a map at the end 2021-05-07 21:11:03 -04:00
Dean Herbert
1cb10c2a22 Remove unnecessary binding logic from HUDOverlay 2021-05-07 17:51:46 +09:00
Dean Herbert
a7acecc52b Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces 2021-05-07 17:51:41 +09:00
Dean Herbert
3044b1c432 Add missing cache rules 2021-05-07 17:50:44 +09:00
Dean Herbert
6c255a0572 Fix drain start time being weirdly incorrect 2021-05-07 17:47:33 +09:00
Dean Herbert
8e78cac058 Fix HealthProcessor cached as derived type in test 2021-05-07 17:31:29 +09:00
Dean Herbert
04d35826a3 Merge branch 'skin-components-bind-outwards-accuracy' into remove-hud-overlay-unused-pieces 2021-05-07 17:25:39 +09:00
Dean Herbert
84a4ff333e Update skin editor test scene to cache a ScoreProcessor 2021-05-07 17:22:56 +09:00
Dean Herbert
755588258e Update HealthDisplay components to use DI to attach data source 2021-05-07 17:22:45 +09:00
Dean Herbert
4ac234bf7f Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy 2021-05-07 17:15:57 +09:00
Dean Herbert
6dc591fc44 Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display 2021-05-07 17:15:37 +09:00
Dean Herbert
9d27b11e49 Update skin editor test scene to cache a ScoreProcessor 2021-05-07 17:10:31 +09:00
Dean Herbert
01eff7f316 Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display 2021-05-07 16:30:08 +09:00
Dean Herbert
93f10330e3 Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy 2021-05-07 16:29:10 +09:00
Dean Herbert
ad398165a2 Update AccuracyCounter components to use DI to attach data source 2021-05-07 16:27:25 +09:00
Dean Herbert
17b93361d5
Merge branch 'master' into skin-components-bind-outwards 2021-05-07 16:20:24 +09:00
Dean Herbert
a2e4fb5b6b Update ScoreCounter components to bind outwards 2021-05-07 16:16:48 +09:00
Dean Herbert
165f443ab5 Merge branch 'master' into add-missing-author-links 2021-05-07 14:32:44 +09:00
Dean Herbert
48b834d12a Merge branch 'master' into mbd-beatmap-set-cover 2021-05-07 13:19:17 +09:00
Gagah Pangeran Rosfatiputra
67f51959db
Merge branch 'master' into osu-markdown 2021-05-06 16:23:20 +07:00
Gagah Pangeran Rosfatiputra
91283d41ce
add paragraph test 2021-05-06 15:13:43 +07:00
Dean Herbert
aff32b0d19 Merge branch 'master' into skin-components-list 2021-05-06 14:17:33 +09:00
Bartłomiej Dach
3cac837acf
Merge branch 'master' into skin-bindables 2021-05-05 20:16:27 +02:00
Dean Herbert
cb8bda2248
Merge pull request #12503 from Denrage/split-BufferedWedgeInfo 2021-05-06 03:16:16 +09:00
Dean Herbert
fe9ade6754 Rename Container to DisplayedContent 2021-05-06 02:14:04 +09:00
Denrage
b6b9a69601 Removed unnecessary class for wrapping 2021-05-05 18:50:49 +02:00
Dean Herbert
4ef901d08d Remove unnecessary redirection property to Container.Info 2021-05-05 21:07:49 +09:00
Dean Herbert
805ef621e9
Merge branch 'master' into play-storyboard-outro 2021-05-05 17:51:16 +09:00
Dean Herbert
3cc9bad979 Actually check for correct state of fade content in rewind test 2021-05-05 17:49:33 +09:00
Christine Chen
1d4a8bc0ae Add visual test for rewinding 2021-05-04 22:23:36 -04:00
Salman Ahmed
12c1ded7a8 Fix test scene broken on master 2021-05-05 00:28:49 +03:00
Salman Ahmed
1ac80d42f9
Merge branch 'master' into corner-rotation-controls 2021-05-04 23:53:23 +03:00
Bartłomiej Dach
2fd596d53c Merge branch 'master' into mbd-beatmap-set-cover 2021-05-04 21:14:48 +02:00
Bartłomiej Dach
040d393dd4 Add visual test case for crossfade behaviour 2021-05-04 21:12:25 +02:00
Dean Herbert
bb9fa1a25e
Merge branch 'master' into play-storyboard-outro 2021-05-04 14:01:34 +09:00
Salman Ahmed
8abff4881b Hide the corresponding rotation handle when holding scale handle 2021-05-04 07:31:55 +03:00
Dean Herbert
4f12ae2711 Merge branch 'master' into split-BufferedWedgeInfo 2021-05-04 13:28:42 +09:00
Gagah Pangeran Rosfatiputra
356b1e9a2d
add emphases test 2021-05-04 05:43:59 +07:00
Bartłomiej Dach
f52375eed2 Merge branch 'master' into mbd-beatmap-set-cover 2021-05-03 15:58:13 +02:00
Bartłomiej Dach
b9220d4dc7 Fix possible multiple enumeration 2021-05-03 15:57:57 +02:00
Dean Herbert
4f8240f19a
Merge branch 'master' into corner-rotation-controls 2021-05-03 18:02:23 +09:00
Dean Herbert
625890381f Update ComboCounter components to use DI to attach data source 2021-05-03 17:43:00 +09:00
Dean Herbert
fdd0713988 Merge branch 'fix-selection-handler-visibility' into skin-bindables 2021-05-03 17:40:03 +09:00
Dean Herbert
3268a75f05 Remove intermediate container to fix tests 2021-05-03 17:35:56 +09:00
Dean Herbert
6da4105da6 Remove Sync namespace (feels unnecessary) 2021-05-03 13:38:53 +09:00
Dean Herbert
e0c129ca85 Merge branch 'master' into multiplayer-spectator-screen 2021-05-03 13:08:14 +09:00
Gagah Pangeran Rosfatiputra
b97d3f2af1
add heading test scene 2021-05-03 09:35:26 +07:00
Gagah Pangeran Rosfatiputra
88aaa9b332
add inline code colour
Reference : 31579d45aa/resources/assets/less/bem/osu-md.less (L12-L17)
2021-05-02 22:35:30 +07:00
Gagah Pangeran Rosfatiputra
6585dd3a3e
add image test 2021-05-23 16:30:41 +07:00
Gagah Pangeran Rosfatiputra
8f1b48d766
add test for notice box 2021-05-23 17:29:48 +07:00
Gagah Pangeran Rosfatiputra
5c1c43dea3
add link assert 2021-05-25 10:44:22 +07:00
Gagah Pangeran Rosfatiputra
98af998978
add test markdown class 2021-05-25 09:56:26 +07:00
Gagah Pangeran Rosfatiputra
a38c33841a
add test scene wiki container 2021-05-23 16:30:41 +07:00
Dean Herbert
a1e64f4e3c Use the existing toolbox design 2021-04-30 14:41:06 +09:00
Gagah Pangeran Rosfatiputra
3681db491c
add long mixed list test
Copied from https://github.com/ppy/osu-wiki/blob/master/wiki/Tournaments/OWC/2020/en.md#tournament-rules
2021-04-30 11:21:20 +07:00
Dean Herbert
ae9d1dc40b Add component list to main editor interface and enable basic placement 2021-04-30 13:10:42 +09:00
Dean Herbert
6442fb819f Split out component from test scene and fix SongProgress 2021-04-30 13:10:42 +09:00
Dean Herbert
4770a64709 Add proof of concept components list 2021-04-30 13:10:42 +09:00
Gagah Pangeran Rosfatiputra
1582b0da88
add ordered list test 2021-04-30 10:43:19 +07:00
Dean Herbert
eeb66a955e
Merge branch 'master' into mbd-beatmap-set-cover 2021-04-30 08:14:33 +09:00
Dean Herbert
de73ac7cec Allow skin editor to be invoked from any context
This is kind of how I see things working going forward, where the editor
can be applied to anything in the game which supports it (ie. a results
screen, gameplay screen, etc.) and it will immediately allow changing
the interface.

This adds a test scene which shows this working with gameplay.
2021-04-29 16:12:15 +09:00
Dean Herbert
74c6fdc4b8 Add DrawableRuleset to the skin editor test to get a hit error meter to display 2021-04-29 16:12:15 +09:00
Dean Herbert
fd587a82ff Replace abstract class with interface, attached to the actual components (not skinnable wrapper) 2021-04-29 16:12:15 +09:00
Dean Herbert
defa350aa7 Set defaults on SkinnableHUDComponent to cancel out relative size default
Specifying locally on each HUD component looks to make more sense.
2021-04-29 16:12:15 +09:00
Dean Herbert
1cb8fc9a24 Extract editor classes out of test namespace and add anchor support 2021-04-29 16:12:15 +09:00
Dean Herbert
74fb7cd180 Extract storable attributes to bindables 2021-04-29 16:12:15 +09:00
Dean Herbert
99b428ee4b Add very basic skin editor test 2021-04-29 16:12:14 +09:00
Dean Herbert
fca173225a Refactor editor selection/blueprint components to be generic 2021-04-29 16:12:14 +09:00
Dean Herbert
2d17219c8f Setup basic test and classes for scale adjustment 2021-04-29 16:12:14 +09:00
Dean Herbert
5b009c21bb Merge branch 'master' into abstract-blueprint-handling 2021-04-29 16:10:22 +09:00
Gagah Pangeran Rosfatiputra
171e954e89
add unordered list test 2021-04-29 13:48:00 +07:00
Dean Herbert
ac1534cda2 Add test covering existing button actually changing to LocallyAvailable state 2021-04-28 15:54:40 +09:00
Gagah Pangeran Rosfatiputra
4e691ce4b0
add test link with inline text markdown 2021-04-28 11:01:54 +07:00
Gagah Pangeran Rosfatiputra
c09067c3d5
add OsuMarkdownTable 2021-04-28 10:53:12 +07:00
Gagah Pangeran Rosfatiputra
736eace00a
add OsuMarkdownQuoteBlock
Reference:
d56352aeef/resources/assets/less/base.less (L7-L10)
2021-04-28 10:11:29 +07:00
Gagah Pangeran Rosfatiputra
6a921af085
add OsuMarkdownSeparator
Reference
d56352aeef/resources/assets/less/bem/osu-md.less (L19-L21)
2021-04-28 09:23:05 +07:00
Dean Herbert
f2e56bd306 Refactor editor selection/blueprint components to be generic 2021-04-27 19:01:29 +09:00
Gagah Pangeran Rosfatiputra
6959f2a8cc
add OsuMarkdownFencedCodeBlock
Reference :
d56352aeef/resources/assets/less/bem/osu-md.less (L41-L45)
2021-04-27 16:01:32 +07:00
Gagah Pangeran Rosfatiputra
65aa01866e
add test scene for OsuMarkdownContainer 2021-04-27 14:38:21 +07:00
Dean Herbert
5f6fd9ba13 Remove outdated dependency requirement in test 2021-04-26 19:07:42 +09:00
smoogipoo
94d0b06493 Expose mute adjustment instead 2021-04-26 19:01:30 +09:00
Dean Herbert
120fb8974d Combine more instances of test player IDs 2021-04-26 17:22:16 +09:00
Dean Herbert
737a15c2d4 Extract out test player IDs to constants 2021-04-26 17:04:39 +09:00
Dean Herbert
55f383c71e Rename test to match new MultiSpectatorLeaderboard class name 2021-04-26 16:48:40 +09:00
Dean Herbert
6d30a1a80f Reference constant for test startup delay 2021-04-26 16:45:20 +09:00
Salman Ahmed
beee318acc Add more distance between each hit object in editor selection test
To avoid potentially hovering over the rotation control instead of wherever the test desired to move the mouse to.
2021-04-26 01:45:52 +03:00
Salman Ahmed
334927ed35 Remove leftover step 2021-04-25 20:13:01 +03:00
Salman Ahmed
7490511ebf Instantiate selection box on SetUp 2021-04-25 20:03:15 +03:00
Salman Ahmed
11318fd9fc Add test coverage 2021-04-25 10:17:36 +03:00
Dean Herbert
c0b1c2f39b
Merge branch 'master' into realm-key-binding-store 2021-04-24 02:40:15 +09:00
smoogipoo
b41897fd9b Rename testscene to match class 2021-04-23 19:23:52 +09:00
smoogipoo
b25340653d Fix failing tests 2021-04-23 00:49:14 +09:00
smoogipoo
4f0857f946 Xmldocs and general refactorings 2021-04-22 23:52:22 +09:00
smoogipoo
ee25949751 Rename classes 2021-04-22 23:39:02 +09:00
smoogipoo
f8f9cf9412 Merge branch 'fix-initial-playingusers' into multiplayer-spectator-screen 2021-04-22 23:25:25 +09:00
smoogipoo
64579d50ac Use only single PlayerInstance for hit sample playback 2021-04-22 22:59:47 +09:00
Dan Balasescu
be8fe47f2c
Merge branch 'master' into editor-add-nudge-shortcuts 2021-04-22 20:38:34 +09:00
smoogipoo
6df23f1301 Merge branch 'master' into multiplayer-spectator-screen 2021-04-22 20:29:24 +09:00
Dan Balasescu
b774f5b72b
Merge pull request #12526 from peppy/fix-system-message-ordering
Fix system messages always being displayed above standard messages
2021-04-22 18:51:25 +09:00
Dan Balasescu
0e24f2eb59
Merge pull request #12529 from peppy/editor-placement-right-click-delete
Allow shift+right-click deletion when in placement mode
2021-04-22 18:50:20 +09:00
Dean Herbert
a5364b224f Add simple key based time nudging support to editor 2021-04-22 18:47:04 +09:00
Dean Herbert
daafa41dc1
Merge branch 'master' into fix-initial-spectator-state-callback 2021-04-22 16:22:04 +09:00
Dean Herbert
cf1e3ea988 Add failing test covering quick shift-rightclick deletion in placement mode 2021-04-22 15:44:12 +09:00
Dean Herbert
ea3bb07924 Add test that fails on incorrect system/info message ordering 2021-04-22 14:51:14 +09:00
Dean Herbert
78f274d51a Merge branch 'master' into realm-key-binding-store 2021-04-22 12:13:23 +09:00
smoogipoo
2bea625613 Fix initial playback states not being correct 2021-04-21 23:22:11 +09:00
Denrage
0dfd0bb59d Refactored background of BeatmapInfoWedge 2021-04-21 15:46:11 +02:00
Denrage
9fba87f67a Moved Info and Background into own container 2021-04-21 15:43:29 +02:00
Gagah Pangeran Rosfatiputra
416e08ae7a
add dummy response API in TestSceneWikiOverlay
`TestSceneNewsOverlay` is used as example for this test.
2021-04-21 17:25:13 +07:00
smoogipoo
e78ef05fcf Merge branch 'gcc-abstraction' into multiplayer-spectator-screen 2021-04-21 17:11:14 +09:00
smoogipoo
31c5fb350f Merge branch 'master' into gcc-abstraction 2021-04-21 16:33:36 +09:00
Bartłomiej Dach
881043bc5d Fix failing test after mod settings layout changes
The slight hack which was used in the test to ensure that the mod
settings overlay covered the entire width of the mod overlay broke after
adjustments to the layout in the previous commit.

Locally adjust the hack to use the parent of the `ModSettingsContainer`
rather than the container itself.
2021-04-20 19:38:25 +02:00
smoogipoo
156a518068 Merge branch 'master' into fix-initial-spectator-state-callback 2021-04-20 21:16:05 +09:00
smoogipoo
c5d6b6ea8d Fix tests failing intermittently
This was due to this code happening in UpdateAfterChildren(), after the
GCC has processed one frame. During this time, the clock could have
advanced an arbitrary amount.

The cause of this is the removal of the Task.Run() to set the clock in
Restart() (now called Reset()) which changed the timing, so it only worked before due to pure
luck.
2021-04-20 18:41:09 +09:00
Gagah Pangeran Rosfatiputra
460d656a0e
initial wiki overlay 2021-04-21 16:21:07 +07:00
Denrage
505a117862 splitted updateable part of wedge 2021-04-20 10:37:52 +02:00
smoogipoo
80473a356e Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction 2021-04-20 17:27:01 +09:00
Denrage
c73bbf0aa7 Fixed Tests 2021-04-19 19:24:58 +02:00
Bartłomiej Dach
97573fb11d Merge branch 'master' into combo-colours-display 2021-04-19 18:21:57 +02:00
Dean Herbert
fc41ad65f8
Merge pull request #12447 from smoogipoo/fix-non-60fps-recording
Record every 60fps interval
2021-04-19 23:26:58 +09:00
Gagah Pangeran Rosfatiputra
5117c51105
initial wiki header 2021-04-19 16:24:47 +07:00
smoogipoo
c12848ce4d Apply fixes to tests 2021-04-19 17:02:59 +09:00
smoogipoo
5397f4faba Merge branch 'master' into fix-initial-spectator-state-callback 2021-04-19 16:49:06 +09:00
jvyden
a854ce429a
add blank line between method 2021-04-18 23:49:13 -04:00
jvyden
999f2d810c
Fix accidentally removed code 2021-04-18 23:30:07 -04:00
Christine Chen
fd1241cc85 Added tests
New tests:
- storyboard ending during the failing animation
- showResults = false
- storyboard ending before score processor completion

Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-18 23:26:50 -04:00
jvyden
e44d11667c
Merge remote-tracking branch 'upstream' 2021-04-18 23:04:35 -04:00
jvyden
b727faace3
Revert changes to IdleTracker 2021-04-18 23:03:43 -04:00
Christine Chen
98460c8feb Rename IStoryboardElementHasDuration, remove unnecessary step in tests, add Duration field 2021-04-18 20:20:14 -04:00
Bartłomiej Dach
577755ee19 Add placeholder when no colours are visible
Will be removed once combo colours are mutable.
2021-04-18 20:46:42 +02:00
Bartłomiej Dach
0cd1aa8c1c Add support for custom colour prefixes 2021-04-18 20:44:55 +02:00
Bartłomiej Dach
67c19df000 Add test coverage for adding/removing colours 2021-04-18 19:35:42 +02:00
Bartłomiej Dach
1b2c43b92c Add basic structure of colour palette 2021-04-18 19:29:04 +02:00
Dean Herbert
2678089e0b Add test case failing on selection after paste 2021-04-18 20:28:39 +09:00
Salman Ahmed
2847dd7e05 Merge branch 'master' into play-storyboard-outro 2021-04-18 06:40:22 +03:00
Christine Chen
7b1d40db7d Remove redundant string interpolation 2021-04-17 22:13:28 -04:00
Christine Chen
e9f8fa64b8 Added a test for toggling the storyboard after the map is loaded 2021-04-17 21:49:29 -04:00
Christine Chen
7f5b1e84a1 Update TestSceneStoryboardWithOutro.cs
- Construct storyboard in CreateWorkingBeatmap()
- Use GameplayClockContainer.GameplayClock.CurrentTime
- Remove unnecessary lines
2021-04-17 13:57:32 -04:00
jvyden
1e56f14f5b
Merge remote-tracking branch 'upstream' 2021-04-17 09:35:24 -04:00
Bartłomiej Dach
f3ea51eeed Adjust tests to not rely on invalid assumption 2021-04-17 14:23:32 +02:00
smoogipoo
d5b26b0ab5 Fix incorrect test spectator client implementation 2021-04-16 23:01:34 +09:00
smoogipoo
a7aa3cb263 Merge branch 'gcc-abstraction' into multiplayer-spectator-screen 2021-04-16 20:16:26 +09:00
smoogipoo
5e82f40d67 Merge branch 'master' into gcc-abstraction 2021-04-16 20:14:53 +09:00
jvyden
8d6c30c73b
Fix lint 2021-04-16 05:57:36 -04:00
jvyden
ec0211809f
Apply peppy's suggestions 2021-04-16 05:53:27 -04:00
smoogipoo
65a6f9f8a4 Merge branch 'fix-initial-spectator-state-callback' into multiplayer-spectator-screen 2021-04-16 18:26:46 +09:00
jvyden
d760e81a91
Fix lint 2021-04-16 05:22:41 -04:00
smoogipoo
46d2181d42 Remove now unnecessary (duplicating) test 2021-04-16 18:21:56 +09:00
smoogipoo
377e5ce6b3 Fix test incorrect sending state too often 2021-04-16 18:21:35 +09:00
jvyden
471b8e3c74
Merge branch 'master' of https://github.com/ppy/osu 2021-04-16 05:02:40 -04:00
jvyden
7d23973ef8
Reset SessionStatics on activity
Closes #12424
2021-04-16 05:01:58 -04:00
smoogipoo
ca74f413cd Change to explicit method instead 2021-04-16 17:31:02 +09:00
smoogipoo
25f0f17766 Attempt to fix match subscreen test failure 2021-04-16 16:16:28 +09:00
smoogipoo
5652490d61 Fix OnUserBeganPlaying not being invoked if already watching 2021-04-16 14:11:55 +09:00
Christine Chen
b15838b220 Move storyboard outro logic to DrawableStoryboard 2021-04-16 00:59:10 -04:00
smoogipoo
5ac0eb02cd Always add player instances at first, populate later 2021-04-16 12:25:29 +09:00
Christine Chen
45c2b72a25
Merge branch 'master' into play-storyboard-outro 2021-04-15 15:11:35 -04:00
Christine Chen
25b8c2f257 Allow skipping storyboard outro
Reuses SkipOverlay by calculating the endtime of the storyboard and using that as a "start point". Upon skipping the outro the score is instantly shown.
When the end of the storyboard is reached the score screen automatically shows up. If the player holds ESC (pause) during the outro, the score is displayed

The storyboard endtime is calculated by getting the latest endtime of the storyboard's elements, or simply returning 0 if there is no storyboard.

Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-15 13:20:40 -04:00
Dean Herbert
7cf15fe729
Merge pull request #12412 from peppy/timeline-adjustments
Update timeline control point display
2021-04-15 22:43:26 +09:00
Dan Balasescu
ac8e462d32
Merge branch 'master' into refactor-framed-replay-input-hander 2021-04-15 21:48:58 +09:00
Dean Herbert
ad671ee07a
Merge branch 'master' into timeline-adjustments 2021-04-15 20:42:38 +09:00
Dan Balasescu
6f17c19a48
Merge branch 'master' into summary-timeline-design-refactors 2021-04-15 20:11:39 +09:00
Dean Herbert
5b06a68b93
Merge pull request #12330 from Cublibre/master
Send a warning notification if device is unplugged and at low battery
2021-04-15 19:21:04 +09:00
smoogipoo
1705d472b5 Reimplement multiplayer syncing using new master/slave clocks 2021-04-15 19:12:52 +09:00
Dean Herbert
18e8682f39 Remove unused using statements 2021-04-15 17:01:25 +09:00
Dean Herbert
dd9a142e89 Fix TestSceneEditorSummaryTimeline not displaying actual beatmap content 2021-04-15 16:39:20 +09:00
Dean Herbert
66bb5766b9 Make Mod.Description abstract and add missing descriptions 2021-04-15 16:39:20 +09:00
Dan Balasescu
a56391c6ca
Merge pull request #12418 from peppy/abstract-mod-description
Make `Mod.Description` abstract and add missing descriptions
2021-04-15 15:42:36 +09:00
Dean Herbert
346e36d32a Make Mod.Description abstract and add missing descriptions 2021-04-15 14:36:26 +09:00
Salman Ahmed
92fd34cea9 Revert "Inverse ignore user settings bindable to "apply user settings" instead"
This reverts commit 175b8da2b2.
2021-04-15 08:02:12 +03:00
Salman Ahmed
175b8da2b2 Inverse ignore user settings bindable to "apply user settings" instead 2021-04-15 07:34:20 +03:00
Salman Ahmed
7a9ff2ab38 Use until steps instead
Ah..
2021-04-15 00:48:25 +03:00
Salman Ahmed
505dc15e03 Add failing test case 2021-04-14 23:35:42 +03:00
Dean Herbert
9dea0ae935 Update test scene to be able to see a bit more 2021-04-14 21:03:52 +09:00
smoogipoo
54643f53e3 Merge branch 'gcc-abstraction' into multiplayer-spectator-screen 2021-04-14 19:56:58 +09:00
smoogipoo
1aa36818df Abstractify GameplayClockContainer 2021-04-14 17:47:11 +09:00
Dean Herbert
7654df94f6
Merge pull request #12395 from frenzibyte/fix-cinema-ignore-settings
Fix beatmap background displayed if storyboard is hidden on "Cinema" mod
2021-04-14 14:31:03 +09:00
smoogipoo
3039b7b0f9 Make tests a bit more resilient 2021-04-13 22:40:24 +09:00
smoogipoo
20823abb30 Make resyncing a bit more resilient 2021-04-13 22:10:35 +09:00
Dan Balasescu
1505a38164
Merge pull request #12396 from peppy/update-timeline-slider-apperance
Update timeline slider/spinner apperance
2021-04-13 20:47:44 +09:00
Dan Balasescu
b2aa46690d
Merge pull request #12389 from peppy/fix-editor-ctrl-drag-deselection
Fix ctrl-dragging on an existing selection unexpectedly causing deselection
2021-04-13 20:38:29 +09:00
smoogipoo
5b53a2b211 Merge branch 'master' into multiplayer-spectator-screen 2021-04-13 20:07:56 +09:00
Dean Herbert
00f235760d Update visual appearance of timeline blueprints to close match new designs 2021-04-13 19:26:20 +09:00
Dean Herbert
fca9c70c1b Move timeline hit object test to immediately viewable area 2021-04-13 19:26:20 +09:00
Dean Herbert
0cf13dab8d
Merge pull request #12391 from frenzibyte/replays-tooltip-graph
Display separate "replays watched" tooltip for replays subsection
2021-04-13 19:25:50 +09:00
Dean Herbert
2884ed3ab9
Merge pull request #12350 from smoogipoo/multiplayer-spectator-player-grid
Add the multiplayer spectator player grid
2021-04-13 19:25:32 +09:00
Dan Balasescu
a0513f64f9
Merge branch 'master' into replays-tooltip-graph 2021-04-13 18:21:10 +09:00
Salman Ahmed
15658eda55 Add failing test case 2021-04-13 12:00:13 +03:00
Salman Ahmed
36510309d1 Merge EnableUserDim and IgnoreUserSettings to one bindable 2021-04-13 10:58:56 +03:00
Dean Herbert
a9652b7b25 Start TimelineTestScene in a more visible place 2021-04-13 16:05:12 +09:00
ekrctb
38d10755cb Merge branch 'master' into refactor-framed-replay-input-hander 2021-04-13 13:47:22 +09:00
Dean Herbert
516bd138e3 Add (previously failing) test coverage of drag from selection 2021-04-13 13:46:38 +09:00
Dean Herbert
7c975359d9 Add basic select/deselect tests 2021-04-13 13:29:37 +09:00
Dean Herbert
05d7fe289f Rename test scene in preparation for increasing scope 2021-04-13 13:09:18 +09:00
Dean Herbert
66e74da2b7 Fix regression in quick delete mouse action blocking 2021-04-13 13:03:14 +09:00
Salman Ahmed
8f84abf348 Display "replays watched" tooltip for replays subsection 2021-04-12 21:51:06 +03:00
Christine Chen
f66306a81a Remove IsLowBattery 2021-04-12 11:15:24 -04:00
Christine Chen
43b97fe0ad Refactor PowerStatus (now called BatteryInfo) 2021-04-12 10:52:52 -04:00
smoogipoo
1e002841cf Add test for scoring mode changes 2021-04-12 22:03:45 +09:00
smoogipoo
c531e38a36 Rework to create a derived tracked user data instead 2021-04-12 22:00:27 +09:00
smoogipoo
27660265b5 Merge branch 'master' into multiplayer-spectator-leaderboard 2021-04-12 21:02:18 +09:00
Dean Herbert
b4c75ba3c6 Fix TestQuickDeleteRemovesObject failing on second run 2021-04-12 19:19:25 +09:00
ekrctb
359fae895f Rename property 2021-04-12 18:50:25 +09:00
ekrctb
e19e8ff2a3 Rewrite FramedReplayInputHandler for robustness
This commit changes the semantics of `CurrentFrame` and `NextFrame` of the class.
The ordering of `NextFrame.Time` and `CurrentFrame.Time` was dependent on the current direction.
Now, it should always satisfy `CurrentFrame.Time <= CurrentTime <= NextFrame.Time` except at the start/end.
This change, however, doesn't break existing deriving classes if the template code pattern usage of interpolation is used.
The deriving class code can be simplified due to the elimination of nullable types. I didn't include those changes in this commit.

I removed `StreamingFramedReplayInputHandlerTest` for now, as it is almost-duplicate of `FramedReplayInputHandlerTest`. I'll include more tests in later commits.

This commit fixes #6150.
2021-04-12 16:18:11 +09:00
Dean Herbert
9be3163592 Merge branch 'master' into multiplayer-spectator-player-grid 2021-04-12 14:14:13 +09:00
smoogipoo
4fcddfb44b Fix multiplayer test failure 2021-04-12 13:42:14 +09:00
ekrctb
d6d8ea5b6b Throw when getting a frame of an empty replay 2021-04-12 11:17:56 +09:00
Salman Ahmed
cb947a3b27 Add expected output in test case rather than determining internally 2021-04-11 13:18:25 -04:00
Salman Ahmed
1fd4cb8963
Merge branch 'master' into master 2021-04-11 10:19:16 +03:00
Christine Chen
08311abc5e Remove setters, cache CreatePowerStatus() and use a dummy LocalPowerStatus class in test scene 2021-04-10 00:00:21 -04:00
smoogipoo
61c400b1a1 Fix filename 2021-04-09 20:18:26 +09:00
smoogipoo
eccd269cce Implement maximum start delay 2021-04-09 20:17:57 +09:00
smoogipoo
950e4e05ef Merge branch 'multiplayer-spectator-leaderboard' into multiplayer-spectator-screen 2021-04-09 18:30:21 +09:00
smoogipoo
e73f3f52d7 Add some more asserts 2021-04-09 18:23:41 +09:00
smoogipoo
9ddcd686ac Fix incorrect assert 2021-04-09 18:23:38 +09:00
smoogipoo
b49997f531 Add test for no frames 2021-04-09 18:18:23 +09:00
smoogipoo
589ce4bdc2 Add test 2021-04-09 18:16:10 +09:00
Christine Chen
59d13b0dd3 Fixed indentation
sorry about the style fixes... I'm using JetBrains Rider from now on.
2021-04-08 21:53:42 -04:00
Christine Chen
6b6a71d3c3 trim whitespace 2021-04-08 20:39:17 -04:00
Christine Chen
493c095535 Fixed code style 2021-04-08 20:28:23 -04:00
Christine Chen
6bccb3aab6 Use DI to implement battery detection, add BatteryCutoff property
- Removed the Xamarin.Essentials package from osu.Game and added it to osu.iOS and osu.Android only.
- iOS and Android implementations use Xamarin.Essentials.Battery, while the Desktop implementation
only returns 100% battery for now.
- Added a BatteryCutoff property to PowerStatus so it can be different for each platform (default 20%, 25% on iOS)
2021-04-08 19:55:11 -04:00
smoogipoo
7958a257e8 Add tests 2021-04-08 22:14:30 +09:00
smoogipoo
70cd018a98 Fix intermittent test failure 2021-04-08 21:38:58 +09:00
smoogipoo
125358158b Merge branch 'master' into multiplayer-spectator-screen 2021-04-08 21:13:37 +09:00
Dean Herbert
1e23f671fa
Merge pull request #12321 from smoogipoo/add-spectate-button-and-state
Add multiplayer spectating user state and button
2021-04-08 19:48:58 +09:00
smoogipoo
b38d332268 Fix broken test 2021-04-08 16:31:39 +09:00
Dean Herbert
545156d15c Add regression test coverage 2021-04-08 15:20:53 +09:00
Dean Herbert
8aff53172d Remove necessity for nested PassThroughInputManger 2021-04-08 15:18:31 +09:00
Christine Chen
0a6baf670e Send a warning notification if device is unplugged and low battery
- Uses Xamarin.Essentials in osu.Game.PlayerLoader to check battery level
- Encapsulated battery checking in the public BatteryManager class so battery level and plugged in status can be accessed and edited in TestPlayerLoader
- When checking battery level, catch NotImplementedException thrown by Xamarin.Essentials.Battery on non-mobile platforms
- Added visual unit tests for battery notification
  To mock battery status and level, we had to define a batteryManager object in TestPlayerLoader and add a new function ResetPlayerWithBattery()

Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-07 15:56:50 -04:00
smoogipoo
72a42ceaf7 Merge branch 'multiplayer-spectator-player-grid' into multiplayer-spectator-screen 2021-04-08 00:19:00 +09:00
smoogipoo
024adb699c Add test and fix several issues 2021-04-08 00:12:21 +09:00
smoogipoo
214813154b Fix class name 2021-04-07 22:28:22 +09:00
smoogipoo
99bee73ac1 Merge branch 'master' into add-spectate-button-and-state 2021-04-07 22:07:52 +09:00
Dan Balasescu
6eb809f4c4
Merge pull request #9194 from boswelja/rebind-song-select
Allow rebinding Song Select mods/random/options keys
2021-04-07 20:55:45 +09:00
smoogipoo
93c5935ebc Add match subscreen support + test 2021-04-07 20:46:30 +09:00
Dean Herbert
b4c6894d13 Add test coverage for song select footer area 2021-04-07 18:29:31 +09:00
smoogipoo
abd637ffaa Add button to footer 2021-04-07 17:35:18 +09:00
smoogipoo
56c13148f1 Fix typo in class name 2021-04-07 16:45:10 +09:00
smoogipoo
c744f77cfa Add participant panel state 2021-04-07 16:40:24 +09:00
smoogipoo
f5667125a0 Remove unnecessary method 2021-04-07 16:37:43 +09:00
smoogipoo
6be9c9f0f4 Link up ready button to spectate state 2021-04-07 16:35:50 +09:00
smoogipoo
1f57b6884d Add ready button to test scene 2021-04-07 16:30:40 +09:00
smoogipoo
6de91d7b6b Add spectate button + test 2021-04-06 21:37:27 +09:00
Dan Balasescu
ba3689b5b9
Merge pull request #12269 from PercyDan54/beatmap-details
Use OnlineViewContainer for BeatmapDetails
2021-04-06 17:52:32 +09:00
Dan Balasescu
2321101518
Merge branch 'master' into fix-overzealousmouse-button-blocking 2021-04-06 16:45:25 +09:00
Dean Herbert
53c1bc666c Make addition of nested GlobalActionContainer in OsuGameTestScene optional 2021-04-06 15:18:00 +09:00
Dean Herbert
e486e521ff Fix regressed test 2021-04-05 22:46:01 +09:00
Dean Herbert
beebdb0734 Clean up implementation 2021-04-05 22:30:51 +09:00
Bartłomiej Dach
b66ba43bc5 Add failing test scene 2021-04-03 14:02:46 +02:00
Bartłomiej Dach
7d4b0e3f0a Fix editor clock scene not re-enabling beatmap
Could interfere with other tests due to causing crashes on attempts to
change `Beatmap.Value`.
2021-04-03 12:34:48 +02:00
PercyDan54
1ff77754fd
Use OnlineViewContainer 2021-04-02 20:14:31 +08:00
smoogipoo
c3c7c18549 Fix tests 2021-04-01 23:48:26 +09:00
smoogipoo
9e95441aa6 Rename Spectator -> SoloSpectator 2021-04-01 22:08:52 +09:00
Dean Herbert
710599c521 Merge branch 'master' into realm-key-binding-store 2021-03-31 15:00:47 +09:00
Dean Herbert
0c53b4eb93 Fix wrong counting and add test 2021-03-31 14:09:39 +09:00
Dean Herbert
321ad737b6 Merge branch 'master' into realm-migration-operation-blocking 2021-03-30 22:40:08 +09:00
Dean Herbert
8dfff999f9 Add rotation slider 2021-03-30 12:40:50 +09:00
Dean Herbert
f8cea5cae3 Merge branch 'master' into realm-migration-operation-blocking 2021-03-26 17:07:31 +09:00
Max Hübner
558f8fa51e Adjust testscene 2021-03-25 23:20:26 +01:00
Dean Herbert
6cb14e91c9 Make Player abstract and introduce SoloPlayer 2021-03-23 18:18:49 +09:00
Dean Herbert
aeff9bd853 Add return bool to HandleRequest to better trigger failures 2021-03-23 18:17:29 +09:00
Bartłomiej Dach
a16c0641b2 Revert EF Core to version 2.2
This reverts commit f3faad74d5, reversing
changes made to 712e7bc7bf.

Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
2021-03-21 11:05:15 +01:00
Dean Herbert
b9b351311a
Merge pull request #11824 from peppy/fix-unsafe-skinnable-sample-play
Fix playing skinned samples being unsafe during skin changes
2021-03-20 11:29:34 +09:00
Bartłomiej Dach
8e0536e1e2 Add failing test scene 2021-03-19 22:44:33 +01:00
Dean Herbert
03592fa696 Merge branch 'master' into realm-migration-operation-blocking 2021-03-19 21:33:26 +09:00
Dean Herbert
f59327cc3e Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-03-19 20:29:44 +09:00
Dean Herbert
196f95ae54 Update to use new bindables and centered area offset 2021-03-19 19:01:32 +09:00
Dean Herbert
9a6a0f3df5 Add test coverage and better UI handling of no tablet connected scenario 2021-03-19 19:01:32 +09:00
Dean Herbert
a8e319a320 Remove min/max from test scene to fix weirdness when switching test sizings 2021-03-19 19:01:31 +09:00
Dean Herbert
382109c7a2 Make test scene feel more like settings (width-wise) 2021-03-19 19:01:31 +09:00
Dean Herbert
464702182d Consume device name 2021-03-19 19:01:31 +09:00
Dean Herbert
3b7edf1333 Make tablet display always fit to size of settings area 2021-03-19 19:01:31 +09:00
Dean Herbert
d026c8da85 Initial pass of configuration interface 2021-03-19 19:01:31 +09:00
Dean Herbert
1c865682ae Add tablet configuration tests 2021-03-19 18:57:49 +09:00
Dean Herbert
711d895a04
Merge pull request #8238 from voidedWarranties/editor-song-end 2021-03-19 16:32:23 +09:00
Bartłomiej Dach
aec859b4d1 Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-03-18 19:51:46 +01:00
voidedWarranties
df6570ebf5 Improve logic and add previously failing test
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-03-17 15:48:55 -07:00
Bartłomiej Dach
21e18c9f6e Fix test hangs in browser due to changing tracks via music controller 2021-03-17 18:46:22 +01:00
Bartłomiej Dach
3b55eeb416 Fix test failure by setting beatmap
Post-merge, it was failing because somewhere along the way
`EditorClockTestScene` started expecting inheritors to set the beatmap
themselves explicitly in BDL.
2021-03-17 18:39:48 +01:00
Bartłomiej Dach
f1e66cc420 Adjust test namespace 2021-03-17 18:37:11 +01:00
Bartłomiej Dach
a691291ae8 Merge branch 'master' into editor-song-end 2021-03-17 18:18:19 +01:00
smoogipoo
e59b8b4ce6 Fix test checking nullable string 2021-03-17 19:07:29 +09:00
smoogipoo
f7ec79c5f4 Fix incorrect generic type 2021-03-17 19:02:25 +09:00
Dean Herbert
4bf57ad860 Remove remaining reference to obsolete value 2021-03-17 18:24:24 +09:00
smoogipoo
7fa5fd5647 Update usages of config with framework changes 2021-03-17 16:10:16 +09:00
Dean Herbert
f3faad74d5
Merge pull request #12003 from UselessToucan/ef_core_5 2021-03-15 15:05:32 +09:00
Dean Herbert
fce21f23d6 Add comments marking workarounds required for EFcore 5 2021-03-15 13:29:26 +09:00
Joehu
d0644221ff Add test showing toolbar behavior change 2021-03-12 15:48:49 -08:00
Roman Kapustin
c6c616f244 Actualize tests 2021-03-11 21:02:40 +03:00
Dean Herbert
a5b3ac7ef8 Add failing test covering alpha commands proceeding non-alpha (but ignored) commands 2021-03-09 15:54:11 +09:00
Dean Herbert
2b1ab3576b
Merge branch 'master' into migrate-country-rank 2021-03-08 11:07:25 +09:00
Dean Herbert
b241749119
Merge pull request #11928 from smoogipoo/fix-test-multiplayer-beatmap 2021-03-04 23:43:55 +09:00
smoogipoo
77607c06eb Fix not being able to enter gameplay in TestSceneMultiplayer 2021-03-03 22:07:39 +09:00
smoogipoo
1ecb1d122a Fix up TestSceneMultiplayer 2021-03-03 21:54:34 +09:00
smoogipoo
6affe33fb2 Fix another test scene 2021-03-03 19:40:19 +09:00
Bartłomiej Dach
3b125a26a8 Add test coverage 2021-03-02 19:21:03 +01:00
Salman Ahmed
2609b22d53 Replace usage of CurrentModeRank in line with API change 2021-03-01 23:07:25 +03:00
smoogipoo
5cfaf1de1b Fix duplicate ongoing operation tracker 2021-03-01 17:43:03 +09:00
smoogipoo
01a4815412 Make labels disappear on null beatmap/no hitobjects 2021-02-25 23:36:02 +09:00
Dean Herbert
3802cb29a4 Fix failing tests doing reference comparisons between string and LocalisedString 2021-02-25 17:49:54 +09:00
Dean Herbert
90e8308716 Merge branch 'master' into localisation-refactor-framework 2021-02-25 17:28:55 +09:00
Dean Herbert
a08a3d44c7 Add failing test coverage for using hotkeys from main menu before toolbar displayed 2021-02-25 14:52:16 +09:00
Dan Balasescu
3e2b21a9b4
Merge pull request #11892 from peppy/allow-collection-name-collisions
Fix crash on two collections existing with the same name
2021-02-24 23:08:05 +09:00
Dean Herbert
6e6fb31c05 Add test coverage 2021-02-24 18:49:16 +09:00
Dan Balasescu
c0f21c8cbe
Merge branch 'master' into fix-selecting-incompatible-freemods 2021-02-24 15:10:48 +09:00
Dan Balasescu
2e730cdde7
Merge pull request #11867 from peppy/add-quick-run-test-beatmap
Fix test failures due to beatmap taking too long to complete autoplay/replay
2021-02-24 13:25:22 +09:00
Dean Herbert
e679a1916f
Merge pull request #11833 from frenzibyte/fix-pofl-on-cooldown
Keep pausing gameplay on focus loss if cannot on first attempt
2021-02-24 00:15:58 +09:00
Dean Herbert
996c0897d1 Seek via GameplayClockContainer for better reliability 2021-02-23 13:40:21 +09:00
Bartłomiej Dach
f62120c66b Remove unused using directive 2021-02-22 22:45:55 +01:00
Dean Herbert
1fd76ea3fb Apply changes to UI components overriding functions with changing signatures 2021-02-22 19:01:42 +09:00
smoogipoo
ee6a94273d Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-02-22 18:31:27 +09:00
Salman Ahmed
6bac83964a Merge branch 'master' into fix-pofl-on-cooldown 2021-02-22 10:03:27 +03:00
Dean Herbert
adf2dc36c9 Fix PlaylistResults tests performing delays in real-time when headless 2021-02-22 15:43:58 +09:00
Dean Herbert
cdbf8de29d Update other tests which can benefit from using a shorter beatmap 2021-02-22 14:53:32 +09:00
Dean Herbert
541237ef16 Use a shorter test beatmap for tests which need to run to completion 2021-02-22 14:48:04 +09:00
smoogipoo
ca92ad715a Add test 2021-02-22 13:32:54 +09:00
Dean Herbert
d2ec151c67 Add failing test for pausing when pause support is disabled 2021-02-20 14:20:13 +09:00
Dan Balasescu
52372fe50d
Merge pull request #11713 from peppy/fix-error-exit-during-results-transition
Fix a potential crash when exiting play during the results screen transition
2021-02-19 18:39:21 +09:00
Dan Balasescu
9fc57b2145
Merge pull request #11832 from peppy/leaderboard-compact-mode
Show compact leaderboard during gameplay to reduce distractions
2021-02-19 18:17:46 +09:00
Salman Ahmed
f6c279ab00 Add assert ensuring player resumed properly 2021-02-19 11:45:45 +03:00
Salman Ahmed
fe5e45ea81 Move gameplay cursor outside instead and fix potential failure 2021-02-19 11:43:33 +03:00
Dean Herbert
52ebe34347 Update TestScenePause exit from fail test to actually fail 2021-02-19 17:26:26 +09:00
Dean Herbert
4c214b74ce Merge branch 'master' into fix-error-exit-during-results-transition 2021-02-19 17:13:55 +09:00
Salman Ahmed
772471a6d8 Add failing test case 2021-02-19 10:46:31 +03:00
Dean Herbert
43c35c5118 Show local user in test scene 2021-02-19 15:15:31 +09:00
Dean Herbert
ee9e6fff40 Add bindable flow for expanded leaderboard state 2021-02-19 15:09:41 +09:00
Salman Ahmed
a407bfe73b Privatize UserRanks and expose a similar CountryRank field instead 2021-02-18 15:37:52 +03:00
Dean Herbert
00574a5288 Use ISample everywhere in Skin GetSample lookup path 2021-02-18 18:32:28 +09:00
Salman Ahmed
a845e96b7a Replace Ranks.Global completely with a GlobalRank property 2021-02-17 08:52:04 +03:00
Salman Ahmed
d7c91a7c6f Merge branch 'fix-tournament-user-population' into multiplayer-participant-rank 2021-02-17 08:42:59 +03:00
Dean Herbert
e82922f8c5 Add the ability to deselect the currently selected room via clicking away
Always felt wrong that you couldn't do this until now.
2021-02-16 13:44:37 +09:00
Salman Ahmed
0e7f52b5cc Always use JSON property global_rank for global ranks instead 2021-02-16 07:33:16 +03:00
Salman Ahmed
5b4999e8af Update user statistics retrieval with API changes 2021-02-16 07:33:13 +03:00
Salman Ahmed
d15ffff9a5 Simplifiy user statistics retrieval to one-time on deserialization 2021-02-16 04:48:36 +03:00
Salman Ahmed
a1496cd8f3 Remove necessity of using CurrentModeRank as a fallback 2021-02-16 04:48:36 +03:00
Dean Herbert
2e646882fa Merge branch 'master' into non-concurrent-sample-playback 2021-02-15 21:22:21 +09:00
Dean Herbert
9ad38ab20e Move HubClientConnector retrieval to IAPIProvider 2021-02-15 16:43:56 +09:00
Dean Herbert
f664fca0dd Tidy up tests (and remove duplicate with new call logic) 2021-02-15 16:11:17 +09:00
Dean Herbert
4f264758a4 Add test coverage of pause from resume overlay 2021-02-15 15:57:36 +09:00
Dean Herbert
ec37e1602d Add failing test coverage of retrying from the results screen 2021-02-15 15:03:09 +09:00
smoogipoo
c6ed3efa4a Merge branch 'master' into non-concurrent-sample-playback 2021-02-15 14:47:32 +09:00
Dean Herbert
25f5120fdf Add failing test coverage of user pausing or quick exiting during cooldown 2021-02-15 14:36:17 +09:00
Dean Herbert
a4dc544235 Refactor some shared code in TestScenePause 2021-02-15 14:24:08 +09:00
Dan Balasescu
34e600464b
Merge branch 'master' into abstract-hub-connection 2021-02-15 13:53:54 +09:00
smoogipoo
d3f0c0730d Merge branch 'master' into non-concurrent-sample-playback 2021-02-12 17:22:15 +09:00
Dean Herbert
f7374703f0 Update tests to match dev domain 2021-02-12 15:29:21 +09:00
Salman Ahmed
d3c1b47592 Replace nullable API with null connector instead 2021-02-11 12:34:39 +03:00
Dean Herbert
aaa0362b12 Merge branch 'master' into autoplay-rate-independence 2021-02-11 17:39:45 +09:00
Jamie Taylor
2ee634d173 Create subclass for "Error" notifications to allow them to have a unique pop-in sound 2021-02-11 13:55:43 +09:00
Salman Ahmed
0c5e66205b Merge branch 'master' into abstract-hub-connection 2021-02-11 02:14:22 +03:00
Dean Herbert
9e400acd1a Merge branch 'master' into fix-mod-settings-fuckery 2021-02-10 17:43:03 +09:00
Dean Herbert
98a83722ff Move the point at which selected mods are reset in tests to allow mutliple creation test flow 2021-02-10 15:29:55 +09:00
Dean Herbert
de8a60435f Add failing test covering reported breaking case 2021-02-10 14:44:37 +09:00
Dean Herbert
e9ef4aaf88 Add test covering expectations of external mod changes 2021-02-10 14:34:45 +09:00
Dan Balasescu
92599aa02b
Merge branch 'master' into user-beatmap-downloading-states-2 2021-02-09 21:06:09 +09:00
Dean Herbert
0a96f4d403 Avoid assigning null to a non-nullable property 2021-02-09 18:56:27 +09:00
Dean Herbert
17475e60b0 Fix missed test scene update 2021-02-09 18:48:50 +09:00
Dean Herbert
3206c7cbae
Merge branch 'master' into overlay-header-refactor 2021-02-09 18:20:07 +09:00
Dean Herbert
94f35825dd Update test to cover changed exit/pause logic
I think this makes more sense?
2021-02-09 17:29:30 +09:00
Dean Herbert
4e3bb27cd5
Merge branch 'master' into fix-mod-settings-fuckery 2021-02-09 16:47:39 +09:00
Dean Herbert
1cb51fa8d2
Merge branch 'master' into autoplay-rate-independence 2021-02-09 16:05:34 +09:00
Dean Herbert
b87327841d Add test covering initial state propagation 2021-02-09 15:46:23 +09:00
Salman Ahmed
a0ead38496 Prevent test spectator clients from attempting hub connections 2021-02-09 08:02:51 +03:00
Salman Ahmed
f04d6d5e5e Update hub clients with changes to connecotr 2021-02-09 08:02:32 +03:00
Dean Herbert
0efad9ded1 Add test coverage of setting reset on deselection 2021-02-09 13:54:13 +09:00
Dean Herbert
3133ccacfa Reset selected mods between each test method
This doesn't actually fix or change behaviour, but does seem like
something we probably want to do here.
2021-02-09 13:09:40 +09:00
Salman Ahmed
f76f92515e Clean up spectator streaming client with new hub connector 2021-02-09 02:15:56 +03:00
Dean Herbert
5fbed05d04
Merge pull request #11551 from smoogipoo/fix-leave-room-race-2
Fix client potentially not leaving a room on exiting multiplayer
2021-02-08 19:23:14 +09:00
smoogipoo
6e34e7d750 Merge branch 'master' into user-beatmap-downloading-states-2 2021-02-08 19:08:53 +09:00
Dean Herbert
42c169054a Revert "Disable failing test temporarily pending resolution"
This reverts commit 10142a4471.
2021-02-08 17:46:34 +09:00
Dean Herbert
10142a4471 Disable failing test temporarily pending resolution 2021-02-08 16:59:21 +09:00
Bartłomiej Dach
68c20a2a37 Allow autoplay score generation to access mod list 2021-02-07 18:35:34 +01:00
Vincent Maggioli
96652e07cd
Merge branch 'master' into zero-spinner-slider 2021-02-05 09:40:55 -05:00
Dean Herbert
f338fa114b
Merge branch 'master' into user-beatmap-downloading-states-2 2021-02-05 18:02:40 +09:00
Dean Herbert
3e750feaa4 Subclass LocalPlayerModSelectOverlay to correctly deselect incompatible mods on free mod selection 2021-02-05 16:42:35 +09:00
Dean Herbert
1368d55152 Add test coverage of precedence of display 2021-02-05 15:58:27 +09:00
Dean Herbert
98c4573240 Add assertions covering new test 2021-02-05 15:52:49 +09:00
Dean Herbert
9e9e382bee Merge branch 'master' into user-beatmap-downloading-states-2 2021-02-05 15:27:17 +09:00
Dean Herbert
2fc3a97f56
Merge pull request #11516 from frenzibyte/ready-button-clean-up
Replace ready button beatmap logic with using `MultiplayerBeatmapTracker` instead
2021-02-05 15:09:25 +09:00
Salman Ahmed
78ea2d50bb Merge branch 'master' into ready-button-clean-up 2021-02-05 07:23:11 +03:00
smoogipoo
cf5233c6ab Merge branch 'master' into freemods 2021-02-05 00:27:14 +09:00
Dean Herbert
cef16a9f61 Add test coverage of animation / selection flushing 2021-02-04 19:55:15 +09:00
Dean Herbert
15062cc63f Fix intermittent test failures 2021-02-04 19:29:48 +09:00
Bartłomiej Dach
cb87da2bb8
Merge branch 'master' into freemod-select-overlay 2021-02-03 22:19:35 +01:00
Dean Herbert
b06f4ee124
Merge branch 'master' into solo-mod-select-overlay 2021-02-03 23:44:08 +09:00
Dean Herbert
2a52851e68
Merge branch 'master' into modselect-dynamic-isvalid 2021-02-03 22:11:33 +09:00
Dean Herbert
77735ac9dc
Merge pull request #11663 from smoogipoo/modselect-disable-stacking
Allow mod buttons to not be stacked
2021-02-03 22:11:02 +09:00
Dean Herbert
b27557f278
Merge pull request #11667 from smoogipoo/fix-mod-icon
Fix ModIcon not updating background colour correctly
2021-02-03 22:06:29 +09:00
smoogipoo
8bb1391515 Fix inspection 2021-02-03 14:53:55 +09:00
Dan Balasescu
2a4488c11b
Merge branch 'master' into freemods 2021-02-03 14:12:39 +09:00
Bartłomiej Dach
fe7f4f7222
Merge branch 'master' into playlists-item-visual-improvements 2021-02-02 21:26:16 +01:00
smoogipoo
6453367a9c Merge branch 'freemod-select-overlay' into freemods 2021-02-02 21:43:35 +09:00
smoogipoo
097ce37e96 Merge branch 'fix-mod-icon' into freemods 2021-02-02 21:37:24 +09:00
smoogipoo
921f008217 Fix ModIcon not updating background colour correctly 2021-02-02 21:35:08 +09:00
smoogipoo
643c0605d8 Implement the freemod selection overlay 2021-02-02 21:14:38 +09:00
smoogipoo
e58ece9e10 Make ModSelectOverlay abstract 2021-02-02 21:06:04 +09:00
smoogipoo
50e92bd0ed Fix selection not being preserved when IsValidMod changes 2021-02-02 20:50:54 +09:00
smoogipoo
10ceddf3ff Make IsValidMod adjustable 2021-02-02 20:47:50 +09:00
smoogipoo
6d620264f4 Allow mod buttons to not be stacked 2021-02-02 20:27:41 +09:00
Dean Herbert
c41c854ce3
Merge pull request #11637 from frenzibyte/improve-chat-autoscroll
Improve auto-scrolling logic for drawable channels
2021-02-02 18:40:25 +09:00
Dean Herbert
bc8a4f4111 Update test handling 2021-02-02 17:21:54 +09:00
Dean Herbert
6d9ac4d0f0 Increase darkness of gradient on buttons to make text readability (slightly) better 2021-02-02 16:57:27 +09:00
Dean Herbert
43052991f8 Remove unused using statement 2021-02-02 16:18:55 +09:00
Dean Herbert
3002fef05e Remove empty parenthesis 2021-02-02 16:11:13 +09:00
Dean Herbert
54c0bdf7d3 Fix PlaylistLoungeTestScene appearing very narrow 2021-02-02 16:04:42 +09:00
Dean Herbert
b3105fb292 Add coverage of local echo messages performing automatic scrolling 2021-02-02 15:46:42 +09:00
Dean Herbert
3670bd40c2 Add test coverage of user scroll overriding 2021-02-02 15:44:11 +09:00
Dean Herbert
398ab9c2c2 Use UserTrackingScrollContainer instead 2021-02-02 15:29:38 +09:00
smoogipoo
f166c4c414 Rename test 2021-02-02 11:04:09 +09:00
Salman Ahmed
dcb1626e4d Remove no longer necessary field 2021-02-01 22:38:42 +03:00
smoogipoo
97e3023df9 Renamespace/rename MatchSongSelect -> PlaylistsSongSelect 2021-02-01 20:16:58 +09:00
smoogipoo
9c4c47599f Merge branch 'master' into freemods 2021-02-01 19:28:10 +09:00
smoogipoo
89a42d60fb General cleanup 2021-02-01 18:50:32 +09:00
smoogipoo
3a906a89fc Pin mod position in participant panels 2021-02-01 18:27:15 +09:00
smoogipoo
3cd30d284e Renamespace 2021-02-01 18:08:49 +09:00
smoogipoo
f538963607 Extra mods -> user mods 2021-02-01 17:57:32 +09:00
smoogipoo
ac2a995041 Add user and panel states 2021-02-01 17:54:56 +09:00
Dean Herbert
328bd191d4
Merge pull request #11561 from Mysfit/fix-storyboard-samples
Fix storyboard samples continuing to play when the beatmap is paused or intro is skipped
2021-02-01 17:48:08 +09:00
Salman Ahmed
39d46d21e6 Add failing test case 2021-01-31 23:44:51 +03:00
Bartłomiej Dach
9ab1ad25eb Merge branch 'master' into fix-leave-room-race-2 2021-01-30 13:41:04 +01:00
smoogipoo
45e41aaeac Initial implementation of freemod selection overlay 2021-01-27 22:15:53 +09:00
smoogipoo
91d34d86f7 Abstractify ModSelectOverlay 2021-01-27 22:02:23 +09:00
Dean Herbert
fedcbf79fa
Merge pull request #11572 from EVAST9919/comment-pill
Make VotePill background transparent for own comments
2021-01-26 18:57:00 +09:00
Dean Herbert
468dfbecbe
Merge branch 'master' into fix-beatmap-listing-2 2021-01-26 17:56:37 +09:00
Salman Ahmed
c317d60169 Add offline test scene for beatmap listing overlay 2021-01-26 00:03:20 +03:00
Salman Ahmed
9312de7c23 Move online beatmap listing overlay to separate test scene 2021-01-26 00:03:20 +03:00
Dean Herbert
439f03e3b3 Fix failing test due to missing dependency 2021-01-25 19:25:38 +09:00
Mysfit
304264046b Added tests. 2021-01-24 17:46:54 -05:00
Salman Ahmed
d034728443 Remove conditional compilation symbols for such case 2021-01-24 01:05:45 +03:00
Salman Ahmed
85b8b00b8c Fix forgotten modulo 2021-01-24 01:04:56 +03:00
Salman Ahmed
faa2210274 Use old-style Enum.GetValues method for older than .NET 5 2021-01-24 00:55:58 +03:00
Salman Ahmed
acfb2d2980 Refactor beatmap set covers into using ModelBackedDrawable<T> 2021-01-24 00:32:33 +03:00
Salman Ahmed
d83abfa7d2 Add test scene with failing test case 2021-01-24 00:32:20 +03:00
Andrei Zavatski
e9d10bb6e7 Revert "Minor refactoring"
This reverts commit 3d42cc1f91.
2021-01-22 22:49:49 +03:00
Andrei Zavatski
3d42cc1f91 Minor refactoring 2021-01-22 22:27:26 +03:00
Bartłomiej Dach
360f26c13d Merge branch 'master' into scroll-to-20 2021-01-22 19:58:36 +01:00
Andrei Zavatski
20161aea6a Show LoginOverlay if not logged-in when clicking on a pill 2021-01-22 21:47:53 +03:00
Andrei Zavatski
6379381f95 Make VotePill background transparent for own comments 2021-01-22 20:46:20 +03:00
Bartłomiej Dach
a71f769cce Add missing license header 2021-01-21 22:09:42 +01:00
Bartłomiej Dach
7046f64e7f Rewrite test scene 2021-01-21 22:09:17 +01:00
vmaggioli
a5f866d95c
Test updates 2021-01-21 15:14:24 -05:00
vmaggioli
e4b59c7317
Test setup 2021-01-21 11:54:26 -05:00
Dean Herbert
259f6504fb Merge branch 'master' into realm-key-binding-store 2021-01-21 15:45:59 +09:00
Dean Herbert
a6516e3be5 Merge branch 'master' into scroll-to-20 2021-01-21 14:28:17 +09:00
smoogipoo
54dbb43f79 Fix more potential failures 2021-01-21 14:03:35 +09:00
Dean Herbert
7c4a072568 Merge branch 'master' into scroll-to-20 2021-01-21 13:48:26 +09:00
smoogipoo
163a937e41 Fix mod test failing intermittently 2021-01-21 13:30:53 +09:00
Andrei Zavatski
da0066e7b0 Merge master with conflicts resolved 2021-01-21 07:30:47 +03:00
Dan Balasescu
c3675293fa
Merge branch 'master' into beatmapset-refactor 2021-01-21 12:38:34 +09:00
Bartłomiej Dach
7abe33ad0e Add failing test case 2021-01-21 00:04:15 +01:00
smoogipoo
bba182a02d Fix test failure 2021-01-20 21:27:16 +09:00
smoogipoo
5ff76be052 Fix potential test failures due to timing 2021-01-20 19:43:51 +09:00
smoogipoo
8ffbcc9860 Fix test failures and general discrepancies 2021-01-20 14:05:35 +09:00
Andrei Zavatski
2ca3ccad06 Move all the content to BeatmapSetHeaderContent drawable 2021-01-20 04:56:46 +03:00
Dean Herbert
f1a785f407 Merge branch 'master' into realm-key-binding-store 2021-01-19 18:22:34 +09:00
smoogipoo
de9d075f94 Initial sample + samplechannel rework 2021-01-19 17:11:40 +09:00
Andrei Zavatski
f0add0a7cf Make BeatmapSetOverlay use OverlayHeader 2021-01-19 01:34:37 +03:00
Andrei Zavatski
70420b56d3 Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-header-refactor 2021-01-18 20:09:51 +03:00
Salman Ahmed
4a1acdece2 Merge branch 'multiplayer-beatmap-tracker' into ready-button-clean-up 2021-01-18 20:06:47 +03:00
Salman Ahmed
5f2e9c5485 Add visual test case for displaying beatmap availability states 2021-01-18 11:49:27 +03:00
Andrei Zavatski
27ffc98445 Implement WebOverlay component 2021-01-18 10:48:12 +03:00
Bartłomiej Dach
2b23c8eabd Use alpha directly for checking visibility in test
`IsPresent` is no longer synonymous with being visible, after applying
the fix to the issue in question.
2021-01-17 18:08:58 +01:00
Salman Ahmed
585aa87c53 Fix playlist item download button never shown back after hiding 2021-01-17 19:17:14 +03:00
Dean Herbert
5fd644fc57 Unify variable names 2021-01-17 22:42:48 +09:00
Dean Herbert
addd463d26
Merge branch 'master' into explicit-search-control 2021-01-17 21:44:25 +09:00
Dean Herbert
edb6d3907b
Merge pull request #11472 from frenzibyte/explicit-beatmap-markers
Add explicit content markers to beatmap panels and overlay
2021-01-17 21:44:10 +09:00
Salman Ahmed
63c0dc9bd9 Update ready button test scene with new logic 2021-01-17 01:11:03 +03:00
Bartłomiej Dach
7296a6dd84 Merge branch 'master' into realm-key-binding-store 2021-01-16 16:48:54 +01:00
Dean Herbert
b8c85ef017 Revert polling changes to fix participant list display
It turns out this polling was necessary to get extra data that isn't
included in the main listing request. It was removed deemed useless, and
in order to fix the order of rooms changing when selecting a room.
Weirdly, I can't reproduce this happening any more, and on close
inspection of the code can't see how it could happen in the first place.

For now, let's revert this change and iterate from there, if/when the
same issue arises again.

I've discussed avoiding this second poll by potentially including more
data (just `user_id`s?) in the main listing request, but not 100% sure
on this - even if the returned data is minimal it's an extra join
server-side, which could cause performance issues for large numbers of
rooms.
2021-01-15 15:19:12 +09:00
Dean Herbert
d023ad8ad1 Remove assert messages 2021-01-15 15:18:29 +09:00
Dean Herbert
51255033e2 Update some missed usages of KeyBindingContainer in tests 2021-01-15 14:57:01 +09:00
Roman Kapustin
0ea4e221b2 Merge branch 'master' into net5.0 2021-01-14 14:02:51 +03:00
Salman Ahmed
268f9d661f Dispose of local config on disposal 2021-01-13 13:00:14 +03:00
Salman Ahmed
a5f99ed8e6 Merge branch 'explicit-beatmap-markers' into explicit-search-control 2021-01-13 12:53:57 +03:00
Salman Ahmed
7fd55efc43 Add test cases for displaying explicit beatmaps 2021-01-13 12:27:15 +03:00
Dean Herbert
422260797b Revert polling changes to fix participant list display
It turns out this polling was necessary to get extra data that isn't
included in the main listing request. It was removed deemed useless, and
in order to fix the order of rooms changing when selecting a room.
Weirdly, I can't reproduce this happening any more, and on close
inspection of the code can't see how it could happen in the first place.

For now, let's revert this change and iterate from there, if/when the
same issue arises again.

I've discussed avoiding this second poll by potentially including more
data (just `user_id`s?) in the main listing request, but not 100% sure
on this - even if the returned data is minimal it's an extra join
server-side, which could cause performance issues for large numbers of
rooms.
2021-01-12 17:26:00 +09:00
Salman Ahmed
80fa2cf693 Add test coverage 2021-01-12 11:14:05 +03:00
Dean Herbert
536e7229d0 Remove unused EF class and unnecessary interface 2021-01-12 14:45:36 +09:00
Dean Herbert
8765aaf9e6 Use IKeyBinding for all key binding usages (and add update flow via primary key) 2021-01-11 16:31:35 +09:00