h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 10:52:53 +08:00
Code Issues Releases Wiki Activity

Add failing test showing OnNewBeat can execute far away from an actual beat

Browse Source
This commit is contained in:
Dean Herbert 2021-07-15 16:01:46 +09:00
parent d0fc258886
commit 3197f599bb
1 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
osu.Game.Tests/Visual/UserInterface/TestSceneBeatSyncedContainer.cs
View File

@ -56,7 +56,34 @@ namespace osu.Game.Tests.Visual.UserInterface
}
[Test]
public void TestFirstBeatAtFirstTimingPoint()
public void TestSeekBackDoesntPlayMidBeat()
{
int? lastBeatIndex = null;
double? lastActuationTime = null;
TimingControlPoint lastTimingPoint = null;
AddStep("bind event", () =>
{
beatContainer.NewBeat = (i, timingControlPoint, effectControlPoint, channelAmplitudes) =>
{
lastActuationTime = gameplayClockContainer.CurrentTime;
lastTimingPoint = timingControlPoint;
lastBeatIndex = i;
};
});
AddStep("Set time before zero", () =>
{
lastBeatIndex = null;
gameplayClockContainer.Seek(-1000);
});
AddUntilStep("wait for trigger", () => lastBeatIndex != null);
AddAssert("trigger is near beat length", () => lastActuationTime != null && lastBeatIndex != null && Precision.AlmostEquals(lastTimingPoint.Time + lastBeatIndex.Value * lastTimingPoint.BeatLength, lastActuationTime.Value, 32));
}
[Test]
public void TestNegativeBeatsStillUsingBeatmapTiming()
{
int? lastBeatIndex = null;
double? lastBpm = null;