39370 Commits

Author	SHA1	Message	Date
Dean Herbert	8391e2a538	Move reporting code out of DrawableChatUsername into more correct locations	2023-05-05 14:03:42 +09:00
tsrk	74e7a958bb	feat(ArgonKeyCounter): make animation ... Currently WIP. Do not consider this final.	2023-05-05 05:31:06 +01:00
Dean Herbert	698baa78bf	Merge pull request #22711 from Terochi/keep-shared-settings-ruleset-change ... Keep shared mod settings when changing ruleset	2023-05-05 13:29:55 +09:00
Bartłomiej Dach	485b7282dc	Clarify type check	2023-05-04 19:06:07 +02:00
Bartłomiej Dach	bdd96caaa9	Merge branch 'master' into edit-mods-preset	2023-05-04 18:59:47 +02:00
Bartłomiej Dach	1f1342b099	Reword xmldoc	2023-05-04 18:33:49 +02:00
Bartłomiej Dach	88e77ad390	Rename Settings{-> Map}	2023-05-04 18:30:41 +02:00
Bartłomiej Dach	26337dbcd8	Do not rely on unspecified Dictionary.Values ordering	2023-05-04 18:29:01 +02:00
Cootz	1ac9d900e1	Clear search on ModSelectOverlay.Hide	2023-05-04 19:24:37 +03:00
Bartłomiej Dach	0d2396c557	Rename method to better indicate directionality	2023-05-04 18:15:12 +02:00
Dean Herbert	95b541ab39	Update framework	2023-05-04 11:27:18 +09:00
Dean Herbert	0034124d79	Remove unnecessary content clear	2023-05-04 11:25:10 +09:00
Dean Herbert	26b8c5b852	Fix mod list display not updating after clicking "use current" ... This is not a regression from my changes. It was broken before them.	2023-05-04 11:23:51 +09:00
Dean Herbert	49fb5da1a2	Stop passing preset panel to popover	2023-05-04 11:19:09 +09:00
Dean Herbert	b12d139317	Remove dead code	2023-05-04 11:16:52 +09:00
Dean Herbert	99d2616c34	Move drawable construction to load for simplicity	2023-05-04 11:14:51 +09:00
Dean Herbert	be995f1359	Add localisation support for new button string	2023-05-04 11:11:19 +09:00
Dean Herbert	b7abab6d8a	More variable improvements	2023-05-04 11:10:05 +09:00
Dean Herbert	0a584f0652	Simplify check logic and improve variable naming	2023-05-04 11:07:09 +09:00
Bartłomiej Dach	59ece64d25	Merge branch 'master' into skin-editor-change-handler-improvement	2023-05-03 19:42:42 +02:00
Bartłomiej Dach	1d4d31e35c	Trim comments ... Leaving only the ones that add anything useful and do not restate the code verbatim.	2023-05-03 19:22:52 +02:00
Bartłomiej Dach	27fabd99fb	Rename variables for legibility ... Having `typedComponents` and `typeComponents` next to each other is asking for trouble.	2023-05-03 19:21:16 +02:00
Terochi	d1d4b54c64	Simplified	2023-05-03 18:31:35 +02:00
Bartłomiej Dach	fa3f42ba75	Merge pull request #23386 from peppy/fix-osu-logo-input-handling ... Extend input handling of osu! logo to full border area	2023-05-03 17:48:51 +02:00
cdwcgt	4549a865d9	Merge branch 'master' into export	2023-05-04 00:18:01 +09:00
cdwcgt	967e801f9c	code inspect	2023-05-03 23:26:58 +09:00
cdwcgt	debbd376bd	move scrollContent update logic to updateActiveState()	2023-05-03 23:24:14 +09:00
cdwcgt	f4b1264cc9	use button Enable status to ensure preset name is not null	2023-05-03 23:22:46 +09:00
cdwcgt	aa5a026c67	remove local button handle	2023-05-03 23:14:24 +09:00
cdwcgt	c609e6345c	remove Use Current Mods menu item	2023-05-03 23:02:50 +09:00
Cootz	152d2678d5	Fix ModSelectColumn completely disappear from ModSelectOverlay	2023-05-03 14:00:46 +03:00
Dean Herbert	be15d07b17	Tidy up various implementation details	2023-05-03 18:59:39 +09:00
Dean Herbert	b932e4d986	Rename DrawableUsername to DrawableChatUsername and only pass message ID	2023-05-03 18:53:22 +09:00
Dean Herbert	b28d7b1a92	Fix non-block namespace	2023-05-03 18:51:02 +09:00
Dean Herbert	4f55afb60d	Merge branch 'master' into chat-report	2023-05-03 18:50:38 +09:00
Dean Herbert	444f66b0ee	Move to base class for added safety	2023-05-03 18:46:30 +09:00
Dean Herbert	cd31cff8cd	Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap ... The handling of cleanup is performed only the `Item_Set` method. This was already correctly called for `DrawableCarouselBeatmapSet`, but not for the class in question here. This would cause runaway memory usage at song select when opening many beatmaps to show their difficulties. For simplicity, we don't yet pool these (and generate the drawables each time a set is opened) which isn't great but likely will be improved upon when we update the visual / filtering of the carousel. But this simplicity caused the memory usage to blow out until exiting back to the main menu when cleanup would finally occur.	2023-05-03 18:41:30 +09:00
Dean Herbert	5757eb7529	Update a few more instances of 0.96f scale constants	2023-05-03 18:20:12 +09:00
Bartłomiej Dach	88135a3be8	Merge pull request #23384 from peppy/fix-incorrect-transform-thread ... Fix potentially incorrect thread access in `OsuTabControlCheckbox`	2023-05-03 10:37:27 +02:00
Dean Herbert	ff28d941b3	Merge pull request #23385 from Joehuu/scroll-back-button-block-hover ... Fix overlay scroll back button not absorbing hover from behind	2023-05-03 16:28:05 +09:00
Bartłomiej Dach	de1b28bcb2	Fix incorrect initial state of checkbox ... This only ever barely used to work without the `(..., true)` in `master` because of haphazard operation ordering.	2023-05-03 09:27:23 +02:00
Bartłomiej Dach	5f781bd6de	Move callback to LoadComplete() ... Is the more correct place for `BindValueChanged()` callbacks.	2023-05-03 09:26:54 +02:00
Dean Herbert	453143813f	Extend input handling of osu! logo to full border area ... This is the easiest way to make this happen. It does mean the pink area is being drawn behind the white border, but I haven't found a scenario where this is noticeable. Closes #4217.	2023-05-03 14:57:57 +09:00
Joseph Madamba	1c74f6e8ea	Fix regressed button hover fade in	2023-05-02 22:54:42 -07:00
Joseph Madamba	bede1292de	Fix overlay scroll back button not absorbing hover from behind	2023-05-02 22:40:37 -07:00
Dean Herbert	a3efae3690	Fix potentially incorrect thread access in OsuTabControlCheckbox ... https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736829.	2023-05-03 14:33:32 +09:00
Dean Herbert	6b017ac05f	Merge pull request #23308 from OliBomby/sample-control-points ... Remove SampleControlPoint and DifficultyControlPoint from HitObject	2023-05-03 14:21:51 +09:00
Dean Herbert	f930c4bd0a	Move struct to bottom of file	2023-05-03 13:33:31 +09:00
Dean Herbert	48fd99818e	Split out default and sample application	2023-05-03 13:30:45 +09:00
Dean Herbert	cca15f930c	Refactor applyLegacyInfoAndDefaults for legibility	2023-05-03 13:26:50 +09:00
Dean Herbert	588a4e6196	Move pragma disable to top of LegacyBeatmapDecoder ... Makes more sense as it's used multiple times in the class.	2023-05-03 13:19:14 +09:00
Dean Herbert	e394b487e0	Merge branch 'master' into edit-mods-preset	2023-05-03 12:06:16 +09:00
Dean Herbert	e42b0cc5b1	Merge pull request #23370 from peppy/fix-editor-playfield-padding ... Add more padding around playfield in editor to avoid overlap with tool areas	2023-05-03 11:44:55 +09:00
Bartłomiej Dach	ec8362c6fc	Merge pull request #23367 from peppy/fix-uo-tooltip ... Fix slider bar tooltips potentially showing negative zero	2023-05-02 18:03:09 +02:00
Bartłomiej Dach	48dd42407b	Merge pull request #23369 from peppy/beatmap-attribute-text-unicode-preference ... Fix `BeatmapAttributeText` not supporting unicode artist/title	2023-05-02 17:32:55 +02:00
Cootz	a6ca049739	Manually implement @bdach prototype	2023-05-02 14:15:33 +03:00
Dean Herbert	94ae9d7664	Merge pull request #23357 from OliBomby/fix-reverse-crash ... Prevent infinite repeat count when adjusting repeats of 0 length slider	2023-05-02 19:53:26 +09:00
Dean Herbert	414b80d44e	Change flashlight depth in a more standard way	2023-05-02 17:00:54 +09:00
Dean Herbert	b2b9f2a036	Merge branch 'master' into bubble_mod_implementation_clean	2023-05-02 16:59:55 +09:00
OliBomby	2e018c8b06	Fix comment 2 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-05-02 08:41:47 +02:00
OliBomby	c2ad8c2320	Fix comment 1 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-05-02 08:41:30 +02:00
Dean Herbert	67f83f246b	Add more padding around playfield in editor to avoid overlap with tool areas ... Closes #23130.	2023-05-02 15:37:02 +09:00
Dean Herbert	4a97c2c105	Merge pull request #23038 from cdwcgt/scale-background-dim ... Add feature to adjust `ScalingContainer` background dim	2023-05-02 15:36:52 +09:00
Dean Herbert	ce4a6c38a0	Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight ... Fix now playing playlist not highlighting selected item on initial open	2023-05-02 15:36:34 +09:00
Dean Herbert	8a536c1cdb	Fix non-block namespace usage	2023-05-02 15:09:24 +09:00
Dean Herbert	1e4a628cb1	Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod ... Fix issue where multiplier show wrong value when adjusting speed on preset	2023-05-02 14:59:41 +09:00
Dean Herbert	e3c384c6b5	Merge branch 'master' into sample-control-points	2023-05-02 14:38:39 +09:00
Dean Herbert	57f48e0703	Start colour black to ensure initial appear transition doesn't look silly	2023-05-02 14:33:57 +09:00
Dean Herbert	ab4f66fad3	Minor readability refactors	2023-05-02 14:31:39 +09:00
Dean Herbert	7a840e1d82	Remove unnecessary TransferValue spec	2023-05-02 14:29:26 +09:00
Dean Herbert	7efaa299bd	Merge branch 'master' into scale-background-dim	2023-05-02 14:24:54 +09:00
Dean Herbert	736be6a73b	Refactor slightly for readability	2023-05-02 14:11:16 +09:00
Dean Herbert	ad40099e32	Ensure negative sign is only applied when the post-rounded result is negative	2023-05-02 14:00:52 +09:00
Dean Herbert	37a5dde859	Fix BeatmapAttributeText not supporting unicode artist/title	2023-05-02 13:47:49 +09:00
Dean Herbert	e808e7316b	Mark delegate value unused and add comment to avoid future regression	2023-05-02 13:29:30 +09:00
Dean Herbert	63890ef6fe	Fix audio offset tooltip potentially showing "-0 ms" ... Closes https://github.com/ppy/osu/issues/23339.	2023-05-02 13:24:22 +09:00
Dean Herbert	983a8f7dfe	Merge branch 'master' into fix-reverse-crash	2023-05-02 13:14:34 +09:00
Dean Herbert	5da78098ad	Merge pull request #23362 from bdach/fix-saving-online-beatmap-not-resetting-id ... Reset online ID on locally modifying beatmap	2023-05-02 12:41:23 +09:00
Bartłomiej Dach	436ebdcfcb	Fix beatmap leaderboard test failure ... Because the online info reset (which includes online ID reset) was happening after encoding, `TestSceneBeatmapLeaderboard.TestLocalScoresDisplayOnBeatmapEdit()` started failing, as the hash no longer matched expectations after the first save of the map.	2023-05-01 19:44:15 +02:00
OliBomby	cf5211aec9	Enable current distance snap when exactly on a hit object	2023-05-01 19:22:52 +02:00
Bartłomiej Dach	f470b2c9cc	Always reset online info when saving local beatmap	2023-05-01 18:17:45 +02:00
Bartłomiej Dach	8ab3a87b13	Add failing test case covering online ID reset on save ... This test scene passes at e58e1151f3 and fails at current master, due to an inadvertent regression caused by e72f103c17. As it turns out, the online lookup flow that was causing UI thread freezes when saving beatmaps in the editor, was also responsible for resetting the online ID of locally-modified beatmaps if online lookup failed.	2023-05-01 18:17:35 +02:00
OliBomby	8c21fddb5e	remove all redundancies from encoded control points	2023-05-01 16:53:38 +02:00
OliBomby	1dc34ee25d	fix infinite repeat count when adjusting length of 0 length slider	2023-05-01 15:48:54 +02:00
OliBomby	8302bb1f37	dont encode custom sample bank for objects without legacy samples	2023-05-01 14:56:29 +02:00
OliBomby	27cfadca16	add sample info to Banana and SpinnerBonusTick	2023-05-01 14:54:06 +02:00
Terochi	4d52ce769b	Revert SaveState() calling on initialization	2023-05-01 12:53:58 +02:00
OliBomby	cef9f73d34	dont assign custom sample bank and volume to hitobjects in non-mania gamemodes ... this makes it easier to edit hitsounds in the stable editor after export because the sample control point effects wont get overwritten by the properties of the hitobject	2023-05-01 12:31:27 +02:00
Bartłomiej Dach	d98aa60efc	Merge branch 'master' into cursor-ripples	2023-05-01 09:37:50 +02:00
OliBomby	2a94757154	Make sure the first object you place has bank and volume	2023-05-01 00:49:01 +02:00
OliBomby	608fa3cc73	Merge remote-tracking branch 'upstream/master' into sample-control-points	2023-04-30 19:47:03 +02:00
OliBomby	139a1d7e6d	fix legacy encoder writing sample info while not writing node samples	2023-04-30 17:46:47 +02:00
Bartłomiej Dach	7cedbca9be	Merge branch 'master' into multiplier-doesnt-update-with-preset-mod	2023-04-30 17:36:00 +02:00
Bartłomiej Dach	2e3daf0a54	Fix leak of ModSettingChangeTracker instances ... The `SelectedMods.BindValueChanged()` callback in `ModSelectOverlay` can in some instances run recursively. This is most heavily leaned on in scenarios where `SelectedMods` is updated by an external component. In such cases, the mod select overlay needs to replace the mod instances received externally with mod instances which it owns, so that the changes made on the overlay can propagate outwards. This in particular means that prior to this commit, it was possible to encounter the following scenario: modSettingChangeTracker?.Dispose(); updateFromExternalSelection(); // mutates SelectedMods to perform the replacement // therefore causing a recursive call modSettingChangeTracker?.Dispose(); // inner call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); // outer call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); This leaks one `modSettingChangeTracker` instance from the inner call, which is never disposed. To avoid this, move the disposal to the same side of the recursion that the creation happens on, changing the call pattern to: updateFromExternalSelection(); // mutates SelectedMods to perform the replacement // therefore causing a recursive call modSettingChangeTracker?.Dispose(); // inner call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); modSettingChangeTracker?.Dispose(); // outer call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); which, while slightly wasteful, does not cause any leaks. The solution is definitely suboptimal, but addressing this properly would entail a major rewrite of the mod instance management in the mods overlay, which is probably not the wisest move to make right now.	2023-04-30 17:31:41 +02:00
Terochi	fb4b681cc5	Use Queue instead of Stack	2023-04-30 16:36:01 +02:00
Terochi	8f02bd80f9	Addressed changes	2023-04-30 16:11:52 +02:00
Terochi	949dc1c0f9	Improved logic	2023-04-30 12:05:55 +02:00
Dean Herbert	b39a9d816e	Add basic structural requirements for cursor ripples	2023-04-30 14:48:03 +09:00
Terochi	8ec2154965	Fixed ApplyStateChange to happen in correct order	2023-04-30 02:01:18 +02:00
OliBomby	83111223e0	fix null sample	2023-04-30 01:08:52 +02:00
OliBomby	92efd04f31	fix sample of drumroll ticks being bankless	2023-04-29 23:52:24 +02:00
OliBomby	ffcc8e91b2	fix legacy parser incorrectly assigning sample info for sliders	2023-04-29 23:51:49 +02:00
Terochi	17e4b75dfd	Save first state when editing	2023-04-29 20:54:19 +02:00
Terochi	3b0ba4b38b	Improved logic for ApplyStateChange for skin editor	2023-04-29 19:52:22 +02:00
Bartłomiej Dach	646d4965b9	Merge branch 'master' into fix-exclusive-fullscreen-detection	2023-04-29 14:39:34 +02:00
Dean Herbert	119687cf6e	Merge pull request #23329 from rltn/clickable-country-name-in-profile ... Clickable country name in profile	2023-04-29 14:19:13 +09:00
Cootz	607a04ae73	Fix the issue	2023-04-29 10:29:33 +09:00
_ltn	2d6c0d2900	use of Child instead of Children	2023-04-28 19:24:07 +03:00
OliBomby	f7c84030ac	remove bank default value	2023-04-28 17:22:34 +02:00
Dean Herbert	6929be49b7	Change condition for exclusive fullscreen notice to only show when using the correct renderer ... This avoids the notice showing when running on windows, but using the newer renderers (where the underlying logic hasn't been tested properly and can result in false-positives). Supersedes https://github.com/ppy/osu-framework/pull/5759 as a more correct implementation.	2023-04-28 22:36:30 +09:00
Ethan	ae85e2a3ff	Update LoginForm.cs	2023-04-28 19:51:10 +08:00
_ltn	4b0ee392f6	add OsuHoverContainer	2023-04-28 05:48:54 +03:00
_ltn	17730f05bc	remove UpdateableCountryText	2023-04-28 05:47:05 +03:00
_ltn	4d144cd5b5	clearing the code	2023-04-28 02:06:13 +03:00
_ltn	092377fdaa	moving UpdateableCountryText	2023-04-28 01:47:14 +03:00
_ltn	e9843f2066	replace country text object	2023-04-28 01:16:50 +03:00
_ltn	b13201fb79	UpdateableCountryText rewrite	2023-04-28 01:14:42 +03:00
_ltn	f5c652325a	Create UpdateableCountryText.cs	2023-04-27 23:44:18 +03:00
Cootz	b795e8ac5a	Use ModSearch in ModeSelectOverlay	2023-04-27 17:26:35 +03:00
Cootz	3c6141f233	Add ModSearch	2023-04-27 17:08:29 +03:00
Bartłomiej Dach	07efa7d660	Merge branch 'master' into fix-storyboard-loop-end-time	2023-04-26 21:53:26 +02:00
OliBomby	354cd23874	removed all usage of hitobject's DifficultyControlPoint	2023-04-26 18:17:02 +02:00
OliBomby	c44f71a737	remove all regular usage of DifficultyControlPoint	2023-04-26 17:55:38 +02:00
OliBomby	1b4f4372d5	fixed sample control point applying	2023-04-26 14:32:12 +02:00
OliBomby	5accb05f45	fix invalidoperation exception	2023-04-26 14:28:48 +02:00
OliBomby	c6fc180659	remove all test usages of SampleControlPoint	2023-04-26 14:21:52 +02:00
OliBomby	87ca0f5335	Update SamplePointPiece.cs	2023-04-26 13:45:58 +02:00
OliBomby	6c70948681	Remove IContext & add IHasGenerateTicks	2023-04-26 13:10:57 +02:00
OliBomby	e27c4dfa10	Invoke ApplyDefaultsToSelf	2023-04-26 11:46:05 +02:00
Terochi	332c199dc2	further simplification	2023-04-26 10:46:29 +02:00
cdwcgt	bfd81b77fa	provide more Accuracy Mode for ModAccuracyChallenge	2023-04-26 17:40:25 +09:00
Dean Herbert	61b62b35f5	Merge pull request #18626 from ggliv/decouple-mod-fails ... Allow ModFailCondition to arbitrarily trigger failures	2023-04-26 16:19:42 +09:00
Dean Herbert	27f81288ef	Merge branch 'master' into keep-shared-settings-ruleset-change	2023-04-26 15:51:31 +09:00
Dean Herbert	cb7b246e33	Fix naming and update in line with nullability	2023-04-26 15:27:58 +09:00
Dean Herbert	210c5e7c53	Merge branch 'master' into decouple-mod-fails	2023-04-26 15:26:20 +09:00
Dean Herbert	6a3b587374	Merge pull request #23260 from Haspamelodica/master ... Fix some videos with uppercase file extensions not displaying correctly in-game	2023-04-26 14:29:25 +09:00
Dean Herbert	1efc78c0f8	Actually use new end time property when setting lifetimes	2023-04-26 13:28:51 +09:00
Terochi	8e297dc60a	Added safety measures for invalid mod combinations	2023-04-25 21:28:03 +02:00
Bartłomiej Dach	5ec8ecb11b	Merge pull request #23309 from peppy/key-counters-fix ... Fix key counters counting during break time	2023-04-25 21:15:12 +02:00
Terochi	0841e73a39	Improved readability and sounds	2023-04-25 21:07:17 +02:00
OliBomby	e4b64bdc3e	clean up code stuff	2023-04-25 19:06:29 +02:00
OliBomby	755ad25dbe	clean code	2023-04-25 18:27:20 +02:00
OliBomby	66eda40cdf	fix implementations of IHasSliderVelocity	2023-04-25 18:22:22 +02:00
OliBomby	c23a7b014e	add missing }	2023-04-25 18:17:07 +02:00
OliBomby	065464d90c	Fixed DifficultyPointPiece	2023-04-25 18:12:53 +02:00
Daniel Kirschten	54e8aa8fe9	Merge branch 'master' into master	2023-04-25 16:04:02 +02:00
OliBomby	ebe1d852f5	remove other usages of hitobject SampleControlPoint	2023-04-25 16:01:43 +02:00
OliBomby	a634617157	Fix file header notice	2023-04-25 16:01:06 +02:00
OliBomby	c37875bee8	remove hitobject SampleControlPoint usage from LegacyBeatmapEncoder	2023-04-25 16:00:40 +02:00
Dean Herbert	14af2063e5	Merge pull request #23247 from peppy/round-editor-rotation ... Always round editor rotation to integer values	2023-04-25 21:43:44 +09:00
Dean Herbert	e08d7daffd	Don't show decimal point in tooltip	2023-04-25 21:43:14 +09:00
Dean Herbert	6b4032e34b	Add missing binding of IsCounting with contained counters	2023-04-25 21:37:19 +09:00
Dean Herbert	0a861ffcee	Restructure key counters to use a common flow	2023-04-25 21:37:19 +09:00
Dean Herbert	7630958633	Stop using Drawable.Name to convey actual UI information	2023-04-25 20:24:36 +09:00
Dean Herbert	dd2c289ce9	Remove pointless default value	2023-04-25 20:22:12 +09:00
OliBomby	97910d6be6	remove unused directives	2023-04-25 13:06:37 +02:00
OliBomby	bf1951fc38	Fix incorrect xmldoc	2023-04-25 12:54:45 +02:00
Dean Herbert	d8b4db3a13	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-25 19:54:31 +09:00
OliBomby	891b87a5ff	remove ApplyLegacyInfo method	2023-04-25 12:52:21 +02:00
OliBomby	ea1e6e9798	Add LegacyContext	2023-04-25 12:12:46 +02:00
OliBomby	a4c6850ab2	made the SampleControlPoint and DifficultyControlPoint obsolete	2023-04-25 11:34:09 +02:00
Dean Herbert	e330052852	Add second definition of EndTime for storyboard elements to account for loops in lifetime	2023-04-25 15:22:11 +09:00
Dean Herbert	3919400be2	Apply NRT to some storyboard classes	2023-04-25 14:30:01 +09:00
Renzo Poggio	0991c56e1c	Add extra check in 'SelectPreviousRandom' ... Check if the poped beatmap exists within the beatmapSets	2023-04-25 00:05:15 -03:00
Hy0tic	80301f0fc9	Merge https://github.com/Hy0tic/osu	2023-04-22 13:32:41 -04:00
Hy0tic	56ab029a58	fix issue where multipler does not update when adjusting speed for preset mod	2023-04-22 13:30:08 -04:00
Daniel Kirschten	6c9a90d1ec	Merge branch 'master' into master	2023-04-22 19:23:52 +02:00
Haspamelodica	e90660c1a4	Switched to lowercase	2023-04-21 02:35:28 +02:00
Haspamelodica	b62de5514c	Fixed video importing bug #23259	2023-04-21 02:10:24 +02:00
Dean Herbert	1066dfcbf6	Change default beat divisor to 4 ... This matches stable, and is a much saner default value. Will apply to new beatmaps and also beatmaps which don't specify a snap value in the `.osu` file.	2023-04-20 14:35:13 +09:00
Dean Herbert	9f4b1f0f24	Always round editor rotation to integer values	2023-04-20 14:30:01 +09:00
Joseph Madamba	776c4cfaad	Ensure selected field is correct in updateSelectionState() ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-04-19 18:34:35 -07:00
Dean Herbert	01260e5f54	Merge branch 'master' into shader-cache-stages	2023-04-19 20:47:34 +09:00
Dean Herbert	760ef10145	Update framework	2023-04-19 00:04:21 +09:00
Dean Herbert	ee5658c15a	Merge pull request #23222 from peppy/update-framework-resources ... Update framework and resources	2023-04-18 14:10:42 +09:00
Dean Herbert	26a2d1fdea	Merge pull request #23000 from Joehuu/fix-beatmap-terminology ... Fix song select matching label not using right terminology	2023-04-18 13:53:05 +09:00
Joseph Madamba	c80a25328d	Shorten label to just "matches"	2023-04-17 20:59:41 -07:00
Joseph Madamba	16df92f405	Fix sets not being plural	2023-04-17 20:59:02 -07:00
Dan Balasescu	c0a25144cf	Apply changes to custom ShaderManager	2023-04-18 11:31:56 +09:00
Dean Herbert	c3f3b8db7c	Update resources	2023-04-17 23:09:46 +09:00
Dean Herbert	fbb15fff26	Update framework	2023-04-17 23:03:16 +09:00
Dean Herbert	7aeab174eb	Merge pull request #23185 from bdach/nested-result-revert ... Invoke `RevertResult` on parent DHO when nested DHO is reverted	2023-04-12 23:08:10 +09:00
Bartłomiej Dach	e72f103c17	Do not look up metadata for locally-modified beatmaps on save	2023-04-11 23:14:35 +02:00
Bartłomiej Dach	db86ced4b4	Invoke RevertResult on parent DHO when nested DHO is reverted ... The behaviour described above was removed in 812a4b412a, thus henceforth contradicting `RevertResult`'s xmldoc. As it is relied on by some external rulesets, bring it back to unbreak them.	2023-04-11 18:29:08 +02:00
Joseph Madamba	d0cbe206a9	Revert back to one number with "matching beatmap difficulties" label	2023-04-10 23:37:29 -07:00
Joseph Madamba	f0c8a3202b	Merge remote-tracking branch 'upstream/master' into fix-beatmap-terminology	2023-04-10 23:22:15 -07:00
Dean Herbert	52bb7891f7	Merge branch 'master' into fix-count-not-updating-when-deleting	2023-04-11 09:04:02 +09:00
Joseph Madamba	f80de08f24	Adjust BeatmapSetsChanged xmldoc ... Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-04-10 11:28:23 -07:00
Joseph Madamba	c7dea71793	Use existing BeatmapSetsChanged action	2023-04-10 11:26:18 -07:00
Dean Herbert	8757276c37	Merge pull request #23156 from Micha-ohne-el/editor-selection-rotation-snapping ... Add rotation snapping to editor selection	2023-04-11 00:45:44 +09:00
Dean Herbert	52c4703261	Merge pull request #23103 from Joehuu/normalise-overlay-padding ... Normalise horizontal padding on overlays	2023-04-10 23:48:59 +09:00
Bartłomiej Dach	1f2c96c8e8	Merge branch 'master' into gd-onlinesetoverlay	2023-04-10 15:35:03 +02:00
Bartłomiej Dach	11fd93a2ba	Inline disturbing getGuestMapper() method ... Disturbing because name suggests pure method, but it is in fact `void` and also performs side effects by about the most confusing means possible.	2023-04-10 15:20:43 +02:00
Bartłomiej Dach	73bd0feef5	Fix incorrectly implemented localisation	2023-04-10 15:03:33 +02:00
Bartłomiej Dach	6fec476147	Simplify snap implementation	2023-04-10 14:55:30 +02:00
Bartłomiej Dach	ead5e9f027	Merge branch 'master' into editor-inspector	2023-04-10 14:29:05 +02:00
Bartłomiej Dach	60358c7203	Perform first inspector text update immediately ... Provides better and more consistent initial state for the inspector.	2023-04-10 14:13:53 +02:00
Bartłomiej Dach	641415ca32	Unify displayed duration format for single/multiple selection	2023-04-10 14:05:32 +02:00
Joseph Madamba	7f5b99c91b	Fix song select beatmap difficulty count not updating when deleting	2023-04-09 22:12:51 -07:00
Dan Balasescu	15f6bc155e	Add progressive score multiplier for HT	2023-04-10 13:35:48 +09:00
Dan Balasescu	c923482976	Add progressive score multiplier for DT	2023-04-10 13:31:48 +09:00
cdwcgt	dd69089117	code quality	2023-04-09 15:51:31 +09:00
cdwcgt	5d64c1b7bf	exception handling	2023-04-09 15:09:18 +09:00
cdwcgt	ce6a87b4a3	Merge remote-tracking branch 'upstream/master' into export	2023-04-09 15:02:47 +09:00
cdwcgt	fc55b96e77	remove CompletionText in Constructor ... this will never used Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-04-09 14:27:42 +09:00
cdwcgt	49193a2bdd	CompletionText ... Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-04-09 22:25:47 +09:00
cdwcgt	de21b4a2f7	use Live<TModel> ... Use RealmAccess only when needed	2023-04-09 22:21:15 +09:00
cdwcgt	1f4da35c8d	notification nullable fix	2023-04-09 22:13:53 +09:00
cdwcgt	13b522e825	repair usage of CancellationToken ... Co-Authored-By: n0099 <n@n0099.net>	2023-04-09 22:09:53 +09:00
Dean Herbert	8d2e852ffd	Fix overbearing key down handling	2023-04-08 22:30:36 +09:00
Dean Herbert	a1fc4def1d	Remove redundant method override	2023-04-08 22:18:07 +09:00
Micha Lehmann	3c4a25e53f	Fix tooltip text not resetting when ending an editor rotation	2023-04-08 14:28:52 +02:00
Micha Lehmann	580d5745c0	Add "(snapped)" to the tooltip when snap-rotating in the editor	2023-04-08 14:15:49 +02:00
Joseph Madamba	a86a968fac	Use public BeatmapSet to match other usages	2023-04-07 21:16:36 -07:00
Joseph Madamba	ed208ef127	Fix more typos and adjust font size to match web	2023-04-07 21:10:37 -07:00
Dean Herbert	f72dd86b42	Fix code quality issues and avoid updating bindable twice per operation	2023-04-08 10:40:36 +09:00
Micha Lehmann	c827c2810b	Improve editor selection rotation value wrapping ... This fixes two issues the previous algorithm had: 1. A half-turn rotation used to show up as -180°. 2. Rotating more than 180° in one drag event would overwhelm it and cause the value to go outside its range. This comes at the cost of a negligible performance hit, since a division (modulo) is performed instead of just addition/subtraction.	2023-04-08 01:30:29 +02:00
Micha Lehmann	f1de560d57	Snap editor selection rotation when holding shift	2023-04-08 01:30:29 +02:00
Dean Herbert	0c71fa1bbd	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-06 23:39:57 +09:00
Dean Herbert	ad717d2368	Fix scheduled calls piling up during transactions	2023-04-06 23:39:36 +09:00
Andrei Zavatski	ed565b1e59	Fix SampleStore isn't being disposed	2023-04-06 11:40:04 +03:00
Dean Herbert	e6872629f3	Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable ... Don't show epilepsy warning when storyboards are disabled	2023-04-06 12:32:38 +09:00
tsrk	809b817e8e	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-05 22:57:36 +02:00
Bartłomiej Dach	ba753a8aac	Merge branch 'master' into update-skinnable-sound-before-playing	2023-04-05 22:56:25 +02:00
Bartłomiej Dach	27055919a3	Merge branch 'master' into fix-old-beatmap-crash-on-load	2023-04-05 21:39:42 +02:00
Bartłomiej Dach	6df7614b9d	Add tests for suppressing epilepsy warning when storyboard disabled	2023-04-05 20:56:50 +02:00
Bartłomiej Dach	e5d57a65c9	Fix incorrect indent	2023-04-05 19:47:25 +02:00
Bartłomiej Dach	432f698697	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-05 19:45:14 +02:00
Dean Herbert	9c8b25e034	Fix display not always updating when expected by updating on a schedule	2023-04-05 13:45:24 +09:00
Dean Herbert	f07d859532	Optimise how often we update the display	2023-04-04 19:31:33 +09:00
Dean Herbert	3209b09270	Move inspector into own file	2023-04-04 19:17:34 +09:00
Dean Herbert	4aed483005	Tidy up dependency resolution	2023-04-04 19:14:30 +09:00
Dean Herbert	195b5fc3f1	Add view for selections of size != 1	2023-04-04 19:11:48 +09:00
Dean Herbert	b0d5761667	Add object type	2023-04-04 19:05:50 +09:00
Dean Herbert	c356c163fa	Add hit object inspector view	2023-04-04 19:03:45 +09:00
Dean Herbert	f9ebdadfe8	Move right-side editor toolbox to base HitObjectComposer ... Move right-side editor toolbox to base `HitObjectComposer`	2023-04-04 19:00:56 +09:00
Bartłomiej Dach	1a5707b65f	Merge pull request #22878 from peppy/fix-replay-fail-on-exit ... Ensure replays don't enter a failed state when exiting gameplay	2023-04-03 22:38:32 +02:00
Bartłomiej Dach	8cc425774b	Merge branch 'master' into fix-replay-fail-on-exit	2023-04-03 21:23:23 +02:00
Bartłomiej Dach	7dfd903b76	Merge branch 'master' into fix-debug-perf-drd	2023-04-03 21:04:18 +02:00
Bartłomiej Dach	b5d9284de2	Merge pull request #23108 from peppy/fix-overlay-toggles-during-disclaimer ... Fix attempting to show overlay during game intro playing hide sound effects	2023-04-03 20:48:03 +02:00
cdwcgt	9dd30e4b4c	condition fix	2023-04-03 20:24:38 +09:00
cdwcgt	735b48679e	use LinkFlowContainer directly	2023-04-03 20:09:49 +09:00
cdwcgt	41c01d3929	nullable condition	2023-04-03 20:07:21 +09:00
cdwcgt	51240ed46b	typo	2023-04-03 19:51:22 +09:00
Dean Herbert	7011928d86	Fix abysmal debug performance due to try-catch logic in DrawableRulesetDependencies	2023-04-03 18:04:33 +09:00
Dean Herbert	b0c09df259	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-03 15:33:35 +09:00
Dean Herbert	43d7386623	Merge pull request #22926 from Joehuu/fix-sort-direction-not-resetting ... Fix beatmap listing sort direction not resetting when changing criteria	2023-04-03 15:32:10 +09:00
Dean Herbert	e4eb736622	Merge pull request #22929 from Joehuu/fix-loading-blocking-overlay-headers ... Fix beatmap listing filter control being blocked by loading layer	2023-04-03 15:29:38 +09:00
Dean Herbert	a097433cb1	Fix overlay toggle keys working during disabled activation modes ... Closes #23104.	2023-04-03 15:03:47 +09:00
Joseph Madamba	247d426c8a	Add horizontal padding to currently playing search textbox	2023-04-02 20:50:18 -07:00
Joseph Madamba	436f1e4ae4	Replace other hardcoded horizontal padding with const ... - Also add overlay stream item padding const and account for it	2023-04-02 20:50:18 -07:00
Joseph Madamba	af389b1107	Replace all hardcoded 50 horizontal padding with const	2023-04-02 20:50:18 -07:00
Joseph Madamba	7a0edabd5d	Normalise overlay horizontal padding const	2023-04-02 20:24:13 -07:00
Dean Herbert	daf9f19b29	Merge pull request #23098 from Joehuu/update-vote-pill-hover ... Update comment vote pill in line with web	2023-04-03 12:01:46 +09:00
Dean Herbert	8932668f77	Update framework	2023-04-03 10:31:47 +09:00
Joseph Madamba	63ea17f10e	Update comment vote pill in line with web	2023-04-02 18:17:40 -07:00
Susko3	c3a6a58169	Fix window mode dropdown not showing	2023-04-02 19:23:18 +02:00
Dean Herbert	1e0b64c9e8	Update framework (again)	2023-04-02 23:07:40 +09:00
cdwcgt	d949ef3ca4	make guestMapperContainer private ... tests don't use it	2023-04-02 22:53:15 +09:00
cdwcgt	2cf8636366	show guest diff author in BeatmapPicker	2023-04-02 22:25:58 +09:00
Dean Herbert	4c2b7e7788	Fix random inspection showing up only in CI	2023-04-02 21:05:20 +09:00
Dean Herbert	cf5acbf66e	Update usage of SupportedWindowModes	2023-04-02 20:16:14 +09:00
Dean Herbert	0f0dd9f2dc	Update resources	2023-04-02 20:07:33 +09:00
Dean Herbert	7f9bf09e03	Update framework	2023-04-02 20:07:31 +09:00
Dean Herbert	4b294278d6	Merge branch 'master' into fix-ruleset-shader-caching	2023-03-31 20:04:55 +09:00
Dean Herbert	1277c8eb5a	Merge branch 'master' into debug-use-en-localisation-fallbacks	2023-03-31 17:26:56 +09:00
Dan Balasescu	4b7d44c329	Remove unused using	2023-03-31 16:23:56 +09:00
Dan Balasescu	28f31ef379	Adjust comment slightly	2023-03-31 16:23:37 +09:00
Dan Balasescu	d5b8a45541	Always use fallback strings for English ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-03-31 16:20:16 +09:00
Bartłomiej Dach	bfbb5ab96b	Merge branch 'master' into fix-fail-progression-to-results	2023-03-30 21:40:49 +02:00
Dean Herbert	796cd9c916	Rewrite comment explaining early return on checkScoreCompleted given new usages	2023-03-31 02:36:17 +09:00
Dean Herbert	b25a59fd14	Rename scoreCompleted -> checkScoreCompleted to reflect the fact it doesn't always succeed	2023-03-31 02:30:04 +09:00
cdwcgt	5d395e6d37	move to ctor	2023-03-29 22:59:54 +09:00
cdwcgt	19b7036b95	use same same duration ... negligence in migrating code	2023-03-29 22:56:35 +09:00
cdwcgt	e85c28031e	change weird name	2023-03-29 22:55:25 +09:00
Dean Herbert	72c5c9848f	Always use LocalisableString fallbacks when deploying debug and viewing english ... This allows changes to `xxxStrings.cs` files to immediately reflect in the UI, which is (at least for me) an expectation.	2023-03-29 14:44:43 +09:00
Dean Herbert	c7003434b2	Fix localisation for audio device error containing incorrect newline escaping	2023-03-29 14:33:10 +09:00
Dean Herbert	4dd0c2c7a5	Add assert ensuring we don't ever get to the results screen with an F rank ... Intentionally an assertion as I want tests to fail, but I don't want this to cause crashes for an end user if it does happen to occur.	2023-03-29 14:11:58 +09:00
Dean Herbert	a8bb2e33ac	Ensure all preconditions are checked before progressing to results screen after storyboard ends	2023-03-29 14:00:11 +09:00
Dean Herbert	aad540629f	Remove duplicate load rule from ShaderPrecompiler	2023-03-29 12:36:56 +09:00
cdwcgt	46ede27869	add feature to adjust ScalingContainer background dim	2023-03-28 22:41:24 +09:00
cdwcgt	31df626f0e	disable button when select other reason	2023-03-28 21:32:28 +09:00
cdwcgt	899860dd77	Merge branch 'master' into chat-report	2023-03-28 21:14:11 +09:00
Dean Herbert	8c1df3c8d9	Fix web account registration not bypassing the URL warning	2023-03-28 15:38:19 +09:00
Dean Herbert	0d77ec013a	Fix ruleset-local shader manager not correctly falling back to existing cached shaders	2023-03-28 15:00:49 +09:00
Dean Herbert	5dfac02b11	Preload triangle shader on startup	2023-03-28 14:15:38 +09:00
Dean Herbert	c742b3f0a8	Update DrawableRulesetDependencies xmldoc to read more correctly	2023-03-28 14:15:19 +09:00
cdwcgt	b065689cf8	Limit the area of popover to DrawableChannel ... popover may be blocked by textBar	2023-03-27 23:04:45 +09:00
Joseph Madamba	8b30c67580	Fix incorrect song select matching label by showing both beatmap and difficulty count for less ambiguity	2023-03-26 18:08:28 -07:00
Joseph Madamba	76a6f97fbb	Fix wrong definition of a beatmap in first run setup	2023-03-26 17:32:03 -07:00
Joseph Madamba	3e0bbb2432	Fix select beatmap button not highlighting when creating a multiplayer room using keyboard	2023-03-26 16:03:21 -07:00
Dean Herbert	6924dc5c50	Update framework	2023-03-27 02:16:33 +09:00
Dean Herbert	898717231b	Hide vulkan renderer option for now ... We'll bring it back when it's more stable.	2023-03-27 02:00:10 +09:00
Bartłomiej Dach	292486c25a	Use more resilient restore method	2023-03-26 14:35:00 +02:00
Bartłomiej Dach	f3c174a7f2	Fix test errors due to missing dependencies	2023-03-26 13:52:26 +02:00
Dean Herbert	bab93bed17	Fix string interpolation and use GetDescription on renderer value	2023-03-26 20:43:28 +09:00
Dean Herbert	ba078e8357	Show "automatic" resolved renderer inline in dropdown instead	2023-03-26 20:29:30 +09:00
Dean Herbert	764361b3d3	Add special case to hide definitely non-working renderers on android	2023-03-26 20:14:33 +09:00
Dean Herbert	e346b02ebf	Add display of current renderer	2023-03-26 20:09:35 +09:00
Dean Herbert	91da546ba2	Merge branch 'master' into add-renderer-selection	2023-03-26 19:33:15 +09:00
Dean Herbert	c803eb8e04	Update framework	2023-03-26 16:14:15 +09:00
Dean Herbert	d31b37e87e	Merge branch 'master' into fix-ubo-not-bound	2023-03-26 16:14:11 +09:00
Joseph Madamba	eaef5ff2a3	Fix now playing playlist not highlighting selected item on initial open	2023-03-25 22:13:51 -07:00
Joseph Madamba	e1906a90eb	Use image@2x from tournament banner api	2023-03-25 13:08:46 -07:00
Joseph Madamba	450c5cef07	Add comment explaining loading container padding	2023-03-24 18:42:34 -07:00
Terochi	e6f1ec57a9	Bring back and make use of clearPreviousSamples()	2023-03-23 18:46:48 +01:00
Dean Herbert	ab6cfea5c7	Revert old value instead of always using default ... Co-authored-by: cdwcgt <loginchen@outlook.com>	2023-03-23 11:27:05 +09:00
cdwcgt	26f2d9047d	code style fix	2023-03-23 01:11:44 +09:00
cdwcgt	85a924f078	why ... merge problem?	2023-03-23 01:02:17 +09:00
cdwcgt	8518d15b8d	use endpoint	2023-03-23 01:00:38 +09:00
Dean Herbert	3050a16bf8	Don't require a restart when selecting Automatic and startup setting was also automatic	2023-03-22 16:56:36 +09:00
Dean Herbert	aabe86dc26	Limit renderers to those available for the current platform	2023-03-22 16:49:29 +09:00
Dean Herbert	956fabb445	Show restart notice when changing renderer	2023-03-22 16:49:29 +09:00
Dean Herbert	13be709718	Add basic renderer selection	2023-03-22 16:49:29 +09:00
Dean Herbert	ad5bdf6511	Merge branch 'master' into fix-ubo-not-bound	2023-03-22 16:46:39 +09:00
Dean Herbert	9bc6b46e4e	Update framework	2023-03-22 16:36:05 +09:00
Dean Herbert	db227b1798	Merge branch 'master' into chat-report	2023-03-22 16:26:28 +09:00
Joseph Madamba	6f3bb85eaa	Always show down arrow on inactive sort buttons	2023-03-22 00:19:23 -07:00
Dean Herbert	c65a79614d	Don't show offset calibration controls when "relax" mod is active ... Closes https://github.com/ppy/osu/issues/22892.	2023-03-22 15:45:04 +09:00
Dean Herbert	425be20e46	Fix song select search textbox font size incorrectly having increased	2023-03-22 14:17:39 +09:00
Joseph Madamba	d9571b6fc9	Move filter control property setters to load()	2023-03-21 21:31:35 -07:00
Joseph Madamba	74a15d7424	Fix overlay headers being blocked by loading layer	2023-03-21 20:32:26 -07:00
Joseph Madamba	e1fb63e1f3	Move beatmap listing filter control to header	2023-03-21 20:32:26 -07:00
Terochi	1478a26cc0	Addressed changes	2023-03-21 23:15:49 +01:00
Joseph Madamba	3cd01ee621	Fix beatmap listing sort direction not resetting when changing criteria	2023-03-21 15:08:37 -07:00
Joseph Madamba	df3ccdff9f	Add failing beatmap listing sort direction on criteria change test	2023-03-21 15:08:37 -07:00
Bartłomiej Dach	9ff9cd3b7f	Merge branch 'master' into skin-editor-cyclic-selection	2023-03-21 19:49:55 +01:00
Dean Herbert	e31a90e043	Don't cycle selection when more than one items are selected	2023-03-21 21:31:10 +09:00
Dean Herbert	5cb8160eee	Merge pull request #22773 from peppy/show-song-select-visible-beatmap-count ... Show count of visible beatmaps at song select	2023-03-21 18:22:29 +09:00
Bartłomiej Dach	ea8da69263	Fix importing beatmaps not changing count of visible beatmaps ... Reproduction steps: 1. Go to song select 2. Open beatmap listing 3. Import a beatmap that would fit the current filter criteria 4. The count of visible beatmaps does not change Fixed by updating the count on `BeatmapSetsChanged` too.	2023-03-20 20:53:53 +01:00
Bartłomiej Dach	695ee39b87	Privatise setter	2023-03-20 20:30:54 +01:00
Dean Herbert	bec28cc7f1	Merge pull request #22883 from smoogipoo/fix-logo-animation ... Use custom vertex shader for logo animation	2023-03-20 16:36:43 +09:00
Dean Herbert	8557589a35	Update resources	2023-03-20 15:28:13 +09:00
Joseph Madamba	970df5d88a	Update profile kudosu section in line with web	2023-03-18 19:49:30 -07:00
Dan Balasescu	c08513d590	Actually use custom vertex action	2023-03-17 20:47:11 +09:00
Dan Balasescu	bcd24873d6	Use custom vertex type	2023-03-17 20:37:05 +09:00
Dean Herbert	8bdb89d05d	Update resources	2023-03-17 19:12:43 +09:00
Dan Balasescu	1c3b60b9e6	Use custom vertex shader for logo animation	2023-03-16 23:56:41 +09:00
Salman Ahmed	678e8ed736	Update UBO usages inline with framework changes	2023-03-16 14:06:35 +03:00
Cootz	54f864463c	Merge branch 'master' into BitmapUpdatesOnScore	2023-03-16 13:54:47 +03:00
cdwcgt	d025c441ca	delay mod save after click save or not popover hidden	2023-03-16 19:48:45 +09:00
Dean Herbert	cb9b14b30f	Revert "Merge pull request #22741 from cdwcgt/do-not-fetch-deletePending" ... This reverts commit 15c44a2817, reversing changes made to de2ab05e78.	2023-03-16 19:48:36 +09:00
cdwcgt	42bcc8bafc	revert mod store	2023-03-16 19:38:15 +09:00
Cootz	556964eae0	Merge branch 'master' into BitmapUpdatesOnScore	2023-03-16 12:16:42 +03:00
Dean Herbert	3b62f87b64	Ensure Player does not fail a score on exit if a replay is currently loaded	2023-03-16 17:14:20 +09:00
Dean Herbert	15c44a2817	Merge pull request #22741 from cdwcgt/do-not-fetch-deletePending ... Don't fetch `beatmapset` that already `PendingDelete` when import score	2023-03-16 16:37:18 +09:00
Dean Herbert	cd102da3af	Move matches string inside text box	2023-03-16 16:34:31 +09:00
Dean Herbert	8e6a4559e3	Add xmldoc for new method and reorder methods in SkinReloadableDrawable	2023-03-16 15:58:42 +09:00
Dean Herbert	297e7d6542	Fix Flush call being run too late in PoolableSkinnableSample	2023-03-16 15:33:30 +09:00
Dean Herbert	89b42ddd98	Don't localise beatmap count string for now	2023-03-16 15:02:38 +09:00
Dean Herbert	7b34607676	Merge branch 'master' into bubble_mod_implementation_clean	2023-03-16 13:45:22 +09:00
Terochi	edc6314634	Drank some coffee and figured out the fix	2023-03-15 10:49:59 +01:00
Dean Herbert	5f9b13a775	Rename Add/AddRange methods as they are no longer conflicting with Container	2023-03-15 18:02:41 +09:00
Dean Herbert	9e444af380	Use object initialisers and fix order of initialisation vs add	2023-03-15 18:02:26 +09:00
Terochi	b0f1a69523	Update the pauseLoop sample instantly on skin change	2023-03-15 09:05:34 +01:00
Terochi	a9c349fa6d	Cache any skin changes in SkinReloadableDrawable to ScheduledDelegate	2023-03-15 09:03:29 +01:00
Dean Herbert	de2ab05e78	Merge pull request #22765 from Joehuu/fix-overlay-sidebar-scroll ... Fix overlay sidebars not scrolling to end due to parent scroll view	2023-03-15 16:52:59 +09:00
Dean Herbert	0a19b1e9cf	Merge pull request #22860 from rozukke/fix-skin-ini-import ... Fix import of skins with non-ASCII names that have been previously exported by lazer	2023-03-15 15:36:51 +09:00
Dean Herbert	f8e773ab8e	Merge branch 'master' into fix-overlay-sidebar-scroll	2023-03-15 15:30:50 +09:00
Dean Herbert	1cf870d956	Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection	2023-03-15 15:16:48 +09:00
Terochi	390ad335d0	Reloading samples before playing then when skin change occurs	2023-03-14 21:35:52 +01:00
Terochi	1d5e596615	Update FailAnimation to use SkinnableSound	2023-03-14 20:44:30 +01:00
Dean Herbert	f91af8fa64	Merge pull request #22750 from smoogipoo/veldrid-renderer ... Update graphic code in line with framework renderer changes	2023-03-15 00:29:54 +09:00
Dean Herbert	6546f5968a	Merge branch 'master' into skin-editor-cyclic-selection	2023-03-14 20:43:56 +09:00
Dean Herbert	b46fc14e56	Merge pull request #22848 from Rovearix/Fix-Dragging-Preventing-Beatmap-Loading ... Prevent LoadingLayer from blocking loading	2023-03-14 20:42:10 +09:00
Dean Herbert	d65d09e45f	Change field to const	2023-03-14 20:24:39 +09:00
Dean Herbert	8fd07b51f7	Merge pull request #22842 from LumpBloom7/Fix-argon-progress-bar-oversized-fill ... Fix argon progress bar fill being oversized	2023-03-14 18:46:25 +09:00
Dean Herbert	4cea29402b	Don't show epilepsy warning when storyboards are disabled ... I have more thoughts on this warning in general (which will likely see it removed or moved in the future) but this seems like a quick QOL fix for now. As mentioned in https://github.com/ppy/osu/discussions/22861.	2023-03-14 18:32:26 +09:00
Dean Herbert	0b23809585	Update resources	2023-03-14 17:52:17 +09:00
Dean Herbert	48d11610b3	Update framework	2023-03-14 17:44:51 +09:00
Dean Herbert	969c0e9c9d	Merge branch 'master' into veldrid-renderer	2023-03-14 17:35:38 +09:00
Rovearix	9ac9287dbd	Switched the implementation to set the blockInput flag for the BeatmapMetadataDisplay's LoadingLayer. This prevents the UIEvents from being being handled in this case without modifying the class	2023-03-13 08:07:55 -04:00
Rovearix	ba728bdab1	Changed the event to be the more correct one to block	2023-03-13 07:49:51 -04:00
rozukke	1f7721786b	Perform check to account for non-ASCII characters	2023-03-13 22:01:26 +11:00
Dean Herbert	da947d8661	Gracefully handle beatmaps specifying images using the video storyboard type	2023-03-13 18:24:16 +09:00
Dean Herbert	eb37d740b1	Update supported video filetypes to match osu-stable	2023-03-13 18:24:16 +09:00
Rovearix	c1618a7a16	Prevent elements that are anchored in the center from blocking loading	2023-03-12 10:57:53 -04:00
Joseph Madamba	6e5b1280b7	Fix multiple notice boxes having no spacing	2023-03-11 21:36:29 -08:00
Joseph Madamba	ea88aee41f	Display stub notice in marked wiki articles	2023-03-11 21:36:28 -08:00
Joseph Madamba	0cf69a1084	Make yaml line strings verbatim	2023-03-11 21:36:23 -08:00
Derrick Timmermans	febdca4547	Fix argon progress bar fill being oversized	2023-03-12 02:08:00 +01:00
Terochi	8e8dda3ac0	Big simplifying	2023-03-11 23:29:36 +01:00
Dan Balasescu	e327993d11	Merge pull request #22527 from Terochi/replay-length-extension ... Replay recording extension until results screen transition	2023-03-11 15:41:32 +09:00
cdwcgt	15f11bb1e8	scorll container and save mod after popover hidden ... Requires manual handling of many visual effects	2023-03-11 12:31:33 +09:00
cdwcgt	1cd565193e	public CheckCurrentModCanBeSave	2023-03-11 11:39:35 +09:00
cdwcgt	8b0f127ff2	split ModPresetRow	2023-03-11 11:25:52 +09:00
Terochi	b51c41a804	Addressed changes	2023-03-09 20:14:58 +01:00
cdwcgt	f4e2620402	fix test	2023-03-10 00:56:22 +09:00
cdwcgt	ca416175bb	remove useless property	2023-03-09 22:58:44 +09:00
cdwcgt	3d746e8dfb	content Menu	2023-03-09 22:49:33 +09:00
cdwcgt	5a1316f0e5	split save logic	2023-03-09 22:43:06 +09:00
tsrk	d806b85a30	revert: make counters an IEnumerable again ... As suggested by bdach as this would make the last two commits useless Refs: 5d15426	2023-03-09 10:25:03 +00:00
Dean Herbert	d95bcb10cc	Merge pull request #22744 from EXtremeExploit/groups-badges-list ... Add group badges to list view	2023-03-09 15:45:46 +09:00
Bartłomiej Dach	ab87f5e0c9	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-03-08 22:37:09 +01:00
EXtremeExploit	686259a33c	Make support badge in list match groups	2023-03-08 13:57:20 -03:00
Dean Herbert	4f7be332f3	Revert isDraggingBlueprint to field	2023-03-08 19:24:03 +09:00
Dean Herbert	245c3c025c	Refactor endClickSelection to reduce nesting	2023-03-08 19:23:32 +09:00
tsrk	5d15426c27	refactor: make Counters return a Container	2023-03-08 01:52:12 +00:00
tsrk	5b0db94a24	docs: add XMLDoc for methods in KCD	2023-03-08 00:58:54 +00:00
tsrk	44297a7d0a	refactor: make KCD a CompositeDrawable	2023-03-08 00:47:16 +00:00
Bartłomiej Dach	72695f7c90	Merge branch 'master' into omit-barline-in-timing-control-point	2023-03-07 22:46:24 +01:00
Bartłomiej Dach	6c5ccdfd90	Merge branch 'master' into optimise-search	2023-03-07 22:07:29 +01:00
Bartłomiej Dach	12af002c4d	Reorder and add xmldoc to KeyCounter members	2023-03-07 21:28:42 +01:00
Bartłomiej Dach	98f40b2679	Improve documentation of InputTrigger	2023-03-07 21:22:59 +01:00
Bartłomiej Dach	5213bfa5c9	Merge branch 'master' into make_skin_reset_dangerous	2023-03-07 21:06:44 +01:00
Terochi	8bf84869a5	Fixed errors covered in new tests	2023-03-07 20:39:50 +01:00
Bartłomiej Dach	cfafa8af8c	Merge branch 'master' into hud/player-components	2023-03-07 19:44:12 +01:00
Bartłomiej Dach	7ade525eef	Display corner radius setting as percentage	2023-03-07 19:43:52 +01:00
Cootz	5d41d343fd	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-03-07 15:46:52 +03:00
Cootz	7107834b9e	Fix truncating bug	2023-03-07 15:43:03 +03:00
Cootz	5191204569	Bring truncating logic back to Export method	2023-03-07 15:39:43 +03:00
cdwcgt	54564e0557	new design	2023-03-07 21:13:35 +09:00
Dean Herbert	97bee4db89	Fix localisations	2023-03-07 18:07:53 +09:00
Dean Herbert	26ef7c2637	Rename confirmation dialog class to mention revert not reset	2023-03-07 18:07:46 +09:00
Dean Herbert	55467fcbe3	Update xmldoc for DangerousActionDialog to match new behaviour	2023-03-07 18:07:46 +09:00
Dean Herbert	dc2945f4f8	Move avatar user loading to BDL also	2023-03-07 17:39:21 +09:00
Dean Herbert	5af41bb1c8	Move filter matching code into own method to simplify early returns	2023-03-07 17:24:17 +09:00
Dean Herbert	5e90b67be0	Move GameplayState usage to BDL	2023-03-07 17:01:29 +09:00
Dean Herbert	d98199961b	Adjust default sizing to fit a bit better with existing elements	2023-03-07 17:00:10 +09:00
Dean Herbert	f7f1dff647	Fix incorrect case of localisable string for "corner radius"	2023-03-07 16:45:33 +09:00
Dean Herbert	6a7c4d0bf7	Remove NRT disables in new classes	2023-03-07 16:41:39 +09:00
Dean Herbert	97ba236eb1	Add basic xmldoc to KeyCounter classes	2023-03-07 16:41:39 +09:00
Dean Herbert	28520414aa	Move KeyCounter components to HUD namespace	2023-03-07 16:41:39 +09:00
Dean Herbert	15d65059b5	Tidy up Add method logic	2023-03-07 16:21:57 +09:00
Dean Herbert	8f6df5ea0f	Merge branch 'master' into gameplay/key-counter-abstraction	2023-03-07 16:09:45 +09:00
Dean Herbert	2cce785fa5	Fix storyboard videos not fading out on completion ... Closes https://github.com/ppy/osu/issues/22802. Stable uses a 1,000 ms fade-in / out. Rather than matching that, I've stuck with 500ms (what lazer was already using for the fade-in) because I think it feels better. Tested using the beatmap linked in the issue thread.	2023-03-07 15:54:35 +09:00
Dean Herbert	21bdbb20e6	Add optional support for cyclic selection to BlueprintContainer	2023-03-07 14:22:12 +09:00
tsrk	fc0e27fb15	style: use normalised CornerRadius values	2023-03-06 20:11:52 +00:00
tsrk	952814604e	style: fix late night oopsies	2023-03-06 20:06:56 +00:00
cdwcgt	4858d3fd42	Added ability to edit mod presets	2023-03-07 02:00:40 +09:00
Bartłomiej Dach	ec15e2b9cc	Merge branch 'master' into dont-filter-results-on-sort-mode	2023-03-06 17:57:47 +01:00
OliBomby	1fcf41379d	Added maintainability patch by bdach	2023-03-06 16:20:36 +01:00
tsrk	3a240aaa5f	style: use 64 radius	2023-03-06 10:27:59 +00:00
Dean Herbert	87d0bef313	Use nullable comparison helper method instead of manual implementation	2023-03-06 15:16:32 +09:00
tsrk	07bde4990d	feat: implement PlayerAvatar	2023-03-05 23:17:39 +00:00
tsrk	20a610ea6c	style: a NRT pass on UpdateableFlag	2023-03-05 23:15:58 +00:00
tsrk	654eacd449	feat(l10n): localise CornerRadius	2023-03-05 23:10:42 +00:00
tsrk	082bfe3621	refactor: SkinnableAvatar to PlayerAvatar	2023-03-05 23:09:02 +00:00
mk56-spn	908651cc11	make ResetConfirmDialog properly utilise its parent's logic ... Adjust name of `DeleteAction` to `DangerousAction`	2023-03-05 20:57:26 +01:00
OliBomby	b0cd801405	fix code quality	2023-03-04 19:34:22 +01:00
OliBomby	5146f7c978	using array again in GetSearchableTerms	2023-03-04 16:49:46 +01:00
OliBomby	70a925aab1	added extra early-returns	2023-03-04 16:49:33 +01:00
OliBomby	b90c389ff0	using List instead of Span in GetSearchableTerms	2023-03-04 15:42:35 +01:00
Bartłomiej Dach	60cdd3c070	Clear components sidebar unconditionally on every target change ... Fixes the working layer dropdown lingering after exiting from a skinnable screen to a non-skinnable one.	2023-03-04 14:10:05 +01:00
Bartłomiej Dach	d233f3a3ab	Show non-skinnable screen placeholder at higher level	2023-03-04 13:49:10 +01:00
Bartłomiej Dach	49e298e304	Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer ... An end result of #22674 is that `SkinBlueprintContainer`s are only ever created by supplying a `SkinComponentsContainer` to them. However, `SkinBlueprintContainer` still contained remnants of code that suggested it was designed to handle cases where more than the drawable supplied to it contained more than one `ISerialisableDrawableContainer`, or even zero. The zero path is totally dead right now (because every `SkinComponentsContainer` is *by necessity* an `ISerialisableDrawableContainer`), and the more-than-one path is dead *for now* (and potentially forever?). Therefore, just hard-couple `SkinBlueprintContainer` to receive a single target container.	2023-03-04 13:33:21 +01:00
Bartłomiej Dach	2f25fb4083	Move NonSkinnableScreenPlaceholder to outer scope	2023-03-04 13:22:43 +01:00
Bartłomiej Dach	15409b9c15	Fix skin selection not clearing on exit to non-skinnable screen	2023-03-04 13:18:34 +01:00
tsrk	d5ba5eed88	fix(SkinnableAvatar): init avatar.CornerRadius	2023-03-03 23:47:22 +00:00
tsrk	d39b8c7c23	fix(SkinnableAvatar): update outdated interface	2023-03-03 19:35:45 +00:00
EXtremeExploit	edd37a9a7c	cleanup	2023-03-03 16:16:45 -03:00
EXtremeExploit	e23db62386	Do list group'badges in a nicer way	2023-03-03 16:14:19 -03:00
Ruki	e75aa9138b	Merge branch 'ppy:master' into hud/avatar-thing	2023-03-03 20:03:56 +01:00
OliBomby	91d206e8d2	Optimised GetSearchableTerms ... Reduced memory allocations to 1	2023-03-03 19:21:50 +01:00
Cootz	322f3e86ba	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-03-03 20:02:09 +03:00
mk56-spn	3bff415909	Change ResetDialogue text	2023-03-03 15:16:48 +01:00
mk56-spn	2b7111867c	Adjust reversion header text naming.	2023-03-03 15:12:20 +01:00
Dean Herbert	82293c0c86	Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes ... From a user's perspective, changing a sort / order mode shouldn't filter away results, but we were doing this. In terms of UX expectations, in stable this kind of scenario would results in a group being added to the end of son select with "Not ranked" or "Unknown". I think we should aim to match this eventually.	2023-03-03 16:36:18 +09:00
Dean Herbert	dc669835e2	Show count of visible beatmaps at song select	2023-03-03 15:28:51 +09:00
Dean Herbert	6ff1fb6b1a	Adjust sizing to allow for timing point information now being longer than before	2023-03-02 18:57:54 +09:00
Joseph Madamba	af540de69b	Fix "talking with" text overflowing when usernames are too long	2023-03-01 22:10:15 -08:00
Joseph Madamba	bb5791a714	Fix overlay sidebars not scrolling to end due to parent scroll view	2023-03-01 21:41:01 -08:00
Dean Herbert	bd11d5d29a	Merge pull request #22743 from Joehuu/scroll-back-to-previous ... Add ability to scroll back to previous position after scrolling to top via button on overlays	2023-03-01 22:55:47 +09:00
Andrei Zavatski	31f58a33ac	Use ColourInfo.Interpolate where possible	2023-02-28 18:47:27 +03:00
Dean Herbert	044b0604b2	Move OmitFirstBarLine to TimingControlPoint	2023-02-28 19:29:31 +09:00
Dean Herbert	89e20a7962	Update resources	2023-02-28 14:47:51 +09:00
Dean Herbert	bd1460a8d5	Update framework	2023-02-28 14:32:58 +09:00
mk56-spn	90227a6496	Rename DeleteConfirmationDialog.cs into DangerousActionDialog.cs	2023-02-27 21:57:59 +01:00
mk56-spn	00a00ead22	Make ResetConfirmDialog inherit from DeleteConfirmationDialog	2023-02-27 21:50:27 +01:00
mk56-spn	1239de6f41	Upper case web using alias	2023-02-27 21:34:07 +01:00
Bartłomiej Dach	92edb0f868	Merge branch 'master' into skin-editor-depth-changing	2023-02-27 19:24:53 +01:00
mk56-spn	bf1897a98f	Adjust warning text slightly.	2023-02-27 16:08:14 +01:00
EXtremeExploit	d722e09b2c	oops	2023-02-26 21:05:41 -03:00
EXtremeExploit	2b9d13cfee	Add group badges to list view	2023-02-26 20:58:20 -03:00
Joseph Madamba	fa710ae1b0	Rename ScrollToTopButton to ScrollBackButton	2023-02-26 14:39:34 -08:00
Joseph Madamba	dc00905f8d	Add ability to scroll back to previous position after scrolling to top via button on overlays	2023-02-26 14:38:51 -08:00
mk56-spn	ff0d1aa9f7	Make reverting changes to a given skin into a "dangerous action"	2023-02-26 20:38:50 +01:00
cdwcgt	a705698ab6	beatmapset that already deletePending should not be fetched	2023-02-26 21:13:05 +09:00
cdwcgt	1d5c87039e	typo	2023-02-26 15:28:43 +09:00
cdwcgt	e8092bff46	logic fix?	2023-02-26 15:28:24 +09:00
cdwcgt	fdf9544688	cancel handle	2023-02-26 15:28:10 +09:00
cdwcgt	a20e2685be	make static name fix	2023-02-25 20:11:08 +09:00
Dan Balasescu	a44c9d10d7	Fix buffer not being bound	2023-02-25 02:18:42 +09:00
Dan Balasescu	069b77dd23	Update language version	2023-02-25 02:15:56 +09:00
Dan Balasescu	dd9748a25c	Adjust DrawNodes to use UBOs	2023-02-25 01:42:55 +09:00
Terochi	09e7c21b23	Implemented a more complex setting conversion logic + tests	2023-02-24 15:11:22 +01:00
cdwcgt	78201c4649	log to database	2023-02-23 22:17:35 +09:00
cdwcgt	60bdae41b6	make static	2023-02-23 22:17:13 +09:00
Dean Herbert	dc3c1150b8	Set better defaults for SkinBlueprint transforms	2023-02-23 21:10:15 +09:00
cdwcgt	9e1eb50d9b	use log	2023-02-23 20:21:04 +09:00
cdwcgt	ba345e5591	delete notify post when duplicate export	2023-02-23 20:10:50 +09:00
Dean Herbert	c48aceb055	Fix undo history not being batched correctly for depth change operations	2023-02-23 20:03:36 +09:00
Bartłomiej Dach	d679703fa2	Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection ... Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play	2023-02-22 18:56:59 +01:00
tsrk	8c94b77de1	refactor(InputTrigger): move out of KCD ... I love JetBrains Rider.	2023-02-22 15:05:07 +00:00
tsrk	1beec71037	refactor(KeyCounterDisplay): apply suggestions ... I also took the freedom to add type checking, as we can't limit the usage of `Add()` since it's a Container. The exception thrown also advises of using the suggested `AddTrigger()` instead.	2023-02-22 14:58:27 +00:00
Dean Herbert	a8c692a215	Merge pull request #22635 from peppy/use-overlays-container-more ... Use `Overlays` container rather than `KeyBindingInputManager` for flashlight	2023-02-22 18:30:21 +09:00
Dean Herbert	16c8a392a1	Add ability to send selected skin components to front or back	2023-02-22 18:17:20 +09:00
Dean Herbert	6e48860c79	Update in line with framework menu handling changes	2023-02-22 17:13:55 +09:00
Terochi	e321536acc	Small clean up	2023-02-22 07:48:43 +01:00
Terochi	82b07d19f8	Fix of incorrect using optimization	2023-02-21 21:48:11 +01:00
Bartłomiej Dach	051eb18b33	Merge branch 'master' into skin-editor-layer-select	2023-02-21 21:38:51 +01:00
Bartłomiej Dach	ab97b02235	Remove contradictory remark from xmldoc	2023-02-21 21:05:46 +01:00
Terochi	dd53a70071	Addressed change requests	2023-02-21 21:01:31 +01:00
Bartłomiej Dach	3d2fcb0cca	Merge branch 'master' into fix-taiko-drum-nested-sample-detection	2023-02-21 20:53:06 +01:00
tsrk	42a5a06b9d	style(KeyCounter): fields and methods visiblity	2023-02-21 19:10:37 +00:00
tsrk	5bec2d7c52	style(KeyCounter): forwardPlayback	2023-02-21 19:02:56 +00:00
Bartłomiej Dach	ec1bf7b0b2	Merge branch 'master' into skin-editor-clipboard	2023-02-21 19:35:58 +01:00
Terochi	191604340f	Added a way for mod settings to be kept when changing ruleset + test	2023-02-21 19:05:10 +01:00
Cootz	1fa6864500	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-21 18:47:59 +03:00
Cootz	90aa4288d0	Reduce the allowed length by 5 to account for (99) suffix. Move truncating logic to GetFilename. Update tests.	2023-02-21 18:35:53 +03:00
cdwcgt	d20e1df603	wrong xmldoc ... because of 6900d0120a	2023-02-21 20:54:06 +09:00
cdwcgt	04dcd661e0	async logic fix	2023-02-21 20:53:02 +09:00
Dean Herbert	9384687d6d	Switch ModMuted to add its metronome to components rather than overlays	2023-02-21 19:04:06 +09:00
Dean Herbert	1acc536248	Move DrawableRuleset.Audio to a less generic level	2023-02-21 19:03:52 +09:00
Dean Herbert	af062e7a68	Change placeComponent to only add to selection, not clear an existing selection	2023-02-21 14:11:18 +09:00
Dean Herbert	5ba6059911	Merge branch 'master' into fix-taiko-drum-nested-sample-detection	2023-02-21 13:58:15 +09:00
Dean Herbert	0d229d959b	Remove unnecessary TriggerChange call	2023-02-21 13:50:19 +09:00
Bartłomiej Dach	6799492596	Merge branch 'master' into skin-editor-layer-select	2023-02-20 21:33:48 +01:00
Bartłomiej Dach	86a7f4dfd0	Do not serialise SkinLayoutInfo.AllDrawables ... - It is entirely derived from `SkinLayoutInfo.DrawableInfo`, which is the actual primary thing we want to serialise. - It will never get read out from any serialised files anyway (corollary of the previous point - it is a get-only property derived from another). - It is only used in tests. All of the three reasons above make serialising the property out to skin files nothing more than a waste of space.	2023-02-20 20:37:48 +01:00
Bartłomiej Dach	c9999bdeb1	Merge branch 'master' into skin-per-ruleset-layouts	2023-02-20 20:14:38 +01:00
Bartłomiej Dach	43724472c4	Clarify comment to avoid playing pronoun game	2023-02-20 20:09:24 +01:00
Dean Herbert	6382314af1	Merge pull request #22697 from ggliv/tablet-area-drag ... Allow tablet area to be dragged	2023-02-20 23:37:25 +09:00
Dean Herbert	43d33d45ca	Only add valid placed components to selected collection on paste	2023-02-20 20:02:43 +09:00
Dean Herbert	b68562b033	Make placeComponent resilient to missing dependencies	2023-02-20 20:00:12 +09:00
Dean Herbert	a9c7edd087	Remove copy pasted comment	2023-02-20 19:57:16 +09:00
Dean Herbert	7a585e1fa1	Merge pull request #22669 from EVAST9919/mod-overlay-triangles ... Add triangles animation to mod select overlay headers	2023-02-20 19:54:21 +09:00
Dean Herbert	ec12186d63	Remove unnecesasry null check on content	2023-02-20 19:53:04 +09:00
Dean Herbert	18700b4daa	Add note about skin migrations being on read and remove an older deprecation notice	2023-02-20 19:51:54 +09:00
Dean Herbert	1629c86b5d	Mark constant identifier as non-localisable ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-02-20 19:48:39 +09:00
Dean Herbert	0ddda018fd	Add xmldoc for SkinComponentsContainerLookup.Ruleset ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-02-20 19:48:18 +09:00
Dean Herbert	5f7a6d13c3	Remove unused GetSerialisableIdentifier for now	2023-02-20 19:47:17 +09:00
Gabe Livengood	c86c1a9029	allow tablet area to be dragged	2023-02-20 00:06:20 -05:00
MK56	b74c1c8334	Merge branch 'master' into bubble_mod_implementation_clean	2023-02-19 21:36:59 +01:00
Bartłomiej Dach	3183f5cee2	Merge branch 'master' into revert-result-in-playfield	2023-02-19 16:33:10 +01:00
Bartłomiej Dach	1ba1298850	Merge branch 'master' into blueprint-improve-visuals	2023-02-19 15:55:30 +01:00
Dean Herbert	d7381b762c	Also tween origin position	2023-02-19 23:52:21 +09:00
Bartłomiej Dach	d9ca7102f0	Use more generic wording for future-proofing	2023-02-19 15:06:40 +01:00
Bartłomiej Dach	aac32a2c9f	Combine config and time checks into one ... Functionally equivalent right now, but the combined variant is more localised to what it actually needs to do, and less error-prone if any new code gets appended to the method.	2023-02-19 13:14:51 +01:00
Maximilian Kruse	723a043c43	naming change from Hitobject to HitObject	2023-02-19 10:18:22 +01:00
Maximilian Kruse	f3522c4162	change bindable seekToHitObject to private	2023-02-19 10:18:02 +01:00
Maximilian Kruse	ddd37bb319	Add setting to disable automatic seeking after object placement	2023-02-18 19:43:45 +01:00
cdwcgt	0667b83960	Path.GetExtension() will not get null	2023-02-19 02:56:53 +09:00
cdwcgt	229b31520f	remove ()	2023-02-19 02:42:33 +09:00
cdwcgt	fba99b344c	Accidentally deleted using ... wtf	2023-02-19 02:41:08 +09:00
cdwcgt	79715fe37b	catch when zipWriter dispose ... ObjectDisposedException also appear when zipwriter dispose after user request cancel	2023-02-19 02:24:07 +09:00
cdwcgt	8446e7d841	comment	2023-02-19 02:17:24 +09:00
cdwcgt	2a6ea99e6a	store exportingModels for all exporter ... No one wants to export multiple copies of the same model at the same time, right?	2023-02-19 02:09:59 +09:00
cdwcgt	30985f192e	catch ObjectDisposedException	2023-02-19 02:06:07 +09:00
cdwcgt	d611603742	catch OperationCanceledException	2023-02-19 01:45:09 +09:00
cdwcgt	309e9b24e2	split LegacyArchiveExporter	2023-02-19 01:18:27 +09:00
Bartłomiej Dach	ea04c487f2	Merge branch 'master' into blueprint-labels-while-hovering	2023-02-18 15:57:30 +01:00
Cootz	5fa75805cc	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-18 15:52:17 +03:00
Bartłomiej Dach	15d209d17e	Merge branch 'master' into CompletionText-LocalisableString	2023-02-18 13:50:58 +01:00
Bartłomiej Dach	fbea3e312f	Merge branch 'master' into skin-editor-improve-toolbox-hover	2023-02-18 10:02:02 +01:00
Bartłomiej Dach	704dddf14b	Merge branch 'master' into skin-editor-clipboard	2023-02-17 22:59:18 +01:00
Bartłomiej Dach	6b9472c367	Merge branch 'master' into skin-per-ruleset-layouts	2023-02-17 22:58:38 +01:00
Bartłomiej Dach	2aa4481f68	Fix toolbox items spontaneously contracting after briefly losing hover ... Reproduction scenario: 1. Hover a toolbox item 2. Unhover the item, but do not hover any other item (can be done by exiting the toolbox completely to the right) 3. Come back to the item hovered in step (1) 4. The item would spontaneously contract after a second	2023-02-17 22:54:11 +01:00
Bartłomiej Dach	b390fdb8cc	Remove unused field	2023-02-17 21:51:19 +01:00
Bartłomiej Dach	8894a73b07	Merge branch 'master' into blueprint-improve-visuals	2023-02-17 21:40:16 +01:00
Andrei Zavatski	ffcca9fd89	Remove awkward width specification	2023-02-17 23:23:58 +03:00
Bartłomiej Dach	6afa65bd3d	Merge branch 'master' into skinnable-clean-up-documentation	2023-02-17 20:59:18 +01:00
Salman Ahmed	449e5fa6f8	Rename one more left-over skinnable naming	2023-02-17 22:09:55 +03:00
cdwcgt	dbb366e279	CompletionText can be a LocalisableString ... I can't find a reason for not doing this, probably this was forgotten in https://github.com/ppy/osu/pull/15440	2023-02-17 22:32:03 +09:00
cdwcgt	843d841f5a	GetFilename and something other ... https://github.com/ppy/osu/pull/21739	2023-02-17 22:23:50 +09:00
cdwcgt	29d6483e17	ConfigureAwait for awaited task	2023-02-17 22:19:24 +09:00
cdwcgt	e84e011d5d	Merge branch 'master' into export	2023-02-17 22:15:19 +09:00
cdwcgt	eac0aa79a3	cancellationToken pass, notification adujust	2023-02-17 22:09:09 +09:00
Cootz	e3bdb3d852	Align links in one line	2023-02-17 15:32:36 +03:00
Cootz	fd1beaef87	Fix typo	2023-02-17 15:24:27 +03:00
Cootz	a3b440493a	Update xml doc	2023-02-17 15:23:43 +03:00
Andrei Zavatski	51940133df	Adjust width and add comment	2023-02-17 15:18:45 +03:00
Andrei Zavatski	0838fa636f	Make triangles slower	2023-02-17 15:16:00 +03:00
Andrei Zavatski	fa300b5ba0	Merge branch 'master' into mod-overlay-triangles	2023-02-17 15:13:51 +03:00
Cootz	ceed3606cd	Remove redundant comment ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-02-17 13:46:06 +03:00
Dean Herbert	0a018514e1	Make skin editor focus only one layer at a time	2023-02-17 19:27:16 +09:00
Dean Herbert	00fcee0c5a	Add per-ruleset component toolbox and placement support	2023-02-17 19:27:16 +09:00
Dean Herbert	ba5a87ca04	Add basic target layer selection in skin editor	2023-02-17 19:27:16 +09:00
Dean Herbert	c03b6cec23	Add IEquatable and ToString support to SkinComponentsContainerLookup	2023-02-17 19:27:16 +09:00
Dean Herbert	a01c3090e4	Fix tests which rely on HUDOverlay's DrawableRuleset being nullable	2023-02-17 19:27:09 +09:00
Dean Herbert	5ed038fbb3	Improve the feel of hovering toolbox component items	2023-02-17 19:26:03 +09:00
Dean Herbert	814080d982	Only show blueprint labels when hovering or selected	2023-02-17 19:23:52 +09:00
Dean Herbert	19d5293ad1	Change early return to also find the earliest nested object	2023-02-17 18:59:31 +09:00
Dean Herbert	209d41ee9d	Use RulesetInfo instead of Ruleset in skin components lookup	2023-02-17 18:24:05 +09:00
Dean Herbert	675e5b81f3	Fix SkinnableLighting showing up as a user placeable component	2023-02-17 18:24:05 +09:00
Dean Herbert	2267aa1ac2	Add ability to retrieve serialisable drawables for specific rulesets	2023-02-17 18:24:05 +09:00
Dean Herbert	ffb99364b9	Ensure skin default component layouts only apply to global layout for now	2023-02-17 18:24:05 +09:00
Dean Herbert	6c61c5f4a8	Fix selection on the edge of blueprints (in the new inflation area) failing	2023-02-17 18:19:46 +09:00
Dean Herbert	16d94b4ea2	Improve visuals of skin blueprint	2023-02-17 18:19:46 +09:00
tsrk	8830e06588	fix: compilation	2023-02-17 09:17:11 +00:00
tsrk	c94e647e21	style(KeyCounterDisplay): remove type check	2023-02-17 09:09:56 +00:00
Dean Herbert	9793774377	Update SkinDeserialisationTest to work with new serialisation structure	2023-02-17 16:22:48 +09:00
Dean Herbert	6b3652f567	Change serialisation format of skin layouts to allow more flexibility ... Also adds per-ruleset storage for each container type.	2023-02-17 14:19:19 +09:00
Dean Herbert	9685fb2114	Always return a non-null container for SkinComponentsContainerLookups	2023-02-17 14:19:19 +09:00
Dean Herbert	4cc6664dc7	Add optional ruleset identifier to SkinComponentsContainerLookup	2023-02-17 14:19:19 +09:00
Dean Herbert	1a63ca9ece	Add xmldoc around SkinComponentsContainerLookup	2023-02-17 14:18:05 +09:00
Dean Herbert	8c772a723f	Expose constant publicly rather than reexposing business	2023-02-17 13:34:19 +09:00
Dean Herbert	96b1498932	Rename max length variable to make sense (it's a filename limit, not path)	2023-02-17 13:33:22 +09:00
tsrk	d0e8d65766	style(KeyCounter): rename IsLit to IsActive	2023-02-17 00:56:17 +00:00
Andrei Zavatski	a84f20bf32	Add triangles to ModSelectColumn	2023-02-17 03:09:32 +03:00
tsrk	e3ca751027	refactor: make FillFlowContainer read-only	2023-02-16 23:17:47 +00:00
tsrk	c61fac578c	style(KeyCounter): rename methods and arguments ... As for the second suggestion in https://github.com/ppy/osu/pull/22654#discussion_r1109047998, I went with the first one as only one Trigger actually uses this argument for rewinding.	2023-02-16 23:15:03 +00:00
Cootz	810712386d	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-17 01:51:24 +03:00
tsrk	ddd6c1a1c6	refactor(KeyCounter): address bindables issues ... `IsCounting` is back being an auto-property. `countPresses` is now encapsulated and being exposed as an `IBindable<int>` via `CountPresses`	2023-02-16 22:20:34 +00:00
tsrk	6340730427	refactor(KeyCounter): remove circularity	2023-02-16 21:59:39 +00:00
Bartłomiej Dach	3ee046000e	Merge branch 'master' into revert-result-in-playfield	2023-02-16 21:54:29 +01:00
Bartłomiej Dach	66e9bb2581	Merge branch 'master' into hide-resume-overlay	2023-02-16 21:33:23 +01:00
Bartłomiej Dach	b8084a15eb	Revert ResumeOverlay setter accessibility change	2023-02-16 21:26:01 +01:00
Bartłomiej Dach	0186062246	Merge branch 'master' into adjust-song-select-background-dim	2023-02-16 20:52:36 +01:00
Bartłomiej Dach	ad5132ed41	Remove redundant conditional access qualifier ... It is impossible for the callback passed to `ApplyToBackground()` to receive a null reference. See `OsuScreen.ApplyToBackground()` - if the background to call the callback on were `null`, then an `InvalidOperationException` would be thrown instead.	2023-02-16 20:47:51 +01:00
Cootz	f1da213bea	Add tests	2023-02-16 16:26:57 +03:00
Dean Herbert	cb7df7282b	Apply NRT to SerialisedDrawableInfo	2023-02-16 20:01:59 +09:00
Cootz	3057ccb635	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-16 13:22:11 +03:00
Dean Herbert	394d368f16	Fix song select potentially updating background parameters when not the current screen	2023-02-16 18:45:22 +09:00
Dean Herbert	affa9507a1	Fix GameplaySampleTriggerSource not considering nested objects when determining the best sample to play	2023-02-16 18:21:33 +09:00
Dean Herbert	ce9ef3bc3c	Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not	2023-02-16 15:47:20 +09:00
Dean Herbert	7afdcb9383	Merge branch 'master' into hide-resume-overlay	2023-02-16 15:42:14 +09:00
Dean Herbert	81dcc105a9	Rename left-over skinnable naming in SerialisedDrawableExtensions	2023-02-16 15:34:41 +09:00
Dean Herbert	76f7accd13	Standardise all local SkinComponentsContainerLookup variables to containerLookup	2023-02-16 15:33:56 +09:00
Dean Herbert	eea0cd3cf8	Reword xmldoc on ISerialisableDrawable to make less skin-centric	2023-02-16 15:31:35 +09:00
Dean Herbert	0b25f7baeb	Reword and fix typos in some new xmldoc ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-02-16 15:27:30 +09:00
Bartłomiej Dach	c315113fde	Merge branch 'master' into maximum-judgement-offset-in-hit-object	2023-02-16 00:15:51 +01:00
tsrk	74e7cc2056	feat: implement new design of key counter	2023-02-15 22:18:02 +00:00
tsrk	e9dcc257b4	reafactor: simplify type checking	2023-02-15 22:06:35 +00:00
tsrk	b0a2e69f95	style: nullable pass on KeyCounterDisplay	2023-02-15 22:06:10 +00:00
tsrk	076eb81b21	refactor: rename trigger classes ... Makes it better to understand their purpose	2023-02-15 21:46:13 +00:00
tsrk	a644fae364	style(KeyCounter): rename (Un)lit methods to (Un)light	2023-02-15 21:41:41 +00:00
tsrk	df0633858c	fix(KeyCounter): don't override Handle ... This caused the Keyboard inputs to register twice, which is not what we want.	2023-02-15 21:41:41 +00:00
tsrk	157bba7830	refactor: rename Trigger class to InputTrigger	2023-02-15 21:41:36 +00:00
Bartłomiej Dach	768eea1ea8	Merge branch 'master' into skinnable-clean-up-documentation	2023-02-15 21:26:11 +01:00
Bartłomiej Dach	1d5d34ba0e	Merge pull request #22647 from peppy/remove-target-component-container ... Simplify and rename `SkinnableTargetComponentsContainer`	2023-02-15 21:25:49 +01:00
Cootz	387a6f1330	Move logic to Export method	2023-02-15 22:43:43 +03:00
Cootz	fb06a77e2b	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-15 22:29:38 +03:00
Cootz	1f586c129c	fix applied	2023-02-15 22:15:44 +03:00
Dean Herbert	925deb7ca5	Make skin editor clipboard shared between screens and skins to allow moving elements over	2023-02-15 19:35:37 +09:00
Dean Herbert	bc83b0c264	Fix clipboard changes not batching as undo steps	2023-02-15 19:35:22 +09:00
Dean Herbert	bcf2555545	Fix components having incorrect default positions	2023-02-15 19:34:42 +09:00
Dean Herbert	d653335b6f	Add basic skin editor clipboard implementation	2023-02-15 19:28:42 +09:00
Dean Herbert	08ed174f61	Change GameplaySkinComponentLookup's generic to always be an enum ... And document the class better.	2023-02-15 18:48:14 +09:00
Dean Herbert	a92e42bb84	Rename SkinnableTargetContainer to SkinComponentsContainer ... Also use full `SkinComponentsContainerLookup` instead of the sub-type. This will potentially be useful once we bring in per-ruleset targets.	2023-02-15 18:37:41 +09:00
Dean Herbert	b1cf6d83d8	Move extension methods closer to serialisation classes	2023-02-15 18:37:41 +09:00
Dean Herbert	e61d2d571c	Move the lookup type out of ISserialisableDrawableContainer	2023-02-15 18:37:41 +09:00
Dean Herbert	a7b47f6503	Rename ISkinnableTarget to ISerialisableDrawableContainer	2023-02-15 18:37:41 +09:00
Dean Herbert	d159d6b970	Rename ISkinnableDrawable to ISerialisableDrawable	2023-02-15 18:37:41 +09:00
Dean Herbert	8cb5a51aa7	Add further documentation to skin classes	2023-02-15 18:23:19 +09:00
Dean Herbert	856efd9fd9	Rename SkinnableDrawableInfo to SerialisedDrawableInfo	2023-02-15 18:23:19 +09:00
Dean Herbert	9e651a7ca2	Rename SkinnableInfo to SkinnableDrawableInfo	2023-02-15 18:23:17 +09:00
Dean Herbert	6010dde86e	Move SkinnableInfo to better namespace	2023-02-15 18:23:10 +09:00
Dean Herbert	8bbd00822c	Simplify and rename SkinnableTargetComponentsContainer	2023-02-15 17:30:21 +09:00
Dean Herbert	e71dfd7555	Fix skin export failing if a directory exists with the proposed filename	2023-02-15 16:11:16 +09:00
Dean Herbert	da8ab7143b	Merge branch 'master' into maximum-judgement-offset-in-hit-object	2023-02-15 14:48:15 +09:00
Dean Herbert	9ed068c1e6	Only apply dim changes when background blur is disabled	2023-02-15 14:16:34 +09:00
Dean Herbert	19e3c5d33c	Adjust song select background dimming to be more evenly applied	2023-02-15 13:59:24 +09:00
Dean Herbert	5024838f3a	Merge branch 'master' into bubble_mod_implementation_clean	2023-02-15 13:47:18 +09:00
Bartłomiej Dach	99b78c63a0	Merge branch 'master' into fix-mania-long-note-regression	2023-02-14 21:25:31 +01:00
Dean Herbert	5ec5222d8a	Expose and consume OsuInputManager explicitly	2023-02-14 17:36:07 +09:00
Dean Herbert	b42b5f97cf	Use Overlays container rather than KeyBindingInputManager for flashlight	2023-02-14 17:36:07 +09:00
Dean Herbert	970388d4e2	Move Overlays container to accept input and be frame-stable	2023-02-14 17:35:12 +09:00
Dean Herbert	e6f0a1dec9	Merge pull request #22632 from Joehuu/fix-beatmap-preview-progress ... Fix beatmap card song preview progress sometimes showing past progress for one frame	2023-02-14 17:06:50 +09:00
Dean Herbert	7aaaf7fca2	Combine and attempt to simplify the score import / preparation process further	2023-02-14 16:55:35 +09:00
Dean Herbert	8a206234f7	Merge branch 'master' into replay-length-extension	2023-02-14 16:42:26 +09:00
Dean Herbert	0217875f3f	Merge branch 'master' into SkinSetOnNotificationClick	2023-02-14 16:04:03 +09:00
Dean Herbert	0ad245e9e0	Rewrite implementation to match other implementations	2023-02-14 16:00:23 +09:00
Dean Herbert	21429e164f	Fix comment grammar	2023-02-14 15:55:32 +09:00
PC	ca2603324c	Change present from skin selection tab to SkinCollection.First()	2023-02-14 09:43:40 +03:00
Joseph Madamba	ea624b8ad0	Reset preview track when stopping instead	2023-02-13 22:39:34 -08:00
Dean Herbert	63f3498762	Restructure UseResumeOverlay to correctly handle a value change before BDL load	2023-02-14 15:11:33 +09:00
Dean Herbert	9e04a36d86	Move test to a mod test and add more resilient test logic	2023-02-14 15:07:45 +09:00
PC	9064391226	Use ChildrenOfType instead of linq	2023-02-14 08:24:03 +03:00
Dean Herbert	51d4ae5241	Merge branch 'master' into footer_V2_implementation	2023-02-14 14:00:53 +09:00
Dean Herbert	f0ebb920b9	Make Actions nullable	2023-02-14 13:54:00 +09:00
Joseph Madamba	24a5a1061f	Fix OsuClickableContainer sounds not being blocked by nested drawables	2023-02-13 15:36:17 -08:00
PC	f8f485e4c8	Move PresentSkinsImport to OsuGame. Replace switch with if statement	2023-02-14 02:29:50 +03:00
MK56	5006dbe3db	Update osu.Game/Screens/Select/FooterV2/FooterButtonV2.cs ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2023-02-14 00:07:02 +01:00
Bartłomiej Dach	939144fb6c	Merge pull request #22628 from EVAST9919/letterbox-no-containers ... Remove unnecessary containers in `LetterboxOverlay`	2023-02-13 23:54:48 +01:00
Pasi4K5	e4b84ebd0b	Add UseResumeOverlay and use it for hiding the ResumeOverlay	2023-02-13 23:51:39 +01:00
Joseph Madamba	7f7e72705f	Fix beatmap card song preview progress sometimes showing past progress for one frame	2023-02-13 14:15:37 -08:00
mk56-spn	ae9a17d76b	Add offset to FooterButtonV2.cs shadow	2023-02-13 22:20:41 +01:00
mk56-spn	be52d0a60c	Add note explaining shadow opacity ... pass ColourProvider in from test, instead of hard coding it in `FooterButtonV2.cs`	2023-02-13 22:18:34 +01:00
mk56-spn	61584ba63c	Fix corner_radius missing in some parts of FooterButtonV2.cs. ... Adjust shadow radius value to 5 to match figma.	2023-02-13 22:15:29 +01:00
mk56-spn	6e6421caea	Change FooterV2.cs colour to use ColourProvider instead of OsuColour. ... Remove unnecessary `FillFlowContainer`	2023-02-13 22:12:25 +01:00
PC	10ab228d76	Improve xml doc	2023-02-13 22:47:29 +03:00
PC	46b13f2565	Improve code quality	2023-02-13 22:44:11 +03:00
PC	637b07efe6	Remove Resolved attribute	2023-02-13 22:36:51 +03:00
PC	a22a36bfe0	Add navigation to skin settings on multiple import	2023-02-13 20:31:09 +03:00
Andrei Zavatski	2dee783401	Remove not needed containers	2023-02-13 15:14:25 +03:00
PC	35bc0a29d8	Add setting skin on notification click	2023-02-13 15:11:55 +03:00
Dean Herbert	679df9bf8b	Merge pull request #22604 from Joehuu/abort-dangerous-dialog-button-on-hover-lost ... Add ability to abort dangerous dialog button on hover lost	2023-02-13 20:40:14 +09:00
tsrk	aa2e0028ab	refactor: hide trigger presence from content	2023-02-13 10:59:10 +00:00
Dean Herbert	55358d36c8	Change MinimumColumnWidth to remove setter	2023-02-13 17:50:32 +09:00
Dean Herbert	ca768ca446	Add comment regarding unused enum members in LegacyNoteBodyStyle	2023-02-13 17:43:52 +09:00
tsrk	11d0e185b8	refactor: separate impl of KeyCounterDisplay ... This allows for different layouts of display. Idk, maybe someone would want to mix both variants? (don't do this please). This commit is mostly prep for further changes.	2023-02-13 01:36:12 +00:00
tsrk	74a58fb674	refactor: separate things in KeyCounter ... To implement different different sources of input for KeyCounter, it is now possible to create a Trigger class (to inherit) instead of inheriting KeyCounter. This eases the creation of more input sources (like for tests) while allowing to implement different UI variants. That way, if another variant of the key counter needs to implemented (for whathever reason), this can be done by only inheriting KeyCounter and changing how things are arranged visually.	2023-02-13 01:24:27 +00:00
Joseph Madamba	cb51b9e350	Use existing ModdingBeatmap activity	2023-02-12 15:01:50 -08:00
Joseph Madamba	bbeef53569	Add TestingBeatmap activity	2023-02-12 13:11:42 -08:00
Joseph Madamba	afb66d8af4	Make user activity class names more specific	2023-02-12 12:32:17 -08:00
Dean Herbert	9d09141ab7	Move taiko-specific property out of DrawableHitObject	2023-02-12 16:09:28 +09:00
Joseph Madamba	8d9245c1d4	Make AbortConfirm() virtual and override with filter logic	2023-02-11 12:54:16 -08:00
Bartłomiej Dach	774eae98cc	Merge branch 'master' into editor-select-timing-on-enter	2023-02-11 16:27:22 +01:00
Bartłomiej Dach	a3cc0d23b3	Fix typo in xmldoc	2023-02-11 16:26:32 +01:00
Bartłomiej Dach	7b2c5ab7eb	Merge pull request #22608 from peppy/update-dependencies ... Update realm and other dependencies	2023-02-11 12:37:02 +01:00
Bartłomiej Dach	ebf469272f	Merge pull request #22544 from peppy/fix-change-join-leave-loop ... Attempt to fix channel join / leave loop	2023-02-11 12:26:26 +01:00
Dean Herbert	20f3ab167e	Re-centralise BannedApiAnalysers nuget package	2023-02-11 19:36:40 +09:00
Bartłomiej Dach	8292052dc2	Merge pull request #22598 from peppy/fix-skip-intro-replay ... Fix "skip" key binding no longer working in replay playback	2023-02-11 11:27:10 +01:00
Dean Herbert	0c5dae5f26	Merge pull request #22529 from ItsShamed/dsc/presence ... Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`	2023-02-11 17:29:47 +09:00
Dean Herbert	86c8675910	Update realm and other dependencies	2023-02-11 13:52:24 +09:00
Dean Herbert	463e8221e0	Merge pull request #22600 from Terochi/song-progress-time-left-fix ... Song progress incorrectly displaying `timeLeft` counter after rotation	2023-02-11 13:19:06 +09:00
Joseph Madamba	94d6ab1ec7	Continue confirming when rehovering if mouse is still down	2023-02-10 19:09:30 -08:00
Joseph Madamba	bfd83768c1	Fix skin component previews on toolbox buttons having incorrect size for one frame	2023-02-10 17:58:34 -08:00
Joseph Madamba	d30d054b4c	Add ability to abort dangerous dialog button on hover lost	2023-02-10 14:41:44 -08:00
Bartłomiej Dach	75e19bb89f	Merge branch 'master' into fix-clickable-avatar-bloat	2023-02-10 21:30:40 +01:00
Bartłomiej Dach	11296c4ffe	Use better exception type	2023-02-10 21:25:19 +01:00
Terochi	81c3e0da31	Fixed timeLeft counter in SongProgressInfo being out of bounds after rotation	2023-02-10 17:58:48 +01:00
Dean Herbert	bfbffc4a68	Add parsing support for mania NoteBodyStyle	2023-02-10 19:46:59 +09:00
Dean Herbert	635e225d19	Add correct lookup for WidthForNoteHeightScale	2023-02-10 19:18:41 +09:00
Dean Herbert	5c795f492f	Reorder game key bindings to allow skip overlay to have precedence over replay controls	2023-02-10 18:57:21 +09:00
Dean Herbert	96fbd04698	Add failing test coverage of skip no longer working in replay playback	2023-02-10 18:57:04 +09:00
Dean Herbert	4f7d26b776	Actually apply new parameter	2023-02-10 18:29:39 +09:00
Dean Herbert	6d876fdb9a	Automatically select the closest timing point on entering the timing screen	2023-02-10 17:48:56 +09:00
Dean Herbert	03e623d1d2	Move ControlPointList to own file	2023-02-10 17:37:31 +09:00
Dean Herbert	ad8b01b478	Merge pull request #22589 from sw1tchbl4d3r/file_hitsample_additions ... Always add to additions soundbank in `convertSoundType`	2023-02-10 17:14:29 +09:00
Dean Herbert	eccde923e5	Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability ... Improve readability of `AccuracyCircle`	2023-02-10 17:03:46 +09:00
Dean Herbert	1df6fc6311	Use if statements rather than conditional case	2023-02-10 17:03:27 +09:00
Dean Herbert	199fb0fd85	Apply NRT to ClickableAvatar and UpdateableAvatar	2023-02-10 16:32:58 +09:00
Dean Herbert	5866b67a5b	Simplify tooltip implementation	2023-02-10 16:24:44 +09:00
Dean Herbert	68c37585e5	Use string.Empty instead of default	2023-02-10 16:22:06 +09:00
Joseph Madamba	a86f06df96	Add back Enabled checks to TooltipText and OnClick to fix guest case	2023-02-09 17:00:32 -08:00
Bartłomiej Dach	96c1832af4	Fix grammar in xmldoc ... Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>	2023-02-10 00:07:24 +01:00
sw1tchbl4d3	f0d11f44fc	Always add to additions soundbank in convertSoundType	2023-02-09 22:27:52 +01:00
Joseph Madamba	0b41dbf579	Remove code bloat from ClickableAvatar	2023-02-09 12:59:26 -08:00
Ruki	2c1154afc6	refactor: improve wording ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2023-02-09 17:15:30 +00:00
Dean Herbert	ab81397119	Merge pull request #22553 from OpenSauce04/taiko-stable-snapping ... Snap Taiko hit objects to match Stable	2023-02-09 23:28:21 +09:00
Dean Herbert	34d1890f1c	Change snapping to only apply to classic mod	2023-02-09 18:22:14 +09:00
ekrctb	258de3b2d8	Store RawTime in JudgementResult	2023-02-09 17:15:37 +09:00
ekrctb	5f0636c330	Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield	2023-02-09 16:47:58 +09:00
Dean Herbert	28897b6e18	Merge pull request #22566 from Joehuu/profile-tournament-banner ... Display tournament banner on user profile	2023-02-09 16:06:36 +09:00
Dean Herbert	cf009432cc	Centralise accuracy cutoff constants and add lookup helper methods	2023-02-09 15:41:58 +09:00
Joseph Madamba	f1decb667e	Address todos relating to init-only usages	2023-02-08 17:51:28 -08:00
Walavouchey	57312279f0	adjust RankNotch gap size to match original value	2023-02-09 02:20:05 +01:00
Joseph Madamba	3b5d573db1	Display tournament banner on user profile	2023-02-08 17:16:09 -08:00
Walavouchey	fd93bd3f50	move rank accuracy requirements to class-local constants	2023-02-09 00:46:24 +01:00
Walavouchey	ee40444fd3	use Precision.AlmostEquals for bounds check	2023-02-08 23:59:19 +01:00
Bartłomiej Dach	0a5c4e04bf	Merge branch 'master' into skin-editor-undo-support	2023-02-08 18:43:59 +01:00
Walavouchey	0531c010eb	display RankBadges on on their sector centres ... the D `RankBadge` does this anyway. the A and S badges are slightly off centre to prevent overlap with the SS badge	2023-02-08 14:01:40 +01:00
Walavouchey	6ace6bfee1	ensure AccuracyCircle doesn't land in gaps created by RankNotches	2023-02-08 13:20:53 +01:00
Joseph Madamba	0156ff732f	Fix beatmap cards not showing context menu on user profile	2023-02-07 22:56:09 -08:00
Dean Herbert	17ca26ebee	Remove unnecessary null check on targetScreen	2023-02-08 15:44:24 +09:00
Dean Herbert	3a3c2e78a1	Merge branch 'master' into skin-editor-undo-support	2023-02-08 15:41:58 +09:00
Dean Herbert	4fdba880b1	Fix xmldoc reference fail at CI	2023-02-08 15:39:18 +09:00
Dean Herbert	78eae171ed	Merge pull request #22507 from Joehuu/fix-comment-padding ... Fix comments having too much padding at the bottom	2023-02-08 15:01:05 +09:00
Dean Herbert	b6809e156b	Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii ... Implement a sheared slider for the updated design	2023-02-08 15:01:00 +09:00
Dean Herbert	c50ea89bc9	Simplify migration to not rely on old/dynamic schema	2023-02-08 14:24:06 +09:00
Dean Herbert	5c113ddb03	Reword xmldoc to read better	2023-02-08 14:20:58 +09:00
Dean Herbert	5cd111e6f1	Fix ordering of methods in OsuSliderBar	2023-02-08 14:01:50 +09:00
Dean Herbert	cec1f77e6c	Fix glow flash occurring after releasing mouse and adjust transition slightly	2023-02-08 13:59:09 +09:00
Cootz	086b3eb542	Fix minor formating issues	2023-02-08 05:50:52 +03:00
Cootz	4ba915268c	Change a comment into RealmAccess	2023-02-08 05:46:47 +03:00
Cootz	ab7c9a200b	Fix a typo	2023-02-08 05:42:06 +03:00
Cootz	6bf56aff73	Add warning for ScoreInfo	2023-02-08 05:40:20 +03:00
Dean Herbert	ee65c65893	Attempt to fix channel join / leave loop ... I don't have a solid way to repro the issue, but this should hopefully help in resolving it. Either way, I think this change brings more correct behaviour (if a websocket message comes through that we have left the channel, I don't believe we should be sending a request to leave that channel again).	2023-02-08 11:31:30 +09:00
Cootz	391af2791b	Fix CSharpWarnings::CS1574,CS1584,CS1581,CS1580	2023-02-08 05:23:42 +03:00
Joseph Madamba	277f71d36a	Expire reply editor instead of clearing container	2023-02-07 15:15:51 -08:00
PC	7e127dafe2	Update reference	2023-02-07 11:52:47 +03:00
Cootz	957c9e7e27	Update osu.Game/Scoring/ScoreInfo.cs ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-02-07 11:23:39 +03:00
Dean Herbert	0320ba770f	Handle component changes via ISkinnableTarget.Components rather than inside SkinEditor directly ... Seems saner? Maybe?	2023-02-07 16:23:25 +09:00
Dean Herbert	e162fd56da	Change the way initial state saving works in EditorChangeHandler to be closer to first change	2023-02-07 16:22:51 +09:00
Dean Herbert	dad348111d	Fix holding a selection while changing screens causing a crash	2023-02-07 16:07:33 +09:00
Dean Herbert	71eef238c4	Make OnStateChange non-implemented rather than wrong	2023-02-07 16:04:31 +09:00
Cootz	a1ee3df453	Improve local variable naming	2023-02-07 03:16:25 +03:00
Cootz	1470ea0a31	Remove unnecessary using directives	2023-02-07 03:07:53 +03:00
Cootz	723f13af25	Add summary for OriginalBeatmapHash	2023-02-07 02:43:27 +03:00
tsrk	da10166628	quality: convert getter property to method so that sensible information can be hidden via an argument	2023-02-06 21:30:55 +00:00
tsrk	1baaae35a9	quality: Simplify string	2023-02-06 20:07:16 +00:00
Bartłomiej Dach	12f6d461b9	Merge pull request #22532 from peppy/fix-long-storyboard-outro ... Fix storyboard outro time potentially running too long	2023-02-06 20:30:36 +01:00
Bartłomiej Dach	179db09075	Merge pull request #22531 from peppy/apply-future-rider-inspection ... Apply single inspection from newer inspectcode versions	2023-02-06 20:05:49 +01:00
tsrk	bc89f8dc5b	feat: add name and rulset verb display support	2023-02-06 12:44:00 +00:00
Cootz	2c7386db39	FIx score appearing on BeatmapLeaderboard and TopLocalRank	2023-02-06 15:14:14 +03:00
Cootz	b00848e742	Fix realm error. Apply OriginalBeatmapHash on import	2023-02-06 13:58:41 +03:00
Dean Herbert	aaf3ad805c	Fix potential nullref in tests	2023-02-06 19:31:45 +09:00
Dean Herbert	b83c8443ea	Ensure pause sample loop is stopped on exiting player	2023-02-06 18:24:31 +09:00
Terochi	43f7665c9e	Improved readability again	2023-02-06 09:49:42 +01:00
Dean Herbert	c691a0d3af	Merge branch 'master' into sheared_slider_implementation_clean_ii	2023-02-06 17:49:33 +09:00
Dean Herbert	c078d3a344	Merge pull request #22357 from EXtremeExploit/groups-probationary-badges ... Make probationary groups a bit transparent	2023-02-06 17:43:57 +09:00
Dean Herbert	a67d5d2a14	Merge branch 'master' into bubble_mod_implementation_clean	2023-02-06 17:24:20 +09:00
Dean Herbert	ddcc02fdfe	Merge pull request #22505 from Joehuu/fix-hover-click-sounds ... Fix some clickable elements having no hover and click sounds	2023-02-06 16:52:19 +09:00
Dean Herbert	eabd1a0cc1	Remove unused Duration property to avoid any misunderstandings	2023-02-06 16:42:39 +09:00
Dean Herbert	679ec986d5	Fix storyboard outro time potentially running too long	2023-02-06 16:39:44 +09:00
Terochi	4f23e096d7	Improved readability	2023-02-06 07:59:37 +01:00
Dean Herbert	4c868372a2	Correctly handle anchor/origin changes as undo states	2023-02-06 15:05:05 +09:00
Dean Herbert	778b8a9bf7	Fix default settings not being serialised / state tracked correctly	2023-02-06 15:00:42 +09:00
Dean Herbert	7445814fc6	Handle changes to SettingSource skin element settings	2023-02-06 14:42:59 +09:00
Dean Herbert	e5f62b0d2e	Remove public access modifier from interface methods	2023-02-06 14:19:25 +09:00
Dean Herbert	e4b17588f5	Add missing xmldoc to new methods in EditorChangeHandler	2023-02-06 14:11:40 +09:00
Dean Herbert	701d21c26f	Apply single inspection from newer inspectcode verisons ... As found in rider EAPs. Appears as a warning and is annoying me occasionally.	2023-02-06 13:52:27 +09:00
Dean Herbert	10ab4d572a	Merge branch 'master' into skin-editor-undo-support	2023-02-06 13:46:50 +09:00
tsrk	b3f38b0f4c	quality: remove redundant Status override	2023-02-06 00:56:11 +00:00
tsrk	bf273597ea	feat: actually support status also for Replays	2023-02-06 00:41:10 +00:00
tsrk	d5b2d9ce97	feat: add support for spectating status	2023-02-05 23:58:08 +00:00
Cootz	d23e787bc1	Update schema_version	2023-02-05 21:55:50 +03:00
Cootz	4598112586	Add OriginalBeatmapHash to ScoreInfo. Update db schema_version, migration	2023-02-05 21:46:38 +03:00
Terochi	f58534f60c	Extended the length of replay at the end of map	2023-02-05 18:51:28 +01:00
Joseph Madamba	cb8458cceb	Use linq and alpha instead ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-02-04 20:11:29 -08:00
Joseph Madamba	191259c050	Use equals instead and update other usage	2023-02-04 19:58:48 -08:00
Bartłomiej Dach	ef900bccdf	Merge branch 'master' into BPM_counter_fix	2023-02-04 23:44:58 +01:00
Bartłomiej Dach	cb7540564a	Merge pull request #22504 from peppy/fix-editor-positional-nudge-undo ... Fix beatmap editor positional nudging not being undoable	2023-02-04 15:52:34 +01:00
Joseph Madamba	4192388b20	Fix expanded beatmap cards getting cut off at the end of profile sections	2023-02-03 21:29:01 -08:00
mk56-spn	88872cf1cf	Use ``GetTrueGameplayRate()`` to remove need for jank	2023-02-04 00:53:54 +01:00
mk56-spn	d9bee958dd	Stop ``BPMCounter.cs``'s value from going to 0 after failing.	2023-02-03 23:56:34 +01:00
Bartłomiej Dach	97afb83394	Merge branch 'master' into carousel	2023-02-03 22:15:44 +01:00
Bartłomiej Dach	63f7d326c2	Merge branch 'master' into fix-editor-positional-nudge-undo	2023-02-03 21:31:05 +01:00
Bartłomiej Dach	4bd43171e8	Merge branch 'master' into fix-skin-editor-padding-weirdness	2023-02-03 20:28:47 +01:00
Bartłomiej Dach	b2a5cf9f2d	Merge branch 'master' into triangles-old-texel	2023-02-03 19:43:34 +01:00
Bartłomiej Dach	59656a7286	Merge branch 'master' into skin-editor-dont-show-save-on-no-change	2023-02-03 19:08:33 +01:00
EXtremeExploit	f9809c9481	the comment	2023-02-03 11:48:11 -03:00
mk56-spn	e1af5e110a	Remove ``RoundedNub.cs` and make `Nub.cs`` non abstract again	2023-02-03 12:19:09 +01:00
mk56-spn	8c11e8e6f4	Extract ShearedNub.cs implementation into its own entirely independent implementation	2023-02-03 11:58:10 +01:00
Joseph Madamba	461b5c5375	Fix comment cancel button not behaving the same as reply text toggle ... - Removed the fading animation as it is awkward right now (needs resizing)	2023-02-03 02:04:19 -08:00
Dean Herbert	2cda277c09	Add a basic change handler to the skin editor	2023-02-03 18:57:50 +09:00
Dean Herbert	2f30306ea2	Expose a method to reload a SkinnableTargetContainer from provided info	2023-02-03 18:53:09 +09:00
Dean Herbert	3345e34544	Move beatmap specific logic out of EditorChangeHandler	2023-02-03 17:53:54 +09:00
Joseph Madamba	94d2799b90	Fix comments having too much padding at the bottom	2023-02-03 00:47:10 -08:00
Joseph Madamba	5a76c1ab9c	Refactor HoverSampleDebounceComponent to inherit Component	2023-02-03 00:29:25 -08:00
Dean Herbert	b437501b0f	Fix beatmap editor positional nudging not being undoable	2023-02-03 17:28:58 +09:00
Dean Herbert	554f14151c	Apply NRT to EditorChangeHandler	2023-02-03 17:13:24 +09:00
Dean Herbert	b19047b90b	Fix skin editor component list having uneven padding	2023-02-03 16:55:51 +09:00
Joseph Madamba	f27bf3ca20	Fix click sounds potentially not working	2023-02-02 23:54:57 -08:00
Joseph Madamba	77569058cb	Alternatively fix hover sounds playing out of clicking bounds	2023-02-02 23:45:54 -08:00
Dean Herbert	60ccf35125	Update resources	2023-02-03 16:44:53 +09:00
Joseph Madamba	6135db6bd7	Revert moving hover sounds to content container	2023-02-02 23:43:08 -08:00
Dean Herbert	7b9239088b	Comment space addition	2023-02-03 16:40:16 +09:00
Andrei Zavatski	14524237ac	Add comment explaining texelSize value	2023-02-03 10:32:41 +03:00
Dean Herbert	4ec46c7476	Merge branch 'master' into footer_V2_implementation	2023-02-03 16:30:16 +09:00
Dean Herbert	48f7e0163c	Adjust comments and formatting of comments	2023-02-03 16:27:20 +09:00
Dean Herbert	4248453616	Use FinishTransforms rather than manual duplication of background colour logic	2023-02-03 16:27:20 +09:00
Dean Herbert	a1200b8fe8	Adjust footer button colour handling to read better and take into account mouse down	2023-02-03 16:27:20 +09:00
Dean Herbert	92306b9123	Combine localisations for abstract skinnable components into a single file ... Generally we don't want localisation files with only one to two translations. It makes it harder for translators to handle in crowdin (a lot of file changes for small results). So for cases like this I believe we should be grouping translations where it makes sense. I've left individual components in their own files as I can see potential for more settings to be added in the future. Plus it gives a bit of extra context.	2023-02-03 16:02:18 +09:00
Dean Herbert	cf8cfe0d2c	Move skin component localisations to namespaces	2023-02-03 15:34:57 +09:00
Dean Herbert	50559643bb	Fix incorrectly applied enum localisation	2023-02-03 15:27:11 +09:00
Dean Herbert	32207dc9dd	Merge branch 'master' into locale/skin-editor-components	2023-02-03 15:24:00 +09:00
Dean Herbert	5ca5f04794	Add parameter hint for optional bool value	2023-02-03 15:18:40 +09:00
Dean Herbert	9c954a93e3	Update Save method xmldoc to make more sense	2023-02-03 15:18:01 +09:00
Dean Herbert	f7094567d7	Rename and document method to limit scope	2023-02-03 15:04:47 +09:00
Bartłomiej Dach	1af898160c	Merge branch 'master' into delete-on-import-android	2023-02-02 21:40:52 +01:00
Bartłomiej Dach	e937022b09	Merge branch 'master' into middle-click-replay-pause	2023-02-02 20:52:03 +01:00
Bartłomiej Dach	4d46a8f32d	Merge branch 'master' into skin-editor-dont-show-save-on-no-change	2023-02-02 19:36:23 +01:00
Bartłomiej Dach	f7fa9e3927	Remove outdated comment	2023-02-02 18:41:35 +01:00
mk56-spn	80fd1a0bc7	Remove leftover comment regarding X axis offsets	2023-02-02 18:29:12 +01:00
Bartłomiej Dach	779c58f9c1	Merge branch 'master' into skin-editor-ux-impovements	2023-02-02 18:16:18 +01:00
Bartłomiej Dach	6c0aada86a	Merge pull request #22490 from peppy/skin-overlay-namespace ... Move skin editor to overlays namespace	2023-02-02 18:14:16 +01:00
mk56-spn	3f0ce75bf5	Rename NormalSliderBar.cs to RoundedSliderBar.cs	2023-02-02 17:24:45 +01:00
mk56-spn	7c5a65bdb7	Rename NormalNub.cs to RoundedNub.cs	2023-02-02 17:23:09 +01:00
Dean Herbert	015f4f2b38	Avoid showing skin save message when changing scenes after making no changes	2023-02-02 18:42:37 +09:00
Dean Herbert	9b6d95b3d6	Adjust skin editor pop in/out to be more snappy	2023-02-02 18:33:45 +09:00
Dean Herbert	26efb8e842	Replace white box legacy placeholder with something that visually fits	2023-02-02 18:33:31 +09:00
tsrk	843d9914c4	quality: remove new line	2023-02-02 08:18:56 +00:00
Dean Herbert	659b78058f	Move replay specific key bindings to their own section	2023-02-02 15:25:52 +09:00
Dean Herbert	edecd2ee25	Merge branch 'master' into middle-click-replay-pause	2023-02-02 15:25:51 +09:00
Dean Herbert	b792dc3af0	Merge pull request #22281 from cdwcgt/editor-check-previewtime ... Add preview time setting check	2023-02-02 15:10:06 +09:00
Dean Herbert	48ef25cbe5	Merge pull request #22421 from EXtremeExploit/misses-animation ... Add movement to legacy misses in osu ruleset	2023-02-02 15:00:57 +09:00
Dean Herbert	91fbf388da	Use localisation strings from ButtonSystem for better consistency	2023-02-02 15:00:24 +09:00
Dean Herbert	500e9c7944	Refactor into a method rather than property	2023-02-02 14:53:58 +09:00
Dean Herbert	942e7729f3	Merge branch 'master' into carousel	2023-02-02 14:41:55 +09:00
Dean Herbert	5b3d7a8f26	Fix typo in missing-preview-point message	2023-02-02 14:34:59 +09:00
Andrei Zavatski	175b9fc5c9	Specify texelSize value in the Triangles background	2023-02-02 08:34:38 +03:00
Dean Herbert	c2cde8361a	Fix message not reading well	2023-02-02 14:33:41 +09:00
Dean Herbert	3a861fd943	Remove multiple cases of excess braces	2023-02-02 14:28:21 +09:00
Dean Herbert	50659f3d52	Merge pull request #22428 from EVAST9919/triangles-new-masking ... Implement Masking property for `TrianglesV2` background	2023-02-02 14:22:16 +09:00
Dean Herbert	229fb518dc	Apply NRT to LegacyJudgementPieceOld	2023-02-02 14:19:00 +09:00
Dean Herbert	183d1c5bd6	Change version comparison to match other existing code as proposed in review	2023-02-02 14:18:49 +09:00
Dean Herbert	263a7e2766	Merge branch 'master' into misses-animation	2023-02-02 14:08:15 +09:00
Dean Herbert	8dc2e6872e	Move skin editor to overlays namespace	2023-02-02 14:00:31 +09:00
Dean Herbert	10df64467a	Merge pull request #22430 from peppy/skin-editor-nrt ... Apply NRT to all skin editor classes	2023-02-02 13:57:57 +09:00
tsrk	0fb6a63709	refactor: change namespacing to allow osu-localisation-analyzer to process all strings	2023-02-02 00:46:14 +00:00
Ruki	89a30d87c7	Merge branch 'ppy:master' into locale/skin-editor-components	2023-02-02 00:02:14 +00:00
tsrk	ddfa95e6ef	refactor: fix typos	2023-02-02 00:01:48 +00:00
tsrk	8645e705fd	feat: add localisation for Skin editor components	2023-02-01 23:48:05 +00:00
Bartłomiej Dach	292016d31e	Merge pull request #22483 from peppy/test-output-gameplay-time ... Output gameplay clock progress in `PlayerTestScene`s	2023-02-01 22:55:10 +01:00
Dean Herbert	a77baf8717	Output gameplay clock progress in PlayerTestScenes	2023-02-01 23:42:44 +09:00
Dean Herbert	d54db8de64	Merge branch 'master' into fix-clicking-metadata-relevance-sort	2023-02-01 19:39:13 +09:00
Dean Herbert	524aa9162d	Store search parameters as tuple	2023-02-01 19:38:47 +09:00
cdwcgt	76296eb35a	Consistent with BeatmapsetVerifier	2023-02-01 11:52:14 +08:00
Joseph Madamba	1a152452f1	Fix incorrect naming of badge header container	2023-01-31 15:16:29 -08:00
Joseph Madamba	0366a8e348	Only call Reset() if lastCategory and lastHasQuery is null	2023-01-31 12:44:44 -08:00
Dean Herbert	7d1b5751fd	Merge pull request #22467 from Cootz/issue#22345 ... Fix migration putting game files in root of disk if no other files exist	2023-01-31 18:41:34 +09:00
Dean Herbert	5d22f3d879	Improve inline comment	2023-01-31 17:17:21 +09:00
Dean Herbert	3d8b35184f	Update framework	2023-01-31 16:24:06 +09:00
Cootz	b18652b25f	CreateSubDirectory removed. Fixes the empty root issue	2023-01-31 10:14:21 +03:00
Cootz	54d5d4e7c6	Fix for the issue	2023-01-31 07:06:26 +03:00
Bartłomiej Dach	b1cbe20cd8	Adjust markdown text flow to framework-side changes	2023-01-30 20:48:52 +01:00
Bartłomiej Dach	c5e1f54185	Fix sample store creation mutating shared resource store	2023-01-30 20:48:52 +01:00
Ruki	96bd79a6f5	Merge branch 'ppy:master' into hud/avatar-thing	2023-01-30 15:43:29 +01:00
mk56-spn	f5d579144b	Remove free mods button	2023-01-30 12:57:24 +01:00
mk56-spn	41f5e5143a	Remove ``onclick` and `mousedown`` override	2023-01-30 12:56:39 +01:00
Joseph Madamba	610d2f9dc7	Fix beatmap listing potentially not sorting by relevance when searching via metadata	2023-01-28 12:14:35 -08:00
Bartłomiej Dach	d38316bf4f	Merge pull request #22429 from peppy/fix-health-display-anchor-point ... Fix default health bar having a very weird anchor point in the skin editor	2023-01-28 10:33:59 +01:00
MK56	c50604f701	Merge branch 'master' into bubble_mod_implementation_clean	2023-01-27 11:58:56 +01:00
ekrctb	27578c48f5	Remove JudgementResultEntry ... It is not needed anymore as TimeAbsolute is stored raw.	2023-01-27 19:35:44 +09:00
Dean Herbert	98c9ba5b6f	Merge branch 'master' into skin-editor-nrt	2023-01-27 19:35:43 +09:00
Dean Herbert	74ab036f3e	Refactor SkinnableSound.Samples to be non-nullable	2023-01-27 19:32:30 +09:00
Dean Herbert	8a9a6c733c	Apply missed cleanup to BackgroundDependencyLoader call ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-01-27 13:55:34 +09:00
Bartłomiej Dach	9bdd43d1b2	Merge pull request #22406 from peppy/fix-storyboard-filename ... Fix beatmaps with multiple `osb` files potentially reading the storyboard from the wrong one	2023-01-26 20:32:16 +01:00
mk56-spn	091cc155d3	Fix nub naming in OsuCheckbox.cs and associated classes	2023-01-26 16:10:02 +01:00
EXtremeExploit	1de0bed83d	fix comment	2023-01-26 11:09:16 -03:00
mk56-spn	a630f1113f	Rename nub object in NormalSliderBar.cs class	2023-01-26 15:03:51 +01:00
mk56-spn	8840694674	Adjust some padding details on ShearedSliderBar.cs as well as colouration tweaks.	2023-01-26 15:03:51 +01:00
mk56-spn	2f90ffccfc	Implement ShearedSliderBar.cs and corresponding TestSceneShearedSliderBar.cs	2023-01-26 15:03:22 +01:00
mk56-spn	6dfb9630d6	Implement ShearedNub.cs as well as tweak the syntax in NormalNub.cs	2023-01-26 15:03:22 +01:00
mk56-spn	b8ae689b31	Re-add Nub.cs and move logic from NormalNub.cs to it.	2023-01-26 15:03:22 +01:00
mk56-spn	63efe79abc	Enable NRT for NormalNub.cs	2023-01-26 15:03:22 +01:00
mk56-spn	374c3b56f6	Rename Nub.cs to NormalNub.cs	2023-01-26 15:03:11 +01:00
EXtremeExploit	758b4c8cfc	Do the thing aka fix the if	2023-01-26 10:01:33 -03:00
mk56-spn	7355397e83	Enable NRT on NormalSliderBar.cs	2023-01-26 12:58:58 +01:00
mk56-spn	fc99165df7	Extract samples into base OsuSliderBar.cs from NormalSliderBar.cs	2023-01-26 12:36:05 +01:00
mk56-spn	9afc8681ef	Extract tooltip implementation into base OsuSliderBar.cs from NormalSliderBar.cs	2023-01-26 12:25:05 +01:00
mk56-spn	ac3ad9cf8d	Implement OsuSliderBar.cs as base ( non framework side ) class from which NormalSliderBar.cs inherits	2023-01-26 12:16:51 +01:00
mk56-spn	3988131475	Rename OsuSliderBar.cs as NormalSliderBar.cs	2023-01-26 12:12:56 +01:00
Dean Herbert	4352c56c3e	Apply NRT to all simple auxiliary skin classes	2023-01-26 17:53:04 +09:00
Dean Herbert	2017ac1135	Apply NRT to all skin editor classes	2023-01-26 17:52:53 +09:00
Dean Herbert	e5d4979bc3	Fix default health bar having a very weird anchor point in the skin editor	2023-01-26 16:56:37 +09:00
Dean Herbert	64e7f6f138	Add more documentation around the implementation of FontAdjustableSkinComponent	2023-01-26 16:05:07 +09:00
Dean Herbert	d63719a602	Move and rename the base component class	2023-01-26 16:04:56 +09:00
Dean Herbert	48885d40cc	Merge branch 'master' into skin-fonts	2023-01-26 15:52:54 +09:00
Andrei Zavatski	7cd21e12f3	Implement masking property for TrianglesV2 background	2023-01-26 09:46:41 +03:00
Dean Herbert	f3c92749bf	Fix code quality issues	2023-01-26 15:43:03 +09:00
Dean Herbert	7cc4fd4efc	Use the exact method stable uses for generating storyboard filenames	2023-01-26 15:09:36 +09:00
Dean Herbert	044234b1ba	Merge pull request #22409 from EVAST9919/triangles-og-masking ... Implement Masking property for `Triangles` background	2023-01-26 14:46:59 +09:00
EXtremeExploit	bcecc49092	Only do misses animations on modern skins	2023-01-25 23:05:11 -03:00
EXtremeExploit	a6fc3ce477	bring comment back	2023-01-25 20:38:55 -03:00
Dan Balasescu	5f4dd19b49	Merge pull request #22389 from peppy/mania-long-note-wang ... Add basic support for stupidly long hold note skin textures	2023-01-26 07:41:27 +09:00
Bartłomiej Dach	fd495e87f7	Fix GetAsync() not limiting texture dimensions	2023-01-25 19:02:35 +01:00
EXtremeExploit	fc968d1d89	del extra newline	2023-01-25 14:38:02 -03:00
EXtremeExploit	a4a94cb96e	Add movement to misses in osu ruleset	2023-01-25 14:34:00 -03:00
EXtremeExploit	0eaebfd40a	Use Alpha instead of opacity on bg color	2023-01-25 10:22:42 -03:00
Andrei Zavatski	1485a6e006	Make masking false by default	2023-01-25 12:54:30 +03:00
Andrei Zavatski	d09d6f31d7	Implement Masking property for TrianglesBackground	2023-01-25 12:20:51 +03:00
Dean Herbert	f0406c34fd	Merge branch 'master' into revert-result-in-playfield	2023-01-25 17:35:33 +09:00
Dean Herbert	efe57f29e0	Merge pull request #22382 from JDECOMBE/beatmapSelectionBlur ... Add ability to disable background blur at song select	2023-01-25 17:34:35 +09:00
Dean Herbert	67e9de43be	Merge pull request #22386 from EVAST9919/triangles-og-shhader ... Use `TriangleBorder` shader in `Triangles` background	2023-01-25 17:25:18 +09:00
Dean Herbert	d15f8c2f3a	Fix beatmaps with multiple osb files potentially reading the storyboard from the wrong one ... In stable, the storyboard filename is fixed. In lazer, we were always looking for the first `.osb` in the database. In the case a beatmap archive housed more than one `.osb` files, this may load the incorrect one. Using `GetDisplayString` here feels like it could potentially go wrong in the future, so I'm open to hard-coding this locally (or using string manipulation to remove the ` [creator_name]` portion of the beatmap's filename). Open to opinions on that. Fixes storyboard playback in https://osu.ppy.sh/beatmapsets/1913687#osu/3947758	2023-01-25 17:11:15 +09:00
Dean Herbert	5c888e0c68	Merge branch 'master' into beatmapSelectionBlur	2023-01-25 16:37:19 +09:00
Dean Herbert	59ee6922b1	Merge pull request #22399 from bdach/user-profile/update-cover ... Update appearance of profile cover area to match web	2023-01-25 16:35:44 +09:00
Dean Herbert	01e280eb6b	Add classic default for song select blur setting	2023-01-25 16:32:00 +09:00
Dean Herbert	e333e12b2e	Fix typo in settings enum (seriously)	2023-01-25 16:32:00 +09:00
Dean Herbert	3faab66f39	Merge branch 'master' into beatmapSelectionBlur	2023-01-25 16:32:00 +09:00
Dean Herbert	1a9ed1ac3f	Remove unnecessary IgnoreUserSettings value change	2023-01-25 16:28:06 +09:00
Dean Herbert	f81dea4166	Remove now unused localisation string	2023-01-25 16:24:52 +09:00
Dean Herbert	7bb6337d2e	Fix nullability (thanks bdach for patch)	2023-01-25 14:43:46 +09:00
Dean Herbert	8caf960f9a	Revert weird nullable changes to Skin.cs	2023-01-25 14:43:46 +09:00
Dean Herbert	0a9b20d5d5	Split lookup store into own file / class	2023-01-25 14:43:46 +09:00
Dean Herbert	c1a5c16973	Reduce maximum texture size to a more commonly-supported 8192	2023-01-25 14:43:46 +09:00
Dean Herbert	d000a4ed28	Make sure to dispose of the original texture upload as we are replacing it	2023-01-25 14:43:46 +09:00
Dean Herbert	598c6fcbad	Add basic support for stupidly long hold note skin textures	2023-01-25 14:43:46 +09:00
Dean Herbert	6bf7773532	Increase duration of expansion transition	2023-01-25 14:28:25 +09:00
Dean Herbert	3e91dd2a16	Update spacing along with expanded state	2023-01-25 14:28:25 +09:00
Dean Herbert	6efab635d8	Merge branch 'master' into fix-copy-difficulty-moving-collections	2023-01-25 14:11:32 +09:00
Dean Herbert	392ff2ffea	Reword comment regarding hash transfer to make more sense	2023-01-25 14:11:02 +09:00
Dean Herbert	741ca96853	Make transferCollections argument to private method explicitly required	2023-01-25 14:09:13 +09:00
Dean Herbert	739ec8d81d	Add argument hint for nondescript bool ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-01-25 14:04:30 +09:00
Bartłomiej Dach	f2df36e6a5	Persist cover visibility to user settings ... Follows web precedent, wherein the setting is saved to local storage.	2023-01-24 23:30:12 +01:00
Bartłomiej Dach	33e91cf512	Implement cover toggling	2023-01-24 23:06:49 +01:00
Bartłomiej Dach	e74176e5bd	Add cover toggle button	2023-01-24 23:06:46 +01:00
Bartłomiej Dach	ef7812412b	Update top header container appearance	2023-01-24 23:06:44 +01:00
Bartłomiej Dach	ff22a91d52	Move user cover lower down	2023-01-24 23:06:37 +01:00
Bartłomiej Dach	edb9c76edf	Merge pull request #22385 from peppy/touchscreen-settings-keyword ... Fix touch input handler settings not matching search for "touchscreen"	2023-01-24 20:50:53 +01:00
Bartłomiej Dach	054938be02	Merge pull request #22387 from peppy/beatmap-leaderboard-cancel-request-eagerly ... Fix beatmap leaderboard potentially showing incorrect leaderboard	2023-01-24 19:49:11 +01:00
Jérémiah DÉCOMBE	acb42f7d12	reusing gameplay background blur loc song select background blur	2023-01-24 10:18:00 +01:00
Dean Herbert	b9291cb116	Change some order and assert for positive visibility before scheduling an operation in changelog overlay	2023-01-24 17:59:25 +09:00
Jérémiah DÉCOMBE	e0a7559d85	variable naming + loc	2023-01-24 09:55:08 +01:00
Joseph Madamba	c6bf755e68	Remove IsPresent override from ChangelogOverlay	2023-01-24 00:22:29 -08:00
Joseph Madamba	df895c4fd6	Always make settings footer build display clickable	2023-01-24 00:21:39 -08:00
Jérémiah DÉCOMBE	7ca2a431e6	changing song select background blur setting to boolean	2023-01-24 09:19:53 +01:00
Jérémiah DÉCOMBE	d783998c81	using BindValueChanged and IsCurrentScreen for setting binding	2023-01-24 09:09:05 +01:00
Dean Herbert	a966d6c330	Merge pull request #18402 from ggliv/mod-accuracy-challenge ... Add accuracy challenge mod	2023-01-24 16:00:55 +09:00
ekrctb	e1702a8ee9	Fix inspection issue	2023-01-24 15:43:57 +09:00
ekrctb	efef97d5be	Store Result.TimeAbsolute separately from offset ... Calculating from TimeOffset is bad because it loses precision. The result time won't change anymore even If `HitObject.GetEndTime()` changes later.	2023-01-24 15:35:06 +09:00
Gabe Livengood	b46ef67a14	increase min minimum accuracy to 60%	2023-01-24 00:31:46 -05:00
ekrctb	cc87923179	Fix OnRevertResult timing	2023-01-24 14:19:24 +09:00
ekrctb	e66e43e17c	Remove unused code	2023-01-24 14:15:17 +09:00
Dean Herbert	bb15ee50e0	Fix beatmap leaderboard potentially showing incorrect leaderboard	2023-01-24 13:52:59 +09:00
Andrei Zavatski	04c96355cb	Use TriangleBorder shader to draw triangles	2023-01-24 07:38:42 +03:00
Dean Herbert	fc558278cc	Fix touch input handler settings not matching search for "touchscreen"	2023-01-24 13:37:12 +09:00
Pasi4K5	8b47af6503	Remove HidesResumeOverlay and set ResumeOverlay to null in OsuModAutopilot	2023-01-24 00:49:09 +01:00
Jeremiah DECOMBE	c1876aac88	removing parameter name abbreviations	2023-01-24 00:36:38 +01:00
Jeremiah DECOMBE	b573e42cc2	BeatmapSelectionBackgroundBlurLevel renamed to SongSelectBackgroundBlurLevel	2023-01-24 00:08:11 +01:00
naoey	e6de167adb	Revert split and make collections boolean internal to BeatmapManager	2023-01-24 07:27:26 +09:00
Jeremiah DECOMBE	26adc28943	missing blank line between methods	2023-01-23 23:15:37 +01:00
Jeremiah DECOMBE	f13a5465ba	variable naming and loc modifications	2023-01-23 23:07:50 +01:00
Bartłomiej Dach	7483967157	Merge branch 'master' into SliderEnd-Snap	2023-01-23 21:33:16 +01:00
Bartłomiej Dach	1f40b2daf6	Clean up xmldocs	2023-01-23 21:22:18 +01:00
Bartłomiej Dach	9f2ed853eb	Merge pull request #22371 from peppy/more-settings-keywords ... Add more keywords to settings based on feedback	2023-01-23 20:19:53 +01:00
Jérémiah DÉCOMBE	6daa364779	adding setting to adjust blur of the background of the song select screen	2023-01-23 13:53:31 +01:00
Dean Herbert	432e0a6a37	Merge branch 'master' into level-badge-colour	2023-01-23 15:46:15 +09:00
Dean Herbert	9c2494383f	Rename fetch method to be non-plural to match all others	2023-01-23 15:43:52 +09:00
Dean Herbert	e3932c077b	Merge pull request #22032 from frenzibyte/fix-potential-difficulty-failure-alt ... Fix advanced statistics display potentially performing invalid difficulty calculation	2023-01-23 15:39:47 +09:00
cdwcgt	5afb733fb2	change IssueTemplatePreviewTimeConflict's text	2023-01-23 15:26:28 +09:00
Dean Herbert	7ebd31d42f	Add more keywords to settings based on feedback	2023-01-23 15:14:16 +09:00
Dean Herbert	2ed9fe3747	Add support for externally specified keywords in SettingsButtons	2023-01-23 15:10:26 +09:00
Dean Herbert	73f083a316	Refactor how additional points are provided to avoid confusion	2023-01-23 14:13:46 +09:00
Susko3	f8537c1cbe	Delegate file deletion to ImportTask to allow overriding it	2023-01-22 22:19:04 +01:00
EXtremeExploit	8d4889d5ce	Cleanup	2023-01-22 17:42:53 -03:00
EXtremeExploit	e60a089f1a	Set alpha on container instead of children	2023-01-22 15:02:02 -03:00
EXtremeExploit	de5eb63ceb	Fix codefactor	2023-01-22 13:38:13 -03:00
EXtremeExploit	933fc8cc83	Fix comment	2023-01-22 13:33:36 -03:00
EXtremeExploit	64c9654910	Make probationary groups a bit transparent	2023-01-22 13:32:05 -03:00
Dean Herbert	f87bb589a2	Merge pull request #22340 from EXtremeExploit/groups-modes ... Add modes text to groups tooltip	2023-01-23 01:10:25 +09:00
Bartłomiej Dach	e1acf85bb3	Merge branch 'master' into groups-modes	2023-01-22 10:09:34 +01:00
Bartłomiej Dach	9bde1ef9bf	Privatise setter	2023-01-22 10:09:08 +01:00
Bartłomiej Dach	b98da506c1	Fix code quality inspection	2023-01-22 10:07:47 +01:00
Bartłomiej Dach	31e7d7333b	Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog	2023-01-22 09:35:37 +01:00
Bartłomiej Dach	06aa3f7798	Rename Stop{SampleAndRemoveFilters -> }() ... Now that just one method for stopping samples is left, let's just repurpose st as the general "stop global effects" method rather than have it there with a hyperspecific name. It also has good symmetry, as there already was a `Start()` method in the class.	2023-01-22 09:29:22 +01:00
Bartłomiej Dach	9e4e85e3e3	Inline StopSample() into StopSampleAndRemoveFilters() ... The first method no longer has any callers except for the second one.	2023-01-22 09:26:01 +01:00
Bartłomiej Dach	0edfd24410	Remove unnecessary sample stop in Restart() ... It is unnecessary, as a successful restart will exit the current player screen, and `OnExiting()` has another `StopSampleAndRemoveFilters()` call, which means that in the restart flow the sample was actually getting stopped twice. Standard exit flow is fine, it only stopped the sample once.	2023-01-22 09:24:12 +01:00
Bartłomiej Dach	88d58e8476	Merge pull request #22337 from Joehuu/fix-comment-editor-sounds ... Fix comment editor text boxes not having sound feedback	2023-01-22 09:10:20 +01:00
Bartłomiej Dach	b66279c5d7	Merge pull request #22341 from peppy/screen-scaling-keywords ... Add search keywords for screen scaling sub-settings	2023-01-22 08:56:14 +01:00
Matheus Filipe dos Santos Reinert	db0b69db6b	Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog	2023-01-22 02:12:07 -03:00
Dean Herbert	7040743249	Add search keywords for screen scaling sub-settings	2023-01-22 13:47:31 +09:00
Matheus Filipe dos Santos Reinert	5b1a23c697	Replace RemoveFilters call with StopSampleAndRemoveFilters	2023-01-22 01:44:16 -03:00
Matheus Filipe dos Santos Reinert	2e1ba6ef49	Create StopSampleAndRemoveFilters method and change RemoveFilters to private	2023-01-22 01:43:40 -03:00
EXtremeExploit	2f3971b6fb	Move code to already existing if block	2023-01-22 01:40:00 -03:00
EXtremeExploit	8c208da324	Cleanup	2023-01-22 01:39:01 -03:00
EXtremeExploit	05f77d2cab	Add modes text to groups tooltip	2023-01-22 01:36:53 -03:00
Matheus Filipe dos Santos Reinert	a746cbc6ed	Fix failSample still playing after player left FailOverlay	2023-01-22 01:14:33 -03:00
Pasi4K5	75a1a2ec2f	Hide ResumeOverlay when OsuModAutopilot is enabled	2023-01-22 03:44:59 +01:00
Joseph Madamba	da03abc812	Fix comment editor text boxes not having sound feedback	2023-01-21 17:32:42 -08:00
naoey	1c1c9915bb	Split saving new and existing beatmaps into separate flows	2023-01-22 10:27:33 +09:00
Bartłomiej Dach	718cbf9382	Fix SegmentedGraph draw node calculating segment colours in unsafe manner ... The `SegmentedGraph`'s draw node would call `getSegmentColour()` on the drawable, which would query the `DrawColourInfo` and `tierColours` properties of the drawable. This is a cross-thread access and as such completely unsafe, as due to being cross-thread it can die on invalidations or out-of-bounds accesses. Fix by transferring everything to the draw node first before attempting to draw. `SegmentedGraph.TierColours` setter already correctly invalidates the draw node via `graphNeedsUpdate`, so no further intervention was required there. Closes #22326.	2023-01-21 23:19:34 +01:00
naoey	a1b5c9d910	Don't transfer MD5 hashes in collections when copying beatmaps ... Fixes #22306. Changes beatmap saving so that by default it does not transfer the hashes in collections, and only transfers them when saving the same difficulty in the editor. Issue seems to have been introduced in https://github.com/ppy/osu/pull/20641.	2023-01-22 01:14:18 +09:00
Salman Ahmed	c48af79588	Fix test browsers on longer working after framework update	2023-01-21 14:49:47 +03:00
Dean Herbert	19450bfe12	Update framework	2023-01-20 23:23:25 +09:00
ekrctb	d8f9b7d02f	Use MaximumJudgementOffset for lifetime	2023-01-19 21:25:21 +09:00
ekrctb	11e1b22bf5	Move MaximumJudgementOffset to HitObject ... We want to access this property for computing lifetime	2023-01-19 21:23:55 +09:00
ekrctb	812a4b412a	Move judgement result revert logic to Playfield ... Previously, some judgement results were not reverted when the source DHO is not alive (e.g. frames skipped in editor). Now, all results are reverted in the exact reverse order.	2023-01-19 19:57:13 +09:00
Dean Herbert	2ce32e3209	Refactor update logic to be easier to follow	2023-01-19 19:27:05 +09:00
mk56-spn	b22363ed8c	Fix JudgementCounterDisplay.cs max judgement always showing upon changing display mode	2023-01-19 10:31:02 +01:00
Dean Herbert	4916a742d5	Immediately focus the textbox when clicking to reply to a comment	2023-01-19 16:08:27 +09:00
Dean Herbert	81e6c3792c	Remove unused method	2023-01-19 16:03:46 +09:00
Dean Herbert	56ce8504ae	Merge branch 'master' into comment-reply	2023-01-19 16:01:47 +09:00
Dean Herbert	07af18b8a7	Remove ReplyCommentEditor into its own class	2023-01-19 16:01:37 +09:00
Dean Herbert	db8084570d	Merge pull request #22285 from bdach/segmented-graph-tint ... Apply draw colour to segmented graph	2023-01-19 13:36:19 +09:00
Dean Herbert	e58abf7d1a	Merge pull request #22284 from bdach/judgement-counter-broken ... Fix "show max judgement" setting not applying initially on judgement counter display	2023-01-19 09:09:06 +09:00
Bartłomiej Dach	a0fe71c706	Use alternative segment colour computation method	2023-01-19 00:08:32 +01:00
Bartłomiej Dach	b62ff8d644	Merge branch 'master' into skin/argon-song-progress-cleaner	2023-01-18 23:52:12 +01:00
Bartłomiej Dach	b8b7442eb8	Make SongProgressInfo.ShowProgress init-only (and remove duplicate init)	2023-01-18 23:35:40 +01:00
Bartłomiej Dach	903c37bf32	Apply draw colour to segmented graph segments	2023-01-18 23:17:57 +01:00
Wleter	f8d8a627b8	change property name	2023-01-18 22:00:39 +01:00
Bartłomiej Dach	769f8c6190	Fix ShowMaxJudgement callback conflicting with JudgementCounter.Pop{In,Out} ... Both `JudgementCounterDisplay` (via the `ShowMaxJudgement` callback) and the `JudgementCounter.Pop{In,Out}` methods were operating on the alpha of the `JudgementCounter`. This meant that if the counter display was created with max judgement initially hidden, it would be hidden by the `ShowMaxJudgement` callback first, but then _unhidden_ by `PopIn()`.	2023-01-18 21:46:28 +01:00
Wleter	40e99069fc	fix typos and newlines	2023-01-18 21:43:09 +01:00
Wleter	ab78dd0436	add collection of selection points.	2023-01-18 21:34:23 +01:00
ansel	77bc4fbf70	Integrate editor into comment	2023-01-18 20:50:07 +03:00
ansel	0d91277ea5	Add ability to change number on replies button	2023-01-18 20:49:30 +03:00
ansel	c74500b4b4	Add reply editor	2023-01-18 20:49:07 +03:00
Bartłomiej Dach	761298cd8e	Merge pull request #22275 from peppy/fix-legacy-old-judgement-animation ... Fix legacy judgement animation not matching perfectly	2023-01-18 18:27:13 +01:00
Gabe Livengood	150195b887	use extension method to check accuracy impact	2023-01-18 12:24:41 -05:00
Gabe Livengood	e0f3fa1af6	remove this in ruleset assignment	2023-01-18 12:22:27 -05:00
Bartłomiej Dach	4a6f6300c5	Merge branch 'master' into fix-carousel-sort-change-after-play	2023-01-18 17:15:20 +01:00
Bartłomiej Dach	7ba448b13c	Update comment to match implementation	2023-01-18 17:12:57 +01:00
cdwcgt	e5eab72aeb	add check for preview time setting	2023-01-19 01:08:37 +09:00
ansel	0f2ca5d5ed	Expose method for drawable comment creation	2023-01-18 18:10:35 +03:00
Wleter	c9375c056e	revert back name change	2023-01-18 15:54:24 +01:00
ansel	18baf3dd5d	Log delete failure	2023-01-18 17:30:34 +03:00
StanR	24ed84aad0	Add tiered level badge colouring	2023-01-18 16:25:11 +03:00
Salman Ahmed	12fc5da143	Merge branch 'master' into frame-stable-cache	2023-01-18 14:16:46 +03:00
Dean Herbert	3b27774561	Remove OnlineID sort consideration	2023-01-18 19:21:02 +09:00
Dean Herbert	4ef940653b	Fix legacy judgement animation not matching perfectly ... This will be the final attempt to get it right. I was seemingly drunk last time I wrote the logic. Closes #21892.	2023-01-18 19:03:04 +09:00
Dean Herbert	43a037c189	Merge pull request #21620 from mk56-spn/JudgementCounter ... Add a judgement counter to skin components	2023-01-18 18:43:49 +09:00
Dean Herbert	522bb8bcca	Use ComputeAccuracy to get imminent accuracy	2023-01-18 18:08:58 +09:00
Dean Herbert	ecb4727aec	Fix formatting issues	2023-01-18 17:33:14 +09:00
Dean Herbert	4cfb059170	Merge branch 'frame-stable-cache' into skin/argon-song-progress-cleaner	2023-01-18 17:21:08 +09:00
Dean Herbert	04705504c5	Move cache to more appropriate location	2023-01-18 17:19:57 +09:00
Dean Herbert	67b40dd234	Adjust the seek effect to feel better	2023-01-18 17:09:39 +09:00
Dean Herbert	01558a9199	Tidy up height logic and allow hovering above bar for easier interaction	2023-01-18 17:09:29 +09:00
Dean Herbert	f3677ab33d	Simplify depth change logic	2023-01-18 16:38:21 +09:00
Dean Herbert	7d0388c55c	Cache IFrameStableClock in Player for easier access ... Allows directly referencing rather than going through `DrawableRuleset`. Helps with testing and implementation of the new song progress display (#22144).	2023-01-18 16:31:58 +09:00
Dean Herbert	42e9b2b48c	Tidy up clock logic in all SongProgress classes	2023-01-18 16:29:42 +09:00
Dean Herbert	8bfd853889	Fix missing comment	2023-01-18 16:11:14 +09:00
Dean Herbert	bfb75730a9	Prefix subclasses of DefaultSongProgress with Default	2023-01-18 15:45:16 +09:00
Dean Herbert	1e5dd9165a	Adjust SkinnableTestScene to give more breathing room to RelativeSize components	2023-01-18 15:37:46 +09:00
Dean Herbert	7266d8e10d	Move "show difficulty graph" settings back to respective implementations to avoid legacy version showing it	2023-01-18 15:31:55 +09:00
Dean Herbert	5a272b4bd6	Merge branch 'master' into skin/argon-song-progress-cleaner	2023-01-18 15:25:02 +09:00
Dean Herbert	742a026077	Add comment mentioning why reference clock fallback logic is required	2023-01-18 15:24:35 +09:00
Dean Herbert	e8770b84cd	Remove no longer necessary interface type	2023-01-18 15:23:55 +09:00
Dean Herbert	5429979049	Combine common code into SongProgress base class	2023-01-18 15:23:55 +09:00
Dean Herbert	afc12e0b83	Tidy up ISongProgressBar interface	2023-01-18 14:43:20 +09:00
Dean Herbert	39ac7615ec	Merge branch 'master' into registration-loc	2023-01-18 13:41:53 +09:00
Dean Herbert	f7c4199a77	Merge pull request #22262 from Joehuu/chat-mention-user ... Add ability to easily mention users in chat by right clicking username	2023-01-18 13:30:02 +09:00
Dean Herbert	736ff419c0	Merge pull request #22261 from peppy/fix-bad-operation ... Fix song select potentially operating on `Carousel` before it is fully loaded	2023-01-18 12:06:33 +09:00
Dean Herbert	4ad79a8a0a	Move IsLoaded check inside BeatmapCarousel	2023-01-18 12:00:47 +09:00
Dean Herbert	0a47dc733f	Merge pull request #22268 from Feodor0090/comments-margin ... Reduce padding for too nested comments	2023-01-18 11:45:41 +09:00
ansel	ca3be71381	Track comment's nesting and reduce padding for too nested	2023-01-18 02:11:07 +03:00
ansel	12544c16ea	Remove canBeNull	2023-01-18 02:10:02 +03:00
Joseph Madamba	dfea42fd16	Add space after username mention	2023-01-17 14:13:50 -08:00
Joseph Madamba	254c881ded	Also check null for bindable channel value	2023-01-17 14:12:48 -08:00
Bartłomiej Dach	f7c942ac10	Move user stats into detail header container	2023-01-17 22:32:24 +01:00
Bartłomiej Dach	7a475d9cf8	Move out stats from top header container	2023-01-17 22:32:15 +01:00
Bartłomiej Dach	350cce1315	Move contents of detail header to separate component	2023-01-17 22:32:12 +01:00
mk56-spn	92a755c5da	adjust colourbar to position itself in a more simple fashion	2023-01-17 22:16:59 +01:00
Bartłomiej Dach	f5459909f9	Merge branch 'master' into comment-editor-3	2023-01-17 21:31:08 +01:00
Bartłomiej Dach	3640342805	Add logging on comment post failure	2023-01-17 21:30:46 +01:00
Wleter	788033e1b8	fix unnecessary newline	2023-01-17 21:13:54 +01:00
Bartłomiej Dach	6f11fbdeed	Merge branch 'master' into fix-carousel-sort-change-after-play	2023-01-17 20:46:06 +01:00
Wleter	b8e6a2d87b	filter currentEndPointPositions	2023-01-17 20:41:49 +01:00