27303 Commits

Author	SHA1	Message	Date
JimmyC7834	e7aeba8d03	added more visual tests	2021-06-20 18:28:43 +08:00
JimmyC7834	42fdfbb9a1	added visual tests	2021-06-20 17:17:07 +08:00
smoogipoo	32bd3107e1	Remove high performance GC setting	2021-06-20 17:07:41 +09:00
Bartłomiej Dach	1f383532f2	Move FodyWeavers configuration to solution root	2021-06-20 10:05:49 +02:00
Bartłomiej Dach	46b9fd9ac8	Remove and ignore FodyWeavers schema files	2021-06-20 10:05:42 +02:00
JimmyC7834	27da3dc75a	added supporter-only-filter content	2021-06-19 20:54:24 +08:00
Dean Herbert	b6e07ff59c	Merge pull request #13572 from bdach/fix-unsupported-locales ... Fix game crashes due to attempting localisation load for unsupported locales	2021-06-19 17:09:39 +09:00
Dean Herbert	afcc3e14f4	m	2021-06-19 16:16:29 +09:00
Bartłomiej Dach	b47774b55a	Remove Tagalog language for now ... Rationale given in inline comment.	2021-06-19 08:07:37 +02:00
Bartłomiej Dach	76db87f9cb	Try-catch around localisation store registration ... Some platforms (android, older windows versions) will throw exceptions at runtime when an unsupported `CultureInfo` is attempted to be instantiated, leading to nasty crashes. Add a preventative try-catch registration to prevent the crash, and log the errors for visibility.	2021-06-19 08:02:30 +02:00
Dean Herbert	3f336d88ec	Merge pull request #11461 from peppy/realm-key-binding-store ... Add initial realm database implementation with KeyBindingStore migration	2021-06-19 02:49:41 +09:00
Dean Herbert	89c27dcb10	Merge pull request #13517 from ekrctb/initial-entry ... Allow setting `Entry` of `PoolableDrawableWithLifetime` (including `DrawableHitObject`)	2021-06-19 00:03:41 +09:00
Dean Herbert	fa838ba253	Merge pull request #13528 from gagahpangeran/last-lang ... Add remaining non-rtl language	2021-06-19 00:00:33 +09:00
smoogipoo	acb47b1606	Merge branch 'master' into last-lang	2021-06-18 23:30:59 +09:00
Dean Herbert	b1fd812805	Merge branch 'master' into more-ui-sfx	2021-06-18 23:24:19 +09:00
Dean Herbert	36f0769f83	Merge branch 'master' into inter-font	2021-06-18 22:38:20 +09:00
Dean Herbert	1ec03bf6fa	Update resources	2021-06-18 22:25:24 +09:00
Dean Herbert	1f6b4b10ab	Update resources	2021-06-18 22:16:15 +09:00
Dean Herbert	390abccb4b	Add workaround for dropdowns playing close animation on first display	2021-06-18 22:08:59 +09:00
Jamie Taylor	5ce52b2669	fix ModButton duplicate click sound	2021-06-18 21:41:07 +09:00
Jamie Taylor	6e4fc26e16	replace 'songselect' hover/click sounds with 'button' ones for now	2021-06-18 21:03:46 +09:00
Jamie Taylor	953683044f	fix checkbox sounds not being used for certain checkboxes	2021-06-18 21:00:08 +09:00
Dean Herbert	5897475708	Merge pull request #13552 from peppy/fix-ruleset-dll-rename ... Fix loading a ruleset with an updated internal name causing a potential startup crash	2021-06-18 20:18:54 +09:00
Dean Herbert	2dadc9d686	Remove unused using statement	2021-06-18 19:39:01 +09:00
Dan Balasescu	846647b5c5	Merge pull request #13549 from peppy/storyboard-outro-logic-refactor ... Separate out storyboard outro logic as much as possible from score completion flow	2021-06-18 19:38:00 +09:00
Dean Herbert	78c5ccda60	Fix renaming a ruleset DLL causing a startup crash	2021-06-18 19:32:40 +09:00
smoogipoo	42c5a962fb	Add xmldoc remark	2021-06-18 19:27:10 +09:00
smoogipoo	36d51d5117	Don't set entry immediately	2021-06-18 19:23:37 +09:00
smoogipoo	36d2199a02	Add exception on Apply() while loading	2021-06-18 19:20:57 +09:00
Jamie Taylor	d462394635	add sound to dropdowns	2021-06-18 19:16:28 +09:00
Jamie Taylor	4feb7c848f	add sound to tab controls	2021-06-18 19:16:00 +09:00
Dan Balasescu	e0f4c792b8	Merge pull request #13546 from peppy/mods-can-specify-self-in-incompatible-list ... Allow mods to specify incompatibility types which they implement themselves	2021-06-18 19:07:38 +09:00
Dean Herbert	c751e087ca	Merge branch 'master' into skin-editor-closest-anchor	2021-06-18 18:54:07 +09:00
Dean Herbert	36b5414b1d	Update comment to hopefully explain a weird conditional better	2021-06-18 17:46:01 +09:00
Dean Herbert	d5a1524eb0	Add missing rulesetID check for global action matching	2021-06-18 17:12:01 +09:00
Dean Herbert	d06e52505a	Fix thread safety of KeyBindingStore.GetReadableKeyCombinationsFor	2021-06-18 17:11:39 +09:00
Dean Herbert	c369beeaaa	Merge branch 'master' into realm-key-binding-store	2021-06-18 16:52:35 +09:00
Dean Herbert	0bc68a7018	Move xmldoc to method	2021-06-18 16:50:31 +09:00
Dean Herbert	19507e107e	Reorder methods to make more sense	2021-06-18 16:46:40 +09:00
Dean Herbert	a7f40dc6d4	Merge branch 'remove-synchronous-prepare-score-method' into storyboard-outro-logic-refactor	2021-06-18 16:45:01 +09:00
Dean Herbert	45122594e5	Remove the synchronous version of PrepareScoreForResults ... Replaces all existing usages with the `async` version.	2021-06-18 16:24:08 +09:00
Dean Herbert	f3426e38b4	Add note about delay parameter	2021-06-18 16:18:20 +09:00
Dean Herbert	3819a1f03b	Remove exit override behaviour ... I don't actually know under what scenario this could have been hit, and actually caused expected behaviour. Consider that in the scenario I describe in the comment (which I added yesterday), the user is requesting a pause or exit which would be "cancelled showing the results instead". But in such a scenario, `PerformExit` would first be run, which cancels the `resultsDisplayDelegate` in the first place. The only special case would be pressing the close button on the window decoration? Which I don't think should be a special case in the first place, so I'm just going to remove this for the time being to keep things simple.	2021-06-18 16:12:35 +09:00
Dean Herbert	06d1bd971c	Default DrawableStoryboard to a completed state to avoid state change on empty storyboards	2021-06-18 16:08:49 +09:00
Dean Herbert	7ef8eac773	Remove unnecessary (and no longer correct) exception	2021-06-18 16:08:31 +09:00
Jamie Taylor	752d0a9f0b	add sound to scroll-to-top button	2021-06-18 16:08:14 +09:00
Dean Herbert	2bf855fcca	Move all storyboard outro skip logic out of updateCompletionState ... This method should only be called to trigger the score completion portion of player progression. The storyboard skip/end logic is now handled separately in `progressToResults`.	2021-06-18 15:50:43 +09:00
smoogipoo	5cf2ac78fc	Adjust font namespaces	2021-06-18 15:40:35 +09:00
Dan Balasescu	2cd72a92e8	Merge pull request #13499 from ekrctb/fix-mania-editor-crash ... Rewrite mania selection blueprint to use only `HitObject` (no `DrawableHitObject`) for layout	2021-06-18 15:10:28 +09:00
Dan Balasescu	cdc1c60fab	Merge branch 'master' into fix-mania-editor-crash	2021-06-18 13:49:25 +09:00
Dean Herbert	4de27429bc	Change ModSelectOverlay to never deselect the user triggered selection	2021-06-18 13:17:55 +09:00
Dean Herbert	5933e0d2d9	Change CheckCompatibleSet to never deselect the current candidat when checking incompatibility	2021-06-18 13:17:32 +09:00
smoogipoo	97cd1217a4	Move IApplicableToDrawableHitObjects to its own file	2021-06-18 13:06:13 +09:00
Bartłomiej Dach	f282326f9a	Move score preparations back below ShowResults check	2021-06-17 19:04:52 +02:00
Bartłomiej Dach	3a1444e75d	Fix malformed xmldoc tag ... Oops. Made a typo in the PR suggestion.	2021-06-17 19:02:56 +02:00
Dean Herbert	9facfe8964	Apply suggestions from code review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-06-18 01:07:54 +09:00
Dean Herbert	e0a3696145	Merge branch 'master' into player-completion-refactoring	2021-06-17 23:51:42 +09:00
Bartłomiej Dach	aae2923e14	Merge branch 'master' into player-pause-exit-results-flow-refactoring	2021-06-17 16:05:09 +02:00
Bartłomiej Dach	10b0d066be	Reword comments slightly	2021-06-17 16:04:58 +02:00
Bartłomiej Dach	561dbea9e1	Use xmldoc-specific syntax for nicer formatting	2021-06-17 15:26:50 +02:00
Dan Balasescu	6cec1145e3	Merge pull request #13523 from ekrctb/applicable-to-dho ... Reduce boilerplate of `IApplicableToDrawableHitObjects` by taking a single DHO instead of an enumerable	2021-06-17 19:59:06 +09:00
Dan Balasescu	77a0e9145d	Merge pull request #13539 from peppy/improve-updateable-avatar-tooltip-handling ... Fix edges of participant tiles showing incorrect tooltip	2021-06-17 19:14:40 +09:00
Dean Herbert	d03c6da60c	Refactor and redocument updateCompletionState() and surrounding methods	2021-06-17 19:13:53 +09:00
Dean Herbert	246ab41cc6	Remove special casing for user exit during storyboard outro	2021-06-17 18:11:15 +09:00
Dean Herbert	7cbebe6d11	Rewrite xmldoc and inline comments for PerformExit	2021-06-17 18:10:59 +09:00
Dan Balasescu	79af80833f	Merge pull request #13537 from peppy/fix-author-info ... Improve code quality of `AuthorInfo`	2021-06-17 16:34:45 +09:00
Dean Herbert	a0e5301c9f	Update usages of showGuestOnNull	2021-06-17 16:33:43 +09:00
Dean Herbert	808b2baa41	Consume new behaviour to fix UserTile discrepancy ... Closes https://github.com/ppy/osu/issues/13522.	2021-06-17 16:31:12 +09:00
Dean Herbert	d9cc1c227b	Allow UpdateableAvatar to handle displaying username as tooltip	2021-06-17 16:31:12 +09:00
Dean Herbert	9495f87f04	Remove redundant NotNull attributes in nullable classes	2021-06-17 16:07:32 +09:00
Dean Herbert	8da0431fa0	Improve code quality of AuthorInfo	2021-06-17 16:05:50 +09:00
Dean Herbert	8e45f26617	Merge branch 'master' into applicable-to-dho	2021-06-17 15:23:56 +09:00
ekrctb	e7954ecb60	Use property instead of backing field consistently	2021-06-17 10:31:20 +09:00
ekrctb	9dcd0bf311	Remove IPlayfieldProvider by caching Playfield	2021-06-17 10:15:24 +09:00
Salman Ahmed	780388d174	Fix incorrect return value	2021-06-17 03:48:29 +03:00
Bartłomiej Dach	418dbf3f3e	Merge branch 'master' into fix-mania-editor-crash	2021-06-16 18:26:33 +02:00
Bartłomiej Dach	191f47f5ee	Merge branch 'master' into beatmap-listing-enum-localisation	2021-06-16 17:44:16 +02:00
Salman Ahmed	74ad6f9117	Remove default skin from the ruleset skin sources ... That one doesn't need any changes to it, can be fetched from the `SkinManager` instead.	2021-06-16 17:24:31 +03:00
Salman Ahmed	52ddf08532	Consider not adding legacy skin transformers to non-legacy skins	2021-06-16 17:24:16 +03:00
Dean Herbert	a8b65d8417	Merge pull request #13430 from pavlukivan/taiko-hd-mod ... Add osu!taiko "Hidden" mod	2021-06-16 23:24:04 +09:00
Gagah Pangeran Rosfatiputra	0e9ca3df3c	add remaining non-rtl language	2021-06-16 21:14:48 +07:00
Gagah Pangeran Rosfatiputra	4b926791b5	add inter font	2021-06-16 21:13:01 +07:00
Salman Ahmed	5ebf570ec4	Revert GetRulesetTransformedSkin accessibility change ... This reverts commit 521077b714. Forgot to do it when I made this `protected`, but subclasses in test scenes require this.	2021-06-16 16:49:38 +03:00
ekrctb	b6a9fa9999	Merge branch 'master' into applicable-to-dho	2021-06-16 22:04:10 +09:00
Dean Herbert	bacb916c03	Merge pull request #13524 from smoogipoo/fix-hud-test-failure ... Fix intermittent HUD test failure	2021-06-16 21:53:58 +09:00
smoogipoo	19f0e3d695	Add HighPerformanceSession	2021-06-16 20:53:48 +09:00
Bartłomiej Dach	a295421b64	Use language-specific lookup key for Other filter	2021-06-16 13:27:02 +02:00
Bartłomiej Dach	69a474e4ab	Merge branch 'master' into beatmap-listing-enum-localisation	2021-06-16 13:16:58 +02:00
Dan Balasescu	382de42438	Merge pull request #13498 from ekrctb/refactor-scrolling-hoc-2 ... Change coordinate used in newly added `ScrollingHitObjectContainer` methods	2021-06-16 20:02:32 +09:00
smoogipoo	2155a4da0a	Fix intermittent HUD test failure	2021-06-16 19:52:58 +09:00
Dan Balasescu	6613301588	Merge branch 'master' into refactor-scrolling-hoc-2	2021-06-16 19:20:11 +09:00
smoogipoo	37babbde6a	Simplify score filter row	2021-06-16 19:09:11 +09:00
Bartłomiej Dach	dc2e3ff89e	Fix wrong language codes ... Confused them with the flags from the web-side source used. Tagalog (`tl`) still has no discernible effect, but that's because there are actually no localisation files in `osu-resources` for that language. Leave it be for now, as web has that entry, so it might mean that translations might be coming at some point in the future.	2021-06-16 12:01:58 +02:00
ekrctb	c59a3ce83f	Obsolete plural IApplicableToDrawableHitObjects	2021-06-16 18:52:16 +09:00
ekrctb	af80418ee8	Implement IApplicableToDrawableHitObject for mods ... A breaking change in `ModWithVisibilityAdjustment` if the method was overriden.	2021-06-16 18:52:01 +09:00
Dean Herbert	379b84ba22	Update framework	2021-06-16 18:51:17 +09:00
Dean Herbert	f4fb2e127d	Merge pull request #13518 from smoogipoo/sort-by-localisation ... Localise "sort by" text in overlays	2021-06-16 18:50:53 +09:00
Dan Balasescu	537cbd1214	Merge pull request #13520 from bdach/add-more-language-enum-values ... Add more languages to settings dropdown	2021-06-16 18:49:42 +09:00
ekrctb	67d8e0059f	Use singular IApplicableToDrawableHitObject for consumers	2021-06-16 18:47:04 +09:00
ekrctb	e69bb67afe	Add IApplicableToDrawableHitObject that is taking a single DHO ... Less cumbersome to implement than old version taking an enumerable. The implementation was always using `foreach` for the enumerable. The new interface is not used yet.	2021-06-16 18:42:28 +09:00
Bartłomiej Dach	cc5145a131	Fix languages with a sub-language part not working properly	2021-06-16 11:10:03 +02:00
ekrctb	2b0e6b6b51	Don't invoke "completed" action for test scene virtual track ... `MusicController` tries to play the next music when a track is completed. In test scenes, we want to keep the virtual track, not random songs.	2021-06-16 17:44:21 +09:00
Dean Herbert	521077b714	Make getRulesetTransformedSkin private	2021-06-16 17:44:18 +09:00
Bartłomiej Dach	d298e95df7	Limit maximum height of settings enum dropdowns	2021-06-16 10:25:50 +02:00
Bartłomiej Dach	64bb1f381b	Add more languages to settings dropdown	2021-06-16 10:25:30 +02:00
Dean Herbert	4b45d8318e	Merge branch 'master' into transformers-per-skin	2021-06-16 16:37:28 +09:00
Dean Herbert	5944c45f55	Specify types explicitly and don't handle non-nullable values with fallbacks	2021-06-16 16:24:30 +09:00
smoogipoo	fafd936c93	Localise "sort by" string in overlays	2021-06-16 16:21:41 +09:00
smoogipoo	6d6604e2f0	Fix incorrect indentation ... I used this for the o!f example.	2021-06-16 16:19:47 +09:00
Dean Herbert	b24730efdb	Merge pull request #13512 from smoogipoo/add-localisation-example ... Localise parts of the beatmap listing overlay	2021-06-16 16:03:40 +09:00
ekrctb	117e94bc94	Allow setting Entry of PoolableDrawableWithLifetime ... It is more convenient than using the constructor because the only limited kind of expression is allowed in a base constructor call. Also, the object initializer syntax can be used.	2021-06-16 16:00:08 +09:00
smoogipoo	3c3ff8be0d	Localise beatmap listing enum values	2021-06-16 15:58:07 +09:00
Dean Herbert	cb80577922	Merge pull request #13509 from bdach/fix-seasonal-backgrounds ... Fix seasonal backgrounds not cycling	2021-06-16 15:26:46 +09:00
Dean Herbert	68fa7d68cc	Merge pull request #13511 from smoogipoo/fix-possible-nullref-2 ... Fix possible nullref in difficulty recommender	2021-06-16 15:20:45 +09:00
Dean Herbert	f802679d38	Merge pull request #13497 from smoogipoo/fix-present-score ... Make PresentScore() use replay hash as fallback	2021-06-16 15:18:01 +09:00
smoogipoo	4c5268694e	Localise some of the BeatmapListingOverlay	2021-06-16 13:46:13 +09:00
smoogipoo	fa00d07107	Upgrade osu-resources	2021-06-16 13:26:36 +09:00
Dean Herbert	66efc3c4de	Merge branch 'master' into realm-key-binding-store	2021-06-16 13:23:13 +09:00
smoogipoo	a5261f0cb3	Add difficulty recommender instantly	2021-06-16 11:48:49 +09:00
smoogipoo	6be41e497a	Fix possible nullref in difficulty recommender	2021-06-16 11:27:38 +09:00
emu1337	be68950c30	refactoring	2021-06-16 03:34:46 +02:00
Bartłomiej Dach	022b1a28d5	Add missing equality implementation for seasonal backgrounds ... The equality operator is used to determine whether the next background in the cycle should be loaded, to avoid pointless loads of the same background several times (see #13362 and #13393). Its omission in the latter pull caused seasonal backgrounds to no longer cycle. Closes #13508.	2021-06-15 23:21:48 +02:00
Dean Herbert	9d168b19c9	Switch to non-beta release	2021-06-16 02:15:25 +09:00
Dean Herbert	acc06ca398	Merge branch 'master' into realm-key-binding-store	2021-06-16 02:14:58 +09:00
Dan Balasescu	e9d4ee3c87	Merge branch 'master' into enhance-mod-settings-text-box-visibility	2021-06-15 16:09:55 +09:00
ekrctb	ef96ceb4ab	Introduce IPlayfieldProvider	2021-06-15 14:43:04 +09:00
smoogipoo	579a4aa9c8	Remove comment	2021-06-15 14:10:09 +09:00
smoogipoo	eb4c093371	Use hash as fallback	2021-06-15 14:06:17 +09:00
ekrctb	bbf0022689	Use natural anchor for TimeAtPosition and PositionAtTime ... The natural anchor is the end of the scrolling direction (e.g. Bottom for Down scrolling).	2021-06-15 13:15:20 +09:00
smoogipoo	f6c6eea6dc	Make PresentScore() only consider replay hash	2021-06-15 11:16:35 +09:00
Bartłomiej Dach	cb1e2e3d97	Improve xmldoc	2021-06-14 21:54:55 +02:00
Dan Balasescu	84ec378be1	Merge branch 'master' into refactor-scrolling-hoc-1	2021-06-14 20:42:38 +09:00
Dan Balasescu	980afd6a04	Merge branch 'master' into fix-song-select-leaderboard-events	2021-06-14 20:03:36 +09:00
Dan Balasescu	15a20ed9d6	Merge pull request #13486 from peppy/revert-nested-platform-container ... Revert "Add nested `PlatformActionContainer` to allow testing of platform actions in visual tests"	2021-06-14 19:53:14 +09:00
Dean Herbert	75b5b50aee	Merge pull request #13490 from smoogipoo/arbitrary-localisation-assembly ... Match any arbitrary assembly for localisations	2021-06-14 19:05:22 +09:00
Dean Herbert	13d0eaa9fe	Update framework	2021-06-14 19:03:31 +09:00
smoogipoo	b327baa4de	Match any arbitrary assembly for localisations	2021-06-14 17:47:31 +09:00
smoogipoo	aa5dae84b2	Make all localisation class strings verbatim	2021-06-14 16:51:17 +09:00
Dean Herbert	83402a70db	Fix potential null ref when no beatmap is selected	2021-06-14 15:06:24 +09:00
Dean Herbert	f8b09b7c81	Avoid refresh if score is not related to current display	2021-06-14 14:28:14 +09:00
Dean Herbert	fc442713bb	Debounce schedule at base class	2021-06-14 14:26:40 +09:00
Dean Herbert	8dd48d48f6	Add support for song select leaderboard to handle newly imported scores	2021-06-14 14:20:23 +09:00
Dean Herbert	564682270a	Revert "Add nested PlatformActionContainer to allow testing of platform actions in visual tests" ... This reverts commit be91203c92.	2021-06-14 13:18:52 +09:00
ekrctb	660bf50dc7	Clarify multiple coordinate systems ... - Fix wrong position is set for DHOs for down/right scrolling direction.	2021-06-14 13:13:27 +09:00
ekrctb	09f1cbde7e	Fix TimeAtPosition doc comment	2021-06-14 13:13:27 +09:00
ekrctb	fdb09ef4d7	Simplify flipPositionIfRequired using scrollLength	2021-06-14 13:13:27 +09:00
ekrctb	8cf4454780	Use Direction enum instead of int ... The property is named `scrollingAxis` to distinguish from `direction`, which is of `ScrollingDirection` type (unfortunate name crash).	2021-06-14 13:13:27 +09:00
Dean Herbert	17347401cf	Remove unused RankingType enum ... We have `BeatmapLeaderboardScope` instead.	2021-06-14 11:27:46 +09:00
Pasi4K5	ef9cb2c958	Rename nested classes	2021-06-12 18:37:31 +02:00
Pasi4K5	b79d57b68c	Move OsuSettingsNumberBox into SettingsNumberBox	2021-06-12 17:57:40 +02:00
Pasi4K5	c728f673d6	Rename classes	2021-06-12 17:37:01 +02:00
Pasi4K5	29f3880415	Move classes into SettingsTextBox	2021-06-12 17:34:02 +02:00
Pasi4K5	bb661abfa6	Clean up OsuModSettingsTextBox	2021-06-12 17:25:22 +02:00
Pasi4K5	fe39a47797	Add OsuModSettingsTextBox and OsuModSettingsNumberBox	2021-06-12 00:34:53 +02:00
Bartłomiej Dach	902bb84ca8	Merge branch 'master' into fix-wave-overlay-sound-on-switch	2021-06-11 22:05:08 +02:00
Dean Herbert	f773ea475d	Update framework	2021-06-12 01:37:13 +09:00
Dean Herbert	c2759121b9	Merge pull request #13454 from nekodex/change-default-hover-click-sample ... Change default HoverSounds/HoverClickSounds samples	2021-06-12 01:01:35 +09:00
Dean Herbert	121df57dca	Fix focused overlays playing their "appear" sound when not necessarily changing state	2021-06-12 00:26:33 +09:00
Dean Herbert	0dbe5dd219	Remove unused using statement	2021-06-12 00:23:18 +09:00
Dean Herbert	d9ea8d64d4	Remove weird local sample logic in ChangelogOverlay	2021-06-12 00:05:49 +09:00
Salman Ahmed	8de0d33c5a	Revert "Move collection change bind to LoadComplete" ... This reverts commit d6d87e1975. Actually that broke things due to the "disableable" instances not added early enough, revert for now.	2021-06-11 17:59:29 +03:00
Salman Ahmed	b6947c25ec	Fix potentially adding the same skin multiple times	2021-06-11 17:55:07 +03:00
Dean Herbert	e098cac1cf	Minor code reformatting / moving	2021-06-11 23:49:14 +09:00
Dean Herbert	5887b4a27c	Update stand-alone usage of hover/select sounds in DrawableOsuMenuItem	2021-06-11 23:46:42 +09:00
Salman Ahmed	d6d87e1975	Move collection change bind to LoadComplete ... Best practice anyways	2021-06-11 17:35:33 +03:00
Dean Herbert	97bb3de1c9	Update resources	2021-06-11 23:03:27 +09:00
Dean Herbert	9c6c1dd237	Merge branch 'master' into change-default-hover-click-sample	2021-06-11 23:03:23 +09:00
Salman Ahmed	108a3deb27	Also handle null Ruleset.CreateLegacySkinProvider values ... Let's just go this way for now, maybe it's a better choice to always create transformers and disallow null, but it's too much work and out of scope at this point	2021-06-11 16:26:54 +03:00
smoogipoo	dca001a72d	Upgraed localisation analyser packages	2021-06-11 22:22:47 +09:00
Bartłomiej Dach	550d566bf9	Simplify member access	2021-06-11 14:24:17 +02:00
Bartłomiej Dach	876a357bf2	Add support for animated colour fill in new style legacy health bar	2021-06-11 14:24:17 +02:00
Jamie Taylor	0b95d07390	Change 'default' hover/click samples into 'button' samples and make 'soft' the new 'default'	2021-06-11 20:47:57 +09:00
Dan Balasescu	3389c4830b	Merge branch 'master' into refactor-scrolling-hoc-1	2021-06-11 20:35:19 +09:00
Jamie Taylor	4f80a3b66d	Add fallback-to-default logic for HoverSounds and HoverClickSounds	2021-06-11 20:14:35 +09:00
Robin Avery	0c8851f4b7	Extract drawable.ScreenSpaceDrawQuad to a variable	2021-06-11 07:06:22 -04:00
Dean Herbert	26312bf60a	Merge branch 'master' into chat-mention	2021-06-11 20:03:44 +09:00
Robin Avery	a6774eb5b5	Inline getOriginPositionFromQuad	2021-06-11 06:59:00 -04:00
Robin Avery	c9b4f9eb71	Make getOriginPositionFromQuad local	2021-06-11 06:55:47 -04:00
Robin Avery	1bc8460902	Rename getTieredComponent to getAnchorFromPosition ... Also rename parameter `component` to `xOrY`.	2021-06-11 06:53:40 -04:00
Robin Avery	6e181a6b63	Rename parameters of getTieredComponent	2021-06-11 06:53:04 -04:00
Robin Avery	a76eaeb52d	Make getTieredComponent local	2021-06-11 06:51:12 -04:00
Jamie Taylor	15d3b4444d	Rename HoverSounds and HoverClickSounds samples	2021-06-11 19:34:54 +09:00
Robin Avery	635300b311	Recalculate closest anchor when origin is changed	2021-06-11 06:28:30 -04:00
smoogipoo	9f163f7f20	Use switch statement to be more explicit about state	2021-06-11 19:23:25 +09:00
Robin Avery	a506f2a776	Revert rename of lambda variables	2021-06-11 06:22:24 -04:00
smoogipoo	0a8daab4f7	Pause master clock when too far ahead	2021-06-11 19:15:53 +09:00
Salman Ahmed	f20146d446	Fix potentially adding null skin sources	2021-06-11 12:58:38 +03:00
Salman Ahmed	e59beffc4e	Forward all base transformer lookup methods to Skin	2021-06-11 12:44:25 +03:00
smoogipoo	59eda70c12	Seek to the least most-recent frame instead	2021-06-11 18:40:56 +09:00
Salman Ahmed	9e16359f18	Refactor disallowing in SkinProvidingContainer to become per source ... Fixes `FindProvider` becoming completely broken, because of no way to perform the checks on one skin source.	2021-06-11 12:29:29 +03:00
ekrctb	af3f253b21	Refactor ScrollingHitObjectContainer and expose more useful methods	2021-06-11 18:28:48 +09:00
smoogipoo	263b8ff097	Wait for full player load	2021-06-11 18:14:37 +09:00
Dean Herbert	8eab7df955	Move BindCollectionChanged out of async load	2021-06-11 17:51:58 +09:00
Salman Ahmed	2e01e61177	Move TODO comment to correct location	2021-06-11 11:46:30 +03:00
Salman Ahmed	8132852753	Add other affectable change action cases	2021-06-11 11:34:22 +03:00
Salman Ahmed	a985e3b8d3	Apply documentation settings for better readability ... Co-authored-by: Dean Herbert <pe@ppy.sh> Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-06-11 11:25:07 +03:00
Dean Herbert	20759657de	Rename configuration variables and refactor lots more	2021-06-11 16:37:31 +09:00
Dean Herbert	3d645608eb	Remove nullability of DI dependencies and fix incorrect load order	2021-06-11 16:28:53 +09:00
Dean Herbert	139401a04a	Inline and refactor overly verbose MessageNotifier code	2021-06-11 16:27:31 +09:00
smoogipoo	a99cb79738	Seek master clock on multi-spectator start	2021-06-11 16:25:45 +09:00
smoogipoo	75d825c85c	Dont control master clock from sync manager	2021-06-11 16:24:52 +09:00
smoogipoo	1c67ef7c91	Make catchup clock support seeking	2021-06-11 16:23:59 +09:00
Bartłomiej Dach	296761ade5	Add missing CurrentSkin null check in DHO disposal	2021-06-11 09:18:58 +02:00
Dean Herbert	c00f9ae4b7	Reword settings text	2021-06-11 16:11:37 +09:00
Dean Herbert	04413f1634	Merge pull request #13444 from peppy/editor-timeline-taiko-hit-colouring ... Show osu!taiko centre/rim colouring in editor timeline	2021-06-11 15:10:24 +09:00
Dean Herbert	debd359d2e	Update xmldoc	2021-06-11 14:50:21 +09:00
Dean Herbert	b9050f91a4	Expose as Skins and consume SkinInfo from instances	2021-06-11 14:49:35 +09:00
Dean Herbert	562cfe8703	Fix filename not matching type rename	2021-06-11 14:34:18 +09:00
Dan Balasescu	97375d9625	Merge pull request #13438 from bdach/more-metadata-fields ... Add remaining metadata fields to editor setup screen	2021-06-11 14:17:34 +09:00
Dean Herbert	bc3b7233ab	Show osu!taiko centre/rim colouring in editor timeline ... Closes #13443.	2021-06-11 14:17:30 +09:00
Bartłomiej Dach	375f64ffd1	Check empty string more explicitly in IsRomanised() ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-06-11 06:38:53 +02:00
Bartłomiej Dach	7fd26ff3b0	Merge branch 'master' into more-metadata-fields	2021-06-11 06:35:51 +02:00
Dean Herbert	38bf04d7ff	Give more space for time values to allow for negative offsets	2021-06-11 13:25:09 +09:00
Salman Ahmed	169c98f963	Add skin providing ruleset resources in RulesetSkinProvidingContainer	2021-06-11 00:25:22 +03:00
Bartłomiej Dach	417aaacc53	Add test coverage for romanised data transfer	2021-06-10 22:18:39 +02:00
Bartłomiej Dach	e41a5a0fcd	Add romanised author & title fields	2021-06-10 22:17:45 +02:00
ilsubyeega-desu	f65f074131	Add star keyword to FilterQueryParser criteria	2021-06-11 02:46:29 +09:00
Salman Ahmed	2240e2c39c	Refrain from attempting to clear skin sources in disposal ... `Drawable.Dispose` is usually in an asynchronous context (async disposals stuff) and therefore this could cause a "collection was modified; enumeration opeartion may not execute" exception.	2021-06-10 17:23:16 +03:00
smoogipoo	58d71e4aea	Remove local "next frame" storage	2021-06-10 22:41:38 +09:00
Salman Ahmed	680791301f	Consume new method rather than caching skin sources on top of Player	2021-06-10 16:36:46 +03:00
Salman Ahmed	23d6c366ac	Add method for assigning arbitrary skins to player in test scenes	2021-06-10 16:36:46 +03:00
Salman Ahmed	ef2c4fd0d8	Make RulesetSkinProvidingContainer able to be overriden for testing purposes	2021-06-10 16:36:46 +03:00
Salman Ahmed	09a2d008d2	Refrain from attempting to transform null skins	2021-06-10 16:36:45 +03:00
smoogipoo	e18f4cd4ba	Combine methods	2021-06-10 22:01:39 +09:00
smoogipoo	5073ede115	Clear existing frames when starting gameplay	2021-06-10 21:38:46 +09:00
smoogipoo	9eecb23fef	Only seek to the end on first frame arrival	2021-06-10 21:35:52 +09:00
Bartłomiej Dach	252fe0a6cc	Add source and tags text boxes to metadata section	2021-06-10 14:13:59 +02:00
Bartłomiej Dach	5a2e710095	Split common method for metadata textbox creation	2021-06-10 13:55:34 +02:00
Salman Ahmed	5c9c424a0d	Switch state case placements for consistency ... Tickled me.	2021-06-10 13:15:18 +03:00
Salman Ahmed	c3a2f2c2a4	Expose default SkinManager providers for use in RulesetSkinProvidingContainer	2021-06-10 13:07:32 +03:00
Salman Ahmed	59be3588eb	Change SkinSources to a bindable list for binding SourceChanged events	2021-06-10 13:07:32 +03:00
Dan Balasescu	35d5632355	Merge pull request #13378 from Syriiin/diffcalc/refactor/auto-properties ... Refactor DifficultyAttributes to use auto properties over public fields	2021-06-10 18:42:11 +09:00
Dan Balasescu	1505534c7e	Merge pull request #13428 from peppy/fix-pm-tab-avatars ... Fix avatars missing in private message channel tabs / local leaderboards	2021-06-10 18:34:23 +09:00
Dean Herbert	4a4a561ca4	Merge pull request #13330 from nekodex/results-screen-sfx ... Add sound effects to the results screen	2021-06-10 18:27:17 +09:00
Salman Ahmed	dde84e5cbd	Merge branch 'master' into transformers-per-skin	2021-06-10 11:58:52 +03:00
Salman Ahmed	58cca9da06	Revert "Expose the skin lookup layers of SkinManager to a property" ... This reverts commit 9e652715ce.	2021-06-10 11:57:28 +03:00
Salman Ahmed	530026b675	Add simple xmldoc to ctors explaining their deal with SkinSources	2021-06-10 11:56:13 +03:00
Salman Ahmed	18edbdd135	Remove mentioning of "layer" in skin providers ... `SkinSources` sounds better.	2021-06-10 11:55:26 +03:00
Dan Balasescu	3cd7d45b0f	Merge pull request #13401 from peppy/no-unranked-display ... Remove the concept of "unranked" mods	2021-06-10 17:51:31 +09:00
Dean Herbert	6a40ef581c	Fix avatars missing in private message channel tabs / local leaderboards ... Regressed in https://github.com/ppy/osu/pull/12204. Adding this back in a central location for now, as each of the remaining cases will need a local solution.	2021-06-10 17:47:17 +09:00
Dean Herbert	0667354fbd	Remove unused resolved skin	2021-06-10 17:30:04 +09:00
Dean Herbert	4f8000a574	Combine cases which return the same value	2021-06-10 17:29:36 +09:00
Dean Herbert	5e80f454ce	Merge branch 'master' into results-screen-sfx	2021-06-10 17:25:35 +09:00
Dan Balasescu	a44fd887ee	Merge branch 'master' into no-unranked-display	2021-06-10 17:09:46 +09:00
Dan Balasescu	479d6d3fc5	Merge branch 'master' into fix-beatmap-skin-disables	2021-06-10 16:37:58 +09:00
Dan Balasescu	4eab717a80	Merge pull request #13408 from peppy/default-skin-fallback ... Add fallback lookup support for `DefaultSkin`	2021-06-10 16:37:48 +09:00
Joseph Madamba	cc38556f61	Fix background being dimmed forever after toggling statistics in results screen	2021-06-09 23:26:57 -07:00
Dean Herbert	9a3ca09501	Merge pull request #13384 from bdach/fixed-label-width ... Align label widths of editor setup screen controls	2021-06-10 14:55:49 +09:00
Dean Herbert	b55a4053cf	Merge pull request #13426 from gagahpangeran/wiki-image-title ... Fix wiki image tooltips not showing inside table views	2021-06-10 14:28:49 +09:00
Dean Herbert	9044a20120	Merge branch 'master' into realm-key-binding-store	2021-06-10 13:58:08 +09:00
Dean Herbert	209d217024	Remove unused using statement	2021-06-10 12:37:56 +09:00
Gagah Pangeran Rosfatiputra	05cb935a94	change WikiMarkdownImage to extend OsuMarkdownImage	2021-06-10 09:38:48 +07:00
Gagah Pangeran Rosfatiputra	28d7b06908	create OsuMarkdownImage	2021-06-10 09:38:07 +07:00
Dean Herbert	3d508f9266	Merge branch 'master' into results-screen-sfx	2021-06-10 11:28:35 +09:00
Joseph Madamba	e3f3c37953	Add ability to navigate score panels with left/right arrows	2021-06-09 17:03:46 -07:00
Salman Ahmed	1aaad7bfd4	Apply few adjustments to skinning overlays comment	2021-06-09 22:49:31 +03:00
Salman Ahmed	e30f6581b3	Wrap gameplay content within a RulesetSkinProvidingContainer	2021-06-09 22:49:31 +03:00
Salman Ahmed	33a9cac398	Add special RulesetSkinProvidingContainer managing ruleset-compatible skin setup	2021-06-09 22:49:31 +03:00
Salman Ahmed	9e652715ce	Expose the skin lookup layers of SkinManager to a property	2021-06-09 22:49:31 +03:00
Salman Ahmed	6538d44708	Make SkinProvidingContainer able to perform lookup on multiple skins ... Currently `protected` functionality for use in custom `SkinProvidingContainer`s, can be exposed to public constructors if it need to later on, but I'm not sure about doing that opposed to just nesting multiple `SkinProvidingContainer`.	2021-06-09 22:49:31 +03:00
Salman Ahmed	cf40282f1f	Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource	2021-06-09 22:49:31 +03:00
Bartłomiej Dach	209f658d05	Merge branch 'master' into fix-beatmap-skin-disables	2021-06-09 20:22:00 +02:00
Bartłomiej Dach	89cdea8123	Merge branch 'master' into fix-results-exit-transition	2021-06-09 19:40:56 +02:00
Bartłomiej Dach	266c1e2e25	Merge branch 'master' into fix-beatmap-skin-disables	2021-06-09 18:43:15 +02:00
Bartłomiej Dach	222ae40a04	Merge branch 'master' into update-framework	2021-06-09 17:36:17 +02:00
Bartłomiej Dach	7fe878299f	Merge branch 'master' into wiki-article	2021-06-09 16:24:45 +02:00
Dean Herbert	f113c095ce	Update framework	2021-06-09 20:29:06 +09:00
Dean Herbert	b02b8ae2bc	Merge pull request #13381 from smoogipoo/improve-hit-error-judgements ... Improve hit error judgement displays	2021-06-09 19:40:17 +09:00
Dean Herbert	31b46afa71	Fix wrong naming scheme for applause samples	2021-06-09 19:35:05 +09:00
Dean Herbert	7d86dafd4f	Simplify tick calculation/playback method	2021-06-09 19:31:53 +09:00
Dean Herbert	57bc34f224	Move consts closer to usage	2021-06-09 19:24:35 +09:00
Dean Herbert	cb4f366651	Move forgotten private function down more	2021-06-09 19:15:55 +09:00
Dean Herbert	81cecac90b	Move tick rate initialisation to earlier	2021-06-09 19:09:00 +09:00
Dean Herbert	499aba95c0	Simplify sample construction logic and move private functions down	2021-06-09 19:06:37 +09:00
Dean Herbert	489a5a3c1d	Add back missing space in csproj	2021-06-09 19:01:05 +09:00
Dean Herbert	21a63efd78	Rename variable back to withFlair to match parent class	2021-06-09 18:55:29 +09:00
Dean Herbert	330bb7cb45	Remove unnecessary skin lookup logic	2021-06-09 18:55:29 +09:00
Dean Herbert	0cf7c56e7e	Add fallback lookup support for DefaultSkin	2021-06-09 18:51:42 +09:00
Dean Herbert	8fda04c2d9	Merge branch 'master' into results-screen-sfx	2021-06-09 18:00:11 +09:00
Dean Herbert	2438c20d63	Fix SourceChanged not being correctly forwarded through LegacySkinTransformer	2021-06-09 17:56:07 +09:00
Dean Herbert	a65b76bdbf	Add a simple fade to the results screen ... Stops it from immediately disappearing.	2021-06-09 17:19:37 +09:00
Dean Herbert	7b0c5e9d32	Fix results screen changing applied colour to background on exit ... The general rule is that screens should only apply colours and the likes on enter / resume, and leave the outwards transition to whatever screen is coming next.	2021-06-09 17:18:55 +09:00
Dean Herbert	258d05d1e0	Ensure PlayerLoader restores the background colour to its own value on resume	2021-06-09 17:17:39 +09:00
Dean Herbert	a7ef0173e9	Add safety to ensure background is correct tint when entering gameplay	2021-06-09 17:07:28 +09:00
Bartłomiej Dach	020c63017e	Fix inspectcode issues	2021-06-09 09:21:02 +02:00
Dean Herbert	448e4e7ee5	Fix FindProvider calls on SkinProvidingContainer not considering disable flags ... Closes #13394.	2021-06-09 16:19:04 +09:00
Bartłomiej Dach	023015f9a6	Merge branch 'master' into fix-skin-background-regression	2021-06-09 08:09:21 +02:00
Bartłomiej Dach	a801a9a14d	Ensure background rotation on default skins	2021-06-09 07:59:47 +02:00
Dean Herbert	b754c52392	Update ModAutoplay matching to use new UserPlayable flag instead	2021-06-09 14:32:48 +09:00
Dean Herbert	b8df3fff9e	Fix incorrect method referenced in xmldco ... Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com>	2021-06-09 14:20:01 +09:00
Dean Herbert	d0e9f8ef90	Replace and obsolete Ranked flag with IsUserPlayable	2021-06-09 14:17:03 +09:00
Dean Herbert	62199a38a8	Add one missing obsoletion removal date	2021-06-09 14:11:50 +09:00
Dean Herbert	f41e34ae2c	Remove more obsoleted members	2021-06-09 14:10:48 +09:00
Dean Herbert	a87226ab10	Remove obsoleted DrawableJudgement methods ... Undated, but change was made on 2020-11-18.	2021-06-09 14:09:23 +09:00
Dean Herbert	7774344f0e	Remove "Unranked" text from ModDisplay	2021-06-09 13:45:09 +09:00
Dean Herbert	249a8f259b	Reword "unranked" to "not ranked" on beatmap overlay ... This will be replaced anyway once we start to consume osu-web translation strings.	2021-06-09 13:44:27 +09:00
Bartłomiej Dach	97204b6f27	Reduce unnecessary background changes via IEquatable implementation	2021-06-08 22:37:18 +02:00
Bartłomiej Dach	a98c302211	Bring back skin background source	2021-06-08 22:04:59 +02:00
Bartłomiej Dach	5bf4dd6358	Move skin background to separate file	2021-06-08 21:57:08 +02:00
Robin Avery	2484ccd50c	Ensure scale x or y does not go below zero in SkinSelectionHandler.HandleScale	2021-06-08 11:49:25 -04:00
Bartłomiej Dach	410cb16340	Apply fixed label width to setup screen items	2021-06-08 17:18:00 +02:00
Bartłomiej Dach	88266eac63	Add option to fix label width of a LabelledDrawable	2021-06-08 16:57:32 +02:00
Robin Avery	10b6b72909	Add guard clause to applyOrigins and rename parameter	2021-06-08 10:29:45 -04:00
Robin Avery	d212918d67	Rename applyCustomAnchors to applyFixedAnchors for consistency with UsesFixedAnchor	2021-06-08 10:14:07 -04:00
smoogipoo	00efed2c39	Add colours for tick judgements	2021-06-08 23:10:21 +09:00
Robin Avery	2c88e6df8d	Simplify applyClosestAnchor to one line by moving another guard clause	2021-06-08 10:09:48 -04:00
smoogipoo	c8e14d7710	Ignore non-scorable and bonus judgements	2021-06-08 23:09:23 +09:00
smoogipoo	c3ea1b26e1	Fix DT being doubled in multiplayer spectator	2021-06-08 22:51:42 +09:00
Robin Avery	f22cc981d1	Move guard clause from checkAndApplyClosestAnchor to applyAnchor	2021-06-08 09:51:39 -04:00
Robin Avery	529a80871b	Rename some methods for clarity ... Methods which operate on a collection of `ISkinnableDrawable`s are now plural; ones which take a single item are singular. This also allows cutting down the name of `getClosestAnchorForDrawable` to just `getClosestAnchor`.	2021-06-08 09:44:42 -04:00
Robin Avery	01da73daf2	Refactor updateDrawableAnchorIfUsingClosest	2021-06-08 09:25:49 -04:00
Robin Avery	6b127f50f2	Inline updateDrawableAnchorIfUsingClosest	2021-06-08 09:14:04 -04:00
Robin Avery	dc50ae40b9	Rename OverridesClosestAnchor to UsesFixedAnchor	2021-06-08 08:28:42 -04:00
Dean Herbert	25af4dfa8a	Merge pull request #13375 from smoogipoo/fix-multi-nullref ... Fix possible nullref when exiting song select too fast	2021-06-08 20:47:40 +09:00
Dan Balasescu	5a8cde7e6f	Merge pull request #13377 from peppy/fix-lazer-replays-getting-classic ... Move legacy `ScoreInfo` to be completely based on presence of classic mod	2021-06-08 19:15:13 +09:00
Samuel Cattini-Schultz	f1bef989b7	Refactor DifficultyAttributes to use auto properties over public fields	2021-06-08 19:43:59 +10:00
smoogipoo	0b9916b266	Add parens to declare operator precedence	2021-06-08 18:39:52 +09:00
Dean Herbert	4ee7721c51	Extract first version out to constant	2021-06-08 18:38:47 +09:00
Dan Balasescu	d31e3e8f1c	Fix nullref	2021-06-08 18:23:03 +09:00
Dean Herbert	b287366c8b	Remove forgotten classic mod addition	2021-06-08 18:09:57 +09:00
Dean Herbert	061e3d7f26	Move legacy ScoreInfo to be completely based on presence of classic mod	2021-06-08 18:00:09 +09:00
Dean Herbert	4d9fffc01b	Update score encoder version to be higher than any existing stable version	2021-06-08 17:59:43 +09:00
smoogipoo	ab9290772b	Fix a similar case with online play sub-screens	2021-06-08 17:54:54 +09:00
smoogipoo	860f1aebb3	Only call OnBackButton() if the screen has finished loading	2021-06-08 17:38:12 +09:00
Dean Herbert	6017ef3825	Merge branch 'master' into fix-skin-sample-lookup	2021-06-08 17:37:36 +09:00
Dan Balasescu	e5e3509c87	Merge pull request #13264 from peppy/legacy-skin-default-fallback ... Allow fallback to legacy defaults from legacy skins	2021-06-08 17:30:27 +09:00
Dan Balasescu	c0fdbfba04	Merge pull request #13374 from peppy/update-framework ... Update framework	2021-06-08 17:09:20 +09:00
smoogipoo	7fa0ac6ed7	Fix possible nullref when exiting song select too fast	2021-06-08 17:03:50 +09:00
Dan Balasescu	791855dfa0	Merge branch 'master' into legacy-skin-default-fallback	2021-06-08 16:54:26 +09:00
Dan Balasescu	e3cb6f45f5	Merge pull request #13371 from peppy/fix-poolable-sample-disposal-skin-change ... Clean up previous sample immediately on skin source change to avoid `Play` after disposal	2021-06-08 16:52:59 +09:00
Dean Herbert	89895f6ce4	Update framework	2021-06-08 16:24:00 +09:00
Dan Balasescu	67135ce3db	Add null check	2021-06-08 16:15:17 +09:00
Dean Herbert	e2fdc23d98	Merge branch 'fix-skin-sample-lookup' into results-screen-sfx	2021-06-08 15:20:11 +09:00
Dean Herbert	e0f568aa8f	Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup	2021-06-08 15:19:52 +09:00
Dean Herbert	95852ccdf8	Merge branch 'master' into results-screen-sfx	2021-06-08 15:14:31 +09:00
Dean Herbert	f3f634e969	Clean up previous sample immediately on skin source change to avoid Play after disposal ... This seems to be the simplest way to avoid calls to `Play` after the underlying sample may have been disposed. As per the issue thread, a local workaround is acceptable here. Closes #13223.	2021-06-08 15:05:18 +09:00
smoogipoo	7341e474f1	Attempt to safeguard against collections database corruptions	2021-06-08 14:25:39 +09:00
Dean Herbert	27e3de3ea3	Add TODO about beatmap skin fallback support	2021-06-08 12:12:14 +09:00
Dean Herbert	06840d78cc	Remove now unused method	2021-06-08 12:06:42 +09:00
Dean Herbert	2c1f22d7ae	Refactor animation lookup to properly handle skins providing non-animated resources	2021-06-08 01:17:20 +09:00
Dean Herbert	e7e9197f03	Fix FindProvider not correctly checking legacy default in SkinManager	2021-06-08 00:42:50 +09:00
Dean Herbert	6d56e02ddb	Add back incorrectly reverted animation handling logic ... This reverts commit b904fa6615.	2021-06-08 00:17:01 +09:00
Dean Herbert	c0305343bc	Fix FindProvider incorrectly returning LegacySkinTransformer itself	2021-06-07 23:23:44 +09:00
Dean Herbert	08701b5eab	Ensure all lookups in LegacyHealthDisplay use the found provider ... Not actually needed to fix the remaining issue but does feel better	2021-06-07 23:23:12 +09:00
Bartłomiej Dach	0531c2dcd9	Move empty window check to bar error meter ... It's not valid in the base `HitErrorMeter`, as the colour meter only displays colour for a given judgement, so it is still valid to add new items to it even if the hit window is 0, as misses are still possible.	2021-06-07 13:16:07 +02:00
Bartłomiej Dach	37d062c7cd	Add failing assertions to hit error meter test	2021-06-07 13:16:07 +02:00
Bartłomiej Dach	b192c46316	Merge branch 'master' into wiki-article	2021-06-07 11:19:20 +02:00
Bartłomiej Dach	a0bda9ad59	Hoist scroll cache declaration to original place of definition	2021-06-07 11:18:18 +02:00
Robin Avery	65f594f860	Rename applyAnchor to applyCustomAnchor	2021-06-07 05:08:18 -04:00
Bartłomiej Dach	e606bf249a	Move dependency specification to BDL ... As it is not used anywhere else.	2021-06-07 11:05:30 +02:00
Dean Herbert	59130be99c	Fix switching storyboard mode not triggering a reload	2021-06-07 17:32:04 +09:00
Dean Herbert	f677f9b5f4	Stop BackgroundScreenDefault from reloading beatmap background when already correct	2021-06-07 17:22:36 +09:00
Dean Herbert	e8d4147773	Add missing null handling for never Markdig version	2021-06-07 16:08:44 +09:00
Dean Herbert	aa700702fe	Update framework	2021-06-07 15:48:45 +09:00
Robin Avery	6c9594ee35	Simplify and rearrange SkinSelectionHandler ... The file has been restructured and reworded such that there are as few differences as possible from b36b40cb34.	2021-06-07 02:40:15 -04:00
Robin Avery	29fa4fdf57	Refactor unacceptable syntax	2021-06-07 01:08:39 -04:00
Robin Avery	133d72a8c0	Rename UsingClosestAnchor ... It is now "OverridesClosestAnchor". The logic is inverted accordingly.	2021-06-07 00:14:36 -04:00
Robin Avery	f28916e30f	Remove all UsingClosestAnchor() extension logic ... It is replaced with ISkinnableDrawable.UsingClosestAnchor.	2021-06-07 00:04:53 -04:00
Robin Avery	ce635af83e	Add UsingClosestAnchor to ISkinnableDrawable ... Also implement it as an auto property in its inheritors. The auto properties default to true.	2021-06-06 23:47:47 -04:00
Dean Herbert	d26c9a66c2	Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup	2021-06-07 12:01:19 +09:00
Robin Avery	6a456e53f4	Rename overly long method	2021-06-06 13:28:17 -04:00
Robin Avery	888882ac63	Remove first-person comment	2021-06-06 13:27:13 -04:00
Dean Herbert	e10dfab2e8	Ensure scorebar marker lookup is performed on the source the background is retrieved from	2021-06-06 23:23:35 +09:00
Robin Avery	da1c38d5a9	Uninvert logic of SkinnableInfo.UsingClosestAnchor ... Also rename "IsUsingClosestAnchor" to simply "UsingClosestAnchor".	2021-06-06 10:13:35 -04:00
Dean Herbert	b5f145cfa9	Use null propagation for animation lookups	2021-06-06 23:01:37 +09:00
Robin Avery	63346f6b75	Refactor getTieredComponent	2021-06-06 09:40:58 -04:00
Gagah Pangeran Rosfatiputra	ed733ee648	directly using table of content entry in wiki table of contents	2021-06-06 20:19:39 +07:00
Robin Avery	11b1b8c633	Add serialization support via SkinnableInfo	2021-06-06 07:18:08 -04:00
Robin Avery	c9f5808bf2	Move lookup logic to DrawableExtensions ... This is now a global lookup to be shared by serialization and editor.	2021-06-06 06:58:21 -04:00
Robin Avery	4aee76456f	Replace localised strings with static English	2021-06-06 05:34:32 -04:00
Robin Avery	c452715bf1	Allow skin elements to find closest anchor ... - Resolves ppy/osu#13252 - Add localisation strings for the context menu instead of using enum	2021-06-06 01:32:04 -04:00
Dean Herbert	b904fa6615	Revert "Ensure all frames in an animation are retrieved from the same skin" ... This reverts commit 37c8c63fc5.	2021-06-06 12:37:42 +09:00
Dean Herbert	b87a5956dd	Add fallback logic to SkinManager	2021-06-06 12:17:55 +09:00
Dean Herbert	39f99bf785	Move FindProvider to ISkinSource	2021-06-06 12:17:32 +09:00
Gagah Pangeran Rosfatiputra	525c16419a	use container for main title and sub title table of contents	2021-06-06 08:37:03 +07:00
Craftplacer	b97f31f314	Revert deletion of xmldoc summary line	2021-06-05 19:03:11 +02:00
Craftplacer	4925a7d59e	Minor code quality changes	2021-06-05 15:57:14 +02:00
Gagah Pangeran Rosfatiputra	9f45a28623	use WikiTableOfContents in WikiSidebar	2021-06-05 19:47:00 +07:00
Gagah Pangeran Rosfatiputra	55f3a328a4	add WikiTableOfContents	2021-06-05 19:46:46 +07:00
Craftplacer	5e44329e0b	Add DummyAPIAccess request handler ... Make CreateChannelRequest.channel public	2021-06-05 14:43:26 +02:00
Craftplacer	ce4bcda803	Use separate method for fetching channel objects ... Resolves a pull request review	2021-06-05 14:02:48 +02:00
Gagah Pangeran Rosfatiputra	958bddc8cb	remove onclick in toc entry	2021-06-05 18:30:28 +07:00
Gagah Pangeran Rosfatiputra	c099751ad1	use plain if check in switch case	2021-06-05 18:26:03 +07:00
Craftplacer	39c3b08fc7	Merge remote-tracking branch 'upstream/master' into chat-mention	2021-06-05 11:18:06 +02:00
Craftplacer	b746fe7c03	Fix binding order	2021-06-05 11:03:49 +02:00
Dean Herbert	9f6e3996b1	Merge branch 'master' into fix-osutestscene-content	2021-06-05 14:49:19 +09:00
Craftplacer	1084906d40	Add DummyAPIAccess one parent up	2021-06-05 03:30:21 +02:00
Gagah Pangeran Rosfatiputra	4cf3381d0b	use wiki article page when failed fetch	2021-06-04 23:59:11 +07:00
Gagah Pangeran Rosfatiputra	5ee77925e4	change WikiArticlePage to extends CompositeDrawable	2021-06-04 23:54:50 +07:00
Gagah Pangeran Rosfatiputra	f07d4532d9	move scroll to into action	2021-06-04 23:51:18 +07:00
Gagah Pangeran Rosfatiputra	a431ef6c48	keep colour change when entry is clicked	2021-06-04 23:43:00 +07:00
Gagah Pangeran Rosfatiputra	5febbe4530	rename method add entry	2021-06-04 23:32:42 +07:00
Gagah Pangeran Rosfatiputra	70c64af25e	rename toc entry	2021-06-04 23:31:51 +07:00
Dean Herbert	10acad6524	Merge pull request #13261 from smoogipoo/fix-spectator-frame-conversion ... Fix spectator crashing when converting mania replay frames	2021-06-05 00:38:15 +09:00
Dan Balasescu	bde0071de8	Merge pull request #13336 from ekrctb/pdwl-catch-explosion ... Fix catch hit lighting not always showing when a replay is rewound	2021-06-04 22:19:34 +09:00
smoogipoo	009aa994d0	Fix potential race incorrectly pausing the source clock	2021-06-04 21:58:51 +09:00
Dan Balasescu	57a38374db	Merge branch 'master' into fix-spectator-frame-conversion	2021-06-04 21:17:40 +09:00
ekrctb	5512231bf4	Add NextSingle of version taking output range to StatelessRNG	2021-06-04 19:52:12 +09:00
Dean Herbert	840f084dc4	Merge pull request #13303 from LeNitrous/mainmenu-storyboard-backgrounds ... Add storyboards as a main menu background source	2021-06-04 19:50:40 +09:00
Gagah Pangeran Rosfatiputra	8883d5e2d1	use heading block to get title string	2021-06-04 15:28:54 +07:00
Gagah Pangeran Rosfatiputra	6d6c03eafe	use linq to find first literal inline	2021-06-04 14:45:06 +07:00
Dean Herbert	ae2165b3be	Fix incorrect xmldoc	2021-06-04 16:44:04 +09:00
Jamie Taylor	50819ef91f	use a dictionary for sample lookups instead	2021-06-04 16:41:52 +09:00
Dean Herbert	5fa9366152	Update resources	2021-06-04 16:22:16 +09:00
Dean Herbert	37c8c63fc5	Ensure all frames in an animation are retrieved from the same skin	2021-06-04 16:18:04 +09:00
Dan Balasescu	2069a5bd28	Merge pull request #13313 from ekrctb/factor-out-hoc ... Factor out entry management logic of `HitObjectContainer` to the new base class	2021-06-04 16:06:48 +09:00
Dean Herbert	06275a6a7d	Merge branch 'master' into legacy-skin-default-fallback	2021-06-04 16:00:30 +09:00
Dan Balasescu	b283c48abb	Merge branch 'master' into factor-out-hoc	2021-06-04 15:31:35 +09:00
Dean Herbert	19a44d65c5	Tidy up code	2021-06-04 15:18:16 +09:00
Dean Herbert	23096c58bb	Merge branch 'master' into fix-spectator-frame-conversion	2021-06-04 15:06:15 +09:00
Dean Herbert	071c07586a	Increase music volume back to 80% for the time being	2021-06-04 15:00:53 +09:00
Nathan Alo	996c156106	apply suggestions ... - apply 0 alpha to beatmap background if storyboard replaces it - use an AudioContainer to mute all samples coming from the storyboard	2021-06-04 13:56:10 +08:00
Gagah Pangeran Rosfatiputra	a706ff63ed	change sprite text to text flow	2021-06-04 12:50:03 +07:00
Gagah Pangeran Rosfatiputra	91e77ee4de	add onclick in toc title	2021-06-04 11:43:49 +07:00
Gagah Pangeran Rosfatiputra	37ff6299c9	add target in toc title	2021-06-04 11:43:32 +07:00
Gagah Pangeran Rosfatiputra	e28b38653b	cache scroll container	2021-06-04 11:43:00 +07:00
Gagah Pangeran Rosfatiputra	4e73d02540	move sidebar into local variable	2021-06-04 11:35:23 +07:00
Gagah Pangeran Rosfatiputra	424d1b4025	add margin padding spacing in toc title	2021-06-04 11:18:08 +07:00
Gagah Pangeran Rosfatiputra	41ec531bab	add subtitle toc	2021-06-04 11:12:42 +07:00
Gagah Pangeran Rosfatiputra	d8d4bf66b3	create TocTitle in WikiSidebar	2021-06-04 11:09:20 +07:00
Gagah Pangeran Rosfatiputra	59dbed6418	create ArticleMarkdownContainer in WikiArticlePage	2021-06-04 11:08:51 +07:00
Gagah Pangeran Rosfatiputra	abb522f084	add missing using	2021-06-04 10:53:48 +07:00
Dan Balasescu	0ba493d598	Merge pull request #13318 from gagahpangeran/error-page-placeholder ... Add error page placeholder for wiki overlay	2021-06-04 12:20:21 +09:00
Gagah Pangeran Rosfatiputra	b1b305c150	add method AddToc	2021-06-04 10:17:38 +07:00
Gagah Pangeran Rosfatiputra	7e78150144	add basic content wiki sidebar	2021-06-04 10:16:49 +07:00
Dean Herbert	eebd5745a8	Move full stop out of link and reword slightly	2021-06-04 11:44:43 +09:00
Dan Balasescu	233551fc08	Merge pull request #13323 from gagahpangeran/extract-sidebar ... Create abstract class `OverlaySidebar`	2021-06-04 11:38:36 +09:00
Gagah Pangeran Rosfatiputra	458910b744	use WikiArticlePage in WikiOverlay	2021-06-04 09:29:36 +07:00
Gagah Pangeran Rosfatiputra	791a9dd33a	add WikiArticlePage	2021-06-04 09:29:10 +07:00
Gagah Pangeran Rosfatiputra	beb0119dd5	initial wiki sidebar	2021-06-04 09:28:31 +07:00
Dan Balasescu	50c60c791f	Merge pull request #13322 from Pasi4K5/seed-for-all-random-mods ... Add seed option for all random mods	2021-06-04 11:26:13 +09:00
Gagah Pangeran Rosfatiputra	905472a20b	make NewsSidebar extends OverlaySidebar	2021-06-04 00:12:29 +07:00
Gagah Pangeran Rosfatiputra	076e498a63	create abstract class OverlaySidebar	2021-06-04 00:12:13 +07:00
Dean Herbert	d444fed46f	Detach gameplay score from replay recorder before importing ... Closes #13320.	2021-06-04 02:00:02 +09:00
Pasi4K5	7a4fc9ffc8	Move seed to base class	2021-06-03 18:16:11 +02:00
Gagah Pangeran Rosfatiputra	c5fc155cc0	Change text wording ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-06-03 20:37:27 +07:00
Gagah Pangeran Rosfatiputra	490ce0bbc5	load placeholder page when failed	2021-06-03 19:40:54 +07:00
Bartłomiej Dach	5f5f3a8c5c	General comment cleanups	2021-06-03 14:20:52 +02:00
Bartłomiej Dach	b2cc2a51ec	Rename method to be less misleading ... Would rather avoid variations of Equals/Equal/IsEqual. There's not really much equality involved as the types are different.	2021-06-03 14:13:01 +02:00
Bartłomiej Dach	e8c2483f19	Use standard list instead of bindable list ... No reason to use a bindable list there, as `CollectionChanged` was never subscribed to.	2021-06-03 14:09:52 +02:00
Bartłomiej Dach	8193691cbc	Invert condition to reduce nesting	2021-06-03 14:09:52 +02:00
Bartłomiej Dach	acb4873157	Merge branch 'master' into keyboard_shortcuts	2021-06-03 14:09:48 +02:00
Dean Herbert	33ab411e39	Merge branch 'master' into drawavatar-use-avatar-url	2021-06-03 19:36:32 +09:00
Jamie Taylor	054de675ff	allow skinned 'applause' sample to override results screen sfx	2021-06-03 18:35:55 +09:00
Jamie Taylor	582360d0c8	only load the required impact/applause samples	2021-06-03 18:35:51 +09:00
Jamie Taylor	ed012a724b	refactor from using public variables	2021-06-03 18:35:46 +09:00
Jamie Taylor	8dc595d201	move result screen samples to DefaultSkin	2021-06-03 18:35:27 +09:00
Jamie Taylor	63e5bc4543	update sample names and timings	2021-06-03 18:34:33 +09:00
Jamie Taylor	30eff8cc2a	remove overlapping/legacy applause	2021-06-03 18:34:28 +09:00
Jamie Taylor	9ad87ee5dc	add sfx for results screen + sound design tool	2021-06-03 18:34:22 +09:00
smoogipoo	e887807ae7	Apply review fixes	2021-06-03 18:32:05 +09:00
smoogipoo	be03a2d7d2	Fix multiple calls to seek method potentially not working	2021-06-03 17:47:22 +09:00
smoogipoo	c3280083a2	Merge branch 'master' into fix-spectator-frame-conversion	2021-06-03 17:42:01 +09:00
smoogipoo	662bbed5d1	Fix seeking to gameplay too soon	2021-06-03 17:38:51 +09:00
Dan Balasescu	15b43beef1	Merge pull request #11857 from Syriiin/diffcalc/refactor/catch-clockrate-effects ... Refactor catch Movement skill to not require explicit clockrate usage	2021-06-03 17:29:27 +09:00
smoogipoo	420df124b5	Add framestable-bypassing seek for spectator	2021-06-03 17:27:21 +09:00
Dan Balasescu	69009a36b7	Merge branch 'master' into autoplay-pause-support	2021-06-03 16:37:41 +09:00
Dean Herbert	48687028a3	Merge branch 'test-platform-actions' into keyboard_shortcuts	2021-06-03 15:35:57 +09:00
Dean Herbert	be91203c92	Add nested PlatformActionContainer to allow testing of platform actions in visual tests	2021-06-03 15:35:32 +09:00
Samuel Cattini-Schultz	f51413ead9	Refactor to pass clockrate in constructor rather than deriving from mods	2021-06-03 16:09:42 +10:00
Dean Herbert	e74fe68c96	Use new platform actions instead of hardcoded keys	2021-06-03 15:04:07 +09:00
ekrctb	b321b20e9d	Remove OnAdd/OnRemove of HitObjectContainer ... Instead, override `AddDrawable`/`RemoveDrawable`.	2021-06-03 15:00:16 +09:00
ekrctb	0ce7baa3f3	Make HitObjectContainer.Clear non-virtual ... It just call `Remove` for all entries.	2021-06-03 15:00:16 +09:00
ekrctb	2c9e5b6c7e	Replace EntryCrossedBoundary with more useful RemoveRewoundEntry property ... It can be used for dynamically added entries.	2021-06-03 15:00:16 +09:00
ekrctb	fe2934db1d	Factor out lifetime management logic of HitObjectContainer	2021-06-03 14:57:28 +09:00
Dean Herbert	a91015302e	Replace second usage of new function	2021-06-03 14:56:29 +09:00
Dean Herbert	a6cc37eb3b	Mark fields readonly	2021-06-03 14:56:21 +09:00
Nathan Alo	d7d0dde5d2	use created storyboard to check for drawables instead	2021-06-03 13:56:14 +08:00
Dean Herbert	4a5d8215f3	Merge branch 'master' into keyboard_shortcuts	2021-06-03 14:47:40 +09:00
Nathan Alo	62b07fb9ce	apply suggestions ... - Replace the sprite with a solid black box when a storyboard requests it. - Create a new storyboard instance and exclude the fail layer as well as strip all samples from it - Do not attempt in creating the storyboard when it isn't needed	2021-06-03 13:27:00 +08:00
Nathan Alo	d00fb21188	prevent scaling container from creating a storyboard background	2021-06-03 13:24:21 +08:00
Dan Balasescu	44b1102241	Merge branch 'master' into autoplay-pause-support	2021-06-03 13:26:00 +09:00
Dean Herbert	a62dd7cca0	Revert "refactor BeatmapBackgroundWithStoryboard to reduce overhead" ... This reverts commit 277545bb06.	2021-06-03 12:33:16 +09:00
Dean Herbert	d6656047e3	Fix beatmap statistics with value of zero not displaying correctly at song select ... Closes #13307.	2021-06-03 01:58:51 +09:00
Nathan Alo	277545bb06	refactor BeatmapBackgroundWithStoryboard to reduce overhead ... This avoids loading the sprite if its not needed and instead of hiding it, it is removed when the storyboard replaces the background or there is a video. This also only initializes DrawableStoryboard if there are any elements in any layer.	2021-06-02 20:27:12 +08:00
Dean Herbert	cde8de154d	Remove unused test property for now	2021-06-02 19:11:09 +09:00
Dan Balasescu	c065f761c7	Merge branch 'master' into legacy-skin-default-fallback	2021-06-02 19:08:52 +09:00
Dean Herbert	e0eb0adb0a	Remove unnecessary bind in ReplayPlayer	2021-06-02 18:32:14 +09:00
Nathan Alo	3c3ef13632	remove fade	2021-06-02 16:28:22 +08:00
Nathan Alo	e66f6e8f91	fix inspect code issues and cleanup code	2021-06-02 16:12:41 +08:00
Nathan Alo	dde64adcb5	add new background type in BackgroundScreenDefault	2021-06-02 15:51:43 +08:00
Nathan Alo	dec18ef826	implement BeatmapBackgroundWithStoryboard	2021-06-02 15:50:58 +08:00
Nathan Alo	5b436ee436	add beatmap with storyboard source	2021-06-02 15:50:33 +08:00
Dean Herbert	5366e7f61e	Merge branch 'master' into remove-hud-component-lookup	2021-06-02 16:10:06 +09:00
Dean Herbert	f8ae70e562	Update existing function type rather than adding an override	2021-06-02 16:04:53 +09:00
Dean Herbert	a15cac6f53	Change the way Score is initialised in Player to better lend to population of metadata	2021-06-02 15:44:04 +09:00
Dan Balasescu	47019196f6	Merge branch 'master' into fix-relative-link-resolution	2021-06-02 14:55:38 +09:00
Dean Herbert	ac761bb075	Use string.Empty instead of arbitrary string	2021-06-02 14:43:35 +09:00
Dean Herbert	4759ac098f	Merge pull request #13293 from smoogipoo/update-dependencies ... Update dependencies	2021-06-02 14:35:06 +09:00
Dean Herbert	4fd8c9c17b	Merge pull request #13284 from ppy/dependabot/nuget/ppy.LocalisationAnalyser-2021.525.0 ... Bump ppy.LocalisationAnalyser from 2021.524.0 to 2021.525.0	2021-06-02 14:34:37 +09:00
Dean Herbert	45984f035b	Make autoplay tests test via the ReplayPlayer code path	2021-06-02 11:49:06 +09:00
smoogipoo	d3d8941ec8	Make method internal	2021-06-02 11:11:41 +09:00
Dean Herbert	911256603b	Rewrite comment to hopefully be more informative	2021-06-02 11:10:02 +09:00
smoogipoo	8ee2b3a2d2	Merge branch 'master' into fix-scrolling-lifetime	2021-06-02 11:08:28 +09:00
Dan Balasescu	ac83450791	Merge pull request #13256 from ekrctb/update-lifetime-2 ... Update DHO lifetime on entry lifetime change	2021-06-02 11:07:54 +09:00
Dean Herbert	8a76d97b63	Remove replay logic from DrawableRuleset (and implement in DrawableEditorRulesetWrapper)	2021-06-02 11:06:30 +09:00
smoogipoo	51e4b6c860	Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.6' into update-dependencies	2021-06-02 09:21:26 +09:00
smoogipoo	4184cb88f6	Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.6' into update-dependencies	2021-06-02 09:21:09 +09:00
smoogipoo	dc31e2925c	Merge remote-tracking branch 'ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.6' into update-dependencies	2021-06-02 09:20:37 +09:00
smoogipoo	e19568c91b	Merge remote-tracking branch 'ppy/dependabot/nuget/Sentry-3.4.0' into update-dependencies	2021-06-02 09:20:33 +09:00
smoogipoo	b0a229da87	Merge remote-tracking branch 'ppy/dependabot/nuget/ppy.LocalisationAnalyser-2021.525.0' into update-dependencies	2021-06-02 09:20:31 +09:00
dependabot[bot]	a758b38278	Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.5 to 5.0.6. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-06-01 19:59:32 +00:00
dependabot[bot]	a10ef2ba65	Bump Humanizer from 2.8.26 to 2.10.1 ... Bumps [Humanizer](https://github.com/Humanizr/Humanizer) from 2.8.26 to 2.10.1. - [Release notes](https://github.com/Humanizr/Humanizer/releases) - [Changelog](https://github.com/Humanizr/Humanizer/blob/main/release_notes.md) - [Commits](https://github.com/Humanizr/Humanizer/compare/v2.8.26...v2.10.1) --- updated-dependencies: - dependency-name: Humanizer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2021-06-01 19:59:31 +00:00
dependabot[bot]	deaa381440	Bump Sentry from 3.3.4 to 3.4.0 ... Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.3.4 to 3.4.0. - [Release notes](https://github.com/getsentry/sentry-dotnet/releases) - [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.3.4...3.4.0) --- updated-dependencies: - dependency-name: Sentry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2021-06-01 19:59:30 +00:00
dependabot[bot]	bd8db2ce63	Bump ppy.LocalisationAnalyser from 2021.524.0 to 2021.525.0 ... Bumps [ppy.LocalisationAnalyser](https://github.com/ppy/osu-localisation-analyser) from 2021.524.0 to 2021.525.0. - [Release notes](https://github.com/ppy/osu-localisation-analyser/releases) - [Commits](https://github.com/ppy/osu-localisation-analyser/compare/2021.524.0...2021.525.0) --- updated-dependencies: - dependency-name: ppy.LocalisationAnalyser dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2021-06-01 19:59:28 +00:00
dependabot[bot]	ea9919e8fe	Bump Microsoft.AspNetCore.SignalR.Client from 5.0.5 to 5.0.6 ... Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.5 to 5.0.6. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Client dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-06-01 19:59:27 +00:00
dependabot[bot]	069baab883	Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.5 to 5.0.6. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.5...v5.0.6) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-06-01 19:59:27 +00:00
Dean Herbert	92ffc4627f	Update framework	2021-06-01 23:24:49 +09:00
Dean Herbert	2e2281c7d2	Revert disabling taiko sample tests and fix logic	2021-06-01 18:57:19 +09:00
Dean Herbert	e8aa5c4ecf	Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup	2021-06-01 18:05:00 +09:00
Dean Herbert	cd139660ab	Merge branch 'master' into legacy-skin-default-fallback	2021-06-01 18:04:54 +09:00
Dean Herbert	3a6d081d82	Remove duplicated taiko fallback	2021-06-01 18:04:49 +09:00
Dean Herbert	ea4644be90	Revert "Fix weird taiko logic failing for weird reasons that probably should not have been a thing" ... This reverts commit 69c4ccad05.	2021-06-01 18:04:49 +09:00
Dean Herbert	a837fc9e3b	Remove duplicated taiko fallback	2021-06-01 18:00:24 +09:00
Dean Herbert	f14c0eae99	Fix editor no longer creating autoplay frames	2021-06-01 17:28:41 +09:00
Dean Herbert	df0a5689e4	Revert "Fix weird taiko logic failing for weird reasons that probably should not have been a thing" ... This reverts commit 69c4ccad05.	2021-06-01 17:13:13 +09:00
Dean Herbert	3668f1861f	Fix one more null issue	2021-06-01 17:10:09 +09:00
Dean Herbert	ff815cb4b4	Fix incorrect xmldoc	2021-06-01 16:57:41 +09:00
Dean Herbert	289dc00f38	Merge branch 'master' into autoplay-pause-support	2021-06-01 16:50:44 +09:00
Dean Herbert	145e42928b	Fix remaining null checks	2021-06-01 16:49:05 +09:00
Dean Herbert	1f8abcdf6c	Merge branch 'master' into fix-relative-link-resolution	2021-06-01 16:49:02 +09:00
Dean Herbert	6e861a9b7f	Revert incorrect ScoreProcessor change	2021-06-01 16:39:50 +09:00
Dean Herbert	790f1dacc9	Ensure ScoreProcessor is still hooked up in special case	2021-06-01 16:24:38 +09:00
Salman Ahmed	7c6400735f	Merge branch 'master' into remove-hud-component-lookup	2021-06-01 10:17:52 +03:00
Salman Ahmed	c090110ae2	Provide cell skin on content creation	2021-06-01 10:16:13 +03:00
Gagah Pangeran Rosfatiputra	b4dd935538	add corner radius and padding	2021-06-01 14:14:12 +07:00
Gagah Pangeran Rosfatiputra	5108dadfbc	use inline code in markdown text flow	2021-06-01 14:03:57 +07:00
Gagah Pangeran Rosfatiputra	1babb05fc7	add OsuMarkdownInlineCode	2021-06-01 14:03:31 +07:00
Dean Herbert	3ba0d29108	Fix incorrect beatmap being parsed down for autoplay generation	2021-06-01 15:44:24 +09:00
Dean Herbert	240f7facba	Add local concessions for autoplay test handling	2021-06-01 15:39:02 +09:00
Dean Herbert	dce24e3d4d	Merge pull request #12950 from gagahpangeran/osu-wiki-overlay ... Initial implementation of Wiki Overlay	2021-06-01 15:20:56 +09:00
ekrctb	40949f6c1b	Simplify lifetime setter ... Setting entry lifetime will cause `LifetimeChanged` event and `base.LifetimeStart`/`End` will be modified in the callback.	2021-06-01 14:46:43 +09:00
ekrctb	0f381f7758	Fix wrong code	2021-06-01 14:38:02 +09:00
Dean Herbert	6ef9b346e1	Fix newly found inspections from 2021.1EAP1	2021-06-01 14:33:21 +09:00
ekrctb	86020adf64	Revert invalid code transformation	2021-06-01 14:28:23 +09:00
Dean Herbert	cbf3ef5400	Create replay via the ICreateReplay interface instead of explicitly ModAutoplay	2021-06-01 14:22:16 +09:00
Dean Herbert	9221213fe5	Fix potential nullref is beatmap load failed	2021-06-01 14:19:23 +09:00
Dean Herbert	14570b6fb1	Merge branch 'master' into autoplay-pause-support	2021-06-01 14:19:21 +09:00
Dean Herbert	a9f4bc6285	Never return a null argument ... Enable nullable	2021-06-01 14:11:17 +09:00
Dean Herbert	27b7039520	Use constant	2021-06-01 14:02:32 +09:00
Dean Herbert	6e4730652e	Push private methods down	2021-06-01 14:01:08 +09:00
Dean Herbert	3ff97f787a	Localise all URL generation for now to avoid weird Schedule logic	2021-06-01 13:56:59 +09:00
Dean Herbert	111bfd4d88	Fix relative URLs having a null argument after resolution to LinkDetails	2021-06-01 13:50:20 +09:00
ekrctb	d5714e63b9	Apply code styling suggestions ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-06-01 13:17:30 +09:00
ekrctb	86d1ba7ef2	Remove unused IScrollingHitObject interface	2021-05-31 23:17:26 +09:00
Dean Herbert	00b3eea840	Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup	2021-05-31 21:39:04 +09:00
Dan Balasescu	bd7814b487	Merge pull request #13257 from ekrctb/simplify-shoc ... Multiple `ScrollingHitObjectContainer` logic simplification	2021-05-31 21:31:10 +09:00
Dean Herbert	69c4ccad05	Fix weird taiko logic failing for weird reasons that probably should not have been a thing	2021-05-31 21:29:47 +09:00
Dean Herbert	1161378b6b	Fix incorrect fallback logic in LegacyBeatmapSkin	2021-05-31 21:29:47 +09:00
Dean Herbert	282c5a9177	Fix potential nullref in SkinProvidingContainer	2021-05-31 21:29:47 +09:00
Dean Herbert	3ff9f9c89d	Make FindProvider non-default	2021-05-31 21:29:47 +09:00
Dean Herbert	8e489754cc	Add ability for LegacySkins to customise the fallback provider	2021-05-31 21:29:47 +09:00
Dean Herbert	88ed95e012	Add FindProvider lookup function	2021-05-31 21:29:47 +09:00
Dean Herbert	1d30791ab0	Add potential pathway for legacy lookups	2021-05-31 21:29:47 +09:00
Dean Herbert	4b27d43e26	Add new parameter for default fallback logic in LegacySkin	2021-05-31 21:29:47 +09:00
ekrctb	ff04942295	Change timing of HitObjectContainer.OnAdd/OnRemove ... Now, `OnAdd` is always invoked after the DHO is added to the container. This change is required by `ScrollingHitObjectContainer` to compute origin adjusted lifetime when origin position is relative to the parent drawable size.	2021-05-31 20:56:25 +09:00
Dan Balasescu	9036b13637	Merge pull request #13260 from peppy/legacy-skin-resource-improvements ... Allow `LegacyDefaultSkin` to be constructed without extra resource store parameter	2021-05-31 20:49:21 +09:00
Dean Herbert	f60e9cb085	Remove weird override logic in TestCase methods	2021-05-31 20:00:47 +09:00
Dean Herbert	e78391db7a	Fix usage of DI before it's ready in combo colour tests	2021-05-31 19:58:19 +09:00
Dean Herbert	17fa2426d4	Merge branch 'master' into legacy-skin-resource-improvements	2021-05-31 19:36:09 +09:00
smoogipoo	7f24518004	Fix spectator crashing when converting mania replay frames	2021-05-31 19:24:22 +09:00
smoogipoo	d2d0896298	Expose GameplayBeatmap and GameplayRuleset from Player	2021-05-31 19:22:20 +09:00
Dean Herbert	ebfc24a499	Rename conflicting resources	2021-05-31 19:14:49 +09:00
Dean Herbert	65709ec7d7	Move leagcy resource store construction local to DefaultLegacySkin	2021-05-31 19:14:49 +09:00
Dan Balasescu	46b6f49a92	Merge pull request #13230 from peppy/non-nullable-beatmapset-files ... Make `BeatmapSet.Files` non-nullable	2021-05-31 19:10:03 +09:00
Dean Herbert	d1ef5483bc	Merge pull request #12826 from frenzibyte/catch-hide-combo-workaround ... Hide legacy HUD combo counters on osu!catch ruleset	2021-05-31 19:04:25 +09:00
Dean Herbert	b16d10bd95	Provide game-wide resources via IStorageResourceProvider	2021-05-31 18:57:47 +09:00
Dean Herbert	675fe37446	Change check order around to ensure re-fetches which return no results don't nullref	2021-05-31 18:35:18 +09:00
Dean Herbert	d4cb70735d	Merge branch 'master' into non-nullable-beatmapset-files	2021-05-31 18:19:57 +09:00
Dan Balasescu	d8768a8c01	Merge pull request #13254 from peppy/fix-editor-beatmap-creation-test-failure-again ... Fix bindable lease failure in editor beatmap creation tests	2021-05-31 17:38:19 +09:00
ekrctb	948a14a627	Merge branch 'simplify-shoc' into fix-scrolling-lifetime ... # Conflicts: # osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs	2021-05-31 16:50:47 +09:00
ekrctb	86d1225aad	Reset lifetime to initial lifetime when layout is invalidated	2021-05-31 16:47:10 +09:00
ekrctb	6d96846776	Remove scrollLength caching field ... It was not clear when the field is updated.	2021-05-31 16:28:02 +09:00
ekrctb	742c5b442b	Remove delay of lifetime update ... The scheduling is no longer necessary because `OnAdd` is changed to not invoked immediately for non-pooled DHOs.	2021-05-31 16:24:13 +09:00
ekrctb	3cedc0824d	Don't add nested hit objects to the sets ... Only top-level hit objects are checked for layout computation caching. Also, lifetime of nested hit objects are not managed by the HitObjectContainer.	2021-05-31 16:20:35 +09:00
ekrctb	56a0a24cba	Make SetInitialLifetime public	2021-05-31 15:33:28 +09:00
Dean Herbert	de0e51a81d	Merge branch 'master' into fix-skin-sample-lookup	2021-05-31 15:27:39 +09:00
Salman Ahmed	4e186b0cf5	ContentVisible -> HiddenByRulesetImplementation	2021-05-31 09:24:26 +03:00
Salman Ahmed	02d18c7a49	Merge branch 'master' into remove-hud-component-lookup	2021-05-31 09:23:04 +03:00
ekrctb	e25cca6fbe	Update drawable lifetime on entry lifetime change	2021-05-31 14:45:29 +09:00
Dan Balasescu	8c6277f0d8	Merge pull request #13235 from ekrctb/update-lifetime-1 ... Update hit object lifetime on `HitObject.DefaultsApplied`	2021-05-31 14:44:40 +09:00
Dean Herbert	5925beaf21	Fix bindable lease failure in editor beatmap creation tests	2021-05-31 14:24:46 +09:00
Dean Herbert	06bd696cc2	Remove previous consumption logic in GetWorkingBeatmap ... This should not be required since the introduction of `workingCache`, which does the same thing in a more global way.	2021-05-31 14:11:58 +09:00
ekrctb	0c101d2859	Apply comment rewording suggestion ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-05-31 13:41:49 +09:00
smoogipoo	a4dca6f839	Reorder methods around load()	2021-05-31 13:39:18 +09:00
Dan Balasescu	1ba607b3ff	Merge branch 'master' into osu-game-base-cleanup	2021-05-31 13:32:09 +09:00
Salman Ahmed	fb111e23d8	Remove "temporarily"	2021-05-31 07:24:59 +03:00
Gagah Pangeran Rosfatiputra	113f90e92e	add back schedule is CurrentPath setter	2021-05-31 10:49:16 +07:00
smoogipoo	bca8a9ea53	Fix HandleFrame crashing when not playing	2021-05-31 10:02:02 +09:00
Bartłomiej Dach	ab077c6656	Merge branch 'master' into non-nullable-beatmapset-files	2021-05-31 00:10:03 +02:00
Salman Ahmed	3fbd4e276d	Add simple xmldoc	2021-05-31 00:07:29 +03:00
Bartłomiej Dach	78213e09d4	Merge branch 'master' into editor-exit-stability	2021-05-30 23:03:50 +02:00
Salman Ahmed	d12e93bfc6	Add skin traget resetting on setup/teardown steps	2021-05-31 00:02:55 +03:00
Gagah Pangeran Rosfatiputra	3c7f1ae996	Merge branch 'master' into osu-wiki-overlay	2021-05-30 20:27:12 +07:00
Dean Herbert	f3bde258a2	Merge pull request #13232 from ekrctb/initial-lifetime ... Fix wrong/misleading comment of `InitialLifetimeOffset`	2021-05-30 22:26:47 +09:00
Dean Herbert	f35cf2d846	Merge branch 'master' into main-page-wiki	2021-05-30 21:01:05 +09:00
Salman Ahmed	fb81e5133f	Merge branch 'master' into catch-hide-combo-workaround	2021-05-30 14:16:46 +03:00
Dean Herbert	dac1a98d8a	Merge branch 'master' into fix-skin-sample-lookup	2021-05-30 15:19:47 +09:00
ekrctb	abb77b95b4	Fix comment grammar	2021-05-30 13:06:28 +09:00
Salman Ahmed	53cbf369d7	Fix potential nullref	2021-05-29 21:22:46 +03:00
Salman Ahmed	42618c713f	Merge branch 'master' into legacy-beatmap-skin-hud-fallback	2021-05-29 20:56:05 +03:00
Dean Herbert	4e7d19a3af	Merge branch 'master' into beatmap-skin	2021-05-29 16:51:17 +09:00
Dean Herbert	9b239e308b	Merge branch 'master' into beatmap-skin	2021-05-29 15:36:43 +09:00
ekrctb	265dfe5416	Add test case of DHO setting LifetimeStart in OnApply	2021-05-28 21:51:48 +09:00
ekrctb	43bf734816	Reset lifetime on HitObject.DefaultsApplied	2021-05-28 21:35:26 +09:00
Dean Herbert	8652ac05db	Merge branch 'editor-exit-stability' into non-nullable-beatmapset-files	2021-05-28 18:58:35 +09:00
Dean Herbert	ee5eb9576f	Fix completely wrong conditional logic	2021-05-28 18:38:50 +09:00
ekrctb	1d5e8f4a91	Fix wrong/misleading comment of InitialLifetimeOffset	2021-05-28 17:19:36 +09:00
Dean Herbert	631d217f78	Remove no longer necessary conditional access	2021-05-28 15:42:35 +09:00
Dean Herbert	6268bbea85	Merge branch 'master' into fix-skin-sample-lookup	2021-05-28 14:47:35 +09:00
Dean Herbert	330d61862d	Add a mention of why StartHidden is required	2021-05-28 14:41:01 +09:00
Dean Herbert	581a86b91a	Revert "Revert "Fix editor tests failing due to empty files being specified"" ... This reverts commit 1af684c4b2.	2021-05-28 14:33:06 +09:00
Dean Herbert	41733af0ed	Revert "Revert "Make BeatmapSetInfo.Files non-nullable"" ... This reverts commit 9c4f39e968.	2021-05-28 14:33:05 +09:00
Dean Herbert	b349ff8693	Revert "Add temporary accounting for tests with null files" ... This reverts commit e52c0a34f8.	2021-05-28 14:33:04 +09:00
Dean Herbert	f1b5aced6f	Merge branch 'master' into editor-exit-stability	2021-05-28 14:32:32 +09:00
Dean Herbert	e52c0a34f8	Add temporary accounting for tests with null files	2021-05-28 14:31:26 +09:00
Dean Herbert	9c4f39e968	Revert "Make BeatmapSetInfo.Files non-nullable" ... This reverts commit c24712642c.	2021-05-28 14:15:28 +09:00
Dean Herbert	1af684c4b2	Revert "Fix editor tests failing due to empty files being specified" ... This reverts commit fdbd421040.	2021-05-28 14:15:28 +09:00
Dean Herbert	5e8893b203	Update framework	2021-05-28 10:42:13 +09:00
Craftplacer	b3ac67675e	Merge branch 'chat-mention' of github.com:Craftplacer/osu into chat-mention	2021-05-27 21:59:51 +02:00
Craftplacer	13b2b7c148	Fix formatting	2021-05-27 21:58:54 +02:00
Gagah Pangeran Rosfatiputra	854ef0abfd	add simple bound check	2021-05-28 00:55:14 +07:00
Gagah Pangeran Rosfatiputra	ead0e92d7d	use select single node for blurb	2021-05-28 00:50:59 +07:00
Dean Herbert	ce96c58230	Move public members up	2021-05-28 02:46:26 +09:00
Dean Herbert	fe6b1936cb	Move OsuUserInputManager out from nested class	2021-05-28 02:46:03 +09:00
Dean Herbert	b4c13d837d	Move import logic out to partial class	2021-05-28 02:44:44 +09:00
Dean Herbert	b8edca59eb	General function reorganisation	2021-05-28 02:37:14 +09:00
Dean Herbert	4e49fbf7fb	Switch protected properties to private where feasible	2021-05-28 02:30:31 +09:00
Dean Herbert	d24a712dd4	Move protected properties to one location and mark setters private where feasible	2021-05-28 02:27:06 +09:00
Dan Balasescu	7e0a4562c9	Merge branch 'master' into fix-bad-make-current-call	2021-05-28 00:32:51 +09:00
Dan Balasescu	fd7a6db774	Merge pull request #12728 from SleepySwords/single-bind-reset-button ... Add a reset button to individual keybinds	2021-05-28 00:31:26 +09:00
Dan Balasescu	08c8cd7a66	Merge pull request #12946 from peppy/fix-storyboard-video-widescreen-no-elements ... Fix storyboard videos not correctly filling the screen	2021-05-28 00:11:04 +09:00
Dan Balasescu	1ffafdd854	Merge branch 'master' into single-bind-reset-button	2021-05-27 23:55:28 +09:00
Dan Balasescu	bc4ccb8a21	Merge pull request #12916 from peppy/fix-taiko-editor-sample-mutations ... Fix osu!taiko editor operations not always updating the menu/visual state correctly	2021-05-27 23:55:16 +09:00
Dan Balasescu	cb850e07f7	Merge pull request #12963 from peppy/fix-settings-panel-hide-animation ... Fix settings panel hide animation looking wrong when a sub-panel is visible when hidden	2021-05-27 23:55:00 +09:00
Dan Balasescu	0a3d3bc006	Merge pull request #12958 from peppy/fix-invalid-ssdq-access ... Fix `BeatmapCarousel` accessing `ScreenSpaceDrawQuad` of non-loaded children	2021-05-27 23:15:06 +09:00
Dan Balasescu	6ddb2062cf	Merge pull request #13214 from peppy/fix-multiplayer-leaderboard-test-failure ... Fix test failure in `TestSceneMultiplayerGameplayLeaderboard`	2021-05-27 22:44:05 +09:00
Dean Herbert	121dd175e6	Fix test failure in TestSceneMultiplayerGameplayLeaderboard ... The transfer of users was not accounting for the fact that the `StartPlay` calls are now scheduled and not necessarily run in time.	2021-05-27 19:57:21 +09:00
Gagah Pangeran Rosfatiputra	e1836cd1b2	add debug assert	2021-05-27 17:12:15 +07:00
Dean Herbert	37ef368738	Move async call out of using to better define the flow of data	2021-05-27 19:03:59 +09:00
Craftplacer	0b17af81f1	Use Contains instead of IndexOf ... Co-authored-by: Berkan Diler <b.diler@gmx.de>	2021-05-27 09:48:30 +00:00
Dean Herbert	046087a367	Fix access to AliveChildren before IsLoaded	2021-05-27 16:58:01 +09:00
Dean Herbert	aa23c4a4b9	Merge branch 'master' into keyboard_shortcuts	2021-05-27 16:30:34 +09:00
Gagah Pangeran Rosfatiputra	c72e258bfb	change for to while in create panels	2021-05-27 14:12:49 +07:00
Gagah Pangeran Rosfatiputra	4fbd43fcae	add inline comment for width 2	2021-05-27 13:24:06 +07:00
Dean Herbert	122bb05aa8	Add a mention that OnApply/OnFree is performed after ApplyDefaults	2021-05-27 15:20:35 +09:00
Dean Herbert	b13b732e02	Remove incorrect DefaultSkin usage	2021-05-27 14:50:56 +09:00
Dean Herbert	70a844ac10	Remove allowFallback parameters completely	2021-05-27 14:50:42 +09:00
Dean Herbert	4fd89faaa4	Fix default skin not having resources or providing samples	2021-05-27 14:09:01 +09:00
Dean Herbert	d66f07fccb	Move text and isFullWidth parameters to constructor	2021-05-27 14:04:50 +09:00
Salman Ahmed	0c2d3ae0e7	Revert "Move beatmap skin info creation to static method at IBeatmapSkin" ... This reverts commit 9806d94b74.	2021-05-27 05:08:49 +03:00
Gagah Pangeran Rosfatiputra	a7865d3f22	move colour provider to BDL	2021-05-27 08:46:24 +07:00
Craftplacer	a679efac1c	Reduce duplicate notification code by making a base class	2021-05-27 01:00:26 +02:00
Craftplacer	cf39e58ce7	Subscribe to CollectionChanged before binding to JoinedChannels	2021-05-27 01:00:08 +02:00
Craftplacer	d47370bac9	Locally bind to LocalUser	2021-05-27 00:59:29 +02:00
Gagah Pangeran Rosfatiputra	649163e13b	Merge branch 'master' into main-page-wiki	2021-05-26 23:51:49 +07:00
Dean Herbert	f6dee13991	Merge pull request #12948 from gagahpangeran/markdown-wiki ... Add wiki markdown container	2021-05-27 01:49:32 +09:00
Dean Herbert	735e7b9c74	Pass fetch more action in via ctor to avoid potential nullref	2021-05-26 22:49:39 +09:00
Dean Herbert	9947867e84	Remove unnecessary bindable flow	2021-05-26 22:46:43 +09:00
Dean Herbert	71de541245	Minor spacing / reformatting	2021-05-26 22:35:11 +09:00
Andrei Zavatski	1bde11a07e	Refactor ArticleListing	2021-05-26 15:35:38 +03:00
Gagah Pangeran Rosfatiputra	905364b5fe	add url as argument for link action external	2021-05-26 19:34:34 +07:00
Gagah Pangeran Rosfatiputra	7546611c14	remove unused cached	2021-05-26 19:32:49 +07:00
Gagah Pangeran Rosfatiputra	2344a1a411	use image block in markdown container	2021-05-26 19:22:33 +07:00
Gagah Pangeran Rosfatiputra	62fb09774a	create WikiMarkdownImageBlock	2021-05-26 19:22:21 +07:00
Andrei Zavatski	82d977f80a	Merge remote-tracking branch 'refs/remotes/ppy/master' into news-request	2021-05-26 14:52:42 +03:00
Dean Herbert	7ed4cbf7bf	Fix settings panel hide animation looking wrong when a sub-panel is visible when hidden	2021-05-26 19:25:05 +09:00
Dean Herbert	14a4095140	Merge branch 'master' into beatmap-skin	2021-05-26 18:39:47 +09:00
Dean Herbert	c05dfee220	Simplify default handling flow	2021-05-26 18:28:00 +09:00
Dean Herbert	7c9383b586	Combine RestorableKeyBindingRow back into KeyBindingRow	2021-05-26 18:17:28 +09:00
Gagah Pangeran Rosfatiputra	db8ccad0b8	Merge branch 'master' into markdown-wiki	2021-05-26 15:25:46 +07:00
Dean Herbert	02806fedb0	Add missing newline	2021-05-26 17:17:02 +09:00
Dean Herbert	17334fd2e6	Inline KeyBindingRow construction	2021-05-26 17:12:12 +09:00
Gagah Pangeran Rosfatiputra	9c31b8856d	change image url replace implementation	2021-05-26 15:10:09 +07:00
Dean Herbert	49b4a6ea67	Replace local namespace qualifiers with using	2021-05-26 17:07:24 +09:00
Dean Herbert	f8a3a37797	Remove outdated comment	2021-05-26 17:01:47 +09:00
Gagah Pangeran Rosfatiputra	47cbbee4d1	remove CreateNotice method and move implementation to local	2021-05-26 15:01:16 +07:00
Dean Herbert	98fa5b67d6	Merge branch 'master' into single-bind-reset-button	2021-05-26 17:01:16 +09:00
Gagah Pangeran Rosfatiputra	eeb6647bc5	remove schedule in set current path	2021-05-26 14:59:36 +07:00
Dean Herbert	1e77a87fab	Merge pull request #12947 from gagahpangeran/markdown-link ... Handle link action in `OsuMarkdownLinkText`	2021-05-26 16:56:24 +09:00
Gagah Pangeran Rosfatiputra	02f0e2f212	Merge branch 'markdown-link' into markdown-wiki	2021-05-26 14:55:32 +07:00
Dan Balasescu	34d1d5198f	Merge pull request #12943 from nbvdkamp/fix-zero-area-skin-element-scale-crash ... Prevent skin editor crash when scaling 0 area drawables	2021-05-26 16:37:58 +09:00
Dean Herbert	88bdd8a7b7	Update some out of date code pieces	2021-05-26 16:01:21 +09:00
Dean Herbert	52ca2f4797	Merge branch 'master' into chat-mention	2021-05-26 16:00:26 +09:00
Gagah Pangeran Rosfatiputra	e02739a136	remove unused colour provider	2021-05-26 13:57:35 +07:00
Gagah Pangeran Rosfatiputra	04f16c0783	Set DocumentUrl inside CreateChildDependencies ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2021-05-26 13:55:16 +07:00
Dean Herbert	b3b39c4c13	Fix BeatmapCarousel accessing ScreenSpaceDrawQuad of non-loaded children ... Fixes failure seen at https://ci.appveyor.com/project/peppy/osu/builds/39302762/tests.	2021-05-26 15:42:27 +09:00
Dean Herbert	b36b40cb34	Remove unnecessary double specification	2021-05-26 15:20:47 +09:00
Dean Herbert	ba8544f614	Update resources	2021-05-26 14:55:44 +09:00
Dean Herbert	e4780abdfd	Split out base call from switch statement	2021-05-26 14:43:59 +09:00
Dean Herbert	d165a75823	Inline request flow to make it easier to understand	2021-05-26 14:37:52 +09:00
Dean Herbert	0f21510b8b	Move code around	2021-05-26 14:29:46 +09:00
Dean Herbert	8ffa7f4a5a	Tidy up code	2021-05-26 14:28:20 +09:00
Dean Herbert	7b09955d59	Remove redundant default bindable value	2021-05-26 14:17:40 +09:00
Dean Herbert	200592114f	Make protected variables private	2021-05-26 14:13:02 +09:00
Swords	07a24d2747	Fixing errors	2021-05-25 23:54:13 +10:00
Swords	9c2dca8229	Removing redundant argument list	2021-05-25 21:53:00 +10:00
Swords	d5feb8353d	Formatting, renaming	2021-05-25 21:37:08 +10:00
Swords	d9f5b578bf	Restore class names	2021-05-25 21:08:40 +10:00
Swords	ce845a9f8d	Apply the rest of requested changes	2021-05-25 21:00:38 +10:00
Dean Herbert	268230c8c4	Merge branch 'master' into fix-taiko-editor-sample-mutations	2021-05-25 19:01:47 +09:00
Dean Herbert	342acadae2	Change LINQ query for better readability	2021-05-25 18:51:51 +09:00
Dean Herbert	871ca8054f	Rename classes as per review feedback	2021-05-25 18:50:33 +09:00
Dean Herbert	7c89dbcd35	Externalise autoplay generation	2021-05-25 18:37:04 +09:00
Dean Herbert	7f9318d976	Expose GameplayBeatmap to derived Player classes	2021-05-25 18:36:47 +09:00
Dean Herbert	c2b938a29f	Remove autoplay consideration from Player	2021-05-25 18:09:37 +09:00
Dean Herbert	a3c78674a1	Add new interface for autoplay mods	2021-05-25 18:09:24 +09:00
Dean Herbert	a249bb9e69	Merge branch 'master' into realm-key-binding-store	2021-05-25 17:18:33 +09:00
Dean Herbert	a7f50c5da6	Revert "Update realm package to latest beta version" ... This reverts commit 2a87b3d74b.	2021-05-25 17:13:25 +09:00
Gagah Pangeran Rosfatiputra	4c8f19af69	load empty page when fail	2021-05-25 14:47:39 +07:00
Dean Herbert	5ea948aabe	Bypass 640x480 coordinate space for video storyboard elements ... This allows the `FillMode.Fill` to take up the full space of the storyboard container.	2021-05-25 16:17:29 +09:00
Dean Herbert	0c55bba220	Allow storyboards to be widescreen if only a video element exists ... This matches stable behaviour, which will allow videos to display filling the screen if they are the only thing contained within the "storyboard".	2021-05-25 16:07:19 +09:00
Dean Herbert	e3507d5453	Move DrawableStoryboard's aspect application to inside its own class	2021-05-25 16:06:39 +09:00
Dan Balasescu	774611f142	Merge pull request #12933 from peppy/fix-scroll-wheel-gameplay-bindings ... Disallow using scroll wheel for gameplay bindings	2021-05-25 16:04:18 +09:00
Gagah Pangeran Rosfatiputra	9de07de467	move text flow container inside markdown container	2021-05-25 12:14:07 +07:00
Dean Herbert	9563b73ea6	Remove unnecessary using statement	2021-05-25 14:14:00 +09:00
Dean Herbert	2a87b3d74b	Update realm package to latest beta version	2021-05-25 13:43:55 +09:00
Dean Herbert	df703b68ec	Merge branch 'master' into realm-key-binding-store	2021-05-25 13:41:48 +09:00
kamp	65649e5a62	Prevent skin editor crash when scaling 0 area drawables ... Some skinnable drawables can have 0 width or height in certain cases, leading to division by 0 and a crash when the position is updated.	2021-05-24 21:36:42 +02:00
Gagah Pangeran Rosfatiputra	728258d93a	add website root url as document url	2021-05-25 00:29:59 +07:00
Dan Balasescu	6263ebf9da	Merge pull request #12495 from peppy/localisation-proof-of-concept ... Add language selection and general structure for localisation support	2021-05-24 23:33:49 +09:00
Dan Balasescu	3b4fbe22f0	Merge pull request #12928 from Firmatorenio/fix-colour-hitmeter-not-registering-taiko-misses ... Fix colour hit error meter incorrectly assuming taiko hits were of correct colour	2021-05-24 23:31:54 +09:00
Dan Balasescu	eeda33a453	Merge branch 'master' into localisation-proof-of-concept	2021-05-24 22:56:18 +09:00
Dean Herbert	37f6ceef79	Add test coverage	2021-05-24 21:57:04 +09:00
Dean Herbert	62b6cadb64	Ensure settings rows cannot set an invalid value in the first place	2021-05-24 21:56:41 +09:00
Swords	518999ffab	Renaming files	2021-05-24 22:49:40 +10:00
smoogipoo	fe9abd5b80	Upgrade packages and fix ResX files	2021-05-24 21:37:05 +09:00
Gagah Pangeran Rosfatiputra	02cdd0b2de	use drawable link compiler in markdown link	2021-05-24 19:10:37 +07:00
Swords	441e4e7d56	Formatting	2021-05-24 22:08:34 +10:00
Swords	ca1d1c58ab	RestoreDefaultValueButton implements OsuButton	2021-05-24 21:34:47 +10:00
Firmatorenio	471f17547a	switch determining the hit result by offset to getting it from the judgement directly	2021-05-24 16:49:58 +06:00
Dean Herbert	a00f226ab3	Add assert on storing to database	2021-05-24 18:41:39 +09:00
Dean Herbert	deabce7140	Disallow updating the database to an invalid value	2021-05-24 18:40:56 +09:00
Dean Herbert	57640810b5	Ignore certain banned InputKeys for gameplay purposes	2021-05-24 18:40:40 +09:00
Salman Ahmed	3585e2900e	Replace unnecessary empty skin implementation with null	2021-05-24 12:28:52 +03:00
Salman Ahmed	7792efb154	Remove no longer used BeatmapSkin	2021-05-24 12:28:06 +03:00
Dan Balasescu	af2a831c83	Merge pull request #12926 from peppy/fix-placement-blueprint-disappearing ... Fix editor placement ending early if a blueprint becomes alive from a pool	2021-05-24 17:42:18 +09:00
Dan Balasescu	91acf16e52	Merge pull request #12912 from peppy/fix-legacy-combo-counter-positioning ... Fix legacy combo counter not accounting for song progress bar	2021-05-24 17:26:25 +09:00
Dan Balasescu	7a343c1576	Merge pull request #12915 from peppy/regenerate-replay-less ... Ensure `RegenerateAutoplay` is only run once per frame	2021-05-24 17:25:42 +09:00
Dan Balasescu	28f91f8d65	Merge pull request #12921 from peppy/fix-hud-offsets-out-of-bounds ... Limit automatically calculated HUD offsets to keep menu items on screen	2021-05-24 17:25:03 +09:00
Dean Herbert	7961dba1d3	Reorder OrderBy for legibility	2021-05-24 17:22:55 +09:00
Dean Herbert	f8c6150493	Update framework	2021-05-24 17:11:01 +09:00
Dean Herbert	65c3c0d53f	Merge branch 'master' into localisation-proof-of-concept	2021-05-24 17:10:56 +09:00
Dean Herbert	4fc6ba50b7	Fix editor placement ending early if a blueprint becomes alive from a pool ... Closes https://github.com/ppy/osu/issues/12630.	2021-05-24 17:04:02 +09:00
Dean Herbert	68364081f2	Merge pull request #11582 from frenzibyte/mbd-beatmap-set-cover ... Refactor beatmap set covers into using `ModelBackedDrawable<T>`	2021-05-24 16:30:14 +09:00
Firmatorenio	e5f586f2a6	fix colour hit error meter not pushing misses when wrong colour note is hit in taiko	2021-05-24 13:29:12 +06:00
Dean Herbert	29e1737f0d	Merge branch 'master' into mbd-beatmap-set-cover	2021-05-24 15:51:03 +09:00
Dean Herbert	100e2d14a5	Move call inside conditional	2021-05-24 15:14:55 +09:00
Andrei Zavatski	06fe0563d3	Move GetNewsRequest from ArticleListing to NewsOverlay	2021-05-24 08:26:44 +03:00
smoogipoo	7494ddeef4	Fix DHOs not receiving initial skin changed events	2021-05-24 14:07:40 +09:00
Dean Herbert	a69a1b5211	Fix Player potentially running MakeCurrent when already removed from the screen stack ... Closes #12919.	2021-05-24 13:53:53 +09:00
Dean Herbert	83981b692e	Also handle items exiting bounds on the opposite side	2021-05-24 13:44:13 +09:00
Dean Herbert	593fea0d5f	Limit automatically calculated HUD offsets to keep menu items on screen	2021-05-24 13:14:18 +09:00
Gagah Pangeran Rosfatiputra	222c34c0a1	fix heading font weight to light	2021-05-23 21:46:41 +07:00
Gagah Pangeran Rosfatiputra	bd1454bdd1	update height to max of its parent height	2021-05-23 21:42:58 +07:00
Gagah Pangeran Rosfatiputra	24960c4fb8	move panel spacing to ctor	2021-05-23 21:31:49 +07:00
Salman Ahmed	d605b6bb8d	Fix HUD overlay components bottom positioning logic accounting for combo	2021-05-23 16:22:51 +03:00
Salman Ahmed	6751d79ce8	Fix oversight in HUD overlay components top positioning logic	2021-05-23 16:22:22 +03:00
Dean Herbert	4c9d72e62a	Ensure EditorBeatmap.Update is called inside PerformOnSelection calls	2021-05-23 21:22:35 +09:00
Dean Herbert	bbfd7ea23f	Ensure RegenerateAutoplay is only run once per frame	2021-05-23 21:20:08 +09:00
Gagah Pangeran Rosfatiputra	10c4ba3a74	add panels to grid content	2021-05-23 19:07:22 +07:00
Gagah Pangeran Rosfatiputra	24fef221e3	change createPanels method to create grid content	2021-05-23 19:07:10 +07:00
Gagah Pangeran Rosfatiputra	8389d90f7e	add GridContainer in wiki main page	2021-05-23 18:52:20 +07:00
Gagah Pangeran Rosfatiputra	4068881096	add bottom margin for paragraph	2021-05-23 18:11:54 +07:00
Gagah Pangeran Rosfatiputra	cd211de729	make panel text bold	2021-05-23 18:10:56 +07:00
Gagah Pangeran Rosfatiputra	512d6d2f7f	centering link inside panel	2021-05-23 18:09:09 +07:00
Gagah Pangeran Rosfatiputra	1e5f34567a	add panel heading main page	2021-05-23 18:07:27 +07:00
Gagah Pangeran Rosfatiputra	365a0b25f2	add IsFullWidth	2021-05-23 18:03:38 +07:00
Gagah Pangeran Rosfatiputra	4d222467cc	initial WikiPanelMarkdownContainer	2021-05-23 18:00:54 +07:00
Gagah Pangeran Rosfatiputra	d9e898a2ee	extract WikiPanelContainer	2021-05-23 17:56:27 +07:00
Gagah Pangeran Rosfatiputra	4a543c2557	add simple panels	2021-05-23 17:49:26 +07:00
Dean Herbert	caa2c5638e	Fix legacy combo counter not accounting for song progress bar	2021-05-23 16:46:57 +09:00
Joseph Madamba	2fd0038154	Fix checkmark being hidden after clicking current waveform opacity setting	2021-05-22 16:42:20 -07:00
Dean Herbert	45c6a9ca91	Merge branch 'refactor-selection-rotate-logic' into fix-flip-logic-discrepancy	2021-05-22 21:17:58 +09:00
Dean Herbert	7d88a19d7f	Remove unnecessary field storage of origin reference	2021-05-22 21:03:40 +09:00
Dean Herbert	34a5b22b79	Merge branch 'master' into refactor-selection-rotate-logic	2021-05-22 20:52:28 +09:00
Dean Herbert	485728ca4e	Merge pull request #12866 from peppy/refactor-selection-scale-logic ... Add proper scaling support to skin editor	2021-05-22 20:07:03 +09:00
Dean Herbert	b13a68592f	Merge branch 'master' into localisation-proof-of-concept	2021-05-22 17:07:23 +09:00
Dean Herbert	fb5672814d	Add remaining strings for ButtonSystem	2021-05-22 13:56:59 +09:00
Dean Herbert	b6db9ef334	Fill out Japanese localisation via resx	2021-05-22 13:54:52 +09:00
Dean Herbert	2fc53017fc	Generate initial resx files	2021-05-22 13:46:09 +09:00
Dean Herbert	cd3f543394	Add LocalisationAnalyser package and tools	2021-05-22 02:32:55 +09:00
Salman Ahmed	4f6de6fdc6	Implement GetSkin() for other working beatmaps	2021-05-21 20:21:29 +03:00
Salman Ahmed	04e75d8f2b	Return empty skin for GetSkin() in TestWorkingBeatmap	2021-05-21 20:21:13 +03:00
Salman Ahmed	318e5fc60b	Mark WorkingBeatmap.GetSkin() as abstract	2021-05-21 20:14:26 +03:00
Dean Herbert	bb2fae55ce	Merge branch 'master' into refactor-selection-rotate-logic	2021-05-21 19:19:54 +09:00
Dan Balasescu	5ad41ded94	Merge branch 'master' into fix-dho-lmc	2021-05-21 19:11:57 +09:00
Dean Herbert	f335337e5d	Merge pull request #12851 from vininew921/applause-stops-on-score-switch ... Fix applause sound stopping after switching scores	2021-05-21 18:49:59 +09:00
Dean Herbert	bf4db60ef4	Remove placeholder translations	2021-05-21 18:48:42 +09:00
Dean Herbert	0acf4cf85c	Translate remaining ButtonSystem strings and rename to match class name	2021-05-21 18:48:11 +09:00
Dean Herbert	df426b9334	Merge pull request #12852 from timiimit/multi-larger-freemod-overlay ... Make freemod selection overlay taller in multiplayer room	2021-05-21 18:45:15 +09:00
Dean Herbert	a8acbbe69c	Merge pull request #12779 from Game4all/import-from-stable-select-location ... Add ability to manually locate a stable location when importing from stable	2021-05-21 18:17:30 +09:00
Dean Herbert	b0a113a36b	Merge branch 'master' into localisation-proof-of-concept	2021-05-21 17:57:54 +09:00
Dean Herbert	abc96057b2	Remove relative height specification and use constant height	2021-05-21 17:55:46 +09:00
Dean Herbert	41c4afb3d5	Restore path specification to "." for consistency	2021-05-21 17:46:27 +09:00
Dean Herbert	2958b9adf4	Merge branch 'master' into import-from-stable-select-location	2021-05-21 17:37:34 +09:00
Dean Herbert	1ca563e831	Merge branch 'master' into applause-stops-on-score-switch	2021-05-21 17:28:28 +09:00
Dean Herbert	0c504c3b7d	Update framework	2021-05-21 17:24:22 +09:00
Dean Herbert	20f890cfd0	Merge branch 'master' into fix-spectator-playing-state-5	2021-05-21 16:49:22 +09:00
Dean Herbert	1c560a9490	Merge pull request #12869 from EVAST9919/sidebar ... Add sidebar to news overlay	2021-05-21 16:21:18 +09:00
smoogipoo	7c59fb37f1	Move check into callback	2021-05-21 16:00:58 +09:00
smoogipoo	36aa186c6e	Merge branch 'thread-safe-spectator-client'	2021-05-21 16:00:24 +09:00
smoogipoo	7f712a4d04	Fix EndPlaying potentially doing cross-thread mutation	2021-05-21 15:57:39 +09:00
smoogipoo	2fdf8aa1aa	Add update thread assertions	2021-05-21 15:57:31 +09:00
Dean Herbert	fbe4d7e03c	Improve code quality around cursor and upwards passing of response data	2021-05-21 15:41:31 +09:00
Dean Herbert	0d575f5728	Remove incorrect (and unintended) modulus logic	2021-05-21 15:06:53 +09:00
Dean Herbert	f9d51656b6	Fix scaling of rotated items not behaving in an understandable way	2021-05-21 15:02:36 +09:00
smoogipoo	895eb14c5a	Forcefully end playing to fix test failures	2021-05-21 14:09:30 +09:00
Gagah Pangeran Rosfatiputra	216b87691c	add blurb	2021-05-21 10:04:45 +07:00
Gagah Pangeran Rosfatiputra	5964ee23cb	add HtmlAgilityPack dependency	2021-05-21 09:54:54 +07:00
Gagah Pangeran Rosfatiputra	49aa0f3a18	initial main page	2021-05-21 10:04:45 +07:00
Dean Herbert	7ad6a1d5ff	Merge branch 'master' into thread-safe-spectator-client	2021-05-21 11:47:58 +09:00
Gagah Pangeran Rosfatiputra	236124496d	add missing accent colour in control tab item	2021-05-21 01:21:32 +07:00
Andrei Zavatski	40ca94cd7b	Fix incorrect year being passed on first load	2021-05-20 16:04:51 +03:00
Andrei Zavatski	c48b5eebdd	Don't reload the context when clicking selected year button	2021-05-20 15:45:39 +03:00
Andrei Zavatski	bd80cf656a	Merge remote-tracking branch 'refs/remotes/ppy/master' into sidebar	2021-05-20 15:41:08 +03:00
Dan Balasescu	7845d07dd5	Merge pull request #12886 from peppy/fix-skin-editor-context-menu-sticking ... Fix skin editor context menus not dismissing when clicking away	2021-05-20 21:03:35 +09:00
Dan Balasescu	527847596e	Merge pull request #12884 from peppy/ternary-menu-item-refactor ... Create base implementations of the two most common `TernaryStateMenuItem`s	2021-05-20 21:02:15 +09:00
Dean Herbert	0f4b502fdf	Add missing xmldoc	2021-05-20 20:09:22 +09:00
Dean Herbert	1848bd902d	Fix skin editor context menus not dismissing when clicking away	2021-05-20 19:51:07 +09:00
Gagah Pangeran Rosfatiputra	6257504bb6	add padding spacing	2021-05-25 14:37:14 +07:00
Gagah Pangeran Rosfatiputra	ae0949fc14	add main page in wiki overlay	2021-05-25 14:20:04 +07:00
smoogipoo	e3284b976d	Merge branch 'thread-safe-spectator-client' into fix-spectator-playing-state-5	2021-05-20 19:46:26 +09:00
smoogipoo	06c99e8c7c	Fix race due to StopWatchingUser() being called asynchronously	2021-05-20 19:45:31 +09:00
smoogipoo	5a8b8782d3	Fix WatchUser being called asynchronously in BDL	2021-05-20 19:44:43 +09:00
smoogipoo	ee4bca9ed1	Handle collection changed event	2021-05-20 19:37:43 +09:00
Dean Herbert	df5970fab4	Create base implementations of the two most common TernaryStateMenuItems	2021-05-20 19:34:53 +09:00
smoogipoo	7ee81669f7	Remove bind helpers from SpectatorClient	2021-05-20 19:27:43 +09:00
smoogipoo	b515fe3cb1	Fix playing user state not removed on stop watching	2021-05-20 19:20:09 +09:00
smoogipoo	89b4f69588	Expose playing user states as bindable dictionary	2021-05-20 19:19:39 +09:00
smoogipoo	2896da499d	Merge branch 'restructure-spectator-client' into thread-safe-spectator-client	2021-05-20 18:53:54 +09:00
smoogipoo	a74405d0ed	Merge branch 'master' into restructure-spectator-client	2021-05-20 18:53:42 +09:00
smoogipoo	f74dbb9e1f	Remove locking from SpectatorScreen	2021-05-20 18:52:20 +09:00
smoogipoo	10597f7e6a	Remove locking from SpectatorClient	2021-05-20 18:37:27 +09:00
Dean Herbert	20f1ef4318	Extract common implementation of updating drawable position from screen space pos	2021-05-20 18:35:13 +09:00
Dean Herbert	6f75c59760	Fix flip logic not using the full selection quad	2021-05-20 18:31:51 +09:00
Dean Herbert	95c78b9185	Split out common selection quad logic	2021-05-20 18:24:25 +09:00
Dean Herbert	27e81d6504	Implement proper rotation algorithm for skin editor	2021-05-20 18:21:16 +09:00
smoogipoo	6eff8d513e	Annotate nullables	2021-05-20 17:51:09 +09:00
smoogipoo	9d07749959	Improve implementation of TestSpectatorClient ... There was a lot of weirdness here, such as storing the playing users, clearing the playing users from test scenes (!!), and storing the users being wathed. This was all a thing because the previous implementation overrode the base method implementations, which is no longer a thing.	2021-05-20 17:41:46 +09:00
Dean Herbert	c24712642c	Make BeatmapSetInfo.Files non-nullable	2021-05-20 17:39:52 +09:00
smoogipoo	750a5c3ea9	Fix test compilation error	2021-05-20 17:20:30 +09:00
Dean Herbert	fdbd421040	Fix editor tests failing due to empty files being specified	2021-05-20 17:09:55 +09:00
smoogipoo	df80531a0a	Split online connectivity into OnlineSpectatorClient	2021-05-20 16:30:56 +09:00
Gagah Pangeran Rosfatiputra	9c824ece1b	handle page change when clicking breadcrumb	2021-05-20 14:00:22 +07:00
Gagah Pangeran Rosfatiputra	1578b0462d	add showParentPage method	2021-05-20 13:58:17 +07:00
smoogipoo	6beeb7f7c4	Rename SpectatorStreamingClient -> SpectatorClient	2021-05-20 15:55:07 +09:00
Dean Herbert	7980bdd384	Revert incorrectly changed requery code	2021-05-20 15:41:58 +09:00
smoogipoo	d197a7f6f5	Rename multiplayer client classes	2021-05-20 15:39:45 +09:00
Dean Herbert	dbfaaecd9c	Reword comment to not mention tests driectly	2021-05-20 15:39:29 +09:00
Dean Herbert	958d51141d	Rename FrontPageDisplay to ArticleListing	2021-05-20 15:24:01 +09:00
Dean Herbert	9267d23dc2	Make year nullable rather than defaulting to zero	2021-05-20 15:23:49 +09:00
Dean Herbert	d4530313aa	Tidy event parameter naming	2021-05-20 15:15:46 +09:00
Dean Herbert	489caebf59	Move bind LoadComplete code out of constructor	2021-05-20 15:15:19 +09:00
ekrctb	0489ae719d	Don't couple PoolableDrawableWithLifetime lifetime with its entry ... It turns out the incompatibility with `LifetimeManagementContainer` causes more issues than anticipated.	2021-05-20 14:56:15 +09:00
Dean Herbert	673ca4c2a1	Tidy up content container specification	2021-05-20 14:30:40 +09:00
Dean Herbert	ac8efdeabd	Move private methods down	2021-05-20 14:12:34 +09:00
Dean Herbert	713f69ea55	Tidy up load process	2021-05-20 14:11:42 +09:00
Dean Herbert	80a714a9c4	Merge pull request #12857 from Joehuu/dev-register-no-warning ... Don't show warning screen when registering on dev server	2021-05-20 14:05:53 +09:00
Dean Herbert	8f5b28d264	Fix "folder missing" message showing incorrectly for beatmaps folder	2021-05-20 13:56:18 +09:00
Dean Herbert	3c201fb8e7	Standardise canBeNull specification	2021-05-20 13:20:35 +09:00
Joseph Madamba	3da2cdfd05	Fix nullref in test	2021-05-19 14:06:21 -07:00
Salman Ahmed	3d99b89633	Add back actually needed change ... *no comment*	2021-05-20 00:03:11 +03:00
Salman Ahmed	d8efcc0793	Remove drive-by change	2021-05-19 23:44:53 +03:00
Salman Ahmed	43094425e2	Merge branch 'legacy-beatmap-skin-hud-fallback' into catch-hide-combo-workaround	2021-05-19 23:18:27 +03:00
Salman Ahmed	9f3ea150f5	Fix legacy beatmap skins not falling back properly on HUD components	2021-05-19 23:01:29 +03:00
Bartłomiej Dach	788f1fcf48	Merge branch 'master' into disable-skin-editor-border	2021-05-19 21:52:29 +02:00
Salman Ahmed	21ca9c8431	Merge branch 'master' into beatmap-skin	2021-05-19 22:39:32 +03:00
Bartłomiej Dach	5df7d3bfd0	Merge branch 'master' into fix-editor-blueprint-wrong-beatmap	2021-05-19 20:48:10 +02:00
Bartłomiej Dach	e9cab29134	Cache editor beatmap in placement blueprint test scene	2021-05-19 20:48:06 +02:00
Gagah Pangeran Rosfatiputra	bc1cad0963	change header breadcrumb when page change	2021-05-20 00:28:26 +07:00
Dean Herbert	eb5db8ff03	Disable border display on skin editor to avoid crashes ... This wasn't being displayed correctly anyway, so rather than fixing let's just remove it for now. Closes #12868.	2021-05-20 02:01:46 +09:00
Dean Herbert	22337e0fc7	Add comment explaining why origin is flipped	2021-05-20 01:59:30 +09:00
Dean Herbert	00ed699340	Fix origin specifications using incorrect flags	2021-05-20 01:53:24 +09:00
Dean Herbert	363aec8179	Merge branch 'master' into hit-error-skinnable	2021-05-20 01:51:45 +09:00
Dean Herbert	a55879e511	Fix oversights in scale algorithm	2021-05-20 01:47:31 +09:00
Dean Herbert	14af86d6c5	Use the same code path for all scaling	2021-05-19 21:46:41 +09:00
Andrei Zavatski	d60478851f	Add proper action to YearButton	2021-05-19 15:38:53 +03:00
Andrei Zavatski	e3ed9b8135	Implement sidebar metadata handling in NewsOverlay	2021-05-19 15:36:05 +03:00
Andrei Zavatski	6cc4ffadab	Implement sticky container for sidebar in NewsOverlay	2021-05-19 15:28:12 +03:00
Andrei Zavatski	150ed01c62	Make NewsSidebar scrollable	2021-05-19 15:22:55 +03:00
Andrei Zavatski	16ffedde8a	Add year parameter to GetNewsRequest	2021-05-19 15:17:57 +03:00
Dean Herbert	6a3c58b9ad	Implement proper scaling algorithms	2021-05-19 19:58:55 +09:00
Dean Herbert	6c4709e7b4	Fix PlacementBlueprint using the wrong beatmap when applying defaults ... Closes #12855.	2021-05-19 18:34:07 +09:00
Dean Herbert	b2c736b42a	Combine and move const closer to usage	2021-05-19 18:09:46 +09:00
Salman Ahmed	825d61e22c	Separate default beatmap skins from DefaultSkin	2021-05-19 12:06:10 +03:00
Dean Herbert	a639132825	Avoid doing any re-fetch on beatmap from test scenes	2021-05-19 17:58:28 +09:00
Salman Ahmed	9806d94b74	Move beatmap skin info creation to static method at IBeatmapSkin	2021-05-19 11:58:00 +03:00
Dean Herbert	a0f67ef3bc	Move scaling logic out of OsuSelectionHandler for reuse	2021-05-19 17:37:28 +09:00
Dean Herbert	fc5987bf69	Refactor DialogOverlay logic to avoid dismissal potentially being unhandled	2021-05-19 16:52:34 +09:00
Vinicius Barbosa	4f397ae7f5	Merge branch 'master' into applause-stops-on-score-switch	2021-05-19 09:52:31 +02:00
Dean Herbert	44e22b31a9	Refactor editor exit sequence to avoid any scenario where a dialog could go stray	2021-05-19 16:51:54 +09:00
Dean Herbert	b83322281e	Consume updated logic at MainMenu	2021-05-19 16:51:54 +09:00
Dean Herbert	124ac689b8	Add method to PopupDialog to press the first OK button	2021-05-19 16:51:54 +09:00
Dean Herbert	87833bfb61	Merge pull request #12736 from EVAST9919/news-sidebar-new ... Implement NewsSideBar component	2021-05-19 16:29:52 +09:00
Dean Herbert	19a07b0107	IsOpen -> Expanded	2021-05-19 15:49:22 +09:00
Dean Herbert	539e5179fe	Tidy up content and bind event code	2021-05-19 15:49:22 +09:00
Salman Ahmed	013fe4928f	Unrevert irrelevant changes	2021-05-19 08:48:21 +03:00
Dan Balasescu	6717355fbe	Merge pull request #12627 from ekrctb/always-use-lifetime-entry ... Always use lifetime entry to manage hit objects in HitObjectContainer	2021-05-19 13:12:01 +09:00
Joseph Madamba	4cc573690e	Move OsuGame out of load method	2021-05-18 14:32:56 -07:00
Joseph Madamba	bde7f88eb3	Don't show warning screen when registering on dev server	2021-05-18 14:23:22 -07:00
timiimit	1fd00d1313	Change from fullscreen to 0.7	2021-05-18 21:52:28 +02:00
Andrei Zavatski	d70d37b7f4	Remove convoluted autosize logic in MonthSection	2021-05-18 22:30:36 +03:00
Andrei Zavatski	24af86689f	Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new	2021-05-18 22:18:52 +03:00
Vinicius Barbosa	d05ffdf120	Added constants for delay value	2021-05-18 20:19:18 +02:00
timiimit	ac5fe0c18c	Change larger freemod selection overlay	2021-05-18 18:50:42 +02:00
Vinicius Barbosa	06fffc499b	Removed unused variables and directives	2021-05-18 16:56:07 +02:00
Salman Ahmed	c98d036b48	Merge branch 'master' into catch-hide-combo-workaround	2021-05-18 17:47:20 +03:00
Salman Ahmed	e7d2f42149	Revert "Merge branch 'fix-legacy-skin-test' into catch-hide-combo-workaround" ... This reverts commit 380d004683, reversing changes made to ff419af512.	2021-05-18 17:46:15 +03:00
Vinicius Barbosa	76a377f3e0	Fixed applause sound stopping after switching scores	2021-05-18 15:30:45 +02:00
Lucas A	775e0fbde5	Mark StableImportManager as nullable.	2021-05-18 15:27:20 +02:00
Dean Herbert	41d8bc291c	Merge pull request #12783 from smoogipoo/hoc-event-queue ... Add a HitObjectUsageEventBuffer to handle HOC events appropriately	2021-05-18 22:22:53 +09:00
Dean Herbert	70b36cdc0d	Merge pull request #12850 from smoogipoo/fix-score-duplication ... Only ignore online score id for database import	2021-05-18 22:18:42 +09:00
smoogipoo	c6160d5304	Only ignore online score id for database import	2021-05-18 21:17:41 +09:00
smoogipoo	5f94b3bdac	Remove legacy playlist item ID handling	2021-05-18 21:03:59 +09:00
Dan Balasescu	ef81bdf63f	Merge branch 'master' into always-use-lifetime-entry	2021-05-18 20:10:12 +09:00
ekrctb	84a1a86c63	Revert "Use entry to calculate lifetime in ScrollingHOC" ... This reverts commit 632bb70e	2021-05-18 19:55:31 +09:00
ekrctb	2c65b8fa93	Revert "Fix uninitialized scrollLength value is used" ... This reverts commit 73dfb04d	2021-05-18 19:55:25 +09:00
smoogipoo	d93ac7ac98	Change class xmldoc a bit	2021-05-18 19:15:46 +09:00
smoogipoo	ab6a79f84c	Simplify	2021-05-18 19:15:46 +09:00
smoogipoo	97f4f7bbd1	Remove Component inheritance	2021-05-18 18:59:45 +09:00
smoogipoo	633f841a0f	Rename to HitObjectUsageEventBuffer	2021-05-18 18:57:02 +09:00
smoogipoo	bfc0205e9b	Fix (began, finished) event	2021-05-18 18:49:11 +09:00
smoogipoo	a31a6947bb	Add test	2021-05-18 18:49:05 +09:00
Salman Ahmed	08ee1e4853	Remove HUD skin component lookup in favour of MainHUDComponents target system	2021-05-18 12:37:23 +03:00
Dean Herbert	d661e98fa6	Move common functionality out of OsuSelectionHandler and implement flip support	2021-05-18 18:34:06 +09:00
Dean Herbert	c80e736712	Change SkinBlueprint to use the origin point as the selection point ... Not sure how this feels, but it makes using the same point throughout the editor possible, which I think is the correct way forward for now.	2021-05-18 18:33:06 +09:00
smoogipoo	61a41d97a4	Add some xmldocs + comments	2021-05-18 17:39:45 +09:00
Dean Herbert	ed957df162	Add simple xmldoc to TransferBlueprintFor method	2021-05-18 16:40:56 +09:00
Dean Herbert	55cc533a37	Merge branch 'master' into hoc-event-queue	2021-05-18 16:31:20 +09:00
Dean Herbert	a96603f025	Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints ... Rename hitobject blueprints and tie them to HitObjects	2021-05-18 16:30:58 +09:00
Dean Herbert	10c730b37d	Add new default locations for hit bar error displays	2021-05-18 15:50:50 +09:00
Dean Herbert	5acb708939	Remove customisation of hit error via standard settings	2021-05-18 15:50:50 +09:00
Salman Ahmed	380d004683	Merge branch 'fix-legacy-skin-test' into catch-hide-combo-workaround	2021-05-18 09:45:43 +03:00
Salman Ahmed	265a89e5cc	Fix LegacySkinPlayerTestScene overriden by default beatmap skin	2021-05-18 09:45:32 +03:00
Salman Ahmed	ff419af512	Hide the combo counter content rather than full death	2021-05-18 09:10:15 +03:00
Dean Herbert	829d326e36	Remove alignment logic completely for the time being ... This was overly complex and does not play well with the new layout customisation system. We can add it back as required.	2021-05-18 14:55:34 +09:00
smoogipoo	75c0d4d972	Merge branch 'rework-hitobject-blueprints' into hoc-event-queue	2021-05-18 14:33:52 +09:00
smoogipoo	882d54a8f8	Remove now unnecessary Apply() method	2021-05-18 14:26:26 +09:00
smoogipoo	e621cfc4ea	Add Apply() method for applying new DHOs	2021-05-18 14:14:10 +09:00
Dean Herbert	0100b88a86	Move private methods down	2021-05-18 14:12:27 +09:00
Dean Herbert	3a5b21c0f5	Update "reset all bindings" button to better match new key binding row widths	2021-05-18 13:47:39 +09:00
Dean Herbert	c71d53a0f9	Fix text and button layout	2021-05-18 13:40:26 +09:00
smoogipoo	f1f3606fd0	Fix unresolved xmldocs	2021-05-18 13:11:58 +09:00
Dan Balasescu	9d423245d8	Fix up xmldocs ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-05-18 13:02:23 +09:00
Lucas A	79740dd2d8	Merge conditionnal expression.	2021-05-17 22:01:05 +02:00
Bartłomiej Dach	0e91a00a7e	Revert to previous width spec instead of size	2021-05-17 21:18:45 +02:00
Bartłomiej Dach	ef114f2407	Simplify bindable flow in KeyBindingRow	2021-05-17 21:10:05 +02:00
Lucas A	8530b31e39	Use bitshifts for enum values instead of literal values.	2021-05-17 21:02:45 +02:00
Bartłomiej Dach	30d7768971	Remove now-redundant null check	2021-05-17 20:47:56 +02:00
Bartłomiej Dach	33fe843ba9	Move value change bindings to LoadComplete() ... Also removes a redundant one from the setter of `Current`. If the set to current comes with an associated value change, the bind-unbind flow that `BindableWithCurrent` implements will handle that change anyway.	2021-05-17 20:46:30 +02:00
Salman Ahmed	f667ea3fd0	Replace AllowDefaultHUDComponentsFallback with a temporary override at LegacyBeatmapSkin	2021-05-17 21:34:53 +03:00
Bartłomiej Dach	2bf62b86ea	Merge branch 'master' into add-overlay-link-colours	2021-05-17 20:11:27 +02:00
Lucas A	e2018f81f3	Use equality check for nullable types.	2021-05-17 19:54:21 +02:00
Bartłomiej Dach	d614a47614	Rename variable to better explain purpose	2021-05-17 18:54:17 +02:00
Bartłomiej Dach	7befcf74ff	Split value change callbacks out to separate methods	2021-05-17 18:53:09 +02:00
Lucas A	97952bc3f0	Fix backwards stable install resolution logic.	2021-05-17 18:39:04 +02:00
Lucas A	6110a847aa	Simplify import ordering logic by making beatmapImportTask non-nullable.	2021-05-17 16:30:13 +02:00
Lucas A	5ca4fd5ab4	Block overlays to prevent getting into a bad state.	2021-05-17 13:28:59 +02:00
Dan Balasescu	ea4dfd3374	Merge pull request #12842 from peppy/song-progress-skinnable ... Add layout customisation support for `SongProgress`	2021-05-17 20:15:01 +09:00
Lucas A	a38fc1a2e0	Override text header.	2021-05-17 13:04:49 +02:00
Lucas A	db255e6814	Mark StableImportManager as potentially null in tests. ... (StableImportManager is added to the DI in OsuGame and not in the OsuGameBase)	2021-05-17 12:55:59 +02:00
Lucas A	fe11426238	Disable appearance of the stable import prompt waiting for user interaction in tests, which caused them to fail.	2021-05-17 12:55:59 +02:00
Lucas A	41fafdf643	Remove now unreachable code paths.	2021-05-17 12:55:59 +02:00
Lucas A	bec06cfac7	Reword StableDirectoryLocationDialog header ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-05-17 12:55:58 +02:00
Lucas A	f60dbbfbbd	Reword import dialogs. ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2021-05-17 12:55:58 +02:00
Lucas A	e15e8068d3	Reword StableDirectoryLocationDialog. ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2021-05-17 12:55:58 +02:00
Lucas A	dabe8bd4c7	Fix code inspections and remove now unused code.	2021-05-17 12:55:58 +02:00
Lucas A	a7b740fd1d	Reword ImportFromStablePopup and display the popup regardless of whether a stable install is detected.	2021-05-17 12:55:58 +02:00
Lucas A	8ba50b1854	Bring back injected dependency incorrectly marked as unused.	2021-05-17 12:55:58 +02:00
Lucas A	481b0a0125	Add StableDirectoryLocationDialog	2021-05-17 12:55:57 +02:00
Lucas A	325a689d65	Order imports depending on beatmap imports if any is running.	2021-05-17 12:55:57 +02:00
Lucas A	851e33fd15	Hook up StableImportManager.	2021-05-17 12:55:57 +02:00
Lucas A	5d5b1e1f0e	Add StableImportManager	2021-05-17 12:55:56 +02:00
Dean Herbert	7137315fa7	Remove HitErrorDisplay container and hook up data	2021-05-17 19:46:50 +09:00
Dean Herbert	42d2711dc6	Use ShouldBeConsideredForInput instead of ReceivePositionalInputAtSubTree	2021-05-17 19:29:59 +09:00
Dean Herbert	83b4515d5c	Merge pull request #12841 from smoogipoo/skin-editor-exclude-interfaces ... Exclude interfaces from skinnable types	2021-05-17 19:11:58 +09:00
Dean Herbert	60f3e628bc	Fix song progress being interactable inside toolbox button	2021-05-17 19:05:22 +09:00
Dean Herbert	ecf70c1707	Remove unnecessary container	2021-05-17 18:55:18 +09:00
Dean Herbert	b80768b44a	Hook up seeking flow	2021-05-17 18:52:56 +09:00
Dean Herbert	0c433cda86	Update HUDOverlay logic to add automatic layout for bottom-aligned components	2021-05-17 18:52:56 +09:00
Dean Herbert	da0913ca2d	Make SongProgress a skinnable component	2021-05-17 18:52:56 +09:00
Dan Balasescu	4151f18f74	Merge pull request #12804 from peppy/fix-autoplay-load-fail-nullref ... Fix a potential nullref when starting `Player` with autoplay disabled and beatmap fails to load	2021-05-17 18:40:05 +09:00
Dean Herbert	1f3ae901ce	Expose DrawableRuleset for consupmtion by HUD components	2021-05-17 18:23:01 +09:00
smoogipoo	0d7a349500	Exclude interfaces from skinnable types	2021-05-17 18:16:09 +09:00
Andrei Zavatski	555e3e2db3	Delete NewsSideBar.cs	2021-05-17 12:02:33 +03:00
Andrei Zavatski	01090de1fd	Fix filenames does not match contained type	2021-05-17 11:55:55 +03:00
Andrei Zavatski	586c5c7365	Emulate year changes in the test scene	2021-05-17 11:36:53 +03:00
Andrei Zavatski	ab16c32bb1	Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new	2021-05-17 11:36:41 +03:00
Dan Balasescu	d75ef160e8	Merge branch 'master' into directory-select-screen	2021-05-17 17:22:03 +09:00
Andrei Zavatski	c0cfbd11dd	Add tooltip and action for PostButton in MonthSection	2021-05-17 11:20:31 +03:00
Andrei Zavatski	5059bfaef9	Use FillFlowContainer in YearsPanel	2021-05-17 11:17:02 +03:00
smoogipoo	e3b8d8ee18	Add support for overlay-coloured links	2021-05-17 16:58:54 +09:00
Andrei Zavatski	e754d2e590	Simplify YearButton	2021-05-17 10:54:45 +03:00
Andrei Zavatski	6db291fe84	Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new	2021-05-17 10:51:56 +03:00
Dean Herbert	baa4089364	Expose method to adjust header text, not whole drawable	2021-05-17 16:41:46 +09:00
Dean Herbert	abeeda5d04	Rewrite YearsPanel to not be insanely long	2021-05-17 16:24:56 +09:00
Dean Herbert	032f60819d	Rename content container	2021-05-17 16:11:46 +09:00
Dean Herbert	22561cda19	MonthDropdown -> MonthSection	2021-05-17 16:02:21 +09:00
Dean Herbert	50e2b5a327	SideBar -> Sidebar	2021-05-17 16:00:36 +09:00
Dan Balasescu	ce7c503e6e	Merge branch 'master' into playlist-unicode	2021-05-17 11:47:10 +09:00
Gagah Pangeran Rosfatiputra	f2de28814a	add and handle OpenWiki link action	2021-05-17 00:43:59 +07:00
Gagah Pangeran Rosfatiputra	463774d4f2	add ShowPage method in WikiOverlay	2021-05-19 19:12:16 +07:00
Dean Herbert	a32f1ef35a	Merge pull request #12811 from PercyDan54/hidden-code-cleanup ... Remove obsolete methods in `ModHidden` and apply few touches	2021-05-16 22:07:45 +09:00
Swords	90f00a7663	Fixes ResotreDefaultValue to use the BindableWithCurrent correctly	2021-05-16 15:01:19 +10:00
Swords	264d8b9b86	Finishing requested changes, and tidy up	2021-05-16 14:48:00 +10:00
Andrei Zavatski	3e1b1c6c3e	Improve statement readability	2021-05-15 19:14:58 +03:00
Andrei Zavatski	e479db9186	Clear transforms in PostsContainer for all children	2021-05-15 19:14:02 +03:00
Andrei Zavatski	881d82ccb6	Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new	2021-05-15 19:08:48 +03:00
Salman Ahmed	f00799cc64	Remove unused using directive ... ...damn it	2021-05-15 18:36:47 +03:00
Salman Ahmed	243c8aa585	Add test coverage	2021-05-15 18:02:38 +03:00
Salman Ahmed	4c25fe750f	Disallow beatmap skin to fall back to default HUD components ... This should become a more generalized `AllowDefaultSkinFallback` when default legacy skin fallback is supported.	2021-05-15 14:32:16 +03:00
Swords	b5e1f78c06	Merge branch 'master' into single-bind-reset-button	2021-05-15 20:29:56 +10:00
Salman Ahmed	34d1490754	Remove null conditional ... Shouldn't guard against that here.	2021-05-15 10:00:05 +03:00
Dean Herbert	dc56250a3c	Merge branch 'master' into player-loader-star-rating	2021-05-15 15:39:57 +09:00
Dean Herbert	94b7e89ac0	Merge pull request #12747 from frenzibyte/current-star-rating ... Allow changing current star difficulty of a `StarRatingDisplay`	2021-05-15 15:39:39 +09:00
Dean Herbert	bdcb1a624e	Merge pull request #12759 from Naxesss/beatmap-verifier-context ... Encapsulate check arguments in context object	2021-05-15 15:39:12 +09:00
PercyDan54	166974506e	Duplicate implementions	2021-05-15 11:55:50 +08:00
PercyDan54	6e5c4ed7c6	Revert "Remove empty override" ... This reverts commit a86a4bab91.	2021-05-15 11:45:14 +08:00
Swords	ecc260030a	Merge branch 'master' into single-bind-reset-button	2021-05-15 12:05:42 +10:00
Swords	50d5af9662	Removed unused method	2021-05-15 12:05:22 +10:00
Swords	d988194dd3	Formatting	2021-05-15 11:40:42 +10:00
Swords	d85f17159f	Formatting	2021-05-15 11:25:56 +10:00
Swords	304caf8bdf	Adding Requested changed	2021-05-15 11:24:08 +10:00
Dean Herbert	7632b8621e	Merge pull request #12805 from peppy/add-user-id-beatmap-metadata ... Add database tracking of beatmap creator `user_id`s	2021-05-15 09:03:52 +09:00
Bartłomiej Dach	7665bdfbbb	Merge branch 'master' into null-assignment-warning-enable	2021-05-15 01:08:34 +02:00
Bartłomiej Dach	69fc072429	Ignore skin component json data if deserialisation fails instead ... Crashing was not really the best thing to do there given the preceding code that already allowed a few continues in case of a missing file.	2021-05-15 01:08:11 +02:00
Bartłomiej Dach	b51d038088	Ignore possible path-related nulls ... They're all in test code anyway, so any issue there will cause a test to fail.	2021-05-15 00:09:34 +02:00
Bartłomiej Dach	fa6b5515b7	Ignore possible null from JsonConvert.DeserializeObject() ... Nothing better can be done if a `null` is indeed returned.	2021-05-15 00:09:34 +02:00
Bartłomiej Dach	5b2b701915	Ignore possible null in GetResponseString() ... A null there indicates a deserialisation error and therefore due to the catch block immediately succeeding the changed line everything will continue to work as intended.	2021-05-15 00:09:34 +02:00
Bartłomiej Dach	628e7a71ed	Ignore possible nulls in Type.GetType() calls ... They're mostly used in extensibility scenarios, so everything happens in runtime. There is no better resolution than to crash with a null reference exception.	2021-05-15 00:09:34 +02:00
Bartłomiej Dach	43c73f9583	Mark access to exception if task faulted as safe ... There are seemingly no C#-side compile-time guarantees that it is safe, but if the task's state is `Faulted` (as is checked right before), the exception cannot be null as per the documentation.	2021-05-15 00:09:34 +02:00
Bartłomiej Dach	c9facf70f9	Use conditional nullability attribute ... As it turns out, C# 8 provides an attribute that allows annotating that an `out` parameter's nullability depends on the method's return value, which is exactly what is desired here.	2021-05-15 00:09:34 +02:00
Bartłomiej Dach	aaa7c7eb05	Handle null case explicitly in SpectatorState.Equals() ... Uses the usual pattern of two `ReferenceEquals` checks against `this` and `null` before proceeding to inspect field values. Doing this causes the compiler to infer that at the point that field values are checked, `other` can no longer viably be `null`.	2021-05-14 23:58:07 +02:00
Bartłomiej Dach	044770f1a2	Locally suppress warning in SerializationReader ... `SerializationReader` is not written in a form that would support turning nullability checking on for the entire class. The biggest problem there is the inner `DynamicDeserializer` static class, whose members are initialised via an `initialize()` method, which the compiler knows nothing about. For this reason, just opt to suppress the single inspection about returning a `null` from a method with a return type of `string` (rider expects `string?`). It would have been also viable to enable nullability checking for this one method, but that's pretty much the same thing and adds no safety anyways, so just disable the warning to minimise surprise.	2021-05-14 23:29:34 +02:00
Bartłomiej Dach	94d80f091f	Merge branch 'master' into fix-deleting-skin-elements	2021-05-14 22:33:41 +02:00
Bartłomiej Dach	3d3c5028e6	Trim unnecessary array copy	2021-05-14 22:33:26 +02:00
Bartłomiej Dach	743b4fbff1	Pass correct member name to ArgumentExceptions	2021-05-14 22:16:37 +02:00
Bartłomiej Dach	876f53bf3b	Fix copy-paste oversights in xmldoc & exception messages	2021-05-14 22:15:43 +02:00
Bartłomiej Dach	8b4e6d2911	Remove no longer necessary FinishTransforms(true) call ... As the component no longer has any transition transforms applied.	2021-05-14 22:03:35 +02:00
Swords	843da30f9d	Reformatting	2021-05-15 01:52:16 +10:00
Swords	6a52622b3f	Merge branch 'single-bind-reset-button' of https://github.com/holaswords/osu into single-bind-reset-button	2021-05-15 01:31:40 +10:00
Swords	1603b92211	Reformatting	2021-05-15 01:30:54 +10:00
Swords	85174793b1	Merge branch 'master' into single-bind-reset-button	2021-05-15 01:07:32 +10:00
Swords	753bdf2083	Fixed formatting	2021-05-15 01:04:15 +10:00
Swords	0725088fde	Well it works, just pretty ugly looking.	2021-05-15 01:01:17 +10:00
PercyDan54	a86a4bab91	Remove empty override	2021-05-14 21:55:32 +08:00
PercyDan54	67dfeeb1b7	Cleanup code in ModHidden	2021-05-14 21:29:13 +08:00
Salman Ahmed	7c2fc9b412	Update usage due to nullability removal	2021-05-14 16:12:33 +03:00
Salman Ahmed	93007c1635	Merge branch 'current-star-rating' into player-loader-star-rating	2021-05-14 16:06:00 +03:00
Salman Ahmed	6cc678f497	Remove nullability and transition support from star rating display	2021-05-14 16:05:40 +03:00
Salman Ahmed	0dc3bfd0c1	Apply simple transforms to star rating display when ready if not	2021-05-14 15:55:26 +03:00
Salman Ahmed	e0728a6e19	Make BeatmapDifficultyCache.GetDifficultyAsync virtual	2021-05-14 15:52:36 +03:00
Dan Balasescu	a1d63243a4	Merge pull request #12800 from frenzibyte/online-play-oversight ... Fix online play subscreens not pushing player loaders when starting gameplay	2021-05-14 20:44:44 +09:00
Dean Herbert	f5dd18f266	Use existing LoadedBeatmapSuccessfully bool instead ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-05-14 16:53:51 +09:00
Dean Herbert	67a99c83a3	Tidy bindable changed code up	2021-05-14 16:24:52 +09:00
Dean Herbert	fcb226bd20	Add local variable for regular access to HitObjects	2021-05-14 16:23:45 +09:00
Dean Herbert	d09da02673	Fix deleting skin elements not saving out to skin ... Closes https://github.com/ppy/osu/issues/12786.	2021-05-14 16:03:22 +09:00
Dean Herbert	32ff406289	Add database tracking of beatmap creator user_ids	2021-05-14 15:40:29 +09:00
Salman Ahmed	8338f702c3	Remove not required null conditional	2021-05-14 09:32:56 +03:00
Dean Herbert	dc576c19b4	Fix a potential nullref when starting Player with autoplay enabled and beatmap fails to load	2021-05-14 15:10:02 +09:00
Dean Herbert	48672f8afd	Add very basic test logic to ensure PlayerLoader is present for playlists	2021-05-14 15:02:36 +09:00
Dean Herbert	1d4bcbaa6e	Merge pull request #12796 from peppy/update-framework ... Update framework	2021-05-14 14:43:54 +09:00
Dean Herbert	46e7d9e0ed	Randomise the values displayed in the skinning toolbox ... To stop the spam of "WYSI" comments everywhere. I guess I underestimated the negative effect this would have.	2021-05-14 12:15:58 +09:00
Dean Herbert	b36c991ba1	Fix single case of incorrect usage	2021-05-14 12:04:38 +09:00
Naxess	a447f20095	Fix formatting of #nullable enable	2021-05-14 03:38:35 +02:00
Naxess	90e0b3374e	Add #nullable enable ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2021-05-14 03:34:50 +02:00
Salman Ahmed	9e8c0a7e70	Fix online play subscreens not pushing player loaders when starting gameplay	2021-05-14 04:25:29 +03:00
Dean Herbert	ddceafb1b0	Update framework	2021-05-14 09:38:25 +09:00
Lucas A	6f248db519	Merge conditional expression.	2021-05-13 19:31:10 +02:00
Lucas A	0caba57945	Make screen properties local to MigrationSelectScreen.	2021-05-13 19:28:23 +02:00
Bartłomiej Dach	6a64a705b8	Merge branch 'master' into skin-blueprint-aspect-lock	2021-05-13 17:53:00 +02:00
Bartłomiej Dach	25b1443c50	Remove dead branch and mark implementation as temporary ... The previous implementation was checking if the `x0` or `x2` anchors were selected to decide on which way to transfer the drawable's scale, but that check actually ends up being always true for corner anchors. To visualise, this is how the corner anchors correspond to `Anchor` flags: x0 x1 x2 | | | y0 -O---O---O- | | | y1 -O---+---O- | | | y2 -O---O---O- | | | The Os indicate where the reference anchors are on a selection box. The first conditional eliminates the middle ones, which makes sense. But after excluding them from further deliberations (marking via X): x0 x1 x2 | | | y0 -O---X---O- | | | y1 -X---+---X- | | | y2 -O---X---O- | | | The remaining anchors always have `x0` or `x2` set. So to avoid confusion, just always transfer one way for now. At some point this should be torn out in favour of an actual implementation of the desired behaviour.	2021-05-13 17:50:12 +02:00
Dean Herbert	0fa90a80d4	Merge branch 'master' into skin-blueprint-aspect-lock	2021-05-13 23:38:53 +09:00
Dean Herbert	3ecbb9ec4b	Merge branch 'master' into skin-blueprint-anchor-origin	2021-05-13 23:38:04 +09:00
Dean Herbert	98830dadda	Merge pull request #12762 from peppy/skin-blueprint-visual-improvements ... Improve the visual appearance of skin editor blueprints	2021-05-13 23:37:21 +09:00
Dean Herbert	cef39eb4fa	Merge pull request #12766 from peppy/stable-anchor-origin ... Keep component positions stable when changing anchor/origin	2021-05-13 23:36:40 +09:00
Dean Herbert	caa3e1dca5	Merge pull request #12767 from peppy/save-on-forced-exit ... Save skin editor changes on forced exit	2021-05-13 23:35:52 +09:00
Lucas A	09a5b9c872	Add XMLDoc to protected members.	2021-05-13 16:28:03 +02:00
Dean Herbert	4183a1c556	Merge pull request #12769 from peppy/remove-skinnable-hud-classes ... Remove remaining test usage of SkinnableXXX HUD components	2021-05-13 22:56:18 +09:00
Dean Herbert	6c12cae105	Remove unnecessary property	2021-05-13 22:25:11 +09:00
Dean Herbert	c57a2f43fa	Merge branch 'master' into skin-blueprint-visual-improvements	2021-05-13 22:22:42 +09:00
Andrei Zavatski	38c0ba2d10	Implement current year highlight in YearsPanel	2021-05-13 16:16:19 +03:00
Dan Balasescu	63fbbc848e	Merge pull request #12778 from peppy/skin-editor-shortcut-fix ... Change default skin editor shortcut to Ctrl+Shift+S	2021-05-13 22:14:03 +09:00
smoogipoo	4cf4817ad2	Remove redundant parens	2021-05-13 22:11:58 +09:00
Dan Balasescu	d2fdd1e521	Merge branch 'master' into stable-anchor-origin	2021-05-13 22:06:21 +09:00
Andrei Zavatski	94543bf000	Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new	2021-05-13 16:00:46 +03:00
Dan Balasescu	67f795cfa6	Merge branch 'master' into save-on-forced-exit	2021-05-13 22:00:38 +09:00
smoogipoo	1e23c53507	Fix inspection	2021-05-13 21:59:38 +09:00
smoogipoo	362a09ca73	Fix up + reduce complexity of HOCEventQueue	2021-05-13 21:41:49 +09:00
smoogipoo	aaf31af326	Add blueprint transferral	2021-05-13 21:16:19 +09:00
smoogipoo	86042e1763	Implement HitObjectContainerEventQueue	2021-05-13 21:15:47 +09:00
Dan Balasescu	d5b14b6b99	Merge branch 'master' into remove-skinnable-hud-classes	2021-05-13 21:06:48 +09:00
Dan Balasescu	1b62947469	Merge branch 'master' into skin-editor-default-placement-location	2021-05-13 20:58:31 +09:00
Dan Balasescu	746862dcb1	Merge pull request #12750 from peppy/skin-serialisation ... Add skin editor saving / loading support	2021-05-13 20:58:03 +09:00
smoogipoo	ffb6135a1b	Rework hitobject blueprints to take in hitobject models	2021-05-13 19:53:32 +09:00
Dan Balasescu	3c471837f8	Merge branch 'master' into skin-serialisation	2021-05-13 19:49:55 +09:00
Dan Balasescu	a3869c02f4	Merge branch 'master' into fix-two-hovered-handles	2021-05-13 19:24:42 +09:00
Dean Herbert	b939318922	Merge branch 'skin-serialisation' into skin-editor-default-placement-location	2021-05-13 19:09:34 +09:00
Dean Herbert	e5f765d1a8	Fix broken exception message	2021-05-13 19:06:58 +09:00