h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-21 22:27:23 +08:00
Code Issues Releases Wiki Activity

Remove unnecessary bindable flow

Browse Source
This commit is contained in:
Dean Herbert 2021-05-26 22:46:43 +09:00
parent 71de541245
commit 9947867e84
1 changed files with 6 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
osu.Game/Overlays/News/Displays/ArticleListing.cs
View File

@ -3,11 +3,9 @@
using System;
using System.Collections.Generic;
using System.Collections.Specialized;
using System.Linq;
using System.Threading;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
using osu.Game.Graphics.UserInterface;
@ -23,9 +21,6 @@ namespace osu.Game.Overlays.News.Displays
{
public Action RequestMorePosts;
private readonly BindableList<APINewsPost> posts = new BindableList<APINewsPost>();
private bool showMoreButtonIsVisible;
private FillFlowContainer content;
private ShowMoreButton showMore;
@ -71,41 +66,16 @@ namespace osu.Game.Overlays.News.Displays
};
}
protected override void LoadComplete()
{
base.LoadComplete();
posts.BindCollectionChanged((sender, args) =>
{
switch (args.Action)
{
case NotifyCollectionChangedAction.Add:
addPosts(args.NewItems.Cast<APINewsPost>());
break;
default:
throw new NotSupportedException(@"You can only add items to this list. Other actions are not supported.");
}
}, true);
}
public void AddPosts(IEnumerable<APINewsPost> posts, bool showMoreButtonIsVisible)
{
this.showMoreButtonIsVisible = showMoreButtonIsVisible;
this.posts.AddRange(posts);
}
private CancellationTokenSource cancellationToken;
private void addPosts(IEnumerable<APINewsPost> posts)
{
public void AddPosts(IEnumerable<APINewsPost> posts, bool morePostsAvailable) => Schedule(() =>
LoadComponentsAsync(posts.Select(p => new NewsCard(p)).ToList(), loaded =>
{
content.AddRange(loaded);
showMore.IsLoading = false;
showMore.Alpha = showMoreButtonIsVisible ? 1 : 0;
}, (cancellationToken = new CancellationTokenSource()).Token);
}
showMore.Alpha = morePostsAvailable ? 1 : 0;
}, (cancellationToken = new CancellationTokenSource()).Token)
);
private CancellationTokenSource cancellationToken;
protected override void Dispose(bool isDisposing)
{