h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 09:43:10 +08:00
Code Issues Releases Wiki Activity

Apply comment rewording suggestion

Browse Source 
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
This commit is contained in:
ekrctb 2021-05-31 13:41:49 +09:00 committed by GitHub
parent 265dfe5416
commit 0c101d2859
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Rulesets/Objects/HitObjectLifetimeEntry.cs
View File

@ -37,8 +37,8 @@ namespace osu.Game.Rulesets.Objects
startTimeBindable.BindTo(HitObject.StartTimeBindable);
startTimeBindable.BindValueChanged(_ => setInitialLifetime(), true);
// It is important to subscribe to this event before applied to a DrawableHitObject.
// Otherwise DHO cannot overwrite LifetimeStart set in setInitialLifetime.
// Subscribe to this event before the DrawableHitObject so that the local callback is invoked before the entry is re-applied as a result of DefaultsApplied.
// This way, the DrawableHitObject can use OnApply() to overwrite the LifetimeStart that was set inside setInitialLifetime().
HitObject.DefaultsApplied += _ => setInitialLifetime();
}