h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 06:57:39 +08:00
Code Issues Releases Wiki Activity

Inline request flow to make it easier to understand

Browse Source
This commit is contained in:
Dean Herbert 2021-05-26 14:37:52 +09:00
parent 0f21510b8b
commit d165a75823
1 changed files with 29 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
osu.Game/Overlays/NewsOverlay.cs
View File

@ -21,7 +21,7 @@ namespace osu.Game.Overlays
private readonly NewsSidebar sidebar;
private readonly Container content;
private GetNewsRequest lastRequest;
private GetNewsRequest request;
private Cursor lastCursor;
@ -139,66 +139,64 @@ namespace osu.Game.Overlays
private void loadListing(int? year = null)
{
beginLoading();
Header.SetFrontPage();
displayedYear = year;
lastCursor = null;
performListingRequest(response =>
beginLoading(true);
request = new GetNewsRequest(displayedYear);
request.Success += response => Schedule(() =>
{
lastCursor = response.Cursor;
sidebar.Metadata.Value = response.SidebarMetadata;
var listing = new ArticleListing(response);
listing.RequestMorePosts += getMorePosts;
LoadDisplay(listing);
LoadDisplay(new ArticleListing(response)
{
RequestMorePosts = getMorePosts
});
});
}
private void loadArticle(string article)
{
beginLoading();
Header.SetArticle(article);
// Temporary, should be handled by ArticleDisplay later
LoadDisplay(Empty());
API.PerformAsync(request);
}
private void getMorePosts()
{
lastRequest?.Cancel();
performListingRequest(response =>
beginLoading(false);
request = new GetNewsRequest(displayedYear, lastCursor);
request.Success += response => Schedule(() =>
{
lastCursor = response.Cursor;
if (content.Child is ArticleListing listing)
listing.AddPosts(response);
});
API.PerformAsync(request);
}
private void performListingRequest(Action<GetNewsResponse> onSuccess)
private void loadArticle(string article)
{
lastRequest = new GetNewsRequest(displayedYear, lastCursor);
lastRequest.Success += response => Schedule(() =>
{
lastCursor = response.Cursor;
onSuccess?.Invoke(response);
});
// This is not yet implemented nor called from anywhere.
beginLoading(true);
API.PerformAsync(lastRequest);
Header.SetArticle(article);
LoadDisplay(Empty());
}
private void beginLoading()
private void beginLoading(bool showLoadingOverlay)
{
lastRequest?.Cancel();
request?.Cancel();
cancellationToken?.Cancel();
Loading.Show();
if (showLoadingOverlay)
Loading.Show();
}
protected override void Dispose(bool isDisposing)
{
lastRequest?.Cancel();
request?.Cancel();
cancellationToken?.Cancel();
base.Dispose(isDisposing);
}