h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-15 06:42:56 +08:00
Code Issues Releases Wiki Activity

Simplify lifetime setter

Browse Source 
Setting entry lifetime will cause `LifetimeChanged` event and `base.LifetimeStart`/`End` will be modified in the callback.
This commit is contained in:
ekrctb 2021-06-01 14:46:43 +09:00
parent 0f381f7758
commit 40949f6c1b
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
osu.Game/Rulesets/Objects/Pooling/PoolableDrawableWithLifetime.cs
View File

@ -35,11 +35,8 @@ namespace osu.Game.Rulesets.Objects.Pooling
if (Entry == null && LifetimeStart != value)
throw new InvalidOperationException($"Cannot modify lifetime of {nameof(PoolableDrawableWithLifetime<TEntry>)} when entry is not set");
if (Entry == null) return;
// Cannot write it as `base.LifetimeStart = Entry.LifetimeStart = value` because the change may be blocked (when `HitObjectLifetimeEntry.KeepAlive` is true).
Entry.LifetimeStart = value;
base.LifetimeStart = Entry.LifetimeStart;
if (Entry != null)
Entry.LifetimeStart = value;
}
}
@ -51,10 +48,8 @@ namespace osu.Game.Rulesets.Objects.Pooling
if (Entry == null && LifetimeEnd != value)
throw new InvalidOperationException($"Cannot modify lifetime of {nameof(PoolableDrawableWithLifetime<TEntry>)} when entry is not set");
if (Entry == null) return;
Entry.LifetimeEnd = value;
base.LifetimeEnd = Entry.LifetimeEnd;
if (Entry != null)
Entry.LifetimeEnd = value;
}
}