10690 Commits

Author	SHA1	Message	Date
sh0ckR6	9a1db04920	Resolve GameplayClockContainer instead of Player	2021-09-20 10:28:58 -04:00
sh0ckR6	36a20ab0b3	Resolve failed test compilation	2021-09-20 10:26:07 -04:00
sh0ckR6	10fe2382b0	Address most issues	2021-09-20 10:07:42 -04:00
Bartłomiej Dach	4e094b2127	Implement grid size toggling matching stable	2021-09-19 20:26:02 +02:00
Bartłomiej Dach	56e80a0706	Add rectangular position snap grid	2021-09-19 18:07:19 +02:00
sh0ckR6	04715a5471	Add null-check when invoking OnSeek	2021-09-18 12:20:36 -04:00
sh0ckR6	f6e279baa1	Add xmldoc to HitErrorMeter.Clear ... Explains how the method is called and what inheritors should do when implementing it.	2021-09-18 12:18:11 -04:00
sh0ckR6	12cc16c598	Remove unused property in SongProgress	2021-09-18 12:05:06 -04:00
sh0ckR6	b2b3108afa	Resolve addressed issues ... + Stopped using testing methods in non-testing classes + Resolve Player and add OnSeek event + Take bindings away from BarHitErrorMeter + Add support for ColourHitErrorMeter	2021-09-17 16:19:41 -04:00
Jamie Taylor	f868feae44	Remove unnecessary Schedule	2021-09-17 21:12:39 +09:00
Jamie Taylor	9485323a13	Add audio feedback for incorrect MP room password	2021-09-17 20:52:13 +09:00
Dan Balasescu	a591fffdbd	Merge pull request #14782 from peppy/refocus-textbox-on-failed-password ... Refocus the multiplayer password entry textbox on failed join	2021-09-17 18:59:09 +09:00
Dean Herbert	027912d4f6	Refocus the multiplayer password entry textbox on failed join	2021-09-17 18:25:25 +09:00
Dean Herbert	1c8e17cf11	Fix the default background parallax being set incorrectly when no screen is present	2021-09-17 18:14:39 +09:00
Dean Herbert	5f27f1c099	Avoid accounting for the pause pitch adjust effect when "fixing" hardware offset adjustments ... Bit of an unfortunate one. Because we are applying the pitch adjustment to the lowest level (`Track`), it's hard to filter out in parent clock calculations. Tried a few solutions but this feels the best. Note that we can't just undo the `pauseFreqAdjust` adjustment as it will div-by-zero. Closes https://github.com/ppy/osu/issues/14773.	2021-09-17 15:43:38 +09:00
Dean Herbert	f524e913e1	Move AllowTrackAdjustments specification to RoomSubScreen	2021-09-17 13:24:01 +09:00
Dean Herbert	cd4ba71a6b	Revert "Merge pull request #14772 from Joehuu/lounge-disallow-track-adj" ... This reverts commit 06ff4838fb, reversing changes made to 5453ea0ce9.	2021-09-17 13:22:39 +09:00
Joseph Madamba	55feb47e61	Disallow track adjustments on playlists / multi lounge	2021-09-16 20:17:21 -07:00
smoogipoo	e8dea0138c	Fix one more issue	2021-09-16 18:34:13 +09:00
smoogipoo	f9d5abff8a	Update with keybinding changes	2021-09-16 18:26:12 +09:00
Dean Herbert	3495fae519	Handle potential for OnResuming call without an OnSuspending first	2021-09-16 16:31:41 +09:00
Dean Herbert	b58415fe19	Make suspend stored state nullable to ensure we don't break it	2021-09-16 16:12:14 +09:00
Dean Herbert	fa693bb8a8	Move MusicController adjustment set to inside OsuScreen itself (and result nullable)	2021-09-16 16:08:09 +09:00
AbstractQbit	318f0941ca	Move all the "inherit previous AllowTrackAdjustments" logic into OsuScreen	2021-09-15 21:25:39 +03:00
Dean Herbert	931e873a7e	Merge branch 'master' into inheritable-allow-track-adjust	2021-09-15 22:26:13 +09:00
AbstractQbit	f0439ef50b	Remove unnecessary AllowTrackAdjustments overrides, add true to SongSelect	2021-09-15 13:12:57 +03:00
Dean Herbert	8acfefed1b	Merge pull request #14741 from smoogipoo/fix-lounge-beatmaps-counter ... Fix incorrect beatmap count and SR range in multi lounge	2021-09-15 18:51:52 +09:00
AbstractQbit	1181317c72	Fix issues found by code quality ci	2021-09-15 12:01:56 +03:00
smoogipoo	f54d554d30	Extract removal to method	2021-09-15 17:03:28 +09:00
AbstractQbit	48cf98ef93	Rephrase null meaning in IOsuScreen.AllowTrackAdjustments ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-09-15 11:00:49 +03:00
AbstractQbit	b87af3dd68	Move the inherited AllowTrackAdjustments into OsuScreen	2021-09-15 10:55:16 +03:00
Dean Herbert	1ba716d9f1	Merge pull request #14737 from bdach/editor-difficulty-switch-shared-state ... Preserve current time and clipboard contents when switching between difficulties	2021-09-15 12:38:56 +09:00
Bartłomiej Dach	7b9e501fa0	Merge branch 'master' into 14421-multi-password-error-handling	2021-09-14 22:58:20 +02:00
Dean Herbert	13f88cbc4e	Fix EditorClock retaining a reference to potentially outdated ControlPointInfo	2021-09-14 23:56:57 +09:00
AbstractQbit	b9193aae6d	Make IOsuScreen.AllowTrackAdjustments nullable ... Allows for inheriting value from the previous screen if undefined	2021-09-14 17:37:57 +03:00
Dean Herbert	57f8ccca16	Remove nullability from EditorState properties ... Also update the xmldoc to not be specific to difficulty switching	2021-09-14 23:36:28 +09:00
Dean Herbert	f8bdca542d	Make restoring state a public call on Editor	2021-09-14 23:36:17 +09:00
Dean Herbert	2a894e7a3f	Make EditorLoader state private	2021-09-14 23:26:02 +09:00
Dean Herbert	563bf92529	Also update the full object on sample changes to make them apply immediately	2021-09-14 19:21:23 +09:00
Dean Herbert	d825da3983	Add note about a better way to adjust velocity	2021-09-14 18:54:29 +09:00
Dean Herbert	e4dd59aee2	Add popovers to adjust SV and samples from the timeline	2021-09-14 18:51:22 +09:00
Dean Herbert	9d17f84681	Adjust timeline height to account for less global control points	2021-09-14 18:51:11 +09:00
Dean Herbert	9551e77553	Remove difficulty and sample sections from timing screen	2021-09-14 18:51:11 +09:00
Dean Herbert	87cfcf706e	Add ability to change slider velocity with shift-drag	2021-09-14 18:26:17 +09:00
Dean Herbert	b19dc5e41f	Remove all legacy ControlPoints when entering the editor	2021-09-14 18:26:16 +09:00
Dean Herbert	6015b5037a	Display difficulty and sample control points associated with hitobjects	2021-09-14 18:26:16 +09:00
smoogipoo	a775915338	Fix incorrect beatmap count and SR range in multi lounge	2021-09-14 18:20:28 +09:00
Dean Herbert	5058f28504	Remove breaking padding	2021-09-14 14:52:50 +09:00
Dean Herbert	8865e3cab8	Add back shake and tweak transform of text	2021-09-14 14:44:32 +09:00
Dean Herbert	7bd749d0eb	Remove weird shaking	2021-09-14 14:19:55 +09:00
Dean Herbert	e3c56f9ebd	Show error message in popover	2021-09-14 14:14:06 +09:00
Dean Herbert	eaac2bad3d	Fix incorrect child margin specifications	2021-09-14 13:49:02 +09:00
Bartłomiej Dach	35ee889e5b	Restore clipboard content after difficulty switch	2021-09-13 21:04:27 +02:00
Bartłomiej Dach	79d0f4835e	Add failing tests for preserving clipboard content	2021-09-13 21:03:30 +02:00
Bartłomiej Dach	3fc72271f1	Restore editor clock time after difficulty switch	2021-09-13 20:59:31 +02:00
AbstractQbit	3c75094f43	Move BarHitErrorMeter's icon reorintation to Update()	2021-09-13 19:41:55 +03:00
AbstractQbit	7267602b95	Fix icon orientation for horizontal bar hit error meter	2021-09-13 17:14:39 +03:00
Dan Balasescu	f6c4bbe2c9	Merge pull request #14730 from peppy/add-missing-track-adjustment-defaults ... Add missing screen level mod application settings for some screens	2021-09-13 15:22:22 +09:00
Dean Herbert	f9c82a9098	Merge pull request #14676 from nekodex/lobby-team-swap ... Add sound for multiplayer team swaps	2021-09-13 15:01:58 +09:00
Dean Herbert	caf7ef6519	Add missing screen level mod application settings for some screens ... Closes #7480. But based on discussion in there this solution may change.	2021-09-13 15:00:34 +09:00
Dean Herbert	7fe0eefb78	Add inline comment regarding team switch sample logic ... Feels a bit convoluted without this. Don't really have a better suggestion for now so a comment will do.	2021-09-13 14:12:19 +09:00
Dean Herbert	65fdceee79	Merge branch 'master' into editor-test-scenes-through-loader	2021-09-13 14:02:55 +09:00
sh0ckR6	447001931c	Resolve LoungeSubScreen from PasswordEntryPopover ... This is preferred over passing down the already-resolved LoungeSubScreen	2021-09-12 14:36:11 -04:00
Bartłomiej Dach	345cde251d	Add "samples match playback rate" to editor setup screen	2021-09-12 16:54:17 +02:00
Bartłomiej Dach	22fa9a303e	Expose test helper for switching between difficulties	2021-09-12 13:55:48 +02:00
Bartłomiej Dach	8357efc74f	Make EditorTestScene go through EditorLoader	2021-09-12 13:26:04 +02:00
sh0ckR6	e018071be4	Remove OnShakeFinish event	2021-09-11 19:50:41 -04:00
sh0ckR6	6cdc842452	Remove placeholder text response ... Weird UX, doesn't feel right compared to the rest of lazer	2021-09-11 17:42:49 -04:00
sh0ckR6	b8a6925175	Use already-resolved LoungeSubScreen instead of nested delegates	2021-09-11 17:41:07 -04:00
Dean Herbert	94702ee7e3	Fix triangles intro attempting to restart track after it is disposed	2021-09-10 18:23:00 +09:00
Dan Balasescu	1d9ad9478e	Merge pull request #14683 from peppy/use-decoupled-clock-triangles-intro ... Use a decoupled clock for triangles intro to avoid startup freezes on broken audio device	2021-09-10 13:15:58 +09:00
sh0ckR6	bde092f816	Clear UR bar display on seek with mouse	2021-09-09 20:08:16 -04:00
sh0ckR6	bf0150bab4	Clear UR bar display on keyboard input	2021-09-09 16:21:51 -04:00
Dean Herbert	6c18df24ec	Change how UsingThemedIntro is set to improve clarity	2021-09-09 22:04:16 +09:00
Dean Herbert	99b6f0352c	Always start decoupled clock regardless of track source	2021-09-09 22:04:00 +09:00
Dean Herbert	199f5235a3	Merge branch 'master' into fix-score-panel-list-keyboard-nav	2021-09-09 12:12:16 +09:00
Dean Herbert	ba99a808af	Use a decoupled clock for triangles intro to avoid startup freezes on broken audio device	2021-09-09 01:21:19 +09:00
Dean Herbert	6fc46792d3	Fix test regressions	2021-09-09 00:39:54 +09:00
Dean Herbert	136573982c	Add fade in and fix incorrect wrapper bounds	2021-09-08 20:52:14 +09:00
Dean Herbert	7941240a00	Revert "Load DrawableLoungRooms asynchronously" ... This reverts commit 0b55bb6913fbf05ebb8ecadfe711084d6797efe0.	2021-09-08 20:52:14 +09:00
Dean Herbert	3e41d8b32e	Reduce initial fade transforms	2021-09-08 20:52:14 +09:00
Dean Herbert	bebb9d7e67	Wrap main content of DrawableRoom	2021-09-08 20:52:14 +09:00
Dean Herbert	037b9cfb59	Load DrawableLoungRooms asynchronously	2021-09-08 20:52:14 +09:00
Jamie Taylor	217ca754ae	Add sound for team swaps	2021-09-08 13:45:05 +09:00
sh0ckR6	b1f91596a7	Give user feedback on password attempt fail ... Shake the popover Set the input box's color to red and set the placeholder text to "incorrect password"	2021-09-07 20:05:24 -04:00
sh0ckR6	b8a1ebb786	Hide Popover after failed password attempt ... Instead of throwing an error, just close the popover and let the user continue	2021-09-07 16:54:21 -04:00
Bartłomiej Dach	8cc444df5f	Fix incorrect keyboard navigation order in score panel list	2021-09-07 21:14:38 +02:00
Dean Herbert	fa62c846c5	Merge pull request #14603 from smoogipoo/score-ordering ... Fix scores not being ordered correctly on leaderboards	2021-09-07 19:18:37 +09:00
Dean Herbert	1aa95de530	Merge branch 'master' into score-ordering	2021-09-07 17:45:38 +09:00
smoogipoo	4658577b1d	Factor in total score calculation time in results screen load	2021-09-07 15:19:09 +09:00
Dean Herbert	93da531d13	Improve code around background screen handling to read better	2021-09-07 14:35:33 +09:00
Dean Herbert	9edd010b1d	Fix unnecessary background screen transition	2021-09-07 14:34:54 +09:00
Dean Herbert	7921ad4516	Add loading spinner in case load takes longer than expected	2021-09-07 14:34:47 +09:00
Dean Herbert	ddaa95a1ca	Fix pushEditor function running twice on returning to loader	2021-09-07 14:34:18 +09:00
Dean Herbert	59aa4dabfd	Improve code around background screen handling to read better	2021-09-07 14:33:58 +09:00
smoogipoo	c9325cc419	Fix results screen test scene	2021-09-07 14:15:23 +09:00
Bartłomiej Dach	5b9f37702b	Remove unnecessary delay before pushing editor from loader	2021-09-06 21:32:23 +02:00
Bartłomiej Dach	2d59008f52	Move screen management logic to EditorLoader	2021-09-06 21:30:50 +02:00
Bartłomiej Dach	bd7d6dd35d	Rename method	2021-09-06 21:27:17 +02:00
Dean Herbert	ce197b6322	Fix missing attribute text (and give slightly more space for "10.00x" cases	2021-09-06 21:40:30 +09:00
Dean Herbert	3c7a34bdbd	Move mania-specific conversion to converter	2021-09-06 21:06:13 +09:00
Dean Herbert	52b6b05883	Update terminology in timing screen for now	2021-09-06 21:06:13 +09:00
Dean Herbert	0500cd578a	Merge branch 'master' into no-more-difficulty-control-points-info	2021-09-06 21:06:12 +09:00
smoogipoo	20100b8894	Fix a few test failures	2021-09-06 20:20:52 +09:00
smoogipoo	401d38fc05	Fix possible nullref	2021-09-06 19:07:37 +09:00
Bartłomiej Dach	d6a47fd99c	Sort difficulties by ruleset and star rating in menu	2021-09-05 21:48:11 +02:00
Bartłomiej Dach	7012a1d934	Fix issues with main menu -> editor loader transition	2021-09-05 21:48:11 +02:00
Bartłomiej Dach	382269b362	Test staying on same difficulty due to unsaved changes	2021-09-05 21:48:10 +02:00
Bartłomiej Dach	c72523bc14	Add basic test for difficulty switching	2021-09-05 21:48:10 +02:00
Bartłomiej Dach	a9403b65b3	Eliminate dependency on OsuGame	2021-09-05 21:48:10 +02:00
Bartłomiej Dach	c397cc2027	Restructure proof of concept	2021-09-05 21:48:09 +02:00
Bartłomiej Dach	fe2520c599	Add intermediary screen to avoid going back to menus	2021-09-05 21:48:09 +02:00
Bartłomiej Dach	7befd030df	Minimal working example of switching difficulties	2021-09-05 21:48:09 +02:00
Bartłomiej Dach	90f0b6874f	Highlight current difficulty in switcher	2021-09-05 21:48:08 +02:00
Bartłomiej Dach	e8fb5d2e66	Add non-functional difficulty switcher to menu	2021-09-05 21:48:08 +02:00
Dean Herbert	e0ee2a5533	Change section title to read better	2021-09-05 13:34:57 +09:00
Dean Herbert	25420af078	Rename method to drop redundant ruleset suffix	2021-09-05 13:34:23 +09:00
Bartłomiej Dach	1a90fb1ef3	Fix cached property being assigned twice	2021-09-04 19:52:42 +02:00
Dean Herbert	f42131ff89	Add back editor functionality for now	2021-09-03 19:08:23 +09:00
Dean Herbert	d4e5a612ea	Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time ... This allows fetching the correct `DifficultyControlPoint` from the hitobject. Nothing more.	2021-09-03 17:11:12 +09:00
Dean Herbert	a3d9ab1e2e	Move approach rate to EffectControlPoint	2021-09-03 16:58:16 +09:00
Dean Herbert	071c56e90b	Update usages of DifficultyPointAt	2021-09-03 16:58:16 +09:00
Bartłomiej Dach	ce1912781e	Add extension point for ruleset-specific beatmap setup sections	2021-09-02 23:29:14 +02:00
Dean Herbert	7688ea7057	Merge branch 'master' into score-ordering	2021-09-02 19:19:52 +09:00
Dan Balasescu	6c649b7bbe	Merge branch 'master' into no-more-sample-control-points-info	2021-09-02 18:09:05 +09:00
Dean Herbert	f223be0760	Merge branch 'master' into score-ordering	2021-09-02 14:45:59 +09:00
Dan Balasescu	aadef41182	Merge pull request #14601 from peppy/fix-editor-setup-screen-pixel-leakage ... Fix pixels poking out of the top edge of editor setup screen	2021-09-02 14:03:37 +09:00
smoogipoo	f7c1177cc9	Fix ScorePanelList nullref when scores are added too soon	2021-09-01 20:35:06 +09:00
Dean Herbert	ef64c05af8	Merge pull request #14533 from frenzibyte/move-incompatibility-icon ... Move mod incompatibility logic to "local player" mod select overlays	2021-09-01 18:12:27 +09:00
Dean Herbert	9e21f5a59c	Rename LocalPlayer to User in mod select prefixes	2021-09-01 17:22:52 +09:00
Dean Herbert	0319177c5c	Fix pixels poking out of the top edge of editor setup screen	2021-09-01 16:46:19 +09:00
smoogipoo	88fc53200e	Refactor	2021-09-01 15:41:52 +09:00
Dean Herbert	edf29e405b	Merge pull request #14581 from bdach/setup-screen-countdown-settings ... Add countdown settings to setup screen	2021-09-01 15:35:46 +09:00
smoogipoo	2de076a74b	Merge branch 'adjust-classic-scoring' into score-ordering	2021-09-01 15:06:55 +09:00
Bartłomiej Dach	5dc938cc9f	Update tests to match expectations	2021-08-31 22:41:47 +02:00
Bartłomiej Dach	04773b51bb	Remove countdown toggle transition for now ... Tricky to get right and the design isn't final as is anyway, so leaving *something* functioning as a best-effort for now.	2021-08-31 22:41:40 +02:00
smoogipoo	fee94236de	Fix update-thread pauses	2021-08-31 21:36:31 +09:00
smoogipoo	bfcadcc4ac	Revert some changes	2021-08-31 19:18:01 +09:00
Dean Herbert	ce0d7cce2d	Merge branch 'remove-ijsonserializable' into no-more-sample-control-points-info	2021-08-31 14:40:54 +09:00
Dean Herbert	c25ab6835c	Remove IJsonSerializable interface ... Was pretty pointless and made it hard to use the custom serialisation terms arbitrarily in tests.	2021-08-31 14:39:20 +09:00
Bartłomiej Dach	ddf9d2aa6c	Add test coverage	2021-08-30 22:55:58 +02:00
Bartłomiej Dach	eec9f6d191	Add countdown settings to design section	2021-08-30 22:51:41 +02:00
Salman Ahmed	6154642075	Merge branch 'master' into local-popover-containers	2021-08-30 15:44:29 +03:00
Dan Balasescu	b95da3ca27	Merge pull request #14576 from peppy/update-framework ... Update framework	2021-08-30 21:09:58 +09:00
smoogipoo	caa797cbf4	Attempt to reorder score panel list	2021-08-30 19:58:35 +09:00
smoogipoo	e19d81c88c	Fix potential incorrect ordering	2021-08-30 19:41:44 +09:00
smoogipoo	4ebb11472d	Update Leaderboard to reorder scores based on scoring mode	2021-08-30 19:34:34 +09:00
Henry Lin	8137eee527	Reuse value to save enum name ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-08-30 18:05:47 +08:00
Henry Lin	04bf667d0d	Parse partially typed enum names in filter query	2021-08-30 17:49:18 +08:00
Dean Herbert	ccacf56dd8	Move to legacy namespace	2021-08-30 17:14:53 +09:00
Dean Herbert	7257aae7f2	Move samples to LegacyControlPointInfo	2021-08-30 17:14:53 +09:00
Dean Herbert	f64efdc4a9	Merge branch 'update-extension-usages' into update-framework	2021-08-30 16:00:09 +09:00
Dan Balasescu	7be825f470	Merge pull request #14488 from frenzibyte/multi-spectator-player-leaving ... Gray out and stop player instances who quit during multi-spectator sessions	2021-08-30 12:04:19 +09:00
Salman Ahmed	e374ef163d	Update localisable formattable extensions usages inline with framework change	2021-08-29 15:00:28 +03:00
Bartłomiej Dach	fcc3e57d5d	Move overlay colour provider up to editor screen	2021-08-28 20:05:58 +02:00
Bartłomiej Dach	e94d96f250	Add local popover container to editor screens	2021-08-28 20:05:58 +02:00
Bartłomiej Dach	7457480b50	Add local popover container to lounge subscreen	2021-08-28 20:05:58 +02:00
Salman Ahmed	378734a7f8	Separate solo spectator player and "exit on restart" logic to own class	2021-08-27 13:24:37 +03:00
Dean Herbert	2b06dacd0e	Change debounce back to using scheduler ... Should better allow for adjusting in the future, as well.	2021-08-27 18:57:19 +09:00
Dean Herbert	33aa48bcf6	Merge branch 'master' into lobby-sounds	2021-08-27 18:46:12 +09:00
Bartłomiej Dach	d71dff4340	Merge branch 'master' into skip-overlay-optimisations	2021-08-26 22:38:17 +02:00
Jamie Taylor	56baecdde4	Add missing interaction sfx to MatchTypePicker	2021-08-26 15:30:20 +09:00
Jamie Taylor	e341f471b0	Add lobby sfx for join/leave/kick/ready/unready events	2021-08-26 15:29:22 +09:00
Dean Herbert	e633b2716d	Fix regression in outro skip handling logic	2021-08-26 13:58:45 +09:00
Dean Herbert	b1a261c902	Avoid using scheduled delegates at all for skip overload input handling	2021-08-26 12:25:37 +09:00
Dean Herbert	956e3c554b	Avoid skip overlay attempting to show when it is already invalid	2021-08-26 12:25:37 +09:00
Salman Ahmed	b4d6495f99	Fix editor skin providing container not providing playable beatmap	2021-08-25 17:52:36 +03:00
Salman Ahmed	3ad0b529fb	Make EditorScreen inherit from VisibilityContainer rather than unsafe transforms	2021-08-25 17:14:52 +03:00
Salman Ahmed	196c74fce8	Gray out and remove player clock when users stop playing	2021-08-25 11:31:02 +03:00
Salman Ahmed	599145b46a	Stop clocks when removing them from sync manager	2021-08-25 11:31:02 +03:00
Dean Herbert	e1ab3434ed	Add ability to handle user join/leave/kick events in MultiplayerComposites	2021-08-25 14:37:14 +09:00
Bartłomiej Dach	e503182a8d	Merge branch 'master' into activity-on-multiplayer-screens	2021-08-24 18:50:55 +02:00
Dean Herbert	08f757a584	Merge pull request #14474 from smoogipoo/fix-multi-crash ... Fix crash when entering multiplayer gameplay	2021-08-24 16:20:18 +09:00
smoogipoo	16ddbcd208	Don't bind to RoomId where it's expected to be constant	2021-08-24 14:25:40 +09:00
Salman Ahmed	847726547a	Move mod value change callback inside wedge info text component	2021-08-24 07:53:49 +03:00
smoogipoo	de0de451fe	Refactor to remove resolved dependency	2021-08-24 13:29:19 +09:00
smoogipoo	df170afbc4	Fix multiplayer crashing when entering gameplay	2021-08-24 13:22:06 +09:00
smoogipoo	956c1cc216	Merge branch 'master' into activity-on-multiplayer-screens	2021-08-24 12:33:34 +09:00
Bartłomiej Dach	ccf337bdc2	Merge branch 'master' into editor-setup-file-selector-popovers	2021-08-23 18:28:44 +02:00
Salman Ahmed	bd42d7aada	Hide popover on file selection	2021-08-23 18:01:01 +03:00
Dean Herbert	34b51100ff	Merge pull request #14448 from bdach/basic-design-settings ... Add basic design settings to editor setup screen	2021-08-23 18:19:58 +09:00
Dean Herbert	c2c9a93e2c	Show editor file choosers in a popover rather than inline ... Supersedes and closes #14370. Closes #14367.	2021-08-23 18:12:36 +09:00
Dean Herbert	2f6b95da39	Add descriptions for the remaining settings	2021-08-23 17:41:03 +09:00
Dean Herbert	1de84e1c98	Change description to include mention of video ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2021-08-23 17:34:19 +09:00
Dean Herbert	eaa4d479ac	Merge pull request #14408 from smoogipoo/remove-current-room ... Remove the global "selected room" from online screens	2021-08-23 17:29:31 +09:00
Dean Herbert	99bb3032a5	Move gradient to be part of the background for now	2021-08-23 15:27:32 +09:00
Dean Herbert	58fb0c042b	Remove background scale altogether ... I'm not sure why this is required. Seems like something which was meant to exist to handle parallax, but that is already handled elsewhere now.	2021-08-23 14:34:27 +09:00
smoogipoo	4f3a5fbad5	Fix test failure	2021-08-23 14:29:15 +09:00
Dan Balasescu	ead1b47e0e	Merge branch 'master' into localise-beatmap-set-overlay	2021-08-23 13:22:52 +09:00
Bartłomiej Dach	2e80e2be51	Reword epilepsy warning description text	2021-08-22 21:47:37 +02:00
Bartłomiej Dach	9538a32b5e	Explicitly update beatmap info wedge on mod change ... This used to already be the case prior to b419ea7, but in a very roundabout way. Changes to the value of the star difficulty bindable - including indirect changes via the set of active mods changing - would trigger the wedge display to regenerate and load asynchronously. b419ea7 accidentally broke this by moving down the bindable retrieval to a lower level, at which point `WedgeInfoText` would only receive the set of mods selected at the time at which a given beatmap was selected, and not receive any further updates, breaking the BPM display updating in real time (as `WedgeInfoText` could not be aware that rate-changing mods were even in effect). To resolve, explicitly reload the wedge's contents on mod changes.	2021-08-22 19:16:46 +02:00
Bartłomiej Dach	e4a8f72167	Add failing test case	2021-08-22 19:16:43 +02:00
Bartłomiej Dach	9816af688e	Add basic design settings to setup screen	2021-08-22 17:43:20 +02:00
Salman Ahmed	9b1720bd6c	Merge branch 'master' into localise-beatmap-set-overlay	2021-08-22 10:53:31 +03:00
Nathan Alo	2877b43824	split multiplayer and playlist activity	2021-08-22 09:54:07 +08:00
Dean Herbert	15d443f6b7	Use the UI mouse cursor when hovering gameplay chat in an interactive state	2021-08-21 14:44:54 +09:00
smoogipoo	f85d3665d8	Cleanups	2021-08-20 21:45:24 +09:00
smoogipoo	5192ee3b57	Fix initial display in room background	2021-08-20 21:40:35 +09:00
smoogipoo	5c8ca32ea4	Simplify lounge implementation	2021-08-20 21:33:21 +09:00
smoogipoo	b1a732b9b7	Remove selectedRoom from OnlinePlayScreen	2021-08-20 21:28:48 +09:00
smoogipoo	ceb07826d7	Merge branch 'master' into remove-current-room	2021-08-20 21:10:41 +09:00
smoogipoo	9458cd5a31	Make DrawableMatchRoom background load instantly	2021-08-20 21:07:51 +09:00
smoogipoo	b190020c4b	Block lounge background screen from exiting	2021-08-20 21:02:25 +09:00
Dean Herbert	77149044a5	Allow intro screen to retrieve beatmap even if rulesets is not loaded	2021-08-20 19:43:48 +09:00
smoogipoo	d304e283e4	Don't deselect online room when joined	2021-08-20 18:14:59 +09:00
smoogipoo	c22c6f3a49	Initial room background implementation	2021-08-20 18:14:12 +09:00
smoogipoo	258ba4674c	Fix background overflows	2021-08-20 17:50:49 +09:00
smoogipoo	3d96da84e6	Set a default background	2021-08-20 17:05:46 +09:00
smoogipoo	8524937c82	Move screenstack up a level	2021-08-20 17:02:55 +09:00
smoogipoo	610a162271	Merge branch 'master' into remove-current-room	2021-08-20 16:23:36 +09:00
Dean Herbert	98357d51da	Merge pull request #14323 from minetoblend/editor-seek ... Prevent seeking before mp3 start time while editor is playing	2021-08-20 13:28:20 +09:00
Dan Balasescu	c95bf735fe	Merge branch 'master' into multiplayer-chat	2021-08-20 11:54:42 +09:00
Dean Herbert	e25592f325	Merge branch 'master' into fix-lounge-loading	2021-08-19 20:01:47 +09:00
Dean Herbert	2b0f2a6db9	Merge pull request #14355 from frenzibyte/mod-settings-difficulty-cache ... Update star difficulty bindables on mod settings change	2021-08-19 20:00:48 +09:00
Dean Herbert	b09105e5a7	Merge pull request #14381 from smoogipoo/match-subscreen-redesign ... Update layout of multiplayer room screens	2021-08-19 19:36:21 +09:00
Dean Herbert	a65cd36a5f	Move some constants to consts	2021-08-19 19:19:46 +09:00
smoogipoo	44e157447c	Initial rework of backgrounds	2021-08-19 19:10:54 +09:00
Dean Herbert	8fce5911a9	Adjust spacing and padding of footer buttons	2021-08-19 19:08:46 +09:00
Dean Herbert	16aecfe934	Start free mod selection area hidden on screen display	2021-08-19 19:02:54 +09:00
Dean Herbert	be77498044	Move chat to right column in multiplayer match screen	2021-08-19 19:02:31 +09:00
Dean Herbert	675e2e34ba	Add padding between beatmap panel and edit button	2021-08-19 19:02:05 +09:00
Dean Herbert	4afc808ffc	Remove horizontal transitions for now ... They look bad with the current toolbar implementation. We can probably add them back once the toolbar is moved to the lounge.	2021-08-19 18:29:59 +09:00
smoogipoo	023f3fb70e	Use BackgroundScreen for multiplayer backgrounds	2021-08-19 18:19:31 +09:00
smoogipoo	493f47787b	Disable condition for the time being	2021-08-19 18:18:42 +09:00
Dean Herbert	4d1582d721	Play settings hide animation if visible when exiting RoomSubScreen	2021-08-19 18:14:45 +09:00
smoogipoo	6b6d52c23b	Add dependency container to RoomSubScreen	2021-08-19 16:53:07 +09:00
smoogipoo	4d1897c6b4	Remove unnecessary resolve into ListingPollingComponent	2021-08-19 16:52:54 +09:00
smoogipoo	00be7f4cca	Make RoomsContainer/DrawableRoom not resolve via DI	2021-08-19 16:52:54 +09:00
smoogipoo	3a1154c00e	Pass room into SelectionPollingComponent	2021-08-19 16:41:21 +09:00
smoogipoo	c31af96f1d	Pass room into RoomSettingsOverlay	2021-08-19 16:41:21 +09:00
smoogipoo	1fd746524d	Remove realtime room category, fix end-date showing for realtime	2021-08-19 16:09:28 +09:00
smoogipoo	6469eaa427	Fix background not updated in room	2021-08-19 15:52:51 +09:00
Salman Ahmed	6bfae25cda	Apply 5px vertical spacing on fill flow ... Regressed, was margin { bottom = 5f } from the star rating display creation method, which I've partly inlined.	2021-08-19 08:30:29 +03:00
Dean Herbert	6d00ea3375	Allow toggling focus via binding	2021-08-19 14:19:59 +09:00
Salman Ahmed	25e6317e7f	Use animated star display in beatmap info wedge and synchronise bar	2021-08-19 07:18:02 +03:00
Salman Ahmed	102320f8ae	Merge branch 'master' into mod-settings-difficulty-cache	2021-08-19 06:35:13 +03:00
Salman Ahmed	b984780d6a	Merge branch 'master' into fix-lounge-loading	2021-08-19 06:26:15 +03:00
Salman Ahmed	0e2f3dff4d	Fix rooms scroll container not masking properly due to padding	2021-08-19 05:09:49 +03:00
Salman Ahmed	ffbe8ddfa4	Refactor lounge sub screen layout for better loading screen appearance	2021-08-19 04:23:12 +03:00
Bartłomiej Dach	07951fe18c	Merge branch 'master' into limit-match-settings-textbox	2021-08-18 21:17:16 +02:00
Davran Dilshat	43cbd10a38	change limit to be on actual usage site	2021-08-18 18:30:50 +01:00
Davran Dilshat	61675eefe0	Add length limit to match settings textboxes	2021-08-18 17:36:57 +01:00
smoogipoo	d40023bcc1	Hide border by default	2021-08-18 21:09:34 +09:00
smoogipoo	e9221f0126	Cleanup unnecessary implementation	2021-08-18 21:00:11 +09:00
smoogipoo	eadf02933a	Split lounge-specific implementation from DrawableRoom	2021-08-18 20:56:44 +09:00
smoogipoo	63af67f61b	Cleanup around footers	2021-08-18 20:25:48 +09:00
Salman Ahmed	8172ffc401	Fix lounge sub screen loading layer displaying in the background	2021-08-18 13:12:58 +03:00
Dean Herbert	1faf789f0e	Allow expanding chat using key binding even when it is hidden	2021-08-18 18:25:21 +09:00
Dean Herbert	365c1bccc6	Fix multiplayer channel being unintentionally left after gameplay session	2021-08-18 18:24:20 +09:00
Salman Ahmed	5e91ec73e3	Handle star rating range display sizing	2021-08-18 11:36:27 +03:00
Dean Herbert	2099298444	Disallow clicking on chat textbox during gameplay	2021-08-18 17:30:50 +09:00
smoogipoo	9220d17202	Adjust paddings/spacings	2021-08-18 17:28:20 +09:00
Dean Herbert	9d2664cbb1	Merge branch 'master' into star-rating-display-v2	2021-08-18 17:22:33 +09:00
smoogipoo	6dc96fdb83	Disable edit button in playlists	2021-08-18 16:56:42 +09:00
smoogipoo	87a5922f0e	Remove participants from playlists screen	2021-08-18 16:26:45 +09:00
smoogipoo	66e11fe75e	Initial integration of playlists with the new structure	2021-08-18 16:09:15 +09:00
smoogipoo	568f1fd345	Fix initial RoomId state not being handled correctly	2021-08-18 16:09:00 +09:00
smoogipoo	90a1be2e61	Move paddings up one level	2021-08-18 15:54:33 +09:00
smoogipoo	744b6749d1	Resolve room settings layout issues	2021-08-18 15:29:01 +09:00
smoogipoo	228ad98b39	Remove extra corner radius on DrawableRoom	2021-08-18 15:27:23 +09:00
smoogipoo	f3bc9c3e45	Merge branch 'master' into match-subscreen-redesign	2021-08-18 15:19:29 +09:00
smoogipoo	c5268c9a99	Simplify by reusing same room panel	2021-08-18 15:19:24 +09:00
smoogipoo	704af94d39	Add edit button to room panel	2021-08-18 15:13:10 +09:00
smoogipoo	0853554c24	Fix settings overlay not being initially visible	2021-08-18 15:11:52 +09:00
smoogipoo	c66abf85f7	Remove match header	2021-08-18 14:04:44 +09:00
Salman Ahmed	8c5d99ab21	Override CreateInstance() in osu! bindable subclasses ... Three bindables are left which don't have this overriden due to them already not having a value-only constructor and not supporting `GetBoundCopy()` properly: - `BeatmapDifficultyCache.BindableStarDifficulty`. - `TotalScoreBindable` - `TotalScoreStringBindable` I could add support for them by passing the required data to them, as they seem to be able to have that shared, but I'm hesitant to support something which was already broken and never used, not sure.	2021-08-18 04:19:58 +03:00
Dan Balasescu	eaf7bd72fc	Merge branch 'master' into multiplayer-chat	2021-08-17 20:08:01 +09:00
Dan Balasescu	d8e9845d00	Merge pull request #14360 from peppy/improve-timeline-tick-visibility ... Improve visibility of repeat ticks / drag areas on timeline	2021-08-17 20:06:49 +09:00
smoogipoo	47d4a2e97f	Make SettingsOverlay protected	2021-08-17 20:05:26 +09:00
smoogipoo	590d814881	Move RoomSettingsOverlay to RoomSubScreen	2021-08-17 18:24:04 +09:00
Dean Herbert	f16468b706	Improve visibility of repeat ticks / drag areas on timeline	2021-08-17 18:17:55 +09:00
smoogipoo	6840ec6716	Actually show the room in the sub screen	2021-08-17 17:58:24 +09:00
Dean Herbert	4a65888cfc	Merge branch 'master' into multiplayer-chat	2021-08-17 17:34:23 +09:00
Dean Herbert	ef9bfece13	Merge branch 'master' into multi-polling-request-refactor	2021-08-17 17:31:25 +09:00
Dean Herbert	3b5fc6d10f	Ensure updateLoadingLayer is run at least once	2021-08-17 17:18:23 +09:00
Dean Herbert	9eb16fa61d	Move poll allowance logic based on signalr connection inside polling component	2021-08-17 17:16:21 +09:00
smoogipoo	5d72c5911a	Rename MatchSettingsOverlay and related classes ... Because "match" is a multiplayer-only concept.	2021-08-17 17:14:28 +09:00
smoogipoo	6416e64e06	Adjust sizings and paddings	2021-08-17 17:13:25 +09:00
smoogipoo	4b198d14eb	Initial refactor of RoomSubScreen	2021-08-17 17:05:20 +09:00
Dean Herbert	a901fca54a	Merge branch 'master' into multi-polling-request-refactor	2021-08-17 16:23:46 +09:00
Dan Balasescu	b1efc6d763	Merge branch 'master' into local-user-play-info	2021-08-17 16:23:44 +09:00
Dean Herbert	6ee6a46894	Remove unnecessary public prefix in interface specification	2021-08-17 16:22:14 +09:00
Dean Herbert	124f149cb5	Add key binding to focus chat input	2021-08-17 16:17:31 +09:00
Dean Herbert	30eee363dc	Add chat display during multiplayer gameplay	2021-08-17 16:17:31 +09:00
Dean Herbert	0d283aa6a3	Expose LocalUserPlaying from Player	2021-08-17 16:16:49 +09:00
Dean Herbert	82eddeffef	Add LocalUserPlayInfo interface to convey common information about player status	2021-08-17 16:15:47 +09:00
Salman Ahmed	3a7b9bf096	Fix MatchSettingsOverlay not resetting focus on hide properly	2021-08-17 08:56:49 +03:00
smoogipoo	f4b7ee5c7f	Merge branch 'master' into hide-player-settings-overlay	2021-08-17 13:44:33 +09:00
smoogipoo	081524b6c8	Privatise setters	2021-08-17 13:44:21 +09:00
Salman Ahmed	b419ea716b	Refactor beatmap info wedge to not fully refresh on star difficulty change ... Makes it look awkward when changing difficulty via mod settings for example. Now the changes should instead only affect the displayed components which consume it directly.	2021-08-17 05:46:06 +03:00
smoogipoo	1e282432c9	Fix password in a better way	2021-08-17 09:40:25 +09:00
smoogipoo	352949069a	Move filter to LoungeSubScreen	2021-08-17 09:36:43 +09:00
smoogipoo	97d5b80834	Fix joining with incorrect password	2021-08-17 09:18:21 +09:00
smoogipoo	6320768a67	Merge branch 'master' into multi-polling-request-refactor	2021-08-17 08:44:56 +09:00
Marvin Schürz	78f9f4a230	Move time clamp to Seek/transformSeekTo methods	2021-08-16 20:39:09 +02:00
Lucas A	a0a9777109	Fix merge conflicts.	2021-08-16 14:50:00 +02:00
Lucas A	1f942d15f8	Localise scoreboard	2021-08-16 13:38:57 +02:00
Lucas A	7bebbf9f74	Mark format strings as verbatim.	2021-08-16 12:46:41 +02:00
Dean Herbert	3ad7688eaf	Merge pull request #14339 from peppy/revert-breaking-config-rename ... Revert "Rename element in OsuSettings enum"	2021-08-16 19:18:22 +09:00
Dean Herbert	1c7cbc8621	Add missing readonly keyword to new bindable	2021-08-16 17:14:13 +09:00
Dean Herbert	8555a465ac	Merge pull request #14318 from bdach/editor-colours-save ... Add support for saving edited combo colours and displaying them in composer	2021-08-16 17:07:53 +09:00
Dean Herbert	fc89f2bac4	Revert "Rename element in OsuSettings enum" ... This reverts commit c2bbe17562.	2021-08-16 16:56:48 +09:00
Dean Herbert	8d45f86bd3	Rename variable to better reflect its purpose	2021-08-16 16:48:40 +09:00
Dean Herbert	ae8a1adae8	Allow seeking via Player.Seek even if disabled	2021-08-16 16:47:57 +09:00
Dean Herbert	838bcc51b2	Avoid new bindable requirement	2021-08-16 16:27:19 +09:00
Dean Herbert	81480ac4fc	Use PlayerConfiguration to convey no-seek state	2021-08-16 16:16:02 +09:00
Salman Ahmed	7fe6f6dd14	Fix kick button action asserting and using User.User.ID rather than User.UserID	2021-08-16 09:47:23 +03:00
Salman Ahmed	79cd062784	Let TeamDisplay take the full MultiplayerRoomUser rather than the underlying User	2021-08-16 09:47:23 +03:00
smoogipoo	08d347f10b	Merge branch 'master' into multi-polling-request-refactor	2021-08-16 13:12:08 +09:00
smoogipoo	b6a2020c59	General refactorings from PR review	2021-08-16 13:09:04 +09:00
smoogipoo	81f9442471	Inline update/addRoom in usage sites	2021-08-16 13:04:06 +09:00
Salman Ahmed	554b09ac1b	Fix SkinnableTargetsContainer blocked from processing scheduled tasks	2021-08-16 06:57:45 +03:00
Dean Herbert	f0fe79b568	Remove buffered container workarounds for now	2021-08-16 11:04:21 +09:00
Dean Herbert	d35886ef19	Reduce frame buffer render scale for blurred background	2021-08-16 11:03:49 +09:00
Dean Herbert	e8e387b549	Cache buffered background to fix multiplayer lounge performance ... Consider this a request for comment. It's the cleanest solution I can come up with without dropping either the blur, or use of `ModelBackedDrawable`. Intended to resolve https://github.com/ppy/osu/issues/14276.	2021-08-16 08:04:54 +09:00
Nathan Alo	cc3468b4ab	apply suggestions ... - make `UserActivity.InGame` and derive that to `InSoloGame` and `InMultiplayerGame` - rename `SoloGame` to `InSoloGame` - rename `MultiplayerGame` to `InMultiplayerGame`	2021-08-16 06:32:33 +08:00
Bartłomiej Dach	6108451449	Retrieve separated skin instance from working beatmap for editing	2021-08-15 21:18:09 +02:00
Bartłomiej Dach	81280dfd25	Use editable skin structure in combo colour picker	2021-08-15 21:18:08 +02:00
Bartłomiej Dach	0d64da8c63	Add skin providing container responding to beatmap skin edits	2021-08-15 21:18:08 +02:00
Bartłomiej Dach	df43e758ee	Add editable beatmap skin	2021-08-15 21:18:07 +02:00
Marvin Schürz	d287db7961	Clamping seekTime to beatmap length	2021-08-15 14:48:56 +02:00
Nathan Alo	2cc096101e	trim whitespace	2021-08-15 18:56:24 +08:00
Salman Ahmed	2ddf28346a	PlayerSettingsGroups -> PlayerSettings	2021-08-14 19:58:20 +03:00
Nathan Alo	4ed06a1021	apply suggestions	2021-08-14 22:39:12 +08:00
kj415j45	c2bbe17562	Rename element in OsuSettings enum ... `ShowProgressGraph` -> `ShowDifficultyGraph`	2021-08-14 22:35:15 +08:00
Nathan Alo	a553942a7f	update InitialActivity on multiplayer Player and SongSelect	2021-08-14 13:20:36 +08:00
Dean Herbert	b8c63eb1cb	Merge branch 'master' into multiplayer-kick-support-events	2021-08-14 14:08:34 +09:00
Dean Herbert	a10ba17b64	Merge pull request #14250 from peppy/leaderboard-limit-player-count ... Add ability for gameplay leaderboard scroll when too many users are displayed	2021-08-14 14:08:18 +09:00
Bartłomiej Dach	e2cc96097f	Unify match score display formatting ... Commas are already applied on the multiplayer leaderboard, as well as the results screen.	2021-08-13 23:57:51 +02:00
Bartłomiej Dach	00317c0e30	Round when totalling up team scores instead of truncating ... Matches score handling in `ScoreManager`.	2021-08-13 23:44:07 +02:00
Bartłomiej Dach	8f3fedade3	Merge branch 'master' into multiplayer-team-vs-results	2021-08-13 21:30:44 +02:00
smoogipoo	0e66a05963	Hide left border of beatmap wedge	2021-08-13 22:29:22 +09:00
smoogipoo	1c0ffd4621	Merge branch 'master' into multi-polling-request-refactor	2021-08-13 22:24:01 +09:00
smoogipoo	155e9e16a5	Refactorings	2021-08-13 22:09:47 +09:00
smoogipoo	d57508853e	Merge branch 'master' into multi-polling-request-refactor	2021-08-13 22:04:31 +09:00
smoogipoo	44b3e3bfac	Merge branch 'master' into fix-playlists-cross-ruleset-entry	2021-08-13 21:58:15 +09:00
smoogipoo	c71a581106	Fix exception when leaving match	2021-08-13 18:24:19 +09:00
smoogipoo	1f992e67f3	Fix listing polling rate when entering room	2021-08-13 18:17:25 +09:00
smoogipoo	1bae7173d3	Fix initial multiplayer poll	2021-08-13 18:14:02 +09:00
smoogipoo	6a46105b5e	Fix incorrect dependency	2021-08-13 18:12:32 +09:00
smoogipoo	83935540ca	Add selection polling component to PlaylistsRoomSubScreen	2021-08-13 18:11:52 +09:00
Dan Balasescu	62970108df	Merge pull request #14269 from peppy/remove-unnecessary-delimiters ... Fix searches at song select with '!' or ',' not matching as expected	2021-08-13 18:00:11 +09:00
smoogipoo	7cbf4c48ed	Fix multiplayer polling when not connected	2021-08-13 17:59:18 +09:00
smoogipoo	8910781bcd	Move listing polling component to LoungeSubScreen	2021-08-13 17:39:09 +09:00
Dean Herbert	5a60b39643	Remove unnecessary delimiters from song select filter splitting	2021-08-13 16:42:58 +09:00
Dean Herbert	db52549152	Move below everything rather than proxying (works better with new design)	2021-08-13 16:20:53 +09:00
Dean Herbert	6a95fa0278	Merge branch 'master' into fix-loading-screen-depth	2021-08-13 16:20:38 +09:00
Dean Herbert	df24f7a81e	Merge pull request #14256 from smoogipoo/multiplayer-header-redesign ... Update multiplayer header to the latest designs	2021-08-13 16:16:25 +09:00
Dean Herbert	f9f3339885	Fix vertical offset not being handled correctly during score panel detach process	2021-08-13 16:14:23 +09:00
Dan Balasescu	f47f2b43b0	Merge branch 'master' into fix-loading-screen-depth	2021-08-13 16:09:00 +09:00
Dean Herbert	732dcd30c7	Merge branch 'master' into multiplayer-team-vs-results	2021-08-13 16:03:10 +09:00
Dean Herbert	dd7ca4b77b	Increase "create room" button height	2021-08-13 15:35:45 +09:00
Dean Herbert	3b6a8a2bae	Rename background sprite and reduce load delay	2021-08-13 15:25:00 +09:00
Dean Herbert	5cec50bdd1	Add comment mentioning why event bindings are not unbound	2021-08-13 15:24:43 +09:00
Dean Herbert	bf024fbd21	Merge branch 'master' into fix-playlists-cross-ruleset-entry	2021-08-13 15:06:37 +09:00
Dean Herbert	90755c0307	Replace condition with matching precalculated bool	2021-08-13 14:50:59 +09:00
Dean Herbert	93574acf72	Fix exception messaging	2021-08-13 14:46:57 +09:00
Dean Herbert	641d57e5e1	Change scroll container subclass name to hopefully read better	2021-08-13 14:46:28 +09:00
Dean Herbert	a1b72e7f97	Remove redundant array type specification	2021-08-13 14:41:07 +09:00
Dean Herbert	b9721f5261	Centralise screen exit logic and guard against non-current screen	2021-08-13 14:39:03 +09:00
Dean Herbert	0f45155b8e	Fix remaining cases of invalid bindable operations during lease	2021-08-13 14:29:28 +09:00
Dean Herbert	92d4c9224a	Merge branch 'master' into fix-playlists-cross-ruleset-entry	2021-08-13 14:28:14 +09:00
Dean Herbert	89eded457c	Fix weird margins on loading display in lounge	2021-08-13 14:27:28 +09:00
smoogipoo	755b6460b6	Fix multiplayer navigation test failure	2021-08-13 14:05:44 +09:00
Salman Ahmed	34c2b317e2	Hide song progress bar on multi-spectator player	2021-08-13 07:30:09 +03:00
Salman Ahmed	e7cf6b2d23	Expire hold-to-quit button on multi-spectator player	2021-08-13 07:29:55 +03:00
Salman Ahmed	8dc7a925e7	Expire instead of hiding and disabling visibility state ... Since it's a temporary change until the spectator interface gets improved, no need to add further logic.	2021-08-13 07:28:59 +03:00
smoogipoo	e913c8f92f	Change strings to verbatim	2021-08-13 13:07:02 +09:00
Salman Ahmed	c10320f239	Hide and disable player settings overlay on multi-spectator player	2021-08-13 06:35:16 +03:00
Salman Ahmed	2b86416cb2	Hide player settings overlay on multi-spectator player loader	2021-08-13 06:35:16 +03:00
Bartłomiej Dach	70005cb39d	Merge branch 'master' into multiplayer-team-vs-results	2021-08-12 20:39:48 +02:00
Bartłomiej Dach	53b4cdfb02	Handle ties in team vs. results screen	2021-08-12 20:38:24 +02:00
Bartłomiej Dach	f06f13215b	Split off multiplayer team results screen to separate class ... The previous version tried to keep both normal multiplayer and team multiplayer results as one screen, but didn't check that team-specific components aren't null in `LoadComplete()`. To decrease number of conditional, split off the team results screen to a separate implementation, and choose one or the other at push time in `MultiplayerPlayer`, depending on team count.	2021-08-12 20:01:31 +02:00
Bartłomiej Dach	828268ad4d	Add winner text background to increase contrast	2021-08-12 19:34:25 +02:00
Bartłomiej Dach	4d26bb6714	Scale score panel to remove overlap with team score display	2021-08-12 19:27:32 +02:00
Dean Herbert	8249ce7988	Merge branch 'master' into multiplayer-header-redesign	2021-08-12 21:00:46 +09:00
smoogipoo	03351cf434	Add blur to background	2021-08-12 20:01:53 +09:00
smoogipoo	050f2d6b0d	Add background to room subscreen	2021-08-12 19:51:03 +09:00
smoogipoo	047b37788b	Merge online play filter control with the lounge subscreen	2021-08-12 19:48:15 +09:00
Dean Herbert	e89aea1fc2	Add some padding between scroll bar and content	2021-08-12 19:47:26 +09:00
Dean Herbert	10195e0c53	Add total user count	2021-08-12 19:47:26 +09:00
Dean Herbert	7b66616dc4	Simplify logic and test/fix edge case	2021-08-12 19:47:26 +09:00
Dean Herbert	8a67304b9f	Fix recent participants hidden user logic not handling edge case correctly ... Hiding just one user never makes sense, so this will now always show up to the required circle count until two users are required to be hidden. This will make the listing more consistent with the width requirement spec.	2021-08-12 19:47:26 +09:00
Dean Herbert	127fd4d292	Match font weight of design for hidden user count	2021-08-12 19:47:26 +09:00
Dean Herbert	2c07b68f6f	Fix incorrect colour for hidden user display	2021-08-12 19:47:26 +09:00
Dean Herbert	512382987e	Add colour provider for multiplayer usage	2021-08-12 19:47:26 +09:00
smoogipoo	ab7bd1df9d	Use full-screen background	2021-08-12 19:27:06 +09:00
smoogipoo	b75c20fee4	Adjust positioning and paddings	2021-08-12 18:02:00 +09:00
smoogipoo	3b7aa262d5	Make header overlap content	2021-08-12 16:52:35 +09:00
smoogipoo	d07bb10d02	Remove breadcrumbs from header	2021-08-12 16:52:30 +09:00
Dean Herbert	ab1cc6ad48	Fix padding around recent participants icon being uneven	2021-08-12 16:50:09 +09:00
Dean Herbert	5f3ceaf0ad	Merge branch 'master' into lounge-redesign	2021-08-12 16:31:14 +09:00
Dean Herbert	e84224f64c	Rename AddPlayer method now that there's no conflict	2021-08-12 16:20:37 +09:00
Dean Herbert	68dbbc17e8	Add support for automatic scrolling in gameplay leaderboard	2021-08-12 16:20:37 +09:00
Dean Herbert	4d6101f4e5	Lease selected room while in match screen to avoid lounge potentially changing it	2021-08-12 14:56:58 +09:00
Dan Balasescu	88f70e7f29	Merge branch 'master' into multiplayer-kick-support-events	2021-08-12 12:12:06 +09:00
Dan Balasescu	60e988aac3	Merge branch 'master' into multiplayer-kick-support	2021-08-12 11:46:56 +09:00
smoogipoo	543482111b	Remove outdated todo	2021-08-12 10:40:14 +09:00
smoogipoo	bbb28d1b29	Don't use null-propagation for status	2021-08-12 09:14:46 +09:00
smoogipoo	58d76e9036	Use FinishTransforms()	2021-08-12 09:13:10 +09:00
Dean Herbert	31608a1bc6	Leave the match screen when kicked	2021-08-11 19:57:10 +09:00
smoogipoo	4002a1606e	Round star ratings before comparing	2021-08-11 18:20:39 +09:00
smoogipoo	eb59f3c591	Revert "Buffer the entire star rating range to fix overlapping alpha" ... This reverts commit c680012523.	2021-08-11 18:15:53 +09:00
smoogipoo	0f5bea235c	Merge branch 'master' into lounge-redesign	2021-08-11 18:15:34 +09:00
Dean Herbert	d6352637d6	Also add tooltip and context menu item	2021-08-11 17:45:34 +09:00
Dean Herbert	bb51ebd0ef	Don't show button on self	2021-08-11 17:42:46 +09:00
Dean Herbert	7aab8c32ec	Add kick button and hook up logic	2021-08-11 17:31:54 +09:00
Dean Herbert	3f067e3a8d	Remove likely unnecessary score null check	2021-08-11 16:59:42 +09:00
Dean Herbert	a223f111cb	Move text to avoid overlapping the results panel	2021-08-11 15:50:01 +09:00
Dean Herbert	430a0e496c	Add winner text	2021-08-11 15:32:14 +09:00
Dean Herbert	c376e652a4	Convey and show team scores at the multiplayer results screen	2021-08-11 15:32:14 +09:00
Dean Herbert	735c5085dd	Fix match score display not doing an initial value update	2021-08-11 14:50:47 +09:00
Dean Herbert	ee3b373e8a	Correctly handle tied scores	2021-08-11 14:48:37 +09:00
Dean Herbert	cf82bca09c	Change logic to only handle the case of exactly two teams	2021-08-11 14:44:13 +09:00
Dean Herbert	a503274e1d	Pass through MultiplayerRoomUsers instead of ints to avoid re-retrieval	2021-08-10 18:39:20 +09:00
Dean Herbert	58714dbe71	Fix ordering of teams to match colours	2021-08-09 19:48:53 +09:00
Dean Herbert	490f9e1848	Fix overlap in spectator view	2021-08-09 19:45:16 +09:00
Dean Herbert	ea6e441dec	Simplify method of marking players as playing in test scenes	2021-08-09 19:21:22 +09:00
Dean Herbert	551929cf5a	Simplify method of marking players as playing in test scenes	2021-08-09 19:18:13 +09:00
Dean Herbert	5f3d087101	Also add team score display to multiplayer spectator screen	2021-08-09 19:17:51 +09:00
Dean Herbert	121648b593	Add gameplay-specific team score display which can expand and contract	2021-08-09 19:17:51 +09:00
Dean Herbert	ebbf6467e8	Support more than two teams	2021-08-09 17:23:02 +09:00
Dean Herbert	cdc173e867	Add tracking of team totals to leaderboard implementation	2021-08-09 17:08:32 +09:00
Dean Herbert	77c9aadd05	Add team colour support to multiplaye gameplay leaderboard panels	2021-08-09 17:06:25 +09:00
Dean Herbert	e1d4eee1d2	Add the ability to set custom overriding colours on GameplayLeaderboardScores	2021-08-09 17:06:21 +09:00
Dean Herbert	0fa1f085df	Store MultiplayerRoomUser as part of tracked data	2021-08-09 16:31:18 +09:00
Dean Herbert	fcec714b4f	Add safeties to avoid MultiplayerPlayer crashing when beatmap can't be loaded	2021-08-09 16:31:18 +09:00
Dean Herbert	aa4c6b9341	Bring across tournament score display for game usage	2021-08-09 16:30:37 +09:00
Dean Herbert	f4739d0118	Remove MaskingSmoothness to avoid making sheered container blurry	2021-08-09 16:28:43 +09:00
Dean Herbert	0b76460043	Merge branch 'master' into lounge-redesign	2021-08-09 16:28:28 +09:00
Dean Herbert	a12f6b78a4	Split status retrieval into its own method	2021-08-09 16:21:12 +09:00
Dean Herbert	7cb743a734	Move font sizing to base class	2021-08-09 16:17:51 +09:00
Lucas A	5e0f9d0af9	Localise user ratings.	2021-08-08 22:00:12 +02:00
Jamie Taylor	5031b19b42	Add sounds to multiplayer games list	2021-08-06 23:39:42 +09:00
Salman Ahmed	b01893d3f2	Merge branch 'master' into star-rating-display-v2	2021-08-06 13:51:34 +03:00
Dan Balasescu	8f014650df	Merge branch 'master' into toggle-multiplayer-leaderboard-with-hud	2021-08-06 19:36:19 +09:00
Dean Herbert	724edcbecd	Toggle the expanded state of the multiplayer leaderboard with the user's HUD ... Resolves https://github.com/ppy/osu/discussions/14140. --- Until now, the multiplayer leaderboard would expand during break time. Now, it respects the user's HUD visibility status (which can be toggled using Shift+Tab).	2021-08-06 19:23:44 +09:00
smoogipoo	c680012523	Buffer the entire star rating range to fix overlapping alpha	2021-08-06 19:06:16 +09:00
smoogipoo	19ed24a06f	Remove unnecessary duplicate background	2021-08-06 18:59:19 +09:00
Dean Herbert	b401dc0b2e	Remove playlist button	2021-08-06 18:58:50 +09:00
smoogipoo	9019e0947a	Remove unused using	2021-08-06 18:54:02 +09:00
smoogipoo	798b16fc24	Remove unused params	2021-08-06 18:52:46 +09:00
smoogipoo	bdfdd00afe	Adjust spacings and sizings of left-side details	2021-08-06 18:52:01 +09:00
Dean Herbert	6164903fec	Merge branch 'master' into new-difficulty-colours	2021-08-06 18:05:53 +09:00
smoogipoo	74bffeac5e	Minor design adustments (paddings/sizing)	2021-08-06 17:03:44 +09:00
smoogipoo	0ea982c036	Update recent participants list to use participant_count	2021-08-05 22:49:41 +09:00
smoogipoo	fd6d488657	Add thousands separator to rank range pill	2021-08-05 21:40:09 +09:00
smoogipoo	c74e620ce9	Add constant for background colour	2021-08-05 21:39:51 +09:00
smoogipoo	87fd1eaf06	Explain negative padding	2021-08-05 21:19:23 +09:00
smoogipoo	438f0ce702	Increase default number of avatars	2021-08-05 21:18:30 +09:00
smoogipoo	2f2e3d7366	Use higher res background image	2021-08-05 21:01:21 +09:00
smoogipoo	b8ec1cb984	Hide star rating max display for equal difficulties	2021-08-05 21:00:28 +09:00
smoogipoo	bd394d9377	Fix pluralisation	2021-08-05 20:56:23 +09:00
smoogipoo	5521f38cfb	Adjust spacing	2021-08-05 20:56:09 +09:00
smoogipoo	0246e6f850	Merge branch 'master' into lounge-redesign	2021-08-05 19:55:15 +09:00
Dan Balasescu	0211521a97	Merge branch 'master' into multiplayer-create-with-enter	2021-08-05 17:07:03 +09:00
Dan Balasescu	5811dff853	Merge pull request #14120 from peppy/multiplayer-team-vs-team-selection ... Add ability to choose Team Versus match type and view / switch teams	2021-08-05 17:02:14 +09:00
Dean Herbert	2b973b9831	Redirect beatmap selection to intentionally click the button directly	2021-08-05 14:21:51 +09:00
Dean Herbert	bf720f7e06	Ensure operations are not performed during loading	2021-08-05 14:14:07 +09:00
Dean Herbert	22bd6c7556	Move keyboard progress flow handling to MatchSettingsOverlay	2021-08-05 14:06:58 +09:00
Dean Herbert	fd54487186	Add safety against pushing to non-current screen	2021-08-05 14:06:58 +09:00
Dean Herbert	2ccf7e75b0	Fix new possible nullref inspection due to delegate initialisation in constructor	2021-08-05 13:24:59 +09:00
Dean Herbert	c84bd2c74d	Update new obsolete usages	2021-08-05 13:22:59 +09:00
Salman Ahmed	b2332eb5b3	Use new difficulty colours permanently	2021-08-04 18:19:37 +03:00
Salman Ahmed	d4399f10f9	Merge both variants of the star rating display	2021-08-04 18:19:28 +03:00
Salman Ahmed	d0ce0cf9f5	Merge branch 'master' into new-difficulty-colours	2021-08-04 17:12:15 +03:00
smoogipoo	3b6771ca65	Remove todo	2021-08-04 22:09:03 +09:00
smoogipoo	fbf89493ad	Merge branch 'master' into lounge-redesign	2021-08-04 19:53:55 +09:00
Dean Herbert	476442d1a3	Merge branch 'master' into multiplayer-create-with-enter	2021-08-04 19:37:41 +09:00
Dan Balasescu	5a6636ae5c	Merge pull request #14116 from peppy/update-platform-action-triggers ... Update existing test to make use of `ManualInputManager.Keys`	2021-08-04 19:36:39 +09:00
Dean Herbert	42e14fb492	Merge branch 'update-platform-action-triggers' into multiplayer-create-with-enter	2021-08-04 17:31:38 +09:00
Dean Herbert	9b9dacf3fe	Update usages of Drawable.Click()	2021-08-04 17:30:33 +09:00
smoogipoo	c06fffb56a	Increase background image resolution	2021-08-04 13:49:13 +09:00
Salman Ahmed	b5970d5cdc	Handle pitch black background case	2021-08-04 01:52:48 +03:00
Dean Herbert	aa320c70a7	Improve show/hide animation and add more padding around the crown	2021-08-03 23:42:37 +09:00
Dean Herbert	b8e878ccc9	Add the ability to change team by clicking current team colour ... Definitely not the final UX, but it's what people are used to and easy to implement, so it'll do for now.	2021-08-03 23:42:37 +09:00
Dean Herbert	5e59b1325c	Add team display to participant list	2021-08-03 23:42:37 +09:00
Dean Herbert	b956d32587	Add the ability to change multiplayer game type	2021-08-03 23:42:37 +09:00
Dean Herbert	c856611f65	Merge branch 'master' into multiplayer-match-rulesets	2021-08-03 23:40:24 +09:00
Salman Ahmed	9a5e052dc0	Use star difficulty colour spectrum game-wide	2021-08-03 15:02:18 +03:00
smoogipoo	50f6632051	Fix duplicate RoomManager	2021-08-03 20:38:50 +09:00
smoogipoo	1b6b7ce343	Merge branch 'master' into lounge-redesign	2021-08-03 20:02:31 +09:00
Dean Herbert	063868713e	Add ability to create a room using only keyboard input	2021-08-03 19:11:10 +09:00
Dean Herbert	feadfbcca7	Add playlist type to picker temporarily	2021-08-03 17:48:20 +09:00
Dean Herbert	01f15bd6fc	Rename picker class to match new naming	2021-08-03 17:47:53 +09:00
Dean Herbert	a42762e351	Merge branch 'multiplayer-rename-game-type' into multiplayer-match-rulesets	2021-08-03 14:55:51 +09:00
Dean Herbert	2564c0c3df	Rename GameType to MatchType and make enum instead of class	2021-08-03 14:46:31 +09:00
Dean Herbert	867426441e	Fix weird access to room via Client	2021-08-02 18:50:22 +09:00
Salman Ahmed	a75da82986	Add explaining comment	2021-08-01 21:14:54 +03:00
Salman Ahmed	ac930b8918	Fix judgement processors provided to mods while not completely loaded	2021-08-01 19:16:30 +03:00
Dean Herbert	48b95ae250	Merge pull request #14067 from nekodex/select-sfx-changes ... Swap 'select' sample variants and add hover+select sounds to more components	2021-07-31 20:03:08 +09:00
Dean Herbert	081dafc4e4	Update existing inline usages to use new extension method	2021-07-31 16:46:02 +09:00
Jamie Taylor	c1d8a7e2ad	Add and use 'Submit' select sample variant for particular components	2021-07-30 21:35:28 +09:00
Jamie Taylor	be3c02ff7f	Remove 'Soft' select sample variant usage (soft is the new default)	2021-07-30 21:35:27 +09:00
Joseph Madamba	451c65a2c8	Fix song progress graph not being correctly hidden	2021-07-29 23:41:01 -07:00
Bartłomiej Dach	0691c0dd63	Switch Colour{Display,Palette} to use Colour4	2021-07-29 23:14:32 +02:00
Henry Lin	89e8296eb1	Reset all types of adjustments in MusicController; Rename AllowRateAdjustments to AllowTrackAdjustments	2021-07-29 15:39:26 +08:00
Bartłomiej Dach	239b38a0ab	Reduce implicit conversions by using default	2021-07-27 21:46:29 +02:00
Lucas A	94877117b9	Apply changes in-line with framework changes.	2021-07-27 18:22:47 +02:00
Dan Balasescu	488dd3ea52	Merge pull request #13980 from peppy/fix-online-song-select-background ... Fix song select background not showing in multiplayer/playlists	2021-07-26 15:16:39 +09:00
Dean Herbert	3770193ede	Fix keyboard navigation at multiplayer lounge not iterating in correct order	2021-07-26 13:49:09 +09:00
Salman Ahmed	749d7a7b24	Fix DrawableRoom swallowing mouse down events before reaching its container	2021-07-26 04:41:47 +03:00
Dan Balasescu	ce30bd8cc7	Merge pull request #14003 from Game4all/localise-profile-overlay-header-stats ... Localise profile overlay numeric statistics	2021-07-25 12:20:38 +09:00
Lucas A	ff3d38de6f	Localise accuracy display.	2021-07-23 22:37:08 +02:00
Dean Herbert	50a2abbe7f	Merge pull request #12683 from frenzibyte/legacy-beatmap-combo-offset ... Apply combo offsets "colour hax" only on beatmap skins	2021-07-23 14:30:18 +09:00
Salman Ahmed	7bc30b46ff	Use BindValueChanged with last running immediately instead	2021-07-23 07:51:58 +03:00
Salman Ahmed	ee3791ccf2	Update colours once on TimelineHitObjectBlueprint	2021-07-23 06:25:56 +03:00
Dean Herbert	a5736085a9	Ensure externally run operations on LoungeSubScreen are run after load is completed	2021-07-23 02:23:37 +09:00
Salman Ahmed	523c154f15	Add ComboIndexWithOffsetsBindable and bind similar to ComboIndexBindable	2021-07-22 16:40:33 +03:00
Dean Herbert	29ffae4025	Merge pull request #13967 from nekodex/new-select-sounds ... Add new 'soft' select sound variant and use it in some places	2021-07-22 16:21:03 +09:00
Dean Herbert	8b1202153a	Merge pull request #13951 from LumpBloom7/timeline-object-interactions ... Make timeline blueprints outside of TimelineBlueprint boundaries interactable	2021-07-22 16:20:22 +09:00
Dean Herbert	957a0686ed	Split out nested classes from TimelineBlueprintContainer ... They got too big.	2021-07-22 15:48:08 +09:00
Dean Herbert	b5cc9010de	Move resolved property to top of class	2021-07-22 15:39:01 +09:00
Dean Herbert	ec3ce57bb9	Fix song select background not showing in multiplayer/playlists ... The screen was now being loaded against incorrect dependencies. I'm not sure why I thought it wasn't possible to just do the `Push` in `LoadComplete` as it seems to work without issue this time... Closes #13974.	2021-07-22 14:33:08 +09:00
Henry Lin	aab7678a69	Truncate beatmap text	2021-07-22 12:18:37 +08:00
Jamie Taylor	507b53dc73	Use 'Soft' hover/select samples for EditorTable row selection	2021-07-21 22:02:40 +09:00
Derrick Timmermans	9d43ca122f	Allow context menus to be triggered as well	2021-07-21 12:04:09 +02:00
Dan Balasescu	4c63e8e036	Merge pull request #13964 from peppy/fix-mod-overflow ... Fix mod display overflowing on contracted results panels	2021-07-21 18:52:00 +09:00
Derrick Timmermans	f85ff40a6b	Add back LeftMouse button check	2021-07-21 11:47:21 +02:00
Dean Herbert	adda96ac86	Merge pull request #13962 from ekrctb/platform-action ... Adapt to framework `PlatformAction` type change	2021-07-21 18:17:38 +09:00
Dean Herbert	a261f1ef8f	Merge pull request #13960 from ekrctb/selection-box-can-flip ... Allow specifying different value of scaling and flipping support for a selection box	2021-07-21 18:05:18 +09:00
Dan Balasescu	b390018e64	Merge branch 'master' into fix-mod-overflow	2021-07-21 17:26:47 +09:00
Dan Balasescu	b556d6d382	Merge pull request #13963 from peppy/tidy-mod-display ... Tidy up `ModDisplay`	2021-07-21 17:26:39 +09:00
Dean Herbert	b910c21230	Add ModFlowDisplay and consume in ContractedPanelMiddleContent	2021-07-21 16:53:04 +09:00
Dean Herbert	5bee06fd5f	Remove forgotten AutoSize specification	2021-07-21 16:43:29 +09:00
Dean Herbert	396ad79d50	Remove unnecessary UnbindAll call	2021-07-21 16:43:08 +09:00
Dean Herbert	a63065dbe9	Tidy up ModDisplay	2021-07-21 16:38:25 +09:00
ekrctb	1bac471b49	Adapt to PlatformAction type change	2021-07-21 16:12:53 +09:00
ekrctb	1bff4373b3	Allow specifying flipping support of selection box different from scaling	2021-07-21 15:59:45 +09:00
Dan Balasescu	3121836741	Merge pull request #13942 from peppy/fix-autoplay-results-timestamp ... Avoid showing time of play on results screen when autoplay	2021-07-21 15:37:31 +09:00
Bartłomiej Dach	db9cf443c7	Allow confirming room password by pressing Enter	2021-07-21 00:04:51 +02:00
Derrick Timmermans	a8cf6a6854	Fix slight Y position offset in HandleDrag	2021-07-20 23:00:58 +02:00
Derrick Timmermans	bfec87b082	Let TimelineBlueprintContainer only accept positional input within timeline quad	2021-07-20 22:30:50 +02:00
Derrick Timmermans	8b09ddbcd6	Merge branch 'ppy:master' into timeline-object-interactions	2021-07-20 16:36:39 +02:00
Dan Balasescu	738d321788	Merge pull request #13946 from peppy/fix-online-play-sub-screens-not-async-loaded ... Fix `OnlinePlayScreen` sub-screens not loaded asynchronously	2021-07-20 19:51:13 +09:00
Dean Herbert	d066ebcd70	Merge pull request #12682 from frenzibyte/refactor-combo-colour-retrieval ... Refactor combo colours retrieval to use skin config lookups instead	2021-07-20 19:47:57 +09:00
Dean Herbert	8e1f8c28bd	Use default value to denote no play date, rather than null	2021-07-20 19:05:08 +09:00
Dan Balasescu	15127f972e	Merge branch 'master' into fix-online-play-sub-screens-not-async-loaded	2021-07-20 18:47:41 +09:00
Dean Herbert	d87ea741ed	Fix OnlinePlayScreen sub-screens not loaded asynchronously	2021-07-20 16:38:39 +09:00
Salman Ahmed	1af230c48c	Merge branch 'master' into refactor-combo-colour-retrieval	2021-07-20 10:08:25 +03:00
Dean Herbert	fe414b942f	Ensure online play subscreen is loaded before forwarding OnExiting ... Closes https://github.com/ppy/osu-framework/issues/4619 (actually not a framework issue; the framework correctly guards against this scenario, see 4e29504384/osu.Framework/Screens/ScreenStack.cs (L277)). Added the assertions to be very explicit about the nested stack's state at this point. Both of those events can only be triggered if the stack has a loaded screen (as far as I can tell), making this check unnecessary in those cases.	2021-07-20 15:51:34 +09:00
Dean Herbert	662822a40c	Avoid showing time of play on results screen when autoplay ... Closes https://github.com/ppy/osu/issues/13940.	2021-07-20 15:19:44 +09:00
Dean Herbert	844152e1b1	Merge pull request #13861 from peppy/add-password-support ... Add multiplayer room password support	2021-07-19 23:32:28 +09:00
Dan Balasescu	6e104fe084	Merge pull request #13894 from peppy/fix-beat-synced-container-alt ... Fix multiple issues with `BeatSyncedContainer`	2021-07-19 23:19:20 +09:00
smoogipoo	6a55cb9df0	Revert unintended change ... It's a deeper issue with ScreenStack (see: https://github.com/ppy/osu-framework/issues/4619).	2021-07-19 22:52:07 +09:00
smoogipoo	57a99886d5	Fix password icon not disappearing when no password	2021-07-19 22:31:01 +09:00
smoogipoo	892d858d5f	Fix compile error	2021-07-19 22:23:31 +09:00
smoogipoo	b7c2d6b1ab	Merge branch 'master' into add-password-support	2021-07-19 22:23:09 +09:00
Dan Balasescu	5ef1fe6948	Merge branch 'master' into fix-replay-date	2021-07-19 21:58:37 +09:00
Dan Balasescu	f3bcaf7f11	Merge pull request #13929 from peppy/i-deep-cloneable ... Create a deep clone of score for score submission purposes	2021-07-19 21:58:27 +09:00
smoogipoo	3168a927dc	Fix possible exception	2021-07-19 20:50:30 +09:00
smoogipoo	2515785f93	Use room password to fill settings textbox	2021-07-19 20:03:32 +09:00
Dean Herbert	b3f60c8253	Fix date being updated on replays unexpectedly	2021-07-19 19:28:35 +09:00
Dean Herbert	f16b4957aa	Move clone to earlier in the process	2021-07-19 19:18:34 +09:00
Dan Balasescu	f1f6af88a1	Merge pull request #13926 from peppy/set-rank-on-failed-submission ... Set score's rank on a failed submission	2021-07-19 18:45:21 +09:00
Dean Herbert	bde35d9f21	Rename radio button classes to be local to editor	2021-07-19 16:57:12 +09:00
Dean Herbert	caba78cb5d	Copy score during submission process to ensure it isn't modified	2021-07-19 14:14:28 +09:00
Dean Herbert	3c028ce05c	Add IDeepCloneable interface and update existing CreateCopy methods to use it	2021-07-19 12:54:17 +09:00
Dean Herbert	d7f997a7f3	Set score's rank on a failed submission ... As we don't have a `RankInfo.F`, this is the next best choice. I am also adding a check osu-web side for this - this is just to make sure we aren't sending scores with SS when they are not actually completed. I'm working on a separate PR to ensure this does not get mutated during the player exit process.	2021-07-19 12:36:15 +09:00
Derrick Timmermans	2e2a2bdd99	Allow moving timeline selection when mousedown event is outside of blueprint container	2021-07-18 18:06:59 +02:00
Derrick Timmermans	ee220feecf	Avoid using guesses to determine whether inputs blocked	2021-07-18 16:04:23 +02:00
Dean Herbert	c6bc95767d	Simplify popover hide logic and add test coverage	2021-07-17 22:31:47 +09:00
Dean Herbert	c966cb0530	Fix dependency lookup failing due to location of PopoverContainer	2021-07-17 15:04:18 +09:00
Dean Herbert	50eed26bd1	Rename radio button item to label	2021-07-17 02:32:23 +09:00
Dean Herbert	eac9b1ec7e	Disable toolbox composition buttons when beatmap is not timed	2021-07-17 02:30:13 +09:00
Dean Herbert	3ae5f6707a	Expose whether an EditorBeatmap has timing present or not via bindable	2021-07-17 02:30:00 +09:00
Dean Herbert	7a671754f2	Change RadioButton's object to a string	2021-07-17 02:29:31 +09:00
Derrick Timmermans	e35cff99c7	Pass on mouseDown input to timeline if no selection modification is made with that input	2021-07-16 17:21:43 +02:00
Derrick Timmermans	3e8a13bfbf	Allow interacting with timeline objects outside of drawable bounds	2021-07-16 16:16:34 +02:00
Dean Herbert	d0fc258886	Remove unused OsuLogo.BeatMatching	2021-07-15 15:11:42 +09:00
Dean Herbert	9d693c75cf	Add Schedule to restore password text box focus behaviour	2021-07-14 23:56:52 +09:00
Dean Herbert	cc09a8b5ba	Update to use OsuPopover implementation	2021-07-14 23:55:46 +09:00
Dean Herbert	b5dd9403b1	Merge branch 'master' into add-password-support	2021-07-14 23:53:03 +09:00
smoogipoo	dfe7cc40a9	Move create room button into the lounge	2021-07-14 18:55:01 +09:00
smoogipoo	3e6b9bd48d	Add filter background	2021-07-14 18:24:30 +09:00
smoogipoo	c64230315f	Adjust layouts	2021-07-14 18:10:59 +09:00
smoogipoo	0bfaf11d51	Remove/fix paddings in lounge	2021-07-14 17:46:52 +09:00
smoogipoo	f6b81b76e8	Add shadow	2021-07-14 17:46:32 +09:00
smoogipoo	da3b40a4dd	Add default background to panel, reduce nesting	2021-07-14 16:56:46 +09:00
smoogipoo	e0c61c24b1	Remove spotlights glow	2021-07-14 16:51:31 +09:00
smoogipoo	0e89bafd17	Add special category pill + secondary background	2021-07-14 16:48:53 +09:00
smoogipoo	c5977f3318	Merge branch 'master' into lounge-redesign	2021-07-14 12:47:16 +09:00
Dan Balasescu	4ce96109b7	Merge branch 'master' into fix-match-screen-buttons-no-user	2021-07-13 18:20:23 +09:00
Dan Balasescu	0557761e51	Merge pull request #13862 from peppy/fix-multiplayer-create-game-failure-crash ... Fix crash when multiplayer server join fails during game creation	2021-07-13 18:00:47 +09:00
Dean Herbert	e791669c40	Fix multiplayer screen buttons showing no text when local user not available	2021-07-13 17:59:58 +09:00
Dean Herbert	60e17fc2b7	Fix disconnected-from-server multiplayer exit sequence being blocked by confirmation dialog	2021-07-13 17:12:35 +09:00
Dean Herbert	481e4dedb0	Move PopoverContainer to OsuGameBase	2021-07-13 16:51:31 +09:00
smoogipoo	b5d4b9444f	wip	2021-07-13 16:51:29 +09:00
Dean Herbert	6409a518db	Focus password text box on popover display	2021-07-13 16:35:37 +09:00
smoogipoo	0cb80e105b	Renamespace classes	2021-07-13 16:02:18 +09:00
smoogipoo	ab282b9e59	Remove RoomInspector from the lounge	2021-07-13 16:00:42 +09:00
smoogipoo	689cee832c	Fix 1px gaps in DrawableRoom background	2021-07-13 15:50:46 +09:00
smoogipoo	8c4a257742	Add recent participants	2021-07-13 15:10:44 +09:00
Dean Herbert	5cffaf4d3b	Add extra explanatory comment to avoid any confusion	2021-07-13 14:34:56 +09:00
Dean Herbert	125bd36ab1	Send password in request ctor directly	2021-07-13 14:27:07 +09:00
Dean Herbert	c6bd58ea4b	Exit match sub screen when a room goes away ... Closes #13847. I think we can probably get some test coverage of this if required, but needs a bit of thought (basically an error needs to be thrown during the multiplayer client portion of the join procedure, after `CurrentRoom` is non-null but before the join completes). Manual testing on password branch (#13861) is possible since it currently errors due to missing method on the live/dev servers. - Create game, which will fail with `MethodNotExists`. - Note the fields on the settings screen are emptied. - Fill fields again and press create game (crash).	2021-07-12 19:20:41 +09:00
Dean Herbert	4dea2d9778	Dismiss popovers on returning to lounge	2021-07-12 18:54:17 +09:00
Dean Herbert	bbc3a013c8	Use BasicPopover for now	2021-07-12 18:29:50 +09:00
Dean Herbert	b4ca6b6188	Update popover logic to take advantage of new explicit popup functionality	2021-07-12 18:25:04 +09:00
Dean Herbert	a3e0168a46	Update tests	2021-07-12 18:25:04 +09:00
Dean Herbert	e25b3518dc	Make password popover display inside RoomsContainer rooms	2021-07-12 18:25:04 +09:00
Dean Herbert	9f9d7f9125	Add remaining pieces of password flow (for osu-web join request)	2021-07-12 18:22:52 +09:00
Dean Herbert	3c49b46c5f	Add lock overlay for rooms which are password protected	2021-07-12 18:22:52 +09:00
smoogipoo	c1fba3da6b	Add solid background	2021-07-12 16:30:34 +09:00
smoogipoo	aba09b20a5	Add host under room title	2021-07-12 16:28:22 +09:00
smoogipoo	4ac812de86	Add rank range pill	2021-07-12 16:15:26 +09:00
Dean Herbert	08c40938db	Add support for updating a room's password	2021-07-12 15:49:19 +09:00
Dean Herbert	4fd6f2101c	Add password textbox input	2021-07-12 15:49:19 +09:00
Dean Herbert	24f330e5c1	Avoid MatchSettingsOverlay base class potentially accessing an uninitialised field	2021-07-12 15:49:19 +09:00
smoogipoo	435b4b0e6e	Remove pill inheritance	2021-07-12 15:21:00 +09:00
smoogipoo	a8cbffa57e	Add playlist count pill	2021-07-12 15:11:53 +09:00
smoogipoo	185e36bf97	Split pill display into abstract class	2021-07-12 15:11:10 +09:00
smoogipoo	b4b0b862ef	Adjust some layout	2021-07-12 14:07:21 +09:00
smoogipoo	ac26374a93	Merge branch 'master' into lounge-redesign	2021-07-12 13:54:42 +09:00
Salman Ahmed	07ede7a147	Disallow custom rulesets from score submission	2021-07-11 03:34:57 +03:00
Dean Herbert	6a5f0e8237	Move handling of replay seek operations out of progress bar ... This is in order to avoid using the now obsoleted property `SliderBar.AllowKeyboardInputWhenNotHovered` (see https://github.com/ppy/osu-framework/pull/4579).	2021-07-09 14:28:59 +09:00
Dean Herbert	e612d7568c	Merge pull request #13771 from LumpBloom7/volume-meter-switch ... Add ability to navigate between volume meters via Alt+Left/Right arrows	2021-07-07 21:50:44 +09:00
Derrick Timmermans	4d7c744101	Fix failing test	2021-07-07 12:59:31 +02:00
smoogipoo	8929aa0ca7	Initial redesign of DrawableRoom	2021-07-07 14:47:24 +09:00
smoogipoo	2ddfa15a80	Redesign RoomStatusInfo	2021-07-07 14:47:24 +09:00
smoogipoo	c50e3fd317	Clean up selection box construction	2021-07-07 14:47:24 +09:00
Bartłomiej Dach	f45418dde7	Replace game-side directory/file selector with framework extensions	2021-07-06 22:11:54 +02:00
Derrick Timmermans	ffe18ebe51	Resolve build errors	2021-07-06 14:11:46 +02:00
Derrick Timmermans	07d54d261a	Let selection container handle manual selection changes	2021-07-06 13:24:18 +02:00
Derrick Timmermans	c5a0672277	Use IStateful<SelectionState> instead of ISelected	2021-07-06 12:07:25 +02:00
Dan Balasescu	32e6c9c5d3	Merge pull request #13786 from peppy/multiplayer-test-fixes ... Fix multiplayer test failures due to leaderboard load process	2021-07-06 16:33:41 +09:00
Dean Herbert	0658cfb986	Throw exceptions rather than silently failing if attempting to add a clock for a non-tracked user	2021-07-06 14:56:00 +09:00
Dean Herbert	1a6b8b2c73	Populate UserScores as early as possible to avoid weird ordering requirements	2021-07-06 14:53:31 +09:00
Bartłomiej Dach	686dd2b5ce	Remove unused constant	2021-07-05 20:35:14 +02:00
Derrick Timmermans	d495196b66	Share item cycling logic with GameplayMenuOverlay	2021-07-05 19:22:55 +02:00
Dean Herbert	f5ddd2a53b	Fix critical failure causing scores to not update on the leaderboard	2021-07-06 01:15:30 +09:00
PercyDan54	e1c646b9b2	Remove redundant arguments	2021-07-05 23:52:39 +08:00
Dean Herbert	f1014af284	Move LoadComplete content to run after user retrieval has completed ... Feels safer, I think.	2021-07-05 21:35:41 +09:00
Dean Herbert	459f9a0465	Handle nulls and fix missing documentation	2021-07-05 21:35:37 +09:00
Dean Herbert	77adf687c6	Consume ability to lookup multiple users in MultiplayerGameplayLeaderboard ... Avoids syncrhonously blocking on asynchronous operations (which was leading to LCA starvation in tests).	2021-07-05 19:56:37 +09:00
Dean Herbert	9c311a6d8a	Add ability to lookup multiple users at once to UserLookupCache	2021-07-05 19:56:16 +09:00
Dean Herbert	229bba14e6	Fix master clock becoming incorrectly paused when all spectator players are too far ahead	2021-07-05 17:45:08 +09:00
Bartłomiej Dach	c143a50b73	Merge branch 'master' into fix-zero-hit-score-submit	2021-07-04 15:31:38 +02:00
Dean Herbert	7a710ceffe	Check count as well (statistics can be populated with zero counts)	2021-07-04 16:41:09 +09:00
Dean Herbert	ef82528309	Don't attempt to submit score when nothing has been hit	2021-07-04 15:16:18 +09:00
Dean Herbert	ec71deec51	Remove some mentions of "lazer" ... I am aware there are more throughout the codebase but intentionally left the remaining mentioned for one reason or another. The intention here is to mainly change user-facing versioning to change the positioning of the "lazer" term (to be where we would expect "cuttingedge" or "beta" to be).	2021-07-04 12:41:27 +09:00
Bartłomiej Dach	fbe3b447e5	Merge branch 'master' into linkify-metadata	2021-07-03 15:51:08 +02:00
Dan Balasescu	ace57a9ee9	Merge pull request #13727 from peppy/update-disclaimer ... Update disclaimer	2021-07-02 21:08:43 +09:00
Dan Balasescu	9eb6ae4d45	Merge pull request #13721 from peppy/submit-on-player-exit ... Submit scores on player exit	2021-07-02 18:25:26 +09:00
Dean Herbert	362816492f	Move to more friendly namespace	2021-07-02 18:09:16 +09:00
Dean Herbert	eacf867073	Move shared types into their own classes	2021-07-02 18:05:00 +09:00
Dean Herbert	f689e788c9	Avoid using game-wide beatmap during score submission	2021-07-02 14:24:27 +09:00
Dean Herbert	62c125d7a2	Tidy up font formatting methods	2021-07-02 12:21:28 +09:00
Dean Herbert	f0727a63be	Reduce usable width	2021-07-02 12:18:52 +09:00
Dean Herbert	a1eaf39645	Slightly change wording to hopefully read better	2021-07-02 12:15:16 +09:00
smoogipoo	4c95af4b16	Add star rating range display	2021-07-01 20:35:31 +09:00
Dean Herbert	4c1b8bc427	Update disclaimer	2021-07-01 20:23:12 +09:00
Dean Herbert	0522500a57	Fix a couple of merge oversights	2021-07-01 19:45:17 +09:00
Dean Herbert	31dbc7798b	Merge branch 'master' into linkify-metadata	2021-07-01 19:41:33 +09:00
smoogipoo	a78d1b4c2e	Update SR colours to match osu-web	2021-07-01 19:37:21 +09:00
Dean Herbert	74c63e15be	Mark score failed on fail and exit	2021-07-01 17:48:09 +09:00
Dean Herbert	04b874bb00	Add flow for submitting score on exiting SubmittingPlayer	2021-07-01 17:02:33 +09:00
Dean Herbert	5bc970af0d	Make TestPlayer inherit from SoloPlayer for more flexibility in testing	2021-07-01 16:55:33 +09:00
Dean Herbert	00d3baef11	Exit handling flow	2021-06-30 20:23:48 +09:00
smoogipoo	6dd3c6fe93	Make MultiSpectatorScreen and tests more resillient to timing	2021-06-29 22:45:51 +09:00
smoogipoo	bfdbe3c3fe	Fix clocks getting added a second time	2021-06-29 17:29:25 +09:00
smoogipoo	8e04d73b67	Merge branch 'rework-multiplayer-test-scenes' into spectator-start-at-end-2	2021-06-29 17:06:57 +09:00
smoogipoo	bcdf36e77b	Merge branch 'master' into spectator-start-at-end-2	2021-06-29 15:53:58 +09:00
smoogipoo	92fa99700e	Merge branch 'master' into rework-multiplayer-test-scenes	2021-06-29 15:39:59 +09:00
smoogipoo	a3b1e1d5fc	Check for null ruleset in FilterCriteria	2021-06-29 15:18:40 +09:00
Dean Herbert	f939e2603a	Merge branch 'master' into localisable-tooltips	2021-06-28 15:29:42 +09:00
Gagah Pangeran Rosfatiputra	2b1d3c8e9c	add od filter in search filter	2021-06-26 21:05:01 +07:00
Gagah Pangeran Rosfatiputra	8e1bcc4d6b	add overall difficulty in filter criteria	2021-06-26 21:02:31 +07:00
Bartłomiej Dach	ea384332c3	Merge branch 'master' into logo-transition-sound	2021-06-25 21:12:48 +02:00
Bartłomiej Dach	50c27d2635	Update usages of IHasTooltip in line with framework localisation changes	2021-06-25 19:10:04 +02:00
aitani9	6bc71590c5	Disable logo click sound when exiting	2021-06-25 09:21:26 -07:00
Dean Herbert	51dd7fc238	Merge pull request #13622 from aitani9/mod-settings-dropdown-height ... Decrease the max dropdown height in mod settings	2021-06-25 17:42:47 +09:00
Dean Herbert	5883922177	Remove mod multiplier completely	2021-06-25 16:36:31 +09:00
aitani9	c8022126dc	Add logo sound case for transitioning to song select	2021-06-23 13:39:12 -07:00
Dean Herbert	151dfdfb79	Merge pull request #13627 from Joehuu/fix-multiplayer-exit-logic ... Fix multiplayer leave dialog not working on all exit operations	2021-06-23 14:56:57 +09:00
Dean Herbert	f62b4f2d24	Merge pull request #13617 from ekrctb/catch-editor ... Add "placeholder" (pre-MVP) implementation of osu!catch editor	2021-06-23 14:00:34 +09:00
ekrctb	0b351c9922	Fix "possible NRE" inspection	2021-06-23 10:57:04 +09:00
ekrctb	eec4457473	Add [CanBeNull] to methods returning null by default	2021-06-23 09:40:07 +09:00
Dean Herbert	4cb9c6a842	Merge pull request #13423 from frenzibyte/transformers-per-skin ... Refactor ruleset skin transforming logic to be per-`ISkin` rather than one `ISkinSource`	2021-06-22 21:24:56 +09:00
ekrctb	a9c7830252	Fix NRE when hit object blueprint is not implemented	2021-06-22 17:20:13 +09:00
Salman Ahmed	b12adc6073	Remove all test skinning changes in favour of the ISkinSource.AllSources path	2021-06-22 10:48:03 +03:00
Dean Herbert	1fff9a93b9	Merge branch 'master' into skin-editor-closest-anchor	2021-06-22 16:41:51 +09:00
Dean Herbert	1b0aadcc6f	Merge branch 'master' into transformers-per-skin	2021-06-22 16:03:15 +09:00
Joseph Madamba	db86098062	Fix dialog not closing after spamming OS window close	2021-06-21 20:23:11 -07:00
Joseph Madamba	9bcd1e6922	Move confirm dialog logic to OnExiting	2021-06-21 20:22:18 -07:00
Joseph Madamba	00b4cf1829	Handle sub screen OnExiting logic on main screen	2021-06-21 20:20:43 -07:00
Dean Herbert	b1fd812805	Merge branch 'master' into more-ui-sfx	2021-06-18 23:24:19 +09:00
Jamie Taylor	6e4fc26e16	replace 'songselect' hover/click sounds with 'button' ones for now	2021-06-18 21:03:46 +09:00
Dean Herbert	c751e087ca	Merge branch 'master' into skin-editor-closest-anchor	2021-06-18 18:54:07 +09:00
Dean Herbert	0bc68a7018	Move xmldoc to method	2021-06-18 16:50:31 +09:00
Dean Herbert	19507e107e	Reorder methods to make more sense	2021-06-18 16:46:40 +09:00
Dean Herbert	a7f40dc6d4	Merge branch 'remove-synchronous-prepare-score-method' into storyboard-outro-logic-refactor	2021-06-18 16:45:01 +09:00
Dean Herbert	45122594e5	Remove the synchronous version of PrepareScoreForResults ... Replaces all existing usages with the `async` version.	2021-06-18 16:24:08 +09:00
Dean Herbert	f3426e38b4	Add note about delay parameter	2021-06-18 16:18:20 +09:00
Dean Herbert	3819a1f03b	Remove exit override behaviour ... I don't actually know under what scenario this could have been hit, and actually caused expected behaviour. Consider that in the scenario I describe in the comment (which I added yesterday), the user is requesting a pause or exit which would be "cancelled showing the results instead". But in such a scenario, `PerformExit` would first be run, which cancels the `resultsDisplayDelegate` in the first place. The only special case would be pressing the close button on the window decoration? Which I don't think should be a special case in the first place, so I'm just going to remove this for the time being to keep things simple.	2021-06-18 16:12:35 +09:00
Dean Herbert	7ef8eac773	Remove unnecessary (and no longer correct) exception	2021-06-18 16:08:31 +09:00
Dean Herbert	2bf855fcca	Move all storyboard outro skip logic out of updateCompletionState ... This method should only be called to trigger the score completion portion of player progression. The storyboard skip/end logic is now handled separately in `progressToResults`.	2021-06-18 15:50:43 +09:00
Bartłomiej Dach	f282326f9a	Move score preparations back below ShowResults check	2021-06-17 19:04:52 +02:00
Bartłomiej Dach	3a1444e75d	Fix malformed xmldoc tag ... Oops. Made a typo in the PR suggestion.	2021-06-17 19:02:56 +02:00
Dean Herbert	9facfe8964	Apply suggestions from code review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-06-18 01:07:54 +09:00
Dean Herbert	e0a3696145	Merge branch 'master' into player-completion-refactoring	2021-06-17 23:51:42 +09:00
Bartłomiej Dach	aae2923e14	Merge branch 'master' into player-pause-exit-results-flow-refactoring	2021-06-17 16:05:09 +02:00
Bartłomiej Dach	10b0d066be	Reword comments slightly	2021-06-17 16:04:58 +02:00
Bartłomiej Dach	561dbea9e1	Use xmldoc-specific syntax for nicer formatting	2021-06-17 15:26:50 +02:00
Dean Herbert	d03c6da60c	Refactor and redocument updateCompletionState() and surrounding methods	2021-06-17 19:13:53 +09:00
Dean Herbert	246ab41cc6	Remove special casing for user exit during storyboard outro	2021-06-17 18:11:15 +09:00
Dean Herbert	7cbebe6d11	Rewrite xmldoc and inline comments for PerformExit	2021-06-17 18:10:59 +09:00
Dean Herbert	808b2baa41	Consume new behaviour to fix UserTile discrepancy ... Closes https://github.com/ppy/osu/issues/13522.	2021-06-17 16:31:12 +09:00
Dean Herbert	4b45d8318e	Merge branch 'master' into transformers-per-skin	2021-06-16 16:37:28 +09:00
Dean Herbert	83402a70db	Fix potential null ref when no beatmap is selected	2021-06-14 15:06:24 +09:00
Dean Herbert	f8b09b7c81	Avoid refresh if score is not related to current display	2021-06-14 14:28:14 +09:00
Dean Herbert	fc442713bb	Debounce schedule at base class	2021-06-14 14:26:40 +09:00
Dean Herbert	8dd48d48f6	Add support for song select leaderboard to handle newly imported scores	2021-06-14 14:20:23 +09:00
smoogipoo	9f163f7f20	Use switch statement to be more explicit about state	2021-06-11 19:23:25 +09:00
smoogipoo	0a8daab4f7	Pause master clock when too far ahead	2021-06-11 19:15:53 +09:00
smoogipoo	59eda70c12	Seek to the least most-recent frame instead	2021-06-11 18:40:56 +09:00
smoogipoo	263b8ff097	Wait for full player load	2021-06-11 18:14:37 +09:00
smoogipoo	a99cb79738	Seek master clock on multi-spectator start	2021-06-11 16:25:45 +09:00
smoogipoo	75d825c85c	Dont control master clock from sync manager	2021-06-11 16:24:52 +09:00
smoogipoo	1c67ef7c91	Make catchup clock support seeking	2021-06-11 16:23:59 +09:00
Dean Herbert	04413f1634	Merge pull request #13444 from peppy/editor-timeline-taiko-hit-colouring ... Show osu!taiko centre/rim colouring in editor timeline	2021-06-11 15:10:24 +09:00
Dan Balasescu	97375d9625	Merge pull request #13438 from bdach/more-metadata-fields ... Add remaining metadata fields to editor setup screen	2021-06-11 14:17:34 +09:00
Dean Herbert	bc3b7233ab	Show osu!taiko centre/rim colouring in editor timeline ... Closes #13443.	2021-06-11 14:17:30 +09:00
Bartłomiej Dach	7fd26ff3b0	Merge branch 'master' into more-metadata-fields	2021-06-11 06:35:51 +02:00
Dean Herbert	38bf04d7ff	Give more space for time values to allow for negative offsets	2021-06-11 13:25:09 +09:00
Bartłomiej Dach	417aaacc53	Add test coverage for romanised data transfer	2021-06-10 22:18:39 +02:00
Bartłomiej Dach	e41a5a0fcd	Add romanised author & title fields	2021-06-10 22:17:45 +02:00
ilsubyeega-desu	f65f074131	Add star keyword to FilterQueryParser criteria	2021-06-11 02:46:29 +09:00
Salman Ahmed	ef2c4fd0d8	Make RulesetSkinProvidingContainer able to be overriden for testing purposes	2021-06-10 16:36:46 +03:00
smoogipoo	e18f4cd4ba	Combine methods	2021-06-10 22:01:39 +09:00
smoogipoo	5073ede115	Clear existing frames when starting gameplay	2021-06-10 21:38:46 +09:00
smoogipoo	9eecb23fef	Only seek to the end on first frame arrival	2021-06-10 21:35:52 +09:00
Bartłomiej Dach	252fe0a6cc	Add source and tags text boxes to metadata section	2021-06-10 14:13:59 +02:00
Bartłomiej Dach	5a2e710095	Split common method for metadata textbox creation	2021-06-10 13:55:34 +02:00
Dean Herbert	4a4a561ca4	Merge pull request #13330 from nekodex/results-screen-sfx ... Add sound effects to the results screen	2021-06-10 18:27:17 +09:00
Salman Ahmed	dde84e5cbd	Merge branch 'master' into transformers-per-skin	2021-06-10 11:58:52 +03:00
Dean Herbert	0667354fbd	Remove unused resolved skin	2021-06-10 17:30:04 +09:00
Dean Herbert	4f8000a574	Combine cases which return the same value	2021-06-10 17:29:36 +09:00
Dean Herbert	5e80f454ce	Merge branch 'master' into results-screen-sfx	2021-06-10 17:25:35 +09:00
Dan Balasescu	a44fd887ee	Merge branch 'master' into no-unranked-display	2021-06-10 17:09:46 +09:00
Joseph Madamba	cc38556f61	Fix background being dimmed forever after toggling statistics in results screen	2021-06-09 23:26:57 -07:00
Dean Herbert	9a3ca09501	Merge pull request #13384 from bdach/fixed-label-width ... Align label widths of editor setup screen controls	2021-06-10 14:55:49 +09:00
Dean Herbert	209d217024	Remove unused using statement	2021-06-10 12:37:56 +09:00
Dean Herbert	3d508f9266	Merge branch 'master' into results-screen-sfx	2021-06-10 11:28:35 +09:00
Joseph Madamba	e3f3c37953	Add ability to navigate score panels with left/right arrows	2021-06-09 17:03:46 -07:00
Salman Ahmed	1aaad7bfd4	Apply few adjustments to skinning overlays comment	2021-06-09 22:49:31 +03:00
Salman Ahmed	e30f6581b3	Wrap gameplay content within a RulesetSkinProvidingContainer	2021-06-09 22:49:31 +03:00
Bartłomiej Dach	89cdea8123	Merge branch 'master' into fix-results-exit-transition	2021-06-09 19:40:56 +02:00
Dean Herbert	b02b8ae2bc	Merge pull request #13381 from smoogipoo/improve-hit-error-judgements ... Improve hit error judgement displays	2021-06-09 19:40:17 +09:00
Dean Herbert	31b46afa71	Fix wrong naming scheme for applause samples	2021-06-09 19:35:05 +09:00
Dean Herbert	7d86dafd4f	Simplify tick calculation/playback method	2021-06-09 19:31:53 +09:00
Dean Herbert	57bc34f224	Move consts closer to usage	2021-06-09 19:24:35 +09:00
Dean Herbert	cb4f366651	Move forgotten private function down more	2021-06-09 19:15:55 +09:00
Dean Herbert	81cecac90b	Move tick rate initialisation to earlier	2021-06-09 19:09:00 +09:00
Dean Herbert	499aba95c0	Simplify sample construction logic and move private functions down	2021-06-09 19:06:37 +09:00
Dean Herbert	21a63efd78	Rename variable back to withFlair to match parent class	2021-06-09 18:55:29 +09:00
Dean Herbert	330bb7cb45	Remove unnecessary skin lookup logic	2021-06-09 18:55:29 +09:00
Dean Herbert	8fda04c2d9	Merge branch 'master' into results-screen-sfx	2021-06-09 18:00:11 +09:00
Dean Herbert	a65b76bdbf	Add a simple fade to the results screen ... Stops it from immediately disappearing.	2021-06-09 17:19:37 +09:00
Dean Herbert	7b0c5e9d32	Fix results screen changing applied colour to background on exit ... The general rule is that screens should only apply colours and the likes on enter / resume, and leave the outwards transition to whatever screen is coming next.	2021-06-09 17:18:55 +09:00
Dean Herbert	258d05d1e0	Ensure PlayerLoader restores the background colour to its own value on resume	2021-06-09 17:17:39 +09:00
Dean Herbert	a7ef0173e9	Add safety to ensure background is correct tint when entering gameplay	2021-06-09 17:07:28 +09:00
Bartłomiej Dach	020c63017e	Fix inspectcode issues	2021-06-09 09:21:02 +02:00
Bartłomiej Dach	a801a9a14d	Ensure background rotation on default skins	2021-06-09 07:59:47 +02:00
Dean Herbert	b754c52392	Update ModAutoplay matching to use new UserPlayable flag instead	2021-06-09 14:32:48 +09:00
Dean Herbert	7774344f0e	Remove "Unranked" text from ModDisplay	2021-06-09 13:45:09 +09:00
Bartłomiej Dach	97204b6f27	Reduce unnecessary background changes via IEquatable implementation	2021-06-08 22:37:18 +02:00
Bartłomiej Dach	a98c302211	Bring back skin background source	2021-06-08 22:04:59 +02:00
Bartłomiej Dach	5bf4dd6358	Move skin background to separate file	2021-06-08 21:57:08 +02:00
Bartłomiej Dach	410cb16340	Apply fixed label width to setup screen items	2021-06-08 17:18:00 +02:00
smoogipoo	00efed2c39	Add colours for tick judgements	2021-06-08 23:10:21 +09:00
smoogipoo	c8e14d7710	Ignore non-scorable and bonus judgements	2021-06-08 23:09:23 +09:00
smoogipoo	c3ea1b26e1	Fix DT being doubled in multiplayer spectator	2021-06-08 22:51:42 +09:00
Robin Avery	dc50ae40b9	Rename OverridesClosestAnchor to UsesFixedAnchor	2021-06-08 08:28:42 -04:00
smoogipoo	ab9290772b	Fix a similar case with online play sub-screens	2021-06-08 17:54:54 +09:00
smoogipoo	860f1aebb3	Only call OnBackButton() if the screen has finished loading	2021-06-08 17:38:12 +09:00
smoogipoo	7fa0ac6ed7	Fix possible nullref when exiting song select too fast	2021-06-08 17:03:50 +09:00
Dean Herbert	95852ccdf8	Merge branch 'master' into results-screen-sfx	2021-06-08 15:14:31 +09:00
Bartłomiej Dach	0531c2dcd9	Move empty window check to bar error meter ... It's not valid in the base `HitErrorMeter`, as the colour meter only displays colour for a given judgement, so it is still valid to add new items to it even if the hit window is 0, as misses are still possible.	2021-06-07 13:16:07 +02:00
Bartłomiej Dach	37d062c7cd	Add failing assertions to hit error meter test	2021-06-07 13:16:07 +02:00
Dean Herbert	59130be99c	Fix switching storyboard mode not triggering a reload	2021-06-07 17:32:04 +09:00
Dean Herbert	f677f9b5f4	Stop BackgroundScreenDefault from reloading beatmap background when already correct	2021-06-07 17:22:36 +09:00
Robin Avery	29fa4fdf57	Refactor unacceptable syntax	2021-06-07 01:08:39 -04:00
Robin Avery	133d72a8c0	Rename UsingClosestAnchor ... It is now "OverridesClosestAnchor". The logic is inverted accordingly.	2021-06-07 00:14:36 -04:00
Robin Avery	f28916e30f	Remove all UsingClosestAnchor() extension logic ... It is replaced with ISkinnableDrawable.UsingClosestAnchor.	2021-06-07 00:04:53 -04:00
Robin Avery	ce635af83e	Add UsingClosestAnchor to ISkinnableDrawable ... Also implement it as an auto property in its inheritors. The auto properties default to true.	2021-06-06 23:47:47 -04:00
Robin Avery	da1c38d5a9	Uninvert logic of SkinnableInfo.UsingClosestAnchor ... Also rename "IsUsingClosestAnchor" to simply "UsingClosestAnchor".	2021-06-06 10:13:35 -04:00
Robin Avery	11b1b8c633	Add serialization support via SkinnableInfo	2021-06-06 07:18:08 -04:00
smoogipoo	009aa994d0	Fix potential race incorrectly pausing the source clock	2021-06-04 21:58:51 +09:00
Dan Balasescu	57a38374db	Merge branch 'master' into fix-spectator-frame-conversion	2021-06-04 21:17:40 +09:00
Dean Herbert	840f084dc4	Merge pull request #13303 from LeNitrous/mainmenu-storyboard-backgrounds ... Add storyboards as a main menu background source	2021-06-04 19:50:40 +09:00
Dean Herbert	23096c58bb	Merge branch 'master' into fix-spectator-frame-conversion	2021-06-04 15:06:15 +09:00
Dean Herbert	d444fed46f	Detach gameplay score from replay recorder before importing ... Closes #13320.	2021-06-04 02:00:02 +09:00
Jamie Taylor	054de675ff	allow skinned 'applause' sample to override results screen sfx	2021-06-03 18:35:55 +09:00
Jamie Taylor	582360d0c8	only load the required impact/applause samples	2021-06-03 18:35:51 +09:00
Jamie Taylor	ed012a724b	refactor from using public variables	2021-06-03 18:35:46 +09:00
Jamie Taylor	8dc595d201	move result screen samples to DefaultSkin	2021-06-03 18:35:27 +09:00
Jamie Taylor	63e5bc4543	update sample names and timings	2021-06-03 18:34:33 +09:00
Jamie Taylor	30eff8cc2a	remove overlapping/legacy applause	2021-06-03 18:34:28 +09:00
Jamie Taylor	9ad87ee5dc	add sfx for results screen + sound design tool	2021-06-03 18:34:22 +09:00
smoogipoo	e887807ae7	Apply review fixes	2021-06-03 18:32:05 +09:00
smoogipoo	be03a2d7d2	Fix multiple calls to seek method potentially not working	2021-06-03 17:47:22 +09:00
smoogipoo	c3280083a2	Merge branch 'master' into fix-spectator-frame-conversion	2021-06-03 17:42:01 +09:00
smoogipoo	662bbed5d1	Fix seeking to gameplay too soon	2021-06-03 17:38:51 +09:00
smoogipoo	420df124b5	Add framestable-bypassing seek for spectator	2021-06-03 17:27:21 +09:00
Nathan Alo	d00fb21188	prevent scaling container from creating a storyboard background	2021-06-03 13:24:21 +08:00
Dan Balasescu	44b1102241	Merge branch 'master' into autoplay-pause-support	2021-06-03 13:26:00 +09:00
Dean Herbert	d6656047e3	Fix beatmap statistics with value of zero not displaying correctly at song select ... Closes #13307.	2021-06-03 01:58:51 +09:00
Dean Herbert	e0eb0adb0a	Remove unnecessary bind in ReplayPlayer	2021-06-02 18:32:14 +09:00
Nathan Alo	dde64adcb5	add new background type in BackgroundScreenDefault	2021-06-02 15:51:43 +08:00
Dean Herbert	a15cac6f53	Change the way Score is initialised in Player to better lend to population of metadata	2021-06-02 15:44:04 +09:00
Dean Herbert	289dc00f38	Merge branch 'master' into autoplay-pause-support	2021-06-01 16:50:44 +09:00
Dean Herbert	3ba0d29108	Fix incorrect beatmap being parsed down for autoplay generation	2021-06-01 15:44:24 +09:00
Dean Herbert	6ef9b346e1	Fix newly found inspections from 2021.1EAP1	2021-06-01 14:33:21 +09:00
Dean Herbert	cbf3ef5400	Create replay via the ICreateReplay interface instead of explicitly ModAutoplay	2021-06-01 14:22:16 +09:00
Dean Herbert	9221213fe5	Fix potential nullref is beatmap load failed	2021-06-01 14:19:23 +09:00
Dean Herbert	14570b6fb1	Merge branch 'master' into autoplay-pause-support	2021-06-01 14:19:21 +09:00
smoogipoo	7f24518004	Fix spectator crashing when converting mania replay frames	2021-05-31 19:24:22 +09:00
smoogipoo	d2d0896298	Expose GameplayBeatmap and GameplayRuleset from Player	2021-05-31 19:22:20 +09:00
Dan Balasescu	46b6f49a92	Merge pull request #13230 from peppy/non-nullable-beatmapset-files ... Make `BeatmapSet.Files` non-nullable	2021-05-31 19:10:03 +09:00
Dean Herbert	d1ef5483bc	Merge pull request #12826 from frenzibyte/catch-hide-combo-workaround ... Hide legacy HUD combo counters on osu!catch ruleset	2021-05-31 19:04:25 +09:00
Salman Ahmed	4e186b0cf5	ContentVisible -> HiddenByRulesetImplementation	2021-05-31 09:24:26 +03:00
Dean Herbert	06bd696cc2	Remove previous consumption logic in GetWorkingBeatmap ... This should not be required since the introduction of `workingCache`, which does the same thing in a more global way.	2021-05-31 14:11:58 +09:00
Salman Ahmed	fb111e23d8	Remove "temporarily"	2021-05-31 07:24:59 +03:00
Salman Ahmed	3fbd4e276d	Add simple xmldoc	2021-05-31 00:07:29 +03:00
Bartłomiej Dach	78213e09d4	Merge branch 'master' into editor-exit-stability	2021-05-30 23:03:50 +02:00
Salman Ahmed	fb81e5133f	Merge branch 'master' into catch-hide-combo-workaround	2021-05-30 14:16:46 +03:00
Dean Herbert	9b239e308b	Merge branch 'master' into beatmap-skin	2021-05-29 15:36:43 +09:00
Dean Herbert	f1b5aced6f	Merge branch 'master' into editor-exit-stability	2021-05-28 14:32:32 +09:00
Dan Balasescu	7e0a4562c9	Merge branch 'master' into fix-bad-make-current-call	2021-05-28 00:32:51 +09:00
Dan Balasescu	bc4ccb8a21	Merge pull request #12916 from peppy/fix-taiko-editor-sample-mutations ... Fix osu!taiko editor operations not always updating the menu/visual state correctly	2021-05-27 23:55:16 +09:00
Dean Herbert	046087a367	Fix access to AliveChildren before IsLoaded	2021-05-27 16:58:01 +09:00
Dean Herbert	14a4095140	Merge branch 'master' into beatmap-skin	2021-05-26 18:39:47 +09:00
Dean Herbert	b3b39c4c13	Fix BeatmapCarousel accessing ScreenSpaceDrawQuad of non-loaded children ... Fixes failure seen at https://ci.appveyor.com/project/peppy/osu/builds/39302762/tests.	2021-05-26 15:42:27 +09:00
Dean Herbert	268230c8c4	Merge branch 'master' into fix-taiko-editor-sample-mutations	2021-05-25 19:01:47 +09:00
Dean Herbert	7c89dbcd35	Externalise autoplay generation	2021-05-25 18:37:04 +09:00
Dean Herbert	7f9318d976	Expose GameplayBeatmap to derived Player classes	2021-05-25 18:36:47 +09:00
Dean Herbert	c2b938a29f	Remove autoplay consideration from Player	2021-05-25 18:09:37 +09:00
Dan Balasescu	6263ebf9da	Merge pull request #12495 from peppy/localisation-proof-of-concept ... Add language selection and general structure for localisation support	2021-05-24 23:33:49 +09:00
Dan Balasescu	3b4fbe22f0	Merge pull request #12928 from Firmatorenio/fix-colour-hitmeter-not-registering-taiko-misses ... Fix colour hit error meter incorrectly assuming taiko hits were of correct colour	2021-05-24 23:31:54 +09:00
Dan Balasescu	eeda33a453	Merge branch 'master' into localisation-proof-of-concept	2021-05-24 22:56:18 +09:00
Firmatorenio	471f17547a	switch determining the hit result by offset to getting it from the judgement directly	2021-05-24 16:49:58 +06:00
Dan Balasescu	af2a831c83	Merge pull request #12926 from peppy/fix-placement-blueprint-disappearing ... Fix editor placement ending early if a blueprint becomes alive from a pool	2021-05-24 17:42:18 +09:00
Dean Herbert	65c3c0d53f	Merge branch 'master' into localisation-proof-of-concept	2021-05-24 17:10:56 +09:00
Dean Herbert	4fc6ba50b7	Fix editor placement ending early if a blueprint becomes alive from a pool ... Closes https://github.com/ppy/osu/issues/12630.	2021-05-24 17:04:02 +09:00
Firmatorenio	e5f586f2a6	fix colour hit error meter not pushing misses when wrong colour note is hit in taiko	2021-05-24 13:29:12 +06:00
Dean Herbert	100e2d14a5	Move call inside conditional	2021-05-24 15:14:55 +09:00
Dean Herbert	a69a1b5211	Fix Player potentially running MakeCurrent when already removed from the screen stack ... Closes #12919.	2021-05-24 13:53:53 +09:00
Dean Herbert	83981b692e	Also handle items exiting bounds on the opposite side	2021-05-24 13:44:13 +09:00
Dean Herbert	593fea0d5f	Limit automatically calculated HUD offsets to keep menu items on screen	2021-05-24 13:14:18 +09:00
Salman Ahmed	d605b6bb8d	Fix HUD overlay components bottom positioning logic accounting for combo	2021-05-23 16:22:51 +03:00
Salman Ahmed	6751d79ce8	Fix oversight in HUD overlay components top positioning logic	2021-05-23 16:22:22 +03:00
Dean Herbert	4c9d72e62a	Ensure EditorBeatmap.Update is called inside PerformOnSelection calls	2021-05-23 21:22:35 +09:00
Joseph Madamba	2fd0038154	Fix checkmark being hidden after clicking current waveform opacity setting	2021-05-22 16:42:20 -07:00
Dean Herbert	34a5b22b79	Merge branch 'master' into refactor-selection-rotate-logic	2021-05-22 20:52:28 +09:00
Dean Herbert	485728ca4e	Merge pull request #12866 from peppy/refactor-selection-scale-logic ... Add proper scaling support to skin editor	2021-05-22 20:07:03 +09:00
Dean Herbert	b13a68592f	Merge branch 'master' into localisation-proof-of-concept	2021-05-22 17:07:23 +09:00
Dean Herbert	fb5672814d	Add remaining strings for ButtonSystem	2021-05-22 13:56:59 +09:00
Salman Ahmed	4f6de6fdc6	Implement GetSkin() for other working beatmaps	2021-05-21 20:21:29 +03:00
Dean Herbert	bb2fae55ce	Merge branch 'master' into refactor-selection-rotate-logic	2021-05-21 19:19:54 +09:00
Dean Herbert	f335337e5d	Merge pull request #12851 from vininew921/applause-stops-on-score-switch ... Fix applause sound stopping after switching scores	2021-05-21 18:49:59 +09:00
Dean Herbert	0acf4cf85c	Translate remaining ButtonSystem strings and rename to match class name	2021-05-21 18:48:11 +09:00
Dean Herbert	df426b9334	Merge pull request #12852 from timiimit/multi-larger-freemod-overlay ... Make freemod selection overlay taller in multiplayer room	2021-05-21 18:45:15 +09:00
Dean Herbert	a8acbbe69c	Merge pull request #12779 from Game4all/import-from-stable-select-location ... Add ability to manually locate a stable location when importing from stable	2021-05-21 18:17:30 +09:00
Dean Herbert	b0a113a36b	Merge branch 'master' into localisation-proof-of-concept	2021-05-21 17:57:54 +09:00
Dean Herbert	abc96057b2	Remove relative height specification and use constant height	2021-05-21 17:55:46 +09:00
Dean Herbert	2958b9adf4	Merge branch 'master' into import-from-stable-select-location	2021-05-21 17:37:34 +09:00
Dean Herbert	1ca563e831	Merge branch 'master' into applause-stops-on-score-switch	2021-05-21 17:28:28 +09:00
Dean Herbert	20f890cfd0	Merge branch 'master' into fix-spectator-playing-state-5	2021-05-21 16:49:22 +09:00
smoogipoo	36aa186c6e	Merge branch 'thread-safe-spectator-client'	2021-05-21 16:00:24 +09:00
smoogipoo	895eb14c5a	Forcefully end playing to fix test failures	2021-05-21 14:09:30 +09:00
Dean Herbert	7ad6a1d5ff	Merge branch 'master' into thread-safe-spectator-client	2021-05-21 11:47:58 +09:00
Dan Balasescu	527847596e	Merge pull request #12884 from peppy/ternary-menu-item-refactor ... Create base implementations of the two most common `TernaryStateMenuItem`s	2021-05-20 21:02:15 +09:00
smoogipoo	e3284b976d	Merge branch 'thread-safe-spectator-client' into fix-spectator-playing-state-5	2021-05-20 19:46:26 +09:00
smoogipoo	5a8b8782d3	Fix WatchUser being called asynchronously in BDL	2021-05-20 19:44:43 +09:00
smoogipoo	ee4bca9ed1	Handle collection changed event	2021-05-20 19:37:43 +09:00
Dean Herbert	df5970fab4	Create base implementations of the two most common TernaryStateMenuItems	2021-05-20 19:34:53 +09:00
smoogipoo	7ee81669f7	Remove bind helpers from SpectatorClient	2021-05-20 19:27:43 +09:00
smoogipoo	2896da499d	Merge branch 'restructure-spectator-client' into thread-safe-spectator-client	2021-05-20 18:53:54 +09:00
smoogipoo	a74405d0ed	Merge branch 'master' into restructure-spectator-client	2021-05-20 18:53:42 +09:00
smoogipoo	f74dbb9e1f	Remove locking from SpectatorScreen	2021-05-20 18:52:20 +09:00
Dean Herbert	27e81d6504	Implement proper rotation algorithm for skin editor	2021-05-20 18:21:16 +09:00
smoogipoo	6beeb7f7c4	Rename SpectatorStreamingClient -> SpectatorClient	2021-05-20 15:55:07 +09:00
smoogipoo	d197a7f6f5	Rename multiplayer client classes	2021-05-20 15:39:45 +09:00
Dean Herbert	dbfaaecd9c	Reword comment to not mention tests driectly	2021-05-20 15:39:29 +09:00
Salman Ahmed	43094425e2	Merge branch 'legacy-beatmap-skin-hud-fallback' into catch-hide-combo-workaround	2021-05-19 23:18:27 +03:00
Dean Herbert	00ed699340	Fix origin specifications using incorrect flags	2021-05-20 01:53:24 +09:00
Dean Herbert	363aec8179	Merge branch 'master' into hit-error-skinnable	2021-05-20 01:51:45 +09:00
Dean Herbert	b2c736b42a	Combine and move const closer to usage	2021-05-19 18:09:46 +09:00
Dean Herbert	a639132825	Avoid doing any re-fetch on beatmap from test scenes	2021-05-19 17:58:28 +09:00
Dean Herbert	a0f67ef3bc	Move scaling logic out of OsuSelectionHandler for reuse	2021-05-19 17:37:28 +09:00
Vinicius Barbosa	4f397ae7f5	Merge branch 'master' into applause-stops-on-score-switch	2021-05-19 09:52:31 +02:00
Dean Herbert	44e22b31a9	Refactor editor exit sequence to avoid any scenario where a dialog could go stray	2021-05-19 16:51:54 +09:00
Dean Herbert	b83322281e	Consume updated logic at MainMenu	2021-05-19 16:51:54 +09:00
Salman Ahmed	013fe4928f	Unrevert irrelevant changes	2021-05-19 08:48:21 +03:00
timiimit	1fd00d1313	Change from fullscreen to 0.7	2021-05-18 21:52:28 +02:00
Vinicius Barbosa	d05ffdf120	Added constants for delay value	2021-05-18 20:19:18 +02:00
timiimit	ac5fe0c18c	Change larger freemod selection overlay	2021-05-18 18:50:42 +02:00
Vinicius Barbosa	06fffc499b	Removed unused variables and directives	2021-05-18 16:56:07 +02:00
Salman Ahmed	c98d036b48	Merge branch 'master' into catch-hide-combo-workaround	2021-05-18 17:47:20 +03:00
Salman Ahmed	e7d2f42149	Revert "Merge branch 'fix-legacy-skin-test' into catch-hide-combo-workaround" ... This reverts commit 380d004683, reversing changes made to ff419af512.	2021-05-18 17:46:15 +03:00
Vinicius Barbosa	76a377f3e0	Fixed applause sound stopping after switching scores	2021-05-18 15:30:45 +02:00
Lucas A	775e0fbde5	Mark StableImportManager as nullable.	2021-05-18 15:27:20 +02:00
Dean Herbert	41d8bc291c	Merge pull request #12783 from smoogipoo/hoc-event-queue ... Add a HitObjectUsageEventBuffer to handle HOC events appropriately	2021-05-18 22:22:53 +09:00
smoogipoo	c6160d5304	Only ignore online score id for database import	2021-05-18 21:17:41 +09:00
smoogipoo	d93ac7ac98	Change class xmldoc a bit	2021-05-18 19:15:46 +09:00
smoogipoo	ab6a79f84c	Simplify	2021-05-18 19:15:46 +09:00
smoogipoo	97f4f7bbd1	Remove Component inheritance	2021-05-18 18:59:45 +09:00
smoogipoo	633f841a0f	Rename to HitObjectUsageEventBuffer	2021-05-18 18:57:02 +09:00
smoogipoo	bfc0205e9b	Fix (began, finished) event	2021-05-18 18:49:11 +09:00
Dean Herbert	d661e98fa6	Move common functionality out of OsuSelectionHandler and implement flip support	2021-05-18 18:34:06 +09:00
smoogipoo	61a41d97a4	Add some xmldocs + comments	2021-05-18 17:39:45 +09:00
Dean Herbert	ed957df162	Add simple xmldoc to TransferBlueprintFor method	2021-05-18 16:40:56 +09:00
Dean Herbert	55cc533a37	Merge branch 'master' into hoc-event-queue	2021-05-18 16:31:20 +09:00
Dean Herbert	a96603f025	Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints ... Rename hitobject blueprints and tie them to HitObjects	2021-05-18 16:30:58 +09:00
Dean Herbert	10c730b37d	Add new default locations for hit bar error displays	2021-05-18 15:50:50 +09:00
Salman Ahmed	380d004683	Merge branch 'fix-legacy-skin-test' into catch-hide-combo-workaround	2021-05-18 09:45:43 +03:00
Salman Ahmed	ff419af512	Hide the combo counter content rather than full death	2021-05-18 09:10:15 +03:00
Dean Herbert	829d326e36	Remove alignment logic completely for the time being ... This was overly complex and does not play well with the new layout customisation system. We can add it back as required.	2021-05-18 14:55:34 +09:00
smoogipoo	75c0d4d972	Merge branch 'rework-hitobject-blueprints' into hoc-event-queue	2021-05-18 14:33:52 +09:00
smoogipoo	882d54a8f8	Remove now unnecessary Apply() method	2021-05-18 14:26:26 +09:00
smoogipoo	e621cfc4ea	Add Apply() method for applying new DHOs	2021-05-18 14:14:10 +09:00
smoogipoo	f1f3606fd0	Fix unresolved xmldocs	2021-05-18 13:11:58 +09:00
Dan Balasescu	9d423245d8	Fix up xmldocs ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-05-18 13:02:23 +09:00
Lucas A	79740dd2d8	Merge conditionnal expression.	2021-05-17 22:01:05 +02:00
Dan Balasescu	ea4dfd3374	Merge pull request #12842 from peppy/song-progress-skinnable ... Add layout customisation support for `SongProgress`	2021-05-17 20:15:01 +09:00
Lucas A	fe11426238	Disable appearance of the stable import prompt waiting for user interaction in tests, which caused them to fail.	2021-05-17 12:55:59 +02:00
Lucas A	f60dbbfbbd	Reword import dialogs. ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2021-05-17 12:55:58 +02:00
Lucas A	a7b740fd1d	Reword ImportFromStablePopup and display the popup regardless of whether a stable install is detected.	2021-05-17 12:55:58 +02:00
Lucas A	851e33fd15	Hook up StableImportManager.	2021-05-17 12:55:57 +02:00
Dean Herbert	7137315fa7	Remove HitErrorDisplay container and hook up data	2021-05-17 19:46:50 +09:00
Dean Herbert	ecf70c1707	Remove unnecessary container	2021-05-17 18:55:18 +09:00
Dean Herbert	b80768b44a	Hook up seeking flow	2021-05-17 18:52:56 +09:00
Dean Herbert	0c433cda86	Update HUDOverlay logic to add automatic layout for bottom-aligned components	2021-05-17 18:52:56 +09:00
Dean Herbert	da0913ca2d	Make SongProgress a skinnable component	2021-05-17 18:52:56 +09:00
Dan Balasescu	4151f18f74	Merge pull request #12804 from peppy/fix-autoplay-load-fail-nullref ... Fix a potential nullref when starting `Player` with autoplay disabled and beatmap fails to load	2021-05-17 18:40:05 +09:00
Dean Herbert	1f3ae901ce	Expose DrawableRuleset for consupmtion by HUD components	2021-05-17 18:23:01 +09:00
Dan Balasescu	ce7c503e6e	Merge branch 'master' into playlist-unicode	2021-05-17 11:47:10 +09:00
Salman Ahmed	34d1490754	Remove null conditional ... Shouldn't guard against that here.	2021-05-15 10:00:05 +03:00
Dean Herbert	dc56250a3c	Merge branch 'master' into player-loader-star-rating	2021-05-15 15:39:57 +09:00
Dean Herbert	94b7e89ac0	Merge pull request #12747 from frenzibyte/current-star-rating ... Allow changing current star difficulty of a `StarRatingDisplay`	2021-05-15 15:39:39 +09:00
Dean Herbert	bdcb1a624e	Merge pull request #12759 from Naxesss/beatmap-verifier-context ... Encapsulate check arguments in context object	2021-05-15 15:39:12 +09:00
Bartłomiej Dach	7665bdfbbb	Merge branch 'master' into null-assignment-warning-enable	2021-05-15 01:08:34 +02:00
Bartłomiej Dach	8b4e6d2911	Remove no longer necessary FinishTransforms(true) call ... As the component no longer has any transition transforms applied.	2021-05-14 22:03:35 +02:00
Salman Ahmed	7c2fc9b412	Update usage due to nullability removal	2021-05-14 16:12:33 +03:00
Salman Ahmed	93007c1635	Merge branch 'current-star-rating' into player-loader-star-rating	2021-05-14 16:06:00 +03:00
Salman Ahmed	6cc678f497	Remove nullability and transition support from star rating display	2021-05-14 16:05:40 +03:00
Salman Ahmed	0dc3bfd0c1	Apply simple transforms to star rating display when ready if not	2021-05-14 15:55:26 +03:00
Dean Herbert	f5dd18f266	Use existing LoadedBeatmapSuccessfully bool instead ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-05-14 16:53:51 +09:00
Dean Herbert	67a99c83a3	Tidy bindable changed code up	2021-05-14 16:24:52 +09:00
Salman Ahmed	8338f702c3	Remove not required null conditional	2021-05-14 09:32:56 +03:00
Dean Herbert	dc576c19b4	Fix a potential nullref when starting Player with autoplay enabled and beatmap fails to load	2021-05-14 15:10:02 +09:00
Dean Herbert	48672f8afd	Add very basic test logic to ensure PlayerLoader is present for playlists	2021-05-14 15:02:36 +09:00
Dean Herbert	b36c991ba1	Fix single case of incorrect usage	2021-05-14 12:04:38 +09:00
Salman Ahmed	9e8c0a7e70	Fix online play subscreens not pushing player loaders when starting gameplay	2021-05-14 04:25:29 +03:00
smoogipoo	362a09ca73	Fix up + reduce complexity of HOCEventQueue	2021-05-13 21:41:49 +09:00
smoogipoo	aaf31af326	Add blueprint transferral	2021-05-13 21:16:19 +09:00
smoogipoo	86042e1763	Implement HitObjectContainerEventQueue	2021-05-13 21:15:47 +09:00
Dan Balasescu	d5b14b6b99	Merge branch 'master' into remove-skinnable-hud-classes	2021-05-13 21:06:48 +09:00
Dan Balasescu	746862dcb1	Merge pull request #12750 from peppy/skin-serialisation ... Add skin editor saving / loading support	2021-05-13 20:58:03 +09:00
smoogipoo	ffb6135a1b	Rework hitobject blueprints to take in hitobject models	2021-05-13 19:53:32 +09:00
Dan Balasescu	3c471837f8	Merge branch 'master' into skin-serialisation	2021-05-13 19:49:55 +09:00
Dan Balasescu	a3869c02f4	Merge branch 'master' into fix-two-hovered-handles	2021-05-13 19:24:42 +09:00
Dean Herbert	c8b7cfc753	Merge branch 'skin-serialisation' into remove-skinnable-hud-classes	2021-05-13 19:05:08 +09:00
Naxess	19800f5f7f	Move IBeatmap arg into context	2021-05-13 11:24:22 +02:00
Dean Herbert	106fa97a11	Rename SkinnableElementTargetContainer to SkinnableTargetContainer	2021-05-13 17:07:38 +09:00
Dean Herbert	7921dc7ece	Rename ISkinnableComponent to ISkinnableDrawable	2021-05-13 17:06:00 +09:00
Dean Herbert	cdcd31b546	Replace ISkinSerialisable with IsEditable property	2021-05-13 17:03:17 +09:00
Naxess	b37cb3bdbe	Change interpreted difficulty from bindable to regular value ... There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.	2021-05-13 09:00:30 +02:00
Naxess	4eeeaf6a1a	Keep track of local bound copy	2021-05-13 07:57:32 +02:00
Naxess	e7c7786db3	Merge branch 'master' into beatmap-verifier-context	2021-05-13 07:40:33 +02:00
Dean Herbert	5b71d8ca37	Merge pull request #12758 from Naxesss/verify-settings-ui ... Add setting UI components to the verify screen	2021-05-13 14:35:35 +09:00
Dean Herbert	b81f86bd4d	Move DI resolution to inside BDL parameters	2021-05-13 13:54:06 +09:00
Dean Herbert	c6648112e5	Simplify binding flow in InterpretationSection	2021-05-13 13:51:41 +09:00
Dean Herbert	cdcbaf4291	Tidy up specification of SettingsSection	2021-05-13 13:45:10 +09:00
Dean Herbert	3b862798e9	Standardise naming of methods related to SkinnableInfo	2021-05-13 13:14:49 +09:00
Naxess	47948d7b34	Set default for bindable in object initializer ... Fixes the CI failure.	2021-05-13 06:08:48 +02:00
Naxess	fb305130de	Also refresh when interpreted difficulty changes	2021-05-13 06:00:21 +02:00
Naxess	ee0a6ba93e	Use local bound copy in InterpretationSection as well ... Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.	2021-05-13 05:59:49 +02:00
Dean Herbert	6caf4e3879	Add xmldoc to SkinnableInfo	2021-05-13 12:57:28 +09:00
Naxess	e80d8f6922	Keep track of local bound copy	2021-05-13 05:46:47 +02:00
Naxess	04c1585eb2	Use more consistent lambda discards	2021-05-13 05:38:45 +02:00
Dean Herbert	8b9ac86d4b	Merge branch 'master' into skin-serialisation	2021-05-13 12:35:06 +09:00
Naxess	e86834b740	Use local bound copy for HiddenIssueTypes	2021-05-13 05:25:20 +02:00
Naxess	c8d21f2c3f	Isolate refreshing to IssueList	2021-05-13 05:25:02 +02:00
Naxess	fbb76ba598	Split ShowIssueTypes dict into hidden and configurable lists ... This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides. Bindings are a bit less neat, though.	2021-05-13 04:50:32 +02:00
Naxess	dd8423c4c4	Set interpreted difficulty to correct default	2021-05-13 04:36:20 +02:00
Naxess	6806e40ad9	Remove unnecessary local variable ... This now exists in `VerifyScreen`, which we can access from here.	2021-05-13 04:30:40 +02:00
Naxess	56bd897666	Move ShowIssueTypes to VerifyScreen	2021-05-13 04:29:27 +02:00
Dan Balasescu	4e7c079560	Merge pull request #12753 from peppy/health-bar-hud-overlay-dependency ... Remove downwards dependency from `HUDOverlay` to `HealthDisplay`	2021-05-12 19:27:02 +09:00
Dean Herbert	0a895fff15	Remove remaining test usage of SkinnableXXX HUD components	2021-05-12 18:53:25 +09:00
Salman Ahmed	96d3586294	Fix rotation handle visibility logic not handling two handles hovered at once	2021-05-12 11:42:55 +03:00
Dean Herbert	c6f0a6aed3	Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen ... Implement the multiplayer spectator screen	2021-05-12 17:24:35 +09:00
Dean Herbert	d2e0e8ad94	Reverse direction of binding to allow for better abstract class definitions	2021-05-12 16:53:58 +09:00
Dean Herbert	17e3764576	Rename Settings to have a more localised name	2021-05-12 16:38:04 +09:00
Dean Herbert	494a1b01a5	Move SkinnableElementTargetContainer out of HUD namespace	2021-05-12 15:59:33 +09:00
Dean Herbert	4aad7b96ea	Merge branch 'health-bar-hud-overlay-dependency' into skin-serialisation	2021-05-12 12:54:37 +09:00
Dean Herbert	184dbaf202	Improve safety of bindings in HealthDisplay	2021-05-12 12:53:30 +09:00
Naxess	64d96b06a6	Add interpreted difficulty info to BeatmapVerifierContext ... Enables checks to make use of the difficulty level as shown in the settings UI.	2021-05-12 02:30:21 +02:00
Naxess	c13b93e6f1	Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks ... This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes. See next commit for example.	2021-05-12 02:29:18 +02:00
Naxess	4aeaec6ecc	Add InterpretationSection and its bindable in IssueList ... We'll eventually connect that bindable so that checks can access it.	2021-05-12 01:32:18 +02:00
Naxess	ad78aec1ef	Refresh IssueList on changes in VisibilitySection	2021-05-12 01:30:45 +02:00
Naxess	1bb7d412da	Add IssueList filtering based on those bindables	2021-05-12 01:29:46 +02:00
Naxess	2e4399f0c1	Add VisibilitySection and its bindables in IssueList	2021-05-12 01:27:21 +02:00
Naxess	01b8794757	Add abstract Section class ... Similar to `Section` in the timing screen, but does not make use of checkboxes, nor specific to control points. So there's a lot of things that differ, hence new class instead of factoring that out.	2021-05-12 01:26:12 +02:00
Naxess	1de35f880b	Separate IssueList into own class	2021-05-12 01:23:31 +02:00
Naxess	d3c1ec55ee	Take IssueList in IssueSettings constructor ... We'll be using this for bindables later.	2021-05-12 01:22:32 +02:00
Naxess	97bd482d4d	Factor out load from settings into new Settings class	2021-05-12 01:21:38 +02:00
Dean Herbert	8e226319e2	Remove downwards dependency from HUDOverlay to HealthDisplay	2021-05-11 23:18:23 +09:00
Dean Herbert	048677846b	Change HealthDisplay to be a CompositeDrawable	2021-05-11 23:10:30 +09:00
smoogipoo	9ad1e5067e	Fix spectate being entered while not having the beatmap	2021-05-11 19:22:09 +09:00
Dean Herbert	f55407f871	Show a message when attempting to customisse a screen which doesn't support it	2021-05-11 18:39:15 +09:00
Dean Herbert	a4e0529617	Replace polling logic with direct bindable reactions	2021-05-11 18:39:15 +09:00
Dean Herbert	a88a8b7d8d	Use ISkinnableComponent wherever possible (and expose as BindableList)	2021-05-11 18:39:15 +09:00
Dean Herbert	0cf3efa16b	Remove customisation support for SongProgressDisplay	2021-05-11 18:39:14 +09:00
Dean Herbert	03d5f10744	Fix default health bar not being considered for top-right flow layout	2021-05-11 18:39:14 +09:00
Dean Herbert	944f09ec98	Move default skin cross-component dependencies out to default specifications	2021-05-11 18:39:14 +09:00
Dean Herbert	c94df672e5	Also serialise Origin out	2021-05-11 18:39:14 +09:00
Dean Herbert	f53ce951dc	Remove DefaultScoreCounter animation for the time being ... May add this back in the future, but for now it's causing issues as it operates on `this`. The default skin may be changing quite a bit in the near future, so we can decide what to do about animation at that point in time.	2021-05-11 18:39:14 +09:00
Dean Herbert	4c4d75e6f9	Remove AccuracyCounter sizing dependency in HUDOverlay	2021-05-11 18:39:14 +09:00
Dean Herbert	2396ba42a6	Change HealthDisplay to be a CompositeDrawable	2021-05-11 18:39:14 +09:00
Dean Herbert	bf65547eec	Allow some serialised components to not be mutable by the user	2021-05-11 18:39:14 +09:00
Dean Herbert	4769a95b49	Fix encapsulation and remove target lookup overhead	2021-05-11 18:39:14 +09:00
Dean Herbert	b248b2e5e3	Hook up full save/load flow	2021-05-11 18:39:14 +09:00
Dean Herbert	004798d61d	Update Legacy components to not require skin in ctor	2021-05-11 18:39:14 +09:00
Dean Herbert	b54eb56169	Move new judgement binding to LoadComplete to ensure containers are loaded	2021-05-11 18:39:14 +09:00
Dean Herbert	6a88b8888b	Add basic support for child serialisation	2021-05-11 18:39:14 +09:00
Dean Herbert	df72656aa1	Remove downwards dependency from HUDOverlay to HealthDisplay	2021-05-11 18:39:14 +09:00
Dean Herbert	95a497e9df	Remove unused interface class for simplicity	2021-05-11 18:39:14 +09:00
Dean Herbert	95a8f21ab2	Add the concept of skinnable target containers and mark a basic one for HUD elements	2021-05-11 18:39:14 +09:00
Dean Herbert	67ea4a7e97	Read from skin config	2021-05-11 18:39:14 +09:00
Dean Herbert	b9ab9342fa	Setup basics to allow extracting serializable content from skinnable Drawables	2021-05-11 18:39:14 +09:00
smoogipoo	10a4a5decb	Merge branch 'master' into multiplayer-spectator-screen	2021-05-11 17:33:09 +09:00
Dan Balasescu	7d9cdd3bc2	Merge branch 'master' into skin-components-list	2021-05-11 17:27:48 +09:00
Salman Ahmed	004ce95f33	Merge branch 'current-star-rating' into player-loader-star-rating	2021-05-11 09:53:10 +03:00
smoogipoo	0f00ee8640	Change failure text ... Although this is not visible anywhere.	2021-05-11 11:35:08 +09:00
smoogipoo	8c9390dc75	Remove replay condition	2021-05-11 11:33:21 +09:00
smoogipoo	6db9e26d48	Fix score submission failures with autoplay	2021-05-11 11:28:09 +09:00
smoogipoo	32f7691349	Fix token failure preventing base.LoadAsyncComplete()	2021-05-11 11:24:35 +09:00
Dean Herbert	6bb52ebcf8	Merge pull request #12570 from frenzibyte/corner-rotation-controls ... Add rotation controls to editor selection box corners	2021-05-10 23:09:44 +09:00
Dean Herbert	2ecd638f7f	Merge branch 'master' into skin-components-list	2021-05-10 18:13:10 +09:00
smoogipoo	fa872858b5	Remove unnecessary check	2021-05-10 16:40:06 +09:00
Salman Ahmed	afc9a1bf23	Remove rolling support and apply few adjustments	2021-05-10 10:16:52 +03:00
Dean Herbert	97e72849af	Fix regressed HitErrorDisplay behaviour (and localise binding to meter implementations)	2021-05-10 15:24:13 +09:00
Salman Ahmed	1c49590ba2	Apply further refactoring to star rating display UX-wise	2021-05-10 08:56:30 +03:00
Salman Ahmed	301dab1ce8	Refactor StarRatingDisplay to be mutable with a current bindable	2021-05-10 08:56:30 +03:00
Dan Balasescu	78952c07b0	Merge branch 'master' into remove-hud-overlay-unused-pieces	2021-05-10 14:39:32 +09:00
smoogipoo	35a7226cd8	Add newline	2021-05-10 13:41:04 +09:00
Dean Herbert	52ce16f9f1	Merge branch 'master' into player-loader-star-rating	2021-05-10 12:46:10 +09:00
Dean Herbert	3c3500d070	Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces	2021-05-10 12:23:18 +09:00