1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 09:32:55 +08:00

Address most issues

This commit is contained in:
sh0ckR6 2021-09-20 10:07:42 -04:00
parent 93ca615c02
commit 10fe2382b0
No known key found for this signature in database
GPG Key ID: 701938030071AF85
4 changed files with 10 additions and 4 deletions

View File

@ -280,6 +280,6 @@ namespace osu.Game.Screens.Play.HUD.HitErrorMeters
}
}
public override void Clear() => judgementsContainer.Clear(true);
protected override void Clear() => judgementsContainer.Clear();
}
}

View File

@ -33,7 +33,7 @@ namespace osu.Game.Screens.Play.HUD.HitErrorMeters
judgementsFlow.Push(GetColourForHitResult(judgement.Type));
}
public override void Clear() => judgementsFlow.Clear(true);
protected override void Clear() => judgementsFlow.Clear();
private class JudgementFlow : FillFlowContainer<HitErrorCircle>
{

View File

@ -77,7 +77,7 @@ namespace osu.Game.Screens.Play.HUD.HitErrorMeters
/// Invoked by <see cref="Player.OnSeek"/> when the active <see cref="Player"/> seeks through the current beatmap.
/// Any inheritors of <see cref="HitErrorMeter"/> should have this method clear their container that displays the hit error results.
/// </summary>
public abstract void Clear();
protected abstract void Clear();
protected override void Dispose(bool isDisposing)
{
@ -85,6 +85,9 @@ namespace osu.Game.Screens.Play.HUD.HitErrorMeters
if (processor != null)
processor.NewJudgement -= OnNewJudgement;
if (player != null)
player.OnSeek -= Clear;
}
}
}

View File

@ -69,7 +69,10 @@ namespace osu.Game.Screens.Play
public Action RestartRequested;
public Action OnSeek;
/// <summary>
/// Invoked when a seek has been performed via <see cref="Seek"/>
/// </summary>
public event Action OnSeek;
public bool HasFailed { get; private set; }