14030 Commits

Author	SHA1	Message	Date
Dean Herbert	38244c081f	Further refactorings along with shadow implementation	2023-07-30 02:29:14 +09:00
Dean Herbert	84bc14c1dd	Improve animation and sizing of maximised screen display	2023-07-30 02:29:14 +09:00
Dean Herbert	1826819663	Move Facade to nested class	2023-07-30 02:29:14 +09:00
Dean Herbert	5fa0a21b56	Add corner radius around player areas	2023-07-30 02:29:14 +09:00
Bartłomiej Dach	579b0bc570	Merge branch 'master' into fix-autoplay-mod-revert	2023-07-29 16:12:11 +02:00
Joseph Madamba	a3301dc7ff	Fix accuracy break info decimal separator being incorrect in certain languages	2023-07-28 23:26:07 -07:00
Bartłomiej Dach	1fd4a6dc96	Fix tests crashing due to HUDOverlay not finding DrawableRuleset in Update()	2023-07-29 01:07:49 +02:00
Bartłomiej Dach	4db203ecc3	Merge branch 'master' into playfield-skin-layer	2023-07-29 00:01:06 +02:00
Bartłomiej Dach	c6f0cf50ca	Use better safety in rectangular grid ... - Checking `DrawSize != Vector2.Zero` is too specific. It could also crash on zero-height-but-non-zero-width, or zero-width-but-non-zero-height. - Take the `gridCache.Validate()` call out of the zero checks, because even if the width or height are zero, not generating anything is valid and there is no reason to validate every frame until `gridCache` gets invalidated again.	2023-07-28 22:57:02 +02:00
QuantumSno	a4065486c1	bound bind during gameplay	2023-07-28 14:39:41 -04:00
Dean Herbert	0e4db9b439	Add safety in RectangularPositionSnapGrid that size is greater than zero ... Would crash otherwise	2023-07-28 16:25:40 +09:00
Dean Herbert	6cf065f6d1	Add playfield layer to skin editor	2023-07-28 15:50:44 +09:00
Dean Herbert	f15394fb6d	Fix temporary auto mod (ctrl+enter at song select) not reverting in all scenarios	2023-07-28 14:49:06 +09:00
Joseph Madamba	9d87ff2986	Improve supporter-only duration notice and fix max duration of non-supporter ... See 3c54229256/.env.example (L230). Might have more duration options in the future.	2023-07-26 01:37:55 -07:00
Dean Herbert	4889864478	Fix files references not correctly being copied after replay import in Player	2023-07-26 15:22:00 +09:00
Dean Herbert	e26afc2b89	Fix ReplayDownloadButton handling key repeat	2023-07-26 15:21:43 +09:00
Joseph Madamba	30e0e00c52	Rename selectedAvailableDuration to hasValidDuration	2023-07-25 22:57:01 -07:00
Dean Herbert	7fd6bb9d5f	Fix a couple of code style issues in SelectionBox	2023-07-26 14:04:38 +09:00
Dean Herbert	39c2bb240b	Apply NRT to SelectionBoxRotationHandle.	2023-07-26 14:04:21 +09:00
Joseph Madamba	0bd34a4f13	Always show supporter-only playlist durations	2023-07-25 21:14:21 -07:00
Bartłomiej Dach	57ccf82f34	Merge branch 'master' into song-select-drain-length	2023-07-25 22:40:45 +02:00
Bartłomiej Dach	3b11559fd0	Revert "Show only the break length instead of total minute breaks" ... This reverts commit 9edaa6909e.	2023-07-25 22:17:55 +02:00
Bartłomiej Dach	3b9f250c1b	Merge branch 'master' into menu-star-fountains	2023-07-25 21:58:13 +02:00
Dean Herbert	3485b72eaa	Disallow interacting with the global track state in Player and Editor	2023-07-25 20:20:53 +09:00
Dean Herbert	6146f30541	Allow screens to change the ability to interact with the global track	2023-07-25 20:20:53 +09:00
Dean Herbert	157b1f301b	Rename AllowTrackAdjustments to more understandable ApplyModTrackAdjustments	2023-07-25 20:20:53 +09:00
Dean Herbert	eac6271bd0	Add new property to avoid overlapping usages	2023-07-25 18:14:03 +09:00
Dean Herbert	9edaa6909e	Show only the break length instead of total minute breaks	2023-07-25 17:02:27 +09:00
Dean Herbert	480163ec2e	Show drain length in length tooltip at song select	2023-07-25 16:58:53 +09:00
Bartłomiej Dach	a201152b04	Add xmldoc to SelectionRotationHandler	2023-07-23 20:56:22 +02:00
Bartłomiej Dach	aec3ca250c	Migrate SelectionHandler to use SelectionRotationHandler	2023-07-23 20:56:22 +02:00
Bartłomiej Dach	ba8ebefb50	Add basic structure for new rotation handler	2023-07-23 20:56:22 +02:00
Bartłomiej Dach	4622255cc7	Move out helper methods to static class	2023-07-23 18:24:20 +02:00
Bartłomiej Dach	9f68bb4e4a	Merge pull request #24333 from peppy/editor-menu-spacer ... Adjust metrics of editor menu spacers (and make visible)	2023-07-23 15:25:27 +02:00
Dean Herbert	4bf300d64d	Merge pull request #24186 from OliBomby/legacy-export ... Add ability to export beatmaps from editor in a stable-compatible format	2023-07-23 15:25:06 +09:00
Dean Herbert	4ea8495c61	Adjust metrics of editor menu spacers (and make visible)	2023-07-23 14:12:37 +09:00
Dean Herbert	fb34ee94c2	Move export/save options to bottom of menu	2023-07-23 14:07:31 +09:00
Dean Herbert	20359c90bc	Adjust localisations slightly	2023-07-23 14:06:00 +09:00
Dean Herbert	d11e56b8bb	Add common Export string and use in editor	2023-07-23 14:03:50 +09:00
Bartłomiej Dach	d1c69283b2	Merge branch 'master' into editor-key-count	2023-07-22 16:11:21 +02:00
Bartłomiej Dach	f985bdc10f	Make difficulty sliders private set	2023-07-22 15:55:20 +02:00
Dean Herbert	fd2bdc10c7	Fix "key count" setting showing as "circle size" in osu!mania editor ... Closes https://github.com/ppy/osu/issues/12904.	2023-07-21 18:52:29 +09:00
Dean Herbert	82a5ba66e1	Align mode switcher with rest of interface	2023-07-21 15:27:42 +09:00
Dean Herbert	cdcb10e0e7	Fix timeline centre point being ever-so-slight off	2023-07-21 15:26:41 +09:00
Dean Herbert	f489dbd7a9	Reduce width of right toolbar ever so slightly (and use more shared constants)	2023-07-21 14:39:15 +09:00
Dean Herbert	870f3e324a	Adjust "test" button to better align with rest of interface	2023-07-21 14:26:33 +09:00
Dean Herbert	ca3d1538ae	Merge branch 'master' into editor-metrics	2023-07-21 14:26:32 +09:00
Dean Herbert	2cb1a6fdaa	Adjust metrics further	2023-07-21 14:23:53 +09:00
Dean Herbert	b29a2081ac	Merge branch 'master' into menu-star-fountains	2023-07-21 14:21:16 +09:00
Bartłomiej Dach	c77d3cd6bd	Merge pull request #24294 from peppy/toggle-all-freemods ... Add ability to toggle all free mods quickly at multiplayer song select	2023-07-20 22:32:53 +02:00
Bartłomiej Dach	07e0a703d7	Adjust inline comment	2023-07-20 20:51:39 +02:00
Bartłomiej Dach	708dd355cd	Merge branch 'master' into editor-cyclic-selection	2023-07-20 20:19:46 +02:00
Bartłomiej Dach	210e114f7d	Merge branch 'master' into editor-prefer-closest	2023-07-20 19:16:09 +02:00
Bartłomiej Dach	511948ba56	Add xmldoc to ApplySelectionOrder()	2023-07-20 19:16:04 +02:00
Dean Herbert	c93d6a4008	Invert text colour when freemods is enabled for better contrast	2023-07-20 13:04:26 +09:00
Dean Herbert	18c5fc689f	Don't expose such specific information from ModSelectOverlay	2023-07-20 12:58:13 +09:00
Dean Herbert	4057fcd70e	Merge branch 'master' into toggle-all-freemods	2023-07-20 12:56:46 +09:00
Bartłomiej Dach	285a232cc2	Merge pull request #24290 from peppy/beatmap-offset-all-difficulties ... Change offset calibration control to adjust for all difficulties of the current beatmap set	2023-07-19 22:31:38 +02:00
Bartłomiej Dach	f3a95d4c13	Merge branch 'master' into menu-star-fountains	2023-07-19 21:26:41 +02:00
Bartłomiej Dach	764029bde1	Fix nullability inspection	2023-07-19 19:23:08 +02:00
Dean Herbert	e47722565a	Clarify guard condition in RoomSubScreen	2023-07-19 19:39:10 +09:00
Dean Herbert	18aace177a	Fix deadlock when logging out while at the create match screen ... Closes https://github.com/ppy/osu/issues/24275.	2023-07-19 19:37:38 +09:00
Dean Herbert	eb149942e5	Add ability to toggle all free mods quickly at multiplayer song select	2023-07-19 19:08:32 +09:00
Dean Herbert	cf3949c9e2	Fix double-click handling when cyclic selection is enabled ... Removes the limitations of cyclic selection as a result.	2023-07-19 17:21:20 +09:00
Dean Herbert	5ec9cd84b2	Change offset calibration control to adjust for all difficulties of the current beatmap set	2023-07-19 17:13:19 +09:00
Dean Herbert	5ade093c5a	Change editor to always perform selection of closest object	2023-07-19 16:56:16 +09:00
Dean Herbert	55a41b0887	Fix overlap between header text and menu items	2023-07-19 15:13:20 +09:00
Dean Herbert	871056790b	Mark editor tile as non-localisable	2023-07-19 15:01:20 +09:00
Dean Herbert	7f336b8dac	Merge branch 'master' into editor-metrics	2023-07-19 15:00:51 +09:00
Dean Herbert	ba237a0e3a	Convert StarFountain to use ParticleSpewer ... More efficient	2023-07-18 20:04:52 +09:00
OliBomby	395dd23966	Put 'Export package' and 'Export legacy package' in one nested menu	2023-07-18 12:37:37 +02:00
OliBomby	5d82190b70	Merge remote-tracking branch 'upstream/master' into legacy-export	2023-07-18 12:18:49 +02:00
Dean Herbert	f4acc86df8	Adjust metrics to closer match expectations	2023-07-18 16:26:37 +09:00
Dean Herbert	49bb0b190a	Split out star constant to reuse in pool definition	2023-07-18 16:14:54 +09:00
Bartłomiej Dach	7fbd47e9ee	Fix MultiplayerMatchSubScreen erroneously pushing exit dialog on API failure ... If `IAPIProvider.State` changes from `Online` at any point when being on an `OnlinePlayScreen`, it will be forcefully exited from. However, `MultiplayerMatchSubScreen` had local logic that suppressed the exit in order to show a confirmation dialog. The problem is, that in the suppression logic, `MultiplayerMatchSubScreen` was checking `MultiplayerClient.IsConnected`, which is a SignalR flag, and was not checking `IAPIAccess.State`, which is maintained separately. Due to differing timeouts and failure thresholds, it is not impossible to have `MultiplayerClient.IsConnected == true` but `IAPIAccess.State != APIState.Online`. In such a case, the match subscreen would wrongly consider itself to be still online and due to that, push useless confirmation dialogs, while being in the process of being forcefully exited. This then caused the dialog to cause a crash, as it was calling `.Exit()` on the screen which would already have been exited by that point, by the force-exit flow.	2023-07-16 19:56:22 +02:00
Aki	cb354685ca	simplify code	2023-07-16 10:21:32 +08:00
Aki	309c852222	Compute the top local rank directly without an expensive detach call	2023-07-15 23:00:13 +08:00
Dean Herbert	85c780ae5b	Allow the osu! logo to be proxied locally into scenes	2023-07-14 19:19:14 +09:00
Dean Herbert	fe70f24925	Update design of summary timeline current time marker	2023-07-14 17:00:42 +09:00
Dean Herbert	e6b8cd0c06	Add editor header	2023-07-14 16:55:12 +09:00
Dean Herbert	57abb15724	Update design of timeline centre marker and adjust surrounding paddings	2023-07-14 16:37:57 +09:00
Dean Herbert	00e9746174	Implement longer design for timing point piece	2023-07-14 16:37:56 +09:00
Dean Herbert	6b222cfafd	Fix slight misalignment so timeline is now completely centered	2023-07-14 14:29:13 +09:00
Dean Herbert	01750dd091	Update metrics of checkboxes and backgrounds to match design better	2023-07-14 14:29:02 +09:00
Dean Herbert	5b2e704264	Move beat divisor control inside of TimelineArea and adjust metrics to match design	2023-07-14 14:19:04 +09:00
Dean Herbert	ebaf63b764	Apply NRT to timeline related classes	2023-07-14 14:04:12 +09:00
Dean Herbert	56acc9e3dd	Change BeatDivisorControl to retrive bindable divisor via DI	2023-07-14 14:03:25 +09:00
Bartłomiej Dach	ff56e35093	Merge pull request #24197 from peppy/allow-autoplay-failure ... Allow autoplay to fail	2023-07-13 23:44:07 +02:00
Bartłomiej Dach	96e4b8d792	Merge pull request #24204 from peppy/results-screen-component-metrics ... Touch up various results screen component's metrics	2023-07-13 22:03:49 +02:00
Dean Herbert	ded7ec3aa6	Merge branch 'master' into framework-clipboard	2023-07-14 03:32:37 +09:00
Bartłomiej Dach	20bde40ce2	Fix differing anchor specs on statistics panel flow items	2023-07-13 20:00:29 +02:00
Dean Herbert	1051982bc5	Tidy up code with constants	2023-07-13 23:25:50 +09:00
Dean Herbert	8f826a3702	Add skinning support for kiai fountain stars	2023-07-13 22:57:04 +09:00
Dean Herbert	53fccaa3bd	Use skinnable sprite	2023-07-13 22:30:27 +09:00
Dean Herbert	1698caa078	Add kiai fountains to main menu	2023-07-13 22:13:40 +09:00
Dean Herbert	20e4e2581a	Change IBeatSyncProvider.Clock to always be non-null	2023-07-13 22:13:40 +09:00
Dean Herbert	2c27b17c85	Disable masking on inner scroll container	2023-07-13 19:01:59 +09:00
Dean Herbert	e34839c891	Rename StatisticContainer to StatisticItemContainer and add a background	2023-07-13 18:59:11 +09:00
Dean Herbert	b333945cde	Change OverallRanking to use a two-column layout similar to statistics table	2023-07-13 18:45:32 +09:00
Dean Herbert	0881f4772c	Adjust metrics of HitEventTimingDistributionGraph	2023-07-13 18:45:32 +09:00
Dean Herbert	947b40149f	Adjust metrics of SimpleStatisticTable	2023-07-13 18:45:32 +09:00
Dean Herbert	d54cf63983	Centralise font size specification for statistic items (and reduce slightly)	2023-07-13 18:31:40 +09:00
Dean Herbert	f223fd7c3b	Adjust metrics of PerformanceBreakdown	2023-07-13 18:30:57 +09:00
Dean Herbert	7637a9e603	Adjust metrics of OverallRanking	2023-07-13 18:30:57 +09:00
Dean Herbert	98bf15182e	Remove more GridContainer nonsense	2023-07-13 18:30:57 +09:00
Dean Herbert	1d62a041cc	Fix animation restarting unexpectedly	2023-07-13 15:07:26 +09:00
Dean Herbert	21f26f98da	Fix graph breaking when resized vertically	2023-07-13 14:57:01 +09:00
Dean Herbert	e2b5abd4e8	Split bar drawable creation into own method	2023-07-13 14:43:41 +09:00
Dean Herbert	fbf14a0f7c	Allow autoplay to fail ... Feels more correct.	2023-07-13 13:41:35 +09:00
Dean Herbert	4f4c481a67	Fix timing distribution graph sometimes not displaying correctly ... Weird "basal" height logic just didn't make any sense (was getting stuck at 1 when `DrawHeight` was 0)	2023-07-12 19:21:39 +09:00
Susko3	2dcd790442	Resolve Clipboard via DI	2023-07-11 11:42:31 +02:00
OliBomby	06e5ef88c0	legacy export broken	2023-07-11 02:30:16 +02:00
Bartłomiej Dach	45194b2b4a	Fix pressing Ctrl-C in composer not copying timestamp to system clipboard	2023-07-09 18:21:43 +02:00
Bartłomiej Dach	84138849cf	Merge pull request #24134 from peppy/skin-retry-sound ... Add support for skinnable "retry" sound	2023-07-08 15:24:26 +02:00
Bartłomiej Dach	10da80638b	Merge pull request #24152 from peppy/results-screen-tweens ... Adjust results screen transition tweens to feel better	2023-07-08 14:15:37 +02:00
Bartłomiej Dach	287418e214	Merge branch 'master' into skin-retry-sound	2023-07-08 14:00:52 +02:00
Bartłomiej Dach	832c1c0009	Merge branch 'master' into fix-gameplay-samepl-trigger-source-rewind	2023-07-08 13:33:04 +02:00
Dean Herbert	82babbf8fa	Adjust results screen transition tweens to feel better	2023-07-07 17:39:54 +09:00
Dean Herbert	d72765b6f8	Merge pull request #24114 from peppy/editor-save-local-score-management ... Ensure scores always have the correct linked `BeatmapInfo`	2023-07-07 15:40:54 +09:00
Dean Herbert	67746e1369	Move retry sample playback to PlayerLoader	2023-07-07 15:36:17 +09:00
Dean Herbert	e0fc97bb93	Replace various local implementations of rewinding checks with new property	2023-07-07 15:21:24 +09:00
Dean Herbert	ddd65f5fe7	Merge pull request #24135 from peppy/update-realm ... Bring realm library up-to-date	2023-07-07 10:59:38 +09:00
Dean Herbert	2e98ab0a48	Expose rewinding state of IGameplayClocks ... The implementation of this requires a bit of a special case for 0, so makes sense to implement in a central place.	2023-07-06 19:08:42 +09:00
Dean Herbert	f69f6adf67	Remove beatmap info wedge rotation animation ... It looks jank and also causes framebuffer overheads. But mostly because it looks jank.	2023-07-06 16:15:42 +09:00
Dean Herbert	a98a36872e	Bring realm library up-to-date	2023-07-06 13:37:43 +09:00
Dean Herbert	9ff6b3fcd3	Merge branch 'master' into editor-save-local-score-management	2023-07-06 12:28:44 +09:00
Dean Herbert	170bc5bfce	Add support for skinnable "retry" sound	2023-07-06 12:25:15 +09:00
Bartłomiej Dach	cdb8a56df4	Remove weird aliased using ... Doesn't appear to be required.	2023-07-05 22:41:22 +02:00
Dean Herbert	9291895305	Make key for toggling replay settings customisable	2023-07-06 01:00:41 +09:00
Dean Herbert	95a9b532df	Remember state of replay settings visibility	2023-07-06 00:53:37 +09:00
Dean Herbert	fbab5acac1	Remove not-yet-implemented settings group comments	2023-07-06 00:46:09 +09:00
Bartłomiej Dach	e2ddcb2349	Silence a few remaining nullability warnings	2023-07-04 22:39:26 +02:00
Dean Herbert	d74b1e148d	Make ScoreInfo.BeatmapInfo nullable	2023-07-04 14:50:34 +09:00
Bartłomiej Dach	21f758947d	Merge branch 'master' into availability-fixes	2023-07-02 20:38:37 +02:00
Bartłomiej Dach	9eec1337b3	Use slightly different condition for better UX	2023-07-01 21:39:08 +02:00
Bartłomiej Dach	183777f8df	Fix edge cases where selection buttons go outside playfield bounds ... Addresses https://github.com/ppy/osu/discussions/23599#discussioncomment-6300885.	2023-07-01 21:27:17 +02:00
Dean Herbert	5f880397a9	Increase the minimum size of the scroll bar ... Allows easier targetting when there is a lot of content in the scroll view As discussed in https://github.com/ppy/osu/discussions/24095#discussioncomment-6332398.	2023-07-02 00:04:56 +09:00
Bartłomiej Dach	e4e08c0f5f	Fix selection handlers eating hotkey presses they didn't handle	2023-06-28 20:48:22 +02:00
Dean Herbert	3883c28b15	Add visual display in participants list when availability is still being established	2023-06-28 16:02:46 +09:00
Dean Herbert	91354b1570	Avoid performing any actions when BeatmapAvailability is updated to Unknown	2023-06-28 16:01:54 +09:00
Dean Herbert	29376ffcc0	Trigger state change when flipping via hotkey in the editor ... This will trigger a change even if nothing happens. But I think that's okay (not easy to avoid) because the change handler should be aware that nothing changed, if anything. Closes https://github.com/ppy/osu/issues/24065.	2023-06-28 13:52:51 +09:00
Dean Herbert	1d4380cfd0	Merge pull request #24058 from peppy/full-term-exact-match ... Add support for matching full terms at song select using suffixed `!`	2023-06-28 12:14:15 +09:00
Dean Herbert	076f41be12	Merge pull request #24059 from peppy/add-editor-rotate-hotkeys ... Add support for `Ctrl` + `<` / `>` to rotate selection in editor	2023-06-28 12:03:34 +09:00
Bartłomiej Dach	9be2d9d62e	Fix hotkey presses generating unnecessary undo history ... The buttons don't check whether the operation they correspond to is possible to perform in the current state of the selection box, so not checking `Can{Reverse,Rotate}` causes superfluous undo states to be added without any real changes if an attempt is made to reverse or rotate a selection that cannot be reversed or rotated.	2023-06-27 22:25:04 +02:00
Bartłomiej Dach	17ed45d07c	Mention hotkeys in button tooltips	2023-06-27 22:04:15 +02:00
Bartłomiej Dach	54280f06be	Switch to == true	2023-06-27 22:02:15 +02:00
Bartłomiej Dach	ad3a470eaf	Enable NRT in SelectionBox	2023-06-27 22:01:44 +02:00
Bartłomiej Dach	eb6bdb5a38	Merge pull request #23926 from ItsShamed/hud/kc-skinnable ... Make key counter skinnable	2023-06-27 21:57:41 +02:00
Bartłomiej Dach	bf99fc61b8	Trim full phrase filters in a more precise manner	2023-06-27 21:50:36 +02:00
Bartłomiej Dach	e3d97b37f1	Rename MatchMode.{None -> Substring}	2023-06-27 21:28:37 +02:00
Bartłomiej Dach	06654dc618	Merge branch 'master' into full-term-exact-match	2023-06-27 21:27:39 +02:00
Bartłomiej Dach	af66ccbfdf	Merge branch 'master' into hud/kc-skinnable	2023-06-27 20:35:47 +02:00
Dean Herbert	c6d952abe3	Add support for Ctrl + < / > to rotate selection in editor ... As discussed in https://github.com/ppy/osu/discussions/24048.	2023-06-27 17:01:41 +09:00
Dean Herbert	7ddbf4eaa7	Add a visual effect when keyboard shortcuts are used to trigger selection box buttons	2023-06-27 17:01:13 +09:00
Dean Herbert	41890cfc65	Change JudgementCountController to a Component and remove handling overrides	2023-06-27 16:39:21 +09:00
Dean Herbert	8bd6f7a46a	Rename ClicksPerSecondCalculator to ClicksPerSecondController	2023-06-27 16:38:46 +09:00
Dean Herbert	de23a4691e	Change JudgementCountController to a Component	2023-06-27 16:38:15 +09:00
Dean Herbert	113b570bd4	Move controllers above skinnable elements in initialisation order	2023-06-27 16:37:23 +09:00
Dean Herbert	e21583ff1b	Refactor InputCountController to not require being added to foreign body via Attach ... I've made the flow match `ClicksPerSecondCalculator` as close as possible. Hopefully this reads better.	2023-06-27 16:36:00 +09:00
Dean Herbert	c423f77d53	Add support for matching full terms using suffixed !	2023-06-27 15:34:33 +09:00
Dean Herbert	702266198b	Add missing "title=" search support at song select	2023-06-27 15:21:13 +09:00
Bartłomiej Dach	9c30b1d3e0	Merge branch 'master' into exact-match-song-select	2023-06-26 22:33:50 +02:00
Bartłomiej Dach	4cb122dad4	Escape user input before embedding into regex	2023-06-26 22:27:48 +02:00
Bartłomiej Dach	8a7a42b7ec	Remove weird nullable enable and double licence header	2023-06-26 22:19:52 +02:00
timiimit	e1cbcabe0b	Fix skip not always triggering in multiplayer	2023-06-26 21:26:41 +02:00
Bartłomiej Dach	7200855d46	Rename Judgement{Tally -> CountController}	2023-06-26 19:30:04 +02:00
Bartłomiej Dach	8d91580dc1	Rename {KeyCounter -> InputCount}Controller	2023-06-26 19:27:42 +02:00
Bartłomiej Dach	4ac48e4cd8	Group input handling members together	2023-06-26 19:25:52 +02:00
Bartłomiej Dach	ff562e2dd7	Remove redundant guard ... In this particular case guarding with `.IsNull()` makes no sense, as the `Trigger` is supplied in constructor and cannot feasibly be null. Doing that only makes sense in scenarios where BDL / dependency injection is involved.	2023-06-26 19:25:52 +02:00
Bartłomiej Dach	dbd76c1193	Fix attempting to add key counter controller to hierarchy in multiple places	2023-06-26 19:02:49 +02:00
Dean Herbert	a74547c43c	Add exact match support at song select	2023-06-26 18:26:44 +09:00
Dean Herbert	14c95f4584	Apply NRT to FilterCriteria	2023-06-26 17:54:11 +09:00
Dean Herbert	44c08f3944	Add xmldoc for KeyCounterController	2023-06-26 16:47:33 +09:00
Dean Herbert	c8e081c2b6	Remove unused interface	2023-06-26 16:32:19 +09:00
Dean Herbert	ec20942830	Actuall add composite component to hierarchy	2023-06-26 16:24:36 +09:00
Dean Herbert	0c869367e1	Merge branch 'master' into hud/kc-skinnable	2023-06-26 15:53:16 +09:00
Dean Herbert	b240ce295b	Rename class and key to better match expectations	2023-06-26 13:38:34 +09:00
Bastian Pedersen	a7153478d6	Use newly create localised strings for buttons	2023-06-25 21:03:07 +02:00
tsrk	350d722c8d	Merge branch 'master' into hud/kc-skinnable	2023-06-25 15:42:08 +02:00
tsrk	a7088ffe22	revert: bring back old attachment flow ... As discussed, this would bring more problems that anything. Refs: 4c39708, f83a4f4	2023-06-25 15:21:55 +02:00
Dean Herbert	3d1a8aeb54	Use more understandable cancel button text	2023-06-25 21:25:16 +09:00
Bartłomiej Dach	a7202721ff	Merge branch 'master' into no-confirmation-on-update-restart	2023-06-25 13:35:21 +02:00
Bartłomiej Dach	e273c223a8	Fix some more missed CI inspections	2023-06-24 17:11:38 +02:00
Bartłomiej Dach	e3a89a6273	Fix remaining obvious CI inspections	2023-06-24 16:07:01 +02:00
Dean Herbert	df5b389629	Manual fixes to reduce warnings to zero	2023-06-24 01:52:53 +09:00
Dean Herbert	0ab0c52ad5	Automated pass	2023-06-24 01:00:03 +09:00
Dean Herbert	1dc7c05c12	Merge branch 'master' into no-confirmation-on-update-restart	2023-06-23 15:33:01 +09:00
Dean Herbert	f66b787b12	Show ongoing operations in exit confirmation dialog ... Also changes the button to a dangerous button, forcing user acknowledgement	2023-06-23 15:20:19 +09:00
Dean Herbert	693b7c9906	Reorganise resolved fields in MainMenu	2023-06-23 15:19:47 +09:00
Dean Herbert	20aedc82ac	Remove unused code	2023-06-23 14:47:32 +09:00
Dean Herbert	6df617d536	Rename ExitConfirmOverlay to be more explicit about purpose	2023-06-23 14:46:38 +09:00
Dean Herbert	11a97e1bb8	Move confirmation bypass implementation to MainMenu to allow for more correct logic	2023-06-23 14:42:56 +09:00
Bartłomiej Dach	0ce4d17e30	Merge pull request #23888 from peppy/fix-intro-playing-twice ... Fix music sometimes restarting twice if exiting song select with no beatmap selected	2023-06-22 22:49:15 +02:00
Bartłomiej Dach	a753c89dea	Merge pull request #23974 from peppy/fix-multiplayer-present-beatmap ... Fix presenting beatmaps while in a multiplayer room not working	2023-06-22 22:48:48 +02:00
Bartłomiej Dach	65d4506ef2	Merge branch 'master' into save-replay-hotkey	2023-06-22 18:51:30 +02:00
Dean Herbert	07a00e8afd	Fix typo in comment ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-06-22 00:02:02 +09:00
Dean Herbert	7b4cbea362	Allow nullable to fix test usages ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-06-22 00:01:48 +09:00
Dean Herbert	59b1f08d53	Don't require exit confirmation when there are no ongoing operations that could be interrupted	2023-06-21 19:06:28 +09:00
Dean Herbert	655491ae2d	Fix potential null ref in ResultsScreen	2023-06-21 17:50:06 +09:00
Dean Herbert	1907beb0c9	Add FireAndForget to stray Task.Run	2023-06-21 17:48:55 +09:00
Dean Herbert	9ca772421d	Improve and combine logic that exists in two classes	2023-06-21 17:48:12 +09:00
Dean Herbert	2e02b4a85b	Apply more correct fix for double-playing menu track	2023-06-20 18:35:51 +09:00
Dean Herbert	0a81170bca	Merge branch 'master' into fix-intro-playing-twice	2023-06-20 18:34:22 +09:00
Dean Herbert	10ed3787a0	Don't show song select screen when local user doesn't have permission to add an item	2023-06-20 18:27:19 +09:00
Dean Herbert	dc1b4a39aa	Fix presenting beatmaps while in a multiplayer room not working	2023-06-20 18:23:59 +09:00
Dean Herbert	4bd121d3b8	Also add hotkey to export replays	2023-06-20 16:54:37 +09:00
Dean Herbert	1e0e29847f	Apply NRT and hotkey support to save replay button at results screen	2023-06-20 16:29:15 +09:00
Dean Herbert	69526f25bb	Add hotkey to save replay ... Defaults to `F2` aka stable.	2023-06-19 20:45:29 +09:00
Dean Herbert	84fc6e92db	Fix slightly incorrect calculations	2023-06-19 20:23:46 +09:00
Dean Herbert	4314f9f46a	Merge branch 'master' into fix-distance-snap-grid-centering	2023-06-19 20:22:09 +09:00
tsrk	f83a4f4952	refactor: tidy up attachement flow ... TODO: find better naming and improve XMLDocs	2023-06-18 22:57:21 +02:00
tsrk	141f9efad5	style(KeyCounterController): remove reliance on Receptor	2023-06-18 21:26:16 +02:00
tsrk	1a8219adf6	style: guard event handler unsubscriptions	2023-06-18 20:20:56 +02:00
Ruki	9c6c6bf1ea	Merge branch 'master' into hud/kc-skinnable	2023-06-18 18:30:44 +02:00
Dean Herbert	425d3c23f5	Fix some code layout and NRT some classes	2023-06-19 01:03:43 +09:00
Bartłomiej Dach	9ba4bf5fb7	Merge branch 'master' into add-mod-search-option	2023-06-18 15:06:21 +02:00
Dean Herbert	eb31fdecee	Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change ... See https://github.com/ppy/osu-framework/pull/5834	2023-06-18 20:57:32 +09:00
Bartłomiej Dach	eafd774044	Bring back old formatting spec	2023-06-17 20:03:24 +02:00
Dean Herbert	4919069ea6	Avoid humanizer regex compilation overhead when opening song select for the first time	2023-06-18 02:19:03 +09:00
Bartłomiej Dach	2976145150	Merge pull request #23937 from peppy/order-by-total-score-extension ... Move `OrderByTotalScore()` to an extension method	2023-06-16 22:18:27 +02:00
Ruki	66f44452d2	Merge branch 'master' into hud/kc-skinnable	2023-06-16 17:30:33 +02:00
Bartłomiej Dach	28696f595f	Privatise setter	2023-06-16 16:24:07 +02:00
Dean Herbert	d965d39c44	Fix distance snap grid circles not correctly being centered on snap point	2023-06-16 17:21:32 +09:00
Dean Herbert	36954e55ad	Fix incorrect mapping when distance spacing is not 1.0x	2023-06-16 17:15:45 +09:00
Dean Herbert	003949ac4e	Merge branch 'master' into limited-distance-spacing	2023-06-16 16:56:22 +09:00
Dean Herbert	362aa4b376	Also move GetMaxAchievableCombo	2023-06-16 15:26:13 +09:00
Dean Herbert	ce41ef6e5d	Move OrderByTotalScore() to an extension method	2023-06-16 15:24:30 +09:00
Dean Herbert	6f0c8c286b	Merge pull request #23906 from Joehuu/truncate-room-name ... Truncate online play drawable room name text	2023-06-16 00:22:04 +09:00
Ruki	aba8219d06	Merge branch 'master' into hud/kc-skinnable	2023-06-15 15:48:43 +02:00
tsrk	fcdaf72915	style(KeyCounter): remove useless IsCounting bindable ... Counting logic has been moved to the `Trigger`	2023-06-15 12:40:47 +02:00
tsrk	184c793f56	style(KeyCounter): remove useless Content override	2023-06-15 12:39:22 +02:00
tsrk	a61c1116f5	style: remove unused IAttachableSkinComponent on KCD	2023-06-15 12:27:37 +02:00
Salman Ahmed	39db17d2e9	Use better method to avoid rewinding to deleted beatmaps	2023-06-15 11:22:11 +03:00
Salman Ahmed	cabb4dfaa8	Merge branch 'master' into fix-rewind-bug	2023-06-15 10:59:15 +03:00
Salman Ahmed	2360219b55	Merge branch 'master' into fix-rewind-bug	2023-06-15 10:48:23 +03:00
Dan Balasescu	e78950a162	Merge pull request #23884 from peppy/argon-progress-visibility-light-background ... Adjust argon progress display to work well on bright backgrounds	2023-06-15 15:50:53 +09:00
tsrk	42b740a175	Merge branch 'master' into hud/kc-skinnable	2023-06-14 22:19:45 +02:00
tsrk	e26aeea589	feat: make KeyCounterDisplay skinnable	2023-06-14 21:15:12 +02:00
tsrk	c637fddf73	refactor: decouple Trigger logic from KeyCounterDisplay ... This allows to keep a coeherent state regardless of the progress of the play	2023-06-14 21:13:35 +02:00
tsrk	e9ef270e46	refactor: move count logic in InputTrigger ... This will allow us to keep track of the real count regardless of whether the key counter has been placed mid-replay or not.	2023-06-14 19:39:28 +02:00
Salman Ahmed	24d8e336e2	Remove width limit on room status text in favour of cell distribution	2023-06-14 07:55:09 +03:00
Joseph Madamba	05bdc92426	Add right padding according to right detail shear	2023-06-13 14:00:56 -07:00
Joseph Madamba	2a3f2ff122	Truncate room name text	2023-06-13 13:56:29 -07:00
Joseph Madamba	df49a48d4d	Put left and right details inside GridContainer	2023-06-13 13:48:47 -07:00
Dean Herbert	f553efba8a	Fix playback controls in editor handling key repeat when they probably shouldn't ... Closes https://github.com/ppy/osu/issues/23903.	2023-06-14 02:30:15 +09:00
Joseph Madamba	0adb399ea8	Use anchor instead of FillFlowContainer	2023-06-13 00:09:58 -07:00
Joseph Madamba	a5c3c9a93f	Use FillFlowContainer instead of GridContainer for drawable room background gradient	2023-06-12 23:30:08 -07:00
Bartłomiej Dach	af3fbdbfbe	Merge pull request #23829 from Joehuu/truncating-text-tooltips ... Add tooltips to truncated text	2023-06-12 23:43:31 +02:00
Salman Ahmed	7269b4807e	Merge branch 'master' into improve-song-select-enter-performance	2023-06-12 13:13:59 +03:00
Dean Herbert	a201339f9c	Fix background track restarting twice when exiting song select with no active selection	2023-06-12 17:12:38 +09:00
Dean Herbert	a1b17c4468	Adjust log output for global background changes to make more sense	2023-06-12 17:12:18 +09:00
Dean Herbert	855185ca85	Adjust argon song progress bar's background fill to always display	2023-06-12 16:43:28 +09:00
Dean Herbert	84670d4c90	Adjust argon graph to use a non-gray colour range	2023-06-12 16:22:40 +09:00
Cootz	036479dd9d	Merge branch 'master' into add-mod-search-option	2023-06-09 16:27:18 +03:00
Dean Herbert	c2663f27a1	Fix audio settings not displaying while watching a replay	2023-06-09 17:58:44 +09:00
Dean Herbert	78b2e6f3df	Add setting to limit distance snapping to current time ... As discussed in https://github.com/ppy/osu/discussions/23815#discussioncomment-6124116.	2023-06-09 15:54:33 +09:00
Dan Balasescu	3c51b5a53a	Merge pull request #23809 from peppy/crop-texture-uploads-song-select ... Greatly improve song select performance by cropping beatmap backgrounds before display	2023-06-09 15:04:57 +09:00
Joseph Madamba	85fedbd025	Add tooltips to truncated text	2023-06-08 19:44:07 -07:00
Bartłomiej Dach	4b3b22f046	Merge branch 'master' into beat-divisor-better-defaults	2023-06-08 20:35:03 +02:00
Bartłomiej Dach	b66d1aa33d	Fix code quality inspection	2023-06-08 20:32:16 +02:00
Dean Herbert	c1743dbe1d	Select all text when popover is initially shown ... Depends on https://github.com/ppy/osu-framework/pull/5823.	2023-06-09 02:27:22 +09:00
Bartłomiej Dach	e6503c24c8	Merge branch 'master' into crop-texture-uploads-song-select	2023-06-08 12:24:16 +02:00
Bartłomiej Dach	281aae91ec	Merge pull request #23808 from peppy/working-beatmap-get-background ... Refactor `IWorkingBeatmap.Background` to `GetBackground()`	2023-06-08 12:23:07 +02:00
Dean Herbert	10c43d2273	Reduce delays and fades for carousel panels to improve song select initial display performance ... Entering song select has seen a hit since the new renderer implementations. The underlying cause is large numbers of vertex buffer uploads (the counter hits >200k for me during the transition). Song select is in the process of being redesigned, and we are probably going to make improvements to the renderer to alleviate this, but in the mean time we can greatly improve the user experience by reducing how long the initial fade in delays take on panels. Visually this doesn't look too jarring, and gives a more immediate feeling when scrolling. It's also more feasible to load elements sooner with https://github.com/ppy/osu/pull/23809 applied.	2023-06-08 17:28:58 +09:00
Dean Herbert	3978d4babb	Crop and disable mipmaps on beatmap panel backgrounds ... This is an effort to improve general performance at song select. At least on the metal renderer, I can notice very high draw frame overheads related to texture uploads. By reducing the size of the texture uploads to roughly match what is actually being displayed on screen (using a relatively inexpensive crop operation), we can bastly reduce stuttering both during initial load and carousel scroll. You might ask if it's safe to disable mipmapping, but I've tested with lower resolutions and bilinear filtering seems to handle just fine. Bilinear without mipmaps only falls apart when you scale below 50% and we're not going too far past that at minimum game scale, if at all.	2023-06-08 16:51:07 +09:00
Dean Herbert	a842f79ad4	Refactor IWorkingBeatmap.Background to GetBackground()	2023-06-08 16:19:32 +09:00
Bartłomiej Dach	b3ce7f7b43	Merge branch 'master' into fix-section-container-scroll-attempt-2	2023-06-08 09:19:26 +02:00
Bartłomiej Dach	3c8f387a6c	Remove unused method	2023-06-07 23:38:06 +02:00
Bartłomiej Dach	d9281ac8c7	Remove unused virtual spec	2023-06-07 23:38:06 +02:00
Bartłomiej Dach	9b665d2e1a	Merge branch 'master' into beat-snap-divisor-hotkeys	2023-06-07 23:38:03 +02:00
Dean Herbert	3a01498789	Use existing next/previous methods (and remove looping behaviour)	2023-06-08 01:01:29 +09:00
Bartłomiej Dach	1f4e79d79d	Merge pull request #23711 from timiimit/add-last-edit-time ... Store timestamp of beatmap's last edit time in local database	2023-06-07 16:57:24 +02:00
Dean Herbert	2c89af608a	Add ability to cycle beat snap divisor using hotkeys ... Defaults to Ctrl+Shift+Wheel (as per stable). Closes #23785.	2023-06-07 17:15:15 +09:00
Dean Herbert	7d49f5d7c6	Apply NRT to SectionsContainer	2023-06-07 16:32:29 +09:00
Salman Ahmed	62cb6a98ca	Remove redundant nullable suppression directives	2023-06-07 08:20:41 +03:00
Dean Herbert	247ac3a5fd	Merge pull request #23781 from bdach/fix-progress-bar-blink ... Fix triangles song progress bar blinking during gameplay	2023-06-07 13:44:43 +09:00
Bartłomiej Dach	be59eb1116	Fix triangles song progress bar blinking during gameplay ... Closes #23760.	2023-06-06 18:36:25 +02:00
Dean Herbert	247fa088db	Add IHasNoTimedInputs interface to scope change further	2023-06-06 22:22:42 +09:00
Dean Herbert	d1300f75c0	Merge branch 'master' into no-offset-calibration-with-relax	2023-06-06 22:22:08 +09:00
Dean Herbert	22f7fe1d79	Rename variable and ensure timestamp is updated even when not saving	2023-06-06 15:11:31 +09:00
Dean Herbert	3a50e0fb2f	Merge branch 'master' into add-last-edit-time	2023-06-06 15:07:20 +09:00
Dean Herbert	0c7ab8f971	Merge branch 'master' into hud/argon-kc-animations-poc	2023-06-06 14:43:08 +09:00
Dean Herbert	2f11bd5473	Adjust animations slightly	2023-06-06 14:42:42 +09:00
Dean Herbert	c54670aee1	Add comment explaining implementation	2023-06-06 13:30:56 +09:00
tsrk	6fc6729677	feat: integrate attachment flow in SkinComponentsContainer	2023-06-06 00:27:43 +02:00
tsrk	4c397085c5	refactor: improve attachement flow ... This removes the hard reliance on individual classes and makes its usage easiser to ingreate anywhere else.	2023-06-06 00:12:53 +02:00
tsrk	41b7eacc72	Merge branch 'master' into hud/argon-kc-animations-poc	2023-06-05 15:22:20 +02:00
Cootz	3ebc801484	Move (de)select all mods hotkeys handling to ModSelectOverlay	2023-06-05 13:49:07 +03:00
Joseph Madamba	4eb0f0261c	Fix song select beatmap panels not displaying correct background shown in web	2023-06-04 22:54:15 -07:00
Bartłomiej Dach	331e90f720	Merge branch 'master' into tidy-results-grid-usage	2023-06-03 19:45:23 +02:00
Bartłomiej Dach	602d5db3bb	Simplify column dimensions code ... `dimensions` would always receive exactly one item, so might as well inline it. And yes, at this point the grid container is mostly a glorified `FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not touching that in this pull pending further decisions with respect to direction.	2023-06-03 19:40:01 +02:00
Bartłomiej Dach	a9d4556647	Merge branch 'master' into update-multiplayer-room-diff-range	2023-06-03 16:50:09 +02:00
Bartłomiej Dach	8433813677	Merge branch 'master' into editor-timeline-fix	2023-06-01 21:18:08 +02:00
Bartłomiej Dach	c2d89a32a9	Adjust inline comment	2023-06-01 21:18:00 +02:00
Andrei Zavatski	03eb7c7830	Fix nullability	2023-06-01 21:21:01 +03:00
Andrei Zavatski	949fe32740	Use combined area of children as a mask instead	2023-06-01 15:32:17 +03:00
Dean Herbert	32207d4112	Remember the last used custom divisor when cycling divisor types	2023-06-01 17:11:49 +09:00
Dean Herbert	bcde2cbc73	Apply NRT to BeatDivisorControl	2023-06-01 16:58:14 +09:00
Dean Herbert	f52ed41f10	Use better defaults of 1/4 and 1/6 when cycling types	2023-06-01 16:28:03 +09:00
Dean Herbert	985604fab5	Return StatisticItems rather than StatisticRows from ruleset ... There were no usages of more than one column being provided per row, so it seemed like unnecessarily complexity. I'm currently trying to reduce complexity so we can improve the layout of the results screen, which currently has up to three levels of nested `GridContainer`s. Of note, I can't add backwards compatibility because the method signature has not changed in `Ruleset` (only the return type). If we do want to keep compatibility with other rulesets, we could designate a new name for the updated method.	2023-06-01 14:35:15 +09:00
Dean Herbert	dc595b83f1	Remove unused Dimension specification from StatisticItem	2023-06-01 14:25:18 +09:00
timiimit	a58426dab6	Use LastEditTime in Editor	2023-05-31 19:07:04 +02:00
Dean Herbert	812def124f	Merge pull request #23661 from peppy/fix-multiplayer-present-crash ... Fix `OnResume` / `OnSuspending` potentially getting called before `OnEntering` on a sub screen	2023-05-31 19:43:30 +09:00
Bartłomiej Dach	62d1774407	Apply same comment & reworded condition to suspend too	2023-05-30 21:54:56 +02:00
Andrei Zavatski	d119447a10	Fix editor timeline hitobjects popping in	2023-05-30 16:41:42 +03:00
Dean Herbert	741ee84ed6	Add comment and use full conditional similar to extension method ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-05-30 18:38:28 +09:00
Dean Herbert	14a376c041	Merge branch 'master' into scorev2	2023-05-30 14:34:43 +09:00
Dean Herbert	1558723420	Merge branch 'master' into scorev2	2023-05-29 20:06:32 +09:00
Dean Herbert	1a6d9e9ff0	Apply NRT to GameplayLeaderboardScore and change GetDisplayedScore handling ... I don't feel too confident with the default scoring function being assigned in the constructor to a publicly settable delegate. This just feels a bit more elegant, and handles the (likely-never-used) case where we need to restore the default function. An alternative would be to provide the function as a `ctor` argument, but I believe that wasn't done here to allow using the `ILeaderboardScore` interface.	2023-05-29 20:00:29 +09:00
Dean Herbert	fcd7a1d51a	Move GetDisplayScore xmldoc to interface and remove getter	2023-05-29 19:41:53 +09:00
Dean Herbert	9a886125ad	Ensure GameplayScoreCounter's display score is updated on ScoringMode change ... This isn't strictly required, but only because of a kind of hacky behaviour where `HUDOverlay` will recreate all components on a scoring mode change currently (see 8f6df5ea0f/osu.Game/Screens/Play/HUDOverlay.cs (L410-L418)). Best we do this just in case that happens to go away in the future.	2023-05-29 19:00:02 +09:00
Dean Herbert	22be045de3	Apply NRT to GameplayScoreCounter	2023-05-29 18:48:17 +09:00
Dean Herbert	b0501c4e5c	Actually use paused header	2023-05-29 10:24:59 +09:00
Robin Oger	cfa1280028	GameplayMenuOverlay.cs: add translatable strings for Retry count: and Song progress: ... This makes the assumption that languages will prefer having the number on the right	2023-05-27 12:47:05 +02:00
Robin Oger	a01577cba5	Adapt changes to fit master	2023-05-27 12:29:14 +02:00
Bartłomiej Dach	574ecf939c	Merge pull request #23647 from peppy/pause-screen-progress ... Show current progress on pause screen	2023-05-26 19:36:30 +02:00
Dean Herbert	725734bc03	Merge pull request #23649 from peppy/keep-selection-buttons-on-screen ... Ensure editor selection buttons remain on screen when selection is near edge	2023-05-26 20:51:45 +09:00
Dean Herbert	6b0e215246	Add (int) flooring and handle potential NaN value	2023-05-26 20:44:13 +09:00
Bartłomiej Dach	96fe7cbe54	Merge branch 'master' into sample-set-controls	2023-05-25 21:58:16 +02:00
Bartłomiej Dach	7d8f08c0ea	Fix ComposeBlueprintContainer briefly assigning auto bank ... Seems to have had no consequence due to the way `AutomaticBankAssignment` works (that flag is checked in `PlacementBlueprint.UpdateTimeAndPosition()`, which runs essentially every frame), but let's avoid putting it there at all ever.	2023-05-25 21:49:29 +02:00
Bartłomiej Dach	b9be886ae1	Merge branch 'master' into pause-screen-progress	2023-05-25 20:34:11 +02:00
Bartłomiej Dach	6425a33b45	Merge branch 'master' into beatmap-length-calcualtions	2023-05-25 17:44:15 +02:00
Bartłomiej Dach	b59f4aee99	Merge pull request #23660 from peppy/simplify-deselect ... Fix crash when deleting dragged object in skin editor	2023-05-25 17:27:41 +02:00
Bartłomiej Dach	3ad5f8b9c9	Polish a few extreme edge cases	2023-05-25 16:39:54 +02:00
Dean Herbert	949de35664	Ensure selection is reset after immediately deleting objects ... Closes https://github.com/ppy/osu/issues/23518.	2023-05-25 23:20:32 +09:00
Bartłomiej Dach	beeca5a8dd	Use alternative layouting implementation	2023-05-25 16:17:44 +02:00
Dean Herbert	b3c2d120bf	Fix OnResume / OnSuspending potentially getting called before OnEntering on a sub screen	2023-05-25 20:39:11 +09:00
Dean Herbert	a6a380dd41	Merge branch 'master' into organize-room-pills	2023-05-25 19:57:28 +09:00
Dean Herbert	609c7227ee	Fix changes to font weight in a couple of combined implementations	2023-05-25 19:55:11 +09:00
Dean Herbert	57c63dbb29	Add xmldoc for GetDisplayScore	2023-05-25 19:24:15 +09:00
Dean Herbert	1049257b56	Simplify SelectionHandler's DeselectAll implementation ... We are already doing other operations in this class directly on `SelectedItems`, so might as well change this one to match	2023-05-25 18:46:31 +09:00
Dean Herbert	1e14b02493	Fix bindable feedback loop	2023-05-25 17:58:38 +09:00
Dean Herbert	37c6e632d0	Switch to using new extension method for length calculations	2023-05-25 17:38:35 +09:00
Dean Herbert	cf9fda0cf2	Merge branch 'beatmap-length-calcualtions' into pause-screen-progress	2023-05-25 17:34:08 +09:00
Dean Herbert	058edb5d5f	Centralise beatmap playable duration and bounds lookups	2023-05-25 17:32:48 +09:00
Bartłomiej Dach	578a0e7494	Merge branch 'master' into beat-divisor-visual-improvements	2023-05-24 22:28:26 +02:00
Bartłomiej Dach	6ec4ecfdd7	Mention fallback default in GetDivisorForBeatIndex()	2023-05-24 22:17:51 +02:00
Bartłomiej Dach	133c954c93	Merge branch 'master' into pause-screen-progress	2023-05-24 21:57:26 +02:00
Bartłomiej Dach	8b6cd1310a	Merge branch 'master' into editor-escape-deselects	2023-05-24 20:18:44 +02:00
Bartłomiej Dach	cd3602406b	Remove unused using directive	2023-05-24 18:54:48 +02:00
Dean Herbert	b14b1072c2	Allow deselecting any selection in the editor using the Back binding (escape key)	2023-05-24 19:24:14 +09:00
Dean Herbert	3b9e1e8a94	Ensure editor selection buttons remain on screen when selection is near edge ... Addresses https://github.com/ppy/osu/discussions/23599.	2023-05-24 19:16:53 +09:00
Dean Herbert	79c9a48ff7	Show song progress at pause/fail screen	2023-05-24 18:36:37 +09:00
Dean Herbert	456f3005d6	Apply nullability to GameplayMenuOverlay and use TextFlowContainer for text	2023-05-24 18:28:04 +09:00
Dean Herbert	8ada8b1c8c	Remove description line from pause/fail screen ... These were in the designs but read pretty bad / evil. I can't think of any text to go in their place that makes sense, so let's just nuke it.	2023-05-24 17:48:35 +09:00
Dean Herbert	3a05dffa50	Add "auto" bank selection during placement	2023-05-24 17:11:12 +09:00
Dean Herbert	fc22c75464	Don't use switch for single case statement	2023-05-24 16:14:05 +09:00
Dean Herbert	a9ba16a2be	Update to support non-control-point sample changes	2023-05-24 14:20:38 +09:00
Dean Herbert	298989ffd2	Merge branch 'master' into sample-set-controls	2023-05-24 14:03:04 +09:00
Dean Herbert	561b759bf9	Tidy up implementation and ensure non-solid ticks start at zero alpha	2023-05-24 13:49:29 +09:00
Dean Herbert	8f1f1955df	Merge pull request #66 from Gyoshi/beat-divisor-visual-improvements ... Add ghost ticks to exhibit current divisor on `BeatDivisorControl`	2023-05-24 13:41:48 +09:00
Joseph Madamba	067328233c	Remove OsuScreen.ApplyLogoArrivingDefaults()	2023-05-23 13:17:43 -07:00
Gyoshi	7fe19d1992	Last instead of Max divisor to match code elsewhere	2023-05-23 18:45:49 +02:00
Gyoshi	c5ef3ae181	Code styling	2023-05-23 18:44:20 +02:00
Gyoshi	b5f8093941	Use RangePadding to align mouse with slider	2023-05-23 18:16:14 +02:00
Gyoshi	7b1e8ede54	Small format	2023-05-23 15:11:27 +02:00
Gyoshi	1b32370c6a	Remove duplicate code by making GetDivisorForBeatIndex method more general	2023-05-23 15:05:38 +02:00
Gyoshi	37a796306d	Small format & comment	2023-05-23 14:30:35 +02:00
Johannes vd Berg	ebda35c3c9	Add ghost ticks to exhibit current divisor on BeatDivisorControl	2023-05-23 12:57:25 +02:00
Dan Balasescu	7658536b5a	Fix CI issues	2023-05-23 19:32:19 +09:00
Dan Balasescu	fee3d43596	Merge branch 'master' into scorev2	2023-05-23 19:07:54 +09:00
Bartłomiej Dach	38b4bd8aef	Fix undo not behaving as expected sometimes	2023-05-22 22:45:39 +02:00
Bartłomiej Dach	e0b7539c2a	Fix sample changes not being applied in patcher	2023-05-22 22:45:23 +02:00
Bartłomiej Dach	f253d17a7f	Fix slider velocity changes not being applied in patcher	2023-05-22 22:19:10 +02:00
timiimit	9d14ea9d27	Merge branch 'ppy:master' into update-multiplayer-room-diff-range	2023-05-21 16:37:00 +02:00
timiimit	4441718437	Merge branch 'ppy:master' into organize-room-pills	2023-05-21 16:36:53 +02:00
Bartłomiej Dach	afdddb0195	Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes ... Fix timeline blueprint display not showing correct combo number / colour during placement	2023-05-20 15:02:55 +02:00
Bartłomiej Dach	0e11adaaac	Merge pull request #23564 from peppy/fix-missing-sample-additions ... Fix sample banks not transferring when adjusting via editor	2023-05-20 14:36:45 +02:00
Dan Balasescu	035d0d5c9c	Fix multiplayer leaderboard not working	2023-05-19 13:16:57 +09:00
Dan Balasescu	c33e4fe75e	Remove unnecessary override	2023-05-18 20:10:28 +09:00
Dan Balasescu	f3591f83a2	Remove ScoreManager.GetTotalScore()	2023-05-18 20:08:49 +09:00
Dan Balasescu	510b8e4c78	Remove ScoreManager.Mode, handle per-use	2023-05-18 20:08:49 +09:00
Dean Herbert	214d7e07fa	Add TODO regarding failing stack display code	2023-05-17 17:52:17 +09:00
Dean Herbert	9563d4f730	Fix weird purple tint on placement object in timeline	2023-05-17 17:26:19 +09:00
Dean Herbert	87ff28b022	Update beat divisor control to show ticks in more visually correct locations ... As proposed in https://github.com/ppy/osu/discussions/23527.	2023-05-17 16:34:12 +09:00
Dean Herbert	730bc3a961	Apply NRT and simplify some remaining code	2023-05-17 16:18:13 +09:00
Dean Herbert	e97d027230	Make OnlinePlayPill class abstract	2023-05-17 16:13:03 +09:00
Dean Herbert	764f0323f4	Show "rewind" text on random button when beginning a right mouse press	2023-05-17 14:51:40 +09:00
Dean Herbert	94b184712d	Fix random button hover state not correctly being reset on right click	2023-05-17 14:51:40 +09:00
Dean Herbert	dc51d5ecf3	Rename GetSampleInfo to better describe what method does ... Also add full xmldoc	2023-05-17 14:07:48 +09:00
Dean Herbert	d9ae822966	Fix bank not correctly being assigned when adding sample additions in editor	2023-05-16 18:52:52 +09:00
timiimit	cc6e4df93e	Remove wrongly added back namepspace	2023-05-16 10:27:46 +02:00
timiimit	4ef74eb3f9	Fix RoomStatusPill text colour	2023-05-16 10:22:52 +02:00
timiimit	81b7737660	Fix text colour of RoomSpecialCategoryPill	2023-05-16 10:20:16 +02:00
timiimit	a9991d9dd4	Remove another unused namespace	2023-05-16 10:14:14 +02:00
timiimit	40daa41a52	Fix naming & namespaces	2023-05-16 10:06:48 +02:00
timiimit	04893064f0	Make used pills inherit from a common one	2023-05-16 09:53:11 +02:00
timiimit	10d6f9ea5a	Create common online play pill	2023-05-16 09:52:26 +02:00
timiimit	0fd718478a	Merge branch 'master' into update-multiplayer-room-diff-range	2023-05-15 07:36:43 +02:00
Bartłomiej Dach	592fcafcd4	Merge pull request #23451 from timiimit/fix-default-progress-graph-flipping ... Fix default progress graph not updating after flip	2023-05-14 19:19:10 +02:00
timiimit	fd80ffd52b	Fix display update condition	2023-05-14 12:09:15 +02:00
timiimit	18efdb0e4c	Make layout readonly	2023-05-13 11:37:56 +02:00
timiimit	d81cdacb0d	Undo stupid changes	2023-05-13 11:28:05 +02:00
timiimit	4b544903cb	Optimize recalculateValues	2023-05-13 10:13:09 +02:00
timiimit	2cfc4eb515	Fix unconsidered height change	2023-05-13 10:12:46 +02:00
timiimit	80b6e014f1	More code style	2023-05-13 01:47:44 +02:00
timiimit	8cc0c5ad1c	Fix code style	2023-05-13 01:39:01 +02:00
timiimit	04f7def798	Remove useless comment	2023-05-13 01:31:12 +02:00
timiimit	21d7c62f30	Add optimized UpdateGraph	2023-05-13 01:29:11 +02:00
timiimit	159cacf9c7	Fix logic in recalculateValues()	2023-05-13 01:27:28 +02:00
timiimit	6180d0d620	Remove cached frame buffer	2023-05-12 15:00:46 +02:00
Dean Herbert	70e248b927	Force placement of in-progress object when changing tools in the editor	2023-05-12 16:06:01 +09:00
Dean Herbert	bdf8a78b42	Add the ability to adjust the beatmap tick rate in the editor	2023-05-09 20:53:20 +09:00
Dan Balasescu	3c3c812ed6	Initial implementation of ScoreV2	2023-05-09 19:33:33 +09:00
Dean Herbert	2085833a84	Fix missing delegate unsubscribe	2023-05-09 17:08:03 +09:00
Dean Herbert	944da06c10	Rename slider multiplier variable back for now	2023-05-09 16:58:19 +09:00
Dean Herbert	8c44d528e9	Use min/max values from stable	2023-05-08 13:52:16 +09:00
Dean Herbert	a6cb1f90e4	Change difficulty popover inspector display (yet again) ... I think this makes the most sense of the iterations I've tested so far, albeit maybe being a touch too verbose.	2023-05-08 13:43:23 +09:00
Dean Herbert	a91edd68d9	Show post-multiplied velocity in main hit object inspector	2023-05-08 13:42:25 +09:00
Dean Herbert	451af9d1b5	Fix beatmap values not being updated due to a varying data type	2023-05-08 13:23:13 +09:00
Dean Herbert	d9dd35c020	Show base velocity in slider adjustment popover	2023-05-08 13:13:09 +09:00
Dean Herbert	31de4de720	Remove median/mode slider velocity display ... The intention was to give an idea of what the most common velocity of the beatmap is, but in hindsight, because the "base" velocity is being set elsewhere this doesn't make sense. It will/should be 1.0x. Showing this range is still valuable, though.	2023-05-08 13:13:09 +09:00
Dean Herbert	b109ee74a6	Add "base velocity" adjustment to difficulty setup screen	2023-05-08 13:13:09 +09:00
Bartłomiej Dach	65b4b198a4	Merge branch 'master' into export	2023-05-06 20:12:53 +02:00
tsrk	e9d7cd7a79	feat(ArgonKeyCounter): flash key name	2023-05-06 19:08:30 +01:00
Bartłomiej Dach	e808a47811	Fix delegate leak	2023-05-05 20:33:27 +02:00
Bartłomiej Dach	f536238554	Use shorter copy	2023-05-05 20:30:50 +02:00
Bartłomiej Dach	34b19dd6f4	Merge branch 'master' into slider-velocity-inspector	2023-05-05 20:20:16 +02:00
Dean Herbert	b7a287869a	Add display of beatmap slider velocity when adjusting	2023-05-05 15:57:38 +09:00
Dean Herbert	cc70d89bf9	Move editor inspector classes out of ruleset namespace	2023-05-05 15:57:38 +09:00
Dean Herbert	560f71ef53	Adjust BlurredIcon expansion ratio to fix glow getting cut off at lower resolutions ... Closes https://github.com/ppy/osu/issues/23210. Ballparked the fix to work down to the lowest resolution we support. The previous number (`2.5f`) was also likely ballparked so the fix seems in line with expectations. I don't want to put too much thought into this because the design of this screen is likely going to change in the mean time anyway.	2023-05-05 14:29:04 +09:00
tsrk	74e7a958bb	feat(ArgonKeyCounter): make animation ... Currently WIP. Do not consider this final.	2023-05-05 05:31:06 +01:00
Bartłomiej Dach	fa3f42ba75	Merge pull request #23386 from peppy/fix-osu-logo-input-handling ... Extend input handling of osu! logo to full border area	2023-05-03 17:48:51 +02:00
cdwcgt	4549a865d9	Merge branch 'master' into export	2023-05-04 00:18:01 +09:00
Dean Herbert	444f66b0ee	Move to base class for added safety	2023-05-03 18:46:30 +09:00
Dean Herbert	cd31cff8cd	Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap ... The handling of cleanup is performed only the `Item_Set` method. This was already correctly called for `DrawableCarouselBeatmapSet`, but not for the class in question here. This would cause runaway memory usage at song select when opening many beatmaps to show their difficulties. For simplicity, we don't yet pool these (and generate the drawables each time a set is opened) which isn't great but likely will be improved upon when we update the visual / filtering of the carousel. But this simplicity caused the memory usage to blow out until exiting back to the main menu when cleanup would finally occur.	2023-05-03 18:41:30 +09:00
Dean Herbert	5757eb7529	Update a few more instances of 0.96f scale constants	2023-05-03 18:20:12 +09:00
Dean Herbert	453143813f	Extend input handling of osu! logo to full border area ... This is the easiest way to make this happen. It does mean the pink area is being drawn behind the white border, but I haven't found a scenario where this is noticeable. Closes #4217.	2023-05-03 14:57:57 +09:00
Dean Herbert	6b017ac05f	Merge pull request #23308 from OliBomby/sample-control-points ... Remove SampleControlPoint and DifficultyControlPoint from HitObject	2023-05-03 14:21:51 +09:00
Dean Herbert	8a536c1cdb	Fix non-block namespace usage	2023-05-02 15:09:24 +09:00
OliBomby	1dc34ee25d	fix infinite repeat count when adjusting length of 0 length slider	2023-05-01 15:48:54 +02:00
OliBomby	608fa3cc73	Merge remote-tracking branch 'upstream/master' into sample-control-points	2023-04-30 19:47:03 +02:00
Cootz	607a04ae73	Fix the issue	2023-04-29 10:29:33 +09:00
OliBomby	c44f71a737	remove all regular usage of DifficultyControlPoint	2023-04-26 17:55:38 +02:00
OliBomby	87ca0f5335	Update SamplePointPiece.cs	2023-04-26 13:45:58 +02:00
Bartłomiej Dach	5ec8ecb11b	Merge pull request #23309 from peppy/key-counters-fix ... Fix key counters counting during break time	2023-04-25 21:15:12 +02:00
OliBomby	e4b64bdc3e	clean up code stuff	2023-04-25 19:06:29 +02:00
OliBomby	755ad25dbe	clean code	2023-04-25 18:27:20 +02:00
OliBomby	c23a7b014e	add missing }	2023-04-25 18:17:07 +02:00
OliBomby	065464d90c	Fixed DifficultyPointPiece	2023-04-25 18:12:53 +02:00
Dean Herbert	14af2063e5	Merge pull request #23247 from peppy/round-editor-rotation ... Always round editor rotation to integer values	2023-04-25 21:43:44 +09:00
Dean Herbert	6b4032e34b	Add missing binding of IsCounting with contained counters	2023-04-25 21:37:19 +09:00
Dean Herbert	0a861ffcee	Restructure key counters to use a common flow	2023-04-25 21:37:19 +09:00
Dean Herbert	7630958633	Stop using Drawable.Name to convey actual UI information	2023-04-25 20:24:36 +09:00
Dean Herbert	dd2c289ce9	Remove pointless default value	2023-04-25 20:22:12 +09:00
Dean Herbert	d8b4db3a13	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-25 19:54:31 +09:00
Renzo Poggio	0991c56e1c	Add extra check in 'SelectPreviousRandom' ... Check if the poped beatmap exists within the beatmapSets	2023-04-25 00:05:15 -03:00
Dean Herbert	9f4b1f0f24	Always round editor rotation to integer values	2023-04-20 14:30:01 +09:00
Joseph Madamba	c80a25328d	Shorten label to just "matches"	2023-04-17 20:59:41 -07:00
Joseph Madamba	d0cbe206a9	Revert back to one number with "matching beatmap difficulties" label	2023-04-10 23:37:29 -07:00
Joseph Madamba	f0c8a3202b	Merge remote-tracking branch 'upstream/master' into fix-beatmap-terminology	2023-04-10 23:22:15 -07:00
Dean Herbert	52bb7891f7	Merge branch 'master' into fix-count-not-updating-when-deleting	2023-04-11 09:04:02 +09:00
Joseph Madamba	f80de08f24	Adjust BeatmapSetsChanged xmldoc ... Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-04-10 11:28:23 -07:00
Joseph Madamba	c7dea71793	Use existing BeatmapSetsChanged action	2023-04-10 11:26:18 -07:00
Bartłomiej Dach	73bd0feef5	Fix incorrectly implemented localisation	2023-04-10 15:03:33 +02:00
Bartłomiej Dach	6fec476147	Simplify snap implementation	2023-04-10 14:55:30 +02:00
Joseph Madamba	7f5b99c91b	Fix song select beatmap difficulty count not updating when deleting	2023-04-09 22:12:51 -07:00
cdwcgt	ce6a87b4a3	Merge remote-tracking branch 'upstream/master' into export	2023-04-09 15:02:47 +09:00
Dean Herbert	8d2e852ffd	Fix overbearing key down handling	2023-04-08 22:30:36 +09:00
Dean Herbert	a1fc4def1d	Remove redundant method override	2023-04-08 22:18:07 +09:00
Micha Lehmann	3c4a25e53f	Fix tooltip text not resetting when ending an editor rotation	2023-04-08 14:28:52 +02:00
Micha Lehmann	580d5745c0	Add "(snapped)" to the tooltip when snap-rotating in the editor	2023-04-08 14:15:49 +02:00
Dean Herbert	f72dd86b42	Fix code quality issues and avoid updating bindable twice per operation	2023-04-08 10:40:36 +09:00
Micha Lehmann	c827c2810b	Improve editor selection rotation value wrapping ... This fixes two issues the previous algorithm had: 1. A half-turn rotation used to show up as -180°. 2. Rotating more than 180° in one drag event would overwhelm it and cause the value to go outside its range. This comes at the cost of a negligible performance hit, since a division (modulo) is performed instead of just addition/subtraction.	2023-04-08 01:30:29 +02:00
Micha Lehmann	f1de560d57	Snap editor selection rotation when holding shift	2023-04-08 01:30:29 +02:00
Dean Herbert	0c71fa1bbd	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-06 23:39:57 +09:00
Dean Herbert	e6872629f3	Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable ... Don't show epilepsy warning when storyboards are disabled	2023-04-06 12:32:38 +09:00
tsrk	809b817e8e	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-05 22:57:36 +02:00
Bartłomiej Dach	ba753a8aac	Merge branch 'master' into update-skinnable-sound-before-playing	2023-04-05 22:56:25 +02:00
Bartłomiej Dach	6df7614b9d	Add tests for suppressing epilepsy warning when storyboard disabled	2023-04-05 20:56:50 +02:00
Bartłomiej Dach	432f698697	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-05 19:45:14 +02:00
Bartłomiej Dach	8cc425774b	Merge branch 'master' into fix-replay-fail-on-exit	2023-04-03 21:23:23 +02:00
Dean Herbert	b0c09df259	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-03 15:33:35 +09:00
Dean Herbert	4b294278d6	Merge branch 'master' into fix-ruleset-shader-caching	2023-03-31 20:04:55 +09:00
Dean Herbert	796cd9c916	Rewrite comment explaining early return on checkScoreCompleted given new usages	2023-03-31 02:36:17 +09:00
Dean Herbert	b25a59fd14	Rename scoreCompleted -> checkScoreCompleted to reflect the fact it doesn't always succeed	2023-03-31 02:30:04 +09:00
Dean Herbert	4dd0c2c7a5	Add assert ensuring we don't ever get to the results screen with an F rank ... Intentionally an assertion as I want tests to fail, but I don't want this to cause crashes for an end user if it does happen to occur.	2023-03-29 14:11:58 +09:00
Dean Herbert	a8bb2e33ac	Ensure all preconditions are checked before progressing to results screen after storyboard ends	2023-03-29 14:00:11 +09:00
Dean Herbert	aad540629f	Remove duplicate load rule from ShaderPrecompiler	2023-03-29 12:36:56 +09:00
Dean Herbert	5dfac02b11	Preload triangle shader on startup	2023-03-28 14:15:38 +09:00
Joseph Madamba	8b30c67580	Fix incorrect song select matching label by showing both beatmap and difficulty count for less ambiguity	2023-03-26 18:08:28 -07:00
Joseph Madamba	3e0bbb2432	Fix select beatmap button not highlighting when creating a multiplayer room using keyboard	2023-03-26 16:03:21 -07:00
Dean Herbert	c65a79614d	Don't show offset calibration controls when "relax" mod is active ... Closes https://github.com/ppy/osu/issues/22892.	2023-03-22 15:45:04 +09:00
Dean Herbert	425be20e46	Fix song select search textbox font size incorrectly having increased	2023-03-22 14:17:39 +09:00
Bartłomiej Dach	9ff9cd3b7f	Merge branch 'master' into skin-editor-cyclic-selection	2023-03-21 19:49:55 +01:00
Dean Herbert	e31a90e043	Don't cycle selection when more than one items are selected	2023-03-21 21:31:10 +09:00
Dean Herbert	5cb8160eee	Merge pull request #22773 from peppy/show-song-select-visible-beatmap-count ... Show count of visible beatmaps at song select	2023-03-21 18:22:29 +09:00
Bartłomiej Dach	ea8da69263	Fix importing beatmaps not changing count of visible beatmaps ... Reproduction steps: 1. Go to song select 2. Open beatmap listing 3. Import a beatmap that would fit the current filter criteria 4. The count of visible beatmaps does not change Fixed by updating the count on `BeatmapSetsChanged` too.	2023-03-20 20:53:53 +01:00
Bartłomiej Dach	695ee39b87	Privatise setter	2023-03-20 20:30:54 +01:00
Cootz	556964eae0	Merge branch 'master' into BitmapUpdatesOnScore	2023-03-16 12:16:42 +03:00
Dean Herbert	3b62f87b64	Ensure Player does not fail a score on exit if a replay is currently loaded	2023-03-16 17:14:20 +09:00
Dean Herbert	f21238f517	Adjust shadow to look better	2023-03-16 16:51:57 +09:00
Dean Herbert	cd102da3af	Move matches string inside text box	2023-03-16 16:34:31 +09:00
Dean Herbert	89b42ddd98	Don't localise beatmap count string for now	2023-03-16 15:02:38 +09:00
Terochi	edc6314634	Drank some coffee and figured out the fix	2023-03-15 10:49:59 +01:00
Dean Herbert	5f9b13a775	Rename Add/AddRange methods as they are no longer conflicting with Container	2023-03-15 18:02:41 +09:00
Dean Herbert	9e444af380	Use object initialisers and fix order of initialisation vs add	2023-03-15 18:02:26 +09:00
Terochi	b0f1a69523	Update the pauseLoop sample instantly on skin change	2023-03-15 09:05:34 +01:00
Dean Herbert	1cf870d956	Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection	2023-03-15 15:16:48 +09:00
Terochi	1d5e596615	Update FailAnimation to use SkinnableSound	2023-03-14 20:44:30 +01:00
Dean Herbert	6546f5968a	Merge branch 'master' into skin-editor-cyclic-selection	2023-03-14 20:43:56 +09:00
Dean Herbert	b46fc14e56	Merge pull request #22848 from Rovearix/Fix-Dragging-Preventing-Beatmap-Loading ... Prevent LoadingLayer from blocking loading	2023-03-14 20:42:10 +09:00
Dean Herbert	4cea29402b	Don't show epilepsy warning when storyboards are disabled ... I have more thoughts on this warning in general (which will likely see it removed or moved in the future) but this seems like a quick QOL fix for now. As mentioned in https://github.com/ppy/osu/discussions/22861.	2023-03-14 18:32:26 +09:00
Rovearix	9ac9287dbd	Switched the implementation to set the blockInput flag for the BeatmapMetadataDisplay's LoadingLayer. This prevents the UIEvents from being being handled in this case without modifying the class	2023-03-13 08:07:55 -04:00
Derrick Timmermans	febdca4547	Fix argon progress bar fill being oversized	2023-03-12 02:08:00 +01:00
Dan Balasescu	e327993d11	Merge pull request #22527 from Terochi/replay-length-extension ... Replay recording extension until results screen transition	2023-03-11 15:41:32 +09:00
tsrk	d806b85a30	revert: make counters an IEnumerable again ... As suggested by bdach as this would make the last two commits useless Refs: 5d15426	2023-03-09 10:25:03 +00:00
Dean Herbert	4f7be332f3	Revert isDraggingBlueprint to field	2023-03-08 19:24:03 +09:00
Dean Herbert	245c3c025c	Refactor endClickSelection to reduce nesting	2023-03-08 19:23:32 +09:00
tsrk	5d15426c27	refactor: make Counters return a Container	2023-03-08 01:52:12 +00:00
tsrk	5b0db94a24	docs: add XMLDoc for methods in KCD	2023-03-08 00:58:54 +00:00
tsrk	44297a7d0a	refactor: make KCD a CompositeDrawable	2023-03-08 00:47:16 +00:00
Bartłomiej Dach	72695f7c90	Merge branch 'master' into omit-barline-in-timing-control-point	2023-03-07 22:46:24 +01:00
Bartłomiej Dach	6c5ccdfd90	Merge branch 'master' into optimise-search	2023-03-07 22:07:29 +01:00
Bartłomiej Dach	12af002c4d	Reorder and add xmldoc to KeyCounter members	2023-03-07 21:28:42 +01:00
Bartłomiej Dach	98f40b2679	Improve documentation of InputTrigger	2023-03-07 21:22:59 +01:00
Bartłomiej Dach	5213bfa5c9	Merge branch 'master' into make_skin_reset_dangerous	2023-03-07 21:06:44 +01:00
Bartłomiej Dach	cfafa8af8c	Merge branch 'master' into hud/player-components	2023-03-07 19:44:12 +01:00
Bartłomiej Dach	7ade525eef	Display corner radius setting as percentage	2023-03-07 19:43:52 +01:00
Dean Herbert	dc2945f4f8	Move avatar user loading to BDL also	2023-03-07 17:39:21 +09:00
Dean Herbert	5af41bb1c8	Move filter matching code into own method to simplify early returns	2023-03-07 17:24:17 +09:00
Dean Herbert	5e90b67be0	Move GameplayState usage to BDL	2023-03-07 17:01:29 +09:00
Dean Herbert	d98199961b	Adjust default sizing to fit a bit better with existing elements	2023-03-07 17:00:10 +09:00
Dean Herbert	6a7c4d0bf7	Remove NRT disables in new classes	2023-03-07 16:41:39 +09:00
Dean Herbert	97ba236eb1	Add basic xmldoc to KeyCounter classes	2023-03-07 16:41:39 +09:00
Dean Herbert	28520414aa	Move KeyCounter components to HUD namespace	2023-03-07 16:41:39 +09:00
Dean Herbert	15d65059b5	Tidy up Add method logic	2023-03-07 16:21:57 +09:00
Dean Herbert	8f6df5ea0f	Merge branch 'master' into gameplay/key-counter-abstraction	2023-03-07 16:09:45 +09:00
Dean Herbert	21bdbb20e6	Add optional support for cyclic selection to BlueprintContainer	2023-03-07 14:22:12 +09:00
tsrk	fc0e27fb15	style: use normalised CornerRadius values	2023-03-06 20:11:52 +00:00
tsrk	952814604e	style: fix late night oopsies	2023-03-06 20:06:56 +00:00
tsrk	3a240aaa5f	style: use 64 radius	2023-03-06 10:27:59 +00:00
Dean Herbert	87d0bef313	Use nullable comparison helper method instead of manual implementation	2023-03-06 15:16:32 +09:00
tsrk	07bde4990d	feat: implement PlayerAvatar	2023-03-05 23:17:39 +00:00
tsrk	654eacd449	feat(l10n): localise CornerRadius	2023-03-05 23:10:42 +00:00
tsrk	082bfe3621	refactor: SkinnableAvatar to PlayerAvatar	2023-03-05 23:09:02 +00:00
mk56-spn	908651cc11	make ResetConfirmDialog properly utilise its parent's logic ... Adjust name of `DeleteAction` to `DangerousAction`	2023-03-05 20:57:26 +01:00
OliBomby	70a925aab1	added extra early-returns	2023-03-04 16:49:33 +01:00
OliBomby	b90c389ff0	using List instead of Span in GetSearchableTerms	2023-03-04 15:42:35 +01:00
tsrk	d5ba5eed88	fix(SkinnableAvatar): init avatar.CornerRadius	2023-03-03 23:47:22 +00:00
tsrk	d39b8c7c23	fix(SkinnableAvatar): update outdated interface	2023-03-03 19:35:45 +00:00
Ruki	e75aa9138b	Merge branch 'ppy:master' into hud/avatar-thing	2023-03-03 20:03:56 +01:00
OliBomby	91d206e8d2	Optimised GetSearchableTerms ... Reduced memory allocations to 1	2023-03-03 19:21:50 +01:00
Dean Herbert	82293c0c86	Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes ... From a user's perspective, changing a sort / order mode shouldn't filter away results, but we were doing this. In terms of UX expectations, in stable this kind of scenario would results in a group being added to the end of son select with "Not ranked" or "Unknown". I think we should aim to match this eventually.	2023-03-03 16:36:18 +09:00
Dean Herbert	dc669835e2	Show count of visible beatmaps at song select	2023-03-03 15:28:51 +09:00
Dean Herbert	6ff1fb6b1a	Adjust sizing to allow for timing point information now being longer than before	2023-03-02 18:57:54 +09:00
Dean Herbert	044b0604b2	Move OmitFirstBarLine to TimingControlPoint	2023-02-28 19:29:31 +09:00
mk56-spn	90227a6496	Rename DeleteConfirmationDialog.cs into DangerousActionDialog.cs	2023-02-27 21:57:59 +01:00
tsrk	8c94b77de1	refactor(InputTrigger): move out of KCD ... I love JetBrains Rider.	2023-02-22 15:05:07 +00:00
tsrk	1beec71037	refactor(KeyCounterDisplay): apply suggestions ... I also took the freedom to add type checking, as we can't limit the usage of `Add()` since it's a Container. The exception thrown also advises of using the suggested `AddTrigger()` instead.	2023-02-22 14:58:27 +00:00
tsrk	42a5a06b9d	style(KeyCounter): fields and methods visiblity	2023-02-21 19:10:37 +00:00
tsrk	5bec2d7c52	style(KeyCounter): forwardPlayback	2023-02-21 19:02:56 +00:00
mk56-spn	299023fce0	Improve visibility of wedge shading in test scene and fix an issue with excessive roundness on said shadow.	2023-02-21 16:07:26 +01:00
Bartłomiej Dach	c9999bdeb1	Merge branch 'master' into skin-per-ruleset-layouts	2023-02-20 20:14:38 +01:00
Bartłomiej Dach	1ba1298850	Merge branch 'master' into blueprint-improve-visuals	2023-02-19 15:55:30 +01:00
Bartłomiej Dach	d9ca7102f0	Use more generic wording for future-proofing	2023-02-19 15:06:40 +01:00
Maximilian Kruse	723a043c43	naming change from Hitobject to HitObject	2023-02-19 10:18:22 +01:00
Maximilian Kruse	ddd37bb319	Add setting to disable automatic seeking after object placement	2023-02-18 19:43:45 +01:00
Bartłomiej Dach	6b9472c367	Merge branch 'master' into skin-per-ruleset-layouts	2023-02-17 22:58:38 +01:00
Bartłomiej Dach	8894a73b07	Merge branch 'master' into blueprint-improve-visuals	2023-02-17 21:40:16 +01:00
Bartłomiej Dach	6afa65bd3d	Merge branch 'master' into skinnable-clean-up-documentation	2023-02-17 20:59:18 +01:00
cdwcgt	e84e011d5d	Merge branch 'master' into export	2023-02-17 22:15:19 +09:00
Dean Herbert	a01c3090e4	Fix tests which rely on HUDOverlay's DrawableRuleset being nullable	2023-02-17 19:27:09 +09:00
Dean Herbert	209d41ee9d	Use RulesetInfo instead of Ruleset in skin components lookup	2023-02-17 18:24:05 +09:00
Dean Herbert	16d94b4ea2	Improve visuals of skin blueprint	2023-02-17 18:19:46 +09:00
tsrk	8830e06588	fix: compilation	2023-02-17 09:17:11 +00:00
tsrk	c94e647e21	style(KeyCounterDisplay): remove type check	2023-02-17 09:09:56 +00:00
Dean Herbert	4cc6664dc7	Add optional ruleset identifier to SkinComponentsContainerLookup	2023-02-17 14:19:19 +09:00
tsrk	d0e8d65766	style(KeyCounter): rename IsLit to IsActive	2023-02-17 00:56:17 +00:00
tsrk	e3ca751027	refactor: make FillFlowContainer read-only	2023-02-16 23:17:47 +00:00
tsrk	c61fac578c	style(KeyCounter): rename methods and arguments ... As for the second suggestion in https://github.com/ppy/osu/pull/22654#discussion_r1109047998, I went with the first one as only one Trigger actually uses this argument for rewinding.	2023-02-16 23:15:03 +00:00
tsrk	ddd6c1a1c6	refactor(KeyCounter): address bindables issues ... `IsCounting` is back being an auto-property. `countPresses` is now encapsulated and being exposed as an `IBindable<int>` via `CountPresses`	2023-02-16 22:20:34 +00:00
tsrk	6340730427	refactor(KeyCounter): remove circularity	2023-02-16 21:59:39 +00:00
Bartłomiej Dach	ad5132ed41	Remove redundant conditional access qualifier ... It is impossible for the callback passed to `ApplyToBackground()` to receive a null reference. See `OsuScreen.ApplyToBackground()` - if the background to call the callback on were `null`, then an `InvalidOperationException` would be thrown instead.	2023-02-16 20:47:51 +01:00
Dean Herbert	394d368f16	Fix song select potentially updating background parameters when not the current screen	2023-02-16 18:45:22 +09:00
tsrk	74e7cc2056	feat: implement new design of key counter	2023-02-15 22:18:02 +00:00
tsrk	e9dcc257b4	reafactor: simplify type checking	2023-02-15 22:06:35 +00:00
tsrk	b0a2e69f95	style: nullable pass on KeyCounterDisplay	2023-02-15 22:06:10 +00:00
tsrk	076eb81b21	refactor: rename trigger classes ... Makes it better to understand their purpose	2023-02-15 21:46:13 +00:00
tsrk	a644fae364	style(KeyCounter): rename (Un)lit methods to (Un)light	2023-02-15 21:41:41 +00:00
tsrk	df0633858c	fix(KeyCounter): don't override Handle ... This caused the Keyboard inputs to register twice, which is not what we want.	2023-02-15 21:41:41 +00:00
tsrk	157bba7830	refactor: rename Trigger class to InputTrigger	2023-02-15 21:41:36 +00:00
Dean Herbert	a92e42bb84	Rename SkinnableTargetContainer to SkinComponentsContainer ... Also use full `SkinComponentsContainerLookup` instead of the sub-type. This will potentially be useful once we bring in per-ruleset targets.	2023-02-15 18:37:41 +09:00
Dean Herbert	d159d6b970	Rename ISkinnableDrawable to ISerialisableDrawable	2023-02-15 18:37:41 +09:00
Dean Herbert	6010dde86e	Move SkinnableInfo to better namespace	2023-02-15 18:23:10 +09:00
Dean Herbert	9ed068c1e6	Only apply dim changes when background blur is disabled	2023-02-15 14:16:34 +09:00
Dean Herbert	19e3c5d33c	Adjust song select background dimming to be more evenly applied	2023-02-15 13:59:24 +09:00
Dean Herbert	7aaaf7fca2	Combine and attempt to simplify the score import / preparation process further	2023-02-14 16:55:35 +09:00
Dean Herbert	8a206234f7	Merge branch 'master' into replay-length-extension	2023-02-14 16:42:26 +09:00
Dean Herbert	51d4ae5241	Merge branch 'master' into footer_V2_implementation	2023-02-14 14:00:53 +09:00
Dean Herbert	f0ebb920b9	Make Actions nullable	2023-02-14 13:54:00 +09:00
MK56	5006dbe3db	Update osu.Game/Screens/Select/FooterV2/FooterButtonV2.cs ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2023-02-14 00:07:02 +01:00
Bartłomiej Dach	939144fb6c	Merge pull request #22628 from EVAST9919/letterbox-no-containers ... Remove unnecessary containers in `LetterboxOverlay`	2023-02-13 23:54:48 +01:00
mk56-spn	ae9a17d76b	Add offset to FooterButtonV2.cs shadow	2023-02-13 22:20:41 +01:00
mk56-spn	be52d0a60c	Add note explaining shadow opacity ... pass ColourProvider in from test, instead of hard coding it in `FooterButtonV2.cs`	2023-02-13 22:18:34 +01:00
mk56-spn	61584ba63c	Fix corner_radius missing in some parts of FooterButtonV2.cs. ... Adjust shadow radius value to 5 to match figma.	2023-02-13 22:15:29 +01:00
mk56-spn	6e6421caea	Change FooterV2.cs colour to use ColourProvider instead of OsuColour. ... Remove unnecessary `FillFlowContainer`	2023-02-13 22:12:25 +01:00
Andrei Zavatski	2dee783401	Remove not needed containers	2023-02-13 15:14:25 +03:00
tsrk	aa2e0028ab	refactor: hide trigger presence from content	2023-02-13 10:59:10 +00:00
tsrk	11d0e185b8	refactor: separate impl of KeyCounterDisplay ... This allows for different layouts of display. Idk, maybe someone would want to mix both variants? (don't do this please). This commit is mostly prep for further changes.	2023-02-13 01:36:12 +00:00
tsrk	74a58fb674	refactor: separate things in KeyCounter ... To implement different different sources of input for KeyCounter, it is now possible to create a Trigger class (to inherit) instead of inheriting KeyCounter. This eases the creation of more input sources (like for tests) while allowing to implement different UI variants. That way, if another variant of the key counter needs to implemented (for whathever reason), this can be done by only inheriting KeyCounter and changing how things are arranged visually.	2023-02-13 01:24:27 +00:00
Joseph Madamba	cb51b9e350	Use existing ModdingBeatmap activity	2023-02-12 15:01:50 -08:00
Joseph Madamba	bbeef53569	Add TestingBeatmap activity	2023-02-12 13:11:42 -08:00
Joseph Madamba	afb66d8af4	Make user activity class names more specific	2023-02-12 12:32:17 -08:00
Bartłomiej Dach	774eae98cc	Merge branch 'master' into editor-select-timing-on-enter	2023-02-11 16:27:22 +01:00
Bartłomiej Dach	a3cc0d23b3	Fix typo in xmldoc	2023-02-11 16:26:32 +01:00
Dean Herbert	0c5dae5f26	Merge pull request #22529 from ItsShamed/dsc/presence ... Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`	2023-02-11 17:29:47 +09:00
Terochi	81c3e0da31	Fixed timeLeft counter in SongProgressInfo being out of bounds after rotation	2023-02-10 17:58:48 +01:00
Dean Herbert	6d876fdb9a	Automatically select the closest timing point on entering the timing screen	2023-02-10 17:48:56 +09:00
Dean Herbert	03e623d1d2	Move ControlPointList to own file	2023-02-10 17:37:31 +09:00
Dean Herbert	eccde923e5	Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability ... Improve readability of `AccuracyCircle`	2023-02-10 17:03:46 +09:00
Dean Herbert	cf009432cc	Centralise accuracy cutoff constants and add lookup helper methods	2023-02-09 15:41:58 +09:00
Walavouchey	57312279f0	adjust RankNotch gap size to match original value	2023-02-09 02:20:05 +01:00
Walavouchey	fd93bd3f50	move rank accuracy requirements to class-local constants	2023-02-09 00:46:24 +01:00
Walavouchey	ee40444fd3	use Precision.AlmostEquals for bounds check	2023-02-08 23:59:19 +01:00
Walavouchey	0531c010eb	display RankBadges on on their sector centres ... the D `RankBadge` does this anyway. the A and S badges are slightly off centre to prevent overlap with the SS badge	2023-02-08 14:01:40 +01:00
Walavouchey	6ace6bfee1	ensure AccuracyCircle doesn't land in gaps created by RankNotches	2023-02-08 13:20:53 +01:00
Dean Herbert	3a3c2e78a1	Merge branch 'master' into skin-editor-undo-support	2023-02-08 15:41:58 +09:00
Dean Herbert	b6809e156b	Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii ... Implement a sheared slider for the updated design	2023-02-08 15:01:00 +09:00
PC	7e127dafe2	Update reference	2023-02-07 11:52:47 +03:00
Dean Herbert	e162fd56da	Change the way initial state saving works in EditorChangeHandler to be closer to first change	2023-02-07 16:22:51 +09:00
tsrk	bc89f8dc5b	feat: add name and rulset verb display support	2023-02-06 12:44:00 +00:00
Cootz	2c7386db39	FIx score appearing on BeatmapLeaderboard and TopLocalRank	2023-02-06 15:14:14 +03:00
Dean Herbert	aaf3ad805c	Fix potential nullref in tests	2023-02-06 19:31:45 +09:00
Dean Herbert	b83c8443ea	Ensure pause sample loop is stopped on exiting player	2023-02-06 18:24:31 +09:00
Terochi	43f7665c9e	Improved readability again	2023-02-06 09:49:42 +01:00
Dean Herbert	c691a0d3af	Merge branch 'master' into sheared_slider_implementation_clean_ii	2023-02-06 17:49:33 +09:00
Dean Herbert	ddcc02fdfe	Merge pull request #22505 from Joehuu/fix-hover-click-sounds ... Fix some clickable elements having no hover and click sounds	2023-02-06 16:52:19 +09:00
Terochi	4f23e096d7	Improved readability	2023-02-06 07:59:37 +01:00
Dean Herbert	778b8a9bf7	Fix default settings not being serialised / state tracked correctly	2023-02-06 15:00:42 +09:00
Dean Herbert	e4b17588f5	Add missing xmldoc to new methods in EditorChangeHandler	2023-02-06 14:11:40 +09:00
Dean Herbert	10ab4d572a	Merge branch 'master' into skin-editor-undo-support	2023-02-06 13:46:50 +09:00
tsrk	bf273597ea	feat: actually support status also for Replays	2023-02-06 00:41:10 +00:00
tsrk	d5b2d9ce97	feat: add support for spectating status	2023-02-05 23:58:08 +00:00
Terochi	f58534f60c	Extended the length of replay at the end of map	2023-02-05 18:51:28 +01:00
Bartłomiej Dach	ef900bccdf	Merge branch 'master' into BPM_counter_fix	2023-02-04 23:44:58 +01:00
mk56-spn	38cc47d64e	Remove ``IsPresent`` usages	2023-02-04 16:52:30 +01:00
Bartłomiej Dach	cb7540564a	Merge pull request #22504 from peppy/fix-editor-positional-nudge-undo ... Fix beatmap editor positional nudging not being undoable	2023-02-04 15:52:34 +01:00
mk56-spn	88872cf1cf	Use ``GetTrueGameplayRate()`` to remove need for jank	2023-02-04 00:53:54 +01:00
mk56-spn	d9bee958dd	Stop ``BPMCounter.cs``'s value from going to 0 after failing.	2023-02-03 23:56:34 +01:00
Bartłomiej Dach	97afb83394	Merge branch 'master' into carousel	2023-02-03 22:15:44 +01:00
Bartłomiej Dach	63f7d326c2	Merge branch 'master' into fix-editor-positional-nudge-undo	2023-02-03 21:31:05 +01:00
Bartłomiej Dach	4bd43171e8	Merge branch 'master' into fix-skin-editor-padding-weirdness	2023-02-03 20:28:47 +01:00
mk56-spn	de37a0a000	enable pixelSnapping for the ``BufferedContainer`` in BeatmapInfoWedgeV2.cs	2023-02-03 19:53:04 +01:00
mk56-spn	5fc8f1d1be	Fix ``BeatmapInfoWedgeV2.cs`` starCounter needing janky rotation application	2023-02-03 19:52:01 +01:00
Dean Herbert	2cda277c09	Add a basic change handler to the skin editor	2023-02-03 18:57:50 +09:00
Dean Herbert	3345e34544	Move beatmap specific logic out of EditorChangeHandler	2023-02-03 17:53:54 +09:00
Joseph Madamba	5a76c1ab9c	Refactor HoverSampleDebounceComponent to inherit Component	2023-02-03 00:29:25 -08:00
Dean Herbert	b437501b0f	Fix beatmap editor positional nudging not being undoable	2023-02-03 17:28:58 +09:00
Dean Herbert	554f14151c	Apply NRT to EditorChangeHandler	2023-02-03 17:13:24 +09:00
Dean Herbert	b19047b90b	Fix skin editor component list having uneven padding	2023-02-03 16:55:51 +09:00
Dean Herbert	4ec46c7476	Merge branch 'master' into footer_V2_implementation	2023-02-03 16:30:16 +09:00
Dean Herbert	48f7e0163c	Adjust comments and formatting of comments	2023-02-03 16:27:20 +09:00
Dean Herbert	4248453616	Use FinishTransforms rather than manual duplication of background colour logic	2023-02-03 16:27:20 +09:00
Dean Herbert	a1200b8fe8	Adjust footer button colour handling to read better and take into account mouse down	2023-02-03 16:27:20 +09:00
Dean Herbert	cf8cfe0d2c	Move skin component localisations to namespaces	2023-02-03 15:34:57 +09:00
Dean Herbert	50559643bb	Fix incorrectly applied enum localisation	2023-02-03 15:27:11 +09:00
Dean Herbert	32207dc9dd	Merge branch 'master' into locale/skin-editor-components	2023-02-03 15:24:00 +09:00
Dean Herbert	f7094567d7	Rename and document method to limit scope	2023-02-03 15:04:47 +09:00
mk56-spn	80fd1a0bc7	Remove leftover comment regarding X axis offsets	2023-02-02 18:29:12 +01:00
mk56-spn	3f0ce75bf5	Rename NormalSliderBar.cs to RoundedSliderBar.cs	2023-02-02 17:24:45 +01:00
Dean Herbert	edecd2ee25	Merge branch 'master' into middle-click-replay-pause	2023-02-02 15:25:51 +09:00
Dean Herbert	91fbf388da	Use localisation strings from ButtonSystem for better consistency	2023-02-02 15:00:24 +09:00
Dean Herbert	500e9c7944	Refactor into a method rather than property	2023-02-02 14:53:58 +09:00
Dean Herbert	942e7729f3	Merge branch 'master' into carousel	2023-02-02 14:41:55 +09:00
tsrk	0fb6a63709	refactor: change namespacing to allow osu-localisation-analyzer to process all strings	2023-02-02 00:46:14 +00:00
tsrk	8645e705fd	feat: add localisation for Skin editor components	2023-02-01 23:48:05 +00:00
mk56-spn	27c52a45fc	Use inline lambda for scheduling	2023-01-30 16:13:55 +01:00
mk56-spn	92690afa5f	de-nest ``removeOldInfo()``	2023-01-30 16:12:26 +01:00
Ruki	96bd79a6f5	Merge branch 'ppy:master' into hud/avatar-thing	2023-01-30 15:43:29 +01:00
mk56-spn	c7d49bdc82	Update ``BeatmapInfoWedgeV2.cs` animation to be similar to exit transition in `SongSelect.cs`	2023-01-30 13:13:57 +01:00
mk56-spn	f5d579144b	Remove free mods button	2023-01-30 12:57:24 +01:00
mk56-spn	41f5e5143a	Remove ``onclick` and `mousedown`` override	2023-01-30 12:56:39 +01:00
mk56-spn	091cc155d3	Fix nub naming in OsuCheckbox.cs and associated classes	2023-01-26 16:10:02 +01:00
mk56-spn	a630f1113f	Rename nub object in NormalSliderBar.cs class	2023-01-26 15:03:51 +01:00
mk56-spn	374c3b56f6	Rename Nub.cs to NormalNub.cs	2023-01-26 15:03:11 +01:00
mk56-spn	3988131475	Rename OsuSliderBar.cs as NormalSliderBar.cs	2023-01-26 12:12:56 +01:00
Dean Herbert	e5d4979bc3	Fix default health bar having a very weird anchor point in the skin editor	2023-01-26 16:56:37 +09:00
Dean Herbert	e333e12b2e	Fix typo in settings enum (seriously)	2023-01-25 16:32:00 +09:00
Dean Herbert	3faab66f39	Merge branch 'master' into beatmapSelectionBlur	2023-01-25 16:32:00 +09:00
Dean Herbert	1a9ed1ac3f	Remove unnecessary IgnoreUserSettings value change	2023-01-25 16:28:06 +09:00
Jérémiah DÉCOMBE	e0a7559d85	variable naming + loc	2023-01-24 09:55:08 +01:00
Jérémiah DÉCOMBE	7ca2a431e6	changing song select background blur setting to boolean	2023-01-24 09:19:53 +01:00
Jérémiah DÉCOMBE	d783998c81	using BindValueChanged and IsCurrentScreen for setting binding	2023-01-24 09:09:05 +01:00
Dean Herbert	bb15ee50e0	Fix beatmap leaderboard potentially showing incorrect leaderboard	2023-01-24 13:52:59 +09:00
Jeremiah DECOMBE	c1876aac88	removing parameter name abbreviations	2023-01-24 00:36:38 +01:00
Jeremiah DECOMBE	b573e42cc2	BeatmapSelectionBackgroundBlurLevel renamed to SongSelectBackgroundBlurLevel	2023-01-24 00:08:11 +01:00
Jeremiah DECOMBE	26adc28943	missing blank line between methods	2023-01-23 23:15:37 +01:00
Jeremiah DECOMBE	f13a5465ba	variable naming and loc modifications	2023-01-23 23:07:50 +01:00
Bartłomiej Dach	7483967157	Merge branch 'master' into SliderEnd-Snap	2023-01-23 21:33:16 +01:00
Bartłomiej Dach	1f40b2daf6	Clean up xmldocs	2023-01-23 21:22:18 +01:00
mk56-spn	655242371b	Buffer wedge content to avoid opacity issues when showing / hiding	2023-01-23 17:00:46 +01:00
Jérémiah DÉCOMBE	6daa364779	adding setting to adjust blur of the background of the song select screen	2023-01-23 13:53:31 +01:00
Dean Herbert	e3932c077b	Merge pull request #22032 from frenzibyte/fix-potential-difficulty-failure-alt ... Fix advanced statistics display potentially performing invalid difficulty calculation	2023-01-23 15:39:47 +09:00
Bartłomiej Dach	06aa3f7798	Rename Stop{SampleAndRemoveFilters -> }() ... Now that just one method for stopping samples is left, let's just repurpose st as the general "stop global effects" method rather than have it there with a hyperspecific name. It also has good symmetry, as there already was a `Start()` method in the class.	2023-01-22 09:29:22 +01:00
Bartłomiej Dach	9e4e85e3e3	Inline StopSample() into StopSampleAndRemoveFilters() ... The first method no longer has any callers except for the second one.	2023-01-22 09:26:01 +01:00
Bartłomiej Dach	0edfd24410	Remove unnecessary sample stop in Restart() ... It is unnecessary, as a successful restart will exit the current player screen, and `OnExiting()` has another `StopSampleAndRemoveFilters()` call, which means that in the restart flow the sample was actually getting stopped twice. Standard exit flow is fine, it only stopped the sample once.	2023-01-22 09:24:12 +01:00
Matheus Filipe dos Santos Reinert	5b1a23c697	Replace RemoveFilters call with StopSampleAndRemoveFilters	2023-01-22 01:44:16 -03:00
Matheus Filipe dos Santos Reinert	2e1ba6ef49	Create StopSampleAndRemoveFilters method and change RemoveFilters to private	2023-01-22 01:43:40 -03:00
Matheus Filipe dos Santos Reinert	a746cbc6ed	Fix failSample still playing after player left FailOverlay	2023-01-22 01:14:33 -03:00