mirror of
https://github.com/ppy/osu.git
synced 2026-05-20 00:20:21 +08:00
Simplify column dimensions code
`dimensions` would always receive exactly one item, so might as well
inline it.
And yes, at this point the grid container is mostly a glorified
`FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not
touching that in this pull pending further decisions with respect to
direction.
This commit is contained in:
@@ -147,7 +147,6 @@ namespace osu.Game.Screens.Ranking.Statistics
|
||||
foreach (var item in statisticItems)
|
||||
{
|
||||
var columnContent = new List<Drawable>();
|
||||
var dimensions = new List<Dimension>();
|
||||
|
||||
if (!hitEventsAvailable && item.RequiresHitEvents)
|
||||
{
|
||||
@@ -161,8 +160,6 @@ namespace osu.Game.Screens.Ranking.Statistics
|
||||
Origin = Anchor.Centre,
|
||||
});
|
||||
|
||||
dimensions.Add(new Dimension());
|
||||
|
||||
rows.Add(new GridContainer
|
||||
{
|
||||
Anchor = Anchor.TopCentre,
|
||||
@@ -170,7 +167,7 @@ namespace osu.Game.Screens.Ranking.Statistics
|
||||
RelativeSizeAxes = Axes.X,
|
||||
AutoSizeAxes = Axes.Y,
|
||||
Content = new[] { columnContent.ToArray() },
|
||||
ColumnDimensions = dimensions.ToArray(),
|
||||
ColumnDimensions = new[] { new Dimension() },
|
||||
RowDimensions = new[] { new Dimension(GridSizeMode.AutoSize) }
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user