Thomas Müller-Höhne
926636cc03
Generalize Bezier curves to BSplines of Nth degree
2023-11-11 13:32:53 +01:00
Bartłomiej Dach
ea556abad8
Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters
2023-11-11 21:28:29 +09:00
Bartłomiej Dach
ee56b4d205
Use barely better assertion fail message in test
2023-11-11 20:56:05 +09:00
Bartłomiej Dach
b7972e3c84
Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters
2023-11-11 20:16:14 +09:00
Bartłomiej Dach
b247b94ecb
Revert test changes
...
They were broken because `SerialisedDrawableInfo` is a reference type
and as such equality checks will use reference equality rather than
member equality.
2023-11-11 19:32:46 +09:00
Bartłomiej Dach
21e1d68b15
Remove unused using directive
2023-11-11 15:52:24 +09:00
Dean Herbert
2e48569982
Improve test comparison logic
...
Doesn't really help that much with nunit output,
but at least you can breakpoint and see the json kinda.
2023-11-10 20:00:51 +09:00
Bartłomiej Dach
b6dcd7d55f
Fix tests so that they actually assert something
2023-11-10 18:48:45 +09:00
Bartłomiej Dach
ec2200d54f
Remove another reference to bar length
2023-11-10 18:26:08 +09:00
Bartłomiej Dach
c522a703eb
Merge branch 'master' into skin-size-editing
2023-11-10 18:19:27 +09:00
Dean Herbert
35e11c7c63
Rename diagonal scale variable and update xmldoc
2023-11-10 17:55:02 +09:00
Bartłomiej Dach
d0f1326a63
Fix formatting
2023-11-10 17:54:48 +09:00
Bartłomiej Dach
8690b08769
Fix compose select box test failures
2023-11-10 16:08:45 +09:00
Dean Herbert
7fc2050f72
Rename variables and mak seconary tooltip type work again
2023-11-10 11:52:34 +09:00
Salman Ahmed
d3af3c615f
Merge branch 'master' into gameplay-hud-redesign/counters
2023-11-10 01:04:03 +03:00
Salman Ahmed
cc9aeb5307
Add test coverage
2023-11-09 22:57:20 +03:00
Salman Ahmed
d4722a3988
Add failing test case
2023-11-09 17:20:10 +03:00
Joshua Hegedus
4900a91c60
fixed static analysis problems and finished the implementation
2023-11-09 13:27:09 +01:00
Joshua Hegedus
ccb9ff826a
fixed tests
2023-11-09 13:09:59 +01:00
Dean Herbert
02966bc02f
Merge branch 'master' into change-clickable-avatars-tooltip-for-usergrid
2023-11-09 18:19:23 +09:00
Bartłomiej Dach
13b599b9b6
Merge branch 'master' into less-basic-touchscreen-detection
2023-11-09 17:36:48 +09:00
Dean Herbert
5ac285ed2f
Merge pull request #25380 from frenzibyte/fix-create-difficulty-crash
...
Fix editor crash when creating a new difficulty in a non-existent beatmap
2023-11-08 18:56:00 +09:00
Dean Herbert
38847c3ac5
Change test to move only on a toggle step
2023-11-08 17:23:01 +09:00
Salman Ahmed
18c71c95cc
Merge branch 'master' into gameplay-hud-redesign/counters
2023-11-08 02:12:37 +03:00
ratinfx
81caa854e6
Separate Test cases by relevant rulesets
2023-11-07 13:02:46 +01:00
ratinfx
aa87e0a44d
HitObject Selection logic and separation for gamemodes
...
+ moved time_regex into EditorTimestampParser
2023-11-07 01:36:58 +01:00
ratinfx
8e8a88cfaf
Removed nullable line from Test
2023-11-07 00:54:15 +01:00
Salman Ahmed
38d16f620c
Alter test case to comply with new behaviour
2023-11-06 21:55:00 +03:00
Salman Ahmed
944fee56f8
Add failing test case
2023-11-06 21:54:40 +03:00
Andrei Zavatski
9d10d93085
Adjust test scene to see graph flickering
2023-11-06 20:45:52 +03:00
Joshua Hegedus
a01f6187f4
testing the tooltip
2023-11-06 14:52:06 +01:00
Joshua Hegedus
718492a0b7
fixed DRY
2023-11-06 11:29:15 +01:00
Joshua Hegedus
b45d8c785c
fixed review findings
2023-11-06 08:38:34 +01:00
Bartłomiej Dach
adb9ca5a13
Add failing test coverage for incorrect treatment of TD in mod presets
2023-11-06 07:56:09 +01:00
Salman Ahmed
634795e45f
Adjust failing test scenes
2023-11-05 02:50:14 +03:00
Salman Ahmed
1d4f4cf4c3
Merge branch 'master' into gameplay-hud-redesign/counters
2023-11-05 02:02:36 +03:00
Salman Ahmed
58a830fc5b
Revert "Add "Argon" performance points counter"
...
This reverts commit 56eeb117ce
2023-11-05 01:55:54 +03:00
ratinfx
7492d953ae
Moved error checks into Editor
...
- Invoke Action on error to Notify user
- added some comments
2023-11-04 21:17:58 +01:00
Joshua Hegedus
ec290ae953
added tests
2023-11-04 19:03:23 +01:00
ratinfx
19cdf99df8
Fixed up tests
2023-11-04 12:04:58 +01:00
ratinfx
f867cff8c7
Added OpenEditorTimestamp Tests
2023-11-04 03:42:08 +01:00
Joseph Madamba
3f8baf913b
Add 100 and 1000 key press step to test overflow
2023-11-02 20:49:01 -07:00
Joseph Madamba
e3b3ce6c84
Fix test overflowing on widescreen + add default (triangles) key counter testing
2023-11-02 20:42:28 -07:00
Joseph Madamba
090601b485
Apply peppy's upright key counter attempt diff
...
Co-Authored-By: Dean Herbert <pe@ppy.sh>
2023-11-02 20:42:23 -07:00
Bartłomiej Dach
d25b54c06d
Split test into two
...
They would fail on CI when written as one, and I don't care why.
2023-11-02 22:14:38 +01:00
Bartłomiej Dach
ef555ed0cf
Fix test failures
2023-11-02 21:24:58 +01:00
Bartłomiej Dach
21a4da463b
Add failing test covering crash scenario
2023-11-02 21:24:58 +01:00
Bartłomiej Dach
29d4d81eaa
Add test scene for basic touchscreen detection scenarios
2023-11-02 21:24:58 +01:00
Bartłomiej Dach
2f6ff893b5
Automatically activate and deactivate touch device mod in song select
2023-11-02 19:45:48 +01:00
Bartłomiej Dach
980c900f43
Add component for game-wide touch detection
2023-11-02 19:32:56 +01:00
Dean Herbert
8c067dc584
Fix mod tests not waiting for presets to finish loading
...
See https://github.com/ppy/osu/actions/runs/6692350567/job/18181352850 .
2023-10-31 14:53:07 +09:00
Dean Herbert
7ceced7012
Scope TestPauseWithLargeOffset to focus on what matters
...
See https://github.com/ppy/osu/actions/runs/6693917410/job/18186111009
This test is to make sure we don't seek before the original
pause time, so I've exposed that value precisely to avoid
CI woes.
2023-10-31 14:47:04 +09:00
Dean Herbert
d379e553da
Fix back-to-front logging
2023-10-31 14:31:26 +09:00
Dean Herbert
bdd3f2847b
Add an extra storyboard sample to avoid intermittent failures in TestStoryboardSamplesStopOnSkip
...
Probably CI running slow timing balls.
The point of failure is `waitUntilStoryboardSamplesPlay()`
after already testing the important part of the test (that
the samples stop on skip) so let's give it another possible
point to recover.
See https://github.com/ppy/osu/actions/runs/6698399814/job/18201753701 .
2023-10-31 14:28:40 +09:00
Dean Herbert
66b84d02cb
Add note about TestGameplayExitFlow failure, and ignore for now
...
See:
https://github.com/ppy/osu/actions/runs/6695995685/job/18194110641
https://github.com/ppy/osu/actions/runs/6700910613/job/18208272419
2023-10-31 14:27:55 +09:00
Dean Herbert
89444d5544
Fix export test still occasionally failing due to file write in progress
...
https://github.com/ppy/osu/actions/runs/6701591401/job/18209826074
Basically, `File.Move` may not be an atomic operation.
2023-10-31 14:00:49 +09:00
Dean Herbert
37ec10d4f5
Fix TestSongSelectScrollHandling not waiting for VolumeOverlay to load
...
See https://github.com/ppy/osu/actions/runs/6701786492/job/18210372721 .
2023-10-31 13:49:53 +09:00
Dean Herbert
fa220d34de
Merge pull request #25272 from frenzibyte/use-scale-adjust-for-player-max-dimensions-test-scene
...
Fix `TestScenePlayerMaxDimensions` texture loading process bottlenecking CI
2023-10-31 13:36:30 +09:00
Dean Herbert
a3dc9a73b1
Revert behaviour changes of MaxDimensions test and ignore instead
2023-10-31 13:36:10 +09:00
Dean Herbert
3060cf1438
Merge pull request #25286 from frenzibyte/search-text-box-select-all
...
Automatically select existing search text when opening settings
2023-10-31 12:14:00 +09:00
Bartłomiej Dach
06508d08fe
Delete outdated test
2023-10-30 20:22:41 +01:00
Bartłomiej Dach
b2d3aa982d
Merge branch 'master' into fix-click-through-timeline
2023-10-30 12:52:00 +01:00
Dean Herbert
8828562512
Merge pull request #25277 from Susko3/fix-cut-in-filter-textbox
...
Fix cut and copy not working in song select search filter textbox
2023-10-30 18:18:46 +09:00
Dean Herbert
63e6eaf538
Fix failing tests
2023-10-30 18:06:11 +09:00
Dean Herbert
6be02966b9
Add test coverage of failing context menu display
2023-10-30 18:06:11 +09:00
Dean Herbert
caddbacfe8
Merge branch 'master' into gameplay-hud-redesign/counters
2023-10-30 16:35:10 +09:00
Salman Ahmed
c7bc8e6865
Move behaviour to settings search text box only
2023-10-30 06:41:01 +03:00
Salman Ahmed
af10dbb76c
Add test case with many tournament banners
2023-10-30 06:20:01 +03:00
Salman Ahmed
ec9ae12bbd
Update API response model to accept array of tournament banners
2023-10-29 01:43:49 +03:00
Salman Ahmed
31c6973bb6
Add test coverage
2023-10-29 01:03:45 +03:00
Susko3
cfc0520481
Add failing test
2023-10-28 12:13:13 +02:00
Salman Ahmed
a53c0adae0
Remove unused using directive
2023-10-28 06:56:12 +03:00
Salman Ahmed
51b7c97cab
Fix TestScenePlayerMaxDimensions bottlenecking CI
2023-10-28 06:07:49 +03:00
Dean Herbert
5a9d4170e8
Merge pull request #24794 from bdach/score-encoding-cleanup
...
Correctly handle multiple online score ID types
2023-10-28 02:29:56 +09:00
Dean Herbert
4ed30342db
Merge pull request #25264 from bdach/quick-retry-f-rank
...
Fix quick retry immediately after completion marking score as failed
2023-10-28 02:29:21 +09:00
Bartłomiej Dach
b5cb538004
Add failing test case for skin editor freeze
2023-10-27 14:23:41 +02:00
Bartłomiej Dach
6789a522d6
Rename test to distinguish it from test-to-come
2023-10-27 14:15:30 +02:00
Bartłomiej Dach
32fc19ea0d
Fix results screen test failure
2023-10-27 13:22:17 +02:00
Bartłomiej Dach
96d784e06b
Delete ScoreInfo.HasReplay as no longer needed
2023-10-27 12:39:54 +02:00
Bartłomiej Dach
3944b045ed
Add extra test coverage for marking score as failed
2023-10-27 12:17:03 +02:00
Bartłomiej Dach
7140eee870
Add failing test coverage for quick retry after completion not changing rank
2023-10-27 12:17:03 +02:00
Dean Herbert
a463c37320
Merge pull request #25243 from bdach/song-select-volume-scroll-blocked
...
Fix left side of carousel blocking volume adjust hotkeys
2023-10-27 00:23:47 +09:00
Bartłomiej Dach
5d6a58d443
Add failing test scene for scroll handling in song select
2023-10-26 16:24:16 +02:00
Bartłomiej Dach
89fec95b01
Fix cross-test data dependency by recreating slider every time
2023-10-26 12:11:26 +02:00
Bartłomiej Dach
96437c4518
Fix tests specifying float precision for double bindable
...
Would cause assignments to `.Value` to become imprecise even if the
underlying bindable could represent the value 100% accurately.
2023-10-26 12:06:03 +02:00
Bartłomiej Dach
910d74fdda
Add failing test coverage for double-click on disabled sliders
2023-10-26 11:59:38 +02:00
Salman Ahmed
df80b4dcab
Update "Argon" health display specifications to match design
...
Also adds a little white bar next to the display to match with the
components below it (score/accuracy/combo counters).
2023-10-26 09:12:05 +03:00
Salman Ahmed
56eeb117ce
Add "Argon" performance points counter
2023-10-26 09:10:10 +03:00
Salman Ahmed
0aa0562dc0
Add "Argon" combo counter
2023-10-26 09:09:55 +03:00
Salman Ahmed
1f36acca1a
Add "Argon" accuracy counter
2023-10-26 09:09:52 +03:00
Salman Ahmed
9ca672d689
Add "Argon" total score counter
2023-10-26 08:58:25 +03:00
Dean Herbert
6934e045df
Fix editor not prompting before saving beatmap for export
2023-10-25 14:39:46 +09:00
Andrei Zavatski
1dbdbd6de6
Merge branch 'master' into comments-image-size
2023-10-23 13:22:31 +03:00
Bartłomiej Dach
dcfd6a0a8a
Remove DistancedHitObjectComposer inheritance from osu! composer
2023-10-19 11:46:30 +02:00
Joseph Madamba
1a3a81c33b
Add slider nub double click revert to default test
2023-10-17 21:41:03 -07:00
Dean Herbert
e081fa48a2
Fix various other inspections
2023-10-17 17:48:51 +09:00
Dean Herbert
5341a335a6
Bypass Parent nullability checks for now
2023-10-17 17:48:45 +09:00
Bartłomiej Dach
9b474b656d
Fix key binding panel test failures from introducing placeholder text
...
Whoops.
2023-10-13 15:03:41 +02:00
Dean Herbert
6358a5e210
Merge pull request #25105 from bdach/multiple-keys-one-binding
...
Disallow binding multiple bindings in a single section to one key
2023-10-13 20:01:33 +09:00
Bartłomiej Dach
5f51b8a7c9
Merge pull request #25097 from peppy/results-screen-progress-fast
...
Show results immediately if user hits "back" key after finishing gameplay
2023-10-13 11:54:34 +02:00
Dean Herbert
17b6ebbfbf
Avoid using a bindable in KeyBindingConflictPopover where data is never mutated
2023-10-13 18:40:21 +09:00
Bartłomiej Dach
d5557bbbfb
Merge pull request #25005 from minetoblend/multiplayer-invites
...
Add ability to invite players to multiplayer rooms
2023-10-13 11:09:28 +02:00
Dean Herbert
37411f923e
Merge branch 'master' into multiple-keys-one-binding
2023-10-13 15:07:12 +09:00
Dean Herbert
aabed8b6e5
Merge pull request #25093 from Joehuu/mod-switch-tiny-extended-info
...
Add extended info support to tiny mod switches
2023-10-13 13:40:24 +09:00
Bartłomiej Dach
f083309e64
Move type back next to exposing class
2023-10-12 20:26:01 +02:00
Bartłomiej Dach
5d637520e7
Add test coverage for key binding conflict resolution
2023-10-12 16:04:46 +02:00
Bartłomiej Dach
f5a6781e5a
Integrate key binding conflict popover into keybindings panel
2023-10-12 16:04:46 +02:00
Bartłomiej Dach
7b6563116a
Implement visual appearance of key binding conflict popover
2023-10-12 16:01:51 +02:00
Bartłomiej Dach
5f0b1d69a5
Prepare KeyBindingRow for accepting external changes
2023-10-12 16:00:20 +02:00
Dean Herbert
fa47309eef
Fix exit key during storyboard outro not progressing to results
2023-10-12 19:31:54 +09:00
Bartłomiej Dach
34bab38e80
Fix judgement counter test failure due to exploiting mania ruleset
...
Large ticks are not a thing in mania anymore, so the judgement counter
tests began to fail as `LargeTickHit` is no longer a valid hit result
in that ruleset.
2023-10-12 11:34:59 +02:00
Dean Herbert
56e27f1c27
Merge branch 'master' into multiplayer-invites
2023-10-12 18:17:15 +09:00
Dean Herbert
e6103fea95
Fix async usage in TestSceneNotificationOverlay
2023-10-12 16:00:36 +09:00
Dean Herbert
3023e44196
Remove unused using statements
2023-10-12 15:52:48 +09:00
Dean Herbert
73b8146729
Update tests in line with new behaviour
2023-10-12 15:42:54 +09:00
Dean Herbert
256c95f045
Add (failing) test coverage of exit/retry during progress to results
2023-10-12 15:42:20 +09:00
Joseph Madamba
418549b48d
Modify some half time mods on test
...
For use after support of extended info on `ModSwitchTiny`.
2023-10-11 13:00:39 -07:00
Joseph Madamba
764f641bc9
Add extended info support to tiny mod switches
2023-10-11 12:47:12 -07:00
Bartłomiej Dach
712564ea4f
Enable NRT in KeyBindingsSubsection
2023-10-11 20:03:31 +02:00
Joseph Madamba
6a9f17d97c
Merge remote-tracking branch 'upstream/master' into pr/22237
2023-10-11 09:53:26 -07:00
Joseph Madamba
e32be36d92
Move invalidation issue todo to tests
2023-10-10 22:29:43 -07:00
Joseph Madamba
ba62498478
Add set up steps to reinit drawables with a different relative width
2023-10-10 20:47:15 -07:00
Joseph Madamba
e049a072f8
Update right content to latest design
...
- Add more scenarios to test
- Future-proof mods display to not overflow
2023-10-10 20:24:25 -07:00
Joseph Madamba
bb3f426b93
Truncate name label and clean up positioning code
...
Also adds a test score with a long username.
2023-10-10 18:26:00 -07:00
Joseph Madamba
43c8d51d02
Add draw width statistic to test
2023-10-10 16:47:33 -07:00
Joseph Madamba
39b008b070
Move test scores to a method and add TestResources.CreateTestScoreInfo()
2023-10-10 16:47:33 -07:00
Joseph Madamba
dad03778b7
Fix leaderboard score caching colour provider
2023-10-10 16:47:33 -07:00
Joseph Madamba
c0b8b3509f
Populate dates and add show animation on test
2023-10-10 16:47:33 -07:00
Dean Herbert
4319b22db8
Add failing test coverage of player not pausing track correctly
2023-10-10 17:55:35 +09:00
Bartłomiej Dach
ea400a9db7
Fix cross-test interference
...
`TestLastPlayedUpdated` was implicitly relying on running first.
`TestGuestScoreIsStoredAsGuest` showing up changed test ordering,
causing the former test to fail if it didn't get to run first.
2023-10-10 09:30:51 +02:00
Bartłomiej Dach
08b1a3cbe2
Add failing test case for guest user being looked up in API
2023-10-10 09:18:57 +02:00
Dean Herbert
7c7771afca
Merge pull request #24986 from peppy/health-animates-in-intro
...
Add initial animation for health bars
2023-10-07 10:31:34 +09:00
Bartłomiej Dach
a099cc0f36
Merge pull request #25030 from peppy/adjustable-health-bar
...
Adjust argon health bar to fit with existing layout
2023-10-06 21:51:18 +02:00
Dean Herbert
1a60e6d76e
Merge branch 'master' into health-animates-in-intro
2023-10-07 00:32:19 +09:00
Dean Herbert
71be3c8f8b
Add ability to adjust health bar settings in test scene
2023-10-06 19:34:27 +09:00
Dean Herbert
db5178e453
Change ArgonHealthDisplay to be relative sized for now
2023-10-06 18:56:39 +09:00
Dean Herbert
1005b7ac85
Fix incorrect test assumption in TestSceneEditorClock
...
I don't know what this test was trying to do, but it was wrong. Any
offset which is applied should be invisible to the clock's final
`CurrentTime` (and to the user).
2023-10-06 16:43:28 +09:00
Dean Herbert
354193c53a
Merge branch 'master' into clock-fix-attempt-2
2023-10-06 16:43:27 +09:00
Bartłomiej Dach
c195fbe76f
Merge branch 'master' into crop-gameplay-textures
2023-10-05 09:35:58 +02:00
Dean Herbert
5a0faaa0b1
Fix TestReplayExport intermittent failure
...
The previous fix was not working as it was checking the path for the
prefix `_`, not the filename.
See https://github.com/ppy/osu/runs/17415814653#r0s2 which clearly shows
this.
2023-10-05 14:30:06 +09:00
Bartłomiej Dach
bd71403309
Merge branch 'master' into health-animates-in-intro
2023-10-04 13:53:42 +02:00
Dean Herbert
5a17a86d1d
Merge branch 'master' into clock-fix-attempt-2
2023-10-04 16:57:49 +09:00
Marvin Schürz
5678d90461
Reduce silliness of notification test case
2023-10-04 00:20:38 +02:00
Bartłomiej Dach
844a3b6c1b
Merge pull request #24980 from frenzibyte/gameplay-hud-redesign/health-display
...
Implement redesigned health bar display for "Argon" skin
2023-10-03 11:26:21 +02:00
Dean Herbert
e1445fcc65
Adjust health display test scene's background colour to better visualise background fill
2023-10-03 17:17:42 +09:00
Marvin Schürz
e81695bcac
Display avatar in invitation notification
2023-10-02 23:10:51 +02:00
Dean Herbert
622cbc3af7
Adjust test scene to actually make HP bars fit
2023-10-02 16:07:45 +09:00
Salman Ahmed
9e2b8254d9
Add argon-specific health display test scene
2023-10-01 13:26:47 +03:00
Salman Ahmed
776536e816
Add "Argon" health display implementation
2023-10-01 00:56:16 +03:00
Salman Ahmed
869f8e5e1b
Adjust test scene to apply miss judgements as well
2023-10-01 00:21:24 +03:00
Salman Ahmed
314ecec65b
Refactor player max dimensions test scene to actually upscale textures
2023-09-30 01:34:49 +03:00
Bartłomiej Dach
7638ea36a0
Merge branch 'master' into mod-icon-extended
2023-09-28 16:57:17 +02:00
Dean Herbert
b8953e8ce1
Code quality pass
2023-09-28 19:03:34 +09:00
Bartłomiej Dach
afa1815d13
Merge pull request #24929 from peppy/reduce-song-select-debounce
...
Reduce delay before loading beatmap after selection change at song select
2023-09-28 10:45:43 +02:00
Dean Herbert
4d5b2477dc
Fix failing song select tack transfer test by using a real track
2023-09-28 15:59:06 +09:00
Dean Herbert
16e752e07d
Add basic structure and test coverage for extended info on mod icon
2023-09-27 19:29:03 +09:00
Dean Herbert
a7237e48aa
Merge branch 'master' into fix-storyboard-skin-textures-lookup
2023-09-27 17:17:51 +09:00
Bartłomiej Dach
12585c9f27
Fix flaky editor beatmap creation test
...
Came up as a failure when locally running tests for
ppy/osu-framework#6001 - but the test is actually a previously-known
flaky that I couldn't reproduce the failure of until the aforementioned
PR.
This appears to be a simple race; the test scene queries the track
length from update thread, but the length is actually set on the audio
thread. So it's not unreasonable that given unlucky timing, the length
will not be set by `TrackBass` before it is queried.
To fix, switch assert to until step. I'm generally not really willing
to give this more time of day until this change is proven insufficient.
2023-09-26 16:42:59 +02:00
Dean Herbert
40a548d372
Adjust new test scene to not be super broken
2023-09-26 17:30:49 +09:00
Dean Herbert
990c54519b
Merge branch 'master' into limit-gameplay-sprite-dimensions
2023-09-26 16:40:32 +09:00
Dean Herbert
b1561b650f
Rename test scene, add xmldoc and increase scale factor to something absurdly high
2023-09-26 16:39:36 +09:00
Dean Herbert
2ca1c684bb
Merge branch 'master' into fix-storyboard-skin-textures-lookup
2023-09-26 14:05:27 +09:00
Andrei Zavatski
292273edbe
Add test scene
2023-09-23 06:31:26 +03:00
Joseph Madamba
f7f390195a
Add user covers to centre content
2023-09-22 19:59:40 -07:00
Joseph Madamba
228731493e
Add relative width slider to test
2023-09-22 19:59:40 -07:00
Dean Herbert
c40bd74138
Update usages of GameplayClockContainer not using an adjustable source
2023-09-22 16:22:36 +09:00
Dean Herbert
8367bb6bee
Don't apply decoupling to SpectatorPlayerClocks
...
See inline comment for reasoning. It's a bit complicated.
2023-09-22 16:22:35 +09:00
Joseph Madamba
70b16d7246
Merge remote-tracking branch 'upstream/master' into pr/22237
2023-09-21 22:51:23 -07:00
Dean Herbert
3f27be1f33
Replace most usages of DecoupleableInterpolatingFramedClock
...
Except `FramedBeatmapClock`, which is the high-effort one.
2023-09-22 12:49:25 +09:00
Bartłomiej Dach
e45d456324
Fix TestFriendScore intermittently failing due to randomness
...
If `createRandomScore()` happened to randomly pick the highest total
score when called with `friend` as the sole argument, that particular
score would not be pink.
`GetScoreByUsername()` would arbitrarily pick the first score for the
user, so in this particular case where a friend had the number 1 score,
the test would wrongly fail.
Fix by checking whether any of the 3 added friend scores have received
the pink colour. Because there is more than 1 friend score in the test,
doing so ensures that at least one of those should eventually become
pink (because, obviously, you can't have two scores at number 1).
2023-09-21 21:12:44 +02:00
Bartłomiej Dach
9301a1907a
Rewrite TestFriendScore assertions to constraint model
...
Allows to clearly see what the failure is:
TearDown : System.TimeoutException : "friend score is pink" timed out: Expected: some item equal to "#FF549A"
But was: < "#FFFFFF", "#7FCC33", "#444444 " >
The #7FCC33 colour is used for the first score on the leaderboard.
2023-09-21 21:05:41 +02:00
Bartłomiej Dach
d73f06fc89
Add test coverage for delete hotkey
2023-09-21 20:01:59 +02:00
Bartłomiej Dach
69ed99dfd5
Merge branch 'master' into mania-edit-disable-sv
2023-09-21 09:13:27 +02:00
Bartłomiej Dach
d7129da8ea
Fix TestSceneDrawableStoryboardSprite not displaying anything
2023-09-20 12:05:23 +02:00
Dean Herbert
c5397bdbb3
Merge branch 'master' into mania-edit-disable-sv
2023-09-20 14:23:07 +09:00
Dean Herbert
1927b524db
Merge branch 'master' into leaderboard-friend-highlight
2023-09-20 14:14:08 +09:00
Dean Herbert
1316403180
Fix inspection in new test scene
2023-09-20 13:02:40 +09:00
Dean Herbert
2f020f8682
Add test coverage of storyboard preferring skin when specified
2023-09-19 20:20:20 +09:00
Dean Herbert
067c487b21
Merge pull request #24450 from cdwcgt/missing-beatmap
...
Fetch missing beatmap when importing replay
2023-09-19 18:40:02 +09:00
Dean Herbert
f726c38215
Pass ArchiveReader instead of Stream to simplify resolution code
2023-09-19 17:49:15 +09:00
Salman Ahmed
8e992de763
Fix crash when loading player instance without exiting previous instance
2023-09-19 05:09:01 +03:00
Salman Ahmed
a373d71b3e
Add basic test scene upscaling all skin elements
2023-09-19 03:40:31 +03:00
Salman Ahmed
57dc76b345
Revert "Update GetTexture signature rather than creating new overload"
...
This reverts commit 96f12cfbaa
2023-09-19 03:21:19 +03:00
Bartłomiej Dach
775f96f061
Add very basic visual tests for missing beatmap notification
...
The full-stack test using the whole 9 `OsuGameTest` yards is unusable
for rapid development. I don't really get how you could ever design
anything using it without tossing your computer out the window.
2023-09-18 14:56:06 +02:00
Bartłomiej Dach
06d1a2a316
Merge branch 'beatmap-card-nano' into missing-beatmap
2023-09-18 14:56:06 +02:00
Dean Herbert
f3b6aa5435
Merge pull request #24821 from bdach/scoring-test-scene-osu
...
Refactor scoring test scene for ruleset extensibility (and move existing instance to osu! ruleset project)
2023-09-18 19:54:14 +09:00
Bartłomiej Dach
5c2413c06b
Implement nano beatmap card
2023-09-18 11:30:14 +02:00
Bartłomiej Dach
3709861132
Merge pull request #24814 from LukynkaCZE/parse-only-supported-char-uris
...
Parse only supported schemes as URIs
2023-09-18 10:20:09 +02:00
Bartłomiej Dach
45751dd1f2
Minimum viable changes for ruleset-specific scoring test scenes
2023-09-15 12:58:29 +02:00
Lukynka CZE
2a18f76b02
add visual test
2023-09-14 17:48:10 +02:00
Dean Herbert
32946413de
Change display text from "difficulty" to "score" multiplier
2023-09-13 20:01:19 +09:00
Dean Herbert
35840bf671
Combine ModCounterDisplay and DifficultyMultiplierDisplay into one class
2023-09-13 18:51:56 +09:00
Bartłomiej Dach
7c65a9de75
Fix Score V1 simulation in scoring test scene incorrectly applying multiplier
...
`TestSceneScoring` included a local simulation of stable's Score V1
algorithm. One of the parts of said algorithm is a mysterious
"score multiplier", influenced by - among others - the beatmap's drain
rate, overall difficulty, circle size, object count, drain length,
and active mods. (An implementation of this already exists in lazer
source, in `OsuLegacyScoreSimulator`, but more on this later.)
However, `TestSceneScoring` had this multiplier in _two_ places, with
_two_ distinct values, one of which being 1 (i.e. basically off).
Unfortunately, the place that had 1 as the multiplier was the wrong one.
Stable calculates the score increase for every hit in two stages;
first, it takes the raw numerical value of the judgement, but then
applies a combo-based bonus on top of it:
scoreIncrease += (int)(Math.Max(0, ComboCounter.HitCombo - 1) * (scoreIncrease / 25 * ScoreMultiplier));
On the face of it, it may appear that the `ScoreMultiplier` factor
can be factored out and applied at the end only when returning total
score. However, once the above formula is rewritten as:
scoreIncrease = scoreIncrease + (int)(Math.Max(0, ComboCounter.HitCombo - 1) * (scoreIncrease / 25 * ScoreMultiplier));
= scoreIncrease * (1 + (Math.Max(0, ComboCounter.HitCombo - 1) / 25 * ScoreMultiplier))
it becomes clear that that assumption is actually _incorrect_,
and the `ScoreMultiplier` _must_ be applied to every score increase
individually.
The above was cross-checked experimentally against stable source
on an example test map with 100 objects, and a replay hitting them
perfectly.
2023-09-12 21:33:26 +02:00
Bartłomiej Dach
3981e2e957
Only show visible graph values in tooltip
2023-09-12 13:29:02 +02:00
Bartłomiej Dach
15708ee465
Add toggle for showing relative/absolute score values
2023-09-12 13:27:40 +02:00
Bartłomiej Dach
607ceeccb9
Persist visibility state of graphs
2023-09-12 12:19:50 +02:00
Bartłomiej Dach
3cf8082aa7
Add capability to toggle visibility of graph
2023-09-12 12:07:12 +02:00
Bartłomiej Dach
95d15a703e
Improve legibility of scoring test scene
...
- Add black background to avoid clashes with background images.
- Use sorta-tetradic colours for the four plots.
2023-09-12 11:36:41 +02:00
Dean Herbert
0d7157f727
Merge branch 'master' into map_info_on_mod_settings
2023-09-12 17:16:47 +09:00
Dean Herbert
7e3652284d
Adjust various class naming and add some xmldoc
2023-09-12 17:15:16 +09:00
Dean Herbert
b4bedee49e
Adjust naming of component to give more context
2023-09-12 15:43:59 +09:00
tsrk.
dbc07bc6dc
fix: provide OverlayColourProvider as a dep in tests
2023-09-12 01:34:17 +02:00
Bartłomiej Dach
824416067e
Fix test failure
2023-09-11 20:53:17 +02:00
tsrk.
8c137353b6
feat: integrate previous usernames tooltip to profile overlay
2023-09-11 15:02:19 +02:00
Bartłomiej Dach
f9d4fbee56
Add collapsed state to effect preview panel
2023-09-11 10:16:24 +02:00
Bartłomiej Dach
589f56d20c
Merge branch 'master' into map_info_on_mod_settings
2023-09-11 09:55:54 +02:00
Bartłomiej Dach
53c30dca64
Fix data flow being sometimes incorrect
2023-09-11 09:53:58 +02:00
Bartłomiej Dach
a631fae6df
Add actual testing
2023-09-11 09:19:37 +02:00
Dean Herbert
87ec33bb66
Tidy up test
2023-09-07 14:50:22 +09:00
Joseph Madamba
5ee412cc9a
Use @2x variant of profile badges
2023-09-06 16:17:53 -07:00
cdwcgt
68752f95e5
color friend score to pink
2023-09-06 22:58:03 +09:00
Dean Herbert
1a37543d28
Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
2023-09-06 19:01:08 +09:00
Bartłomiej Dach
eddb879973
Merge pull request #24722 from peppy/beatmap-status-pill-animation
...
Add animation support for beatmap status pills
2023-09-06 09:59:21 +02:00
Bartłomiej Dach
b5e812eb3e
Merge pull request #24723 from bdach/beatmap-carousel-split-missing-status
...
Fix status on carousel beatmap set not showing in split difficulty mode
2023-09-06 09:35:38 +02:00
Bartłomiej Dach
b884f1af4a
Assign random statuses to beatmap sets in carousel test
...
Just to have visual coverage of the statuses before fixing them not
propagating to split difficulty mode.
2023-09-06 08:25:07 +02:00
Dean Herbert
dded7fe6ca
Merge branch 'master' into beatmap-options-popover
2023-09-06 15:16:34 +09:00
Dean Herbert
034c887dcb
Add animation support for beatmap status pills
...
To be used in conjunction with https://github.com/ppy/osu/pull/22116
2023-09-06 15:04:25 +09:00
Joseph Madamba
3f92dae55c
Move star rating display and status pill out of reloadable content
2023-09-05 15:20:20 -07:00
Joseph Madamba
676240928e
Move actual star updating to star rating display
2023-09-05 14:57:55 -07:00
Dean Herbert
96f12cfbaa
Update GetTexture signature rather than creating new overload
2023-09-05 18:01:19 +09:00
Dean Herbert
02fefff5e7
Add better testing of options popover
2023-09-05 16:44:46 +09:00
Dean Herbert
340edf68d3
Fix test scene not updating all star counters
2023-09-05 15:59:00 +09:00
Joseph Madamba
9451613391
Rename null beatmap test to indicate there's a background
2023-09-04 21:39:41 -07:00
Joseph Madamba
854bb323cc
Remove weird red edge effect visibility
2023-09-04 21:21:55 -07:00
Joseph Madamba
e0a9c7e9a9
Fix wedge showing abruptly in test
2023-09-04 14:54:58 -07:00
Joseph Madamba
2df2002735
Move negative corner radius margin to constructor
2023-09-04 12:42:01 -07:00
Joseph Madamba
2fbd67cf26
Merge branch 'master' into beatmap_wedge_clean_ii
2023-09-04 11:24:20 -07:00
Joseph Madamba
5abf271b56
Implement beatmap options popover
2023-09-04 00:53:09 -07:00
cdwcgt
58844092d6
post a notification instead a screen
2023-09-04 16:17:21 +09:00
cdwcgt
dfecddbf5d
Merge branch 'master' into missing-beatmap
2023-09-04 12:41:23 +09:00
Magnus-Cosmos
ae9c901b94
Fix BeatmapInfoWedge tests failing due to BPM
2023-09-03 01:45:22 -04:00
Dean Herbert
0f5eff1230
Merge branch 'master' into mania-edit-disable-sv
2023-09-01 19:08:48 +09:00
Bartłomiej Dach
118c86df34
Fix TestSceneUpdateBeatmapSetButton using random difficulty count
2023-08-28 14:57:00 +02:00
Bartłomiej Dach
6251803868
Add failing test coverage of selection not being retained on song select
2023-08-28 10:05:59 +02:00
Bartłomiej Dach
3a6920c306
Add failing test coverage of beatmap update flow w/ split diffs
2023-08-28 09:51:44 +02:00
Dean Herbert
84f4fab9cf
Adjust test to actually test diff splitting
2023-08-25 18:09:51 +09:00
Dean Herbert
b471ab07a6
Fix typo in test step
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-24 18:30:59 +09:00
Dean Herbert
ba70d48d2c
Fix one more test probably going off-screen
2023-08-24 13:31:33 +09:00
Dean Herbert
4881130cae
Limit set/diff count in test to better fit on screen
2023-08-24 03:32:12 +09:00
Dean Herbert
5eac604f8b
Add coverage of selection retention when difficulties are split out
2023-08-23 19:44:42 +09:00
Dean Herbert
a64381f855
Add test coverage of add/remove when difficulties are split out
2023-08-23 19:43:08 +09:00
Dean Herbert
5555f73e97
Update test to match new behaviour
2023-08-23 19:38:18 +09:00
Dean Herbert
e7d61e0002
Fix star fountain directions not matching stable
2023-08-21 17:59:24 +09:00
Bartłomiej Dach
90bef267c8
Merge pull request #24581 from OliBomby/fix-segment-ends
...
Fix `SliderPath.GetSegmentEnds`
2023-08-21 09:29:13 +02:00
Bartłomiej Dach
479c463751
Explain why segment end positions are not recovered in test
2023-08-21 08:29:51 +02:00
Bartłomiej Dach
3d52a1267e
Fix test failures via test-local popover containers
2023-08-19 15:08:30 +02:00
Bartłomiej Dach
2b09594823
Use nunit constraints in test for better debug experience
2023-08-19 14:33:26 +02:00
OliBomby
fbf4d3ac81
Add test
2023-08-18 12:36:34 +02:00
Dan Balasescu
a2fd7707a1
Allow toggling SVs in the editor
2023-08-18 18:55:24 +09:00
OliBomby
080d2b62f4
fix focus test
2023-08-16 23:16:57 +02:00
Dean Herbert
59a31cc868
Merge pull request #24431 from bdach/slider-with-textbox-instantaneous
...
Add instantaneous mode to `SliderWithTextBoxInput`
2023-08-16 20:10:52 +09:00
Bartłomiej Dach
f9ca7f3e0e
Merge pull request #24564 from peppy/multi-spectator-test-improvements
...
Add various testing improvements to various tournament components
2023-08-16 12:29:36 +02:00
Bartłomiej Dach
bdf87e43db
Merge branch 'master' into slider-with-textbox-instantaneous
2023-08-16 10:48:45 +02:00
Dean Herbert
26d05afadc
Add more test coverage to multi spectator screen
2023-08-16 17:14:42 +09:00
Dean Herbert
56eb44d15b
Change TestSpectatorClient to provide some better fake data for score / acc
2023-08-16 17:14:42 +09:00
Bartłomiej Dach
4f47b196c1
Merge branch 'master' into fix-unsafe-realm-access
2023-08-16 09:59:17 +02:00
Dean Herbert
a8824c8c8a
Remove flaky test documentation for fixed test
2023-08-16 14:30:10 +09:00
cdwcgt
e7b34cd4da
declare BeatmapSet is not null
2023-08-14 03:43:16 +09:00
Bartłomiej Dach
4152b4e523
Remove duplicated test case
2023-08-12 22:46:18 +02:00
QuantumSno
e9bb9434e9
Merge remote-tracking branch 'origin/leaderboard-toggle' into leaderboard-toggle
2023-08-12 00:19:48 -04:00
QuantumSno
562af8b46d
Updated test TestSceneGameplayChatDisplay.cs. Now uses new default bind for toggle chat (enter)
2023-08-12 00:18:10 -04:00
Bartłomiej Dach
d91798271d
Add test case covering exit block
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-08-08 22:06:49 +02:00
nanashi-1
9bdff29dd7
add visual test
2023-08-07 09:50:54 +08:00
Joseph Madamba
d179fe3d96
Add support for changelog entries with url attached
2023-08-03 23:24:37 -07:00
Bartłomiej Dach
dde03b7d46
Merge branch 'master' into playfield-skin-layer
2023-08-03 20:42:15 +02:00
cdwcgt
eef63b41da
fetch missing beatmap when import score with missing beatmap
2023-08-02 17:58:05 +09:00
Dean Herbert
0e510088f9
Ensure background of gameplay is black when storyboard is overriding background display
2023-08-02 15:50:15 +09:00
Bartłomiej Dach
5b6c3321cf
Merge branch 'master' into multi-spectator-flow-fixes
2023-08-01 19:03:48 +02:00
Bartłomiej Dach
bcfc76b469
Add visual-only test coverage for centred player case
2023-08-01 17:41:07 +02:00
Dean Herbert
ed0c7e8880
Add failing test coverage showing crash on multiple StartGameplay invocations
2023-08-01 19:21:58 +09:00
Bartłomiej Dach
049215f2dc
Add test coverage for invalid input scenarios
2023-08-01 01:02:16 +02:00
Bartłomiej Dach
4fb0ff8800
Implement instantaneous SliderWithTextBoxInput mode
2023-08-01 01:02:16 +02:00
Bartłomiej Dach
0b019f1d45
Add test covering desired instantaneous behaviour
2023-08-01 01:01:37 +02:00
Bartłomiej Dach
ca81f23356
Add test covering non-instantaneous behaviour
2023-08-01 01:01:37 +02:00
Dean Herbert
528298bc39
Update test in line with framework changes
2023-08-01 07:17:12 +09:00
Dean Herbert
f06b203067
Merge branch 'master' into edit-nodesample
2023-07-31 14:06:38 +09:00
Bartłomiej Dach
ebe5dd2ac9
Interface with SelectionRotationHandler via DI rather than explicit passing
2023-07-30 20:21:41 +02:00
Bartłomiej Dach
262f25dce8
Make SelectionRotationHandler a Component
2023-07-30 20:18:33 +02:00
Bartłomiej Dach
821cd08f34
Merge branch 'master' into selection-operations-refactor
2023-07-30 19:29:06 +02:00
Bartłomiej Dach
898913f32a
Merge pull request #24415 from peppy/multi-spectator-improvements
...
General visual improvements to mutliplayer spectatator screen
2023-07-30 12:43:26 +02:00
Bartłomiej Dach
e208f38bcb
Merge pull request #24361 from peppy/fix-editor-global-music-hotkey-conflicts
...
Disallow interacting with the global track state in `Player` and `Editor`
2023-07-30 12:28:53 +02:00
Dean Herbert
feea412bec
Add test with only one player
2023-07-30 14:40:24 +09:00
Bartłomiej Dach
43a51671ac
Fix wrong test step name
2023-07-29 16:12:02 +02:00
Bartłomiej Dach
aca8310cd1
Fix non-compiling test
...
To be fair, currently the test is a bit pointless (as it has no reason
to be a `SkinnableTestScene`, it gains precisely nothing from it - all
that is shown there is some generic components on song select). But that
is no worse then `master`, so look away for now.
2023-07-28 23:36:57 +02:00
Dean Herbert
269d4d1cd6
Add test coverage of autoplay restore not working
2023-07-28 14:49:06 +09:00
Bartłomiej Dach
22163020c3
Merge pull request #24367 from peppy/fix-replay-export-from-results
...
Fix attempting to export replay from results screen after play not working
2023-07-27 20:47:07 +02:00
Dean Herbert
e702e0a23e
Avoid intercepting temporary files in new test
2023-07-27 17:44:36 +09:00
Bartłomiej Dach
f66093d3cf
Revert failing test to prior assertions too
2023-07-26 21:51:32 +02:00
Bartłomiej Dach
7bc3edb05a
Fix code quality inspection
2023-07-26 20:52:03 +02:00
Dean Herbert
2dace742a3
Add test coverage of score arriving on disk when exporting from results screen after play
2023-07-26 15:21:43 +09:00
Bartłomiej Dach
653f01f4ce
Merge pull request #24359 from peppy/fix-unknown-mod-test-failure
...
Fix `TestSceneUnknownMod` failing due to null reference
2023-07-25 22:40:03 +02:00
Bartłomiej Dach
3b9f250c1b
Merge branch 'master' into menu-star-fountains
2023-07-25 21:58:13 +02:00
Bartłomiej Dach
d75e6f78d6
Adjust cyclic selection test to hitcircle lifetime adjustments
...
As it turns out, the tightening of hitcircle lifetimes in editor caused
the test to fail, since the objects were too far apart and at the
starting time of the test, the first object was fully faded out and as
such not alive, therefore leading cyclic selection to fail to select it.
To fix, bring all three objects closer together time-wise so that this
does not happen and the test can continue to exercise its original
behaviour.
2023-07-25 18:54:13 +02:00
Dean Herbert
157b1f301b
Rename AllowTrackAdjustments to more understandable ApplyModTrackAdjustments
2023-07-25 20:20:53 +09:00
Dean Herbert
060ad36d60
Add test coverage of music control in editor from external
2023-07-25 20:20:53 +09:00
Dean Herbert
c1d93607e0
Fix TestSceneUnknownMod failing due to null reference
2023-07-25 19:06:13 +09:00
Bartłomiej Dach
21df0e2d60
Migrate test to SelectionRotationHandler
2023-07-23 20:56:22 +02:00
Bartłomiej Dach
2ef843261b
Adjust failing test after metrics changes
2023-07-21 19:08:40 +02:00
Dean Herbert
ca3d1538ae
Merge branch 'master' into editor-metrics
2023-07-21 14:26:32 +09:00
Dean Herbert
b29a2081ac
Merge branch 'master' into menu-star-fountains
2023-07-21 14:21:16 +09:00
Bartłomiej Dach
c77d3cd6bd
Merge pull request #24294 from peppy/toggle-all-freemods
...
Add ability to toggle all free mods quickly at multiplayer song select
2023-07-20 22:32:53 +02:00
Bartłomiej Dach
48024cd17f
Add test coverage of double click behaviour
2023-07-20 20:51:17 +02:00
Bartłomiej Dach
f60a6e9893
Fix test step descriptions
2023-07-20 20:47:33 +02:00
Bartłomiej Dach
708dd355cd
Merge branch 'master' into editor-cyclic-selection
2023-07-20 20:19:46 +02:00
Bartłomiej Dach
210e114f7d
Merge branch 'master' into editor-prefer-closest
2023-07-20 19:16:09 +02:00
Dan Balasescu
733ce4c382
Fix incorrect dependency caching
...
These are tested framework-side to throw exceptions, but the
test is ignored for the source generated version because it quietly
allows this scenario.
The source gen project should eventually have an analyser for these
unsupported cases, or we could consider relaxing this particular case.
2023-07-20 22:30:49 +09:00
Bartłomiej Dach
f3a95d4c13
Merge branch 'master' into menu-star-fountains
2023-07-19 21:26:41 +02:00
Dean Herbert
eb149942e5
Add ability to toggle all free mods quickly at multiplayer song select
2023-07-19 19:08:32 +09:00
Dean Herbert
94c5b8ed32
Apply NRT to TestSceneComposerSelection
2023-07-19 17:22:25 +09:00
Dean Herbert
d33b174243
Add test coverage of beatmap editor cyclic selection
2023-07-19 17:21:20 +09:00
Dean Herbert
9d46d00294
Update skin editor cyclic test to match expectations better
2023-07-19 16:56:16 +09:00
Dean Herbert
4e4dcc9846
Add test coverage of selection preferring closest objects
2023-07-19 16:56:16 +09:00
Dean Herbert
7f336b8dac
Merge branch 'master' into editor-metrics
2023-07-19 15:00:51 +09:00
Dean Herbert
2e3d1fe950
Fix regression in time jumping behaviour
2023-07-19 13:38:04 +09:00
Bartłomiej Dach
a42992d3fd
Remove unused local variable
2023-07-16 17:10:26 +02:00
Bartłomiej Dach
72bf43e297
Add failing test covering exit dialog crash
2023-07-16 16:55:20 +02:00
Dean Herbert
56acc9e3dd
Change BeatDivisorControl to retrive bindable divisor via DI
2023-07-14 14:03:25 +09:00
Bartłomiej Dach
cdbb6f90be
Merge pull request #24199 from peppy/revert-to-default-design-change
...
Update design of "revert to default" button
2023-07-13 23:44:24 +02:00
Bartłomiej Dach
ff56e35093
Merge pull request #24197 from peppy/allow-autoplay-failure
...
Allow autoplay to fail
2023-07-13 23:44:07 +02:00
Bartłomiej Dach
e7dbe3c938
Fix broken test
2023-07-13 22:28:26 +02:00
Bartłomiej Dach
cef0dd1d61
Merge pull request #24190 from novialriptide/emoji-fix
...
Replace emoji unicode with `[emoji]`
2023-07-13 22:05:12 +02:00
Bartłomiej Dach
6b9dabbd3c
Rewrite test scene to show non-themed and themed variants
2023-07-13 21:54:30 +02:00
Bartłomiej Dach
ae7ed697ec
Adjust failing test after permitting autoplay and no fail combo
2023-07-13 21:22:48 +02:00
Bartłomiej Dach
4859b8c994
Add some extra text coverage against potential emoji-to-link misparses
2023-07-13 20:51:52 +02:00
Bartłomiej Dach
9b771ee798
Merge pull request #24202 from peppy/save-preset-on-select
...
Allow saving changes to mod presets using enter key
2023-07-13 19:50:16 +02:00
Bartłomiej Dach
4b06b6f34e
Crudely fix crashes when switching between TestResultsWithPlayer cases
...
In the visual test browser, if two `TestResultsWithPlayer` test cases
are ran consecutively, the second would die on `SoloStatisticsWatcher`
seeing duplicated online score IDs. This surfaced after
6ef39b87fe
2023-07-13 19:06:02 +02:00
Dean Herbert
1698caa078
Add kiai fountains to main menu
2023-07-13 22:13:40 +09:00
Dean Herbert
20e4e2581a
Change IBeatSyncProvider.Clock to always be non-null
2023-07-13 22:13:40 +09:00
Dean Herbert
6ef39b87fe
Reorder tests for testability
2023-07-13 18:12:46 +09:00
Dean Herbert
654a7057fc
Add actual statistics changes to better visualise layout
2023-07-13 18:12:46 +09:00
Dean Herbert
aebbffacf2
Show online stats on TestSceneStatisticsPanel
...
Fix test regression
2023-07-13 18:12:37 +09:00
Dean Herbert
b7ab46d87b
Add full statistics score to TestSceneResultsScreen
2023-07-13 18:12:35 +09:00
Dean Herbert
6529c810fa
Change order and test population in TestSceneStatisticsPanel to give better visible results
2023-07-13 18:12:19 +09:00
Dean Herbert
db37de45ac
Allow saving changes to presets in popover using "select" binding
2023-07-13 17:53:26 +09:00
Dean Herbert
f5c472c0fe
Don't hide mod select overlay when pressing select binding with no search
2023-07-13 17:50:07 +09:00
Dean Herbert
94201579f6
Update design of "revert to default" button
...
I keep getting feedback that the old design looked like anything *but* a
button to revert defaults. Including people clicking it expecting
opposite behaviour.
This is intended to be a temporary design until we get the full new UI
components online (where this is moved to the right-hand-side).
2023-07-13 14:26:03 +09:00
Dean Herbert
1bfe5a18cb
Rename RestoreDefaultValueButton to RevertToDefaultButton
...
Because I can't find it every time I search.
2023-07-13 13:46:50 +09:00
Zyf
82364b4f9f
Use OsuScoreProcessor in the scoring test scene
2023-07-11 02:46:32 +02:00
Bartłomiej Dach
2af8c7bc24
Add failing test case for chat message length limit enforcement
2023-07-09 21:40:27 +02:00
Bartłomiej Dach
055e4a78f0
Merge branch 'master' into taiko-hitsounding-final-attempt
2023-07-08 18:10:04 +02:00
Bartłomiej Dach
e2aaef6663
Merge branch 'master' into no-dismiss-all-progress-notifications
2023-07-08 14:19:57 +02:00
Bartłomiej Dach
832c1c0009
Merge branch 'master' into fix-gameplay-samepl-trigger-source-rewind
2023-07-08 13:33:04 +02:00
Dean Herbert
d72765b6f8
Merge pull request #24114 from peppy/editor-save-local-score-management
...
Ensure scores always have the correct linked `BeatmapInfo`
2023-07-07 15:40:54 +09:00
Dean Herbert
f8be6d41f7
Play basic notification test first
2023-07-07 13:23:45 +09:00
Dean Herbert
8978f2ddd8
Remove all usage of !something!.something
...
aka don't mix NRT forgiving syntax with not syntax
2023-07-07 10:15:33 +09:00
Dean Herbert
2e98ab0a48
Expose rewinding state of IGameplayClocks
...
The implementation of this requires a bit of a special case
for 0, so makes sense to implement in a central place.
2023-07-06 19:08:42 +09:00
Dean Herbert
7a3a14e50d
Add sample trigger tests covering rewinding of gameplay
2023-07-06 19:08:42 +09:00
Dean Herbert
af3f9086e5
Expose rewinding state of IGameplayClocks
...
The implementation of this requires a bit of a special case
for 0, so makes sense to implement in a central place.
2023-07-06 14:16:31 +09:00
Dean Herbert
a98a36872e
Bring realm library up-to-date
2023-07-06 13:37:43 +09:00
Dean Herbert
9ff6b3fcd3
Merge branch 'master' into editor-save-local-score-management
2023-07-06 12:28:44 +09:00
Dean Herbert
51b0d18c04
Fix weird test assertion output
2023-07-05 18:44:27 +09:00
Bartłomiej Dach
b0f6b22fa7
Add assertions covering correctness of judged flags on entry
2023-07-04 23:48:46 +02:00
Bartłomiej Dach
2b098bdf61
Add test coverage for mixed pooled/non-pooled usages
2023-07-04 23:41:06 +02:00
Bartłomiej Dach
e2ddcb2349
Silence a few remaining nullability warnings
2023-07-04 22:39:26 +02:00
Dean Herbert
d74b1e148d
Make ScoreInfo.BeatmapInfo nullable
2023-07-04 14:50:34 +09:00
Bartłomiej Dach
21f758947d
Merge branch 'master' into availability-fixes
2023-07-02 20:38:37 +02:00
Dean Herbert
537404440d
Set the beatmap locally available for participants list tests
2023-06-29 13:17:42 +09:00
Bartłomiej Dach
0940ab1e11
Add failing tests covering correct flip handling
2023-06-28 20:48:02 +02:00
Dean Herbert
3883c28b15
Add visual display in participants list when availability is still being established
2023-06-28 16:02:46 +09:00
Dean Herbert
bc26d52dbd
Merge pull request #24067 from bdach/fix-difficulties-not-deleting-from-db
...
Fix delete difficulty flow not actually deleting the difficulty from realm
2023-06-28 12:06:01 +09:00
Dean Herbert
076f41be12
Merge pull request #24059 from peppy/add-editor-rotate-hotkeys
...
Add support for `Ctrl` + `<` / `>` to rotate selection in editor
2023-06-28 12:03:34 +09:00
Bartłomiej Dach
d72a8da295
Add test coverage for deleted difficulties staying in realm
2023-06-27 23:40:12 +02:00
Bartłomiej Dach
444f71541a
Add test coverage for rotate hotkeys
2023-06-27 22:10:53 +02:00
Bartłomiej Dach
7052f87eb8
Add even more safety against unloaded components
2023-06-27 21:21:14 +02:00
Bartłomiej Dach
af66ccbfdf
Merge branch 'master' into hud/kc-skinnable
2023-06-27 20:35:47 +02:00
Bartłomiej Dach
9681ee7eeb
Fix broken test step
2023-06-27 20:29:27 +02:00
Bartłomiej Dach
ada9c48bde
Attempt to fix more test failures
2023-06-27 20:17:58 +02:00
Dean Herbert
8bd6f7a46a
Rename ClicksPerSecondCalculator to ClicksPerSecondController
2023-06-27 16:38:46 +09:00
Dean Herbert
e21583ff1b
Refactor InputCountController to not require being added to foreign body via Attach
...
I've made the flow match `ClicksPerSecondCalculator` as close as
possible. Hopefully this reads better.
2023-06-27 16:36:00 +09:00
Dean Herbert
e99de0eb5d
Add safety to tests to ensure loaded
2023-06-27 16:04:34 +09:00
Bartłomiej Dach
9c87d42f2b
Attempt to remedy HUD overlay test failure by waiting more
2023-06-26 22:41:31 +02:00
Bartłomiej Dach
e998be0eee
Use == true rather than ?? false
2023-06-26 22:29:20 +02:00
Bartłomiej Dach
7200855d46
Rename Judgement{Tally -> CountController}
2023-06-26 19:30:04 +02:00
Bartłomiej Dach
8d91580dc1
Rename {KeyCounter -> InputCount}Controller
2023-06-26 19:27:42 +02:00
Dean Herbert
14c95f4584
Apply NRT to FilterCriteria
2023-06-26 17:54:11 +09:00
Dean Herbert
0c869367e1
Merge branch 'master' into hud/kc-skinnable
2023-06-26 15:53:16 +09:00
Dean Herbert
ac0c988d49
Fix weirdly named test method and add xmldoc
2023-06-26 13:21:29 +09:00
Joseph Madamba
25c9bf4061
Improve and refactor LoginPanel test scene to use LoginOverlay
2023-06-25 11:39:32 -07:00
tsrk
350d722c8d
Merge branch 'master' into hud/kc-skinnable
2023-06-25 15:42:08 +02:00
Dean Herbert
cf43cd2bdc
Rename test scene to match updated class name
2023-06-25 21:26:10 +09:00
Bartłomiej Dach
a7202721ff
Merge branch 'master' into no-confirmation-on-update-restart
2023-06-25 13:35:21 +02:00
Bartłomiej Dach
25842105ce
Merge pull request #23976 from peppy/gameplay-sample-trigger-source-correctness
...
Adjust `GameplaySampleTriggerSource` to only switch samples when close enough to the next hit object
2023-06-25 08:23:55 +02:00
Bartłomiej Dach
f8d2f2f7e1
Fix more issues discovered by CI that can be fixed game-side
2023-06-24 19:04:05 +02:00
Bartłomiej Dach
d7ae430ec2
Merge branch 'master' into framework-update
2023-06-24 18:47:52 +02:00
Bartłomiej Dach
e273c223a8
Fix some more missed CI inspections
2023-06-24 17:11:38 +02:00
Bartłomiej Dach
e3a89a6273
Fix remaining obvious CI inspections
2023-06-24 16:07:01 +02:00
Dean Herbert
2bda63c2c8
Merge branch 'master' into mass-nrt
2023-06-24 09:59:15 +09:00
Dean Herbert
58e6b3782b
Fix a couple of remaining issues
2023-06-24 09:58:36 +09:00
Dean Herbert
3585c3f1d5
Apply required nullability changes
2023-06-24 09:58:36 +09:00
Salman Ahmed
c5771912db
Merge branch 'master' into tournament-chatcolor
2023-06-23 22:23:33 +03:00
Dean Herbert
df5b389629
Manual fixes to reduce warnings to zero
2023-06-24 01:52:53 +09:00
Dean Herbert
0ab0c52ad5
Automated pass
2023-06-24 01:00:03 +09:00
Dean Herbert
1dc7c05c12
Merge branch 'master' into no-confirmation-on-update-restart
2023-06-23 15:33:01 +09:00
Dean Herbert
a76037b643
Add test coverage of confirm-for-operations
2023-06-23 15:30:21 +09:00
Dean Herbert
7fa07805b0
Expose all notifications from INotificationOverlay
...
Also fixes `HasOngoingOperations` not actually working.
2023-06-23 15:19:21 +09:00
Dean Herbert
6df617d536
Rename ExitConfirmOverlay to be more explicit about purpose
2023-06-23 14:46:38 +09:00
Dean Herbert
11a97e1bb8
Move confirmation bypass implementation to MainMenu to allow for more correct logic
2023-06-23 14:42:56 +09:00
Bartłomiej Dach
2c1c20e0a7
Rename test helpers
2023-06-22 23:10:16 +02:00
Bartłomiej Dach
786deec296
Rename and xmldoc members
2023-06-22 23:00:52 +02:00
Liam DeVoe
6de7328fef
add test for comment when logging in and out
2023-06-21 02:17:51 -04:00
Liam DeVoe
dd4f271158
fix cancel test for new button layout
2023-06-21 02:15:02 -04:00
Bartłomiej Dach
2f77675fe7
Fix errors in tests due to mismatching NRT annotations
2023-06-20 21:57:32 +02:00
Dean Herbert
92e89c7df7
Update test expectations
2023-06-20 21:02:34 +09:00
Dean Herbert
04dad6c6e8
Use IGameplayClock to ensure our clock source is correct
2023-06-20 20:47:56 +09:00
Liam DeVoe
343052410b
update CommentEditor test components
2023-06-19 22:08:45 -04:00
Ruki
9c6c6bf1ea
Merge branch 'master' into hud/kc-skinnable
2023-06-18 18:30:44 +02:00
Bartłomiej Dach
75300ca229
Switch search box to initially unfocused
...
Done primarily to keep mod hotkeys working without any behavioural
changes when mod select is opened.
2023-06-18 15:58:50 +02:00
Bartłomiej Dach
9ba4bf5fb7
Merge branch 'master' into add-mod-search-option
2023-06-18 15:06:21 +02:00
Bartłomiej Dach
0b6c0592e4
Add failing test case for mod preset filtering not working after ruleset change
2023-06-18 14:51:16 +02:00
Bartłomiej Dach
b9156b1df3
Reword/rename some stuff in test
2023-06-18 14:24:35 +02:00
Bartłomiej Dach
76f509a1db
Do not use ?? true pattern
...
Universally disliked. `!= false` is preferred.
2023-06-18 14:19:38 +02:00
Bartłomiej Dach
9758e5f840
Fix utterly broken test
...
- Was on wrong ruleset, so the mod/free mod sets did literally nothing
- `assertHasFreeModButton` had a param that did nothing
- Was checking `MatchingFilter` rather than `Visible`
2023-06-18 14:16:38 +02:00
Dean Herbert
eb31fdecee
Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change
...
See https://github.com/ppy/osu-framework/pull/5834
2023-06-18 20:57:32 +09:00
Joseph Madamba
9ae864c219
Fix beatmap info length tooltip not showing actual drain length
2023-06-17 15:00:32 -07:00
tsrk
61101335cc
test: fix KeyCounterController not provided as a dependency
2023-06-16 19:00:09 +02:00
tsrk
f9321a24d9
test: change hideTarget drawable and testing logic
...
Doesn't change what it needs to test conceptually
2023-06-16 17:24:40 +02:00
Ruki
aba8219d06
Merge branch 'master' into hud/kc-skinnable
2023-06-15 15:48:43 +02:00
tsrk
7e70598773
test: move back key counter tests in ctor
2023-06-15 12:02:30 +02:00
Salman Ahmed
b9543f4fdd
Add failing test case
2023-06-15 11:21:52 +03:00
tsrk
42b740a175
Merge branch 'master' into hud/kc-skinnable
2023-06-14 22:19:45 +02:00
tsrk
c637fddf73
refactor: decouple Trigger logic from KeyCounterDisplay
...
This allows to keep a coeherent state regardless of the progress of the play
2023-06-14 21:13:35 +02:00
tsrk
758831b983
test: remove hard usages of KeyCounterDisplay
2023-06-14 13:25:24 +02:00
cdwcgt
51451bd53e
fix test
2023-06-14 01:32:27 +09:00
cdwcgt
430938fbb2
allow custom username color for chatLine
...
user's color (e.g. green for NAT) will be ignore
2023-06-12 22:07:36 +09:00
Cootz
aece548db1
Merge branch 'master' into add-mod-search-option
2023-06-12 13:09:09 +03:00
Dean Herbert
062fd58602
Add test to known time
2023-06-12 16:43:28 +09:00
Dean Herbert
c9f9569e4a
Add ability to change background colour in song progress test scene
2023-06-12 16:22:40 +09:00
Cootz
036479dd9d
Merge branch 'master' into add-mod-search-option
2023-06-09 16:27:18 +03:00
Bartłomiej Dach
58507291b9
Apply NRT in MemoryCachingComponent test-only subclasses
2023-06-09 13:48:42 +02:00
Bartłomiej Dach
4b3b22f046
Merge branch 'master' into beat-divisor-better-defaults
2023-06-08 20:35:03 +02:00
Dean Herbert
0875fc6233
Update tests in line with new behaviour
2023-06-09 02:28:38 +09:00
Bartłomiej Dach
281aae91ec
Merge pull request #23808 from peppy/working-beatmap-get-background
...
Refactor `IWorkingBeatmap.Background` to `GetBackground()`
2023-06-08 12:23:07 +02:00
Dean Herbert
a842f79ad4
Refactor IWorkingBeatmap.Background to GetBackground()
2023-06-08 16:19:32 +09:00
Bartłomiej Dach
b3ce7f7b43
Merge branch 'master' into fix-section-container-scroll-attempt-2
2023-06-08 09:19:26 +02:00
Bartłomiej Dach
35e41d816a
Cover clamping to max beat divisor in test
2023-06-07 23:38:06 +02:00
Bartłomiej Dach
9b665d2e1a
Merge branch 'master' into beat-snap-divisor-hotkeys
2023-06-07 23:38:03 +02:00
Dean Herbert
3a01498789
Use existing next/previous methods (and remove looping behaviour)
2023-06-08 01:01:29 +09:00
Bartłomiej Dach
1f4e79d79d
Merge pull request #23711 from timiimit/add-last-edit-time
...
Store timestamp of beatmap's last edit time in local database
2023-06-07 16:57:24 +02:00
Dean Herbert
757596fffa
Add test coverage of scroll failing
2023-06-07 16:32:29 +09:00
Bartłomiej Dach
f51b8a6a05
Fix code quality inspection
2023-06-06 21:11:24 +02:00
Bartłomiej Dach
7694aa7219
Add test coverage
2023-06-06 20:36:44 +02:00
Bartłomiej Dach
46ec250d34
Fix test failures due to cross-test state pollution
...
`TestSceneEditorTestGameplay` is not isolated from database, and one of
the tests exiting editor when seeked to 60000 milliseconds
(`TestClockTimeTransferIsOneDirectional()`) ended up changing
`EditorTimestamp` to the same value, causing
`TestSaveChangesBeforeGameplayTest()` to fail due to changing initial
state.
To fix, perform a direct deletion of imported beatmaps in realm to avert
this scenario, contrary to the soft-deletion via `BeatmapManager` done
previously.
2023-06-06 20:21:55 +02:00
Cootz
ba7069df34
Fix SelectAllModsButton state doesn’t update when search term changed
2023-06-06 16:12:31 +03:00
Dean Herbert
66b8b5192b
Add test coverage of editor timestamp remembering
2023-06-06 15:25:19 +09:00
Bartłomiej Dach
5c1abdc704
Fix screen navigation test hijacking dummy request handler
...
In an upcoming change, I stumbled upon a test failure mode wherein tests
in `TestSceneScreenNavigation` would die on the following exception:
2023-05-07 17:58:42 [error]: System.ObjectDisposedException: Cannot access a closed Realm.
2023-05-07 17:58:42 [error]: Object name: 'Realms.Realm'.
2023-05-07 17:58:42 [error]: at Realms.Realm.ThrowIfDisposed()
2023-05-07 17:58:42 [error]: at Realms.Realm.All[T]()
2023-05-07 17:58:42 [error]: at osu.Game.Beatmaps.BeatmapManager.<>c__DisplayClass25_0.<QueryBeatmap>b__0(Realm r) in D:\a\osu\osu\osu.Game\Beatmaps\BeatmapManager.cs:line 282
2023-05-07 17:58:42 [error]: at osu.Game.Database.RealmAccess.Run[T](Func`2 action) in D:\a\osu\osu\osu.Game\Database\RealmAccess.cs:line 387
2023-05-07 17:58:42 [error]: at osu.Game.Beatmaps.BeatmapManager.QueryBeatmap(Expression`1 query) in D:\a\osu\osu\osu.Game\Beatmaps\BeatmapManager.cs:line 282
2023-05-07 17:58:42 [error]: at osu.Game.Tests.Visual.OnlinePlay.TestRoomRequestsHandler.<HandleRequest>g__createResponseBeatmaps|6_0(Int32[] beatmapIds, <>c__DisplayClass6_0& ) in D:\a\osu\osu\osu.Game\Tests\Visual\OnlinePlay\TestRoomRequestsHandler.cs:line 174
2023-05-07 17:58:42 [error]: at osu.Game.Tests.Visual.OnlinePlay.TestRoomRequestsHandler.HandleRequest(APIRequest request, APIUser localUser, BeatmapManager beatmapManager) in D:\a\osu\osu\osu.Game\Tests\Visual\OnlinePlay\TestRoomRequestsHandler.cs:line 140
2023-05-07 17:58:42 [error]: at osu.Game.Tests.Visual.TestMultiplayerComponents.<>c__DisplayClass18_0.<load>b__0(APIRequest request) in D:\a\osu\osu\osu.Game.Tests\Visual\TestMultiplayerComponents.cs:line 80
2023-05-07 17:58:42 [error]: at osu.Game.Online.API.DummyAPIAccess.<>c__DisplayClass32_0.<Queue>b__0() in D:\a\osu\osu\osu.Game\Online\API\DummyAPIAccess.cs:line 74
Upon closer inspection, one of the tests in the scene instantiates a
`TestMultiplayerComponents` instance. `TestMultiplayerComponents`
registers a custom request handler onto `DummyAPIAccess`. Normally, this
is not an issue; however, because `TestSceneScreenNavigation` is an
`OsuGameTestScene`, and therefore has its storage recycled after every
test, this leads to the error above in the following scenario:
1. `TestPushMatchSubScreenAndPressBackButtonImmediately()` passes.
2. The test is cleaned up, and the test case's storage is recycled,
including the test case's realm database.
3. In a subsequent test, a web request handled by the dummy API request
handler is fired. The dummy API request handler subsequently attempts
to access a realm that does not exist anymore.
As the usage of `TestMultiplayerComponents` is highly unorthodox in this
particular case, I'm opting for a localised fix which ensures that the
request handler is cleaned up appropriately.
2023-06-05 23:15:16 +02:00
Cootz
71e6f80c40
Add hotkey for switching search bar focus
2023-06-05 15:54:19 +03:00
Cootz
3ebc801484
Move (de)select all mods hotkeys handling to ModSelectOverlay
2023-06-05 13:49:07 +03:00
Bartłomiej Dach
25d0f0f3da
Merge pull request #23741 from peppy/fix-manage-collection-commit-on-focus-loss
...
Fix collection name changes not being reflected if enter is not pressed
2023-06-04 17:19:13 +02:00
Cootz
fd554033db
Update tests
2023-06-04 17:11:04 +03:00
Dean Herbert
3e308e4c27
Add test coverage showing commit failure in manage collections dialog
2023-06-04 12:50:30 +09:00
Bartłomiej Dach
331e90f720
Merge branch 'master' into tidy-results-grid-usage
2023-06-03 19:45:23 +02:00
Bartłomiej Dach
a9d4556647
Merge branch 'master' into update-multiplayer-room-diff-range
2023-06-03 16:50:09 +02:00
Cootz
4c7cca101e
Rename IsValid to Visible
2023-06-02 11:33:38 +03:00
Olivier Schipper
3f7bebfda4
Merge branch 'master' into edit-nodesample
2023-06-02 00:57:15 +02:00
OliBomby
acd8ff9a24
revert add sample point piece tests
2023-06-02 00:42:36 +02:00
OliBomby
035163a792
add new behaviour tests to TestSceneHitObjectSampleAdjustments
2023-06-02 00:40:00 +02:00
OliBomby
3110f87831
Revert "Add PopoverContainer to TimelineTestScene"
...
This reverts commit 8acfe6b58b
2023-06-01 18:48:12 +02:00
Dean Herbert
bcde2cbc73
Apply NRT to BeatDivisorControl
2023-06-01 16:58:14 +09:00
OliBomby
e709390052
reset popover at the end of sample tests
2023-06-01 09:00:59 +02:00
OliBomby
aa52d86ea3
add nodesample piece test
2023-06-01 08:12:39 +02:00
OliBomby
2812b23457
Add sample point piece test
2023-06-01 08:03:41 +02:00
OliBomby
8acfe6b58b
Add PopoverContainer to TimelineTestScene
2023-06-01 07:41:30 +02:00
Dean Herbert
985604fab5
Return StatisticItems rather than StatisticRows from ruleset
...
There were no usages of more than one column being provided per row, so
it seemed like unnecessarily complexity. I'm currently trying to reduce
complexity so we can improve the layout of the results screen, which
currently has up to three levels of nested `GridContainer`s.
Of note, I can't add backwards compatibility because the method
signature has not changed in `Ruleset` (only the return type). If we do
want to keep compatibility with other rulesets, we could designate a new
name for the updated method.
2023-06-01 14:35:15 +09:00
Dean Herbert
14a376c041
Merge branch 'master' into scorev2
2023-05-30 14:34:43 +09:00
Bartłomiej Dach
5604dfb758
Merge branch 'master' into acc-challenge
2023-05-29 22:33:57 +02:00
Bartłomiej Dach
1b57b0d31c
Add testing
2023-05-29 22:33:46 +02:00
Dean Herbert
1558723420
Merge branch 'master' into scorev2
2023-05-29 20:06:32 +09:00
Bartłomiej Dach
53c91349fe
Merge branch 'master' into slider-control-point-no-distance-snap
2023-05-26 19:52:54 +02:00
Bartłomiej Dach
96fe7cbe54
Merge branch 'master' into sample-set-controls
2023-05-25 21:58:16 +02:00
Dean Herbert
804671ca74
Split out grid snapping modes into "relative" and "global" types
2023-05-25 21:41:19 +09:00
Dean Herbert
7a5349d747
Remove constructor from MultiplayerPlaylistItem which is only used in tests
2023-05-25 20:09:40 +09:00
Dean Herbert
058edb5d5f
Centralise beatmap playable duration and bounds lookups
2023-05-25 17:32:48 +09:00
Dan Balasescu
6d9ba9248d
Massage tests a bit more
2023-05-25 16:38:22 +09:00
Bartłomiej Dach
578a0e7494
Merge branch 'master' into beat-divisor-visual-improvements
2023-05-24 22:28:26 +02:00
Bartłomiej Dach
07b5874eee
Fix test step name
2023-05-24 20:18:36 +02:00
Dean Herbert
6044327181
Add test coverage for escape deselecting any active selection
2023-05-24 23:59:22 +09:00
Dean Herbert
663cec1ff6
Combine editor navigation test scenes
2023-05-24 23:51:28 +09:00
Dean Herbert
8e5ba2208d
Add test coverage of new hotkeys
2023-05-24 17:33:48 +09:00
Dean Herbert
e68ba6366c
Update new usages of "soft" to use the new constant
2023-05-24 14:04:10 +09:00
Dean Herbert
298989ffd2
Merge branch 'master' into sample-set-controls
2023-05-24 14:03:04 +09:00
Gyoshi
b5f8093941
Use RangePadding to align mouse with slider
2023-05-23 18:16:14 +02:00
Gyoshi
fa00f8b92a
replace manual code with existing method
2023-05-23 18:16:12 +02:00
Gyoshi
921d7e4d89
More fitting tests for new layout
2023-05-23 18:16:10 +02:00
Dan Balasescu
fee3d43596
Merge branch 'master' into scorev2
2023-05-23 19:07:54 +09:00
Dan Balasescu
844c023fb7
Fix tests
2023-05-23 18:18:27 +09:00
Dean Herbert
ff5dde0ebe
Merge pull request #23575 from Joehuu/fix-inverted-video-only-check
...
Fix old widescreen videos with black bars not correctly filling screen (again)
2023-05-23 16:47:52 +09:00
Cootz
c3f06ad2db
Merge branch 'master' into add-mod-search-option
2023-05-23 08:55:57 +03:00
Bartłomiej Dach
2ce150ba2b
Add failing test case for sample undo
2023-05-22 22:23:05 +02:00
Bartłomiej Dach
843d2903d2
Add failing test case for slider velocity undo
2023-05-22 22:18:15 +02:00
Cootz
67bf1b4dfe
Select/deselect first visible mod when GlobalAction.Select is triggered
2023-05-21 11:05:01 +03:00
Dan Balasescu
7cbf48ffcf
Fix TestSceneScoring and incorrect combo calculations
2023-05-19 14:09:19 +09:00
Dan Balasescu
73544231de
Fix TestSceneTopLocalRank
2023-05-19 14:06:56 +09:00
Joseph Madamba
caa79704ac
Add test coverage for failing case
2023-05-17 20:23:37 -07:00
Dean Herbert
ec2b9165d5
Adjust BeatDivisorControl test to show control mmuch larger
2023-05-17 16:33:58 +09:00
Dean Herbert
ebce39cd1c
Add test coverage of failing sample bank transfer
2023-05-16 18:52:52 +09:00
Dean Herbert
8528fcaedc
Rename editor sample adjustment test scene to increase scope of tests
2023-05-16 18:52:52 +09:00
Dean Herbert
83dcd78826
Make HitSampleInfo.Bank non-nullable
2023-05-16 18:12:56 +09:00
Cootz
6647d95ea7
Kill search focus when clicking on ModColumn
2023-05-14 18:32:16 +03:00
Bartłomiej Dach
a99bf0fc5a
Add test coverage
2023-05-14 12:29:24 +02:00
Bartłomiej Dach
9a327d95b8
Add test coverage
2023-05-14 11:24:24 +02:00
Cootz
2467813d81
Block deselect all short key when using the search box
2023-05-09 16:14:42 +03:00
Dean Herbert
9160711470
Change "Show main page" test steps to actually load the main page
2023-05-08 15:32:00 +09:00
Dean Herbert
f002038137
Add test coverage of failing wiki return to page scenario
2023-05-08 15:29:05 +09:00
Bartłomiej Dach
8514b2758a
Fix rapid back button test failure
2023-05-07 21:07:38 +02:00
Cootz
4c3af6ecfe
Add test coverage for deselect all with filtered mods selected
2023-05-07 15:50:21 +03:00
Bartłomiej Dach
80ac8abaa6
Merge branch 'master' into chat-report
2023-05-06 15:30:44 +02:00
Bartłomiej Dach
fba3c587cf
Add test coverage for info message failing to display
2023-05-06 15:26:29 +02:00
Cootz
5aca3a78da
Add basic tests for external search
2023-05-06 12:21:32 +03:00
Cootz
a226caff56
Fix testing
2023-05-06 11:09:44 +03:00
Cootz
7422b5285c
Fix wrong filtering in testing
2023-05-05 22:41:30 +03:00
Dean Herbert
8391e2a538
Move reporting code out of DrawableChatUsername into more correct locations
2023-05-05 14:03:42 +09:00
Dean Herbert
698baa78bf
Merge pull request #22711 from Terochi/keep-shared-settings-ruleset-change
...
Keep shared mod settings when changing ruleset
2023-05-05 13:29:55 +09:00
Bartłomiej Dach
99e8b2ce70
Make getMod() method generally better
2023-05-04 19:12:22 +02:00
Bartłomiej Dach
aa7885ab97
Use better test step names
2023-05-04 19:11:51 +02:00
Bartłomiej Dach
bdd96caaa9
Merge branch 'master' into edit-mods-preset
2023-05-04 18:59:47 +02:00
Bartłomiej Dach
e43fc23606
Fix typos in test
2023-05-04 18:50:21 +02:00
cdwcgt
2cb6642b0d
use AddUntilStep or not wait
2023-05-04 13:18:25 +09:00
Bartłomiej Dach
59ece64d25
Merge branch 'master' into skin-editor-change-handler-improvement
2023-05-03 19:42:42 +02:00
cdwcgt
c609e6345c
remove Use Current Mods menu item
2023-05-03 23:02:50 +09:00
cdwcgt
3a15783a3c
remove wait, use AddUntilStep
2023-05-03 22:59:01 +09:00
cdwcgt
25bf4e68ec
remove useless wait
2023-05-03 22:53:13 +09:00
Cootz
f0d35eb12b
Update testing
2023-05-03 13:12:11 +03:00
Dean Herbert
b932e4d986
Rename DrawableUsername to DrawableChatUsername and only pass message ID
2023-05-03 18:53:22 +09:00
Dean Herbert
4f55afb60d
Merge branch 'master' into chat-report
2023-05-03 18:50:38 +09:00
Dean Herbert
384693a431
Fix test failure in MultiplayerMatchSongSelect due to multiple overlays present
...
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736995?pr=23308 .
2023-05-03 14:30:58 +09:00
Dean Herbert
6b017ac05f
Merge pull request #23308 from OliBomby/sample-control-points
...
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
Dean Herbert
e394b487e0
Merge branch 'master' into edit-mods-preset
2023-05-03 12:06:16 +09:00
Dean Herbert
e42b0cc5b1
Merge pull request #23370 from peppy/fix-editor-playfield-padding
...
Add more padding around playfield in editor to avoid overlap with tool areas
2023-05-03 11:44:55 +09:00
Bartłomiej Dach
95badb9455
Adjust composer tests to new screen layout
...
`TestSceneHitObjectComposer.TestPlacementFailsWhenClickingButton()` was
attempting to cover the case of the user clicking a toolbox button which
was in front of the playfield, and ensure that the click did not result
in a placement. However, since the paddings in
67f83f246b
2023-05-02 18:45:45 +02:00
Cootz
a6ca049739
Manually implement @bdach prototype
2023-05-02 14:15:33 +03:00
Dean Herbert
94ae9d7664
Merge pull request #23357 from OliBomby/fix-reverse-crash
...
Prevent infinite repeat count when adjusting repeats of 0 length slider
2023-05-02 19:53:26 +09:00
Dean Herbert
1e4a628cb1
Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod
...
Fix issue where multiplier show wrong value when adjusting speed on preset
2023-05-02 14:59:41 +09:00
Dean Herbert
e3c384c6b5
Merge branch 'master' into sample-control-points
2023-05-02 14:38:39 +09:00
Dean Herbert
983a8f7dfe
Merge branch 'master' into fix-reverse-crash
2023-05-02 13:14:34 +09:00
Dean Herbert
87db891143
Adjust test to reliabily fail
2023-05-02 13:12:11 +09:00
Bartłomiej Dach
1fb4c814f4
Remove no longer needed API call mocking
...
The online ID will be reset unconditionally after any local change is
made to any beatmap. That behaviour no longer depends on online lookups
succeeding or failing.
This may change at a later date when beatmap submission is integrated
into lazer - the idea is that online IDs would get re-populated on local
beatmaps once they are submitted to web.
2023-05-01 19:08:41 +02:00
Bartłomiej Dach
8ab3a87b13
Add failing test case covering online ID reset on save
...
This test scene passes at e58e1151f3e72f103c17
2023-05-01 18:17:35 +02:00
OliBomby
dbb2a8980b
add test
2023-05-01 15:56:23 +02:00
Terochi
4d52ce769b
Revert SaveState() calling on initialization
2023-05-01 12:53:58 +02:00
OliBomby
608fa3cc73
Merge remote-tracking branch 'upstream/master' into sample-control-points
2023-04-30 19:47:03 +02:00
Bartłomiej Dach
7cedbca9be
Merge branch 'master' into multiplier-doesnt-update-with-preset-mod
2023-04-30 17:36:00 +02:00
Bartłomiej Dach
d35355970f
Add test case covering failure scenario
2023-04-30 17:23:45 +02:00
Terochi
8f02bd80f9
Addressed changes
2023-04-30 16:11:52 +02:00
Terochi
949dc1c0f9
Improved logic
2023-04-30 12:05:55 +02:00
Terochi
585318400c
Refactor tests
2023-04-30 02:32:20 +02:00
Terochi
9a9e02b110
Added tests
2023-04-30 02:00:35 +02:00
Dean Herbert
2643100644
Add xmldoc to new test mentioning failure rate and general purpose
2023-04-29 11:05:10 +09:00
Dean Herbert
32f8c674f4
Extract beatmap retrieval method for more legibility
2023-04-29 11:01:29 +09:00
Dean Herbert
a6f0186112
Improve legibility and code quality of new test
2023-04-29 10:51:56 +09:00
Dean Herbert
428b5fad3c
Rename test scene to explicitly mention navigation testing
2023-04-29 10:51:56 +09:00
Cootz
d9b3c97179
Fix testing
2023-04-29 10:29:33 +09:00
Cootz
c5357d30ab
Add test
2023-04-29 10:29:33 +09:00
Bartłomiej Dach
07efa7d660
Merge branch 'master' into fix-storyboard-loop-end-time
2023-04-26 21:53:26 +02:00
OliBomby
354cd23874
removed all usage of hitobject's DifficultyControlPoint
2023-04-26 18:17:02 +02:00
OliBomby
c44f71a737
remove all regular usage of DifficultyControlPoint
2023-04-26 17:55:38 +02:00
OliBomby
9f8d7bccba
fix usings
2023-04-26 17:34:02 +02:00
OliBomby
c6fc180659
remove all test usages of SampleControlPoint
2023-04-26 14:21:52 +02:00
Dean Herbert
27f81288ef
Merge branch 'master' into keep-shared-settings-ruleset-change
2023-04-26 15:51:31 +09:00
Bartłomiej Dach
196b5b41eb
Also disable counting on argon display in test
...
Mostly for my own peace of mind.
2023-04-25 20:17:57 +02:00
Bartłomiej Dach
753fa09356
Fix test failures due to type mismatch
2023-04-25 20:10:11 +02:00
Dean Herbert
0c3a015953
Fix key counter test not testing the full binding of IsCounting
2023-04-25 21:37:19 +09:00
Dean Herbert
d8b4db3a13
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-25 19:54:31 +09:00
Dean Herbert
e330052852
Add second definition of EndTime for storyboard elements to account for loops in lifetime
2023-04-25 15:22:11 +09:00
Dean Herbert
26a2d1fdea
Merge pull request #23000 from Joehuu/fix-beatmap-terminology
...
Fix song select matching label not using right terminology
2023-04-18 13:53:05 +09:00
Joseph Madamba
c80a25328d
Shorten label to just "matches"
2023-04-17 20:59:41 -07:00
Bartłomiej Dach
0cc92ce5f9
Add failing test case
...
Covering nested object reverts not firing the parent's `RevertResult`
event in accordance with what the xmldoc of the event states.
2023-04-11 18:24:34 +02:00
Joseph Madamba
d0cbe206a9
Revert back to one number with "matching beatmap difficulties" label
2023-04-10 23:37:29 -07:00
Dean Herbert
52bb7891f7
Merge branch 'master' into fix-count-not-updating-when-deleting
2023-04-11 09:04:02 +09:00
Bartłomiej Dach
1f2c96c8e8
Merge branch 'master' into gd-onlinesetoverlay
2023-04-10 15:35:03 +02:00
Bartłomiej Dach
6e08105e2c
Remove usage of "diff" vernacular
2023-04-10 15:27:10 +02:00
Joseph Madamba
bfb7ead689
Add failing text box beatmap difficulty count test
2023-04-09 22:12:50 -07:00
Joseph Madamba
ed208ef127
Fix more typos and adjust font size to match web
2023-04-07 21:10:37 -07:00
Dean Herbert
0c71fa1bbd
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-06 23:39:57 +09:00
Dean Herbert
e6872629f3
Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable
...
Don't show epilepsy warning when storyboards are disabled
2023-04-06 12:32:38 +09:00
tsrk
809b817e8e
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-05 22:57:36 +02:00
Bartłomiej Dach
ba753a8aac
Merge branch 'master' into update-skinnable-sound-before-playing
2023-04-05 22:56:25 +02:00
Bartłomiej Dach
6df7614b9d
Add tests for suppressing epilepsy warning when storyboard disabled
2023-04-05 20:56:50 +02:00
Bartłomiej Dach
02c6126be7
Ensure storyboards are enabled in existing epilepsy warning tests
2023-04-05 20:53:54 +02:00
Bartłomiej Dach
432f698697
Merge branch 'master' into gameplay/key-counter-abstraction
2023-04-05 19:45:14 +02:00
Bartłomiej Dach
8cc425774b
Merge branch 'master' into fix-replay-fail-on-exit
2023-04-03 21:23:23 +02:00
Bartłomiej Dach
b5d9284de2
Merge pull request #23108 from peppy/fix-overlay-toggles-during-disclaimer
...
Fix attempting to show overlay during game intro playing hide sound effects
2023-04-03 20:48:03 +02:00
cdwcgt
9e0277b2fd
useless using
2023-04-04 00:19:14 +09:00
cdwcgt
735b48679e
use LinkFlowContainer directly
2023-04-03 20:09:49 +09:00
Dean Herbert
6239789188
Fix missing using statements in multiple test scenes
2023-04-03 15:37:10 +09:00
Dean Herbert
b0c09df259
Merge branch 'master' into gameplay/key-counter-abstraction
2023-04-03 15:33:35 +09:00
Dean Herbert
43d7386623
Merge pull request #22926 from Joehuu/fix-sort-direction-not-resetting
...
Fix beatmap listing sort direction not resetting when changing criteria
2023-04-03 15:32:10 +09:00
Dean Herbert
a097433cb1
Fix overlay toggle keys working during disabled activation modes
...
Closes #23104 .
2023-04-03 15:03:47 +09:00
cdwcgt
2cf8636366
show guest diff author in BeatmapPicker
2023-04-02 22:25:58 +09:00
Dean Herbert
9b45591c2f
Add failing test coverage of saving failed replay causing progression to results
2023-03-29 14:00:11 +09:00
cdwcgt
f01247f1ab
test
2023-03-28 21:41:00 +09:00
cdwcgt
899860dd77
Merge branch 'master' into chat-report
2023-03-28 21:14:11 +09:00
Dean Herbert
d31b37e87e
Merge branch 'master' into fix-ubo-not-bound
2023-03-26 16:14:11 +09:00
Joseph Madamba
e1906a90eb
Use image@2x from tournament banner api
2023-03-25 13:08:46 -07:00
cdwcgt
26f2d9047d
code style fix
2023-03-23 01:11:44 +09:00
cdwcgt
8518d15b8d
use endpoint
2023-03-23 01:00:38 +09:00
Dean Herbert
ad5bdf6511
Merge branch 'master' into fix-ubo-not-bound
2023-03-22 16:46:39 +09:00
Dean Herbert
db227b1798
Merge branch 'master' into chat-report
2023-03-22 16:26:28 +09:00
Terochi
1478a26cc0
Addressed changes
2023-03-21 23:15:49 +01:00
Joseph Madamba
df3ccdff9f
Add failing beatmap listing sort direction on criteria change test
2023-03-21 15:08:37 -07:00
Bartłomiej Dach
9ff9cd3b7f
Merge branch 'master' into skin-editor-cyclic-selection
2023-03-21 19:49:55 +01:00
Dean Herbert
fb51221c2b
Add test coverage of cyclic selection triggering when more than one item is selected
2023-03-21 21:31:10 +09:00
Salman Ahmed
678e8ed736
Update UBO usages inline with framework changes
2023-03-16 14:06:35 +03:00
cdwcgt
d025c441ca
delay mod save after click save or not popover hidden
2023-03-16 19:48:45 +09:00
Cootz
556964eae0
Merge branch 'master' into BitmapUpdatesOnScore
2023-03-16 12:16:42 +03:00
Dean Herbert
a81408ca06
Add failing test coverage showing that replay will fail on exiting gameplay
2023-03-16 17:12:46 +09:00
Dean Herbert
159c8833c7
Add test coverage of SkinnableSound not updating in time when not present
2023-03-16 15:41:05 +09:00
Dean Herbert
5378cdff20
Apply NRT to TestSceneSkinnableSound
2023-03-16 15:10:35 +09:00
Dean Herbert
5f9b13a775
Rename Add/AddRange methods as they are no longer conflicting with Container
2023-03-15 18:02:41 +09:00
Dean Herbert
8908648f97
Fix super-dodgy cast of IEnumerable to Drawable
2023-03-15 18:01:22 +09:00
Dean Herbert
1cf870d956
Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection
2023-03-15 15:16:48 +09:00
Dean Herbert
3c4e2d8700
Add tests covering drag selection
2023-03-14 21:04:51 +09:00
Dean Herbert
969c0e9c9d
Merge branch 'master' into veldrid-renderer
2023-03-14 17:35:38 +09:00
Terochi
8e8dda3ac0
Big simplifying
2023-03-11 23:29:36 +01:00
cdwcgt
15f11bb1e8
scorll container and save mod after popover hidden
...
Requires manual handling of many visual effects
2023-03-11 12:31:33 +09:00
cdwcgt
f4e2620402
fix test
2023-03-10 00:56:22 +09:00
cdwcgt
d009cd8422
test
2023-03-09 22:49:45 +09:00
tsrk
d806b85a30
revert: make counters an IEnumerable again
...
As suggested by bdach as this would make the last two commits useless
Refs: 5d15426
2023-03-09 10:25:03 +00:00
tsrk
44297a7d0a
refactor: make KCD a CompositeDrawable
2023-03-08 00:47:16 +00:00
Terochi
bedf4cc259
Remove extra code
2023-03-07 16:03:11 +01:00
cdwcgt
54564e0557
new design
2023-03-07 21:13:35 +09:00
Dean Herbert
28520414aa
Move KeyCounter components to HUD namespace
2023-03-07 16:41:39 +09:00
Dean Herbert
15d65059b5
Tidy up Add method logic
2023-03-07 16:21:57 +09:00
Dean Herbert
8f6df5ea0f
Merge branch 'master' into gameplay/key-counter-abstraction
2023-03-07 16:09:45 +09:00
Dean Herbert
d2fcdf6e0e
Add test coverage of cyclic selection in skin editor
2023-03-07 15:11:47 +09:00
cdwcgt
0095fd85ca
remove == true
2023-03-07 02:18:34 +09:00
cdwcgt
4858d3fd42
Added ability to edit mod presets
2023-03-07 02:00:40 +09:00
Bartłomiej Dach
ec15e2b9cc
Merge branch 'master' into dont-filter-results-on-sort-mode
2023-03-06 17:57:47 +01:00
Bartłomiej Dach
9d4bb2ecf7
Add failing test coverage for clearing sidebar contents
2023-03-04 14:08:50 +01:00
Bartłomiej Dach
2f25fb4083
Move NonSkinnableScreenPlaceholder to outer scope
2023-03-04 13:22:43 +01:00
Bartłomiej Dach
3dd3b5e77a
Add failing test case
2023-03-04 13:17:54 +01:00
Dean Herbert
a14dede036
Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
...
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.
Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
Dean Herbert
7a092ea995
Add better coverage and more comments explaining the structure of test setup
2023-03-03 17:18:14 +09:00
Dean Herbert
82293c0c86
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
...
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.
In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
Dean Herbert
bd11d5d29a
Merge pull request #22743 from Joehuu/scroll-back-to-previous
...
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
Bartłomiej Dach
92edb0f868
Merge branch 'master' into skin-editor-depth-changing
2023-02-27 19:24:53 +01:00
Joseph Madamba
fa710ae1b0
Rename ScrollToTopButton to ScrollBackButton
2023-02-26 14:39:34 -08:00
Joseph Madamba
d98d330da2
Add expected behavior test for scroll back to previous position
2023-02-26 14:30:46 -08:00
Dan Balasescu
dd9748a25c
Adjust DrawNodes to use UBOs
2023-02-25 01:42:55 +09:00
Terochi
09e7c21b23
Implemented a more complex setting conversion logic + tests
2023-02-24 15:11:22 +01:00
tsrk
6307b3948a
style: use Trigger initialisation
2023-02-22 17:59:39 +00:00
Bartłomiej Dach
d679703fa2
Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection
...
Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play
2023-02-22 18:56:59 +01:00
tsrk
1beec71037
refactor(KeyCounterDisplay): apply suggestions
...
I also took the freedom to add type checking, as we can't limit the
usage of `Add()` since it's a Container. The exception thrown also
advises of using the suggested `AddTrigger()` instead.
2023-02-22 14:58:27 +00:00
Dean Herbert
a8c692a215
Merge pull request #22635 from peppy/use-overlays-container-more
...
Use `Overlays` container rather than `KeyBindingInputManager` for flashlight
2023-02-22 18:30:21 +09:00
Dean Herbert
32a9c066df
Add test coverage of bring-to-front / send-to-back operations
2023-02-22 18:17:20 +09:00
Dean Herbert
90ca635a17
Fix weird nullability in TestSceneSkinEditor
2023-02-22 18:17:20 +09:00
Dean Herbert
f61fbcf3fc
Update assertion to also check GameplayClockContainer's current time
2023-02-22 15:26:09 +09:00
Dean Herbert
a511e64fa5
Seek using GameplayClockContainer
2023-02-22 14:41:20 +09:00
Bartłomiej Dach
d59d153654
Fix test compile failures from Audio hoisting
2023-02-21 21:03:00 +01:00
Terochi
dd53a70071
Addressed change requests
2023-02-21 21:01:31 +01:00
Bartłomiej Dach
3d2fcb0cca
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 20:53:06 +01:00
Bartłomiej Dach
ec1bf7b0b2
Merge branch 'master' into skin-editor-clipboard
2023-02-21 19:35:58 +01:00
Terochi
191604340f
Added a way for mod settings to be kept when changing ruleset + test
2023-02-21 19:05:10 +01:00
mk56-spn
299023fce0
Improve visibility of wedge shading in test scene and fix an issue with excessive roundness on said shadow.
2023-02-21 16:07:26 +01:00
Dean Herbert
9321ec29dc
Update slider sample source asserts to match expected behaviour
...
As pointed out in review, if the current time is after the end of the
slider, the correct hit object to use for sample retrieval is the object
itself, not any nested object.
2023-02-21 14:04:38 +09:00
Dean Herbert
e686b4393e
Add wait steps to ensure frame-stable clock has caught up before checking state
2023-02-21 14:04:19 +09:00
Dean Herbert
5ba6059911
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 13:58:15 +09:00
Bartłomiej Dach
3183f5cee2
Merge branch 'master' into revert-result-in-playfield
2023-02-19 16:33:10 +01:00
Bartłomiej Dach
704dddf14b
Merge branch 'master' into skin-editor-clipboard
2023-02-17 22:59:18 +01:00
Bartłomiej Dach
6afa65bd3d
Merge branch 'master' into skinnable-clean-up-documentation
2023-02-17 20:59:18 +01:00
tsrk
ddd6c1a1c6
refactor(KeyCounter): address bindables issues
...
`IsCounting` is back being an auto-property.
`countPresses` is now encapsulated and being exposed as an
`IBindable<int>` via `CountPresses`
2023-02-16 22:20:34 +00:00
Bartłomiej Dach
3ee046000e
Merge branch 'master' into revert-result-in-playfield
2023-02-16 21:54:29 +01:00
Bartłomiej Dach
2fdf1fd876
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-16 19:43:02 +01:00
Bartłomiej Dach
5bdc5dfadd
Add one more assert to keep coverage from previous implementation
2023-02-16 19:02:51 +01:00
Dean Herbert
b59ec551f6
Add test coverage of GameplaySampleTriggerSource not considering nested objects
2023-02-16 18:21:33 +09:00
Dean Herbert
979c079f8b
Refactor GameplaySampleTriggerSource test to not be realtime dependent
2023-02-16 17:58:44 +09:00
Dean Herbert
9d02a2ef0e
Apply NRT to GamepleSampleTriggerSource tests
2023-02-16 17:58:44 +09:00
Dean Herbert
2fbaf88a3c
Add clipboard dependency to SkinEditor specific tests
...
This is usually provided by the `SkinEditorOverlay`, which is not always
present in tests.
2023-02-16 15:24:38 +09:00
tsrk
74e7cc2056
feat: implement new design of key counter
2023-02-15 22:18:02 +00:00
tsrk
076eb81b21
refactor: rename trigger classes
...
Makes it better to understand their purpose
2023-02-15 21:46:13 +00:00
tsrk
157bba7830
refactor: rename Trigger class to InputTrigger
2023-02-15 21:41:36 +00:00
Dean Herbert
a92e42bb84
Rename SkinnableTargetContainer to SkinComponentsContainer
...
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
Dean Herbert
b1cf6d83d8
Move extension methods closer to serialisation classes
2023-02-15 18:37:41 +09:00
Dean Herbert
856efd9fd9
Rename SkinnableDrawableInfo to SerialisedDrawableInfo
2023-02-15 18:23:19 +09:00
Dean Herbert
9e651a7ca2
Rename SkinnableInfo to SkinnableDrawableInfo
2023-02-15 18:23:17 +09:00
Dean Herbert
6010dde86e
Move SkinnableInfo to better namespace
2023-02-15 18:23:10 +09:00
Dean Herbert
d9b4d932c9
Fix test container lookup failure
2023-02-15 17:47:34 +09:00
Dean Herbert
ca75f0ec77
Apply NRT to TestSceneBeatmapSkinFallbacks
2023-02-15 17:30:21 +09:00
Dean Herbert
8bbd00822c
Simplify and rename SkinnableTargetComponentsContainer
2023-02-15 17:30:21 +09:00
Dean Herbert
51d4ae5241
Merge branch 'master' into footer_V2_implementation
2023-02-14 14:00:53 +09:00
Bartłomiej Dach
939144fb6c
Merge pull request #22628 from EVAST9919/letterbox-no-containers
...
Remove unnecessary containers in `LetterboxOverlay`
2023-02-13 23:54:48 +01:00
mk56-spn
6e6421caea
Change FooterV2.cs colour to use ColourProvider instead of OsuColour.
...
Remove unnecessary `FillFlowContainer`
2023-02-13 22:12:25 +01:00
Andrei Zavatski
006356e617
Add TestSceneLetterboxOverlay
2023-02-13 14:17:33 +03:00
tsrk
11d0e185b8
refactor: separate impl of KeyCounterDisplay
...
This allows for different layouts of display. Idk, maybe someone would
want to mix both variants? (don't do this please). This commit is mostly
prep for further changes.
2023-02-13 01:36:12 +00:00
Joseph Madamba
cb51b9e350
Use existing ModdingBeatmap activity
2023-02-12 15:01:50 -08:00
Joseph Madamba
bbeef53569
Add TestingBeatmap activity
2023-02-12 13:11:42 -08:00
Joseph Madamba
afb66d8af4
Make user activity class names more specific
2023-02-12 12:32:17 -08:00
mk56-spn
09cb6ca3a7
Clean up formatting and wedge placement in testscene a tad,
2023-02-11 18:15:21 +01:00
mk56-spn
468419896a
Separate ruleset changing tests into their own method.
...
Add small clarification for edge colouring in visibility test
2023-02-11 18:08:50 +01:00
mk56-spn
cb679ccc2b
Separate wedge visibility test into its own method
2023-02-11 18:03:27 +01:00
Bartłomiej Dach
8292052dc2
Merge pull request #22598 from peppy/fix-skip-intro-replay
...
Fix "skip" key binding no longer working in replay playback
2023-02-11 11:27:10 +01:00
Dean Herbert
0c5dae5f26
Merge pull request #22529 from ItsShamed/dsc/presence
...
Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`
2023-02-11 17:29:47 +09:00
Dean Herbert
96fbd04698
Add failing test coverage of skip no longer working in replay playback
2023-02-10 18:57:04 +09:00
Dean Herbert
eccde923e5
Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability
...
Improve readability of `AccuracyCircle`
2023-02-10 17:03:46 +09:00
ekrctb
5ddaf8ea3c
Fix test setting invalid TimeOffset
2023-02-09 17:43:04 +09:00
Dean Herbert
92eb6b6717
Simplify TestSceneAccuracyCircle test specifications
2023-02-09 15:42:03 +09:00
Joseph Madamba
3b5d573db1
Display tournament banner on user profile
2023-02-08 17:16:09 -08:00
Walavouchey
9544a1d26d
use values closer to the extremities for test cases
2023-02-09 00:02:32 +01:00
Walavouchey
6ace6bfee1
ensure AccuracyCircle doesn't land in gaps created by RankNotches
2023-02-08 13:20:53 +01:00
Dean Herbert
38031fdf23
Add test coverage of stores stored in database as well
2023-02-08 15:38:07 +09:00
Dean Herbert
d4d985ba0f
Improve test to also check that reverting hash restores old scores
2023-02-08 15:34:46 +09:00
Dean Herbert
c7eec371f5
Clean up tests somewhat
2023-02-08 15:22:17 +09:00
Cootz
338d96534a
Add leaderboard test on beatmap update
2023-02-08 05:01:54 +03:00
PC
7e127dafe2
Update reference
2023-02-07 11:52:47 +03:00
Cootz
cb26601cb4
Fix test's score generation
2023-02-07 02:29:28 +03:00
tsrk
bc89f8dc5b
feat: add name and rulset verb display support
2023-02-06 12:44:00 +00:00
Dean Herbert
c691a0d3af
Merge branch 'master' into sheared_slider_implementation_clean_ii
2023-02-06 17:49:33 +09:00
Dean Herbert
c078d3a344
Merge pull request #22357 from EXtremeExploit/groups-probationary-badges
...
Make probationary groups a bit transparent
2023-02-06 17:43:57 +09:00
tsrk
e878bb42a4
test: add test for watching activity
2023-02-06 00:53:56 +00:00
Susko3
364217829c
Add test for ArchiveImportIPCChannel
2023-02-03 18:39:46 +01:00
Susko3
13fc649edf
Refactor test to more closely match how OsuGameDesktop works
2023-02-03 18:22:51 +01:00
mk56-spn
e1af5e110a
Remove ``RoundedNub.cs` and make `Nub.cs`` non abstract again
2023-02-03 12:19:09 +01:00
Dean Herbert
4ec46c7476
Merge branch 'master' into footer_V2_implementation
2023-02-03 16:30:16 +09:00
Dean Herbert
a1200b8fe8
Adjust footer button colour handling to read better and take into account mouse down
2023-02-03 16:27:20 +09:00
Bartłomiej Dach
e937022b09
Merge branch 'master' into middle-click-replay-pause
2023-02-02 20:52:03 +01:00
Bartłomiej Dach
6c0aada86a
Merge pull request #22490 from peppy/skin-overlay-namespace
...
Move skin editor to overlays namespace
2023-02-02 18:14:16 +01:00
mk56-spn
3f0ce75bf5
Rename NormalSliderBar.cs to RoundedSliderBar.cs
2023-02-02 17:24:45 +01:00
mk56-spn
7c5a65bdb7
Rename NormalNub.cs to RoundedNub.cs
2023-02-02 17:23:09 +01:00
Dean Herbert
edecd2ee25
Merge branch 'master' into middle-click-replay-pause
2023-02-02 15:25:51 +09:00
Dean Herbert
50659f3d52
Merge pull request #22428 from EVAST9919/triangles-new-masking
...
Implement Masking property for `TrianglesV2` background
2023-02-02 14:22:16 +09:00
Dean Herbert
8dc2e6872e
Move skin editor to overlays namespace
2023-02-02 14:00:31 +09:00
Bartłomiej Dach
4fc7d37a1b
Fix wonky log message
2023-02-01 22:58:11 +01:00
Bartłomiej Dach
efc9a34b98
Merge branch 'master' into add-more-logging
2023-02-01 22:55:28 +01:00
Dean Herbert
34a6106170
Add more logging in TestScenePause to better understand test failures
2023-02-02 01:01:32 +09:00
Dean Herbert
d54db8de64
Merge branch 'master' into fix-clicking-metadata-relevance-sort
2023-02-01 19:39:13 +09:00
Andrei Zavatski
faee012a2a
Add texelSize slider to TriangleBorder shader test scene
2023-02-01 10:37:44 +03:00
mk56-spn
f5d579144b
Remove free mods button
2023-01-30 12:57:24 +01:00
Salman Ahmed
20f4061e30
Move ongoing operation wait step to proper place
2023-01-29 00:24:15 +03:00
Joseph Madamba
845bbf55fe
Add failing beatmap listing search on initial open test
2023-01-28 12:10:50 -08:00
mk56-spn
76146b5c53
Address naming discrepancy in TestSceneShearedSliderBar.cs
2023-01-26 15:12:52 +01:00
mk56-spn
2f90ffccfc
Implement ShearedSliderBar.cs and corresponding TestSceneShearedSliderBar.cs
2023-01-26 15:03:22 +01:00
mk56-spn
374c3b56f6
Rename Nub.cs to NormalNub.cs
2023-01-26 15:03:11 +01:00
mk56-spn
3988131475
Rename OsuSliderBar.cs as NormalSliderBar.cs
2023-01-26 12:12:56 +01:00
Dean Herbert
13937cf555
Merge branch 'master' into stream-tool-2
2023-01-26 16:08:20 +09:00
Andrei Zavatski
7cd21e12f3
Implement masking property for TrianglesV2 background
2023-01-26 09:46:41 +03:00
Andrei Zavatski
d09d6f31d7
Implement Masking property for TrianglesBackground
2023-01-25 12:20:51 +03:00
Dean Herbert
e3a5c233e9
Update test to use newer assetion logic
2023-01-25 17:39:35 +09:00
Dean Herbert
f0406c34fd
Merge branch 'master' into revert-result-in-playfield
2023-01-25 17:35:33 +09:00
Dean Herbert
67e9de43be
Merge pull request #22386 from EVAST9919/triangles-og-shhader
...
Use `TriangleBorder` shader in `Triangles` background
2023-01-25 17:25:18 +09:00
Dean Herbert
59ee6922b1
Merge pull request #22399 from bdach/user-profile/update-cover
...
Update appearance of profile cover area to match web
2023-01-25 16:35:44 +09:00
Dean Herbert
4674956ccf
Merge pull request #22318 from naoey/fix-copy-difficulty-moving-collections
...
Fix creating a copy of a difficulty in the editor removing the original beatmap from user collections
2023-01-25 15:06:46 +09:00
Dean Herbert
68a9d945b9
Merge branch 'master' into user-profile/update-cover
2023-01-25 14:30:35 +09:00
Dean Herbert
6efab635d8
Merge branch 'master' into fix-copy-difficulty-moving-collections
2023-01-25 14:11:32 +09:00
Bartłomiej Dach
a3bb6d1fab
Revert a few more relative to absolute changes
...
Because not sure why they were changed in the first place.
2023-01-25 00:00:23 +01:00
Bartłomiej Dach
4d7cd59df3
Fix TestAbsoluteImage() no longer actually testing absolute image URL
2023-01-24 23:58:39 +01:00
Bartłomiej Dach
f2df36e6a5
Persist cover visibility to user settings
...
Follows web precedent, wherein the setting is saved to local storage.
2023-01-24 23:30:12 +01:00
Bartłomiej Dach
ef7812412b
Update top header container appearance
2023-01-24 23:06:44 +01:00
Jai Sharma
c991aa5ca4
TestSceneWikiMarkdownContainer: Revert CurrentPath changes and update markdown img links only
2023-01-24 22:01:53 +00:00
Andrei Zavatski
04995b66da
Add seed slider to Triangles test sceen
2023-01-24 07:09:25 +03:00
Jai Sharma
2454eb8cd9
TestSceneWikiMarkdownContainer: Add visual test for inline and fenced code syntax
2023-01-24 00:53:45 +00:00
Jai Sharma
f067a84631
TestSceneWikiMarkdowContainer: Update image paths
2023-01-24 00:51:07 +00:00
mk56-spn
bc94f1b773
add free mods button to test
2023-01-23 16:43:38 +01:00
mk56-spn
4623c04f46
Add mania score to leaderboard test scene
2023-01-23 11:35:42 +01:00
ekrctb
8405a3e172
Add test for RevertResult
2023-01-23 18:51:55 +09:00
Dean Herbert
432e0a6a37
Merge branch 'master' into level-badge-colour
2023-01-23 15:46:15 +09:00
Dean Herbert
736965e009
Fix test scene potentially overflowing visible region
2023-01-23 15:45:44 +09:00
EXtremeExploit
b62d4deb6f
Fix also typo on filename
2023-01-22 17:17:19 -03:00
EXtremeExploit
55976df307
Fix typo in test class name
2023-01-22 16:43:03 -03:00
EXtremeExploit
aeebbe4003
Add group badges test from #22280
2023-01-22 15:12:40 -03:00
EXtremeExploit
64c9654910
Make probationary groups a bit transparent
2023-01-22 13:32:05 -03:00
Bartłomiej Dach
e1acf85bb3
Merge branch 'master' into groups-modes
2023-01-22 10:09:34 +01:00
EXtremeExploit
05f77d2cab
Add modes text to groups tooltip
2023-01-22 01:36:53 -03:00
Joseph Madamba
da03abc812
Fix comment editor text boxes not having sound feedback
2023-01-21 17:32:42 -08:00
naoey
a1b5c9d910
Don't transfer MD5 hashes in collections when copying beatmaps
...
Fixes #22306 .
Changes beatmap saving so that by default it does not transfer
the hashes in collections, and only transfers them when saving the same
difficulty in the editor.
Issue seems to have been introduced in https://github.com/ppy/osu/pull/20641 .
2023-01-22 01:14:18 +09:00
Dean Herbert
e86748626a
Merge pull request #22296 from frenzibyte/actually-fix-beatmap-options
2023-01-20 10:21:55 +09:00
Salman Ahmed
8174ef06c3
Fix intermittent failure in playlists match loading test
2023-01-20 01:18:41 +03:00
Salman Ahmed
f0464b0340
Actually fix intermittent failure in beatmap options state test
2023-01-19 22:47:35 +03:00
mk56-spn
b22363ed8c
Fix JudgementCounterDisplay.cs max judgement always showing upon changing display mode
2023-01-19 10:31:02 +01:00
Dean Herbert
56ce8504ae
Merge branch 'master' into comment-reply
2023-01-19 16:01:47 +09:00
Dean Herbert
db8084570d
Merge pull request #22285 from bdach/segmented-graph-tint
...
Apply draw colour to segmented graph
2023-01-19 13:36:19 +09:00
Dean Herbert
e58abf7d1a
Merge pull request #22284 from bdach/judgement-counter-broken
...
Fix "show max judgement" setting not applying initially on judgement counter display
2023-01-19 09:09:06 +09:00
Bartłomiej Dach
b62ff8d644
Merge branch 'master' into skin/argon-song-progress-cleaner
2023-01-18 23:52:12 +01:00
Bartłomiej Dach
e09b768a99
Add test steps demonstrating failure
2023-01-18 23:07:40 +01:00
Bartłomiej Dach
7299d227d1
Add failing test case
2023-01-18 21:42:22 +01:00
Bartłomiej Dach
06212bca51
Restructure test scene to demonstrate failure
2023-01-18 21:41:00 +01:00
ansel
7f4d8bdcaa
Add test
2023-01-18 21:27:42 +03:00
Bartłomiej Dach
4a6f6300c5
Merge branch 'master' into fix-carousel-sort-change-after-play
2023-01-18 17:15:20 +01:00
StanR
8ae82484b5
Usings
2023-01-18 16:38:58 +03:00
StanR
24ed84aad0
Add tiered level badge colouring
2023-01-18 16:25:11 +03:00
Dean Herbert
3b27774561
Remove OnlineID sort consideration
2023-01-18 19:21:02 +09:00
Dean Herbert
43a037c189
Merge pull request #21620 from mk56-spn/JudgementCounter
...
Add a judgement counter to skin components
2023-01-18 18:43:49 +09:00
Dean Herbert
d4f2cd244d
Fix broken test step
2023-01-18 18:12:40 +09:00
Dean Herbert
42e9b2b48c
Tidy up clock logic in all SongProgress classes
2023-01-18 16:29:42 +09:00
Dean Herbert
5ead85f461
Limit catch-up speed in test to emulate gameplay
2023-01-18 16:13:43 +09:00
Dean Herbert
8030194cd5
Use actual beatmap's hitobjects in test to better display density
2023-01-18 16:11:46 +09:00
Dean Herbert
bfb75730a9
Prefix subclasses of DefaultSongProgress with Default
2023-01-18 15:45:16 +09:00
Dean Herbert
04c0a5d728
Update TestSceneSongProgress to properly work with new implementation
2023-01-18 15:44:19 +09:00
Dean Herbert
5a272b4bd6
Merge branch 'master' into skin/argon-song-progress-cleaner
2023-01-18 15:25:02 +09:00
Dean Herbert
e8770b84cd
Remove no longer necessary interface type
2023-01-18 15:23:55 +09:00
Dean Herbert
f9dd3f6def
Switch test to specifically target the argon verison of the progress bar
2023-01-18 15:23:55 +09:00
Dean Herbert
5429979049
Combine common code into SongProgress base class
2023-01-18 15:23:55 +09:00
Dean Herbert
45c5bd8403
Simplify HUD test to not require casting to specific ProgressBar type
2023-01-18 14:37:09 +09:00
Bartłomiej Dach
f5459909f9
Merge branch 'master' into comment-editor-3
2023-01-17 21:31:08 +01:00
Bartłomiej Dach
6f11fbdeed
Merge branch 'master' into fix-carousel-sort-change-after-play
2023-01-17 20:46:06 +01:00
mk56-spn
c44891d427
clean up linQ result formatting. Replace numbers with hitresult displaynames.
...
Make adjustments to statistics to allow them to work with autosizing
2023-01-17 20:13:50 +01:00
tsrk
66441d4421
test: remove test for ArgonSongProgressGraph
2023-01-17 13:16:11 +00:00
Dean Herbert
181473c5fc
Rename flow to better match its purpose
2023-01-17 18:28:08 +09:00
Dean Herbert
35ad66eef9
Give flow container a type to avoid locally casting in every location
2023-01-17 18:27:33 +09:00
Dean Herbert
09c7ab3af6
Rename exposed settings to make more sense
2023-01-17 18:27:15 +09:00
Dean Herbert
f923dc5009
Use framework Direction instead of local enum
...
It should be stable enough to use.
2023-01-17 18:27:15 +09:00
Dean Herbert
65bd2e74fd
Merge branch 'master' into skin/argon-song-progress-cleaner
2023-01-17 18:00:42 +09:00
