Dean Herbert
2396ba42a6
Change HealthDisplay to be a CompositeDrawable
2021-05-11 18:39:14 +09:00
Dean Herbert
004798d61d
Update Legacy components to not require skin in ctor
2021-05-11 18:39:14 +09:00
smoogipoo
10a4a5decb
Merge branch 'master' into multiplayer-spectator-screen
2021-05-11 17:33:09 +09:00
Dean Herbert
2ecd638f7f
Merge branch 'master' into skin-components-list
2021-05-10 18:13:10 +09:00
Dean Herbert
97e72849af
Fix regressed HitErrorDisplay behaviour (and localise binding to meter implementations)
2021-05-10 15:24:13 +09:00
Dean Herbert
3c3500d070
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-10 12:23:18 +09:00
Dean Herbert
1d38fa29b5
Remove unused using statement
2021-05-10 12:23:04 +09:00
Dean Herbert
1bbbe80420
Fix missing instances of HealthProcessor caching
2021-05-10 12:22:24 +09:00
Dean Herbert
132bb7832d
Fix some regressions when updating test scenes
2021-05-10 12:06:33 +09:00
Dean Herbert
b274fdf20d
Merge branch 'master' into skin-components-bind-outwards-health
2021-05-10 11:13:44 +09:00
Dean Herbert
2bcf1ed306
Merge pull request #12715 from Cublibre/fix-early-exit-crash
...
Fix InvalidOperationException when exiting a map at the end
2021-05-09 23:21:19 +09:00
Christine Chen
ae2b5a0806
Actually test that player was exited
2021-05-08 22:42:14 -04:00
Bartłomiej Dach
efb9164658
Restore previous test scene logic
2021-05-08 21:35:12 +02:00
Bartłomiej Dach
0bc6a026eb
Merge branch 'master' into skin-components-bind-outwards-accuracy
2021-05-08 21:08:53 +02:00
Christine Chen
25312b3e88
Don't restart completion delegate on exit, revert exit behavior to lazer
2021-05-08 11:47:44 -04:00
Christine Chen
8c564a69ed
Fix InvalidOperationException when exiting a map at the end
2021-05-07 21:11:03 -04:00
Dean Herbert
1cb10c2a22
Remove unnecessary binding logic from HUDOverlay
2021-05-07 17:51:46 +09:00
Dean Herbert
a7acecc52b
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-07 17:51:41 +09:00
Dean Herbert
3044b1c432
Add missing cache rules
2021-05-07 17:50:44 +09:00
Dean Herbert
6c255a0572
Fix drain start time being weirdly incorrect
2021-05-07 17:47:33 +09:00
Dean Herbert
8e78cac058
Fix HealthProcessor cached as derived type in test
2021-05-07 17:31:29 +09:00
Dean Herbert
04d35826a3
Merge branch 'skin-components-bind-outwards-accuracy' into remove-hud-overlay-unused-pieces
2021-05-07 17:25:39 +09:00
Dean Herbert
84a4ff333e
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:22:56 +09:00
Dean Herbert
755588258e
Update HealthDisplay components to use DI to attach data source
2021-05-07 17:22:45 +09:00
Dean Herbert
4ac234bf7f
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 17:15:57 +09:00
Dean Herbert
6dc591fc44
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 17:15:37 +09:00
Dean Herbert
9d27b11e49
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:10:31 +09:00
Dean Herbert
01eff7f316
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 16:30:08 +09:00
Dean Herbert
93f10330e3
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 16:29:10 +09:00
Dean Herbert
ad398165a2
Update AccuracyCounter components to use DI to attach data source
2021-05-07 16:27:25 +09:00
Dean Herbert
17b93361d5
Merge branch 'master' into skin-components-bind-outwards
2021-05-07 16:20:24 +09:00
Dean Herbert
a2e4fb5b6b
Update ScoreCounter components to bind outwards
2021-05-07 16:16:48 +09:00
Dean Herbert
aff32b0d19
Merge branch 'master' into skin-components-list
2021-05-06 14:17:33 +09:00
Bartłomiej Dach
3cac837acf
Merge branch 'master' into skin-bindables
2021-05-05 20:16:27 +02:00
Dean Herbert
3cc9bad979
Actually check for correct state of fade content in rewind test
2021-05-05 17:49:33 +09:00
Christine Chen
1d4a8bc0ae
Add visual test for rewinding
2021-05-04 22:23:36 -04:00
Dean Herbert
bb9fa1a25e
Merge branch 'master' into play-storyboard-outro
2021-05-04 14:01:34 +09:00
Dean Herbert
625890381f
Update ComboCounter components to use DI to attach data source
2021-05-03 17:43:00 +09:00
Dean Herbert
a1e64f4e3c
Use the existing toolbox design
2021-04-30 14:41:06 +09:00
Dean Herbert
ae9d1dc40b
Add component list to main editor interface and enable basic placement
2021-04-30 13:10:42 +09:00
Dean Herbert
6442fb819f
Split out component from test scene and fix SongProgress
2021-04-30 13:10:42 +09:00
Dean Herbert
4770a64709
Add proof of concept components list
2021-04-30 13:10:42 +09:00
Dean Herbert
de73ac7cec
Allow skin editor to be invoked from any context
...
This is kind of how I see things working going forward, where the editor
can be applied to anything in the game which supports it (ie. a results
screen, gameplay screen, etc.) and it will immediately allow changing
the interface.
This adds a test scene which shows this working with gameplay.
2021-04-29 16:12:15 +09:00
Dean Herbert
74c6fdc4b8
Add DrawableRuleset to the skin editor test to get a hit error meter to display
2021-04-29 16:12:15 +09:00
Dean Herbert
fd587a82ff
Replace abstract class with interface, attached to the actual components (not skinnable wrapper)
2021-04-29 16:12:15 +09:00
Dean Herbert
defa350aa7
Set defaults on SkinnableHUDComponent to cancel out relative size default
...
Specifying locally on each HUD component looks to make more sense.
2021-04-29 16:12:15 +09:00
Dean Herbert
1cb8fc9a24
Extract editor classes out of test namespace and add anchor support
2021-04-29 16:12:15 +09:00
Dean Herbert
74fb7cd180
Extract storable attributes to bindables
2021-04-29 16:12:15 +09:00
Dean Herbert
99b428ee4b
Add very basic skin editor test
2021-04-29 16:12:14 +09:00
Dean Herbert
fca173225a
Refactor editor selection/blueprint components to be generic
2021-04-29 16:12:14 +09:00
Dean Herbert
2d17219c8f
Setup basic test and classes for scale adjustment
2021-04-29 16:12:14 +09:00
Dean Herbert
120fb8974d
Combine more instances of test player IDs
2021-04-26 17:22:16 +09:00
Dean Herbert
daafa41dc1
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-22 16:22:04 +09:00
smoogipoo
e78ef05fcf
Merge branch 'gcc-abstraction' into multiplayer-spectator-screen
2021-04-21 17:11:14 +09:00
smoogipoo
156a518068
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-20 21:16:05 +09:00
smoogipoo
c5d6b6ea8d
Fix tests failing intermittently
...
This was due to this code happening in UpdateAfterChildren(), after the
GCC has processed one frame. During this time, the clock could have
advanced an arbitrary amount.
The cause of this is the removal of the Task.Run() to set the clock in
Restart() (now called Reset()) which changed the timing, so it only worked before due to pure
luck.
2021-04-20 18:41:09 +09:00
smoogipoo
80473a356e
Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction
2021-04-20 17:27:01 +09:00
smoogipoo
c12848ce4d
Apply fixes to tests
2021-04-19 17:02:59 +09:00
Christine Chen
fd1241cc85
Added tests
...
New tests:
- storyboard ending during the failing animation
- showResults = false
- storyboard ending before score processor completion
Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-18 23:26:50 -04:00
Christine Chen
98460c8feb
Rename IStoryboardElementHasDuration, remove unnecessary step in tests, add Duration field
2021-04-18 20:20:14 -04:00
Christine Chen
7b1d40db7d
Remove redundant string interpolation
2021-04-17 22:13:28 -04:00
Christine Chen
e9f8fa64b8
Added a test for toggling the storyboard after the map is loaded
2021-04-17 21:49:29 -04:00
Christine Chen
7f5b1e84a1
Update TestSceneStoryboardWithOutro.cs
...
- Construct storyboard in CreateWorkingBeatmap()
- Use GameplayClockContainer.GameplayClock.CurrentTime
- Remove unnecessary lines
2021-04-17 13:57:32 -04:00
smoogipoo
5e82f40d67
Merge branch 'master' into gcc-abstraction
2021-04-16 20:14:53 +09:00
smoogipoo
65a6f9f8a4
Merge branch 'fix-initial-spectator-state-callback' into multiplayer-spectator-screen
2021-04-16 18:26:46 +09:00
smoogipoo
46d2181d42
Remove now unnecessary (duplicating) test
2021-04-16 18:21:56 +09:00
smoogipoo
377e5ce6b3
Fix test incorrect sending state too often
2021-04-16 18:21:35 +09:00
smoogipoo
ca74f413cd
Change to explicit method instead
2021-04-16 17:31:02 +09:00
smoogipoo
5652490d61
Fix OnUserBeganPlaying not being invoked if already watching
2021-04-16 14:11:55 +09:00
Christine Chen
b15838b220
Move storyboard outro logic to DrawableStoryboard
2021-04-16 00:59:10 -04:00
Christine Chen
45c2b72a25
Merge branch 'master' into play-storyboard-outro
2021-04-15 15:11:35 -04:00
Christine Chen
25b8c2f257
Allow skipping storyboard outro
...
Reuses SkipOverlay by calculating the endtime of the storyboard and using that as a "start point". Upon skipping the outro the score is instantly shown.
When the end of the storyboard is reached the score screen automatically shows up. If the player holds ESC (pause) during the outro, the score is displayed
The storyboard endtime is calculated by getting the latest endtime of the storyboard's elements, or simply returning 0 if there is no storyboard.
Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-15 13:20:40 -04:00
Dan Balasescu
ac8e462d32
Merge branch 'master' into refactor-framed-replay-input-hander
2021-04-15 21:48:58 +09:00
Dean Herbert
5b06a68b93
Merge pull request #12330 from Cublibre/master
...
Send a warning notification if device is unplugged and at low battery
2021-04-15 19:21:04 +09:00
Dean Herbert
346e36d32a
Make Mod.Description abstract and add missing descriptions
2021-04-15 14:36:26 +09:00
smoogipoo
1aa36818df
Abstractify GameplayClockContainer
2021-04-14 17:47:11 +09:00
Christine Chen
f66306a81a
Remove IsLowBattery
2021-04-12 11:15:24 -04:00
Christine Chen
43b97fe0ad
Refactor PowerStatus (now called BatteryInfo)
2021-04-12 10:52:52 -04:00
ekrctb
359fae895f
Rename property
2021-04-12 18:50:25 +09:00
ekrctb
e19e8ff2a3
Rewrite FramedReplayInputHandler for robustness
...
This commit changes the semantics of `CurrentFrame` and `NextFrame` of the class.
The ordering of `NextFrame.Time` and `CurrentFrame.Time` was dependent on the current direction.
Now, it should always satisfy `CurrentFrame.Time <= CurrentTime <= NextFrame.Time` except at the start/end.
This change, however, doesn't break existing deriving classes if the template code pattern usage of interpolation is used.
The deriving class code can be simplified due to the elimination of nullable types. I didn't include those changes in this commit.
I removed `StreamingFramedReplayInputHandlerTest` for now, as it is almost-duplicate of `FramedReplayInputHandlerTest`. I'll include more tests in later commits.
This commit fixes #6150 .
2021-04-12 16:18:11 +09:00
ekrctb
d6d8ea5b6b
Throw when getting a frame of an empty replay
2021-04-12 11:17:56 +09:00
Salman Ahmed
cb947a3b27
Add expected output in test case rather than determining internally
2021-04-11 13:18:25 -04:00
Salman Ahmed
1fd4cb8963
Merge branch 'master' into master
2021-04-11 10:19:16 +03:00
Christine Chen
08311abc5e
Remove setters, cache CreatePowerStatus() and use a dummy LocalPowerStatus class in test scene
2021-04-10 00:00:21 -04:00
Christine Chen
59d13b0dd3
Fixed indentation
...
sorry about the style fixes... I'm using JetBrains Rider from now on.
2021-04-08 21:53:42 -04:00
Christine Chen
6b6a71d3c3
trim whitespace
2021-04-08 20:39:17 -04:00
Christine Chen
493c095535
Fixed code style
2021-04-08 20:28:23 -04:00
Christine Chen
6bccb3aab6
Use DI to implement battery detection, add BatteryCutoff property
...
- Removed the Xamarin.Essentials package from osu.Game and added it to osu.iOS and osu.Android only.
- iOS and Android implementations use Xamarin.Essentials.Battery, while the Desktop implementation
only returns 100% battery for now.
- Added a BatteryCutoff property to PowerStatus so it can be different for each platform (default 20%, 25% on iOS)
2021-04-08 19:55:11 -04:00
Dean Herbert
8aff53172d
Remove necessity for nested PassThroughInputManger
2021-04-08 15:18:31 +09:00
Christine Chen
0a6baf670e
Send a warning notification if device is unplugged and low battery
...
- Uses Xamarin.Essentials in osu.Game.PlayerLoader to check battery level
- Encapsulated battery checking in the public BatteryManager class so battery level and plugged in status can be accessed and edited in TestPlayerLoader
- When checking battery level, catch NotImplementedException thrown by Xamarin.Essentials.Battery on non-mobile platforms
- Added visual unit tests for battery notification
To mock battery status and level, we had to define a batteryManager object in TestPlayerLoader and add a new function ResetPlayerWithBattery()
Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-07 15:56:50 -04:00
Dean Herbert
beebdb0734
Clean up implementation
2021-04-05 22:30:51 +09:00
smoogipoo
c3c7c18549
Fix tests
2021-04-01 23:48:26 +09:00
smoogipoo
9e95441aa6
Rename Spectator -> SoloSpectator
2021-04-01 22:08:52 +09:00
Bartłomiej Dach
aec859b4d1
Merge branch 'master' into fix-unsafe-skinnable-sample-play
2021-03-18 19:51:46 +01:00
smoogipoo
7fa5fd5647
Update usages of config with framework changes
2021-03-17 16:10:16 +09:00
Dean Herbert
a5b3ac7ef8
Add failing test covering alpha commands proceeding non-alpha (but ignored) commands
2021-03-09 15:54:11 +09:00
smoogipoo
ee6a94273d
Merge branch 'master' into fix-unsafe-skinnable-sample-play
2021-02-22 18:31:27 +09:00
Salman Ahmed
6bac83964a
Merge branch 'master' into fix-pofl-on-cooldown
2021-02-22 10:03:27 +03:00
Dean Herbert
d2ec151c67
Add failing test for pausing when pause support is disabled
2021-02-20 14:20:13 +09:00
Salman Ahmed
f6c279ab00
Add assert ensuring player resumed properly
2021-02-19 11:45:45 +03:00
Salman Ahmed
fe5e45ea81
Move gameplay cursor outside instead and fix potential failure
2021-02-19 11:43:33 +03:00
Dean Herbert
52ebe34347
Update TestScenePause exit from fail test to actually fail
2021-02-19 17:26:26 +09:00
Dean Herbert
4c214b74ce
Merge branch 'master' into fix-error-exit-during-results-transition
2021-02-19 17:13:55 +09:00
Salman Ahmed
772471a6d8
Add failing test case
2021-02-19 10:46:31 +03:00
Dean Herbert
00574a5288
Use ISample everywhere in Skin GetSample lookup path
2021-02-18 18:32:28 +09:00
Dean Herbert
2e646882fa
Merge branch 'master' into non-concurrent-sample-playback
2021-02-15 21:22:21 +09:00
Dean Herbert
9ad38ab20e
Move HubClientConnector retrieval to IAPIProvider
2021-02-15 16:43:56 +09:00
Dean Herbert
f664fca0dd
Tidy up tests (and remove duplicate with new call logic)
2021-02-15 16:11:17 +09:00
Dean Herbert
4f264758a4
Add test coverage of pause from resume overlay
2021-02-15 15:57:36 +09:00
smoogipoo
c6ed3efa4a
Merge branch 'master' into non-concurrent-sample-playback
2021-02-15 14:47:32 +09:00
Dean Herbert
25f5120fdf
Add failing test coverage of user pausing or quick exiting during cooldown
2021-02-15 14:36:17 +09:00
Dean Herbert
a4dc544235
Refactor some shared code in TestScenePause
2021-02-15 14:24:08 +09:00
Dan Balasescu
34e600464b
Merge branch 'master' into abstract-hub-connection
2021-02-15 13:53:54 +09:00
smoogipoo
d3f0c0730d
Merge branch 'master' into non-concurrent-sample-playback
2021-02-12 17:22:15 +09:00
Salman Ahmed
d3c1b47592
Replace nullable API with null connector instead
2021-02-11 12:34:39 +03:00
Dean Herbert
94f35825dd
Update test to cover changed exit/pause logic
...
I think this makes more sense?
2021-02-09 17:29:30 +09:00
Salman Ahmed
a0ead38496
Prevent test spectator clients from attempting hub connections
2021-02-09 08:02:51 +03:00
Salman Ahmed
f04d6d5e5e
Update hub clients with changes to connecotr
2021-02-09 08:02:32 +03:00
Salman Ahmed
f76f92515e
Clean up spectator streaming client with new hub connector
2021-02-09 02:15:56 +03:00
Bartłomiej Dach
68c20a2a37
Allow autoplay score generation to access mod list
2021-02-07 18:35:34 +01:00
Mysfit
304264046b
Added tests.
2021-01-24 17:46:54 -05:00
Bartłomiej Dach
7abe33ad0e
Add failing test case
2021-01-21 00:04:15 +01:00
smoogipoo
8ffbcc9860
Fix test failures and general discrepancies
2021-01-20 14:05:35 +09:00
smoogipoo
de9d075f94
Initial sample + samplechannel rework
2021-01-19 17:11:40 +09:00
Dean Herbert
d023ad8ad1
Remove assert messages
2021-01-15 15:18:29 +09:00
Dean Herbert
51255033e2
Update some missed usages of KeyBindingContainer in tests
2021-01-15 14:57:01 +09:00
Roman Kapustin
0ea4e221b2
Merge branch 'master' into net5.0
2021-01-14 14:02:51 +03:00
mcendu
17abe90c27
move SkinnableHealthDisplay
...
Similar components are in osu.Game.Screens.Play.HUD while this is not
2020-12-31 20:23:13 +08:00
Dean Herbert
92d74a9343
Fix potential nullref in test scene
2020-12-28 20:48:14 +09:00
Dean Herbert
6254907ef9
Move multiplayer leaderboard test to correct namespace
2020-12-28 20:31:08 +09:00
Dean Herbert
966a2151e3
Ensure the previous leaderboard is removed
2020-12-26 17:55:24 +09:00
Dean Herbert
2599e95335
Add test coverage
2020-12-26 12:11:19 +09:00
Dean Herbert
ff57562956
Fix multiplayer leaderboard not unsubscribing from quit users
2020-12-26 11:35:31 +09:00
Dean Herbert
fa14438671
Merge pull request #11285 from peppy/resort-leaderboard-less
...
Re-sort the leaderboard order a maximum of once a second
2020-12-25 00:05:13 +09:00
Dean Herbert
d0e8347968
Change asserts into until steps
2020-12-24 22:28:25 +09:00
Dean Herbert
eb795a2127
Move all endpoint information to a configuration class
2020-12-24 17:58:38 +09:00
Dean Herbert
8ac76bd524
Merge pull request #11199 from smoogipoo/refactor-player-score-creation
...
Asyncify player score creation and submission
2020-12-20 17:30:11 +09:00
Bartłomiej Dach
f827b6c030
Use terser dictionary initialiser syntax
2020-12-19 21:26:40 +01:00
Bartłomiej Dach
631a0cea41
Fix intended random factor not being random in test
2020-12-19 21:25:04 +01:00
Dean Herbert
b3bff281ce
Merge branch 'master' into spectator-driven-leaderboard
2020-12-20 01:13:59 +09:00
Salman Ahmed
228acf25a7
Add test case creating leaderboard scores with existing users
2020-12-18 13:13:31 +03:00
smoogipoo
2958cab239
Remove GotoRanking
2020-12-18 17:47:33 +09:00
Dean Herbert
470c68d6a5
Merge branch 'gameplay-leaderboard-update' into spectator-driven-leaderboard
2020-12-18 17:30:21 +09:00
Dean Herbert
668536ce56
Fix vertical size potentially changing during relayout
2020-12-18 17:25:48 +09:00
Dean Herbert
bca4d83af7
Revert previous player add flow via interface
2020-12-18 17:19:55 +09:00
Dean Herbert
5e83605026
Merge branch 'gameplay-leaderboard-update' into spectator-driven-leaderboard
2020-12-18 17:07:43 +09:00
Dean Herbert
157a72ec5d
Revert previous player add flow via interface
2020-12-18 17:07:38 +09:00
Dean Herbert
96f23a1135
Merge branch 'master' into gameplay-leaderboard-update
2020-12-18 16:56:21 +09:00
Dean Herbert
869cac819d
Merge branch 'gameplay-leaderboard-update' into spectator-driven-leaderboard
2020-12-18 16:55:44 +09:00
smoogipoo
2db7433c0b
Refactor player score creation and submission process
2020-12-18 16:51:59 +09:00
Dean Herbert
99f2032fdf
Merge branch 'master' into gameplay-leaderboard-update
2020-12-18 16:44:52 +09:00
Dean Herbert
ceb2e4762d
Add test covering a more consistent spread of player scores
2020-12-18 16:20:42 +09:00
Salman Ahmed
a8abefcd66
Make GameplayLeaderboardScore a model class
2020-12-18 03:34:33 +03:00
Salman Ahmed
0faf3fdfd3
Update gameplay leaderboard scores with the new design
2020-12-17 15:19:10 +03:00
Dean Herbert
cc3dddf59f
Fix test scene crashing on second run of SetUp
...
Also correctly support LongRunningLoad
2020-12-17 16:02:07 +09:00
Dean Herbert
cda3bd2017
Rename test scene to match tested class name
2020-12-16 16:22:47 +09:00
Dean Herbert
6bce587b59
Pass users in via constructor and correctly unbind on disposal
2020-12-16 16:20:29 +09:00
Dean Herbert
c1ba0f4642
Use a local lookup cache for better usernames
2020-12-16 16:20:29 +09:00
Dean Herbert
09d0ceb766
Add testing setup to get a better visual idea of how scoreboard will work
...
fixup! Add method to ScoreProcessor to calculate score and accuracy from statistics
2020-12-16 16:20:29 +09:00
Dean Herbert
fb795f6bfd
Add initial hook-up to spectator backend
2020-12-16 16:20:29 +09:00
Dean Herbert
88b3bf06e8
Merge branch 'master' into add-bundle-header
2020-12-16 13:40:15 +09:00
Dean Herbert
b5ab400ad7
Fix test filename not matching updated class name
2020-12-15 15:44:43 +09:00
Dean Herbert
8b68ccc0ff
Rename class and move inside HUD namespace
2020-12-15 15:34:11 +09:00
Dean Herbert
8362ad37e3
Bring up-to-date with code changes
2020-12-15 15:22:14 +09:00
Dean Herbert
70e5d4495a
Merge branch 'master' into ingame-leaderboard-general-implementation
2020-12-15 15:14:56 +09:00
Dean Herbert
64a2526678
Add header class and basic flow for propagating data updates
2020-12-14 17:33:23 +09:00
Dean Herbert
1793385e96
Pass a score to the replay recorder to allow reading more general scoring data
2020-12-14 16:52:14 +09:00
Dean Herbert
53da137425
Merge branch 'master' into net5.0
2020-12-10 17:14:21 +09:00
Dean Herbert
31cfaefdeb
Move private functions in line with others
2020-11-30 15:39:43 +09:00
Dean Herbert
809caaa44c
Use standard switch syntax (preferred for now)
2020-11-30 15:39:08 +09:00
Dan Balasescu
0c36a3c263
Merge branch 'master' into pool-scrolling
2020-11-30 14:04:54 +09:00
Bartłomiej Dach
9bf70e4e97
Add slider test step for visual inspection purposes
2020-11-28 20:32:08 +01:00
Bartłomiej Dach
8e0f525588
Rewrite existing test scene somewhat
2020-11-28 20:29:35 +01:00
ekrctb
8f5129323d
Merge branch 'master' into pool-scrolling
2020-11-27 13:12:05 +09:00
ekrctb
57454bbb1c
Remove hitObject argument from OnApply and OnFree
2020-11-27 10:13:05 +09:00
ekrctb
eae33fe74a
Fix format
2020-11-26 14:16:33 +09:00
ekrctb
0817dae86c
Add failing test to check non-pooled lifetime
2020-11-26 12:35:49 +09:00
ekrctb
ec92545d7a
fix indent
2020-11-24 18:56:05 +09:00
ekrctb
cabc8aa63b
Revert "Simplify ScrollingHitObjectContainer logic"
...
This reverts commit b4cc39149c117e6a0e95ee917a67cec8ba723d06.
2020-11-24 18:56:05 +09:00
ekrctb
8f39b54e58
Simplify ScrollingHitObjectContainer logic
2020-11-24 18:56:05 +09:00
ekrctb
df3844cdbb
Add failing tests for pooling scrolling playfield
2020-11-24 18:56:05 +09:00
Roman Kapustin
1feda1152d
Fix InspectCode warnings
2020-11-21 02:06:20 +03:00
Dean Herbert
dd5b90cf6c
Add test coverage of animation restarting
2020-11-19 18:08:54 +09:00
Dean Herbert
fe025043bd
Make test run multiple times
2020-11-19 17:16:29 +09:00
Dean Herbert
9df93e1f18
Add basic implementation of particle explosion
...
Using drawables still, just to get things in place and setup the
structure
2020-11-19 14:54:33 +09:00
smoogipoo
f5e12b9d7c
Adjust TestScenePlayerLoader for safety
2020-11-16 23:53:54 +09:00
Bartłomiej Dach
42de4437cc
Add failing test case
2020-11-15 19:43:42 +01:00
smoogipoo
b4470b0152
Merge branch 'fix-broken-test' into osu-hitobject-pooling-playfield
2020-11-14 01:50:13 +09:00
smoogipoo
b4d4f5456c
Fix broken fail judgement test
2020-11-14 01:49:48 +09:00
smoogipoo
5cbf6252b7
Merge branch 'hitobject-pooling-in-playfield' into osu-hitobject-pooling-playfield
2020-11-14 01:03:11 +09:00
smoogipoo
c71b237c4f
Merge all pooling support into Playfield
2020-11-14 00:59:08 +09:00
smoogipoo
36f1833f6e
Move hitobject pooling to Playfield
2020-11-14 00:41:18 +09:00
smoogipoo
feabca860b
Fix sample playback test
2020-11-13 18:35:33 +09:00
smoogipoo
4236dd826d
Improve documentation and make abstract again
2020-11-13 14:57:09 +09:00
smoogipoo
5dbbe11fc6
Remove PoolHitObjects, use return value of CreateDrawableRepresentation() instead
2020-11-12 14:04:16 +09:00
smoogipoo
3401b099d4
Add some tests
2020-11-11 18:50:08 +09:00
Joehu
ef3c918a3c
Simplify input buttons/keys in tests
2020-11-09 14:18:20 -08:00
Dean Herbert
1e1569eb53
Use int instead of long for user_id fields for now
2020-11-06 12:59:46 +09:00
Dean Herbert
ce1743ab28
Fix missed usage in test scene
2020-11-04 15:35:42 +09:00
Dean Herbert
c1d9a0c92c
Move click action out of user panel
2020-11-02 21:09:47 +09:00
Dean Herbert
ed30756c19
Add test coverage for new display (and remove live version for now)
2020-11-02 20:41:14 +09:00
Dan Balasescu
04178e9458
Merge branch 'master' into spectator-replay-watcher
2020-11-02 14:54:51 +09:00
Dan Balasescu
1b53e6c782
Merge branch 'master' into sample-lookup-improvements
2020-11-02 13:04:35 +09:00
Dean Herbert
9a43291fd3
Merge branch 'master' into spectator-replay-watcher
2020-10-30 20:49:24 +09:00
smoogipoo
43f9c1ebea
Fix HUD test having out of date value
2020-10-30 18:26:38 +09:00
Dean Herbert
79aecc9a98
Merge branch 'master' into spectator-replay-watcher
2020-10-30 16:31:24 +09:00
Dan Balasescu
0ef1459f4b
Merge pull request #10621 from peppy/hud-momentary-visibility
...
Add momentary HUD toggle
2020-10-30 15:40:54 +09:00
Dean Herbert
984a243eff
Add skinnable test scene for HUD overlay
2020-10-30 14:24:16 +09:00
Dean Herbert
bd7871d9f5
Update test scene to be non-skinnable (and add test covering momentary display)
2020-10-30 14:20:00 +09:00
Dean Herbert
53bd31c69e
Commit missing test pieces
2020-10-30 14:00:07 +09:00
Dean Herbert
2ea4aa0a37
Fix incorrect specification on some sample lookups
2020-10-30 11:59:41 +09:00
Dean Herbert
fa85751425
Move helper functions to bottom of class
2020-10-29 15:10:42 +09:00
Dean Herbert
fe409a55e6
Rename starvation test
2020-10-29 15:10:11 +09:00
Dean Herbert
ce58bfdc4e
Add test covering host retry after returning to spectator screen
2020-10-29 15:09:12 +09:00
Dean Herbert
6a31a313b6
Fix stop watching test to check correct screen presence
2020-10-29 15:08:06 +09:00
Dean Herbert
7dd3a748be
Add further test logic to ensure retry / restart flow is working correctly
2020-10-29 15:03:38 +09:00
Dean Herbert
a59ea987b7
Make tests more resilient under headless execution
2020-10-29 14:57:36 +09:00
Dean Herbert
6c2cee7b3f
Avoid cross-pollution between tests of current playing state
2020-10-28 23:15:51 +09:00
Dean Herbert
7cc4a7cb5c
Add more accurate fail scenario test logic
2020-10-28 22:59:54 +09:00
Dean Herbert
1d499ec15d
Change beatmap not existing test to specify a beatmap ID that can't possibly exist
2020-10-28 22:51:35 +09:00
Dean Herbert
8bbcb9be8a
Always use imported beatmap in tests
2020-10-28 22:50:57 +09:00
Dean Herbert
5fcd39a43d
Ensure spectator screen is loaded before continuing
2020-10-28 16:29:06 +09:00
Dean Herbert
d5e0fa322b
Fix a couple of inspections
2020-10-27 22:30:45 +09:00
Dean Herbert
2cacdaa11b
Add basic beatmap download and play flow
2020-10-27 19:28:34 +09:00
Dean Herbert
42b3aa3359
Fix spectating when starting from a point that isn't at the beginning of the beatmap
2020-10-27 18:58:37 +09:00
Dean Herbert
a289b7034f
Add test helper functions to promote code share
2020-10-27 18:58:37 +09:00
Dean Herbert
b3d793a505
Fix gameplay proceeding when no frames have been received yet
2020-10-27 18:58:37 +09:00
Dean Herbert
d4467d20a2
Allow tests to continue sending frames from point they left off
2020-10-27 18:58:37 +09:00
Dean Herbert
63131d46aa
Send initial spectator state more correctly in test component
2020-10-27 18:58:37 +09:00
Dean Herbert
4dba96e189
Add more useful frame sending logic to tests
2020-10-27 18:58:37 +09:00
Dean Herbert
c1e7cd6e47
Stop replay playback when frames are starved
2020-10-27 18:58:37 +09:00
Dean Herbert
400542bc0b
Ensure frames arrive
2020-10-27 18:58:37 +09:00
Dean Herbert
593b0a3ada
Setup tests to run headless, add basic pass support
2020-10-27 18:58:37 +09:00
Dean Herbert
67f6d52e35
Setup tests
2020-10-27 18:58:37 +09:00
Dean Herbert
9bb2cff8a5
Convey actual beatmap and ruleset for full testing setup
2020-10-27 18:58:37 +09:00
Dean Herbert
82a27c73a0
Create basic testing setup
2020-10-27 18:58:37 +09:00
Dean Herbert
5fd97bd043
Add basic spectator screen
2020-10-27 18:58:37 +09:00
Dean Herbert
03d566da35
Rename test variable and remove unncessary cast
2020-10-27 14:35:12 +09:00
Dean Herbert
606a4304a8
Remove unused usings
2020-10-27 14:33:16 +09:00
Dean Herbert
6853da459d
Move sample pausing logic out of FrameStabilityContainer
2020-10-27 13:54:33 +09:00
Bartłomiej Dach
7392876b5f
Fix mania crashing due to spectator client handling frames with unconverted beatmap
2020-10-27 00:35:25 +01:00
Dean Herbert
b1a88a4993
Remove extra using
2020-10-26 16:34:30 +09:00
Dean Herbert
dfe07271de
Add very basic latency handling to spectator test
2020-10-26 16:31:39 +09:00
Dean Herbert
f5dbaa9b0f
Only watch local user to prevent conflict between testers
2020-10-26 15:27:15 +09:00
Dean Herbert
8508d5f8b9
Rename test scene to match purpose
2020-10-26 15:24:28 +09:00
Dean Herbert
e941f2fb71
Fix playback not being smooth (and event unbinding logic)
2020-10-26 15:24:12 +09:00
Dean Herbert
b86347dc81
Merge branch 'master' into spectator
2020-10-26 13:39:07 +09:00
Dean Herbert
431054377a
Merge branch 'master' into epilepsy-warning-volume-restoration
2020-10-25 22:22:11 +09:00
Dean Herbert
55f1b05dbf
Fix test failures due to recorder not stopping in time
2020-10-23 14:47:08 +09:00
Dean Herbert
51ae93d484
Revert unnecessary file changes
2020-10-22 19:31:59 +09:00
Dean Herbert
04f46bc1f8
Clean up usings
2020-10-22 19:24:32 +09:00
Dean Herbert
d659b7739d
Correctly stop watching users that leave
2020-10-22 19:16:34 +09:00
Dean Herbert
34e889e66e
Don't watch every user in normal gameplay (but allow so in test)
2020-10-22 18:38:03 +09:00
Dean Herbert
1ab6f41b3b
Add basic send and receive test
2020-10-22 18:10:27 +09:00
Dean Herbert
93db75bd41
Begin shaping the spectator streaming component
2020-10-22 17:48:15 +09:00
Dean Herbert
b39a4da6bc
Add initial classes for spectator support
2020-10-22 14:46:21 +09:00
Bartłomiej Dach
e2552d4c36
Merge branch 'master' into storyboard-skin-sprites
2020-10-20 23:01:54 +02:00
Bartłomiej Dach
8c14c9e1c4
Add basic test coverage
2020-10-20 23:01:25 +02:00
Bartłomiej Dach
2c7880e9d6
Add failing test case
2020-10-20 20:30:15 +02:00
Dan Balasescu
bd4e0e1a60
Merge branch 'master' into epilepsy-warning
2020-10-20 17:43:37 +09:00
Dean Herbert
4f8a755518
Add "hide during gameplay" mode
2020-10-20 14:20:44 +09:00
Dean Herbert
80b1f816c7
Merge branch 'master' into hide-hud-during-break-time
2020-10-20 14:19:04 +09:00
Bartłomiej Dach
fd4bab85cf
Merge branch 'master' into epilepsy-warning
2020-10-20 01:06:46 +02:00
Bartłomiej Dach
1ac0b3b13d
Add asserts to tests
2020-10-20 00:08:26 +02:00
Bartłomiej Dach
a9f27a71a2
Fix code formatting issues
2020-10-19 23:53:41 +02:00
Bartłomiej Dach
8aeeed9402
Fix weird number formatting in test
2020-10-17 15:47:37 +02:00
Bartłomiej Dach
e4463254d7
Add test coverage for score counter alignment
2020-10-17 15:29:30 +02:00
smoogipoo
dfbc0965e4
Merge branch 'master' into peppy/skinnable-health-display
2020-10-16 23:17:17 +09:00
Dean Herbert
e87f515a4f
Merge pull request #10522 from Morilli/legacyskin-fixes
...
Add support for ScorePrefix and ScoreOverlap values in legacy skins
2020-10-16 20:54:03 +09:00
Dean Herbert
0437f7e7e9
Delete outdated test scene
...
Has been replaced by the four new skinnable tests for each component.
2020-10-16 18:22:20 +09:00
Dean Herbert
de60374c88
Remove unused using
2020-10-16 17:26:14 +09:00
Dean Herbert
c0a1f2158c
Add basic component structure for skinnable health displays
2020-10-16 17:08:46 +09:00
Dean Herbert
88f74921fb
Update with new r# inspections
2020-10-16 12:49:39 +09:00
Dan Balasescu
583fdc3a95
Merge pull request #10510 from peppy/skinnable-accuracy-display
...
Add legacy skinning support for accuracy display
2020-10-15 21:20:48 +09:00
Dan Balasescu
5d8cf87155
Merge pull request #10511 from peppy/bottom-error-display
...
Add support for bottom-anchored hit error display
2020-10-15 20:51:09 +09:00
Dan Balasescu
70b050f212
Merge branch 'master' into skinnable-accuracy-display
2020-10-15 20:28:57 +09:00
Dan Balasescu
1ce0e83e59
Merge branch 'master' into skinnable-score-display
2020-10-15 19:16:03 +09:00
Dan Balasescu
93dfbd5d9e
Merge pull request #10505 from peppy/skin-disabler-refactor
...
Move ISampleDisabler implementation to Player and FrameStabilityContainer
2020-10-15 19:14:52 +09:00
Dean Herbert
70806deba1
Add support for bottom-anchored hit error display
2020-10-15 19:14:02 +09:00
Dean Herbert
b31a3fbabb
Add test
2020-10-15 18:11:30 +09:00
Dean Herbert
e1da64398e
Add and consume skinnable score counter
2020-10-15 17:14:42 +09:00
Dean Herbert
219cbec6bd
Split out DefaultScoreCounter and make ScoreCounter abstract
2020-10-15 16:32:30 +09:00
Dean Herbert
b06f59ffdc
Split out test for combo counter specifically
2020-10-15 15:35:33 +09:00
Bartłomiej Dach
2ca6c4e377
Adjust test step names
2020-10-14 23:24:16 +02:00
Dean Herbert
b63303a2a8
Fix tests
2020-10-14 21:40:49 +09:00
Dean Herbert
e3eaba7b2c
Move ISampleDisabler implementation to Player and FrameStabilityContainer
2020-10-14 19:39:48 +09:00
Dean Herbert
7f5ea57bd4
Clean-up pass (best effort) on LegacyComboCounter
2020-10-14 19:16:34 +09:00
Dean Herbert
9bb8a43bce
Combine LegacyComboCounter and ComboCounter classes
2020-10-14 19:16:34 +09:00
Dean Herbert
2fce064e32
Add basic legacy combo counter and updating positioning logic
2020-10-14 19:16:34 +09:00
Dean Herbert
6eb3176776
Add combo incrementing tests to hud overlay test suite
2020-10-14 19:16:34 +09:00
Dean Herbert
375146b489
Make HUDOverlay test scene skinnable
2020-10-14 19:16:34 +09:00
Shane Woolcock
f90ac2e76c
Ensure we assert after the seek has completed
2020-10-07 18:50:02 +10:30
Shane Woolcock
2e0a9f53c1
Add test coverage
2020-10-07 17:52:39 +10:30
Bartłomiej Dach
9eeac759b8
Re-enable and fix gameplay sample playback test
2020-10-05 21:22:32 +02:00
Dean Herbert
606a08c6ad
Temporarily ignore failing gameplay samples test
2020-10-05 20:01:12 +09:00
Dean Herbert
e1c4c8f3d5
Add failing test coverage of gameplay sample pausing (during seek)
2020-10-05 14:27:51 +09:00
smoogipoo
7890319802
Merge branch 'master' into adjust-hit-result-types
2020-10-01 16:19:07 +09:00
Dean Herbert
367b35bb10
Merge branch 'master' into fix-storyboard-sample-pausing
2020-09-30 22:42:26 +09:00
Dean Herbert
414c40d298
Reverse inheritance order of SkinnableSound's pause logic
2020-09-30 15:45:14 +09:00
smoogipoo
f439c1afbc
Make osu/taiko/catch use Ok+Great
2020-09-29 17:16:55 +09:00
Dean Herbert
56c8e4dacf
Fix failing tests
2020-09-29 14:25:39 +09:00
Dean Herbert
d6f3beffb6
Use existing bindable flow instead
2020-09-29 12:50:17 +09:00
Bartłomiej Dach
8d9945dea8
Change until step to assert for consistency
2020-09-27 11:28:23 +02:00
Bartłomiej Dach
00aea77489
Fix potential instability of overlay activation tests
2020-09-27 11:18:13 +02:00
Salman Ahmed
522e2cdbcd
Avoid embedding NUnit Assert inside test steps if possible
2020-09-19 05:56:35 +03:00
Salman Ahmed
1e1422c16a
Samples don't get paused...
2020-09-19 05:55:39 +03:00
Salman Ahmed
b3ffd36b65
Use lambda expression instead
2020-09-19 05:55:28 +03:00
Salman Ahmed
6aa84424e4
Merge remote-tracking branch 'upstream/master' into fix-new-samples-starting-while-gameplay-paused
2020-09-19 05:53:04 +03:00
smoogipoo
c7d24203ce
Make beatmap conversion support cancellation tokens
2020-09-17 17:40:05 +09:00
Salman Ahmed
105634c099
Add test case ensuring correct behaviour
2020-09-16 01:59:41 +03:00
Dean Herbert
d3957e6155
Move title specification for settings groups to constructor
...
Using an abstract property was awkward for this as it is being consumed
in the underlying constructor but could not be dynamically set in time from a
derived class.
2020-09-09 18:50:31 +09:00
Lucas A
82e314da59
Fix merge conflicts.
2020-09-03 21:56:47 +02:00
Dean Herbert
4239e9f684
Fix storyboard test not actually working due to incorrect track referencing
2020-08-21 18:44:14 +09:00
Dean Herbert
d5cbb589c2
Revert some test scene changes to use Beatmap.Track where relevant
2020-08-21 17:21:08 +09:00
Dean Herbert
357fb3a10e
Merge branch 'master' into beatmap-track-rework
2020-08-21 12:53:09 +09:00
Dean Herbert
5714c761eb
Merge pull request #9768 from frenzibyte/allow-counter-customize-sprite-text
...
Allow providing custom sprite text for RollingCounter<T>
2020-08-20 00:14:48 +09:00
Salman Ahmed
8f1a71c6b1
Remove counter sprite attributes for not being of any reasonable use
2020-08-19 07:44:45 +03:00
Dean Herbert
e4303d7943
Fix PlayerLoader test failures due to too many steps
2020-08-18 12:35:23 +09:00
Dean Herbert
93a8bc3d5a
Remove local reset method in GameplayClockContainer
2020-08-17 22:36:09 +09:00
Dean Herbert
d9debef156
Add explicit LoadTrack method
2020-08-17 15:38:16 +09:00
Lucas A
589d4eeb52
Remove setting.
2020-08-16 17:18:40 +02:00
Dean Herbert
71f4e753f0
Merge branch 'master' into beatmap-track-rework
2020-08-16 22:35:32 +09:00
Bartłomiej Dach
c1a9bf507a
Add failing test case
2020-08-15 13:06:53 +02:00
Dean Herbert
e465afa280
Merge branch 'master' into beatmap-track-rework
2020-08-14 20:02:43 +09:00
Lucas A
74a8a4bca8
Make testing code clearer to understand.
2020-08-13 21:53:17 +02:00
Dean Herbert
cf9bda6c19
Add coverage of early exit with null and non-null player
2020-08-13 13:05:13 +09:00
Dean Herbert
fd7bf70b7d
Remove weird "after load" action
...
This was pretty pointless anyway and from its usages, doesn't look to
need to exist.
2020-08-13 13:03:18 +09:00
Dean Herbert
5b536aebe7
Add missing null checks and avoid cross-test pollution
2020-08-13 12:53:37 +09:00
smoogipoo
070d71ec27
More cleanups
2020-08-12 00:48:38 +09:00
smoogipoo
20197e2768
Remove locally-cached music controller
2020-08-11 12:27:32 +09:00
Lucas A
052bb06c91
Add ability to open overlays during gameplay breaks.
2020-08-10 20:13:50 +02:00
smoogipoo
e87f50f74f
Rename method
2020-08-07 22:31:41 +09:00
smoogipoo
5002d69f69
Update inspections
2020-08-07 20:51:56 +09:00
Lucas A
f8ef53a62e
Fix tests.
2020-08-07 10:25:51 +02:00
smoogipoo
2e3ecf71c7
Pass track from Player to components
2020-08-06 18:31:08 +09:00
smoogipoo
5c05fe3988
Expose track from MusicController
2020-08-06 16:24:14 +09:00
smoogipoo
6e42b8219c
Move track to MusicController, compiles
2020-08-06 16:24:14 +09:00
Lucas A
242a035f7e
Apply review suggestions.
2020-08-03 21:25:45 +02:00
Lucas A
25ebb8619d
Add tests.
2020-08-03 16:04:11 +02:00
Dean Herbert
ca434e82d9
Fix test failures due to gameplay clock not being unpaused
2020-07-28 17:09:38 +09:00
Dean Herbert
91c2afe9f1
Merge branch 'master' into fix-gameplay-sample-pausing
2020-07-28 15:10:37 +09:00
Dean Herbert
cc0d5d74d7
Merge branch 'master' into Issue#9170
2020-07-28 13:36:42 +09:00
Dean Herbert
33e8e0aa18
Add back until steps so headless tests can better handle thread delays
2020-07-27 19:05:31 +09:00
Dean Herbert
1f8abf2cf6
Fix headless tests
2020-07-27 19:03:21 +09:00
Dean Herbert
5fd73795f6
Remove wait steps and add coverage of non-looping sounds
2020-07-27 18:02:17 +09:00
Dean Herbert
12368ace3b
Rename variable
2020-07-27 17:46:44 +09:00
Dean Herbert
d8f4e044de
Add test coverage
2020-07-27 17:46:10 +09:00
Dean Herbert
2c62b23d85
Update naming
2020-07-22 19:53:45 +09:00
Dean Herbert
fea6389f69
Hide HUD elements during break time by default
2020-07-22 12:41:06 +09:00
Gagah Pangeran
d9fedb293a
add initial test
2020-07-21 15:48:11 +07:00
Dean Herbert
648e414c14
Update InputHandlers in line with framework changes
2020-07-19 11:39:11 +09:00
Dean Herbert
77143952a9
Add test coverage
2020-07-17 19:17:48 +09:00
smoogipoo
9f7750e615
Add texture wrapping support to skins
2020-07-17 16:54:30 +09:00
Dean Herbert
fa407d2c7b
Make tests better
2020-07-15 16:42:37 +09:00
Joehu
ec3fe8d346
Add test for arrow key seeking
2020-07-14 21:59:26 -07:00
Bartłomiej Dach
3783fe8d6a
Rename fields for clarity
2020-06-26 19:39:53 +02:00
Power Maker
798e8e7a8d
Fix CI fail
2020-06-26 15:12:01 +02:00
Power Maker
efeaa1cc10
Make some changes, fix and add tests
2020-06-26 14:58:42 +02:00
Dean Herbert
a6c6e391ca
Fix player not exiting immediately on Alt-F4
2020-06-23 17:38:30 +09:00
Dean Herbert
9746e24d1e
Rename abstract TestScene
2020-06-12 19:40:54 +09:00
Salman Ahmed
84b40ea2c6
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
...
# Conflicts:
# osu.Game.Rulesets.Catch.Tests/TestSceneBananaShower.cs
# osu.Game.Rulesets.Catch.Tests/TestSceneHyperDash.cs
# osu.Game/Tests/Visual/ModTestScene.cs
# osu.Game/Tests/Visual/OsuTestScene.cs
2020-06-03 22:00:02 +03:00
Lucas A
f63c66396f
Apply review suggestions.
2020-06-02 13:32:52 +02:00
Dan Balasescu
64d1b4b11b
Merge branch 'master' into move-setter-to-duration
2020-06-01 15:55:48 +09:00
smoogipoo
013461377e
Fix potential nullref
2020-05-28 21:46:02 +09:00
Dean Herbert
cbd563e80b
Rename to IHasDuration
2020-05-27 12:38:39 +09:00
Dean Herbert
b8e0a6f127
Move sett from EndTime to Duration
2020-05-27 12:37:44 +09:00
Bartłomiej Dach
24d898c870
Demonstrate failure case in visual test scene
2020-05-21 21:56:55 +02:00
Bartłomiej Dach
8702a1b5a5
Fix test scene regression
2020-05-21 20:16:02 +02:00
smoogipoo
f98ee27185
Fix referencing wrong child
2020-05-18 20:01:00 +09:00
smoogipoo
6d70f4b410
Merge branch 'master' into allowgameplayoverlays-hide-skip
2020-05-18 19:54:38 +09:00
smoogipoo
2fd25f5ee6
Fix tests
2020-05-18 19:54:26 +09:00
Dean Herbert
be3a0a3c1d
Merge branch 'master' into remove-requiredtypes
2020-05-16 18:28:14 +09:00
smoogipoo
648999a2de
Remove all RequiredTypes usages
2020-05-16 18:17:12 +09:00
Lucas A
ed9d6f2829
Fix CI inspection.
2020-05-15 22:58:15 +02:00
Lucas A
4096463d02
Move SkipOverlay internal alpha manipulation to a nested container and adjust visual tests.
2020-05-15 19:43:01 +02:00
Dean Herbert
de50b725d5
Fix mod failure checks executing actual game logic
2020-05-12 20:08:35 +09:00
Salman Ahmed
6fa9feb15c
Merge remote-tracking branch 'upstream/master' into add-interval-list
2020-04-29 05:14:40 +03:00
Salman Ahmed
227503c0af
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
2020-04-23 16:25:33 +03:00
Salman Ahmed
2fa47992dc
Seal the ruleset creation methods and let abstract method take their place
...
Also makes `CreatePlayerRuleset()` and `CreateRulesetForSkinProvider()` not-null to avoid unwanted behaviour with their derivers
2020-04-23 13:27:12 +03:00
Dean Herbert
3b0099c687
Refactor tests
2020-04-21 12:26:43 +09:00
Dean Herbert
5a2129da7c
Merge branch 'master' into allow-cancelling-completion
2020-04-21 11:22:37 +09:00
Salman Ahmed
2c012b9af1
Use AddUntilStep whenever possible
...
Avoid redundant usage
2020-04-20 06:43:18 +03:00
Salman Ahmed
e12e3391fb
Base wait steps duration on the delay used for results display
...
With `* 2` for safety of not potentially going to the next step and the delegate not executed yet.
2020-04-20 06:42:33 +03:00
Dean Herbert
2444dd42d0
Remove not-implemented-exception
2020-04-20 09:57:46 +09:00
Dean Herbert
f3fee73441
Fix DatabasedKeyBindingContainer not using defaults for non-databased ruleset
2020-04-20 09:35:00 +09:00
Salman Ahmed
65a8860a65
Add test cases to ensure no regression in "cancelling completion"
2020-04-19 06:01:09 +03:00
Salman Ahmed
92df4e3a9e
Remove PlayerTestScene constructor and use CreateRuleset method instead
2020-04-17 11:17:51 +03:00
smoogipoo
59728ffebd
Fix up/improve test scene
2020-04-14 15:24:34 +09:00
Salman Ahmed
9a29797a5b
Use IntervalList<double> for tracking break periods
2020-04-09 23:00:16 +03:00
Dean Herbert
1c72afe8c4
Move fading test to top for convenience
2020-04-09 14:52:40 +09:00
Dean Herbert
6db22366e2
Add new tests and tidy up existing tests
2020-04-09 14:47:48 +09:00
Dean Herbert
947745d87e
Change fail effect to be less distracting
2020-04-09 14:34:23 +09:00
Dean Herbert
0e2d5213ce
Merge branch 'master' into low-hp-red-layer
2020-04-09 13:53:57 +09:00
Salman Ahmed
0eaea8ef9d
Create a constructor for break period
...
For simple construction of break periods (e.g. filling a method with an array of break periods inside a test case)
2020-04-05 21:29:03 +03:00
Lucas A
1562612f41
Update visual tests and remove unessecary XMLDoc tag
2020-04-01 15:12:31 +02:00
Dean Herbert
db59d0530e
Remove test coverage of scale down
2020-03-31 14:15:25 +09:00
Dean Herbert
1fce7cce01
Remove ScaleDownToFit as it was not implemented without enough safety
2020-03-31 13:50:04 +09:00
Lucas A
ab01111c36
Fix merge conflicts.
2020-03-30 17:39:11 +02:00
Dan Balasescu
113bbe8c4d
Merge pull request #8488 from peppy/fix-autoplay-results-display
...
Fix auto mod results screen not displaying correctly
2020-03-30 11:01:16 +09:00
Dean Herbert
d99b445720
Move non-headless tests to correct namespace
2020-03-30 10:00:28 +09:00
Dean Herbert
98a700ef3a
Attempt to fix tests by skipping one break at a time
2020-03-30 00:58:06 +09:00
Dean Herbert
653480b2f8
Add regression test
2020-03-29 23:29:46 +09:00
Dean Herbert
a317ef65b8
Remove default for argument
2020-03-28 12:18:28 +09:00
Bartłomiej Dach
46af4bce32
Cover regression in autoplay test
2020-03-27 19:42:45 +01:00
Dean Herbert
6ecfeb8cc3
Merge pull request #8455 from Game4all/handle-novideo-beatmaps
...
Fix NullReferenceException when starting the no-video version of a beatmap with video
2020-03-27 21:12:40 +09:00
Lucas A
6788b7f9cd
Add test for loading storyboards with missing video file.
2020-03-27 12:07:47 +01:00
Lucas A
00c1ff993a
Fix merge conflicts.
2020-03-26 15:48:18 +01:00
Lucas A
c1ac57e70f
Add back visual tests and add easing to alpha fade.
2020-03-26 12:14:44 +01:00
Dean Herbert
07462120e4
Split break tracking into its own component
2020-03-26 15:30:23 +09:00
Dean Herbert
0b728f483f
Rename base test class to help avoid incorrect reference
2020-03-23 10:01:33 +09:00
Lucas A
6b0c5bc65d
Rename to LowHealthLayer to FaillingLayer.
2020-03-17 22:32:07 +01:00
Lucas A
8c611a981f
Update visual tests
2020-03-17 22:17:28 +01:00
smoogipoo
1c4296f5e7
Implement the new results screen
2020-03-17 17:43:16 +09:00
Dean Herbert
c2fbc85e77
Split out test scene for StarCounter
2020-03-09 01:26:34 +09:00
Dean Herbert
979988235d
Increase flexibility of StarCounter component
2020-03-08 15:56:22 +09:00
Dean Herbert
0ccf691c97
Remove unnecessary interpolation
2020-03-06 18:00:07 +09:00
Dean Herbert
3b0e3cd71a
Remove using statements
2020-03-06 17:55:57 +09:00
Dean Herbert
40074f10db
Remove unnecessary override
2020-03-06 17:55:05 +09:00
Dean Herbert
90dbb90470
Merge branch 'master' into disable-keycounter-breaks
2020-03-06 17:53:10 +09:00
Dean Herbert
5200633f9f
Centralise TestPlayer implementations as much as possible
2020-03-05 11:25:07 +09:00
naoey
3d344a076d
Add test for disabled keycounter, don't discard change event values
2020-03-03 06:17:25 +05:30
naoey
1ce972dd5b
Remove unused variable
2020-02-29 21:53:49 +05:30
naoey
bca58ddb42
Make KeyCounter stop counting during breaks
2020-02-29 21:18:43 +05:30
Dean Herbert
29e2e17144
Merge branch 'master' into fix-dho-lifetimes-via-judgements
2020-02-25 19:07:57 +09:00
Dean Herbert
a047456354
Revert changes to make HitObject abstract
2020-02-25 19:07:15 +09:00
Dean Herbert
ffc7eaa3f2
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
...
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.
This fixes BananaShower and JuiceStreams in osu!catch.
This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Dean Herbert
e8ebb31517
Expire old judgement lines if too many exist
2020-02-23 03:53:51 +09:00
Dean Herbert
05c48cd929
Fix volume mute tests regressing
2020-02-14 19:27:32 +09:00
Dean Herbert
47325601f4
Add failing test
2020-02-14 19:16:08 +09:00
Bartłomiej Dach
12469469ad
Add reproduction test steps for lifetime bug
...
Modify TestSceneScrollingHitObjects to contain a test case that serves
as a reproduction for a visual bug in which using the overlapping scroll
algorithm results in an incorrect origin adjustment for lifetime.
2020-02-06 23:12:22 +01:00
Bartłomiej Dach
ecde641729
Randomise colours in scrolling test scene
...
Switch to using randomised colours in TestSceneScrollingHitObjects to
better distinguish individual hit objects.
2020-02-06 22:47:59 +01:00
Salman Ahmed
0ccbffde8d
Use ChildrenOfType instead
2020-02-03 23:43:04 +03:00
Salman Ahmed
26a9d60437
Avoid exposing whenever possible
2020-02-03 23:17:10 +03:00
Salman Ahmed
4cd4055e7c
Rename to AlwaysVisible and add XMLDoc
2020-02-03 20:00:43 +03:00
Salman Ahmed
51ed289c59
Revert namings and behaviour changes
2020-02-03 19:59:58 +03:00
Salman Ahmed
351cb8ac1a
Rename Visible to HasReplayLoaded and change default value
...
Doesn't make sense to be true by default
2020-02-03 15:47:52 +03:00
Salman Ahmed
443063263e
Merge remote-tracking branch 'upstream/master' into fix-key-counter-visible-on-reshowing-hud
2020-02-03 15:18:25 +03:00
Salman Ahmed
0f449d1b99
Set config value instead
2020-02-02 18:46:59 +03:00
Salman Ahmed
28e340c486
Inherit Container and fade the key flow instead of individual children
2020-02-02 18:46:27 +03:00
Salman Ahmed
6103674b54
Add tests for changing HUD visibility on hidden key counter configuration
2020-02-02 14:50:05 +03:00
Dean Herbert
ed368e44ea
Merge branch 'master' into safe-screen-lease
2020-02-01 02:11:18 +09:00
Dean Herbert
19f516e710
Ensure OsuScreen level leases are taken out synchronously
2020-01-31 19:10:44 +09:00
Dean Herbert
5f48affcba
Centralise screen exit logic to ScreenTestScene
2020-01-31 14:19:29 +09:00
Dean Herbert
2187dbd0c2
Rename steps in test for clarity
2020-01-24 14:37:37 +09:00
Dean Herbert
997b49f6dc
Change display to always show progress bar, only hiding seeking handle instead
2020-01-24 14:21:22 +09:00
Dean Herbert
da65fff48e
Merge remote-tracking branch 'upstream/master' into collapse-graph-option
2020-01-24 13:55:42 +09:00
Dean Herbert
c390348eab
Merge remote-tracking branch 'upstream/master' into colour-score-meter
2020-01-24 11:45:33 +09:00
Dan Balasescu
03c778df75
Merge branch 'master' into update-framework
2020-01-09 19:02:26 +09:00
smoogipoo
91735ff367
Update MathUtils namespace usages
2020-01-09 13:43:44 +09:00
Bartłomiej Dach
f0fe3bc804
Pass bindable to BeatmapMetadataDisplay
...
It was reported that mods selected in song select would show up during
loading of replays which were recorded under a different set of mods.
This was caused by BeatmapMetadataDisplay accepting a plain read-only
value of the Mods bindable in PlayerLoader.load(), therefore making the
mod value assignment in ReplayPlayerLoader.OnEntering() have no effect
on that component.
To resolve this issue, make BeatmapMetadataDisplay accept the
higher-level bindable, bind to it locally and pass it down the hierarchy
to ModDisplay.
2020-01-08 20:10:43 +01:00
Bartłomiej Dach
a3f7d3c445
Add failing test
...
Add test case demonstrating the lack of update of the metadata display's
mods upon setting the Mods property in PlayerLoader.
2020-01-08 19:55:35 +01:00
Bartłomiej Dach
d828b31ae4
Schedule child mutation in test setup
2019-12-27 17:16:43 +01:00
Bartłomiej Dach
e2a55b79ca
Refactor scrolling hit object scene
...
To better demonstrate the desired effect of the fix introduced in
193e41f
2019-12-27 16:52:07 +01:00
Bartłomiej Dach
005ec4b373
Demonstrate bug in scrolling container scene
...
Modify TestSceneScrollingHitObjects to showcase the effect of origin
choice on object lifetime for all four scrolling directions.
2019-12-26 20:37:06 +01:00
smoogipoo
00a36c388c
Fix tests
2019-12-26 19:18:39 +09:00
smoogipoo
7414a6aadd
Merge remote-tracking branch 'huoyaoyuan/master' into health-processor
...
# Conflicts:
# osu.Game.Rulesets.Catch/CatchRuleset.cs
# osu.Game.Rulesets.Mania/ManiaRuleset.cs
# osu.Game.Rulesets.Taiko/TaikoRuleset.cs
2019-12-26 14:56:54 +09:00
Dan Balasescu
9702cc9809
Merge branch 'master' into remove-legacy-id
2019-12-25 21:01:12 +09:00
Dean Herbert
0677f746aa
Provide the ruleset to converter classes
2019-12-24 16:02:16 +09:00
smoogipoo
6e7426a098
Simplify/improve beatmap conversion precheck
2019-12-23 17:44:18 +09:00
Andrei Zavatski
5af1260094
Improve testing
2019-12-21 14:30:49 +03:00
smoogipoo
76f2fb378f
Separate score and health parts of ScoreProcessor
2019-12-19 20:03:14 +09:00
Dean Herbert
51a01c7006
Merge pull request #7256 from peppy/remove-ruleset-ctor-param
...
Remove RulesetInfo parameter from Ruleset constructor
2019-12-18 18:42:42 +09:00
smoogipoo
2a128340d0
Merge remote-tracking branch 'refs/remotes/origin/master' into nightcore-beats
2019-12-18 17:58:37 +09:00
Dean Herbert
6e0802e50c
Remove RulesetInfo parameter from Ruleset constructor
2019-12-18 14:49:09 +09:00
Huo Yaoyuan
ecfc6dfa3d
CA1825: use Array.Empty.
2019-12-17 12:59:48 +08:00
Dean Herbert
7d979e1264
Add finalised test scene
2019-12-16 19:41:04 +09:00
smoogipoo
6cf318c34b
Merge remote-tracking branch 'refs/remotes/origin/master' into improve-hud-hiding
2019-12-16 18:41:21 +09:00
Dean Herbert
bc31146560
Mods -> SelectedMods
2019-12-13 21:45:38 +09:00
smoogipoo
1807fc9b61
Fix testcase not converting beatmap
2019-12-12 16:48:33 +09:00
Dean Herbert
3ccfee64f6
Add HUDOverlay tests
2019-12-12 16:09:42 +09:00
smoogipoo
5861eca80d
Make DrawableRuleset take a converted beatmap
2019-12-12 15:58:11 +09:00
Dean Herbert
274958669c
Add early assert as sanity check
2019-12-11 15:47:41 +09:00
Dean Herbert
6c8f325063
Add failing test
2019-12-11 15:46:07 +09:00
Dan Balasescu
bd6a08a21b
Merge branch 'master' into apply-to-track
2019-12-10 16:15:24 +09:00
Dean Herbert
eb074b7058
Allow mods to apply to track, not clock
2019-12-09 17:44:45 +09:00
smoogipoo
53f7c753fb
General cleanups
2019-12-09 16:44:19 +09:00
smoogipoo
c18f2e6436
Merge remote-tracking branch 'refs/remotes/origin/master' into segmented-slider-paths-3
2019-12-09 15:34:49 +09:00
smoogipoo
2654710d91
Add tests and fix negative expected distances
2019-12-06 15:37:06 +09:00
Dean Herbert
12f1c9e088
Fix test failure
2019-12-06 15:29:02 +09:00
Dean Herbert
de23364608
Add failing test
2019-12-06 13:47:34 +09:00
smoogipoo
2702edfa55
Rename new path, replace existing one
2019-12-05 17:49:32 +09:00
smoogipoo
5e9b739b67
Re-implement slider paths to support multiple segments
2019-12-05 16:45:02 +09:00
Dean Herbert
5b8ca8f84a
Remove test ignore rules
2019-12-05 01:17:11 +09:00
Dean Herbert
9ac0ac0944
Merge branch 'master' into fix-pause-testcase
2019-12-05 01:00:27 +09:00
Dean Herbert
f0d49d0cdf
Decouple APILegacyScoreInfo from ScoreInfo
2019-12-03 15:31:11 +09:00
Dean Herbert
e7ef919b0b
Ignore another failing test
2019-11-29 01:47:52 +09:00
Dean Herbert
1c4063677d
Ignore test temporarily
2019-11-29 00:45:35 +09:00
smoogipoo
f504370867
Make player block exit if pausable
2019-11-28 15:58:26 +09:00
Dan Balasescu
c6a85a11bd
Merge branch 'master' into sharpen
2019-11-27 17:09:11 +09:00
Huo Yaoyuan
c0fe91a84c
Merge branch 'master' into sharpen
2019-11-26 18:21:50 +08:00
Dean Herbert
77ce9642ba
Add test coverage and simplify break time updating
2019-11-26 15:32:48 +09:00
Dean Herbert
45514ff660
Apply fixes
2019-11-25 11:30:55 +09:00
Dan Balasescu
5d2a608be0
Merge branch 'master' into lead-in-fixes
2019-11-22 13:48:55 +09:00
Dean Herbert
71a64da566
Fix test regressions
2019-11-21 22:07:37 +09:00
Dean Herbert
bd6831624a
Decouple skip button animations from gameplay clock
2019-11-21 19:51:22 +09:00
Dean Herbert
46a94821d4
Add support for consecutive skips
2019-11-21 18:59:55 +09:00
Dean Herbert
8d1b11d4bd
Add storyboard lead-in tests
2019-11-21 18:50:54 +09:00
Dean Herbert
4e53bca8dd
Simplify tests
2019-11-21 18:50:38 +09:00
Dean Herbert
29d2374928
Add back skip button actuation count tests
2019-11-21 17:23:52 +09:00
Dean Herbert
586e31efc2
Update tests
2019-11-21 15:56:08 +09:00
Dean Herbert
8369be90f2
Allow skip button to actuate more than once
2019-11-21 15:19:06 +09:00
Dean Herbert
dbfec215e7
Improve test quality
2019-11-15 14:47:28 +09:00
Dean Herbert
c7d0b88854
Update test scene
2019-11-15 14:15:09 +09:00
Dean Herbert
eee5902851
Merge remote-tracking branch 'upstream/master' into lead-in-fixes
2019-11-15 14:05:31 +09:00
Huo Yaoyuan
bbeab6fa76
Use auto property.
2019-11-12 19:53:25 +08:00
Dan Balasescu
1c1a49011b
Merge branch 'master' into infrastructure
2019-11-08 19:10:49 +09:00
Dean Herbert
1f40641d05
Add failing test
2019-11-06 10:32:09 +09:00
Bartłomiej Dach
3ec9580ba8
Add test for retry overlay presence
...
Add visual tests checking presence (or lack thereof) of the
hold-to-retry overlay in the results screen.
2019-11-04 01:55:30 +01:00
Dan Balasescu
8a5d3ab40a
Merge branch 'master' into add-retry-button
2019-11-02 10:51:14 +09:00
Dean Herbert
84d17f3702
Add retry button
2019-11-01 15:41:51 +09:00
Dean Herbert
14fec6f1f3
Move ReplayDownloadButton to correct namespace
2019-11-01 15:06:36 +09:00
Dean Herbert
d089e47a56
Merge branch 'master' into master
2019-11-01 14:15:57 +09:00
Huo Yaoyuan
8d290a3242
Resolve CS0067.
2019-10-30 23:43:13 +08:00
Dan Balasescu
514c9f1eef
Merge branch 'master' into bindable-control-points
2019-10-30 16:20:54 +09:00
Dean Herbert
46b44f4f99
Fix PlayerSettingsOverlay being shown by default
2019-10-28 18:37:58 +09:00
nwabear
9e2e87c8d1
added visual tests
...
added small commenting
added xmldoc for CancelResume();
2019-10-26 14:29:52 -05:00
Dean Herbert
e987db37ec
Add grouping of ControlPoints
2019-10-25 19:52:02 +09:00
Dean Herbert
626f7388c8
Add tests for quick retry and quick exit scenarios
2019-10-04 12:23:01 +08:00
Dean Herbert
e646b2677c
Add test coverage
2019-10-04 11:25:23 +08:00
Joseph Madamba
d87f6d270b
Merge branch 'master' into fix-alt-f4-being-blocked-by-overlays
2019-10-03 08:43:31 -07:00
Joehu
ff56453f1a
Fix test regressions
2019-10-02 12:07:07 -07:00
Craftplacer
5f399add82
Resolve @iiSaLMaN 's suggested changes
2019-10-01 18:15:40 +02:00
Dean Herbert
02c1f490f1
Merge branch 'master' into muted-notification
2019-09-28 20:33:32 +08:00
Craftplacer
06c32d52dc
Change wrong volume bindable used in test
2019-09-27 09:19:39 +02:00
Craftplacer
9a31ccd2e3
Add missing test cases for master, track and mute button
...
This also modifies the reset player method to make it possible to set something before the player is loaded but after the container has loaded.
2019-09-26 14:05:43 +02:00
smoogipoo
244627ff10
Add comment + test for slider multiplier
2019-09-25 20:12:01 +09:00
smoogipoo
ccb5623487
Fix test name
2019-09-25 20:03:03 +09:00
Dean Herbert
f11156c2dc
Fix tests not working correctly
2019-09-25 19:30:25 +09:00
smoogipoo
4abe0473b9
Fix relative beat length not considering slider multiplier
2019-09-24 16:49:42 +09:00
Craftplacer
cca97c09d2
Merge branch 'muted-notification' of https://github.com/Craftplacer/osu into muted-notification
2019-09-23 16:50:30 +02:00
Craftplacer
8df77ffe92
Revert test scene changes
2019-09-23 16:48:30 +02:00
Craftplacer
9a687ae8e2
Merge branch 'master' into muted-notification
2019-09-23 01:59:37 +02:00
Craftplacer
c92545e294
Update osu.Game.Tests/Visual/Gameplay/TestScenePlayerLoader.cs
...
Co-Authored-By: Salman Ahmed <slmanarendo1950@gmail.com>
2019-09-23 01:41:59 +02:00
iiSaLMaN
e793854735
Invert BypassFail usage
2019-09-19 08:00:41 +03:00
Craftplacer
c3221e1a36
Prepare classes for player loader test scene
2019-09-18 23:27:26 +02:00
iiSaLMaN
3efcf0493c
Remove redundant using directive
2019-09-18 23:28:48 +03:00
iiSaLMaN
ea6318ed73
Fix failing test
2019-09-18 23:17:24 +03:00
iiSaLMaN
871adb16e0
Add asserts for fail bypassing
2019-09-18 22:51:03 +03:00
Dean Herbert
e17cd9e964
Reduce length of tests
2019-09-18 16:14:31 +09:00
Dean Herbert
77947e8309
Fix rewind tests failing
2019-09-17 22:33:27 +09:00
Dan Balasescu
b10ce0b12d
Merge branch 'master' into key-counter-fixes
2019-09-13 19:43:33 +09:00
smoogipoo
cf2f841b4d
Fix player not correctly exiting after an unpause
2019-09-13 15:42:58 +09:00
Dean Herbert
68feedbd15
Fix unreported CI issue
2019-09-12 18:46:42 +09:00
Dean Herbert
09a0c9f4d2
Add key counter rewind tests
2019-09-12 18:10:50 +09:00
Dean Herbert
0cdf125c1e
Handle key counter rewinding in a better way
...
Use ElapsedFrameTime rather than storing state data
2019-09-12 15:42:14 +09:00
Dean Herbert
158737e001
Remove FadeTime customisation
...
Also adjusts fade transitions to feel better, especially in fast forward scenarios.
2019-09-12 14:27:29 +09:00
Dean Herbert
3a18e9907b
Merge branch 'master' into ingame-leaderboard-general-implementation
2019-09-11 22:32:53 +09:00
Dean Herbert
b89fb5cdf7
Fix failing test
2019-09-06 16:51:30 +09:00
Dean Herbert
6ce36bd39e
Merge branch 'master' into stop-counting-to-score-after-fail
2019-09-06 16:12:53 +09:00
Dean Herbert
f925e781a9
Refactor HitWindows for legibility
2019-09-06 15:24:14 +09:00
Dean Herbert
9d0151f19f
Merge pull request #5969 from peppy/skin-configuration-refactor
...
Refactor skin configuration lookups to be more flexible
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2019-09-05 17:28:37 +09:00
Dean Herbert
a1d7291ffa
Fix pause menu keyboard navigation being affected by initial cursor hover
2019-09-05 16:31:10 +09:00
Dean Herbert
c0bcbfd892
Merge branch 'master'
...
Conflicts:
osu.Game.Tests/Visual/Gameplay/TestSceneSkinnableDrawable.cs
2019-09-05 14:40:30 +09:00
Dean Herbert
f7e417de02
Add test for changing of a source ( #5968 )
...
Add test for changing of a source
2019-09-05 14:06:25 +09:00
Dean Herbert
2983918f71
Merge remote-tracking branch 'upstream/master' into skin-configuration-refactor
2019-09-04 13:40:41 +09:00
Dean Herbert
7cbcc7b906
Further test refactors
2019-09-04 11:36:09 +09:00
Dean Herbert
1802d2efaf
Merge remote-tracking branch 'upstream/master' into fix-gameplay-menu-button-hover-ani
2019-09-04 10:35:14 +09:00
Dean Herbert
5c10a22877
Update tests to use [Test] attributes
2019-09-04 10:34:56 +09:00
Joehu
9ec16bc2b2
Add test for initial button hover
2019-09-03 16:56:45 -07:00
Dean Herbert
2f74ef5131
Add test for changing of a source
2019-09-03 18:22:51 +09:00
Dean Herbert
bebc3309ce
Refactor skin configuration to be infinitely extensible
2019-09-03 17:57:34 +09:00
Dean Herbert
05ed9d3802
Merge remote-tracking branch 'upstream/master' into non-timeoffset-judgements
2019-09-03 13:07:58 +09:00
Joehu
3d1f051437
Move hover tests after key tests
2019-09-02 11:13:34 -07:00
smoogipoo
0c73c5acf3
Expose full hitobject rather than hit windows
2019-09-02 17:14:40 +09:00
smoogipoo
f2bdf94a1d
Add HitWindows to JudgementResult to indicate timing errors
2019-09-02 16:28:14 +09:00
Dean Herbert
f9fcf1562f
Merge remote-tracking branch 'upstream/master' into iskincomponent
2019-09-02 14:21:02 +09:00
Dean Herbert
8f5dc06d55
Merge remote-tracking branch 'upstream/master' into accuracy-bar
2019-08-30 20:18:25 +09:00
smoogipoo
6fb8a6cdbe
Fix testcases not working for OD10
2019-08-30 19:53:38 +09:00
smoogipoo
8b4976ad92
Remove unnecessary intermediate OD tests
2019-08-30 19:53:38 +09:00
Dean Herbert
8fc177b743
Fix namespacing and hitwindow source
2019-08-30 18:46:42 +09:00
Dean Herbert
741bd0a5cf
Fix incorrect colour sizes and simplify alignment specification
2019-08-30 18:35:17 +09:00
Dean Herbert
54696eef39
Reverse display, add animation and reduce width
2019-08-30 17:06:23 +09:00
Dean Herbert
5f3e638499
Make test useful
2019-08-30 16:40:24 +09:00
Dean Herbert
bdbfa7bd2f
Fix class naming
2019-08-30 15:32:47 +09:00
Dean Herbert
1d77e3764d
Merge branch 'master' into accuracy-bar
2019-08-30 15:21:32 +09:00
Dean Herbert
a15828ab25
Introduce the concept of SkinComponents
...
Removes reliance on string lookups and better defines elements for introduction into database
2019-08-30 14:55:52 +09:00
Dean Herbert
dc1046bf0c
Merge remote-tracking branch 'upstream/master' into add-ruleset-legacy-skin
2019-08-30 12:53:05 +09:00
smoogipoo
6ab2b20c70
Add an interface for working beatmaps
2019-08-29 19:38:44 +09:00
Dean Herbert
ecfcbe3723
Merge remote-tracking branch 'upstream/master' into relative-beat-lengths
2019-08-28 20:21:56 +09:00
Dean Herbert
7ea55a5cdd
Merge remote-tracking branch 'upstream/master' into add-ruleset-legacy-skin
2019-08-28 16:36:20 +09:00
iiSaLMaN
18431a42e6
Resolve merge conflicts
2019-08-27 20:06:17 +03:00
smoogipoo
9e926d44c0
Obsolete legacy UpdateState() method
2019-08-27 16:09:47 +09:00
smoogipoo
fb8b5ee106
Add test
2019-08-26 16:31:46 +09:00
Dean Herbert
6e3a63dae8
Update tests
2019-08-26 12:31:51 +09:00
iiSaLMaN
d8535574d1
Pass sample info to Skin.GetSample
2019-08-23 14:32:43 +03:00
Andrei Zavatski
9f64e09625
Move HitErrorDisplayOverlay back to the HUD
2019-08-20 08:45:51 +03:00
Andrei Zavatski
d337f9b482
DefaultHitErrorDisplay -> BarHitErrorDisplay
2019-08-20 08:03:17 +03:00
Andrei Zavatski
50c47568e4
Don't present Meh hit windows if it has no value
2019-08-19 22:45:27 +03:00
Andrei Zavatski
1bff103d32
CI fixes
2019-08-19 21:25:14 +03:00
Andrei Zavatski
6d84523bc0
Add testing
2019-08-19 21:10:12 +03:00
Dean Herbert
ff601eefe6
Fix failing test
2019-08-16 13:21:28 +09:00
Dean Herbert
ad24265730
Split visual component out of MusicController
2019-08-13 14:30:18 +09:00
Dean Herbert
29870c773c
Merge branch 'master' into stop-counting-to-score-after-fail
2019-08-09 14:16:34 +09:00
smoogipoo
a9c4b5ac4e
Add tests
2019-08-09 14:04:56 +09:00
iiSaLMaN
472af16015
Revert unintended change
2019-08-04 19:17:45 +03:00
iiSaLMaN
ca7a812e1c
Add PlayerPosition property
2019-08-04 18:39:42 +03:00
iiSaLMaN
598c02f8b9
Shorten Where().FirstOrDefault()
2019-08-04 18:31:32 +03:00
iiSaLMaN
f5daf98aa5
Reset player state on setup
2019-08-04 18:28:40 +03:00
iiSaLMaN
f2ab259c21
Add an assert if current break index has skipped a break
2019-07-30 13:30:26 +03:00
iiSaLMaN
e6e315e07b
Expose current break index
2019-07-30 13:29:41 +03:00
iiSaLMaN
77aa3a9fe5
Clear previous score items on SetUp
2019-07-30 12:37:01 +03:00
Dean Herbert
e8e5b2742d
Fix manual clock usage
2019-07-30 18:31:57 +09:00
Salman Ahmed
c8b7cf8672
Merge branch 'master' into add-bindable-for-break-times
2019-07-30 06:23:47 +03:00
iiSaLMaN
6233dc22e0
Add simple tests for current implementation
2019-07-29 06:52:42 +03:00
iiSaLMaN
c9e45f8cdc
Assign clocks instead of creating 2 separate overlays
2019-07-28 09:27:02 +03:00
iiSaLMaN
37c3265942
Manually call the update function on retrieving IsBreakTime value
2019-07-28 09:21:54 +03:00
iiSaLMaN
4143bafd67
More simplifies
2019-07-28 05:22:09 +03:00
iiSaLMaN
4d49b38277
Add a function for loading a list of breaks
2019-07-28 05:21:27 +03:00
iiSaLMaN
46f17885c6
Rewrite break overlay test
2019-07-27 15:51:14 +03:00
iiSaLMaN
6fac716ec7
Use container instead of fill flow
2019-07-26 08:15:46 +03:00
Shane Woolcock
5e51012800
Rewrite updateBreakTimeBindable
2019-07-25 22:54:05 +09:30
Dean Herbert
eca63980d2
Add comprehensive scaling mode tests
2019-07-22 14:43:07 +09:00
Dean Herbert
74c961bcff
Add more flexible skin element confine modes
2019-07-22 14:42:56 +09:00
Dean Herbert
ecbd0f7eff
Merge branch 'master' into fix-skip-button-clickability
2019-07-11 23:10:28 +09:00
Dean Herbert
27e79d56ec
Merge branch 'master' into collapse-graph-option
2019-07-09 23:40:43 +09:00
Dean Herbert
64de3840b0
Add missing wait step in TestScenePlayerLoader
2019-07-06 15:25:53 +09:00
Unknown
d05512a12a
invert usage corresponding to previous description change
2019-07-05 09:16:50 +02:00
Dean Herbert
39bd5e6478
Add test
2019-07-05 15:50:31 +09:00
Unknown
b425df6c75
various fixes
...
- make AllowSeeking a Bindable which fixes incorrect initial position and removes unnecessary variables
- make SongProgressInfo fixed height
2019-07-05 08:48:40 +02:00
Unknown
1cb7a9617b
move songprogress up to be able to see below for masking
2019-07-05 08:29:57 +02:00
Unknown
c22667bdf7
reorganise tests
2019-07-05 08:05:38 +02:00
Dean Herbert
1b36860169
Fix test cross-talk
2019-07-04 19:26:12 +09:00
Unknown
608223cbb4
Add setting to collapse the song progress graph
2019-07-04 11:59:38 +02:00
Dean Herbert
2dc356a24e
Remove using
2019-07-04 18:47:43 +09:00
Dean Herbert
86e9d97b6a
Adjust variables and test length to avoid random failures
2019-07-04 18:38:29 +09:00
Dean Herbert
73bc71f8b2
Use local clock to add consistency to skip times
2019-07-04 17:32:58 +09:00
Dean Herbert
db24ac28ec
Add tests
2019-07-04 16:53:08 +09:00
naoey
ee516d2515
Make direct panel download and replay buttons share UI
2019-07-02 15:55:30 +05:30
naoey
d8f6bbc90e
Disable replay button when replay is unavailable
2019-06-29 12:49:03 +05:30
naoey
7d9e215744
Code quality fixes
2019-06-29 12:29:12 +05:30
naoey
424711d24b
Fix replay button shake container
...
- Add license headers
- Slightly reduce bottom margin of button in score screen
2019-06-29 12:26:37 +05:30
naoey
bc52f76556
Move replay button to score card
2019-06-29 10:55:30 +05:30
Dean Herbert
c04f14a1e3
Remove unused using statement
2019-06-26 00:23:39 +09:00
Dean Herbert
a4214db39e
Add test for pause via hold
2019-06-26 00:00:53 +09:00
David Zhao
de59e038ac
Prevent non-combo affecting judgements from triggering sudden death
2019-06-21 14:29:16 +09:00
smoogipoo
0c293be89c
Wait for track to start running before seeking
2019-06-14 19:51:31 +09:00
smoogipoo
95082d2fcc
Rename testcase
2019-06-14 19:35:47 +09:00
smoogipoo
4972f862e6
Seek track instead
2019-06-14 19:35:35 +09:00
smoogipoo
f12caaf907
Increase leniency
2019-06-13 15:47:21 +09:00
smoogipoo
44d2514f1a
Add test scene
2019-06-13 14:45:09 +09:00
Dean Herbert
00ee45fe46
Merge remote-tracking branch 'origin/update-visibility-container' into update-framework
2019-06-11 19:36:13 +09:00
Dean Herbert
609a82bc94
Update VisibilityContainer usage in line with framework
2019-06-11 15:13:58 +09:00
Dean Herbert
59b624d4ba
Fix test regression
2019-06-10 01:08:39 +09:00
Dean Herbert
9c214c3f0e
Add animation on failing
2019-06-04 16:13:16 +09:00
Dean Herbert
a2fbcb2bd3
Fix rebase regressions
2019-05-31 15:58:46 +09:00
Dean Herbert
d1d1c4ee7a
Add lead-in tests
2019-05-31 15:50:46 +09:00
Dean Herbert
f33a5bc54c
Centralise and update WorkingBeatmap creation in test cases
2019-05-31 14:40:53 +09:00
Dean Herbert
4ac2acbfc0
Fix usages of SpriteText (instead of OsuSpriteText)
2019-05-21 14:13:52 +09:00
smoogipoo
ccbf3ff812
Update framework
2019-05-17 22:35:23 +09:00
Roman Kapustin
459a285cd8
Rename test cases to test scenes inline with the framework change
2019-05-14 22:37:25 +03:00
Dean Herbert
d18504bfe0
Attempt to fix pause test failures by reducing steps
2019-05-13 19:23:38 +09:00
Dean Herbert
3566da73cc
Merge branch 'master' into fix-more-pause-cases
2019-05-12 15:57:45 +09:00
Dean Herbert
f5d7330a20
Fix player loader testcase potentially failing ( #4720 )
...
Fix player loader testcase potentially failing
Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-05-12 13:18:38 +09:00
smoogipoo
bde2d552b6
Merge remote-tracking branch 'origin/master' into fix-more-pause-cases
...
# Conflicts:
# osu.Game.Tests/Visual/Gameplay/TestCasePause.cs
2019-05-10 22:16:59 +09:00
smoogipoo
3352252e00
Fix testcase regression
2019-05-10 18:21:07 +09:00
Dean Herbert
97796a8578
Attempt to fix failing tests by delaying starting of the gameplay clock
2019-05-10 18:10:07 +09:00
smoogipoo
7c105fd99f
Fix testcase players pausing on window unfocus
2019-05-10 15:39:25 +09:00
Dean Herbert
3c796bcfda
Merge branch 'master' into fix-player-testcase
2019-05-10 13:20:22 +09:00
Dean Herbert
3bcfc86b9c
Allow custom MaxCatchUpFrames to be specified
...
Also adjusts the default to allow for smoother seeking.
2019-05-09 16:39:03 +09:00
Dean Herbert
66594b7a1b
Pass GameplayStartTime to FrameStabilityContainer to allow bypassing prior to start
2019-05-09 16:39:03 +09:00
Dean Herbert
5b1ae1210a
Add more asserts to pause test in an attempt to track down intermittent test failures
2019-05-09 11:31:40 +09:00
Dean Herbert
29fdfefafc
Merge branch 'master' into fix-player-testcase
2019-05-08 17:30:03 +09:00
Dean Herbert
8bc313fb33
Merge branch 'master' into fix-new-inspections
2019-05-07 14:14:40 +09:00
smoogipoo
d7c09e7dbd
Merge remote-tracking branch 'origin/master' into fix-new-inspections
...
# Conflicts:
# osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
# osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
# osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
# osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
# osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
# osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
# osu.Game/Graphics/OsuFont.cs
# osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
# osu.Game/Overlays/Profile/Header/BadgeContainer.cs
# osu.Game/Overlays/Profile/ProfileHeader.cs
# osu.Game/Screens/Select/PlaySongSelect.cs
# osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
smoogipoo
3661ddbff6
Fix player loader testcase potentially failing
2019-05-07 13:02:19 +09:00
Dean Herbert
3e3f12f277
Use more local bindables
2019-05-04 17:53:17 +09:00
iiSaLMaN
b08fb5136e
Merge branch 'master' into sh-xh-grading-2
2019-04-26 10:38:10 +03:00
KingLuigi4932
4e0f21102b
Merge branch 'sh-xh-grading-2' of https://github.com/iiSaLMaN/osu into sh-xh-grading-2
2019-04-25 14:04:12 +03:00
KingLuigi4932
c6b3197dd0
Add AdjustRank and use it in Hidden Mod
2019-04-25 13:56:57 +03:00
smoogipoo
0bd35ab7bb
Turn on warnings, resolve issues
2019-04-25 17:36:17 +09:00
Dan Balasescu
9fa8f62077
Merge branch 'master' into update-framework
2019-04-25 12:25:17 +09:00
Dean Herbert
f273f5daae
Remove unnecessary using statement
2019-04-24 15:55:51 +09:00
Dean Herbert
3b36a4982d
Fix tests running under nUnit and running multiple times in concession
2019-04-24 15:46:49 +09:00
Dean Herbert
a3e7ec0a14
Add tests for FrameStabilityContainer
2019-04-24 15:25:53 +09:00
smoogipoo
489929d25c
Fix PlayerLoader testcase being completely broken
2019-04-19 20:38:38 +09:00
smoogipoo
5a3d6a0258
Fix post-merge errors
2019-04-17 16:11:59 +09:00
Dean Herbert
bb539af1a0
Merge branch 'master' into player-mod-reinstantiation
2019-04-16 22:35:21 +08:00
smoogipoo
1db2d49696
Fix testcases
2019-04-10 17:54:57 +09:00
smoogipoo
0222424aef
Make mods IReadOnlyList<Mod> gamewide
...
Prevents potential multiple evaluations of enumerable.
2019-04-10 17:20:36 +09:00
smoogipoo
4310f07a5c
Rename SelectedMods -> Mods
2019-04-10 12:03:57 +09:00
smoogipoo
aa2c97b859
Add mod reinstantiation testcase
2019-04-09 15:05:03 +09:00
smoogipoo
d8ec1e73a3
Cleanup TestCasePlayerLoader
2019-04-09 13:50:54 +09:00
smoogipoo
c584967eb1
Remove mods from workingbeatmap
2019-04-09 12:59:32 +09:00
Dean Herbert
c39c37a18d
Apply more missed cases
2019-04-01 12:44:46 +09:00
Dean Herbert
6949c233bf
Merge remote-tracking branch 'upstream/master' into resume-cursor-2
2019-03-29 15:02:12 +09:00
Dean Herbert
202a0086cc
Merge branch 'master' into better-player-flags
2019-03-29 13:45:45 +09:00
Dean Herbert
fed58fba3a
Merge remote-tracking branch 'upstream/master' into resume-cursor-2
2019-03-29 12:14:28 +09:00
Dan Balasescu
d410054ec8
Merge branch 'master' into key-counter-display
2019-03-29 11:22:59 +09:00
Dean Herbert
a88f23e555
Convert remaining two flags to ctor parameters
2019-03-26 16:53:44 +09:00
Dean Herbert
83863d35c3
Remove AllowLeadIn flag
2019-03-26 16:35:00 +09:00
Dean Herbert
8658de5108
Rename KeyCounterCollection -> KeyCounterDisplay
...
Also fix not working
2019-03-26 13:52:48 +09:00
Dean Herbert
85c63f14f2
Add comprehensive player resume testing
2019-03-26 13:18:33 +09:00
Dean Herbert
4c0121a112
Merge remote-tracking branch 'upstream/master' into resume-cursor-2
2019-03-26 11:31:23 +09:00
Dean Herbert
39df8cce19
Fix incorrect usage of InternalChildren
...
Could cause overwriting of components added by base DrawableHitObjcet class (such as samples)
2019-03-25 13:48:55 +09:00
Dean Herbert
9a6576c0a1
Merge remote-tracking branch 'upstream/master' into multi-background-stack
2019-03-25 12:40:31 +09:00
Dean Herbert
a1c5eda05b
Add grouping of visual tests
2019-03-25 01:02:36 +09:00
