37510 Commits

Author	SHA1	Message	Date
Dean Herbert	f9d952220f	Fix barlines being misaligned if generation start time is clamped	2022-11-23 18:12:03 +09:00
Dean Herbert	774f70e380	Simplify class structure	2022-11-23 16:56:40 +09:00
Dean Herbert	0749a7bb07	Simplify attribute assignment	2022-11-23 16:53:36 +09:00
Dean Herbert	0f034606fd	Use LocalisableDescription from BeatmapOnlineStatus enum instead of locally defined	2022-11-23 16:49:51 +09:00
Dean Herbert	a8af83e62a	Move label initialisation out of ctor	2022-11-23 16:49:39 +09:00
Dean Herbert	27473262af	Rename attributes in enum to match better with user expectations	2022-11-23 16:45:46 +09:00
Dean Herbert	b89689a34a	Rename class and reword settings text/tooltips to avoid clashing with other naming	2022-11-23 16:31:50 +09:00
Dean Herbert	a9192c32ea	Merge branch 'master' into beatmap-info	2022-11-23 16:10:12 +09:00
Dean Herbert	9b9b8a5977	Add ability to seek between control points in editor using down/up arrows ... Matches stable. Addresses #21376.	2022-11-23 15:59:32 +09:00
Dean Herbert	d146f86511	Fix crash when hitting 'T' to tap timing while no timing point is selected	2022-11-23 15:39:56 +09:00
Dean Herbert	172e798847	Merge pull request #21228 from Terochi/recent-messages-implementation ... Add ability to view chat send history in input box	2022-11-23 14:58:42 +09:00
Bartłomiej Dach	8dbc38e17a	Remove unused setter	2022-11-22 20:14:22 +01:00
Bartłomiej Dach	76bb529cfa	Add test for local echo adding day separator	2022-11-22 16:46:21 +01:00
Dean Herbert	de163b2bb5	Change song select to only allow volume adjusting if alt is held while scrolling	2022-11-22 19:48:55 +09:00
Alden Wu	a2b505f4c0	Use a direct Lighten instead of >1f Color4 values	2022-11-22 00:31:22 -08:00
Dean Herbert	1632df1f4d	Update DifficultyBindable to match new bindable spec	2022-11-22 14:51:19 +09:00
Dan Balasescu	985781bc3b	Merge pull request #21356 from peppy/standardise-broken-storyboard-paths ... Add support for storyboards with incorrect path specifications (`\\` instead of `\`)	2022-11-22 14:33:51 +09:00
Alden Wu	4084a2b066	Highlight ChatLine username on hover	2022-11-21 18:57:59 -08:00
Bartłomiej Dach	8dbe31a172	Merge branch 'master' into higher-aspect-ratio-max	2022-11-21 19:51:39 +01:00
Bartłomiej Dach	c0f65d83b3	Merge branch 'master' into hide-no-spin-bonus	2022-11-21 19:14:54 +01:00
Bartłomiej Dach	206aece77b	Merge branch 'master' into avoid-null-audio-device-name-crahs	2022-11-21 16:37:13 +01:00
Bartłomiej Dach	7944d9cefa	Merge pull request #21304 from EVAST9919/beatmap-bar ... Rework BarGraph to use Quads	2022-11-21 16:24:18 +01:00
Terochi	d81ef541bc	Variant 5: cannot change history, edit resets index	2022-11-21 10:17:28 +01:00
Terochi	7dc7729ac2	Variant 4: cannot change history, empty text/everything selected resets index (current with bug fix)	2022-11-21 10:11:26 +01:00
C0D3 M4513R	93ab1c9432	Merge branch 'master' into beatmap-info	2022-11-21 09:01:24 +00:00
Terochi	58288275a6	Variant 3: cannot change history, cannot reset index (the "default")	2022-11-21 09:43:36 +01:00
Terochi	672e1cd45b	Variant 2: edit changes history, cannot reset index (similar to stable)	2022-11-21 09:41:29 +01:00
Terochi	8f942f130b	Variant 1: edit changes history, empty text resets index	2022-11-21 09:36:31 +01:00
Andrei Zavatski	ec8532951c	Make Thickness property auto	2022-11-21 10:32:19 +03:00
Dean Herbert	2774c1ea49	Merge pull request #21215 from jai-x/triangles-bundled-beatmap ... Add winner of Triangles mapping competition as a bundled beatmap	2022-11-21 16:22:23 +09:00
Andrei Zavatski	14a4de36f4	Expose thickness property	2022-11-21 10:20:35 +03:00
Dean Herbert	3da21e596a	Add support for storyboards with incorrect path specifications (\\ instead of \) ... Closes https://github.com/ppy/osu/issues/21204.	2022-11-21 16:12:01 +09:00
Dean Herbert	462a213ffc	Add TODO note about handling initial silences	2022-11-21 15:23:04 +09:00
Dean Herbert	efd73ea9da	Rename method to suit better	2022-11-21 15:22:57 +09:00
Dean Herbert	5c640d15a0	Stop requesting messages as part of initial chat presence	2022-11-21 15:17:54 +09:00
Dean Herbert	9a330c3cdb	Apply nullability and clean up conditionals	2022-11-21 15:02:45 +09:00
Dean Herbert	a07b033d22	Merge branch 'master' into triangles-v2	2022-11-21 14:55:01 +09:00
Dean Herbert	981264b011	Avoid crashing when a system audio device provides a null name	2022-11-21 14:51:41 +09:00
Dean Herbert	40f2da364c	Limit how far before the first hitobject that barlines can be generated	2022-11-21 14:40:25 +09:00
Dean Herbert	93a189603a	Hide spinner ticks / bonus from results screen when not applicable to score	2022-11-21 14:20:36 +09:00
Dean Herbert	4a79141824	Merge pull request #21338 from RATCM/fix-leaderboard-filter ... Match leaderboard filter behaviour to web	2022-11-21 14:01:55 +09:00
Dean Herbert	e53b4321ff	Ensure two day separators are not added in a row	2022-11-21 14:01:10 +09:00
Dean Herbert	fa7b45dfb1	Fix chat day separator not being added on pending message resolution ... Closes #21316.	2022-11-21 13:52:14 +09:00
Dean Herbert	dfa92b3de9	Merge pull request #21326 from bdach/fix-phantom-beatmap-sets ... Fix phantom beatmap sets appearing on carousel after delete/update	2022-11-21 13:25:14 +09:00
Dean Herbert	c7ae837687	Increase maximum aspect ratio for tablet settings to 23:9 / 2.55	2022-11-21 12:45:54 +09:00
Dean Herbert	92aea22cd3	Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup ... Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-21 12:16:56 +09:00
vegguid	a431b793b9	Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-20 23:18:19 +01:00
Andrei Zavatski	18c79dfda3	Move all the logic into BarsInfo class	2022-11-20 23:00:13 +03:00
RATCM	f5fbb7c8de	Changed comments	2022-11-20 19:27:40 +01:00
RATCM	d20a357c0e	Fixed ordering bug	2022-11-20 19:24:51 +01:00
RATCM	9040dfbd4e	Match leaderboard filter behaviour to web	2022-11-20 17:39:46 +01:00
Bartłomiej Dach	1269afd0c5	Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu ... Hide scroll speed control from effects section on rulesets which don't support it	2022-11-20 16:17:55 +01:00
Bartłomiej Dach	0f382590e6	Remove unnecessary #nullable disable	2022-11-20 15:31:51 +01:00
Bartłomiej Dach	33b2fe46d9	Add xmldoc to HistoryTextBox	2022-11-20 12:29:47 +01:00
Bartłomiej Dach	7b274083d3	Fix phantom beatmap sets appearing on carousel after delete/update ... Regressed in c40c70509e. As it turns out, `item.Item.Filtered.Value` is not the only condition that should be checked to determine if a carousel item should be hidden or not - `item.Item.State.Value != CarouselItemState.Collapsed` should also be true. This was even available as the `item.Item.Visible` convenience property, which is used in this commit. Failing to check `item.Item.State.Value` led to setting non-zero alpha on collapsed carousel items, leading to phantom beatmap sets appearing, as the alpha was set in the entire carousel's `Update()` method, thus firing every frame.	2022-11-20 10:08:34 +01:00
Andrei Zavatski	36141cb2a4	Make BarsInfo a class	2022-11-20 05:14:07 +03:00
Salman Ahmed	4b0ba86bd0	Identify scrolling rulesets using temporary DrawableRuleset instances	2022-11-20 04:12:52 +03:00
Salman Ahmed	58296bd4f0	Introduce IDrawableScrollingRuleset for editor consumption	2022-11-20 04:11:10 +03:00
Andrei Zavatski	fcb52ee237	Make BarsInfo a readonly struct	2022-11-20 02:28:07 +03:00
Andrei Zavatski	fbfcf49ea6	Remove readonly modifier from struct fields	2022-11-20 02:13:54 +03:00
Andrei Zavatski	2cb966b47c	Rework BarsInfo struct	2022-11-20 01:48:54 +03:00
Andrei Zavatski	6c62cfb830	Store barBreadth as a separate float	2022-11-19 23:40:02 +03:00
Andrei Zavatski	67ee9f3915	Naming adjustments	2022-11-19 23:34:55 +03:00
Andrei Zavatski	f1201454b7	Use value tuples	2022-11-19 23:29:50 +03:00
Andrei Zavatski	6f449a583e	Handle empty values as a separate case	2022-11-19 23:27:48 +03:00
Terochi	eff6c7be64	Removed unnecessary methods, changed tests, and moved LimitedCapacityQueue.cs to a more generic namespace.	2022-11-19 16:53:35 +01:00
Bartłomiej Dach	0c671a2a82	Merge branch 'master' into fix-tablet-aspect-ratio-values	2022-11-19 14:32:24 +01:00
Bartłomiej Dach	c05c1625f2	Merge branch 'master' into editor-test-play-dont-retain-test-time	2022-11-19 12:09:04 +01:00
Salman Ahmed	60c424837b	Merge branch 'master' into disable-scroll-speed-on-osu	2022-11-19 12:13:45 +03:00
Salman Ahmed	2e3af97892	Remove unused using	2022-11-19 12:13:36 +03:00
Andrei Zavatski	0239103b6b	Fix BeatmapOverlay crashing test scene	2022-11-19 11:33:14 +03:00
Andrei Zavatski	05992d3aa8	CI fix	2022-11-19 10:23:37 +03:00
Andrei Zavatski	9b8f98735c	Use struct for bars description	2022-11-19 10:16:58 +03:00
Andrei Zavatski	7d02cbafed	Merge branch 'master' into beatmap-bar	2022-11-19 09:58:10 +03:00
Andrei Zavatski	11f5fddc1f	Remove redundant returns	2022-11-19 09:57:52 +03:00
Dean Herbert	130f776427	Merge pull request #21267 from peppy/catch-file-enumeration-errors ... Catch and gracefully handle file/directory enumeration failures during stable import	2022-11-19 15:38:40 +09:00
Salman Ahmed	290369db47	Hide scroll speed slider on rulesets which don't support it	2022-11-19 06:42:27 +03:00
Salman Ahmed	016de2f5a0	Fix editor not always playing hitsounds with clock offsets applied	2022-11-19 05:15:22 +03:00
Andrei Zavatski	e8ca9f5dc5	Rework BarGraph to use Quads	2022-11-19 00:22:57 +03:00
Salman Ahmed	1be8c6bd9c	Fix "perform from screen" not considering screen load state	2022-11-18 17:23:10 +03:00
Dawid Sośnia	9ad484a0f4	Merge branch 'ppy:master' into gameplay-leaderboard-fix	2022-11-18 12:11:22 +01:00
Dean Herbert	06ce8130c2	Apply changes in line with framework NRT updates	2022-11-18 18:13:15 +09:00
Dean Herbert	95908ec023	Update framework	2022-11-18 18:13:00 +09:00
Dan Balasescu	e4fc14faee	Merge pull request #21270 from peppy/auto-advance-bindings ... Auto-advance binding for ruleset key bindings	2022-11-18 16:19:54 +09:00
Dan Balasescu	9d33a6568e	Merge pull request #21292 from peppy/fix-binding-two-keys-single-binding ... Fix being able to bind two non-modifier keys to the same binding	2022-11-18 16:19:38 +09:00
Dan Balasescu	d8e99d811d	Merge pull request #21293 from frenzibyte/fix-timeline-extent-scrolling ... Fix timeline potentially scrolling at extents while not dragging	2022-11-18 16:19:30 +09:00
Dean Herbert	d59befc9d3	Fix initial visual state of positions before sort runs	2022-11-18 16:08:27 +09:00
Dean Herbert	aff218dfd5	Redirect through validity function rather than overriding Sort	2022-11-18 16:03:40 +09:00
Dean Herbert	20af8217f4	Tidy up bindable flow	2022-11-18 15:50:41 +09:00
Dean Herbert	e4f522aad1	Fix inspections / typos	2022-11-18 15:47:37 +09:00
Dean Herbert	d17c091d63	Move constant to a better location	2022-11-18 15:47:31 +09:00
Dean Herbert	3faa7f5f74	Merge branch 'master' into gameplay-leaderboard-fix	2022-11-18 15:44:30 +09:00
Salman Ahmed	90cd386323	Fix timeline potentially scrolling at extents while not dragging	2022-11-18 09:43:16 +03:00
Dean Herbert	bab5be8dee	Merge pull request #21290 from smoogipoo/multiplayer-test-debug ... Add some debugging for multiplayer test failures	2022-11-18 15:39:33 +09:00
Dean Herbert	e658efbefa	Fix being able to bind two non-modifier keys to the same binding	2022-11-18 15:34:41 +09:00
Dan Balasescu	c2a127dc68	Merge pull request #21289 from peppy/fix-triangle-button-flash ... Fix triangle button flash effect looking incorrect	2022-11-18 15:26:43 +09:00
Dan Balasescu	219d049edf	Merge pull request #21140 from maromalo/long-standard ... Standardise scores to `long` type	2022-11-18 15:26:33 +09:00
Dan Balasescu	cc434c9113	Merge pull request #21288 from peppy/fix-no-network-slow-gameplay-load ... Fix entering gameplay while network connection is in a bad state taking too long	2022-11-18 15:24:31 +09:00
Dan Balasescu	7e9d2ecaf5	Merge pull request #21287 from peppy/fix-null-ref-persistent-endpoint-connector ... Fix potential incorrect connection state resulting in null reference	2022-11-18 15:08:33 +09:00
Dan Balasescu	b0faa009c1	Add some debugging for multiplayer test failures	2022-11-18 14:52:11 +09:00
Dean Herbert	5fc0d45675	Fix triangle button flash effect looking incorrect	2022-11-18 14:30:59 +09:00
Dan Balasescu	57b8495c7a	Merge branch 'master' into long-standard	2022-11-18 14:24:04 +09:00
Dan Balasescu	d47c46d144	Compute raw score in-line ... Saves on an allocation (though it seems to only be a ValueType so it shouldn't be a big deal) and a tail-call.	2022-11-18 14:22:28 +09:00
Dean Herbert	964ceddf83	Fix API queue only being flushed once while in a failing state	2022-11-18 14:21:37 +09:00
Dean Herbert	e4d134a820	Reduce time waited on a score submission token from 60 to 30s	2022-11-18 14:07:40 +09:00
Dan Balasescu	1b1fed723d	Merge pull request #21269 from peppy/fix-key-bindings-keyword ... Move "keybindings" keyword to correct section	2022-11-18 14:05:08 +09:00
Dan Balasescu	551192b413	Refactor a bit for readability	2022-11-18 13:55:37 +09:00
Dean Herbert	a5d22195f2	Fix potential incorrect connection state resulting in null reference	2022-11-18 13:45:46 +09:00
Dean Herbert	1ff1738988	Merge pull request #21244 from nanashi-1/beatmapoptions-disabled ... Disable certain beatmap option buttons when there are no beatmaps selected	2022-11-18 12:55:07 +09:00
Dan Balasescu	a776622ce0	Merge pull request #21284 from peppy/now-playing-overlay-texture-reduction ... Fix `NowPlayingOverlay` loading background texture too early (and permanently)	2022-11-18 12:09:16 +09:00
Dan Balasescu	c34dd27674	Merge pull request #21276 from peppy/eager-triangles-disposal ... Eagerly dispose of triangles intro textures to avoid holding for full length of game session	2022-11-18 11:58:39 +09:00
Dan Balasescu	baa4fd56e2	Merge pull request #21279 from peppy/news-load-unload ... Fix news post images never unloading from memory after first display	2022-11-18 11:56:13 +09:00
Dan Balasescu	13fe0d3491	Merge pull request #21278 from peppy/overlay-header-texture-reduction ... Avoid loading overlay headers until first open	2022-11-18 11:53:46 +09:00
Dean Herbert	b53f9baf6a	Fix NowPlayingOverlay loading background texture too early (and permanently)	2022-11-18 11:21:12 +09:00
Dean Herbert	93c2280754	Fix supporter filters text not being set correctly	2022-11-18 10:35:05 +09:00
Dawid Sośnia	0dbf491872	Merge branch 'master' into gameplay-leaderboard-fix	2022-11-17 22:06:51 +01:00
Piggey	eb691266c1	cleanup	2022-11-17 21:50:39 +01:00
Dean Herbert	b37e9c0266	Fix news post images never unloading from memory after first display	2022-11-18 00:01:53 +09:00
Dean Herbert	73e4827d36	Avoid loading overlay headers until first open ... Also switches them to use non-atlased target as they won't benefit much from atlasing.	2022-11-17 23:55:43 +09:00
Dean Herbert	63c1855511	Avoid loading beatmap listing placeholders until required	2022-11-17 23:42:21 +09:00
Dean Herbert	a3e8cc1663	Mark beatmap listing placeholder textures as large	2022-11-17 23:41:35 +09:00
Dean Herbert	20d87fbed4	Eagerly dispose of triangles intro textures to avoid holding for full length of game session	2022-11-17 23:05:34 +09:00
Piggey	fa00fc5c6d	change scoresType to be a bindable	2022-11-17 13:27:56 +01:00
Dragon	a25c94d567	Replacing structure to use LimitedCapacityQueue.cs	2022-11-17 13:07:06 +01:00
Dragon	a9747d367c	Cleaning up	2022-11-17 13:07:06 +01:00
Terochi	0100c01b82	Implemented finite limit of stored history.	2022-11-17 13:07:06 +01:00
Terochi	5253f5309e	Added more tests for new features	2022-11-17 13:07:06 +01:00
Terochi	44c3e71746	Reversed indexing	2022-11-17 13:07:06 +01:00
Terochi	3d4962e181	Added functioning tests.	2022-11-17 13:07:06 +01:00
Terochi	6d83af01e2	Moved and renamed MessageHistoryTextBox.cs for better fit.	2022-11-17 13:07:06 +01:00
Dragon	b9590320b7	Moved implementation to ChatRecentTextBox.cs and derived ChatTextBox.cs and StandAloneChatDisplay.cs from it.	2022-11-17 13:07:06 +01:00
Dragon	a1af663682	Implemented previous messages lookup in the ChatTextBox.cs	2022-11-17 13:07:06 +01:00
Piggey	dea2a6ed8d	override sort() function in SoloGameplayLeaderboard	2022-11-17 12:12:36 +01:00
nanashi-1	4773979e52	add condition	2022-11-17 16:15:34 +08:00
Dean Herbert	d1b2116400	Auto-advance binding for ruleset key bindings	2022-11-17 15:23:20 +09:00
Dean Herbert	bd2e0dc82b	Move "keybindings" keyword to correct section ... Without this, things like tablet settings would show when searching for bindings, even though these settings have nothing to do with key bindings.	2022-11-17 15:09:42 +09:00
Dan Balasescu	5ceb7ecc41	Remove unused using	2022-11-17 13:56:27 +09:00
Dean Herbert	1050d7da34	Use more generic exception type (issue reported AggegateException)	2022-11-17 13:36:16 +09:00
Dean Herbert	adab9f0e48	Catch and gracefully handle file/directory enumeration failures during stable import ... Closes https://github.com/ppy/osu/issues/21214.	2022-11-17 13:34:42 +09:00
Dean Herbert	a4e713a61f	When returning to the editor after test play, use the original editor time rather than the point of exit	2022-11-17 12:36:24 +09:00
Dean Herbert	bfcd9e0f45	Don't seek to current editor location when location is close to (or before) the first object	2022-11-17 12:32:35 +09:00
Dan Balasescu	bdfc317a8e	Merge pull request #21255 from peppy/fix-full-area-reset ... Fix "reset to full area" button not always working correctly	2022-11-17 11:13:06 +09:00
Dan Balasescu	b23b5ebce9	Merge pull request #21257 from peppy/fix-test-mode ... Fix combo colour normalisation setting not applying to editor test play	2022-11-17 10:44:44 +09:00
Salman Ahmed	87b4fee10f	Remove leftover constant	2022-11-17 04:05:21 +03:00
Salman Ahmed	55beaf5d93	Revert buttons order change	2022-11-17 04:05:15 +03:00
Salman Ahmed	039ab83a46	Disable beatmap options button when none selected	2022-11-17 04:00:23 +03:00
Salman Ahmed	0e46614c57	Revert beatmap option button state changes	2022-11-17 03:57:01 +03:00
Salman Ahmed	c1673771eb	Merge branch 'master' into fix-full-area-reset	2022-11-17 01:57:56 +03:00
Salman Ahmed	7a28a7f2a0	Move IGameplaySettings override to compose screen to keep test mode unaffected	2022-11-17 01:45:16 +03:00
Andrei Zavatski	13cf3fc40c	Make SpawnRatio public	2022-11-16 15:17:50 +03:00
Andrei Zavatski	cc4f05f3d3	Replace Scale with SpeedMultiplier	2022-11-16 15:12:57 +03:00
Andrei Zavatski	109aa37dd8	Apply fixes from original Triangles	2022-11-16 15:02:09 +03:00
Andrei Zavatski	d94c624ee4	Merge branch 'master' into triangles-v2	2022-11-16 14:53:32 +03:00
Dean Herbert	ee6fffec5f	Fix combo colour normalisation setting not applying to editor test play	2022-11-16 17:54:49 +09:00
Dean Herbert	bb762d8131	Fix "reset to full area" button not always working correctly	2022-11-16 15:45:26 +09:00
nanashi-1	5d8d8ffce5	fix naming	2022-11-16 10:09:51 +08:00
nanashi-1	55edd6c907	add space	2022-11-16 09:58:49 +08:00
nanashi-1	1fb8357e93	change disabledAlpha from readonly to const	2022-11-16 09:58:32 +08:00
nanashi-1	9101ad0cbd	fixed naming	2022-11-16 09:42:40 +08:00
Dean Herbert	52ecd894db	Move equilateral triangle ratio to constant	2022-11-15 22:20:08 +09:00
nanashi-1	5973bb1956	AddButton now returns the button	2022-11-15 20:57:31 +08:00
nanashi-1	1186ed3e32	add disable	2022-11-15 20:56:18 +08:00
nanashi-1	e8d170e772	disable certain options when no beatmap is selected	2022-11-15 20:55:55 +08:00
Andrei Zavatski	f27a5f977d	Improve triangles distribution	2022-11-15 11:49:53 +03:00
Andrei Zavatski	c7dc6db124	Fix incorrect number of added triangles	2022-11-15 11:32:05 +03:00
Andrei Zavatski	ebff844334	Reset triangles on scale change	2022-11-15 11:06:28 +03:00
Dean Herbert	489dca79a1	Remove upper limit for pooling	2022-11-15 12:31:25 +09:00
Dean Herbert	308ed1abd1	Fix number of judgements shown potentially exceeding upper limit	2022-11-15 12:31:25 +09:00
Dean Herbert	59a8603728	Ensure flowing animation starts correctly from zero	2022-11-15 12:04:40 +09:00
Dean Herbert	aef6ee23eb	Apply pooling support to ColourHitErrorMeter	2022-11-15 12:04:40 +09:00
Dean Herbert	a86b50d62a	Apply nullability to BarHitErrorMeter	2022-11-15 11:33:27 +09:00
Dean Herbert	576f462f59	Add pooling support to BarHitErrorMeter	2022-11-15 11:33:27 +09:00
Dan Balasescu	e43593a164	Merge pull request #21227 from Susko3/fix-FallbackSampleStore-async-fallback-logic ... Fix `FallbackSampleStore.GetAsync` fallback logic	2022-11-14 10:17:42 +09:00
Susko3	56fd1f95b1	Fix FallbackSampleStore.GetAsync fallback logic	2022-11-13 18:47:28 +01:00
Joseph Madamba	4578a96813	Fix beatmap card expanded content not blocking clicks from behind	2022-11-13 08:18:44 -08:00
Andrei Zavatski	81c9ea98e2	Implement TrianglesV2 component	2022-11-13 15:31:48 +03:00
Dean Herbert	efe42f701a	Merge branch 'master' into only-rounded-shader	2022-11-13 16:34:48 +09:00
Dean Herbert	236cc0bdaf	Update resources	2022-11-13 16:21:28 +09:00
Dean Herbert	887b6832c9	Update framework	2022-11-13 16:15:30 +09:00
Dean Herbert	eae8530722	Fix SkinnableSprite lookups broken in lazer-first skins ... Regressed with removal of local `GetTexture` calls in e19ba65f91	2022-11-13 12:46:21 +09:00
Jai Sharma	c5cb4e4e7d	Add winner of Triangles mapping competition as a bundled beatmap ... https://osu.ppy.sh/home/news/2022-10-06-results-triangles	2022-11-12 17:48:40 +00:00
Dean Herbert	f343ba6111	Add xmldoc for chat ack request	2022-11-13 00:10:06 +09:00
Dean Herbert	22d8a1160e	Fix last silence ID being updated too often, causing most silences to be missed	2022-11-13 00:10:06 +09:00
Dean Herbert	143c946128	Simplify ack re-perform flow	2022-11-12 23:02:37 +09:00
Dean Herbert	bfb939cbd0	Expand on why call needs to be made every 10 minutes	2022-11-12 22:24:27 +09:00
Dean Herbert	6a3665a6fd	Remove excess logging on WebSocketNotificaitonsClient	2022-11-12 22:09:27 +09:00
maromalo	1911120afe	Merge branch 'master' into long-standard	2022-11-12 09:52:11 -03:00
Dean Herbert	ace4099079	Update ack code after incorrect merge	2022-11-12 21:41:10 +09:00
Thomas Müller-Höhne	9ef43ebd83	Fix compilation after framework-side PR updates	2022-11-12 21:24:12 +09:00
Dean Herbert	dde09d409b	Merge branch 'master' into chat-silences	2022-11-12 21:00:56 +09:00
Thomas Müller-Höhne	fa8e38d9d6	Target rounded fragment shader ... Compatibility with osu-framework change https://github.com/ppy/osu-framework/pull/5512	2022-11-12 17:18:23 +09:00
Samaoo	4ff17cb4bd	remove unused using directive	2022-11-12 08:52:33 +01:00
Samaoo	7a860fb460	address reviews	2022-11-12 08:49:03 +01:00
Samaoo	268011be9e	use MathF	2022-11-11 17:56:50 +01:00
Samaoo	173f557376	fix tablet aspect ratio values	2022-11-11 17:14:34 +01:00
Dean Herbert	19876ca0fb	Merge branch 'master' into websocket-chat-2	2022-11-11 23:53:42 +09:00
Dean Herbert	151dd7c62f	Fix one more reverted change	2022-11-11 22:21:38 +09:00
Dean Herbert	0af4bdaf5c	Add back removed configuration elements	2022-11-11 18:29:15 +09:00
Dean Herbert	106f1cf90b	Merge branch 'master' into combo-colour-brightness-limit	2022-11-11 18:24:39 +09:00
Dean Herbert	392d4e778e	Change default beatmap listing key binding to Ctrl+B	2022-11-11 17:10:46 +09:00
Dan Balasescu	fe58329478	Merge pull request #21151 from peppy/taiko-judgement-fixes ... Fix various issues surrounding hit judgements	2022-11-11 16:41:46 +09:00
Dan Balasescu	5bdbf56f43	Merge branch 'master' into taiko-judgement-fixes	2022-11-11 15:48:33 +09:00
Dan Balasescu	1a1a186d22	Merge branch 'master' into taiko-barline-separation	2022-11-11 15:47:06 +09:00
Dan Balasescu	db25e9e9c8	Merge branch 'master' into combo-colour-brightness-limit	2022-11-11 15:31:28 +09:00
Bartłomiej Dach	88195d3984	Merge branch 'master' into improve-ui-control-sound-sync	2022-11-11 07:29:37 +01:00
Dan Balasescu	6ac19615fa	Fix test failure	2022-11-11 14:55:41 +09:00
Bartłomiej Dach	63270c8619	Merge branch 'master' into improve-ui-control-sound-sync	2022-11-11 05:50:28 +01:00
Susko3	5b1e39abd5	Fix parsing of Language when using default system locale	2022-11-10 22:56:24 +01:00
maromalo	83a3f1b82e	Add computeRawScore()	2022-11-10 14:15:20 -03:00
Dean Herbert	86862b1f29	Merge pull request #21164 from Susko3/fix-default-24h-time-format ... Fix `Prefer24HourTime` default value being wrong	2022-11-11 00:16:47 +09:00
Dan Balasescu	94772a9cda	Merge pull request #21147 from peppy/fix-timeline-editor-crash ... Fix editor hard crash when beatmap file specified out-of-range timeline zoom value	2022-11-10 22:59:55 +09:00
Dan Balasescu	fd88c92d5a	Merge pull request #21144 from peppy/fix-storyboard-end-start-time ... Fix incorrect handling of storyboard events with `end_time` before `start_time`	2022-11-10 22:53:45 +09:00
Dean Herbert	1f8824a754	Update framework	2022-11-10 16:14:40 +09:00
Dean Herbert	bc6da2bbaf	Merge branch 'master' into fix-default-24h-time-format	2022-11-10 16:14:37 +09:00
Dean Herbert	4c6ab27ae4	Merge pull request #21192 from Samaoo/fix-tablet-area-dimensions ... Fix inaccurate tablet area dimensions when applying aspect ratio	2022-11-10 14:14:11 +09:00
Dan Balasescu	606d42c679	Merge pull request #21184 from peppy/skinnable-things-cleanup ... Skinnable class naming pass	2022-11-10 12:52:08 +09:00
Dan Balasescu	46d4fc0279	Merge pull request #21167 from peppy/fix-storyboard-variables ... Fix some issues with storyboard variables	2022-11-10 12:46:52 +09:00
Dan Balasescu	dddbc7496a	Merge pull request #21168 from peppy/fix-storyboard-extension-lookup ... Fix sprites not displaying in storyboard if filename extension is missing in script	2022-11-10 12:31:00 +09:00
Dan Balasescu	051f7f4c68	Merge pull request #21173 from peppy/toggle-hit-markers ... Add the ability to toggle off hit marker displays in the editor	2022-11-10 12:23:53 +09:00
Dean Herbert	3547c04002	Merge branch 'master' into skinnable-things-cleanup	2022-11-10 12:09:32 +09:00
Dan Balasescu	f90010628c	Merge pull request #21185 from peppy/fix-editor-sample-spam ... Fix editor playing too many sounds when user performs a manual seek during playback	2022-11-10 12:05:16 +09:00
Dan Balasescu	040d7ee247	Merge pull request #21183 from peppy/skinnable-nullability ... Apply nullability considerations to all skin related classes	2022-11-10 11:50:41 +09:00
Joseph Madamba	2b81f3048c	Merge branch 'master' into close-side-overlays-when-main-overlay	2022-11-09 12:48:57 -08:00
Samaoo	be81c658af	move tablet area calculations to functions	2022-11-09 20:14:01 +01:00
Piggey	0011f4e7be	fix comment lol	2022-11-09 19:59:04 +01:00
Piggey	4fbc240aa1	Merge remote-tracking branch 'origin/gameplay-leaderboard-fix' into gameplay-leaderboard-fix	2022-11-09 19:53:56 +01:00
Piggey	ab53fb17d3	change displayed text from #? to -	2022-11-09 19:53:36 +01:00
Samaoo	533a2db5ea	fix inaccurate tablet area dimensions when applying aspect ratio	2022-11-09 18:48:47 +01:00
C0D3 M4513R	a57c824092	Merge branch 'master' into beatmap-info	2022-11-09 14:47:08 +00:00
Dean Herbert	e19ba65f91	Remove LookupName from base ISkinComponentLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	1aa0e40f2f	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
Dean Herbert	e75c3b3f94	Rename SkinnableTarget to GlobalSkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	c908969d9b	Rename ISkinComponent to ISkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	ab458320c4	Fix some lingering inspections	2022-11-09 17:46:24 +09:00
Dean Herbert	4457648b1c	Fix editor playing too many sounds when user performs a manual seek during playback	2022-11-09 17:42:33 +09:00
Dean Herbert	d4251271d8	Apply nullability to SkinnableDrawable	2022-11-09 13:59:13 +09:00
Dean Herbert	bf26dbffc2	Apply nullability to skinning support classes	2022-11-09 13:59:13 +09:00
Dawid Sośnia	9549e55ef8	Merge branch 'ppy:master' into gameplay-leaderboard-fix	2022-11-08 20:04:13 +01:00
Piggey	d48c56818f	change positionText to display "#?" if tracked score is being 51st on the leaderboard	2022-11-08 20:02:21 +01:00
Dean Herbert	4448fcb3c8	Override combo colour brightness normalisation setting only in editor	2022-11-08 18:29:10 +09:00
Dean Herbert	dd4cd3cf8e	Move gameplay configuration to interface to allow editor overriding	2022-11-08 18:25:24 +09:00
Dean Herbert	ada039151b	Add the ability to toggle off hit marker displays in the editor	2022-11-08 18:07:06 +09:00
Dean Herbert	9650ae1329	Limit editor background dim to 75% maximum	2022-11-08 17:20:37 +09:00
Dean Herbert	349d262c18	Remove commented unbind	2022-11-08 17:19:48 +09:00
Dean Herbert	b166e477c2	Merge branch 'master' into editor-background	2022-11-08 17:18:34 +09:00
Dean Herbert	b9374cae55	Hide settings/notifications regardless of IsPresent state of new overlay	2022-11-08 14:38:02 +09:00
Dean Herbert	0b34340447	Fix sprites not displaying in storyboard if filename extension is missing in script	2022-11-08 14:34:28 +09:00
Dean Herbert	064a245c50	Don't trim whitespace from variable keys / values	2022-11-08 13:30:11 +09:00
Dean Herbert	b764d1bd04	Decode variables earlier in flow in case they include indent logic ... Without this change, the `depth` calculation could be incorrect.	2022-11-08 13:29:42 +09:00
maromalo	64e6276397	Fix score rounding issue	2022-11-08 01:10:21 -03:00
Dean Herbert	49f530910c	Merge pull request #21163 from frenzibyte/always-show-cursor-on-focus-loss ... Always display menu cursor when game is not focused	2022-11-08 12:37:19 +09:00
Dean Herbert	2163cd212b	Automatically close settings and notification overlays when opening main overlay ... Closes #21162.	2022-11-08 12:04:07 +09:00
Salman Ahmed	1465d043f4	Merge branch 'master' into song-select-transition-improvement	2022-11-08 03:36:19 +03:00
Susko3	8568520c33	Fix Prefer24HourTime default value ... Will use the system culture so it always matches the rest of the OS.	2022-11-08 01:34:06 +01:00
Salman Ahmed	7ee9018a94	Always display menu cursor when game is not focused	2022-11-08 03:18:12 +03:00
C0D3 M4513R	ab650d8a1b	Use AutoSizeAxes	2022-11-07 15:22:20 +01:00
Dean Herbert	2b72c3833b	Remove unnecessary centering logic in DrawableJudgement	2022-11-07 17:19:32 +09:00
C0D3 M4513R	28ab092b6f	Simplify the whole Templating process	2022-11-07 07:55:42 +01:00
Dan Balasescu	fdca3c2d1c	Rename method for consistency	2022-11-07 14:35:42 +09:00
Dan Balasescu	67e99b5344	Lookup channels before calling HandleJoinedChannel()	2022-11-07 14:34:55 +09:00
Dean Herbert	c69a4f9333	Move major barline portion to default implementation to allow for further customisation ... Of note, this removes the "major" barline triangles from legacy skins. I think this is more correct, as they did not display in stable.	2022-11-07 14:29:58 +09:00
Dean Herbert	f6d93fcd5a	Fix editor hard crash when beatmap file specified out-of-range timeline zoom value	2022-11-07 12:54:02 +09:00
Joseph Madamba	76df61504f	Remove unnecessary timestamp update ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2022-11-06 19:45:59 -08:00
Joseph Madamba	61ec0ba566	Make chat line timestamp adjust to 24-hour time setting	2022-11-06 19:28:01 -08:00
Joseph Madamba	b977fc8181	Use autosize instead of max width on fixed width timestamps	2022-11-06 19:28:01 -08:00
Dean Herbert	6085120dc5	Fix incorrect handling of storyboard events with end_time before start_time	2022-11-07 12:25:36 +09:00
Dan Balasescu	f931bdc5ff	Fix channel lookup not considering missing ids	2022-11-07 12:25:23 +09:00
Dan Balasescu	cd8402df72	Print event type to logs	2022-11-07 12:11:50 +09:00
Dean Herbert	391840404d	Play exiting transition in both directions	2022-11-07 11:59:43 +09:00
Dan Balasescu	cf03001c83	Better handling for joining channels with only ID	2022-11-07 11:52:07 +09:00
Dan Balasescu	e3adf5a985	Handle channel parts	2022-11-07 11:36:55 +09:00
Dan Balasescu	93f84ece0d	Merge pull request #21118 from peppy/increase-main-menu-background-change-delay ... Adjust transition effect for main menu backgrounds	2022-11-07 11:33:09 +09:00
maromalo	8eef2ba8de	quality shenanigans	2022-11-06 20:12:26 -03:00
maromalo	b7ef9b176d	Make score type consistent	2022-11-06 19:59:27 -03:00
C0D3 M4513R	0c17571c58	Merge branch 'master' into beatmap-info	2022-11-06 18:53:14 +00:00
Dean Herbert	e7b543de2f	Move disabled check to apply to all calls to updateGlow()	2022-11-07 02:19:13 +09:00
Dean Herbert	700f8b0469	Remove pointless nested if conditional ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-11-07 02:13:04 +09:00
Dean Herbert	14a4fdfbe3	Merge pull request #21135 from CenTdemeern1/master ... Fix preposition for exclusive fullscreen prompt	2022-11-07 00:00:19 +09:00
Dean Herbert	75bf023f14	Fix HSPAColour.ToColour not being pure	2022-11-06 23:35:51 +09:00
CenTdemeern1	e8603ede15	Fix second prompt	2022-11-06 15:35:26 +01:00
Dean Herbert	51078bddf9	Remove unused bindable	2022-11-06 23:34:04 +09:00
Dean Herbert	ee68f33e3c	Merge pull request #21109 from frenzibyte/fix-beatmap-duplicating-again ... Fix beatmap cards still potentially showing twice in listing	2022-11-06 18:46:31 +09:00
Dean Herbert	e02c477008	Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks ... Remove nullable disable in the checks.	2022-11-06 18:39:03 +09:00
CenTdemeern1	887a3f3e28	Fix preposition for exclusive fullscreen prompt	2022-11-05 19:44:25 +01:00
Bartłomiej Dach	84179fb087	Merge branch 'master' into combo-colour-brightness-limit	2022-11-05 16:48:56 +01:00
Salman Ahmed	c27f7fa421	Merge branch 'master' into song-select-transition-improvement	2022-11-04 20:16:02 +03:00
Salman Ahmed	ee6f036c44	Add note about using ExceptBy once it's available	2022-11-04 19:35:24 +03:00
Salman Ahmed	ce5aacb760	Filter out duplicated cards using custom equality comparer instead	2022-11-04 19:27:35 +03:00
Salman Ahmed	bd512c4937	Remove equality comparison implementation from BeatmapCard ... This turned out to be a hurdle instead as it disallows adding two beatmap cards of equal beatmap, which, while being a good behaviour in client, makes tests more complicated to work.	2022-11-04 19:27:20 +03:00
Dan Balasescu	d426977f03	Handle channel joins	2022-11-04 20:11:42 +09:00
Dan Balasescu	f12ada9d92	Fix chat connecting too early	2022-11-04 19:36:24 +09:00
Dean Herbert	78bb940e6c	Don't play hover sounds on disabled elements	2022-11-04 19:06:08 +09:00
Dean Herbert	0e350f52f5	Fix SliderBar disabled value potentially not transferring to hover sounds	2022-11-04 19:06:08 +09:00
Dean Herbert	a2fdad4afc	Fix slider updating glow when disabled	2022-11-04 19:06:08 +09:00
Dean Herbert	a16540dc6d	Update Nub hover animation to better suit immediacy of sound effects	2022-11-04 19:06:08 +09:00
Dan Balasescu	1d2818dc70	Reschedule ack request on completion	2022-11-04 19:02:26 +09:00
Dan Balasescu	66bbe34116	Move polling clients to osu.Game.Tests namespace	2022-11-04 18:52:57 +09:00
Dean Herbert	8b58475ee0	Update OsuButton hover animation to better suit immediacy of sound effects	2022-11-04 18:51:09 +09:00
Dan Balasescu	fa18b5f701	Construct notifications client inside ChannelManager	2022-11-04 18:51:00 +09:00
Dan Balasescu	72745656e7	Remove StartChat()/chat enablement	2022-11-04 18:48:34 +09:00
Dan Balasescu	58396d49dc	Fix handling of local echo deduplication	2022-11-04 18:44:22 +09:00
Dean Herbert	4f14ae4e34	Adjust transition effect for main menu backgrounds	2022-11-04 17:45:14 +09:00
Dean Herbert	4bbff99f31	Remove unnecessary fade in SeasonalBackground	2022-11-04 17:45:14 +09:00
Dean Herbert	2b934e0bea	Increase delay for changing background on returning to main menu	2022-11-04 17:45:13 +09:00
Dean Herbert	923d44a769	Update dependencies	2022-11-04 17:00:58 +09:00
Dean Herbert	566738494f	Merge pull request #20952 from OliBomby/bezier-convert ... Add conversion algorithm for lazer slider curves to work with stable	2022-11-04 16:49:51 +09:00
Dean Herbert	c40c70509e	Improve song select transition to gameplay	2022-11-04 15:24:37 +09:00
Joseph Madamba	e11d44d14f	Add url clicking support to profile badges	2022-11-03 18:12:32 -07:00
Salman Ahmed	ac8fb4f9b2	Fix beatmap cards still potentially showing twice in listing	2022-11-04 03:23:34 +03:00
C0D3 M4513R	21effc5f54	Merge remote-tracking branch 'origin/beatmap-info' into beatmap-info	2022-11-03 18:55:06 +01:00
C0D3 M4513R	a435e365ea	Allow for the Value of BeatmapInfoDrawable to be formatted	2022-11-03 18:54:55 +01:00
Dean Herbert	f6c376c090	Minor refactoring	2022-11-03 20:29:27 +09:00
Dean Herbert	f75c4ba95f	Update resources	2022-11-03 20:27:44 +09:00
Dean Herbert	1edde8f73c	Merge branch 'master' into disabled-button-sfx	2022-11-03 20:27:41 +09:00
Dean Herbert	cdb3494418	Merge pull request #20765 from Feodor0090/comment-report ... Implement comments reporting	2022-11-03 20:09:00 +09:00
Dean Herbert	486515ed90	Merge pull request #20758 from frenzibyte/maintain-common-mod-selection ... Maintain selection of common mods when switching rulesets	2022-11-03 20:08:32 +09:00
Jamie Taylor	59bbd9c460	Fix some components using wrong sample set	2022-11-03 17:47:49 +09:00
Jamie Taylor	f1c17129eb	Add support for 'disabled' sample variation to HoverClickSounds	2022-11-03 17:47:49 +09:00
C0D3 M4513R	2ec29c0f26	Merge branch 'master' into beatmap-info	2022-11-03 07:09:02 +00:00
C0D3 M4513R	502bfa950e	Fix potential resource leak	2022-11-03 08:05:26 +01:00
Dean Herbert	c48c9ecb6d	Merge pull request #20743 from frenzibyte/improve-beatmap-card-buttons ... Improve clickable area of beatmap card icon buttons	2022-11-03 15:47:08 +09:00
Dean Herbert	e336d486a6	Merge pull request #21093 from peppy/auto-skip-multiple-times ... Fix automated skip not skipping more than once when required	2022-11-03 15:46:56 +09:00
Dean Herbert	56ef519cc2	Move PopoverContainer into OnlineOverlay to ensure correct colours	2022-11-03 15:43:06 +09:00
Dean Herbert	e6c45b8ab5	Merge branch 'master' into comment-report	2022-11-03 15:35:42 +09:00
Dean Herbert	20dd405c2b	Merge branch 'master' into maintain-common-mod-selection	2022-11-03 15:32:40 +09:00
Dean Herbert	07bfac40fa	Adjust padding to avoid overlap with card border when expanded	2022-11-03 14:03:28 +09:00
Dean Herbert	66a6084d3f	Scale in the background fill alongside the icon	2022-11-03 14:03:19 +09:00
Dan Balasescu	fc191807c6	Fix velocity test failing with no audio device	2022-11-03 13:59:22 +09:00
Dean Herbert	df9f49eef2	Move hover layer behind icon ... Looked bad on the "already downloaded" state where the icon becomes black.	2022-11-03 13:56:07 +09:00
Dean Herbert	fb0bc597a0	Merge branch 'master' into improve-beatmap-card-buttons	2022-11-03 13:53:29 +09:00
Dean Herbert	4154be6cda	Adjust auto-skip to skip multiple times if necessary	2022-11-03 13:52:29 +09:00
Dean Herbert	aef3c7918c	Add total skip count to SkipOverlay	2022-11-03 13:52:24 +09:00
C0D3 M4513R	49427fe8b7	Merge branch 'master' into beatmap-info	2022-11-02 15:38:15 +00:00
C0D3 M4513R	95e2521ca4	Use more Localisations	2022-11-02 13:56:55 +01:00
C0D3 M4513R	2e5db5e259	Remove nullable disable from TextElement	2022-11-02 13:24:05 +01:00
C0D3 M4513R	ed7e3a29e2	Add Localisation ... Also add Labels for what is displayed, and prefix/suffix for Labels Add a Prefix and Suffix for Values	2022-11-02 13:00:45 +01:00
cdwcgt	7073d8dd8e	range and precision for EditorDim	2022-11-02 19:57:01 +09:00
cdwcgt	a44c7c7514	range and precision for EditorWaveformOpacity	2022-11-02 19:56:35 +09:00
Dean Herbert	3ec9686e58	Fix test failures and rename configuration value to match better	2022-11-02 18:15:18 +09:00
Dean Herbert	0e502de8b4	Rename field to match usage	2022-11-02 18:04:42 +09:00
Dean Herbert	4f8e912f06	Fix APINotification parsing failing	2022-11-02 17:53:19 +09:00
Dean Herbert	c3eb0c6330	Merge branch 'master' into editor-background	2022-11-02 17:43:38 +09:00
Dan Balasescu	063a8bdf9e	Remove messages from silenced users	2022-11-02 17:13:14 +09:00
Dan Balasescu	f688ed12d0	Add test for removing chat messages	2022-11-02 17:00:47 +09:00
Dan Balasescu	cb51fc7384	Merge pull request #21071 from peppy/fix-multiple-import-notifications ... Fix multiple notifications arriving for imports in edge cases	2022-11-02 16:54:56 +09:00
Dan Balasescu	db34f238c0	Fix inverted condition	2022-11-02 15:47:30 +09:00
Dan Balasescu	e5f53b1ad8	Use Interlocked.Exhange() instead ... Increment isn't correct since it returns the post-incremented value. It also always increments.	2022-11-02 15:18:48 +09:00
cdwcgt	9884618290	rename editorDim to editorBackgroundDim	2022-11-02 15:12:15 +09:00
cdwcgt	d6b8439121	add xmldoc for DimAmount	2022-11-02 15:11:49 +09:00
cdwcgt	df1f7e2b13	remove #nullable disable	2022-11-02 15:09:40 +09:00
Dean Herbert	2b04e852be	Merge branch 'master' into websocket-chat-2	2022-11-02 14:56:13 +09:00
Dan Balasescu	22f662a076	Merge pull request #21070 from peppy/standardise-visual-settings-ui-components ... Standardise "Visual Settings" components to fix mismatched paddings and labels	2022-11-02 14:53:00 +09:00
Dean Herbert	e761c0395d	Fix multiple notifications arriving for imports in edge cases	2022-11-02 14:47:56 +09:00
Dean Herbert	4dabb1aa9c	Merge pull request #20990 from smoogipoo/socket-client ... Generalise `HubClientConnector` into `SocketClientConnector`	2022-11-02 14:17:36 +09:00
Dean Herbert	37300ba9e2	Standardise "Visual Settings" components to fix mismatched paddings and labels	2022-11-02 14:01:57 +09:00
Dean Herbert	50b6fe4acb	Localise new label	2022-11-02 14:01:03 +09:00
Dean Herbert	61fc3c8cc0	Add setting to visual settings toolbox	2022-11-02 13:58:34 +09:00
Dean Herbert	5b8699872f	Merge branch 'standardise-visual-settings-ui-components' into combo-colour-brightness-limit	2022-11-02 13:58:33 +09:00
Dean Herbert	d8aa06ea92	Standardise "Visual Settings" components to fix mismatched paddings and labels	2022-11-02 13:55:56 +09:00
Dean Herbert	99ba7c29dd	Change range to 0-100% and rename to "normalisation"	2022-11-02 13:47:11 +09:00
Dan Balasescu	30800c9252	Add/adjust xmldocs	2022-11-02 13:16:34 +09:00
Dean Herbert	2f3c80f884	Remove toggle and change method of application to blend with original colour	2022-11-02 13:08:29 +09:00
Dean Herbert	a01602e63c	Merge branch 'master' into combo-colour-brightness-limit	2022-11-02 12:09:27 +09:00
Dan Balasescu	3816152c9d	Merge branch 'socket-client' into websocket-chat-2	2022-11-02 11:49:57 +09:00
Dan Balasescu	e59c8b7d24	Use IDisposable instead	2022-11-02 11:49:04 +09:00
Dan Balasescu	c9108ce41b	Rename StartAsync -> ConnectAsync	2022-11-02 11:44:16 +09:00
Dan Balasescu	46d1713e28	Rename Socket* -> PersistentEndpoint*	2022-11-02 11:43:22 +09:00
Dan Balasescu	8ac2075c61	Fix possible threading issues ... Not really sure of the best way to handle this in general. It could be argued that this should be a `Component` type and the bindable bound in `LoadComplete()`...	2022-11-02 10:04:25 +09:00
C0D3 M4513R	975eed964e	Don't make Beatmap in OsuGameBase public ... Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>	2022-11-01 21:19:01 +01:00
C0D3 M4513R	c231a20cbb	Add a generic text Element ... Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>	2022-11-01 20:54:52 +01:00
C0D3 M4513R	905ebc3c1f	Initial implementation of a Beatmap Information Skinning Element ... Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>	2022-11-01 20:46:32 +01:00
Dean Herbert	9f031b55a1	Merge branch 'master' into fix-directory-selector-breadcrumb	2022-11-01 22:28:13 +09:00
Dean Herbert	e104242864	Update framework	2022-11-01 22:28:06 +09:00
Dan Balasescu	5b25ef5f2f	Construct notifications client via IAPIProvider	2022-11-01 21:34:34 +09:00
Bartłomiej Dach	ac554c644d	Merge branch 'master' into fix-slider-sv-snap	2022-11-01 13:19:46 +01:00
Dan Balasescu	5621db8a2e	Merge pull request #21052 from peppy/fix-control-point-info ... Fix control points not being cloned when running beatmap conversion	2022-11-01 21:04:49 +09:00
Dean Herbert	f014acfc8d	Fix DrawableHitObject.AccentColour not being updated if object entry is not attached	2022-11-01 19:34:53 +09:00
Dean Herbert	27af91003b	Merge branch 'master' into combo-colour-brightness-limit	2022-11-01 17:50:26 +09:00
Dean Herbert	978d15955c	Fix control points not being cloned when running beatmap conversion ... Closes #20994. I haven't considered how this affects performance of difficulty calculation or otherwise. Seems like a sane initial fix which we can iterate on going forward. I've tested using the scenario in the linked issue. I'm not going to add test coverage because [BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs) should correctly cover this scenario once we are serialising control points as well.	2022-11-01 17:42:09 +09:00
Dean Herbert	29bc653d24	Remove incorrect double multiplication and add missing test coverage	2022-11-01 17:17:54 +09:00
Dean Herbert	d15585153d	Fix breadcrumb display in directory selector overlapping new "show hidden" button ... Closes #21034.	2022-11-01 17:07:59 +09:00
Dean Herbert	8280605e92	Fix notch toggle not applying correctly after restart	2022-11-01 16:31:09 +09:00
Dean Herbert	2a88409dfe	Fix time snap of sliders not matching when SV is not 1.0x ... This regressed with https://github.com/ppy/osu/pull/20850 because the function was used in other places which expect it to factor slider velocity into the equation. Rather than reverting, I've added a new argument, as based on the method naming alone it was hard to discern whether SV should actually be considered. The reason for the change in #20850 was to avoid the SV coming in from a reference object which may not have a correct SV in the first place. In such cases, passing `false` to the function will give the expected behaviour.	2022-11-01 15:12:58 +09:00
Dean Herbert	706adfb28c	Improve messaging when ruleset load fails	2022-11-01 13:57:34 +09:00
OliBomby	0461303895	Change return type to List	2022-10-31 11:39:41 +01:00
OliBomby	414e21c657	Added xmldoc to public methods	2022-10-31 11:39:14 +01:00
Dean Herbert	17f482bfc3	Merge branch 'master' into websocket-chat-2	2022-10-31 16:11:58 +09:00
Dean Herbert	8a37649097	Merge branch 'master' into socket-client	2022-10-31 16:00:14 +09:00
Dean Herbert	94dd4045f1	Remove borrowed framework code	2022-10-31 15:42:17 +09:00
Dean Herbert	31ba77e378	Merge branch 'master' into bezier-convert	2022-10-31 15:41:08 +09:00
Dean Herbert	9ea2bd84bd	Merge pull request #21018 from andy840119/reuse-the-function-in-timeline-class ... Reuse function in the timeline class	2022-10-30 23:49:02 +09:00
Dean Herbert	1035b5fb19	Fix hold to pause button not working when HUD is hidden	2022-10-30 21:38:45 +09:00
andy840119	a753369d3e	Reuse function TimeAtPosition() and PositionAtTime().	2022-10-30 17:21:50 +08:00
andy840119	4c9c65856c	Remove the nullable disable annotation in the testing beatmap and mark some of the properties as nullable. ... This class will be used in some check test cases.	2022-10-30 17:03:54 +08:00
andy840119	a1a9238bd1	Use empty string instead of null because issue template not accept null.	2022-10-30 16:31:07 +08:00
andy840119	505ec800da	File name should be nullable.	2022-10-30 16:29:54 +08:00
andy840119	db48a57fa7	Remove nullable disable annotation in some checks class.	2022-10-30 16:28:49 +08:00
andy840119	24c27e62f6	Remove nullable disable annotation in the issue and issue template-related class.	2022-10-30 16:25:15 +08:00
Joseph Madamba	d56786b5ff	Fix toolbar visual bug when toggling clock displays	2022-10-29 15:25:16 -07:00
Bartłomiej Dach	71d87489ab	Merge branch 'master' into safe-area-toggle	2022-10-29 13:19:44 +02:00
Bartłomiej Dach	f775741d65	Merge branch 'master' into fix-filename-char-filtering	2022-10-29 12:42:10 +02:00
Bartłomiej Dach	87fc5be562	Merge branch 'master' into improve-argon-bananas	2022-10-29 12:09:24 +02:00
ansel	9df96aab38	Remove local popover containers	2022-10-28 22:17:45 +03:00
ansel	295c40581b	Add a global popover container	2022-10-28 20:18:11 +03:00
D.Headley	21d68bfb84	Delete unused button	2022-10-28 16:40:21 +02:00
Dean Herbert	0c25658805	Update framework	2022-10-28 21:58:38 +09:00
Dan Balasescu	d3173ab1bd	Remove weird cast	2022-10-28 18:54:34 +09:00
Dan Balasescu	ab78cde2d4	Fix crossthread mutations	2022-10-28 18:37:43 +09:00
Dan Balasescu	169bcc2654	Use polling connector in tests	2022-10-28 18:08:08 +09:00
Dean Herbert	f46a9d683a	Fix null reference in headless tests	2022-10-28 18:07:25 +09:00
Dean Herbert	66ed77ac91	Rename and add documentation to function	2022-10-28 18:04:28 +09:00
Dan Balasescu	527b1d9db1	Generalise + add polling-style for usage in tests	2022-10-28 17:53:28 +09:00
Dean Herbert	92167afaab	Merge pull request #20842 from frenzibyte/fix-input-sections-in-tests ... Fix input settings not displaying in visual test browser	2022-10-28 17:27:15 +09:00
Dean Herbert	8c057b3af7	Add comment explaining why handlers are added in OsuGameBase	2022-10-28 17:26:53 +09:00
Dean Herbert	a826f778bf	Merge pull request #20984 from smoogipoo/fix-missing-beatmap-ruleset ... Populate beatmap ruleset in `SoloScoreInfo.ToScoreInfo()`	2022-10-28 17:19:14 +09:00
Dan Balasescu	efa8256911	Use more verbatim strings	2022-10-28 16:32:17 +09:00
Dan Balasescu	2f731f86ba	Adjust ChannelManager to use notifications client	2022-10-28 16:28:58 +09:00
Dan Balasescu	33bb1212d1	Add notifications websocket + chat implementation	2022-10-28 16:28:58 +09:00
Joseph Madamba	87328dd1f5	Fix bar hit error meter labels not clearing when setting to none	2022-10-27 23:59:01 -07:00
Dan Balasescu	eeee928f73	Merge pull request #20946 from peppy/argon-catch ... Add first pass osu!catch "argon" skin	2022-10-28 15:45:46 +09:00
nullium21	6901ed997d	One more little change ... Damn, i forgor. Sorry, CI runners.	2022-10-28 09:22:08 +03:00
nullium21	c1e9398c19	Fix regex by allowing file extensions + typed new ... Apparently, the _whole_ filename was checked with GetValidArchiveContentFilename, not just the stem.	2022-10-28 09:19:34 +03:00
Dan Balasescu	b3219526a5	Populate beatmap ruleset in SoloScoreInfo.ToScoreInfo()	2022-10-28 14:42:45 +09:00
Dan Balasescu	51d8392e7f	Merge pull request #20982 from peppy/remove-obsoleted-simple ... Clean up various obsoleted code	2022-10-28 14:36:04 +09:00
Dean Herbert	f9d2c30c3e	Add user toggle for application of safe areas	2022-10-28 14:05:45 +09:00
Dean Herbert	42eafe318c	Remove various simple obsoletions	2022-10-28 13:20:58 +09:00
Dean Herbert	21f8a91efb	Remove obsoleted int parsing logic of configuration ruleset	2022-10-28 13:12:21 +09:00
Dean Herbert	08832ae593	Remove obsoleted PositionalHitsounds global setting	2022-10-28 13:09:39 +09:00
Dean Herbert	71970d83cf	Remove obsoleted ShowProgressGraph global setting ... This was moved to the component itself.	2022-10-28 12:47:45 +09:00
Dean Herbert	dcff8a193c	Use better method of forcing serialisation	2022-10-28 01:26:10 +09:00
Dean Herbert	3c4ba6e9fc	Fix SoloScoreInfo.Rank not being serialised if rank is D	2022-10-27 19:02:32 +09:00
Dean Herbert	6fe8298152	Update framework	2022-10-27 19:02:01 +09:00
nullium21	68d1febe6e	Use a regex for matching invalid characters instead ... What the regex does is it matches everything except alphanumeric and [_()[] -], excluding EOL since regex101 seems to also match it, and we probably don't want that to happen.	2022-10-27 10:33:50 +03:00
Dan Balasescu	6cca3a3dc8	Add new API requests	2022-10-27 14:55:24 +09:00
Dan Balasescu	4127aaa988	Extract general elements from HubClientConnector into SocketClientConnector	2022-10-27 14:37:10 +09:00
Dean Herbert	14c7cbde38	Fix toggle mute (and volume meter traversal) handling repeat key presses ... Closes #20953.	2022-10-27 11:41:00 +09:00
Dean Herbert	1b2ee44131	Merge pull request #20658 from sw1tchbl4d3r/fix-17143 ... Fix legacy BpmMultiplier clamp value	2022-10-27 11:27:59 +09:00
Joseph Madamba	0efbae6e70	Fix osu! logo drag area being a square	2022-10-26 18:33:07 -07:00
Bartłomiej Dach	71425ba937	Merge branch 'master' into read-current-distance-snap	2022-10-26 22:46:42 +02:00
Bartłomiej Dach	f787da892b	Merge branch 'master' into grid-momentary-shortcuts	2022-10-26 21:30:24 +02:00
OliBomby	86d5fcc26d	Added tests	2022-10-26 19:30:42 +02:00
OliBomby	77dcd0fae2	Create BezierConverter.cs	2022-10-26 17:21:20 +02:00
nullium21	dffebdf7ed	Only use 0-9A-Za-z-_()[] characters in filenames	2022-10-26 13:31:32 +03:00
cdwcgt	6991195d69	let editor dim different from gameplay dim	2022-10-26 15:22:57 +09:00
Dean Herbert	6b53ea3400	Enable distance snapping when DS value is changed via user interaction	2022-10-26 13:37:01 +09:00
Dean Herbert	7d59bc6e2f	Merge branch 'grid-momentary-shortcuts' into read-current-distance-snap	2022-10-26 13:28:04 +09:00
Dean Herbert	54ae16badc	Move distance snap toggle button implementation to DistancedHitObjectComposer	2022-10-26 13:27:23 +09:00
Dean Herbert	8d9a85e9e5	Fix typos in xmldoc ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-10-26 13:14:12 +09:00
Dean Herbert	2016d33055	Offset start of distance snap grid drawing if reference object's start time doesn't align ... Closes #20938.	2022-10-26 13:11:26 +09:00
Dean Herbert	7249542167	Merge pull request #20912 from LittleEndu/carousel-do-not-select-random ... Make beatmap carousel select nearest to selection when selection was filtered	2022-10-26 11:40:56 +09:00
Dean Herbert	d9d083752a	Clamp backwards index to total current items to fix edge case of item removal	2022-10-26 11:03:11 +09:00
Joseph Madamba	8505848b1a	Scroll beatmap listing to top when searching via tags/source	2022-10-25 18:06:49 -07:00
Bartłomiej Dach	48057412f5	Merge branch 'master' into grid-momentary-shortcuts	2022-10-25 22:17:08 +02:00
Bartłomiej Dach	f5ca447b8e	Rename one more "{duplicate -> clone}" reference	2022-10-25 21:34:41 +02:00
Bartłomiej Dach	bcdf24b972	Merge branch 'master' into add-editor-object-clone	2022-10-25 21:33:52 +02:00
Bartłomiej Dach	3d31c9bbc5	Merge branch 'master' into beat-snap-divisor-hotkey	2022-10-25 20:32:32 +02:00
Dean Herbert	cf3bf41b49	Harden and simplify logic to avoid weird issues	2022-10-25 18:57:15 +09:00
Dean Herbert	da93849b80	Rename some pieces and better document SampleBankInfo	2022-10-25 14:55:33 +09:00
Dean Herbert	2b850694fa	Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts	2022-10-25 14:10:45 +09:00
Dan Balasescu	6177df2a24	Merge branch 'master' into fix-17143	2022-10-25 13:44:58 +09:00
Dean Herbert	22ea9a8ab4	Add early return of carousel group has no items	2022-10-25 13:34:22 +09:00
cdwcgt	f9c6190426	Add DimAmount for UserDimContainer	2022-10-25 13:00:53 +09:00
Dean Herbert	2456a18bc1	Rewrite implementation to avoid duplicated LINQ returns	2022-10-25 12:48:17 +09:00
Dean Herbert	4d4f6e25ba	Rename to "clone" instead of "duplicate"	2022-10-25 11:43:23 +09:00
Dean Herbert	1e579e06f8	Fix duplicate working incorrectly if there is no selection currently made	2022-10-25 11:42:12 +09:00
Dean Herbert	da74690ec9	Add test coverage of clone operations	2022-10-25 11:38:58 +09:00
Endrik Tombak	5a118cfdc3	Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection ... Conflicts: osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs	2022-10-24 21:40:48 +03:00
cdwcgt	a2682b3ce3	background dim settings for editor ... View -> Background Dim follow `DimLevel` and `BlurLevel` Co-Authored-By: Dead_Bush_Sanpai <DeadBushSanpai@yandex.com>	2022-10-24 23:55:33 +09:00
cdwcgt	de881cc5cb	useless #nullable disable	2022-10-24 23:17:28 +09:00
Dean Herbert	247cf589aa	Merge branch 'master' into directoryselector-hidden-toggle	2022-10-24 15:33:10 +09:00
Dean Herbert	995216cced	Merge pull request #20819 from Joppe27/taiko-kiai-flashing ... Implement taiko hitobject kiai flashing	2022-10-24 15:31:13 +09:00
Dean Herbert	1d5df15027	Add ability to use Shift+Number to set current beat divisor in editor	2022-10-24 15:20:15 +09:00
Dean Herbert	d0e6bda9ef	Stop HitObjectComposer from handling Shift+Number keys	2022-10-24 15:19:36 +09:00
Dean Herbert	e72a71a28e	Add simple editor "duplicate objects" key binding	2022-10-24 14:01:34 +09:00
Dean Herbert	e9b3048a8b	Change the order of global bindings to give overlays lowest priority	2022-10-24 13:58:00 +09:00
Bartłomiej Dach	a55f91f54b	Merge branch 'master' into read-current-distance-snap	2022-10-24 00:15:15 +02:00
Bartłomiej Dach	3a6a87db0f	Merge branch 'master' into fix-editor-distanct-snap-sv-accounting	2022-10-23 18:42:08 +02:00
Susko3	a35026d537	Downgrade AutoMapper to fix Android startup crash	2022-10-22 23:29:44 +02:00
Dean Herbert	9155fcf3cb	Update framework	2022-10-22 23:25:08 +09:00
Dean Herbert	3d37a67590	Update framework	2022-10-22 14:15:17 +09:00
Salman Ahmed	b0a4cd4f30	Inline content creation in base add method	2022-10-22 03:43:14 +03:00
Salman Ahmed	6c82bc36ed	Encapsulate report logic inside button implementation ... Avoids complicating the `DrawableComment` class, and allows for isolated testability.	2022-10-22 02:48:27 +03:00
Salman Ahmed	9b5e35d599	Remove dependency on DrawableComment from report popover and simplify logic ... Allows for testing the button and popover in isolation.	2022-10-22 02:47:33 +03:00
Salman Ahmed	081cf1cc47	Adjust comment report popover design	2022-10-22 02:45:31 +03:00
Salman Ahmed	0491b1fd18	Merge branch 'master' into update-framework	2022-10-21 22:39:56 +03:00
Dean Herbert	c1ed775deb	Update framework	2022-10-21 23:36:16 +09:00
Dean Herbert	f516e32949	Improve UI a bit	2022-10-21 23:35:53 +09:00
Dean Herbert	bb921ff9a7	Fix incorrect current DS value when inside a slider	2022-10-21 23:35:47 +09:00
ansel	15aeb4a137	Display text in buttons flow instead of toast	2022-10-21 17:25:41 +03:00
Dean Herbert	f6de366766	Combine display and button into one control	2022-10-21 23:21:07 +09:00
Dean Herbert	645a84b1d6	Display current distance snap and add button to update to use it	2022-10-21 22:58:36 +09:00
Dean Herbert	7dc03097ff	Change distance snap to never account for slider velocity ... This is a nuanced detail that was implemented incorrectly from the outset. When mapping, generally a mapper chooses the distance spacing with no regard to the SV. It has always been common to have a lower or higher distance spacing than SV, but with the way the lazer editor has worked, the SV was multiplied into the distance snap grid display, incorectly changing its spacing depending on the "reference object" (which is usually the previous hitobject chronologically).	2022-10-21 21:51:24 +09:00
Dean Herbert	447d420c99	Fix adjusting volume via settings playing tick samples twice	2022-10-21 21:03:39 +09:00
Dean Herbert	4803f606c2	Merge pull request #20845 from nekodex/settings-sidebar-sfx ... Add unique hover/select samples to settings sidebar buttons	2022-10-21 20:56:58 +09:00
Dean Herbert	8b74b5807f	Update resources	2022-10-21 20:53:37 +09:00
Dean Herbert	af84f708b7	Avoid serialising some more properties of SoloScoreInfo unless present	2022-10-21 19:30:35 +09:00
Jamie Taylor	7b1edff2b3	Add unique hover/select samples to settings sidebar buttons	2022-10-21 18:06:38 +09:00
Dean Herbert	6cdfddea62	Always enable distance spacing when adusting distance space multiplier	2022-10-21 16:10:55 +09:00
Dan Balasescu	703a8afb11	Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks ... Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself	2022-10-21 12:56:14 +09:00
Dean Herbert	7dbd6e2469	Merge branch 'master' into taiko-kiai-flashing	2022-10-21 12:48:35 +09:00
Salman Ahmed	27ce3d8342	Fix input settings not displaying in visual test browser	2022-10-21 01:52:19 +03:00
Joseph Madamba	bf4a91f1f0	Fix skin toolbox component button not playing hover/click sounds	2022-10-20 13:16:03 -07:00
ansel	81bdf716ef	Change test	2022-10-20 19:56:00 +03:00
ansel	0ef903230c	Make report button a separate component	2022-10-20 18:47:42 +03:00
ansel	da4f04ace7	Make dropdown not resize	2022-10-20 18:22:55 +03:00
ansel	635900085c	Disable button when there is no text	2022-10-20 18:12:20 +03:00
ansel	ed39481932	Use another string for title	2022-10-20 18:11:35 +03:00
Dean Herbert	5c13c443ff	Fix incorrect fallback logic ... Regressed when attempting to share implementation of binary search.	2022-10-20 23:08:44 +09:00
Dean Herbert	26860a903e	Refactor implementation to support hitobjects nested multiple levels deep	2022-10-20 22:30:30 +09:00
Dean Herbert	a754dc6d3b	Expose binary search methods publicly ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2022-10-20 14:34:07 +09:00
Dan Balasescu	fd7274095f	Merge pull request #20826 from peppy/fix-missing-beatmap-backgrounds ... Fix some older beatmaps having missing backgrounds	2022-10-20 12:46:24 +09:00
Dean Herbert	cc311eef2a	Merge pull request #20834 from frenzibyte/fix-slider-ball-tint ... Enable slider ball tint on "classic" skin	2022-10-20 12:34:45 +09:00
Dean Herbert	6b26547d03	Merge pull request #20835 from frenzibyte/improve-hide-mouse-on-keyboard ... Improve automatic cursor hiding logic and limit to gameplay screen	2022-10-20 11:44:20 +09:00
Dean Herbert	2f8a4fd2d0	Merge branch 'master' into remove-current-item	2022-10-20 10:02:09 +09:00
Dean Herbert	77b25c4a5c	Merge pull request #20788 from frenzibyte/handle-submitting-player-request-timeout ... Fix potential exception in `SubmittingPlayer` token retrieval on request timeout	2022-10-20 09:51:57 +09:00
Salman Ahmed	39650717ea	Improve input detection to not make cursor flicker on combined input	2022-10-20 03:45:25 +03:00
Salman Ahmed	4bf4938b72	Keep cursor hiding feature to gameplay screens for now	2022-10-20 03:44:58 +03:00
Salman Ahmed	eb386d4bd5	Enable slider ball tint in default legacy skin	2022-10-20 03:29:25 +03:00
Dean Herbert	a7d4a74ed6	Update osu.Game/Tests/Visual/ScrollingTestContainer.cs ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-10-20 08:07:56 +09:00
Dean Herbert	78943a21d8	Update osu.Game/Beatmaps/ControlPoints/IControlPoint.cs ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-10-20 08:06:05 +09:00
ansel	57320074a0	Fix accidental breakage of changelog layout	2022-10-20 01:24:36 +03:00
Dean Herbert	59e2478b0e	Fix some older beatmaps having missing backgrounds ... Closes https://github.com/ppy/osu/issues/20824. Note that this will require a reimport of beatmaps as it is baked into the database. Probably not worth making a migration for at this point in time.	2022-10-19 16:01:10 +09:00
Joppe27	9b123e7365	Adjust flash intensity and fade values to feel better	2022-10-19 00:51:44 +02:00
Joppe27	a76a039722	Rename KiaiFlashingDrawable and move to osu.Game	2022-10-18 23:40:43 +02:00
Dean Herbert	d237c818f6	Fix nested objects in overlapping scrolling hit object container ruleset not using correct reference time	2022-10-18 16:15:21 +09:00
Dean Herbert	ec3761ced9	Standardise control point search logic in OverlappingScrollAlgorithm ... Was using a very local algorithm which I cannot guarantee is correct. I'd rather it just use the one used everywhere else.	2022-10-18 16:01:05 +09:00
Dean Herbert	fbad33bef7	Adjust durations and make start off screen	2022-10-18 15:01:53 +09:00
Dean Herbert	6b42f1931a	Remove autosize easing in SettingsToolboxGroup ... It just feels like unnecessary motion.	2022-10-18 15:01:26 +09:00
Dean Herbert	84688b53a1	Merge branch 'fix-editor-padding' into player-loader-improvements	2022-10-18 14:52:59 +09:00
Dean Herbert	860214c22a	Adjust paddings to feel better now that backgrounds are visible of toolboxes	2022-10-18 14:38:45 +09:00
Dean Herbert	6a7f6c76ff	Fix osu! editor padding being applied to toolboxes ... The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.	2022-10-18 14:32:00 +09:00
Dean Herbert	0f809dcaa7	Merge branch 'master' into player-loader-improvements	2022-10-18 14:22:55 +09:00
Dean Herbert	72be4940fd	Merge branch 'master' into comment-report	2022-10-18 13:52:33 +09:00
Dean Herbert	ccbac08985	Merge pull request #20593 from ekrctb/catch-editor-height ... Allow arbitrary height catch editor	2022-10-18 12:10:49 +09:00
ansel	3258a41ca3	Merge branch 'comment-report' of https://github.com/Feodor0090/osu into comment-report	2022-10-17 20:41:46 +03:00
ansel	cd77ae062e	Localize the button	2022-10-17 20:41:23 +03:00
ansel	797acf334f	Show username in popup	2022-10-17 20:41:13 +03:00
Feodor0090	6efe7b5334	Merge branch 'master' into comment-report	2022-10-17 16:08:13 +03:00
ansel	ceb4d624b5	Delete wip form	2022-10-17 13:43:35 +03:00
ansel	ffa22d8a68	Update popover not to use labelled drawables	2022-10-17 13:42:17 +03:00
ansel	d7e5bcbd3c	Add popover containers to overlays	2022-10-17 13:41:46 +03:00
Dean Herbert	516320edd9	Merge branch 'master' into handle-submitting-player-request-timeout	2022-10-17 18:51:13 +09:00
Dan Balasescu	4220d6b3fc	Merge pull request #20780 from outfoxxed/fix-hiterror-icons ... Fix hit error bar icon orientation	2022-10-17 18:48:31 +09:00
ansel	7ed26369a3	Make a new report form, closer to web	2022-10-17 12:41:57 +03:00
Dean Herbert	1e7b8cd227	Fix formatting issues	2022-10-17 13:22:06 +09:00
Salman Ahmed	ae05f374a2	Fix potential invalid operation exception in SubmittingPlayer token retrieval	2022-10-17 03:26:29 +03:00
outfoxxed	85de802793	Only create hit error bar icon containers once ... Move icon container creation to BDL, and only recreate the contained icon when `recreateLabels` is called	2022-10-16 11:47:21 -07:00
Bartłomiej Dach	d0a495717e	Merge branch 'master' into comment-copy-link	2022-10-16 19:56:06 +02:00
ansel	4a8d976cb4	Use api's endpoint	2022-10-16 20:20:34 +03:00
ansel	e1785f73a2	Make report's comment not optional	2022-10-16 20:14:05 +03:00
outfoxxed	d6030891a2	Reuse existing code in hit error bar fix ... Use `UprightAspectMaintainingContainer` instead of a local fix for hit error bar orientation	2022-10-16 10:06:38 -07:00
ansel	ba595ab8fa	Display toast instead of notification	2022-10-16 19:57:21 +03:00
ansel	9822a092c4	Add localization for enum	2022-10-16 19:50:55 +03:00
outfoxxed	cd1885a17b	Fix hit error bar icon orientation ... Icons now keep their original orientation when the hit error bar is flipped	2022-10-16 02:55:10 -07:00
Salman Ahmed	1824b1deee	Merge branch 'master' into tablet-button-binding	2022-10-16 04:10:04 +03:00
Aki	91358f4a6a	Implement tablet button bindings	2022-10-15 15:16:14 +08:00
Salman Ahmed	324c749383	Merge branch 'master' into player-loader-improvements	2022-10-15 03:07:15 +03:00
Salman Ahmed	241ecb63a1	Hide manual input manager cursor in OsuGameTestScenes ... Allows checking that the cursor is actually hidden in `TestSceneOsuGame.TestCursorHidesWhenIdle`.	2022-10-15 00:20:22 +03:00
Salman Ahmed	06e6713237	Move mouse input detection inside MenuCursorContainer to allow testing	2022-10-15 00:20:22 +03:00
Salman Ahmed	ba72f13f54	Merge branch 'master' into hide-mouse-on-keyboard-input	2022-10-14 22:26:30 +03:00
Feodor0090	fb046e31c1	Merge branch 'master' into comment-report	2022-10-14 16:57:23 +03:00
ansel	dc0aa2295a	Add test	2022-10-14 16:51:48 +03:00
ansel	3e9fd4c08c	Implement reporting flow	2022-10-14 16:26:25 +03:00
ansel	7251d41deb	Add request class	2022-10-14 16:15:28 +03:00
ansel	c65a8a83f3	Add basic UI for reporting	2022-10-14 15:52:09 +03:00
Dan Balasescu	10aabfc650	Merge pull request #20739 from peppy/settings-toolbox ... Adjust visuals of settings toolboxes (gameplay loading screen and editor)	2022-10-14 20:31:05 +09:00
Dan Balasescu	dcb6357964	Add ability to remove the current item in multiplayer	2022-10-14 20:23:55 +09:00
Dean Herbert	32c3e35762	Change background colour to a lighter tint to avoid clash with slider bars	2022-10-14 19:38:27 +09:00
Dean Herbert	2404bb42b9	Use 10% alpha rather than 0% when toolbox is not hovered	2022-10-14 19:33:49 +09:00
Dan Balasescu	525f98c158	Fix max combo missing from playlists results screen	2022-10-14 18:01:54 +09:00
Dan Balasescu	8a88339e78	Allow combo colour normalisation to be disabled	2022-10-14 14:37:24 +09:00
Dan Balasescu	15db65c037	Extract to struct, add dictionary term	2022-10-14 14:12:53 +09:00
Dan Balasescu	b43bae122c	Fix incorrect porting of code	2022-10-14 13:46:25 +09:00
Salman Ahmed	01c65d3cc1	Remove seemingly unnecessary/leftover code	2022-10-14 02:16:36 +03:00
Salman Ahmed	739b21ab3b	Maintain mod selection on ruleset change for common mods	2022-10-14 02:15:58 +03:00
ansel	8a47628fe1	Use spacer drawable instead of spacing on links container	2022-10-14 00:04:13 +03:00
ansel	295e6f5a68	Move toast to it's namespace	2022-10-13 23:57:25 +03:00
ansel	34ff072a9b	Change text	2022-10-13 22:47:48 +03:00
ansel	a0cca391f6	Add copy link button to comments	2022-10-13 22:18:26 +03:00
ansel	e97dbf3dbc	Move copy toast to its own file	2022-10-13 22:12:32 +03:00
Salman Ahmed	ef72b66dad	Remove beatmap card background workaround to fix broken corners	2022-10-13 16:09:54 +03:00
Salman Ahmed	6c316bcc9e	Make beatmap card icon buttons fill up to the area	2022-10-13 16:09:54 +03:00
Salman Ahmed	aa8040d696	Add hover box to beatmap card icon button	2022-10-13 16:09:54 +03:00
Dean Herbert	3645269108	Improve logo transition and reduce delay of exiting player loader in optimal conditions	2022-10-13 17:29:47 +09:00
Dean Herbert	b33935e392	Fix player loading screen settings scaling in ... This always looked weird, and from the looks of the structure was probably unintentional from the start (it is in the logo tracking container for whatever reason).	2022-10-13 17:12:36 +09:00
Dean Herbert	a93c350ca8	Start settings panels without background visible	2022-10-13 17:11:56 +09:00
Dean Herbert	6608ada925	Fix test failures due to missing colour provider dependency	2022-10-13 17:05:11 +09:00
Dean Herbert	15f9697c9f	Roughly update design of editor buttons	2022-10-13 16:57:25 +09:00
Dean Herbert	4d99c7002b	Add background behind editor toolbox groups	2022-10-13 16:36:19 +09:00
Dean Herbert	0f4a2a6059	Improve feel of settings toolbox group	2022-10-13 16:36:19 +09:00
Dean Herbert	c3902728f6	Reorganise beatmap snap control to work better in compact mode	2022-10-13 15:47:54 +09:00
Dean Herbert	a525b3f9f8	Reorder and rename toggle checkboxes to fit better	2022-10-13 15:44:33 +09:00
Dean Herbert	f6f5d33f53	Add slight padding to playfield (roughly matches stable)	2022-10-13 15:44:23 +09:00
Dan Balasescu	338115ff6a	Move check to LegacyDifficultyControlPoint	2022-10-13 15:05:15 +09:00
Dan Balasescu	4149235e63	Limit minimum brightness of combo colours	2022-10-13 14:05:33 +09:00
Dean Herbert	ebc1088457	Merge pull request #20729 from frenzibyte/update-local-confirmation-dialog ... Request user confirmation on updating locally-modified beatmaps	2022-10-13 12:36:37 +09:00
Dean Herbert	c9b4cacc20	Merge pull request #20724 from mk56-spn/Highest_Combo_Counter ... Add "longest combo" counter to HUD components.	2022-10-13 12:26:49 +09:00
Dean Herbert	f573ee4521	Merge pull request #20512 from Feodor0090/comment-deletion ... Add ability to delete own comments	2022-10-13 12:13:08 +09:00
Dean Herbert	e240f659c2	Refactor visibility states to read better	2022-10-13 11:22:40 +09:00
Dan Balasescu	565e5586fd	Merge pull request #20725 from peppy/fix-beatmap-skin-fallbakcs ... Fix legacy fallbacks not working correctly for beatmap skins	2022-10-13 10:08:40 +09:00
Salman Ahmed	964ed01abb	Add confirmation dialog for updating locally modified beatmaps	2022-10-13 02:40:15 +03:00
Salman Ahmed	4fb156ef4e	Update xmlodc and add nullability attributes	2022-10-13 00:16:42 +03:00
Salman Ahmed	6199db11a2	Make OsuUserInputManager dependency nullable for tournament client	2022-10-12 17:55:32 +03:00
Salman Ahmed	7a6ecaff0d	Remove default invisible cursor container from rulesets	2022-10-12 17:50:47 +03:00
Salman Ahmed	a44cfe2901	Hide menu cursor when user is idle	2022-10-12 17:50:31 +03:00
Salman Ahmed	8305d886e6	Refactor internal visibility logic to route back to PopIn/PopOut	2022-10-12 17:50:04 +03:00
Dean Herbert	19f3810020	Revert namespace change ... Let's not	2022-10-12 18:50:47 +09:00
Dean Herbert	3da54814f8	Merge pull request #20641 from pfgithub/patch-fix-save-collections ... Preserve collections when saving a beatmap	2022-10-12 18:36:45 +09:00
sw1tchbl4d3	df0501235d	Introduce BpmMultiplierMania, remove after the fact clamps	2022-10-12 11:14:01 +02:00
Dean Herbert	8bf4ca4b53	Add legacy skin fallback when beatmap skin is providing resources	2022-10-12 17:47:20 +09:00
Dean Herbert	fd20515a6d	Don't throw if LegacySkin doesn't have a transformer encapsulating it ... This allows for more flexibility in lookups.	2022-10-12 17:29:17 +09:00
Dean Herbert	1c93551590	Remove completely incorrect check before applying ruleset transformer	2022-10-12 17:07:13 +09:00
Dan Balasescu	9473c350b5	Merge pull request #20266 from cdwcgt/catch-combo-hide ... Fade out CatchComboDisplay when hide HUD	2022-10-12 16:59:07 +09:00
Dan Balasescu	3ac3c33cc3	Merge pull request #20712 from peppy/reduce-import-transaction-scope ... Reduce the scope of realm transactions during import operations	2022-10-12 16:56:21 +09:00
Dario Headley	b72c8970eb	Max Combo Counter added	2022-10-12 09:50:01 +02:00
Dan Balasescu	300888b423	Merge pull request #20720 from peppy/fix-welcome-intro-delay ... Fix incorrect delay for non-theme music on "welcome" intro	2022-10-12 16:15:54 +09:00
Dean Herbert	e43c8e84b0	Use Show instead of Alpha=1	2022-10-12 15:48:42 +09:00
Dean Herbert	47fe4eb0bd	Merge branch 'master' into comment-deletion	2022-10-12 15:48:26 +09:00
Dean Herbert	5ce890cdb5	Merge pull request #20568 from Susko3/update-displays-in-setting ... Sync displays dropdown in settings with OS displays	2022-10-12 15:35:31 +09:00
Dean Herbert	d2d589a156	Expose HUD state via Player	2022-10-12 15:11:52 +09:00
Dean Herbert	1d6d047a69	Merge branch 'master' into master	2022-10-12 14:52:07 +09:00
Dean Herbert	d6998c810c	Fix incorrect delay for non-theme music on "welcome" intro	2022-10-12 14:51:14 +09:00
Dean Herbert	db148d145b	Fix incorrect offset logic for beatmaps without a preview point specified	2022-10-12 14:47:37 +09:00
Dean Herbert	721bfb5369	Rename parameter to read better	2022-10-12 14:46:35 +09:00
Dean Herbert	195ece02c6	Merge branch 'master' into update-displays-in-setting	2022-10-12 14:37:49 +09:00
Dean Herbert	ab24e87013	Merge branch 'master' into improve-drag-selection	2022-10-12 13:20:17 +09:00
Dean Herbert	b444f0fd0b	Merge pull request #20714 from frenzibyte/improve-flashlight-on-break ... Improve flashlight display on break periods	2022-10-12 13:10:12 +09:00
Dean Herbert	a5948e7680	Merge pull request #20704 from ekrctb/scrolling-drag-box ... Anchor editor drag box on time (catch, mania)	2022-10-12 11:48:05 +09:00
Salman Ahmed	84fdd2e107	Improve flashlight display on break periods	2022-10-11 17:16:57 +03:00
ekrctb	fcb9e2cc00	Refactor blueprint container drag code	2022-10-11 22:39:53 +09:00
Salman Ahmed	0a97ee71a9	Hide menu cursor when non-mouse input is applied	2022-10-11 16:23:51 +03:00
Salman Ahmed	60c92c8744	Enable NRT on MenuCursorContainer	2022-10-11 16:23:51 +03:00
Salman Ahmed	894127a948	Expose bindable for identifying last input source	2022-10-11 16:21:54 +03:00
Salman Ahmed	9b45a9cf76	Rename various cursor symbols ... - `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor` - `MenuCursor` -> `MenuCursorContainer	2022-10-11 16:21:01 +03:00
Dean Herbert	390ff8b9da	Reduce the scope of realm transactions during import operations	2022-10-11 21:58:28 +09:00
Dan Balasescu	cc0ca470f1	Merge pull request #20702 from peppy/update-prefer-no-video ... Fix beatmap update button not respecting user "prefer no video" setting	2022-10-11 19:36:14 +09:00
Daniel Källberg	63e651130a	Grouped localisation strings	2022-10-11 10:59:07 +02:00
Dan Balasescu	2ae41521eb	Merge pull request #20708 from peppy/mania-holding-sounds ... Implement hold "sliding" samples in osu!mania	2022-10-11 17:31:44 +09:00
Dan Balasescu	88e82d3154	Merge pull request #20681 from peppy/fix-hidden-hud-interaction ... Fix HUD components being interactive even when the HUD is visually hidden	2022-10-11 17:19:27 +09:00
NotGumballer91	d18466d740	Fix delay inconsistency in IntroCircles.cs	2022-10-11 16:16:57 +08:00
Dan Balasescu	6cdc9b2662	Merge pull request #20682 from peppy/fix-show-score-from-song-select ... Fix clicking a leaderboard score at song select transtiioning briefly to main menu	2022-10-11 17:16:16 +09:00
NotGumballer91	5baad52a9e	Fix unintended delay on osu!theme	2022-10-11 16:15:56 +08:00
Dan Balasescu	045eb884b5	Merge pull request #20683 from peppy/storyboard-handle-backwards-events ... Add support for weird storyboards which have backwards events	2022-10-11 17:12:22 +09:00
Dean Herbert	f41b79688f	Avoid casting by accepting all Playfields but throwing on a bad choice	2022-10-11 16:54:41 +09:00
Dean Herbert	f060e6a780	Implement hold "sliding" samples in osu!mania	2022-10-11 16:31:37 +09:00
Daniel Källberg	9c611019b3	Toolbar localisation	2022-10-11 09:30:32 +02:00
Dean Herbert	9bab02fab4	Remove unused using statement	2022-10-11 16:23:05 +09:00
Dean Herbert	eba3d37a11	Add xmldoc and simplify calling	2022-10-11 15:50:02 +09:00
Dean Herbert	6f6290a21a	Use async flow for storing key binding changes to realm	2022-10-11 15:37:22 +09:00
Dean Herbert	a44ba579c5	Fix beatmap update button not respecting user "prefer no video" setting ... Closes #20701.	2022-10-11 14:27:40 +09:00
ekrctb	6ab29a62d0	Anchor drag box on time (catch, mania) ... Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.	2022-10-11 14:23:17 +09:00
ekrctb	1a24762f9b	Improve drag box selection logic ... `AllowDeselectionDuringDrag` is remove. Instead, selected hit objects are not automatically deselected when clock is seeked to a later time (the hit object is dead). Update drag box selection even if mouse is not moved (in case clock is running or scroll wheel is used).	2022-10-11 14:11:45 +09:00
Dan Balasescu	ccab04d141	Merge pull request #20645 from frenzibyte/flag-markdown ... Add support for inline country flags in wiki overlay	2022-10-11 14:01:24 +09:00
Dean Herbert	cb21126623	Merge pull request #20586 from ekrctb/time-based-selection ... Use hit object time for timeline drag selection instead of relying on blueprint	2022-10-11 13:20:15 +09:00
pfg	e619c9c1e6	fix style	2022-10-10 21:48:41 -04:00
pfg	de8d485305	Move 'transferCollections' to a shared location	2022-10-10 21:45:33 -04:00
NotGumballer91	a883f44ea2	Merge branch 'master' into master	2022-10-11 02:11:21 +08:00
NotGumballer91	ef840e98cf	Update IntroCircles.cs	2022-10-11 01:49:53 +08:00
NotGumballer91	8a4f2efa14	Update IntroScreen.cs	2022-10-11 01:49:49 +08:00
NotGumballer91	3cd6ce8e3f	Update WorkingBeatmap.cs	2022-10-11 01:48:55 +08:00
Dean Herbert	3d58df2b61	Merge branch 'master' into flag-markdown	2022-10-11 01:58:43 +09:00
Dean Herbert	d700040a0d	Make country code parsing resilient to invalid cases	2022-10-11 01:39:53 +09:00
Dean Herbert	be5a413753	Update framework	2022-10-11 01:35:35 +09:00
Dean Herbert	5a43cb6bb2	Merge pull request #20606 from sw1tchbl4d3r/barline_generator_improvements ... Barline generator improvements	2022-10-11 01:31:30 +09:00
sw1tchbl4d3	5a4196fd51	Make currentEffectPoint non-nullable	2022-10-10 15:34:29 +02:00
NotGumballer91	9a3689b6e9	Update IntroCircles.cs	2022-10-10 21:04:14 +08:00
NotGumballer91	749dc40062	Update WorkingBeatmap.cs	2022-10-10 21:03:11 +08:00
NotGumballer91	e3b405cc23	Update IWorkingBeatmap.cs	2022-10-10 21:02:23 +08:00
sw1tchbl4d3	d389808427	Make effect point search more efficient	2022-10-10 14:00:26 +02:00
Dean Herbert	28185178d6	Add support for weird storyboards which have backwards events ... Closes https://github.com/ppy/osu/issues/20632. Not adding test coverage because this is just weird.	2022-10-10 16:51:55 +09:00
sw1tchbl4d3	eae32ca483	Switch DefinitelyBigger to AlmostBigger to account for fp errors	2022-10-10 09:39:40 +02:00
sw1tchbl4d3	f8036658c7	Move clamps directly to the usages in the conversion algorithm	2022-10-10 09:36:18 +02:00
Dean Herbert	e57819d687	Merge pull request #20665 from frenzibyte/fix-smoke-blocked-on-relax ... Fix smoke being blocked with "Relax" mod enabled	2022-10-10 16:36:03 +09:00
Dean Herbert	b783fdf667	Fix clicking a leaderboard score at song select transtiioning briefly to main menu ... - Regressed in #20567. - Closes #20651.	2022-10-10 16:20:18 +09:00
Dean Herbert	20adc522b9	Fix HUD components being interactive even when the HUD is visually hidden	2022-10-10 16:05:41 +09:00
Dean Herbert	26a473e85e	Update resources (fixes osu!mania flashlight crash)	2022-10-10 14:24:36 +09:00
D.Headley	5d2e3dcf4a	Remove leftover Enum	2022-10-09 22:52:54 +02:00
Salman Ahmed	2d4f390372	Remove non-smoke key bindings on "Relax" mod instead	2022-10-09 17:14:16 +03:00
sw1tchbl4d3	e0904e263f	Fix legacy BpmMultiplier clamp value	2022-10-09 11:25:47 +02:00
Salman Ahmed	a9aba74351	Add markdown country flag support	2022-10-08 21:50:25 +03:00
Salman Ahmed	098a56a784	Add custom container extension support	2022-10-08 21:25:11 +03:00
pfg	edec613724	Remove unnecessary '?'	2022-10-08 13:58:42 -04:00
pfg	ff14453c2b	Preserve collections when saving a beatmap	2022-10-08 12:42:29 -04:00
ansel	c384093802	Update main test and add failure scenario test	2022-10-08 18:53:41 +03:00
ansel	b697200460	Properly modify comment visual state on deletion	2022-10-08 18:41:08 +03:00
ansel	4e7c30504f	Schedule action buttons visibility changes	2022-10-08 17:15:10 +03:00
ansel	abf56c27a1	Do not requere dialog overlay	2022-10-08 17:11:09 +03:00
sw1tchbl4d3	63ffaa6929	Respect OmitFirstBarLine effect	2022-10-07 20:38:32 +02:00
sw1tchbl4d3	903c8612c8	Move endTime to next timing point	2022-10-07 20:34:31 +02:00
Dean Herbert	072b64b8d4	Update all dependencies	2022-10-07 21:16:11 +09:00
Dan Balasescu	c18d4afdcc	Merge branch 'master' into fix-leaderboard-first-place-fade	2022-10-07 19:55:16 +09:00
Dan Balasescu	0fb4ac4733	Merge pull request #20603 from peppy/bg-dim-reduce ... Adjust out-of-the-box background dim back down to 70%	2022-10-07 19:40:13 +09:00
Dan Balasescu	57e4d6cc4a	Merge pull request #20562 from peppy/fix-score-submission-crash ... Fix potential crash when score submission token retrival fails	2022-10-07 19:24:35 +09:00
Dean Herbert	a8742f0cc3	Adjust out-of-the-box background dim back down to 70% ... It was previously bumped from 60% to 80%, but I've recently felt that this is too high as a default, and takes away from storyboards and video backgrounds.	2022-10-07 18:47:32 +09:00
Dean Herbert	a543222a2b	Add ability to pad stage vertically	2022-10-07 15:45:35 +09:00
Dean Herbert	eea3d5adb8	Standardise column index naming and xmldoc	2022-10-07 15:24:36 +09:00
Dean Herbert	13e0a59f70	Add note about why LegacyManiaSkinConfigurationLookup exist	2022-10-07 15:24:36 +09:00
Dean Herbert	3947011baf	Fix regression in legacy dual stage handling logic	2022-10-07 15:24:36 +09:00
Dan Balasescu	bce20e0a59	Merge branch 'master' into adjust-flashlight	2022-10-07 14:45:30 +09:00
Dan Balasescu	7385ef3e1b	Extract combo scale to virtual function	2022-10-07 14:26:19 +09:00
Joseph Madamba	b27e70ca47	Fix language settings dropdown not updating when changing language in first run setup	2022-10-06 21:11:00 -07:00
ekrctb	6164e0896a	Don't reselect already selected items in SelectAll	2022-10-07 10:46:07 +09:00
Dean Herbert	4980e53c9c	Merge pull request #20376 from goodtrailer/smoke ... Add cursor "smoke" trails	2022-10-07 03:41:07 +09:00
ekrctb	9247ff3e0a	Allow changing scrolling speed in catch editor ... Scroll speed is not saved and doesn't affect gameplay. It is purely a feature for a better visualization. It is currently bind to scroll speed increase/decrease. Default F3/F4 crashes with editor shortcuts so it has to be changed.	2022-10-06 18:06:16 +09:00
ekrctb	29cc554632	Ensure blueprint is added for selected hit object	2022-10-06 13:59:54 +09:00
ekrctb	0d448e6cc8	Fix items without blueprints are not deselected	2022-10-06 13:50:56 +09:00
Dean Herbert	e9ab465da6	Merge branch 'master' into localisation-settings	2022-10-06 13:22:08 +09:00
ekrctb	b0213c29e9	Use mid time instead of start time ... It is closer to the old blueprint-based behavior	2022-10-05 22:19:22 +09:00
ekrctb	6753f6b01a	Move AllowDeselectionDuringDrag down ... Because it is now ignored in the timeline implementation anyways	2022-10-05 22:14:11 +09:00
ekrctb	3108c42ece	Fix inspect issues	2022-10-05 22:04:43 +09:00
ekrctb	00b3d97f69	Improve timeline selection performance ... But selecting a large number of hit objects is still very slow because all DHOs must be added and also `AddBlueprintFor` has quadratic behaviors	2022-10-05 21:58:05 +09:00
ekrctb	0613388aaa	Make sure all selected items get deleted	2022-10-05 21:58:05 +09:00
ekrctb	0ffde02f79	Use hit object time for timeline selection	2022-10-05 21:51:01 +09:00
ekrctb	8d29e9e76b	Move selection logic from DragBox to BlueprintContainer	2022-10-05 21:51:01 +09:00
Dan Balasescu	35d04fe33c	Merge pull request #20582 from peppy/fix-being-playing-unobserved ... Silence unobserved exceptions in `BeginPlayingInternal`	2022-10-05 20:51:55 +09:00
Dan Balasescu	c52ddb0e50	Merge pull request #20570 from ekrctb/scrolling-lifetime ... Compute lifetime start from entry for scrolling hit objects	2022-10-05 20:45:43 +09:00
Dean Herbert	365a78d358	Merge branch 'master' into smoke	2022-10-05 18:58:18 +09:00
Dean Herbert	64858cfb8e	Update resources	2022-10-05 18:55:49 +09:00
Dean Herbert	4f084664ac	Merge branch 'master' into comment-deletion	2022-10-05 14:34:50 +09:00
Dean Herbert	74db42394a	Silence unobserved exceptions in BeginPlayingInternal ... Closes #20526.	2022-10-05 14:31:13 +09:00
Dean Herbert	276021dd85	Remove now unnecessary ScheduleAfterChildren	2022-10-05 14:20:01 +09:00
Dean Herbert	e06ece7531	Update framework	2022-10-05 14:19:51 +09:00
Dean Herbert	c7d645b086	Merge branch 'master' into fix-gameplay-leaderboard-overlap	2022-10-05 14:15:50 +09:00
Dan Balasescu	d9c3f5834c	Merge pull request #20567 from peppy/fix-show-replay-crash ... Fix potential crash when attempting to display an imported score at song select	2022-10-04 19:46:15 +09:00
Dean Herbert	75b9bf2cf9	Merge branch 'master' into intel-exclusive-warning	2022-10-04 19:02:01 +09:00
Dan Balasescu	7293ad751e	Update packages	2022-10-04 18:59:35 +09:00
Dan Balasescu	41082ab928	Fix misplaced parenthesis	2022-10-04 18:21:29 +09:00
ekrctb	1cccd03480	Fix scrolling nested hit object lifetime not set	2022-10-04 15:17:14 +09:00
ekrctb	781f5420b0	Add test for scrolling hit object lifetime	2022-10-04 15:17:11 +09:00
ekrctb	5d80950eaf	Compute lifetime from entry in scrolling container	2022-10-04 15:12:28 +09:00
Susko3	efc9bed4f0	Use IWindow.DisplaysChanged to update displays	2022-10-03 23:52:04 +02:00
Susko3	31fefc1ee2	Add nullable annotation to LayoutSettings	2022-10-03 23:23:02 +02:00
Susko3	e98b4b4fbd	Make updateDisplayModeDropdowns regular method	2022-10-03 23:14:21 +02:00
Dean Herbert	0bac5ef465	Merge branch 'master' into smoke	2022-10-03 21:29:42 +09:00
Dean Herbert	dfb143ec0b	Update resources	2022-10-03 21:14:57 +09:00
Dean Herbert	332d63b53b	Always return to main menu before attempting to present a score from import	2022-10-03 20:29:44 +09:00
Dean Herbert	13ee5c179e	Add missing parenthesis in log message	2022-10-03 18:42:40 +09:00
Dan Balasescu	deae7cff60	Adjust flashliht scaling to match classic	2022-10-03 18:38:29 +09:00
Dan Balasescu	0df217d85c	Add ability to adjust flashlight smoothness	2022-10-03 18:24:56 +09:00
Dean Herbert	d9f678d942	Change song select random key binding to not handle key repeat	2022-10-03 18:16:54 +09:00
Dean Herbert	42aac16b37	Adjust leaderboard score panels sizing based on accuracy/combo width	2022-10-03 18:12:36 +09:00
Dean Herbert	65369e96eb	Ensure token retrieval failure logic only runs once	2022-10-03 17:29:46 +09:00
Dean Herbert	c4dd23ed15	Log token retrieval failures even when gameplay is allowed to continue	2022-10-03 17:29:34 +09:00
Dean Herbert	4dbac917fc	Merge pull request #20547 from nanashi-1/solo-gameplay-leaderboard-max-combo ... Display highest combo rather than current combo for local play on leaderboard	2022-10-03 16:57:05 +09:00
Salman Ahmed	a810afafb3	Reschedule results display delegate to avoid potential softlocks in the future	2022-10-02 15:37:56 +03:00
Salman Ahmed	59728b0ccb	Fix results display delegate potentially cancelled while not exiting	2022-10-02 15:30:06 +03:00
nanashi-1	2493468800	display highest combo instead of current combo	2022-10-02 18:40:31 +08:00
ansel	85adfc2df7	Fix DI type	2022-09-28 18:26:36 +03:00
ansel	7645fe20f5	Merge branch 'master' into comment-deletion	2022-09-28 17:55:22 +03:00
ansel	636befb499	Add visual feedback for deleting process	2022-09-28 17:49:37 +03:00
Dan Balasescu	f318452510	Merge pull request #20503 from peppy/change-default-skin ... Change default skin for new installations to "Argon"	2022-09-28 18:34:40 +09:00
Dean Herbert	4ee435507d	Update framework	2022-09-28 17:58:47 +09:00
Dean Herbert	cbbca616c1	Merge branch 'master' into fix-leaderboard-first-place-fade	2022-09-28 17:58:45 +09:00
Dan Balasescu	1890a66b28	Merge pull request #20509 from o-dasher/cleanup-setting-sources ... Removes unnecessary setting sources specifications	2022-09-28 17:55:42 +09:00
Dan Balasescu	cbed268ac9	Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements ... Clamp `LifetimeStart` of `HitObject`s to their judgement windows	2022-09-28 17:49:35 +09:00
Dean Herbert	baa9e0441f	Merge pull request #20428 from frenzibyte/fix-update-progress-notification ... Fix update progress notification not closing on completion	2022-09-28 17:43:45 +09:00
Dean Herbert	9b3778f226	Merge pull request #20507 from smoogipoo/fix-multiplayer-tests ... Fix failing multiplayer tests	2022-09-28 17:41:55 +09:00
Dan Balasescu	715b1f64f3	Merge pull request #20518 from peppy/fix-leaderboard-wobble ... Fix leaderboard wobble when in first place	2022-09-28 17:03:31 +09:00
Dean Herbert	cdcc8494c9	Fix fade being applied for too long when leaderboard scrolls to start	2022-09-28 16:10:19 +09:00
Dean Herbert	c8643ed265	Set ClampExtension to zero to stop jittering	2022-09-28 15:58:00 +09:00
Dean Herbert	8edb1cb98a	Add test coverage of current score staying on screen	2022-09-28 15:57:50 +09:00
ansel	ae0d62838b	Move API and DO to fields	2022-09-27 22:46:23 +03:00
ansel	58d9509ce6	Apply NRT to Comment	2022-09-27 22:45:05 +03:00
ansel	5282c8b8c6	Fix CQ	2022-09-27 19:40:18 +03:00
ansel	5da7cb5397	Make comment ID public for test	2022-09-27 19:02:18 +03:00
ansel	60ee813e45	Implement delete button	2022-09-27 18:33:16 +03:00
ansel	31a7ba3f91	Add delete button	2022-09-27 18:23:15 +03:00
sw1tchbl4d3	0cffbb7562	Clamp LifetimeStart of HitObject's to their judgement windows	2022-09-27 16:54:24 +02:00
o-dasher	f3e25eacad	Removes unnecessary setting sources specifications	2022-09-27 09:25:58 -04:00
ansel	1721b8e47a	Add request class	2022-09-27 16:25:26 +03:00
Dan Balasescu	a0d05f5bb7	Merge pull request #20501 from peppy/fix-editor-initial-performance ... Fix editor performance being sub-par on beatmap load	2022-09-27 21:34:04 +09:00
Dan Balasescu	1811647e34	Make room requests handler handle GetBeatmapRequest	2022-09-27 20:30:41 +09:00
Dan Balasescu	da8d94c4b4	Fix test failures due to scheduled operations	2022-09-27 20:24:44 +09:00
Dean Herbert	58217b6839	Fix weird conditional	2022-09-27 20:09:21 +09:00
Dan Balasescu	8642ed7631	Merge pull request #20504 from peppy/fix-playlist-connectivity-crash ... Fix potential crash when losing network connectivity in multiplayer/playlists screens	2022-09-27 18:36:24 +09:00
Dan Balasescu	ec30050f2c	Merge pull request #20502 from peppy/forward-toasts-on-gameplay ... Flush toast tray on entering gameplay	2022-09-27 18:35:54 +09:00
Dan Balasescu	5a28174448	Merge pull request #20488 from nanashi-1/toggle-score-overlay ... Add toggle for solo gameplay leaderboard	2022-09-27 18:09:55 +09:00
Dean Herbert	3ece7205ed	Fix potential crash when losing network connectivity at online play screen ... Addresses #20448.	2022-09-27 17:52:34 +09:00
Dean Herbert	8b722f8817	Change default skin for new installations to "Argon" ... Closes #20459.	2022-09-27 17:41:56 +09:00
Dean Herbert	461ba64bfa	Flush toast tray on entering a no-notification section	2022-09-27 17:32:53 +09:00
Dean Herbert	c61f5403ab	Increase delay back slightly on notifications posting after disabled period	2022-09-27 17:32:30 +09:00
Dean Herbert	0296685c74	Start key counter / gameplay leaderboard hidden to avoid initial fade out	2022-09-27 17:25:24 +09:00
Dean Herbert	a9088d9231	Add assert/log output when too many ticks are being displayed	2022-09-27 17:18:46 +09:00
Dean Herbert	e227519b09	Don't attempt to render timeline ticks until DrawWidth is above zero	2022-09-27 17:18:46 +09:00
Dean Herbert	ccae721af2	Ensure ZoomableScrollContainer content isn't shown until zoom is set	2022-09-27 17:07:11 +09:00
Dean Herbert	9dc0eb7fd0	Remove unused static	2022-09-27 17:04:56 +09:00
Dean Herbert	320f134634	Use same logic as KeyCounterDisplay	2022-09-27 15:01:18 +09:00
Dean Herbert	bac3108aea	Remove unnecessary keywords	2022-09-27 14:29:59 +09:00
Dan Balasescu	aa3956cfbb	Merge pull request #20495 from Feodor0090/playlist-overflow-fix ... Fix playlist overlay overflowing at high UI scales	2022-09-27 13:53:14 +09:00
Dean Herbert	de6709d12c	Fix rank_history serialisation order dependence ... ```csharp [network] 2022-09-26 18:18:39 [verbose]: Processing response from https://dev.ppy.sh/api/v2/me/ failed with Newtonsoft.Json.JsonSerializationException: Error setting value to 'rankHistory' on 'osu.Game.Online.API.Requests.Responses.APIUser'. [network] 2022-09-26 18:18:39 [verbose]: ---> System.NullReferenceException: Object reference not set to an instance of an object. [network] 2022-09-26 18:18:39 [verbose]: at osu.Game.Online.API.Requests.Responses.APIUser.set_rankHistory(APIRankHistory value) in /tmp/osu/osu.Game/Online/API/Requests/Responses/APIUser.cs:line 231 ```	2022-09-27 12:46:17 +09:00
Salman Ahmed	8aff856c79	Fix SkinnableTestScene sizing logic potentially failing to work	2022-09-27 05:18:17 +03:00
nanashi-1	5d18001d75	move config	2022-09-26 21:11:38 +08:00
nanashi-1	4295d9c169	revert	2022-09-26 21:11:14 +08:00
nanashi-1	ee4d1b2d58	add config visibility	2022-09-26 20:13:07 +08:00
nanashi-1	dc051a8b79	add gameplay leaderboard config	2022-09-26 20:08:58 +08:00
nanashi-1	bed25ff60e	add gameplay leaderboard config string	2022-09-26 20:08:26 +08:00
nanashi-1	f81107eb5a	add gameplay leaderboard config	2022-09-26 20:07:43 +08:00
Dan Balasescu	836da6a5e6	Merge pull request #20485 from peppy/leaderboard-nrt ... Apply NRT to leaderboard hierarchy	2022-09-26 18:53:37 +09:00
Dan Balasescu	e5894ccd6f	Merge pull request #20478 from peppy/fix-progress-notification-fling ... Fix progress notifications being able to be flung (and cancelled)	2022-09-26 18:21:12 +09:00
Dan Balasescu	f2eed881bd	Merge pull request #20480 from peppy/fix-drawable-mutation-tablet-settings ... Fix potential crash from incorrect drawable mutation in tablet settings display	2022-09-26 18:16:52 +09:00
Dan Balasescu	525de8c140	Merge pull request #20479 from peppy/fix-drawable-mutation-misc ... Fix potential crash on game exit due to incorrect scheduling of realm change handler	2022-09-26 18:02:28 +09:00
Dan Balasescu	987294f294	Merge pull request #20483 from peppy/music-controller-thread-safety ... Move `MusicController` binds to `LoadComplete` for added thread safety	2022-09-26 17:59:02 +09:00
Dan Balasescu	c969afcb71	Merge branch 'master' into leaderboard-nrt	2022-09-26 17:12:19 +09:00
Dan Balasescu	28470bd5c0	Merge pull request #20486 from peppy/gameplay-leaderboard-nrt ... Apply NRT to `GameplayLeaderboard` hierarchy	2022-09-26 17:11:51 +09:00
Dan Balasescu	426ab176d6	Merge pull request #20418 from peppy/fix-leaderboard-crash ... Fix intermittent leaderboard crash due to request finishing after drawable is disposed	2022-09-26 17:10:32 +09:00
Dean Herbert	20da1051d9	Apply NRT to GameplayLeaderboard hierarchy ... Just some cleanup work that I wanted to do as part of my last changes.	2022-09-26 16:21:24 +09:00
Dean Herbert	5fc836d1f0	Apply NRT to BeatmapLeaderboard / MatchLeaderboard	2022-09-26 16:17:28 +09:00
Dean Herbert	a1297af441	Apply NRT to base Leaderboard classes	2022-09-26 16:12:47 +09:00
Dean Herbert	32d56fe3a9	Use request cancellation and IsDisposed guard instead of more Schedule	2022-09-26 16:02:33 +09:00
Dean Herbert	4e9b25d8b0	Move MusicController binds to LoadComplete for added thread safety	2022-09-26 15:42:37 +09:00
Dean Herbert	43c16cb613	Fix potential crash from incorrect drawable mutation in tablet settings display	2022-09-26 15:10:02 +09:00
Dean Herbert	c4887269f7	Avoid performing a realm write if there are no changes pending in RulesetConfigManager	2022-09-26 14:55:23 +09:00
Dean Herbert	4bd96108c0	Fix crash on game exit due to incorrect scheduling of realm change handler	2022-09-26 14:45:17 +09:00
Dean Herbert	b6dd8168d2	Fix progress notifications being able to be flung	2022-09-26 14:33:12 +09:00
o-dasher	feadac1f79	Cleanup all other leftover binding instantiation	2022-09-25 16:02:40 -04:00
o-dasher	537796c3a1	Cleanup mod bindings	2022-09-25 15:49:22 -04:00
ansel	5d0b2d34c9	Make playlist to always be in screen bounds	2022-09-24 23:35:06 +03:00
ansel	6c8e587344	Move margin value to constant	2022-09-24 21:52:16 +03:00
Salman Ahmed	ddbbd594c6	Merge branch 'master' into fix-main-menu-storyboard-crash	2022-09-23 18:56:17 +03:00
Salman Ahmed	835cae3087	Remove null conditional	2022-09-23 17:06:55 +03:00
Salman Ahmed	cdc3afac88	Fix update progress notification not closing on completion	2022-09-23 16:30:07 +03:00
Dean Herbert	0fa5e1b28e	Fix intermittent leaderboard crash due to request finishing after drawable is disposed	2022-09-23 20:18:44 +09:00
Dean Herbert	4e9053b099	Fix crash when storyboard attempts to play at main menu	2022-09-23 20:10:57 +09:00
Dean Herbert	a65a76f7de	Fix off-thread drawable mutation in multiplayer settings overlay when an error occurs ... Closes #20413.	2022-09-23 20:05:32 +09:00
Dean Herbert	8a7526aaa3	Merge pull request #20344 from frenzibyte/better-tablet-notifications ... Improve tablet error/warning notifications messaging	2022-09-22 22:45:27 +09:00
Dan Balasescu	61a41d9533	Merge pull request #20402 from peppy/argon-combo-colours ... Add argon combo colours	2022-09-22 21:33:20 +09:00
Dan Balasescu	1d1012e196	Merge pull request #20286 from peppy/gameplay-leaderboards ... Add basic gameplay leaderboard display	2022-09-22 21:16:12 +09:00
Dan Balasescu	6a0047b7a2	Update location of FullscreenCapability bindable	2022-09-22 21:01:23 +09:00
Dan Balasescu	445e026a32	Merge pull request #20389 from peppy/fix-gameplay-leaderboard-layout ... Fix gameplay leaderboard sometimes not showing up	2022-09-22 20:51:54 +09:00
Dean Herbert	37e2579244	Fix reversed checks	2022-09-22 20:35:26 +09:00
Dan Balasescu	5dbe73ad0e	Merge pull request #20398 from peppy/fix-missing-notelock-shake ... Fix "note lock" shake not always animating	2022-09-22 20:07:38 +09:00
Dan Balasescu	7508592789	Clean up some checks	2022-09-22 19:56:24 +09:00
Dean Herbert	8f7a306d81	Inline comment regarding margin necessity	2022-09-22 19:53:16 +09:00
Dean Herbert	5243ff3c22	Add argon combo colours ... I'm 99% sure these are just test colours flyte was using, but they look good so let's go with them. I've added two new colours to increase the default combo colour rotation to 6. The initial ordering still matches, for whatever that's worth.	2022-09-22 19:49:32 +09:00
Salman Ahmed	fd92bcdff2	Ignore case sensitivity during message comparison ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2022-09-22 13:21:27 +03:00
Salman Ahmed	794a131954	Update method name and conditions	2022-09-22 13:17:01 +03:00
Dean Herbert	74aefdc5bd	Move basic transformer behaviour to base abstract class	2022-09-22 18:53:43 +09:00
Dean Herbert	ea7c5458fe	Fix sprite dropdown not showing resources from non-legacy skins during gameplay	2022-09-22 18:53:43 +09:00
Salman Ahmed	fa3f53f39f	Remove tablet prefix from error notification	2022-09-22 12:37:24 +03:00
Dean Herbert	b321afc3a6	Update framework	2022-09-22 18:04:31 +09:00
Dean Herbert	2bc6b4e84f	Merge branch 'master' into Colour_hit_meter_improved	2022-09-22 15:52:06 +09:00
Dean Herbert	f0dcda9acc	Decrease precision of spacing setting	2022-09-22 15:49:02 +09:00
Dean Herbert	26d98323ff	Fix bindable flow, code quality, everything	2022-09-22 15:45:23 +09:00
Dean Herbert	0f663deda0	Fix changing shape causing alpha to be permanently reset to zero	2022-09-22 15:24:57 +09:00
Dean Herbert	ae70b2c32f	Fix other weirdness in variable and description naming	2022-09-22 15:21:27 +09:00
Dean Herbert	19db7c5977	Remove "Opacity" setting ... This should be implemented at a higher level	2022-09-22 15:19:01 +09:00
Dean Herbert	f3898da37a	Rename judgement count to not mention "shape"	2022-09-22 15:18:20 +09:00
Dan Balasescu	729322c505	Merge pull request #20396 from peppy/files-folder-notice ... Add warning message in `files` folder to avoid accidental deletion	2022-09-22 15:18:18 +09:00
Dean Herbert	7d93fa9f65	Merge branch 'master' into Colour_hit_meter_improved	2022-09-22 15:11:58 +09:00
Dan Balasescu	70bab81282	Merge pull request #20377 from peppy/argon-skin ... Add new default "argon" skin	2022-09-22 14:50:43 +09:00
Dean Herbert	78625fda7d	Improve exception when attempting to call DrawableHitObject.ClearInternal	2022-09-22 14:44:03 +09:00
Dean Herbert	db21601632	Add warning message in files folder to avoid accidental deletion ... This is a pretty standard practice for applications that have data stored in folders where a user may accidentally determine that the content is unnecessary. Aims to address cases like https://github.com/ppy/osu/discussions/20394#discussioncomment-3705694. It's not the first time this has come up, and definitely won't be the last.	2022-09-22 13:17:24 +09:00
Dan Balasescu	2b8b138079	Add "keybindings" search term to settings	2022-09-21 18:46:28 +09:00
Dean Herbert	992441b9de	Disable alpha component parsing in beatmap / skin colour sections	2022-09-21 16:11:41 +09:00
Dean Herbert	5b73f24864	Fix outdated scores being held by BeatmapLeaderboard after external beatmap switch	2022-09-21 15:21:32 +09:00
Dean Herbert	29c4d06d36	Merge branch 'fix-gameplay-leaderboard-layout' into gameplay-leaderboards	2022-09-21 14:58:58 +09:00
Dean Herbert	b04871f40a	Animate scroll for a better visual experience	2022-09-21 14:51:12 +09:00
Dean Herbert	087ca59ebb	Add extra margin space to flow equal to height of leaderboard ... This ensures the content is always on screen, but also accounts for the fact that scroll operations without animation were actually forcing the local score to a location it can't usually reside at. Basically, the local score was in the scroll extension region (due to always trying to scroll the local player to the middle of the display, but there being no other content below the local player to scroll up by).	2022-09-21 14:51:12 +09:00
Dean Herbert	4385001d28	Fix solo leaderboard seeing imported score via realm subscription flow	2022-09-21 13:59:11 +09:00
Dean Herbert	a8338c4efd	Add local score after existing scores to avoid initial re-sort	2022-09-21 13:38:40 +09:00
Dean Herbert	4492a26b59	Merge branch 'master' into argon-skin	2022-09-21 13:00:16 +09:00
Dan Balasescu	8bf196d561	Merge pull request #20354 from peppy/default-skin-refactor ... Rename default skin to make way for new version	2022-09-21 11:48:38 +09:00
Salman Ahmed	dcfb6a2f06	Fix progress notifications no longer blocking close on click	2022-09-21 00:15:50 +03:00
Salman Ahmed	b8f2e13503	Avoid catching all exceptions raising from skin instance creation	2022-09-20 22:27:27 +03:00
Dean Herbert	8837618ab1	Merge pull request #20342 from smoogipoo/server-shutdown-countdown ... Implement server shutdown countdown + notification	2022-09-20 20:51:16 +09:00
Dan Balasescu	d777afc454	Remove countdown at under 5 seconds	2022-09-20 19:55:44 +09:00
Dan Balasescu	7f15dc6e6c	Merge pull request #20321 from HiddenNode/fix_graph_info_overlap ... Fix Progress bar info text overlapping with progress graph	2022-09-20 19:30:51 +09:00
Dean Herbert	e0f1f1a5e1	Update resources	2022-09-20 17:20:47 +09:00
Dan Balasescu	80d8eedb7c	Merge pull request #20366 from peppy/fix-nullable-download-progress ... Fix multiplayer crashes due to incorrect download state	2022-09-20 17:16:11 +09:00
Dean Herbert	68c040175a	Ensure Leaderboard.Scores is updated immediately via request flow	2022-09-20 17:02:57 +09:00
Dan Balasescu	2499493347	Merge pull request #20375 from peppy/fix-score-reference-leak ... Fix mods potentially keeping reference to runtime gameplay elements	2022-09-20 16:26:31 +09:00
Dan Balasescu	b84f716c22	Display seconds when hours>0 to be more lively	2022-09-20 16:02:31 +09:00
Dan Balasescu	ef29987f36	Remove FinalNotification	2022-09-20 15:54:18 +09:00
Dan Balasescu	700000b583	Use custom notification with timer	2022-09-20 15:54:18 +09:00
アズタケ	d22d009fb3	fix review points. items not included in this localization were reverted.	2022-09-20 14:02:11 +09:00
Dean Herbert	b5771ece41	Reduce the amount by which clicking the mute notification incraeses volume	2022-09-20 13:00:08 +09:00
Dean Herbert	a9c120c214	Reduce volume requirement for showing muted notification to 1%	2022-09-20 12:46:35 +09:00
Alden Wu	74056201e7	Return smoke key to key overlay	2022-09-19 09:15:59 -07:00
Alden Wu	0316e3e706	Merge branch 'master' of https://github.com/ppy/osu into smoke	2022-09-19 09:07:17 -07:00
Dean Herbert	1c02fa8399	Update comment to not mention horizontal plane	2022-09-20 00:08:06 +09:00
Dean Herbert	46db3ad96d	Move implementation to individual classes	2022-09-20 00:06:02 +09:00
Dean Herbert	03cc6b8af3	Fix parameter name	2022-09-19 23:44:03 +09:00
Dean Herbert	bd28c6f96d	Merge branch 'master' into localisation-settings	2022-09-19 23:37:26 +09:00
Dean Herbert	b55aa68177	Remove xmldoc on private fields	2022-09-19 23:16:46 +09:00
Dean Herbert	0f7b38f4c3	Add new default skin "argon"	2022-09-19 23:16:46 +09:00
Dean Herbert	cbb4845fa6	Merge pull request #20358 from o-dasher/simplify-flashlight ... Fix flashlight shrinking at >100x rather than starting from 100x	2022-09-19 22:03:34 +09:00
Dean Herbert	494790294a	Update SkinnableTestScene to show new default skin	2022-09-19 12:38:34 +09:00
Dean Herbert	0a625bd879	Fix mods potentially keeping reference to runtime gameplay elements ... As noticed by smoogipoo during multiplayer match on the weekend.	2022-09-19 12:18:46 +09:00
Dean Herbert	454125123d	Add failing test coverage showing mod reference leak path	2022-09-19 12:18:35 +09:00
Alden Wu	6852577dad	Remove smoke from key overlay	2022-09-18 19:08:01 -07:00
Alden Wu	06178104c8	Show smoke in replays	2022-09-18 17:55:06 -07:00
Salman Ahmed	a413c7a3e6	Merge branch 'master' into fix-notification-count	2022-09-19 02:08:20 +03:00
O Thiago	a4e9c7711c	Fix when flashlight shrinking takes place	2022-09-18 18:59:17 -04:00
O Thiago	407b104116	Revert changes ... This reverts commit beef3b418a. Revert "Use linq expression for handling breaks" This reverts commit 8464a1941b. Revert "renames variables to make more logical sense" This reverts commit 3b87ecf56c. Revert "Removes overhead when not combo based size" This reverts commit ac4229e3d4.	2022-09-18 18:57:53 -04:00
Dean Herbert	0ac28cbecc	Fix potential crash from missing DownloadProgress	2022-09-18 23:42:16 +09:00
Dean Herbert	6a06a5b1b5	Reword fallback instantiation handling comment to hopefully explain things better	2022-09-18 18:20:28 +09:00
Dean Herbert	d0b8409de5	Apply more renames	2022-09-18 18:19:00 +09:00
Dean Herbert	1914c41d0d	Merge pull request #20353 from Drison64/fix-timelineZoom-zero ... EditorBeatmap's TimelineZoom should never be zero	2022-09-18 18:06:26 +09:00
Dan Balasescu	2dcaf7cfd8	Fix memory leak due to missing event unbind	2022-09-18 14:25:31 +09:00
O Thiago	ac4229e3d4	Removes overhead when not combo based size	2022-09-18 00:38:01 -04:00
O Thiago	3b87ecf56c	renames variables to make more logical sense	2022-09-18 00:19:40 -04:00
O Thiago	8464a1941b	Use linq expression for handling breaks	2022-09-17 23:49:23 -04:00
O Thiago	beef3b418a	Simplifies size calculation	2022-09-17 23:41:23 -04:00
Drison64	c075d3de08	Create a test and a check if initial zoom value of ZoomableScrollContainer is in range	2022-09-17 22:43:40 +02:00
Ondřej Vajďák	9d94343317	Update osu.Game/Screens/Edit/Compose/Components/Timeline/Timeline.cs ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-09-17 19:51:44 +02:00
Drison64	c8768eb399	Changed == to <= on TimelineZoom check	2022-09-17 19:00:50 +02:00
Drison64	88e6ce575a	Merge branch 'fix-timelineZoom-zero' of https://github.com/Drison64/osu into fix-timelineZoom-zero	2022-09-17 18:57:36 +02:00
Drison64	3c7ea5c8fa	Update	2022-09-17 18:57:09 +02:00
Salman Ahmed	9a10ecb378	Clarify purpose of APIUserScoreAggregate	2022-09-17 19:37:30 +03:00
Dean Herbert	41e69fbca6	Remove "default" prefix from naming	2022-09-18 00:15:26 +09:00
Dean Herbert	1c4e02fae8	Explicitly order default skins in dropdown to get correct order	2022-09-18 00:12:43 +09:00
Dean Herbert	1b475f9360	Ensure skin InstantiationInfo is updated when saving	2022-09-18 00:12:43 +09:00
Dean Herbert	64ee210825	Add realm migration to update skin names	2022-09-18 00:12:43 +09:00
Dean Herbert	487378f732	Fallback to default skin if instantiation fails	2022-09-17 23:57:25 +09:00
Dean Herbert	3e28ab72ce	Standardise default skin names	2022-09-17 23:57:25 +09:00
Dean Herbert	51841988bf	Rename references to DefaultSkin to have Triangles suffix	2022-09-17 23:57:25 +09:00
Ondřej Vajďák	448485a56b	Merge branch 'master' into fix-timelineZoom-zero	2022-09-17 16:24:18 +02:00
HiddenNode	2dfa89c62e	Clean up	2022-09-17 15:05:25 +01:00
Drison64	0b6a77bc8b	EditorBeatmap's TimelineZoom should never be zero	2022-09-17 15:59:42 +02:00
HiddenNode	d580b07063	Refactor update condition logic	2022-09-17 14:40:36 +01:00
Dean Herbert	a1d830e47f	Fix formatting	2022-09-17 22:22:56 +09:00
vegguid	0bfe967452	moved BindValueChanged to LoadComplete	2022-09-17 12:58:23 +02:00
HiddenNode	e3d5ba5301	Check if graph DrawSize changed	2022-09-17 11:44:25 +01:00
HiddenNode	0d76f4501d	Revert "Set InvalidationSource to Self" ... This reverts commit 2092008251.	2022-09-17 10:10:20 +01:00
Salman Ahmed	48527f2d07	Ignore case during logger name comparison	2022-09-16 22:50:49 +03:00
vegguid	288cc7b201	Fixed Leaderboard tooltip not following time format setting	2022-09-16 21:36:17 +02:00
Salman Ahmed	110652592f	Display readable tablet notifications and link to supported list page	2022-09-16 16:32:06 +03:00
Salman Ahmed	877165eb98	Allow specifying icon colour on simple notifications	2022-09-16 16:21:43 +03:00
Dan Balasescu	92b2417d4c	Post notification when room joined	2022-09-16 21:10:11 +09:00
アズタケ	81d582c051	fix review points and fine tuning	2022-09-16 21:08:25 +09:00
Dan Balasescu	e95983cdb4	Merge branch 'master' into fix-skin-flow	2022-09-16 20:15:51 +09:00
Dan Balasescu	433bb5ae24	Add ServerShuttingDownCountdown	2022-09-16 19:56:52 +09:00
Dean Herbert	85bb6f0beb	Update framework ... Update framework (again) Update framework	2022-09-16 19:35:34 +09:00
アズタケ	3a62d29269	fix tab spacing	2022-09-16 18:43:59 +09:00
アズタケ	b99b10e586	fix code style problem	2022-09-16 18:34:13 +09:00
アズタケ	c0e2ba419e	Localize non-localizable setting items	2022-09-16 18:31:02 +09:00
Dean Herbert	4c4fdfd153	Provide scores directly to Player instance rather than relying on DI	2022-09-16 18:15:17 +09:00
Dean Herbert	38d8d457d9	Add back second completion post attempt for case when notification overlay isn't loaded yet	2022-09-16 17:54:44 +09:00
Dean Herbert	0d24fda4b9	Fire Notification.Closed immediately to ensure off-screen notifications are closed	2022-09-16 16:36:56 +09:00
Dean Herbert	0227eddda1	Merge branch 'master' into gameplay-leaderboards	2022-09-16 15:44:58 +09:00
Dan Balasescu	cbf55732da	Merge pull request #20337 from peppy/catch-unobserved-network-exceptions ... Catch any unobserved exceptions during beatmap metadata harvesting	2022-09-16 14:37:08 +09:00
Dean Herbert	21ac3fd88b	Catch any unobserved exceptions during beatmap metadata harvesting ... The process will retry when a connection is successful, so this doesn't need to be as loud as it was. Addresses https://github.com/ppy/osu/discussions/20331.	2022-09-16 14:00:06 +09:00
Dean Herbert	4486fa2546	Merge pull request #20334 from Drison64/fix-scorePanel-timeFormat ... Make score panel timestamp adjust to 24-hour time setting	2022-09-16 13:40:34 +09:00
Dan Balasescu	d9499abc33	Refactor to avoid passing around bindables	2022-09-16 13:14:25 +09:00
Dan Balasescu	fcba917419	Merge pull request #20320 from peppy/skin-transformers ... Allow skin transformers to be created for all skins	2022-09-16 12:58:46 +09:00
Dan Balasescu	49d2c84646	Merge pull request #19991 from Feodor0090/mods-effect-displays ... Move `DifficultyMultiplierDisplay`'s layout and colour logic to a base class	2022-09-16 10:30:30 +09:00
Drison64	4f208416be	Fixed irresponsiveness of score panel timestamp to time format	2022-09-16 13:50:18 +14:00
Dean Herbert	db822696ed	Use latest version of sqlite3 bundle	2022-09-16 01:02:46 +09:00
Dean Herbert	5ce67345ae	Catch against sqlite initialisation failures	2022-09-16 01:02:38 +09:00
Dan Balasescu	f86bbaae30	Merge branch 'master' into mods-effect-displays	2022-09-15 21:17:58 +09:00
Dean Herbert	c7f8f948b9	Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins	2022-09-15 20:18:10 +09:00
HiddenNode	2092008251	Set InvalidationSource to Self	2022-09-15 11:16:00 +01:00
Dan Balasescu	96a89f4fca	Merge pull request #20319 from peppy/remove-ef-migration ... Remove all entity framework code and migrations	2022-09-15 19:15:23 +09:00
HiddenNode	8286ab0d04	Revert "Fix SongProgress invalidating too often" ... This reverts commit 2b4b14ca99.	2022-09-15 11:11:58 +01:00
Dean Herbert	ea513c539b	Merge pull request #20303 from peppy/hitobject-entry-nesting-stoled ... Fix editor performance drop over time due to lingering nested object references	2022-09-15 17:15:01 +09:00
Dean Herbert	28b15e232d	Remove all EF models	2022-09-15 16:59:36 +09:00
Dean Herbert	65d1c40dd5	Remove remaining package references and replace with SQLitePCLRaw direct reference ... This may require further consideration for test and iOS projects.	2022-09-15 16:58:58 +09:00
Dean Herbert	581a4d2d6d	Use APIBeatmap for realm migration requiring ShortName mapping	2022-09-15 16:58:58 +09:00
Dean Herbert	0aa92c78ec	Add local sqlite initialisation to BeatmapUpdaterMetadataLookup for now	2022-09-15 16:58:58 +09:00
Dean Herbert	40a60f7145	Remove all entity framework code and migrations	2022-09-15 16:58:58 +09:00
Dan Balasescu	e56ea58e71	Fix up xmldoc	2022-09-15 16:06:21 +09:00
Dan Balasescu	c847cc521e	Add some inline comments	2022-09-15 16:00:35 +09:00
Dan Balasescu	68e4d22898	Precondition against entryMap intead of parentMap	2022-09-15 15:43:15 +09:00
Dan Balasescu	31bc067dd1	Don't store nulls to parentMap	2022-09-15 15:38:44 +09:00
Salman Ahmed	efebe55d22	Display certain sort criterias based on selected category and query	2022-09-15 04:30:09 +03:00
Salman Ahmed	de7dd29d79	Add "Nominations" and "Updated" sorting criteria in beatmap listing	2022-09-15 03:57:05 +03:00
Dean Herbert	eb18d3661d	Merge pull request #20309 from mk56-spn/dead_class_removal ... Unused class KeyCounterState.cs Removal	2022-09-15 03:38:39 +09:00
Mk-56spn	d6db82283a	Removes unused class	2022-09-14 18:01:29 +02:00
Dean Herbert	5dc0d32e42	Apply NRT to hitobject lifetime related classes	2022-09-14 15:24:20 +09:00
ekrctb	c59aa57450	Remove createLifetimeEntry from HitObjectEntryManager	2022-09-14 15:19:33 +09:00
ekrctb	47539e2129	Add doc comments to HitObjectEntryManager	2022-09-14 15:19:05 +09:00
ekrctb	bde390828b	Manage entries of nested hit objects in HitObjectEntryManager ... - Fix nested hit objects are leaked when parent hit object is edited or deleted	2022-09-14 15:19:05 +09:00
ekrctb	a9eba27129	Factor out pooling logic from Playfield	2022-09-14 15:19:05 +09:00
Dan Balasescu	90e5949e9f	Merge pull request #20300 from peppy/stable-sort-local-scores ... Fix local scores potentially not being stable-sorted for leaderboard display	2022-09-14 15:11:07 +09:00
Dean Herbert	bc07513c3c	Fix local scores potentially not being stable-sorted for leaderboard display	2022-09-14 14:19:53 +09:00
Dean Herbert	fcf54f1bc8	Fix gameplay leaderboard not being sorted correctly in tie situations	2022-09-14 14:18:12 +09:00
Dean Herbert	8a6977213a	Fix displayed scores in gameplay leaderboard not tracking display mode changes	2022-09-14 14:02:35 +09:00
Dan Balasescu	024f7991ad	Merge pull request #20292 from peppy/fix-preix-matching-status ... Fix song select status prefix matching no longer working	2022-09-14 13:53:03 +09:00
Joseph Madamba	85e3a681b1	Fix notification overlay toast tray background absorbing input from behind	2022-09-13 21:07:30 -07:00
Dean Herbert	b4e6a20846	Fix song select status prefix matching no longer working ... Regressed in #19275 due to weird logic. Closes #20289.	2022-09-14 12:59:05 +09:00
Dan Balasescu	ef6d60ffe9	Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards ... Fix beatmap listing potentially showing duplicate beatmap cards	2022-09-14 10:25:24 +09:00
Salman Ahmed	04dbb6fc1b	Add inline comment	2022-09-14 00:49:02 +03:00
Dan Balasescu	4a49433e2e	Merge branch 'master' into notification-fling-right	2022-09-13 20:01:56 +09:00
Dean Herbert	81b5e4a865	Fix back-to-front condition on leaderboard always show configuration	2022-09-13 19:57:40 +09:00
Dean Herbert	94693a4667	Fix oversight when making interface implementation explicit	2022-09-13 19:55:57 +09:00
Dean Herbert	566a61e770	Merge pull request #20244 from peppy/notification-fling ... Add ability to "fling" notifications to dismiss them	2022-09-13 19:50:34 +09:00
Dean Herbert	9226f0abbc	Implement equality correctly in Live	2022-09-13 19:16:25 +09:00
Dean Herbert	e15a25ea49	Fix leaderboard positioning logic to actually consider elements on the left side	2022-09-13 18:45:11 +09:00
Dean Herbert	678eec1c67	Move LeaderboardFlow to HUDOverlay to share positioning logic	2022-09-13 18:45:11 +09:00
Dean Herbert	5894d2f0bc	Ensure gameplay leaderboard hides with rest of HUD when it should	2022-09-13 18:45:11 +09:00
Dean Herbert	6d167070f8	Add back DI leaderboard retrieval via bindable pathway	2022-09-13 18:45:11 +09:00
Dean Herbert	70e6b595f1	Refactor SoloGameplayLeaderboard to not read scores via DI ... Also allows updating scores if they arrive late.	2022-09-13 18:00:21 +09:00
Dean Herbert	d2b80645ab	Change Leaderboard to use IUser instead of APIUser	2022-09-13 18:00:21 +09:00
Dean Herbert	ac58c222b9	Allow DrawableAvatar to accept an IUser for now	2022-09-13 18:00:21 +09:00
Dean Herbert	d251c0b2ac	Move leaderboard implementation to Player itself	2022-09-13 18:00:21 +09:00
Dean Herbert	368faa0084	Make constructor protected in base implementation	2022-09-13 18:00:21 +09:00
Dean Herbert	4c669e2bce	Track local Player.Score's user rather than using APIProvider	2022-09-13 18:00:21 +09:00
Salman Ahmed	3490b16056	Add simplified SoloGameplayLeaderboard implementation ... Note that this doesn't support waiting until leaderboard finishes fetching scores.	2022-09-13 18:00:21 +09:00
Dean Herbert	27a81dfb9f	Merge pull request #20270 from OliBomby/fix-selectionblueprint-order ... Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes	2022-09-13 17:18:58 +09:00
Dan Balasescu	53ac9dbc38	Merge branch 'master' into notification-fling	2022-09-13 17:07:16 +09:00
Dan Balasescu	0e2155303e	Merge branch 'master' into fix-song-progress-invalidations	2022-09-13 16:07:05 +09:00
Dan Balasescu	62971ef1cc	Merge pull request #20281 from peppy/fix-drawable-ruleset-dependencies ... Fix null considerations in `DrawableRulesetDependencies`	2022-09-13 15:26:29 +09:00
Dean Herbert	f53507828c	Rename event to be more generic (and add comprehensive xmldoc)	2022-09-13 14:59:30 +09:00
Dean Herbert	ac034bffeb	Fix potential crash if multiplayer spectator load is aborted early	2022-09-13 14:21:54 +09:00
Dean Herbert	0fcd9e02f6	Fix skin dropdown not updating correctly when skin is changed externally	2022-09-13 14:01:40 +09:00
Dean Herbert	d368f37c3a	Remove redundant second Current set operation	2022-09-13 13:50:59 +09:00
Dean Herbert	6bf6b7e125	Fix null considerations in DrawableRulesetDependencies	2022-09-13 13:13:38 +09:00
Dean Herbert	9c2b0efbc7	Merge pull request #20262 from smoogipoo/scoreprocessor-computeaccuracy ... Add `ScoreProcessor.ComputeAccuracy()`	2022-09-13 11:55:02 +09:00
Salman Ahmed	0ca4be5e5b	Fix one more inspection	2022-09-13 03:45:31 +03:00
OliBomby	fd48249eef	fix with new event	2022-09-13 02:20:52 +02:00
Salman Ahmed	69b9bae3b3	Merge branch 'master' into scoreprocessor-computeaccuracy	2022-09-13 03:09:52 +03:00
Salman Ahmed	a20c97d072	Merge branch 'master' into fix-skin-animation-edge-case	2022-09-13 02:26:55 +03:00
Salman Ahmed	5fba21d658	Rename parameter to clarify purpose	2022-09-13 02:21:01 +03:00
OliBomby	718f8c4ee2	revert the fix	2022-09-13 01:09:42 +02:00
Salman Ahmed	07f577a0c6	Fix beatmap listing potentially showing duplicate beatmap cards	2022-09-13 01:39:21 +03:00
OliBomby	8400de4b2e	invoking hitobject updated before invoking removed	2022-09-12 17:50:11 +02:00
ansel	8cbc0502ae	Inline CalculateEffect	2022-09-12 15:51:18 +03:00
Dean Herbert	88107108ee	Add ability to flick notifications to the right to store for later	2022-09-12 20:20:57 +09:00
Dean Herbert	802c5629c0	Merge branch 'master' into notification-fling	2022-09-12 20:09:21 +09:00
Dean Herbert	2b4b14ca99	Fix SongProgress invalidating too often ... This regressed with https://github.com/ppy/osu/pull/19556. Rather than try and figure whether that new container needs to handle size differently, this is a simple solution. Height was taken from a runtime check (maxes out at about 14.5). Closes #20235.	2022-09-12 20:06:53 +09:00
Dean Herbert	f31deaef7c	Simplify skin bindable flow ... Now, nothing touches the configuration apart from `OsuGame`, making everything else flow better and avoid weird cyclic set bugs. Closes https://github.com/ppy/osu/issues/20234.	2022-09-12 19:51:50 +09:00
Dan Balasescu	5bd0be14ed	Merge pull request #20259 from peppy/fix-changelog-crash ... Fix potential crash when opening changelog overlay if entry has no URL	2022-09-12 19:47:21 +09:00
Dean Herbert	cb6d02ec3a	Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset ... Remove the nullable disable annotation in the ruleset class	2022-09-12 19:07:23 +09:00
Dean Herbert	d92e000fe6	Fix flinging a notification not correctly running Close	2022-09-12 19:00:03 +09:00
Dean Herbert	4ee3e8f087	Don't play fling animation when activating a notification	2022-09-12 18:57:18 +09:00
Dean Herbert	c064853751	Merge branch 'master' into notification-fling	2022-09-12 18:56:15 +09:00
Dean Herbert	e29f5cb456	Fix new-style legacy skins with animated judgements not adding correct transforms ... Closes #16173.	2022-09-12 18:54:06 +09:00
Dan Balasescu	27d4016ccb	Add ScoreProcessor.ComputeAccuracy()	2022-09-12 18:37:55 +09:00
Dan Balasescu	4b37330316	Merge pull request #20248 from acid-chicken/fix/stats/td ... Fix new hit distribution graph didn't account for size changes	2022-09-12 18:11:18 +09:00
Dan Balasescu	b0980a7bf1	Merge pull request #20215 from peppy/notification-dismiss ... Allow dismissing notifications without performing action using middle / right click	2022-09-12 18:03:06 +09:00
Dan Balasescu	3cfacb5e39	Merge pull request #20257 from peppy/update-button-show-login ... Show login overlay when attempting to update a beatmap while logged out	2022-09-12 17:51:45 +09:00
Dean Herbert	58c1ea0321	Fix potential crash when opening changelog overlay if entry has no URL	2022-09-12 17:51:15 +09:00
Dean Herbert	d561fcb126	Don't trigger fling animation when Close is triggered by non-user action	2022-09-12 16:54:25 +09:00
Dean Herbert	5a02e1e713	Use padding instead of FillFlow.Spacing to avoid artifact during animation	2022-09-12 16:46:45 +09:00
Dean Herbert	a506178571	Make bounding box shrink faster to allow for rapid flinging	2022-09-12 16:39:46 +09:00
Dan Balasescu	bcbc867694	Merge branch 'master' into mods-effect-displays	2022-09-12 16:35:28 +09:00
Dean Herbert	931049aec1	Merge branch 'master' into notification-dismiss	2022-09-12 16:27:41 +09:00
Dean Herbert	bd3673baa9	Fix being able to drag after already closing a notification	2022-09-12 16:25:32 +09:00
Acid Chicken (硫酸鶏)	4f298db066	fix(osu.Game): reset Y axis of the bars in hit distribution graph at the first drawing	2022-09-12 16:25:29 +09:00
Acid Chicken (硫酸鶏)	0d0e2e7bcc	fix(osu.Game): bars in hit distribution graph stretching in the opposite direction when DrawHeight is less than DrawWidth	2022-09-12 16:20:33 +09:00
Dan Balasescu	31225066a1	Merge pull request #19308 from frenzibyte/top-rank-badge-order ... Fix best rank badge not handling legacy scores properly	2022-09-12 16:20:21 +09:00
Dean Herbert	8e6b2796eb	Merge branch 'master' into notification-fling	2022-09-12 16:19:36 +09:00
Dean Herbert	94f8197e22	Show login overlay when attempting to update a beatmap while logged out	2022-09-12 16:15:14 +09:00
Dan Balasescu	6c59be7be9	Merge pull request #20254 from peppy/fix-update-notification ... Fix update progress notification icon overload	2022-09-12 16:01:19 +09:00
Dean Herbert	96951057df	Avoid using bindables	2022-09-12 15:56:06 +09:00
Dean Herbert	bcd2445d9b	Move helper functions down in file	2022-09-12 15:50:10 +09:00
Dean Herbert	0755289ec3	Apply NRT to HitEventTimingDistributionGraph	2022-09-12 15:48:50 +09:00
Dean Herbert	7a62544923	Merge pull request #19275 from solstice23/search-filter ... Add multiple-units support in search length criteria	2022-09-12 15:43:44 +09:00
Dean Herbert	2476cf8fb3	Adjust movement to look less sudden when snapping back to Y=0	2022-09-12 15:37:48 +09:00
Dean Herbert	e06a0f7300	Fix dragged state not being exposed correctly	2022-09-12 15:21:01 +09:00
Dean Herbert	92beb6cbe7	Hide notification read light when in a toast state ... Also adds test coverage of read state and light.	2022-09-12 15:17:45 +09:00
Dean Herbert	9b31aa6d7a	Fix activation not firing with refactors	2022-09-12 15:04:30 +09:00
Dean Herbert	60b0b909a5	Move update icon to background to avoid colour collission with progress spinner	2022-09-12 14:58:46 +09:00
Dean Herbert	eca241e9a7	Move UpdateProgressNotification to base UpdateManager class	2022-09-12 14:52:11 +09:00
Dean Herbert	bbf906ee06	Remove unnecessary virtual spec	2022-09-12 14:20:48 +09:00
Dean Herbert	24138b65a7	Fix storyboard animations not starting their animation playback from the correct point in time	2022-09-12 14:05:16 +09:00
Acid Chicken (硫酸鶏)	ac324c63e2	fix(osu.Game): handle size changes in timing distribution graph	2022-09-12 04:46:32 +09:00
Dean Herbert	9ef23c79ce	Disallow forwarding during a drag operation	2022-09-11 22:05:44 +09:00
Dean Herbert	a56cadcf90	Ensure drag position is reset when transferred to tray	2022-09-11 22:03:29 +09:00
Dean Herbert	b5a2f7003e	Disallow flinging when not in toast state	2022-09-11 21:47:45 +09:00
Dean Herbert	d6f90e3b9f	Add basic fling-to-dismiss support	2022-09-11 21:32:22 +09:00
Dan Balasescu	1eb2c74e57	Fix countdown serialisation	2022-09-11 18:50:51 +09:00
ansel	324a3723a5	Rewrite DMD	2022-09-10 23:23:04 +03:00
ansel	3f93ec8538	Expose counter to inheritors	2022-09-10 23:20:28 +03:00
ansel	667854b034	Make effect display have a built-in counter	2022-09-10 23:18:48 +03:00
Mk-56spn	c00bf61273	Framework change adressed	2022-09-10 21:24:29 +02:00
MK56	8661dc3c93	Merge branch 'ppy:master' into Colour_hit_meter_improved	2022-09-10 21:16:23 +02:00
Mk-56spn	f6aef73f9e	fixed shape bindable not working, test creation, removal of Clear(), adjusted settings names	2022-09-10 20:30:43 +02:00
Dean Herbert	a9094c6b03	Add test coverage of clicking close button to dismiss	2022-09-10 15:18:32 +09:00
Dean Herbert	efe3b1aa7b	Allow dismissing notifications without performing action using middle / right click	2022-09-10 15:10:37 +09:00
ansel	b056cac10a	Remove generic and add default implementation for CalculateEffect	2022-09-10 08:34:29 +03:00
andy840119	3d7367a842	Move the CreateConvertibleReplayFrame() into the base ruleset class for avoid api breaking change in the customized ruleset.	2022-09-10 11:07:23 +08:00
andy840119	1398a7e11e	Property should accept the nullable state.	2022-09-10 10:46:40 +08:00
andy840119	e62999fb16	Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset ... # Conflicts: # osu.Game.Rulesets.Catch/CatchRuleset.cs # osu.Game.Rulesets.Osu/OsuRuleset.cs # osu.Game.Rulesets.Taiko/TaikoRuleset.cs # osu.Game/Rulesets/Ruleset.cs	2022-09-10 10:40:12 +08:00
Salman Ahmed	5e4e3dfc2c	Fix markdown container not rendering certain text correctly	2022-09-10 02:55:20 +03:00
Salman Ahmed	95062c2cc8	Remove center origin specification to avoid single-frame layout issues	2022-09-09 19:42:58 +03:00
Salman Ahmed	dd10a06e3d	Merge branch 'master' into top-rank-badge-order	2022-09-09 19:38:44 +03:00
solstice23	823078ed2d	Merge branch 'master' into search-filter	2022-09-09 23:12:37 +08:00
Dean Herbert	602ffebd54	Apply NRT and fix code style	2022-09-09 23:29:04 +09:00
Dean Herbert	d961b96897	Merge branch 'master' into search-filter	2022-09-09 23:25:54 +09:00
Dean Herbert	8f9df9c7b4	Merge pull request #18642 from Joehuu/fix-play-button-touch ... Fix beatmap card play button not working with touch inputs when not hovered	2022-09-09 19:41:05 +09:00
Dean Herbert	e479a022ef	Merge pull request #19556 from HiddenNode/fix_progress_bar_info ... Fix progress bar text orientation and scale	2022-09-09 18:46:34 +09:00
Dean Herbert	e9ce968ae3	Merge branch 'master' into fix-play-button-touch	2022-09-09 18:08:18 +09:00
Dean Herbert	bd4723d89d	Merge pull request #20200 from smoogipoo/lazer-maximum-statistics ... Populate `MaximumStatistics` for scores imported into lazer	2022-09-09 17:50:53 +09:00
Dean Herbert	648c6245bb	Add xmldoc	2022-09-09 17:40:03 +09:00
Dean Herbert	27f745b980	Merge branch 'master' into fix_progress_bar_info	2022-09-09 17:34:13 +09:00
Dean Herbert	ec21ab8171	Reduce ramp mod multipliers in line with other difficulty change mods for now ... Closes https://github.com/ppy/osu/issues/20204. Will require reprocessing of everything server-side.	2022-09-09 16:39:57 +09:00
Dean Herbert	05797cb9e5	Fix enum to STRING????????? conversion (and use bindable flow)	2022-09-09 16:30:08 +09:00
Dan Balasescu	fd6d67d0f6	Merge pull request #20205 from peppy/fix-go-home-during-exit ... Fix attempting to use "home" key binding while exiting game causing errors	2022-09-09 16:27:27 +09:00
Dan Balasescu	280b1dd484	Revert async Task change	2022-09-09 16:12:18 +09:00
Dan Balasescu	2bd23d7499	Merge pull request #20203 from peppy/fix-beat-sync-stop ... Fix beat sync stopping after returning to menu from a failed play	2022-09-09 15:37:46 +09:00
Dean Herbert	856dbbba69	Fix attempting to use "home" key binding while exiting game causing errors	2022-09-09 14:52:51 +09:00
Dean Herbert	d6748d6921	Avoid double call to ProcessFrame	2022-09-09 14:35:47 +09:00
Dean Herbert	64cf6b9014	Compare with decoupled clock directly to avoid including offsets	2022-09-09 14:35:35 +09:00
Dean Herbert	c6c59f050c	Merge pull request #20195 from cdwcgt/SkinEditorShortcut ... Add arrow shortcuts to skin editor	2022-09-09 14:17:08 +09:00
Dean Herbert	20ffbc4676	Fix beat sync stopping after returning to menu from a failed play ... Closes #20193. Explanation is inline comment.	2022-09-09 14:13:03 +09:00
Dan Balasescu	08d0c08750	Fix async exception by using difficulty calculator directly	2022-09-09 13:57:01 +09:00
Dan Balasescu	ba2ef424d4	Turn score ids into ulongs	2022-09-09 11:46:06 +09:00
Dan Balasescu	3b932b46ca	Fix entire TPL thread potentially being consumed during gameplay	2022-09-09 10:00:52 +09:00
Dan Balasescu	731d3f3b63	Add MaximumStatistics upgrade for databased scores	2022-09-09 09:56:08 +09:00
Dean Herbert	f1fa442287	Merge pull request #19599 from ItsShamed/kps ... Add clicks/second counter to HUD	2022-09-09 01:50:12 +09:00
cdwcgt	d1e27e8a69	add arrow short cut for skin editor ... basically from `ComposeBlueprintContainer` because they have the same logic	2022-09-08 23:14:34 +08:00
Dean Herbert	6945c43e0d	Merge pull request #20178 from smoogipoo/fix-match-creation-beatmap-select ... Fix several weird scenarios with online play song selection	2022-09-08 23:07:09 +09:00
Dean Herbert	45239fc737	Update TrueGameplayRate accessing	2022-09-08 23:03:15 +09:00
Dean Herbert	d4afc3629c	Merge branch 'master' into kps	2022-09-08 23:00:36 +09:00
Dan Balasescu	3c8ee1a20a	Merge pull request #20179 from peppy/update-framework ... Update framework	2022-09-08 22:14:16 +09:00
Dan Balasescu	9aab502adc	Merge pull request #20157 from peppy/true-gameplay-rate ... Refactor `TrueGameplayRate` to account for only gameplay adjustments, no matter what	2022-09-08 19:54:32 +09:00
Dan Balasescu	4fc03998a1	Merge pull request #20189 from peppy/fix-playlist-item-download-button-visibility ... Fix playlist items showing download button briefly during initial display	2022-09-08 19:47:35 +09:00
Dean Herbert	8de896a393	Update framework	2022-09-08 19:21:15 +09:00
Dean Herbert	096d1c3ff3	Merge pull request #20143 from acid-chicken/feat/stats/colored-td ... Show judgement colours in hit distribution graph	2022-09-08 19:15:40 +09:00
Dean Herbert	13d9b2188b	Merge pull request #20145 from smoogipoo/multiple-countdowns ... Implement support for multiple active countdowns in multiplayer	2022-09-08 19:15:30 +09:00
Dean Herbert	a98c6b2c1f	Add comment metioning why we need to use DrawableRuleset lookup	2022-09-08 19:14:23 +09:00
Mk-56spn	07c16224d2	Fix Main file issues	2022-09-08 11:58:14 +02:00
Dean Herbert	6729bb3e1a	Change FrameStableClock to inherit IGameplayClock	2022-09-08 18:24:18 +09:00
Dean Herbert	5c2fb3e434	Simplify calculation method	2022-09-08 18:22:53 +09:00
Dean Herbert	0de220c45c	Change IsExclusive default value to true	2022-09-08 17:54:29 +09:00
Dean Herbert	d463bd2f3f	Merge pull request #20130 from Exanc/master ... Display 0 stars instead of infinity for the minimum star slider	2022-09-08 17:51:32 +09:00
Dean Herbert	c6521e4c72	Rename ordering helper method	2022-09-08 17:50:27 +09:00
Dan Balasescu	76eae73fa4	Revert unintended change	2022-09-08 17:41:23 +09:00
Dan Balasescu	c61c596c1f	Expose as readonly IAggregateAudioAdjustment	2022-09-08 17:37:02 +09:00
Dan Balasescu	b559d4ecdf	Rename GameplayAdjustments -> AdjustmentsFromMods	2022-09-08 17:14:06 +09:00
Dean Herbert	ed81297611	Fix playlist items showing download button briefly during initial local presence checks	2022-09-08 17:10:45 +09:00
Dan Balasescu	b0b4da533a	Expose gameplay adjustments via MultiSpectatorPlayer instead	2022-09-08 16:59:20 +09:00
Dean Herbert	d523a2ac33	Rename default value field and make private	2022-09-08 15:53:08 +09:00
Dean Herbert	9ead5e59d3	Fix incorrectly displaying minimum value in placeholder messaging	2022-09-08 15:51:15 +09:00
Dean Herbert	3b116a1a47	Fix mods not being set on BeginPlayingInternal	2022-09-08 13:17:27 +09:00
Salman Ahmed	50923b6e5b	Move track assignment below	2022-09-08 00:25:55 +03:00
Dean Herbert	68ea5a765f	Update framework	2022-09-07 23:56:45 +09:00
Acid Chicken (硫酸鶏)	267465df18	chore(osu.Game): combine Osu.Colour.{Draw,Text}ForHitResult into OsuColour.ForHitResult	2022-09-07 23:34:46 +09:00
Acid Chicken (硫酸鶏)	54f0bb797e	refactor(osu.Game): remove nullable optouts in HitResult.cs	2022-09-07 23:32:45 +09:00
Acid Chicken (硫酸鶏)	b560b6f745	refactor(osu.Game): arrange the code for the timing distribution graph	2022-09-07 23:29:10 +09:00
Dan Balasescu	83c0cb1acc	Fix beatmap set to null after exiting song select	2022-09-07 21:34:29 +09:00
Dan Balasescu	fcea244537	Remove initial selection from OnlinePlaySongSelect ... This stuff never really worked anyway - every case except with an already created multiplayer room was broken anyway.	2022-09-07 21:34:29 +09:00
Dan Balasescu	208bd0f391	Give OnlinePlaySongSelect a reference PlaylistItem	2022-09-07 21:34:29 +09:00
Dean Herbert	6a03b4e0de	Merge branch 'master' into true-gameplay-rate	2022-09-07 20:01:03 +09:00
Dean Herbert	770c1ade2f	Add test coverage of track rate adjusting during multi spectator	2022-09-07 20:00:24 +09:00
Dan Balasescu	cb9bae1f5c	Enable NRT	2022-09-07 19:54:55 +09:00
Dean Herbert	e6b449fe0b	Fix case of zero rate calculating a zero true gameplay rate	2022-09-07 19:23:44 +09:00
Dean Herbert	1be3b74ff3	Fix multiplayer spectator not getting gameplay adjustments applied	2022-09-07 19:12:34 +09:00
Dean Herbert	fa15502384	Move full track adjustment flow inside MasterGameplayClockContainer	2022-09-07 19:12:16 +09:00
Dean Herbert	75d0deef72	Apply proposed changes to remove inheritance from MasterGameplayClockContainer	2022-09-07 17:49:05 +09:00
Dan Balasescu	f8e37af2e0	Merge pull request #20171 from peppy/beatmap-carousel-nrt ... Fix missing null checks on `selectedBeatmap` fields in `BeatmapCarousel`	2022-09-07 17:15:00 +09:00
Dean Herbert	68c27522e7	Merge pull request #20158 from smoogipoo/taiko-geki-katu ... Decode taiko Geki/Katu from legacy scores into `LargeBonus`	2022-09-07 17:06:42 +09:00
Dean Herbert	99ef0c95fe	Simplify children assignment	2022-09-07 16:51:51 +09:00
Dean Herbert	5b758afd09	Merge branch 'master' into taiko-geki-katu	2022-09-07 16:22:47 +09:00
Dean Herbert	824e68dab3	Fix VectorScale set to 0 still showing some sprites in storyboard ... This implementation was matching the [framework side implementation of scale](16d1c2d335/osu.Framework/Graphics/Drawable.cs (L973-L976)) but I don't think it's required here. I'm still not sure if the framework implementation is correct, but removing it locally does seem to fix broken storyboard cases. Closes https://github.com/ppy/osu/issues/20155.	2022-09-07 15:39:19 +09:00
Dan Balasescu	dc71abdf56	Merge pull request #20144 from peppy/fix-notification-overlay-presence ... Fix completion toasts sometimes not displaying	2022-09-07 14:55:33 +09:00
Dean Herbert	f3bda4e040	Fix weird edge case of nullability in CarouselRoot ... A bit unfortunately, but it's what we get for having ctor level bindings..	2022-09-07 14:27:25 +09:00
Dean Herbert	e18b524f8e	Fix missing null checks on selectedBeatmap fields in BeatmapCarousel	2022-09-07 14:12:35 +09:00
Dean Herbert	241d33d415	Apply NRT to BeatmapCarousel	2022-09-07 14:07:53 +09:00
Jamie Taylor	cb1d886c9c	Add audio feedback for Esc/Back clearing text from a FocusedTextBox	2022-09-07 13:17:04 +09:00
Acid Chicken (硫酸鶏)	3003fc1061	refactor(osu.Game): improve code quality	2022-09-07 02:29:15 +09:00
Salman Ahmed	90207b6032	Merge branch 'master' into feature/EditorDeleteDiff	2022-09-06 18:48:06 +03:00
Dan Balasescu	7c0e99c5a8	Decode Geki/Katu from legacy taiko scores into LargeBonus	2022-09-07 00:12:34 +09:00
Dean Herbert	66c44f5913	Delegate interface to valid target	2022-09-06 22:26:46 +09:00
Dean Herbert	bc1212f4e6	Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method	2022-09-06 22:26:46 +09:00
Dean Herbert	db15bd56e8	Invalidate working beatmap cache when calling DeleteDifficultyImmediately rather than in editor code	2022-09-06 18:12:47 +09:00
Dean Herbert	579e7e1f17	Fix deleting a difficulty not updating the beatmap set hash	2022-09-06 18:12:47 +09:00
Dean Herbert	a3de5f808e	Fix typo in LoopStartTime addition	2022-09-06 17:46:03 +09:00
Dean Herbert	6e52dbb266	Update IsDisplayingToasts to check the flow count directly	2022-09-06 17:30:24 +09:00
Dean Herbert	677708c5e4	Rewrite logic using a list	2022-09-06 16:58:51 +09:00
Dean Herbert	d667f46830	Refactor alpha check to not overwrite sourced overrides with values from later commands	2022-09-06 16:41:32 +09:00
Dean Herbert	bea42d2862	Handle earliest-alpha-start-time logic in StoryboardSprite itself	2022-09-06 16:16:58 +09:00
Dean Herbert	a5e57b083c	Remove EarliestDisplayTime's input to CommandStartTime	2022-09-06 16:16:58 +09:00
Dean Herbert	9e3228aa65	Fix completion notification not being posted if completion occurs during NotificationOverlay load	2022-09-06 04:07:49 +09:00
Acid Chicken (硫酸鶏)	b109e5de6c	chore(osu.Game): align height of bars on timing distribution graph to basalHeight first and combine their transitions into each one	2022-09-06 00:04:10 +09:00
Dean Herbert	44b456e216	Use gameplay clock's TrueGameplayRate in FrameStabilityContainer?	2022-09-05 23:38:22 +09:00
Dean Herbert	266eb758aa	Use new flow to calcaulate TrueGameplayRate	2022-09-05 23:37:49 +09:00
Dean Herbert	7084aeee05	Add method flow to reset applied adjustments	2022-09-05 23:22:38 +09:00
Dean Herbert	e33486a766	Implement IAdjustableAudioComponent in MasterGameplayClockContainer	2022-09-05 23:20:02 +09:00
Dean Herbert	6296c971f8	Merge pull request #20136 from smoogipoo/fix-cancellation-perf ... Improve performance when cancelling import with debugger attached	2022-09-05 22:03:50 +09:00
Dan Balasescu	b2f30fbf8c	Add countdown exclusivity	2022-09-05 20:13:23 +09:00
Dean Herbert	510972e3ad	Avoid reference counting by using height calculation for IsPresent instead ... The reference counting was to guarantee performance (zero allocations) when the notification overlay was not required, but adds extra complexity. Instead, the toast tray now uses its ongoing height calculation as a metric for presence.	2022-09-05 19:38:09 +09:00
Dean Herbert	0514c96191	Fix incorrect count tracking when notification is manually disposed	2022-09-05 19:26:40 +09:00
Dean Herbert	229e1a8ef7	Fix notification overlay being present when it doesn't need to	2022-09-05 19:13:58 +09:00
Dean Herbert	f754686521	Remove necessity of AlwaysPresent for ProgressUpdate completion posting	2022-09-05 19:13:58 +09:00
Dan Balasescu	2923c10cd8	Rewrite rooms to store multiple active countdowns ... Update test to the new structure	2022-09-05 19:03:26 +09:00
Dean Herbert	0d4ee6bd80	Centralise ability to fetch all toast tray notifications (including animating ones)	2022-09-05 18:42:20 +09:00
Dean Herbert	eca7b8f988	Fix completion notifications not always showing as toasts	2022-09-05 18:39:11 +09:00
Dean Herbert	4fa6707bf0	Set all progress notifications to non-important	2022-09-05 18:29:35 +09:00
Dan Balasescu	87e26e34b8	Merge pull request #20141 from peppy/fix-editor-timeline-sv-display ... Fix incorrect slider length in timeline when non-default velocity is inherited from previous object	2022-09-05 17:51:25 +09:00
Dean Herbert	2bec8b82b3	Fix textbox sample playback potentially crashing if called before load	2022-09-05 16:26:41 +09:00
Dean Herbert	57954bb8f5	Enable nullability on TimelineHitObjectBlueprint	2022-09-05 14:50:43 +09:00
Mk-56spn	aace334fb3	Fix some test issues	2022-09-05 04:49:48 +02:00
Dan Balasescu	8cbd344330	Improve performance when cancelling import with debugger attached	2022-09-05 11:28:13 +09:00
Dan Balasescu	07d4a025b0	Merge pull request #20109 from frenzibyte/online-play-room-status-inconsistency ... Fix room status dropdown placement inconsistent between multiplayer and playlists	2022-09-05 11:19:56 +09:00
Exanc	4ea7ca4c07	Slight tweak to the StarsSlider ... - MinimumStarsSlider now shows "0" when at it's minimum - Modified and NoResultsPlaceholder the tooltip to stay consistent with the changes	2022-09-05 00:09:20 +02:00
Acid Chicken (硫酸鶏)	7e77c9e8b4	chore(osu.Game): only the first result should be white at zero position on HitEventTimingDistributionGraph	2022-09-05 04:44:27 +09:00
Acid Chicken (硫酸鶏)	b67fd3d880	chore(osu.Game): split transform duration of bars on HitTimingDistributionGraph	2022-09-05 03:45:51 +09:00
Acid Chicken (硫酸鶏)	0af6b3dc0f	chore(osu.Game): colorize bars by OD on HitEventTimingDistributionGraph	2022-09-05 02:02:38 +09:00
Acid Chicken (硫酸鶏)	074d2a7a3a	chore(osu.Game): provide ordering index for HitResult	2022-09-05 02:01:44 +09:00
Acid Chicken (硫酸鶏)	5f0832ead7	refactor(osu.Game): separate OsuColour.ForHitResult by usage	2022-09-05 01:58:57 +09:00
Mk-56spn	0c6d8efa28	Large code refactor, Implementation of shapes option drop down	2022-09-04 17:24:12 +02:00
MK56	1a11f7e8d4	Merge branch 'ppy:master' into Colour_hit_meter_improved	2022-09-03 16:32:19 +02:00
Salman Ahmed	ff4a051c05	Merge branch 'master' into remove-dispose-updates	2022-09-03 16:14:50 +03:00
Salman Ahmed	e8fa872f61	Fix room status dropdown position inconsistent on online-play screens	2022-09-03 16:14:21 +03:00
Salman Ahmed	778d767a12	Revert disposal on SectionsContainer properties	2022-09-03 15:02:57 +03:00
Mk-56spn	51061c3a12	Bug fixing and parameter adjustments	2022-09-03 01:27:22 +02:00
Mk-56spn	534c40e18e	Initial version	2022-09-02 23:07:30 +02:00
Dean Herbert	bc5340e33a	Merge branch 'master' into fix_progress_bar_info	2022-09-02 18:00:35 +09:00