22529 Commits

Author	SHA1	Message	Date
Dean Herbert	1682260677	Remove left over logging line	2020-11-24 15:28:03 +09:00
Dean Herbert	ee33f62809	Fix DrawableJudgement not always animating correctly on skin change ... If the skin is changed before gameplay has started (at the loading screen) it is possible for a sequence of events to occur which results in the animation not being played: - `SkinReloadableDrawable` runs its BDL load (and calls `OnSkinChanged` once) - User changes skin, triggering `DrawableJudgement`'s skin change handling (binding directly on the `SkinSource` locally) - This will call `PrepareDrawables` and reinitialise the `SkinnableDrawable` child hierarchy, then immediately apply the animations to it. - The new `SkinnableDrawable` will then get the `SkinChanged` event and schedule a handler for it, which will run on its first Update call. - Any added animations will be lost as a result. Fixed by binding directly to the `SkinnableDrawable`'s `OnSkinChanged`. This has the added bonus of not needing to reinitialise the child hierarchy on skin change (which felt a bit weird in the first place).	2020-11-24 15:23:53 +09:00
Dan Balasescu	57ff150051	Merge pull request #10829 from Joehuu/music-osd-bindings ... Add music bindings to on screen display	2020-11-24 14:36:34 +09:00
Joehu	1fd4b04767	Just set music shortcut text locally	2020-11-23 20:43:46 -08:00
Dean Herbert	e36b1051c1	Add spacing between inline comments	2020-11-24 13:15:59 +09:00
Dean Herbert	82640418ba	Invert hide logic for readability	2020-11-24 13:12:04 +09:00
Dean Herbert	44ca67c534	Simplify fill logic and add xmldoc	2020-11-24 13:10:11 +09:00
Dean Herbert	37ea65de2a	Merge branch 'master' into profile-overlay-graph-new	2020-11-24 12:52:59 +09:00
Joehu	52f5473cc0	Set global action as a parameter in toast	2020-11-23 15:13:58 -08:00
Bartłomiej Dach	5701b32bae	Handle constant graphs better	2020-11-23 22:12:32 +01:00
Bartłomiej Dach	8347ecf494	Simplify row tick creation code	2020-11-23 21:52:47 +01:00
Bartłomiej Dach	7b0d3dfe0c	Refactor tick calculation code for readability	2020-11-23 21:38:04 +01:00
Bartłomiej Dach	bb5aa9a9c9	Guard against empty values early	2020-11-23 21:24:37 +01:00
Bartłomiej Dach	e9ffeb8b5d	Make missing date check more robust	2020-11-23 21:09:42 +01:00
Dean Herbert	060acb9010	Merge pull request #10935 from bdach/fix-mania-judgement-fade-in ... Rewind judgement transforms before clearing	2020-11-23 17:05:04 +09:00
Dean Herbert	5e014fc4fe	Merge pull request #10941 from LumpBloom7/improve-MenuVisualizer ... Improve LogoVisualisation looks when MenuGlow colors are used	2020-11-23 15:25:18 +09:00
Dean Herbert	19faa2b9bb	Add comment covering intentional call to ClearTransformsAfter	2020-11-23 15:20:59 +09:00
Andrei Zavatski	1b33d30039	Simplify horizontal ticks creation	2020-11-23 08:52:29 +03:00
Andrei Zavatski	42741895e6	Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-overlay-graph-new	2020-11-23 08:41:57 +03:00
Dean Herbert	898e2dae27	Restore kiai time flashing behaviour	2020-11-23 14:27:02 +09:00
Dean Herbert	5662e722ed	Merge pull request #10936 from bdach/fix-follow-points-getting-stuck ... Fix legacy follow point animations not playing after a while	2020-11-23 14:14:00 +09:00
Dean Herbert	3ed7868801	Scroll editor setup screen to file selector on display ... Previously the file selector would potentially display off-screen, making for confusing UX. Closes #10942.	2020-11-23 13:49:14 +09:00
Dean Herbert	ae609b9d48	Remove unnecessary local variable	2020-11-23 13:35:13 +09:00
Dean Herbert	2ae5a95d77	Change opacity value to match master implementation	2020-11-23 13:35:02 +09:00
Derrick Timmermans	61078e9ae1	Use 0.2f instead of .2f	2020-11-22 18:59:16 +01:00
Derrick Timmermans	ba7ce4c933	Make colour readonly	2020-11-22 18:37:49 +01:00
Derrick Timmermans	458016d17d	Remove AccentColour member variable from LogoVisualisation	2020-11-22 17:36:59 +01:00
Derrick Timmermans	1551402a8d	Change IntroWelcome visualiser to use Colour instead of AccentColour	2020-11-22 17:33:40 +01:00
Derrick Timmermans	b468f061f1	Remove unused using	2020-11-22 17:20:00 +01:00
Derrick Timmermans	cc33b0f2c6	Apply MenuGlow to Visualisation Colour instead of AccentColour	2020-11-22 16:53:53 +01:00
Bartłomiej Dach	827a089810	Merge branch 'master' into change-taiko-ez	2020-11-22 13:29:02 +01:00
Bartłomiej Dach	1c31a4a6b6	Expose animation start time as mutable in interface	2020-11-22 13:11:22 +01:00
Bartłomiej Dach	b62a873502	Merge branch 'master' into remove-default-retry-balue	2020-11-22 10:54:40 +01:00
ekrctb	666112cb5a	Address @bdach's minor suggestions	2020-11-22 18:51:16 +09:00
ekrctb	c506b438bf	Remove more code and make some methods private	2020-11-22 18:51:16 +09:00
Dean Herbert	a3b1d14f17	Apply similar fix to PoolableSkinnableSound	2020-11-22 14:44:39 +09:00
Andrei Zavatski	b745fb681a	Fix incorrect static using placement	2020-11-22 04:40:55 +03:00
Andrei Zavatski	4887132947	Adjustments for edge cases support	2020-11-22 04:28:17 +03:00
Andrei Zavatski	f07f8089d6	Adjust monthsPerTick value	2020-11-22 03:58:56 +03:00
Andrei Zavatski	e6c116f0ab	Rework horizontal ticks creation	2020-11-22 03:49:00 +03:00
Andrei Zavatski	6e581902cd	Simplify column ticks creation	2020-11-22 03:11:38 +03:00
Andrei Zavatski	453f0ba675	Make tick lines thicker	2020-11-22 02:34:29 +03:00
Andrei Zavatski	3cb1d04667	Move dates fill into it's own method	2020-11-22 02:25:12 +03:00
Andrei Zavatski	d4b56aac84	Add missing whitespace	2020-11-22 02:17:54 +03:00
Andrei Zavatski	9d7ddf8343	Merge master with conflicts resolved	2020-11-22 02:13:35 +03:00
Andrei Zavatski	fe4c622041	Make OnUserChanged private	2020-11-21 23:13:46 +03:00
Andrei Zavatski	dbfc839df3	Move missing text to PaginatedProfileSubsection	2020-11-21 23:03:54 +03:00
Andrei Zavatski	11c3ccfcaa	Move rulesets property to PaginatedProfileSubsection	2020-11-21 22:49:56 +03:00
Bartłomiej Dach	240c1b0aef	Add support for changing animation start time after load	2020-11-21 20:06:30 +01:00
Bartłomiej Dach	9f997db958	Rewind judgement transforms before clearing	2020-11-21 17:56:49 +01:00
Bartłomiej Dach	875f986979	Remove default from base ResultsScreen too	2020-11-21 14:38:38 +01:00
Endrik Tombak	72d9da5fac	Apply review suggestions	2020-11-21 14:26:09 +02:00
Endrik Tombak	6c5a6b42e5	Only calculate recommended SR once	2020-11-21 14:09:32 +02:00
Endrik Tombak	944f3480c2	Merge branch 'master' of https://github.com/ppy/osu into present-recommended ... Conflicts: osu.Game/OsuGameBase.cs osu.Game/Screens/Select/DifficultyRecommender.cs osu.Game/Screens/Select/SongSelect.cs	2020-11-21 14:01:01 +02:00
ekrctb	295ca38cda	Merge remote-tracking branch 'origin/master' into on-drawable-hitobject-added	2020-11-21 15:25:16 +09:00
ekrctb	4345d8dcb6	Event -> virtual method	2020-11-21 15:20:33 +09:00
ekrctb	281ed49332	Add HasInitialized to DHO ... As it turned out, `IsLoaded` is not a reliable way.	2020-11-21 11:19:52 +09:00
Andrei Zavatski	718ba9253b	Implement ProfileSubsection component	2020-11-21 03:18:24 +03:00
Andrei Zavatski	c4cb1440ab	Rename PaginatedContainerHeader to ProfileSubsectionHeader	2020-11-21 02:59:01 +03:00
ekrctb	82aefa3868	Rework and rename to OnNewDrawableHitObject. ... The semantics is changed and hopefully more clear.	2020-11-21 00:27:19 +09:00
smoogipoo	9520cf6481	Merge branch 'master' into fix-judgement-ordering	2020-11-20 22:49:33 +09:00
Dan Balasescu	58fc61aa95	Merge branch 'master' into legacy-judgement-particles	2020-11-20 22:19:11 +09:00
Dan Balasescu	8785da1b41	Merge pull request #10917 from peppy/no-applause-on-autoplay ... Don't play flair animations / sounds when watching autoplay or viewing a result directly	2020-11-20 21:48:10 +09:00
Dan Balasescu	79752bcb19	Merge branch 'master' into legacy-jugement-match-stable-transforms	2020-11-20 20:51:27 +09:00
Dean Herbert	8080fe942c	Fix samples being played more than once on skin change	2020-11-20 20:38:26 +09:00
ekrctb	772f6df668	Add a remark for DrawableHitObjectAdded	2020-11-20 18:00:00 +09:00
ekrctb	c013cd11c9	Add DrawableHitObjectAdded event	2020-11-20 17:56:47 +09:00
Dean Herbert	53b6d90ab4	Don't show default judgements in front of objects for now	2020-11-20 16:30:58 +09:00
Dean Herbert	a00e0d7279	Move CanBeNull specification to the interface	2020-11-20 16:30:48 +09:00
Dean Herbert	7fe0923fcf	Show main judgement content above hitobjects	2020-11-20 16:25:48 +09:00
Dean Herbert	0e9999ecb1	Merge branch 'remove-dead-playfield-code' into fix-judgement-ordering	2020-11-20 16:12:48 +09:00
Dean Herbert	2db42f8e67	Remove default allowRetry parameter value from ResultsScreen	2020-11-20 14:35:44 +09:00
Dean Herbert	8c32d3f781	Don't play flair animations / sounds when watching autoplay or viewing a result directly ... I think this is a pretty good place to be for now. The flair will play if you just watched a play (local, replay or spectator) but will not play if you are coming from song select (viewing a replay's result screen from the leaderboard) or in the case of autoplay. Closes #10762.	2020-11-20 14:32:31 +09:00
Dean Herbert	1df3f88fc4	Update framework	2020-11-20 12:32:17 +09:00
Bartłomiej Dach	6356b2dde9	Prevent editor from crashing for rulesets with no compose screen implementation	2020-11-19 22:11:52 +01:00
smoogipoo	7c83a27002	Add more xmldocs	2020-11-19 22:48:21 +09:00
smoogipoo	8a656f7cee	Fix missing SkinChanged event + safety	2020-11-19 22:42:44 +09:00
smoogipoo	a53848ef9b	Fix storyboard imlpementation	2020-11-19 22:30:41 +09:00
smoogipoo	d388c44428	Cleanup, refactoring, and restart sample on skin change	2020-11-19 22:30:21 +09:00
smoogipoo	7180bfe4ba	Unlimit number of samples per pool	2020-11-19 21:21:57 +09:00
smoogipoo	0287269b2f	Fix volume discrepancies	2020-11-19 21:21:30 +09:00
smoogipoo	f013928fa3	Set maximum pool size	2020-11-19 20:40:01 +09:00
smoogipoo	70cb197957	Cleanups	2020-11-19 20:38:36 +09:00
smoogipoo	812d5d59b1	Fix looping not being propagated	2020-11-19 20:29:09 +09:00
smoogipoo	8920534a25	Fix pools not being added to hierarchy	2020-11-19 20:24:03 +09:00
smoogipoo	003fed857c	Separate files	2020-11-19 19:52:34 +09:00
smoogipoo	730b14b5bb	Add initial hit sample pooling	2020-11-19 19:51:09 +09:00
Dean Herbert	1c7ee2ca5f	Simplify math by making direction a float	2020-11-19 18:46:19 +09:00
Dean Herbert	84e73e88d5	Use structs for parts for added safety	2020-11-19 18:08:54 +09:00
Dean Herbert	3a7291c5cf	Fix some behavioural regressions	2020-11-19 17:56:11 +09:00
Dean Herbert	476d0256cc	Replace particle explosion implementation with DrawNode version	2020-11-19 17:22:37 +09:00
Dean Herbert	83024f1ec5	Add back positional randomness from stable	2020-11-19 16:00:20 +09:00
Dean Herbert	efd5acb8ab	Randomise direction every animation playback	2020-11-19 15:55:11 +09:00
Dean Herbert	9d04ce75cc	Make particles additive and consume in judgement explosions	2020-11-19 15:47:02 +09:00
Dean Herbert	9df93e1f18	Add basic implementation of particle explosion ... Using drawables still, just to get things in place and setup the structure	2020-11-19 14:54:33 +09:00
Dean Herbert	7f3c8ad744	Merge pull request #10872 from smoogipoo/fix-missing-triangles	2020-11-19 14:11:08 +09:00
Dean Herbert	ba735584fa	Add null check for disposal safety	2020-11-19 14:04:43 +09:00
Dean Herbert	85c5c68dfa	Provide particle drawable as a function (for future use)	2020-11-19 13:20:21 +09:00
Bartłomiej Dach	24d7fa03d8	Merge branch 'master' into legacy-jugement-match-stable-transforms	2020-11-18 20:33:58 +01:00
Bartłomiej Dach	5156de3a10	Merge branch 'master' into fix-judgement-transform-logic	2020-11-18 19:20:11 +01:00
Dean Herbert	ecd6d09600	Merge pull request #10891 from smoogipoo/remove-obsoletes ... Remove obsolete method	2020-11-18 23:07:31 +09:00
Dan Balasescu	9f6ca06039	Merge pull request #10889 from peppy/return-null-if-skinnable-sprite-no-exist ... Fix SkinnableSprite initialising a drawable even when the texture is not available	2020-11-18 21:35:13 +09:00
smoogipoo	cb5d1d0d77	Remove obsolete method	2020-11-18 21:26:35 +09:00
Dean Herbert	b3bec81b79	Update xmldoc to match new behaviour	2020-11-18 19:38:38 +09:00
Dean Herbert	8522ddc61e	Reduce nesting of skinned component to reduce exposed surface	2020-11-18 19:34:27 +09:00
PercyDan54	9a3dd12f30	Move to debug settings	2020-11-18 18:15:56 +08:00
Dean Herbert	ee8804b50b	Fix animation playback not running on skin change	2020-11-18 19:03:34 +09:00
Dean Herbert	c47e70da9b	Update animations for new/old miss style and add fades	2020-11-18 19:03:34 +09:00
Dean Herbert	9d3de5bca0	Fix hit lighting dictating lifetime even when not present in skin	2020-11-18 19:03:34 +09:00
Dean Herbert	9d0a6de26e	Fix SkinnableSprite initialising a drawable even when the texture is not available	2020-11-18 19:03:34 +09:00
Dean Herbert	72a15ef2dc	Handle DrawableJudgement lifetime more flexibly	2020-11-18 19:03:34 +09:00
Dean Herbert	94886a09b2	Remove fades from DrawableJudgement itself	2020-11-18 19:03:34 +09:00
Dean Herbert	5bd4ace37f	Split out new and old style legacy judgement pieces	2020-11-18 19:03:34 +09:00
Dean Herbert	8be31f4805	Adjust legacy skin judgement transforms to match stable	2020-11-18 19:03:05 +09:00
Dean Herbert	8ccb399eff	Merge pull request #10883 from smoogipoo/defined-blueprint-order	2020-11-18 18:46:37 +09:00
Dean Herbert	bb1aacb360	Fix SkinnableSprite initialising a drawable even when the texture is not available	2020-11-18 18:07:00 +09:00
Dean Herbert	efc18887c8	Update framework	2020-11-18 18:01:55 +09:00
smoogipoo	f00c23b4a0	Add comment + xmldoc	2020-11-18 13:37:15 +09:00
smoogipoo	783c172b5d	Make sealed and cleanup comparator	2020-11-18 13:33:22 +09:00
Bartłomiej Dach	57eaee27ae	Rename param to match type better	2020-11-17 20:12:04 +01:00
Bartłomiej Dach	875d7dec79	Remove redundant this. qualifier	2020-11-17 20:11:13 +01:00
smoogipoo	58c8184ad7	Define blueprint order similarly to hitobjects	2020-11-17 22:56:31 +09:00
PercyDan54	dcaebd2621	Add license text	2020-11-17 21:39:29 +08:00
PercyDan54	809338a280	Init Import screen	2020-11-17 20:19:12 +08:00
Dean Herbert	dd4b69feab	Add legacy judgement implementation which doesn't transform on animations	2020-11-17 15:46:57 +09:00
Dean Herbert	8247e6ce91	Move result type to ctor	2020-11-17 15:43:54 +09:00
Dean Herbert	e4f1e52422	Add xmldoc coverage of Apply()	2020-11-17 15:03:26 +09:00
Dean Herbert	f465dd5a5e	Move all extended animation logic out of DrawableJudgement	2020-11-17 14:59:34 +09:00
Dean Herbert	d7b6e4a32d	Merge pull request #10867 from smoogipoo/refactor-user-request ... Refactor user caching to improve readability and fix threadsafety issues	2020-11-17 14:20:45 +09:00
Dean Herbert	9dfa4249e0	Make Apply non-virtual	2020-11-17 14:05:13 +09:00
smoogipoo	3bcf9c255a	Add Triangles.Reset()	2020-11-17 13:06:30 +09:00
smoogipoo	33c643e369	Add obsoletion for unused property	2020-11-17 12:23:34 +09:00
Dean Herbert	009d666241	Use dictionary to avoid linq overhead	2020-11-17 10:57:11 +09:00
Bartłomiej Dach	8da40ce2dc	Reduce duplication by extracting ModEasyWithExtraLives	2020-11-16 19:54:00 +01:00
Bartłomiej Dach	128adce017	Merge branch 'master' into change-taiko-ez	2020-11-16 19:37:47 +01:00
Bartłomiej Dach	72a8734f93	Merge branch 'master' into add-back-initiallifetimeoffset	2020-11-16 18:54:37 +01:00
smoogipoo	e8dbc190f1	Remove ability to pool DHOs in parent playfields	2020-11-16 23:30:24 +09:00
smoogipoo	cead67d512	Add back removed InitialLifetimeOffset removal	2020-11-16 21:49:29 +09:00
smoogipoo	85b0f71467	Handle duplicate user IDs within the same batch	2020-11-16 21:17:43 +09:00
smoogipoo	87bf168718	Use queue instead of list	2020-11-16 20:52:51 +09:00
smoogipoo	1b1f4c9c09	Refactor user request to fix threadsafety issues	2020-11-16 20:35:22 +09:00
PercyDan54	f2ef7bee5d	Fix checks	2020-11-16 18:17:50 +08:00
PercyDan54	d7acfd5413	Remove retires from ModEasy	2020-11-16 18:15:15 +08:00
Dan Balasescu	a98327f0c5	Merge branch 'master' into fix-currentskininfo-thread-safety	2020-11-16 17:55:22 +09:00
Dan Balasescu	09298139e1	Merge pull request #10844 from bdach/spinner-rotation-tracker-state ... Fix rotation tracker state not being reset on drawable spinner re-use	2020-11-16 17:10:40 +09:00
Dean Herbert	709370c69b	Move schedule call outwards	2020-11-16 16:49:31 +09:00
Dean Herbert	9a7fdb2b7e	Move skin deletion logic to OsuGameBase to promote thread safety ... `CurrentSkinInfo` is used in multiple places expecting thread safety, while ItemRemoved events are explicitly mentioning they are not thread safe. As SkinManager itself doesn't have the ability to schedule to the update thread, I've just moved the logic to `OsuGameBase`. We may want to move the current skin bindable out of the manager class in the future to match things like `BeatmapManager`. Closes https://github.com/ppy/osu/issues/10837.	2020-11-16 16:43:19 +09:00
Dean Herbert	6706840b54	Merge pull request #10853 from bdach/add-to-legacy-conversion-tests	2020-11-16 15:22:04 +09:00
Dean Herbert	baed1573dc	Merge pull request #10838 from nbvdkamp/fix-quick-delete-crash	2020-11-16 14:42:52 +09:00
Dan Balasescu	3dbd7d5654	Merge pull request #10856 from bdach/reset-transforms-on-return-to-pool ... Clear DrawableHitObject transforms on return to pool	2020-11-16 14:40:38 +09:00
Dean Herbert	7b79b9b9c1	Merge branch 'master' into fix-quick-delete-crash	2020-11-16 13:54:54 +09:00
Bartłomiej Dach	399a1a16a0	Refactor beginClickSelection in a slightly different way	2020-11-15 21:06:47 +01:00
Bartłomiej Dach	9c0a0031d6	Clear existing transforms on DHO return to pool	2020-11-15 19:50:22 +01:00
kamp	1db303b159	Revert beginClickSelection logic	2020-11-15 16:54:48 +01:00
Bartłomiej Dach	5d44286d38	Add missing generic mappings to legacy mods	2020-11-15 15:35:06 +01:00
Bartłomiej Dach	5ace7abaa8	Add abstract non-generic ModNightcore to pattern-match over	2020-11-15 15:32:02 +01:00
Bartłomiej Dach	8b74298567	Add base method for testing conversion in other direction	2020-11-15 14:48:23 +01:00
Bartłomiej Dach	9899687bfe	Rename existing method to allow for new one	2020-11-15 14:17:41 +01:00
Dean Herbert	199043f677	Allow preview tracks to exist without an owner (without hard crashing)	2020-11-15 13:21:09 +09:00
Dean Herbert	34f09e2e20	Merge branch 'master' into fix-spectator-preview-crash	2020-11-15 13:16:10 +09:00
Bartłomiej Dach	f8cabbdd21	Clear result when freeing pooled hitobject	2020-11-14 21:09:22 +01:00
Andrei Zavatski	a52c98b55c	Fix broken test scene	2020-11-14 21:20:37 +03:00
Andrei Zavatski	fe9d17fc56	Fix CodeFactor issues	2020-11-14 20:31:03 +03:00
Andrei Zavatski	a94546f905	CI fixes	2020-11-14 20:17:32 +03:00
Andrei Zavatski	5354bf1fa5	Ticks distribution improvements	2020-11-14 20:07:52 +03:00
Andrei Zavatski	02168c6c2f	Implement dates with zero count fill	2020-11-14 19:17:01 +03:00
Bartłomiej Dach	b344a13734	Add support for previewing tracks on spectator screen	2020-11-14 17:08:27 +01:00
Andrei Zavatski	af174aa653	Implement chart subsections	2020-11-14 18:48:47 +03:00
Andrei Zavatski	c2a7f2f356	Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-overlay-graph-new	2020-11-14 18:21:12 +03:00
Andrei Zavatski	ae4a2e74fa	Implement ProfileSubsection	2020-11-14 18:21:10 +03:00
Bartłomiej Dach	8a78d408db	Add more missed null checks	2020-11-14 15:52:12 +01:00
Bartłomiej Dach	610ed99ae3	Add null checks to unguarded resolved-as-null fields	2020-11-14 14:52:58 +01:00
kamp	4d2bc790fd	Fix crash on shift+right-click deleting objects	2020-11-14 13:20:16 +01:00
Dean Herbert	354e748e45	Merge branch 'master' into osu-hitobject-pooling-playfield	2020-11-14 15:44:00 +09:00
Andrei Zavatski	01f28a35c3	Implement vertical ticks creation	2020-11-14 07:28:01 +03:00
Andrei Zavatski	d98c59f2a4	Implement horizontal ticks creation	2020-11-14 06:38:02 +03:00
Andrei Zavatski	9d8e7e8954	ProfileLineChart layout implementation	2020-11-14 04:46:26 +03:00
Dean Herbert	52ff7b6593	Merge branch 'master' into hitobject-pooling-in-playfield	2020-11-14 10:27:12 +09:00
Joehu	2071cba944	Add music bindings to on screen display	2020-11-13 13:16:36 -08:00
Bartłomiej Dach	d55eae55ad	Merge branch 'master' into fix-combo-break-rewind-replay	2020-11-13 21:46:32 +01:00
Bartłomiej Dach	405407ff9e	Merge branch 'master' into fix-combo-break-sounds	2020-11-13 21:07:34 +01:00
Bartłomiej Dach	e6300f25d4	Merge branch 'master' into add-always-play-combo-break-setting	2020-11-13 20:25:55 +01:00
Bartłomiej Dach	403415147d	Merge branch 'master' into fix-perform-from-menu-overlay-hiding	2020-11-13 19:11:53 +01:00
smoogipoo	21b015d63a	Remove explicit public	2020-11-14 01:06:38 +09:00
smoogipoo	5cbf6252b7	Merge branch 'hitobject-pooling-in-playfield' into osu-hitobject-pooling-playfield	2020-11-14 01:03:11 +09:00
smoogipoo	c71b237c4f	Merge all pooling support into Playfield	2020-11-14 00:59:08 +09:00
smoogipoo	36f1833f6e	Move hitobject pooling to Playfield	2020-11-14 00:41:18 +09:00
smoogipoo	d347493ba3	Merge branch 'master' into osu-hitobject-pooling	2020-11-13 23:13:09 +09:00
smoogipoo	9792d1fc73	Fix slider tests	2020-11-13 23:08:39 +09:00
Dean Herbert	f093acc9d5	Merge pull request #10823 from smoogipoo/pooling-editor-support ... Add pooling support to the editor	2020-11-13 19:58:46 +09:00
smoogipoo	d83b479c81	Internalise lifetime extensions and events too	2020-11-13 19:21:45 +09:00
smoogipoo	4a4219fd11	Add region	2020-11-13 19:21:45 +09:00
smoogipoo	92189e35cc	Make playfield KeepAlive methods internal	2020-11-13 19:21:45 +09:00
smoogipoo	832d52a056	Fix hitobject sample tests	2020-11-13 18:19:07 +09:00
Dean Herbert	df7032bc6c	Merge pull request #10803 from smoogipoo/nested-hitobject-pooling ... Add nested hitobject pooling	2020-11-13 17:34:10 +09:00
smoogipoo	3c91626132	Merge branch 'pooling-editor-support' into osu-editor-pooling	2020-11-13 17:27:00 +09:00
smoogipoo	688a442fb3	Add missing dictionary	2020-11-13 17:26:46 +09:00
smoogipoo	942ecde0e1	Merge branch 'master' into pooling-editor-support	2020-11-13 17:23:35 +09:00
smoogipoo	0219aff7bc	Add timeline visible range adjustment	2020-11-13 17:10:29 +09:00
Dean Herbert	8268b33392	Merge pull request #10822 from peppy/update-framework ... Update framework	2020-11-13 17:10:07 +09:00
smoogipoo	3957697c48	Add pooling support to the editor	2020-11-13 17:08:20 +09:00
smoogipoo	4ef2e9548c	Pass HitObjectComposer to BlueprintContainer via ctor	2020-11-13 16:59:37 +09:00
Dean Herbert	06fd0d08d1	Merge branch 'master' into nested-hitobject-pooling	2020-11-13 16:53:20 +09:00
Dean Herbert	a9fc7572ed	Update framework	2020-11-13 15:33:27 +09:00
smoogipoo	7085b25898	Merge branch 'hitobject-pooling-base' into osu-hitobject-pooling	2020-11-13 14:57:59 +09:00
smoogipoo	4236dd826d	Improve documentation and make abstract again	2020-11-13 14:57:09 +09:00
smoogipoo	a07d4a7915	Remove unnecessary dictionary for now	2020-11-13 14:42:41 +09:00
smoogipoo	35329aa976	Reduce the number of state updates	2020-11-13 14:33:23 +09:00
Dean Herbert	0985cb3327	Fix perform from menu not hiding overlays if already on target screen	2020-11-13 14:08:08 +09:00
Dean Herbert	a2c81a3a52	Add back setting to toggle "always play first combo break"	2020-11-13 13:42:00 +09:00
Dean Herbert	4b5743d993	Fix combo break sound not playing after rewind	2020-11-13 13:38:14 +09:00
Dean Herbert	43626573df	Fix combo break sounds playing when seeking	2020-11-13 13:36:19 +09:00
Dean Herbert	38105ed6a2	Merge branch 'master' into hitobject-pooling-base	2020-11-13 11:27:32 +09:00
Dan Balasescu	2840fd0f8f	Merge branch 'master' into hitobject-pooling-base	2020-11-12 23:17:36 +09:00
Bartłomiej Dach	96fbfc33fa	Merge branch 'master' into perform-from-menu-dialog-aware	2020-11-12 15:05:45 +01:00
Dan Balasescu	e804fe5458	Merge pull request #10801 from peppy/fix-legacy-legacy-storyboard-frame-delays ... Fix storyboard animations of very old beatmaps playing too slow	2020-11-12 19:06:57 +09:00
smoogipoo	0abda7b557	Merge branch 'hitobject-pooling-base' into osu-hitobject-pooling	2020-11-12 18:49:03 +09:00
smoogipoo	261ddd2b4a	Fix samples not being disposed	2020-11-12 18:48:25 +09:00
smoogipoo	8aaa500431	Add lifetime extensions	2020-11-12 18:34:50 +09:00
smoogipoo	243e913e4a	Add hitobject usage events	2020-11-12 18:32:20 +09:00
smoogipoo	fe347c8661	Add playfield support for keeping hitobjects alive	2020-11-12 18:30:32 +09:00
smoogipoo	7548db7ecc	Fix hitobjects sometimes not fading in completely with HD mod	2020-11-12 18:29:22 +09:00
Andrei Zavatski	7177dd5d82	Add counter to most played beatmaps section in user overlay	2020-11-12 18:29:22 +09:00
Dean Herbert	8a2addbf3d	Update framework	2020-11-12 18:29:22 +09:00
Dean Herbert	d9750fc043	Remove duplicate instantiation of externalLinkOpener	2020-11-12 18:29:22 +09:00
smoogipoo	a8c2b798ad	Add support for nested hitobject pooling	2020-11-12 17:43:51 +09:00
smoogipoo	e44a8b3934	Resort as early as possible	2020-11-12 17:07:20 +09:00
Dean Herbert	41a1730927	Merge pull request #10794 from smoogipoo/fix-osu-hd-mod	2020-11-12 17:06:04 +09:00
Dean Herbert	25af091409	Fix storyboard animations of very old beatmaps playing too slow ... Closes https://github.com/ppy/osu/issues/10772.	2020-11-12 17:03:43 +09:00
smoogipoo	cf91962865	Fix test failures due to on-the-fly starttime changes	2020-11-12 16:58:40 +09:00
smoogipoo	974390bda7	Make Add() + Remove() virtual	2020-11-12 15:36:02 +09:00
smoogipoo	72a6b75626	Add back removed event	2020-11-12 15:34:51 +09:00
smoogipoo	4e43235955	Fix double bind leading to test failures	2020-11-12 15:33:49 +09:00
smoogipoo	653f5bce67	Reword xmldocs	2020-11-12 15:00:58 +09:00
smoogipoo	16e4e8d032	Fix possible nullref	2020-11-12 14:54:33 +09:00
smoogipoo	1f8d376b85	Replace CreatePool() with non-virtual RegisterPool() overload	2020-11-12 14:17:33 +09:00
smoogipoo	5dbbe11fc6	Remove PoolHitObjects, use return value of CreateDrawableRepresentation() instead	2020-11-12 14:04:16 +09:00
smoogipoo	f652eb9982	Remove GetDrawableRepresentation() override, add null hinting	2020-11-12 13:18:44 +09:00
smoogipoo	d7d77460fb	Small refactorings	2020-11-12 12:55:42 +09:00
Dean Herbert	ad79c2bc62	Avoid multiple enumeration by converting to array at construction time	2020-11-12 10:55:22 +09:00
Andrei Zavatski	f753f138c6	Add counter to most played beatmaps section in user overlay	2020-11-12 03:11:29 +03:00
Dean Herbert	ef5e3d5ab8	Merge pull request #10796 from smoogipoo/fix-incorrect-framestability-value ... Fix frame stable playback not being set correctly	2020-11-11 19:54:45 +09:00
smoogipoo	a8929b0764	Revert unnecessary change of casting	2020-11-11 19:27:07 +09:00
smoogipoo	7fdaf69903	Add some more xmldocs	2020-11-11 19:12:12 +09:00
smoogipoo	606cfacedf	Fix state update exception in a better way	2020-11-11 19:01:12 +09:00
smoogipoo	7d02018134	Remove some unnecessary implementations for now	2020-11-11 18:54:40 +09:00
smoogipoo	d7bee80d4e	Merge branch 'fix-incorrect-framestability-value' into hitobject-pooling-base	2020-11-11 18:52:51 +09:00
smoogipoo	90499329bd	Fix frame stable playback not being set correctly	2020-11-11 18:50:38 +09:00
Dean Herbert	a08833f3b3	Update framework	2020-11-11 18:03:04 +09:00
Bartłomiej Dach	2b2f0321fd	Merge branch 'master' into fix-osu-hd-mod	2020-11-11 09:45:45 +01:00
smoogipoo	6f7a1dd57d	Merge branch 'master' into hitobject-pooling-base	2020-11-11 17:09:18 +09:00
Dean Herbert	6fa0cc9bda	Merge pull request #10792 from peppy/remove-double-external-link-opener ... Remove duplicate instantiation of externalLinkOpener	2020-11-11 16:58:35 +09:00
smoogipoo	5d55af5818	Fix hitobjects sometimes not fading in completely with HD mod	2020-11-11 16:35:48 +09:00
Dean Herbert	804450e707	Remove duplicate instantiation of externalLinkOpener	2020-11-11 15:49:45 +09:00
smoogipoo	7df9484458	Merge branch 'master' into add-random-skin-hotkey	2020-11-11 15:48:12 +09:00
Dan Balasescu	09324c4598	Merge pull request #3652 from WebFreak001/shuffle-skin ... Add "random skin" option to skin setting dropdown	2020-11-11 15:47:00 +09:00
Dan Balasescu	8ad84d6640	Merge branch 'master' into osd-custom-bindings-display	2020-11-11 15:12:31 +09:00
Dan Balasescu	b446f21c68	Merge pull request #10786 from peppy/osd-skin-display ... Display skin changes via on-screen display overlay	2020-11-11 15:12:19 +09:00
Dean Herbert	c308eb75d9	Move logic for performing actions from specific screen to its own component	2020-11-11 14:45:50 +09:00
Dean Herbert	f78f2fb59e	Merge branch 'osd-custom-bindings-display' into add-random-skin-hotkey	2020-11-11 13:53:49 +09:00
Dean Herbert	324626e097	Move default config tracking calls out of OnScreenDisplay itself	2020-11-11 13:53:09 +09:00
Dean Herbert	11cf04eed1	Fix frames potentially getting added to spectator replay in wrong format ... The way spectator currently works, the `Spectator` screen is responsible for adding new frames to the replay, even when it has a child (`SpectatorPlayer`) present. There was a possibility that a new play had already started, and on returning to the Spectator screen (to initialise the new play) there would be a brief period where the Player instance is still reading from the replay, the `userBeganPlaying` call had not yet finished initialising the new target replay, and `userSentFrames` is run (asynchronously), writing frames to the previous replay using the incorrect ruleset instance). To make this work, it doesn't `Schedule` frame addition to the replay (making things a bit unsafe). Changing this itself isn't such a simple one to do, so I instead opted to fix this via locking. Closes https://github.com/ppy/osu/issues/10777.	2020-11-11 13:39:43 +09:00
Dean Herbert	8d38d9cc93	Add hotkey to select random skin	2020-11-11 13:05:03 +09:00
Dean Herbert	df00a4ab9b	Merge branch 'osd-custom-bindings-display' into shuffle-skin	2020-11-11 13:00:32 +09:00
Dean Herbert	3364648fe2	Merge branch 'osd-skin-display' into shuffle-skin	2020-11-11 13:00:31 +09:00
Dean Herbert	6014751e29	Add the ability for the game OSD to display user bindings ... Adds binding display for mouse button toggle / HUD toggle keys. - [ ] Depends on #10786 for ease-of-merge	2020-11-11 12:56:10 +09:00
Dean Herbert	9caa56c64f	Display skin changes via on-screen display overlay	2020-11-11 12:19:01 +09:00
Dean Herbert	6674628bc7	Only include user skins in random choices	2020-11-11 12:03:38 +09:00
Dean Herbert	6b548ef5e4	Split out SkinInfo ID constants and fix random logic	2020-11-11 11:54:40 +09:00
Dean Herbert	6593aac3f2	Merge pull request #7762 from EVAST9919/history-graph	2020-11-11 11:35:34 +09:00
Dean Herbert	a5e13e4d2c	Merge branch 'master' into shuffle-skin	2020-11-11 11:34:48 +09:00
Dan Balasescu	451f0a29c6	Merge pull request #10784 from peppy/fix-best-performance-weighting ... Fix user profile best performance weighting being out of order	2020-11-11 11:21:43 +09:00
Dean Herbert	89c4e3d3b2	Merge branch 'master' into history-graph	2020-11-11 11:01:48 +09:00
Dean Herbert	8706b51b77	Merge pull request #10717 from smoogipoo/dho-apply	2020-11-11 10:54:24 +09:00
Dean Herbert	53c968e137	Fix user profile best performance weighting being out of order	2020-11-11 10:19:59 +09:00
Andrei Zavatski	6c428d8b11	Merge master with conflicts resolved	2020-11-11 01:37:01 +03:00
Bartłomiej Dach	546249b071	Temporarily fix crash on deleting control point groups	2020-11-10 21:32:47 +01:00
smoogipoo	b725c9cce9	Fix possible nullrefs	2020-11-11 00:24:28 +09:00
smoogipoo	e525784cb2	Clear lifetimeEntry after use	2020-11-11 00:24:14 +09:00
smoogipoo	99e5450af3	Cache DrawableRuleset	2020-11-11 00:22:36 +09:00
smoogipoo	66213f2ed0	Add pooling support to DrawableRuleset + Playfield	2020-11-10 23:56:32 +09:00
smoogipoo	31e4d71852	Rewrite HitObjectContainer with pooling support	2020-11-10 22:49:02 +09:00
smoogipoo	5354ef1699	Merge branch 'dho-apply' into hitobject-pooling-base	2020-11-10 22:30:08 +09:00
Bartłomiej Dach	20f9759a2e	Merge branch 'master' into fix-storyboard-sprite-paths	2020-11-10 12:57:10 +01:00
Dean Herbert	e1dcac4d8b	Update framework	2020-11-10 20:29:29 +09:00
Bartłomiej Dach	61093030ee	Remove redundant class name qualifier	2020-11-10 12:20:49 +01:00
Bartłomiej Dach	ce837eaba0	Rename variables	2020-11-10 12:20:26 +01:00
Bartłomiej Dach	dd873dbd85	Merge branch 'master' into fix-profile-graph-crash	2020-11-10 12:17:12 +01:00
smoogipoo	6f3f6dc28b	Add hitobject lifetime support	2020-11-10 20:16:52 +09:00
cadon0	539806e9d6	Rewrite - Add empty drawable whenever sprite not found	2020-11-10 23:52:37 +13:00
cadon0	6446074976	Fix paths for storyboard animation sprites	2020-11-10 23:52:37 +13:00
smoogipoo	45e9f16f6b	Add initial DrawableRuleset interface	2020-11-10 19:27:08 +09:00
smoogipoo	757a4b5c31	Add hitobject lifetime model	2020-11-10 19:26:01 +09:00
smoogipoo	88112801eb	Remove result storage from hitobject	2020-11-10 18:56:16 +09:00
Dan Balasescu	ef1036cef1	Merge pull request #10767 from peppy/fix-editor-crash-on-two-mouse-button-click ... Fix BlueprintContainer triggering assert when left and right mouse button are pressed together	2020-11-10 18:41:58 +09:00
Dan Balasescu	d873229120	Merge pull request #10769 from peppy/fix-mod-select-keys-handle-control ... Stop mod select overlay hotkeys handling input when control is pressed	2020-11-10 18:37:14 +09:00
smoogipoo	f5076fe3b8	Revert unnecessary change	2020-11-10 18:15:11 +09:00
Dan Balasescu	4e3f6f19f4	Merge pull request #10768 from bdach/force-import-standardised ... Always store standardised score when populating ScoreInfo	2020-11-10 18:12:35 +09:00
Dean Herbert	833c0b223e	Clamp index to valid bounds	2020-11-10 18:08:12 +09:00
Dean Herbert	2e3dc6fc46	Merge branch 'master' into fix-profile-graph-crash	2020-11-10 18:06:51 +09:00
Dean Herbert	28daff1716	Stop mod select overlay hotkeys handling input when control is pressed ... Closes https://github.com/ppy/osu/issues/10766 in about the best way we can for now.	2020-11-10 17:57:59 +09:00
Dan Balasescu	601cc477e5	Merge branch 'master' into fix-editor-crash-on-two-mouse-button-click	2020-11-10 17:42:25 +09:00
Dan Balasescu	86026ad98f	Merge pull request #10764 from peppy/fix-editor-quick-delete-via-left-mouse ... Fix editor quick delete being triggerable from left mouse button	2020-11-10 17:42:12 +09:00
Dean Herbert	de6fcd1792	Fix BlueprintContainer triggering assert when left and right mouse button are pressed together	2020-11-10 17:16:28 +09:00
Dean Herbert	a012105dac	Fix editor quick delete being triggerable from left mouse button ... Closes https://github.com/ppy/osu/issues/10629.	2020-11-10 16:54:37 +09:00
Bartłomiej Dach	109abc0e29	Always store standardised score when populating ScoreInfo	2020-11-10 08:41:00 +01:00
Dean Herbert	5221a34929	Only handle keys which create characters	2020-11-10 16:32:58 +09:00
Dean Herbert	a2ef3aa21a	Force beatmap listing overlay's textbox back on screen when a key is pressed ... Not the cleanest solution, but works for now. Will eventually be replaced after the header is updated to reflect the latest designs (which keeps it on screen in all cases). Closes https://github.com/ppy/osu/issues/10703.	2020-11-10 16:26:30 +09:00
Andrei Zavatski	e464e719ef	Merge remote-tracking branch 'refs/remotes/ppy/master' into history-graph	2020-11-10 10:22:57 +03:00
Dean Herbert	6cc0bf17a9	Add explicit lock object and some xmldoc for clarity	2020-11-10 14:31:52 +09:00
Dean Herbert	dc21aebdc7	Merge branch 'master' into fix-bdc-threadsafety	2020-11-10 14:31:51 +09:00
Dean Herbert	85d641c630	Merge pull request #10740 from Game4all/add-multi-statuses	2020-11-10 14:23:26 +09:00
Dean Herbert	4855e43764	Merge pull request #10758 from nbvdkamp/rank-history-json-property-fix ... Replace rankHistory in JsonProperty with rank_history for consistency	2020-11-10 14:05:25 +09:00
Dean Herbert	582b5454ed	Merge pull request #10759 from Joehuu/disable-watching-yourself	2020-11-10 13:10:54 +09:00
Dean Herbert	4af390a168	Move hierarchy init to load and remove unnecessary field storage	2020-11-10 12:33:07 +09:00
Dean Herbert	de554f9091	Merge pull request #10742 from Morilli/fix-ki-texture-positioning	2020-11-10 12:27:40 +09:00
Joehu	670d6d8719	Make button field readonly	2020-11-09 18:59:54 -08:00
Joehu	c671d97e6f	Disable watch button on the local user	2020-11-09 18:39:35 -08:00
kamp	4303a24a6f	Replace rankHistory in JsonProperty with rank_history	2020-11-10 00:53:24 +01:00
Dean Herbert	37feedae7a	Fix potential crash due to stale index	2020-11-10 07:27:38 +09:00
Dean Herbert	1548c0dc25	Ensure graph hover state is updated after data changes	2020-11-10 07:27:27 +09:00
smoogipoo	0bab5605d1	Merge branch 'master' into dho-apply	2020-11-10 01:30:45 +09:00
smoogipoo	d4d3a6621e	Disable automatic lifetime management	2020-11-10 01:30:25 +09:00
smoogipoo	66ea1572c7	Fix unsafe list manipulation in BeatmapDifficultyCache	2020-11-10 01:10:00 +09:00
smoogipoo	ac47399e6e	Update state after OnApply()	2020-11-10 00:30:23 +09:00
smoogipoo	ec8b726ea8	Re-privatise start time bindable	2020-11-09 21:51:58 +09:00
Lucas A	b8c63e7944	Apply review suggestions.	2020-11-09 13:39:50 +01:00
Dean Herbert	ba137aadc8	Update framework	2020-11-09 20:44:12 +09:00
Dean Herbert	4d6f0a8ea7	Fix API request error handling	2020-11-09 19:42:00 +09:00
Dean Herbert	d99e1ba8dd	Merge branch 'master' into efficient-user-retrieval	2020-11-09 19:41:44 +09:00
Dan Balasescu	33c3b07101	Fix events not being bound correctly ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-11-09 19:06:48 +09:00
Dan Balasescu	a2877fb00a	Merge pull request #10730 from peppy/fix-patcher-no-object-crash ... Fix legacy patcher crash on no objects present	2020-11-09 18:51:00 +09:00
Morilli	7b0e387dfc	apply different offset based on whether the marker is newStyle or not	2020-11-09 08:20:19 +01:00
Morilli	490fbd1dd8	Fix ki* textures having an incorrect vertical position	2020-11-09 05:54:48 +01:00
Dean Herbert	cfb42037cf	Refactor request string logic to avoid linq usage	2020-11-09 12:23:29 +09:00
Dean Herbert	690e69bcc6	Reforamt for legibility	2020-11-09 12:22:54 +09:00
Dean Herbert	dc69eefa51	Use HashSet instead of ConcurentBag	2020-11-09 11:54:28 +09:00
Dean Herbert	90ce1bd5f0	Add missing async suffix	2020-11-09 10:40:16 +09:00
Lucas A	e44951969f	Use ??= operator instead of null check.	2020-11-08 18:22:19 +01:00
Lucas A	d8d4022119	Precise XMLDoc	2020-11-08 14:39:56 +01:00
Lucas A	48fce8c4b9	Add user activities to multi subscreens.	2020-11-08 13:21:21 +01:00
Lucas A	89b98b5388	Make multiplayer screen handle user activity updates from subscreens.	2020-11-08 13:16:27 +01:00
Lucas A	55070556a7	Move activity setup to BDL.	2020-11-08 12:53:19 +01:00
Lucas A	790a2ca97d	Extract UserActivity logic to OsuGame.	2020-11-08 12:29:52 +01:00
Dean Herbert	42e4df8cc8	Merge branch 'master' into efficient-user-retrieval	2020-11-08 14:35:40 +09:00
Dean Herbert	567cf932f1	Merge pull request #10732 from bdach/editor-exit-stack-overflow ... Fix crash upon exiting the editor without saving from new beatmap	2020-11-08 12:12:24 +09:00
Bartłomiej Dach	6d4bb4316c	Fix difficulty retrieval for online-sourced beatmaps	2020-11-08 00:12:25 +01:00
Bartłomiej Dach	ddbd6df24d	Unbind bindable lists for general safety	2020-11-07 20:59:57 +01:00
Bartłomiej Dach	e078b78dcc	Ensure callbacks don't fire when restoring default beatmap	2020-11-07 20:59:57 +01:00
Dean Herbert	b0052210b6	Add asserts of HitObjects indices	2020-11-08 00:18:38 +09:00
Dean Herbert	c5b6908e71	Always write [HitObjects] to file ... I think this is expected. If not, there's an alternative solution.	2020-11-08 00:18:27 +09:00
Dean Herbert	d93cf08570	Merge branch 'master' into dho-apply	2020-11-07 01:18:46 +09:00
smoogipoo	91c627c22d	Revert HOC changes	2020-11-07 00:57:33 +09:00
smoogipoo	b1e039bcec	Prevent overrides from messing with application/freeing	2020-11-07 00:40:26 +09:00
smoogipoo	3a4bd73823	Fix DHOs being freed when not expected	2020-11-07 00:25:26 +09:00
Dean Herbert	f94ac1cbc7	Merge branch 'master' into efficient-user-retrieval	2020-11-07 00:07:29 +09:00
Dean Herbert	84e090583d	Merge pull request #10712 from peppy/move-cache-logic-to-base-impl ... Move cache and lookup logic to base MemoryCachingComponent class	2020-11-07 00:06:43 +09:00
smoogipoo	7eceda242b	Change derived class to use property	2020-11-06 23:04:28 +09:00
smoogipoo	2d892c7407	Allow Apply() to be called multiple times sequentially	2020-11-06 23:03:29 +09:00
smoogipoo	248d342a2f	Initial Apply()/FreeAfterUse() DHO implementation	2020-11-06 23:02:37 +09:00
smoogipoo	2bef9312d9	Make SkinReloadableDrawable poolable	2020-11-06 22:15:06 +09:00
Dan Balasescu	f230250faf	Merge branch 'master' into editor-slider-control-point-quick-delete	2020-11-06 21:47:37 +09:00
Dean Herbert	4bbd3fe886	Handle null result	2020-11-06 18:37:27 +09:00
Dean Herbert	c3c288145a	Ignore null results for now	2020-11-06 17:55:29 +09:00
Dean Herbert	1ca8b03aa5	Never disable pause button on now playing overlay	2020-11-06 17:26:23 +09:00
Dean Herbert	24be1e183b	Merge branch 'move-cache-logic-to-base-impl' into efficient-user-retrieval	2020-11-06 17:24:36 +09:00
Dean Herbert	c1c3d37720	Remove non-null assert	2020-11-06 17:24:28 +09:00
Dean Herbert	c97c6bbf52	Add and consume user cache class	2020-11-06 17:00:29 +09:00
Dean Herbert	893979b3de	Add exception if attempting to exceed the maximum supported lookup size for one request	2020-11-06 17:00:29 +09:00
Dean Herbert	2457083d8b	Add padding to currently playing view	2020-11-06 17:00:29 +09:00
Dean Herbert	db039da668	Add and consume multi-lookup API endpoint	2020-11-06 17:00:29 +09:00
Dean Herbert	aa252d562a	Rename top user request to make way for new type	2020-11-06 17:00:29 +09:00
Dean Herbert	f51cb0dd14	Add ruleset fallback logic into cache lookup class	2020-11-06 16:58:53 +09:00
Dean Herbert	d3a303e251	Use CheckExists function	2020-11-06 16:57:09 +09:00
Dean Herbert	9bb32f0914	Merge branch 'master' into move-cache-logic-to-base-impl	2020-11-06 16:56:35 +09:00
Dan Balasescu	44c6457c85	Merge branch 'master' into add-spinner-spin	2020-11-06 15:40:40 +09:00
Dean Herbert	c5b172d0dd	Remove synchronous lookup path from BeatmapDifficultyCache	2020-11-06 14:53:15 +09:00
Dan Balasescu	972fc54c2d	Merge pull request #10710 from peppy/user-id-as-int ... Use int instead of long for user_id fields for now	2020-11-06 14:35:14 +09:00
Dean Herbert	1dcbf15d81	Merge branch 'master' into move-cache-logic-to-base-impl	2020-11-06 14:35:06 +09:00
Dan Balasescu	9ec5f9bff8	Merge pull request #10711 from peppy/rename-cache-classes ... Rename cache classes in line with their function (and share a base implementation)	2020-11-06 14:34:47 +09:00
Dean Herbert	b69ada64e8	Update BeatmapDifficultyCache to use base implementation logic	2020-11-06 14:31:21 +09:00
Dean Herbert	a2606d31c7	Move lookup/storage/compute logic to base class (and consume in ScorePerformanceCache)	2020-11-06 13:51:41 +09:00
Dean Herbert	517a656899	Move StarDifficulty to own file	2020-11-06 13:51:25 +09:00
Dean Herbert	74ca2faa31	Remove unused using	2020-11-06 13:48:06 +09:00
Dean Herbert	07166ec819	Fix a couple of remaining unnecessary casts	2020-11-06 13:29:47 +09:00
Dean Herbert	0103b12575	Add basic base class to begin to standardise function across caching components	2020-11-06 13:26:39 +09:00
Dan Balasescu	71a1165209	Merge branch 'master' into drawable-hit-object-hit-state-fix	2020-11-06 13:19:25 +09:00
Dean Herbert	14bb079feb	Rename ScorePerformanceManager to ScorePerformanceCache	2020-11-06 13:15:33 +09:00
Dean Herbert	5113d4af8f	Rename BeatmapDifficultyManager to BeatmapDifficultyCache	2020-11-06 13:14:29 +09:00
Dean Herbert	1e1569eb53	Use int instead of long for user_id fields for now	2020-11-06 12:59:46 +09:00
Dean Herbert	d774afd224	Update framework	2020-11-05 22:29:44 +09:00
Dean Herbert	309b1d6334	Merge pull request #10695 from peppy/fix-skinnable-test-scene ... Fix SkinnableTestScene's autosize propagation	2020-11-05 20:48:36 +09:00
Dean Herbert	a0b3379909	Fix judgement offsets being zero when windows are empty	2020-11-05 18:58:37 +09:00
Dean Herbert	2bbdbfda5c	Merge pull request #10696 from smoogipoo/visibility-adjustment-mod	2020-11-05 18:18:57 +09:00
Dean Herbert	2d50a7b616	Fix a few xmldoc typos	2020-11-05 17:38:02 +09:00
Dean Herbert	019d286ce8	Merge branch 'drawable-hit-object-hit-state-fix' into add-spinner-glow	2020-11-05 17:27:38 +09:00
Dean Herbert	8aa0a698d9	Avoid errors due to second set	2020-11-05 17:26:41 +09:00
Dean Herbert	9c91f16e3a	Update sizing as early as possible in addition to scheduling (to handle any dependent edge cases)	2020-11-05 17:24:59 +09:00
Dean Herbert	8293846afc	Merge branch 'master' into fix-skinnable-test-scene	2020-11-05 17:24:24 +09:00
Dean Herbert	0cadb31947	Merge branch 'master' into drawable-hit-object-hit-state-fix	2020-11-05 17:07:52 +09:00
smoogipoo	9d5b1ec28c	Add removal dates	2020-11-05 17:04:11 +09:00
Dean Herbert	2d0c62dce2	Fix SkinnableTestScene's autosize propagation ... Regressed with recent DrawableHitObject changes (moving of RelativeSizeAxes specifications out of constructors).	2020-11-05 16:37:48 +09:00
Dean Herbert	414daab1dc	Fix paused samples potentially getting stuck in a playing state in rapid toggling ... Closes #10693. Should be obvious why.	2020-11-05 16:14:23 +09:00
smoogipoo	cc518feca7	Make methods abstract	2020-11-05 16:03:10 +09:00
smoogipoo	a219aa7ba2	Add xmldoc	2020-11-05 15:53:35 +09:00
smoogipoo	628b8be15d	Implement ModWithVisibilityAdjustment	2020-11-05 15:40:25 +09:00
smoogipoo	9a7fcadabc	Use BDL for top-level osu! DHOs	2020-11-05 13:51:46 +09:00
Dan Balasescu	ea2fd831ab	Merge branch 'master' into editor-slider-control-point-quick-delete	2020-11-05 00:38:42 +09:00
Dean Herbert	d19b799f44	Invert boolean logic	2020-11-04 17:53:03 +09:00
Dean Herbert	68b7efe4d5	Change order of execution to be chronological	2020-11-04 17:14:23 +09:00
Dean Herbert	831325978a	Always execute UpdateHitStateTransforms (even for idle)	2020-11-04 17:14:23 +09:00
Dean Herbert	3b6cf95f49	Remove parameter from StartTime method and add obsoleted previous version	2020-11-04 16:39:52 +09:00
Dean Herbert	7f30140b7e	Add new method handling hit state specifically ... Until now UpdateStateTransforms was applying results offsets to StartTime. This didn't cover the case of a HitObject with duration, where the call would be made with `StartTime + hitOffset` rather than `EndTime + hitOffset`. To resolve this, a new method has been added which should be used to handle hit-specific state transforms.	2020-11-04 16:13:14 +09:00
Dan Balasescu	3322c2bbc5	Merge branch 'master' into ios-editor-crash-fix	2020-11-04 15:56:40 +09:00
Dean Herbert	487a5ecdba	Replace all usage of IBindableList.GetBoundCopy	2020-11-04 15:29:14 +09:00
Dan Balasescu	42c543f5b9	Merge branch 'master' into fix-editor-play-after-drag	2020-11-04 14:45:20 +09:00
Dan Balasescu	98c992004b	Merge pull request #10660 from peppy/fix-song-select-first-track-looping ... Fix looping mode not being set on first track after entering song select	2020-11-04 14:37:27 +09:00
Dan Balasescu	c6779b414e	Merge pull request #10611 from peppy/spectator-listing ... Add "currently playing" player listing and spectator UI flow	2020-11-04 14:08:11 +09:00
Dean Herbert	cfe3218239	Move scheduler call to inside method itself for added safety	2020-11-04 10:23:06 +09:00
Dean Herbert	29e8e5ab94	Merge branch 'master' into fix-load-async-after-disposal-beatmap-wedge	2020-11-04 10:23:05 +09:00
Dean Herbert	9dc2ca666d	Merge branch 'master' into spectator-listing	2020-11-04 09:30:15 +09:00
Bartłomiej Dach	3bb86ce127	Merge branch 'master' into editor-waveform-opacity	2020-11-03 23:04:19 +01:00
Bartłomiej Dach	13f729916a	Merge branch 'master' into editor-timeline-scroll-mousewheel	2020-11-03 22:27:35 +01:00
Bartłomiej Dach	ddf0d75c38	Don't fall through to seek if handling zoom	2020-11-03 21:49:21 +01:00
Bartłomiej Dach	4b528e80d0	Use AltPressed shorthand	2020-11-03 21:49:04 +01:00
Bartłomiej Dach	211510fe9a	Fix undesirable vertical spacing in currently playing display	2020-11-03 19:12:03 +01:00
Bartłomiej Dach	86d283ebf4	Adjust layout slightly to avoid specifying width twice	2020-11-03 19:03:48 +01:00
Bartłomiej Dach	18428dff8e	Ensure hotkey actions are executable in handler	2020-11-03 18:01:12 +01:00
Dean Herbert	83c004bbde	Add key bindings for flip and reverse patterns	2020-11-03 21:10:31 +09:00
Dean Herbert	9f333ac58a	Add the ability to delete slider control points using shift+right click ... Closes https://github.com/ppy/osu/issues/10672. In two minds about how this should be implemented but went in this direction initially. The other way would be to add local handling of Shift-Right Click inside PathControlPointPiece (which is already doing mouse handling itself).	2020-11-03 20:46:33 +09:00
Dean Herbert	1b2bd6a8c9	Remove redundant base call	2020-11-03 20:10:13 +09:00
Dean Herbert	3e29e468ea	Ensure "start watching" button starts in a disabled state	2020-11-03 20:06:42 +09:00
Dean Herbert	a3c67aabe2	Merge branch 'master' into spectator-listing	2020-11-03 19:56:25 +09:00
Dean Herbert	d788931661	Fix LoadComponentAsync calls potentially occuring after beatmap wedge disposal ... As seen in https://ci.appveyor.com/project/peppy/osu/builds/36109658/tests. Also adds cancellation logic for good measure.	2020-11-03 19:53:45 +09:00
Dean Herbert	df9ff76f23	Reduce assert to guard in the outwards direction	2020-11-03 16:49:13 +09:00
Dean Herbert	f701a38e20	Merge branch 'master' into fix-song-select-first-track-looping	2020-11-03 16:48:20 +09:00
Dean Herbert	c2ffc18379	Change editor timeline mouse wheel handling to scroll by default (and zoom with alt held)	2020-11-03 16:30:11 +09:00
Dean Herbert	0dcb4ea441	Add handling of opacity to timeline waveform display	2020-11-03 16:07:01 +09:00
Dean Herbert	7e4314684b	Add editor waveform opacity selection to menu	2020-11-03 16:01:14 +09:00
Dean Herbert	6bf35d5767	Fix editor menu not supporting stateful item drawables	2020-11-03 16:00:07 +09:00
Dean Herbert	34aa59f237	Fix editor clock not always remaining stopped when dragging timeline ... Closes https://github.com/ppy/osu/issues/10461.	2020-11-03 15:00:01 +09:00
Bartłomiej Dach	b152514bc7	Merge branch 'master' into spectator-connection-logging	2020-11-02 20:21:45 +01:00
Dean Herbert	ab308d28d2	Debounce calls to UpdateTernaryStates ... Just something I noticed in passing recently which may help with reducing performance overhead of some batch operations.	2020-11-03 01:08:36 +09:00
Dean Herbert	d5c95a8b46	Centralise into methods and add assertions for safety	2020-11-03 00:45:55 +09:00
Dean Herbert	c3d3856a64	Fix looping mode not being set on first track after entering song select ... Closes #10656.	2020-11-02 23:51:02 +09:00
Dean Herbert	c1d9a0c92c	Move click action out of user panel	2020-11-02 21:09:47 +09:00
smoogipoo	3956a0669a	Fix editor seek transform seeking too much	2020-11-02 21:08:58 +09:00
Dean Herbert	ed30756c19	Add test coverage for new display (and remove live version for now)	2020-11-02 20:41:14 +09:00
Dean Herbert	c6de0544d2	Disable display for not	2020-11-02 20:21:23 +09:00
Dean Herbert	5cbfaf3589	Revert "Add (temporary) local user cache to avoid re-querying API each display" ... This reverts commit 4e17634ee2.	2020-11-02 20:19:38 +09:00
Dean Herbert	a89aeaf1ce	Add very basic connection status logging for spectator streaming client	2020-11-02 17:32:10 +09:00
Dean Herbert	4e17634ee2	Add (temporary) local user cache to avoid re-querying API each display	2020-11-02 17:31:04 +09:00
smoogipoo	6f623d8cca	Rename IsUserPaused -> UserPauseRequested	2020-11-02 16:08:59 +09:00
Dean Herbert	414f65c1ef	Merge branch 'master' into spectator-listing	2020-11-02 15:48:21 +09:00
Dean Herbert	8adf146f53	Merge pull request #10640 from bdach/fix-music-paused-on-multi-exit	2020-11-02 15:46:19 +09:00
Dean Herbert	ab9e0aac58	Merge pull request #10258 from Game4all/results-dynamic-pp-calc	2020-11-02 15:40:55 +09:00
Dan Balasescu	2c51c24913	Merge pull request #10605 from peppy/spectator-replay-watcher ... Add screen hierarchy for spectating another player	2020-11-02 15:29:59 +09:00
Dean Herbert	8f2cd0e8c5	Add matching requestedByUser parameter to Play method	2020-11-02 15:01:30 +09:00
Dean Herbert	d2f6303988	Change default value of requestedByUser to false	2020-11-02 14:56:50 +09:00
Dean Herbert	ecad85b5f5	Merge branch 'master' into fix-music-paused-on-multi-exit	2020-11-02 14:55:15 +09:00
Dan Balasescu	04178e9458	Merge branch 'master' into spectator-replay-watcher	2020-11-02 14:54:51 +09:00
Dean Herbert	7b320a991f	Add note about missing expiration logic	2020-11-02 14:53:32 +09:00
Dean Herbert	d46f7535c9	Add xmldoc for new component	2020-11-02 14:50:44 +09:00
Dean Herbert	fb105a1e9c	Remove unnecessary field storage	2020-11-02 14:49:25 +09:00
Dean Herbert	73b290aca3	Merge branch 'master' into results-dynamic-pp-calc	2020-11-02 14:47:33 +09:00
Dean Herbert	3adf451e82	Handle changes via SamplePoints list for simplicity	2020-11-02 14:40:40 +09:00
smoogipoo	bd7c3d0d9f	Merge branch 'master' into results-screen-applause	2020-11-02 13:38:19 +09:00
Dan Balasescu	1b53e6c782	Merge branch 'master' into sample-lookup-improvements	2020-11-02 13:04:35 +09:00
Dan Balasescu	8a768669ad	Merge pull request #10606 from FamousPig/fix-timeline-drag-select-weirdness ... Fix timeline zoom during drag-select causing unexpected behaviour	2020-11-02 13:04:26 +09:00
Dean Herbert	6cfaee0f0b	Merge pull request #10631 from bdach/shift-delete-all-selected	2020-11-02 12:04:58 +09:00
Dean Herbert	6e2d722b8a	Merge pull request #10649 from ppy/dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-3.3.1	2020-11-02 11:52:38 +09:00
Dan Balasescu	5ae3da9399	Merge branch 'master' into fix-timeline-drag-select-weirdness	2020-11-02 11:18:37 +09:00
Dean Herbert	61c9bb3245	Merge branch 'master' into dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-3.3.1	2020-11-02 10:56:09 +09:00
Dan Balasescu	b1b52f9073	Merge branch 'master' into fix-resume-beatmap-options-edit	2020-11-02 10:46:31 +09:00
Dan Balasescu	ba726c6291	Merge pull request #10623 from cadon0/fix-beatmap-details-metadata-bounce ... Fix "bounce" when metadata container text is empty in song select	2020-11-02 10:45:14 +09:00
Joehu	71d55f16f3	Fix edit beatmap options button not resuming back to song select	2020-11-01 13:50:38 -08:00
Bartłomiej Dach	432282e8de	Use alternative solution to avoid storing last zoom	2020-11-01 21:25:05 +01:00
Bartłomiej Dach	3090b6ccb5	Resolve CA2249 inspections ... "Use `string.Contains` instead of `string.IndexOf` to improve readability"	2020-11-01 18:54:44 +01:00
Bartłomiej Dach	89bf7b1bd6	Resolve CA1835 inspection ... "Change the `ReadAsync` method call to use the `Stream.ReadAsync(Memory<byte>, CancellationToken)` overload"	2020-11-01 18:51:39 +01:00
Bartłomiej Dach	ca5de22ca5	Resolve CA1834 inspection ... "Use `StringBuilder.Append(char)` instead of `StringBuilder.Append(string)` when the input is a constant unit string"	2020-11-01 18:50:13 +01:00
Bartłomiej Dach	2b0bea535e	Resolve CA1805 inspections ... "Member is explicitly initialized to its default value"	2020-11-01 18:47:40 +01:00
Bartłomiej Dach	716458344f	Ensure spectator player is unsubscribed to prevent leak	2020-11-01 16:13:19 +01:00
Bartłomiej Dach	23d9fa4dfa	Merge branch 'master' into spectator-replay-watcher	2020-11-01 15:53:37 +01:00
Bartłomiej Dach	b7696c85ad	Add more xmldocs	2020-11-01 15:23:03 +01:00
Dean Herbert	1f8d627af4	Merge branch 'master' into shift-delete-all-selected	2020-11-01 23:03:01 +09:00
Dean Herbert	e1b8875553	Merge pull request #10634 from bdach/fix-leftover-selection-box-tooltip ... Fix selection box action tooltips still being visible after object deletion	2020-11-01 23:02:29 +09:00
Bartłomiej Dach	5903c3be90	Fix inaccurate xmldoc	2020-11-01 14:39:10 +01:00
Lucas A	6bfff43634	Extract StatisticCounter to a separate class and use it instead.	2020-11-01 13:25:36 +01:00
Bartłomiej Dach	f3e0480e77	Merge branch 'master' into fix-beatmap-details-metadata-bounce	2020-10-31 17:36:40 +01:00
Bartłomiej Dach	79f47953a8	Migrate existing call to new flag parameter	2020-10-31 16:08:27 +01:00
Bartłomiej Dach	19023e7d43	Fix player restart invoking user-level pause	2020-10-31 16:08:15 +01:00
Bartłomiej Dach	941e8525af	Add flag parameter to allow non-user-pause via music controller	2020-10-31 16:07:54 +01:00
Dean Herbert	a9a3489e92	Fix potential null reference when loading background ... As seen in https://discordapp.com/channels/188630481301012481/188630652340404224/772094427342569493. Caused due to async load of the loader, which means it may not be ready before Next() is called.	2020-10-31 22:51:35 +09:00
Bartłomiej Dach	007c27d3ff	Schedule visibility update once per frame	2020-10-31 14:45:11 +01:00
Bartłomiej Dach	d74c19e2d7	Shorten show/hide code	2020-10-31 13:54:02 +01:00
Bartłomiej Dach	3322b8a7ea	Run OnSelectionChanged() on each change	2020-10-31 13:54:02 +01:00
Bartłomiej Dach	003994ab75	Bind UpdateVisibility() directly to source of truth	2020-10-31 13:54:02 +01:00
Bartłomiej Dach	129b1bc6d3	Delete all selected objects if shift-clicked on one	2020-10-31 11:46:25 +01:00
Dean Herbert	6a293dd536	Add missing ctor parameters back	2020-10-31 18:56:30 +09:00
Dean Herbert	979eb1685b	Merge branch 'master' into results-screen-applause	2020-10-31 18:47:49 +09:00
Dean Herbert	f0b80d245e	Merge branch 'master' into spectator-listing	2020-10-31 16:22:49 +09:00
Dean Herbert	a088151e58	Merge branch 'spectator-replay-watcher' into spectator-listing	2020-10-31 16:22:10 +09:00
Bartłomiej Dach	78842ab95a	Improve look & behaviour of background transitions	2020-10-30 22:40:24 +01:00
Bartłomiej Dach	391dd73843	Fix typo in comment	2020-10-30 22:39:34 +01:00
Bartłomiej Dach	38cf90a69b	Change background to seasonal right after login	2020-10-30 22:03:26 +01:00
Bartłomiej Dach	29ad099902	Allow to fetch if going online after launch	2020-10-30 21:49:14 +01:00
Bartłomiej Dach	67a325f47d	Move config setting logic to background loader	2020-10-30 21:22:22 +01:00
Bartłomiej Dach	cf0e8e0a62	Document nullability of seasonal backgrounds	2020-10-30 20:00:59 +01:00
Bartłomiej Dach	aeab2be5d1	Add xmldoc to SeasonalBackgroundMode	2020-10-30 19:56:52 +01:00
Bartłomiej Dach	20c27c6943	Rename lookup & field	2020-10-30 19:55:22 +01:00
Bartłomiej Dach	82ef85569b	Fix nullref when querying IsInSeason before request completion	2020-10-30 19:35:08 +01:00
Max Hübner	d5dfd1dffe	Insert optional parentheses	2020-10-30 18:07:07 +01:00
Max Hübner	51a58269ad	Fix nullref in case of successfull request but no backgrounds available	2020-10-30 17:57:29 +01:00
Max Hübner	0b46c19b23	Move seasonalBackgroundMode check up and early return if available	2020-10-30 17:16:51 +01:00
Max Hübner	f6eb5680ec	Save full api response in SessionStatics	2020-10-30 16:43:18 +01:00
Max Hübner	6f6a8e2a8f	Convert switch to if	2020-10-30 16:06:48 +01:00
Max Hübner	d19dd4eef6	IsInSeason() -> IsInSeason	2020-10-30 15:56:19 +01:00
Max Hübner	4e3fb615d2	Rename "SeasonalBackgrounds" to "SeasonalBackgroundMode"	2020-10-30 15:54:10 +01:00
Dean Herbert	1db8dfd03e	Merge branch 'master' into seasonal-backgrounds	2020-10-30 22:53:51 +09:00
Dean Herbert	bc69ed3870	Simplify sample lookup	2020-10-30 22:33:27 +09:00
cadon0	a1fa6588f6	Fix "bounce" when metadata container text is empty	2020-10-31 01:06:19 +13:00
Dean Herbert	b4e5311014	Move initial state set inside updateClock	2020-10-30 20:39:25 +09:00
Dean Herbert	1bd461f229	Move clock logic back to inside updateClock method	2020-10-30 20:21:14 +09:00
Max Hübner	f27ce7521d	Make "Sometimes" setting depend on season end date, rather than chance	2020-10-30 10:27:43 +01:00
Dean Herbert	79aecc9a98	Merge branch 'master' into spectator-replay-watcher	2020-10-30 16:31:24 +09:00
Dean Herbert	32e68a6a3c	Fix FramedReplayInputHandler incorrectly blocking in streaming mode when time requested is before the first frame ... Most of this is just tidying up the logic to (hopefully) be better to follow, again (again (again)). The actual fix is that we now allow interpolation/playback when the incoming time is less than the first frame's time, regardless of receiving status.	2020-10-30 16:09:03 +09:00
Dan Balasescu	0ef1459f4b	Merge pull request #10621 from peppy/hud-momentary-visibility ... Add momentary HUD toggle	2020-10-30 15:40:54 +09:00
Dean Herbert	0f997386ae	Fix direction and IsRunning not updating on first frame after becoming valid ... The parent clock will not unpause until WaitingForFrames becomes false, so I've moved the set of that before we start to propagate its values across. Doesn't fix any visible issue but should make propagation one game loop faster.	2020-10-30 15:26:23 +09:00
Dean Herbert	326fd03525	Fix loop not exiting after first valid frame	2020-10-30 15:25:53 +09:00
Dan Balasescu	b14291a312	Merge branch 'master' into tracked-hud-visibility-settings	2020-10-30 14:58:45 +09:00
Dan Balasescu	8be16bd4ed	Merge pull request #10370 from peppy/fix-test-beatmap-virtual-clock ... Ensure virtual track time is long enough for test beatmaps	2020-10-30 14:23:06 +09:00
Dan Balasescu	45b8af5391	Merge pull request #10614 from peppy/results-screen-animate-once ... Only play results panel animation once (and only for the local user)	2020-10-30 14:21:05 +09:00
Dean Herbert	8928aa6d92	Add key binding to show HUD while held	2020-10-30 14:19:40 +09:00
Dean Herbert	b4eda65383	Commit missing pieces	2020-10-30 13:53:51 +09:00
Dean Herbert	c72017a7db	Remove "hide during breaks" option ... Probably wouldn't be used anyway.	2020-10-30 13:49:45 +09:00
Dean Herbert	f58f8e0f93	Update resources	2020-10-30 13:46:54 +09:00
Dean Herbert	9bb86ccb83	Change shift-tab to cycle available HUD visibility modes	2020-10-30 13:09:22 +09:00
Dean Herbert	18f92818da	Show current HUD visibility mode as a tracked setting	2020-10-30 13:09:13 +09:00
Dean Herbert	46d89d55f4	Add note about ScheduleAfterChildren requirement	2020-10-30 12:47:04 +09:00
Dean Herbert	8e6c803900	Avoid running full updateClock loop when waiting on frames	2020-10-30 12:39:11 +09:00
Dean Herbert	8dbaca341e	Merge branch 'sample-lookup-improvements' into results-screen-applause	2020-10-30 12:28:48 +09:00
Dean Herbert	b906736b85	Remove redundant initialisation	2020-10-30 12:28:40 +09:00
Dean Herbert	823230f06a	Merge branch 'sample-lookup-improvements' into results-screen-applause	2020-10-30 12:17:36 +09:00
Dean Herbert	2ea4aa0a37	Fix incorrect specification on some sample lookups	2020-10-30 11:59:41 +09:00
Dean Herbert	d319b27b3d	Run sample lookup logic through getFallbackNames	2020-10-30 11:59:41 +09:00
Dean Herbert	0b28cca7e6	Don't force Gameplay prefix on all skin sample lookups	2020-10-30 11:59:40 +09:00
Dean Herbert	c9a85587fb	Allow SampleInfo to specify fallback sample lookup names	2020-10-30 11:59:29 +09:00
Dean Herbert	0c1d12460f	Remove unused parameter	2020-10-30 10:30:11 +09:00
Max Hübner	fb1e09b3e7	Load seasonal backgrounds according to setting	2020-10-29 18:04:48 +01:00
Max Hübner	d9846fad37	Remove fallback texture parameter ... When there isn't a seasonal event, we don't want to fall back to the basic background here, but rather to the user selected background source.	2020-10-29 18:03:36 +01:00
Max Hübner	34371b8888	Show next Background on showSeasonalBackgrounds.ValueChanged	2020-10-29 17:44:23 +01:00
Max Hübner	bf4d99dfe7	Load SeasonalBackgroundLoader asynchronously	2020-10-29 17:43:10 +01:00
Max Hübner	907e1921c7	Make SeasonalBackgroundLoader read from SessionStatics	2020-10-29 17:31:42 +01:00
Max Hübner	76c0a790b4	Add separate Seasonal Backgrounds setting (Always, Sometimes, Never)	2020-10-29 17:28:04 +01:00
Dean Herbert	87be7d162b	Merge branch 'master' into spectator-replay-watcher	2020-10-30 00:25:17 +09:00
Max Hübner	b189e0b7cf	Revert "Load SeasonalBackgroundLoader asynchronously" ... This reverts commit 81ebcd8796.	2020-10-29 16:01:22 +01:00
Max Hübner	7d523fee28	Revert "Set BackgroundSource.Seasonal as default setting" ... This reverts commit cdb2d23578.	2020-10-29 14:31:07 +01:00
Max Hübner	0c540537c9	Revert "Add BackgroundSource.Seasonal" ... This reverts commit 2871001cc2.	2020-10-29 14:30:50 +01:00
Dean Herbert	1c353b4745	Update framework	2020-10-29 20:38:28 +09:00
Dean Herbert	17ea06f793	Merge branch 'results-screen-animate-once' into results-screen-applause	2020-10-29 20:23:25 +09:00
Dean Herbert	7be4dfabd8	Revert "Update namespace references" ... This reverts commit d69d78ab5d.	2020-10-29 20:23:15 +09:00
Dean Herbert	404885af89	Merge branch 'results-screen-animate-once' into results-screen-applause	2020-10-29 18:52:54 +09:00
Dean Herbert	3491dea9e2	Fix scroll logic running before children may be alive in flow	2020-10-29 18:51:54 +09:00
Dean Herbert	d69d78ab5d	Update namespace references	2020-10-29 18:45:18 +09:00
Dean Herbert	f1b8a8f7f5	Remove unused using	2020-10-29 18:16:04 +09:00
Dean Herbert	335d150a13	Fix aim time being mutated inside update loop	2020-10-29 18:11:50 +09:00
Dean Herbert	4dec46b33e	Attempt to fix in a less destructive way for now	2020-10-29 17:52:58 +09:00
Dean Herbert	7bef695072	Merge branch 'master' into fix-test-beatmap-virtual-clock	2020-10-29 17:51:15 +09:00
Dean Herbert	0a0239a7c7	Only play results panel animation once (and only for the local user)	2020-10-29 17:08:59 +09:00
Dean Herbert	11f85779d5	Fix panel expanded state being updated multiple times unnecessarily	2020-10-29 17:08:59 +09:00
Dean Herbert	71e373ff51	Make results panels aware of whether they are a local score that has just been set	2020-10-29 17:08:59 +09:00
Dean Herbert	4a26084df8	Only play results panel animation once (and only for the local user)	2020-10-29 17:04:33 +09:00
Dean Herbert	f1ce09930e	Fix panel expanded state being updated multiple times unnecessarily	2020-10-29 17:03:45 +09:00
Dean Herbert	5d5b0221e5	Add skinning support for legacy applause playback	2020-10-29 16:32:29 +09:00
Dean Herbert	c863341ca1	Don't force Gameplay prefix on all skin sample lookups	2020-10-29 16:32:20 +09:00
Dean Herbert	b49a579411	Allow SampleInfo to specify fallback sample lookup names	2020-10-29 16:32:03 +09:00
Dean Herbert	fb82c043a5	Add rank appear sound (new default)	2020-10-29 16:11:37 +09:00
Dean Herbert	a8e9c62583	Make results panels aware of whether they are a local score that has just been set	2020-10-29 16:11:25 +09:00
Dean Herbert	6e630e8c88	Merge branch 'spectator-replay-watcher' into spectator-listing	2020-10-29 15:33:43 +09:00
Dean Herbert	2671d371da	Move clock retrieval to new correct location	2020-10-29 15:28:39 +09:00
Dean Herbert	3ea27e23e8	Update namespace references	2020-10-29 15:20:10 +09:00
Dean Herbert	3751c357a3	Update framework	2020-10-29 15:19:05 +09:00
Dean Herbert	0818835b16	Merge branch 'spectator-replay-watcher' into spectator-listing	2020-10-29 15:13:21 +09:00
Dean Herbert	db2b00068f	Avoid sourcing parent clock when in a paused state	2020-10-29 14:48:56 +09:00
Dean Herbert	d91456dc29	Move initial validity check out of loop for clarity	2020-10-29 14:25:47 +09:00
Dean Herbert	2e5a8b2287	Fix xmldoc to read better in new context	2020-10-29 13:16:31 +09:00
Dan Balasescu	a022b869eb	Merge branch 'master' into frame-stability-clean-up	2020-10-29 13:02:17 +09:00
Dan Balasescu	4a264bc173	Merge branch 'master' into beatmap-listing-search-options	2020-10-29 12:04:40 +09:00
Dan Balasescu	8ccc3c2ec8	Merge pull request #10596 from charlie-gray/right-click-circle-delete ... Add support for deleting objects when Shift is held down	2020-10-29 11:37:22 +09:00
Bartłomiej Dach	1313ab89e7	Add xmldoc to multiple selection row	2020-10-28 23:37:21 +01:00
Bartłomiej Dach	016e920aa9	Move filter tab item hierarchy construction to BDL	2020-10-28 23:14:52 +01:00
Bartłomiej Dach	a8cefb0d4c	Rename method	2020-10-28 23:12:28 +01:00
Bartłomiej Dach	f5aedc96c4	Rework multiple selection filter	2020-10-28 23:07:54 +01:00
Bartłomiej Dach	e77049eae3	Use discard-like lambda parameter names	2020-10-28 22:58:51 +01:00
Bartłomiej Dach	fa53549ed2	Mark request fields as possibly-null	2020-10-28 22:57:03 +01:00
Bartłomiej Dach	a1696942f0	Merge branch 'master' into right-click-circle-delete	2020-10-28 22:12:14 +01:00
Bartłomiej Dach	202fe09306	Group selection actions back up in SelectionHandler	2020-10-28 22:06:48 +01:00
Andrei Zavatski	5c2c5f2000	Use existing ScoreRank for rank filter	2020-10-28 23:35:08 +03:00
Andrei Zavatski	4f6081c7f3	Use BindableList<T>	2020-10-28 19:44:13 +03:00
Dean Herbert	bca317b151	Remove excess using statement	2020-10-28 23:43:16 +09:00
Dean Herbert	e1bf751dac	Merge branch 'spectator-replay-watcher' into spectator-listing	2020-10-28 23:17:50 +09:00
Dean Herbert	5d02de29ca	Fix attempt to change ruleset/beatmap bindables while screen is not active	2020-10-28 22:50:45 +09:00
Dean Herbert	25ab3a5fea	Construct replay after being sure a ruleset is available to avoid nullrefs	2020-10-28 22:10:37 +09:00
Dean Herbert	dd2f44f393	Add basic "currently watching" text to player to signify that spectator is active	2020-10-28 19:43:06 +09:00
Dean Herbert	93fd913876	Add setting to allow automatically downloading during a spectating session	2020-10-28 19:43:06 +09:00
Dean Herbert	9807089834	Fix screen exit potentially occuring during transition	2020-10-28 19:43:06 +09:00
Dean Herbert	4df8119852	Add missing schedule	2020-10-28 19:43:06 +09:00
Dean Herbert	93e3e1a4db	Don't inherit ReplayPlayer to make results screen work correctly	2020-10-28 19:02:38 +09:00
Dean Herbert	344ff8f4bc	"Improve" visuals of spectator screen	2020-10-28 19:02:38 +09:00
Dean Herbert	2d73dfbe39	Add more safety around beatmap panel and button display logic	2020-10-28 19:02:38 +09:00
Dean Herbert	c97feb09bf	Allow continuing to automatically spectate user from results screen	2020-10-28 19:02:38 +09:00
Dean Herbert	16b0a7b33e	Add button flow to allow resuming watching after exiting manually	2020-10-28 19:02:38 +09:00
Dean Herbert	84d854e231	Avoid having the user profile show when clicking a spectator panel	2020-10-28 19:02:38 +09:00
Dean Herbert	32becb6882	Add simple listing of currently playing users	2020-10-28 19:02:38 +09:00
Dean Herbert	ce9dd0c920	Fix enum descriptions not being displayed in OverlayHeaderTabControl	2020-10-28 17:44:15 +09:00
Dean Herbert	6169349f7c	Fix switching to new beatmap not working correctly	2020-10-28 17:44:11 +09:00
Dean Herbert	730cc645fb	Avoid reconstructing ruleset for each frame bundle	2020-10-28 16:33:52 +09:00
Dean Herbert	48b0357e7d	Fix "finished playing" events handled for potentially incorrect user	2020-10-28 16:11:14 +09:00
Dean Herbert	6eddd76bdc	Simplify FramedReplayInputHandler's SetFrame implementation	2020-10-28 16:03:23 +09:00
Dean Herbert	09da75b143	Merge branch 'frame-stability-clean-up' into spectator-replay-watcher	2020-10-28 15:34:46 +09:00
Dean Herbert	2b1e79a4e8	Simplify state changes further	2020-10-28 15:32:20 +09:00
Dean Herbert	c9515653b3	Restore previous directionality logic to avoid logic differences	2020-10-28 15:31:57 +09:00
Dean Herbert	77d807d0f5	Merge branch 'frame-stability-clean-up' into spectator-replay-watcher	2020-10-28 15:26:02 +09:00
Dean Herbert	59e9c2639a	Remove try-finally	2020-10-28 15:16:56 +09:00
Dean Herbert	a06516c900	Extract out frame stability state into enum for (hopefully) better clarity	2020-10-28 15:15:15 +09:00
Dean Herbert	8c9bda2ded	Split out replay update method	2020-10-28 15:14:06 +09:00
Dean Herbert	9b9a41596f	Split out frame stability calculation to own method	2020-10-28 15:14:06 +09:00
Dean Herbert	3e5322541d	Make direction setting more clear	2020-10-28 14:35:42 +09:00
Dean Herbert	351acce698	Merge branch 'master' into fix-editor-bindable-crash	2020-10-28 13:34:54 +09:00
Dean Herbert	01b576c861	Fix editor crash on exit when forcing exit twice in a row	2020-10-28 13:32:39 +09:00
Andrei Zavatski	914bd53788	Add missing blank line	2020-10-28 02:39:51 +03:00
Andrei Zavatski	6fd3686c4d	Use IReadOnlyCollection instead of List in SearchBeatmapSetsRequest	2020-10-28 02:36:35 +03:00
Andrei Zavatski	03c5057a92	Simplify BeatmapSearchMultipleSelectionFilterRow	2020-10-28 02:28:31 +03:00
Andrei Zavatski	fd11346a28	Update button colours	2020-10-28 01:48:24 +03:00
Andrei Zavatski	b4ec3b9fef	Simplify MultipleSelectionFilterTabItem state changes	2020-10-28 01:41:46 +03:00
Dean Herbert	0a7f3dc19b	Avoid null reference on finalization ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-10-28 07:29:07 +09:00
Andrei Zavatski	c4efceceb2	Use char instead of sting for request parameter creation	2020-10-27 23:57:11 +03:00
Andrei Zavatski	008d1d697c	Implement filtering by rank achieved	2020-10-27 23:14:48 +03:00
Andrei Zavatski	1710b396e7	Implement BeatmapSearchMultipleSelectionFilterRow	2020-10-27 22:27:29 +03:00
Andrei Zavatski	1b40b56d41	Add ability to search by play criteria	2020-10-27 21:30:53 +03:00
Andrei Zavatski	26a60d898c	Implement BeatmapSearchExtraFilterRow	2020-10-27 21:22:20 +03:00
Andrei Zavatski	742a96484b	Add ability to set extra parameters to SearchBeatmapSetsRequest	2020-10-27 20:13:18 +03:00
Leon Gebler	0ddf840a63	Merge branch 'master' into fix-timeline-drag-select-weirdness	2020-10-27 15:31:55 +01:00
Leon Gebler	983a2774e8	Code Formatting	2020-10-27 15:09:10 +01:00
Leon Gebler	064c50c3ac	Expose currentZoom to fix selection box wiggle	2020-10-27 14:38:35 +01:00
Dean Herbert	d5e0fa322b	Fix a couple of inspections	2020-10-27 22:30:45 +09:00
Lucas A	a96c067bea	Remove uncessary async-await state machine level.	2020-10-27 13:45:21 +01:00
Dan Balasescu	26a7545534	Merge branch 'master' into fix-editor-samples-not-pausing-screen-swap	2020-10-27 21:29:16 +09:00
Dean Herbert	2cacdaa11b	Add basic beatmap download and play flow	2020-10-27 19:28:34 +09:00
Dean Herbert	42b3aa3359	Fix spectating when starting from a point that isn't at the beginning of the beatmap	2020-10-27 18:58:37 +09:00
Dean Herbert	b3d793a505	Fix gameplay proceeding when no frames have been received yet	2020-10-27 18:58:37 +09:00
Dean Herbert	851d45d2eb	Add sane pausing logic	2020-10-27 18:58:37 +09:00
Dean Herbert	9e6b0a42ec	Allow FrameStabilityContainer to handle waiting-for-data state better (and pause outwards)	2020-10-27 18:58:37 +09:00
Dean Herbert	3ec3321a3d	Add missing space	2020-10-27 18:58:37 +09:00
Dean Herbert	b737a8bf6e	Add field to Replay denoting whether the full replay have been received or not	2020-10-27 18:58:37 +09:00
Dean Herbert	c1e7cd6e47	Stop replay playback when frames are starved	2020-10-27 18:58:37 +09:00
Dean Herbert	9bac8f3792	Add null check on replay as safety measure	2020-10-27 18:58:37 +09:00
Dean Herbert	400542bc0b	Ensure frames arrive	2020-10-27 18:58:37 +09:00
Dean Herbert	ac4671c594	Add basic implementation of spectator screen	2020-10-27 18:58:37 +09:00
Dean Herbert	154ccf1b49	Expose events from streaming client	2020-10-27 18:58:37 +09:00
Dean Herbert	5fd97bd043	Add basic spectator screen	2020-10-27 18:58:37 +09:00
Dean Herbert	df5348cd93	Merge pull request #10601 from peppy/move-sample-pause-logic	2020-10-27 17:49:32 +09:00
Dean Herbert	b8beac27ce	Use previous logic for catching-up mode	2020-10-27 17:14:41 +09:00
Dean Herbert	e0ad005cc1	Move editor sample disabling logic to editor class (and support screen switching)	2020-10-27 14:33:44 +09:00
Dean Herbert	09087faf3b	Fix non-matching filename	2020-10-27 14:23:24 +09:00
Dean Herbert	9cfb81589e	Use bindable flow instead	2020-10-27 14:10:12 +09:00
Dean Herbert	6853da459d	Move sample pausing logic out of FrameStabilityContainer	2020-10-27 13:54:33 +09:00
Dean Herbert	3c2e2f29bc	Remove unused using statement	2020-10-27 13:17:44 +09:00
Dean Herbert	27c1a4c4d3	Move right-click deletion logic to be handled at a SelectionBlueprint level	2020-10-27 12:53:54 +09:00
Dean Herbert	e1f578c590	Change editor timing screen seek behaviour to only occur on clicking table rows ... Previously it would react to any selection changed event, which could in lude time changes (which is done by removing then adding the ControlPointGroup). Closes #10590.	2020-10-27 12:28:12 +09:00
Dean Herbert	266596d404	Merge branch 'master' into right-click-circle-delete	2020-10-27 12:02:29 +09:00
Dean Herbert	68719bb23d	Rename other variables to match	2020-10-27 10:59:24 +09:00
Bartłomiej Dach	7392876b5f	Fix mania crashing due to spectator client handling frames with unconverted beatmap	2020-10-27 00:35:25 +01:00
Bartłomiej Dach	3f8c4c57d0	Fix code style issues & restructure	2020-10-26 22:16:28 +01:00
Charlie	255bb9d100	fixed issue with returns	2020-10-26 14:52:59 -05:00
Charlie	ccaf6560ec	formatting	2020-10-26 14:30:37 -05:00
Charlie	1239670566	moved right click shift delete functionality to HandleSelectionRequested + reduced func size	2020-10-26 14:28:53 -05:00
Charlie	ead3c19567	added function so circle is deleted when shift+right click	2020-10-26 13:40:42 -05:00
Leon Gebler	704f8cc4f2	Fix selection box wandering off into the distance	2020-10-26 18:45:03 +01:00
Dean Herbert	dfe07271de	Add very basic latency handling to spectator test	2020-10-26 16:31:39 +09:00
Dean Herbert	b86347dc81	Merge branch 'master' into spectator	2020-10-26 13:39:07 +09:00
Dean Herbert	9caa7ff64d	Remove debug endpoint	2020-10-26 13:38:05 +09:00
Dean Herbert	431054377a	Merge branch 'master' into epilepsy-warning-volume-restoration	2020-10-25 22:22:11 +09:00
Bartłomiej Dach	0542a45c43	Change to manual adjustment add/remove	2020-10-25 12:33:35 +01:00
Dean Herbert	8b04cd2cb0	Fix a potential null reference when loading carousel difficulties	2020-10-25 20:28:24 +09:00
Bartłomiej Dach	85e14f3f0c	Shorten fade duration to make fade out snappier	2020-10-25 00:40:11 +02:00
Bartłomiej Dach	e101ba5cba	Move volume manipulations to player loader	2020-10-25 00:40:11 +02:00
Bartłomiej Dach	73174961f0	Rework animation sequence for readability	2020-10-24 22:30:08 +02:00
Max Hübner	81ebcd8796	Load SeasonalBackgroundLoader asynchronously	2020-10-23 13:41:00 +02:00
Max Hübner	c1d03a5bac	Add SeasonalBackgroundLoader and SeasonalBackground	2020-10-23 13:40:13 +02:00
Dean Herbert	e20a986401	Add ruleset to state	2020-10-23 17:24:19 +09:00
Dean Herbert	89797d7a57	Merge pull request #9786 from Wieku/storyboard-skin-sprites ... Allow storyboard elements to load textures from skins	2020-10-23 17:16:55 +09:00
Dean Herbert	4f746792fb	Fix regression causing storyboard sprites to have incorrect origin support	2020-10-23 15:46:24 +09:00
Dean Herbert	8232bf1957	Merge pull request #10576 from Game4all/song-select-wedge-dynamic-star-rating	2020-10-23 15:39:02 +09:00
Dean Herbert	1b84402b96	Centralise and share logic for storyboard frame lookup method	2020-10-23 15:34:00 +09:00
Dean Herbert	9141f48b04	Remove beatmap-based ctor to promote single flow	2020-10-23 14:57:27 +09:00
Dean Herbert	4fca7675b0	Don't send spectate data when an autoplay mod is active	2020-10-23 14:47:21 +09:00
Dean Herbert	e99cf369fa	Don't worry about EndPlaying being invoked when not playing	2020-10-23 13:33:23 +09:00
Dean Herbert	f11bcfcb8f	Remove unnecessary public specification in interface ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-10-23 10:03:33 +09:00
Max Hübner	09d49aa0f7	Add GetSeasonalBackgroundsRequest	2020-10-22 18:25:01 +02:00
Max Hübner	cdb2d23578	Set BackgroundSource.Seasonal as default setting	2020-10-22 18:23:03 +02:00
Max Hübner	2871001cc2	Add BackgroundSource.Seasonal	2020-10-22 18:21:28 +02:00
Dean Herbert	54d666604b	Fix incorrect order of flag settings	2020-10-22 22:56:23 +09:00
Dean Herbert	9f2f8d8cc7	Fix missing licence headers	2020-10-22 19:41:10 +09:00
Dean Herbert	147d502da1	Fix initial play state not being kept locally if not connected	2020-10-22 19:30:07 +09:00
Dean Herbert	ee2513bf4b	Add batch sending	2020-10-22 19:17:19 +09:00
Dean Herbert	823d717a7d	Reduce the serialised size of LegacyReplayFrame	2020-10-22 19:17:10 +09:00
Dean Herbert	34e889e66e	Don't watch every user in normal gameplay (but allow so in test)	2020-10-22 18:38:03 +09:00
Dean Herbert	1ab6f41b3b	Add basic send and receive test	2020-10-22 18:10:27 +09:00
Dean Herbert	c834aa6051	Use APIMod for mod serialization	2020-10-22 17:48:15 +09:00
Dean Herbert	0611b30258	Drop webpack	2020-10-22 17:48:15 +09:00
Dean Herbert	05697dfe68	Add spectator state object support	2020-10-22 17:48:15 +09:00
Dean Herbert	2021945a8c	Add retry/error handling logic	2020-10-22 17:48:15 +09:00
Dean Herbert	96049c39c9	Add begin/end session logic	2020-10-22 17:48:15 +09:00
Dean Herbert	4788b4a643	Expose oauth access token via api interface	2020-10-22 17:48:15 +09:00
Dean Herbert	175fd512b0	Send frames to streaming client from replay recorder	2020-10-22 17:48:15 +09:00
Dean Herbert	93db75bd41	Begin shaping the spectator streaming component	2020-10-22 17:48:15 +09:00
Dean Herbert	c6db832efa	Add xmldoc notes about thread safety of api bindables	2020-10-22 14:56:20 +09:00
Dean Herbert	5a00a05a95	Add missing schedule call	2020-10-22 14:49:48 +09:00
Dean Herbert	db4dd3182b	Add xmldoc to spectator interfaces	2020-10-22 14:46:21 +09:00
Dean Herbert	b39a4da6bc	Add initial classes for spectator support	2020-10-22 14:46:21 +09:00
Dean Herbert	da573c7487	Remove unused usings	2020-10-22 14:44:10 +09:00
Dean Herbert	3fe6f77444	Fix cases of multiple bdl methods	2020-10-22 14:30:49 +09:00
Dean Herbert	303975ccb1	Remove unnecessary permitNulls	2020-10-22 14:27:49 +09:00
Dean Herbert	9753dab93b	Remove IOnlineComponent and change existing components to use bindable flow	2020-10-22 14:19:12 +09:00
Lucas A	cf69eacae9	Make StarRatingDisplay dynamic.	2020-10-21 19:05:14 +02:00
Lucas A	670775cecb	Make beatmap wedge difficulty indicator color update dynamically.	2020-10-21 18:57:48 +02:00
Bartłomiej Dach	58c9e57a68	Fix comment	2020-10-21 17:17:23 +02:00
Dean Herbert	22112e4303	Fix ISourcedFromTouch events being blocked by LoadingLayer	2020-10-21 23:11:51 +09:00
Bartłomiej Dach	e2552d4c36	Merge branch 'master' into storyboard-skin-sprites	2020-10-20 23:01:54 +02:00
Bartłomiej Dach	58a54c5b6c	Utilise UseSkinSprites value in storyboard sprite logic	2020-10-20 23:01:25 +02:00
Bartłomiej Dach	cdd56ece87	Read UseSkinSprites when decoding storyboards	2020-10-20 22:49:56 +02:00
Bartłomiej Dach	e54836a63e	Use SkinnableSprite to avoid unnecessary reloads	2020-10-20 22:49:56 +02:00
Dean Herbert	8273715bde	Merge pull request #9484 from FlashyReese/visible-playfield-boundary	2020-10-20 19:43:41 +09:00
Dan Balasescu	bd4e0e1a60	Merge branch 'master' into epilepsy-warning	2020-10-20 17:43:37 +09:00
Dan Balasescu	5fe38533e2	Merge branch 'master' into hide-hud-during-break-time	2020-10-20 15:39:35 +09:00
Dean Herbert	55d08fad5c	Remove unused field	2020-10-20 15:18:15 +09:00
Dean Herbert	411ae38605	Remove unused using	2020-10-20 15:06:31 +09:00
Dean Herbert	7a68636f71	Adjust fade sequence and durations to feel better	2020-10-20 15:03:33 +09:00
Dean Herbert	4e57751ca1	Fix background dim application to avoid overdraw, transition smoother	2020-10-20 15:03:12 +09:00
Dan Balasescu	1fe987d4b3	Merge pull request #10497 from peppy/beatmap-carousel-less-diffcalc-stutter ... Disable difficulty calculation for set-level difficulty icons	2020-10-20 14:57:34 +09:00
Dan Balasescu	976f96b51d	Merge branch 'master' into beatmap-carousel-refactor-less-alloc-overhead	2020-10-20 14:26:23 +09:00
Dan Balasescu	13060b8575	Merge branch 'master' into beatmap-carousel-less-diffcalc-stutter	2020-10-20 14:26:16 +09:00
Dan Balasescu	f35611b452	Merge pull request #10494 from peppy/beatmap-carousel-refactor ... Add beatmap set level pooling to beatmap carousel	2020-10-20 14:25:56 +09:00
Dean Herbert	4f8a755518	Add "hide during gameplay" mode	2020-10-20 14:20:44 +09:00
Dean Herbert	024009e174	Change default to "always visible"	2020-10-20 14:19:15 +09:00
Dean Herbert	80b1f816c7	Merge branch 'master' into hide-hud-during-break-time	2020-10-20 14:19:04 +09:00
Dean Herbert	267b399f9f	Add some simple border styles	2020-10-20 13:59:03 +09:00
Dean Herbert	c57fecd1fc	Update comment to make it clear this is a hack	2020-10-20 12:43:57 +09:00
Bartłomiej Dach	fd4bab85cf	Merge branch 'master' into epilepsy-warning	2020-10-20 01:06:46 +02:00
Bartłomiej Dach	05251c646e	Fade volume back up on pop out	2020-10-20 01:06:20 +02:00
Bartłomiej Dach	1fc22bdbff	Only show warning once on given map	2020-10-20 00:59:36 +02:00
Bartłomiej Dach	a164d330e5	Improve feel of transition	2020-10-20 00:51:31 +02:00
Bartłomiej Dach	1238e6c30f	Add flag value to database ... Unfortunately required, as loadBeatmaps() refreshes the decoded beatmap with the database-stored values, which can end up overwriting the decoded ones.	2020-10-20 00:46:08 +02:00
Bartłomiej Dach	6e50ae0458	Reformulate push sequence code	2020-10-20 00:22:30 +02:00
Bartłomiej Dach	8505903041	Move warning construction to load()	2020-10-20 00:08:05 +02:00
Bartłomiej Dach	a9f27a71a2	Fix code formatting issues	2020-10-19 23:53:41 +02:00
Bartłomiej Dach	aeca61eb3e	Split warning to separate file	2020-10-19 23:48:02 +02:00
Bartłomiej Dach	44279ed347	Remove unused using directive	2020-10-19 23:46:09 +02:00
Salman Ahmed	6e4b28ed1e	Different version of epilepsy warning display	2020-10-20 00:32:44 +03:00
Bartłomiej Dach	ba818e3ae0	Merge branch 'master' into results-dynamic-pp-calc	2020-10-19 21:41:07 +02:00
Joehu	fef6e55b39	Remove unused using and field	2020-10-19 12:32:16 -07:00
Bartłomiej Dach	7c388f1132	Move editor playfield border locally to osu! composer	2020-10-19 21:20:13 +02:00
Bartłomiej Dach	bca0539735	Move setting to osu! ruleset subsection	2020-10-19 21:05:21 +02:00
Joehu	dbda18acea	Fix autoplay/replay settings going off screen on some legacy skins	2020-10-19 12:04:23 -07:00
Bartłomiej Dach	4267d23d59	Move border to more appropriate namespace	2020-10-19 20:56:34 +02:00
Bartłomiej Dach	4af3fd1ed6	Allow toggling border on & off during gameplay	2020-10-19 20:41:45 +02:00
Bartłomiej Dach	053c7a69a6	Fix code style issues & compilation failures	2020-10-19 20:22:48 +02:00
Dean Herbert	85790d8569	Merge branch 'master' into beatmap-carousel-refactor	2020-10-19 20:46:55 +09:00
Dan Balasescu	b9c1d21743	Merge pull request #10559 from peppy/fix-migration-test-failures ... Fix migration test failures due to finalizer disposal of LocalConfigManager	2020-10-19 20:26:20 +09:00
Dean Herbert	d5940193a2	Ensure visible items is greater than zero before trying to display a range	2020-10-19 19:55:20 +09:00
Dean Herbert	9106e97c37	Ensure max value in clamp is at least zero	2020-10-19 19:10:01 +09:00
Dan Balasescu	534088c66b	Merge branch 'master' into fix-legacy-score-display-fixed-width	2020-10-19 19:04:20 +09:00
Dean Herbert	28eae5d26b	Fix migration test failures due to finalizer disposal of LocalConfigManager	2020-10-19 19:03:22 +09:00
Dean Herbert	002ade51fc	Merge pull request #9816 from voidedWarranties/duplicate-multi-room	2020-10-19 19:02:03 +09:00
Dean Herbert	9792ac2fbd	Merge branch 'master' into beatmap-carousel-refactor	2020-10-19 18:44:07 +09:00
Dean Herbert	46d17d3857	Merge branch 'master' into beatmap-carousel-refactor	2020-10-19 18:43:17 +09:00
Dean Herbert	51e9a91343	Merge pull request #10493 from peppy/update-framework	2020-10-19 18:42:55 +09:00
Dean Herbert	1c2185e969	Replace comment with link to issue	2020-10-19 18:41:28 +09:00
Dean Herbert	044622a7a6	Fix out of bounds issues	2020-10-19 18:41:17 +09:00
Dean Herbert	22bde43106	Merge branch 'master' into visible-playfield-boundary	2020-10-19 18:05:28 +09:00
Dean Herbert	b940a7cee2	Merge pull request #10235 from Joehuu/fix-tournament-ruleset-dropdown-anchor	2020-10-19 17:46:15 +09:00
Dean Herbert	d1eafc9934	Merge pull request #8136 from Game4all/fix-login-placeholder-inheritance	2020-10-19 17:45:54 +09:00
Dean Herbert	437ca91b94	Use DI to open the copy rather than passing in an ugly action	2020-10-19 17:23:04 +09:00
Dean Herbert	6d22f0e196	Use existing copy method and update xmldoc	2020-10-19 17:15:13 +09:00
Dan Balasescu	5333319482	Merge pull request #10401 from LittleEndu/score-test ... Expand ScoreProcessor tests	2020-10-19 17:03:59 +09:00
Dean Herbert	61a43770bd	Merge branch 'master' into duplicate-multi-room	2020-10-19 16:58:45 +09:00
Dean Herbert	79a17b2371	Reapply waveform colour fix	2020-10-19 16:57:08 +09:00
Dean Herbert	401dd2db37	Update framework	2020-10-19 16:55:00 +09:00
Dean Herbert	ca1c287664	Merge pull request #9256 from MiraiSubject/tourney-asset-refactor	2020-10-19 16:42:09 +09:00
Dean Herbert	d6efa3069a	Merge branch 'master' into fix-login-placeholder-inheritance	2020-10-19 16:25:44 +09:00
Dean Herbert	f597572d73	Add comment with reasoning for TopRight anchor	2020-10-19 16:02:39 +09:00
Dean Herbert	03f336feb5	Merge branch 'master' into fix-tournament-ruleset-dropdown-anchor	2020-10-19 15:57:19 +09:00
Dan Balasescu	fe51236c00	Merge branch 'master' into score-test	2020-10-19 15:55:52 +09:00
Dan Balasescu	b5cadd6a2c	Merge pull request #10555 from peppy/fix-score-display-zero-padding ... Fix incorrect zero padding for classic scoring mode	2020-10-19 15:54:12 +09:00
Dean Herbert	31f6051db9	Add missing xmldoc	2020-10-19 15:36:27 +09:00
Dean Herbert	39cf27637e	Update to use virtual methods instead of reconstructing TextBuilder	2020-10-19 14:59:03 +09:00
Dean Herbert	f218a32e5f	Merge branch 'master' into tourney-asset-refactor	2020-10-19 14:42:52 +09:00
Dean Herbert	ba99c5c134	Remove rolling delay on default combo counter	2020-10-19 14:39:02 +09:00
Dean Herbert	cdb649476b	Allow legacy text to display fixed width correctly	2020-10-19 14:33:53 +09:00
Dean Herbert	e3b47083fc	Add "scoring" as keyword to more easily find score display mode setting	2020-10-19 14:05:41 +09:00
Dean Herbert	cb1784a846	Fix score displays using non-matching zero padding depending on user score display mode	2020-10-19 14:05:28 +09:00
Dan Balasescu	408183fdf9	Merge pull request #10553 from bdach/fix-key-counter-order ... Fix key counter actions displaying out of order	2020-10-19 13:44:08 +09:00
Dean Herbert	467bb9b96f	Merge branch 'master' into beatmap-carousel-refactor	2020-10-19 13:17:11 +09:00
Dean Herbert	bff3856c83	Account for panel height when removing as off-screen	2020-10-19 13:13:32 +09:00
Dean Herbert	ee0efa0b4c	Fix off-by-one in display range retrieval logic	2020-10-19 13:05:42 +09:00
Dean Herbert	4590d9b93b	Remove outdated comment logic	2020-10-19 13:04:12 +09:00
Bartłomiej Dach	5b96f01564	Fix key counter actions displaying out of order	2020-10-18 19:21:36 +02:00
Bartłomiej Dach	a5b0307cfb	Apply same fix to legacy accuracy counter	2020-10-17 15:39:26 +02:00
Bartłomiej Dach	0acc86f757	Split line for readability	2020-10-17 15:39:25 +02:00
unknown	bba9a0b2fe	set sprite text anchor and origin to top right	2020-10-17 00:25:16 +08:00
Dean Herbert	daa0a05d9e	Merge pull request #10534 from smoogipoo/fix-ef-ordinal-warning ... Silence EF warning due to ordinal being unsupported	2020-10-17 00:19:42 +09:00
Dan Balasescu	dff2ba6e5d	Merge pull request #10531 from peppy/fix-accuracy-scale ... Adjust accuracy display to match stable	2020-10-16 23:52:30 +09:00
Dan Balasescu	b7c12ff61e	Merge pull request #10530 from peppy/fix-catch-dual-combo-counter ... Fix osu!catch showing two combo counters for legacy skins	2020-10-16 23:52:14 +09:00
smoogipoo	6385d5f369	Replace with local tolist	2020-10-16 23:40:44 +09:00
smoogipoo	81cc5e1c42	Silence EF warning due to ordinal being unsupported	2020-10-16 23:31:37 +09:00
smoogipoo	2586990301	Update resources	2020-10-16 23:19:34 +09:00
smoogipoo	dfbc0965e4	Merge branch 'master' into peppy/skinnable-health-display	2020-10-16 23:17:17 +09:00
Dean Herbert	e87f515a4f	Merge pull request #10522 from Morilli/legacyskin-fixes ... Add support for ScorePrefix and ScoreOverlap values in legacy skins	2020-10-16 20:54:03 +09:00
Berkan Diler	fe3a23750c	Use char overloads for string methods	2020-10-16 11:52:29 +02:00
Dean Herbert	2ba8bc45fd	Also add slight adjustment to score display	2020-10-16 18:37:24 +09:00
Dean Herbert	cbaad4eb56	Adjust accuracy display to match stable	2020-10-16 18:34:14 +09:00
Berkan Diler	cc11283143	Use string.Starts-/EndsWith char overloads	2020-10-16 11:27:02 +02:00
Dean Herbert	8a3bce3cc3	Fix osu!catch showing two combo counters for legacy skins	2020-10-16 18:20:17 +09:00
Dean Herbert	a774de2270	Also add support in LegacyComboCounter	2020-10-16 17:52:22 +09:00
Dean Herbert	24b0a1b84b	Switch to direct casts (we can be sure LegacySpriteText is present at this point)	2020-10-16 17:40:07 +09:00
Dean Herbert	3ce6d1fea1	Remove unnecessary AccuracyText enum ... All elements use "score" regardless.	2020-10-16 17:36:54 +09:00
Dean Herbert	e9c4b67cf4	Inline variable	2020-10-16 17:35:35 +09:00
Dean Herbert	05f1017c28	Fix lookup check not being updated to use prefix	2020-10-16 17:35:21 +09:00
Dean Herbert	a1892aa0a7	Only additive flash explosions over the epic cutoff	2020-10-16 17:25:55 +09:00
Dean Herbert	77bf050a80	Ignore IgnoreHits for flashiness	2020-10-16 17:24:43 +09:00
Dean Herbert	9572260e6d	Add bulge and explode support	2020-10-16 17:09:00 +09:00
Dean Herbert	8104bd0f74	Add fill colour changes	2020-10-16 17:08:46 +09:00
Dean Herbert	5803c72b4c	Add support for old marker style danger textures	2020-10-16 17:08:46 +09:00
Dean Herbert	f0b15813e2	Add support for both legacy styles	2020-10-16 17:08:46 +09:00
Dean Herbert	bdebf2f1a4	Fix skinnable test scene still not working with dynamic compilation	2020-10-16 17:08:46 +09:00
Dean Herbert	6d3a106a86	Simplify texture lookups	2020-10-16 17:08:46 +09:00
Dean Herbert	f28bcabae7	Avoid transforms per hp change	2020-10-16 17:08:46 +09:00
Dean Herbert	a810f56ec8	Move "flash on hit only" logic to binding	2020-10-16 17:08:46 +09:00
Dean Herbert	5be9e30cd0	Add legacy implementation	2020-10-16 17:08:46 +09:00
Dean Herbert	e89c5c3b3c	Add dynamic compile exceptions to fix skin test scenes	2020-10-16 17:08:46 +09:00
Dean Herbert	c0a1f2158c	Add basic component structure for skinnable health displays	2020-10-16 17:08:46 +09:00
Morilli	df1db8611c	move skin-specific config retrieval to GetDrawableComponent	2020-10-16 08:36:20 +02:00
Dan Balasescu	829241a9f0	Merge pull request #10521 from peppy/fix-editor-seek-interval-when-playing ... Fix editor not seeking by full beat when track is playing	2020-10-16 13:55:03 +09:00
Dan Balasescu	39a0653859	Merge pull request #10520 from peppy/string-function-culture-inspections ... Enable string StartsWith/EndsWith culture inspections and fix usages	2020-10-16 13:54:52 +09:00
Dean Herbert	83482ca15c	Fix one more missed occurrence	2020-10-16 13:21:47 +09:00
Morilli	085d8d0ecb	Add support for ScorePrefix and ScoreOverlap values in legacy skins	2020-10-16 06:16:20 +02:00
Dean Herbert	aea31d1582	Fix editor not seeking by full beat when track is playing ... This is expected behaviour as my osu-stable, and I still stand behind the reasoning behind it. Closes #10519.	2020-10-16 13:07:00 +09:00
Dean Herbert	88ffcb9234	Update EndsWith usages	2020-10-16 12:58:34 +09:00
Dean Herbert	88f74921fb	Update with new r# inspections	2020-10-16 12:49:39 +09:00
Dean Herbert	cc41845f56	Add missing string function ordinal specifications	2020-10-16 12:49:31 +09:00
Dean Herbert	703f58bb2f	Remove last.fm support ... Has been broken for ages, and their service isn't really something people use these days.	2020-10-16 11:54:11 +09:00
Dan Balasescu	583fdc3a95	Merge pull request #10510 from peppy/skinnable-accuracy-display ... Add legacy skinning support for accuracy display	2020-10-15 21:20:48 +09:00
Dan Balasescu	5d8cf87155	Merge pull request #10511 from peppy/bottom-error-display ... Add support for bottom-anchored hit error display	2020-10-15 20:51:09 +09:00
Dan Balasescu	70b050f212	Merge branch 'master' into skinnable-accuracy-display	2020-10-15 20:28:57 +09:00
Dan Balasescu	1ce0e83e59	Merge branch 'master' into skinnable-score-display	2020-10-15 19:16:03 +09:00
Dan Balasescu	93dfbd5d9e	Merge pull request #10505 from peppy/skin-disabler-refactor ... Move ISampleDisabler implementation to Player and FrameStabilityContainer	2020-10-15 19:14:52 +09:00
Dean Herbert	70806deba1	Add support for bottom-anchored hit error display	2020-10-15 19:14:02 +09:00
Dan Balasescu	bfffad8fdb	Merge pull request #10504 from peppy/skinnable-combo-counter ... Add legacy skinning support for combo counter	2020-10-15 19:11:22 +09:00
Dean Herbert	d76365ed1b	Make container readonly	2020-10-15 18:38:41 +09:00
Dan Balasescu	5640d33d1a	Merge branch 'master' into skin-disabler-refactor	2020-10-15 18:32:50 +09:00
Dean Herbert	6983978c98	Correct top-right element offset by finding the lower top anchor element	2020-10-15 18:30:44 +09:00
Dan Balasescu	2beddf5351	Merge pull request #10495 from FamousPig/mod-customisation-absorb-mouse-input ... Fix mod customisation container not absorbing input	2020-10-15 18:25:44 +09:00
Dean Herbert	ca74cf824c	Add padding	2020-10-15 18:24:28 +09:00
Dan Balasescu	190f3f36ce	Merge branch 'master' into skinnable-combo-counter	2020-10-15 18:13:00 +09:00
Dan Balasescu	a9075fc47c	Merge pull request #10502 from peppy/hud-available-area ... Confine available area for HUD components to exclude the song progress area	2020-10-15 18:12:49 +09:00
Dean Herbert	b31a3fbabb	Add test	2020-10-15 18:11:30 +09:00
Dean Herbert	4f6dd15869	Add legacy font lookup support for comma/percent	2020-10-15 17:56:37 +09:00
Dean Herbert	254eba9008	Add and consume skinnable accuracy counter	2020-10-15 17:53:16 +09:00
Dean Herbert	90ff8ff050	Merge branch 'skinnable-combo-counter' into skinnable-score-display	2020-10-15 17:52:06 +09:00
Dean Herbert	37e9f331ad	Simplify score font lookup	2020-10-15 17:49:55 +09:00
Dean Herbert	43e5cb90e2	Merge branch 'skinnable-combo-counter' into skinnable-score-display	2020-10-15 17:30:29 +09:00
Dean Herbert	9f51327e4b	Fix completely incorrect default positioning logic	2020-10-15 17:29:40 +09:00
Dean Herbert	5b5ba7df93	Remove unused offset	2020-10-15 17:22:34 +09:00
Dean Herbert	d8d085ede9	Align top-right elements with lowest point in score display	2020-10-15 17:14:42 +09:00
Dean Herbert	74c031cfbb	Fix ModOverlay not including "UNRANKED" text in size	2020-10-15 17:14:42 +09:00
Dean Herbert	b210147c2e	Update combo counter to read from default score display's position correctly	2020-10-15 17:14:42 +09:00
Dean Herbert	950c47287c	Fix positioning of score display in HUD overlay	2020-10-15 17:14:42 +09:00
Dean Herbert	e1da64398e	Add and consume skinnable score counter	2020-10-15 17:14:42 +09:00
Dean Herbert	219cbec6bd	Split out DefaultScoreCounter and make ScoreCounter abstract	2020-10-15 16:32:30 +09:00
Dean Herbert	d5f2aab52e	Tidy up SkinnableComboCounter class slightly	2020-10-15 15:37:40 +09:00
Bartłomiej Dach	c3f1a30447	Merge branch 'master' into mod-customisation-absorb-mouse-input	2020-10-15 00:40:27 +02:00
Dean Herbert	e0210f5c4c	Ignore failed casts to make tests happy	2020-10-14 23:52:58 +09:00
Dean Herbert	ef2e2894a2	Merge branch 'master' into fix-mania-diffcalc	2020-10-14 23:49:14 +09:00
Dean Herbert	1684c4f412	Merge pull request #10503 from smoogipoo/fix-mod-combinations ... Fix MultiMod difficulty calculator combinations not generating correctly	2020-10-14 23:42:59 +09:00
Dean Herbert	8b864c8c22	Merge branch 'master' into fix-multimod-copy	2020-10-14 22:29:38 +09:00
smoogipoo	ed57b1363f	Remove unused usings	2020-10-14 20:08:46 +09:00
smoogipoo	c4fdd35223	Fix same-type incompatibility through multimod	2020-10-14 19:53:37 +09:00
Dean Herbert	e3eaba7b2c	Move ISampleDisabler implementation to Player and FrameStabilityContainer	2020-10-14 19:39:48 +09:00
smoogipoo	e9ebeedbe2	Refactor generation	2020-10-14 19:32:30 +09:00
Dean Herbert	ac4f56403d	Adjust size/position	2020-10-14 19:16:34 +09:00
Dean Herbert	7f5ea57bd4	Clean-up pass (best effort) on LegacyComboCounter	2020-10-14 19:16:34 +09:00
Dean Herbert	9bb8a43bce	Combine LegacyComboCounter and ComboCounter classes	2020-10-14 19:16:34 +09:00
Dean Herbert	fbbea48c8c	Add score text skinnability	2020-10-14 19:16:34 +09:00
Dean Herbert	2fce064e32	Add basic legacy combo counter and updating positioning logic	2020-10-14 19:16:34 +09:00
Dean Herbert	6a6718ebab	Allow bypassing origin/anchor setting of skinnable components ... It makes little sense to set these when using RelativeSizeAxes.Both	2020-10-14 19:16:34 +09:00
Dean Herbert	899bac6ca5	Rename catch combo counter for clarity	2020-10-14 19:16:34 +09:00
Dean Herbert	f5623ee21e	Setup skinnable combo counter component with default implementation	2020-10-14 19:16:34 +09:00
Dean Herbert	60603d2918	Add skin components and interfaces	2020-10-14 19:16:34 +09:00
Dean Herbert	98acf1e31d	Make field read only	2020-10-14 19:16:25 +09:00
smoogipoo	d7a52e97ff	Fix multimod difficulty combinations not generating correctly	2020-10-14 19:03:11 +09:00
Dean Herbert	a7f8e26e35	Adjust bottom-right elements positions based on song progress display	2020-10-14 18:51:53 +09:00
Dean Herbert	0cf3e90904	Update SongProgress height based on its dynamic height during resize	2020-10-14 18:44:22 +09:00
Dean Herbert	ace9fbc8d3	Confine available area for HUD components to excluse the song progress area	2020-10-14 18:44:22 +09:00
smoogipoo	f04aec538f	Fix MultiMod throwing exceptions when creating copies	2020-10-14 18:12:19 +09:00
Dean Herbert	207c409792	Merge branch 'master' into fix-mania-diffcalc	2020-10-14 15:26:32 +09:00
Dean Herbert	3e326a9234	Use bindable flow for event propagation	2020-10-14 15:22:17 +09:00
Dean Herbert	24eff8c66d	Rename container to match "settings" term used everywhere	2020-10-14 15:13:49 +09:00
Dean Herbert	30e1fce7a4	Reduce alloc overhead of DrawableCarouselBeatmapSet using new function-based ctor	2020-10-14 15:10:50 +09:00
Dean Herbert	07e6609e6d	Disable difficulty calculation for set-level difficulty icons	2020-10-14 14:16:22 +09:00
Leon Gebler	3fd913b13f	rename customisation container class	2020-10-13 19:38:25 +02:00
Bartłomiej Dach	1af17fbd5e	Merge branch 'master' into fix-early-break-cull	2020-10-13 18:02:08 +02:00
Leon Gebler	663b806974	move ModSettingsContainer to seperate component	2020-10-13 17:45:40 +02:00
Dean Herbert	e662dc5342	Add missing licence headers	2020-10-13 20:57:26 +09:00
Dean Herbert	8057ea1097	Fix formatting issues	2020-10-13 20:50:36 +09:00
Dean Herbert	3d416f4d64	Clean up beatmapSet resolution in DrawableCarouselBeatmapSet	2020-10-13 19:31:29 +09:00
Dean Herbert	75b6a5e17e	Remove unnecessary hack (fixed via framework update)	2020-10-13 19:31:29 +09:00
Dean Herbert	5d11db7753	Locallise ChildItems to DrawableCarouselBeatmapSet for clarity	2020-10-13 19:31:29 +09:00
Dean Herbert	37daefc2b5	Remove outdated comment	2020-10-13 19:12:33 +09:00
Dean Herbert	8eca28e8bc	Add comment about off-screen loading	2020-10-13 19:10:35 +09:00
Dean Herbert	834b0186f4	Adjust fade duration to be slightly shorter	2020-10-13 18:50:10 +09:00
Dean Herbert	2346644c04	Switch DelayedLoadUnloadWrappers to DelayedLoadWrappers ... Due to pooling usage, there is no time we need to unload. Switching to DelayedLoadWrapper cleans up the code and reduces overhead substantially.	2020-10-13 18:47:40 +09:00
Dean Herbert	a1801f8ae4	Unmark todo for now	2020-10-13 18:47:36 +09:00
Dean Herbert	40a0ab7aaa	Avoid allocating CarouselItems for bounds checks	2020-10-13 18:33:31 +09:00
Dean Herbert	4f4f222514	Remove unnecessary fade (already applied by base DrawableCarouselItem)	2020-10-13 18:28:28 +09:00
Dean Herbert	83358d487f	Remove logging	2020-10-13 18:18:22 +09:00
Dean Herbert	3d9ea852ec	Remove masking override (no longer needed as our size is now correct)	2020-10-13 18:14:23 +09:00
Dean Herbert	69650c16fc	Simplify vertical position calculations by including spacing in height definition	2020-10-13 18:13:36 +09:00
Dean Herbert	b1ddb08a4e	Fix right click context menus appearing in incorrect locations	2020-10-13 18:01:12 +09:00
Dean Herbert	d9a6a6b245	Split content out into own class	2020-10-13 18:01:12 +09:00
Dean Herbert	9b2ebb8f0f	Fix main content DelayedLoadUnloadWrapper not getting a valid size before load	2020-10-13 17:45:41 +09:00
Dean Herbert	f3b937e358	Fix masking issues with certain aspect ratio displays	2020-10-13 17:37:33 +09:00
Dean Herbert	fdd4d95cdc	Fix difficulties being at incorrect vertical positions after filter is applied	2020-10-13 17:37:33 +09:00
Dean Herbert	1f0aa974dd	Fix failing tests	2020-10-13 17:37:33 +09:00
Dean Herbert	b536f571fd	Move header height propagation to update for safety	2020-10-13 17:37:33 +09:00
Dean Herbert	ded09b78cb	Avoid usage of AutoSize for DrawableCarouselItems in general	2020-10-13 17:37:33 +09:00
Dean Herbert	cecdf14f53	Avoid reconstructing beatmap difficulties that were recently displayed	2020-10-13 17:37:33 +09:00
Dean Herbert	1da49073ab	Calculate content height automatically	2020-10-13 17:37:33 +09:00
Dean Herbert	c08b5e8d03	Align beatmap difficulties correctly	2020-10-13 17:37:33 +09:00
Dean Herbert	cfec4f4fc1	Extract header element from base DrawableCarouselItem class	2020-10-13 17:37:33 +09:00
Dean Herbert	2aad482545	Fix x offsets of difficulties not being updated	2020-10-13 17:37:33 +09:00
Dean Herbert	1b7e3397c6	Use expiry to avoid ToArray	2020-10-13 17:37:33 +09:00
Dean Herbert	075bf23714	Better track off-screen drawables (and return to pool less often)	2020-10-13 17:37:33 +09:00
Dean Herbert	29983afcef	Replace pool/cleanup logic with simplest form possible ... This will temporarily break panels that go off-screen, as they will disappear immediately	2020-10-13 17:37:33 +09:00
Dean Herbert	06e84c8eb3	Add comments and split out update steps into a more logical flow	2020-10-13 17:37:33 +09:00
Dean Herbert	20b54fb904	Move transform clean-up to pooling free call	2020-10-13 17:37:33 +09:00
Dean Herbert	f6aa448523	Store y positions inside items rather than in a separate array	2020-10-13 17:37:33 +09:00
Dean Herbert	b92c22ad42	Add logging	2020-10-13 17:37:33 +09:00
Dean Herbert	9814e9ba7f	Split classes out to reduce loc burder on DrawableCarouselBeatmapSet	2020-10-13 17:37:33 +09:00
Dean Herbert	975cd5a840	Add back beatmap difficulty appear/disappear movement	2020-10-13 17:37:33 +09:00
Dean Herbert	fd8654cff3	Add back difficulty panel spacing	2020-10-13 17:37:33 +09:00
Dean Herbert	ce67f65084	Fix single results not showing up	2020-10-13 17:37:33 +09:00
Dean Herbert	220c8ba2c4	Fix incorrect vertical offsets when difficulties are filtered away	2020-10-13 17:37:33 +09:00
Dean Herbert	82f9ca3de9	Bind to filter event changes in base drawable item	2020-10-13 17:37:33 +09:00
Dean Herbert	813ee19728	Use existing event flow for rendering beatmap difficulties	2020-10-13 17:37:33 +09:00
Dean Herbert	8847cedf29	Add initial pass of vertical transforms	2020-10-13 17:37:33 +09:00
Dean Herbert	15325f5f51	Base bounds checks on +1 (to avoid worrying about current item heights)	2020-10-13 17:37:33 +09:00
Dean Herbert	bb03c5d77c	Temporarily disable masking temporarily to fix panels disappearing at extents	2020-10-13 17:37:33 +09:00
Dean Herbert	524419d5e4	Fix filtered items being considered for height calculation	2020-10-13 17:37:33 +09:00
Dean Herbert	0a144a1388	Correctly free panels after use to avoid finalizer disposal of subtree	2020-10-13 17:37:33 +09:00
Dean Herbert	c5a6f4b453	Fix scroll to selected beatmap	2020-10-13 17:37:33 +09:00
Dean Herbert	5c29aa8cce	Fix multiple difficulties being expanded at once	2020-10-13 17:37:33 +09:00
Dean Herbert	5c2f134665	Add back left offset for selected set	2020-10-13 17:37:33 +09:00
Dean Herbert	3cfc0dc82d	Add safeties to beatmap panel loading code	2020-10-13 17:37:33 +09:00
Dean Herbert	954d43ef56	Debounce state application events	2020-10-13 17:37:33 +09:00
Dean Herbert	ca1f5dcada	Add back panel padding	2020-10-13 17:37:33 +09:00
Dean Herbert	0400b34349	Load more components asynchronously after pool resolution	2020-10-13 17:37:33 +09:00
Dean Herbert	f3b24b9bb5	Avoid performing eager selection constantly on adding ranges of new children	2020-10-13 17:37:33 +09:00
Dean Herbert	0a978c6131	Add basic pooling setup	2020-10-13 17:37:33 +09:00
Dean Herbert	f17d661c1a	Add basic range-based invalidation	2020-10-13 17:37:33 +09:00
Dean Herbert	3143224e5b	Refactor how drawable carousel items are constructed	2020-10-13 17:37:33 +09:00
Dean Herbert	9193f5b0ba	Expose panel height from non-drawable models	2020-10-13 17:37:33 +09:00
Dean Herbert	a393bbe8f7	Remove direct drawable storage from carousel models	2020-10-13 17:37:33 +09:00
Dean Herbert	b08e7ce1f5	Update BaseColour specification	2020-10-13 17:37:24 +09:00
Dean Herbert	41d82e3e8a	Update framework	2020-10-13 17:34:11 +09:00
Bartłomiej Dach	68b505ab86	Extract helper function for pp value handling	2020-10-12 22:14:45 +02:00
Bartłomiej Dach	d4ba9d2682	Simplify implementation of CalculatePerformanceAsync	2020-10-12 22:10:02 +02:00
Bartłomiej Dach	7117fd0fba	Add xmldoc and nullability annotations	2020-10-12 21:44:04 +02:00
Bartłomiej Dach	779e6e10a7	Split ctors to avoid passing fields one by one	2020-10-12 21:43:14 +02:00
Leon Gebler	1a85123b89	rename container class to be more descriptive	2020-10-12 21:24:42 +02:00
Leon Gebler	7df9282727	CodeAnalysis fixes	2020-10-12 15:58:34 +02:00
Dean Herbert	5ff61142ad	Merge pull request #10489 from smoogipoo/fix-convert-difficulty-icons ... Fallback to default ruleset star rating if conversion fails	2020-10-12 21:57:13 +09:00
smoogipoo	372761a46f	More/better commenting	2020-10-12 19:22:34 +09:00
smoogipoo	eb4ef157ca	Fix implicit segments not being constructed correctly	2020-10-12 19:16:37 +09:00
smoogipoo	48c0ae40ef	Fix multi-segment sliders not parsing correctly	2020-10-12 18:04:28 +09:00
smoogipoo	ccf7e2c49a	Fallback to default ruleset star rating if conversion fails	2020-10-12 16:31:42 +09:00
smoogipoo	379971578d	Remove culling notice from HasEffect	2020-10-12 15:28:16 +09:00
Leon Gebler	e5548a1216	Move ModSettingsContainer class inside ModSelectOverlay	2020-10-12 00:16:18 +02:00
Dean Herbert	8431a5a23c	Merge pull request #10483 from Joehuu/add-extended-stats-keyboard-shortcut	2020-10-11 22:48:42 +09:00
Dean Herbert	a246991c50	Merge pull request #10472 from LeNitrous/expose-player-isbreaktime ... Expose BreakTracker.IsBreakTime in Player	2020-10-11 22:36:24 +09:00
Dean Herbert	de6fe34361	Bind to local bindable and combine dual bindings	2020-10-11 21:51:48 +09:00
Dean Herbert	5fcdee6fd8	Remove cast and expose as IBindable	2020-10-11 21:46:55 +09:00
Joehu	8faa86b048	Add ability to toggle extended statistics using space or enter	2020-10-10 18:32:22 -07:00
unknown	6a52c98a42	make IsBreakTime its own bindable and bind it to BreakTracker on load	2020-10-11 06:15:20 +08:00
Dean Herbert	16a78b3172	Merge pull request #10478 from bdach/fix-beatmap-difficulty-rating-rounding ... Apply rounding when calculating beatmap difficulty rating	2020-10-11 03:36:59 +09:00
Lucas A	e845cc92b8	Round pp values to nearest integer.	2020-10-10 19:58:06 +02:00
Bartłomiej Dach	09f3c0f091	Merge branch 'master' into search-via-online-id	2020-10-10 19:40:25 +02:00
Lucas A	a0e6226b7a	Rename LocalId -> LocalScoreID	2020-10-10 19:19:24 +02:00
Lucas A	de522d53ea	Make CalculatePerformanceAsync() nullable.	2020-10-10 19:16:21 +02:00
Bartłomiej Dach	8af78656e4	Add precision tolerance to difficulty rating range checks	2020-10-10 18:15:52 +02:00