1
0
mirror of https://github.com/ppy/osu.git synced 2025-02-13 14:13:18 +08:00

Temporarily disable masking temporarily to fix panels disappearing at extents

This commit is contained in:
Dean Herbert 2020-10-12 19:11:02 +09:00
parent 524419d5e4
commit bb03c5d77c
2 changed files with 5 additions and 1 deletions

View File

@ -571,7 +571,7 @@ namespace osu.Game.Screens.Select
updateItems();
// Remove all items that should no longer be on-screen
scrollableContent.RemoveAll(p => p.Y < visibleUpperBound - p.DrawHeight || p.Y > visibleBottomBound || !p.IsPresent);
//scrollableContent.RemoveAll(p => p.Y < visibleUpperBound - p.DrawHeight || p.Y > visibleBottomBound || !p.IsPresent);
// Find index range of all items that should be on-screen
int firstIndex = yPositions.BinarySearch(visibleUpperBound - DrawableCarouselItem.MAX_HEIGHT);

View File

@ -10,6 +10,7 @@ using osu.Framework.Graphics;
using osu.Framework.Graphics.Colour;
using osu.Framework.Graphics.Containers;
using osu.Framework.Graphics.Cursor;
using osu.Framework.Graphics.Primitives;
using osu.Framework.Graphics.Shapes;
using osu.Framework.Graphics.UserInterface;
using osu.Framework.Input.Events;
@ -31,6 +32,9 @@ namespace osu.Game.Screens.Select.Carousel
{
public const float HEIGHT = MAX_HEIGHT;
// TODO: don't do this. need to split out the base class' style so our height isn't fixed to the panel display height (and autosize?).
protected override bool ComputeIsMaskedAway(RectangleF maskingBounds) => false;
private Action<BeatmapSetInfo> restoreHiddenRequested;
private Action<int> viewDetails;