15047 Commits

Author	SHA1	Message	Date
Dean Herbert	02bb506cce	Avoid using .Children for enumeration in other locations	2024-01-23 05:32:11 +09:00
Dean Herbert	069af13aaf	Reduce enumerator overhead in GameplayLeaderboard	2024-01-23 05:31:53 +09:00
Bartłomiej Dach	45dc9de1e0	Remove remnant of old implementation of showing "A due to misses"	2024-01-22 19:58:11 +01:00
Bartłomiej Dach	5bae9074aa	Merge branch 'master' into s-rank-change	2024-01-22 19:54:53 +01:00
Bartłomiej Dach	4cd1573a4c	Merge pull request #26612 from peppy/fix-back-sample-playback ... Fix back sound being too loud when exiting many screens	2024-01-22 16:18:32 +01:00
Bartłomiej Dach	3cf83e7106	Merge pull request #26667 from peppy/fix-star-fountains ... Fix star fountains sometimes resetting visually	2024-01-22 16:13:55 +01:00
Bartłomiej Dach	43fa89ebcd	Merge branch 'master' into fix-back-sample-playback	2024-01-22 15:36:32 +01:00
Bartłomiej Dach	9aa7c7f591	Revert incorrect removal of exitConfirmed flag ... Removing it meant that it was _literally impossible_ to exit multiplayer.	2024-01-22 15:35:03 +01:00
Bartłomiej Dach	49c117793c	Merge pull request #26609 from peppy/fix-per-ruleset-hud-positioning ... Fix gameplay elements not correctly offsetting to avoid per-ruleset skin layout	2024-01-22 15:00:03 +01:00
Bartłomiej Dach	95435ecd13	Merge pull request #26591 from peppy/offset-awareness ... Show offset explanation tooltip on settings offset adjust slider bar	2024-01-22 14:59:31 +01:00
Bartłomiej Dach	b8dd78eec8	Merge branch 'master' into fix-per-ruleset-hud-positioning	2024-01-22 13:55:56 +01:00
Dean Herbert	15df6b1da1	Revert keyboard seek speed change	2024-01-22 21:47:38 +09:00
Bartłomiej Dach	99d3fcc326	Fix crash if ruleset components container is not present	2024-01-22 13:45:55 +01:00
Dean Herbert	83f9118b22	Adjust results screen to handle S->A rank adjustment when misses are present	2024-01-22 21:43:32 +09:00
Bartłomiej Dach	0d6c681275	Merge pull request #26649 from peppy/fix-more-allocations ... Remove `FillFlow` overhead of argon counters	2024-01-22 12:57:16 +01:00
Bartłomiej Dach	b7f0102461	Merge pull request #26662 from peppy/fix-player-crash ... Fix potential null reference in player screen transition handling	2024-01-22 11:07:16 +01:00
Dean Herbert	cd551b1abd	Fix star fountains sometimes resetting visually ... Addresses https://github.com/ppy/osu/discussions/26622.	2024-01-22 18:01:21 +09:00
Bartłomiej Dach	1ac682e2c9	Merge branch 'master' into replay-seek-single-frame	2024-01-22 09:36:15 +01:00
Dean Herbert	3dd18c777a	Remove a couple more overrides	2024-01-22 17:00:35 +09:00
Dean Herbert	f6fa965252	Merge pull request #26661 from frenzibyte/fix-mouse-blueprint ... Fix blueprint container not handling right clicks correctly while moving a blueprint	2024-01-22 16:53:54 +09:00
Bartłomiej Dach	493d495992	Merge pull request #26605 from peppy/simplify-gameplay-pause ... Simplify gameplay pause sequence	2024-01-22 08:49:08 +01:00
Dean Herbert	3e5fe66e58	Fix potential null reference in player screen transition handling ... See https://github.com/ppy/osu/actions/runs/7607677219/job/20715418536?pr=26660.	2024-01-22 16:37:56 +09:00
Dean Herbert	1f0ad5cff2	Apply same fix in more places	2024-01-22 15:56:16 +09:00
Dean Herbert	74f05a5c4b	Use container itself rather than ScrollContent	2024-01-22 15:54:24 +09:00
Salman Ahmed	2bd9cd5d34	Fix blueprint container not handling right clicks correctly while moveing an element	2024-01-22 04:39:08 +03:00
Andrei Zavatski	cec4f670d1	Reduce allocation overhead in BeatmapCarousel	2024-01-22 03:12:23 +03:00
Dean Herbert	02369139b3	Remove FillFlow overhead of argon counters	2024-01-21 13:22:58 +09:00
OliBomby	78e87d379b	fix divide by zero	2024-01-20 16:53:11 +01:00
OliBomby	5f40d3aed9	rename variable	2024-01-20 16:29:26 +01:00
OliBomby	9b9485f656	fix adjust axes detection	2024-01-20 15:39:38 +01:00
OliBomby	1596776a81	fix imports	2024-01-20 15:15:49 +01:00
OliBomby	0fc448f4f3	fix adjusting scale from anchor	2024-01-20 15:12:48 +01:00
OliBomby	6a4129dad8	fix aspect ratio transform	2024-01-20 15:11:35 +01:00
OliBomby	fcaa5ec20e	remove debug logs	2024-01-20 13:26:08 +01:00
OliBomby	6a57be0a50	clean up code and fix flipping	2024-01-20 13:04:05 +01:00
OliBomby	a4f771ec08	refactor CanScale properties	2024-01-20 01:13:01 +01:00
OliBomby	26c0d1077a	Refactor scale handling in editor to facilitate reuse	2024-01-20 00:22:53 +01:00
Dean Herbert	c50534c819	Move seek/step logic into ReplayPlayer	2024-01-18 20:38:15 +09:00
Dean Herbert	8c4af58109	Keep replay controls expanded by default	2024-01-18 20:13:32 +09:00
Dean Herbert	60e972cd15	Add ability to step forward/backwards single frames	2024-01-18 20:13:32 +09:00
Dean Herbert	dafff26d0e	Tidy up implementation of PlaybackSettings	2024-01-18 20:13:32 +09:00
Dean Herbert	c4e9bcd140	Remove test guarantee of audio time not advancing	2024-01-18 20:06:53 +09:00
Bartłomiej Dach	2be989b9f5	Merge pull request #26542 from peppy/non-touch-fade-button ... Fade hold-for-menu button out completely on non-touch devices	2024-01-18 11:27:50 +01:00
Dean Herbert	fd9c7184e4	Only play back sample once when traversing up multiple screens in stack	2024-01-18 16:31:33 +09:00
Dean Herbert	ef0b5c9406	Stop playing back samples for nested screens in multiplayer ... I'd argue this sounds better.	2024-01-18 16:31:20 +09:00
Dean Herbert	ee3de9c522	Fix gameplay elements not correcly offsetting to avoid per-ruleset skin layout ... Closes https://github.com/ppy/osu/issues/26601.	2024-01-18 15:44:27 +09:00
Dean Herbert	8ab8c90e33	Remove "pause rate adjust" flow	2024-01-18 14:21:02 +09:00
Dean Herbert	799c74cfe5	Simplify gameplay pause sequence	2024-01-18 14:17:19 +09:00
smallketchup82	060ea1d4fd	Switch from using a constructor argument to using a public field for ShowExtendedTooltip	2024-01-17 14:04:13 -05:00
smallketchup82	b6422bc8bd	Apply suggested changes ... - Change difficultyicon mods parameter docstring to be more professional - Add a parameter for controlling whether the difficulty statistics show or not. Defaults to false - Round the BPM in the tooltip to make sure it displays correctly	2024-01-17 09:07:17 -05:00
Bartłomiej Dach	b718897b30	Merge pull request #26593 from peppy/rolling-counter-unstick ... Change rolling counters to use quicker easing types	2024-01-17 14:37:52 +01:00
Dean Herbert	6a8a45bb13	Merge pull request #26585 from frenzibyte/fix-editor-ux ... Fix timing point changes not applying after selecting another one	2024-01-17 19:53:35 +09:00
Bartłomiej Dach	5cb17bcacf	Merge pull request #26502 from frenzibyte/prevent-submission-with-invalid-mods ... Add guard against submitting score with invalid mod instances	2024-01-17 11:39:32 +01:00
Dean Herbert	456a8e6e82	Merge pull request #26549 from bdach/hit-error-meter-pooling-bad ... Fix `ColourHitErrorMeter` not loading pooled drawables ahead of time	2024-01-17 18:43:47 +09:00
Dean Herbert	a66ddc7813	Change rolling counters to use quicker easing types	2024-01-17 18:18:53 +09:00
Dean Herbert	cc7be137bc	Show tooltip on global offset adjust slider bar	2024-01-17 17:57:49 +09:00
Dean Herbert	123e36a999	Change display text for beatmap audio offset adjust to make more sense	2024-01-17 17:51:46 +09:00
Dean Herbert	c1c2e61723	Merge pull request #26446 from LeNitrous/add/replay-playback-controls ... Add replay playback controls	2024-01-17 17:06:15 +09:00
Dean Herbert	e97b31d82e	Fix test failures	2024-01-17 16:40:45 +09:00
Dean Herbert	e7732caaf7	Make PlayerSettingsOverlay's api more stringent	2024-01-17 15:13:59 +09:00
Dean Herbert	2788bd912e	Add tooltips and localisation	2024-01-17 15:12:33 +09:00
Dean Herbert	e53989faeb	Change replay playback adjustment to skew frequency, not tempo	2024-01-17 15:02:42 +09:00
Dean Herbert	042e852a3e	Adjust playback speed range to allow slower minimum speed	2024-01-17 15:02:42 +09:00
Dean Herbert	42f64c2c44	Move load procedure to async method and simplify code	2024-01-17 15:02:42 +09:00
Salman Ahmed	46429c5074	Schedule control point switch for settings modifications to apply first	2024-01-17 08:15:01 +03:00
Bartłomiej Dach	a9d086c119	Fix touch device not always activating when it should ... See https://github.com/ppy/osu/discussions/26574	2024-01-16 17:12:40 +01:00
Dean Herbert	2be8d66d4c	Fix argon health bar showing "miss" bar for bananas	2024-01-16 15:52:18 +09:00
Dean Herbert	34905b2052	Apply NRT to new classes	2024-01-16 14:17:21 +09:00
Dean Herbert	1fd85b79db	Merge branch 'master' into argon-health-rework	2024-01-16 13:35:29 +09:00
Bartłomiej Dach	97e08f5071	Fix ColourHitErrorMeter not loading pooled drawables ahead of time	2024-01-15 21:40:07 +01:00
Bartłomiej Dach	744cb8e10c	Merge pull request #26538 from peppy/save-multiplayer-filter-mode ... Remember multiplayer room filter mode	2024-01-15 19:53:50 +01:00
Bartłomiej Dach	a41108057f	Merge pull request #26287 from wooster0/no-scores-yet ... Don't leave scores screen empty if no scores are present yet	2024-01-15 19:49:20 +01:00
Bartłomiej Dach	c5a276a7de	Merge pull request #26543 from peppy/offset-toast-limit ... Only display offset toast when in local gameplay	2024-01-15 19:19:21 +01:00
Bartłomiej Dach	4d39c91972	Merge pull request #26449 from peppy/playlist-room-buttons ... Allow interacting with playlist item buttons when not selected	2024-01-15 19:12:01 +01:00
Andrei Zavatski	8661edfc2f	Organize consts better	2024-01-15 21:07:12 +03:00
Bartłomiej Dach	9d2c82452c	Revert "simplify the code even more" ... This reverts commit 9bc9db9138.	2024-01-15 18:47:49 +01:00
Andrei Zavatski	c406135487	Merge branch 'master' into argon-health-rework	2024-01-15 20:40:19 +03:00
Bartłomiej Dach	64e94a8b6c	Merge pull request #26544 from peppy/fix-background-dim-failure ... Fix background dim occasionally getting in a bad state when exiting gameplay	2024-01-15 15:16:37 +01:00
Bartłomiej Dach	c5351bd14d	Fix back-to-front set	2024-01-15 14:20:07 +01:00
Bartłomiej Dach	d206acac63	Merge pull request #26540 from peppy/fix-double-counters ... De-dupe displayed hits in judgement counter	2024-01-15 14:02:11 +01:00
Bartłomiej Dach	cd9b6656ba	Merge pull request #26536 from peppy/cache-fonts ... Fix gameplay counter textures not being cached ahead of time	2024-01-15 13:11:40 +01:00
Salman Ahmed	1d7b63e204	Move checking logic inside ModUtils and somewhat optimise	2024-01-15 14:58:59 +03:00
wooster0	9bc9db9138	simplify the code even more	2024-01-15 20:58:43 +09:00
Bartłomiej Dach	6dee2860d2	Merge branch 'master' into fix-multiplayer-mods-cheesing	2024-01-15 12:19:29 +01:00
Dean Herbert	8e32780888	Fix background dim occasionally getting in a bad state when exiting gameplay	2024-01-15 19:21:19 +09:00
Dean Herbert	0aa8a20d57	Fix regression in interaction when panels are not selectable	2024-01-15 18:34:32 +09:00
Dean Herbert	2a2a4c416e	Only display offset toast when in local gameplay	2024-01-15 18:17:49 +09:00
Dean Herbert	52f8348ee3	Fade hold-for-menu button out completely on non-touch devices	2024-01-15 17:55:37 +09:00
Dean Herbert	e6453853c2	De-dupe displayed hits in judgement counter	2024-01-15 16:02:59 +09:00
Dean Herbert	6940579b9e	Remember multiplayer room filter mode ... As proposed in https://github.com/ppy/osu/discussions/26218.	2024-01-15 14:30:34 +09:00
Dean Herbert	0b5cc8fb10	Fix gameplay counter textures not being cached ahead of time ... Part of https://github.com/ppy/osu/issues/26535.	2024-01-15 14:01:21 +09:00
Dean Herbert	68496f7a0e	Fix scores not showing up on leaderboards during gameplay	2024-01-14 15:13:20 +09:00
Salman Ahmed	0c02062780	Add guard against starting gameplay with invalid mod instances ... Move guard to `Player` instead	2024-01-13 16:25:02 +03:00
Salman Ahmed	c514550dfa	Fix multiplayer potentially selecting mods of wrong ruleset when starting match	2024-01-13 11:17:08 +03:00
Bartłomiej Dach	6572fa4378	Only validate playback rate when in submission context ... Temporary workaround for https://github.com/ppy/osu/issues/26404. It appears that some audio files do not behave well with BASS, leading BASS to report a contradictory state of affairs (i.e. a track that is in playing state but also not progressing). This appears to be related to seeking specifically, therefore only enable the validation of playback rate in the most sensitive contexts, namely when any sort of score submission is involved.	2024-01-12 14:59:15 +01:00
Andrei Zavatski	c1e4e51a5f	Add comment explaining negative container padding	2024-01-12 15:34:07 +03:00
Andrei Zavatski	8d4ba6d466	Remove PathPadding property	2024-01-12 15:30:19 +03:00
Nitrous	ccbba8a00b	Avoid NRE due to a beatmap loading with no hit objects.	2024-01-12 17:19:59 +08:00
Nitrous	c545a9c242	remove extra new line	2024-01-12 15:13:38 +08:00
Nitrous	c404628113	move creation of PlaybackSettings to ReplayPlayer	2024-01-12 15:12:02 +08:00
Andrei Zavatski	e861661037	Remove invalidations in update ... oops	2024-01-12 03:03:41 +03:00
Andrei Zavatski	101a26a53e	Update start and end progress in one go	2024-01-12 02:54:07 +03:00
Andrei Zavatski	bbb36da323	Don't pass start and end progress to the background	2024-01-11 18:58:40 +03:00
Andrei Zavatski	d75bf55c58	CI fixes	2024-01-11 18:28:00 +03:00
Andrei Zavatski	f1db7db259	Implement ArgonHealthDisplayBar	2024-01-11 17:52:34 +03:00
Andrei Zavatski	90ab306a96	Implement ArgonHealthDisplayBackground	2024-01-11 17:52:33 +03:00
Nitrous	6cd255f549	Contains + Add to TryAdd	2024-01-11 11:36:58 +08:00
Dean Herbert	5d6f767dbd	Reduce excessive Color4 allocations during path colour updates	2024-01-11 00:31:39 +09:00
Dean Herbert	49d13cda6b	Fix failing test by setting health on source of truth	2024-01-10 23:09:43 +09:00
Dean Herbert	f912a1ba31	Merge branch 'master' into health-less-value-changed	2024-01-10 18:03:34 +09:00
Nitrous	72e302dfac	Enumerate nested hit objects	2024-01-10 15:27:41 +08:00
Nitrous	b74c3b1c5c	Make all hit objects before the start time marked as hit.	2024-01-10 15:19:38 +08:00
Nitrous	484e9e8ee6	Fix binding order of IsPaused bindable and disable playback controls in spectator mode.	2024-01-09 22:09:20 +08:00
Bartłomiej Dach	8110c995dd	Merge branch 'master' into allocs-off-the-charts	2024-01-09 14:11:00 +01:00
Bartłomiej Dach	92ba770314	Fix missing wireframe behind percent sign on accuracy counter	2024-01-09 14:00:58 +01:00
Bartłomiej Dach	77bf6e3244	Fix missing wireframe behind "x" sign on combo counter display	2024-01-09 13:59:27 +01:00
wooster0	8ad697ff4c	apply some suggestions/corrections	2024-01-09 21:28:46 +09:00
Dean Herbert	4110adc4c0	Fix missing wireframe on argon combo counter	2024-01-09 20:16:28 +09:00
Bartłomiej Dach	66b3945cd6	Move current screen check to better place	2024-01-09 10:44:30 +01:00
Dean Herbert	9c7e555237	Fix initial animation not playing correctly	2024-01-09 18:27:37 +09:00
Dean Herbert	80892f3167	Fix misses not displaying properly	2024-01-09 18:18:11 +09:00
Dean Herbert	b6505ba063	Reduce colour tween overhead and mark other calls of concern	2024-01-09 18:16:54 +09:00
Dean Herbert	12a59eb34c	Remove vertex update overheads	2024-01-09 17:35:01 +09:00
Nitrous	c081ca2145	Make field to a local.	2024-01-09 16:30:48 +08:00
Dean Herbert	b3533d270c	Remove delegate overhead of HealthBarValue/GlowBarValue	2024-01-09 17:20:49 +09:00
Nitrous	63961ea276	use RepeatingButtonBehavior for seek buttons	2024-01-09 16:08:29 +08:00
Dean Herbert	d83b8dbdaf	Refactor ArgonHealthDisplay to user interpolation and less bindable events	2024-01-09 16:50:27 +09:00
Dean Herbert	1837b31f9b	Remove usage of HealthDisplay.BindValueChanged ... Health updates very often when using HP drain. Let's avoid bindable overheads.	2024-01-09 16:38:05 +09:00
Nitrous	bdecac6d79	Inverse check.	2024-01-09 15:19:54 +08:00
Nitrous	99c7685495	use GameplayClock.IsPaused bindable instead of polling in Update	2024-01-09 15:18:21 +08:00
Dean Herbert	1f6e1cbe56	Allow interacting with playlist item buttons when not selected	2024-01-09 14:45:21 +09:00
Dean Herbert	765d41faa9	Change second occurrence of debug.assert with early return for fallback safety	2024-01-09 14:07:48 +09:00
Dean Herbert	3f5899dae0	Fix incorrect implementation of wireframe digits	2024-01-09 14:07:48 +09:00
Nitrous	afa808695b	Make resolved properties nullable.	2024-01-09 12:48:11 +08:00
Nitrous	2e041823a1	Perform null check on gameplay state.	2024-01-09 12:24:09 +08:00
Nitrous	bb2b7d3c31	Add playback controls.	2024-01-09 12:23:01 +08:00
Bartłomiej Dach	58db39ec32	Fix crash when clicking osu! logo in song select immediately after exiting ... Closes https://github.com/ppy/osu/issues/26415. The crash report with incomplete log was backwards, the exit comes first. Sentry events and the reproducing test in 8a87301c55 confirm this.	2024-01-08 21:37:25 +01:00
Bartłomiej Dach	70ba5dd0d3	Merge pull request #26385 from peppy/carousel-thing ... Fix beatmap carousel not preloading panels when off-screen	2024-01-08 19:37:34 +01:00
Dean Herbert	51bd32bf7e	Restore comment regarding usage of MinBy	2024-01-09 01:08:47 +09:00
Dean Herbert	e77d203a24	Refactor delayed load logic to hopefully read better	2024-01-09 01:08:17 +09:00
Bartłomiej Dach	5337d999b5	Merge branch 'master' into disable-intro-track-pause	2024-01-08 12:54:37 +01:00
Bartłomiej Dach	b6ce57b777	Use override that was intended to steer global track control rather than local sets	2024-01-08 12:54:16 +01:00
Bartłomiej Dach	3e9d222d67	Merge pull request #26409 from peppy/overall-ranking-overlap ... Fix overall ranking text overlapping at some aspect ratios	2024-01-08 12:29:42 +01:00
Dean Herbert	16ea7f9b77	Avoid completely unnecessary string allocations in ArgonCounterTextComponent	2024-01-07 14:31:22 +09:00
Dean Herbert	b809d4c068	Remove delegate overhead from argon health display's animation updates	2024-01-07 14:31:22 +09:00
Dean Herbert	d3710f0bfd	Remove scores from song select leaderboard when leaving the screen	2024-01-06 20:53:20 +09:00
Dean Herbert	14a43375a7	Fix overall ranking text overlapping at some aspect ratios ... Can't confirm on the actual ranking screen due to stuff not working. Maybe it'll work tomorrow. Closes https://github.com/ppy/osu/issues/26341.	2024-01-06 20:25:07 +09:00
Zachary	091241634c	Make IntroScreen set AllowTrackControl to false instead	2024-01-05 23:55:17 +10:00
Dean Herbert	fbc40ffc65	Merge pull request #26381 from Joehuu/flash-ongoing-operations-dialog ... Flash blocking ongoing operations dialog when trying to force quit	2024-01-05 18:34:06 +09:00
Dean Herbert	91bb3f6c57	Cache argon character glyph lookups to reduce string allocations	2024-01-05 01:24:00 +09:00
Zachary	9b734bac25	Allow track control after intro screen finishes.	2024-01-05 01:14:34 +10:00
Dean Herbert	35b9940c4e	Merge pull request #26140 from CaffeeLake/multiplier1x ... Fix mod score multiplier rounding to 1.00x with specific mod combinations	2024-01-04 19:26:49 +09:00
Dean Herbert	81c6fd5589	Load items closer to the centre of the screen as a priority	2024-01-04 19:25:12 +09:00
Dean Herbert	adac3b65ce	Fix beatmap carousel not preloading panels when off-screen	2024-01-04 19:25:12 +09:00
Dean Herbert	705f25e4b9	Make ScoreProcessor.Rank read-only	2024-01-04 17:13:24 +09:00
Dean Herbert	0bbc27e380	Add a gameplay configuration flag to disable fail animation	2024-01-04 17:13:24 +09:00
Joseph Madamba	cd9bf0c753	Flash blocking ongoing operations dialog when trying to force quit	2024-01-03 22:30:46 -08:00
wooster0	2c64db0628	Use already existing message placeholder + localized string	2024-01-04 12:15:48 +09:00
CaffeeLake	c7b0a7ff69	Merge branch 'master' into multiplier1x	2024-01-04 05:04:23 +09:00
CaffeeLake	8482d731c3	Merge branch 'master' into multiplier1x	2024-01-03 20:24:45 +09:00
Bartłomiej Dach	04147eb689	Fix lack of correct default value spec	2024-01-03 11:46:28 +01:00
Bartłomiej Dach	e686a6a1dd	Fix player submission test intermittent failures due to audio playback discrepancy logic kicking in ... See https://github.com/ppy/osu/actions/runs/7384457927/job/20087439457#step:5:133.	2024-01-03 09:17:01 +01:00
Dean Herbert	bdfaa4b583	Fix crash when dragging rotation control in editor with both mouse buttons ... Closes https://github.com/ppy/osu/issues/26325.	2024-01-03 13:34:50 +09:00
Dean Herbert	e4ba7b81b0	Merge pull request #26343 from adryzz/fix-discord-multiplayer-presence ... update the current activity when the multiplayer room updates	2024-01-03 13:10:56 +09:00
CaffeeLake	79ef032182	Merge branch 'master' into multiplier1x	2024-01-03 07:40:02 +09:00
Lena	17656e9b9c	update the current activity when the multiplayer room updates	2024-01-02 18:38:25 +01:00
Bartłomiej Dach	3c5e9ac9a9	Fix possible double score submission when auto-retrying via perfect mod ... Closes https://github.com/ppy/osu/issues/26035. `submitOnFailOrQuit()`, as the name suggests, can be called both when the player has failed, or when the player screen is being exited from. Notably, when perfect mod with auto-retry is active, the two happen almost simultaneously. This double call exposes a data race in `submitScore()` concerning the handling of `scoreSubmissionSource`. The race could be experimentally confirmed by applying the following patch: diff --git a/osu.Game/Screens/Play/SubmittingPlayer.cs b/osu.Game/Screens/Play/SubmittingPlayer.cs index 83adf1f960..76dd29bbdb 100644 --- a/osu.Game/Screens/Play/SubmittingPlayer.cs +++ b/osu.Game/Screens/Play/SubmittingPlayer.cs @@ -228,6 +228,7 @@ private Task submitScore(Score score) return Task.CompletedTask; } + Logger.Log($"{nameof(scoreSubmissionSource)} is {(scoreSubmissionSource == null ? "null" : "not null")}"); if (scoreSubmissionSource != null) return scoreSubmissionSource.Task; @@ -237,6 +238,7 @@ private Task submitScore(Score score) Logger.Log($"Beginning score submission (token:{token.Value})..."); + Logger.Log($"creating new {nameof(scoreSubmissionSource)}"); scoreSubmissionSource = new TaskCompletionSource<bool>(); var request = CreateSubmissionRequest(score, token.Value); which would result in the following log output: [runtime] 2024-01-02 09:54:13 [verbose]: scoreSubmissionSource is null [runtime] 2024-01-02 09:54:13 [verbose]: scoreSubmissionSource is null [runtime] 2024-01-02 09:54:13 [verbose]: Beginning score submission (token:36780)... [runtime] 2024-01-02 09:54:13 [verbose]: creating new scoreSubmissionSource [runtime] 2024-01-02 09:54:13 [verbose]: Beginning score submission (token:36780)... [runtime] 2024-01-02 09:54:13 [verbose]: creating new scoreSubmissionSource [network] 2024-01-02 09:54:13 [verbose]: Performing request osu.Game.Online.Solo.SubmitSoloScoreRequest [network] 2024-01-02 09:54:14 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/869310/solo/scores/36780 successfully completed! [network] 2024-01-02 09:54:14 [verbose]: SubmitSoloScoreRequest finished with response size of 639 bytes [network] 2024-01-02 09:54:14 [verbose]: Performing request osu.Game.Online.Solo.SubmitSoloScoreRequest [runtime] 2024-01-02 09:54:14 [verbose]: Score submission completed! (token:36780 id:20247) [network] 2024-01-02 09:54:14 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/869310/solo/scores/36780 successfully completed! [network] 2024-01-02 09:54:14 [verbose]: SubmitSoloScoreRequest finished with response size of 639 bytes [runtime] 2024-01-02 09:54:14 [error]: An unhandled error has occurred. [runtime] 2024-01-02 09:54:14 [error]: System.InvalidOperationException: An attempt was made to transition a task to a final state when it had already completed. [runtime] 2024-01-02 09:54:14 [error]: at osu.Game.Screens.Play.SubmittingPlayer.<>c__DisplayClass30_0.<submitScore>b__0(MultiplayerScore s) in /home/dachb/Documents/opensource/osu/osu.Game/Screens/Play/SubmittingPlayer.cs:line 250 The intention of the submission logic was to only ever create one `scoreSubmissionSource`, and then reuse this one if a redundant submission request was made. However, because of the temporal proximity of fail and quit in this particular case, combined with the fact that the calls to `submitScore()` are taking place on TPL threads, means that there is a read-write data race on `scoreSubmissionSource`, wherein the source can be actually created twice. This leads to two concurrent score submission requests, which, upon completion, attempt to transition only _the second_ `scoreSubmissionSource` to a final state (this is because the API success/failure request callbacks capture `this`, i.e. the entire `SubmittingPlayer` instance, rather than the `scoreSubmissionSource` reference specifically). To fix, ensure correct synchronisation on the read-write critical section, which should prevent the `scoreSubmissionSource` from being created multiple times.	2024-01-02 10:55:52 +01:00
iilwy	fbedcb29e4	Merge branch 'master' into fix-precision	2024-01-01 10:42:15 -06:00
OliBomby	6bb72a9fcc	Revert "Remove other grid types" ... This reverts commit de14da95fa.	2024-01-01 15:46:07 +01:00
OliBomby	de14da95fa	Remove other grid types	2024-01-01 15:44:20 +01:00
OliBomby	f649fa106f	Added bindables and binding with BindTo	2024-01-01 15:13:11 +01:00
OliBomby	d0ca3f2b2b	Add circular grid	2024-01-01 15:13:11 +01:00
OliBomby	847f04e63a	reduce opacity of middle cardinal lines	2024-01-01 15:13:10 +01:00
OliBomby	8a331057b0	Make it actually possible to change grid type	2024-01-01 15:13:10 +01:00
OliBomby	f223487e1c	improve code	2024-01-01 15:13:10 +01:00
OliBomby	0ce1a48e68	Add comment	2024-01-01 15:13:10 +01:00
OliBomby	a20c430d6f	fix wrong grid cache being used	2024-01-01 15:13:10 +01:00
OliBomby	d0c8b285ce	clean up code duplication	2024-01-01 15:13:10 +01:00
OliBomby	92c3b142a4	Added Triangular snap grid	2024-01-01 15:11:50 +01:00
OliBomby	f2edd705ea	add rotation to snapped position	2024-01-01 15:11:49 +01:00
OliBomby	f3b88c318b	Add rotation to snap grid visual	2024-01-01 15:11:49 +01:00
Salman Ahmed	34acb435b8	Merge branch 'master' into multiplier1x	2023-12-31 16:48:00 +03:00
wooster0	0c85fd496f	Don't leave scores screen empty if no scores are present yet ... Addresses https://github.com/ppy/osu/discussions/23787 I originally wanted to set `allowShowingResults` to false if there are no results but because this involves an API request to fetch the scores that would mean all the scores would have to be fetched all at once so that it knows whether to hide or show the "View results" button on a beatmap. Because that would slow things down and be very inefficient, this still allows the user to view the scores screen but if there aren't any scores, it shows a text, which I think is at least for now better than nothing. As for the testing of this, I wasn't sure how to not generate scores only for one specific test so I opted into not using `SetUpSteps` and doing it that way.	2023-12-31 22:42:32 +09:00
iminlikewithyou	5ae5d7f92d	change floor to round	2023-12-30 23:59:47 -06:00
Salman Ahmed	4dc11c4c48	Update existing code to use helper method	2023-12-31 05:18:07 +03:00
iminlikewithyou	45f6c78314	Merge branch 'master' of https://github.com/ppy/osu into menu-button-tweaks	2023-12-30 12:58:10 -06:00
iminlikewithyou	452f201f06	use margins isntead of moving the position of the sprite	2023-12-30 12:56:38 -06:00
CaffeeLake	bca0600482	Use 0.99x or 1.01x ... Signed-off-by: CaffeeLake <PascalCoffeeLake@gmail.com>	2023-12-31 00:47:09 +09:00
Dean Herbert	61c46b78bd	Update MenuTip.cs ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2023-12-29 22:24:16 +09:00
Dean Herbert	9f0fe6c6ca	Fix common typos ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-12-29 22:20:29 +09:00
Dean Herbert	d00b7c9cdf	Add some new menu tips (and reword some others)	2023-12-29 22:14:51 +09:00
Dean Herbert	2b81f4f557	Merge pull request #26221 from bdach/system-title-only-on-top-level-menu ... Do not display system title in inital menu state	2023-12-29 21:13:40 +09:00
Bartłomiej Dach	db78d73fa5	Do not display system title in inital menu state ... Addresses https://github.com/ppy/osu/discussions/26199.	2023-12-29 11:50:30 +01:00
Bartłomiej Dach	99cddb6317	Use alternative workaround	2023-12-29 11:07:45 +01:00
Bartłomiej Dach	cd1f6b46c4	Fix crash after changing audio track in editor ... Closes https://github.com/ppy/osu/issues/26213. Reproduction scenario: switch audio track in editor after timeline loads. Happens because `beatmap.Value.Track.Length` is 0 immediately after a track switch, until BASS computes the actual track length on the audio thread. Yes this is a hack. No I have no better immediate ideas how to address this otherwise.	2023-12-29 10:37:36 +01:00
Nitrous	c68a850325	Make menu tip about mod select more up to date.	2023-12-29 08:51:54 +08:00
iminlikewithyou	51d26d2d71	make the hover scale bigger ... as a consequence, the rotation needs to be tweaked to be lower	2023-12-28 17:20:44 -06:00
iminlikewithyou	f1f1221e0e	move text left to be visually centered in the skewed rectangle	2023-12-28 17:18:41 -06:00
iminlikewithyou	4760c6aaee	move icon upwards to be visually centered	2023-12-28 17:17:24 -06:00
iminlikewithyou	637119f7d4	increase the base size of button icons	2023-12-28 17:15:23 -06:00
Bartłomiej Dach	7a10e132ea	Fix crash when retrieval of system title image fails ... Closes https://github.com/ppy/osu/issues/26194.	2023-12-28 20:39:13 +01:00
Bartłomiej Dach	6d124513e7	Fix test failures due to player bailing early after failing to load beatmap	2023-12-28 14:15:15 +01:00
Bartłomiej Dach	619b0cc69b	Fix code quality inspection	2023-12-28 14:12:28 +01:00
Bartłomiej Dach	24a80da83f	Merge branch 'master' into universal-offset-from-session-plays	2023-12-28 14:07:46 +01:00
Dean Herbert	e1a376c0a7	Fix using "Back" binding at spectator fail screen not working	2023-12-28 20:14:18 +09:00
Bartłomiej Dach	0fc86a07cb	Merge pull request #26177 from peppy/fix-leaderboard-tab-ordering ... Fix song select leaderboard tab ordering not matching stable	2023-12-28 12:02:46 +01:00
Dean Herbert	b7f3c83514	Expose the ability to update global offset from the player loader screen	2023-12-28 20:01:34 +09:00
Dean Herbert	bd0e2b4dde	Remove disclaimer screen completely	2023-12-28 17:21:29 +09:00
Dean Herbert	7dc50b9baf	Don't dismiss on hover, and allow dismissing via click	2023-12-28 17:20:01 +09:00
Dean Herbert	1f2339244e	Add supporter display to main menu	2023-12-28 17:20:01 +09:00
Dean Herbert	b19f72481b	Fade out quickly on game exit sequence	2023-12-28 17:19:41 +09:00
Dean Herbert	0ad6ac8b2a	Remove unused variable	2023-12-28 16:48:17 +09:00
Dean Herbert	932d03a4f8	Make toggle more immediately hide/show tips	2023-12-28 16:21:19 +09:00
Dean Herbert	222459d921	Add background and improve layout	2023-12-28 16:16:27 +09:00
Dean Herbert	a1867afbb4	Move menu tips to main menu ... In preparation for removing the disclaimer screen.	2023-12-28 16:06:08 +09:00
Dean Herbert	6684987289	Reduce refresh interval slightly	2023-12-28 15:19:09 +09:00
Dean Herbert	0ea62d0c5d	Add initial additive blending on fade in	2023-12-28 15:16:42 +09:00
Dean Herbert	972234b1e5	Move re-schedule inside continuation	2023-12-28 15:12:44 +09:00
Dean Herbert	481a251786	Use HandleLink to allow potentially opening wiki or otherwise	2023-12-28 15:11:02 +09:00
Dean Herbert	289e0f00f9	Add flash on click	2023-12-28 15:10:47 +09:00
Dean Herbert	c70e7d340d	Adjust animation and add delay to URL open	2023-12-28 15:10:47 +09:00
Dean Herbert	ffc8778d67	Fix song select leaderboard tab ordering not matching stable	2023-12-28 14:13:35 +09:00
Bartłomiej Dach	ef39759813	More code quality inspections	2023-12-28 00:18:20 +01:00
Bartłomiej Dach	a3f720bc62	Retrieve system title from online source	2023-12-27 23:37:39 +01:00
Bartłomiej Dach	d9299a8a55	Implement visual appearance of "system title" message in main menu	2023-12-27 23:07:17 +01:00
Bartłomiej Dach	1b7af989ec	Migrate BeatmapOffsetControl to use session static directly	2023-12-27 19:19:27 +01:00
Bartłomiej Dach	d4423d4933	Store last set score to a SessionStatic	2023-12-27 19:13:42 +01:00
Bartłomiej Dach	53766285ce	Remove remaining hexacons usages	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	288ac930e4	Use new icons in editor ... Some that exist on figma are purposefully not used due to an editorial request from @peppy.	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	c45477bd1f	Use new icons in main menu wherever feasible	2023-12-27 17:42:18 +01:00
rushiiMachine	1d4db3b7a9	Fix SkinEditorOverlay freezing when ReplayPlayer screen exits early ... Originally when popping in, the ReplayPlayer was loaded first (if previous screen was MainMenu), and afterwards the SkinEditor component was loaded asynchronously. However, if the ReplayPlayer screen exits quickly (like in the event the beatmap has no objects), the skin editor component has not finished initializing (this is before it was even added to the component tree, so it's still not marked `Visible`), then the screen exiting will cause `OsuGame` to call SetTarget(newScreen) -> setTarget(...) which sees that the cached `skinEditor` is not visible yet, and hides/nulls the field. This is the point where LoadComponentAsync(editor, ...) finishes, and the callback sees that the cached skinEditor field is now different (null) than the one that was loaded, and never adds it to the component tree. This occurrence is unhandled and as such the SkinEditorOverlay never hides itself, consuming all input infinitely. This PR changes the loading to start loading the ReplayPlayer *after* the SkinEditor has been loaded and added to the component tree. Additionally, this lowers the exit delay for ReplayPlayer and changes the "no hit objects" notification to not be an error since it's a controlled exit.	2023-12-26 12:22:00 -08:00
Bartłomiej Dach	668ce937a8	Merge pull request #26138 from peppy/fix-audio-rate-playback-not-fail ... Bail from score submission if audio playback rate is too far from reality	2023-12-26 19:13:46 +01:00
Dean Herbert	d70fddb6fd	Fix elapsed time being counted twice on first frame	2023-12-27 00:11:22 +09:00
Dean Herbert	03e2463b06	Add test coverage and refactor to better handle equality edge case	2023-12-26 21:21:08 +09:00
Dean Herbert	1f2f749db6	Fix selection not being retained in control point list when undoing / redoing	2023-12-26 21:04:42 +09:00
Dean Herbert	f2c0e7cf2e	Fix editor's control point list refreshing multiple times for a single change	2023-12-26 21:04:42 +09:00
Bartłomiej Dach	b1a26acdd0	Merge pull request #26136 from peppy/add-waveform-visual-offset ... Add visual offset to better align editor waveforms with expectations	2023-12-26 12:57:13 +01:00
Dean Herbert	225528d519	Bail from score submission if audio playback rate is too far from reality ... Closes https://github.com/ppy/osu/issues/23149.	2023-12-26 19:20:58 +09:00
Dean Herbert	f9e47242db	Add visual offset to better align editor waveforms with expectations	2023-12-26 17:44:49 +09:00
Nathan Tran	060bf8beff	Fix rewind backtracking	2023-12-25 15:27:32 -08:00
Dean Herbert	686b2a4394	Disable positional interaction for now	2023-12-24 03:00:51 +09:00
Dean Herbert	72bec527fd	Add conditions to match stable offset adjust limitations	2023-12-24 02:36:27 +09:00
Dean Herbert	92b490f2e7	Don't bother with alt support for now	2023-12-24 01:59:48 +09:00
Dean Herbert	6f11885d4b	Add control to allow changing offset from gameplay	2023-12-23 20:51:30 +09:00
Dean Herbert	7e9522a722	Allow external use of offset text explanation	2023-12-23 20:46:12 +09:00
Dean Herbert	27a9dcc5a1	Add basic hotkey offset adjust support (via existing offset control)	2023-12-23 19:55:05 +09:00
smallketchup82	f7c1e66165	Make the difficulty stats change based on the currently applied mods	2023-12-22 17:28:02 -05:00
Simon G	b31b9e96d0	adjust beatmap length and drain based on rate changing mods	2023-12-22 03:04:48 +01:00
Bartłomiej Dach	81bbdccee7	Rename ScoreInfo.{ -> Client}Version	2023-12-21 12:56:43 +01:00
Dean Herbert	a4baa0a716	Add versioning of local scores ... For any potential future usage	2023-12-21 18:37:15 +09:00
rushiiMachine	ebbc8333e8	Prevent ExportReplay being spammed on fail by being held down ... This was already handled in ReplayDownloadButton (98efff0bd6/osu.Game/Screens/Ranking/ReplayDownloadButton.cs (L114-L115)) but seemingly missed for SaveFailedScoreButton	2023-12-20 08:41:16 -08:00
Dean Herbert	7fa4dcf0fb	Fix selection retention logic copy paste failure	2023-12-20 19:27:57 +09:00
Dean Herbert	e003462f7d	Fix beatmap updates causing one extra carousel selection	2023-12-20 19:15:02 +09:00
Dean Herbert	64f62e7d90	Fix song select running updates when screen is not active ... Who would have guessed that `Schedule` calls were there for a reason! I've tidied things up. Most of the changes I've made here are not required – the schedule is the main thing here. The reason the sound was playing is because one-too-many schedules was removed causing beatmap updates to update carousel specifics while still at the player loader screen. Note that the selection sound still plays on returning to song select, but this is not a regression. I'm looking at fixing this in a separate PR because I'm in a good place as far as understanding the logic right now and it would be a waste to leave it broken. Closes https://github.com/ppy/osu/issues/25875.	2023-12-20 17:31:09 +09:00
Bartłomiej Dach	9a5027e556	Merge pull request #25900 from peppy/editor-from-any-carousel ... Allow choosing "Edit" from any beatmap carousel item	2023-12-20 08:35:42 +01:00
Dan Balasescu	3818977a36	Merge pull request #25898 from peppy/song-select-stats ... Update song select to always show difficulty stats	2023-12-20 14:39:35 +09:00
Dean Herbert	85e5d74a16	Apply proposed changes	2023-12-20 12:42:06 +09:00
OliBomby	c167f10ad5	fix crash from dragging near zero-length repeating object in timeline	2023-12-19 21:20:45 +01:00
Bartłomiej Dach	e306cc35ba	Merge branch 'master' into fix-song-select-realm-refresh-performance	2023-12-19 14:14:46 +01:00
Dean Herbert	bbfdd6892d	Allow choosing "Edit" from any beatmap carousel item	2023-12-19 19:58:49 +09:00
Dean Herbert	502e3edac3	Add missing invalidation call	2023-12-19 19:39:48 +09:00
Dean Herbert	3b848e8503	Tidy up visual look	2023-12-19 19:28:02 +09:00
Dean Herbert	07bb0805e9	Move advanced stats to a more permanent location on song select	2023-12-19 19:10:43 +09:00
Dean Herbert	0a64d631e2	Add support for dual-column advanced stats	2023-12-19 19:09:47 +09:00
Dean Herbert	8f5d21dc70	Actually fix realm selection retention regression	2023-12-19 18:10:55 +09:00
Dean Herbert	7e9c1b2acb	Use sender's realm (because we can)	2023-12-19 17:27:52 +09:00
Bartłomiej Dach	7c05d66bd7	Add more detail to exception	2023-12-19 08:57:18 +01:00
Dean Herbert	44efa2c540	Fix incorrect ordering of items at song select when certain sort modes are used	2023-12-19 15:09:03 +09:00
Dean Herbert	d81cabc063	Revert "Improve performance of attemptSelection using new cached count and LastSelected" ... This reverts commit 25df42630e.	2023-12-18 22:46:02 +09:00
Dean Herbert	25e3a8e82e	Fix a few of silly issues	2023-12-18 22:45:58 +09:00
Dean Herbert	25df42630e	Improve performance of attemptSelection using new cached count and LastSelected	2023-12-18 20:47:08 +09:00
Dean Herbert	5755fa214a	Cache non-filtered beatmap counts to massively improve count performance	2023-12-18 20:44:08 +09:00
Dean Herbert	034c5cd654	Debounce count updates for good measure	2023-12-18 20:43:23 +09:00
Dean Herbert	6fa1f5ef9b	Simplify invalidation logic ... The only case where this was checking is guaranteed by realm to only be called once.	2023-12-18 20:31:02 +09:00
Dean Herbert	87b7699fcc	Avoid calling invalidation logic per beatmap set updated ... Realm will batch the updates. We don't want to do expensive operations per set when we don't need to.	2023-12-18 20:31:02 +09:00
Dean Herbert	32cc3f9ef7	Combine multiple similar invalidation logic into single event	2023-12-18 20:31:02 +09:00
Dan Balasescu	d7aca2f641	Add IApplicableHealthProcessor	2023-12-17 19:27:03 +09:00
Bartłomiej Dach	b3c6e80f5c	Merge pull request #25770 from peppy/show-back-button-spectator ... Show back button when spectating	2023-12-15 09:08:24 +01:00
Dean Herbert	48e89b903c	Merge pull request #25760 from bdach/if-i-speak-i-am-in-big-trouble-pt-1 ... Fix `AdjustedAttributesTooltip` being broken by design	2023-12-15 12:26:10 +09:00
Dean Herbert	27296c59de	Show back button when spectating ... Avoids getting stuck at some screens. It's a bit ugly having the back button visible like this, but is the best approach we have for now.	2023-12-15 11:26:17 +09:00
Dan Balasescu	fbef40bb1f	Reduce some allocations in SongSelect in the mania ruleset	2023-12-15 11:01:15 +09:00
Bartłomiej Dach	9e5b6b97ff	Fix AdjustedAttributesTooltip being broken by design ... Fixes issue described in the following comment: https://github.com/ppy/osu/pull/25759#issuecomment-1855954637 That is just not how the tooltip system is supposed to be used. To name the individual sins: - Caching and returning a tooltip instance like the classes that used tooltips is incorrect. The lifetime of tooltip instances is managed by the tooltip container. `GetCustomTooltip()` is called by it exclusively. It should return a fresh instance every time. - Not putting actual data in `IHasCustomTooltip.TooltipContent` is wrong. - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly* wrong. I'm not even sure which particular combination of the above transgressions caused the issue as it presented itself, but at this time I frankly do not care.	2023-12-14 16:15:56 +01:00
Givikap120	b22a7cf520	Update AdvancedStats.cs	2023-12-14 14:31:58 +02:00
Givikap120	c2373bb37b	change the order of attributes ... + simplifying the bug fix	2023-12-14 14:31:19 +02:00
Givikap120	8698835db2	fixed bug ... fixed the bug where it's not updates tooltip when there are no mods	2023-12-14 14:00:35 +02:00
Dean Herbert	e296730b37	Merge pull request #24642 from Givikap120/arod_rate_adjust ... Show adjusted AR/OD when using DT/HT	2023-12-13 22:17:10 +09:00
Dean Herbert	76c4931f3a	Merge pull request #25673 from frenzibyte/fix-argon-initial-display ... Fix `ArgonHealthDisplay` not displaying miss correctly during initial transition	2023-12-13 22:16:34 +09:00
Dean Herbert	9235f3d935	Merge pull request #25747 from peppy/fix-hit-error-clear ... Fix hit error displays not clearing on seek	2023-12-13 17:36:24 +09:00
Dean Herbert	5062c53e36	Refactor everything for sanity	2023-12-13 17:33:39 +09:00
Dean Herbert	3131d37621	Clear transformations with more fire	2023-12-13 17:00:21 +09:00
Dean Herbert	fb44fb18e0	Update in line with upstream changes	2023-12-13 16:42:20 +09:00
Dean Herbert	0259ab761b	Merge branch 'master' into arod_rate_adjust	2023-12-13 16:35:18 +09:00
Dean Herbert	fdcf87569c	Merge pull request #25711 from smoogipoo/mania-convert-song-select-keycount ... Display osu!mania keycount in song select carousel panels and details	2023-12-13 16:31:25 +09:00
Dean Herbert	ec6200b4ad	Merge pull request #25743 from peppy/merge-everything-at-once ... Merge everything at once	2023-12-13 16:17:06 +09:00
Dean Herbert	f2c6c348be	Fix HitError Clear methods not correctly returning pooled drawables	2023-12-13 16:13:23 +09:00
Dean Herbert	110749205d	Cache GameplayClockContainer to allow usage of OnSeek	2023-12-13 16:13:08 +09:00
Dean Herbert	5e10f9f899	Fix failing tests due to more textboxes being present with searchable dropdowns	2023-12-13 15:11:47 +09:00
Dean Herbert	eb30a603d9	Fix typo in argument name	2023-12-13 15:01:36 +09:00
Dean Herbert	0be6743e87	Apply Bindable.Parse refactorings	2023-12-13 14:07:38 +09:00
Dean Herbert	5b00cf283d	Merge branch 'master' into drawnode-subtree-draw-cleanup	2023-12-13 14:01:01 +09:00
Dan Balasescu	c31ff84417	Fix possible nullref	2023-12-13 13:32:27 +09:00
Givikap120	2d94841929	fixed one test	2023-12-10 02:00:32 +02:00
Givikap120	faf54bca43	Merge branch 'master' into arod_rate_adjust	2023-12-10 01:49:18 +02:00
Givikap120	1d0c37e138	fixed test errors	2023-12-10 00:40:05 +02:00
Dan Balasescu	b36db3518c	Add keycount to song select details panel and carousel panels	2023-12-09 22:31:51 +09:00
Dean Herbert	a500f55ec6	Merge pull request #25688 from peppy/match-default-sv ... Change default slider velocity for new beatmaps to match osu!stable	2023-12-07 11:52:16 +09:00
Bartłomiej Dach	f69a5b44cc	Merge branch 'master' into fix-argon-initial-display	2023-12-06 09:30:28 +01:00
Bartłomiej Dach	4585a169b1	Merge pull request #25686 from peppy/fix-song-select-match ... Fix searching at song select matching incorrect ruleset	2023-12-06 09:25:47 +01:00
Dean Herbert	0af16732b8	Change default slider velocity to 1.4 ... This is the default in osu!stable and plays better than 1.0.	2023-12-06 13:38:46 +09:00
Dean Herbert	4da6d53c72	Merge pull request #25672 from frenzibyte/fix-argon-health-display-2 ... Fix `ArgonHealthDisplay` sometimes behaving weirdly on miss judgements (alternative)	2023-12-06 12:24:39 +09:00
Dean Herbert	8286d3896f	Fix searching at song select matching incorrect ruleset ... Regressed with https://github.com/ppy/osu/pull/25679.	2023-12-06 11:32:26 +09:00
Salman Ahmed	20fd458fac	Perserve miss animation when followed by a hit at same frame	2023-12-05 21:59:28 +03:00
Salman Ahmed	9496cdf42b	Add explanatory note for scheduling	2023-12-05 21:59:28 +03:00
Salman Ahmed	927cfe4257	Fix health processor event leaks	2023-12-05 21:59:28 +03:00
Bartłomiej Dach	88095aaefa	Merge pull request #25637 from smoogipoo/multiplayer-abort ... Add ability for the host to abort an in-progress match	2023-12-05 13:51:00 +01:00
Bartłomiej Dach	4644c4e7a2	Remove unused class	2023-12-05 12:43:32 +01:00
Bartłomiej Dach	566d336470	Merge pull request #25679 from peppy/song-select-search-performance ... Improve song select search performance	2023-12-05 11:06:31 +01:00
Dean Herbert	5a2240838b	Merge branch 'master' into multiplayer-abort	2023-12-05 17:01:54 +09:00
Dean Herbert	02178d8e61	Remove usage of case-when	2023-12-05 16:58:16 +09:00
Dean Herbert	f317e06da1	Use DangerousActionDialog	2023-12-05 16:54:44 +09:00
Dean Herbert	45e499778f	Search terms before performing other criteria checks ... Very minor, but putting the more common case towards the start of the method allows early return.	2023-12-05 15:28:56 +09:00
Dean Herbert	42010574b5	Avoid list construction when doing filtering	2023-12-05 15:26:14 +09:00
Dean Herbert	27e778ae09	Avoid sorting items when already in the correct sort order	2023-12-05 14:47:32 +09:00
Dean Herbert	7fda38d0b0	Use ordinal comparison when searching at song select ... Bypasses various overheads. In theory should be fine? (until it's not on some language)	2023-12-05 14:14:13 +09:00
Guido	8756dd25c6	Changed file chooser in resource selection to show file name when file is selected	2023-12-04 22:51:56 +01:00
Salman Ahmed	629e64d50a	Fix ArgonHealthDisplay not displaying miss correctly during initial transition	2023-12-04 23:55:31 +03:00
Salman Ahmed	4d82a55594	Remove method for being unused	2023-12-04 23:24:28 +03:00
Salman Ahmed	5723715ea0	Fix ArgonHealthDisplay sometimes behaving weirdly on miss judgements	2023-12-04 23:24:28 +03:00
Dan Balasescu	8587652869	Fix countdown button being enabled	2023-12-04 11:00:11 +09:00
Dan Balasescu	c2644a5d5e	Correctly implement button enabled state	2023-12-04 10:18:37 +09:00
Dan Balasescu	b56a78c6ec	Adjust with framework changes	2023-12-04 08:51:21 +09:00
Dan Balasescu	1b0fc8ca9d	Refactor	2023-12-01 20:41:41 +09:00
Dan Balasescu	15c9416244	Rename method	2023-12-01 18:47:40 +09:00
Dan Balasescu	a94180c8c6	Rename LoadAborted -> GameplayAborted, AbortGameplayReal -> AbortMatch	2023-12-01 18:26:59 +09:00
Dan Balasescu	894c31753b	Add initial support for aborting multiplayer games	2023-12-01 15:31:06 +09:00
Dean Herbert	1cfcaee121	Reorder badges so that SS shows above others ... This isn't perfect and probably needs much more consideration, but let's at least give the "better" ranks more visibility by bringing them to the front. Of note, this is only important due to the changes to osu!catch accuracy-grade cutoffs, which brings things closer in proximity than ever before.	2023-11-29 20:29:52 +09:00
Dan Balasescu	295a1b01d6	Adjust catch score grade cutoffs	2023-11-29 19:05:31 +09:00
Dean Herbert	537c9e031d	Merge pull request #25522 from bdach/no-concurrent-connections ... Implement flow allowing disconnection from online services when another client instance for same user is detected	2023-11-28 19:09:38 +09:00
Dean Herbert	a4be28a2ae	Don't show buttons on fail overlay when player interaction is disabled	2023-11-27 12:25:24 +09:00
Bartłomiej Dach	98ab9853ce	Merge branch 'master' into show-spectator-fail-2	2023-11-27 12:24:59 +09:00
Bartłomiej Dach	19639de299	Merge branch 'master' into fix-spectator-quit-2	2023-11-27 11:36:10 +09:00
Dean Herbert	a6cf1e5d2e	Make osu! logo do something when in edit submenu	2023-11-25 00:53:25 +09:00
Dean Herbert	a44edfdedd	Fix incorrect sample for top level edit button	2023-11-24 19:37:57 +09:00
Dan Balasescu	289cda71b2	Fix inspections	2023-11-24 15:06:51 +09:00
Dean Herbert	7ceb49fbc0	Add extra test coverage and handle case where still at loading screen	2023-11-24 15:05:39 +09:00
Dean Herbert	d3a55d83c0	Schedule FailScore inside onFail instead of onFailComplete	2023-11-24 14:44:57 +09:00
Dean Herbert	ef5dd24589	Update failing test coverage and fix onFail being called too often	2023-11-24 14:44:57 +09:00
Dean Herbert	4ad3cb3b49	Submit and send failed spectator state more aggressively	2023-11-24 14:44:57 +09:00
Dean Herbert	8375dd72d6	Add xmldoc to new AllowFail method	2023-11-24 14:44:57 +09:00
Dean Herbert	ca93fdc94b	Add visualisation of when a spectated player fails ... Create a new stack each time for isolation and safety	2023-11-24 14:44:57 +09:00
Dean Herbert	b024065857	Remove implicit schedule of abstract methods in SpectatorScreen ... This allows each implementation to have control over scheduling. Without this, the solo implementation would not be able to handle quit events while watching a player, as it would push a child (gameplay) screen to the stack where the `SpectatorScreen` would usually be.	2023-11-24 14:26:09 +09:00
Dean Herbert	335e8efff7	Apply NRT to SoloSpecatorScreen	2023-11-24 14:26:09 +09:00
Dean Herbert	dabbdf674b	Rename SoloSpectator to SoloSpectatorScreen	2023-11-24 14:26:08 +09:00
Dean Herbert	4c7d2bb0fb	Apply NRT to SpectatorScreen	2023-11-24 14:26:08 +09:00
Dean Herbert	b8179aa875	Use better(?) icons and full strings	2023-11-24 13:23:47 +09:00
Dean Herbert	a069a673fa	Allow buttons to be displayed on more than one state (and share the back button)	2023-11-24 13:18:17 +09:00
Dean Herbert	1d1b3ca982	Apply NRT to MainMenuButton	2023-11-24 13:18:17 +09:00
Dean Herbert	8ad414488a	Play out previous transforms immediately to avoid flow issues with multiple sub menus	2023-11-24 13:18:17 +09:00
Dean Herbert	7e59a1d0be	Apply NRT to ButtonSystem	2023-11-24 13:18:17 +09:00
Dean Herbert	5905ca6492	Add second level menu for skin editors	2023-11-24 13:18:17 +09:00
Dean Herbert	340227a06d	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
Dean Herbert	95c00f9666	Add HexaconIcons lookup to allow usage with SpriteIcon	2023-11-24 13:17:39 +09:00
Dean Herbert	537b0ae870	Add silly annotation for now (more new r# rules)	2023-11-24 12:47:42 +09:00
Givikap120	c2a44cf118	Made custom tooltip	2023-11-23 23:30:18 +02:00
Dean Herbert	5239fee947	Allow use of skin username/flag/avatar components outside of gameplay	2023-11-23 17:15:03 +09:00
Dean Herbert	9a6857bfad	Merge pull request #25530 from yesseruser/FlagHUD ... Fix skin element "PlayerFlag" responding to clicks/hovers	2023-11-23 16:51:09 +09:00
Dan Balasescu	30309cdf11	Merge pull request #25415 from Poyo-SSB-forks/unify-ur ... Change unstable rate calculation to account for rate-change mods	2023-11-23 09:53:28 +09:00
yesseruser	82fec4194d	Disabled RecievePositionalInputAtSubTree in PlayerFlag.	2023-11-22 15:45:32 +01:00
yesseruser	08e0279d72	Revert "Renamed UpdateableFlag to ClickableUpdateableFlag." ... This reverts commit 671177e871.	2023-11-22 15:25:43 +01:00
yesseruser	be8b59e59d	Revert "Created and implemened a BaseUpdateableFlag." ... This reverts commit cd7e0bf620.	2023-11-22 15:25:35 +01:00
yesseruser	cd7e0bf620	Created and implemened a BaseUpdateableFlag. ... The tooltip still shows.	2023-11-21 19:27:33 +01:00
yesseruser	671177e871	Renamed UpdateableFlag to ClickableUpdateableFlag.	2023-11-21 19:02:23 +01:00
Dean Herbert	21bf288277	Merge pull request #25520 from peppy/context-menu-spacers ... Allow context menus to have visible spacers	2023-11-21 16:56:36 +09:00
Bartłomiej Dach	bf972a04ee	Merge pull request #25409 from Tom94/bspline-sliders ... Add free-hand drawing of sliders to the editor	2023-11-21 16:28:14 +09:00
Bartłomiej Dach	d83b2e24e7	Merge pull request #25371 from RatinFX/open-editor-timestamp ... Implement opening editor timestamp links	2023-11-21 15:48:36 +09:00
Bartłomiej Dach	aa3ff151c0	Fix RoomManager attempting to part room when not online	2023-11-21 15:15:46 +09:00
Bartłomiej Dach	42fada578e	Centralise and improve messaging around online state ... When the server requests a disconnect due to a user connecting via a second device, the client will now log the user out on the first device and show a notification informing them of the cause of disconnection.	2023-11-21 15:15:46 +09:00
Dean Herbert	7c5345bf7e	Use SimpleErrorNotification for error display	2023-11-21 15:10:41 +09:00
Dean Herbert	917a68eac3	Adjust localisablel strings and keys	2023-11-21 15:08:15 +09:00
Dean Herbert	405ab499e9	Allow context menus to have visible spacers	2023-11-21 14:24:10 +09:00
Bartłomiej Dach	b6215b2809	Rename and document SelectFromTimestamp	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	234ef6f923	Rectify selection keep-alive logic	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	246aacb216	Remove unnecessary guard ... Setting a bindable's value to something if that value is already there is a no-op (doesn't trigger bindings / callbacks).	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	0e0ab66148	Simplify parsing code ... Less methods, less smeared around logic, saner data types.	2023-11-20 21:57:12 +09:00
Bartłomiej Dach	b6e3e42445	Merge branch 'master' into bspline-sliders	2023-11-20 12:03:29 +09:00
Dean Herbert	9172632b0b	Rename method and adjust xmldoc to be very explicit about how wrong this is	2023-11-17 17:04:20 +09:00
Dean Herbert	d1cea10f21	Add note about localisation	2023-11-17 16:52:40 +09:00
Dean Herbert	0a8ede6274	Merge pull request #25469 from Joehuu/argon-hide-counter-labels ... Add ability to toggle labels on argon counter components	2023-11-16 17:01:03 +09:00
Bartłomiej Dach	1e2f1b3ef2	Merge branch 'master' into unload-main-menu-storyboard	2023-11-16 15:46:44 +09:00
Bartłomiej Dach	dbd4f26436	Use alternative method of scheduling storyboard unload	2023-11-16 15:37:53 +09:00
Dean Herbert	b45872d2e0	Merge branch 'master' into argon-hide-counter-labels	2023-11-16 14:20:13 +09:00
Dean Herbert	73eda6c09c	Move non-matching default value to argon skin default speficiation instead	2023-11-16 14:18:49 +09:00
Dean Herbert	7f90db7603	Merge pull request #25472 from bdach/argon-health-folding-in-on-self ... Fix argon health bar folding in on itself when too narrow	2023-11-15 19:02:30 +09:00
Dean Herbert	2987c0e802	Add note about enfocing size methodology	2023-11-15 19:01:52 +09:00
Dean Herbert	189fca2eb6	Merge pull request #25339 from joshika39/change-clickable-avatars-tooltip-for-usergrid ... Add `UserGridPanel` as the `ClickableAvatar` tooltip	2023-11-15 18:01:24 +09:00
Bartłomiej Dach	8cd1f08a92	Fix argon health bar folding in on itself	2023-11-15 15:42:45 +09:00
Joseph Madamba	62352ce5f3	Add ability to toggle labels on argon counter components	2023-11-14 20:46:42 -08:00
Joseph Madamba	87ace7565d	Use existing localisation for argon counter component labels	2023-11-14 20:44:33 -08:00
Bartłomiej Dach	159cf41f82	Fix default argon health bar width being zero ... Closes #25460.	2023-11-15 12:53:09 +09:00
Bartłomiej Dach	711bf14c06	Merge pull request #25443 from peppy/fix-argon-custom-skins ... Fix customised argon skins no longer loading due to incorrect resource store specification	2023-11-14 23:11:39 +09:00
Dean Herbert	a745642f76	Fix customised argon skins no longer loading due to incorrect resource store spec	2023-11-14 22:01:56 +09:00
Bartłomiej Dach	83f8f03c7e	Fix argon health bar not relative sizing correctly	2023-11-14 21:54:06 +09:00
Bartłomiej Dach	70d2de5669	Move song select touch detector to solo implementation ... It should not run in multiplayer. Even if we wanted to allow touch-only playlist items at some point, the current behaviour of multiplayer song selects with respect to touch device mod is currently just broken.	2023-11-14 16:35:16 +09:00
Givikap120	26d493986c	Fixed precision and updated AdvancedStats	2023-11-12 18:05:18 +02:00
Dean Herbert	798e677c09	Refactor KeyCounterDisplay to use autosize ... A previous attempt at this was unsuccessful due to a partially off-screen elements not getting the correct size early enough (see https://github.com/ppy/osu/issues/14793). This can be accounted for by setting `AlwaysPresent` when visibility is expected. This fixes [test failures](https://github.com/ppy/osu/actions/runs/6838444698/job/18595535795) due to the newly added `Width` / `Height` being persisted with floating-point errors (by not persisting the values in the first place, via `AutoSize.Both`).	2023-11-12 17:19:25 +09:00
Dean Herbert	6bd5eda2a0	Merge branch 'master' into arod_rate_adjust	2023-11-12 15:49:07 +09:00
ratinfx	4e1e19728c	Refactor HitObject selection in Composer	2023-11-11 14:02:42 +01:00
Thomas Müller-Höhne	926636cc03	Generalize Bezier curves to BSplines of Nth degree	2023-11-11 13:32:53 +01:00
Bartłomiej Dach	ea556abad8	Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters	2023-11-11 21:28:29 +09:00
Bartłomiej Dach	50789d2e18	Fix song progress bars not sizing vertically properly	2023-11-11 21:28:04 +09:00
Bartłomiej Dach	870e4ce27e	Fix argon health display not handling invalidation correctly	2023-11-11 20:42:45 +09:00
Bartłomiej Dach	b7972e3c84	Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters	2023-11-11 20:16:14 +09:00
Poyo	064857c40b	Calculate unstable rate using rate-adjusted offsets	2023-11-10 19:57:44 -08:00
Salman Ahmed	96da7a07bb	Add detailed explaination on existence of ScheduleUntilTransitionEnd	2023-11-11 02:57:29 +03:00
Salman Ahmed	080f13e34d	Schedule outside of UnloadStoryboard and fix disposal happening on update thread	2023-11-11 02:56:45 +03:00
Givikap120	60c3e7250b	fixed naming incconvinence	2023-11-10 15:13:40 +02:00
Bartłomiej Dach	c522a703eb	Merge branch 'master' into skin-size-editing	2023-11-10 18:19:27 +09:00
Bartłomiej Dach	374e13b496	Remove argon health display bar length setting ... It is no longer needed. Intentionally not doing backwards migration to simplify things; users can fix their skins.	2023-11-10 18:18:58 +09:00
Dean Herbert	1c63f1f89d	Merge pull request #25348 from bdach/less-basic-touchscreen-detection ... Implement basic touchscreen detection	2023-11-10 18:01:40 +09:00
Dean Herbert	35e11c7c63	Rename diagonal scale variable and update xmldoc	2023-11-10 17:55:02 +09:00
Dean Herbert	a02aeed50a	Adjust combo animation slightly	2023-11-10 16:53:16 +09:00
Dean Herbert	67312a2db9	Remove ArgonScoreWedge and use ArgonWedgePiece directly	2023-11-10 16:53:16 +09:00
Dean Herbert	b4ec62473e	Remove width/height bindables from ArgonWedgePiece	2023-11-10 16:53:15 +09:00
Dean Herbert	4f90ac15fa	Reduce the default wireframe opacity a bit	2023-11-10 15:53:05 +09:00
Dean Herbert	7e0b41219c	Change animation to only affect number portion, add miss animation	2023-11-10 15:53:05 +09:00
Dean Herbert	e861681cd4	Adjust argon rolling easings	2023-11-10 15:53:05 +09:00
Dean Herbert	7c3a626f4b	Add basic animation for combo counter	2023-11-10 15:53:05 +09:00
Dean Herbert	6c1d48dfaf	Remove unused function	2023-11-10 15:53:05 +09:00
Dean Herbert	f31c1c9c79	Rename and move skinnable line component to a more commomn place	2023-11-10 15:53:05 +09:00
Dean Herbert	ec3b6e47fb	Change selection handling to adjust Size instead of Scale for edge nodes	2023-11-10 14:22:28 +09:00
Dean Herbert	7fc2050f72	Rename variables and mak seconary tooltip type work again	2023-11-10 11:52:34 +09:00
Salman Ahmed	d3af3c615f	Merge branch 'master' into gameplay-hud-redesign/counters	2023-11-10 01:04:03 +03:00
Salman Ahmed	6f5d905ce7	Update argon accuracy counter design	2023-11-10 01:02:05 +03:00
Salman Ahmed	59998b507a	Hide background sprite when storyboard finishes loading	2023-11-09 23:23:57 +03:00
Salman Ahmed	768a31b2f5	Fix background crash on a beatmap with no storyboard	2023-11-09 22:57:20 +03:00
Salman Ahmed	bd8409219f	Unload beatmap storyboard background when no longer present	2023-11-09 17:20:11 +03:00
Susko3	0c4c9aa4b5	Show touch taps setting in player loader on mobile platforms	2023-11-09 14:52:33 +01:00
Joshua Hegedus	ccb9ff826a	fixed tests	2023-11-09 13:09:59 +01:00
Dean Herbert	02966bc02f	Merge branch 'master' into change-clickable-avatars-tooltip-for-usergrid	2023-11-09 18:19:23 +09:00
Dean Herbert	67dc3aa5b7	Merge pull request #25366 from Susko3/better-touch-settings ... Add "disable taps during gameplay" to touch input settings and related UI	2023-11-09 18:19:02 +09:00
Bartłomiej Dach	63a0ea5410	Fix PlayerTouchInputDetector applying touch device mod when other inactive mods present	2023-11-09 17:51:01 +09:00
Bartłomiej Dach	13b599b9b6	Merge branch 'master' into less-basic-touchscreen-detection	2023-11-09 17:36:48 +09:00
Jamie Taylor	8a47f05b16	Always play 'swoosh' sample when transitioning back to logo	2023-11-09 14:01:33 +09:00
Jamie Taylor	f69c2ea39b	Implement sample choking/muting for ButtonSystem samples	2023-11-08 22:21:24 +09:00
Jamie Taylor	f0a1df06ac	Add 'swoosh' samples to accentuate MainMenu animations	2023-11-08 22:21:24 +09:00
Jamie Taylor	17aa079cb1	Use new tiered 'back' samples	2023-11-08 22:21:24 +09:00
Jamie Taylor	fc1a0cf645	Update ButtonSystem to use new sample names	2023-11-08 22:21:24 +09:00
Salman Ahmed	2ef17c56b1	Remove unused local	2023-11-08 02:13:35 +03:00
Salman Ahmed	18c71c95cc	Merge branch 'master' into gameplay-hud-redesign/counters	2023-11-08 02:12:37 +03:00
Salman Ahmed	4de5454538	Bring back left-side line next to health display ... Makes the score counter not look weird when it reaches 8 digits	2023-11-08 02:07:15 +03:00
Salman Ahmed	fdc714a248	Support percentages and ignore dot characters in wireframes part	2023-11-08 02:06:14 +03:00
Salman Ahmed	d30bac3f49	Move "required display digits" feature to reside in argon score counter	2023-11-08 02:06:14 +03:00
Salman Ahmed	e6d3085353	Update accuracy counter design	2023-11-08 02:06:14 +03:00
Salman Ahmed	cbea2db4be	Support absolute-sized health bar and use it for default layout	2023-11-08 02:06:14 +03:00
Dean Herbert	c00a1d948a	Merge branch 'master' into better-touch-settings	2023-11-07 23:21:59 +09:00
Dean Herbert	3e257f1e6c	Remove unused using statements	2023-11-07 23:21:51 +09:00
Susko3	fcd73e62d2	Remove mobile specific changes ... Will be added back in a separate PR	2023-11-07 13:06:14 +01:00
ratinfx	544d5d1d86	Forgot a clock.Stop call	2023-11-07 12:23:22 +01:00
ratinfx	bdbeb2bce4	Renamed CollectionChanged event handler	2023-11-07 11:11:32 +01:00
ratinfx	aa87e0a44d	HitObject Selection logic and separation for gamemodes ... + moved time_regex into EditorTimestampParser	2023-11-07 01:36:58 +01:00
ratinfx	44f127c8a8	Renamed method and made private	2023-11-07 01:02:45 +01:00
ratinfx	0834b79cc7	Renamed method and moved Notifications inside	2023-11-07 00:56:24 +01:00
Susko3	7385c3c97b	Move InputSettings children creation code to BDL ... - Avoids now obsolete variable name - Makes changing to touch detection easier (access to session statics in BDL)	2023-11-07 00:17:15 +01:00
Susko3	05d9418718	Rename setting to TouchDisableGameplayTaps for better visibility when searching	2023-11-07 00:13:46 +01:00
Salman Ahmed	0dbba13686	Split argon score sprite text and update combo counter design	2023-11-07 01:59:36 +03:00
Salman Ahmed	7c1c62ba8a	Remove argon combo wedge and update combo counter position	2023-11-07 01:59:36 +03:00
Salman Ahmed	ce36884ef0	Make score wireframes display up to required digits count	2023-11-07 01:59:36 +03:00
Salman Ahmed	754e05213c	Update argon score wedge design	2023-11-07 01:59:36 +03:00
Susko3	f8b5ecc92a	Update UI to use the new setting	2023-11-06 21:07:15 +01:00
Salman Ahmed	b2749943e2	Display "required save" popup when creating another difficulty on a new beatmap	2023-11-06 21:54:40 +03:00
Dean Herbert	51c891e2e4	Automatically refresh the verify screen's issue list on re-entering it ... Addresses https://github.com/ppy/osu/discussions/25365.	2023-11-06 19:34:36 +09:00
Bartłomiej Dach	682668ccf0	Remove touch device toasts entirely	2023-11-06 10:54:32 +01:00
Bartłomiej Dach	97fee6143c	Rename touch "input handlers" to detectors	2023-11-06 10:08:19 +01:00
Joshua Hegedus	4a70f2435c	fixed showUsernameTooltip	2023-11-06 09:22:50 +01:00
Dean Herbert	0915ac8891	Use left aligned text for non-rotate key counter	2023-11-06 16:32:12 +09:00
ratinfx	277cf7dc12	Ensure every SelectedItem is alive and has Blueprint	2023-11-05 18:26:51 +01:00
Susko3	9947897c5f	Use appropriate clicks/taps text in player loader input settings	2023-11-05 12:53:40 +01:00
Susko3	fa1d1df594	Rename mouse button string to Disable clicks during gameplay	2023-11-05 12:43:14 +01:00
Salman Ahmed	1d4f4cf4c3	Merge branch 'master' into gameplay-hud-redesign/counters	2023-11-05 02:02:36 +03:00
Salman Ahmed	6c3169a0ed	Remove PP wedge and logic for gameplay layout	2023-11-05 01:56:54 +03:00
Salman Ahmed	a23dfbeab5	Revert "Abstractify PP counter logic from the "Triangles" implementation" ... This reverts commit daf4a03fd0.	2023-11-05 01:55:54 +03:00
Salman Ahmed	58a830fc5b	Revert "Add "Argon" performance points counter" ... This reverts commit 56eeb117ce.	2023-11-05 01:55:54 +03:00
Salman Ahmed	1c844a155e	Remove health line detail	2023-11-05 01:55:54 +03:00
Salman Ahmed	91cf237fc1	Revert health display settings changes	2023-11-05 01:55:54 +03:00
ratinfx	7492d953ae	Moved error checks into Editor ... - Invoke Action on error to Notify user - added some comments	2023-11-04 21:17:58 +01:00
Givikap120	d0b2b4f7b9	Update AdvancedStats.cs	2023-11-04 21:57:42 +02:00
Givikap120	820519c37d	improved tooltip	2023-11-04 21:55:46 +02:00
Givikap120	57170501cd	Improve code quality	2023-11-04 17:25:09 +02:00
ratinfx	60f62faec3	Renamed Editor method	2023-11-04 03:30:38 +01:00
ratinfx	43ab7f4942	Added OpenEditorTimestamp base implementation	2023-11-04 02:01:18 +01:00
Joseph Madamba	16731ff85f	Fix text positioning	2023-11-02 20:42:28 -07:00
Joseph Madamba	b3dfe19472	Fix UprightAspectMaintainingContainer not being centred	2023-11-02 20:42:28 -07:00
Joseph Madamba	090601b485	Apply peppy's upright key counter attempt diff ... Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-11-02 20:42:23 -07:00
Bartłomiej Dach	a78fab0e7d	Do not hardcode ruleset name in touch device detection toast	2023-11-03 00:17:29 +01:00
Bartłomiej Dach	a613292802	Fix unknown mod test failure	2023-11-02 23:44:40 +01:00
Bartłomiej Dach	0dd0a84312	Move player touch handler to SubmittingPlayer ... Shouldn't be there in `ReplayPlayer`.	2023-11-02 22:56:43 +01:00
Bartłomiej Dach	8784dd42c0	Do not attempt to turn on Touch Device in song select with autoplay active	2023-11-02 22:56:43 +01:00
Bartłomiej Dach	3a6d65d395	Touch up PlayerTouchInputHandler	2023-11-02 21:24:58 +01:00
Bartłomiej Dach	c588f434e5	Fix song select touch handler causing crashes when song select is suspended	2023-11-02 21:24:58 +01:00
Bartłomiej Dach	f2df02b60f	Automatically activate touch device mod in player	2023-11-02 21:24:58 +01:00
Bartłomiej Dach	2f6ff893b5	Automatically activate and deactivate touch device mod in song select	2023-11-02 19:45:48 +01:00
Bartłomiej Dach	850866e7f4	Merge pull request #25316 from peppy/metronome-always-play-tick ... Decouple metronome tick playback from pendulum movement	2023-10-31 09:37:29 +01:00
Bartłomiej Dach	144006fbe8	Update autoselect implementation to work correctly with framework changes	2023-10-31 08:38:22 +01:00
Bartłomiej Dach	8a68333425	Merge branch 'master' into beat-divisor-select-text-on-click	2023-10-31 08:36:53 +01:00
Dean Herbert	64efc3d251	Decouple metronome tick playback from pendulum movement ... Not super happy about doing this, but it seems like it's in the best interest of editor usability.	2023-10-31 15:33:46 +09:00
Dean Herbert	7ceced7012	Scope TestPauseWithLargeOffset to focus on what matters ... See https://github.com/ppy/osu/actions/runs/6693917410/job/18186111009 This test is to make sure we don't seek before the original pause time, so I've exposed that value precisely to avoid CI woes.	2023-10-31 14:47:04 +09:00
Dean Herbert	f706fd2fca	Merge pull request #25307 from bdach/slider-velocity-undo ... Fix slider velocity changes not being undone correctly	2023-10-31 01:44:18 +09:00
Bartłomiej Dach	b2d3aa982d	Merge branch 'master' into fix-click-through-timeline	2023-10-30 12:52:00 +01:00
Bartłomiej Dach	cea24298cb	Privatise setters	2023-10-30 12:42:34 +01:00
Bartłomiej Dach	de89b7e53c	Fix slider velocity changes not being undone correctly ... Closes https://github.com/ppy/osu/issues/25239. `LegacyEditorBeatmapPatcher.processHitObjectLocalData()` was already supposed to be handling changes to hitobjects that will show up neither when comparing the hitobjects themselves or the timing point with "legacy" info stripped - so, in other words, changes to slider velocity and samples. However, a change to slider velocity requires default application to take effect, so just resetting the value would visually fix the timeline marker but not change the actual object. Calling `EditorBeatmap.Update()` fixes this by way of triggering default re-application. This could probably be smarter (by only invoking the update when strictly necessary, etc.) - but I'm not sure it's worth the hassle. This is intended to be a quick fix, rather than a complete solution - the complete solution would indeed likely entail a wholesale restructuring of the editor's change handling.	2023-10-30 10:59:02 +01:00
Dean Herbert	8828562512	Merge pull request #25277 from Susko3/fix-cut-in-filter-textbox ... Fix cut and copy not working in song select search filter textbox	2023-10-30 18:18:46 +09:00
Dean Herbert	63e6eaf538	Fix failing tests	2023-10-30 18:06:11 +09:00
Dean Herbert	57d88a0ac4	Fix right clicks on timeline objects potentially getting eaten by playfield area ... `SelectionHandler` is receiving input from anywhere out of necessity: 19f892687a/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs (L119-L125) Also important is that `BlueprintContainer` will selectively not block right clicks to make sure they fall through to the `ContextMenuContainer`: 19f892687a/osu.Game/Screens/Edit/Compose/Components/BlueprintContainer.cs (L122-L126) But because the whole editor is sharing a `ContextMenuContainer` and it's at a higher level than both components, we observe here the playfield's `SelectionHandler` intercepting the right click before it can reach the `ContextMenuContainer`. The fix here is similar to what we're already doing in `TimelineBlueprintContaienr`.	2023-10-30 18:06:11 +09:00
Bartłomiej Dach	19d10e5e45	Merge pull request #25300 from peppy/better-submission-logging ... Improve log output surrounding score submission	2023-10-30 09:04:06 +01:00
Dean Herbert	caddbacfe8	Merge branch 'master' into gameplay-hud-redesign/counters	2023-10-30 16:35:10 +09:00
Dean Herbert	a91b704d21	Fix some new nullable inspections	2023-10-30 15:10:10 +09:00
Dean Herbert	d90f29a5ff	Improve log output surrounding score submission	2023-10-30 15:07:26 +09:00
Susko3	366e41f111	Use local workaround instead of disabling clipboard entirely	2023-10-28 12:23:23 +02:00
Dean Herbert	5a9d4170e8	Merge pull request #24794 from bdach/score-encoding-cleanup ... Correctly handle multiple online score ID types	2023-10-28 02:29:56 +09:00
Bartłomiej Dach	35f30d6135	Scale back debug assertion ... The import preparation task can actually be non-null when exiting even if the player hasn't passed: - fail beatmap - click import button to import the failed replay	2023-10-27 14:39:58 +02:00
Bartłomiej Dach	dc7f5cd6ed	Add preventive assertions concerning submission flow state	2023-10-27 13:30:51 +02:00
Bartłomiej Dach	2d5b1711f6	Share !HasPassed condition	2023-10-27 13:27:48 +02:00
Bartłomiej Dach	96d784e06b	Delete ScoreInfo.HasReplay as no longer needed	2023-10-27 12:39:54 +02:00
Bartłomiej Dach	86a8ab6db6	Fix quick retry immediately after completion marking score as failed ... Closes https://github.com/ppy/osu/issues/25247. The scenario involved here is as follows: 1. User completes beatmap by hitting all notes. 2. `checkScoreCompleted()` determines completion, and calls `progressToResults(withDelay: true)`. 3. `progressToResults()` schedules `resultsDisplayDelegate`, which includes a call to `prepareAndImportScoreAsync()`, a second in the future. 4. User presses quick retry hotkey. This calls `Player.Restart(quickRestart: true)`, which invokes `Player.RestartRequested`, which in turn calls `PlayerLoader.restartRequested(true)`, which in turn causes `PlayerLoader` to make itself current, which means that `Player.OnExiting()` will get called. 5. `Player.OnExiting()` sees that `prepareScoreForDisplayTask` is null (because `prepareAndImportScoreAsync()` - which sets it - is scheduled to happen in the future), and as such assumes that the score did not complete. Thus, it marks the score as failed. 6. `Player.Restart()` after invoking `RestartRequested` calls `PerformExit(false)`, which then will unconditionally call `prepareAndImportScoreAsync()`. But the score has already been marked as failed. The flow above can be described as "convoluted", but I'm not sure I have it in me right now to try and refactor it again. Therefore, to fix, switch the `prepareScoreForDisplayTask` null check in `Player.OnExiting()` to check `GameplayState.HasPassed` instead, as it is not susceptible to the same out-of-order read issue.	2023-10-27 12:17:03 +02:00
Dean Herbert	fc25e24397	Merge branch 'master' into score-encoding-cleanup	2023-10-27 18:03:38 +09:00
Bartłomiej Dach	fdb81bfa4c	Rename methods to not mention "source clock" anymore	2023-10-26 19:38:52 +02:00
Bartłomiej Dach	565ae99e0d	Fix StopUsingBeatmapClock() applying adjustments to track it was supposed to stop using ... - Closes https://github.com/ppy/osu/issues/25248 - Possibly also closes https://github.com/ppy/osu/issues/20475 Regressed in e33486a766. `StopUsingBeatmapClock()` intends to, as the name says, stop operating on the working beatmap clock to yield its usage to other components on exit. As part of that it tries to unapply audio adjustments so that other screens can apply theirs freely instead. However, the aforementioned commit introduced a bug in this. Previously to it, `track` was an alias for the `SourceClock`, which could be mutated in an indirect way via `ChangeSource()` calls. The aforementioned commit made `track` a `readonly` field, initialised in constructor, which would _never_ change value. In particular, it would _always_ be the beatmap track, which meant that `StopUsingBeatmapClock()` would remove the adjustments from the beatmap track, but then at the end of the method, _apply them onto that same track again_. This was only saved by the fact that clock adjustments are removed again on disposal of the `MasterGameplayClockContainer()`. This - due to async disposal pressure - could explain infrequently reported cases wherein the track would just continue to speed up ad infinitum. To fix, fully substitute the beatmap track for a virtual track at the point of calling `StopUsingBeatmapClock()`.	2023-10-26 19:38:52 +02:00
Bartłomiej Dach	2fa2217381	Fix left side of carousel blocking volume adjust hotkeys ... Closes https://github.com/ppy/osu/issues/25234. A little ad-hoc, but probably fine...?	2023-10-26 16:26:35 +02:00
Bartłomiej Dach	5d6a58d443	Add failing test scene for scroll handling in song select	2023-10-26 16:24:16 +02:00
Bartłomiej Dach	cbb2a0dd70	Use both score ID types to deduplicate score on solo results screen	2023-10-26 15:09:59 +02:00
Bartłomiej Dach	ca4b09f8ef	Merge branch 'master' into score-encoding-cleanup	2023-10-26 09:04:05 +02:00
Salman Ahmed	07e7d533bf	Bake external scale factors into glyph scale	2023-10-26 10:01:27 +03:00
Salman Ahmed	df80b4dcab	Update "Argon" health display specifications to match design ... Also adds a little white bar next to the display to match with the components below it (score/accuracy/combo counters).	2023-10-26 09:12:05 +03:00
Salman Ahmed	50af1574cf	Add "Argon" background wedges	2023-10-26 09:10:56 +03:00
Salman Ahmed	56eeb117ce	Add "Argon" performance points counter	2023-10-26 09:10:10 +03:00
Salman Ahmed	daf4a03fd0	Abstractify PP counter logic from the "Triangles" implementation	2023-10-26 09:09:55 +03:00
Salman Ahmed	0aa0562dc0	Add "Argon" combo counter	2023-10-26 09:09:55 +03:00
Salman Ahmed	1f36acca1a	Add "Argon" accuracy counter	2023-10-26 09:09:52 +03:00
Salman Ahmed	9ca672d689	Add "Argon" total score counter	2023-10-26 08:58:25 +03:00
Dean Herbert	6934e045df	Fix editor not prompting before saving beatmap for export	2023-10-25 14:39:46 +09:00
Dean Herbert	34505b3933	Merge pull request #25185 from bdach/minimum-sample-volume	2023-10-24 22:04:43 +09:00
Bartłomiej Dach	19be0055d5	Merge pull request #24921 from Pasi4K5/diff-name-search ... Add ability to search for difficulty names using square brackets	2023-10-24 12:07:02 +02:00
Dean Herbert	c9161a7bfc	Remove incorrect copy paste fail	2023-10-24 17:32:01 +09:00
Bartłomiej Dach	abfe2ce0fe	Fix comment	2023-10-24 10:05:20 +02:00
Dean Herbert	fcb366af4d	Add diff= support for more advanced usages	2023-10-24 16:09:05 +09:00
Dean Herbert	6865d8894d	Simplify implementation and remove unsupported test coverage	2023-10-24 16:01:32 +09:00
Bartłomiej Dach	05d7516479	Merge pull request #25182 from peppy/song-select-scroll-improvemets ... Improve mouse interactions at song select	2023-10-24 08:26:20 +02:00
Dean Herbert	1274829193	Block scroll and click operations on the left side of song select	2023-10-24 14:51:40 +09:00
Pasi4K5	c5339f440e	Apply code review suggestions	2023-10-23 23:30:54 +02:00
Bartłomiej Dach	12282fff5c	Disallow setting sample volume lower than 5% in editor	2023-10-20 15:50:21 +02:00
Dean Herbert	0ae0b0c353	Fix carousel "reset position" marging not scaling with UI scale correctly	2023-10-20 20:04:26 +09:00
Dean Herbert	137a1d948d	Allow interacting with the carousel anywhere in empty space at song select	2023-10-20 20:04:11 +09:00
Susko3	5bbbca3e44	Also support D for those with muscle memory from stable	2023-10-20 12:22:00 +02:00
Susko3	4a3a4ee17f	Change beatmap listing key to B to match Ctrl-B shortcut	2023-10-20 11:47:00 +02:00
Dean Herbert	52c2eb93de	Merge branch 'master' into taiko-beat-snap-grid	2023-10-19 23:53:01 +09:00
Dean Herbert	e081fa48a2	Fix various other inspections	2023-10-17 17:48:51 +09:00
Dean Herbert	5341a335a6	Bypass Parent nullability checks for now	2023-10-17 17:48:45 +09:00
Dean Herbert	2a89a25790	Add beat snap grid to osu!taiko editor ... Addresses https://github.com/ppy/osu/discussions/25150.	2023-10-17 16:59:56 +09:00
Dean Herbert	1b9acdf55c	Abstract out common implementation of BeatSnapGrid	2023-10-17 16:42:52 +09:00
Bartłomiej Dach	fb2293821a	Allow watching replay from multi/playlist results screens	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	c4af8591a5	Preserve OnlineID when importing scores ... Previously, for lazer scores, the ID returned from `osu-web` was discarded and replaced with -1, due to the fact that the appropriate structures for unification with stable, as well as unification across solo and multiplayer, were not in place yet. Now we're at the point where scores from all the aforementioned sources receive a `solo_scores` DB row, and as such, we can start treating `solo_scores`-scheme IDs as canonical "online IDs" for a score.	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	9cd33d9bb2	Merge pull request #25139 from peppy/collection-ordering-fix ... Fix collections not being sorted alphabetically in context menus	2023-10-16 10:53:43 +02:00
Dean Herbert	7139592e43	Fix collections not being sorted correctly in context menus	2023-10-16 16:03:12 +09:00
Dean Herbert	48832c64ac	Fix health bar animating when it shouldn't be ... It wasn't correctly checking the current underlying health, which could be zero in usages of `AccumulatingHealthProcessor`, for instance. Closes #25046.	2023-10-16 13:12:04 +09:00
Jamie Taylor	d97b618d02	Use new generic-error sample in appropriate places	2023-10-13 21:06:50 +09:00
Bartłomiej Dach	5f51b8a7c9	Merge pull request #25097 from peppy/results-screen-progress-fast ... Show results immediately if user hits "back" key after finishing gameplay	2023-10-13 11:54:34 +02:00
Bartłomiej Dach	79cec7707d	Privatise setter	2023-10-13 09:56:46 +02:00
Bartłomiej Dach	6c8490bc7e	Revert changes to LoungeSubScreen.Join() ... - `virtual` modifier was used in mocking. - The spacing change revert is just mostly to keep it out of the final diff.	2023-10-12 20:39:40 +02:00
Dean Herbert	fa47309eef	Fix exit key during storyboard outro not progressing to results	2023-10-12 19:31:54 +09:00
Dean Herbert	d174a6ce61	Remove dead code which was only there for the exit-specific scenario	2023-10-12 19:27:35 +09:00
Dean Herbert	32eda99c3a	Add missing xmldoc returns	2023-10-12 19:06:34 +09:00
Dean Herbert	56e27f1c27	Merge branch 'master' into multiplayer-invites	2023-10-12 18:17:15 +09:00
Dean Herbert	94d7a65e40	Schedule Join operations rather than using OnLoadComplete for added safety	2023-10-12 17:42:02 +09:00
Dean Herbert	242a41371c	Fix HotkeyOverlay fade out occurring when exit is blocked	2023-10-12 15:42:54 +09:00
Dean Herbert	7c0d496730	Show results immediately if user hits "back" key after finishing gameplay ... I've gone ahead and matched the osu!stable behaviour for this, as it seems like it's what people are used to and they will settle for no less. Closes https://github.com/ppy/osu/issues/18089.	2023-10-12 15:42:23 +09:00
Dean Herbert	b9dbc8139b	Merge branch 'master' into fix-argon-health-bar-flash	2023-10-11 00:20:08 +09:00
Bartłomiej Dach	d701e88a08	Merge pull request #25076 from peppy/fix-argon-health-bar-perf ... Ensure health displays don't pile up transforms when off-screen	2023-10-10 16:33:32 +02:00
Dean Herbert	b9dadc52b7	Adjust comment to match current behaviour ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-10-10 22:54:19 +09:00
Dean Herbert	e2e28ef0ca	Remove comment regarding inlined delegate	2023-10-10 22:12:20 +09:00
Dean Herbert	682aa06acf	Remove JudgementResult from Miss/Flash as it is not used	2023-10-10 22:10:44 +09:00
Dean Herbert	f0bd975393	Change GameplayClockContainer.Reset to directly call GameplayClock.Stop ... The reasoning is explained in the inline comment, but basically this was getting blocked by `isPaused` being in an initial `true` state (as it is on construction), while the source clock was still `IsRunning`. There's no real guarantee of sync between the source and the `isPaused` bindable right now. Maybe there should be in the future, but to restore sanity, let's ensure that a call to `Reset` can at least stop the track as we expect.	2023-10-10 18:16:14 +09:00
Dean Herbert	100c0cf533	Fix MultiplayerPlayer never calling Reset on GameplayClockContainer ... This call is responsible for ensuring the clock is in a stopped state.	2023-10-10 17:58:37 +09:00
Dean Herbert	eee7dc02da	Reduce severity of clock running check to avoid production crashes	2023-10-10 17:58:11 +09:00
Dean Herbert	4674f63655	Fix Scheduler.AddOnce not working in one location	2023-10-10 16:17:34 +09:00
Dean Herbert	7e68b64526	Avoid running finishInitialAnimation when already finished	2023-10-10 15:59:48 +09:00
Dean Herbert	1eb6c93916	Also debounce updatePathVertices to reduce overhead	2023-10-10 15:50:42 +09:00
Dean Herbert	6c346874d3	Add TODO mentioning that ArgonHealthDisplay is doing lerp wrong	2023-10-10 15:24:54 +09:00
Dean Herbert	57f588fa86	Ensure health displays don't pile up transforms when off-screen	2023-10-10 15:24:54 +09:00
Dean Herbert	6ee958743e	Adjust glow animation specifics slightly	2023-10-10 15:10:42 +09:00
Dean Herbert	aeb579eb54	Syncrhonise initial colour of glowBar for sanity	2023-10-10 15:10:27 +09:00
Dean Herbert	8e26b3c405	Fix argon health bar not completing flash animation correctly	2023-10-10 15:09:33 +09:00
Bartłomiej Dach	ca217094d6	Merge pull request #25063 from peppy/move-download-button ... Move playlist item download button to left	2023-10-09 10:01:15 +02:00
Dean Herbert	142c61ab9b	Move playlist item download button to left	2023-10-09 12:21:56 +09:00
Dean Herbert	e5207167c8	Rename FailAnimation to FailAnimationContainer	2023-10-08 00:39:30 +09:00
Dean Herbert	7c7771afca	Merge pull request #24986 from peppy/health-animates-in-intro ... Add initial animation for health bars	2023-10-07 10:31:34 +09:00
Bartłomiej Dach	cfcdbe1c30	Merge pull request #25028 from peppy/bindable-fixes ... Fix some incorrect bindable-related code	2023-10-06 22:31:30 +02:00
Bartłomiej Dach	a099cc0f36	Merge pull request #25030 from peppy/adjustable-health-bar ... Adjust argon health bar to fit with existing layout	2023-10-06 21:51:18 +02:00
Bartłomiej Dach	b7d0bf3756	Only flush the Current transform specifically	2023-10-06 21:39:29 +02:00
Bartłomiej Dach	ce0d4bd0df	Fix health display potentially desyncing from actual if health was changed during initial animation	2023-10-06 21:35:08 +02:00
Dean Herbert	58448d3dd9	Fix health animation affecting failing tint	2023-10-07 01:06:31 +09:00
Dean Herbert	1a60e6d76e	Merge branch 'master' into health-animates-in-intro	2023-10-07 00:32:19 +09:00
Dean Herbert	8e5b2e78e5	Fix variable clash	2023-10-06 21:01:23 +09:00
Dean Herbert	d87ab9c82d	Adjust transition time based on miss/hit	2023-10-06 19:34:38 +09:00
Dean Herbert	3f2a00d90d	Add argon health display to default skin layout	2023-10-06 19:34:27 +09:00
Dean Herbert	f40e910c51	Remove left line from health display	2023-10-06 19:34:27 +09:00
Dean Herbert	db5178e453	Change ArgonHealthDisplay to be relative sized for now	2023-10-06 18:56:39 +09:00
Dean Herbert	936a21a661	Fix redundant bindable initialisation in SongSelect	2023-10-06 16:51:56 +09:00
Dean Herbert	1d7b8ea21a	Fix incorrect implementation of IHasCurrentValue in FooterButtonFreeMods	2023-10-06 16:51:40 +09:00
Dean Herbert	f2e56bbb65	Fix publicly-settable bindables	2023-10-06 16:51:24 +09:00
Dean Herbert	1005b7ac85	Fix incorrect test assumption in TestSceneEditorClock ... I don't know what this test was trying to do, but it was wrong. Any offset which is applied should be invisible to the clock's final `CurrentTime` (and to the user).	2023-10-06 16:43:28 +09:00
Dean Herbert	354193c53a	Merge branch 'master' into clock-fix-attempt-2	2023-10-06 16:43:27 +09:00
Dean Herbert	61fd4186af	Ensure regenerateDisplay is eventually performed if originally called before load	2023-10-05 22:55:23 +09:00
Dean Herbert	76cc2f9f22	Fix WaveformComparisonDisplay potentially crashing on invalid track length ... As seen at https://github.com/ppy/osu/runs/17415814918#r0s2.	2023-10-05 14:58:55 +09:00
Bartłomiej Dach	bd71403309	Merge branch 'master' into health-animates-in-intro	2023-10-04 13:53:42 +02:00
Dean Herbert	5a17a86d1d	Merge branch 'master' into clock-fix-attempt-2	2023-10-04 16:57:49 +09:00
Marvin Schürz	6d97f89399	Rename OnlinePlayScreen.LoungeSubScreen to Lounge	2023-10-04 08:37:22 +02:00
Bartłomiej Dach	844a3b6c1b	Merge pull request #24980 from frenzibyte/gameplay-hud-redesign/health-display ... Implement redesigned health bar display for "Argon" skin	2023-10-03 11:26:21 +02:00
Dean Herbert	4f3c433946	Move vertex related constants local to method	2023-10-03 17:41:52 +09:00
Dean Herbert	32b2ac4974	Rename and refactor glow/miss bars to hopefully make more sense	2023-10-03 17:41:11 +09:00
Dean Herbert	4f9daa1c14	Tidy up ArgonHealthDisplay code quality	2023-10-03 17:32:35 +09:00
Dean Herbert	8178cf3a8d	Tidy up background colour gradient logic ... This changes things visually a touch, but I think it feels better. And reads better.	2023-10-03 17:17:11 +09:00
Marvin Schürz	a171fa7649	Join multiplayer match when clicking the invite notification	2023-10-03 01:31:30 +02:00
Dean Herbert	82ba545358	Add initial animation for health bars	2023-10-02 17:01:58 +09:00
Dean Herbert	3a45bcad15	Improve flash and glow further	2023-10-02 02:11:07 +09:00
Dean Herbert	c4f47974bc	Improve glow further	2023-10-02 02:11:07 +09:00
Dean Herbert	88d608e1fa	Tidy up common animation code	2023-10-02 02:11:07 +09:00
Dean Herbert	df51e61234	Improve animation	2023-10-02 00:42:51 +09:00
Dean Herbert	22aa7ffd06	Use additive colour	2023-10-01 22:09:59 +09:00
Salman Ahmed	eef099e69d	Do not display "miss" bar if health is already zero	2023-10-01 15:25:34 +03:00
Salman Ahmed	7825bea959	Use interpolation for health bar opacity instead of transforms	2023-10-01 15:25:23 +03:00
Salman Ahmed	30d9004ef9	Fix small mistake	2023-10-01 13:41:11 +03:00
Salman Ahmed	446c9c2efe	Apply adjustments on the "miss" bar display	2023-10-01 13:39:36 +03:00
Salman Ahmed	9e2b8254d9	Add argon-specific health display test scene	2023-10-01 13:26:47 +03:00
Salman Ahmed	a331fb993a	Adjust health bar outer stroke colour	2023-10-01 01:21:37 +03:00
Salman Ahmed	319208ca3d	Adjust health bar glow intensity	2023-10-01 01:18:05 +03:00
Salman Ahmed	776536e816	Add "Argon" health display implementation	2023-10-01 00:56:16 +03:00
Salman Ahmed	33b0cb15a8	Add handling for miss judgements in HealthDisplay	2023-10-01 00:21:25 +03:00
Pasi4K5	c927f90a48	Replace regex with a custom algorithm and update test scene.	2023-09-29 13:46:33 +02:00
Pasi4K5	23c20ca5f4	Add xmldocs	2023-09-29 13:44:11 +02:00
Joseph Madamba	9e90374a90	Flash discard changes dialog popup when force quitting room/playlist creation with changes	2023-09-28 17:09:50 -07:00
Bartłomiej Dach	8215c4cb0e	Merge branch 'master' into mods-stable-ordering	2023-09-28 18:30:56 +02:00
Bartłomiej Dach	7638ea36a0	Merge branch 'master' into mod-icon-extended	2023-09-28 16:57:17 +02:00
Bartłomiej Dach	90326f62a7	Merge pull request #24953 from peppy/flash-dialog-on-stuck ... Flash dialog popup when attempting to exit editor while exit is being blocked	2023-09-28 11:04:38 +02:00
Bartłomiej Dach	afa1815d13	Merge pull request #24929 from peppy/reduce-song-select-debounce ... Reduce delay before loading beatmap after selection change at song select	2023-09-28 10:45:43 +02:00
Dean Herbert	7d74d84e6c	Display mod icons using stable ordering ... In discussion with nanaya, we likely want this now that we're adding the ability for some icons to be extended. Historically mod icons have been displayed in a stable but arbitrary order (based on their position in the `Mods` enum). This change aims to make them stable across lazer scores (where they are stored based on .. the order the user selected them).	2023-09-28 16:48:09 +09:00
Dean Herbert	7908b36b39	Flash dialog popup when attempting to exit editor while exit is being blocked	2023-09-28 15:25:39 +09:00
Dean Herbert	9f4df29880	Adjust fade durations at player loader to better hide mod jank	2023-09-27 19:29:03 +09:00
Dean Herbert	a639e51ddb	Fix value not updating after missing beatmap is imported	2023-09-27 18:17:25 +09:00
Dean Herbert	175cf68bd6	Avoid re-fetching WorkingBeatmap	2023-09-27 18:13:07 +09:00
Dean Herbert	ae31a8fadf	Reduce delay before loading beatmap after selection change at song select ... This was originally set high because of performance concerns. We have since improved things quite drastically. Even with a very low debounce my song select is amazingly smooth. This is about as low as we can got unless we want chaos when key repeating left/right arrows (it's not as bad as you think, maybe worth testing during review and see if it feels more expected?). Of note, stable has key repeat disabled on left/right arrows and zero debounce. Addresses concerns in https://github.com/ppy/osu/discussions/24916.	2023-09-26 16:21:09 +09:00
Fabian van Oeffelt	2040dcabe0	Improve Code Quality	2023-09-25 17:51:39 +02:00
Fabian van Oeffelt	2a3391d83b	Remove unused namepace	2023-09-25 16:56:34 +02:00
Fabian van Oeffelt	59d3143645	Fix SR/BPM Display in Playlist rooms	2023-09-25 16:53:40 +02:00
Pasi4K5	74896fd6b2	Fix multiple difficulty search queries not working in some cases.	2023-09-25 13:38:47 +02:00
Pasi4K5	793d1bf970	Add ability to search for difficulty names	2023-09-25 12:52:49 +02:00
Dean Herbert	d019cb5167	Update in line with framed clock changes	2023-09-22 22:02:18 +09:00
Dean Herbert	251a85db43	Fix StopUsingBeatmapClock not transferring time and running state	2023-09-22 16:22:36 +09:00
Dean Herbert	faa0481fc6	Fix editor operating directly on track rather than decoupled clock	2023-09-22 16:22:36 +09:00
Dean Herbert	8367bb6bee	Don't apply decoupling to SpectatorPlayerClocks ... See inline comment for reasoning. It's a bit complicated.	2023-09-22 16:22:35 +09:00
Dean Herbert	bf08fbe196	Set source directly in FramedBeatmapClock ctor ... This isn't required, but avoids creating a temporary `StopwatchClock` and generally just makes debug easier with less state changes.	2023-09-22 16:22:35 +09:00
Dean Herbert	586311d508	Fix souce clock not always being transferred to FramedBeatmapClock in time	2023-09-22 16:22:35 +09:00
Dean Herbert	a1e298930c	Remove second hopefully-unnecessary workaround	2023-09-22 14:41:07 +09:00
Dean Herbert	df08c4e1ad	Disable decoupling for OsuGameBase's beatmap implementation ... This avoids it ever mutating the underlying track (aka attempting to start it). Resolves the one caveat mentioned in aeef92fa710648d4a00edc523e13c17ac6104125.	2023-09-22 12:49:25 +09:00
Dean Herbert	117cd74af6	Update usage of DecoupleableInterpolatingFramedClock in FramedBeatmapClock	2023-09-22 12:49:25 +09:00
Dean Herbert	3f27be1f33	Replace most usages of DecoupleableInterpolatingFramedClock ... Except `FramedBeatmapClock`, which is the high-effort one.	2023-09-22 12:49:25 +09:00
Dean Herbert	600651795b	Change FramedBeatmapClock to always be decoupled	2023-09-22 12:49:25 +09:00
Salman Ahmed	5266cdc722	Add explanatory note	2023-09-21 20:41:10 +03:00
Salman Ahmed	095812c6b8	Merge branch 'master' into fix-song-select-shift-delete	2023-09-21 20:25:43 +03:00
Salman Ahmed	9e4a56d64e	Merge branch 'master' into update-framework	2023-09-21 19:49:20 +03:00
Dean Herbert	9af4e75dfc	Disable clipboard export for song select textbox ... In combination with https://github.com/ppy/osu-framework/pull/5997, closes https://github.com/ppy/osu/issues/24867	2023-09-22 01:24:29 +09:00
Bartłomiej Dach	69ed99dfd5	Merge branch 'master' into mania-edit-disable-sv	2023-09-21 09:13:27 +02:00
Dean Herbert	bf984388b3	Update clocks in line with framework changes	2023-09-20 21:17:08 +09:00
Dean Herbert	c5397bdbb3	Merge branch 'master' into mania-edit-disable-sv	2023-09-20 14:23:07 +09:00
Dean Herbert	71ac5cfc79	Don't bother binding to friends changes for score display purposes	2023-09-20 14:14:37 +09:00
Dean Herbert	1927b524db	Merge branch 'master' into leaderboard-friend-highlight	2023-09-20 14:14:08 +09:00
Bartłomiej Dach	3bddf4bf9a	Rename spectator-specific settings to more generic (with backwards migration)	2023-09-18 14:56:06 +02:00
Bartłomiej Dach	9b391cd661	Merge branch 'master' into import-task-improve	2023-09-14 19:37:01 +02:00
Dean Herbert	541cd972e1	Rename ArchiveReader implementations to read better	2023-09-14 13:36:07 +09:00
Dan Balasescu	753c1c877c	Revert masking SSBO changes	2023-09-13 23:10:13 +09:00
Givikap120	1a70110a4e	Added BeatmapAttributesDisplay support	2023-09-12 16:44:44 +03:00
Givikap120	c61212c523	Merge pull request #1 from Givikap120/master ... add display to calibrate	2023-09-12 13:02:19 +03:00
Bartłomiej Dach	589f56d20c	Merge branch 'master' into map_info_on_mod_settings	2023-09-11 09:55:54 +02:00
Bartłomiej Dach	76bf82d900	Do not show mod effects on free mod select	2023-09-11 09:55:45 +02:00
Givikap120	ed213dad6c	minor format fix (again)	2023-09-08 20:38:24 +03:00
Givikap120	a01537c763	minor format fix	2023-09-08 20:37:07 +03:00
Givikap120	02e2b8546c	fixed all stated problems	2023-09-08 20:32:55 +03:00
Joseph Madamba	d0780fb765	Add comment explaining the max width	2023-09-06 15:01:55 -07:00
Joseph Madamba	97bd90c0ff	Link new song select wedge title and artist to search text box	2023-09-06 14:41:10 -07:00
cdwcgt	68752f95e5	color friend score to pink	2023-09-06 22:58:03 +09:00
Dean Herbert	1a37543d28	Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity	2023-09-06 19:01:08 +09:00
Bartłomiej Dach	b5e812eb3e	Merge pull request #24723 from bdach/beatmap-carousel-split-missing-status ... Fix status on carousel beatmap set not showing in split difficulty mode	2023-09-06 09:35:38 +02:00
Bartłomiej Dach	63e92f8fab	Fix status on carousel beatmap set not showing in split difficulty mode	2023-09-06 08:25:19 +02:00
Dean Herbert	dded7fe6ca	Merge branch 'master' into beatmap-options-popover	2023-09-06 15:16:34 +09:00
Joseph Madamba	73604d171a	Make "general" a common string	2023-09-05 23:00:07 -07:00
Joseph Madamba	701e24e8d3	Move hide button to end and make it work	2023-09-05 18:50:31 -07:00
Joseph Madamba	6d2e57b73e	Add localisation support to beatmap options popover	2023-09-05 18:43:42 -07:00
Joseph Madamba	69fa8747f0	Explicitly add beatmapinfo param to edit call	2023-09-05 18:35:35 -07:00
Joseph Madamba	9565039192	Hide beatmap options popover when beatmap changes	2023-09-05 18:24:54 -07:00
Joseph Madamba	9f10082ffc	Revert param removal of delete beatmap and clear scores methods	2023-09-05 18:24:53 -07:00
Joseph Madamba	8e8fae0fba	Fix left padding adding shear width	2023-09-05 15:21:23 -07:00
Joseph Madamba	3f92dae55c	Move star rating display and status pill out of reloadable content	2023-09-05 15:20:20 -07:00
Joseph Madamba	676240928e	Move actual star updating to star rating display	2023-09-05 14:57:55 -07:00
Joseph Madamba	5becac6431	Make beatmap non-nullable ... Doesn't seem like it'll be null after first set: 5454d1caa1/osu.Game/OsuGameBase.cs (L363)	2023-09-05 14:43:43 -07:00
Joseph Madamba	b63c1e4257	Remove mods dependency ... BPM is not in the wedge anymore.	2023-09-05 12:14:17 -07:00
Joseph Madamba	6e6dd86a51	Remove buffered container comment ... While it is true that there is a transparency overlap, it is only seen when entering/exiting song select. And there are other components game-wide that exhibit the same issue when transparency changes. Should be reconsidered another time.	2023-09-05 11:10:06 -07:00
Dean Herbert	4cd4eb3b0a	Move "general" to top for key binding compatibility	2023-09-05 16:46:49 +09:00
Dean Herbert	84d8d33ad7	Add headers and generally improve the UI of the popover	2023-09-05 16:44:55 +09:00
Dean Herbert	4ff3630484	Add a slight delay before hiding the popover to better visualise button click	2023-09-05 16:14:01 +09:00
Dean Herbert	a8c9c2bf17	Remove buffered container (doesn't seem like it's doing anything anymore)	2023-09-05 15:59:00 +09:00
Joseph Madamba	98d027d207	Fix star counter animating weird and delayed	2023-09-04 21:39:41 -07:00
Joseph Madamba	9accd0ded2	Fix star rating rolling counter regression	2023-09-04 21:21:56 -07:00
Joseph Madamba	82fb9dc2ef	Simplify text initialization	2023-09-04 12:59:21 -07:00
Joseph Madamba	e70510ef19	Move drawable and binding logic to standard places	2023-09-04 12:56:20 -07:00
Joseph Madamba	2df2002735	Move negative corner radius margin to constructor	2023-09-04 12:42:01 -07:00
Joseph Madamba	e8a793425b	Use right padding instead of negative x offset	2023-09-04 12:38:40 -07:00
Joseph Madamba	bf71099e57	Fix truncating sprite text usage	2023-09-04 12:04:20 -07:00
Joseph Madamba	2fbd67cf26	Merge branch 'master' into beatmap_wedge_clean_ii	2023-09-04 11:24:20 -07:00
Joseph Madamba	f616648730	Remove icon blending	2023-09-04 09:40:35 -07:00
Joseph Madamba	6c0bd13308	Add xmldoc to newly exposed methods	2023-09-04 00:53:14 -07:00
Joseph Madamba	5abf271b56	Implement beatmap options popover	2023-09-04 00:53:09 -07:00
Hồ Nguyên Minh	d5a89c4c45	Fix formatting	2023-09-04 13:32:42 +07:00
Hồ Nguyên Minh	b17a55d6a8	Add length check for slider velocity	2023-09-04 10:43:05 +07:00
Magnus-Cosmos	d674856e29	Use existing localisations in BeatmapInfoWedge	2023-09-02 22:49:29 -04:00
Givikap120	5e5fe84a88	Update AdvancedStats.cs	2023-09-03 02:19:02 +03:00
Givikap120	0779cd8f4f	minor design fixes	2023-09-03 02:17:04 +03:00
Givikap120	2e2d4d0d60	Merge branch 'map_info_on_mod_settings' of https://github.com/Givikap120/osu into map_info_on_mod_settings	2023-09-03 02:09:18 +03:00
Givikap120	b0398b6259	functionality is done	2023-09-03 02:09:01 +03:00
Bartłomiej Dach	76954f6e91	Merge branch 'master' into skin-editor-selection-negative-scaling	2023-09-01 21:30:24 +02:00
Wleter	fc4069f794	let SelectionBox perform flip with scale handles	2023-09-01 13:01:51 +02:00
Dean Herbert	0f5eff1230	Merge branch 'master' into mania-edit-disable-sv	2023-09-01 19:08:48 +09:00
Dean Herbert	96a5443813	Merge branch 'master' into carousel-difficulty-split	2023-08-30 14:24:30 +09:00
Dean Herbert	cbd4b91feb	Merge pull request #24678 from Nabile-Rahmani/bot-scores ... Fix and use score user's IsBot property in results screen animation	2023-08-30 14:00:35 +09:00
Nabile Rahmani	b658b0e346	Fix and use score user's IsBot property in results screen animation ... While a mod-created replay did flag itself as performed by a bot, the extension method converting it into a Score did not copy all the generated properties. As noted, it might be preferable for ModCreatedUser to inherit APIUser and forward it as-is to the Score instance. Related to PR #24675	2023-08-29 23:28:50 +02:00
Wleter	14ee0ee395	Merge branch 'ppy:master' into skin-editor-selection-negative-scaling	2023-08-29 17:30:55 +02:00
Wleter	d56ab0fe9a	change names	2023-08-29 17:25:52 +02:00
Givikap120	f8adc911cd	Merge branch 'ppy:master' into map_info_on_mod_settings	2023-08-28 23:17:04 +03:00
Givikap120	50235cc245	somewhat working prototype	2023-08-28 23:16:33 +03:00
Wleter	07e126241d	working negative scaling	2023-08-28 16:41:55 +02:00
Bartłomiej Dach	97d1c6e9fc	Merge branch 'master' into carousel-difficulty-split	2023-08-28 11:07:43 +02:00
Bartłomiej Dach	b9795eb3d4	Fix changes to beatmap sets being undone on switching sort mode	2023-08-28 11:02:22 +02:00
Bartłomiej Dach	80ec18d117	Fix incorrect selection restore code in split case ... The fallback to "any of the added sets" needs to be applied after they've all been added, rather than with every added one. Otherwise, in flows that expect a particular difficulty to be selected in the end (such as exiting from editor) would end up switching away from the edited beatmap.	2023-08-28 10:06:26 +02:00
Bartłomiej Dach	0af6cc1394	Fix online ID not being propagated in split difficulty mode ... Would result in failures to re-download the beatmap in update flows, for instance.	2023-08-28 10:05:59 +02:00
Givikap120	290f8db341	fixed stated problems ... removed functions from `Ruleset.cs` and added a `GetEffectiveDifficulty()` instead	2023-08-26 02:13:14 +03:00
Givikap120	8a1fc7c340	Basic stuff (not working for now)	2023-08-26 01:20:41 +03:00
Dean Herbert	10b1450138	Rename remove method to better explain return type being IEnumerable	2023-08-25 18:10:54 +09:00
Givikap120	d5ac93f631	Added "value is rate changed" indication ... Now if AR or OD value is not "true" and changed through rate - it will appear with symbol `*` Instead of `11` it wil show as `11*`	2023-08-25 01:25:12 +03:00
Givikap120	772633178c	Moved ruleset decl in right place	2023-08-25 01:02:12 +03:00
Givikap120	17b9b1649a	Fixed "works only for std" problem ... 1) Now it use AR/OD calculation from Ruleset class 2) Implemented needed functions in each of default rulesets	2023-08-25 00:58:26 +03:00
Dean Herbert	89eeff515b	Reduce complexity of selection restore	2023-08-25 00:52:54 +09:00
Givikap120	ed886a4dc3	Added a true AR/OD display when using DT/HT	2023-08-24 16:49:42 +03:00
Dean Herbert	9e94f38091	Fix typo in local variable	2023-08-24 18:33:15 +09:00
Dean Herbert	081fb308e1	Merge branch 'master' into new-overlay-sfx	2023-08-24 18:29:00 +09:00
Jamie Taylor	2e27a476bb	Re-enable sample playback for PasswordEntryPopover and remove sampleJoin playback instead	2023-08-24 18:04:47 +09:00
Dean Herbert	018be4c20f	Fix selection not being retained when switching between split mode	2023-08-22 18:49:02 +09:00
Dean Herbert	ecbf0f138e	Fix incorrect handling when new beatmaps arrive	2023-08-22 18:48:07 +09:00
Dean Herbert	2b1c6ae612	Ensure ID is maintained in temporary BeatmapSetInfos	2023-08-22 18:48:07 +09:00
Dean Herbert	290d18ad69	Split out difficulties in beatmap carousel in a bit of a hacky way ... Seems like the simplest path forward for now, without a full rewrite.	2023-08-22 18:47:41 +09:00
Dan Balasescu	e8337c592a	Update framework and apply changes to support masking SSBO	2023-08-22 12:50:13 +09:00
Dean Herbert	e7d61e0002	Fix star fountain directions not matching stable	2023-08-21 17:59:24 +09:00
Dean Herbert	4915b2563c	Merge pull request #24366 from Joehuu/supporter-playlist-duration ... Always show supporter-only playlist durations	2023-08-21 17:46:26 +09:00
Dean Herbert	8120c3f87a	Merge branch 'master' into precise-rotation-2	2023-08-19 23:25:42 +09:00
Dan Balasescu	a2fd7707a1	Allow toggling SVs in the editor	2023-08-18 18:55:24 +09:00
Dean Herbert	9023059bc0	Convert to switch statement	2023-08-18 17:27:09 +09:00
Dean Herbert	75750957c7	Add note about why pop in samples are disabled for PasswordEntryPopover	2023-08-18 17:11:30 +09:00
OliBomby	360f9750e1	Allow selecting empty control point groups	2023-08-17 16:30:18 +02:00
Jamie Taylor	d10d7b6ea4	Change some component samples to go better with overlay pop-in samples	2023-08-17 18:36:37 +09:00
Jamie Taylor	3d7ba0e18c	Add pop-in/pop-out sfx to more overlays	2023-08-17 18:36:37 +09:00
Jamie Taylor	b15a54c914	Use new overlay pop-in/pop-out samples	2023-08-17 18:36:36 +09:00
Dean Herbert	a78c03bd5b	Merge branch 'master' into precise-rotation-2	2023-08-17 17:59:13 +09:00
OliBomby	88e6fe72dc	fix code quality	2023-08-16 23:09:04 +02:00
OliBomby	fd54c329fa	dont focus volume, so keybinds immediately available	2023-08-16 22:08:49 +02:00
OliBomby	a938b810b4	Add keybind for bank setting	2023-08-16 22:07:36 +02:00
OliBomby	02b7c8f27b	Move sliderbody hs to middle of first span	2023-08-16 21:15:47 +02:00
Dean Herbert	59a31cc868	Merge pull request #24431 from bdach/slider-with-textbox-instantaneous ... Add instantaneous mode to `SliderWithTextBoxInput`	2023-08-16 20:10:52 +09:00
Bartłomiej Dach	ed84be2f26	Merge pull request #24566 from peppy/multiplayer-spectator-score-diff ... Add score difference display to multiplayer spectator	2023-08-16 12:57:17 +02:00
Bartłomiej Dach	19f892687a	Add precise rotation control to osu! editor	2023-08-16 11:37:52 +02:00
Bartłomiej Dach	bdf87e43db	Merge branch 'master' into slider-with-textbox-instantaneous	2023-08-16 10:48:45 +02:00
Bartłomiej Dach	35af15f491	Merge branch 'master' into multi-spectator-fix-startup-delay	2023-08-16 10:34:20 +02:00
Dean Herbert	8b9759c569	Apply nullability to MatchScoreDisplay	2023-08-16 17:26:10 +09:00
Dean Herbert	ab826c35b7	Add score diff display to multiplayer spectator ... Basically pulling changes over from the tournament client implementation	2023-08-16 17:26:10 +09:00
Bartłomiej Dach	add1ef77d0	Fix typo in comment	2023-08-16 10:07:12 +02:00
Bartłomiej Dach	4f47b196c1	Merge branch 'master' into fix-unsafe-realm-access	2023-08-16 09:59:17 +02:00
Dean Herbert	bb98f10ff6	Use CurrentTime instead of StartTime for hotfix seek (and update comment)	2023-08-16 16:38:49 +09:00
Dean Herbert	184eabb902	Merge branch 'master' into multi-spectator-fix-startup-delay	2023-08-16 16:27:49 +09:00
Dean Herbert	31c2b7f925	Merge branch 'master' into leaderboard-toggle	2023-08-16 15:49:55 +09:00
Dean Herbert	5bd7370439	Add log output when editor is creating a fresh beatmap	2023-08-16 14:23:17 +09:00
Dean Herbert	e8bde6504a	Fix score being cloned in async method causing random crashes ... Closes https://github.com/ppy/osu/issues/24445.	2023-08-15 16:08:13 +09:00
Bartłomiej Dach	1b3806539a	Merge branch 'master' into leaderboard-toggle	2023-08-10 22:50:55 +02:00
Bartłomiej Dach	2698ec9206	Merge branch 'master' into block-exit-if-save-failed	2023-08-08 23:41:03 +02:00
Bartłomiej Dach	500a1363ec	Merge branch 'master' into fix-break-info-decimal-separator	2023-08-08 22:49:00 +02:00
nanashi-1	bd67e93310	fix code format	2023-08-07 11:16:51 +08:00
nanashi-1	f3f7d1ba7c	remove measly abstract	2023-08-07 09:50:24 +08:00
nanashi-1	92bf363ecf	use Drawable Rank	2023-08-06 20:43:09 +08:00
nanashi-1	4060373e03	add rank display element	2023-08-05 21:15:31 +08:00
Joseph Madamba	49f5d6813e	Block beatmap editor from testing/exiting/exporting when saving fails	2023-08-04 22:08:25 -07:00
Bartłomiej Dach	785d2ed9b1	Merge branch 'master' into multi-spectator-better-start-time	2023-08-03 22:07:47 +02:00
Bartłomiej Dach	52b1073d93	Fix playfield skin layer not rotating correctly with barrel roll mod	2023-08-03 21:08:00 +02:00
Bartłomiej Dach	dde03b7d46	Merge branch 'master' into playfield-skin-layer	2023-08-03 20:42:15 +02:00
Dean Herbert	71f6e5731d	Fix potential null reference if no frames found ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-03 08:58:19 +09:00
Dean Herbert	f38b21110f	Add missing parenthesis to comment ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-03 08:57:43 +09:00
Joseph Madamba	aab462fd95	Fix valueText being replaced even if current is not binding to anything	2023-08-02 09:40:22 -07:00
Dean Herbert	87fee001c7	Fix multiplayer spectator potentially taking too long to start ... When watching from the middle of gameplay, due to a series of failures, `SpectatorClock` would not get seeked to the current time, causing all clients to look like they were out of sync. This is a hotfix for the issue. A better fix will require framework changes or considerable restructuring. I'd recommend testing this works in practice and agreeing that while it is a hack, it's likely not going to cause issues and is something we want to see fixed sooner rather than later.	2023-08-02 19:05:43 +09:00
Dean Herbert	14d87e49c7	Improve choice of where to start playback of multiplayer spectator	2023-08-02 18:46:35 +09:00
Dean Herbert	0e510088f9	Ensure background of gameplay is black when storyboard is overriding background display	2023-08-02 15:50:15 +09:00
Dean Herbert	a618ed140e	Move StoryboardReplacesBackground bindable more local to usage	2023-08-02 15:29:18 +09:00
Bartłomiej Dach	5b6c3321cf	Merge branch 'master' into multi-spectator-flow-fixes	2023-08-01 19:03:48 +02:00
Bartłomiej Dach	a75f42f5a9	Merge branch 'master' into multi-spectator-extended-results	2023-08-01 18:25:41 +02:00
Bartłomiej Dach	f7d5ac9f92	Privatise setter	2023-08-01 18:09:48 +02:00
QuantumSno	054ca5e59c	Merge branch 'master' into leaderboard-toggle	2023-08-01 10:06:03 -04:00
Dean Herbert	70bd1d3cf4	Fix centred player not animating correctly	2023-08-01 20:18:21 +09:00
Dean Herbert	df504e1fc2	Show extended statistics in multiplayer spectator automatically	2023-08-01 20:02:36 +09:00
Dean Herbert	fe47dc291b	Fix onLoadRequested getting early-exited too early in spectator scenarios ... In some scenarios, multiplayer spectator would not tick over to the next beatmap. Here's an example: - Room has two items queued - Local user starts download of both - First beatmap starts and download is complete - First beatmap ends (spectating is active) - Second beatmap starts but download is not complete In this scenario, the local client will get stuck at the spectator screen due to the `onLoadRequested`-invoked screen change being early exited. It would require manual recovery (clicking back button) to return to a sane state.	2023-08-01 19:22:41 +09:00
Dean Herbert	9fe9ea2c90	Fix potential crash on multiple StartGameplay calls in multiplayer spectator	2023-08-01 19:22:41 +09:00
Bartłomiej Dach	2e2b0c4e41	Move SliderWithTextBoxInput to more general namespace	2023-08-01 01:01:36 +02:00
Dean Herbert	a3afb198a1	Merge pull request #24341 from bdach/selection-operations-refactor ... Refactor rotation handling in editor to facilitate reuse	2023-07-31 17:18:05 +09:00
Dean Herbert	f06b203067	Merge branch 'master' into edit-nodesample	2023-07-31 14:06:38 +09:00
Bartłomiej Dach	ebe5dd2ac9	Interface with SelectionRotationHandler via DI rather than explicit passing	2023-07-30 20:21:41 +02:00
Bartłomiej Dach	262f25dce8	Make SelectionRotationHandler a Component	2023-07-30 20:18:33 +02:00
Bartłomiej Dach	821cd08f34	Merge branch 'master' into selection-operations-refactor	2023-07-30 19:29:06 +02:00
Bartłomiej Dach	7763f3dd40	Fix osu! logo suddenly disappearing during rapid exit	2023-07-30 19:05:37 +02:00
Bartłomiej Dach	d3435483eb	Fix multiplayer match screen being exited from when not current ... This was supposed to be fixed by #24255, but has popped up as a regression on Sentry since: https://sentry.ppy.sh/organizations/ppy/issues/22749/?project=2&referrer=regression_activity-email On a fifteen-minute check I cannot figure out how to reproduce, so rather than spending further brain cycles on this, just apply the same explicit guard that like fifteen other places do.	2023-07-30 15:50:10 +02:00
Bartłomiej Dach	1f7f336fd5	Merge branch 'master' into fix-replay-export-queued-op	2023-07-30 14:58:14 +02:00
Bartłomiej Dach	898913f32a	Merge pull request #24415 from peppy/multi-spectator-improvements ... General visual improvements to mutliplayer spectatator screen	2023-07-30 12:43:26 +02:00
Bartłomiej Dach	e208f38bcb	Merge pull request #24361 from peppy/fix-editor-global-music-hotkey-conflicts ... Disallow interacting with the global track state in `Player` and `Editor`	2023-07-30 12:28:53 +02:00
Dean Herbert	6d5b3617b3	Remove pending export operation if active score is changed	2023-07-30 16:41:45 +09:00
Dean Herbert	35ec55c1f6	Don't queue export replay operations if button is disabled	2023-07-30 16:41:33 +09:00
Dean Herbert	45ceaba00d	Disable multiplayer spectator zoom when there's only one player's screen visible	2023-07-30 14:40:58 +09:00
Dean Herbert	945d89e955	Move disables to loading screens for better coverage of edge cases	2023-07-30 13:45:42 +09:00
Joseph Madamba	4ddf05602f	Update BreakInfoLine to formatting standards	2023-07-29 11:05:15 -07:00
Joseph Madamba	6ebfafa9c3	Remove unnecessary text comparison	2023-07-29 11:02:04 -07:00
Joseph Madamba	740898dffb	Remove unnecessary prefix parameter	2023-07-29 10:40:18 -07:00
Joseph Madamba	9d928c0225	Apply NRT to BreakInfoLine	2023-07-29 10:39:50 -07:00
Dean Herbert	75625f089e	Hide toolbar when entering multiplayer spectator	2023-07-30 02:29:14 +09:00
Dean Herbert	38244c081f	Further refactorings along with shadow implementation	2023-07-30 02:29:14 +09:00
Dean Herbert	84bc14c1dd	Improve animation and sizing of maximised screen display	2023-07-30 02:29:14 +09:00
Dean Herbert	1826819663	Move Facade to nested class	2023-07-30 02:29:14 +09:00
Dean Herbert	5fa0a21b56	Add corner radius around player areas	2023-07-30 02:29:14 +09:00
Bartłomiej Dach	579b0bc570	Merge branch 'master' into fix-autoplay-mod-revert	2023-07-29 16:12:11 +02:00
Joseph Madamba	a3301dc7ff	Fix accuracy break info decimal separator being incorrect in certain languages	2023-07-28 23:26:07 -07:00
Bartłomiej Dach	1fd4a6dc96	Fix tests crashing due to HUDOverlay not finding DrawableRuleset in Update()	2023-07-29 01:07:49 +02:00
Bartłomiej Dach	4db203ecc3	Merge branch 'master' into playfield-skin-layer	2023-07-29 00:01:06 +02:00
Bartłomiej Dach	c6f0cf50ca	Use better safety in rectangular grid ... - Checking `DrawSize != Vector2.Zero` is too specific. It could also crash on zero-height-but-non-zero-width, or zero-width-but-non-zero-height. - Take the `gridCache.Validate()` call out of the zero checks, because even if the width or height are zero, not generating anything is valid and there is no reason to validate every frame until `gridCache` gets invalidated again.	2023-07-28 22:57:02 +02:00
QuantumSno	a4065486c1	bound bind during gameplay	2023-07-28 14:39:41 -04:00
Dean Herbert	0e4db9b439	Add safety in RectangularPositionSnapGrid that size is greater than zero ... Would crash otherwise	2023-07-28 16:25:40 +09:00
Dean Herbert	6cf065f6d1	Add playfield layer to skin editor	2023-07-28 15:50:44 +09:00
Dean Herbert	f15394fb6d	Fix temporary auto mod (ctrl+enter at song select) not reverting in all scenarios	2023-07-28 14:49:06 +09:00
Joseph Madamba	9d87ff2986	Improve supporter-only duration notice and fix max duration of non-supporter ... See 3c54229256/.env.example (L230). Might have more duration options in the future.	2023-07-26 01:37:55 -07:00
Dean Herbert	4889864478	Fix files references not correctly being copied after replay import in Player	2023-07-26 15:22:00 +09:00
Dean Herbert	e26afc2b89	Fix ReplayDownloadButton handling key repeat	2023-07-26 15:21:43 +09:00
Joseph Madamba	30e0e00c52	Rename selectedAvailableDuration to hasValidDuration	2023-07-25 22:57:01 -07:00