1
0
mirror of https://github.com/ppy/osu.git synced 2025-02-13 11:12:54 +08:00
osu-lazer/osu.Game/Screens
Bartłomiej Dach de89b7e53c
Fix slider velocity changes not being undone correctly
Closes https://github.com/ppy/osu/issues/25239.

`LegacyEditorBeatmapPatcher.processHitObjectLocalData()` was already
supposed to be handling changes to hitobjects that will show up neither
when comparing the hitobjects themselves or the timing point with
"legacy" info stripped - so, in other words, changes to slider velocity
and samples.

However, a change to slider velocity requires default application to
take effect, so just resetting the value would visually fix the timeline
marker but not change the actual object. Calling
`EditorBeatmap.Update()` fixes this by way of triggering default
re-application.

This could probably be smarter (by only invoking the update when
strictly necessary, etc.) - but I'm not sure it's worth the hassle. This
is intended to be a quick fix, rather than a complete solution - the
complete solution would indeed likely entail a wholesale restructuring
of the editor's change handling.
2023-10-30 10:59:02 +01:00
..
Backgrounds Fix some new nullable inspections 2023-10-30 15:10:10 +09:00
Edit Fix slider velocity changes not being undone correctly 2023-10-30 10:59:02 +01:00
Import Merge branch 'master' into update-framework 2022-11-26 16:19:36 +01:00
Menu Also support D for those with muscle memory from stable 2023-10-20 12:22:00 +02:00
OnlinePlay Merge branch 'master' into score-encoding-cleanup 2023-10-26 09:04:05 +02:00
Play Merge pull request #25300 from peppy/better-submission-logging 2023-10-30 09:04:06 +01:00
Ranking Delete ScoreInfo.HasReplay as no longer needed 2023-10-27 12:39:54 +02:00
Select Fix left side of carousel blocking volume adjust hotkeys 2023-10-26 16:26:35 +02:00
Spectate Bring realm library up-to-date 2023-07-06 13:37:43 +09:00
Utility Use generic Enum methods 2022-12-26 20:36:39 +01:00
BackgroundScreen.cs Partial everything 2022-11-27 00:00:27 +09:00
BackgroundScreenStack.cs Manual fixes to reduce warnings to zero 2023-06-24 01:52:53 +09:00
IHandlePresentBeatmap.cs Automated pass 2023-06-24 01:00:03 +09:00
IHasSubScreenStack.cs Automated pass 2023-06-24 01:00:03 +09:00
IOsuScreen.cs Allow screens to change the ability to interact with the global track 2023-07-25 20:20:53 +09:00
IPerformFromScreenRunner.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
Loader.cs Revert masking SSBO changes 2023-09-13 23:10:13 +09:00
OsuScreen.cs Fix various other inspections 2023-10-17 17:48:51 +09:00
OsuScreenDependencies.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
OsuScreenStack.cs Manual fixes to reduce warnings to zero 2023-06-24 01:52:53 +09:00
ScorePresentType.cs Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
ScreenWhiteBox.cs Partial everything 2022-11-27 00:00:27 +09:00
StartupScreen.cs Automated pass 2023-06-24 01:00:03 +09:00