mirror of
https://github.com/ppy/osu.git
synced 2025-02-15 18:13:09 +08:00
de89b7e53c
Closes https://github.com/ppy/osu/issues/25239. `LegacyEditorBeatmapPatcher.processHitObjectLocalData()` was already supposed to be handling changes to hitobjects that will show up neither when comparing the hitobjects themselves or the timing point with "legacy" info stripped - so, in other words, changes to slider velocity and samples. However, a change to slider velocity requires default application to take effect, so just resetting the value would visually fix the timeline marker but not change the actual object. Calling `EditorBeatmap.Update()` fixes this by way of triggering default re-application. This could probably be smarter (by only invoking the update when strictly necessary, etc.) - but I'm not sure it's worth the hassle. This is intended to be a quick fix, rather than a complete solution - the complete solution would indeed likely entail a wholesale restructuring of the editor's change handling. |
||
|---|---|---|
| .. | ||
| Components | ||
| Compose | ||
| Design | ||
| GameplayTest | ||
| Setup | ||
| Timing | ||
| Verify | ||
| BackgroundDimMenuItem.cs | ||
| BeatmapEditorChangeHandler.cs | ||
| BindableBeatDivisor.cs | ||
| BottomBar.cs | ||
| ClipboardContent.cs | ||
| CreateNewDifficultyDialog.cs | ||
| DeleteDifficultyConfirmationDialog.cs | ||
| Editor.cs | ||
| EditorBeatmap.cs | ||
| EditorBeatmapSkin.cs | ||
| EditorChangeHandler.cs | ||
| EditorClipboard.cs | ||
| EditorClock.cs | ||
| EditorLoader.cs | ||
| EditorRoundedScreenSettings.cs | ||
| EditorRoundedScreenSettingsSection.cs | ||
| EditorScreen.cs | ||
| EditorScreenMode.cs | ||
| EditorScreenWithTimeline.cs | ||
| EditorSkinProvidingContainer.cs | ||
| EditorState.cs | ||
| EditorTable.cs | ||
| HitAnimationsMenuItem.cs | ||
| IEditorChangeHandler.cs | ||
| LegacyEditorBeatmapPatcher.cs | ||
| PromptForSaveDialog.cs | ||
| SaveRequiredPopupDialog.cs | ||
| TransactionalCommitComponent.cs | ||
| WaveformOpacityMenuItem.cs | ||