1
0
mirror of https://github.com/ppy/osu.git synced 2026-06-04 06:23:37 +08:00

Reduce delay before loading beatmap after selection change at song select

This was originally set high because of performance concerns. We have
since improved things quite drastically. Even with a very low debounce
my song select is amazingly smooth.

This is about as low as we can got unless we want chaos when key
repeating left/right arrows (it's not as bad as you think, maybe worth
testing during review and see if it feels more expected?).

Of note, stable has key repeat disabled on left/right arrows and zero
debounce.

Addresses concerns in https://github.com/ppy/osu/discussions/24916.
This commit is contained in:
Dean Herbert
2023-09-26 16:19:53 +09:00
Unverified
parent 81130eacd1
commit ae31a8fadf
+5 -1
View File
@@ -525,7 +525,11 @@ namespace osu.Game.Screens.Select
if (beatmapInfoNoDebounce == null)
run();
else
selectionChangedDebounce = Scheduler.AddDelayed(run, 200);
{
// Intentionally slightly higher than repeat_tick_rate to avoid loading songs when holding left / right arrows.
// See https://github.com/ppy/osu-framework/blob/master/osu.Framework/Input/InputManager.cs#L44
selectionChangedDebounce = Scheduler.AddDelayed(run, 80);
}
if (beatmap?.Equals(beatmapInfoPrevious) != true)
{