Fix editor's control point list refreshing multiple times for a single change

2026-06-04 05:43:42 +08:00 · 2023-12-26 20:31:34 +09:00
parent b1a26acdd0
commit f2c0e7cf2e
1 changed files with 7 additions and 2 deletions
@@ -109,8 +109,13 @@ namespace osu.Game.Screens.Edit.Timing
            controlPointGroups.BindTo(Beatmap.ControlPointInfo.Groups);
            controlPointGroups.BindCollectionChanged((_, _) =>
            {
-                table.ControlGroups = controlPointGroups;
-                changeHandler?.SaveState();
+                // This callback can happen many times in a change operation. It gets expensive.
+                // We really should be handling the `CollectionChanged` event properly.
+                Scheduler.AddOnce(() =>
+                {
+                    table.ControlGroups = controlPointGroups;
+                    changeHandler?.SaveState();
+                });
            }, true);

            table.OnRowSelected += drawable => scroll.ScrollIntoView(drawable);