10371 Commits

Author	SHA1	Message	Date
Alden Wu	c2d8ffc225	Refactor ChatLine username drawable creation	2022-11-28 17:50:12 -08:00
mk56-spn	db7f429e39	Fix partial class issues and adjust test slightly	2022-11-27 10:44:05 +01:00
mk56-spn	0aba119056	Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation ... # Conflicts: # osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs # osu.Game/Screens/Select/DifficultyRangeFilterControl.cs	2022-11-27 10:40:29 +01:00
Jai Sharma	8dcd1a2067	Add test to verify selected timing point will be scrolled into view	2022-11-27 02:48:15 +00:00
cdwcgt	54681217be	fix test	2022-11-27 10:53:00 +09:00
cdwcgt	e16f8a4410	Merge branch 'master' into NowPlaying	2022-11-27 08:48:49 +08:00
Bartłomiej Dach	212d78865a	Add a few more missing partial specs	2022-11-26 16:30:52 +01:00
Bartłomiej Dach	894ef15e79	Merge branch 'master' into update-framework	2022-11-26 16:19:36 +01:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
mk56-spn	1ebaf4963d	Improve tests slightly	2022-11-26 13:59:05 +01:00
mk56-spn	92ed2ed4ef	Refactor star "DifficultyRangeFilterControl" into generic range slider class	2022-11-26 12:19:08 +01:00
Bartłomiej Dach	ca0597b38e	Merge branch 'master' into dont-change-ruleset-convert	2022-11-25 19:23:36 +01:00
Bartłomiej Dach	73176a1315	Merge branch 'master' into triangle-button-v2	2022-11-25 18:35:59 +01:00
cdwcgt	13f86f3e53	Merge branch 'master' into NowPlaying	2022-11-25 23:22:52 +09:00
cdwcgt	a2ea7a3f58	show selected mod and use ILocalisedBindableString in np	2022-11-25 23:20:44 +09:00
Dean Herbert	2425878e67	Add test coverage	2022-11-25 20:06:36 +09:00
Bartłomiej Dach	fca3e7e39f	Merge branch 'master' into editor-seek-control-points	2022-11-24 21:53:47 +01:00
Dean Herbert	ba0990d43e	Update test assumptions	2022-11-25 01:51:41 +09:00
Dean Herbert	53b03df93d	Combine TriangleButton and RoundedButton classes	2022-11-24 16:26:57 +09:00
Dean Herbert	40f706155f	Update RoundedButton to have new triangles design	2022-11-24 16:18:15 +09:00
Dean Herbert	44a71741e4	Merge pull request #21225 from EVAST9919/triangles-v2 ... Implement TrianglesV2 component	2022-11-24 16:15:25 +09:00
Dean Herbert	8914a871c1	Merge pull request #21065 from C0D3-M4513R/beatmap-info ... Add Beatmap Information elements	2022-11-24 15:22:04 +09:00
Dean Herbert	37f725bfa2	Reverse directionality of up/down traversal keys to match scroll	2022-11-24 13:55:58 +09:00
Bartłomiej Dach	2f67199b1c	Merge branch 'master' into fix-missing-day-separator	2022-11-23 18:40:44 +01:00
Bartłomiej Dach	cf5f5a4de3	Extend tap timing control test coverage in no point selected case	2022-11-23 17:25:34 +01:00
Bartłomiej Dach	06449b62f1	Add test coverage for crash scenario	2022-11-23 16:11:57 +01:00
Andrei Zavatski	2204af04e4	Improve test scene to better show colour gradient	2022-11-23 16:12:13 +03:00
Dean Herbert	a6bba1967e	Update serialisation test to match new comopnent naming	2022-11-23 17:06:22 +09:00
Dean Herbert	a9192c32ea	Merge branch 'master' into beatmap-info	2022-11-23 16:10:12 +09:00
Dean Herbert	9b9b8a5977	Add ability to seek between control points in editor using down/up arrows ... Matches stable. Addresses #21376.	2022-11-23 15:59:32 +09:00
Dean Herbert	172e798847	Merge pull request #21228 from Terochi/recent-messages-implementation ... Add ability to view chat send history in input box	2022-11-23 14:58:42 +09:00
Bartłomiej Dach	39934bccd6	Add back removed test coverage	2022-11-22 19:47:41 +01:00
Bartłomiej Dach	76bb529cfa	Add test for local echo adding day separator	2022-11-22 16:46:21 +01:00
Dan Balasescu	6b75f529c7	Merge pull request #21366 from bdach/broken-rank-graph-test ... Fix broken rank graph test	2022-11-22 14:35:14 +09:00
Bartłomiej Dach	41039340cf	Fix rank graphs not showing in test due to unset IsRanked	2022-11-21 21:00:06 +01:00
Bartłomiej Dach	1777a60136	Add failing assertions	2022-11-21 20:58:52 +01:00
Bartłomiej Dach	735cac3104	Rewrite rank graph test to use more modern style	2022-11-21 20:56:38 +01:00
Bartłomiej Dach	f36ccab84e	Merge branch 'master' into tablet-settings-test-scene	2022-11-21 20:42:04 +01:00
Bartłomiej Dach	ff5cb116f0	Fix weird scroll container sizing	2022-11-21 19:27:06 +01:00
Bartłomiej Dach	7944d9cefa	Merge pull request #21304 from EVAST9919/beatmap-bar ... Rework BarGraph to use Quads	2022-11-21 16:24:18 +01:00
cdwcgt	e37d30a373	refactor based on reviews ... removed LegacyExportManager Separated the method of CreateZip method and the default export method	2022-11-21 18:58:01 +09:00
Terochi	d81ef541bc	Variant 5: cannot change history, edit resets index	2022-11-21 10:17:28 +01:00
Terochi	7dc7729ac2	Variant 4: cannot change history, empty text/everything selected resets index (current with bug fix)	2022-11-21 10:11:26 +01:00
C0D3 M4513R	93ab1c9432	Merge branch 'master' into beatmap-info	2022-11-21 09:01:24 +00:00
Terochi	58288275a6	Variant 3: cannot change history, cannot reset index (the "default")	2022-11-21 09:43:36 +01:00
cdwcgt	ed53168267	typo fix	2022-11-21 17:42:11 +09:00
Terochi	672e1cd45b	Variant 2: edit changes history, cannot reset index (similar to stable)	2022-11-21 09:41:29 +01:00
Terochi	8f942f130b	Variant 1: edit changes history, empty text resets index	2022-11-21 09:36:31 +01:00
Andrei Zavatski	14a4de36f4	Expose thickness property	2022-11-21 10:20:35 +03:00
Dean Herbert	9a330c3cdb	Apply nullability and clean up conditionals	2022-11-21 15:02:45 +09:00
Dean Herbert	a07b033d22	Merge branch 'master' into triangles-v2	2022-11-21 14:55:01 +09:00
Dean Herbert	dfa92b3de9	Merge pull request #21326 from bdach/fix-phantom-beatmap-sets ... Fix phantom beatmap sets appearing on carousel after delete/update	2022-11-21 13:25:14 +09:00
Dean Herbert	d0ff5be7e6	Fix TestSceneTabletSettings falling off the bottom of the screen	2022-11-21 12:15:43 +09:00
Bartłomiej Dach	1269afd0c5	Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu ... Hide scroll speed control from effects section on rulesets which don't support it	2022-11-20 16:17:55 +01:00
Salman Ahmed	793d5b117e	Fix timing screen test scene not creating editor beatmap properly	2022-11-20 15:20:35 +03:00
Bartłomiej Dach	b3667821eb	Add failing test case	2022-11-20 10:07:32 +01:00
Andrei Zavatski	6f449a583e	Handle empty values as a separate case	2022-11-19 23:27:48 +03:00
Terochi	eff6c7be64	Removed unnecessary methods, changed tests, and moved LimitedCapacityQueue.cs to a more generic namespace.	2022-11-19 16:53:35 +01:00
Bartłomiej Dach	c05c1625f2	Merge branch 'master' into editor-test-play-dont-retain-test-time	2022-11-19 12:09:04 +01:00
Dean Herbert	130f776427	Merge pull request #21267 from peppy/catch-file-enumeration-errors ... Catch and gracefully handle file/directory enumeration failures during stable import	2022-11-19 15:38:40 +09:00
Salman Ahmed	ca67689a36	Fix intermittent present beatmap test failures	2022-11-19 07:44:43 +03:00
Bartłomiej Dach	d587f29351	Update tests to reflect desired behaviour	2022-11-18 21:03:30 +01:00
cdwcgt	fc4a6cb125	working with test	2022-11-19 01:02:35 +09:00
Salman Ahmed	8943819ee7	Add test coverage	2022-11-18 17:49:03 +03:00
Dean Herbert	b86b45b6d2	Fix excess string interpolation	2022-11-18 21:13:21 +09:00
Dawid Sośnia	9ad484a0f4	Merge branch 'ppy:master' into gameplay-leaderboard-fix	2022-11-18 12:11:22 +01:00
cdwcgt	4b29941b47	add LegacyExportManager	2022-11-18 20:00:00 +09:00
Dan Balasescu	9d33a6568e	Merge pull request #21292 from peppy/fix-binding-two-keys-single-binding ... Fix being able to bind two non-modifier keys to the same binding	2022-11-18 16:19:38 +09:00
Dean Herbert	7c08cff297	Make new test more resilient to false passes	2022-11-18 16:10:32 +09:00
Dean Herbert	0a520c979e	Update test to split out per-type tests	2022-11-18 16:03:40 +09:00
Salman Ahmed	e2aca8dc90	Suppress nullable warning for now	2022-11-18 09:46:50 +03:00
Dean Herbert	3faa7f5f74	Merge branch 'master' into gameplay-leaderboard-fix	2022-11-18 15:44:30 +09:00
Dean Herbert	cb8275ee75	Add failing test coverage to TestSceneKeyBindingPanel for multiple non-modifiers being bound	2022-11-18 15:34:41 +09:00
Dean Herbert	45f5849301	Add more test coverage to TestSceneKeyBindingPanel	2022-11-18 15:33:14 +09:00
Dan Balasescu	57b8495c7a	Merge branch 'master' into long-standard	2022-11-18 14:24:04 +09:00
Salman Ahmed	82829867db	Fix beatmap options test failure due to no beatmap being selected	2022-11-18 07:07:56 +03:00
Dean Herbert	1ff1738988	Merge pull request #21244 from nanashi-1/beatmapoptions-disabled ... Disable certain beatmap option buttons when there are no beatmaps selected	2022-11-18 12:55:07 +09:00
Dawid Sośnia	0dbf491872	Merge branch 'master' into gameplay-leaderboard-fix	2022-11-17 22:06:51 +01:00
Piggey	53769479c7	oh oops	2022-11-17 21:42:15 +01:00
Piggey	eb8f6626ab	revert changes from GameplayLeaderboard tests	2022-11-17 21:38:09 +01:00
Piggey	5e4ade3bee	add tests	2022-11-17 13:28:04 +01:00
Dragon	a25c94d567	Replacing structure to use LimitedCapacityQueue.cs	2022-11-17 13:07:06 +01:00
Dragon	a9747d367c	Cleaning up	2022-11-17 13:07:06 +01:00
Terochi	19dc31c7ae	Changed tests.	2022-11-17 13:07:06 +01:00
Terochi	5253f5309e	Added more tests for new features	2022-11-17 13:07:06 +01:00
Terochi	3d4962e181	Added functioning tests.	2022-11-17 13:07:06 +01:00
Terochi	a79af6671e	Added SetUp for new tests.	2022-11-17 13:07:06 +01:00
Salman Ahmed	039ab83a46	Disable beatmap options button when none selected	2022-11-17 04:00:23 +03:00
Salman Ahmed	0e46614c57	Revert beatmap option button state changes	2022-11-17 03:57:01 +03:00
cdwcgt	e1a21e0cf9	create a task to export to avoid block main thread ... Code quality and remove some #nullable disable	2022-11-17 01:08:06 +09:00
Andrei Zavatski	13cf3fc40c	Make SpawnRatio public	2022-11-16 15:17:50 +03:00
Andrei Zavatski	bda32d71bf	Change test scene name	2022-11-16 14:53:55 +03:00
Andrei Zavatski	d94c624ee4	Merge branch 'master' into triangles-v2	2022-11-16 14:53:32 +03:00
nanashi-1	46c7451ede	remove redundant code	2022-11-16 09:57:23 +08:00
nanashi-1	9101ad0cbd	fixed naming	2022-11-16 09:42:40 +08:00
nanashi-1	7aec5ca1e8	visual tests	2022-11-15 20:57:42 +08:00
Andrei Zavatski	333165e052	Add test scene for Triangles	2022-11-15 10:54:37 +03:00
Dean Herbert	308ed1abd1	Fix number of judgements shown potentially exceeding upper limit	2022-11-15 12:31:25 +09:00
Andrei Zavatski	81c9ea98e2	Implement TrianglesV2 component	2022-11-13 15:31:48 +03:00
maromalo	1911120afe	Merge branch 'master' into long-standard	2022-11-12 09:52:11 -03:00
Dean Herbert	dde09d409b	Merge branch 'master' into chat-silences	2022-11-12 21:00:56 +09:00
Dean Herbert	8154eaafd8	Merge pull request #20991 from smoogipoo/websocket-chat-2 ... Receive chat messages via notification websocket	2022-11-12 18:18:39 +09:00
Bartłomiej Dach	b0314c67aa	Fix failing gameplay bindings test	2022-11-12 14:16:46 +09:00
Dean Herbert	19876ca0fb	Merge branch 'master' into websocket-chat-2	2022-11-11 23:53:42 +09:00
Dean Herbert	106f1cf90b	Merge branch 'master' into combo-colour-brightness-limit	2022-11-11 18:24:39 +09:00
Dan Balasescu	db25e9e9c8	Merge branch 'master' into combo-colour-brightness-limit	2022-11-11 15:31:28 +09:00
Dan Balasescu	6ac19615fa	Fix test failure	2022-11-11 14:55:41 +09:00
Bartłomiej Dach	63270c8619	Merge branch 'master' into improve-ui-control-sound-sync	2022-11-11 05:50:28 +01:00
Dean Herbert	3547c04002	Merge branch 'master' into skinnable-things-cleanup	2022-11-10 12:09:32 +09:00
Dan Balasescu	040d7ee247	Merge pull request #21183 from peppy/skinnable-nullability ... Apply nullability considerations to all skin related classes	2022-11-10 11:50:41 +09:00
Joseph Madamba	2b81f3048c	Merge branch 'master' into close-side-overlays-when-main-overlay	2022-11-09 12:48:57 -08:00
Salman Ahmed	3909e5730e	Rename test steps ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2022-11-09 21:33:28 +03:00
C0D3 M4513R	a57c824092	Merge branch 'master' into beatmap-info	2022-11-09 14:47:08 +00:00
Dean Herbert	e19ba65f91	Remove LookupName from base ISkinComponentLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	1aa0e40f2f	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
Dean Herbert	e75c3b3f94	Rename SkinnableTarget to GlobalSkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	c908969d9b	Rename ISkinComponent to ISkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	ab458320c4	Fix some lingering inspections	2022-11-09 17:46:24 +09:00
Dawid Sośnia	9549e55ef8	Merge branch 'ppy:master' into gameplay-leaderboard-fix	2022-11-08 20:04:13 +01:00
Piggey	9da57c66a2	add visual tests	2022-11-08 20:03:09 +01:00
Dean Herbert	b166e477c2	Merge branch 'master' into editor-background	2022-11-08 17:18:34 +09:00
Dean Herbert	4c15794694	Add test coverage of overlay interplay	2022-11-08 14:58:57 +09:00
maromalo	b7ef9b176d	Make score type consistent	2022-11-06 19:59:27 -03:00
C0D3 M4513R	0c17571c58	Merge branch 'master' into beatmap-info	2022-11-06 18:53:14 +00:00
Dean Herbert	ee68f33e3c	Merge pull request #21109 from frenzibyte/fix-beatmap-duplicating-again ... Fix beatmap cards still potentially showing twice in listing	2022-11-06 18:46:31 +09:00
Dean Herbert	e02c477008	Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks ... Remove nullable disable in the checks.	2022-11-06 18:39:03 +09:00
Bartłomiej Dach	84179fb087	Merge branch 'master' into combo-colour-brightness-limit	2022-11-05 16:48:56 +01:00
andy840119	e862ba5e04	Fix the wrong AsNonNull() usage.	2022-11-05 20:13:50 +08:00
andy840119	6062641bf4	Mark mock track as nun-nullable because technically it should not accept the null track.	2022-11-05 16:17:20 +08:00
andy840119	5931e965c5	Mark background prams in the getMockWorkingBeatmap() as nun-nullable because technically it should not accept the null background.	2022-11-05 16:16:26 +08:00
Dan Balasescu	fa18b5f701	Construct notifications client inside ChannelManager	2022-11-04 18:51:00 +09:00
Dean Herbert	eb836269e7	Allow testing settings panel with interactivity by default	2022-11-04 18:50:17 +09:00
Dean Herbert	923d44a769	Update dependencies	2022-11-04 17:00:58 +09:00
Dean Herbert	566738494f	Merge pull request #20952 from OliBomby/bezier-convert ... Add conversion algorithm for lazer slider curves to work with stable	2022-11-04 16:49:51 +09:00
Dean Herbert	dd5a3b2bf3	Add one more complex test	2022-11-04 16:49:21 +09:00
Joseph Madamba	e11d44d14f	Add url clicking support to profile badges	2022-11-03 18:12:32 -07:00
Salman Ahmed	37b5f48911	Adjust test scene to cover failure	2022-11-04 03:23:33 +03:00
Dean Herbert	1edde8f73c	Merge branch 'master' into disabled-button-sfx	2022-11-03 20:27:41 +09:00
Dean Herbert	cdb3494418	Merge pull request #20765 from Feodor0090/comment-report ... Implement comments reporting	2022-11-03 20:09:00 +09:00
Dean Herbert	486515ed90	Merge pull request #20758 from frenzibyte/maintain-common-mod-selection ... Maintain selection of common mods when switching rulesets	2022-11-03 20:08:32 +09:00
Jamie Taylor	f1c17129eb	Add support for 'disabled' sample variation to HoverClickSounds	2022-11-03 17:47:49 +09:00
C0D3 M4513R	2ec29c0f26	Merge branch 'master' into beatmap-info	2022-11-03 07:09:02 +00:00
Dean Herbert	c48c9ecb6d	Merge pull request #20743 from frenzibyte/improve-beatmap-card-buttons ... Improve clickable area of beatmap card icon buttons	2022-11-03 15:47:08 +09:00
Dean Herbert	e6c45b8ab5	Merge branch 'master' into comment-report	2022-11-03 15:35:42 +09:00
Dean Herbert	20dd405c2b	Merge branch 'master' into maintain-common-mod-selection	2022-11-03 15:32:40 +09:00
Dean Herbert	fb0bc597a0	Merge branch 'master' into improve-beatmap-card-buttons	2022-11-03 13:53:29 +09:00
Dean Herbert	5f2f6b84b2	Add failing test coverage of automated skip scenarios	2022-11-03 13:52:27 +09:00
Dean Herbert	aef3c7918c	Add total skip count to SkipOverlay	2022-11-03 13:52:24 +09:00
C0D3 M4513R	75b5025e12	Fix Skin Deserialisation Test	2022-11-02 16:37:48 +01:00
Dean Herbert	3ec9686e58	Fix test failures and rename configuration value to match better	2022-11-02 18:15:18 +09:00
Dean Herbert	0e502de8b4	Rename field to match usage	2022-11-02 18:04:42 +09:00
Dean Herbert	c3eb0c6330	Merge branch 'master' into editor-background	2022-11-02 17:43:38 +09:00
Dan Balasescu	063a8bdf9e	Remove messages from silenced users	2022-11-02 17:13:14 +09:00
Dan Balasescu	f688ed12d0	Add test for removing chat messages	2022-11-02 17:00:47 +09:00
Dan Balasescu	695104a666	Fix TestSceneChatOverlay messages not being unique	2022-11-02 16:59:03 +09:00
Dean Herbert	2b04e852be	Merge branch 'master' into websocket-chat-2	2022-11-02 14:56:13 +09:00
Dan Balasescu	5b25ef5f2f	Construct notifications client via IAPIProvider	2022-11-01 21:34:34 +09:00
Dean Herbert	29bc653d24	Remove incorrect double multiplication and add missing test coverage	2022-11-01 17:17:54 +09:00
Dean Herbert	d807d9d822	Add failing test covering snap calculations with SV applied	2022-11-01 16:22:48 +09:00
Dean Herbert	e8b7914295	Add test coverage of new parameter	2022-11-01 15:13:05 +09:00
Dean Herbert	2a88409dfe	Fix time snap of sliders not matching when SV is not 1.0x ... This regressed with https://github.com/ppy/osu/pull/20850 because the function was used in other places which expect it to factor slider velocity into the equation. Rather than reverting, I've added a new argument, as based on the method naming alone it was hard to discern whether SV should actually be considered. The reason for the change in #20850 was to avoid the SV coming in from a reference object which may not have a correct SV in the first place. In such cases, passing `false` to the function will give the expected behaviour.	2022-11-01 15:12:58 +09:00
Dean Herbert	17f482bfc3	Merge branch 'master' into websocket-chat-2	2022-10-31 16:11:58 +09:00
Dean Herbert	e38ba5e4c6	Apply nullability to new test scene	2022-10-31 15:46:57 +09:00
Dean Herbert	31ba77e378	Merge branch 'master' into bezier-convert	2022-10-31 15:41:08 +09:00
Dean Herbert	8399261c77	Add failing test showing hold for menu not working when HUD is hidden	2022-10-30 21:38:31 +09:00
Dean Herbert	f5e11343c2	Apply nullability to HUD test scene	2022-10-30 21:25:31 +09:00
andy840119	c8c76f2351	Use AsNonNull() because the type does not accept the null case.	2022-10-30 17:03:54 +08:00
andy840119	500bf90a34	Mark as accept the nullable stream.	2022-10-30 17:03:54 +08:00
andy840119	6ce3841686	Remove nullable disable annotation in the test case.	2022-10-30 17:03:54 +08:00
Bartłomiej Dach	71d87489ab	Merge branch 'master' into safe-area-toggle	2022-10-29 13:19:44 +02:00
Dean Herbert	19e0b9085c	Remove redundant parameters	2022-10-29 00:24:33 +09:00
Dan Balasescu	169bcc2654	Use polling connector in tests	2022-10-28 18:08:08 +09:00
Dean Herbert	f9d2c30c3e	Add user toggle for application of safe areas	2022-10-28 14:05:45 +09:00
Bartłomiej Dach	f787da892b	Merge branch 'master' into grid-momentary-shortcuts	2022-10-26 21:30:24 +02:00
OliBomby	86d5fcc26d	Added tests	2022-10-26 19:30:42 +02:00
cdwcgt	6991195d69	let editor dim different from gameplay dim	2022-10-26 15:22:57 +09:00
Dean Herbert	7249542167	Merge pull request #20912 from LittleEndu/carousel-do-not-select-random ... Make beatmap carousel select nearest to selection when selection was filtered	2022-10-26 11:40:56 +09:00
Bartłomiej Dach	48057412f5	Merge branch 'master' into grid-momentary-shortcuts	2022-10-25 22:17:08 +02:00
Bartłomiej Dach	bcdf24b972	Merge branch 'master' into add-editor-object-clone	2022-10-25 21:33:52 +02:00
Bartłomiej Dach	3d31c9bbc5	Merge branch 'master' into beat-snap-divisor-hotkey	2022-10-25 20:32:32 +02:00
Dean Herbert	2b850694fa	Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts	2022-10-25 14:10:45 +09:00
Dean Herbert	8e4f5381e3	Add top level test coverage of editor shortcuts	2022-10-25 12:03:46 +09:00
Dean Herbert	1b42f5ec6e	Add test coverage of BeatDivisorControl key bindings	2022-10-25 11:51:31 +09:00
Dean Herbert	4d4f6e25ba	Rename to "clone" instead of "duplicate"	2022-10-25 11:43:23 +09:00
Dean Herbert	da74690ec9	Add test coverage of clone operations	2022-10-25 11:38:58 +09:00
Dan Balasescu	f6f30eec0b	Merge pull request #20810 from peppy/scoring-test-scene ... Add test scene as environment to test changes to score algorithms	2022-10-25 11:19:00 +09:00
Endrik Tombak	b95091fbb0	Move test to improve diff readability	2022-10-24 22:55:09 +03:00
Endrik Tombak	9def12c60b	Write new tests	2022-10-24 22:50:56 +03:00
Dean Herbert	f08270f6b0	Fix incorrect maxBaseScore accounting due to silly oversight	2022-10-24 15:54:09 +09:00
Dean Herbert	247cf589aa	Merge branch 'master' into directoryselector-hidden-toggle	2022-10-24 15:33:10 +09:00
Salman Ahmed	90a9961a69	Add visual test case for report button ... Makes it much easier to test button/popover design changes	2022-10-22 02:50:59 +03:00
ansel	15aeb4a137	Display text in buttons flow instead of toast	2022-10-21 17:25:41 +03:00
Dean Herbert	bace3df4ca	Update test assertions in line with change	2022-10-21 22:58:10 +09:00
Dan Balasescu	703a8afb11	Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks ... Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself	2022-10-21 12:56:14 +09:00
ansel	81bdf716ef	Change test	2022-10-20 19:56:00 +03:00
Dean Herbert	6b26547d03	Merge pull request #20835 from frenzibyte/improve-hide-mouse-on-keyboard ... Improve automatic cursor hiding logic and limit to gameplay screen	2022-10-20 11:44:20 +09:00
Salman Ahmed	212f15e2d2	Update existing test cases	2022-10-20 04:06:33 +03:00
Dean Herbert	2f8a4fd2d0	Merge branch 'master' into remove-current-item	2022-10-20 10:02:09 +09:00
Dean Herbert	bea136ce50	Adjust test assert ordering to read better	2022-10-19 23:59:40 +09:00
Dean Herbert	579d5b51eb	Add and consume sample bank constants	2022-10-19 20:47:58 +09:00
Dean Herbert	f23bc484dc	Use better method of positioning mouse over visual settings area	2022-10-18 19:15:11 +09:00
Dean Herbert	d5666ca717	Add tooltip display of current values	2022-10-18 19:04:02 +09:00
Dean Herbert	d92aca7c22	Fix scoreV2 being higher than intended	2022-10-18 18:30:18 +09:00
Dean Herbert	74e1b5794b	Add ability to add "OK" or 100s via right click	2022-10-18 18:27:05 +09:00
Dean Herbert	a7b3aa62fb	Move lines to background to better visualise graphs at points of change	2022-10-18 18:13:13 +09:00
Dean Herbert	74986e0c8c	Show final scores and change colouring again	2022-10-18 18:07:42 +09:00
Dean Herbert	4b2fe72a90	Add stable v2 algorithm	2022-10-18 18:02:42 +09:00
Dean Herbert	743ae10df5	Improve colouring	2022-10-18 17:50:59 +09:00
Dean Herbert	7360cca047	Add stable v1 algorithm	2022-10-18 17:50:58 +09:00
Dean Herbert	d694c8b771	Move test scene more correctly into visual folder	2022-10-18 17:10:53 +09:00
Dean Herbert	c77847b284	Improve layout and add combo text	2022-10-18 16:55:22 +09:00
Dean Herbert	19b4d2d25e	Add vertical grid lines	2022-10-18 16:55:22 +09:00
Dean Herbert	1ea2a1ff04	Add basic legend and line colouring	2022-10-18 16:55:22 +09:00
Dean Herbert	94c57a459d	Add ability to add miss locations by clicking	2022-10-18 16:55:22 +09:00
Dean Herbert	49d5931022	Initial setup with adjustable max combo	2022-10-18 16:55:19 +09:00
Dean Herbert	ec3761ced9	Standardise control point search logic in OverlappingScrollAlgorithm ... Was using a very local algorithm which I cannot guarantee is correct. I'd rather it just use the one used everywhere else.	2022-10-18 16:01:05 +09:00
ansel	3258a41ca3	Merge branch 'comment-report' of https://github.com/Feodor0090/osu into comment-report	2022-10-17 20:41:46 +03:00
ansel	18cc3b0bd3	Fix reason not set in test	2022-10-17 20:23:25 +03:00
Feodor0090	6efe7b5334	Merge branch 'master' into comment-report	2022-10-17 16:08:13 +03:00
ansel	3bcc91511f	Update test	2022-10-17 13:46:13 +03:00
Dan Balasescu	28277dd880	Fix tests	2022-10-17 19:34:05 +09:00
ansel	e1785f73a2	Make report's comment not optional	2022-10-16 20:14:05 +03:00
Salman Ahmed	841e20c336	Remove unused usings	2022-10-15 17:16:08 +03:00
Salman Ahmed	7d53d35bf6	Remove duplicate & outdated test case	2022-10-15 16:23:54 +03:00
Salman Ahmed	421b81b6ca	Fix broken test case	2022-10-15 00:41:14 +03:00
Salman Ahmed	45f590ca43	Add test case for hiding cursor on idle	2022-10-15 00:20:22 +03:00
Salman Ahmed	97c4282e55	Add test cases for hiding cursor on keyboard input	2022-10-15 00:20:22 +03:00
Salman Ahmed	ba72f13f54	Merge branch 'master' into hide-mouse-on-keyboard-input	2022-10-14 22:26:30 +03:00
Feodor0090	fb046e31c1	Merge branch 'master' into comment-report	2022-10-14 16:57:23 +03:00
ansel	dc0aa2295a	Add test	2022-10-14 16:51:48 +03:00
ansel	c65a8a83f3	Add basic UI for reporting	2022-10-14 15:52:09 +03:00
Dan Balasescu	10aabfc650	Merge pull request #20739 from peppy/settings-toolbox ... Adjust visuals of settings toolboxes (gameplay loading screen and editor)	2022-10-14 20:31:05 +09:00
Salman Ahmed	3e5e717fce	Add failing test cases	2022-10-14 02:00:11 +03:00
Bartłomiej Dach	df66a0c2e9	Fix flaky update beatmap set test ... It is generally not possible to click a button that's not yet there, and it turns out that when the test in question is ran headless, it may not necessarily be there immediately.	2022-10-13 21:03:52 +02:00
Salman Ahmed	6c316bcc9e	Make beatmap card icon buttons fill up to the area	2022-10-13 16:09:54 +03:00
Dean Herbert	6608ada925	Fix test failures due to missing colour provider dependency	2022-10-13 17:05:11 +09:00
Dean Herbert	0f4a2a6059	Improve feel of settings toolbox group	2022-10-13 16:36:19 +09:00
Dean Herbert	ebc1088457	Merge pull request #20729 from frenzibyte/update-local-confirmation-dialog ... Request user confirmation on updating locally-modified beatmaps	2022-10-13 12:36:37 +09:00
Dean Herbert	c9b4cacc20	Merge pull request #20724 from mk56-spn/Highest_Combo_Counter ... Add "longest combo" counter to HUD components.	2022-10-13 12:26:49 +09:00
Dean Herbert	f573ee4521	Merge pull request #20512 from Feodor0090/comment-deletion ... Add ability to delete own comments	2022-10-13 12:13:08 +09:00
Salman Ahmed	7db7bcc283	Add test coverage	2022-10-13 02:40:20 +03:00
Feodor0090	565de23222	Fix CQ (non-readonly field)	2022-10-12 21:26:33 +03:00
Dean Herbert	f1f323ee82	Add new deserialisation test including longest combo counter	2022-10-12 18:55:50 +09:00
Dean Herbert	19f3810020	Revert namespace change ... Let's not	2022-10-12 18:50:47 +09:00
Dean Herbert	3da54814f8	Merge pull request #20641 from pfgithub/patch-fix-save-collections ... Preserve collections when saving a beatmap	2022-10-12 18:36:45 +09:00
D.Headley	e2c80f09da	Remove unnecesary directive	2022-10-12 11:05:22 +02:00
Dario Headley	b72c8970eb	Max Combo Counter added	2022-10-12 09:50:01 +02:00
Dean Herbert	00d8398056	Update test scene to allow seeing loading spinner	2022-10-12 15:48:42 +09:00
Dean Herbert	47fe4eb0bd	Merge branch 'master' into comment-deletion	2022-10-12 15:48:26 +09:00
Salman Ahmed	9b45a9cf76	Rename various cursor symbols ... - `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor` - `MenuCursor` -> `MenuCursorContainer	2022-10-11 16:21:01 +03:00
Dan Balasescu	88e82d3154	Merge pull request #20681 from peppy/fix-hidden-hud-interaction ... Fix HUD components being interactive even when the HUD is visually hidden	2022-10-11 17:19:27 +09:00
Dean Herbert	ece42de408	Fix variable naming in test	2022-10-11 15:53:48 +09:00
Dan Balasescu	ccab04d141	Merge pull request #20645 from frenzibyte/flag-markdown ... Add support for inline country flags in wiki overlay	2022-10-11 14:01:24 +09:00
Dean Herbert	cb21126623	Merge pull request #20586 from ekrctb/time-based-selection ... Use hit object time for timeline drag selection instead of relying on blueprint	2022-10-11 13:20:15 +09:00
Dean Herbert	d700040a0d	Make country code parsing resilient to invalid cases	2022-10-11 01:39:53 +09:00
Dean Herbert	f6a8cc3f32	Add test showing broken input in HUD overlay when hidden	2022-10-10 16:05:41 +09:00
Dean Herbert	7726dda975	Remove whitespace	2022-10-10 15:31:45 +09:00
pfg	f219c0886d	Add a test for realm preservation	2022-10-09 10:19:21 -04:00
Salman Ahmed	0309751d55	Add test coverage	2022-10-08 21:50:31 +03:00
Salman Ahmed	13083813bd	Update hardcoded article page	2022-10-08 21:50:25 +03:00
ansel	e7b1f369a3	Revert unwanted changes in other tests	2022-10-08 18:55:58 +03:00
ansel	c384093802	Update main test and add failure scenario test	2022-10-08 18:53:41 +03:00
ansel	6e82ffbc6f	Add check for spinner	2022-10-08 17:41:51 +03:00
ansel	c11258a7e9	Tidy up test reloading	2022-10-08 17:20:25 +03:00
ansel	abf56c27a1	Do not requere dialog overlay	2022-10-08 17:11:09 +03:00
Dean Herbert	072b64b8d4	Update all dependencies	2022-10-07 21:16:11 +09:00
Dean Herbert	4980e53c9c	Merge pull request #20376 from goodtrailer/smoke ... Add cursor "smoke" trails	2022-10-07 03:41:07 +09:00
ekrctb	0ade049252	Add test for selected hit object blueprint	2022-10-06 14:02:49 +09:00
ekrctb	2a7476cc4a	Add test for timeline drag selection	2022-10-05 23:29:45 +09:00
Dan Balasescu	c52ddb0e50	Merge pull request #20570 from ekrctb/scrolling-lifetime ... Compute lifetime start from entry for scrolling hit objects	2022-10-05 20:45:43 +09:00
Dean Herbert	365a78d358	Merge branch 'master' into smoke	2022-10-05 18:58:18 +09:00
Dean Herbert	4f084664ac	Merge branch 'master' into comment-deletion	2022-10-05 14:34:50 +09:00
Dean Herbert	c7d645b086	Merge branch 'master' into fix-gameplay-leaderboard-overlap	2022-10-05 14:15:50 +09:00
Dan Balasescu	d9c3f5834c	Merge pull request #20567 from peppy/fix-show-replay-crash ... Fix potential crash when attempting to display an imported score at song select	2022-10-04 19:46:15 +09:00
ekrctb	15d159a97e	Fix tests	2022-10-04 16:10:18 +09:00
ekrctb	781f5420b0	Add test for scrolling hit object lifetime	2022-10-04 15:17:11 +09:00
Dan Balasescu	21620bee1a	Attempt to fix deadlock in test	2022-10-04 15:02:53 +09:00
Dean Herbert	0bac5ef465	Merge branch 'master' into smoke	2022-10-03 21:29:42 +09:00
Dean Herbert	7fbbe88c8e	Add test coverage of song select score presentation failures	2022-10-03 20:29:44 +09:00
Dean Herbert	42aac16b37	Adjust leaderboard score panels sizing based on accuracy/combo width	2022-10-03 18:12:36 +09:00
Dean Herbert	4dbac917fc	Merge pull request #20547 from nanashi-1/solo-gameplay-leaderboard-max-combo ... Display highest combo rather than current combo for local play on leaderboard	2022-10-03 16:57:05 +09:00
Dean Herbert	492f26c832	Update test step in line with new combo source	2022-10-03 16:56:32 +09:00
Salman Ahmed	b6701dd578	Add failing test case	2022-10-02 15:29:53 +03:00
ansel	85adfc2df7	Fix DI type	2022-09-28 18:26:36 +03:00
ansel	7645fe20f5	Merge branch 'master' into comment-deletion	2022-09-28 17:55:22 +03:00
ansel	965e7bf265	Check local deletion in test	2022-09-28 17:52:12 +03:00
Dan Balasescu	f318452510	Merge pull request #20503 from peppy/change-default-skin ... Change default skin for new installations to "Argon"	2022-09-28 18:34:40 +09:00
Dean Herbert	baa9e0441f	Merge pull request #20428 from frenzibyte/fix-update-progress-notification ... Fix update progress notification not closing on completion	2022-09-28 17:43:45 +09:00
Dean Herbert	8edb1cb98a	Add test coverage of current score staying on screen	2022-09-28 15:57:50 +09:00
ansel	4013c96ca5	Fix test failures	2022-09-27 22:40:53 +03:00
ansel	5282c8b8c6	Fix CQ	2022-09-27 19:40:18 +03:00
ansel	2f551be1be	Implement tests	2022-09-27 19:03:02 +03:00
ansel	710f9e8f58	Setup a test scene	2022-09-27 18:11:27 +03:00
Dean Herbert	ed0752a5f1	Update test assumptions	2022-09-27 21:55:54 +09:00
Dean Herbert	87a1e05641	Remove unused using statement	2022-09-27 15:06:05 +09:00
Dean Herbert	4260ace1a6	Fix test coverage	2022-09-27 15:01:21 +09:00
nanashi-1	214a1c2d7f	code factor	2022-09-26 21:26:13 +08:00
nanashi-1	1fab1db145	move test	2022-09-26 21:11:48 +08:00
nanashi-1	4295d9c169	revert	2022-09-26 21:11:14 +08:00
nanashi-1	5c132aadeb	add visual test	2022-09-26 20:15:17 +08:00
Dan Balasescu	836da6a5e6	Merge pull request #20485 from peppy/leaderboard-nrt ... Apply NRT to leaderboard hierarchy	2022-09-26 18:53:37 +09:00
Dean Herbert	0f18bef3f3	Fix incorrect test assumptions	2022-09-26 17:59:39 +09:00
Dan Balasescu	c969afcb71	Merge branch 'master' into leaderboard-nrt	2022-09-26 17:12:19 +09:00
Dean Herbert	a1297af441	Apply NRT to base Leaderboard classes	2022-09-26 16:12:47 +09:00
Dean Herbert	82d4689716	Add failing test showing progress notifications can be flung and cancelled	2022-09-26 14:33:12 +09:00
o-dasher	ced7212660	Fixes syntax error	2022-09-25 16:33:39 -04:00
o-dasher	a9318e5c04	Fixes small oversight ... was applying a value when it wasn't supposed to be applied.	2022-09-25 16:32:16 -04:00
o-dasher	feadac1f79	Cleanup all other leftover binding instantiation	2022-09-25 16:02:40 -04:00
Salman Ahmed	4bd92b89bc	Change test scene to ensure progress notification is closed on completion	2022-09-23 16:29:19 +03:00
Dan Balasescu	1d1012e196	Merge pull request #20286 from peppy/gameplay-leaderboards ... Add basic gameplay leaderboard display	2022-09-22 21:16:12 +09:00
Dan Balasescu	445e026a32	Merge pull request #20389 from peppy/fix-gameplay-leaderboard-layout ... Fix gameplay leaderboard sometimes not showing up	2022-09-22 20:51:54 +09:00
Dean Herbert	1ed4b9c11c	Add more flexibility to test	2022-09-22 15:45:30 +09:00
Dean Herbert	ae70b2c32f	Fix other weirdness in variable and description naming	2022-09-22 15:21:27 +09:00
Dean Herbert	19db7c5977	Remove "Opacity" setting ... This should be implemented at a higher level	2022-09-22 15:19:01 +09:00
Dean Herbert	f3898da37a	Rename judgement count to not mention "shape"	2022-09-22 15:18:20 +09:00
Dean Herbert	e48fe3a9e2	Add nullability to test scene	2022-09-22 15:17:37 +09:00
Dean Herbert	7d93fa9f65	Merge branch 'master' into Colour_hit_meter_improved	2022-09-22 15:11:58 +09:00
Dan Balasescu	70bab81282	Merge pull request #20377 from peppy/argon-skin ... Add new default "argon" skin	2022-09-22 14:50:43 +09:00
Dean Herbert	1ef09f2ae1	Fix regression in TestSceneSongProgress	2022-09-21 23:26:25 +09:00
Dean Herbert	992441b9de	Disable alpha component parsing in beatmap / skin colour sections	2022-09-21 16:11:41 +09:00
Dean Herbert	0996051271	Order test scores more correctly	2022-09-21 15:03:06 +09:00
Dean Herbert	29c4d06d36	Merge branch 'fix-gameplay-leaderboard-layout' into gameplay-leaderboards	2022-09-21 14:58:58 +09:00
Dean Herbert	5cc2721e9a	Add failing test showing layout failure in gameplay leaderboard	2022-09-21 14:42:02 +09:00
Dean Herbert	4492a26b59	Merge branch 'master' into argon-skin	2022-09-21 13:00:16 +09:00
Dan Balasescu	8bf196d561	Merge pull request #20354 from peppy/default-skin-refactor ... Rename default skin to make way for new version	2022-09-21 11:48:38 +09:00
Salman Ahmed	29fa868fde	Fix test scene not resetting mouse position ... Also fixes until step flipped.	2022-09-21 03:05:44 +03:00
Salman Ahmed	8b918d29fc	Add failing test case	2022-09-21 00:15:50 +03:00
Dean Herbert	ff56821152	Change SkinnableHUDComponentTestScene to show new HUD twice ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-09-21 00:24:29 +09:00
Dean Herbert	8837618ab1	Merge pull request #20342 from smoogipoo/server-shutdown-countdown ... Implement server shutdown countdown + notification	2022-09-20 20:51:16 +09:00
Dean Herbert	fc6ab9c6a9	Add test coverage of shutdown notifications	2022-09-20 17:42:39 +09:00
Dan Balasescu	2499493347	Merge pull request #20375 from peppy/fix-score-reference-leak ... Fix mods potentially keeping reference to runtime gameplay elements	2022-09-20 16:26:31 +09:00
Dean Herbert	b5771ece41	Reduce the amount by which clicking the mute notification incraeses volume	2022-09-20 13:00:08 +09:00
Alden Wu	c3b8e1d718	Fix test and spawn smoke immediately	2022-09-19 10:16:05 -07:00
Dean Herbert	70d60a7e73	Update import skin test in line with new default	2022-09-19 23:16:46 +09:00
Dean Herbert	41e7d271d7	Remove redundant string interpolation	2022-09-19 21:51:54 +09:00
Dean Herbert	2b1c5b2c4a	Fix test failure due to triangle skin no longer being null intests	2022-09-19 12:34:50 +09:00
Dean Herbert	454125123d	Add failing test coverage showing mod reference leak path	2022-09-19 12:18:35 +09:00
Salman Ahmed	a413c7a3e6	Merge branch 'master' into fix-notification-count	2022-09-19 02:08:20 +03:00
Dean Herbert	d0b8409de5	Apply more renames	2022-09-18 18:19:00 +09:00
Drison64	c075d3de08	Create a test and a check if initial zoom value of ZoomableScrollContainer is in range	2022-09-17 22:43:40 +02:00
Dean Herbert	41e69fbca6	Remove "default" prefix from naming	2022-09-18 00:15:26 +09:00
Dean Herbert	51841988bf	Rename references to DefaultSkin to have Triangles suffix	2022-09-17 23:57:25 +09:00
Dean Herbert	4c4fdfd153	Provide scores directly to Player instance rather than relying on DI	2022-09-16 18:15:17 +09:00
Dean Herbert	0ff4e343f8	Add failing test showing incorrect unread notification count	2022-09-16 16:29:54 +09:00
Dean Herbert	0227eddda1	Merge branch 'master' into gameplay-leaderboards	2022-09-16 15:44:58 +09:00
Dan Balasescu	fcba917419	Merge pull request #20320 from peppy/skin-transformers ... Allow skin transformers to be created for all skins	2022-09-16 12:58:46 +09:00
Dan Balasescu	f86bbaae30	Merge branch 'master' into mods-effect-displays	2022-09-15 21:17:58 +09:00
Dean Herbert	c7f8f948b9	Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins	2022-09-15 20:18:10 +09:00
Dan Balasescu	96a89f4fca	Merge pull request #20319 from peppy/remove-ef-migration ... Remove all entity framework code and migrations	2022-09-15 19:15:23 +09:00
Dean Herbert	ea513c539b	Merge pull request #20303 from peppy/hitobject-entry-nesting-stoled ... Fix editor performance drop over time due to lingering nested object references	2022-09-15 17:15:01 +09:00
Dean Herbert	65d1c40dd5	Remove remaining package references and replace with SQLitePCLRaw direct reference ... This may require further consideration for test and iOS projects.	2022-09-15 16:58:58 +09:00
Dean Herbert	40a60f7145	Remove all entity framework code and migrations	2022-09-15 16:58:58 +09:00
Dan Balasescu	0329601e84	Fix inspection	2022-09-15 16:09:27 +09:00
Salman Ahmed	9824d09d49	Add test coverage	2022-09-15 04:30:09 +03:00
Dean Herbert	b4e6a20846	Fix song select status prefix matching no longer working ... Regressed in #19275 due to weird logic. Closes #20289.	2022-09-14 12:59:05 +09:00
Dan Balasescu	ef6d60ffe9	Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards ... Fix beatmap listing potentially showing duplicate beatmap cards	2022-09-14 10:25:24 +09:00
Dan Balasescu	4a49433e2e	Merge branch 'master' into notification-fling-right	2022-09-13 20:01:56 +09:00
Dean Herbert	566a61e770	Merge pull request #20244 from peppy/notification-fling ... Add ability to "fling" notifications to dismiss them	2022-09-13 19:50:34 +09:00
Dean Herbert	6d167070f8	Add back DI leaderboard retrieval via bindable pathway	2022-09-13 18:45:11 +09:00
Dean Herbert	d2b80645ab	Change Leaderboard to use IUser instead of APIUser	2022-09-13 18:00:21 +09:00
Salman Ahmed	fed9a47866	Add test coverage	2022-09-13 18:00:21 +09:00
Dean Herbert	27a81dfb9f	Merge pull request #20270 from OliBomby/fix-selectionblueprint-order ... Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes	2022-09-13 17:18:58 +09:00
Dan Balasescu	53ac9dbc38	Merge branch 'master' into notification-fling	2022-09-13 17:07:16 +09:00
Dean Herbert	608c893b23	Add basic test guarantees	2022-09-13 15:03:13 +09:00
Salman Ahmed	a6f68e4a90	Fix NRT inspections	2022-09-13 03:08:13 +03:00
OliBomby	a1f4724685	moved the location of the tests	2022-09-13 01:38:29 +02:00
Salman Ahmed	a5b962d9a3	Add failing test case	2022-09-13 01:37:23 +03:00
Dean Herbert	88107108ee	Add ability to flick notifications to the right to store for later	2022-09-12 20:20:57 +09:00
Dean Herbert	802c5629c0	Merge branch 'master' into notification-fling	2022-09-12 20:09:21 +09:00
Dean Herbert	cb6d02ec3a	Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset ... Remove the nullable disable annotation in the ruleset class	2022-09-12 19:07:23 +09:00
Dean Herbert	f56f6545c0	Add test coverage of flinging	2022-09-12 19:06:09 +09:00
Dean Herbert	c064853751	Merge branch 'master' into notification-fling	2022-09-12 18:56:15 +09:00
Dan Balasescu	4b37330316	Merge pull request #20248 from acid-chicken/fix/stats/td ... Fix new hit distribution graph didn't account for size changes	2022-09-12 18:11:18 +09:00
Dean Herbert	d561fcb126	Don't trigger fling animation when Close is triggered by non-user action	2022-09-12 16:54:25 +09:00
Dan Balasescu	bcbc867694	Merge branch 'master' into mods-effect-displays	2022-09-12 16:35:28 +09:00
Dean Herbert	931049aec1	Merge branch 'master' into notification-dismiss	2022-09-12 16:27:41 +09:00
Dan Balasescu	31225066a1	Merge pull request #19308 from frenzibyte/top-rank-badge-order ... Fix best rank badge not handling legacy scores properly	2022-09-12 16:20:21 +09:00
Dean Herbert	8e6b2796eb	Merge branch 'master' into notification-fling	2022-09-12 16:19:36 +09:00
Dan Balasescu	6c59be7be9	Merge pull request #20254 from peppy/fix-update-notification ... Fix update progress notification icon overload	2022-09-12 16:01:19 +09:00
Dean Herbert	7a62544923	Merge pull request #19275 from solstice23/search-filter ... Add multiple-units support in search length criteria	2022-09-12 15:43:44 +09:00
Dean Herbert	92beb6cbe7	Hide notification read light when in a toast state ... Also adds test coverage of read state and light.	2022-09-12 15:17:45 +09:00
Dean Herbert	9b31aa6d7a	Fix activation not firing with refactors	2022-09-12 15:04:30 +09:00
Dean Herbert	2b79e6b2de	Add test coverage of update notification	2022-09-12 14:52:16 +09:00
Dean Herbert	cf25ee8e84	Add test coverage of storyboard animation start time	2022-09-12 14:17:15 +09:00
Acid Chicken (硫酸鶏)	bb3d5bc9f4	test(osu.Game): add slider steps to change the size in timing distribution graph tests	2022-09-12 04:43:15 +09:00
ansel	064fe832c7	Fix test	2022-09-10 23:18:59 +03:00
MK56	8661dc3c93	Merge branch 'ppy:master' into Colour_hit_meter_improved	2022-09-10 21:16:23 +02:00
Mk-56spn	46d9262a60	test naming oversight	2022-09-10 20:38:34 +02:00
Mk-56spn	f6aef73f9e	fixed shape bindable not working, test creation, removal of Clear(), adjusted settings names	2022-09-10 20:30:43 +02:00
Dean Herbert	a9094c6b03	Add test coverage of clicking close button to dismiss	2022-09-10 15:18:32 +09:00
Dean Herbert	efe3b1aa7b	Allow dismissing notifications without performing action using middle / right click	2022-09-10 15:10:37 +09:00
andy840119	e62999fb16	Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset ... # Conflicts: # osu.Game.Rulesets.Catch/CatchRuleset.cs # osu.Game.Rulesets.Osu/OsuRuleset.cs # osu.Game.Rulesets.Taiko/TaikoRuleset.cs # osu.Game/Rulesets/Ruleset.cs	2022-09-10 10:40:12 +08:00
Salman Ahmed	ae53e27e6c	Adjust test coverage to read better	2022-09-09 19:39:06 +03:00
Salman Ahmed	dd10a06e3d	Merge branch 'master' into top-rank-badge-order	2022-09-09 19:38:44 +03:00
solstice23	823078ed2d	Merge branch 'master' into search-filter	2022-09-09 23:12:37 +08:00
Dean Herbert	d961b96897	Merge branch 'master' into search-filter	2022-09-09 23:25:54 +09:00
Dean Herbert	8f9df9c7b4	Merge pull request #18642 from Joehuu/fix-play-button-touch ... Fix beatmap card play button not working with touch inputs when not hovered	2022-09-09 19:41:05 +09:00
Dean Herbert	7d100c5eec	Fix test in line with new expectations	2022-09-09 18:10:10 +09:00
Dean Herbert	e9ce968ae3	Merge branch 'master' into fix-play-button-touch	2022-09-09 18:08:18 +09:00
Dean Herbert	9ec399a25a	Remove NRT overrides in new tests	2022-09-09 17:49:31 +09:00
Dean Herbert	68d1b7d7cf	Reduce test count	2022-09-09 17:48:51 +09:00
Dean Herbert	27f745b980	Merge branch 'master' into fix_progress_bar_info	2022-09-09 17:34:13 +09:00
Mk-56spn	5852a09003	small fix	2022-09-09 08:21:33 +02:00
Dean Herbert	c6c59f050c	Merge pull request #20195 from cdwcgt/SkinEditorShortcut ... Add arrow shortcuts to skin editor	2022-09-09 14:17:08 +09:00
Dan Balasescu	ba2ef424d4	Turn score ids into ulongs	2022-09-09 11:46:06 +09:00
Dan Balasescu	28477f3b97	Fix inspection	2022-09-09 08:55:35 +09:00
Mk-56spn	38ccd06d5e	Test fix	2022-09-08 20:42:55 +02:00
Dean Herbert	f1fa442287	Merge pull request #19599 from ItsShamed/kps ... Add clicks/second counter to HUD	2022-09-09 01:50:12 +09:00
cdwcgt	2e775e6886	Add test for object move	2022-09-08 23:47:55 +08:00
Dean Herbert	27aa3552dc	Update in line with TrueGameplayRate changes	2022-09-09 00:00:08 +09:00
Dean Herbert	6945c43e0d	Merge pull request #20178 from smoogipoo/fix-match-creation-beatmap-select ... Fix several weird scenarios with online play song selection	2022-09-08 23:07:09 +09:00
Dean Herbert	d4afc3629c	Merge branch 'master' into kps	2022-09-08 23:00:36 +09:00
Dan Balasescu	3c8ee1a20a	Merge pull request #20179 from peppy/update-framework ... Update framework	2022-09-08 22:14:16 +09:00
Dan Balasescu	9aab502adc	Merge pull request #20157 from peppy/true-gameplay-rate ... Refactor `TrueGameplayRate` to account for only gameplay adjustments, no matter what	2022-09-08 19:54:32 +09:00
Dan Balasescu	a90ca94a18	Remove outdated tests	2022-09-08 19:51:28 +09:00
Dan Balasescu	4fc03998a1	Merge pull request #20189 from peppy/fix-playlist-item-download-button-visibility ... Fix playlist items showing download button briefly during initial display	2022-09-08 19:47:35 +09:00
Dan Balasescu	c585f08a3b	Fix still inverted condition	2022-09-08 19:42:09 +09:00
Dean Herbert	15a4eb46c4	Rename test scene to match class name	2022-09-08 19:20:26 +09:00
Dean Herbert	096d1c3ff3	Merge pull request #20143 from acid-chicken/feat/stats/colored-td ... Show judgement colours in hit distribution graph	2022-09-08 19:15:40 +09:00
Dean Herbert	13d9b2188b	Merge pull request #20145 from smoogipoo/multiple-countdowns ... Implement support for multiple active countdowns in multiplayer	2022-09-08 19:15:30 +09:00
Dean Herbert	ee094e3a85	Rewrite tests	2022-09-08 19:05:13 +09:00
Dan Balasescu	b559d4ecdf	Rename GameplayAdjustments -> AdjustmentsFromMods	2022-09-08 17:14:06 +09:00
Dean Herbert	ed81297611	Fix playlist items showing download button briefly during initial local presence checks	2022-09-08 17:10:45 +09:00
Dean Herbert	7b079c134e	Update test to actually test what was intended	2022-09-08 15:48:04 +09:00
Dean Herbert	3d9bf25c8a	Apply NRT to TestScenePlaySongSelect ... Very mess.	2022-09-08 14:49:57 +09:00
Dean Herbert	6aac0bd4e9	Update test to account for the fact that SSDQ is not zero anymore	2022-09-08 13:43:37 +09:00
Dan Balasescu	208bd0f391	Give OnlinePlaySongSelect a reference PlaylistItem	2022-09-07 21:34:29 +09:00
Dean Herbert	6a03b4e0de	Merge branch 'master' into true-gameplay-rate	2022-09-07 20:01:03 +09:00
Dean Herbert	770c1ade2f	Add test coverage of track rate adjusting during multi spectator	2022-09-07 20:00:24 +09:00
Dean Herbert	75d0deef72	Apply proposed changes to remove inheritance from MasterGameplayClockContainer	2022-09-07 17:49:05 +09:00
Dan Balasescu	f8e37af2e0	Merge pull request #20171 from peppy/beatmap-carousel-nrt ... Fix missing null checks on `selectedBeatmap` fields in `BeatmapCarousel`	2022-09-07 17:15:00 +09:00
Dan Balasescu	264c9bfaf6	Merge pull request #20173 from peppy/test-scene-storyboard-tidy ... Tidy up `TestSceneStoryboard`	2022-09-07 17:07:19 +09:00
Dean Herbert	68c27522e7	Merge pull request #20158 from smoogipoo/taiko-geki-katu ... Decode taiko Geki/Katu from legacy scores into `LargeBonus`	2022-09-07 17:06:42 +09:00
Dean Herbert	cb1bb99208	Tidy up test logic	2022-09-07 16:43:48 +09:00
Dean Herbert	5b758afd09	Merge branch 'master' into taiko-geki-katu	2022-09-07 16:22:47 +09:00
Dean Herbert	b50116e9e4	Add missing null check in BeatmapCarousel tests	2022-09-07 16:22:11 +09:00
Dean Herbert	258b8f015c	Add test coverage of storyboard using zero VectorScale	2022-09-07 15:39:19 +09:00
Dean Herbert	866bc553fe	Tidy up TestSceneStoryboard	2022-09-07 15:38:49 +09:00
Dan Balasescu	dc71abdf56	Merge pull request #20144 from peppy/fix-notification-overlay-presence ... Fix completion toasts sometimes not displaying	2022-09-07 14:55:33 +09:00
Acid Chicken (硫酸鶏)	3003fc1061	refactor(osu.Game): improve code quality	2022-09-07 02:29:15 +09:00
Salman Ahmed	90207b6032	Merge branch 'master' into feature/EditorDeleteDiff	2022-09-06 18:48:06 +03:00
Dan Balasescu	7c0e99c5a8	Decode Geki/Katu from legacy taiko scores into LargeBonus	2022-09-07 00:12:34 +09:00
Dean Herbert	c2107bd322	Fix test failures due to notifications being forwarded before player finishes loading	2022-09-06 23:36:27 +09:00
Dean Herbert	bc1212f4e6	Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method	2022-09-06 22:26:46 +09:00
Dean Herbert	579e7e1f17	Fix deleting a difficulty not updating the beatmap set hash	2022-09-06 18:12:47 +09:00
Dean Herbert	9f2ea54e40	Tidy up TestSceneLeadIn constant for loop offset to read better	2022-09-06 17:45:53 +09:00
Dean Herbert	fa0a4614f8	Add failing test for second incorrect case of start time handling	2022-09-06 16:40:59 +09:00
Dean Herbert	abf0242686	Add failing test for incorrect start time of storyboard elements	2022-09-06 16:16:58 +09:00
Mk-56spn	cfa1ebd0cb	Test fix	2022-09-06 03:00:13 +02:00
Dean Herbert	9e3228aa65	Fix completion notification not being posted if completion occurs during NotificationOverlay load	2022-09-06 04:07:49 +09:00
Dean Herbert	0514c96191	Fix incorrect count tracking when notification is manually disposed	2022-09-05 19:26:40 +09:00
Dean Herbert	229e1a8ef7	Fix notification overlay being present when it doesn't need to	2022-09-05 19:13:58 +09:00
Dan Balasescu	2923c10cd8	Rewrite rooms to store multiple active countdowns ... Update test to the new structure	2022-09-05 19:03:26 +09:00
Dean Herbert	56886fed09	Add test coverage of progress notification completions showing	2022-09-05 18:39:11 +09:00
Acid Chicken (硫酸鶏)	6946015d17	style(osu.Game): fix multiple blank lines	2022-09-05 07:49:29 +00:00
Mk-56spn	aace334fb3	Fix some test issues	2022-09-05 04:49:48 +02:00
Acid Chicken (硫酸鶏)	19ab1433c6	test(osu.Game): add more test cases for HitTimingDistributionGraph	2022-09-05 03:46:23 +09:00
Dean Herbert	bc5340e33a	Merge branch 'master' into fix_progress_bar_info	2022-09-02 18:00:35 +09:00
Dean Herbert	dc02b59a05	Add extra coverage to tests ... Also fixes a potential failure due to test beatmap having two difficulties with same name.	2022-09-02 17:57:20 +09:00
HiddenNode	7a8fa5c2e4	Fix filenames mismatch	2022-09-02 09:56:00 +01:00
Dean Herbert	65baf73d97	Add test scene	2022-09-02 16:50:28 +09:00
Dean Herbert	a70fc10d06	Fix mock track construction failure	2022-09-02 16:30:04 +09:00
Dean Herbert	6a35b233e5	Merge branch 'master' into remove-dispose-updates	2022-09-01 23:03:19 +09:00
Dean Herbert	148e487c02	Add failing test of date submitted search failing	2022-09-01 19:59:27 +09:00
HiddenNode	921a9ef895	clean up	2022-08-31 22:18:52 +01:00
HiddenNode	a548b28158	Added test scene for SizePreservingSpriteText	2022-08-31 22:05:46 +01:00
Dean Herbert	ba20044af4	Fix missing nullability consideraition	2022-08-31 23:24:39 +09:00
Dan Balasescu	837b19ab24	Merge pull request #19919 from khang06/nan-sv ... Emulate osu!stable's NaN slider velocity behavior	2022-08-31 19:06:49 +09:00
Dan Balasescu	6cadcc206b	Merge pull request #20032 from peppy/toast-notification-tray ... Add toast notification tray	2022-08-31 16:57:37 +09:00
Dan Balasescu	000412c50f	Merge pull request #20014 from peppy/fix-resume-skip-forward ... Fix gameplay skipping forward during resume operation	2022-08-31 16:30:37 +09:00
Dan Balasescu	afe2862df4	Merge branch 'master' into toast-notification-tray	2022-08-31 16:07:11 +09:00
Dan Balasescu	e984dc4a19	Merge pull request #20042 from peppy/fix-composer-test-scenes ... Test editor `ComposeScreen` tests not adding beatmap to hierarchy	2022-08-31 15:59:48 +09:00
Dean Herbert	7337d4c1aa	Merge branch 'master' into kps	2022-08-31 15:41:42 +09:00
Dean Herbert	e9463f3c19	Test editor ComposeScreen tests not adding beatmap to hierarchy ... Makes it hard to test anything because `EditorBeatmap`'s `Update` method updates whether a beatmap has timing or not (enabling the placement controls). Also adds a basic timing point to allow for better testing.	2022-08-31 14:07:56 +09:00
Dean Herbert	7ce1cf7560	Add test coverage of skip button failure with equal time	2022-08-31 13:22:51 +09:00
Dean Herbert	c573396ab6	Fix IntroTestScene not clearing previous notifications hard enough	2022-08-31 12:46:54 +09:00
Dean Herbert	3d93e0ded1	Merge branch 'master' into fix-resume-skip-forward	2022-08-31 12:16:15 +09:00
Dean Herbert	9eb615f942	Fix remaining test failures by strengthening PlayerLoader tests ... - Click using `TriggerClick` as notifications move around quite a bit. - Ensure any notifications from a previous test method are cleaned up.	2022-08-31 01:40:30 +09:00
Dean Herbert	31a9980686	Update remaining test expectations with new behaviour	2022-08-31 00:57:30 +09:00
Dean Herbert	a62ba9e0d9	Remove notification blocking behaviour of first run setup	2022-08-31 00:57:18 +09:00
Dean Herbert	b8fda1a16f	Apply NRT to notification classes ... and tidy things up a bit.	2022-08-30 15:57:10 +09:00
Dan Balasescu	8b3742188f	Fix test by also clearing out maximum statistics	2022-08-30 15:42:36 +09:00
Dan Balasescu	5202c15a0e	Populate MaximumStatistics for test scores	2022-08-30 15:11:39 +09:00
HiddenNode	43f2ba6596	Added test scene	2022-08-29 22:00:33 +01:00
HiddenNode	d20e7da2d9	Changed epsilon	2022-08-29 21:03:22 +01:00
ansel	545e0bbcef	Adjust inheritors and test	2022-08-29 22:49:25 +03:00
Dean Herbert	062a6fcc18	Fix failing large offset test ... If we are going to continue to let the underlying clock process frames, there needs to be a bit of lenience to allow the backwards seek on resume (to play back over the freq ramp period). The test is meant to be ensuring we don't skip the full offset amount, so div10 seems pretty safe.	2022-08-30 01:21:55 +09:00
Dan Balasescu	0491addbbd	Merge pull request #19974 from peppy/no-gameplay-clock-editor-offset ... Fix editor not applying offsets	2022-08-29 21:10:29 +09:00
Dean Herbert	82b9e1f0eb	Merge pull request #20011 from smoogipoo/scoring-refactor ... Refactor scoring to remove async methods / simplify	2022-08-29 19:55:27 +09:00
Dean Herbert	ad5ef52922	Add test coverage of resuming after pause not skipping forward in time	2022-08-29 19:02:01 +09:00
Dan Balasescu	e3e204001e	Merge pull request #19907 from peppy/ruleset-api-versioning ... Add ruleset API versioning	2022-08-29 18:50:01 +09:00
Salman Ahmed	f2378d3fde	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-29 11:23:22 +03:00
Dean Herbert	9b830d063f	Merge pull request #20010 from smoogipoo/scoreprocessor-no-rewrite-statistics ... Don't include misses in failed score statistics	2022-08-29 17:07:13 +09:00
Dean Herbert	2dafa041a7	Account for offset being applied to editor clock time in TestSceneEditorClock	2022-08-29 16:42:50 +09:00
Dan Balasescu	d4a37725c4	Adjust test	2022-08-29 15:59:57 +09:00
Dean Herbert	a215d009fe	Update Remove/RemoveRange/RemoveAll calls in line with framework changes	2022-08-29 15:57:40 +09:00
Dan Balasescu	423f6f90f2	Remove async calls from ScoreManager	2022-08-29 15:34:08 +09:00
Dean Herbert	e8ae6840ea	Add test coverage of selection being retained	2022-08-29 15:23:34 +09:00
Dean Herbert	892f43da43	Add test coverage of ruleset being marked unavailable if methods are throwing	2022-08-29 14:28:55 +09:00
Dean Herbert	5ff4e6a4fe	Add test coverage for outdated ruleset	2022-08-29 14:26:12 +09:00
Dan Balasescu	c0b13c7e1f	Refactor ScoreProcessor ComputeScore() methods	2022-08-29 13:51:10 +09:00
HiddenNode	d4a52baa56	Added visual test for UprightAspectMaintainingContainer	2022-08-29 00:07:42 +01:00
ansel	2a12194ff9	Test colours	2022-08-28 02:59:38 +03:00
ansel	90334a2b91	Add test scene	2022-08-27 20:12:45 +03:00
Dan Balasescu	289b6f1a58	Merge pull request #19924 from peppy/fix-playlist-overlay-test-failures ... Fix intermittent test failures in `TestScenePlaylistOverlay`	2022-08-26 23:36:16 +09:00
Salman Ahmed	1fd1672d89	Merge branch 'master' into mod-validation-tests	2022-08-26 15:00:07 +03:00
Dean Herbert	6dc859973b	Merge branch 'master' into fix-playlist-overlay-test-failures	2022-08-26 20:25:53 +09:00
Dean Herbert	90ff0864c0	Merge branch 'master' into no-gameplay-clock-editor-offset	2022-08-26 20:25:21 +09:00
Dan Balasescu	91e044542d	Merge pull request #19828 from peppy/no-gameplay-clock-gameplay-offset ... Introduce `FramedBeatmapClock` (and use in gameplay flow)	2022-08-26 20:21:34 +09:00
Dean Herbert	5ef8e26ebe	Fix check not accounting for mods not existing in certain rulesets ... Also check all instances, rather than first.	2022-08-26 19:59:26 +09:00
Dean Herbert	580754833f	Merge branch 'master' into mod-validation-tests	2022-08-26 19:48:42 +09:00
Dean Herbert	9c9238d6e8	Fix TimelineTestScene's beatmap getting overwritten by EditorClockTestScene	2022-08-26 18:38:52 +09:00
Dean Herbert	4b72e55770	Fix various test scenes not adding EditorClock to the draw hierarchy	2022-08-26 18:08:43 +09:00
Dean Herbert	9050f54681	Split out test assertion methods to read better	2022-08-26 16:56:03 +09:00
Dean Herbert	a8c699610a	Fix lead in tests not waiting for player to start running ... The tests are only meant to ensure that gameplay eventually starts. The case where failures can occur is where the master clock is behind the player clock (due to being in lead-in time). Because the test is running in real-time, it can take arbitrary amounts of time to catch up. If it took too long, the test would fail.	2022-08-25 18:00:14 +09:00
Dean Herbert	ddb434f47a	Rename asserts to method names to make it easier to track in logs	2022-08-25 17:30:13 +09:00
Dean Herbert	a5c61d9a52	Improve understandability of TestMostInSyncUserIsAudioSource	2022-08-25 16:47:33 +09:00
Dean Herbert	3a17c6df08	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-25 16:24:55 +09:00
Salman Ahmed	eb57ea76ab	Merge branch 'master' into legacy-combo-increase	2022-08-25 09:46:12 +03:00
Dean Herbert	1032b2a68c	Fix some BeatmapCarousel tests not correctly reinitialising local data per run ... Closes https://github.com/ppy/osu/issues/19949.	2022-08-25 14:03:26 +09:00
Dan Balasescu	73f41439ae	Remove redundant qualifiers	2022-08-25 13:34:58 +09:00
Ryuki	5cddc7ed1f	Code cleanup (CPS)	2022-08-24 17:13:23 +02:00
Dan Balasescu	c9ff39f8c3	Add HitResult.LegacyComboIncrease	2022-08-24 19:46:41 +09:00
Dean Herbert	5129716612	Merge branch 'master' into kps	2022-08-24 18:18:45 +09:00
Dean Herbert	ddccf4defe	Remove dollar sign	2022-08-24 17:17:59 +09:00
Dean Herbert	27b57947e4	Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity	2022-08-24 17:13:14 +09:00
Dean Herbert	5f01f461b3	Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock	2022-08-24 17:13:14 +09:00
Dean Herbert	5079e0d83d	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-24 16:52:10 +09:00
Khang	adea29c106	Fix test failures	2022-08-24 03:37:33 -04:00
Dean Herbert	d33d705684	Make WaitingOnFrames non-bindable	2022-08-24 16:03:38 +09:00
Khang	c7d4c739aa	Add a basic NaN control point test for LegacyBeatmapDecoder	2022-08-24 02:53:55 -04:00
Dean Herbert	995e6664b6	Rename spectator clock sync classes	2022-08-24 15:13:08 +09:00
Dean Herbert	31f657fe01	Remove ISpectatorPlayerClock interface ... Too many levels of redirection. One interface with one implementation is not useful, IMO.	2022-08-24 15:12:57 +09:00
Dean Herbert	46d000b8ce	Fix test regressions on windows due to Reset never being called ... I'm not sure this is great. Without calling `Reset`, the correct initial time may not be set (ever). In practice this doesn't happen anywhere in the gameplay flow, but something worth noting. This change is required now that `Reset` isn't called in the constructor. It couldn't be called in the constructor because it would cause the audio track to reset its position too early. What an ordeal.	2022-08-24 11:50:20 +09:00
Dean Herbert	ec61a94dc9	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-23 17:36:06 +09:00
Dean Herbert	9a579871c0	Remove pointless initial import	2022-08-23 17:33:53 +09:00
Dean Herbert	a62deae3cc	Use local realm rather than fetching from dependencies	2022-08-23 17:33:53 +09:00
Dean Herbert	690e048864	Ensure all initial imports are completed before running playlist overlay tests steps	2022-08-23 17:33:53 +09:00
Dean Herbert	553897f2f0	Remove AddClock method to CreateManagedClock	2022-08-23 13:52:43 +09:00
Khang	a81672f3dc	Use an infinite tick distance instead of directly disabling tick generation for SliderEventGenerator	2022-08-22 23:31:24 -04:00
Khang	9f08c474ca	Treat NaN slider velocity timing points as 1.0x but without slider ticks	2022-08-22 21:58:38 -04:00
Khang	e8d4bc4497	Allow NaN during beatmap parsing if desired	2022-08-22 21:04:26 -04:00
Dan Balasescu	5d3d8681d4	Invert creation of clocks in multi spectator	2022-08-22 19:14:06 +09:00
Ryuki	b597049524	Code cleanup for CPS tests ... - Remove null-forgiving operator usages - Fix code quality issues mentionned by NVika	2022-08-22 10:47:37 +02:00
Dean Herbert	058d67f8e8	Merge pull request #19695 from naoei/ruleset-localization ... Change most ruleset-accessible string types to Localisable strings	2022-08-22 16:13:23 +09:00
Dan Balasescu	0815b01b75	Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation ... Fix selecting preset containing Difficulty Adjust automatically opening customisation panel	2022-08-22 15:44:00 +09:00
Dean Herbert	af2e82d7d5	Move operation of setting GameplayClockContainer.StartTime to Reset call	2022-08-22 14:11:06 +09:00
Ryuki	c56390cd7b	Use less custom classes for CPS tests	2022-08-22 00:03:24 +02:00
Nao	189a407cb1	Merge branch 'master' into ruleset-localization	2022-08-20 21:39:10 -04:00
Ryuki	3ac6500423	Add new test resources for CPS counter	2022-08-21 03:00:51 +02:00
Dean Herbert	da407aa827	Merge branch 'master' into kps	2022-08-20 15:24:58 +09:00
Dean Herbert	15d49b0357	Update TestSceneSpectator to user new assert style	2022-08-19 01:46:19 +09:00
Ryuki	3de35a1518	Update calculator and tests to match changes on clocks	2022-08-18 18:40:02 +02:00
Dean Herbert	cc86909633	Increase lenience on TestSceneLeadIn tests ... I've gone through these in detail and can't find an issue with the actual flow of things. For whatever reason, the new structure has a slightly higher delay, likely due to performing less `Seek` calls (previously a `Seek` was called after the clock start which may have been making this more accurate on the first `Player.Update`). I don't think it really matters that this is slightly off, but we'll see how this plays out.	2022-08-19 01:39:00 +09:00
Dean Herbert	2eba8650ca	Update TestSceneLeadIn to use new assert style	2022-08-18 19:26:19 +09:00
Dean Herbert	43879633db	Ensure setting a StartTime on a GameplayClockContainer always resets to the new time	2022-08-18 18:54:10 +09:00
Dean Herbert	728cd96508	Update TestSceneLeadIn to use new assert style	2022-08-18 18:54:10 +09:00
Dan Balasescu	fa167b1d12	Merge pull request #19779 from peppy/no-gameplay-clock ... Remove all remaining usage of `GameplayClock`	2022-08-18 18:52:57 +09:00
Dan Balasescu	7878231a73	Merge pull request #19817 from peppy/various-test-fixes ... Refactor some tests	2022-08-18 14:39:43 +09:00
Dean Herbert	e7ddbc41c8	Merge branch 'master' into no-gameplay-clock	2022-08-17 22:21:10 +09:00
Dan Balasescu	11301f52b7	Merge pull request #19814 from peppy/update-framework ... Update framework (and other dependencies)	2022-08-17 19:24:01 +09:00
Dean Herbert	553ae4781f	Remove unnecessary local implementation in TestScenePlaybackControl	2022-08-17 19:21:54 +09:00
Dean Herbert	4ef4d66f49	Add some extra initial state checks to TestSceneEditorSeekSnapping	2022-08-17 19:21:46 +09:00
Dan Balasescu	3a0017c87b	Fix flaky quick retry test	2022-08-17 17:09:44 +09:00
Dean Herbert	a5ac69a554	Update various dependencies	2022-08-17 16:57:56 +09:00
Dean Herbert	20256aad11	Merge branch 'master' into no-gameplay-clock	2022-08-17 15:21:20 +09:00
Dan Balasescu	24fd411720	Merge pull request #19594 from BlauFx/improve_retry_behaviour ... Skip song intro on quick restart	2022-08-16 20:18:12 +09:00
Dean Herbert	9a1a7bae89	Make test actually test things	2022-08-16 14:40:02 +09:00
Dean Herbert	6761f869f9	Modify flow to avoid weird bindable and value resetting	2022-08-16 14:17:35 +09:00
Dean Herbert	a15e6f19aa	Fix running TestScenePlayerLoader interactively leaving volume in a bad state	2022-08-16 13:40:46 +09:00
Dean Herbert	c9baadcf88	Merge branch 'master' into improve_retry_behaviour	2022-08-16 13:06:04 +09:00
Bartłomiej Dach	a494e55d93	Adjust test scene to reflect new behaviour	2022-08-15 20:43:19 +02:00
Bartłomiej Dach	f0ad31b650	Add failing test case	2022-08-15 20:38:22 +02:00
Bartłomiej Dach	5ff2e41a55	Add preset column to mod select test scene	2022-08-15 18:38:37 +02:00
Dean Herbert	1696a905ba	Reduce exposed properties in GameplayClockContainer	2022-08-15 20:22:36 +09:00
Dean Herbert	704568ae3b	Remove remaining usage of GameplayClock	2022-08-15 20:22:36 +09:00
Dean Herbert	87760bbc06	Fix IsCatchingUp not being in correct state	2022-08-15 20:17:48 +09:00
Dean Herbert	04d88b8216	Use constraint based assertions in TestSceneFrameStabilityContainer	2022-08-15 19:19:19 +09:00
Dean Herbert	27569e2ed5	Remove FrameStableClock (and redirect usages to FrameStabilityContainer)	2022-08-15 19:19:19 +09:00
Dean Herbert	f81c7644b4	Make GameplayClockContainer also an IGameplayClock and expose to remaining tests	2022-08-15 18:30:53 +09:00
Dean Herbert	c8764cb333	Move all usage of GameplayClock to IGameplayClock	2022-08-15 18:30:53 +09:00
Dean Herbert	6d78218142	Update usages of GameplayClockContainer.GameplayClock to access properties directly	2022-08-15 18:08:49 +09:00
Dean Herbert	58146598c8	Update TestSceneEditorClock to use constraint-based assertions	2022-08-15 18:08:05 +09:00
Nao	c940f5abcb	Merge branch 'master' into ruleset-localization	2022-08-14 15:17:44 -04:00
naoei	784ce4d23d	Add test coverage for localisable setting source	2022-08-14 15:06:33 -04:00
Ryuki	2aa3a1b50d	Rename all "KeysPerSecond" usages to "ClicksPerSecond"	2022-08-14 20:12:11 +02:00
Ryuki	9dc806506e	Make ActionListener and KeysPerSecondCalculator not rely on events to add timestamps	2022-08-14 19:31:14 +02:00
Dean Herbert	a90967715c	Add test coverage of new imports not correctly being filtered by collection filter	2022-08-12 15:06:34 +09:00
Dean Herbert	5111bad86c	Refactor TestScenePlaylistOverlay to use realm for testing ... Removes the dual-purpose flow which existed only for testing.	2022-08-12 15:06:34 +09:00
Ryuki	3c6461b9e4	Remove KPS acronym usage	2022-08-11 10:01:39 +02:00
Ryuki	0e1efbd865	Rename DrawableCookieziRuleset to MockDrawableRuleset	2022-08-11 01:04:06 +02:00
Ryuki	d58d5eebe2	Add basic tests for KPS ... Created private mock classes to use them in place of `GameplayClock` and `DrawableRuleset`.	2022-08-11 00:51:13 +02:00
naoei	3e38baca3c	Change ruleset mod description types	2022-08-10 16:09:11 -04:00
Dean Herbert	7c6e5a1085	Add test coverage of case insensitive audio equality	2022-08-10 16:06:56 +09:00
Dean Herbert	d59f4720f1	Merge pull request #19664 from peppy/test-assertions ... Update multiple tests to use new assert output for easier to understand failures	2022-08-09 23:15:16 +09:00
Dan Balasescu	41af03dec5	Merge pull request #19597 from frenzibyte/hotfix-multi-spectator-results-screen ... Fix multi-spectator potentially getting stuck for passed players (hotfix)	2022-08-09 21:11:10 +09:00
Dan Balasescu	2de9e5f40f	Fix test failure	2022-08-09 20:23:45 +09:00
Dean Herbert	1270ee9624	Update multiple tests to use new assert output for easier to understand failures	2022-08-09 19:19:54 +09:00
Dean Herbert	aa9ced7f04	Add test coverage of ToolbarUserButton	2022-08-09 15:51:10 +09:00
Ryuki	edb8e5e33e	Temporarily emptying TestSceneKeysPerSecondCounter until a good test can be found	2022-08-09 02:43:41 +02:00
BlauFx	e4879aa450	Add test	2022-08-08 21:12:38 +02:00
Bartłomiej Dach	eba070a0f8	Add weak test coverage of broken audio playback after soft-delete	2022-08-08 20:30:37 +02:00
Dean Herbert	a8dee17513	Fix missing DummyRenderer in skin resources tests	2022-08-08 13:06:01 +09:00
Dean Herbert	e1189da824	Merge branch 'master' into irenderer-glwrapper	2022-08-08 12:31:53 +09:00
Dean Herbert	0537c471dc	Merge pull request #19582 from smoogipoo/apimod-json-cleanup ... Don't serialise empty mod settings	2022-08-08 11:49:08 +09:00
Salman Ahmed	f75dced305	Fix possible null assignment inspection in TestScenePreviewTrackManager	2022-08-08 02:00:24 +03:00
Bartłomiej Dach	839409d7ac	Add preset column to solo mod select overlay	2022-08-07 16:20:31 +02:00
Bartłomiej Dach	de64b83532	Add test coverage for desired user selection behaviour	2022-08-07 16:20:16 +02:00
Bartłomiej Dach	25daaa56e2	Add test coverage for desired external selection behaviour	2022-08-07 15:30:20 +02:00
Dean Herbert	4a95638756	Merge branch 'master' into mod-overlay/delete-preset	2022-08-07 12:34:25 +09:00
Dean Herbert	5946124278	Merge pull request #19612 from bdach/mod-overlay/common-delete-dialog ... Unify implementations of deletion dialogs	2022-08-07 12:18:03 +09:00
Bartłomiej Dach	6f6beddab5	Add test coverage for mod preset deletion flow	2022-08-06 21:58:55 +02:00
Bartłomiej Dach	9b3183b2b4	Implement mod preset deletion flow	2022-08-06 21:58:55 +02:00
Bartłomiej Dach	26b9adbe0c	Adjust collection deletion test to match new expectations	2022-08-06 21:07:21 +02:00
Bartłomiej Dach	cc353b872c	Add test coverage for other approval events	2022-08-06 18:21:57 +02:00
Salman Ahmed	789e8b4d8d	Fix multi-spectator test updating state after removing user ... Removing user triggers `playingUsers.Remove`, but doing so before updating the state leads to `EndGameplay` being called with `State == Playing` rather than `Quit`.	2022-08-06 05:41:26 +03:00
Ryuki	0c07df2c26	Remove DT from KPS test	2022-08-05 21:02:37 +02:00
Ryuki	b4e0fa7c53	Rewrite tests for KPS	2022-08-05 15:53:06 +02:00
Dan Balasescu	cf362a6b4f	Merge pull request #19529 from peppy/locally-modified-pill ... Show "locally modified" pill when local modifications have been made	2022-08-05 21:12:13 +09:00
Dan Balasescu	c4b9b2a14b	Merge branch 'master' into irenderer-glwrapper	2022-08-05 20:35:06 +09:00
Dean Herbert	7c952f8069	Add more test coverage of locally-modified state change	2022-08-05 14:25:10 +09:00
Dan Balasescu	0de00e9b3f	Don't serialise empty mod settings	2022-08-05 14:00:53 +09:00
Ryuki	42d1bdfc95	Move KPS calculation to a standalone class	2022-08-05 04:17:01 +02:00
Dan Balasescu	c11a24b3ff	Remove unused using	2022-08-04 15:05:52 +09:00
Dan Balasescu	6632367c6d	Ensure skin samples are looked up in correct order	2022-08-04 14:48:12 +09:00
Bartłomiej Dach	ac9321204c	Merge branch 'master' into mod-overlay/create-preset	2022-08-03 21:21:52 +02:00
Dean Herbert	7022d9e5f8	Fix test step names being too long	2022-08-03 21:13:49 +09:00
Dean Herbert	bacbf5b7f0	Update existing test expectations	2022-08-03 20:20:06 +09:00
Dean Herbert	24d84890e4	Change all filter control button state test to until steps ... There's multiple schedules at play which could be adding multi-frame delays. let's play it safe and try and fix flaky tests. Example of `Schedule` which could cause an issue: 392cb352cc/osu.Game/Collections/CollectionDropdown.cs (L77-L78) Example of test failure: https://github.com/ppy/osu/runs/7648118894?check_suite_focus=true	2022-08-03 20:03:07 +09:00
Bartłomiej Dach	add2971eb4	Implement preset creation flow with test coverage	2022-08-02 22:05:54 +02:00
Bartłomiej Dach	1b3074d098	Implement popover for creating mod presets	2022-08-02 22:03:33 +02:00
Dan Balasescu	5a1c05918f	Fix test failures	2022-08-02 20:18:45 +09:00
Dan Balasescu	b4e55f7309	Apply IRenderer changes	2022-08-02 19:50:57 +09:00
Dan Balasescu	dc49862466	Merge branch 'irenderer-shaders' into irenderer-textures	2022-08-02 19:25:24 +09:00
Bartłomiej Dach	923d9a4e5f	Add failing assertions to demonstrate autosize failure	2022-08-01 22:04:14 +02:00
Dean Herbert	c0e5f11c90	Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability ... Fix newly imported beatmaps not using correct comparer for sorting	2022-08-02 02:20:51 +09:00
Dean Herbert	01cc9bd7ef	Merge pull request #19479 from frenzibyte/carousel-update-on-resume ... Fix song select not updating selected beatmap card on editor resume	2022-08-02 00:48:18 +09:00
Salman Ahmed	682192dbd7	Add failing test case	2022-08-01 18:43:01 +03:00
Salman Ahmed	7c9f8648a5	Merge branch 'master' into remove-nullable-disable-in-the-audio-namespace	2022-08-01 15:25:12 +03:00
Dan Balasescu	d4eec9122f	Merge pull request #19516 from peppy/fix-editor-track-disposal-crash ... Fix editor potentially playing a track post-disposal	2022-08-01 18:12:21 +09:00
Dan Balasescu	225033c3b2	Merge pull request #19517 from peppy/add-more-missing-realm-refreshres ... Add more missing realm `Refresh()` calls to new beatmap import tests	2022-08-01 17:54:51 +09:00
Dan Balasescu	1d27c4f020	Merge pull request #19504 from peppy/skin-serialisation-test-coverfage ... Add test coverage of deserialisation of skin layouts	2022-08-01 17:17:16 +09:00
Dean Herbert	ee68113913	Add more missing realm Refresh() calls to new beatmap import tests ... As noticed at https://github.com/ppy/osu/runs/7605101313?check_suite_focus=true	2022-08-01 17:06:46 +09:00
Dean Herbert	2519706ad6	Add test coverage of editor crash	2022-08-01 16:53:49 +09:00
Dan Balasescu	47860bb966	Remove unused using	2022-08-01 16:33:59 +09:00
Dean Herbert	3b6349a145	Add test coverage of remaining components which weren't already included	2022-08-01 14:16:26 +09:00
Dean Herbert	d112743cea	Improve test coverage of skin serialisation to ensure full coverage ... Will fail when new skinnable components are added until they have coverage in resources.	2022-08-01 14:04:12 +09:00
Joseph Madamba	320c4abb66	Add failing online play non-current sub screen onexiting test	2022-07-31 20:13:06 -07:00
Bartłomiej Dach	5a34122a85	Fix test breakage after realm migration	2022-07-31 23:53:46 +02:00
Bartłomiej Dach	9d3cdae4bb	Fix test scene to handle restarts properly	2022-07-31 23:53:46 +02:00
Bartłomiej Dach	9dea8e3d12	Add test coverage of preset soft deletion	2022-07-31 23:53:46 +02:00
Bartłomiej Dach	c837848238	Add extended test coverage of preset realm subscription	2022-07-31 23:53:45 +02:00
Bartłomiej Dach	345f103119	Migrate mod preset column to use realm	2022-07-31 23:53:45 +02:00
Dean Herbert	f9f9b65c86	Add test coverage of deserialisation skin layouts	2022-08-01 01:14:05 +09:00
Dean Herbert	db4c6aa3d3	Add test skin layout json resources	2022-08-01 01:13:47 +09:00
andy840119	5dd641bc60	Remove the nullable disable annotation in the test project.	2022-07-31 22:02:07 +08:00
Salman Ahmed	b95aff3e5f	Add failing test case	2022-07-30 18:50:41 +03:00
Susko3	38a8b9cf0a	Add battery info for desktop platforms	2022-07-30 14:26:19 +02:00
Dean Herbert	43e612f6d4	Merge pull request #19455 from peppy/confirm-playlist-discard ... Add confirmation dialog when about to discard a playlist	2022-07-30 19:17:49 +09:00
Salman Ahmed	8ca8484f0e	Fix failing tests	2022-07-30 11:49:33 +03:00
Salman Ahmed	ec1a7994cc	Switch method to statement body for better readability ... Almost thought the method was not wrapped in an `AddStep`.	2022-07-30 10:11:01 +03:00
Salman Ahmed	0c125db197	Fix potential nullref on TestSceneAutoplay check steps	2022-07-30 10:11:01 +03:00
Dan Balasescu	e06f39a69f	Apply IRenderer shader changes	2022-07-30 01:29:11 +09:00
Salman Ahmed	3bc1774c87	Merge branch 'master' into pie-chart-progress	2022-07-29 16:54:59 +03:00
Salman Ahmed	3b1a76b190	Remove redundant/overwritten specifications	2022-07-29 16:45:29 +03:00
Salman Ahmed	905bbdc8ee	Remove caching of GameplayClockContainer in favour of GameplayClock ... Also fixes `SongProgress` being displayed in skin editor on non-gameplay screens, due to `GameplayClock` not marked as a required dependency.	2022-07-29 16:45:29 +03:00
Dan Balasescu	6703b8df02	Merge pull request #19454 from peppy/filter-control-tests-realm-refresh ... Ensure realm is in a good state before asserts in `TestSceneFilterControl`	2022-07-29 17:57:38 +09:00
Dean Herbert	07e3765b34	Ensure collection is added to dropdown before trying to click it	2022-07-29 17:25:30 +09:00
Dean Herbert	0a2265b0e8	Add test coverage of playlist exit confirmation	2022-07-29 17:11:37 +09:00
Dean Herbert	eb92c35335	Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering ... Move spectator begin/end playing to SubmittingPlayer	2022-07-29 16:09:50 +09:00
Dean Herbert	e07e761c10	Ensure realm is in a good state before asserts in TestSceneFilterControl	2022-07-29 15:59:53 +09:00
Dan Balasescu	aaa6f963bd	Fix potential test failures due to Setup/SetUpSteps ordering	2022-07-29 15:27:39 +09:00
Ryuki	2df24019fd	Merge branch 'master' into kps	2022-07-28 18:38:09 +02:00
Ryuki	079150849a	Add some tests	2022-07-28 18:37:50 +02:00
Ryuki	b2e7da5aa0	Add basic Queue based implementation of KPS	2022-07-28 18:37:12 +02:00
Dean Herbert	45879f7836	Merge pull request #19443 from smoogipoo/fix-intermittent-hud-tests ... Fix intermittent HUD tests	2022-07-28 23:20:46 +09:00
Dean Herbert	e664690fe2	Remove unnecessary LoadTrack call	2022-07-28 22:19:46 +09:00
Dean Herbert	3005ff1b9f	Merge branch 'master' into pie-chart-progress	2022-07-28 22:19:27 +09:00
Dan Balasescu	a59d7f6710	Merge branch 'master' into collections-track-beatmap-updates	2022-07-28 22:05:34 +09:00
Dan Balasescu	aa03df905f	Merge pull request #19441 from peppy/test-working-beatmap-unfuck ... Reduce calls to `LoadTrack` by implicitly running on test/dummy classes	2022-07-28 22:05:25 +09:00
Dan Balasescu	11e0022fad	Merge branch 'master' into realm-collections	2022-07-28 21:00:08 +09:00
Dan Balasescu	ce694123eb	Move spectator begin/end playing to SubmittingPlayer	2022-07-28 20:44:04 +09:00
Dean Herbert	7108553883	Tidy up various things everywhere	2022-07-28 18:25:14 +09:00
Dean Herbert	a21aee4e9c	Reduce calls to LoadTrack by implicitly running on test/dummy classes	2022-07-28 18:11:40 +09:00
Dan Balasescu	1039338d80	Fix intermittent HUD tests	2022-07-28 17:58:07 +09:00
Dan Balasescu	1da9830145	Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store ... Remove unused `RulesetStore` from `BeatmapManager` constructor	2022-07-28 17:46:12 +09:00
Dan Balasescu	6d4023b933	Adjust comment	2022-07-28 16:56:11 +09:00
Dan Balasescu	cd01c5d3ac	Fix assertion	2022-07-28 16:34:31 +09:00
Nitrous	0d36907cad	apply code quality fixes	2022-07-28 15:30:45 +08:00
Nitrous	70ed347b06	simplify helper methods	2022-07-28 15:19:35 +08:00
Dean Herbert	2b9d46d803	Remove unused RulesetStore from BeatmapManager constructor	2022-07-28 16:19:05 +09:00
Nitrous	db62d4be3a	apply suggestions ... - refactor `SongProgress` - make`UpdateProgress` more readable - enable NRT on new classes - refactor `TestSceneSongProgress` to use `GameplayClockContainer`	2022-07-28 15:15:41 +08:00
Dan Balasescu	6bf293e130	Fix managed object reused between test runs	2022-07-28 15:45:33 +09:00
Dean Herbert	8ac886a247	Update test to account for sort order	2022-07-28 15:20:25 +09:00
Dean Herbert	67c44552cb	Add realm Refresh calls to ensure tests are stable	2022-07-28 15:18:04 +09:00
Dean Herbert	485d140a21	Add realm refresh calls to fix intermittent test failures on new update tests	2022-07-28 15:15:41 +09:00
Dean Herbert	2ae5a34c0e	Add test coverage of beatmap updates transferring collection hashes	2022-07-28 15:02:58 +09:00
Dean Herbert	ad482b8afc	Tidy up naming of collection dropdowns	2022-07-28 13:57:21 +09:00
Dean Herbert	34a2d1a6e1	Fix ManageCollectionsDialog and remove weird placeholder logic	2022-07-28 13:57:21 +09:00
Dean Herbert	67c7f324ee	Simplify CollectionFilterDropdown filter flow weirdness	2022-07-28 13:57:21 +09:00
Dean Herbert	0913cf013c	Split out tests and fix variable conflict	2022-07-28 13:24:14 +09:00
Dean Herbert	aa65b73f19	Merge branch 'master' into add-notif-externalbutton	2022-07-28 12:17:36 +09:00
Dean Herbert	8da499fb0f	Add proper test coverage	2022-07-28 12:16:21 +09:00
Nitrous	9088caa377	move LegacyComboCounter to osu.Game.Skinning	2022-07-28 08:36:26 +08:00
Dean Herbert	438067a18b	Convert realm data propagation to more correctly use Live<T> ... wip	2022-07-27 19:35:09 +09:00
Dean Herbert	41393616d8	Replace BeatmapCollection with RealmBeatmapCollection	2022-07-27 19:35:09 +09:00
Dean Herbert	9c543fef48	Remove CollectionManager	2022-07-27 18:45:33 +09:00
Nitrous	6af6f03e29	refactor song progress test scene	2022-07-27 15:57:47 +08:00
Nitrous	1e013bd4e9	move song progress graph to its own test scene	2022-07-27 15:57:23 +08:00
Dean Herbert	494486ad09	Fix potential test failure if scores are added to the beatmap which is subsequently removed	2022-07-27 16:27:10 +09:00
Nitrous	37e642b0bd	make SongProgress abstract ... - move unrelated logic to `DefaultSongProgress` - make `LegacySongProgress` inherit `SongProgress`	2022-07-27 15:19:21 +08:00
Dean Herbert	6b73f7c7ec	Split out legacy import path from realm manager	2022-07-27 15:04:09 +09:00
Dan Balasescu	8f7dff5c2c	Merge pull request #19378 from peppy/beatmap-update-test ... Add separate beatmap update flow to handle edge cases better	2022-07-26 18:49:20 +09:00
Dean Herbert	6ff44ed2c6	Merge pull request #19399 from frenzibyte/carousel-order-stability ... Maintain sort stability by using carousel item ID as a fallback	2022-07-26 17:33:30 +09:00
Dean Herbert	7f75184a01	Merge branch 'master' into beatmap-update-test	2022-07-26 17:27:36 +09:00
Dean Herbert	ee694c1257	Add test coverage of no online ID scenario	2022-07-26 17:27:23 +09:00
Dean Herbert	1221cb1a42	Add comprehensive test coverage of update scenarios	2022-07-26 17:22:52 +09:00
Dan Balasescu	28e81b7c32	Merge pull request #19392 from peppy/fix-test-leftovers ... Avoid leaving left-over files after test run completes	2022-07-26 16:33:14 +09:00
Dean Herbert	846291d203	Refactor new tests to not suck as much as the old importer tests	2022-07-26 16:33:00 +09:00
Salman Ahmed	91ffa7007f	Improve existing test coverage to cover order changes from other sort modes	2022-07-26 10:24:51 +03:00
Dean Herbert	8370ca9765	Add ImportAsUpdate method to IModelImporter to avoid otehr changes	2022-07-26 15:49:04 +09:00
Dean Herbert	4efe09e7c2	Merge pull request #19377 from frenzibyte/fix-timeline-tests ... Fix intermittent timeline zoom test failures	2022-07-26 15:18:35 +09:00
Dean Herbert	ac553d22ea	Fix left over resource file which isn't actually imported	2022-07-26 15:08:18 +09:00
Dean Herbert	59d3cc52c4	Avoid leaving left-over files after test run completes	2022-07-26 15:08:18 +09:00
Dean Herbert	7d8a78ef01	Move tests to own class	2022-07-26 14:53:20 +09:00
Dean Herbert	ef10145d6f	Rename MenuCursorContainer and clean up code	2022-07-26 14:11:52 +09:00
Salman Ahmed	e5355f314d	Use longer hash string	2022-07-25 15:19:32 +03:00
Dean Herbert	9c411c2250	Fix test nullability assertions	2022-07-25 20:06:37 +09:00
Dean Herbert	92dd1bcddb	Add test coverage of actual update flow	2022-07-25 19:51:19 +09:00
Dean Herbert	2e14d8730c	Move implementation of updating a beatmap to BeatmapImporter	2022-07-25 19:51:19 +09:00
Dean Herbert	6a3e8e31de	Centralise calls to reset online info of a BeatmapInfo	2022-07-25 19:51:19 +09:00
Dean Herbert	ec477a3ebf	Add basic coverage of current behaviour of beatmap reimport	2022-07-25 19:51:19 +09:00
Salman Ahmed	1b6ebcfd87	Remove SubmittableScore and replace with SoloScoreInfo extension method	2022-07-25 13:43:43 +03:00
Salman Ahmed	d04df19c7e	Remove APIScore and replace its final usage	2022-07-25 13:13:46 +03:00
Dan Balasescu	068063a43a	Merge pull request #19371 from peppy/fix-working-cache-invalidation ... Fix calls to `GetWorkingBeatmap` invalidating cache too often	2022-07-25 18:29:46 +09:00
Dan Balasescu	1d48cee230	Merge pull request #19373 from peppy/fix-negative-star-rating-display ... Fix star ratings which are still being calculated showing as "-1" at song select	2022-07-25 18:20:30 +09:00
Salman Ahmed	bc2b629ee7	Let tests wait until track load before testing zoom	2022-07-25 12:07:50 +03:00
Salman Ahmed	123930306b	Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load	2022-07-25 12:07:50 +03:00
Salman Ahmed	93175eaf6e	Re-enable timeline zoom test and remove flaky attribute	2022-07-25 11:39:23 +03:00
Dean Herbert	6bf2645b1a	Fix StarRatingDisplay not handling negative numbers as "pending"	2022-07-25 15:44:54 +09:00
Salman Ahmed	6bdd1f43a2	Add visual test coverage	2022-07-25 09:40:20 +03:00
Dean Herbert	bbbc0a863f	Add test coverage of WorkingBeatmap retrieval from BeatmapManager	2022-07-25 15:30:49 +09:00
Salman Ahmed	7facd6d822	Merge branch 'master' into beatmap-overlay-null-pp	2022-07-25 07:38:59 +03:00
Salman Ahmed	6c95c49da3	Mark test score with null PP for visual testing	2022-07-25 07:31:52 +03:00
Dan Balasescu	0226b358ee	Disable timeline test for now	2022-07-25 13:20:33 +09:00
Dean Herbert	12e2e63a1c	Merge pull request #19349 from bdach/mod-overlay/presets-column ... Implement basic appearance of mod preset column	2022-07-25 13:10:47 +09:00
Salman Ahmed	fa9daa6899	Fix TestSceneReplayRecorder not using score provided by gameplay state	2022-07-25 05:21:27 +03:00
Salman Ahmed	feef16b09b	Add potentially failing test case	2022-07-25 04:18:30 +03:00
Bartłomiej Dach	6a67d76d7c	Add basic mod preset column implementation	2022-07-24 16:39:04 +02:00
Salman Ahmed	0c16ef3e2e	Add failing test case	2022-07-24 08:34:24 +03:00
solstice23	ea97122425	Separate positive and negative test cases	2022-07-23 21:47:51 +08:00
solstice23	63210d5662	Merge branch 'master' into search-filter	2022-07-23 18:13:53 +08:00
solstice23	3f2c341369	Simplify length parsing	2022-07-23 18:13:19 +08:00
Salman Ahmed	2829a7e836	Merge branch 'master' into beatmap-overlay-modded-stats	2022-07-23 10:38:13 +03:00
Salman Ahmed	c937c0548e	Add test coverage	2022-07-23 10:16:11 +03:00
Salman Ahmed	3aecd288e2	Enable NRT on TopLocalRank	2022-07-23 09:27:03 +03:00
Salman Ahmed	727fe76b60	Fix TopLocalRank hacking around presence to hide on null rank ... Fixed this here because that blocks `Schedule` from running, and I don't want to add another override to the `IsPresent` flag.	2022-07-23 09:22:22 +03:00
Salman Ahmed	1220250bb6	Improve test scene and add failing test case	2022-07-23 08:03:48 +03:00
Bartłomiej Dach	d0e15d04cc	Merge branch 'master' into mod-overlay/preset-panel	2022-07-22 19:23:09 +02:00
Dan Balasescu	d9105c9785	Merge pull request #19272 from peppy/beatmap-background-reprocessing ... Add background beatmap processing	2022-07-22 20:33:26 +09:00
Dean Herbert	63fe4f265f	Merge pull request #19263 from frenzibyte/fix-failed-score-statistics ... Populate failed scores with "miss" results for all remaining hitobjects	2022-07-22 20:16:16 +09:00
Dan Balasescu	6b69ff19c8	Remove unused using	2022-07-22 17:24:46 +09:00
Salman Ahmed	e5ab6652fd	Fix one more case of referencing old mod select overlay in tests	2022-07-22 11:12:24 +03:00
Dean Herbert	e20458421a	Update flaky timeline zoom test to output something useful	2022-07-22 16:05:20 +09:00
solstice23	7c222505e9	Simplify length parsing	2022-07-22 14:24:17 +08:00
solstice23	80e82763e3	Add negative test cases	2022-07-22 12:09:47 +08:00
Bartłomiej Dach	bdff7f1ef4	Implement basic appearance of mod preset panels	2022-07-21 23:29:21 +02:00
solstice23	de25830b2b	Add more test cases	2022-07-22 03:27:08 +08:00
solstice23	0dcb3644f5	Merge branch 'master' into search-filter	2022-07-22 01:32:25 +08:00
solstice23	52fad1e14d	Add test cases for search length criteria	2022-07-21 18:59:48 +08:00
Dean Herbert	1374738a0d	Add test coverage	2022-07-21 18:20:46 +09:00
Salman Ahmed	559254db31	Merge branch 'master' into fix-update-button-test-failure	2022-07-21 11:15:43 +03:00
Dan Balasescu	defadeef47	Merge pull request #19250 from peppy/fps-counter ... Add game-side FPS counter	2022-07-21 16:26:38 +09:00
Dean Herbert	fc0c9f76bd	Fix UpdateBeatmapSetButton intermittent test failure ... Carousel would only expire items when off-screen. This meant that for a case (like a test) where items are generally always on-screen, `UpdateBeatmapSet` calls would result in panels remaining hidden but not cleaned up.	2022-07-21 16:24:48 +09:00
Salman Ahmed	9df49db45f	Include bonus/ignore judgements in statistics fill logic	2022-07-21 08:13:09 +03:00
Salman Ahmed	5513a8b6b4	Fix changelog overlay tests failing due to missing CreatedAt date	2022-07-21 07:21:27 +03:00
Salman Ahmed	3c2a885872	Add test coverage	2022-07-21 06:01:48 +03:00
Dean Herbert	0c3d43026d	Add initial structure for fps counter	2022-07-20 23:49:19 +09:00
Dean Herbert	62133fa069	Merge pull request #19246 from frenzibyte/fix-wiki-navigation ... Fix wiki overlay not handling path redirection properly	2022-07-20 20:08:11 +09:00
Dan Balasescu	d2a3c2594d	Fix inspections	2022-07-20 16:33:52 +09:00
Dan Balasescu	f9c02c34b6	Merge branch 'master' into beatmap-update-online-flow	2022-07-20 15:15:51 +09:00
Salman Ahmed	e7f35701db	Add failing test case	2022-07-20 09:06:11 +03:00
Dean Herbert	af4d7feb9b	Merge pull request #19244 from frenzibyte/highlight-perfect-ticks ... Highlight perfect slider tick/end values in beatmap info leaderboards	2022-07-20 14:44:03 +09:00
Dan Balasescu	6c0d7f8099	Merge pull request #19235 from andy840119/remove-nullable-disable-in-the-mods ... Remove nullable disable annotation in the mods.	2022-07-20 14:39:32 +09:00
Dan Balasescu	ebb9861377	Merge branch 'master' into remove-nullable-disable-in-the-mods	2022-07-20 13:28:28 +09:00
Salman Ahmed	ae6aab2555	Merge branch 'master' into edit-map-carousel	2022-07-20 02:43:47 +03:00
Salman Ahmed	4d1f9a1329	Adjust test scene to cover slider ticks	2022-07-20 00:53:10 +03:00
為什麼	2a83404dbe	Use array.empty instead of null value.	2022-07-19 20:39:41 +08:00
為什麼	ee7e7f2d3a	Mark the property as non-nullable.	2022-07-19 20:39:41 +08:00
為什麼	d9addebc93	Remove the nullable disable annotation in the test project and fix the api broken.	2022-07-19 20:39:41 +08:00
Dean Herbert	6357223341	Fix incorrect DI fetch and apply nullability to ModelDownloader	2022-07-19 20:06:34 +09:00
Dean Herbert	17046b0553	Add basic handling of download failures	2022-07-19 19:01:23 +09:00
Dean Herbert	f6de76e057	Move test to stand-alone class and add full ui testing	2022-07-19 18:50:27 +09:00
Dean Herbert	eaf4f6dbb7	Add beatmap update button	2022-07-19 18:29:36 +09:00
Adam Baker	59018ab5ba	Fix multiplayer queue edit button opening to the wrong beatmap	2022-07-18 23:21:16 -05:00
Bartłomiej Dach	6f37487528	Replace calls to defective Humanizer methods with correct version	2022-07-18 22:34:58 +02:00
Bartłomiej Dach	ffa9a83a4f	Add own fixed copy of defective Humanizer methods	2022-07-18 21:37:31 +02:00
Dean Herbert	e14e2cca45	Merge pull request #19212 from peppy/fix-audio-equality-fuck ... Fix audio/background equality not correctly using `BeatmapInfo` local filenames	2022-07-18 19:28:51 +09:00
Dean Herbert	18da9ddfbf	Add test coverage of two beatmaps in same set with different audio files	2022-07-18 17:05:21 +09:00
Salman Ahmed	b5c7d07ba8	Merge branch 'master' into fix-user-profile-overlay	2022-07-18 10:27:33 +03:00
Dean Herbert	a7f19cc796	Merge pull request #19137 from frenzibyte/country-enum ... Replace `Country` class with enumeration	2022-07-18 16:12:24 +09:00
Salman Ahmed	018da74fe8	Replace default with CountryCode.Unknown	2022-07-18 08:54:35 +03:00
Salman Ahmed	cf99849478	CountryCode.XX -> CountryCode.Unknown	2022-07-18 08:45:54 +03:00
Salman Ahmed	100c53f9ef	Country -> CountryCode	2022-07-18 08:40:34 +03:00
tsunyoku	d1c60b5741	correct assertion logic	2022-07-17 23:53:35 +01:00
tsunyoku	d17acd0f45	add message to Assert.That	2022-07-17 23:16:27 +01:00
tsunyoku	92513dc936	reverse IsInstanceOfType logic	2022-07-17 22:49:09 +01:00
tsunyoku	0c50931d2f	change method of finding incompatibleMod	2022-07-17 22:10:35 +01:00
tsunyoku	dcce14ae8f	rename NoConflictingModAcronyms to ModValidity, add test for two-way mod incompatibility	2022-07-17 21:15:29 +01:00
tsunyoku	14ae183c70	update tests to match SoloScoreInfo	2022-07-17 14:22:46 +01:00
tsunyoku	71a4b8843f	update tests to new profile score format	2022-07-17 14:08:44 +01:00
Dean Herbert	acd5254f51	Add test coverage ensuring unique acronyms	2022-07-16 17:19:55 +09:00
Salman Ahmed	e62049f4a9	Update various usages of Country inline with new enum	2022-07-16 05:04:24 +03:00
Salman Ahmed	68afb65aff	Move default state steps to SetUp rather than duplicating per test case	2022-07-15 22:10:21 +03:00
Salman Ahmed	8f7b3cf11a	Merge branch 'master' into Save-Score-Failed	2022-07-15 22:10:19 +03:00
Dean Herbert	21433d4ecb	Add test coverage of saving a failed score	2022-07-15 20:14:58 +09:00
Dean Herbert	4b253f83c3	Fix intermittent test failures due to randomised score statistics	2022-07-15 17:39:08 +09:00
Dan Balasescu	c1dd1cfead	Merge pull request #19082 from peppy/api-solo-score-model ... Add and consume `SoloScoreInfo`	2022-07-15 15:20:18 +09:00
Salman Ahmed	0bafafd63b	Remove unnecessary test coverage ... RIP hours.	2022-07-15 03:20:52 +03:00
Salman Ahmed	be69514002	Fix CollectionManager opening file multiple times across test scene	2022-07-14 06:21:23 +03:00
Salman Ahmed	cb2f0b8c67	Add test coverage for collection items	2022-07-14 03:42:03 +03:00
Salman Ahmed	9ec4fbb86d	Add test coverage for details item	2022-07-14 03:41:47 +03:00
Salman Ahmed	099a7e90d6	Centralise creation of playlist in test scene	2022-07-14 02:19:30 +03:00
Salman Ahmed	102d0415f1	Merge branch 'master' into drawable-playlist-item-collection	2022-07-14 00:10:49 +03:00
Dan Balasescu	7ed05277f8	Merge pull request #19098 from peppy/last-played ... Add "last played" sort mode to song select	2022-07-13 22:44:50 +09:00
Dean Herbert	2e86e7ccee	Add extra steps to TestExitWithoutSave to guarantee track type	2022-07-13 19:41:46 +09:00
Dean Herbert	c6b6f41b71	Add test coverage of AudioEquals	2022-07-13 19:41:38 +09:00
Dean Herbert	4b96d74b0c	Add test coverage of LastPlayed updating	2022-07-13 16:43:43 +09:00
Dan Balasescu	363e23c251	Use correct HitResult in test	2022-07-12 18:47:44 +09:00
Dean Herbert	0fe3bac173	Store mods to array and update test scenes	2022-07-12 18:00:25 +09:00
Dean Herbert	779d512b44	Merge branch 'master' into mod-icon-colors	2022-07-12 14:36:55 +09:00
Dean Herbert	90fecbc9c7	Add test showing all mod icons for reference	2022-07-12 14:32:39 +09:00
Dean Herbert	aac3c166de	Merge pull request #19038 from novialriptide/replay-user-bug-fix ... Populate user ID for locally imported scores	2022-07-12 13:55:11 +09:00
Dan Balasescu	3ca10ac02c	Merge pull request #19063 from Joehuu/fix-samples-cancel-exit ... Fix editor playing object samples while paused after cancelling exit	2022-07-12 12:51:27 +09:00
為什麼	079fcf13a6	Add missing import.	2022-07-12 09:41:03 +08:00
andy	3dbd0c9055	Update osu.Game.Tests/Visual/Editing/TimelineTestScene.cs ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-07-12 09:37:16 +08:00
Bartłomiej Dach	cca208b3c7	Merge branch 'master' into replay-user-bug-fix	2022-07-11 21:51:09 +02:00
Salman Ahmed	09bfca4e4a	Fix build failing on tests	2022-07-11 21:45:39 +03:00
Salman Ahmed	84002aefae	Update file/directory selector tests to use ThemeComparisonTestScene	2022-07-11 20:18:50 +03:00
Dean Herbert	44d2e001ed	Update various dependencies	2022-07-11 20:16:49 +09:00
Joseph Madamba	6220650ea3	Fix dialog overlay not loading in time for headless test	2022-07-11 02:29:56 -07:00
Dean Herbert	958c0fb390	Remove Appveyor.TestLogger	2022-07-11 15:01:16 +09:00
為什麼	8e1ed1c621	Mark CreateHitObjectComposer() accept null. ... And add the null check in the test case.	2022-07-10 10:15:27 +08:00
Joseph Madamba	5fcc4bf713	Add failing sample playback disabled check	2022-07-09 12:10:18 -07:00
Salman Ahmed	667b1d795d	Ensure score has custom ruleset	2022-07-08 19:15:03 +03:00
Salman Ahmed	8c7aabccb0	Fix custom legacy ID in test scene not overriding base value	2022-07-08 19:01:21 +03:00
Dean Herbert	ac3cdf103a	Fix test not failing against master	2022-07-08 19:17:51 +09:00
Dean Herbert	5651eca06c	Merge branch 'master' into custom-ruleset-score-import	2022-07-08 19:03:47 +09:00
Dean Herbert	3c8f06403c	Make test work properly	2022-07-08 19:03:26 +09:00
Dan Balasescu	26d88aa326	Fix intermittent MusicController tests	2022-07-08 14:29:15 +09:00
Dan Balasescu	0bc332e90b	Merge pull request #19029 from peppy/fix-skin-import-duplicate ... Fix skins potentially being duplicated on batch import	2022-07-08 14:18:14 +09:00
Salman Ahmed	67fa15f231	Remove no longer required context menu container in ParticipantsList	2022-07-08 01:42:55 +03:00
Dean Herbert	c53dd4a703	Fix editor saving not updating BeatmapSetInfo's hash	2022-07-08 02:33:14 +09:00
Salman Ahmed	cd4755fbd9	Add test coverage for batch-import path	2022-07-07 18:06:35 +03:00
Dan Balasescu	f109e510ce	Merge branch 'master' into metadata-client	2022-07-07 19:45:52 +09:00
Dan Balasescu	7086779cf4	Merge pull request #19026 from peppy/async-track-operations ... Use fire-and-forget async operations on global track	2022-07-07 19:45:03 +09:00
Dean Herbert	bf10f2db2e	Add test coverage of nested rollback for good measure	2022-07-07 18:19:01 +09:00
Dean Herbert	ac216d94a8	Fix transaction not being disposed	2022-07-07 18:15:38 +09:00
Dean Herbert	dd5b127fb5	Update various tests to enable NRT to avoid new inspection failures	2022-07-07 17:51:49 +09:00
Dean Herbert	57b2f8189c	Add back test workaround for TestScenePlayerScoreSubmission with updated explanation ... This reverts commit f88e2aa025.	2022-07-07 17:42:03 +09:00
Dean Herbert	79bed0abdf	Merge branch 'realm-nested-writes' into metadata-client	2022-07-07 17:37:06 +09:00
Dean Herbert	5197d0fa9e	Add automatic transaction handling to realm helper methods	2022-07-07 17:36:25 +09:00
Dean Herbert	b663986b9f	Add test coverage of locally available without replay button handling	2022-07-07 17:04:04 +09:00
Dean Herbert	461d133c1f	Add test coverage of score importing	2022-07-07 16:43:31 +09:00
Dean Herbert	f88e2aa025	Remove EF test workaround	2022-07-07 15:02:03 +09:00
Salman Ahmed	a5b01b8920	Improve asserts in TestSeekPerformsInGameplayTime to be more descriptive	2022-07-07 01:00:55 +03:00
Dean Herbert	7053a8507b	Merge pull request #18993 from Joehuu/fix-personal-best-delete-context-menu ... Fix personal best score showing delete option on context menu	2022-07-06 14:53:35 +09:00
Dean Herbert	59d0bac728	Hook up update flow to metadata stream	2022-07-05 21:32:00 +09:00
Joseph Madamba	f1b55d743c	Fix delete local score test having no files	2022-07-04 11:04:20 -07:00
Dean Herbert	64edc6888d	Add test coverage of corrupt realm creating backup	2022-07-04 16:45:23 +09:00
Dan Balasescu	65917fbb99	Merge pull request #18990 from andy840119/remove-nullable-disable-in-the-ruleset-filter ... Remove nullable disable annotation in the ruleset filter.	2022-07-04 13:46:31 +09:00
andy840119	14ef771290	Remove the nullable disable annotation in the test case.	2022-07-03 21:05:14 +08:00
Dan Balasescu	9bf91835b6	Merge pull request #18962 from peppy/slider-range-control ... Move star difficulty filter to song select	2022-07-03 21:58:00 +09:00
Dan Balasescu	385bd5a1b2	Merge pull request #18965 from peppy/mark-flaky-tests ... Mark, document and silence remaining flaky tests on standard CI runs	2022-07-03 21:41:14 +09:00
Dan Balasescu	724fd19038	Remove nullable disables	2022-07-03 21:15:13 +09:00
Dan Balasescu	982bcc4500	Merge pull request #18981 from peppy/fix-beatmap-info-wedge-test ... Fix `BeatmapInfoWedge` test potentially failing due to quick initial load	2022-07-03 13:10:16 +09:00
Salman Ahmed	9b833524c0	Merge branch 'master' into add-realm-blocking-logging	2022-07-02 12:41:36 +03:00
Salman Ahmed	f09c46238d	Merge branch 'master' into fix-channel-id-clash	2022-07-02 10:21:47 +03:00
Dean Herbert	2cc9c579d4	Merge pull request #18969 from smoogipoo/fix-multiplayer-cross-pollution ... Fix cross-pollution of server- and client-side multiplayer objects in tests	2022-07-02 13:18:35 +09:00
Dean Herbert	2352636bf2	Fix ID clash with announce and PM channels in chat overlay tests ... Yet Another Issue. https://github.com/ppy/osu/runs/7159306924?check_suite_focus=true Not sure why announce channel was using a user id for its channel ID. Bad copy paste?	2022-07-02 13:11:50 +09:00
Dean Herbert	1a14808c39	Fix BeatmapInfoWedge test potentially failing due to quick initial load ... Was doing a comparison of previous vs new content after explicitly doing a load in a previous step.	2022-07-02 13:03:14 +09:00
Dean Herbert	4fd47b5fa0	Add more verbose logging to realm blocking process	2022-07-02 12:36:56 +09:00
Dan Balasescu	6644f9a72a	Fix completely incorrect test	2022-07-01 21:14:06 +09:00
Dan Balasescu	3b1842a2c2	Merge pull request #18835 from peppy/beatmap-update-flow ... Split out beatmap update tasks to `BeatmapUpdater` and invoke from editor save flow	2022-07-01 20:28:04 +09:00
Dan Balasescu	93c68e4329	More test hardening around ClientAPIRoom usages	2022-07-01 19:49:27 +09:00
Dean Herbert	6baccad058	Merge pull request #18821 from ggliv/locked-room-filter ... Add room access type filter to multiplayer lounge screen	2022-07-01 19:37:43 +09:00
Dan Balasescu	b64c0d011c	Isolate client's Room from TestMultiplayerClient	2022-07-01 19:23:25 +09:00
Dan Balasescu	0be858b5bf	Rename APIRoom -> ClientAPIRoom, remove unused asserts	2022-07-01 19:21:59 +09:00
Dean Herbert	b829884861	Merge pull request #18963 from peppy/more-placeholder-suggestions ... Add difficulty filter reset to song select "no results" suggestions	2022-07-01 17:55:23 +09:00
Dean Herbert	e213c1a4ef	Rename enum to explicitly mention it is a filter	2022-07-01 17:27:03 +09:00
Dean Herbert	9911c6cbf0	Merge branch 'master' into locked-room-filter	2022-07-01 17:17:01 +09:00
Dean Herbert	0e1f08eff8	Fix regressing BeatmapRecommendations tests due to diffcalc running at	2022-07-01 17:10:15 +09:00
Dean Herbert	17ad6648d1	Fix new test failing on headless runs	2022-07-01 17:07:00 +09:00
Dean Herbert	8f8c2a8c9a	Remove one flaky test description (fixed via #18966)	2022-07-01 16:55:47 +09:00
Salman Ahmed	3bca439c4f	Merge branch 'master' into more-placeholder-suggestions	2022-07-01 10:52:32 +03:00
Dan Balasescu	58c9bb031f	Apply PR reviews/fixes	2022-07-01 16:51:15 +09:00
Dan Balasescu	c22e77e481	Fix test sometimes referencing old ModSelect object	2022-07-01 16:46:27 +09:00
Dean Herbert	b597843579	Mark and document remaining flaky tests	2022-07-01 16:17:40 +09:00
Dan Balasescu	409224560f	Merge pull request #18874 from peppy/realm-fix-async-write-after-disposal ... Ensure all async writes are completed before realm is disposed	2022-07-01 15:29:01 +09:00
Dean Herbert	3e0f4e7609	Add test coverage of difficulty filter reset	2022-07-01 15:28:55 +09:00
Dean Herbert	32139ac13f	Tidy up implementation and add basic visual test	2022-07-01 15:16:58 +09:00
andy840119	d94f700ab1	Remove the nullable disable annotate in the test project.	2022-06-30 23:06:49 +08:00
Dean Herbert	447b496eff	Merge branch 'master' into realm-fix-async-write-after-disposal	2022-06-30 19:07:15 +09:00
Dean Herbert	84ecd524c8	Move wait steps upwards	2022-06-30 17:58:43 +09:00
Dean Herbert	7ab8335935	Fix various multiplayer test failures due to not waiting for ongoing operation ... As seen at https://teamcity.ppy.sh/buildConfiguration/Osu_Build/1138?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildTestsSection=true.	2022-06-30 17:42:45 +09:00
Dan Balasescu	5a346edc63	Merge pull request #18951 from peppy/fix-realm-missing-transaction-rollback ... Fix `PerformWrite` not rolling back transaction on exception	2022-06-30 17:17:56 +09:00
Dean Herbert	98938821e5	Merge branch 'master' into beatmap-update-flow	2022-06-30 16:44:17 +09:00
Dean Herbert	10934450cc	Fix directory cleanup occurring too early during realm tests	2022-06-30 16:02:46 +09:00
Dean Herbert	0abb400f64	Add reproduction of transaction not being exited correctly	2022-06-30 15:15:09 +09:00
Dan Balasescu	c5d31f50cd	Attempt to fix flaky TestSceneAutoplay test	2022-06-30 11:38:51 +09:00
Dean Herbert	165af8392f	Merge pull request #18944 from bdach/editor-navigation-test-again-again	2022-06-30 10:37:56 +09:00
Bartłomiej Dach	8171deec49	Attempt to fix editor navigation test failures again ... First of all, stop relying that `InputManager` will successfully press the gameplay test button, because it won't if it's obscured by the notification overlay. Closing the overlay in a loop doesn't work because there's a chance that a notification is posted, then all overlays are closed, then another notification is posted, and so the button still isn't clickable. Instead, use the `TestGameplay()` method directly. Secondly, the notifications will still block `EditorPlayerLoader` from transitioning to `EditorPlayer`. Here we have no other choice than to aggressively dismiss notifications every spin of the relevant until step and hope we eventually progress to `EditorPlayer`.	2022-06-29 22:45:56 +02:00
Bartłomiej Dach	381deaf62d	Merge branch 'master' into fix-flaky-placeholder-test	2022-06-29 22:31:45 +02:00
Dean Herbert	46cbbf5c6e	Fix flaky song select placeholder test by changing ruleset post-display ... Was failing occasionally due to the beatmap present operation causing the test's ruleset change to undo. ```csharp TearDown : System.TimeoutException : "wait for placeholder visible" timed out --TearDown at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0() at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered) at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition) --- End of stack trace from previous location --- at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test) at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /opt/buildagent/work/ecd860037212ac52/osu.Game/Tests/Visual/OsuTestScene.cs:line 503 at osu.Framework.Testing.TestScene.RunTestsFromNUnit() ------- Stdout: ------- [runtime] 2022-06-29 10:36:45 [verbose]: 💨 Class: TestScenePlaySongSelect [runtime] 2022-06-29 10:36:45 [verbose]: 🔶 Test: TestPlaceholderConvertSetting [runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #1 exit all screens [runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #2 reset defaults [runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #3 delete all beatmaps [runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #4 change ruleset to 2 [runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #5 import test map for ruleset 0 [database] 2022-06-29 10:36:45 [verbose]: [efc1a] Beginning import from unknown... [database] 2022-06-29 10:36:45 [verbose]: [efc1a] Import successfully completed! [runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #6 wait for imported to arrive in carousel [runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #7 change convert setting [runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #8 create song select [runtime] 2022-06-29 10:36:45 [verbose]: ScreenTestScene screen changed → TestScenePlaySongSelect+TestSongSelect [runtime] 2022-06-29 10:36:45 [verbose]: 📺 ScreenTestScene(OsuScreenStack)#338(depth:1) loading TestScenePlaySongSelect+TestSongSelect#263 [runtime] 2022-06-29 10:36:45 [verbose]: decoupled ruleset transferred ("" -> "osu!catch") [runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #9 wait for present [runtime] 2022-06-29 10:36:45 [verbose]: 📺 ScreenTestScene(OsuScreenStack)#338(depth:1) entered TestScenePlaySongSelect+TestSongSelect#263 [runtime] 2022-06-29 10:36:45 [verbose]: 📺 BackgroundScreenStack#328(depth:1) loading BackgroundScreenBeatmap#338 [runtime] 2022-06-29 10:36:45 [verbose]: 📺 BackgroundScreenStack#328(depth:1) entered BackgroundScreenBeatmap#338 [runtime] 2022-06-29 10:36:45 [verbose]: Song select updating selection with beatmap:null ruleset:fruits [runtime] 2022-06-29 10:36:45 [verbose]: Song select changing beatmap from "please load a beatmap! - no beatmaps available!" to "null" [runtime] 2022-06-29 10:36:45 [verbose]: Song select working beatmap updated to Some Artist 0 - Some Song (set id 6224) ece7b702-895c-4f15-892f-05e4ff5e9a24 (Some Guy 3) [Normal 6224000 (length 0:50, bpm 106.7)] [runtime] 2022-06-29 10:36:45 [verbose]: Song select updating selection with beatmap:null ruleset:osu [runtime] 2022-06-29 10:36:45 [verbose]: decoupled ruleset transferred ("osu!catch" -> "osu!") [runtime] 2022-06-29 10:36:45 [verbose]: Song select updating selection with beatmap:74232aa2-2a1f-4920-b643-e85976838251 ruleset:osu [runtime] 2022-06-29 10:36:45 [verbose]: Song select decided to ensurePlayingSelected [runtime] 2022-06-29 10:36:45 [verbose]: Game-wide working beatmap updated to Some Artist 0 - Some Song (set id 6224) ece7b702-895c-4f15-892f-05e4ff5e9a24 (Some Guy 3) [Normal 6224000 (length 0:50, bpm 106.7)] [runtime] 2022-06-29 10:36:45 [debug]: Focus changed from nothing to SeekLimitedSearchTextBox. [network] 2022-06-29 10:36:45 [verbose]: Failing request osu.Game.Online.API.Requests.GetBeatmapRequest (System.InvalidOperationException: DummyAPIAccess cannot process this request.) [runtime] 2022-06-29 10:36:45 [verbose]: ✔️ 16 repetitions [runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #10 wait for carousel loaded [runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #11 wait for placeholder visible [runtime] 2022-06-29 10:36:55 [verbose]: 💥 Failed (on attempt 1,459) [runtime] 2022-06-29 10:36:55 [verbose]: ⏳ Currently loading components (0) [runtime] 2022-06-29 10:36:55 [verbose]: 🧵 Task schedulers [runtime] 2022-06-29 10:36:55 [verbose]: LoadComponentsAsync (standard) concurrency:4 running:0 pending:0 [runtime] 2022-06-29 10:36:55 [verbose]: LoadComponentsAsync (long load) concurrency:4 running:0 pending:0 [runtime] 2022-06-29 10:36:55 [verbose]: 🎱 Thread pool [runtime] 2022-06-29 10:36:55 [verbose]: worker: min 1 max 32,767 available 32,766 [runtime] 2022-06-29 10:36:55 [verbose]: completion: min 1 max 1,000 available 1,000 [runtime] 2022-06-29 10:36:55 [debug]: Focus on "SeekLimitedSearchTextBox" no longer valid as a result of unfocusIfNoLongerValid. [runtime] 2022-06-29 10:36:55 [debug]: Focus changed from SeekLimitedSearchTextBox to nothing. ```	2022-06-30 04:45:04 +09:00
Dean Herbert	13108155d3	Fix crash on visual esting TestSceneChatOverlay due to null user	2022-06-30 03:43:56 +09:00
Dean Herbert	a3b4a515fc	Merge branch 'master' into realm-fix-async-write-after-disposal	2022-06-29 22:39:05 +09:00
Joseph Madamba	36e71d39f2	Fix one more mod settings test	2022-06-28 09:54:18 -07:00
Joseph Madamba	d07c2a64b9	Remove unused using	2022-06-28 08:39:09 -07:00
Joseph Madamba	f07107aba9	Fix failing diff adjust slider tests	2022-06-28 08:38:15 -07:00
Dean Herbert	ed1b809f54	Add missing request handling to actually join PM channels	2022-06-28 18:11:37 +09:00
Dean Herbert	21d31ee218	Ensure joined channels are actually joined to avoid unexpected tab order	2022-06-28 18:11:37 +09:00
Dean Herbert	d64959ad0c	Add test coverage of async writes during a blocking operation	2022-06-28 17:07:49 +09:00
Dan Balasescu	d630b62cfc	Merge pull request #18915 from peppy/slider-snaking-test-refactoring ... Apply various refactorings to `TestSceneSliderSnaking`	2022-06-28 16:16:35 +09:00
Dan Balasescu	8e4a6c43b5	Merge pull request #18914 from peppy/spectator-playback-test-leniences ... Increase leniences on `TestSceneSpectatorPlayback.TestWithSendFailure`	2022-06-28 16:15:51 +09:00
Dean Herbert	35745c83b7	Replace dodgy SetUpSteps overriding with usage of HasCustomSteps	2022-06-28 15:19:02 +09:00
Dean Herbert	a2701a3205	Increase leaniences on TestSceneSpectatorPlayback.TestWithSendFailure ... Not really sure how to improve this further, but should help with cases like this: ```csharp [runtime] 2022-06-28 05:32:06 [verbose]: 💨 Class: TestSceneSpectatorPlayback [runtime] 2022-06-28 05:32:06 [verbose]: 🔶 Test: TestWithSendFailure [runtime] 2022-06-28 05:32:06 [verbose]: 🔸 Step #1 Setup containers [runtime] 2022-06-28 05:32:06 [verbose]: Received 1 new frames (total 1 of 2) [runtime] 2022-06-28 05:32:06 [verbose]: 🔸 Step #2 received frames [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 7 of 8) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 13 of 19) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 19 of 29) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 25 of 44) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 31 of 45) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 37 of 59) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 43 of 67) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 49 of 125) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 55 of 126) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 61 of 127) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 67 of 128) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 73 of 129) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 79 of 130) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 85 of 131) [runtime] 2022-06-28 05:32:06 [verbose]: ✔️ 22 repetitions [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 91 of 132) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 97 of 133) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 103 of 134) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 109 of 135) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 115 of 136) [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 121 of 137) [runtime] 2022-06-28 05:32:06 [verbose]: 🔸 Step #3 start failing sends [runtime] 2022-06-28 05:32:06 [verbose]: Received 6 new frames (total 127 of 138) [runtime] 2022-06-28 05:32:06 [verbose]: 🔸 Step #4 wait for send attempts [runtime] 2022-06-28 05:32:06 [verbose]: 🔸 Step #5 frames did not increase [runtime] 2022-06-28 05:32:06 [verbose]: 💥 Failed [runtime] 2022-06-28 05:32:06 [verbose]: ⏳ Currently loading components (0) [runtime] 2022-06-28 05:32:06 [verbose]: 🧵 Task schedulers [runtime] 2022-06-28 05:32:06 [verbose]: LoadComponentsAsync (standard) concurrency:4 running:0 pending:0 [runtime] 2022-06-28 05:32:06 [verbose]: LoadComponentsAsync (long load) concurrency:4 running:0 pending:0 [runtime] 2022-06-28 05:32:06 [verbose]: 🎱 Thread pool [runtime] 2022-06-28 05:32:06 [verbose]: worker: min 1 max 32,767 available 32,766 [runtime] 2022-06-28 05:32:06 [verbose]: completion: min 1 max 1,000 available 1,000 [runtime] 2022-06-28 05:32:06 [verbose]: Host execution state changed to Stopping ``` https://teamcity.ppy.sh/buildConfiguration/Osu_Build/811?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildTestsSection=true	2022-06-28 14:58:34 +09:00
Dean Herbert	c1075d113f	Add logging around current channel changes and join requests ... Tracking down a flaky test (https://teamcity.ppy.sh/buildConfiguration/Osu_Build/553?hideProblemsFromDependencies=false&expandBuildTestsSection=true&hideTestsFromDependencies=false): ```csharp TearDown : System.TimeoutException : "PM Channel 1 displayed" timed out --TearDown at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0() at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered) at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition) --- End of stack trace from previous location --- at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test) at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /opt/buildagent/work/ecd860037212ac52/osu.Game/Tests/Visual/OsuTestScene.cs:line 503 at osu.Framework.Testing.TestScene.RunTestsFromNUnit() ------- Stdout: ------- [runtime] 2022-06-27 23:18:55 [verbose]: 💨 Class: TestSceneChatOverlay [runtime] 2022-06-27 23:18:55 [verbose]: 🔶 Test: TestKeyboardNextChannel [runtime] 2022-06-27 23:18:55 [verbose]: Chat is now polling every 60000 ms [runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #1 Setup request handler [runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #2 Add test channels [runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #3 Show overlay with channels [runtime] 2022-06-27 23:18:55 [verbose]: Unhandled Request Type: osu.Game.Online.API.Requests.CreateChannelRequest [network] 2022-06-27 23:18:55 [verbose]: Failing request osu.Game.Online.API.Requests.CreateChannelRequest (System.InvalidOperationException: DummyAPIAccess cannot process this request.) [runtime] 2022-06-27 23:18:55 [verbose]: Unhandled Request Type: osu.Game.Online.API.Requests.CreateChannelRequest [network] 2022-06-27 23:18:55 [verbose]: Failing request osu.Game.Online.API.Requests.CreateChannelRequest (System.InvalidOperationException: DummyAPIAccess cannot process this request.) [runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #4 Select channel 1 [runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #5 Channel 1 is visible [runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #6 Press document next keys [runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #7 Channel 2 is visible [runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #8 Press document next keys [runtime] 2022-06-27 23:18:55 [verbose]: 🔸 Step #9 PM Channel 1 displayed [network] 2022-06-27 23:18:55 [verbose]: Request to https://a.ppy.sh/587 failed with System.Net.WebException: NotFound. [network] 2022-06-27 23:18:55 [verbose]: Request to https://a.ppy.sh/503 failed with System.Net.WebException: NotFound. [runtime] 2022-06-27 23:19:05 [verbose]: 💥 Failed (on attempt 5,550) [runtime] 2022-06-27 23:19:05 [verbose]: ⏳ Currently loading components (0) [runtime] 2022-06-27 23:19:05 [verbose]: 🧵 Task schedulers [runtime] 2022-06-27 23:19:05 [verbose]: LoadComponentsAsync (standard) concurrency:4 running:0 pending:0 [runtime] 2022-06-27 23:19:05 [verbose]: LoadComponentsAsync (long load) concurrency:4 running:0 pending:0 [runtime] 2022-06-27 23:19:05 [verbose]: 🎱 Thread pool [runtime] 2022-06-27 23:19:05 [verbose]: worker: min 1 max 32,767 available 32,766 [runtime] 2022-06-27 23:19:05 [verbose]: completion: min 1 max 1,000 available 1,000 [runtime] 2022-06-27 23:19:05 [debug]: Focus on "ChatTextBox" no longer valid as a result of unfocusIfNoLongerValid. [runtime] 2022-06-27 23:19:05 [debug]: Focus changed from ChatTextBox to nothing. ``` This kind of logging should be helpful: ```csharp [runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #5 Channel 1 is visible [runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #6 Press document next keys [runtime] 2022-06-28 04:59:57 [verbose]: Current channel changed to #channel-2 [runtime] 2022-06-28 04:59:57 [debug]: Pressed (DocumentNext) handled by TestSceneChatOverlay+TestChatOverlay. [runtime] 2022-06-28 04:59:57 [debug]: KeyDownEvent(PageDown, False) handled by ManualInputManager+LocalPlatformActionContainer. [runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #7 Channel 2 is visible [runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #8 Press document next keys [runtime] 2022-06-28 04:59:57 [verbose]: Current channel changed to test user 685 [runtime] 2022-06-28 04:59:57 [debug]: Pressed (DocumentNext) handled by TestSceneChatOverlay+TestChatOverlay. [runtime] 2022-06-28 04:59:57 [debug]: KeyDownEvent(PageDown, False) handled by ManualInputManager+LocalPlatformActionContainer. [runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #9 PM Channel 1 displayed [runtime] 2022-06-28 04:59:57 [verbose]: 🔸 Step #10 Press document next keys [runtime] 2022-06-28 04:59:57 [verbose]: Current channel changed to test user 218 ```	2022-06-28 14:00:30 +09:00
Bartłomiej Dach	1a0228415d	Wait for and dismiss notification in editor navigation test	2022-06-27 22:29:47 +02:00
Dean Herbert	569fde4b47	Add messages to all InvalidOperationExceptions ... Without this, they can be very non-descript and hard to track down	2022-06-28 01:34:25 +09:00
Dan Balasescu	396e7fc166	Merge pull request #18862 from peppy/empty-beatmap-file-fix-2 ... Fix second case of empty beatmaps being reported to sentry as errors	2022-06-27 20:37:57 +09:00
Dean Herbert	f355c3a3c9	Merge pull request #18864 from peppy/fix-realm-audio-track-test-fail ... Centralise and harden editor-ready-for-use check	2022-06-27 19:42:49 +09:00
Dean Herbert	6203885040	Add test coverage of realm async writes	2022-06-27 19:38:14 +09:00
Dean Herbert	1fc4fa6820	Remove unnecessary Task.Run workaround in tests	2022-06-27 19:21:05 +09:00
Dan Balasescu	e131101708	Merge pull request #18866 from peppy/fix-storyboard-outro-skip-test-flaky ... Fix `TestStoryboardSkipOutro` occasionally failing due to strict timings	2022-06-27 18:33:02 +09:00
Dean Herbert	5af1106fa5	Remove unused using statement	2022-06-27 18:04:52 +09:00
Dean Herbert	401d9c1bae	Fix TestStoryboardSkipOutro occasionally failing due to strict timings	2022-06-27 17:13:46 +09:00
Dean Herbert	8c3c1f095e	Update rollback test expectations ... I can't find a better way to do this. It's very hard to trigger an actual failure in the import process these days. For now I've just made this work with the new assumptions. May be worth removing the test in the future if this ever backfires.	2022-06-27 17:04:35 +09:00
Dean Herbert	13dcaf82ad	Fix chat tests failing 1/10000 runs ... 31a447fda0/osu.Game/Online/Chat/ChannelManager.cs (L412-L414) Sigh.	2022-06-27 16:50:10 +09:00
Dean Herbert	5a7d339cc8	Centralise and harden editor-ready-for-use check ... Not only does this combine the check into one location, but it also adds a check on the global `WorkingBeatmap` being updated, which is the only way I can see the following failure happening: ```csharp 05:19:07 osu.Game.Tests: osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.TestAddAudioTrack 05:19:07 Failed TestAddAudioTrack [161 ms] 05:19:07 Error Message: 05:19:07 TearDown : System.NullReferenceException : Object reference not set to an instance of an object. 05:19:07 Stack Trace: 05:19:07 --TearDown 05:19:07 at osu.Game.Database.ModelManager`1.<>c__DisplayClass7_0.<AddFile>b__0(TModel managed) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36 05:19:07 at osu.Game.Database.ModelManager`1.<>c__DisplayClass8_0.<performFileOperation>b__0(Realm realm) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 49 05:19:07 at osu.Game.Database.RealmExtensions.Write(Realm realm, Action`1 function) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\RealmExtensions.cs:line 14 05:19:07 at osu.Game.Database.ModelManager`1.performFileOperation(TModel item, Action`1 operation) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 46 05:19:07 at osu.Game.Database.ModelManager`1.AddFile(TModel item, Stream contents, String filename) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36 05:19:07 at osu.Game.Screens.Edit.Setup.ResourcesSection.ChangeAudioTrack(FileInfo source) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Screens\Edit\Setup\ResourcesSection.cs:line 115 05:19:07 at osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.<TestAddAudioTrack>b__13_0() in C:\BuildAgent\work\ecd860037212ac52\osu.Game.Tests\Visual\Editing\TestSceneEditorBeatmapCreation.cs:line 101 05:19:07 at osu.Framework.Testing.Drawables.Steps.AssertButton.checkAssert() 05:19:07 at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered) 05:19:07 at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition) ```	2022-06-27 16:22:01 +09:00
Dean Herbert	b70b365411	Ensure files are cleaned up even on test step failure in TestAddAudioTrack	2022-06-27 15:53:05 +09:00
Dan Balasescu	05148d2b98	Merge pull request #18854 from peppy/fix-flaky-editor-navigation-test ... Attempt to fix flaky `EditorNavigation` test	2022-06-27 13:58:28 +09:00
Dean Herbert	b5a8889fb8	Attempt to fix flaky EditorNavigation test ... Conditionals taken from f8830c6850/osu.Game/Tests/Visual/EditorTestScene.cs (L61-L62) where it seemed to resolve other similar cases.	2022-06-27 03:04:50 +09:00
Dean Herbert	cd9eaf215b	Attempt to fix flaky PlaylistOverlay test	2022-06-27 02:58:01 +09:00
Dean Herbert	31a447fda0	Update parameter discards	2022-06-24 21:26:19 +09:00
Dean Herbert	30eebf3511	Merge branch 'master' into c-sharp-10	2022-06-24 21:22:33 +09:00
Dean Herbert	2c5e5fed6f	Add test coverage of star rating and difficulty updating on editor save	2022-06-24 21:02:38 +09:00
Dean Herbert	06d59b717c	Move beatmap processing tasks to new BeatmapUpdater class	2022-06-24 21:02:37 +09:00
Bartłomiej Dach	26c5b59f6d	Replace usages of string.To{Lower,Upper}()	2022-06-24 11:57:45 +02:00
Dan Balasescu	c7e92f46f4	Merge pull request #18819 from peppy/difficulty-icon-refactor-pass ... Refactor difficulty icons to not suck	2022-06-24 17:50:50 +09:00
Dean Herbert	8912f07745	Merge branch 'master' into difficulty-icon-refactor-pass	2022-06-24 16:34:35 +09:00
Dean Herbert	545c04aaf5	Fix dangerous File.Copy causing intermittent realm migration test failures ... Resolves an issue I've been able to locally reproduce on windows. Basically, the `File.Copy` would begin while realm was blocking. The "restore" operation is posted to the `SynchronizationContext` to run on next update call, but in the mean time the copy would begin, causing a conflict of interest. Very dangerous. Only really noticeable on windows.	2022-06-24 16:18:56 +09:00
Dean Herbert	f71f6302fd	Remove unnecessary null casts	2022-06-24 14:50:11 +09:00
Bartłomiej Dach	489ed5d34d	Rename test method	2022-06-23 18:04:38 +02:00
Gabe Livengood	454eff43c5	publicity -> accesstype	2022-06-23 11:40:25 -04:00
Gabe Livengood	9a15adbfff	add an all option to publicity filter	2022-06-23 11:24:28 -04:00
Gabe Livengood	2def6d809b	refactor to use enum dropdown	2022-06-23 11:02:27 -04:00
Dean Herbert	ef258122d2	Move GetDifficultyRating helper method to StarDifficulty	2022-06-23 19:51:58 +09:00
Dean Herbert	01da6f20b3	Tidy up all remaining usages	2022-06-23 19:27:35 +09:00
Dean Herbert	7ef8b7df5f	Add timeout for all ManualResetEventSlim.Wait invocations ... Timeout values were taken as best-guesses of upper values we'd expect from sane execution.	2022-06-23 14:46:00 +09:00
Gabe Livengood	a03cfbc2d4	add test coverage	2022-06-22 17:01:42 -04:00
Dean Herbert	97fcf8cec9	Merge pull request #18668 from smoogipoo/editor-controlpoint-undo-redo	2022-06-23 04:02:24 +09:00
Bartłomiej Dach	a9f6eb0293	Add test coverage for new intended behaviour of sequential hotkey style	2022-06-21 15:18:37 +02:00
Bartłomiej Dach	a996325e19	Add test coverage for filter handling in classic style	2022-06-21 15:00:39 +02:00
Bartłomiej Dach	da1814e7c3	Restructure everything to fix free mod overlay issue	2022-06-21 14:48:41 +02:00
Bartłomiej Dach	143c8e8da6	Add test scene for desired classic selection behaviour	2022-06-21 13:35:00 +02:00
Bartłomiej Dach	658f5341c7	Set up flow for switching between hotkey styles	2022-06-21 13:34:58 +02:00
Bartłomiej Dach	73124d2b1f	Encapsulate mod hotkey selection logic in strategy pattern	2022-06-21 12:49:01 +02:00
Dean Herbert	10efb4bc6c	Fix incorrect disposal in teardown steps	2022-06-21 14:08:30 +09:00
Bartłomiej Dach	21d60231b6	Add limited test coverage of osu:// scheme link IPC flow	2022-06-20 22:22:25 +02:00
Bartłomiej Dach	b0b3ea42cc	Remove null default value in ImportSkinTest helper method	2022-06-20 10:44:14 +02:00
Dan Balasescu	c402e90598	Merge pull request #18777 from peppy/output-directory-on-import-failure ... Silence exception and provide more log output when import fails due to empty `.osu` files	2022-06-20 17:36:21 +09:00
Dan Balasescu	e0c82d11ab	Convert == usages to ReferenceEquals	2022-06-20 16:56:19 +09:00
Dean Herbert	e82d948acc	Add test coverage of import throwing when no valid .osu files are found	2022-06-20 16:06:22 +09:00
Dean Herbert	92f1a2958c	Rename Import(TModel) to ImportModel to differentiate from other import methods	2022-06-20 15:18:07 +09:00
Dean Herbert	a6c8a832aa	Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask)	2022-06-20 15:14:57 +09:00
Dean Herbert	7daab2d45b	Merge branch 'master' into skin-editor-transform-fix	2022-06-20 14:10:01 +09:00
Dean Herbert	e4d0c7a0fb	Move beatmap import step to only be required when entering gameplay	2022-06-20 14:08:05 +09:00
Dean Herbert	329f1a0822	Add test coverage of original fail case and improve test reliability and code quality	2022-06-20 14:08:05 +09:00
Dean Herbert	243806e810	Move common step of toggling skin editor to own method	2022-06-20 13:32:44 +09:00
Gabe Livengood	2b0e82be40	add test coverage	2022-06-19 14:35:05 -04:00
Bartłomiej Dach	def87ed782	Add failing test for editor gameplay test using wrong ruleset	2022-06-19 19:28:35 +02:00
Salman Ahmed	47ce087694	Actually click the gameplay scene button than TriggerClick	2022-06-18 18:32:02 +03:00
Bartłomiej Dach	f6a3047596	Merge branch 'master' into editor-metadata-name-unification	2022-06-18 10:22:52 +02:00
Dan Balasescu	fd9902e816	Manual #nullable processing	2022-06-17 16:38:35 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Salman Ahmed	42378dbb88	Improve test coverage to ensure volume is unaffected when mouse is away	2022-06-16 20:22:57 +03:00
Salman Ahmed	47d0ecf5e8	Merge branch 'master' into editor-metadata-name-unification	2022-06-16 18:53:23 +03:00
Bartłomiej Dach	9c4f6d2ce0	Merge branch 'master' into first-run-setup-notification-interruption	2022-06-16 15:14:40 +02:00
Dean Herbert	f3984d98e6	Remove RealmArchiveModelManager from hierarchy	2022-06-16 18:53:13 +09:00
Dean Herbert	1f3e1b2d97	Combine BeatmapManager and BeatmapModelManager into one class	2022-06-16 18:07:04 +09:00
Dean Herbert	84dba36cf5	Update usages of BeatmapModelManager which only require importing to use BeatmapImporter	2022-06-16 17:59:24 +09:00
Salman Ahmed	2c35b1404b	Use FileInfo as current bindable type	2022-06-15 19:29:09 +03:00
Bartłomiej Dach	665ef5fdcc	Add test coverage for API-incompatible rulesets wrt mods	2022-06-15 17:31:46 +02:00
Bartłomiej Dach	0418d70056	Add test coverage for ignoring null mods returned by rulesets	2022-06-15 17:31:46 +02:00
Salman Ahmed	387c54c252	Ensure notification is displayed after first-run setup is hidden	2022-06-15 18:13:24 +03:00
Dean Herbert	f23ddfe6cc	Move remaining realm classes out of Stores namespace	2022-06-15 21:56:00 +09:00
Dean Herbert	584345a97e	Merge pull request #18693 from frenzibyte/toolbar-volume-control ... Add basic volume control support in toolbar music button	2022-06-15 17:50:10 +09:00
Dean Herbert	87bf53485a	Merge pull request #18649 from frenzibyte/selection-context-outside-bounds ... Fix context menus not appearing when clicking outside of editor playfield's bounds	2022-06-15 17:08:09 +09:00
Dean Herbert	080f2859ef	Merge pull request #18689 from peppy/quick-import-only-on-batch ... Always perform full consistency checks for single imports	2022-06-15 17:06:06 +09:00
Salman Ahmed	dfab8b71f6	Merge branch 'master' into stable-beatmap-recursive-import	2022-06-15 10:06:46 +03:00