39370 Commits

Author	SHA1	Message	Date
Dan Balasescu	7658536b5a	Fix CI issues	2023-05-23 19:32:19 +09:00
Dan Balasescu	fee3d43596	Merge branch 'master' into scorev2	2023-05-23 19:07:54 +09:00
Dean Herbert	02d8e3a11e	Mark FullscreenOverlay's shadow effect as Hollow to save on shader overhead	2023-05-23 18:50:14 +09:00
Dean Herbert	6f4e2b37ed	Add shadow to notifications and settings overlays to better distinguish from other overlays	2023-05-23 18:50:14 +09:00
Dan Balasescu	d45b54399b	Add back minimum/maximum accuracy	2023-05-23 18:15:32 +09:00
Dan Balasescu	3598ca9125	Adjust xmldoc	2023-05-23 18:05:10 +09:00
Dean Herbert	adf9a596b5	Fix weird state when attempting to enter gameplay skin editor scene from multiplayer ... Closes https://github.com/ppy/osu/issues/23626.	2023-05-23 17:58:44 +09:00
Dan Balasescu	8570f825ed	Consider all accuracy judgements in accuracy progress	2023-05-23 17:47:35 +09:00
Dan Balasescu	f8101fbbc7	Rename variables	2023-05-23 17:44:17 +09:00
Dean Herbert	ff5dde0ebe	Merge pull request #23575 from Joehuu/fix-inverted-video-only-check ... Fix old widescreen videos with black bars not correctly filling screen (again)	2023-05-23 16:47:52 +09:00
Dean Herbert	7c039b0b67	Merge pull request #23618 from bdach/fix-taiko-swells-drumrolls-silent ... Fix hitsounds not playing before and during taiko drum rolls and swells	2023-05-23 16:44:04 +09:00
Dan Balasescu	62d504af92	Fix base implementation of ComputeTotalScore	2023-05-23 15:59:24 +09:00
Dan Balasescu	e1feeded12	Change statistics type, remove overridability	2023-05-23 15:36:34 +09:00
Cootz	c3f06ad2db	Merge branch 'master' into add-mod-search-option	2023-05-23 08:55:57 +03:00
Bartłomiej Dach	38b4bd8aef	Fix undo not behaving as expected sometimes	2023-05-22 22:45:39 +02:00
Bartłomiej Dach	e0b7539c2a	Fix sample changes not being applied in patcher	2023-05-22 22:45:23 +02:00
Bartłomiej Dach	f253d17a7f	Fix slider velocity changes not being applied in patcher	2023-05-22 22:19:10 +02:00
Dean Herbert	7742904d2a	Merge pull request #23593 from Dimmitsaras/unfocused-notifications ... Always show chat message notifications if window is unfocused	2023-05-22 14:17:20 +09:00
Dean Herbert	09c66bea8f	Merge pull request #23606 from Joehuu/fix-news-sidebar-link-clicking-area ... Fix clicking area of news sidebar post links	2023-05-22 14:17:08 +09:00
Joseph Madamba	7392109bce	Apply same behavioral changes to NewsCard	2023-05-21 19:28:12 -07:00
Joseph Madamba	2279aad360	Apply NRT to NewsCard	2023-05-21 19:27:20 -07:00
Dean Herbert	b3527b92b6	Handle case in tests where current display becomes null	2023-05-22 09:25:44 +09:00
Bartłomiej Dach	19816ae013	Update framework	2023-05-21 20:38:27 +02:00
Bartłomiej Dach	6df1d29862	Merge branch 'master' into use-atomic-ReplaceRange	2023-05-21 20:32:59 +02:00
Joseph Madamba	88c112612f	Remove hardcoded website url ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-05-21 10:35:22 -07:00
Bartłomiej Dach	5229cf7343	Add failing test cases for drum roll/swell sample playback	2023-05-21 18:57:01 +02:00
timiimit	9d14ea9d27	Merge branch 'ppy:master' into update-multiplayer-room-diff-range	2023-05-21 16:37:00 +02:00
timiimit	4441718437	Merge branch 'ppy:master' into organize-room-pills	2023-05-21 16:36:53 +02:00
Cootz	67bf1b4dfe	Select/deselect first visible mod when GlobalAction.Select is triggered	2023-05-21 11:05:01 +03:00
Joseph Madamba	8aefb62532	Rename PostButton to PostLink	2023-05-20 16:38:56 -07:00
Joseph Madamba	ec5f0bbf42	Fix clicking area of news sidebar post links ... Side effect is that the hover color is yellow and pressing it opens an external dialog, but those are temporary (pending implementation of link underline to make `Light1` hover more readable and set at a higher level and news pages).	2023-05-20 16:32:04 -07:00
Bartłomiej Dach	de5917b645	Merge branch 'master' into unfocused-notifications	2023-05-20 19:32:52 +02:00
Bartłomiej Dach	a677d87d39	Touch up inline comments	2023-05-20 19:29:59 +02:00
Bartłomiej Dach	8e0a97ca49	Remove usage of HasSubmenu ... Property has been removed in the appropriate framework-side PR and instead folded into `IsActionable`. See: https://github.com/ppy/osu-framework/pull/5658#discussion_r1114834647	2023-05-20 18:02:12 +02:00
Bartłomiej Dach	67c044773b	Merge branch 'master' into fix-menu-state-display	2023-05-20 17:57:00 +02:00
Bartłomiej Dach	afdddb0195	Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes ... Fix timeline blueprint display not showing correct combo number / colour during placement	2023-05-20 15:02:55 +02:00
Bartłomiej Dach	0e11adaaac	Merge pull request #23564 from peppy/fix-missing-sample-additions ... Fix sample banks not transferring when adjusting via editor	2023-05-20 14:36:45 +02:00
Dan Balasescu	25d72d370e	Always add non-bonus change to combo portion	2023-05-20 00:24:43 +09:00
Dan Balasescu	30a296bd09	Rename parameters	2023-05-19 17:27:02 +09:00
Dan Balasescu	6c6f8621c1	Add score processor statistics to replay header	2023-05-19 16:29:24 +09:00
Dan Balasescu	d74bf2a096	Refactor for safety	2023-05-19 14:37:26 +09:00
Dan Balasescu	2ae34530f7	Avoid NaN values during ApplyBeatmap processing()	2023-05-19 14:14:34 +09:00
Dan Balasescu	7cbf48ffcf	Fix TestSceneScoring and incorrect combo calculations	2023-05-19 14:09:19 +09:00
Dan Balasescu	035d0d5c9c	Fix multiplayer leaderboard not working	2023-05-19 13:16:57 +09:00
Dan Balasescu	8b56a3f87d	Remove ClassicScoreMultiplier and DefaultScoreProcessor	2023-05-19 12:24:52 +09:00
Dan Balasescu	00e0411369	Fix/rework ModAccuracyChallenge calculation	2023-05-18 20:45:02 +09:00
Dan Balasescu	ef86be6d21	Fix base score added for non-accuracy-affecting objects	2023-05-18 20:32:50 +09:00
Dan Balasescu	c33e4fe75e	Remove unnecessary override	2023-05-18 20:10:28 +09:00
Dan Balasescu	808818768b	Add TotalScore to replay frame headers	2023-05-18 20:08:49 +09:00
Dan Balasescu	f3591f83a2	Remove ScoreManager.GetTotalScore()	2023-05-18 20:08:49 +09:00
Dan Balasescu	510b8e4c78	Remove ScoreManager.Mode, handle per-use	2023-05-18 20:08:49 +09:00
Dan Balasescu	829e47d30b	Add MaxTotalScore for performance breakdown calculator	2023-05-18 17:47:25 +09:00
Dan Balasescu	f2483a1cf8	Add some helper methods, fix precision differences ... Introduces some error at all times, but if we're to store scores everywhere as `long`, then the same precision should be applied to the "during gameplay" path as well.	2023-05-18 17:44:31 +09:00
Dean Herbert	ee522253cb	Remove a couple of unnecessary volume declarations	2023-05-18 14:12:57 +09:00
Bartłomiej Dach	9ca1c7f7b7	Merge pull request #23580 from peppy/fix-profile-button-depth ... Ensure scroll-to-top button is displayed above all overlay content	2023-05-17 21:23:46 +02:00
Dimmitsaras	7ac6688a0f	Chat message notifications always play on unfocused window	2023-05-17 18:34:39 +03:00
Dean Herbert	b58ab28765	Make EditorClock non-nullable in PlacementBlueprint	2023-05-17 21:40:52 +09:00
Dean Herbert	214d7e07fa	Add TODO regarding failing stack display code	2023-05-17 17:52:17 +09:00
Dean Herbert	0b25818bd2	Update combo information on placement blueprint	2023-05-17 17:26:19 +09:00
Dean Herbert	9563d4f730	Fix weird purple tint on placement object in timeline	2023-05-17 17:26:19 +09:00
Dean Herbert	8d925c8a8a	Move combo information updating to an interface level helper method	2023-05-17 17:26:19 +09:00
Dean Herbert	e43f2c2c43	Improve previous hitobject lookup efficient and correctness	2023-05-17 17:19:29 +09:00
Dean Herbert	7d7d402d4e	Apply NRT to PlacementBlueprint	2023-05-17 17:19:29 +09:00
Dean Herbert	87ff28b022	Update beat divisor control to show ticks in more visually correct locations ... As proposed in https://github.com/ppy/osu/discussions/23527.	2023-05-17 16:34:12 +09:00
Dean Herbert	730bc3a961	Apply NRT and simplify some remaining code	2023-05-17 16:18:13 +09:00
Dean Herbert	e97d027230	Make OnlinePlayPill class abstract	2023-05-17 16:13:03 +09:00
Dean Herbert	79e1d978e7	Ensure scroll-to-top button is displayed above all overlay content	2023-05-17 15:42:38 +09:00
Dean Herbert	764f0323f4	Show "rewind" text on random button when beginning a right mouse press	2023-05-17 14:51:40 +09:00
Dean Herbert	94b184712d	Fix random button hover state not correctly being reset on right click	2023-05-17 14:51:40 +09:00
Dean Herbert	dc421bd2af	Revert "Merge pull request #23570 from huoyaoyuan/inspect-code-cs11" ... This reverts commit ab2bd123e7, reversing changes made to 267e63320f.	2023-05-17 14:49:47 +09:00
Dean Herbert	510ebe1f23	Fix weird optional usage in HitSampleInfo.With	2023-05-17 14:11:52 +09:00
Dean Herbert	dc51d5ecf3	Rename GetSampleInfo to better describe what method does ... Also add full xmldoc	2023-05-17 14:07:48 +09:00
Dean Herbert	a8bc337006	Change default volume when constructing a HitSampleInfo to non-zero	2023-05-17 14:06:02 +09:00
Susko3	fec47fa690	Merge branch 'master' into use-atomic-ReplaceRange ... This reverts 0dcf1b540e	2023-05-17 06:56:54 +02:00
Joseph Madamba	d6fa44240d	Fix storyboard video-only check being inverted	2023-05-16 21:51:32 -07:00
John	e2633ae993	Removed unnecessary [Resolved] attribute (thanks bdach) ... Moved accent color assignment from OnUpdate to ApplyCustomUpdateState. In order to get this to work, a flag needed to be added to DrawableHitObject.cs to disable combo color updates also being applied.	2023-05-16 21:08:56 -07:00
Dean Herbert	0d3c64dc32	Merge pull request #23572 from bdach/avoid-display-settings-feedback ... Work around issues with bindable/event feedback in layout settings	2023-05-17 12:03:45 +09:00
Susko3	2d7fe68311	Prevent feedback by using atomic .ReplaceRange() ... `display.NewValue` will never be null, checked on SDL + osuTK/Android. On Android it's a 0x0 display, importantly not null.	2023-05-16 21:57:31 +02:00
Bartłomiej Dach	0dcf1b540e	Attempt to preserve old resolution when switching displays	2023-05-16 21:14:09 +02:00
Bartłomiej Dach	88ce627c8e	Avoid bindable/event feedback when changing resolution	2023-05-16 21:02:23 +02:00
Huo Yaoyuan	ddfdd712bd	Update InspectCode to 2022.3.3 and enable C# 11	2023-05-17 00:07:06 +08:00
Dean Herbert	d9ae822966	Fix bank not correctly being assigned when adding sample additions in editor	2023-05-16 18:52:52 +09:00
Dean Herbert	83dcd78826	Make HitSampleInfo.Bank non-nullable	2023-05-16 18:12:56 +09:00
timiimit	cc6e4df93e	Remove wrongly added back namepspace	2023-05-16 10:27:46 +02:00
timiimit	4ef74eb3f9	Fix RoomStatusPill text colour	2023-05-16 10:22:52 +02:00
timiimit	81b7737660	Fix text colour of RoomSpecialCategoryPill	2023-05-16 10:20:16 +02:00
timiimit	a9991d9dd4	Remove another unused namespace	2023-05-16 10:14:14 +02:00
timiimit	40daa41a52	Fix naming & namespaces	2023-05-16 10:06:48 +02:00
timiimit	04893064f0	Make used pills inherit from a common one	2023-05-16 09:53:11 +02:00
timiimit	10d6f9ea5a	Create common online play pill	2023-05-16 09:52:26 +02:00
timiimit	0fd718478a	Merge branch 'master' into update-multiplayer-room-diff-range	2023-05-15 07:36:43 +02:00
timiimit	83ceb3457f	Add xmldoc comment	2023-05-15 07:36:15 +02:00
timiimit	cb8d5f459f	Remove bad comment	2023-05-15 07:36:15 +02:00
Bartłomiej Dach	592fcafcd4	Merge pull request #23451 from timiimit/fix-default-progress-graph-flipping ... Fix default progress graph not updating after flip	2023-05-14 19:19:10 +02:00
Cootz	6647d95ea7	Kill search focus when clicking on ModColumn	2023-05-14 18:32:16 +03:00
timiimit	f7a2321175	Merge branch 'master' into update-multiplayer-room-diff-range	2023-05-14 12:28:58 +02:00
Bartłomiej Dach	cc2dfc8371	Merge branch 'master' into editor-slider-placement-tool-change	2023-05-14 12:26:37 +02:00
timiimit	86a834fb56	Fix TODO comment	2023-05-14 12:20:16 +02:00
timiimit	fd80ffd52b	Fix display update condition	2023-05-14 12:09:15 +02:00
timiimit	5d68701321	Copy StarRange when creating PlaylistItem	2023-05-14 12:08:37 +02:00
timiimit	f1f30b94a6	Add StarRating Property	2023-05-14 11:05:47 +02:00
Bartłomiej Dach	e6786e0244	Merge branch 'master' into editor-slider-placement-input	2023-05-14 10:52:22 +02:00
Bartłomiej Dach	325de2dc22	Merge pull request #23507 from peppy/editor-blueprint-end-placement ... Move blueprint validity conditions to allow more correct external usage of `EndPlacement`	2023-05-14 10:24:04 +02:00
Bartłomiej Dach	58410c6fc0	Merge pull request #23506 from peppy/tablet-settings-keywords ... Fix some tablet settings being hidden when searching using "area" keyword	2023-05-14 09:44:55 +02:00
Bartłomiej Dach	732bd7812b	Merge pull request #23529 from peppy/no-hold-during-gameplay ... Fix hold-for-right-click showing during gameplay	2023-05-13 15:33:13 +02:00
Dean Herbert	8c542c6c51	Fix hold-for-right-click showing during gameplay	2023-05-13 21:32:30 +09:00
Dean Herbert	2e6fd4b321	Update framework	2023-05-13 20:54:22 +09:00
timiimit	18efdb0e4c	Make layout readonly	2023-05-13 11:37:56 +02:00
timiimit	d81cdacb0d	Undo stupid changes	2023-05-13 11:28:05 +02:00
timiimit	4b544903cb	Optimize recalculateValues	2023-05-13 10:13:09 +02:00
timiimit	2cfc4eb515	Fix unconsidered height change	2023-05-13 10:12:46 +02:00
John	7a907f7207	Code quality improvements (thanks to ItsShamed): Removed #nullable disable, fixed incorrect LocalisableString, removed incorrect dependency injection for OsuColour, fixed nullable dependency for IBeatmap ... Removed unnecessary usage of "this." caught by the CI code quality check	2023-05-12 22:13:39 -07:00
John	e5884016ab	Initial commit for the snap colour mod. Implements basic functionality.	2023-05-12 19:07:25 -07:00
timiimit	80b6e014f1	More code style	2023-05-13 01:47:44 +02:00
timiimit	8cc0c5ad1c	Fix code style	2023-05-13 01:39:01 +02:00
timiimit	04f7def798	Remove useless comment	2023-05-13 01:31:12 +02:00
timiimit	21d7c62f30	Add optimized UpdateGraph	2023-05-13 01:29:11 +02:00
timiimit	159cacf9c7	Fix logic in recalculateValues()	2023-05-13 01:27:28 +02:00
timiimit	6180d0d620	Remove cached frame buffer	2023-05-12 15:00:46 +02:00
Dean Herbert	0c1959ef2f	Allow commiting / undoing placement of blueprints using back / select bindings	2023-05-12 16:06:20 +09:00
Dean Herbert	70e248b927	Force placement of in-progress object when changing tools in the editor	2023-05-12 16:06:01 +09:00
Dean Herbert	f443cfb93e	Move blueprint validity conditions to allow more correct external usage of EndPlacement ... Until now, these were haphazardly enforce inline in blueprint implementations. The only thing stopping complete breakage is that `EndPlacement` wasn't called (too much) from outside the blueprint, leaving them responsible for their own placement. By moving this conditional out of the provided paramters to `EndPlacement`, it allows more flexible usage of that method externally. Coming in a future PR.	2023-05-12 16:02:22 +09:00
Dean Herbert	c0f869e685	Fix some tablet settings being hidden when searching using "area" keyword ... As discussed in https://github.com/ppy/osu/discussions/23504.	2023-05-12 14:57:56 +09:00
tsrk	2d45d602a5	feat(settings): more keyword for first run setup	2023-05-11 15:03:42 +01:00
tsrk	c1a85658b7	feat(settings): add "import" as keywords for first run setup	2023-05-11 14:58:17 +01:00
Cootz	ca68850730	fix formatting	2023-05-10 19:43:58 +03:00
Dean Herbert	3fc19553b4	Update resources	2023-05-10 15:19:46 +09:00
Dean Herbert	4aa241daea	Update framework	2023-05-10 15:19:43 +09:00
Cootz	2467813d81	Block deselect all short key when using the search box	2023-05-09 16:14:42 +03:00
Dean Herbert	bdf8a78b42	Add the ability to adjust the beatmap tick rate in the editor	2023-05-09 20:53:20 +09:00
Dean Herbert	ca5e8b290f	Add clamping to SliderMultiplier and SliderTickRate at parsing time	2023-05-09 20:53:20 +09:00
Dean Herbert	d10dd6d5ae	Merge branch 'master' into base-s-v	2023-05-09 20:52:11 +09:00
Dan Balasescu	a7b623f52a	Reimplement classic scoring mode	2023-05-09 20:21:38 +09:00
Dan Balasescu	3c3c812ed6	Initial implementation of ScoreV2	2023-05-09 19:33:33 +09:00
Dean Herbert	2085833a84	Fix missing delegate unsubscribe	2023-05-09 17:08:03 +09:00
Dean Herbert	944da06c10	Rename slider multiplier variable back for now	2023-05-09 16:58:19 +09:00
Bartłomiej Dach	1d162d1d15	Merge pull request #23440 from peppy/drawable-hit-object-sync-animations ... Fix hit object animations not being played back in sync	2023-05-08 23:44:37 +02:00
Bartłomiej Dach	30ce86a582	Merge pull request #23437 from peppy/fix-hold-note-input-test ... Fix `TestSceneHoldNoteInput` not displaying correctly	2023-05-08 22:22:33 +02:00
Bartłomiej Dach	2177dbf42a	Merge pull request #23436 from peppy/fix-wiki-error-return-to-main ... Fix "Return to main page" link not working on wiki after error	2023-05-08 21:56:29 +02:00
Dean Herbert	64498e95a4	Add an IAnimationTimeReference to DrawableHitObject to synchronise all animations	2023-05-08 18:56:29 +09:00
Dan Balasescu	d2380bd840	Remove usages of [ExcludeFromDynamicCompile]	2023-05-08 18:12:56 +09:00
Dean Herbert	d6ce56e6b1	Fix GetMostCommonBeatLength returning zero in case of not timing points	2023-05-08 17:09:08 +09:00
Dean Herbert	1b7dd32eb1	Apply nullability in related classes and remove unused variable	2023-05-08 17:09:08 +09:00
Dean Herbert	715b735131	Fix "Return to main page" link not working on wiki after error	2023-05-08 15:29:05 +09:00
Dean Herbert	8c44d528e9	Use min/max values from stable	2023-05-08 13:52:16 +09:00
Dean Herbert	a6cb1f90e4	Change difficulty popover inspector display (yet again) ... I think this makes the most sense of the iterations I've tested so far, albeit maybe being a touch too verbose.	2023-05-08 13:43:23 +09:00
Dean Herbert	a91edd68d9	Show post-multiplied velocity in main hit object inspector	2023-05-08 13:42:25 +09:00
Dean Herbert	451af9d1b5	Fix beatmap values not being updated due to a varying data type	2023-05-08 13:23:13 +09:00
Dean Herbert	d9dd35c020	Show base velocity in slider adjustment popover	2023-05-08 13:13:09 +09:00
Dean Herbert	31de4de720	Remove median/mode slider velocity display ... The intention was to give an idea of what the most common velocity of the beatmap is, but in hindsight, because the "base" velocity is being set elsewhere this doesn't make sense. It will/should be 1.0x. Showing this range is still valuable, though.	2023-05-08 13:13:09 +09:00
Dean Herbert	b109ee74a6	Add "base velocity" adjustment to difficulty setup screen	2023-05-08 13:13:09 +09:00
Dean Herbert	f7d44c3013	Rename SliderMultiplier to BaseSliderVelocity	2023-05-08 13:13:09 +09:00
Cootz	60bad35145	Remove weird update usage when 'deselect all' pressed	2023-05-07 15:34:01 +03:00
Cootz	4d235105d1	Convert ModSearchContainer to block-scoped namespace	2023-05-07 15:14:49 +03:00
Bartłomiej Dach	65b4b198a4	Merge branch 'master' into export	2023-05-06 20:12:53 +02:00
tsrk	e9d7cd7a79	feat(ArgonKeyCounter): flash key name	2023-05-06 19:08:30 +01:00
Bartłomiej Dach	510484011c	Mark exporter extensions as untranslatable	2023-05-06 19:42:28 +02:00
Bartłomiej Dach	3f63fd7f4d	Reorder increment to make progress update less weird	2023-05-06 19:39:52 +02:00
Bartłomiej Dach	bb17b684b0	Rename flag	2023-05-06 19:38:41 +02:00
Bartłomiej Dach	a56a5d563c	Unify error message wording	2023-05-06 19:38:05 +02:00
Bartłomiej Dach	3afe198d1d	Remove weird single-use private method	2023-05-06 19:34:22 +02:00
Bartłomiej Dach	e0823ffd03	Move lower and xmldoc GetFilename(TModel)	2023-05-06 19:29:08 +02:00
Bartłomiej Dach	5e64d25b2a	Make UserFileStorage readonly again	2023-05-06 19:26:51 +02:00
Dean Herbert	64d7e0d896	Rename outputStream variable to match base class	2023-05-07 00:24:30 +09:00
Dean Herbert	d2591368a6	More xmldoc fixes	2023-05-06 23:53:35 +09:00
Bartłomiej Dach	e2410c00e2	Merge branch 'master' into update-framework	2023-05-06 16:25:44 +02:00
Bartłomiej Dach	38ebce8ee9	Update framework again	2023-05-06 16:21:48 +02:00
Dean Herbert	0d095c4bb7	Remove non-Live pathway	2023-05-06 23:10:18 +09:00
Dean Herbert	e75ff33d62	Remove redundant xmldoc and reword some remaining	2023-05-06 23:10:09 +09:00
Bartłomiej Dach	3942281d13	Fix back-to-front logic	2023-05-06 15:34:55 +02:00
Bartłomiej Dach	80ac8abaa6	Merge branch 'master' into chat-report	2023-05-06 15:30:44 +02:00
Bartłomiej Dach	1da5e69d5a	Fix API success callback scheduling to dead drawable	2023-05-06 15:27:27 +02:00
Bartłomiej Dach	6b4050ea52	Remove invalid report reason (and add osu-web references)	2023-05-06 15:01:57 +02:00
Bartłomiej Dach	52e5835be6	Document and retouch ReportPopover	2023-05-06 14:52:38 +02:00
Cootz	cbb9f0100e	Update PopIn and PopOut filtering. Expose SearchTerm	2023-05-06 11:27:06 +03:00
Cootz	a226caff56	Fix testing	2023-05-06 11:09:44 +03:00
Cootz	7422b5285c	Fix wrong filtering in testing	2023-05-05 22:41:30 +03:00
Bartłomiej Dach	e808a47811	Fix delegate leak	2023-05-05 20:33:27 +02:00
Bartłomiej Dach	f536238554	Use shorter copy	2023-05-05 20:30:50 +02:00
Bartłomiej Dach	34b19dd6f4	Merge branch 'master' into slider-velocity-inspector	2023-05-05 20:20:16 +02:00
Bartłomiej Dach	4ca80cf6be	Merge pull request #23404 from peppy/show-sv-in-inspector ... Show slider velocity in hit object inspector	2023-05-05 20:19:50 +02:00
Bartłomiej Dach	3b37a421e6	Merge pull request #23401 from peppy/fix-break-overlay-glow-cutoff ... Fix break overlay arrows' glow getting cut off at lower resolutions	2023-05-05 20:12:34 +02:00
cdwcgt	71864fbb93	remove meanless comment	2023-05-05 21:29:06 +09:00
cdwcgt	4393e53b43	ExportToStream should be public	2023-05-05 21:28:43 +09:00
Dean Herbert	490df8073c	Fix one incorrect namespace syntax file	2023-05-05 21:15:26 +09:00
Dean Herbert	747f912af5	Fix incorrect cancellation logic	2023-05-05 21:08:01 +09:00
Dean Herbert	5d78561aa3	Remove weird catch logic	2023-05-05 21:05:57 +09:00
Dean Herbert	2a3e03695c	Simplify ExportAsync, remove weird dedupe logic and unnecessary return success code	2023-05-05 21:05:52 +09:00
Dean Herbert	4ccfebc02b	Simplify ExportToStreamAsync implementation	2023-05-05 21:01:10 +09:00
Dean Herbert	fc2d2de34c	Fix notification text not including export filename	2023-05-05 16:53:27 +09:00
Dean Herbert	9cafb20fcb	Move file missing logging to a better location, and log actual filenames to logs	2023-05-05 16:53:16 +09:00
Dean Herbert	4ec98b0578	Improve xmldoc and fix silly progress text in LegacyArchiveExporter	2023-05-05 16:45:45 +09:00
Dean Herbert	0158102467	Rename class back to original name so I can read the diff	2023-05-05 16:19:10 +09:00
Dean Herbert	b7a287869a	Add display of beatmap slider velocity when adjusting	2023-05-05 15:57:38 +09:00
Dean Herbert	cc70d89bf9	Move editor inspector classes out of ruleset namespace	2023-05-05 15:57:38 +09:00
Dean Herbert	4663057060	Split out EditorInspector implementation for reuse	2023-05-05 15:54:15 +09:00
Cootz	ab94b4dce1	Update ModPresetPanel.FilterTerms to account mod names and acronyms	2023-05-05 09:52:09 +03:00
Cootz	54757df51f	Fix mod deselect button not working properly when search applied	2023-05-05 09:31:27 +03:00
Dean Herbert	76b2f0e6dd	Show slider velocity in hit object inspector	2023-05-05 15:15:18 +09:00
Dean Herbert	560f71ef53	Adjust BlurredIcon expansion ratio to fix glow getting cut off at lower resolutions ... Closes https://github.com/ppy/osu/issues/23210. Ballparked the fix to work down to the lowest resolution we support. The previous number (`2.5f`) was also likely ballparked so the fix seems in line with expectations. I don't want to put too much thought into this because the design of this screen is likely going to change in the mean time anyway.	2023-05-05 14:29:04 +09:00
Dean Herbert	8391e2a538	Move reporting code out of DrawableChatUsername into more correct locations	2023-05-05 14:03:42 +09:00
tsrk	74e7a958bb	feat(ArgonKeyCounter): make animation ... Currently WIP. Do not consider this final.	2023-05-05 05:31:06 +01:00
Dean Herbert	698baa78bf	Merge pull request #22711 from Terochi/keep-shared-settings-ruleset-change ... Keep shared mod settings when changing ruleset	2023-05-05 13:29:55 +09:00
Bartłomiej Dach	485b7282dc	Clarify type check	2023-05-04 19:06:07 +02:00
Bartłomiej Dach	bdd96caaa9	Merge branch 'master' into edit-mods-preset	2023-05-04 18:59:47 +02:00
Bartłomiej Dach	1f1342b099	Reword xmldoc	2023-05-04 18:33:49 +02:00
Bartłomiej Dach	88e77ad390	Rename Settings{-> Map}	2023-05-04 18:30:41 +02:00
Bartłomiej Dach	26337dbcd8	Do not rely on unspecified Dictionary.Values ordering	2023-05-04 18:29:01 +02:00
Cootz	1ac9d900e1	Clear search on ModSelectOverlay.Hide	2023-05-04 19:24:37 +03:00
Bartłomiej Dach	0d2396c557	Rename method to better indicate directionality	2023-05-04 18:15:12 +02:00
Dean Herbert	95b541ab39	Update framework	2023-05-04 11:27:18 +09:00
Dean Herbert	0034124d79	Remove unnecessary content clear	2023-05-04 11:25:10 +09:00
Dean Herbert	26b8c5b852	Fix mod list display not updating after clicking "use current" ... This is not a regression from my changes. It was broken before them.	2023-05-04 11:23:51 +09:00
Dean Herbert	49fb5da1a2	Stop passing preset panel to popover	2023-05-04 11:19:09 +09:00
Dean Herbert	b12d139317	Remove dead code	2023-05-04 11:16:52 +09:00
Dean Herbert	99d2616c34	Move drawable construction to load for simplicity	2023-05-04 11:14:51 +09:00
Dean Herbert	be995f1359	Add localisation support for new button string	2023-05-04 11:11:19 +09:00
Dean Herbert	b7abab6d8a	More variable improvements	2023-05-04 11:10:05 +09:00
Dean Herbert	0a584f0652	Simplify check logic and improve variable naming	2023-05-04 11:07:09 +09:00
Bartłomiej Dach	59ece64d25	Merge branch 'master' into skin-editor-change-handler-improvement	2023-05-03 19:42:42 +02:00
Bartłomiej Dach	1d4d31e35c	Trim comments ... Leaving only the ones that add anything useful and do not restate the code verbatim.	2023-05-03 19:22:52 +02:00
Bartłomiej Dach	27fabd99fb	Rename variables for legibility ... Having `typedComponents` and `typeComponents` next to each other is asking for trouble.	2023-05-03 19:21:16 +02:00
Terochi	d1d4b54c64	Simplified	2023-05-03 18:31:35 +02:00
Bartłomiej Dach	fa3f42ba75	Merge pull request #23386 from peppy/fix-osu-logo-input-handling ... Extend input handling of osu! logo to full border area	2023-05-03 17:48:51 +02:00
cdwcgt	4549a865d9	Merge branch 'master' into export	2023-05-04 00:18:01 +09:00
cdwcgt	967e801f9c	code inspect	2023-05-03 23:26:58 +09:00
cdwcgt	debbd376bd	move scrollContent update logic to updateActiveState()	2023-05-03 23:24:14 +09:00
cdwcgt	f4b1264cc9	use button Enable status to ensure preset name is not null	2023-05-03 23:22:46 +09:00
cdwcgt	aa5a026c67	remove local button handle	2023-05-03 23:14:24 +09:00
cdwcgt	c609e6345c	remove Use Current Mods menu item	2023-05-03 23:02:50 +09:00
Cootz	152d2678d5	Fix ModSelectColumn completely disappear from ModSelectOverlay	2023-05-03 14:00:46 +03:00
Dean Herbert	be15d07b17	Tidy up various implementation details	2023-05-03 18:59:39 +09:00
Dean Herbert	b932e4d986	Rename DrawableUsername to DrawableChatUsername and only pass message ID	2023-05-03 18:53:22 +09:00
Dean Herbert	b28d7b1a92	Fix non-block namespace	2023-05-03 18:51:02 +09:00
Dean Herbert	4f55afb60d	Merge branch 'master' into chat-report	2023-05-03 18:50:38 +09:00
Dean Herbert	444f66b0ee	Move to base class for added safety	2023-05-03 18:46:30 +09:00
Dean Herbert	cd31cff8cd	Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap ... The handling of cleanup is performed only the `Item_Set` method. This was already correctly called for `DrawableCarouselBeatmapSet`, but not for the class in question here. This would cause runaway memory usage at song select when opening many beatmaps to show their difficulties. For simplicity, we don't yet pool these (and generate the drawables each time a set is opened) which isn't great but likely will be improved upon when we update the visual / filtering of the carousel. But this simplicity caused the memory usage to blow out until exiting back to the main menu when cleanup would finally occur.	2023-05-03 18:41:30 +09:00
Dean Herbert	5757eb7529	Update a few more instances of 0.96f scale constants	2023-05-03 18:20:12 +09:00
Bartłomiej Dach	88135a3be8	Merge pull request #23384 from peppy/fix-incorrect-transform-thread ... Fix potentially incorrect thread access in `OsuTabControlCheckbox`	2023-05-03 10:37:27 +02:00
Dean Herbert	ff28d941b3	Merge pull request #23385 from Joehuu/scroll-back-button-block-hover ... Fix overlay scroll back button not absorbing hover from behind	2023-05-03 16:28:05 +09:00
Bartłomiej Dach	de1b28bcb2	Fix incorrect initial state of checkbox ... This only ever barely used to work without the `(..., true)` in `master` because of haphazard operation ordering.	2023-05-03 09:27:23 +02:00
Bartłomiej Dach	5f781bd6de	Move callback to LoadComplete() ... Is the more correct place for `BindValueChanged()` callbacks.	2023-05-03 09:26:54 +02:00
Dean Herbert	453143813f	Extend input handling of osu! logo to full border area ... This is the easiest way to make this happen. It does mean the pink area is being drawn behind the white border, but I haven't found a scenario where this is noticeable. Closes #4217.	2023-05-03 14:57:57 +09:00
Joseph Madamba	1c74f6e8ea	Fix regressed button hover fade in	2023-05-02 22:54:42 -07:00
Joseph Madamba	bede1292de	Fix overlay scroll back button not absorbing hover from behind	2023-05-02 22:40:37 -07:00
Dean Herbert	a3efae3690	Fix potentially incorrect thread access in OsuTabControlCheckbox ... https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736829.	2023-05-03 14:33:32 +09:00
Dean Herbert	6b017ac05f	Merge pull request #23308 from OliBomby/sample-control-points ... Remove SampleControlPoint and DifficultyControlPoint from HitObject	2023-05-03 14:21:51 +09:00
Dean Herbert	f930c4bd0a	Move struct to bottom of file	2023-05-03 13:33:31 +09:00
Dean Herbert	48fd99818e	Split out default and sample application	2023-05-03 13:30:45 +09:00
Dean Herbert	cca15f930c	Refactor applyLegacyInfoAndDefaults for legibility	2023-05-03 13:26:50 +09:00
Dean Herbert	588a4e6196	Move pragma disable to top of LegacyBeatmapDecoder ... Makes more sense as it's used multiple times in the class.	2023-05-03 13:19:14 +09:00
Dean Herbert	e394b487e0	Merge branch 'master' into edit-mods-preset	2023-05-03 12:06:16 +09:00
Dean Herbert	e42b0cc5b1	Merge pull request #23370 from peppy/fix-editor-playfield-padding ... Add more padding around playfield in editor to avoid overlap with tool areas	2023-05-03 11:44:55 +09:00
Bartłomiej Dach	ec8362c6fc	Merge pull request #23367 from peppy/fix-uo-tooltip ... Fix slider bar tooltips potentially showing negative zero	2023-05-02 18:03:09 +02:00
Bartłomiej Dach	48dd42407b	Merge pull request #23369 from peppy/beatmap-attribute-text-unicode-preference ... Fix `BeatmapAttributeText` not supporting unicode artist/title	2023-05-02 17:32:55 +02:00
Cootz	a6ca049739	Manually implement @bdach prototype	2023-05-02 14:15:33 +03:00
Dean Herbert	94ae9d7664	Merge pull request #23357 from OliBomby/fix-reverse-crash ... Prevent infinite repeat count when adjusting repeats of 0 length slider	2023-05-02 19:53:26 +09:00
Dean Herbert	414b80d44e	Change flashlight depth in a more standard way	2023-05-02 17:00:54 +09:00
Dean Herbert	b2b9f2a036	Merge branch 'master' into bubble_mod_implementation_clean	2023-05-02 16:59:55 +09:00
OliBomby	2e018c8b06	Fix comment 2 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-05-02 08:41:47 +02:00
OliBomby	c2ad8c2320	Fix comment 1 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-05-02 08:41:30 +02:00
Dean Herbert	67f83f246b	Add more padding around playfield in editor to avoid overlap with tool areas ... Closes #23130.	2023-05-02 15:37:02 +09:00
Dean Herbert	4a97c2c105	Merge pull request #23038 from cdwcgt/scale-background-dim ... Add feature to adjust `ScalingContainer` background dim	2023-05-02 15:36:52 +09:00
Dean Herbert	ce4a6c38a0	Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight ... Fix now playing playlist not highlighting selected item on initial open	2023-05-02 15:36:34 +09:00
Dean Herbert	8a536c1cdb	Fix non-block namespace usage	2023-05-02 15:09:24 +09:00
Dean Herbert	1e4a628cb1	Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod ... Fix issue where multiplier show wrong value when adjusting speed on preset	2023-05-02 14:59:41 +09:00
Dean Herbert	e3c384c6b5	Merge branch 'master' into sample-control-points	2023-05-02 14:38:39 +09:00
Dean Herbert	57f48e0703	Start colour black to ensure initial appear transition doesn't look silly	2023-05-02 14:33:57 +09:00
Dean Herbert	ab4f66fad3	Minor readability refactors	2023-05-02 14:31:39 +09:00
Dean Herbert	7a840e1d82	Remove unnecessary TransferValue spec	2023-05-02 14:29:26 +09:00
Dean Herbert	7efaa299bd	Merge branch 'master' into scale-background-dim	2023-05-02 14:24:54 +09:00
Dean Herbert	736be6a73b	Refactor slightly for readability	2023-05-02 14:11:16 +09:00
Dean Herbert	ad40099e32	Ensure negative sign is only applied when the post-rounded result is negative	2023-05-02 14:00:52 +09:00
Dean Herbert	37a5dde859	Fix BeatmapAttributeText not supporting unicode artist/title	2023-05-02 13:47:49 +09:00
Dean Herbert	e808e7316b	Mark delegate value unused and add comment to avoid future regression	2023-05-02 13:29:30 +09:00
Dean Herbert	63890ef6fe	Fix audio offset tooltip potentially showing "-0 ms" ... Closes https://github.com/ppy/osu/issues/23339.	2023-05-02 13:24:22 +09:00
Dean Herbert	983a8f7dfe	Merge branch 'master' into fix-reverse-crash	2023-05-02 13:14:34 +09:00
Dean Herbert	5da78098ad	Merge pull request #23362 from bdach/fix-saving-online-beatmap-not-resetting-id ... Reset online ID on locally modifying beatmap	2023-05-02 12:41:23 +09:00
Bartłomiej Dach	436ebdcfcb	Fix beatmap leaderboard test failure ... Because the online info reset (which includes online ID reset) was happening after encoding, `TestSceneBeatmapLeaderboard.TestLocalScoresDisplayOnBeatmapEdit()` started failing, as the hash no longer matched expectations after the first save of the map.	2023-05-01 19:44:15 +02:00
OliBomby	cf5211aec9	Enable current distance snap when exactly on a hit object	2023-05-01 19:22:52 +02:00
Bartłomiej Dach	f470b2c9cc	Always reset online info when saving local beatmap	2023-05-01 18:17:45 +02:00
Bartłomiej Dach	8ab3a87b13	Add failing test case covering online ID reset on save ... This test scene passes at e58e1151f3 and fails at current master, due to an inadvertent regression caused by e72f103c17. As it turns out, the online lookup flow that was causing UI thread freezes when saving beatmaps in the editor, was also responsible for resetting the online ID of locally-modified beatmaps if online lookup failed.	2023-05-01 18:17:35 +02:00
OliBomby	8c21fddb5e	remove all redundancies from encoded control points	2023-05-01 16:53:38 +02:00
OliBomby	1dc34ee25d	fix infinite repeat count when adjusting length of 0 length slider	2023-05-01 15:48:54 +02:00
OliBomby	8302bb1f37	dont encode custom sample bank for objects without legacy samples	2023-05-01 14:56:29 +02:00
OliBomby	27cfadca16	add sample info to Banana and SpinnerBonusTick	2023-05-01 14:54:06 +02:00
Terochi	4d52ce769b	Revert SaveState() calling on initialization	2023-05-01 12:53:58 +02:00
OliBomby	cef9f73d34	dont assign custom sample bank and volume to hitobjects in non-mania gamemodes ... this makes it easier to edit hitsounds in the stable editor after export because the sample control point effects wont get overwritten by the properties of the hitobject	2023-05-01 12:31:27 +02:00
Bartłomiej Dach	d98aa60efc	Merge branch 'master' into cursor-ripples	2023-05-01 09:37:50 +02:00
OliBomby	2a94757154	Make sure the first object you place has bank and volume	2023-05-01 00:49:01 +02:00
OliBomby	608fa3cc73	Merge remote-tracking branch 'upstream/master' into sample-control-points	2023-04-30 19:47:03 +02:00
OliBomby	139a1d7e6d	fix legacy encoder writing sample info while not writing node samples	2023-04-30 17:46:47 +02:00
Bartłomiej Dach	7cedbca9be	Merge branch 'master' into multiplier-doesnt-update-with-preset-mod	2023-04-30 17:36:00 +02:00
Bartłomiej Dach	2e3daf0a54	Fix leak of ModSettingChangeTracker instances ... The `SelectedMods.BindValueChanged()` callback in `ModSelectOverlay` can in some instances run recursively. This is most heavily leaned on in scenarios where `SelectedMods` is updated by an external component. In such cases, the mod select overlay needs to replace the mod instances received externally with mod instances which it owns, so that the changes made on the overlay can propagate outwards. This in particular means that prior to this commit, it was possible to encounter the following scenario: modSettingChangeTracker?.Dispose(); updateFromExternalSelection(); // mutates SelectedMods to perform the replacement // therefore causing a recursive call modSettingChangeTracker?.Dispose(); // inner call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); // outer call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); This leaks one `modSettingChangeTracker` instance from the inner call, which is never disposed. To avoid this, move the disposal to the same side of the recursion that the creation happens on, changing the call pattern to: updateFromExternalSelection(); // mutates SelectedMods to perform the replacement // therefore causing a recursive call modSettingChangeTracker?.Dispose(); // inner call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); modSettingChangeTracker?.Dispose(); // outer call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); which, while slightly wasteful, does not cause any leaks. The solution is definitely suboptimal, but addressing this properly would entail a major rewrite of the mod instance management in the mods overlay, which is probably not the wisest move to make right now.	2023-04-30 17:31:41 +02:00
Terochi	fb4b681cc5	Use Queue instead of Stack	2023-04-30 16:36:01 +02:00
Terochi	8f02bd80f9	Addressed changes	2023-04-30 16:11:52 +02:00
Terochi	949dc1c0f9	Improved logic	2023-04-30 12:05:55 +02:00
Dean Herbert	b39a9d816e	Add basic structural requirements for cursor ripples	2023-04-30 14:48:03 +09:00
Terochi	8ec2154965	Fixed ApplyStateChange to happen in correct order	2023-04-30 02:01:18 +02:00
OliBomby	83111223e0	fix null sample	2023-04-30 01:08:52 +02:00
OliBomby	92efd04f31	fix sample of drumroll ticks being bankless	2023-04-29 23:52:24 +02:00
OliBomby	ffcc8e91b2	fix legacy parser incorrectly assigning sample info for sliders	2023-04-29 23:51:49 +02:00
Terochi	17e4b75dfd	Save first state when editing	2023-04-29 20:54:19 +02:00
Terochi	3b0ba4b38b	Improved logic for ApplyStateChange for skin editor	2023-04-29 19:52:22 +02:00
Bartłomiej Dach	646d4965b9	Merge branch 'master' into fix-exclusive-fullscreen-detection	2023-04-29 14:39:34 +02:00
Dean Herbert	119687cf6e	Merge pull request #23329 from rltn/clickable-country-name-in-profile ... Clickable country name in profile	2023-04-29 14:19:13 +09:00
Cootz	607a04ae73	Fix the issue	2023-04-29 10:29:33 +09:00
_ltn	2d6c0d2900	use of Child instead of Children	2023-04-28 19:24:07 +03:00
OliBomby	f7c84030ac	remove bank default value	2023-04-28 17:22:34 +02:00
Dean Herbert	6929be49b7	Change condition for exclusive fullscreen notice to only show when using the correct renderer ... This avoids the notice showing when running on windows, but using the newer renderers (where the underlying logic hasn't been tested properly and can result in false-positives). Supersedes https://github.com/ppy/osu-framework/pull/5759 as a more correct implementation.	2023-04-28 22:36:30 +09:00
Ethan	ae85e2a3ff	Update LoginForm.cs	2023-04-28 19:51:10 +08:00
_ltn	4b0ee392f6	add OsuHoverContainer	2023-04-28 05:48:54 +03:00
_ltn	17730f05bc	remove UpdateableCountryText	2023-04-28 05:47:05 +03:00
_ltn	4d144cd5b5	clearing the code	2023-04-28 02:06:13 +03:00
_ltn	092377fdaa	moving UpdateableCountryText	2023-04-28 01:47:14 +03:00
_ltn	e9843f2066	replace country text object	2023-04-28 01:16:50 +03:00
_ltn	b13201fb79	UpdateableCountryText rewrite	2023-04-28 01:14:42 +03:00
_ltn	f5c652325a	Create UpdateableCountryText.cs	2023-04-27 23:44:18 +03:00
Cootz	b795e8ac5a	Use ModSearch in ModeSelectOverlay	2023-04-27 17:26:35 +03:00
Cootz	3c6141f233	Add ModSearch	2023-04-27 17:08:29 +03:00
Bartłomiej Dach	07efa7d660	Merge branch 'master' into fix-storyboard-loop-end-time	2023-04-26 21:53:26 +02:00
OliBomby	354cd23874	removed all usage of hitobject's DifficultyControlPoint	2023-04-26 18:17:02 +02:00
OliBomby	c44f71a737	remove all regular usage of DifficultyControlPoint	2023-04-26 17:55:38 +02:00
OliBomby	1b4f4372d5	fixed sample control point applying	2023-04-26 14:32:12 +02:00
OliBomby	5accb05f45	fix invalidoperation exception	2023-04-26 14:28:48 +02:00
OliBomby	c6fc180659	remove all test usages of SampleControlPoint	2023-04-26 14:21:52 +02:00
OliBomby	87ca0f5335	Update SamplePointPiece.cs	2023-04-26 13:45:58 +02:00
OliBomby	6c70948681	Remove IContext & add IHasGenerateTicks	2023-04-26 13:10:57 +02:00
OliBomby	e27c4dfa10	Invoke ApplyDefaultsToSelf	2023-04-26 11:46:05 +02:00
Terochi	332c199dc2	further simplification	2023-04-26 10:46:29 +02:00
cdwcgt	bfd81b77fa	provide more Accuracy Mode for ModAccuracyChallenge	2023-04-26 17:40:25 +09:00
Dean Herbert	61b62b35f5	Merge pull request #18626 from ggliv/decouple-mod-fails ... Allow ModFailCondition to arbitrarily trigger failures	2023-04-26 16:19:42 +09:00
Dean Herbert	27f81288ef	Merge branch 'master' into keep-shared-settings-ruleset-change	2023-04-26 15:51:31 +09:00
Dean Herbert	cb7b246e33	Fix naming and update in line with nullability	2023-04-26 15:27:58 +09:00
Dean Herbert	210c5e7c53	Merge branch 'master' into decouple-mod-fails	2023-04-26 15:26:20 +09:00
Dean Herbert	6a3b587374	Merge pull request #23260 from Haspamelodica/master ... Fix some videos with uppercase file extensions not displaying correctly in-game	2023-04-26 14:29:25 +09:00
Dean Herbert	1efc78c0f8	Actually use new end time property when setting lifetimes	2023-04-26 13:28:51 +09:00
Terochi	8e297dc60a	Added safety measures for invalid mod combinations	2023-04-25 21:28:03 +02:00
Bartłomiej Dach	5ec8ecb11b	Merge pull request #23309 from peppy/key-counters-fix ... Fix key counters counting during break time	2023-04-25 21:15:12 +02:00
Terochi	0841e73a39	Improved readability and sounds	2023-04-25 21:07:17 +02:00
OliBomby	e4b64bdc3e	clean up code stuff	2023-04-25 19:06:29 +02:00
OliBomby	755ad25dbe	clean code	2023-04-25 18:27:20 +02:00
OliBomby	66eda40cdf	fix implementations of IHasSliderVelocity	2023-04-25 18:22:22 +02:00
OliBomby	c23a7b014e	add missing }	2023-04-25 18:17:07 +02:00
OliBomby	065464d90c	Fixed DifficultyPointPiece	2023-04-25 18:12:53 +02:00
Daniel Kirschten	54e8aa8fe9	Merge branch 'master' into master	2023-04-25 16:04:02 +02:00
OliBomby	ebe1d852f5	remove other usages of hitobject SampleControlPoint	2023-04-25 16:01:43 +02:00
OliBomby	a634617157	Fix file header notice	2023-04-25 16:01:06 +02:00
OliBomby	c37875bee8	remove hitobject SampleControlPoint usage from LegacyBeatmapEncoder	2023-04-25 16:00:40 +02:00
Dean Herbert	14af2063e5	Merge pull request #23247 from peppy/round-editor-rotation ... Always round editor rotation to integer values	2023-04-25 21:43:44 +09:00
Dean Herbert	e08d7daffd	Don't show decimal point in tooltip	2023-04-25 21:43:14 +09:00
Dean Herbert	6b4032e34b	Add missing binding of IsCounting with contained counters	2023-04-25 21:37:19 +09:00
Dean Herbert	0a861ffcee	Restructure key counters to use a common flow	2023-04-25 21:37:19 +09:00
Dean Herbert	7630958633	Stop using Drawable.Name to convey actual UI information	2023-04-25 20:24:36 +09:00
Dean Herbert	dd2c289ce9	Remove pointless default value	2023-04-25 20:22:12 +09:00
OliBomby	97910d6be6	remove unused directives	2023-04-25 13:06:37 +02:00
OliBomby	bf1951fc38	Fix incorrect xmldoc	2023-04-25 12:54:45 +02:00
Dean Herbert	d8b4db3a13	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-25 19:54:31 +09:00
OliBomby	891b87a5ff	remove ApplyLegacyInfo method	2023-04-25 12:52:21 +02:00
OliBomby	ea1e6e9798	Add LegacyContext	2023-04-25 12:12:46 +02:00
OliBomby	a4c6850ab2	made the SampleControlPoint and DifficultyControlPoint obsolete	2023-04-25 11:34:09 +02:00
Dean Herbert	e330052852	Add second definition of EndTime for storyboard elements to account for loops in lifetime	2023-04-25 15:22:11 +09:00
Dean Herbert	3919400be2	Apply NRT to some storyboard classes	2023-04-25 14:30:01 +09:00
Renzo Poggio	0991c56e1c	Add extra check in 'SelectPreviousRandom' ... Check if the poped beatmap exists within the beatmapSets	2023-04-25 00:05:15 -03:00
Hy0tic	80301f0fc9	Merge https://github.com/Hy0tic/osu	2023-04-22 13:32:41 -04:00
Hy0tic	56ab029a58	fix issue where multipler does not update when adjusting speed for preset mod	2023-04-22 13:30:08 -04:00
Daniel Kirschten	6c9a90d1ec	Merge branch 'master' into master	2023-04-22 19:23:52 +02:00
Haspamelodica	e90660c1a4	Switched to lowercase	2023-04-21 02:35:28 +02:00
Haspamelodica	b62de5514c	Fixed video importing bug #23259	2023-04-21 02:10:24 +02:00
Dean Herbert	1066dfcbf6	Change default beat divisor to 4 ... This matches stable, and is a much saner default value. Will apply to new beatmaps and also beatmaps which don't specify a snap value in the `.osu` file.	2023-04-20 14:35:13 +09:00
Dean Herbert	9f4b1f0f24	Always round editor rotation to integer values	2023-04-20 14:30:01 +09:00
Joseph Madamba	776c4cfaad	Ensure selected field is correct in updateSelectionState() ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-04-19 18:34:35 -07:00
Dean Herbert	01260e5f54	Merge branch 'master' into shader-cache-stages	2023-04-19 20:47:34 +09:00
Dean Herbert	760ef10145	Update framework	2023-04-19 00:04:21 +09:00
Dean Herbert	ee5658c15a	Merge pull request #23222 from peppy/update-framework-resources ... Update framework and resources	2023-04-18 14:10:42 +09:00
Dean Herbert	26a2d1fdea	Merge pull request #23000 from Joehuu/fix-beatmap-terminology ... Fix song select matching label not using right terminology	2023-04-18 13:53:05 +09:00
Joseph Madamba	c80a25328d	Shorten label to just "matches"	2023-04-17 20:59:41 -07:00
Joseph Madamba	16df92f405	Fix sets not being plural	2023-04-17 20:59:02 -07:00
Dan Balasescu	c0a25144cf	Apply changes to custom ShaderManager	2023-04-18 11:31:56 +09:00
Dean Herbert	c3f3b8db7c	Update resources	2023-04-17 23:09:46 +09:00
Dean Herbert	fbb15fff26	Update framework	2023-04-17 23:03:16 +09:00
Dean Herbert	7aeab174eb	Merge pull request #23185 from bdach/nested-result-revert ... Invoke `RevertResult` on parent DHO when nested DHO is reverted	2023-04-12 23:08:10 +09:00
Bartłomiej Dach	e72f103c17	Do not look up metadata for locally-modified beatmaps on save	2023-04-11 23:14:35 +02:00
Bartłomiej Dach	db86ced4b4	Invoke RevertResult on parent DHO when nested DHO is reverted ... The behaviour described above was removed in 812a4b412a, thus henceforth contradicting `RevertResult`'s xmldoc. As it is relied on by some external rulesets, bring it back to unbreak them.	2023-04-11 18:29:08 +02:00
Joseph Madamba	d0cbe206a9	Revert back to one number with "matching beatmap difficulties" label	2023-04-10 23:37:29 -07:00
Joseph Madamba	f0c8a3202b	Merge remote-tracking branch 'upstream/master' into fix-beatmap-terminology	2023-04-10 23:22:15 -07:00
Dean Herbert	52bb7891f7	Merge branch 'master' into fix-count-not-updating-when-deleting	2023-04-11 09:04:02 +09:00
Joseph Madamba	f80de08f24	Adjust BeatmapSetsChanged xmldoc ... Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-04-10 11:28:23 -07:00
Joseph Madamba	c7dea71793	Use existing BeatmapSetsChanged action	2023-04-10 11:26:18 -07:00
Dean Herbert	8757276c37	Merge pull request #23156 from Micha-ohne-el/editor-selection-rotation-snapping ... Add rotation snapping to editor selection	2023-04-11 00:45:44 +09:00
Dean Herbert	52c4703261	Merge pull request #23103 from Joehuu/normalise-overlay-padding ... Normalise horizontal padding on overlays	2023-04-10 23:48:59 +09:00
Bartłomiej Dach	1f2c96c8e8	Merge branch 'master' into gd-onlinesetoverlay	2023-04-10 15:35:03 +02:00
Bartłomiej Dach	11fd93a2ba	Inline disturbing getGuestMapper() method ... Disturbing because name suggests pure method, but it is in fact `void` and also performs side effects by about the most confusing means possible.	2023-04-10 15:20:43 +02:00
Bartłomiej Dach	73bd0feef5	Fix incorrectly implemented localisation	2023-04-10 15:03:33 +02:00
Bartłomiej Dach	6fec476147	Simplify snap implementation	2023-04-10 14:55:30 +02:00
Bartłomiej Dach	ead5e9f027	Merge branch 'master' into editor-inspector	2023-04-10 14:29:05 +02:00
Bartłomiej Dach	60358c7203	Perform first inspector text update immediately ... Provides better and more consistent initial state for the inspector.	2023-04-10 14:13:53 +02:00
Bartłomiej Dach	641415ca32	Unify displayed duration format for single/multiple selection	2023-04-10 14:05:32 +02:00
Joseph Madamba	7f5b99c91b	Fix song select beatmap difficulty count not updating when deleting	2023-04-09 22:12:51 -07:00
Dan Balasescu	15f6bc155e	Add progressive score multiplier for HT	2023-04-10 13:35:48 +09:00
Dan Balasescu	c923482976	Add progressive score multiplier for DT	2023-04-10 13:31:48 +09:00
cdwcgt	dd69089117	code quality	2023-04-09 15:51:31 +09:00
cdwcgt	5d64c1b7bf	exception handling	2023-04-09 15:09:18 +09:00
cdwcgt	ce6a87b4a3	Merge remote-tracking branch 'upstream/master' into export	2023-04-09 15:02:47 +09:00
cdwcgt	fc55b96e77	remove CompletionText in Constructor ... this will never used Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-04-09 14:27:42 +09:00
cdwcgt	49193a2bdd	CompletionText ... Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-04-09 22:25:47 +09:00
cdwcgt	de21b4a2f7	use Live<TModel> ... Use RealmAccess only when needed	2023-04-09 22:21:15 +09:00
cdwcgt	1f4da35c8d	notification nullable fix	2023-04-09 22:13:53 +09:00
cdwcgt	13b522e825	repair usage of CancellationToken ... Co-Authored-By: n0099 <n@n0099.net>	2023-04-09 22:09:53 +09:00
Dean Herbert	8d2e852ffd	Fix overbearing key down handling	2023-04-08 22:30:36 +09:00
Dean Herbert	a1fc4def1d	Remove redundant method override	2023-04-08 22:18:07 +09:00
Micha Lehmann	3c4a25e53f	Fix tooltip text not resetting when ending an editor rotation	2023-04-08 14:28:52 +02:00
Micha Lehmann	580d5745c0	Add "(snapped)" to the tooltip when snap-rotating in the editor	2023-04-08 14:15:49 +02:00
Joseph Madamba	a86a968fac	Use public BeatmapSet to match other usages	2023-04-07 21:16:36 -07:00
Joseph Madamba	ed208ef127	Fix more typos and adjust font size to match web	2023-04-07 21:10:37 -07:00
Dean Herbert	f72dd86b42	Fix code quality issues and avoid updating bindable twice per operation	2023-04-08 10:40:36 +09:00
Micha Lehmann	c827c2810b	Improve editor selection rotation value wrapping ... This fixes two issues the previous algorithm had: 1. A half-turn rotation used to show up as -180°. 2. Rotating more than 180° in one drag event would overwhelm it and cause the value to go outside its range. This comes at the cost of a negligible performance hit, since a division (modulo) is performed instead of just addition/subtraction.	2023-04-08 01:30:29 +02:00
Micha Lehmann	f1de560d57	Snap editor selection rotation when holding shift	2023-04-08 01:30:29 +02:00
Dean Herbert	0c71fa1bbd	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-06 23:39:57 +09:00
Dean Herbert	ad717d2368	Fix scheduled calls piling up during transactions	2023-04-06 23:39:36 +09:00
Andrei Zavatski	ed565b1e59	Fix SampleStore isn't being disposed	2023-04-06 11:40:04 +03:00
Dean Herbert	e6872629f3	Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable ... Don't show epilepsy warning when storyboards are disabled	2023-04-06 12:32:38 +09:00
tsrk	809b817e8e	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-05 22:57:36 +02:00
Bartłomiej Dach	ba753a8aac	Merge branch 'master' into update-skinnable-sound-before-playing	2023-04-05 22:56:25 +02:00
Bartłomiej Dach	27055919a3	Merge branch 'master' into fix-old-beatmap-crash-on-load	2023-04-05 21:39:42 +02:00
Bartłomiej Dach	6df7614b9d	Add tests for suppressing epilepsy warning when storyboard disabled	2023-04-05 20:56:50 +02:00
Bartłomiej Dach	e5d57a65c9	Fix incorrect indent	2023-04-05 19:47:25 +02:00
Bartłomiej Dach	432f698697	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-05 19:45:14 +02:00
Dean Herbert	9c8b25e034	Fix display not always updating when expected by updating on a schedule	2023-04-05 13:45:24 +09:00
Dean Herbert	f07d859532	Optimise how often we update the display	2023-04-04 19:31:33 +09:00
Dean Herbert	3209b09270	Move inspector into own file	2023-04-04 19:17:34 +09:00
Dean Herbert	4aed483005	Tidy up dependency resolution	2023-04-04 19:14:30 +09:00
Dean Herbert	195b5fc3f1	Add view for selections of size != 1	2023-04-04 19:11:48 +09:00
Dean Herbert	b0d5761667	Add object type	2023-04-04 19:05:50 +09:00
Dean Herbert	c356c163fa	Add hit object inspector view	2023-04-04 19:03:45 +09:00
Dean Herbert	f9ebdadfe8	Move right-side editor toolbox to base HitObjectComposer ... Move right-side editor toolbox to base `HitObjectComposer`	2023-04-04 19:00:56 +09:00
Bartłomiej Dach	1a5707b65f	Merge pull request #22878 from peppy/fix-replay-fail-on-exit ... Ensure replays don't enter a failed state when exiting gameplay	2023-04-03 22:38:32 +02:00
Bartłomiej Dach	8cc425774b	Merge branch 'master' into fix-replay-fail-on-exit	2023-04-03 21:23:23 +02:00
Bartłomiej Dach	7dfd903b76	Merge branch 'master' into fix-debug-perf-drd	2023-04-03 21:04:18 +02:00
Bartłomiej Dach	b5d9284de2	Merge pull request #23108 from peppy/fix-overlay-toggles-during-disclaimer ... Fix attempting to show overlay during game intro playing hide sound effects	2023-04-03 20:48:03 +02:00
cdwcgt	9dd30e4b4c	condition fix	2023-04-03 20:24:38 +09:00
cdwcgt	735b48679e	use LinkFlowContainer directly	2023-04-03 20:09:49 +09:00
cdwcgt	41c01d3929	nullable condition	2023-04-03 20:07:21 +09:00
cdwcgt	51240ed46b	typo	2023-04-03 19:51:22 +09:00
Dean Herbert	7011928d86	Fix abysmal debug performance due to try-catch logic in DrawableRulesetDependencies	2023-04-03 18:04:33 +09:00
Dean Herbert	b0c09df259	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-03 15:33:35 +09:00
Dean Herbert	43d7386623	Merge pull request #22926 from Joehuu/fix-sort-direction-not-resetting ... Fix beatmap listing sort direction not resetting when changing criteria	2023-04-03 15:32:10 +09:00
Dean Herbert	e4eb736622	Merge pull request #22929 from Joehuu/fix-loading-blocking-overlay-headers ... Fix beatmap listing filter control being blocked by loading layer	2023-04-03 15:29:38 +09:00
Dean Herbert	a097433cb1	Fix overlay toggle keys working during disabled activation modes ... Closes #23104.	2023-04-03 15:03:47 +09:00
Joseph Madamba	247d426c8a	Add horizontal padding to currently playing search textbox	2023-04-02 20:50:18 -07:00
Joseph Madamba	436f1e4ae4	Replace other hardcoded horizontal padding with const ... - Also add overlay stream item padding const and account for it	2023-04-02 20:50:18 -07:00
Joseph Madamba	af389b1107	Replace all hardcoded 50 horizontal padding with const	2023-04-02 20:50:18 -07:00
Joseph Madamba	7a0edabd5d	Normalise overlay horizontal padding const	2023-04-02 20:24:13 -07:00
Dean Herbert	daf9f19b29	Merge pull request #23098 from Joehuu/update-vote-pill-hover ... Update comment vote pill in line with web	2023-04-03 12:01:46 +09:00
Dean Herbert	8932668f77	Update framework	2023-04-03 10:31:47 +09:00
Joseph Madamba	63ea17f10e	Update comment vote pill in line with web	2023-04-02 18:17:40 -07:00
Susko3	c3a6a58169	Fix window mode dropdown not showing	2023-04-02 19:23:18 +02:00
Dean Herbert	1e0b64c9e8	Update framework (again)	2023-04-02 23:07:40 +09:00
cdwcgt	d949ef3ca4	make guestMapperContainer private ... tests don't use it	2023-04-02 22:53:15 +09:00
cdwcgt	2cf8636366	show guest diff author in BeatmapPicker	2023-04-02 22:25:58 +09:00
Dean Herbert	4c2b7e7788	Fix random inspection showing up only in CI	2023-04-02 21:05:20 +09:00
Dean Herbert	cf5acbf66e	Update usage of SupportedWindowModes	2023-04-02 20:16:14 +09:00
Dean Herbert	0f0dd9f2dc	Update resources	2023-04-02 20:07:33 +09:00
Dean Herbert	7f9bf09e03	Update framework	2023-04-02 20:07:31 +09:00
Dean Herbert	4b294278d6	Merge branch 'master' into fix-ruleset-shader-caching	2023-03-31 20:04:55 +09:00
Dean Herbert	1277c8eb5a	Merge branch 'master' into debug-use-en-localisation-fallbacks	2023-03-31 17:26:56 +09:00
Dan Balasescu	4b7d44c329	Remove unused using	2023-03-31 16:23:56 +09:00
Dan Balasescu	28f31ef379	Adjust comment slightly	2023-03-31 16:23:37 +09:00
Dan Balasescu	d5b8a45541	Always use fallback strings for English ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-03-31 16:20:16 +09:00
Bartłomiej Dach	bfbb5ab96b	Merge branch 'master' into fix-fail-progression-to-results	2023-03-30 21:40:49 +02:00
Dean Herbert	796cd9c916	Rewrite comment explaining early return on checkScoreCompleted given new usages	2023-03-31 02:36:17 +09:00
Dean Herbert	b25a59fd14	Rename scoreCompleted -> checkScoreCompleted to reflect the fact it doesn't always succeed	2023-03-31 02:30:04 +09:00
cdwcgt	5d395e6d37	move to ctor	2023-03-29 22:59:54 +09:00
cdwcgt	19b7036b95	use same same duration ... negligence in migrating code	2023-03-29 22:56:35 +09:00
cdwcgt	e85c28031e	change weird name	2023-03-29 22:55:25 +09:00
Dean Herbert	72c5c9848f	Always use LocalisableString fallbacks when deploying debug and viewing english ... This allows changes to `xxxStrings.cs` files to immediately reflect in the UI, which is (at least for me) an expectation.	2023-03-29 14:44:43 +09:00
Dean Herbert	c7003434b2	Fix localisation for audio device error containing incorrect newline escaping	2023-03-29 14:33:10 +09:00
Dean Herbert	4dd0c2c7a5	Add assert ensuring we don't ever get to the results screen with an F rank ... Intentionally an assertion as I want tests to fail, but I don't want this to cause crashes for an end user if it does happen to occur.	2023-03-29 14:11:58 +09:00
Dean Herbert	a8bb2e33ac	Ensure all preconditions are checked before progressing to results screen after storyboard ends	2023-03-29 14:00:11 +09:00
Dean Herbert	aad540629f	Remove duplicate load rule from ShaderPrecompiler	2023-03-29 12:36:56 +09:00
cdwcgt	46ede27869	add feature to adjust ScalingContainer background dim	2023-03-28 22:41:24 +09:00
cdwcgt	31df626f0e	disable button when select other reason	2023-03-28 21:32:28 +09:00
cdwcgt	899860dd77	Merge branch 'master' into chat-report	2023-03-28 21:14:11 +09:00
Dean Herbert	8c1df3c8d9	Fix web account registration not bypassing the URL warning	2023-03-28 15:38:19 +09:00
Dean Herbert	0d77ec013a	Fix ruleset-local shader manager not correctly falling back to existing cached shaders	2023-03-28 15:00:49 +09:00
Dean Herbert	5dfac02b11	Preload triangle shader on startup	2023-03-28 14:15:38 +09:00
Dean Herbert	c742b3f0a8	Update DrawableRulesetDependencies xmldoc to read more correctly	2023-03-28 14:15:19 +09:00
cdwcgt	b065689cf8	Limit the area of popover to DrawableChannel ... popover may be blocked by textBar	2023-03-27 23:04:45 +09:00
Joseph Madamba	8b30c67580	Fix incorrect song select matching label by showing both beatmap and difficulty count for less ambiguity	2023-03-26 18:08:28 -07:00
Joseph Madamba	76a6f97fbb	Fix wrong definition of a beatmap in first run setup	2023-03-26 17:32:03 -07:00
Joseph Madamba	3e0bbb2432	Fix select beatmap button not highlighting when creating a multiplayer room using keyboard	2023-03-26 16:03:21 -07:00
Dean Herbert	6924dc5c50	Update framework	2023-03-27 02:16:33 +09:00
Dean Herbert	898717231b	Hide vulkan renderer option for now ... We'll bring it back when it's more stable.	2023-03-27 02:00:10 +09:00
Bartłomiej Dach	292486c25a	Use more resilient restore method	2023-03-26 14:35:00 +02:00
Bartłomiej Dach	f3c174a7f2	Fix test errors due to missing dependencies	2023-03-26 13:52:26 +02:00
Dean Herbert	bab93bed17	Fix string interpolation and use GetDescription on renderer value	2023-03-26 20:43:28 +09:00
Dean Herbert	ba078e8357	Show "automatic" resolved renderer inline in dropdown instead	2023-03-26 20:29:30 +09:00
Dean Herbert	764361b3d3	Add special case to hide definitely non-working renderers on android	2023-03-26 20:14:33 +09:00
Dean Herbert	e346b02ebf	Add display of current renderer	2023-03-26 20:09:35 +09:00
Dean Herbert	91da546ba2	Merge branch 'master' into add-renderer-selection	2023-03-26 19:33:15 +09:00
Dean Herbert	c803eb8e04	Update framework	2023-03-26 16:14:15 +09:00
Dean Herbert	d31b37e87e	Merge branch 'master' into fix-ubo-not-bound	2023-03-26 16:14:11 +09:00
Joseph Madamba	eaef5ff2a3	Fix now playing playlist not highlighting selected item on initial open	2023-03-25 22:13:51 -07:00
Joseph Madamba	e1906a90eb	Use image@2x from tournament banner api	2023-03-25 13:08:46 -07:00
Joseph Madamba	450c5cef07	Add comment explaining loading container padding	2023-03-24 18:42:34 -07:00
Terochi	e6f1ec57a9	Bring back and make use of clearPreviousSamples()	2023-03-23 18:46:48 +01:00
Dean Herbert	ab6cfea5c7	Revert old value instead of always using default ... Co-authored-by: cdwcgt <loginchen@outlook.com>	2023-03-23 11:27:05 +09:00
cdwcgt	26f2d9047d	code style fix	2023-03-23 01:11:44 +09:00
cdwcgt	85a924f078	why ... merge problem?	2023-03-23 01:02:17 +09:00
cdwcgt	8518d15b8d	use endpoint	2023-03-23 01:00:38 +09:00
Dean Herbert	3050a16bf8	Don't require a restart when selecting Automatic and startup setting was also automatic	2023-03-22 16:56:36 +09:00
Dean Herbert	aabe86dc26	Limit renderers to those available for the current platform	2023-03-22 16:49:29 +09:00
Dean Herbert	956fabb445	Show restart notice when changing renderer	2023-03-22 16:49:29 +09:00
Dean Herbert	13be709718	Add basic renderer selection	2023-03-22 16:49:29 +09:00
Dean Herbert	ad5bdf6511	Merge branch 'master' into fix-ubo-not-bound	2023-03-22 16:46:39 +09:00
Dean Herbert	9bc6b46e4e	Update framework	2023-03-22 16:36:05 +09:00
Dean Herbert	db227b1798	Merge branch 'master' into chat-report	2023-03-22 16:26:28 +09:00
Joseph Madamba	6f3bb85eaa	Always show down arrow on inactive sort buttons	2023-03-22 00:19:23 -07:00
Dean Herbert	c65a79614d	Don't show offset calibration controls when "relax" mod is active ... Closes https://github.com/ppy/osu/issues/22892.	2023-03-22 15:45:04 +09:00
Dean Herbert	425be20e46	Fix song select search textbox font size incorrectly having increased	2023-03-22 14:17:39 +09:00
Joseph Madamba	d9571b6fc9	Move filter control property setters to load()	2023-03-21 21:31:35 -07:00
Joseph Madamba	74a15d7424	Fix overlay headers being blocked by loading layer	2023-03-21 20:32:26 -07:00
Joseph Madamba	e1fb63e1f3	Move beatmap listing filter control to header	2023-03-21 20:32:26 -07:00
Terochi	1478a26cc0	Addressed changes	2023-03-21 23:15:49 +01:00
Joseph Madamba	3cd01ee621	Fix beatmap listing sort direction not resetting when changing criteria	2023-03-21 15:08:37 -07:00
Joseph Madamba	df3ccdff9f	Add failing beatmap listing sort direction on criteria change test	2023-03-21 15:08:37 -07:00
Bartłomiej Dach	9ff9cd3b7f	Merge branch 'master' into skin-editor-cyclic-selection	2023-03-21 19:49:55 +01:00
Dean Herbert	e31a90e043	Don't cycle selection when more than one items are selected	2023-03-21 21:31:10 +09:00
Dean Herbert	5cb8160eee	Merge pull request #22773 from peppy/show-song-select-visible-beatmap-count ... Show count of visible beatmaps at song select	2023-03-21 18:22:29 +09:00
Bartłomiej Dach	ea8da69263	Fix importing beatmaps not changing count of visible beatmaps ... Reproduction steps: 1. Go to song select 2. Open beatmap listing 3. Import a beatmap that would fit the current filter criteria 4. The count of visible beatmaps does not change Fixed by updating the count on `BeatmapSetsChanged` too.	2023-03-20 20:53:53 +01:00
Bartłomiej Dach	695ee39b87	Privatise setter	2023-03-20 20:30:54 +01:00
Dean Herbert	bec28cc7f1	Merge pull request #22883 from smoogipoo/fix-logo-animation ... Use custom vertex shader for logo animation	2023-03-20 16:36:43 +09:00
Dean Herbert	8557589a35	Update resources	2023-03-20 15:28:13 +09:00
Joseph Madamba	970df5d88a	Update profile kudosu section in line with web	2023-03-18 19:49:30 -07:00
Dan Balasescu	c08513d590	Actually use custom vertex action	2023-03-17 20:47:11 +09:00
Dan Balasescu	bcd24873d6	Use custom vertex type	2023-03-17 20:37:05 +09:00
Dean Herbert	8bdb89d05d	Update resources	2023-03-17 19:12:43 +09:00
Dan Balasescu	1c3b60b9e6	Use custom vertex shader for logo animation	2023-03-16 23:56:41 +09:00
Salman Ahmed	678e8ed736	Update UBO usages inline with framework changes	2023-03-16 14:06:35 +03:00
Cootz	54f864463c	Merge branch 'master' into BitmapUpdatesOnScore	2023-03-16 13:54:47 +03:00
cdwcgt	d025c441ca	delay mod save after click save or not popover hidden	2023-03-16 19:48:45 +09:00
Dean Herbert	cb9b14b30f	Revert "Merge pull request #22741 from cdwcgt/do-not-fetch-deletePending" ... This reverts commit 15c44a2817, reversing changes made to de2ab05e78.	2023-03-16 19:48:36 +09:00
cdwcgt	42bcc8bafc	revert mod store	2023-03-16 19:38:15 +09:00
Cootz	556964eae0	Merge branch 'master' into BitmapUpdatesOnScore	2023-03-16 12:16:42 +03:00
Dean Herbert	3b62f87b64	Ensure Player does not fail a score on exit if a replay is currently loaded	2023-03-16 17:14:20 +09:00
Dean Herbert	15c44a2817	Merge pull request #22741 from cdwcgt/do-not-fetch-deletePending ... Don't fetch `beatmapset` that already `PendingDelete` when import score	2023-03-16 16:37:18 +09:00
Dean Herbert	cd102da3af	Move matches string inside text box	2023-03-16 16:34:31 +09:00
Dean Herbert	8e6a4559e3	Add xmldoc for new method and reorder methods in SkinReloadableDrawable	2023-03-16 15:58:42 +09:00
Dean Herbert	297e7d6542	Fix Flush call being run too late in PoolableSkinnableSample	2023-03-16 15:33:30 +09:00
Dean Herbert	89b42ddd98	Don't localise beatmap count string for now	2023-03-16 15:02:38 +09:00
Dean Herbert	7b34607676	Merge branch 'master' into bubble_mod_implementation_clean	2023-03-16 13:45:22 +09:00
Terochi	edc6314634	Drank some coffee and figured out the fix	2023-03-15 10:49:59 +01:00
Dean Herbert	5f9b13a775	Rename Add/AddRange methods as they are no longer conflicting with Container	2023-03-15 18:02:41 +09:00
Dean Herbert	9e444af380	Use object initialisers and fix order of initialisation vs add	2023-03-15 18:02:26 +09:00
Terochi	b0f1a69523	Update the pauseLoop sample instantly on skin change	2023-03-15 09:05:34 +01:00
Terochi	a9c349fa6d	Cache any skin changes in SkinReloadableDrawable to ScheduledDelegate	2023-03-15 09:03:29 +01:00
Dean Herbert	de2ab05e78	Merge pull request #22765 from Joehuu/fix-overlay-sidebar-scroll ... Fix overlay sidebars not scrolling to end due to parent scroll view	2023-03-15 16:52:59 +09:00
Dean Herbert	0a19b1e9cf	Merge pull request #22860 from rozukke/fix-skin-ini-import ... Fix import of skins with non-ASCII names that have been previously exported by lazer	2023-03-15 15:36:51 +09:00
Dean Herbert	f8e773ab8e	Merge branch 'master' into fix-overlay-sidebar-scroll	2023-03-15 15:30:50 +09:00
Dean Herbert	1cf870d956	Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection	2023-03-15 15:16:48 +09:00
Terochi	390ad335d0	Reloading samples before playing then when skin change occurs	2023-03-14 21:35:52 +01:00
Terochi	1d5e596615	Update FailAnimation to use SkinnableSound	2023-03-14 20:44:30 +01:00
Dean Herbert	f91af8fa64	Merge pull request #22750 from smoogipoo/veldrid-renderer ... Update graphic code in line with framework renderer changes	2023-03-15 00:29:54 +09:00
Dean Herbert	6546f5968a	Merge branch 'master' into skin-editor-cyclic-selection	2023-03-14 20:43:56 +09:00
Dean Herbert	b46fc14e56	Merge pull request #22848 from Rovearix/Fix-Dragging-Preventing-Beatmap-Loading ... Prevent LoadingLayer from blocking loading	2023-03-14 20:42:10 +09:00
Dean Herbert	d65d09e45f	Change field to const	2023-03-14 20:24:39 +09:00
Dean Herbert	8fd07b51f7	Merge pull request #22842 from LumpBloom7/Fix-argon-progress-bar-oversized-fill ... Fix argon progress bar fill being oversized	2023-03-14 18:46:25 +09:00
Dean Herbert	4cea29402b	Don't show epilepsy warning when storyboards are disabled ... I have more thoughts on this warning in general (which will likely see it removed or moved in the future) but this seems like a quick QOL fix for now. As mentioned in https://github.com/ppy/osu/discussions/22861.	2023-03-14 18:32:26 +09:00
Dean Herbert	0b23809585	Update resources	2023-03-14 17:52:17 +09:00
Dean Herbert	48d11610b3	Update framework	2023-03-14 17:44:51 +09:00
Dean Herbert	969c0e9c9d	Merge branch 'master' into veldrid-renderer	2023-03-14 17:35:38 +09:00
Rovearix	9ac9287dbd	Switched the implementation to set the blockInput flag for the BeatmapMetadataDisplay's LoadingLayer. This prevents the UIEvents from being being handled in this case without modifying the class	2023-03-13 08:07:55 -04:00
Rovearix	ba728bdab1	Changed the event to be the more correct one to block	2023-03-13 07:49:51 -04:00
rozukke	1f7721786b	Perform check to account for non-ASCII characters	2023-03-13 22:01:26 +11:00
Dean Herbert	da947d8661	Gracefully handle beatmaps specifying images using the video storyboard type	2023-03-13 18:24:16 +09:00
Dean Herbert	eb37d740b1	Update supported video filetypes to match osu-stable	2023-03-13 18:24:16 +09:00
Rovearix	c1618a7a16	Prevent elements that are anchored in the center from blocking loading	2023-03-12 10:57:53 -04:00
Joseph Madamba	6e5b1280b7	Fix multiple notice boxes having no spacing	2023-03-11 21:36:29 -08:00
Joseph Madamba	ea88aee41f	Display stub notice in marked wiki articles	2023-03-11 21:36:28 -08:00
Joseph Madamba	0cf69a1084	Make yaml line strings verbatim	2023-03-11 21:36:23 -08:00
Derrick Timmermans	febdca4547	Fix argon progress bar fill being oversized	2023-03-12 02:08:00 +01:00
Terochi	8e8dda3ac0	Big simplifying	2023-03-11 23:29:36 +01:00
Dan Balasescu	e327993d11	Merge pull request #22527 from Terochi/replay-length-extension ... Replay recording extension until results screen transition	2023-03-11 15:41:32 +09:00
cdwcgt	15f11bb1e8	scorll container and save mod after popover hidden ... Requires manual handling of many visual effects	2023-03-11 12:31:33 +09:00
cdwcgt	1cd565193e	public CheckCurrentModCanBeSave	2023-03-11 11:39:35 +09:00
cdwcgt	8b0f127ff2	split ModPresetRow	2023-03-11 11:25:52 +09:00
Terochi	b51c41a804	Addressed changes	2023-03-09 20:14:58 +01:00
cdwcgt	f4e2620402	fix test	2023-03-10 00:56:22 +09:00
cdwcgt	ca416175bb	remove useless property	2023-03-09 22:58:44 +09:00
cdwcgt	3d746e8dfb	content Menu	2023-03-09 22:49:33 +09:00
cdwcgt	5a1316f0e5	split save logic	2023-03-09 22:43:06 +09:00
tsrk	d806b85a30	revert: make counters an IEnumerable again ... As suggested by bdach as this would make the last two commits useless Refs: 5d15426	2023-03-09 10:25:03 +00:00
Dean Herbert	d95bcb10cc	Merge pull request #22744 from EXtremeExploit/groups-badges-list ... Add group badges to list view	2023-03-09 15:45:46 +09:00
Bartłomiej Dach	ab87f5e0c9	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-03-08 22:37:09 +01:00
EXtremeExploit	686259a33c	Make support badge in list match groups	2023-03-08 13:57:20 -03:00
Dean Herbert	4f7be332f3	Revert isDraggingBlueprint to field	2023-03-08 19:24:03 +09:00
Dean Herbert	245c3c025c	Refactor endClickSelection to reduce nesting	2023-03-08 19:23:32 +09:00
tsrk	5d15426c27	refactor: make Counters return a Container	2023-03-08 01:52:12 +00:00
tsrk	5b0db94a24	docs: add XMLDoc for methods in KCD	2023-03-08 00:58:54 +00:00
tsrk	44297a7d0a	refactor: make KCD a CompositeDrawable	2023-03-08 00:47:16 +00:00
Bartłomiej Dach	72695f7c90	Merge branch 'master' into omit-barline-in-timing-control-point	2023-03-07 22:46:24 +01:00
Bartłomiej Dach	6c5ccdfd90	Merge branch 'master' into optimise-search	2023-03-07 22:07:29 +01:00
Bartłomiej Dach	12af002c4d	Reorder and add xmldoc to KeyCounter members	2023-03-07 21:28:42 +01:00
Bartłomiej Dach	98f40b2679	Improve documentation of InputTrigger	2023-03-07 21:22:59 +01:00
Bartłomiej Dach	5213bfa5c9	Merge branch 'master' into make_skin_reset_dangerous	2023-03-07 21:06:44 +01:00
Terochi	8bf84869a5	Fixed errors covered in new tests	2023-03-07 20:39:50 +01:00
Bartłomiej Dach	cfafa8af8c	Merge branch 'master' into hud/player-components	2023-03-07 19:44:12 +01:00
Bartłomiej Dach	7ade525eef	Display corner radius setting as percentage	2023-03-07 19:43:52 +01:00
Cootz	5d41d343fd	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-03-07 15:46:52 +03:00
Cootz	7107834b9e	Fix truncating bug	2023-03-07 15:43:03 +03:00
Cootz	5191204569	Bring truncating logic back to Export method	2023-03-07 15:39:43 +03:00
cdwcgt	54564e0557	new design	2023-03-07 21:13:35 +09:00
Dean Herbert	97bee4db89	Fix localisations	2023-03-07 18:07:53 +09:00
Dean Herbert	26ef7c2637	Rename confirmation dialog class to mention revert not reset	2023-03-07 18:07:46 +09:00
Dean Herbert	55467fcbe3	Update xmldoc for DangerousActionDialog to match new behaviour	2023-03-07 18:07:46 +09:00
Dean Herbert	dc2945f4f8	Move avatar user loading to BDL also	2023-03-07 17:39:21 +09:00
Dean Herbert	5af41bb1c8	Move filter matching code into own method to simplify early returns	2023-03-07 17:24:17 +09:00
Dean Herbert	5e90b67be0	Move GameplayState usage to BDL	2023-03-07 17:01:29 +09:00
Dean Herbert	d98199961b	Adjust default sizing to fit a bit better with existing elements	2023-03-07 17:00:10 +09:00
Dean Herbert	f7f1dff647	Fix incorrect case of localisable string for "corner radius"	2023-03-07 16:45:33 +09:00
Dean Herbert	6a7c4d0bf7	Remove NRT disables in new classes	2023-03-07 16:41:39 +09:00
Dean Herbert	97ba236eb1	Add basic xmldoc to KeyCounter classes	2023-03-07 16:41:39 +09:00
Dean Herbert	28520414aa	Move KeyCounter components to HUD namespace	2023-03-07 16:41:39 +09:00
Dean Herbert	15d65059b5	Tidy up Add method logic	2023-03-07 16:21:57 +09:00
Dean Herbert	8f6df5ea0f	Merge branch 'master' into gameplay/key-counter-abstraction	2023-03-07 16:09:45 +09:00
Dean Herbert	2cce785fa5	Fix storyboard videos not fading out on completion ... Closes https://github.com/ppy/osu/issues/22802. Stable uses a 1,000 ms fade-in / out. Rather than matching that, I've stuck with 500ms (what lazer was already using for the fade-in) because I think it feels better. Tested using the beatmap linked in the issue thread.	2023-03-07 15:54:35 +09:00
Dean Herbert	21bdbb20e6	Add optional support for cyclic selection to BlueprintContainer	2023-03-07 14:22:12 +09:00
tsrk	fc0e27fb15	style: use normalised CornerRadius values	2023-03-06 20:11:52 +00:00
tsrk	952814604e	style: fix late night oopsies	2023-03-06 20:06:56 +00:00
cdwcgt	4858d3fd42	Added ability to edit mod presets	2023-03-07 02:00:40 +09:00
Bartłomiej Dach	ec15e2b9cc	Merge branch 'master' into dont-filter-results-on-sort-mode	2023-03-06 17:57:47 +01:00
OliBomby	1fcf41379d	Added maintainability patch by bdach	2023-03-06 16:20:36 +01:00
tsrk	3a240aaa5f	style: use 64 radius	2023-03-06 10:27:59 +00:00
Dean Herbert	87d0bef313	Use nullable comparison helper method instead of manual implementation	2023-03-06 15:16:32 +09:00
tsrk	07bde4990d	feat: implement PlayerAvatar	2023-03-05 23:17:39 +00:00
tsrk	20a610ea6c	style: a NRT pass on UpdateableFlag	2023-03-05 23:15:58 +00:00
tsrk	654eacd449	feat(l10n): localise CornerRadius	2023-03-05 23:10:42 +00:00
tsrk	082bfe3621	refactor: SkinnableAvatar to PlayerAvatar	2023-03-05 23:09:02 +00:00
mk56-spn	908651cc11	make ResetConfirmDialog properly utilise its parent's logic ... Adjust name of `DeleteAction` to `DangerousAction`	2023-03-05 20:57:26 +01:00
OliBomby	b0cd801405	fix code quality	2023-03-04 19:34:22 +01:00
OliBomby	5146f7c978	using array again in GetSearchableTerms	2023-03-04 16:49:46 +01:00
OliBomby	70a925aab1	added extra early-returns	2023-03-04 16:49:33 +01:00
OliBomby	b90c389ff0	using List instead of Span in GetSearchableTerms	2023-03-04 15:42:35 +01:00
Bartłomiej Dach	60cdd3c070	Clear components sidebar unconditionally on every target change ... Fixes the working layer dropdown lingering after exiting from a skinnable screen to a non-skinnable one.	2023-03-04 14:10:05 +01:00
Bartłomiej Dach	d233f3a3ab	Show non-skinnable screen placeholder at higher level	2023-03-04 13:49:10 +01:00
Bartłomiej Dach	49e298e304	Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer ... An end result of #22674 is that `SkinBlueprintContainer`s are only ever created by supplying a `SkinComponentsContainer` to them. However, `SkinBlueprintContainer` still contained remnants of code that suggested it was designed to handle cases where more than the drawable supplied to it contained more than one `ISerialisableDrawableContainer`, or even zero. The zero path is totally dead right now (because every `SkinComponentsContainer` is *by necessity* an `ISerialisableDrawableContainer`), and the more-than-one path is dead *for now* (and potentially forever?). Therefore, just hard-couple `SkinBlueprintContainer` to receive a single target container.	2023-03-04 13:33:21 +01:00
Bartłomiej Dach	2f25fb4083	Move NonSkinnableScreenPlaceholder to outer scope	2023-03-04 13:22:43 +01:00
Bartłomiej Dach	15409b9c15	Fix skin selection not clearing on exit to non-skinnable screen	2023-03-04 13:18:34 +01:00
tsrk	d5ba5eed88	fix(SkinnableAvatar): init avatar.CornerRadius	2023-03-03 23:47:22 +00:00
tsrk	d39b8c7c23	fix(SkinnableAvatar): update outdated interface	2023-03-03 19:35:45 +00:00
EXtremeExploit	edd37a9a7c	cleanup	2023-03-03 16:16:45 -03:00
EXtremeExploit	e23db62386	Do list group'badges in a nicer way	2023-03-03 16:14:19 -03:00
Ruki	e75aa9138b	Merge branch 'ppy:master' into hud/avatar-thing	2023-03-03 20:03:56 +01:00
OliBomby	91d206e8d2	Optimised GetSearchableTerms ... Reduced memory allocations to 1	2023-03-03 19:21:50 +01:00
Cootz	322f3e86ba	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-03-03 20:02:09 +03:00
mk56-spn	3bff415909	Change ResetDialogue text	2023-03-03 15:16:48 +01:00
mk56-spn	2b7111867c	Adjust reversion header text naming.	2023-03-03 15:12:20 +01:00
Dean Herbert	82293c0c86	Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes ... From a user's perspective, changing a sort / order mode shouldn't filter away results, but we were doing this. In terms of UX expectations, in stable this kind of scenario would results in a group being added to the end of son select with "Not ranked" or "Unknown". I think we should aim to match this eventually.	2023-03-03 16:36:18 +09:00
Dean Herbert	dc669835e2	Show count of visible beatmaps at song select	2023-03-03 15:28:51 +09:00
Dean Herbert	6ff1fb6b1a	Adjust sizing to allow for timing point information now being longer than before	2023-03-02 18:57:54 +09:00
Joseph Madamba	af540de69b	Fix "talking with" text overflowing when usernames are too long	2023-03-01 22:10:15 -08:00
Joseph Madamba	bb5791a714	Fix overlay sidebars not scrolling to end due to parent scroll view	2023-03-01 21:41:01 -08:00
Dean Herbert	bd11d5d29a	Merge pull request #22743 from Joehuu/scroll-back-to-previous ... Add ability to scroll back to previous position after scrolling to top via button on overlays	2023-03-01 22:55:47 +09:00
Andrei Zavatski	31f58a33ac	Use ColourInfo.Interpolate where possible	2023-02-28 18:47:27 +03:00
Dean Herbert	044b0604b2	Move OmitFirstBarLine to TimingControlPoint	2023-02-28 19:29:31 +09:00
Dean Herbert	89e20a7962	Update resources	2023-02-28 14:47:51 +09:00
Dean Herbert	bd1460a8d5	Update framework	2023-02-28 14:32:58 +09:00
mk56-spn	90227a6496	Rename DeleteConfirmationDialog.cs into DangerousActionDialog.cs	2023-02-27 21:57:59 +01:00
mk56-spn	00a00ead22	Make ResetConfirmDialog inherit from DeleteConfirmationDialog	2023-02-27 21:50:27 +01:00
mk56-spn	1239de6f41	Upper case web using alias	2023-02-27 21:34:07 +01:00
Bartłomiej Dach	92edb0f868	Merge branch 'master' into skin-editor-depth-changing	2023-02-27 19:24:53 +01:00
mk56-spn	bf1897a98f	Adjust warning text slightly.	2023-02-27 16:08:14 +01:00
EXtremeExploit	d722e09b2c	oops	2023-02-26 21:05:41 -03:00
EXtremeExploit	2b9d13cfee	Add group badges to list view	2023-02-26 20:58:20 -03:00
Joseph Madamba	fa710ae1b0	Rename ScrollToTopButton to ScrollBackButton	2023-02-26 14:39:34 -08:00
Joseph Madamba	dc00905f8d	Add ability to scroll back to previous position after scrolling to top via button on overlays	2023-02-26 14:38:51 -08:00
mk56-spn	ff0d1aa9f7	Make reverting changes to a given skin into a "dangerous action"	2023-02-26 20:38:50 +01:00
cdwcgt	a705698ab6	beatmapset that already deletePending should not be fetched	2023-02-26 21:13:05 +09:00
cdwcgt	1d5c87039e	typo	2023-02-26 15:28:43 +09:00
cdwcgt	e8092bff46	logic fix?	2023-02-26 15:28:24 +09:00
cdwcgt	fdf9544688	cancel handle	2023-02-26 15:28:10 +09:00
cdwcgt	a20e2685be	make static name fix	2023-02-25 20:11:08 +09:00
Dan Balasescu	a44c9d10d7	Fix buffer not being bound	2023-02-25 02:18:42 +09:00
Dan Balasescu	069b77dd23	Update language version	2023-02-25 02:15:56 +09:00
Dan Balasescu	dd9748a25c	Adjust DrawNodes to use UBOs	2023-02-25 01:42:55 +09:00
Terochi	09e7c21b23	Implemented a more complex setting conversion logic + tests	2023-02-24 15:11:22 +01:00
cdwcgt	78201c4649	log to database	2023-02-23 22:17:35 +09:00
cdwcgt	60bdae41b6	make static	2023-02-23 22:17:13 +09:00
Dean Herbert	dc3c1150b8	Set better defaults for SkinBlueprint transforms	2023-02-23 21:10:15 +09:00
cdwcgt	9e1eb50d9b	use log	2023-02-23 20:21:04 +09:00
cdwcgt	ba345e5591	delete notify post when duplicate export	2023-02-23 20:10:50 +09:00
Dean Herbert	c48aceb055	Fix undo history not being batched correctly for depth change operations	2023-02-23 20:03:36 +09:00
Bartłomiej Dach	d679703fa2	Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection ... Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play	2023-02-22 18:56:59 +01:00
tsrk	8c94b77de1	refactor(InputTrigger): move out of KCD ... I love JetBrains Rider.	2023-02-22 15:05:07 +00:00
tsrk	1beec71037	refactor(KeyCounterDisplay): apply suggestions ... I also took the freedom to add type checking, as we can't limit the usage of `Add()` since it's a Container. The exception thrown also advises of using the suggested `AddTrigger()` instead.	2023-02-22 14:58:27 +00:00
Dean Herbert	a8c692a215	Merge pull request #22635 from peppy/use-overlays-container-more ... Use `Overlays` container rather than `KeyBindingInputManager` for flashlight	2023-02-22 18:30:21 +09:00
Dean Herbert	16c8a392a1	Add ability to send selected skin components to front or back	2023-02-22 18:17:20 +09:00
Dean Herbert	6e48860c79	Update in line with framework menu handling changes	2023-02-22 17:13:55 +09:00
Terochi	e321536acc	Small clean up	2023-02-22 07:48:43 +01:00
Terochi	82b07d19f8	Fix of incorrect using optimization	2023-02-21 21:48:11 +01:00
Bartłomiej Dach	051eb18b33	Merge branch 'master' into skin-editor-layer-select	2023-02-21 21:38:51 +01:00
Bartłomiej Dach	ab97b02235	Remove contradictory remark from xmldoc	2023-02-21 21:05:46 +01:00
Terochi	dd53a70071	Addressed change requests	2023-02-21 21:01:31 +01:00
Bartłomiej Dach	3d2fcb0cca	Merge branch 'master' into fix-taiko-drum-nested-sample-detection	2023-02-21 20:53:06 +01:00
tsrk	42a5a06b9d	style(KeyCounter): fields and methods visiblity	2023-02-21 19:10:37 +00:00
tsrk	5bec2d7c52	style(KeyCounter): forwardPlayback	2023-02-21 19:02:56 +00:00
Bartłomiej Dach	ec1bf7b0b2	Merge branch 'master' into skin-editor-clipboard	2023-02-21 19:35:58 +01:00
Terochi	191604340f	Added a way for mod settings to be kept when changing ruleset + test	2023-02-21 19:05:10 +01:00
Cootz	1fa6864500	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-21 18:47:59 +03:00
Cootz	90aa4288d0	Reduce the allowed length by 5 to account for (99) suffix. Move truncating logic to GetFilename. Update tests.	2023-02-21 18:35:53 +03:00
cdwcgt	d20e1df603	wrong xmldoc ... because of 6900d0120a	2023-02-21 20:54:06 +09:00
cdwcgt	04dcd661e0	async logic fix	2023-02-21 20:53:02 +09:00
Dean Herbert	9384687d6d	Switch ModMuted to add its metronome to components rather than overlays	2023-02-21 19:04:06 +09:00
Dean Herbert	1acc536248	Move DrawableRuleset.Audio to a less generic level	2023-02-21 19:03:52 +09:00
Dean Herbert	af062e7a68	Change placeComponent to only add to selection, not clear an existing selection	2023-02-21 14:11:18 +09:00
Dean Herbert	5ba6059911	Merge branch 'master' into fix-taiko-drum-nested-sample-detection	2023-02-21 13:58:15 +09:00
Dean Herbert	0d229d959b	Remove unnecessary TriggerChange call	2023-02-21 13:50:19 +09:00
Bartłomiej Dach	6799492596	Merge branch 'master' into skin-editor-layer-select	2023-02-20 21:33:48 +01:00
Bartłomiej Dach	86a7f4dfd0	Do not serialise SkinLayoutInfo.AllDrawables ... - It is entirely derived from `SkinLayoutInfo.DrawableInfo`, which is the actual primary thing we want to serialise. - It will never get read out from any serialised files anyway (corollary of the previous point - it is a get-only property derived from another). - It is only used in tests. All of the three reasons above make serialising the property out to skin files nothing more than a waste of space.	2023-02-20 20:37:48 +01:00
Bartłomiej Dach	c9999bdeb1	Merge branch 'master' into skin-per-ruleset-layouts	2023-02-20 20:14:38 +01:00
Bartłomiej Dach	43724472c4	Clarify comment to avoid playing pronoun game	2023-02-20 20:09:24 +01:00
Dean Herbert	6382314af1	Merge pull request #22697 from ggliv/tablet-area-drag ... Allow tablet area to be dragged	2023-02-20 23:37:25 +09:00
Dean Herbert	43d33d45ca	Only add valid placed components to selected collection on paste	2023-02-20 20:02:43 +09:00
Dean Herbert	b68562b033	Make placeComponent resilient to missing dependencies	2023-02-20 20:00:12 +09:00
Dean Herbert	a9c7edd087	Remove copy pasted comment	2023-02-20 19:57:16 +09:00
Dean Herbert	7a585e1fa1	Merge pull request #22669 from EVAST9919/mod-overlay-triangles ... Add triangles animation to mod select overlay headers	2023-02-20 19:54:21 +09:00
Dean Herbert	ec12186d63	Remove unnecesasry null check on content	2023-02-20 19:53:04 +09:00
Dean Herbert	18700b4daa	Add note about skin migrations being on read and remove an older deprecation notice	2023-02-20 19:51:54 +09:00
Dean Herbert	1629c86b5d	Mark constant identifier as non-localisable ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-02-20 19:48:39 +09:00
Dean Herbert	0ddda018fd	Add xmldoc for SkinComponentsContainerLookup.Ruleset ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-02-20 19:48:18 +09:00
Dean Herbert	5f7a6d13c3	Remove unused GetSerialisableIdentifier for now	2023-02-20 19:47:17 +09:00
Gabe Livengood	c86c1a9029	allow tablet area to be dragged	2023-02-20 00:06:20 -05:00
MK56	b74c1c8334	Merge branch 'master' into bubble_mod_implementation_clean	2023-02-19 21:36:59 +01:00
Bartłomiej Dach	3183f5cee2	Merge branch 'master' into revert-result-in-playfield	2023-02-19 16:33:10 +01:00
Bartłomiej Dach	1ba1298850	Merge branch 'master' into blueprint-improve-visuals	2023-02-19 15:55:30 +01:00
Dean Herbert	d7381b762c	Also tween origin position	2023-02-19 23:52:21 +09:00
Bartłomiej Dach	d9ca7102f0	Use more generic wording for future-proofing	2023-02-19 15:06:40 +01:00
Bartłomiej Dach	aac32a2c9f	Combine config and time checks into one ... Functionally equivalent right now, but the combined variant is more localised to what it actually needs to do, and less error-prone if any new code gets appended to the method.	2023-02-19 13:14:51 +01:00
Maximilian Kruse	723a043c43	naming change from Hitobject to HitObject	2023-02-19 10:18:22 +01:00
Maximilian Kruse	f3522c4162	change bindable seekToHitObject to private	2023-02-19 10:18:02 +01:00
Maximilian Kruse	ddd37bb319	Add setting to disable automatic seeking after object placement	2023-02-18 19:43:45 +01:00
cdwcgt	0667b83960	Path.GetExtension() will not get null	2023-02-19 02:56:53 +09:00
cdwcgt	229b31520f	remove ()	2023-02-19 02:42:33 +09:00
cdwcgt	fba99b344c	Accidentally deleted using ... wtf	2023-02-19 02:41:08 +09:00
cdwcgt	79715fe37b	catch when zipWriter dispose ... ObjectDisposedException also appear when zipwriter dispose after user request cancel	2023-02-19 02:24:07 +09:00
cdwcgt	8446e7d841	comment	2023-02-19 02:17:24 +09:00
cdwcgt	2a6ea99e6a	store exportingModels for all exporter ... No one wants to export multiple copies of the same model at the same time, right?	2023-02-19 02:09:59 +09:00
cdwcgt	30985f192e	catch ObjectDisposedException	2023-02-19 02:06:07 +09:00
cdwcgt	d611603742	catch OperationCanceledException	2023-02-19 01:45:09 +09:00
cdwcgt	309e9b24e2	split LegacyArchiveExporter	2023-02-19 01:18:27 +09:00
Bartłomiej Dach	ea04c487f2	Merge branch 'master' into blueprint-labels-while-hovering	2023-02-18 15:57:30 +01:00
Cootz	5fa75805cc	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-18 15:52:17 +03:00
Bartłomiej Dach	15d209d17e	Merge branch 'master' into CompletionText-LocalisableString	2023-02-18 13:50:58 +01:00
Bartłomiej Dach	fbea3e312f	Merge branch 'master' into skin-editor-improve-toolbox-hover	2023-02-18 10:02:02 +01:00
Bartłomiej Dach	704dddf14b	Merge branch 'master' into skin-editor-clipboard	2023-02-17 22:59:18 +01:00
Bartłomiej Dach	6b9472c367	Merge branch 'master' into skin-per-ruleset-layouts	2023-02-17 22:58:38 +01:00
Bartłomiej Dach	2aa4481f68	Fix toolbox items spontaneously contracting after briefly losing hover ... Reproduction scenario: 1. Hover a toolbox item 2. Unhover the item, but do not hover any other item (can be done by exiting the toolbox completely to the right) 3. Come back to the item hovered in step (1) 4. The item would spontaneously contract after a second	2023-02-17 22:54:11 +01:00
Bartłomiej Dach	b390fdb8cc	Remove unused field	2023-02-17 21:51:19 +01:00
Bartłomiej Dach	8894a73b07	Merge branch 'master' into blueprint-improve-visuals	2023-02-17 21:40:16 +01:00
Andrei Zavatski	ffcca9fd89	Remove awkward width specification	2023-02-17 23:23:58 +03:00
Bartłomiej Dach	6afa65bd3d	Merge branch 'master' into skinnable-clean-up-documentation	2023-02-17 20:59:18 +01:00
Salman Ahmed	449e5fa6f8	Rename one more left-over skinnable naming	2023-02-17 22:09:55 +03:00
cdwcgt	dbb366e279	CompletionText can be a LocalisableString ... I can't find a reason for not doing this, probably this was forgotten in https://github.com/ppy/osu/pull/15440	2023-02-17 22:32:03 +09:00
cdwcgt	843d841f5a	GetFilename and something other ... https://github.com/ppy/osu/pull/21739	2023-02-17 22:23:50 +09:00
cdwcgt	29d6483e17	ConfigureAwait for awaited task	2023-02-17 22:19:24 +09:00
cdwcgt	e84e011d5d	Merge branch 'master' into export	2023-02-17 22:15:19 +09:00
cdwcgt	eac0aa79a3	cancellationToken pass, notification adujust	2023-02-17 22:09:09 +09:00
Cootz	e3bdb3d852	Align links in one line	2023-02-17 15:32:36 +03:00
Cootz	fd1beaef87	Fix typo	2023-02-17 15:24:27 +03:00
Cootz	a3b440493a	Update xml doc	2023-02-17 15:23:43 +03:00
Andrei Zavatski	51940133df	Adjust width and add comment	2023-02-17 15:18:45 +03:00
Andrei Zavatski	0838fa636f	Make triangles slower	2023-02-17 15:16:00 +03:00
Andrei Zavatski	fa300b5ba0	Merge branch 'master' into mod-overlay-triangles	2023-02-17 15:13:51 +03:00
Cootz	ceed3606cd	Remove redundant comment ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-02-17 13:46:06 +03:00
Dean Herbert	0a018514e1	Make skin editor focus only one layer at a time	2023-02-17 19:27:16 +09:00
Dean Herbert	00fcee0c5a	Add per-ruleset component toolbox and placement support	2023-02-17 19:27:16 +09:00
Dean Herbert	ba5a87ca04	Add basic target layer selection in skin editor	2023-02-17 19:27:16 +09:00
Dean Herbert	c03b6cec23	Add IEquatable and ToString support to SkinComponentsContainerLookup	2023-02-17 19:27:16 +09:00
Dean Herbert	a01c3090e4	Fix tests which rely on HUDOverlay's DrawableRuleset being nullable	2023-02-17 19:27:09 +09:00
Dean Herbert	5ed038fbb3	Improve the feel of hovering toolbox component items	2023-02-17 19:26:03 +09:00
Dean Herbert	814080d982	Only show blueprint labels when hovering or selected	2023-02-17 19:23:52 +09:00
Dean Herbert	19d5293ad1	Change early return to also find the earliest nested object	2023-02-17 18:59:31 +09:00
Dean Herbert	209d41ee9d	Use RulesetInfo instead of Ruleset in skin components lookup	2023-02-17 18:24:05 +09:00
Dean Herbert	675e5b81f3	Fix SkinnableLighting showing up as a user placeable component	2023-02-17 18:24:05 +09:00
Dean Herbert	2267aa1ac2	Add ability to retrieve serialisable drawables for specific rulesets	2023-02-17 18:24:05 +09:00
Dean Herbert	ffb99364b9	Ensure skin default component layouts only apply to global layout for now	2023-02-17 18:24:05 +09:00
Dean Herbert	6c61c5f4a8	Fix selection on the edge of blueprints (in the new inflation area) failing	2023-02-17 18:19:46 +09:00
Dean Herbert	16d94b4ea2	Improve visuals of skin blueprint	2023-02-17 18:19:46 +09:00
tsrk	8830e06588	fix: compilation	2023-02-17 09:17:11 +00:00
tsrk	c94e647e21	style(KeyCounterDisplay): remove type check	2023-02-17 09:09:56 +00:00
Dean Herbert	9793774377	Update SkinDeserialisationTest to work with new serialisation structure	2023-02-17 16:22:48 +09:00
Dean Herbert	6b3652f567	Change serialisation format of skin layouts to allow more flexibility ... Also adds per-ruleset storage for each container type.	2023-02-17 14:19:19 +09:00
Dean Herbert	9685fb2114	Always return a non-null container for SkinComponentsContainerLookups	2023-02-17 14:19:19 +09:00
Dean Herbert	4cc6664dc7	Add optional ruleset identifier to SkinComponentsContainerLookup	2023-02-17 14:19:19 +09:00
Dean Herbert	1a63ca9ece	Add xmldoc around SkinComponentsContainerLookup	2023-02-17 14:18:05 +09:00
Dean Herbert	8c772a723f	Expose constant publicly rather than reexposing business	2023-02-17 13:34:19 +09:00
Dean Herbert	96b1498932	Rename max length variable to make sense (it's a filename limit, not path)	2023-02-17 13:33:22 +09:00
tsrk	d0e8d65766	style(KeyCounter): rename IsLit to IsActive	2023-02-17 00:56:17 +00:00
Andrei Zavatski	a84f20bf32	Add triangles to ModSelectColumn	2023-02-17 03:09:32 +03:00
tsrk	e3ca751027	refactor: make FillFlowContainer read-only	2023-02-16 23:17:47 +00:00
tsrk	c61fac578c	style(KeyCounter): rename methods and arguments ... As for the second suggestion in https://github.com/ppy/osu/pull/22654#discussion_r1109047998, I went with the first one as only one Trigger actually uses this argument for rewinding.	2023-02-16 23:15:03 +00:00
Cootz	810712386d	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-17 01:51:24 +03:00
tsrk	ddd6c1a1c6	refactor(KeyCounter): address bindables issues ... `IsCounting` is back being an auto-property. `countPresses` is now encapsulated and being exposed as an `IBindable<int>` via `CountPresses`	2023-02-16 22:20:34 +00:00
tsrk	6340730427	refactor(KeyCounter): remove circularity	2023-02-16 21:59:39 +00:00
Bartłomiej Dach	3ee046000e	Merge branch 'master' into revert-result-in-playfield	2023-02-16 21:54:29 +01:00
Bartłomiej Dach	66e9bb2581	Merge branch 'master' into hide-resume-overlay	2023-02-16 21:33:23 +01:00
Bartłomiej Dach	b8084a15eb	Revert ResumeOverlay setter accessibility change	2023-02-16 21:26:01 +01:00
Bartłomiej Dach	0186062246	Merge branch 'master' into adjust-song-select-background-dim	2023-02-16 20:52:36 +01:00
Bartłomiej Dach	ad5132ed41	Remove redundant conditional access qualifier ... It is impossible for the callback passed to `ApplyToBackground()` to receive a null reference. See `OsuScreen.ApplyToBackground()` - if the background to call the callback on were `null`, then an `InvalidOperationException` would be thrown instead.	2023-02-16 20:47:51 +01:00
Cootz	f1da213bea	Add tests	2023-02-16 16:26:57 +03:00
Dean Herbert	cb7df7282b	Apply NRT to SerialisedDrawableInfo	2023-02-16 20:01:59 +09:00
Cootz	3057ccb635	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-16 13:22:11 +03:00
Dean Herbert	394d368f16	Fix song select potentially updating background parameters when not the current screen	2023-02-16 18:45:22 +09:00
Dean Herbert	affa9507a1	Fix GameplaySampleTriggerSource not considering nested objects when determining the best sample to play	2023-02-16 18:21:33 +09:00
Dean Herbert	ce9ef3bc3c	Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not	2023-02-16 15:47:20 +09:00
Dean Herbert	7afdcb9383	Merge branch 'master' into hide-resume-overlay	2023-02-16 15:42:14 +09:00
Dean Herbert	81dcc105a9	Rename left-over skinnable naming in SerialisedDrawableExtensions	2023-02-16 15:34:41 +09:00
Dean Herbert	76f7accd13	Standardise all local SkinComponentsContainerLookup variables to containerLookup	2023-02-16 15:33:56 +09:00
Dean Herbert	eea0cd3cf8	Reword xmldoc on ISerialisableDrawable to make less skin-centric	2023-02-16 15:31:35 +09:00
Dean Herbert	0b25f7baeb	Reword and fix typos in some new xmldoc ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-02-16 15:27:30 +09:00
Bartłomiej Dach	c315113fde	Merge branch 'master' into maximum-judgement-offset-in-hit-object	2023-02-16 00:15:51 +01:00
tsrk	74e7cc2056	feat: implement new design of key counter	2023-02-15 22:18:02 +00:00
tsrk	e9dcc257b4	reafactor: simplify type checking	2023-02-15 22:06:35 +00:00
tsrk	b0a2e69f95	style: nullable pass on KeyCounterDisplay	2023-02-15 22:06:10 +00:00
tsrk	076eb81b21	refactor: rename trigger classes ... Makes it better to understand their purpose	2023-02-15 21:46:13 +00:00
tsrk	a644fae364	style(KeyCounter): rename (Un)lit methods to (Un)light	2023-02-15 21:41:41 +00:00
tsrk	df0633858c	fix(KeyCounter): don't override Handle ... This caused the Keyboard inputs to register twice, which is not what we want.	2023-02-15 21:41:41 +00:00
tsrk	157bba7830	refactor: rename Trigger class to InputTrigger	2023-02-15 21:41:36 +00:00
Bartłomiej Dach	768eea1ea8	Merge branch 'master' into skinnable-clean-up-documentation	2023-02-15 21:26:11 +01:00
Bartłomiej Dach	1d5d34ba0e	Merge pull request #22647 from peppy/remove-target-component-container ... Simplify and rename `SkinnableTargetComponentsContainer`	2023-02-15 21:25:49 +01:00
Cootz	387a6f1330	Move logic to Export method	2023-02-15 22:43:43 +03:00
Cootz	fb06a77e2b	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-15 22:29:38 +03:00
Cootz	1f586c129c	fix applied	2023-02-15 22:15:44 +03:00
Dean Herbert	925deb7ca5	Make skin editor clipboard shared between screens and skins to allow moving elements over	2023-02-15 19:35:37 +09:00
Dean Herbert	bc83b0c264	Fix clipboard changes not batching as undo steps	2023-02-15 19:35:22 +09:00
Dean Herbert	bcf2555545	Fix components having incorrect default positions	2023-02-15 19:34:42 +09:00
Dean Herbert	d653335b6f	Add basic skin editor clipboard implementation	2023-02-15 19:28:42 +09:00
Dean Herbert	08ed174f61	Change GameplaySkinComponentLookup's generic to always be an enum ... And document the class better.	2023-02-15 18:48:14 +09:00
Dean Herbert	a92e42bb84	Rename SkinnableTargetContainer to SkinComponentsContainer ... Also use full `SkinComponentsContainerLookup` instead of the sub-type. This will potentially be useful once we bring in per-ruleset targets.	2023-02-15 18:37:41 +09:00
Dean Herbert	b1cf6d83d8	Move extension methods closer to serialisation classes	2023-02-15 18:37:41 +09:00
Dean Herbert	e61d2d571c	Move the lookup type out of ISserialisableDrawableContainer	2023-02-15 18:37:41 +09:00
Dean Herbert	a7b47f6503	Rename ISkinnableTarget to ISerialisableDrawableContainer	2023-02-15 18:37:41 +09:00
Dean Herbert	d159d6b970	Rename ISkinnableDrawable to ISerialisableDrawable	2023-02-15 18:37:41 +09:00
Dean Herbert	8cb5a51aa7	Add further documentation to skin classes	2023-02-15 18:23:19 +09:00
Dean Herbert	856efd9fd9	Rename SkinnableDrawableInfo to SerialisedDrawableInfo	2023-02-15 18:23:19 +09:00
Dean Herbert	9e651a7ca2	Rename SkinnableInfo to SkinnableDrawableInfo	2023-02-15 18:23:17 +09:00
Dean Herbert	6010dde86e	Move SkinnableInfo to better namespace	2023-02-15 18:23:10 +09:00
Dean Herbert	8bbd00822c	Simplify and rename SkinnableTargetComponentsContainer	2023-02-15 17:30:21 +09:00
Dean Herbert	e71dfd7555	Fix skin export failing if a directory exists with the proposed filename	2023-02-15 16:11:16 +09:00
Dean Herbert	da8ab7143b	Merge branch 'master' into maximum-judgement-offset-in-hit-object	2023-02-15 14:48:15 +09:00
Dean Herbert	9ed068c1e6	Only apply dim changes when background blur is disabled	2023-02-15 14:16:34 +09:00
Dean Herbert	19e3c5d33c	Adjust song select background dimming to be more evenly applied	2023-02-15 13:59:24 +09:00
Dean Herbert	5024838f3a	Merge branch 'master' into bubble_mod_implementation_clean	2023-02-15 13:47:18 +09:00
Bartłomiej Dach	99b78c63a0	Merge branch 'master' into fix-mania-long-note-regression	2023-02-14 21:25:31 +01:00
Dean Herbert	5ec5222d8a	Expose and consume OsuInputManager explicitly	2023-02-14 17:36:07 +09:00
Dean Herbert	b42b5f97cf	Use Overlays container rather than KeyBindingInputManager for flashlight	2023-02-14 17:36:07 +09:00
Dean Herbert	970388d4e2	Move Overlays container to accept input and be frame-stable	2023-02-14 17:35:12 +09:00
Dean Herbert	e6f0a1dec9	Merge pull request #22632 from Joehuu/fix-beatmap-preview-progress ... Fix beatmap card song preview progress sometimes showing past progress for one frame	2023-02-14 17:06:50 +09:00
Dean Herbert	7aaaf7fca2	Combine and attempt to simplify the score import / preparation process further	2023-02-14 16:55:35 +09:00
Dean Herbert	8a206234f7	Merge branch 'master' into replay-length-extension	2023-02-14 16:42:26 +09:00
Dean Herbert	0217875f3f	Merge branch 'master' into SkinSetOnNotificationClick	2023-02-14 16:04:03 +09:00
Dean Herbert	0ad245e9e0	Rewrite implementation to match other implementations	2023-02-14 16:00:23 +09:00
Dean Herbert	21429e164f	Fix comment grammar	2023-02-14 15:55:32 +09:00
PC	ca2603324c	Change present from skin selection tab to SkinCollection.First()	2023-02-14 09:43:40 +03:00
Joseph Madamba	ea624b8ad0	Reset preview track when stopping instead	2023-02-13 22:39:34 -08:00
Dean Herbert	63f3498762	Restructure UseResumeOverlay to correctly handle a value change before BDL load	2023-02-14 15:11:33 +09:00
Dean Herbert	9e04a36d86	Move test to a mod test and add more resilient test logic	2023-02-14 15:07:45 +09:00
PC	9064391226	Use ChildrenOfType instead of linq	2023-02-14 08:24:03 +03:00
Dean Herbert	51d4ae5241	Merge branch 'master' into footer_V2_implementation	2023-02-14 14:00:53 +09:00
Dean Herbert	f0ebb920b9	Make Actions nullable	2023-02-14 13:54:00 +09:00
Joseph Madamba	24a5a1061f	Fix OsuClickableContainer sounds not being blocked by nested drawables	2023-02-13 15:36:17 -08:00
PC	f8f485e4c8	Move PresentSkinsImport to OsuGame. Replace switch with if statement	2023-02-14 02:29:50 +03:00
MK56	5006dbe3db	Update osu.Game/Screens/Select/FooterV2/FooterButtonV2.cs ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2023-02-14 00:07:02 +01:00
Bartłomiej Dach	939144fb6c	Merge pull request #22628 from EVAST9919/letterbox-no-containers ... Remove unnecessary containers in `LetterboxOverlay`	2023-02-13 23:54:48 +01:00
Pasi4K5	e4b84ebd0b	Add UseResumeOverlay and use it for hiding the ResumeOverlay	2023-02-13 23:51:39 +01:00
Joseph Madamba	7f7e72705f	Fix beatmap card song preview progress sometimes showing past progress for one frame	2023-02-13 14:15:37 -08:00
mk56-spn	ae9a17d76b	Add offset to FooterButtonV2.cs shadow	2023-02-13 22:20:41 +01:00
mk56-spn	be52d0a60c	Add note explaining shadow opacity ... pass ColourProvider in from test, instead of hard coding it in `FooterButtonV2.cs`	2023-02-13 22:18:34 +01:00
mk56-spn	61584ba63c	Fix corner_radius missing in some parts of FooterButtonV2.cs. ... Adjust shadow radius value to 5 to match figma.	2023-02-13 22:15:29 +01:00
mk56-spn	6e6421caea	Change FooterV2.cs colour to use ColourProvider instead of OsuColour. ... Remove unnecessary `FillFlowContainer`	2023-02-13 22:12:25 +01:00
PC	10ab228d76	Improve xml doc	2023-02-13 22:47:29 +03:00
PC	46b13f2565	Improve code quality	2023-02-13 22:44:11 +03:00
PC	637b07efe6	Remove Resolved attribute	2023-02-13 22:36:51 +03:00
PC	a22a36bfe0	Add navigation to skin settings on multiple import	2023-02-13 20:31:09 +03:00
Andrei Zavatski	2dee783401	Remove not needed containers	2023-02-13 15:14:25 +03:00
PC	35bc0a29d8	Add setting skin on notification click	2023-02-13 15:11:55 +03:00
Dean Herbert	679df9bf8b	Merge pull request #22604 from Joehuu/abort-dangerous-dialog-button-on-hover-lost ... Add ability to abort dangerous dialog button on hover lost	2023-02-13 20:40:14 +09:00
tsrk	aa2e0028ab	refactor: hide trigger presence from content	2023-02-13 10:59:10 +00:00
Dean Herbert	55358d36c8	Change MinimumColumnWidth to remove setter	2023-02-13 17:50:32 +09:00
Dean Herbert	ca768ca446	Add comment regarding unused enum members in LegacyNoteBodyStyle	2023-02-13 17:43:52 +09:00
tsrk	11d0e185b8	refactor: separate impl of KeyCounterDisplay ... This allows for different layouts of display. Idk, maybe someone would want to mix both variants? (don't do this please). This commit is mostly prep for further changes.	2023-02-13 01:36:12 +00:00
tsrk	74a58fb674	refactor: separate things in KeyCounter ... To implement different different sources of input for KeyCounter, it is now possible to create a Trigger class (to inherit) instead of inheriting KeyCounter. This eases the creation of more input sources (like for tests) while allowing to implement different UI variants. That way, if another variant of the key counter needs to implemented (for whathever reason), this can be done by only inheriting KeyCounter and changing how things are arranged visually.	2023-02-13 01:24:27 +00:00
Joseph Madamba	cb51b9e350	Use existing ModdingBeatmap activity	2023-02-12 15:01:50 -08:00
Joseph Madamba	bbeef53569	Add TestingBeatmap activity	2023-02-12 13:11:42 -08:00
Joseph Madamba	afb66d8af4	Make user activity class names more specific	2023-02-12 12:32:17 -08:00
Dean Herbert	9d09141ab7	Move taiko-specific property out of DrawableHitObject	2023-02-12 16:09:28 +09:00
Joseph Madamba	8d9245c1d4	Make AbortConfirm() virtual and override with filter logic	2023-02-11 12:54:16 -08:00
Bartłomiej Dach	774eae98cc	Merge branch 'master' into editor-select-timing-on-enter	2023-02-11 16:27:22 +01:00
Bartłomiej Dach	a3cc0d23b3	Fix typo in xmldoc	2023-02-11 16:26:32 +01:00
Bartłomiej Dach	7b2c5ab7eb	Merge pull request #22608 from peppy/update-dependencies ... Update realm and other dependencies	2023-02-11 12:37:02 +01:00