Dean Herbert
fab09575ec
Add full testing flow for BeatmapOffsetControl
2022-03-01 18:44:15 +09:00
Dean Herbert
1847f69bf9
Add basic beatmap offset adjustment control
2022-03-01 18:44:15 +09:00
Dean Herbert
260cf793fe
Add test coverage of more advanced frame delivery scenarios to TestSceneSpectatorPlayback
2022-02-24 02:28:13 +09:00
Dean Herbert
c94e7e2abe
Add ability to simulate network failures to TestSpectatorClient
2022-02-24 02:23:48 +09:00
Dean Herbert
14c8ce50a0
Prefix all test send methods in TestSpectatorClient with Send
2022-02-24 02:23:48 +09:00
Dean Herbert
6a08fd57ef
Rename "client" fields in tests to specify whether spectator or multiplayer
2022-02-16 09:52:18 +09:00
Dan Balasescu
539cbe62c6
Fix incorrect usages of user lookup cache in tests
2022-02-15 21:23:24 +09:00
Dan Balasescu
ffc4c64f7e
Unify namings across the board
2022-02-09 12:10:07 +09:00
Dan Balasescu
4966c4e974
Remove redundant parameter
2022-02-09 11:51:47 +09:00
Dan Balasescu
886d1d2df6
Refactorings
2022-02-08 21:29:43 +09:00
Dan Balasescu
4c76027178
Rename completed state to passed
2022-02-08 20:29:49 +09:00
Dan Balasescu
0d99017178
Add state tests
2022-02-08 20:27:08 +09:00
Dan Balasescu
09728a29ed
Merge branch 'fix-broken-test-scene' into spectator-state-rework
2022-02-04 22:42:10 +09:00
Dan Balasescu
fa3d1115fa
Remove online api requirement
2022-02-04 19:17:50 +09:00
Dan Balasescu
dd63b1a350
Fix broken spectator playback test scene
2022-02-04 19:12:02 +09:00
Dan Balasescu
fcbba3d948
Rename PlayingUserStates -> WatchingUserStates
2022-02-02 23:11:29 +09:00
Dan Balasescu
589f5e7a31
Update test which has now been resolved
2022-02-02 23:09:38 +09:00
Dan Balasescu
6d3bc005ea
Merge branch 'master' into spectator-state-rework
2022-02-02 18:57:04 +09:00
Bartłomiej Dach
7cdf63c654
Remove unused FindProvider() methods
...
No longer needed since 39f99bf785
2022-02-01 21:53:21 +01:00
Dan Balasescu
41007169f7
Give SpectatorState a user state
2022-02-01 21:51:05 +09:00
Dan Balasescu
781cb9f18d
Move HasPassed/HasFailed into GameplayState
2022-02-01 14:46:24 +09:00
Dan Balasescu
502e6af008
Remove PlayingUsers list from SpectatorClient
2022-02-01 14:42:30 +09:00
Dan Balasescu
0458d408bb
Add replay statistics frames to FramedReplayInputHandler
2022-01-31 18:53:47 +09:00
Dan Balasescu
4727aeda01
Give last bundled replay frame the frame header
2022-01-31 18:53:47 +09:00
Dean Herbert
57f793aff0
Rename dictionary and make private for added safety
2022-01-31 15:12:08 +09:00
Bartłomiej Dach
1253e1ecc1
Replace LINQ Count() invocation with count property access
2022-01-28 20:25:12 +01:00
Dan Balasescu
3037a3a769
Purge final spectator frames before ending play
2022-01-28 22:26:05 +09:00
Dan Balasescu
32f9299fe0
Remove unused using
2022-01-28 15:26:29 +09:00
Dean Herbert
28c8e07e3f
Ensure hold for menu button fades out if the cursor is never moved
...
Closes https://github.com/ppy/osu/discussions/16669 .
2022-01-28 14:48:35 +09:00
Dean Herbert
f32d56e213
Bring HoldForMenuButton tests up-to-date in code quality
2022-01-28 14:48:17 +09:00
Dean Herbert
5288eedd31
Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
2022-01-27 15:38:03 +09:00
Dean Herbert
cd71ec0edd
Remove ILive<> interface (and use abstract Live<> instead)
2022-01-26 13:38:56 +09:00
Dean Herbert
778d2a71b4
Remove Task from the inner-most Import method in RealmArchiveModelImporter
...
One of my pending work items for post-realm merge.
The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.
Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.
2022-01-25 15:30:29 +09:00
Bartłomiej Dach
735414bc49
Replace TimeSignatures enum with struct for storage of arbitrary meter
2022-01-22 20:50:31 +01:00
Dean Herbert
7f65f3a47f
Remove all usage of BaseDifficulty (and access Difficulty instead)
2022-01-18 22:57:39 +09:00
Dean Herbert
90166829c3
Update tests which were importing scores without a valid beatmap
2022-01-17 14:47:19 +09:00
Bartłomiej Dach
03e4ec4214
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-15 14:45:42 +01:00
Susko3
19467e58c1
Remove unused params from BDL methods
2022-01-15 01:06:39 +01:00
Dean Herbert
8d4a3cc569
Remove pointless Metadata set
2022-01-14 23:27:33 +09:00
Dean Herbert
5cbd731864
Add RulesetInfo hashcode implementation and tidy up equality
2022-01-12 17:49:10 +09:00
Dean Herbert
605898ec53
Add missing "non-null" elements missing from some tests
2022-01-12 17:49:10 +09:00
Dean Herbert
6251713796
Add missing Ruleset in ReplayRecorder tests
2022-01-12 17:00:17 +09:00
Dean Herbert
31a3161189
Make tests compile again
2022-01-12 17:00:16 +09:00
Dean Herbert
213d89b479
Update null fallback cases involving OnlineID
2022-01-12 16:39:36 +09:00
Dan Balasescu
af9fad00c3
Merge branch 'master' into async-deadlock-safety
2022-01-10 16:11:09 +09:00
Dean Herbert
3cd996eb4a
Merge branch 'master' into async-deadlock-safety
2022-01-07 17:28:59 +09:00
Dean Herbert
00177a3ae1
Update usages to new naming
2022-01-06 22:54:43 +09:00
Bartłomiej Dach
66613cbaa4
Wait for async continuation in score submission test
...
The previous assert step was optimistically assuming that the async
continuation that writes the value of
`FakeImportingPlayer.ImportedScore` always completes before it, but
that's not necessarily true even if the continuation is instant (it is
still subject to things like task scheduling and TPL thread pool
limits).
To ensure no spurious failures, swap out the assert step for an until
step instead.
2022-01-06 13:09:25 +01:00
Bartłomiej Dach
84765b99b3
Handle score submission request in submission test scene
...
Was previously not handled at all, therefore displaying request failures
in the test log output. While that was mostly a red herring and
shouldn't have caused any actual *test* failures, it is still better to
handle this explicitly in a realistic manner.
2022-01-06 12:57:26 +01:00
Dean Herbert
73b40e6833
Replace usage of .Result with .WaitSafelyForResult
2022-01-04 11:51:41 +09:00
Bartłomiej Dach
7cdba2f7c3
Add test coverage of score submission if player is exited during import
2022-01-03 22:00:47 +01:00
Dean Herbert
04d8fd3a58
Improve reliability of TestStoryboardSkipOutro
...
Aims to resolve failures as seen at
https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true .
Have run quite a lot locally with no failures (while removing the skip step 100% fails).
2022-01-01 15:32:39 +09:00
Bartłomiej Dach
34b0101ff4
Add visual test coverage of "hidden by ruleset" combo option
2021-12-26 16:49:18 +01:00
Dean Herbert
f3f491374b
Remove unused load checks
2021-12-22 18:17:00 +09:00
Bartłomiej Dach
54790bb758
Merge branch 'master' into fix-realm-post-storage-migration-failure
2021-12-17 00:19:46 +01:00
Dan Balasescu
eb3050b2ac
Fix incorrect test
2021-12-14 15:08:00 +09:00
Dean Herbert
441b7baa93
Provide a realm factory to usages of ToLive/RealmLive
2021-12-14 14:26:34 +09:00
Dean Herbert
309290a3c9
Use new method in more places that can benefit from it
2021-12-13 16:56:43 +09:00
Dean Herbert
bff02bedbf
Rename APIScoreInfo to APIScore
2021-12-10 16:11:49 +09:00
Dean Herbert
a969fe3ef8
Add test coverage showing intended UX of user's volume levels being retained when unmuting
2021-12-08 13:37:47 +09:00
Dean Herbert
9033169177
Merge pull request #15951 from peppy/fix-failing-recorder-tests-w
...
Fix intermittent test failures in scenes using `SpectatorClient`
2021-12-06 18:40:27 +09:00
Dan Balasescu
568364b604
Fix indentation
2021-12-06 17:38:57 +09:00
Dean Herbert
0d3d22d3e1
Update TestSceneReplayReocorder to be safer about disposal
2021-12-06 17:09:12 +09:00
Dean Herbert
50a5f52f92
Remove duplicated test scene (see TestSceeneReplayRecorder)
2021-12-06 17:09:11 +09:00
Dean Herbert
d58b85b381
Refactor TestScenSpectatorPlayback to properly clean up without async disposal
2021-12-06 17:09:11 +09:00
Dean Herbert
452fa93444
Merge branch 'master' into realm-integration/skins-rebase
2021-12-06 15:21:02 +09:00
Dean Herbert
1eed2436e6
Clean up unused resolved properties
2021-12-03 18:49:49 +09:00
Dean Herbert
f6a3709060
Store default skins to database
2021-11-29 18:28:25 +09:00
Dean Herbert
23146d59d1
Use ILive for current skin
2021-11-29 18:28:25 +09:00
Dean Herbert
f283770f34
Update mock RulesetInfo usage to set OnlineID instead of ID
2021-11-24 15:50:26 +09:00
Dean Herbert
b9923e5396
Remove subclassing of RulesetInfo
2021-11-22 16:39:17 +09:00
Dean Herbert
d7b178ea37
Update test scenes which should not handle key repeat
2021-11-18 13:13:36 +09:00
Dean Herbert
7c2e79f911
Update all simple cases of switching to IWorkingBeatmap
2021-11-17 20:56:57 +09:00
Dean Herbert
62d670a3ca
Update DifficultyCalculator to take an IWorkingBeatmap
2021-11-15 19:16:48 +09:00
Dean Herbert
5be22916bb
Add test coverage against frequency ramp increasing between fail animation and fail screen
2021-11-14 14:41:17 +09:00
Dean Herbert
6a098a8634
Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface
2021-11-12 17:46:24 +09:00
Bartłomiej Dach
dbdbfc4723
Add failing test case for PP counter not initially updating
2021-11-11 16:33:31 +01:00
Bartłomiej Dach
9bad912dd0
Add failing test case
2021-11-11 13:22:06 +01:00
Bartłomiej Dach
03a315b9f5
Fix missing beatmap in replay download test scene
...
Was causing nullrefs in `GetDisplayTitle()`.
2021-11-09 14:33:06 +01:00
Bartłomiej Dach
74c37e248d
Merge branch 'master' into master
2021-11-09 08:40:52 +01:00
Dean Herbert
78aef9ce86
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-08 13:35:49 +09:00
Bartłomiej Dach
6d30248cef
Merge branch 'master' into use-class-rename
2021-11-07 15:41:00 +01:00
Dean Herbert
0ecf5f201c
Rename User to APIUser and move to correct namespace
2021-11-07 11:26:01 +09:00
Dean Herbert
b8fb22b769
Add missing test coverage of score import process being tracked correctly
2021-11-06 16:45:55 +09:00
Chinmay Patil
77e853ce25
Optimized UR Counter and removed redundant code
2021-11-05 12:16:58 -06:00
Salman Ahmed
b723975767
Replace pragma with add/remove => throw
2021-11-05 09:10:38 +03:00
Salman Ahmed
af6ae1cce5
Remove hacky code with explicit pragma disable
2021-11-05 03:49:35 +03:00
Chinmay Patil
8923561b05
Removed Unnessicary class in the Test file, and optimized UR counter
2021-11-04 14:27:48 -06:00
Chinmay Patil
a76878e053
A bit more formatting
2021-11-04 09:52:16 -06:00
Chinmay Patil
c568888500
Edited to remove unessicary blank lines
2021-11-04 09:47:52 -06:00
Chinmay Patil
223efe55d5
Added Tests for UR counter
2021-11-04 09:23:29 -06:00
Dean Herbert
d1e6d1cb98
Update some other missed incorrect null/empty usages
2021-11-04 14:50:43 +09:00
Bartłomiej Dach
5dcff7d8b7
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 11:41:20 +01:00
Bartłomiej Dach
6a44cf3ff1
Add missing beatmap spec in test scene
2021-11-01 09:44:08 +01:00
Dean Herbert
269a8df0ec
Fix HasReplay not being corrrectly implemented by APIScoreInfo
2021-11-01 13:20:37 +09:00
Dean Herbert
17a83f701a
Store mods as APIMods for the time being
2021-10-29 15:13:49 +09:00
Dean Herbert
1944c255a7
Implement score interfaces
2021-10-29 13:49:30 +09:00
Dean Herbert
817369903a
Rename API score classes
2021-10-29 13:40:56 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Bartłomiej Dach
95ed9a431c
Add test coverage for no submission for ruleset with null ID
2021-10-19 00:06:07 +02:00
Dan Balasescu
8643c725cc
Merge pull request #15175 from peppy/fail-animation-flash-controlled-by-setting
...
Don't flash screen red on fail if the user has disabled red tinting
2021-10-18 15:27:10 +09:00
Dean Herbert
762949f49f
Don't flash screen red on fail if the user has disabled red tinting
2021-10-18 14:20:38 +09:00
Dean Herbert
0d992a0493
Add failing test showing epilepsy warning is not fading on early exit
2021-10-18 13:30:24 +09:00
Bartłomiej Dach
b34086a792
Add failing test case for incorrect RulesetID population in submission flow
2021-10-16 16:10:42 +02:00
Bartłomiej Dach
29ec498f6c
Add failing test case for player sending wrong ruleset ID to spectator server
2021-10-16 13:34:24 +02:00
Dan Balasescu
e49f1f6e6b
Merge branch 'master' into no-more-difficulty-control-points-info
2021-10-13 20:17:57 +09:00
Dean Herbert
26a1e40d24
Fix storyboard outro during fail test not being lenient enough
2021-10-13 13:48:57 +09:00
Bartłomiej Dach
8dcfc3dd7e
Replace no-op seeks with wait steps
2021-10-12 18:31:20 +02:00
Bartłomiej Dach
b1ad3161dd
Add failing test case for frame stable clock direction flip scenario
2021-10-11 21:25:02 +02:00
smoogipoo
bc37cb6f43
Merge branch 'master' into no-more-difficulty-control-points-info
2021-10-08 18:41:17 +09:00
Dan Balasescu
bece807857
Merge pull request #14980 from peppy/difficulty-move-to-beatmap
...
Copy `BaseDifficulty` to `Beatmap<T>` and move the majority of write operations across
2021-10-07 18:43:44 +09:00
Dean Herbert
697f53c445
Fix test failure due to reference of Player.Mods
2021-10-07 15:00:47 +09:00
Dean Herbert
b339c149d8
Copy BaseDifficulty to Beatmap<T> and move all write operations across
2021-10-06 15:10:45 +09:00
Dean Herbert
d6f25e07cc
Add assert coverage of non-downloadable states
2021-10-06 05:49:18 +09:00
Dean Herbert
31c0c7a888
Remove pointless (and incorrect) click step
2021-10-06 05:49:04 +09:00
Dean Herbert
777763a550
Add more comprehensive (and failing) test coverage of replay download button
2021-10-06 05:29:00 +09:00
Dean Herbert
98fef6ece2
Handle judgement reverts with actual display updates
2021-10-05 19:08:30 +09:00
Dean Herbert
0859c336de
Also dim counter during initial calculation phase
2021-10-05 17:24:36 +09:00
Dean Herbert
04538a69e4
Add assert tests
2021-10-05 17:10:24 +09:00
Dean Herbert
eeb5f3d519
Add basic test scene
2021-10-05 16:51:43 +09:00
smoogipoo
86df4919f7
Fix skin fallbacks test
2021-10-05 11:06:26 +09:00
smoogipoo
031c5a441e
Merge branch 'master' into realtime-pp-display
2021-10-04 20:19:37 +09:00
Dean Herbert
853cf6feaa
Rename last remaining BeatmapInfo Beatmap usage
2021-10-04 17:35:53 +09:00
Dean Herbert
32afd3f426
Replace all basic usages
2021-10-02 02:22:23 +09:00
smoogipoo
4e3d9da22d
Increase test lenience
2021-10-01 22:58:40 +09:00
Dan Balasescu
625711e6d2
Merge pull request #14776 from peppy/fix-pause-with-audio-offset
...
Avoid accounting for the pause pitch adjust effect when "fixing" hardware offset adjustments
2021-09-28 18:44:22 +09:00
Dean Herbert
46bafb6252
Merge branch 'master' into no-more-difficulty-control-points-info
2021-09-28 13:53:56 +09:00
Bartłomiej Dach
761548e533
Merge branch 'master' into 14470-ur-not-updating
2021-09-20 22:07:33 +02:00
sh0ckR6
93ca615c02
Add tests for clearing HitErrorMeter
...
Works with both `BarHitErrorMeter` and `ColourHitErrorMeter`
2021-09-19 14:15:22 -04:00
Opelkuh
366dbf5c3d
Add test for time jumps
2021-09-19 15:35:03 +02:00
Opelkuh
761da45f6a
Revert af4c3727d77a16e2534df9bbf452336b5c544342
2021-09-19 14:00:56 +02:00
Opelkuh
1d7d779f66
Merge branch 'master' into add-legacy-star-particles
2021-09-19 04:34:35 +02:00
Opelkuh
3f8454cb76
Remove abstract from ParticleSpewer
2021-09-19 03:19:16 +02:00
Opelkuh
ef530ed87c
Normalize particle velocity based on max duration
2021-09-18 23:45:58 +02:00
Opelkuh
846cde53b3
Add RelativePositionAxes support
2021-09-18 22:54:12 +02:00
Dean Herbert
45caeb84d3
Fix incorrect type specification when restoring bindable value
2021-09-17 16:28:47 +09:00
Dean Herbert
2c071a4d22
Add test coverage of pausing with a large audio offset
2021-09-17 15:43:38 +09:00
smoogipoo
f9d5abff8a
Update with keybinding changes
2021-09-16 18:26:12 +09:00
Dean Herbert
2df4073946
SpawnParticle -> CreateParticle (and set time outside of virtual call)
...
Allows easier overriding (no need to call the `base.CreateParticle` call
and worry about overwriting the time value.
2021-09-16 16:52:46 +09:00
Dean Herbert
a2dcef7c0a
Use local (or barebones BeatmapInfo) where feasible
2021-09-15 13:40:05 +09:00
smoogipoo
4b3ab42ffd
Ensure beatmap is populated
2021-09-15 13:18:46 +09:00
Opelkuh
b009772206
Fix code inspect failure
2021-09-13 21:44:28 +02:00
Opelkuh
224244801f
Remove Particles namespace
2021-09-13 21:44:27 +02:00
Opelkuh
7327603fc8
Fix outdated test step description
2021-09-13 21:44:26 +02:00
Opelkuh
cfcb46034c
Remove ParticleJet
2021-09-13 21:44:23 +02:00
Opelkuh
328c9a5dd0
Change ParticleSpewer.Active to a Bindable
2021-09-13 21:44:18 +02:00
Opelkuh
1a60ce164e
Add ParticleJet
2021-09-13 21:44:16 +02:00
Dean Herbert
9cf79a80c2
Replace many more calls to CreateAllMods with more specific calls
2021-09-10 12:04:55 +09:00
Dean Herbert
cf633973a9
Refactor exposed mod retrieval methods for better safety
2021-09-10 11:09:13 +09:00
Dean Herbert
766d789845
Rename ApproachRate to ScrollSpeed for now (to reduce complexity/confusion)
2021-09-06 21:06:13 +09:00
Dean Herbert
d587dc6203
Populate new approach rate where required
2021-09-03 17:11:12 +09:00
Dean Herbert
a3d9ab1e2e
Move approach rate to EffectControlPoint
2021-09-03 16:58:16 +09:00
Dean Herbert
4dd60e3299
Merge branch 'master' into taiko-drum-refacor
2021-08-30 14:12:52 +09:00
Dean Herbert
f078a9d2bf
Fix incorrect step type
2021-08-26 17:17:39 +09:00
Dean Herbert
6dcd9427ac
Remove bindable usage in PathControlPoint
...
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
2021-08-26 12:33:53 +09:00
Dean Herbert
7e6e2a7e29
Remove unused assignment
2021-08-25 17:39:06 +09:00
Dean Herbert
fc85ae0e34
Add test coverage
2021-08-25 16:56:44 +09:00
smoogipoo
342f2d756d
Fix test not working intermittently
2021-08-24 15:18:05 +09:00
Dan Balasescu
c95bf735fe
Merge branch 'master' into multiplayer-chat
2021-08-20 11:54:42 +09:00
Salman Ahmed
6ed3e469f7
Fix wrong attribute used for setup method
2021-08-18 06:50:01 +03:00
Salman Ahmed
f592350856
Fix config pollution in HUD overlay test scene
2021-08-18 04:59:08 +03:00
Dean Herbert
0d283aa6a3
Expose LocalUserPlaying from Player
2021-08-17 16:16:49 +09:00
Dean Herbert
8555a465ac
Merge pull request #14318 from bdach/editor-colours-save
...
Add support for saving edited combo colours and displaying them in composer
2021-08-16 17:07:53 +09:00
Salman Ahmed
9d99741663
Add failing test case
2021-08-16 06:56:59 +03:00
Bartłomiej Dach
6108451449
Retrieve separated skin instance from working beatmap for editing
2021-08-15 21:18:09 +02:00
Dean Herbert
e84224f64c
Rename AddPlayer method now that there's no conflict
2021-08-12 16:20:37 +09:00
Dean Herbert
68dbbc17e8
Add support for automatic scrolling in gameplay leaderboard
2021-08-12 16:20:37 +09:00
Dean Herbert
f4591b01d7
Add test step to show leaderboard in expanded state by default
2021-08-12 15:21:00 +09:00
Dean Herbert
9b9dacf3fe
Update usages of Drawable.Click()
2021-08-04 17:30:33 +09:00
smoogipoo
11b9ba86cb
Fix TestSceneSpectator reusing cached spectator client
2021-08-03 18:28:08 +09:00
Salman Ahmed
6b8de2a10b
Add test coverage for excluded cases in score submission
2021-07-11 03:35:35 +03:00
Dean Herbert
6ae631b03a
Remove previous seek testing logic from common test scene
2021-07-09 16:52:03 +09:00
Dean Herbert
9083b28114
Add test coverage of seeking and pausing
2021-07-09 14:47:11 +09:00
Dean Herbert
e612d7568c
Merge pull request #13771 from LumpBloom7/volume-meter-switch
...
Add ability to navigate between volume meters via Alt+Left/Right arrows
2021-07-07 21:50:44 +09:00
Dan Balasescu
09a5516cc6
Merge pull request #13811 from smoogipoo/remove-unused-using
...
Remove unused usings
2021-07-07 16:30:07 +09:00
Dan Balasescu
05c4e0254b
Merge pull request #13796 from peppy/fix-skin-providing-container
...
Rewrite `SkinProvidingContainer`
2021-07-07 15:43:24 +09:00
smoogipoo
faf95c7161
Remove unused usings
2021-07-07 15:35:14 +09:00
Dean Herbert
35672f372a
Shorten test beatmap to avoid timeouts in score submission test
2021-07-07 14:58:01 +09:00
Derrick Timmermans
4451598bcf
Fix remaining quality complaints
2021-07-06 15:17:19 +02:00
Derrick Timmermans
ffe18ebe51
Resolve build errors
2021-07-06 14:11:46 +02:00
Dean Herbert
d75d67577a
Fix regressed tests
2021-07-06 17:37:34 +09:00
Derrick Timmermans
d495196b66
Share item cycling logic with GameplayMenuOverlay
2021-07-05 19:22:55 +02:00
PercyDan54
e1c646b9b2
Remove redundant arguments
2021-07-05 23:52:39 +08:00
Bartłomiej Dach
19f02dc3d9
Ensure tests with no token have at least one hit
...
Because submission can be prevented by both not having been issued a
correct submission token, and by not actually registering any hits in
gameplay, ensure that tests that don't receive a token register at least
one hit, to avoid potentially having test cases that test the "no token"
flow pass erroneously because they never had any hits in the first
place.
2021-07-04 14:34:52 +02:00
Dean Herbert
2a74b1c539
Add test coverage of new scenarios
2021-07-04 17:27:02 +09:00
Dean Herbert
30467191b2
Remove local handling of NoFail addition
2021-07-02 14:21:48 +09:00
Dean Herbert
a6323b7d87
Use APIException
2021-07-01 17:54:59 +09:00
Dean Herbert
74c63e15be
Mark score failed on fail and exit
2021-07-01 17:48:09 +09:00
Dean Herbert
6e8d4e382e
Add test coverage of token failure scenarios
2021-07-01 17:20:40 +09:00
Dean Herbert
397d2491b3
Update test scenes to actually cover submission logic
2021-07-01 16:55:44 +09:00
Dean Herbert
4a54e7cdb8
Add tests covering score preparation flow
2021-06-30 20:23:24 +09:00
smoogipoo
8e04d73b67
Merge branch 'rework-multiplayer-test-scenes' into spectator-start-at-end-2
2021-06-29 17:06:57 +09:00
smoogipoo
bcdf36e77b
Merge branch 'master' into spectator-start-at-end-2
2021-06-29 15:53:58 +09:00
smoogipoo
7aefbe3da1
Move UserLookupCache inside dependencies
2021-06-25 17:37:02 +09:00
Salman Ahmed
37f7486fb1
Fix potential null reference in LINQ method
2021-06-22 12:25:29 +03:00
Salman Ahmed
31cbb36a64
Implement FindProvider and AllSources properly on all test ISkinSources
2021-06-22 12:03:14 +03:00
Dean Herbert
0ad189e357
Expose skin sources via ISkinSource and revert to consuming based on hierarchy
2021-06-22 16:19:55 +09:00
Dean Herbert
1b0aadcc6f
Merge branch 'master' into transformers-per-skin
2021-06-22 16:03:15 +09:00
Dean Herbert
246ab41cc6
Remove special casing for user exit during storyboard outro
2021-06-17 18:11:15 +09:00
smoogipoo
58d71e4aea
Remove local "next frame" storage
2021-06-10 22:41:38 +09:00
Salman Ahmed
6538d44708
Make SkinProvidingContainer able to perform lookup on multiple skins
...
Currently `protected` functionality for use in custom `SkinProvidingContainer`s, can be exposed to public constructors if it need to later on, but I'm not sure about doing that opposed to just nesting multiple `SkinProvidingContainer`.
2021-06-09 22:49:31 +03:00
Salman Ahmed
cf40282f1f
Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource
2021-06-09 22:49:31 +03:00
smoogipoo
c8e14d7710
Ignore non-scorable and bonus judgements
2021-06-08 23:09:23 +09:00
Dean Herbert
6017ef3825
Merge branch 'master' into fix-skin-sample-lookup
2021-06-08 17:37:36 +09:00
Dan Balasescu
791855dfa0
Merge branch 'master' into legacy-skin-default-fallback
2021-06-08 16:54:26 +09:00
Bartłomiej Dach
1b4771655a
Adjust test scene to avoid cross-test interference
...
* Move steps from ctor to a separate basic test.
* Wait for barrage to complete in basic test, as not doing so polluted
state of other tests.
* Reset score processor after every test.
2021-06-07 13:16:07 +02:00
Bartłomiej Dach
37d062c7cd
Add failing assertions to hit error meter test
2021-06-07 13:16:07 +02:00
Bartłomiej Dach
122a624b7f
Remove bogus CatchHitWindows
...
`CatchHitWindows` were a vestige from the past, and were not actually
used anywhere except for the hit error meter test, giving off an
appearance that the hit error meter was working properly.
`CatchHitObject` actually specifies empty hit windows.
2021-06-07 13:16:07 +02:00
Dean Herbert
d26c9a66c2
Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
2021-06-07 12:01:19 +09:00
Dean Herbert
06275a6a7d
Merge branch 'master' into legacy-skin-default-fallback
2021-06-04 16:00:30 +09:00
smoogipoo
c3280083a2
Merge branch 'master' into fix-spectator-frame-conversion
2021-06-03 17:42:01 +09:00
smoogipoo
3bc81fbb06
Fix spectator tests
2021-06-03 17:27:24 +09:00
smoogipoo
420df124b5
Add framestable-bypassing seek for spectator
2021-06-03 17:27:21 +09:00
Dan Balasescu
44b1102241
Merge branch 'master' into autoplay-pause-support
2021-06-03 13:26:00 +09:00
Dan Balasescu
c065f761c7
Merge branch 'master' into legacy-skin-default-fallback
2021-06-02 19:08:52 +09:00
Dean Herbert
5366e7f61e
Merge branch 'master' into remove-hud-component-lookup
2021-06-02 16:10:06 +09:00
Dean Herbert
f8ae70e562
Update existing function type rather than adding an override
2021-06-02 16:04:53 +09:00
Dean Herbert
45984f035b
Make autoplay tests test via the ReplayPlayer code path
2021-06-02 11:49:06 +09:00
Salman Ahmed
cb38abab35
Add local logic for creating default/legacy implementation based on cell skin
2021-06-01 10:17:01 +03:00
Salman Ahmed
cd8e3f3a04
Revert "Group all skinnable test scenes to one TestSceneSkinnableHUDComponents"
...
This reverts commit d1272d5e13
2021-06-01 09:57:43 +03:00
Dean Herbert
00b3eea840
Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
2021-05-31 21:39:04 +09:00
Dean Herbert
3ff9f9c89d
Make FindProvider non-default
2021-05-31 21:29:47 +09:00
smoogipoo
c787c008a5
Fix test potentially not waiting for player to load
2021-05-31 20:21:26 +09:00
Dean Herbert
de0e51a81d
Merge branch 'master' into fix-skin-sample-lookup
2021-05-31 15:27:39 +09:00
Salman Ahmed
02d18c7a49
Merge branch 'master' into remove-hud-component-lookup
2021-05-31 09:23:04 +03:00
ekrctb
771f3c48c0
Add failing test showing lifetime not recomputed with pooled objects
2021-05-31 14:48:52 +09:00
Dean Herbert
dac1a98d8a
Merge branch 'master' into fix-skin-sample-lookup
2021-05-30 15:19:47 +09:00
Salman Ahmed
200fecc774
Fix missing using directive
2021-05-29 21:22:39 +03:00
Salman Ahmed
42618c713f
Merge branch 'master' into legacy-beatmap-skin-hud-fallback
2021-05-29 20:56:05 +03:00
Dean Herbert
951fc5ef6e
Remove misleading comment and misplaced bug fix
...
This shouldn't be fixed in a test scene; the underlying issue should be
fixed in actual game code.
2021-05-29 15:39:13 +09:00
Dean Herbert
9b239e308b
Merge branch 'master' into beatmap-skin
2021-05-29 15:36:43 +09:00
Dean Herbert
6268bbea85
Merge branch 'master' into fix-skin-sample-lookup
2021-05-28 14:47:35 +09:00
Dan Balasescu
1a0ace8d58
Merge branch 'master' into fix-slow-load-test-failure
2021-05-27 23:15:42 +09:00
Dean Herbert
bcf1e3db1e
Fix test failures in TestSceneStoryboardWithOutro
...
Test was not accounting for the fact that the results may not have
loaded in time.
2021-05-27 19:45:55 +09:00
Dean Herbert
c39ea85701
Fix TestSceneSkinnableSound not doing DI correctly
2021-05-27 15:42:25 +09:00
Dean Herbert
70a844ac10
Remove allowFallback parameters completely
2021-05-27 14:50:42 +09:00
Dean Herbert
8e923a5d8f
Instantiate immediately, rather than waiting for instantiation
2021-05-26 22:24:51 +09:00
Dean Herbert
878079d3d7
Fix correct beatmap not being set if running test alone
2021-05-26 19:08:00 +09:00
Dean Herbert
a77de24746
Fix SlowLoadPlayer potentially not being instantiated in time for test
2021-05-26 18:58:18 +09:00
Dean Herbert
14a4095140
Merge branch 'master' into beatmap-skin
2021-05-26 18:39:47 +09:00
Salman Ahmed
afb33f1641
Remove no longer necessary test case
2021-05-21 20:21:50 +03:00
Salman Ahmed
c0dfe37965
Remove unused using directive
2021-05-20 21:08:36 +03:00
Salman Ahmed
eaae9a1b67
Remove unrequired null conditional
2021-05-20 21:08:31 +03:00
Salman Ahmed
262a27610c
Improve components assertion logic
2021-05-20 20:47:40 +03:00
smoogipoo
9d07749959
Improve implementation of TestSpectatorClient
...
There was a lot of weirdness here, such as storing the playing users,
clearing the playing users from test scenes (!!), and storing the users
being wathed.
This was all a thing because the previous implementation overrode the
base method implementations, which is no longer a thing.
2021-05-20 17:41:46 +09:00
smoogipoo
6beeb7f7c4
Rename SpectatorStreamingClient -> SpectatorClient
2021-05-20 15:55:07 +09:00
Salman Ahmed
97c8499884
Add test coverage
2021-05-19 23:01:41 +03:00
Salman Ahmed
71da960000
Extract assert step addition out of assertion method
2021-05-19 22:53:22 +03:00
Salman Ahmed
21ca9c8431
Merge branch 'master' into beatmap-skin
2021-05-19 22:39:32 +03:00
Salman Ahmed
6fc06a10a1
Add extensible test scene for beatmap skins fallback instead
2021-05-19 21:52:29 +03:00
Salman Ahmed
d1272d5e13
Group all skinnable test scenes to one TestSceneSkinnableHUDComponents
2021-05-18 12:38:06 +03:00
Dean Herbert
c885ad87d5
Update HitErrorDisplay tests
2021-05-18 15:12:29 +09:00
Dean Herbert
da0913ca2d
Make SongProgress a skinnable component
2021-05-17 18:52:56 +09:00
Dean Herbert
c8b7cfc753
Merge branch 'skin-serialisation' into remove-skinnable-hud-classes
2021-05-13 19:05:08 +09:00
Dean Herbert
e0e9106921
Enable autoplay in skin editor tests
2021-05-13 14:55:11 +09:00
Dean Herbert
8b9ac86d4b
Merge branch 'master' into skin-serialisation
2021-05-13 12:35:06 +09:00
Dean Herbert
55e1f97f59
Remove unused using statement
2021-05-12 19:06:40 +09:00
Dean Herbert
0a895fff15
Remove remaining test usage of SkinnableXXX HUD components
2021-05-12 18:53:25 +09:00
Dean Herbert
c6f0a6aed3
Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen
...
Implement the multiplayer spectator screen
2021-05-12 17:24:35 +09:00
smoogipoo
21fc0ba43b
Combine test spectator streaming client implementations
2021-05-12 13:05:02 +09:00
Dean Herbert
048677846b
Change HealthDisplay to be a CompositeDrawable
2021-05-11 23:10:30 +09:00
Dean Herbert
61ea3f2e64
Remove unnecessary test step creating needless skins
2021-05-11 18:39:15 +09:00
Dean Herbert
2396ba42a6
Change HealthDisplay to be a CompositeDrawable
2021-05-11 18:39:14 +09:00
Dean Herbert
004798d61d
Update Legacy components to not require skin in ctor
2021-05-11 18:39:14 +09:00
smoogipoo
10a4a5decb
Merge branch 'master' into multiplayer-spectator-screen
2021-05-11 17:33:09 +09:00
Dean Herbert
2ecd638f7f
Merge branch 'master' into skin-components-list
2021-05-10 18:13:10 +09:00
Dean Herbert
97e72849af
Fix regressed HitErrorDisplay behaviour (and localise binding to meter implementations)
2021-05-10 15:24:13 +09:00
Dean Herbert
3c3500d070
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-10 12:23:18 +09:00
Dean Herbert
1d38fa29b5
Remove unused using statement
2021-05-10 12:23:04 +09:00
Dean Herbert
1bbbe80420
Fix missing instances of HealthProcessor caching
2021-05-10 12:22:24 +09:00
Dean Herbert
132bb7832d
Fix some regressions when updating test scenes
2021-05-10 12:06:33 +09:00
Dean Herbert
b274fdf20d
Merge branch 'master' into skin-components-bind-outwards-health
2021-05-10 11:13:44 +09:00
Dean Herbert
2bcf1ed306
Merge pull request #12715 from Cublibre/fix-early-exit-crash
...
Fix InvalidOperationException when exiting a map at the end
2021-05-09 23:21:19 +09:00
Christine Chen
ae2b5a0806
Actually test that player was exited
2021-05-08 22:42:14 -04:00
Bartłomiej Dach
efb9164658
Restore previous test scene logic
2021-05-08 21:35:12 +02:00
Bartłomiej Dach
0bc6a026eb
Merge branch 'master' into skin-components-bind-outwards-accuracy
2021-05-08 21:08:53 +02:00
Christine Chen
25312b3e88
Don't restart completion delegate on exit, revert exit behavior to lazer
2021-05-08 11:47:44 -04:00
Christine Chen
8c564a69ed
Fix InvalidOperationException when exiting a map at the end
2021-05-07 21:11:03 -04:00
Dean Herbert
1cb10c2a22
Remove unnecessary binding logic from HUDOverlay
2021-05-07 17:51:46 +09:00
Dean Herbert
a7acecc52b
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-07 17:51:41 +09:00
Dean Herbert
3044b1c432
Add missing cache rules
2021-05-07 17:50:44 +09:00
Dean Herbert
6c255a0572
Fix drain start time being weirdly incorrect
2021-05-07 17:47:33 +09:00
Dean Herbert
8e78cac058
Fix HealthProcessor cached as derived type in test
2021-05-07 17:31:29 +09:00
Dean Herbert
04d35826a3
Merge branch 'skin-components-bind-outwards-accuracy' into remove-hud-overlay-unused-pieces
2021-05-07 17:25:39 +09:00
Dean Herbert
84a4ff333e
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:22:56 +09:00
Dean Herbert
755588258e
Update HealthDisplay components to use DI to attach data source
2021-05-07 17:22:45 +09:00
Dean Herbert
4ac234bf7f
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 17:15:57 +09:00
Dean Herbert
6dc591fc44
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 17:15:37 +09:00
Dean Herbert
9d27b11e49
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:10:31 +09:00
Dean Herbert
01eff7f316
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 16:30:08 +09:00
Dean Herbert
93f10330e3
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 16:29:10 +09:00
Dean Herbert
ad398165a2
Update AccuracyCounter components to use DI to attach data source
2021-05-07 16:27:25 +09:00
Dean Herbert
17b93361d5
Merge branch 'master' into skin-components-bind-outwards
2021-05-07 16:20:24 +09:00
Dean Herbert
a2e4fb5b6b
Update ScoreCounter components to bind outwards
2021-05-07 16:16:48 +09:00
Dean Herbert
aff32b0d19
Merge branch 'master' into skin-components-list
2021-05-06 14:17:33 +09:00
Bartłomiej Dach
3cac837acf
Merge branch 'master' into skin-bindables
2021-05-05 20:16:27 +02:00
Dean Herbert
3cc9bad979
Actually check for correct state of fade content in rewind test
2021-05-05 17:49:33 +09:00
Christine Chen
1d4a8bc0ae
Add visual test for rewinding
2021-05-04 22:23:36 -04:00
Dean Herbert
bb9fa1a25e
Merge branch 'master' into play-storyboard-outro
2021-05-04 14:01:34 +09:00
Dean Herbert
625890381f
Update ComboCounter components to use DI to attach data source
2021-05-03 17:43:00 +09:00
Dean Herbert
a1e64f4e3c
Use the existing toolbox design
2021-04-30 14:41:06 +09:00
Dean Herbert
ae9d1dc40b
Add component list to main editor interface and enable basic placement
2021-04-30 13:10:42 +09:00
Dean Herbert
6442fb819f
Split out component from test scene and fix SongProgress
2021-04-30 13:10:42 +09:00
Dean Herbert
4770a64709
Add proof of concept components list
2021-04-30 13:10:42 +09:00
Dean Herbert
de73ac7cec
Allow skin editor to be invoked from any context
...
This is kind of how I see things working going forward, where the editor
can be applied to anything in the game which supports it (ie. a results
screen, gameplay screen, etc.) and it will immediately allow changing
the interface.
This adds a test scene which shows this working with gameplay.
2021-04-29 16:12:15 +09:00
Dean Herbert
74c6fdc4b8
Add DrawableRuleset to the skin editor test to get a hit error meter to display
2021-04-29 16:12:15 +09:00
Dean Herbert
fd587a82ff
Replace abstract class with interface, attached to the actual components (not skinnable wrapper)
2021-04-29 16:12:15 +09:00
Dean Herbert
defa350aa7
Set defaults on SkinnableHUDComponent to cancel out relative size default
...
Specifying locally on each HUD component looks to make more sense.
2021-04-29 16:12:15 +09:00
Dean Herbert
1cb8fc9a24
Extract editor classes out of test namespace and add anchor support
2021-04-29 16:12:15 +09:00
Dean Herbert
74fb7cd180
Extract storable attributes to bindables
2021-04-29 16:12:15 +09:00
Dean Herbert
99b428ee4b
Add very basic skin editor test
2021-04-29 16:12:14 +09:00
Dean Herbert
fca173225a
Refactor editor selection/blueprint components to be generic
2021-04-29 16:12:14 +09:00
Dean Herbert
2d17219c8f
Setup basic test and classes for scale adjustment
2021-04-29 16:12:14 +09:00
Dean Herbert
120fb8974d
Combine more instances of test player IDs
2021-04-26 17:22:16 +09:00
Dean Herbert
daafa41dc1
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-22 16:22:04 +09:00
smoogipoo
e78ef05fcf
Merge branch 'gcc-abstraction' into multiplayer-spectator-screen
2021-04-21 17:11:14 +09:00
smoogipoo
156a518068
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-20 21:16:05 +09:00
smoogipoo
c5d6b6ea8d
Fix tests failing intermittently
...
This was due to this code happening in UpdateAfterChildren(), after the
GCC has processed one frame. During this time, the clock could have
advanced an arbitrary amount.
The cause of this is the removal of the Task.Run() to set the clock in
Restart() (now called Reset()) which changed the timing, so it only worked before due to pure
luck.
2021-04-20 18:41:09 +09:00
smoogipoo
80473a356e
Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction
2021-04-20 17:27:01 +09:00
smoogipoo
c12848ce4d
Apply fixes to tests
2021-04-19 17:02:59 +09:00
Christine Chen
fd1241cc85
Added tests
...
New tests:
- storyboard ending during the failing animation
- showResults = false
- storyboard ending before score processor completion
Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-18 23:26:50 -04:00
Christine Chen
98460c8feb
Rename IStoryboardElementHasDuration, remove unnecessary step in tests, add Duration field
2021-04-18 20:20:14 -04:00
Christine Chen
7b1d40db7d
Remove redundant string interpolation
2021-04-17 22:13:28 -04:00
Christine Chen
e9f8fa64b8
Added a test for toggling the storyboard after the map is loaded
2021-04-17 21:49:29 -04:00
Christine Chen
7f5b1e84a1
Update TestSceneStoryboardWithOutro.cs
...
- Construct storyboard in CreateWorkingBeatmap()
- Use GameplayClockContainer.GameplayClock.CurrentTime
- Remove unnecessary lines
2021-04-17 13:57:32 -04:00
smoogipoo
5e82f40d67
Merge branch 'master' into gcc-abstraction
2021-04-16 20:14:53 +09:00
smoogipoo
65a6f9f8a4
Merge branch 'fix-initial-spectator-state-callback' into multiplayer-spectator-screen
2021-04-16 18:26:46 +09:00
smoogipoo
46d2181d42
Remove now unnecessary (duplicating) test
2021-04-16 18:21:56 +09:00
smoogipoo
377e5ce6b3
Fix test incorrect sending state too often
2021-04-16 18:21:35 +09:00
smoogipoo
ca74f413cd
Change to explicit method instead
2021-04-16 17:31:02 +09:00
smoogipoo
5652490d61
Fix OnUserBeganPlaying not being invoked if already watching
2021-04-16 14:11:55 +09:00
Christine Chen
b15838b220
Move storyboard outro logic to DrawableStoryboard
2021-04-16 00:59:10 -04:00
Christine Chen
45c2b72a25
Merge branch 'master' into play-storyboard-outro
2021-04-15 15:11:35 -04:00
Christine Chen
25b8c2f257
Allow skipping storyboard outro
...
Reuses SkipOverlay by calculating the endtime of the storyboard and using that as a "start point". Upon skipping the outro the score is instantly shown.
When the end of the storyboard is reached the score screen automatically shows up. If the player holds ESC (pause) during the outro, the score is displayed
The storyboard endtime is calculated by getting the latest endtime of the storyboard's elements, or simply returning 0 if there is no storyboard.
Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-15 13:20:40 -04:00
Dan Balasescu
ac8e462d32
Merge branch 'master' into refactor-framed-replay-input-hander
2021-04-15 21:48:58 +09:00
Dean Herbert
5b06a68b93
Merge pull request #12330 from Cublibre/master
...
Send a warning notification if device is unplugged and at low battery
2021-04-15 19:21:04 +09:00
Dean Herbert
346e36d32a
Make Mod.Description abstract and add missing descriptions
2021-04-15 14:36:26 +09:00
smoogipoo
1aa36818df
Abstractify GameplayClockContainer
2021-04-14 17:47:11 +09:00
Christine Chen
f66306a81a
Remove IsLowBattery
2021-04-12 11:15:24 -04:00
Christine Chen
43b97fe0ad
Refactor PowerStatus (now called BatteryInfo)
2021-04-12 10:52:52 -04:00
ekrctb
359fae895f
Rename property
2021-04-12 18:50:25 +09:00
ekrctb
e19e8ff2a3
Rewrite FramedReplayInputHandler for robustness
...
This commit changes the semantics of `CurrentFrame` and `NextFrame` of the class.
The ordering of `NextFrame.Time` and `CurrentFrame.Time` was dependent on the current direction.
Now, it should always satisfy `CurrentFrame.Time <= CurrentTime <= NextFrame.Time` except at the start/end.
This change, however, doesn't break existing deriving classes if the template code pattern usage of interpolation is used.
The deriving class code can be simplified due to the elimination of nullable types. I didn't include those changes in this commit.
I removed `StreamingFramedReplayInputHandlerTest` for now, as it is almost-duplicate of `FramedReplayInputHandlerTest`. I'll include more tests in later commits.
This commit fixes #6150 .
2021-04-12 16:18:11 +09:00
ekrctb
d6d8ea5b6b
Throw when getting a frame of an empty replay
2021-04-12 11:17:56 +09:00
Salman Ahmed
cb947a3b27
Add expected output in test case rather than determining internally
2021-04-11 13:18:25 -04:00
Salman Ahmed
1fd4cb8963
Merge branch 'master' into master
2021-04-11 10:19:16 +03:00
Christine Chen
08311abc5e
Remove setters, cache CreatePowerStatus() and use a dummy LocalPowerStatus class in test scene
2021-04-10 00:00:21 -04:00
Christine Chen
59d13b0dd3
Fixed indentation
...
sorry about the style fixes... I'm using JetBrains Rider from now on.
2021-04-08 21:53:42 -04:00
Christine Chen
6b6a71d3c3
trim whitespace
2021-04-08 20:39:17 -04:00
Christine Chen
493c095535
Fixed code style
2021-04-08 20:28:23 -04:00
Christine Chen
6bccb3aab6
Use DI to implement battery detection, add BatteryCutoff property
...
- Removed the Xamarin.Essentials package from osu.Game and added it to osu.iOS and osu.Android only.
- iOS and Android implementations use Xamarin.Essentials.Battery, while the Desktop implementation
only returns 100% battery for now.
- Added a BatteryCutoff property to PowerStatus so it can be different for each platform (default 20%, 25% on iOS)
2021-04-08 19:55:11 -04:00
Dean Herbert
8aff53172d
Remove necessity for nested PassThroughInputManger
2021-04-08 15:18:31 +09:00
Christine Chen
0a6baf670e
Send a warning notification if device is unplugged and low battery
...
- Uses Xamarin.Essentials in osu.Game.PlayerLoader to check battery level
- Encapsulated battery checking in the public BatteryManager class so battery level and plugged in status can be accessed and edited in TestPlayerLoader
- When checking battery level, catch NotImplementedException thrown by Xamarin.Essentials.Battery on non-mobile platforms
- Added visual unit tests for battery notification
To mock battery status and level, we had to define a batteryManager object in TestPlayerLoader and add a new function ResetPlayerWithBattery()
Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-07 15:56:50 -04:00
Dean Herbert
beebdb0734
Clean up implementation
2021-04-05 22:30:51 +09:00
smoogipoo
c3c7c18549
Fix tests
2021-04-01 23:48:26 +09:00
smoogipoo
9e95441aa6
Rename Spectator -> SoloSpectator
2021-04-01 22:08:52 +09:00
Bartłomiej Dach
aec859b4d1
Merge branch 'master' into fix-unsafe-skinnable-sample-play
2021-03-18 19:51:46 +01:00
smoogipoo
7fa5fd5647
Update usages of config with framework changes
2021-03-17 16:10:16 +09:00
Dean Herbert
a5b3ac7ef8
Add failing test covering alpha commands proceeding non-alpha (but ignored) commands
2021-03-09 15:54:11 +09:00
smoogipoo
ee6a94273d
Merge branch 'master' into fix-unsafe-skinnable-sample-play
2021-02-22 18:31:27 +09:00
Salman Ahmed
6bac83964a
Merge branch 'master' into fix-pofl-on-cooldown
2021-02-22 10:03:27 +03:00
Dean Herbert
d2ec151c67
Add failing test for pausing when pause support is disabled
2021-02-20 14:20:13 +09:00
Salman Ahmed
f6c279ab00
Add assert ensuring player resumed properly
2021-02-19 11:45:45 +03:00
Salman Ahmed
fe5e45ea81
Move gameplay cursor outside instead and fix potential failure
2021-02-19 11:43:33 +03:00
Dean Herbert
52ebe34347
Update TestScenePause exit from fail test to actually fail
2021-02-19 17:26:26 +09:00
Dean Herbert
4c214b74ce
Merge branch 'master' into fix-error-exit-during-results-transition
2021-02-19 17:13:55 +09:00
Salman Ahmed
772471a6d8
Add failing test case
2021-02-19 10:46:31 +03:00
Dean Herbert
00574a5288
Use ISample everywhere in Skin GetSample lookup path
2021-02-18 18:32:28 +09:00
Dean Herbert
2e646882fa
Merge branch 'master' into non-concurrent-sample-playback
2021-02-15 21:22:21 +09:00
Dean Herbert
9ad38ab20e
Move HubClientConnector retrieval to IAPIProvider
2021-02-15 16:43:56 +09:00
Dean Herbert
f664fca0dd
Tidy up tests (and remove duplicate with new call logic)
2021-02-15 16:11:17 +09:00
Dean Herbert
4f264758a4
Add test coverage of pause from resume overlay
2021-02-15 15:57:36 +09:00
smoogipoo
c6ed3efa4a
Merge branch 'master' into non-concurrent-sample-playback
2021-02-15 14:47:32 +09:00
Dean Herbert
25f5120fdf
Add failing test coverage of user pausing or quick exiting during cooldown
2021-02-15 14:36:17 +09:00
Dean Herbert
a4dc544235
Refactor some shared code in TestScenePause
2021-02-15 14:24:08 +09:00
Dan Balasescu
34e600464b
Merge branch 'master' into abstract-hub-connection
2021-02-15 13:53:54 +09:00
smoogipoo
d3f0c0730d
Merge branch 'master' into non-concurrent-sample-playback
2021-02-12 17:22:15 +09:00
Salman Ahmed
d3c1b47592
Replace nullable API with null connector instead
2021-02-11 12:34:39 +03:00
Dean Herbert
94f35825dd
Update test to cover changed exit/pause logic
...
I think this makes more sense?
2021-02-09 17:29:30 +09:00
Salman Ahmed
a0ead38496
Prevent test spectator clients from attempting hub connections
2021-02-09 08:02:51 +03:00
Salman Ahmed
f04d6d5e5e
Update hub clients with changes to connecotr
2021-02-09 08:02:32 +03:00
Salman Ahmed
f76f92515e
Clean up spectator streaming client with new hub connector
2021-02-09 02:15:56 +03:00
Bartłomiej Dach
68c20a2a37
Allow autoplay score generation to access mod list
2021-02-07 18:35:34 +01:00
Mysfit
304264046b
Added tests.
2021-01-24 17:46:54 -05:00
Bartłomiej Dach
7abe33ad0e
Add failing test case
2021-01-21 00:04:15 +01:00
smoogipoo
8ffbcc9860
Fix test failures and general discrepancies
2021-01-20 14:05:35 +09:00
smoogipoo
de9d075f94
Initial sample + samplechannel rework
2021-01-19 17:11:40 +09:00
Dean Herbert
d023ad8ad1
Remove assert messages
2021-01-15 15:18:29 +09:00
Dean Herbert
51255033e2
Update some missed usages of KeyBindingContainer in tests
2021-01-15 14:57:01 +09:00
Roman Kapustin
0ea4e221b2
Merge branch 'master' into net5.0
2021-01-14 14:02:51 +03:00
mcendu
17abe90c27
move SkinnableHealthDisplay
...
Similar components are in osu.Game.Screens.Play.HUD while this is not
2020-12-31 20:23:13 +08:00
Dean Herbert
92d74a9343
Fix potential nullref in test scene
2020-12-28 20:48:14 +09:00
Dean Herbert
6254907ef9
Move multiplayer leaderboard test to correct namespace
2020-12-28 20:31:08 +09:00
Dean Herbert
966a2151e3
Ensure the previous leaderboard is removed
2020-12-26 17:55:24 +09:00
Dean Herbert
2599e95335
Add test coverage
2020-12-26 12:11:19 +09:00
Dean Herbert
ff57562956
Fix multiplayer leaderboard not unsubscribing from quit users
2020-12-26 11:35:31 +09:00
Dean Herbert
fa14438671
Merge pull request #11285 from peppy/resort-leaderboard-less
...
Re-sort the leaderboard order a maximum of once a second
2020-12-25 00:05:13 +09:00
Dean Herbert
d0e8347968
Change asserts into until steps
2020-12-24 22:28:25 +09:00
Dean Herbert
eb795a2127
Move all endpoint information to a configuration class
2020-12-24 17:58:38 +09:00
Dean Herbert
8ac76bd524
Merge pull request #11199 from smoogipoo/refactor-player-score-creation
...
Asyncify player score creation and submission
2020-12-20 17:30:11 +09:00
Bartłomiej Dach
f827b6c030
Use terser dictionary initialiser syntax
2020-12-19 21:26:40 +01:00
Bartłomiej Dach
631a0cea41
Fix intended random factor not being random in test
2020-12-19 21:25:04 +01:00
Dean Herbert
b3bff281ce
Merge branch 'master' into spectator-driven-leaderboard
2020-12-20 01:13:59 +09:00
Salman Ahmed
228acf25a7
Add test case creating leaderboard scores with existing users
2020-12-18 13:13:31 +03:00
smoogipoo
2958cab239
Remove GotoRanking
2020-12-18 17:47:33 +09:00
Dean Herbert
470c68d6a5
Merge branch 'gameplay-leaderboard-update' into spectator-driven-leaderboard
2020-12-18 17:30:21 +09:00
Dean Herbert
668536ce56
Fix vertical size potentially changing during relayout
2020-12-18 17:25:48 +09:00
Dean Herbert
bca4d83af7
Revert previous player add flow via interface
2020-12-18 17:19:55 +09:00
Dean Herbert
5e83605026
Merge branch 'gameplay-leaderboard-update' into spectator-driven-leaderboard
2020-12-18 17:07:43 +09:00
Dean Herbert
157a72ec5d
Revert previous player add flow via interface
2020-12-18 17:07:38 +09:00
Dean Herbert
96f23a1135
Merge branch 'master' into gameplay-leaderboard-update
2020-12-18 16:56:21 +09:00
Dean Herbert
869cac819d
Merge branch 'gameplay-leaderboard-update' into spectator-driven-leaderboard
2020-12-18 16:55:44 +09:00
smoogipoo
2db7433c0b
Refactor player score creation and submission process
2020-12-18 16:51:59 +09:00
Dean Herbert
99f2032fdf
Merge branch 'master' into gameplay-leaderboard-update
2020-12-18 16:44:52 +09:00
Dean Herbert
ceb2e4762d
Add test covering a more consistent spread of player scores
2020-12-18 16:20:42 +09:00
Salman Ahmed
a8abefcd66
Make GameplayLeaderboardScore a model class
2020-12-18 03:34:33 +03:00
Salman Ahmed
0faf3fdfd3
Update gameplay leaderboard scores with the new design
2020-12-17 15:19:10 +03:00
Dean Herbert
cc3dddf59f
Fix test scene crashing on second run of SetUp
...
Also correctly support LongRunningLoad
2020-12-17 16:02:07 +09:00
Dean Herbert
cda3bd2017
Rename test scene to match tested class name
2020-12-16 16:22:47 +09:00
Dean Herbert
6bce587b59
Pass users in via constructor and correctly unbind on disposal
2020-12-16 16:20:29 +09:00
Dean Herbert
c1ba0f4642
Use a local lookup cache for better usernames
2020-12-16 16:20:29 +09:00
Dean Herbert
09d0ceb766
Add testing setup to get a better visual idea of how scoreboard will work
...
fixup! Add method to ScoreProcessor to calculate score and accuracy from statistics
2020-12-16 16:20:29 +09:00
Dean Herbert
fb795f6bfd
Add initial hook-up to spectator backend
2020-12-16 16:20:29 +09:00
Dean Herbert
88b3bf06e8
Merge branch 'master' into add-bundle-header
2020-12-16 13:40:15 +09:00
Dean Herbert
b5ab400ad7
Fix test filename not matching updated class name
2020-12-15 15:44:43 +09:00
Dean Herbert
8b68ccc0ff
Rename class and move inside HUD namespace
2020-12-15 15:34:11 +09:00
Dean Herbert
8362ad37e3
Bring up-to-date with code changes
2020-12-15 15:22:14 +09:00
Dean Herbert
70e5d4495a
Merge branch 'master' into ingame-leaderboard-general-implementation
2020-12-15 15:14:56 +09:00
Dean Herbert
64a2526678
Add header class and basic flow for propagating data updates
2020-12-14 17:33:23 +09:00
Dean Herbert
1793385e96
Pass a score to the replay recorder to allow reading more general scoring data
2020-12-14 16:52:14 +09:00
Dean Herbert
53da137425
Merge branch 'master' into net5.0
2020-12-10 17:14:21 +09:00
Dean Herbert
31cfaefdeb
Move private functions in line with others
2020-11-30 15:39:43 +09:00
Dean Herbert
809caaa44c
Use standard switch syntax (preferred for now)
2020-11-30 15:39:08 +09:00
Dan Balasescu
0c36a3c263
Merge branch 'master' into pool-scrolling
2020-11-30 14:04:54 +09:00
Bartłomiej Dach
9bf70e4e97
Add slider test step for visual inspection purposes
2020-11-28 20:32:08 +01:00
Bartłomiej Dach
8e0f525588
Rewrite existing test scene somewhat
2020-11-28 20:29:35 +01:00
ekrctb
8f5129323d
Merge branch 'master' into pool-scrolling
2020-11-27 13:12:05 +09:00
ekrctb
57454bbb1c
Remove hitObject argument from OnApply and OnFree
2020-11-27 10:13:05 +09:00
ekrctb
eae33fe74a
Fix format
2020-11-26 14:16:33 +09:00
ekrctb
0817dae86c
Add failing test to check non-pooled lifetime
2020-11-26 12:35:49 +09:00
ekrctb
ec92545d7a
fix indent
2020-11-24 18:56:05 +09:00
ekrctb
cabc8aa63b
Revert "Simplify ScrollingHitObjectContainer logic"
...
This reverts commit b4cc39149c117e6a0e95ee917a67cec8ba723d06.
2020-11-24 18:56:05 +09:00
ekrctb
8f39b54e58
Simplify ScrollingHitObjectContainer logic
2020-11-24 18:56:05 +09:00
ekrctb
df3844cdbb
Add failing tests for pooling scrolling playfield
2020-11-24 18:56:05 +09:00
Roman Kapustin
1feda1152d
Fix InspectCode warnings
2020-11-21 02:06:20 +03:00
Dean Herbert
dd5b90cf6c
Add test coverage of animation restarting
2020-11-19 18:08:54 +09:00
Dean Herbert
fe025043bd
Make test run multiple times
2020-11-19 17:16:29 +09:00
Dean Herbert
9df93e1f18
Add basic implementation of particle explosion
...
Using drawables still, just to get things in place and setup the
structure
2020-11-19 14:54:33 +09:00
smoogipoo
f5e12b9d7c
Adjust TestScenePlayerLoader for safety
2020-11-16 23:53:54 +09:00
Bartłomiej Dach
42de4437cc
Add failing test case
2020-11-15 19:43:42 +01:00
smoogipoo
b4470b0152
Merge branch 'fix-broken-test' into osu-hitobject-pooling-playfield
2020-11-14 01:50:13 +09:00
smoogipoo
b4d4f5456c
Fix broken fail judgement test
2020-11-14 01:49:48 +09:00
smoogipoo
5cbf6252b7
Merge branch 'hitobject-pooling-in-playfield' into osu-hitobject-pooling-playfield
2020-11-14 01:03:11 +09:00
smoogipoo
c71b237c4f
Merge all pooling support into Playfield
2020-11-14 00:59:08 +09:00
smoogipoo
36f1833f6e
Move hitobject pooling to Playfield
2020-11-14 00:41:18 +09:00
smoogipoo
feabca860b
Fix sample playback test
2020-11-13 18:35:33 +09:00
smoogipoo
4236dd826d
Improve documentation and make abstract again
2020-11-13 14:57:09 +09:00
smoogipoo
5dbbe11fc6
Remove PoolHitObjects, use return value of CreateDrawableRepresentation() instead
2020-11-12 14:04:16 +09:00
smoogipoo
3401b099d4
Add some tests
2020-11-11 18:50:08 +09:00
Joehu
ef3c918a3c
Simplify input buttons/keys in tests
2020-11-09 14:18:20 -08:00
Dean Herbert
1e1569eb53
Use int instead of long for user_id fields for now
2020-11-06 12:59:46 +09:00
Dean Herbert
ce1743ab28
Fix missed usage in test scene
2020-11-04 15:35:42 +09:00
Dean Herbert
c1d9a0c92c
Move click action out of user panel
2020-11-02 21:09:47 +09:00
Dean Herbert
ed30756c19
Add test coverage for new display (and remove live version for now)
2020-11-02 20:41:14 +09:00
Dan Balasescu
04178e9458
Merge branch 'master' into spectator-replay-watcher
2020-11-02 14:54:51 +09:00
Dan Balasescu
1b53e6c782
Merge branch 'master' into sample-lookup-improvements
2020-11-02 13:04:35 +09:00
Dean Herbert
9a43291fd3
Merge branch 'master' into spectator-replay-watcher
2020-10-30 20:49:24 +09:00
smoogipoo
43f9c1ebea
Fix HUD test having out of date value
2020-10-30 18:26:38 +09:00
Dean Herbert
79aecc9a98
Merge branch 'master' into spectator-replay-watcher
2020-10-30 16:31:24 +09:00
Dan Balasescu
0ef1459f4b
Merge pull request #10621 from peppy/hud-momentary-visibility
...
Add momentary HUD toggle
2020-10-30 15:40:54 +09:00
Dean Herbert
984a243eff
Add skinnable test scene for HUD overlay
2020-10-30 14:24:16 +09:00
Dean Herbert
bd7871d9f5
Update test scene to be non-skinnable (and add test covering momentary display)
2020-10-30 14:20:00 +09:00
Dean Herbert
53bd31c69e
Commit missing test pieces
2020-10-30 14:00:07 +09:00
Dean Herbert
2ea4aa0a37
Fix incorrect specification on some sample lookups
2020-10-30 11:59:41 +09:00
Dean Herbert
fa85751425
Move helper functions to bottom of class
2020-10-29 15:10:42 +09:00
Dean Herbert
fe409a55e6
Rename starvation test
2020-10-29 15:10:11 +09:00
Dean Herbert
ce58bfdc4e
Add test covering host retry after returning to spectator screen
2020-10-29 15:09:12 +09:00
Dean Herbert
6a31a313b6
Fix stop watching test to check correct screen presence
2020-10-29 15:08:06 +09:00
Dean Herbert
7dd3a748be
Add further test logic to ensure retry / restart flow is working correctly
2020-10-29 15:03:38 +09:00
Dean Herbert
a59ea987b7
Make tests more resilient under headless execution
2020-10-29 14:57:36 +09:00
Dean Herbert
6c2cee7b3f
Avoid cross-pollution between tests of current playing state
2020-10-28 23:15:51 +09:00
Dean Herbert
7cc4a7cb5c
Add more accurate fail scenario test logic
2020-10-28 22:59:54 +09:00
Dean Herbert
1d499ec15d
Change beatmap not existing test to specify a beatmap ID that can't possibly exist
2020-10-28 22:51:35 +09:00
Dean Herbert
8bbcb9be8a
Always use imported beatmap in tests
2020-10-28 22:50:57 +09:00
Dean Herbert
5fcd39a43d
Ensure spectator screen is loaded before continuing
2020-10-28 16:29:06 +09:00
Dean Herbert
d5e0fa322b
Fix a couple of inspections
2020-10-27 22:30:45 +09:00
Dean Herbert
2cacdaa11b
Add basic beatmap download and play flow
2020-10-27 19:28:34 +09:00
Dean Herbert
42b3aa3359
Fix spectating when starting from a point that isn't at the beginning of the beatmap
2020-10-27 18:58:37 +09:00
Dean Herbert
a289b7034f
Add test helper functions to promote code share
2020-10-27 18:58:37 +09:00
Dean Herbert
b3d793a505
Fix gameplay proceeding when no frames have been received yet
2020-10-27 18:58:37 +09:00
Dean Herbert
d4467d20a2
Allow tests to continue sending frames from point they left off
2020-10-27 18:58:37 +09:00
Dean Herbert
63131d46aa
Send initial spectator state more correctly in test component
2020-10-27 18:58:37 +09:00
Dean Herbert
4dba96e189
Add more useful frame sending logic to tests
2020-10-27 18:58:37 +09:00
Dean Herbert
c1e7cd6e47
Stop replay playback when frames are starved
2020-10-27 18:58:37 +09:00
Dean Herbert
400542bc0b
Ensure frames arrive
2020-10-27 18:58:37 +09:00
Dean Herbert
593b0a3ada
Setup tests to run headless, add basic pass support
2020-10-27 18:58:37 +09:00
Dean Herbert
67f6d52e35
Setup tests
2020-10-27 18:58:37 +09:00
Dean Herbert
9bb2cff8a5
Convey actual beatmap and ruleset for full testing setup
2020-10-27 18:58:37 +09:00
Dean Herbert
82a27c73a0
Create basic testing setup
2020-10-27 18:58:37 +09:00
Dean Herbert
5fd97bd043
Add basic spectator screen
2020-10-27 18:58:37 +09:00
Dean Herbert
03d566da35
Rename test variable and remove unncessary cast
2020-10-27 14:35:12 +09:00
Dean Herbert
606a4304a8
Remove unused usings
2020-10-27 14:33:16 +09:00
Dean Herbert
6853da459d
Move sample pausing logic out of FrameStabilityContainer
2020-10-27 13:54:33 +09:00
Bartłomiej Dach
7392876b5f
Fix mania crashing due to spectator client handling frames with unconverted beatmap
2020-10-27 00:35:25 +01:00
Dean Herbert
b1a88a4993
Remove extra using
2020-10-26 16:34:30 +09:00
Dean Herbert
dfe07271de
Add very basic latency handling to spectator test
2020-10-26 16:31:39 +09:00
Dean Herbert
f5dbaa9b0f
Only watch local user to prevent conflict between testers
2020-10-26 15:27:15 +09:00
Dean Herbert
8508d5f8b9
Rename test scene to match purpose
2020-10-26 15:24:28 +09:00
Dean Herbert
e941f2fb71
Fix playback not being smooth (and event unbinding logic)
2020-10-26 15:24:12 +09:00
Dean Herbert
b86347dc81
Merge branch 'master' into spectator
2020-10-26 13:39:07 +09:00
Dean Herbert
431054377a
Merge branch 'master' into epilepsy-warning-volume-restoration
2020-10-25 22:22:11 +09:00
Dean Herbert
55f1b05dbf
Fix test failures due to recorder not stopping in time
2020-10-23 14:47:08 +09:00
Dean Herbert
51ae93d484
Revert unnecessary file changes
2020-10-22 19:31:59 +09:00
Dean Herbert
04f46bc1f8
Clean up usings
2020-10-22 19:24:32 +09:00
Dean Herbert
d659b7739d
Correctly stop watching users that leave
2020-10-22 19:16:34 +09:00
Dean Herbert
34e889e66e
Don't watch every user in normal gameplay (but allow so in test)
2020-10-22 18:38:03 +09:00
Dean Herbert
1ab6f41b3b
Add basic send and receive test
2020-10-22 18:10:27 +09:00
Dean Herbert
93db75bd41
Begin shaping the spectator streaming component
2020-10-22 17:48:15 +09:00
Dean Herbert
b39a4da6bc
Add initial classes for spectator support
2020-10-22 14:46:21 +09:00
Bartłomiej Dach
e2552d4c36
Merge branch 'master' into storyboard-skin-sprites
2020-10-20 23:01:54 +02:00
Bartłomiej Dach
8c14c9e1c4
Add basic test coverage
2020-10-20 23:01:25 +02:00
Bartłomiej Dach
2c7880e9d6
Add failing test case
2020-10-20 20:30:15 +02:00
Dan Balasescu
bd4e0e1a60
Merge branch 'master' into epilepsy-warning
2020-10-20 17:43:37 +09:00
Dean Herbert
4f8a755518
Add "hide during gameplay" mode
2020-10-20 14:20:44 +09:00
Dean Herbert
80b1f816c7
Merge branch 'master' into hide-hud-during-break-time
2020-10-20 14:19:04 +09:00
Bartłomiej Dach
fd4bab85cf
Merge branch 'master' into epilepsy-warning
2020-10-20 01:06:46 +02:00
Bartłomiej Dach
1ac0b3b13d
Add asserts to tests
2020-10-20 00:08:26 +02:00
Bartłomiej Dach
a9f27a71a2
Fix code formatting issues
2020-10-19 23:53:41 +02:00
Bartłomiej Dach
8aeeed9402
Fix weird number formatting in test
2020-10-17 15:47:37 +02:00
Bartłomiej Dach
e4463254d7
Add test coverage for score counter alignment
2020-10-17 15:29:30 +02:00
smoogipoo
dfbc0965e4
Merge branch 'master' into peppy/skinnable-health-display
2020-10-16 23:17:17 +09:00
Dean Herbert
e87f515a4f
Merge pull request #10522 from Morilli/legacyskin-fixes
...
Add support for ScorePrefix and ScoreOverlap values in legacy skins
2020-10-16 20:54:03 +09:00
Dean Herbert
0437f7e7e9
Delete outdated test scene
...
Has been replaced by the four new skinnable tests for each component.
2020-10-16 18:22:20 +09:00
Dean Herbert
de60374c88
Remove unused using
2020-10-16 17:26:14 +09:00
Dean Herbert
c0a1f2158c
Add basic component structure for skinnable health displays
2020-10-16 17:08:46 +09:00
Dean Herbert
88f74921fb
Update with new r# inspections
2020-10-16 12:49:39 +09:00
Dan Balasescu
583fdc3a95
Merge pull request #10510 from peppy/skinnable-accuracy-display
...
Add legacy skinning support for accuracy display
2020-10-15 21:20:48 +09:00
Dan Balasescu
5d8cf87155
Merge pull request #10511 from peppy/bottom-error-display
...
Add support for bottom-anchored hit error display
2020-10-15 20:51:09 +09:00
Dan Balasescu
70b050f212
Merge branch 'master' into skinnable-accuracy-display
2020-10-15 20:28:57 +09:00
Dan Balasescu
1ce0e83e59
Merge branch 'master' into skinnable-score-display
2020-10-15 19:16:03 +09:00
Dan Balasescu
93dfbd5d9e
Merge pull request #10505 from peppy/skin-disabler-refactor
...
Move ISampleDisabler implementation to Player and FrameStabilityContainer
2020-10-15 19:14:52 +09:00
Dean Herbert
70806deba1
Add support for bottom-anchored hit error display
2020-10-15 19:14:02 +09:00
Dean Herbert
b31a3fbabb
Add test
2020-10-15 18:11:30 +09:00
Dean Herbert
e1da64398e
Add and consume skinnable score counter
2020-10-15 17:14:42 +09:00
Dean Herbert
219cbec6bd
Split out DefaultScoreCounter and make ScoreCounter abstract
2020-10-15 16:32:30 +09:00
Dean Herbert
b06f59ffdc
Split out test for combo counter specifically
2020-10-15 15:35:33 +09:00
Bartłomiej Dach
2ca6c4e377
Adjust test step names
2020-10-14 23:24:16 +02:00
Dean Herbert
b63303a2a8
Fix tests
2020-10-14 21:40:49 +09:00
Dean Herbert
e3eaba7b2c
Move ISampleDisabler implementation to Player and FrameStabilityContainer
2020-10-14 19:39:48 +09:00
Dean Herbert
7f5ea57bd4
Clean-up pass (best effort) on LegacyComboCounter
2020-10-14 19:16:34 +09:00
Dean Herbert
9bb8a43bce
Combine LegacyComboCounter and ComboCounter classes
2020-10-14 19:16:34 +09:00
Dean Herbert
2fce064e32
Add basic legacy combo counter and updating positioning logic
2020-10-14 19:16:34 +09:00
Dean Herbert
6eb3176776
Add combo incrementing tests to hud overlay test suite
2020-10-14 19:16:34 +09:00
Dean Herbert
375146b489
Make HUDOverlay test scene skinnable
2020-10-14 19:16:34 +09:00
Shane Woolcock
f90ac2e76c
Ensure we assert after the seek has completed
2020-10-07 18:50:02 +10:30
Shane Woolcock
2e0a9f53c1
Add test coverage
2020-10-07 17:52:39 +10:30
Bartłomiej Dach
9eeac759b8
Re-enable and fix gameplay sample playback test
2020-10-05 21:22:32 +02:00
Dean Herbert
606a08c6ad
Temporarily ignore failing gameplay samples test
2020-10-05 20:01:12 +09:00
Dean Herbert
e1c4c8f3d5
Add failing test coverage of gameplay sample pausing (during seek)
2020-10-05 14:27:51 +09:00
smoogipoo
7890319802
Merge branch 'master' into adjust-hit-result-types
2020-10-01 16:19:07 +09:00
Dean Herbert
367b35bb10
Merge branch 'master' into fix-storyboard-sample-pausing
2020-09-30 22:42:26 +09:00
Dean Herbert
414c40d298
Reverse inheritance order of SkinnableSound's pause logic
2020-09-30 15:45:14 +09:00
smoogipoo
f439c1afbc
Make osu/taiko/catch use Ok+Great
2020-09-29 17:16:55 +09:00
Dean Herbert
56c8e4dacf
Fix failing tests
2020-09-29 14:25:39 +09:00
Dean Herbert
d6f3beffb6
Use existing bindable flow instead
2020-09-29 12:50:17 +09:00
Bartłomiej Dach
8d9945dea8
Change until step to assert for consistency
2020-09-27 11:28:23 +02:00
Bartłomiej Dach
00aea77489
Fix potential instability of overlay activation tests
2020-09-27 11:18:13 +02:00
Salman Ahmed
522e2cdbcd
Avoid embedding NUnit Assert inside test steps if possible
2020-09-19 05:56:35 +03:00
Salman Ahmed
1e1422c16a
Samples don't get paused...
2020-09-19 05:55:39 +03:00
Salman Ahmed
b3ffd36b65
Use lambda expression instead
2020-09-19 05:55:28 +03:00
Salman Ahmed
6aa84424e4
Merge remote-tracking branch 'upstream/master' into fix-new-samples-starting-while-gameplay-paused
2020-09-19 05:53:04 +03:00
smoogipoo
c7d24203ce
Make beatmap conversion support cancellation tokens
2020-09-17 17:40:05 +09:00
Salman Ahmed
105634c099
Add test case ensuring correct behaviour
2020-09-16 01:59:41 +03:00
Dean Herbert
d3957e6155
Move title specification for settings groups to constructor
...
Using an abstract property was awkward for this as it is being consumed
in the underlying constructor but could not be dynamically set in time from a
derived class.
2020-09-09 18:50:31 +09:00
Lucas A
82e314da59
Fix merge conflicts.
2020-09-03 21:56:47 +02:00
Dean Herbert
4239e9f684
Fix storyboard test not actually working due to incorrect track referencing
2020-08-21 18:44:14 +09:00
Dean Herbert
d5cbb589c2
Revert some test scene changes to use Beatmap.Track where relevant
2020-08-21 17:21:08 +09:00
Dean Herbert
357fb3a10e
Merge branch 'master' into beatmap-track-rework
2020-08-21 12:53:09 +09:00
Dean Herbert
5714c761eb
Merge pull request #9768 from frenzibyte/allow-counter-customize-sprite-text
...
Allow providing custom sprite text for RollingCounter<T>
2020-08-20 00:14:48 +09:00
Salman Ahmed
8f1a71c6b1
Remove counter sprite attributes for not being of any reasonable use
2020-08-19 07:44:45 +03:00
Dean Herbert
e4303d7943
Fix PlayerLoader test failures due to too many steps
2020-08-18 12:35:23 +09:00
Dean Herbert
93a8bc3d5a
Remove local reset method in GameplayClockContainer
2020-08-17 22:36:09 +09:00
Dean Herbert
d9debef156
Add explicit LoadTrack method
2020-08-17 15:38:16 +09:00
Lucas A
589d4eeb52
Remove setting.
2020-08-16 17:18:40 +02:00
Dean Herbert
71f4e753f0
Merge branch 'master' into beatmap-track-rework
2020-08-16 22:35:32 +09:00
Bartłomiej Dach
c1a9bf507a
Add failing test case
2020-08-15 13:06:53 +02:00
Dean Herbert
e465afa280
Merge branch 'master' into beatmap-track-rework
2020-08-14 20:02:43 +09:00
Lucas A
74a8a4bca8
Make testing code clearer to understand.
2020-08-13 21:53:17 +02:00
Dean Herbert
cf9bda6c19
Add coverage of early exit with null and non-null player
2020-08-13 13:05:13 +09:00
Dean Herbert
fd7bf70b7d
Remove weird "after load" action
...
This was pretty pointless anyway and from its usages, doesn't look to
need to exist.
2020-08-13 13:03:18 +09:00
Dean Herbert
5b536aebe7
Add missing null checks and avoid cross-test pollution
2020-08-13 12:53:37 +09:00
smoogipoo
070d71ec27
More cleanups
2020-08-12 00:48:38 +09:00
smoogipoo
20197e2768
Remove locally-cached music controller
2020-08-11 12:27:32 +09:00
Lucas A
052bb06c91
Add ability to open overlays during gameplay breaks.
2020-08-10 20:13:50 +02:00
smoogipoo
e87f50f74f
Rename method
2020-08-07 22:31:41 +09:00
smoogipoo
5002d69f69
Update inspections
2020-08-07 20:51:56 +09:00
Lucas A
f8ef53a62e
Fix tests.
2020-08-07 10:25:51 +02:00
smoogipoo
2e3ecf71c7
Pass track from Player to components
2020-08-06 18:31:08 +09:00
smoogipoo
5c05fe3988
Expose track from MusicController
2020-08-06 16:24:14 +09:00
smoogipoo
6e42b8219c
Move track to MusicController, compiles
2020-08-06 16:24:14 +09:00
Lucas A
242a035f7e
Apply review suggestions.
2020-08-03 21:25:45 +02:00
Lucas A
25ebb8619d
Add tests.
2020-08-03 16:04:11 +02:00
Dean Herbert
ca434e82d9
Fix test failures due to gameplay clock not being unpaused
2020-07-28 17:09:38 +09:00
Dean Herbert
91c2afe9f1
Merge branch 'master' into fix-gameplay-sample-pausing
2020-07-28 15:10:37 +09:00
Dean Herbert
cc0d5d74d7
Merge branch 'master' into Issue#9170
2020-07-28 13:36:42 +09:00
Dean Herbert
33e8e0aa18
Add back until steps so headless tests can better handle thread delays
2020-07-27 19:05:31 +09:00
Dean Herbert
1f8abf2cf6
Fix headless tests
2020-07-27 19:03:21 +09:00
Dean Herbert
5fd73795f6
Remove wait steps and add coverage of non-looping sounds
2020-07-27 18:02:17 +09:00
Dean Herbert
12368ace3b
Rename variable
2020-07-27 17:46:44 +09:00
Dean Herbert
d8f4e044de
Add test coverage
2020-07-27 17:46:10 +09:00
Dean Herbert
2c62b23d85
Update naming
2020-07-22 19:53:45 +09:00
Dean Herbert
fea6389f69
Hide HUD elements during break time by default
2020-07-22 12:41:06 +09:00
Gagah Pangeran
d9fedb293a
add initial test
2020-07-21 15:48:11 +07:00
Dean Herbert
648e414c14
Update InputHandlers in line with framework changes
2020-07-19 11:39:11 +09:00
Dean Herbert
77143952a9
Add test coverage
2020-07-17 19:17:48 +09:00
smoogipoo
9f7750e615
Add texture wrapping support to skins
2020-07-17 16:54:30 +09:00
Dean Herbert
fa407d2c7b
Make tests better
2020-07-15 16:42:37 +09:00
Joehu
ec3fe8d346
Add test for arrow key seeking
2020-07-14 21:59:26 -07:00
Bartłomiej Dach
3783fe8d6a
Rename fields for clarity
2020-06-26 19:39:53 +02:00
Power Maker
798e8e7a8d
Fix CI fail
2020-06-26 15:12:01 +02:00
Power Maker
efeaa1cc10
Make some changes, fix and add tests
2020-06-26 14:58:42 +02:00
Dean Herbert
a6c6e391ca
Fix player not exiting immediately on Alt-F4
2020-06-23 17:38:30 +09:00
Dean Herbert
9746e24d1e
Rename abstract TestScene
2020-06-12 19:40:54 +09:00
Salman Ahmed
84b40ea2c6
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
...
# Conflicts:
# osu.Game.Rulesets.Catch.Tests/TestSceneBananaShower.cs
# osu.Game.Rulesets.Catch.Tests/TestSceneHyperDash.cs
# osu.Game/Tests/Visual/ModTestScene.cs
# osu.Game/Tests/Visual/OsuTestScene.cs
2020-06-03 22:00:02 +03:00
Lucas A
f63c66396f
Apply review suggestions.
2020-06-02 13:32:52 +02:00
Dan Balasescu
64d1b4b11b
Merge branch 'master' into move-setter-to-duration
2020-06-01 15:55:48 +09:00
smoogipoo
013461377e
Fix potential nullref
2020-05-28 21:46:02 +09:00
Dean Herbert
cbd563e80b
Rename to IHasDuration
2020-05-27 12:38:39 +09:00
Dean Herbert
b8e0a6f127
Move sett from EndTime to Duration
2020-05-27 12:37:44 +09:00
Bartłomiej Dach
24d898c870
Demonstrate failure case in visual test scene
2020-05-21 21:56:55 +02:00
Bartłomiej Dach
8702a1b5a5
Fix test scene regression
2020-05-21 20:16:02 +02:00
smoogipoo
f98ee27185
Fix referencing wrong child
2020-05-18 20:01:00 +09:00
smoogipoo
6d70f4b410
Merge branch 'master' into allowgameplayoverlays-hide-skip
2020-05-18 19:54:38 +09:00
smoogipoo
2fd25f5ee6
Fix tests
2020-05-18 19:54:26 +09:00
Dean Herbert
be3a0a3c1d
Merge branch 'master' into remove-requiredtypes
2020-05-16 18:28:14 +09:00
smoogipoo
648999a2de
Remove all RequiredTypes usages
2020-05-16 18:17:12 +09:00
Lucas A
ed9d6f2829
Fix CI inspection.
2020-05-15 22:58:15 +02:00
Lucas A
4096463d02
Move SkipOverlay internal alpha manipulation to a nested container and adjust visual tests.
2020-05-15 19:43:01 +02:00
Dean Herbert
de50b725d5
Fix mod failure checks executing actual game logic
2020-05-12 20:08:35 +09:00
Salman Ahmed
6fa9feb15c
Merge remote-tracking branch 'upstream/master' into add-interval-list
2020-04-29 05:14:40 +03:00
Salman Ahmed
227503c0af
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
2020-04-23 16:25:33 +03:00
Salman Ahmed
2fa47992dc
Seal the ruleset creation methods and let abstract method take their place
...
Also makes `CreatePlayerRuleset()` and `CreateRulesetForSkinProvider()` not-null to avoid unwanted behaviour with their derivers
2020-04-23 13:27:12 +03:00
Dean Herbert
3b0099c687
Refactor tests
2020-04-21 12:26:43 +09:00
Dean Herbert
5a2129da7c
Merge branch 'master' into allow-cancelling-completion
2020-04-21 11:22:37 +09:00
Salman Ahmed
2c012b9af1
Use AddUntilStep whenever possible
...
Avoid redundant usage
2020-04-20 06:43:18 +03:00
Salman Ahmed
e12e3391fb
Base wait steps duration on the delay used for results display
...
With `* 2` for safety of not potentially going to the next step and the delegate not executed yet.
2020-04-20 06:42:33 +03:00
Dean Herbert
2444dd42d0
Remove not-implemented-exception
2020-04-20 09:57:46 +09:00
Dean Herbert
f3fee73441
Fix DatabasedKeyBindingContainer not using defaults for non-databased ruleset
2020-04-20 09:35:00 +09:00
Salman Ahmed
65a8860a65
Add test cases to ensure no regression in "cancelling completion"
2020-04-19 06:01:09 +03:00
Salman Ahmed
92df4e3a9e
Remove PlayerTestScene constructor and use CreateRuleset method instead
2020-04-17 11:17:51 +03:00
smoogipoo
59728ffebd
Fix up/improve test scene
2020-04-14 15:24:34 +09:00
