29257 Commits

Author	SHA1	Message	Date
Dean Herbert	3803f2f462	Fix leaderboard potentially displaying the wrong scores ... Closes #14762. This class is ugly. I think the whole process should be clened up once we have correctly-scheduled `SynchronizationContext`s. There's not much saving it as long as all these interdispersed `Schedule`s around required.	2021-10-06 16:07:29 +09:00
Dean Herbert	222997f2b9	Copy difficulty settings back out to BeatmapInfo on editor changes	2021-10-06 15:19:26 +09:00
Dean Herbert	0ab8dcc2a0	Fix taiko weird difficulty multiplier failing on double convert	2021-10-06 15:18:06 +09:00
Dean Herbert	b339c149d8	Copy BaseDifficulty to Beatmap<T> and move all write operations across	2021-10-06 15:10:45 +09:00
Dan Balasescu	e6aa05a4a4	Merge pull request #14978 from peppy/fix-editor-file-selector-textbox-drags ... Fix dragging on an editor file selection text box causing repeated popover display	2021-10-06 13:52:08 +09:00
Dan Balasescu	80c8612630	Merge pull request #14977 from peppy/fix-working-beatmap-cache-invalidation ... Fix changes not being reflected immediately after exiting the editor	2021-10-06 13:51:21 +09:00
Dean Herbert	d9849bcf49	Fix dragging on an editor file selection text box causing repeated popover display ... Local fix and no tests as this is a pretty weird usage of `TextBox`. We'll probably want to change it to not use a textbox eventually. Closes #14969.	2021-10-06 13:15:05 +09:00
Dean Herbert	90fdaf18c0	Fix PushAndConfirm potentially failing if new screen quickly pushes a child screen	2021-10-06 12:55:04 +09:00
Dean Herbert	8ffaa491e7	Fix BeatmapModelManager not receiving WorkingBeatmapCache	2021-10-06 12:55:04 +09:00
Dean Herbert	007b33cd88	Add missing methods to interfaces	2021-10-06 12:55:04 +09:00
Dean Herbert	ffbb7a9b1a	Remove incorrect csproj change ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-10-06 12:22:32 +09:00
Dan Balasescu	e837a3511d	Merge branch 'master' into beatmap-difficulty-more-interface-usage	2021-10-06 12:18:51 +09:00
Jamie Taylor	266e62794e	Tweak cutoff effect for new Q value	2021-10-06 11:52:05 +09:00
Dan Balasescu	4bbff2ebf7	Merge branch 'master' into new-interfaces	2021-10-06 11:38:17 +09:00
Jamie Taylor	df182ba92b	Set fQ to recommended value from BASS developer to prevent filter calculations from overflowing when approaching nyquist	2021-10-06 11:29:03 +09:00
Dan Balasescu	9491e5a547	Merge pull request #14954 from peppy/rename-result-response ... Rename `APIRequest.Result` to `Response`	2021-10-06 10:52:33 +09:00
Dan Balasescu	007e5f174c	Merge pull request #14959 from peppy/add-screen-test-debug ... Add various logging output in an atttempt to figure multiplayer test failure	2021-10-06 10:11:50 +09:00
Dean Herbert	4f59fc15a5	Mark BeatmapSet as nullable for the time being	2021-10-06 05:54:37 +09:00
Dean Herbert	4d5696959b	Remove unnecessary access modifier in interface ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-10-06 05:52:28 +09:00
Dean Herbert	1f6a31355c	Remove unused using statement ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-06 05:30:49 +09:00
Dean Herbert	5a4474e1b2	Fix incorrect DI retrieval in ReplayDownloadButton	2021-10-06 05:29:00 +09:00
Dean Herbert	c23acb8f05	Merge pull request #14967 from bdach/fix-accidental-json-property-rename ... Fix "most played beatmap" request breakage after property rename	2021-10-06 05:00:12 +09:00
Bartłomiej Dach	baa8baaa1e	Fix "most played beatmap" request breakage after property rename	2021-10-05 21:17:19 +02:00
Bartłomiej Dach	a5b07ce4fe	Fix backwards containment check in chat channel load callback	2021-10-05 20:53:06 +02:00
Bartłomiej Dach	12da27cde7	Add test coverage for loading process on channel join	2021-10-05 20:52:40 +02:00
Dean Herbert	6f7b8293af	Merge pull request #14919 from smoogipoo/realtime-pp-display ... Implement real-time PP counter	2021-10-05 20:50:03 +09:00
Dean Herbert	98fef6ece2	Handle judgement reverts with actual display updates	2021-10-05 19:08:30 +09:00
Dean Herbert	5c62d3b6cb	Merge pull request #14907 from peppy/remove-local-realm-thread-switch-handling ... Remove local handling of realm when switching thread modes	2021-10-05 19:00:19 +09:00
Dean Herbert	e6efdae7c9	Add various logging output in an atttempt to figure multiplayer test failure	2021-10-05 18:53:20 +09:00
Dean Herbert	bd84a8b749	Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage	2021-10-05 18:21:21 +09:00
Dean Herbert	2be44188ef	Add missing null checks	2021-10-05 17:59:38 +09:00
Dean Herbert	0859c336de	Also dim counter during initial calculation phase	2021-10-05 17:24:36 +09:00
Dean Herbert	1e4da81120	Fix import notifications not showing correct text	2021-10-05 17:14:09 +09:00
Dean Herbert	f64226ded6	Fix display not displaying correctly after initial load	2021-10-05 17:10:32 +09:00
Dean Herbert	599d82e383	Avoid returning a live IEnumerable	2021-10-05 17:01:07 +09:00
Dean Herbert	fa7f11d906	Add easing to rolling counter value	2021-10-05 16:51:49 +09:00
Dean Herbert	565e888f58	Tidy up attribute retrieval code	2021-10-05 16:40:07 +09:00
smoogipoo	45b63cbad9	Remove unnecessary dependency	2021-10-05 16:03:25 +09:00
Dean Herbert	676df55a0e	Fade display out during rewind (as the value displayed is no longer valid)	2021-10-05 15:39:29 +09:00
Dean Herbert	81a13566bc	Adjust default location slightly, fix alignment of "pp" subtext	2021-10-05 15:28:03 +09:00
Dean Herbert	b6af93d434	Apply some code quality refactoring	2021-10-05 15:14:49 +09:00
Dean Herbert	7176dc95e5	Revert Player.Score to protected	2021-10-05 14:55:40 +09:00
Dean Herbert	e19be8ebe4	Make GameplayState.Score immutable	2021-10-05 14:55:40 +09:00
Dean Herbert	a5aa32811a	Remove null check suppression and add non-null fallback	2021-10-05 14:49:59 +09:00
Dean Herbert	d3b9660148	Move common interface implementations to extension methods	2021-10-05 14:41:14 +09:00
Dean Herbert	b41fa41c85	Rename APIRequest.Result to Response	2021-10-05 14:28:56 +09:00
smoogipoo	5624dd9af6	Fix incorrect CancellationToken usage ... Apparently I wrote the BDL system and don't know how this works. I believe you need `CancellationToken?` or CanBeNull=true, however that doesn't actually play well when actually using the token in code...	2021-10-05 12:07:41 +09:00
smoogipoo	593da79bbc	Further asyncify load process	2021-10-05 11:26:13 +09:00
smoogipoo	d120678e30	Fix redundant default value	2021-10-04 21:13:14 +09:00
smoogipoo	d1e7191f94	Pass score into GameplayState	2021-10-04 20:59:51 +09:00
smoogipoo	0b0316e27e	Fix missing CanBeNull	2021-10-04 20:59:31 +09:00
Dean Herbert	57c5be39d3	Merge branch 'master' into remove-local-realm-thread-switch-handling	2021-10-04 20:52:44 +09:00
Dean Herbert	1d99bc280f	Merge branch 'master' into new-interfaces	2021-10-04 20:42:40 +09:00
smoogipoo	1837e1bf3c	Share rounding with PerformanceStatistic	2021-10-04 20:35:53 +09:00
smoogipoo	fb63e5ed87	Add todo	2021-10-04 20:35:26 +09:00
smoogipoo	221cc1747c	Drop "default" prefix	2021-10-04 20:34:28 +09:00
smoogipoo	5aae673240	Use GameplayState	2021-10-04 20:33:54 +09:00
smoogipoo	2e3450b3f5	Make Mods readonly	2021-10-04 20:20:24 +09:00
smoogipoo	031c5a441e	Merge branch 'master' into realtime-pp-display	2021-10-04 20:19:37 +09:00
Dan Balasescu	4bd1083388	Merge pull request #14903 from peppy/importer-returns-live ... Add `ILive<T>` and use as return type of `Import` methods	2021-10-04 20:16:32 +09:00
smoogipoo	4871db2f86	Merge branch 'master' into importer-returns-live	2021-10-04 19:42:36 +09:00
Dean Herbert	853cf6feaa	Rename last remaining BeatmapInfo Beatmap usage	2021-10-04 17:35:53 +09:00
Dan Balasescu	5937a93e2d	Merge pull request #14949 from peppy/login-error-display ... Show login failure messages on login form	2021-10-04 17:23:11 +09:00
Dan Balasescu	c1540c137a	Merge pull request #14932 from peppy/rename-beatmap-info-beatmap-fields ... Rename `BeatmapInfo` variables which were named `beatmap` for clarity	2021-10-04 17:22:06 +09:00
Dean Herbert	6ac0601d2c	Fix incorrect csproj merge	2021-10-04 17:18:08 +09:00
Dean Herbert	ae5d1e8ac0	Merge branch 'master' into remove-local-realm-thread-switch-handling	2021-10-04 17:17:10 +09:00
Dean Herbert	95f1cc85d4	Update framework	2021-10-04 17:12:40 +09:00
Dean Herbert	f293e008d9	Move BeatmapInfo's SearchableTerms implementation to interface	2021-10-04 17:01:02 +09:00
Dean Herbert	51b7dce16f	Remove reference to osu-web-10	2021-10-04 16:55:51 +09:00
Dean Herbert	fd6b10656c	Add TODO reminder about ruleset reference transfer quirk	2021-10-04 16:55:16 +09:00
Dean Herbert	4df5f93152	Inline single usage of StoryboardFile to avoid interface default method woes	2021-10-04 16:55:02 +09:00
Dean Herbert	8bfdfe3672	Add literal string marker ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-04 16:54:00 +09:00
Dean Herbert	63f0b0c932	Rename out of place interface name	2021-10-04 16:35:55 +09:00
Dean Herbert	e631653f4b	Remove incorrectly committed FodyWeavers file	2021-10-04 16:30:12 +09:00
Dean Herbert	857000b756	Mark IPresentImports as covariant	2021-10-04 16:29:46 +09:00
Dean Herbert	3c15ef720f	Remove setter from IHasGuidPrimaryKey interface	2021-10-04 16:26:28 +09:00
Dean Herbert	916342c837	Merge branch 'master' into importer-returns-live	2021-10-04 16:24:26 +09:00
Dan Balasescu	aca2f0c12d	Merge pull request #14901 from peppy/model-importer-split ... Split importer interface out of `IModelManager`	2021-10-04 16:22:29 +09:00
Dean Herbert	3a0b7ba8ff	Add fallback to use Message when Hint is not available	2021-10-04 16:18:55 +09:00
smoogipoo	69c2b7dc59	Merge branch 'master' into rename-beatmap-info-beatmap-fields	2021-10-04 16:03:22 +09:00
Dan Balasescu	fd002da469	Merge pull request #14948 from peppy/fix-drawable-channel-ci-failures ... Ensure a `DrawableChannel` is not attempted to be added after disposal	2021-10-04 16:03:13 +09:00
smoogipoo	4e1322effa	Fix typo	2021-10-04 16:02:45 +09:00
Dan Balasescu	aa1bfc16d2	Merge pull request #14929 from peppy/gameplay-state ... Replace `GameplayBeatmap` with `GameplayState`	2021-10-04 15:56:44 +09:00
Dan Balasescu	d82829fad3	Merge pull request #14909 from peppy/realm-context-factory-safer-blocking ... Ensure realm blocks until all threaded usages are completed	2021-10-04 15:52:45 +09:00
Dean Herbert	266b4c7124	Expose login errors from IAPIProvider and show on the login form	2021-10-04 15:40:24 +09:00
Dean Herbert	5aaafce597	Make AuthenticateWithLogin throw instead of return a bool success status	2021-10-04 15:40:00 +09:00
smoogipoo	bc984dff4f	Fix typo	2021-10-04 15:35:28 +09:00
Dean Herbert	c19c2335ec	Remove added schedule due to changing flow	2021-10-04 14:58:54 +09:00
Dean Herbert	c6aba3e78b	Ensure a DrawableChannel is not attempted to be added after disposal	2021-10-04 14:44:16 +09:00
Dean Herbert	3d71576fbe	Merge pull request #14920 from smoogipoo/guard-skin-exception ... Guard against exception in skin deserialisation	2021-10-04 14:07:49 +09:00
Dean Herbert	c8419ebedb	Merge pull request #14946 from bdach/torus-alternate ... Add alternate Torus font	2021-10-04 11:47:11 +09:00
Dean Herbert	11e9c16b92	Update resources	2021-10-04 11:13:46 +09:00
Bartłomiej Dach	017756cbca	Use Torus alternates on online play screens as per design	2021-10-04 00:26:41 +02:00
Bartłomiej Dach	86240cc8ec	Add alternate Torus font	2021-10-03 23:36:39 +02:00
Bartłomiej Dach	83fa1be713	Merge branch 'master' into fix-keybinds-reset-search	2021-10-03 13:54:57 +02:00
Susko3	3e403cfe03	Add comment explaining the purpose of the empty FilterTerms	2021-10-02 19:16:46 +02:00
Bartłomiej Dach	f03cf87872	Merge branch 'master' into storyboard-fixes	2021-10-02 18:41:01 +02:00
Dean Herbert	ec61c3c5ee	Rename all remaining cases	2021-10-03 00:55:29 +09:00
Susko3	d55836c0b2	Make ResetButton no longer part of search filtering ... The button will now appear if and only if all the bindings in its section are visible (not filtered out by the search)	2021-10-02 15:10:30 +02:00
Dean Herbert	20e3f7fec4	Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage	2021-10-02 13:08:02 +09:00
Dean Herbert	973c31132b	Rename BeatmapInfo variables which were named beatmap for clarity	2021-10-02 12:45:34 +09:00
Dean Herbert	1be96b4292	Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.10'	2021-10-02 11:04:00 +09:00
Dean Herbert	fb6426d68d	Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.10'	2021-10-02 11:03:30 +09:00
dependabot[bot]	cb8165ca50	Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.9 to 5.0.10. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.9...v5.0.10) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-02 00:59:32 +00:00
dependabot[bot]	f60f712bcc	Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.9 to 5.0.10. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.9...v5.0.10) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-02 00:59:32 +00:00
dependabot[bot]	9517d69f21	Bump MessagePack from 2.3.75 to 2.3.85 ... Bumps [MessagePack](https://github.com/neuecc/MessagePack-CSharp) from 2.3.75 to 2.3.85. - [Release notes](https://github.com/neuecc/MessagePack-CSharp/releases) - [Changelog](https://github.com/neuecc/MessagePack-CSharp/blob/master/prepare_release.ps1) - [Commits](https://github.com/neuecc/MessagePack-CSharp/compare/v2.3.75...v2.3.85) --- updated-dependencies: - dependency-name: MessagePack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-02 00:59:31 +00:00
dependabot[bot]	5ea51f4a9f	Bump Sentry from 3.9.0 to 3.9.4 ... Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.9.0 to 3.9.4. - [Release notes](https://github.com/getsentry/sentry-dotnet/releases) - [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.9.0...3.9.4) --- updated-dependencies: - dependency-name: Sentry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-01 18:15:07 +00:00
Dean Herbert	bea310007f	Merge pull request #14922 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.10 ... Bump Microsoft.AspNetCore.SignalR.Client from 5.0.9 to 5.0.10	2021-10-02 03:12:14 +09:00
Dean Herbert	ea1e09837e	Merge pull request #14923 from ppy/dependabot/nuget/HtmlAgilityPack-1.11.37 ... Bump HtmlAgilityPack from 1.11.36 to 1.11.37	2021-10-02 03:11:52 +09:00
Dean Herbert	dcd7d7a709	Add JsonIgnore rule for StoryboardFile ... Not sure why this is required, doesn't make much sense.	2021-10-02 03:05:06 +09:00
Dean Herbert	7e009f6168	Add full xmldoc	2021-10-02 02:31:41 +09:00
Dean Herbert	32afd3f426	Replace all basic usages	2021-10-02 02:22:23 +09:00
Dean Herbert	05ca3aec4f	Rename GameplayState to SpectatorGameplayState	2021-10-02 02:10:11 +09:00
dependabot[bot]	6de4e981dd	Bump Realm from 10.5.0 to 10.6.0 ... Bumps [Realm](https://github.com/realm/realm-dotnet) from 10.5.0 to 10.6.0. - [Release notes](https://github.com/realm/realm-dotnet/releases) - [Changelog](https://github.com/realm/realm-dotnet/blob/master/CHANGELOG.md) - [Commits](https://github.com/realm/realm-dotnet/compare/10.5.0...10.6.0) --- updated-dependencies: - dependency-name: Realm dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-01 17:01:37 +00:00
dependabot[bot]	323a9a748d	Bump HtmlAgilityPack from 1.11.36 to 1.11.37 ... Bumps [HtmlAgilityPack](https://github.com/zzzprojects/html-agility-pack) from 1.11.36 to 1.11.37. - [Release notes](https://github.com/zzzprojects/html-agility-pack/releases) - [Commits](https://github.com/zzzprojects/html-agility-pack/compare/v1.11.36...v1.11.37) --- updated-dependencies: - dependency-name: HtmlAgilityPack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-01 17:01:32 +00:00
dependabot[bot]	1eb67dc594	Bump Microsoft.AspNetCore.SignalR.Client from 5.0.9 to 5.0.10 ... Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.9 to 5.0.10. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.9...v5.0.10) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Client dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-01 17:01:28 +00:00
Jamie Taylor	2a4a376b87	Refactor Filter to behave closer to a Transformable	2021-10-02 01:32:47 +09:00
Dean Herbert	d6dbdc911f	Merge branch 'master' into storyboard-fixes	2021-10-02 00:35:51 +09:00
Dean Herbert	682fe5be78	Merge branch 'master' into realm-context-factory-safer-blocking	2021-10-02 00:30:09 +09:00
Dean Herbert	b1f9bbdc69	Merge branch 'master' into model-importer-split	2021-10-02 00:29:29 +09:00
Dan Balasescu	a620b55d55	Merge pull request #14900 from peppy/model-downloader-split ... Split `ArchiveModelManager` into two pieces	2021-10-01 23:16:09 +09:00
Dan Balasescu	d24f89fead	Merge pull request #14906 from peppy/update-realm-context-factory ... Refine `RealmContext` implementation	2021-10-01 22:57:03 +09:00
Dan Balasescu	6a172d54d5	Merge branch 'master' into model-downloader-split	2021-10-01 22:34:39 +09:00
Dean Herbert	a32f5d44e2	Improve clarity of xmldoc ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-10-01 22:23:51 +09:00
smoogipoo	adff418fd2	Guard against exception in skin deserialisation	2021-10-01 22:17:38 +09:00
Dan Balasescu	154c412f34	Merge branch 'master' into beatmap-manager-split	2021-10-01 21:46:27 +09:00
smoogipoo	0ee148b53f	Extra guard against no attributes	2021-10-01 21:31:26 +09:00
smoogipoo	a1f880a36a	Split classes	2021-10-01 21:00:39 +09:00
smoogipoo	d0081908c5	Make Score internal	2021-10-01 20:52:48 +09:00
smoogipoo	98badd644f	Add xmldocs	2021-10-01 20:09:39 +09:00
smoogipoo	5820a71652	Fix mania difficulty calculator crashing	2021-10-01 19:57:45 +09:00
Dean Herbert	4c28749d73	Fix incorrect legacy decoder usage	2021-10-01 19:05:08 +09:00
Dean Herbert	3faafd7200	Rename parameter to repeatCount and add guards	2021-10-01 18:26:29 +09:00
Dean Herbert	59bd13c154	Merge branch 'master' into slider-timeline-velcotiy-adjust-v2	2021-10-01 17:47:00 +09:00
Dean Herbert	ac471a0ec1	Merge branch 'no-more-difficulty-control-points-info' into slider-timeline-velcotiy-adjust-v2	2021-10-01 17:46:58 +09:00
Dean Herbert	0daf8937e3	Add missing xmldoc	2021-10-01 17:36:44 +09:00
Dean Herbert	d6618a99a3	Redirect more methods to interface implementations	2021-10-01 17:36:44 +09:00
Dean Herbert	9dae92e78c	Add missing backlink to BeatmapSet from Beatmap and fix non-explicit implementations	2021-10-01 17:22:25 +09:00
Dean Herbert	00e33a1da7	Fix incorrect OnlineID mappings	2021-10-01 17:06:09 +09:00
Dean Herbert	05996cc2e9	Add changes that got forgotted in branch surgery	2021-10-01 17:04:53 +09:00
Dean Herbert	a92d499d7a	Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo	2021-10-01 16:55:50 +09:00
Dean Herbert	8595eb2d11	Switch BeatmapDifficulty usages to use interface type	2021-10-01 16:55:50 +09:00
Dean Herbert	d309636460	Update all EF based models to implement new read only interfaces	2021-10-01 16:55:50 +09:00
Dean Herbert	619dfe0690	Add new interface base types for models	2021-10-01 16:55:47 +09:00
smoogipoo	36be041846	Merge branch 'master' into realtime-pp-display	2021-10-01 13:28:38 +09:00
Dean Herbert	74841cf1a9	Merge branch 'update-realm-context-factory' into realm-context-factory-safer-blocking	2021-10-01 03:54:31 +09:00
Dean Herbert	b51fd00ba3	Guard against disposal in all context retrievals	2021-10-01 03:46:53 +09:00
Dean Herbert	8557530cd5	Add back main context locking	2021-10-01 03:45:00 +09:00
Dean Herbert	c71cf1e220	Fix incomplete xmldoc	2021-10-01 01:51:31 +09:00
Dean Herbert	3ddb348252	Merge branch 'online-lookup-cache-separation' into beatmap-manager-split	2021-10-01 01:49:31 +09:00
Dean Herbert	2ed28f625a	Pass whole queue in rather than function	2021-10-01 01:46:37 +09:00
Dean Herbert	428c7830d9	Pass online lookup queue in as a whole, rather than function	2021-10-01 01:45:21 +09:00
Dean Herbert	27c4f2b06e	Add missing disposal	2021-10-01 01:38:50 +09:00
Dean Herbert	dde19f2e81	Fix unbalanced brackets ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-01 01:37:51 +09:00
Dean Herbert	cfd3bdf888	Ensure realm blocks until all threaded usages are completed	2021-10-01 01:34:35 +09:00
Dean Herbert	38cd383aaf	Remove local handling of realm when switching thread modes	2021-10-01 00:27:54 +09:00
Dean Herbert	9fa901f6aa	Refine RealmContext implementation API	2021-09-30 23:56:38 +09:00
Dean Herbert	a2e61883e3	Initial push to use ILive in import process	2021-09-30 22:55:25 +09:00
Dean Herbert	66409147dc	Remove duplicate interface specification	2021-09-30 19:25:08 +09:00
Dean Herbert	c05a8fc4a2	Split importer interface out of IModelManager	2021-09-30 18:52:09 +09:00
Dean Herbert	3e3b9bc963	Split out IModelDownloader and also split apart ScoreManager	2021-09-30 18:25:20 +09:00
Dean Herbert	0a00bc7795	Split out IPostNotifications into an interface	2021-09-30 18:21:34 +09:00
Dean Herbert	fd13142a15	Add missing interface to BeatmapManager	2021-09-30 18:21:24 +09:00
smoogipoo	fab0d531be	Add counter to HUD	2021-09-30 17:55:00 +09:00
smoogipoo	4d8418e072	Fix possible nullrefs	2021-09-30 17:54:56 +09:00
smoogipoo	d2a8f35b4c	Update styling	2021-09-30 17:54:52 +09:00
Dean Herbert	7a72747d88	Add back optional online lookups	2021-09-30 17:18:39 +09:00
Dean Herbert	90225f2082	Hook up all required interfaces to new BeatmapManager	2021-09-30 17:18:39 +09:00
smoogipoo	84bddf0885	Initial PP counter implementation	2021-09-30 17:00:24 +09:00
Dean Herbert	5618c9933b	Expose more pieces of ArchiveModelManager via interfaces	2021-09-30 16:44:39 +09:00
Dean Herbert	d21139b03e	Split out database portion from BeatmapManager	2021-09-30 15:43:49 +09:00
Dean Herbert	e7e0473323	Split out WorkingBeatmapCache from BeatmapManager	2021-09-30 15:40:41 +09:00
Jamie Taylor	968826c9e7	Fix typo	2021-09-30 15:17:39 +09:00
Dean Herbert	8a6501fa58	Add basic component level xmldoc	2021-09-30 14:46:07 +09:00
Dean Herbert	6ffd9fdcfa	Split out BeatmapOnlineLookupQueue from BeatmapManager	2021-09-30 14:46:01 +09:00
Dean Herbert	b8b61a196f	Merge pull request #14891 from smoogipoo/mp-currently-playing-map ... Add currently playing map to multiplayer lounge	2021-09-30 14:22:07 +09:00
smoogipoo	816018edb7	Move hosted by text into nullcheck	2021-09-30 12:04:30 +09:00
smoogipoo	202a602d2f	Change default status to "ready to play"	2021-09-30 12:03:44 +09:00
smoogipoo	ea30445efc	Remove verbatim string	2021-09-30 12:03:34 +09:00
smoogipoo	619a907c47	Fix zero height grid	2021-09-30 12:01:26 +09:00
smoogipoo	56b3c8aa9a	Remove forgotten text	2021-09-30 11:52:14 +09:00
Jamie Taylor	f55c4ac640	IsLoaded check no longer required	2021-09-29 21:05:46 +09:00
smoogipoo	c83dd7d2b6	Merge OnlinePlayComposite and RoomSubScreenComposite	2021-09-29 20:55:20 +09:00
Jamie Taylor	4d91204faf	Pause Editor sample playback while popup dialog is shown	2021-09-29 20:46:41 +09:00
smoogipoo	c9c2d20544	Limit max size	2021-09-29 20:44:38 +09:00
Jamie Taylor	2608d193a9	Refactor Filter component to be more re-usable	2021-09-29 20:30:01 +09:00
Jamie Taylor	94e2dbd7e7	Add a low-pass filter effect to music when certain popup dialogs are shown	2021-09-29 20:30:00 +09:00
smoogipoo	67d847fbd3	Add room status text to DrawableRoom	2021-09-29 20:24:49 +09:00
smoogipoo	5f921c7836	Change SelectedItem to show the last item by default	2021-09-29 20:24:32 +09:00
smoogipoo	d89577b2e7	Add host to DrawableRoomParticipantsList	2021-09-29 19:34:40 +09:00
smoogipoo	73ee82ee2b	Rename RecentParticipantsList -> DrawableRoomParticipantsList	2021-09-29 19:15:58 +09:00
Dean Herbert	7914daaef0	Remove unused using	2021-09-29 19:09:48 +09:00
Dean Herbert	4fd19cbb0d	Use null check instead of assert in Hide() due to public exposure	2021-09-29 18:58:43 +09:00
Dean Herbert	c5b7e97bd9	Fix skin editor potentially crashing during close process ... As reported at https://github.com/ppy/osu/discussions/14850#discussioncomment-1399382.	2021-09-29 18:53:49 +09:00
Dan Balasescu	754c56d7ae	Merge branch 'master' into move-startup-concurrency-check	2021-09-29 17:20:20 +09:00
Dan Balasescu	ce3cf72a77	Merge pull request #14888 from peppy/rename-json-key-resolver ... Rename JSON key resolver to better expose what it's doing	2021-09-29 16:58:42 +09:00
Dean Herbert	dcf87e97c2	Update framework	2021-09-29 14:03:41 +09:00
Dean Herbert	117d47bf7f	Rename JSON key resolver to better expose what it's doing	2021-09-29 11:26:37 +09:00
Sebastian Krajewski	f148fbcc94	Cap LoopCount to at least 1	2021-09-29 00:59:08 +02:00
Dan Balasescu	625711e6d2	Merge pull request #14776 from peppy/fix-pause-with-audio-offset ... Avoid accounting for the pause pitch adjust effect when "fixing" hardware offset adjustments	2021-09-28 18:44:22 +09:00
Dean Herbert	46bafb6252	Merge branch 'master' into no-more-difficulty-control-points-info	2021-09-28 13:53:56 +09:00
Bartłomiej Dach	ca6cbca04a	Fix range selection crashing after non-mouse selection	2021-09-27 20:54:29 +02:00
Dean Herbert	bcdbffbca0	Update framework	2021-09-27 20:56:54 +09:00
Dean Herbert	d4310f5d9a	Move database connection string operations local ... In line with framework changes in https://github.com/ppy/osu-framework/pull/4793.	2021-09-27 17:32:41 +09:00
Dean Herbert	df85092426	Resolve inner items early in process and rename variable	2021-09-27 14:24:17 +09:00
Dean Herbert	41fb3371e5	Merge branch 'master' into blueprint-container-sorting	2021-09-27 14:12:09 +09:00
Dean Herbert	5466fb08fd	Merge branch 'master' into timeline-shift-click-selection	2021-09-27 13:40:39 +09:00
Bartłomiej Dach	d3203f83dd	Add implementation of range selection	2021-09-26 20:12:26 +02:00
Bartłomiej Dach	81d160c85a	Add test covering expected UX of range selection	2021-09-26 19:27:47 +02:00
Bartłomiej Dach	6dc3e66c93	Include combo information when determining ordering if available	2021-09-26 15:52:25 +02:00
Bartłomiej Dach	a86b9893ac	Always re-sort blueprints before adding/removing one	2021-09-26 15:48:56 +02:00
Bartłomiej Dach	a66d48dbad	Merge branch 'master' into diffcalc-optimisations	2021-09-26 14:46:50 +02:00
Joseph Madamba	9b9c30c8a1	Fix text overflowing on dropdown headers	2021-09-24 22:04:45 -07:00
Dean Herbert	ad6c4e3878	Update framework	2021-09-24 12:46:46 +09:00
Dean Herbert	6b698047ab	Fix DialogOverlay potentially not expiring dialogs as soon as it should	2021-09-23 19:19:03 +09:00
Dean Herbert	60c9e9f704	Merge pull request #14805 from bdach/rectangular-snap-grid ... Add rectangular snap grid to osu! editor composer	2021-09-22 00:12:03 +09:00
Dean Herbert	3b174a71a3	Move startup concurrency check to higher level ... Makes more sense to perform this check outside of the game itself now that we can.	2021-09-21 18:00:55 +09:00
Dan Balasescu	ffdaf23329	Merge pull request #14814 from peppy/fix-key-counter-masking ... Fix `KeyCounterDisplay` potentially getting stuck invisible due to autosize masking	2021-09-21 16:21:38 +09:00
smoogipoo	6246bbc262	Also add to ParticleExplosion	2021-09-21 14:37:09 +09:00
smoogipoo	bad3f0b1e9	Disable FtB pass for particle spewer	2021-09-21 14:25:44 +09:00
Dean Herbert	8584c0b6da	Merge branch 'master' into diffcalc-optimisations	2021-09-21 14:22:42 +09:00
Dean Herbert	add8aac6d5	Merge pull request #14815 from ppy/dependabot/nuget/osu.Game/SharpCompress-0.29.0 ... Bump SharpCompress from 0.28.3 to 0.29.0 in /osu.Game	2021-09-21 14:05:21 +09:00
Bartłomiej Dach	761548e533	Merge branch 'master' into 14470-ur-not-updating	2021-09-20 22:07:33 +02:00
dependabot[bot]	b715b89edc	Bump SharpCompress from 0.28.3 to 0.29.0 in /osu.Game ... Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.28.3 to 0.29.0. - [Release notes](https://github.com/adamhathcock/sharpcompress/releases) - [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.28.3...0.29) --- updated-dependencies: - dependency-name: SharpCompress dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-20 19:54:05 +00:00
sh0ckR6	fb416c79e9	Fully revert Player	2021-09-20 15:01:03 -04:00
Dean Herbert	a3464c98a7	Fix KeyCounterDisplay potentially getting stuck invisible due to autosize masking ... Closes #14793.	2021-09-20 23:52:01 +09:00
sh0ckR6	9a1db04920	Resolve GameplayClockContainer instead of Player	2021-09-20 10:28:58 -04:00
sh0ckR6	36a20ab0b3	Resolve failed test compilation	2021-09-20 10:26:07 -04:00
sh0ckR6	10fe2382b0	Address most issues	2021-09-20 10:07:42 -04:00
Dean Herbert	7812c33ddd	Merge branch 'master' into add-legacy-star-particles	2021-09-20 18:15:12 +09:00
Dean Herbert	cdef6d0cf5	Add key binding support for grid mode cycle	2021-09-20 16:43:15 +09:00
Dean Herbert	d96d1b3e47	Update framework	2021-09-20 15:09:27 +09:00
Dean Herbert	16e60eed56	Reduce NestedHitObject enumerator overhead ... This was especially bad due to it allocating on any and every start time change, even the first (see usage in `HitObject.ctor`).	2021-09-20 15:09:27 +09:00
Bartłomiej Dach	ab213e2010	Add missing licence headers	2021-09-19 21:09:03 +02:00
Bartłomiej Dach	4e094b2127	Implement grid size toggling matching stable	2021-09-19 20:26:02 +02:00
Bartłomiej Dach	56e80a0706	Add rectangular position snap grid	2021-09-19 18:07:19 +02:00
Opelkuh	9c90dd539f	Use Interpolation.Lerp	2021-09-19 15:06:15 +02:00
Opelkuh	0b593fac5c	Scope down DrawNode's source parameter	2021-09-19 14:49:09 +02:00
Opelkuh	d5a10e9221	Fix particles not spawning if Time.Current is negative	2021-09-19 14:47:20 +02:00
Opelkuh	761da45f6a	Revert af4c3727d77a16e2534df9bbf452336b5c544342	2021-09-19 14:00:56 +02:00
Opelkuh	1d7d779f66	Merge branch 'master' into add-legacy-star-particles	2021-09-19 04:34:35 +02:00
Opelkuh	3f8454cb76	Remove abstract from ParticleSpewer	2021-09-19 03:19:16 +02:00
Opelkuh	ef530ed87c	Normalize particle velocity based on max duration	2021-09-18 23:45:58 +02:00
Opelkuh	846cde53b3	Add RelativePositionAxes support	2021-09-18 22:54:12 +02:00
sh0ckR6	04715a5471	Add null-check when invoking OnSeek	2021-09-18 12:20:36 -04:00
sh0ckR6	f6e279baa1	Add xmldoc to HitErrorMeter.Clear ... Explains how the method is called and what inheritors should do when implementing it.	2021-09-18 12:18:11 -04:00
sh0ckR6	12cc16c598	Remove unused property in SongProgress	2021-09-18 12:05:06 -04:00
Bartłomiej Dach	80197bae48	Revert not decoding legacy difficulty points on scrolling rulesets for now	2021-09-18 15:32:08 +02:00
Bartłomiej Dach	76ccdd1340	Collect and sort points from nested objects before extracting	2021-09-18 14:38:38 +02:00
Bartłomiej Dach	8026968939	Move difficulty -> effect point conversion back to decoder	2021-09-18 14:38:38 +02:00
Dean Herbert	801bee7c47	Merge pull request #14785 from nekodex/wrong-password ... Add audio feedback for incorrect multiplayer room password	2021-09-18 12:02:33 +09:00
sh0ckR6	b2b3108afa	Resolve addressed issues ... + Stopped using testing methods in non-testing classes + Resolve Player and add OnSeek event + Take bindings away from BarHitErrorMeter + Add support for ColourHitErrorMeter	2021-09-17 16:19:41 -04:00
Dean Herbert	cc11532d9b	Update resources	2021-09-18 03:08:42 +09:00
Jamie Taylor	f868feae44	Remove unnecessary Schedule	2021-09-17 21:12:39 +09:00
Jamie Taylor	9485323a13	Add audio feedback for incorrect MP room password	2021-09-17 20:52:13 +09:00
Dean Herbert	7ea55b2cee	Merge branch 'master' into fix-taiko-fl	2021-09-17 19:15:20 +09:00
Dean Herbert	a743a3f306	Change combo bind logic to be non-weird	2021-09-17 19:15:14 +09:00
Dan Balasescu	90f1592d15	Merge pull request #14783 from peppy/login-feedback ... Move login panel related files to own namespace and tidy up class nesting	2021-09-17 19:02:23 +09:00
Dan Balasescu	a591fffdbd	Merge pull request #14782 from peppy/refocus-textbox-on-failed-password ... Refocus the multiplayer password entry textbox on failed join	2021-09-17 18:59:09 +09:00
smoogipoo	2d39131202	Refactor taiko flashlight a bit	2021-09-17 18:41:03 +09:00
Dean Herbert	50f155e4b9	Move login panel related files to own namespace and tidy up class nesting	2021-09-17 18:34:16 +09:00
Dean Herbert	027912d4f6	Refocus the multiplayer password entry textbox on failed join	2021-09-17 18:25:25 +09:00
Dean Herbert	1c8e17cf11	Fix the default background parallax being set incorrectly when no screen is present	2021-09-17 18:14:39 +09:00
Dean Herbert	5f27f1c099	Avoid accounting for the pause pitch adjust effect when "fixing" hardware offset adjustments ... Bit of an unfortunate one. Because we are applying the pitch adjustment to the lowest level (`Track`), it's hard to filter out in parent clock calculations. Tried a few solutions but this feels the best. Note that we can't just undo the `pauseFreqAdjust` adjustment as it will div-by-zero. Closes https://github.com/ppy/osu/issues/14773.	2021-09-17 15:43:38 +09:00
Dan Balasescu	24105debce	Merge branch 'master' into fix-skin-editor-masking	2021-09-17 13:54:24 +09:00
Dean Herbert	1b13b74740	Fix skin editor potentially leaving game-wide masking in the wrong state ... Just going with the simplest way to solve this. Closes https://github.com/ppy/osu/issues/14769.	2021-09-17 13:48:20 +09:00
Dean Herbert	f524e913e1	Move AllowTrackAdjustments specification to RoomSubScreen	2021-09-17 13:24:01 +09:00
Dean Herbert	cd4ba71a6b	Revert "Merge pull request #14772 from Joehuu/lounge-disallow-track-adj" ... This reverts commit 06ff4838fb, reversing changes made to 5453ea0ce9.	2021-09-17 13:22:39 +09:00
Joseph Madamba	55feb47e61	Disallow track adjustments on playlists / multi lounge	2021-09-16 20:17:21 -07:00
Joseph Madamba	2983d54682	Fix wiki main page blurb overflowing at higher ui scale	2021-09-16 17:32:23 -07:00
Dean Herbert	6b43e955be	Merge branch 'limit-max-triangles' into update-framework	2021-09-16 22:49:50 +09:00
Dean Herbert	fde7c88999	Merge branch 'master' into update-framework	2021-09-16 22:49:02 +09:00
Dean Herbert	edb1230111	Fix potential nullref throw on failed startup	2021-09-16 22:48:09 +09:00
Dean Herbert	b399f910e4	Merge branch 'fix-osu-game-test-scene' into update-framework	2021-09-16 22:46:52 +09:00
Dean Herbert	a1d33c1a46	Update framework	2021-09-16 22:38:19 +09:00
Dean Herbert	df786afb24	Merge pull request #14763 from kj415j45/localisation-settings-GlobalAction ... Add localisation for Settings-KeyBindings-GlobalActions	2021-09-16 21:08:00 +09:00
kj415j45	a18fed0da4	Remove unused using	2021-09-16 17:38:33 +08:00
smoogipoo	4b5857c876	Merge branch 'baseline-changes-update' into update-framework	2021-09-16 18:34:22 +09:00
smoogipoo	e8dea0138c	Fix one more issue	2021-09-16 18:34:13 +09:00
smoogipoo	f9d5abff8a	Update with keybinding changes	2021-09-16 18:26:12 +09:00
kj415j45	e323f10cd5	Remove unused [Description]	2021-09-16 17:10:29 +08:00
kj415j45	51997fa533	Add localisation for GlobalActions	2021-09-16 16:02:04 +08:00
Dean Herbert	9127a706ac	Use private for internally used property	2021-09-16 16:54:56 +09:00
Dean Herbert	2df4073946	SpawnParticle -> CreateParticle (and set time outside of virtual call) ... Allows easier overriding (no need to call the `base.CreateParticle` call and worry about overwriting the time value.	2021-09-16 16:52:46 +09:00
Dean Herbert	da0667365b	Merge branch 'master' into inheritable-allow-track-adjust	2021-09-16 16:35:11 +09:00
Dean Herbert	6f2d818b64	Merge pull request #14740 from smoogipoo/mania-note-animations ... Add animation support for mania notes	2021-09-16 16:34:53 +09:00
Dean Herbert	3495fae519	Handle potential for OnResuming call without an OnSuspending first	2021-09-16 16:31:41 +09:00
Dean Herbert	b58415fe19	Make suspend stored state nullable to ensure we don't break it	2021-09-16 16:12:14 +09:00
Dean Herbert	fa693bb8a8	Move MusicController adjustment set to inside OsuScreen itself (and result nullable)	2021-09-16 16:08:09 +09:00
Dan Balasescu	43379a2eaa	Merge pull request #14752 from peppy/realm-settings ... Move (ruleset) settings to realm	2021-09-16 14:05:41 +09:00
Dean Herbert	4d4a9b86c1	Merge branch 'master' into mania-note-animations	2021-09-16 11:12:07 +09:00
AbstractQbit	318f0941ca	Move all the "inherit previous AllowTrackAdjustments" logic into OsuScreen	2021-09-15 21:25:39 +03:00
Dean Herbert	931e873a7e	Merge branch 'master' into inheritable-allow-track-adjust	2021-09-15 22:26:13 +09:00
AbstractQbit	f0439ef50b	Remove unnecessary AllowTrackAdjustments overrides, add true to SongSelect	2021-09-15 13:12:57 +03:00
Dean Herbert	8acfefed1b	Merge pull request #14741 from smoogipoo/fix-lounge-beatmaps-counter ... Fix incorrect beatmap count and SR range in multi lounge	2021-09-15 18:51:52 +09:00
Dean Herbert	07fec268c0	Limit maximum triangles to avoid GL buffer overflow	2021-09-15 18:32:59 +09:00
AbstractQbit	1181317c72	Fix issues found by code quality ci	2021-09-15 12:01:56 +03:00
Dean Herbert	4f1db5af40	Attach migration memo to DatabasedSetting class for visibility	2021-09-15 17:25:07 +09:00
Dean Herbert	a1d325cb22	Mark key and value non-nullable (at realm end) and simplify Value logic	2021-09-15 17:16:05 +09:00
Dean Herbert	a150fb2996	Add nullability directive and make variant non-nullable	2021-09-15 17:16:05 +09:00
Dean Herbert	15e3f95c87	Remove remnants of DatabasedSetting from SkinInfo ... This was never used	2021-09-15 17:12:04 +09:00
Dean Herbert	dcfe9c67e3	Make ruleset id non-nullable	2021-09-15 17:12:04 +09:00
Dean Herbert	80ecf81be3	Rename all databased setting classes to be specific to rulesets for now	2021-09-15 17:12:04 +09:00
Dean Herbert	520e550764	Bring back SettingsStore to avoid changing ruleset API for now ... Also fixes some remaining test failures due to locally constructed rulesets that are not being tracked by the game.	2021-09-15 17:12:02 +09:00
Dean Herbert	c36a67d06e	Fix some tests failing due to using a locally constructed ruleset	2021-09-15 17:04:38 +09:00
Dean Herbert	5bb741b4e8	Remove migration of key bindings	2021-09-15 17:04:38 +09:00
smoogipoo	f54d554d30	Extract removal to method	2021-09-15 17:03:28 +09:00
AbstractQbit	48cf98ef93	Rephrase null meaning in IOsuScreen.AllowTrackAdjustments ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-09-15 11:00:49 +03:00
AbstractQbit	b87af3dd68	Move the inherited AllowTrackAdjustments into OsuScreen	2021-09-15 10:55:16 +03:00
Dean Herbert	2bcb3fd304	Add migration of existing settings	2021-09-15 16:31:13 +09:00
Dean Herbert	ac377a2e3c	Remove unused SettingsStore	2021-09-15 16:31:13 +09:00
Dean Herbert	a2f1752344	Make settings works with current caching structure ... Will likely pull out that `RulesetConfigCache` next, but this is an "everything works" state.	2021-09-15 16:31:13 +09:00
Dean Herbert	14314476f0	Update realm to latest version	2021-09-15 16:22:14 +09:00
Dean Herbert	187c557ea8	Begin migrating settings implementation across to realm	2021-09-15 16:22:14 +09:00
Salman Ahmed	8217b90b1c	Consider legacy glyph texture heights as the baselines for simplicity ... Mixing `LegacySpriteText` with legitment fonts should never be the case, so it's fine to consuder the height as the baseline, since there's really no other way around it.	2021-09-15 09:14:47 +03:00
Dean Herbert	623377772c	Merge branch 'master' into fix-spectator-random-mod	2021-09-15 13:55:28 +09:00
Dean Herbert	1ba716d9f1	Merge pull request #14737 from bdach/editor-difficulty-switch-shared-state ... Preserve current time and clipboard contents when switching between difficulties	2021-09-15 12:38:56 +09:00
Dan Balasescu	5ea1924c30	Merge branch 'master' into display-sr-changes	2021-09-15 10:22:11 +09:00
Bartłomiej Dach	7b9e501fa0	Merge branch 'master' into 14421-multi-password-error-handling	2021-09-14 22:58:20 +02:00
Bartłomiej Dach	baf9961934	Amend xmldoc of shake extension method	2021-09-14 22:50:45 +02:00
AbstractQbit	bd18c581c1	Replace allowTrackAdjustmentsStack with a Dictionary	2021-09-14 21:14:24 +03:00
AbstractQbit	01d2f4f17a	Make allowTrackAdjustmentsStack readonly	2021-09-14 18:04:43 +03:00
Dean Herbert	13f88cbc4e	Fix EditorClock retaining a reference to potentially outdated ControlPointInfo	2021-09-14 23:56:57 +09:00
AbstractQbit	b9193aae6d	Make IOsuScreen.AllowTrackAdjustments nullable ... Allows for inheriting value from the previous screen if undefined	2021-09-14 17:37:57 +03:00
Dean Herbert	57f8ccca16	Remove nullability from EditorState properties ... Also update the xmldoc to not be specific to difficulty switching	2021-09-14 23:36:28 +09:00
Dean Herbert	f8bdca542d	Make restoring state a public call on Editor	2021-09-14 23:36:17 +09:00
Dean Herbert	2a894e7a3f	Make EditorLoader state private	2021-09-14 23:26:02 +09:00
Dean Herbert	563bf92529	Also update the full object on sample changes to make them apply immediately	2021-09-14 19:21:23 +09:00
Dean Herbert	d825da3983	Add note about a better way to adjust velocity	2021-09-14 18:54:29 +09:00
Dean Herbert	e4dd59aee2	Add popovers to adjust SV and samples from the timeline	2021-09-14 18:51:22 +09:00
Dean Herbert	9d17f84681	Adjust timeline height to account for less global control points	2021-09-14 18:51:11 +09:00
Dean Herbert	9551e77553	Remove difficulty and sample sections from timing screen	2021-09-14 18:51:11 +09:00
Dean Herbert	87cfcf706e	Add ability to change slider velocity with shift-drag	2021-09-14 18:26:17 +09:00
Dean Herbert	b19dc5e41f	Remove all legacy ControlPoints when entering the editor	2021-09-14 18:26:16 +09:00
Dean Herbert	6015b5037a	Display difficulty and sample control points associated with hitobjects	2021-09-14 18:26:16 +09:00
smoogipoo	a775915338	Fix incorrect beatmap count and SR range in multi lounge	2021-09-14 18:20:28 +09:00
smoogipoo	63aa3ddcba	Add animation support for mania notes	2021-09-14 17:45:23 +09:00
smoogipoo	b807c161b4	Remove now-unused DI params	2021-09-14 17:25:57 +09:00
smoogipoo	6cffbee592	Fix random/target mods not working in spectator	2021-09-14 17:22:58 +09:00
Dean Herbert	a7ae3cc03e	Change SampleControlPoint time to use leniency in bindable changed event too	2021-09-14 16:24:55 +09:00
Dean Herbert	5058f28504	Remove breaking padding	2021-09-14 14:52:50 +09:00
Dean Herbert	8865e3cab8	Add back shake and tweak transform of text	2021-09-14 14:44:32 +09:00
Dean Herbert	e17b800470	Move shake logic into extension method	2021-09-14 14:44:23 +09:00
Dean Herbert	7bd749d0eb	Remove weird shaking	2021-09-14 14:19:55 +09:00
Dean Herbert	e3c56f9ebd	Show error message in popover	2021-09-14 14:14:06 +09:00
Dean Herbert	eaac2bad3d	Fix incorrect child margin specifications	2021-09-14 13:49:02 +09:00
smoogipoo	3df4cbca2c	Reduce precision of difficulty calculator tests	2021-09-14 13:45:10 +09:00
Opelkuh	9fd616c578	Tiny refactor	2021-09-14 00:16:42 +02:00
Opelkuh	224244801f	Remove Particles namespace	2021-09-13 21:44:27 +02:00
Opelkuh	cfcb46034c	Remove ParticleJet	2021-09-13 21:44:23 +02:00
Opelkuh	99eff4f41f	Move cursor particles under OsuCursorContainer	2021-09-13 21:44:22 +02:00
Opelkuh	c2f7b01ca4	Change particle AngularVelocity into StartAngle and EndAngle	2021-09-13 21:44:21 +02:00
Opelkuh	6d68da8ff0	Remove StartScale from ParticleSpewer particles	2021-09-13 21:44:20 +02:00
Opelkuh	db662f8c5c	Add ParticleParent option to ParticleSpewer	2021-09-13 21:44:20 +02:00
Opelkuh	328c9a5dd0	Change ParticleSpewer.Active to a Bindable	2021-09-13 21:44:18 +02:00
Opelkuh	4c753420d3	Fix ParticleSpewer gravity calculation	2021-09-13 21:44:17 +02:00
Opelkuh	714cf33aac	Change ParticleSpewer to use screen space	2021-09-13 21:44:17 +02:00
Opelkuh	1a60ce164e	Add ParticleJet	2021-09-13 21:44:16 +02:00
Bartłomiej Dach	35ee889e5b	Restore clipboard content after difficulty switch	2021-09-13 21:04:27 +02:00
Bartłomiej Dach	79d0f4835e	Add failing tests for preserving clipboard content	2021-09-13 21:03:30 +02:00
Bartłomiej Dach	3fc72271f1	Restore editor clock time after difficulty switch	2021-09-13 20:59:31 +02:00
AbstractQbit	3c75094f43	Move BarHitErrorMeter's icon reorintation to Update()	2021-09-13 19:41:55 +03:00
AbstractQbit	7267602b95	Fix icon orientation for horizontal bar hit error meter	2021-09-13 17:14:39 +03:00
Dean Herbert	1e09f558d1	Merge pull request #14687 from Emil8250/master ... Make "Reset bindings" button wider to accommodate to localisations better	2021-09-13 22:46:06 +09:00
AbstractQbit	9c1fc2ec65	Tweak filled nub border width value	2021-09-13 14:19:33 +03:00
Dean Herbert	4d2373ffb9	Combine similar value changed calls	2021-09-13 20:08:46 +09:00
Dean Herbert	d999c29d3a	Remove unused GameHost DI in OsuGameTestScene	2021-09-13 19:38:43 +09:00
AbstractQbit	0f5ed81a7a	Fix dimmed checked nub artifact ... This adds transition that extends nub's border to fill it. Fill fade can be removed, but combined effect looks nicer imo, and the fill is still needed because if removed, border becomes invisible for some reason.	2021-09-13 13:31:13 +03:00
Dean Herbert	aa71e3f3d4	Update nested game tests in line with framework changes	2021-09-13 19:04:13 +09:00
Dan Balasescu	f6c4bbe2c9	Merge pull request #14730 from peppy/add-missing-track-adjustment-defaults ... Add missing screen level mod application settings for some screens	2021-09-13 15:22:22 +09:00
Dean Herbert	0c646f6dbd	Merge pull request #14694 from nekodex/no-avatar-click-sound ... Don't play hover/select sounds for UpdatableAvatar unless it's clickable	2021-09-13 15:14:43 +09:00
Dean Herbert	f9c82a9098	Merge pull request #14676 from nekodex/lobby-team-swap ... Add sound for multiplayer team swaps	2021-09-13 15:01:58 +09:00
Dean Herbert	caf7ef6519	Add missing screen level mod application settings for some screens ... Closes #7480. But based on discussion in there this solution may change.	2021-09-13 15:00:34 +09:00
Dean Herbert	52c69d2f22	Adjust value to not be full width (but allow for more accommodations with localised versions)	2021-09-13 14:17:45 +09:00
Dean Herbert	684c39dad0	Update resources	2021-09-13 14:12:37 +09:00
Dean Herbert	7fe0eefb78	Add inline comment regarding team switch sample logic ... Feels a bit convoluted without this. Don't really have a better suggestion for now so a comment will do.	2021-09-13 14:12:19 +09:00
Dean Herbert	65fdceee79	Merge branch 'master' into editor-test-scenes-through-loader	2021-09-13 14:02:55 +09:00
Dan Balasescu	d9b4fae4e5	Merge branch 'master' into chat-command	2021-09-13 13:32:44 +09:00
Bartłomiej Dach	5969e2b852	Add TODO comment about lack of in-gameplay support	2021-09-13 00:13:07 +02:00
sh0ckR6	447001931c	Resolve LoungeSubScreen from PasswordEntryPopover ... This is preferred over passing down the already-resolved LoungeSubScreen	2021-09-12 14:36:11 -04:00
Bartłomiej Dach	1be8cb452f	Make new beatmaps' samples match playback rate by default	2021-09-12 16:57:21 +02:00
Bartłomiej Dach	345cde251d	Add "samples match playback rate" to editor setup screen	2021-09-12 16:54:17 +02:00
Bartłomiej Dach	af7c2b93e6	Add encoding support for SamplesMatchPlaybackRate	2021-09-12 16:47:38 +02:00
Bartłomiej Dach	cd181452be	Add decoding support for SamplesMatchPlaybackRate	2021-09-12 16:45:27 +02:00
Bartłomiej Dach	925b455330	Add "samples match playback rate" setting to beatmap info	2021-09-12 16:40:52 +02:00
Bartłomiej Dach	22fa9a303e	Expose test helper for switching between difficulties	2021-09-12 13:55:48 +02:00
Bartłomiej Dach	f8a681d810	Delegate Editor{Beatmap,Clock} to Editor directly	2021-09-12 13:40:06 +02:00
Bartłomiej Dach	8357efc74f	Make EditorTestScene go through EditorLoader	2021-09-12 13:26:04 +02:00
Bartłomiej Dach	c4627bed6d	Print username in case of generic network failure too	2021-09-12 12:56:36 +02:00
rednir	e511c2ef2b	add comment	2021-09-12 08:50:53 +01:00
sh0ckR6	e018071be4	Remove OnShakeFinish event	2021-09-11 19:50:41 -04:00
sh0ckR6	6cdc842452	Remove placeholder text response ... Weird UX, doesn't feel right compared to the rest of lazer	2021-09-11 17:42:49 -04:00
sh0ckR6	b8a6925175	Use already-resolved LoungeSubScreen instead of nested delegates	2021-09-11 17:41:07 -04:00
Bartłomiej Dach	b9c127c07e	Improve content transitions in beatmap listing	2021-09-11 22:37:36 +02:00
Davran Dilshat	1b264a2dd0	make user lookup string public	2021-09-11 16:22:29 +01:00
Davran Dilshat	c166f1a06a	change error message based on exception message	2021-09-11 14:18:09 +01:00
Bartłomiej Dach	addba43e7d	Merge branch 'master' into fix-password-popover-back-button	2021-09-11 14:18:25 +02:00
Bartłomiej Dach	0e5659acb2	Remove leftover exception throw	2021-09-11 14:10:29 +02:00
Dean Herbert	94702ee7e3	Fix triangles intro attempting to restart track after it is disposed	2021-09-10 18:23:00 +09:00
Dean Herbert	943e0d49f7	Handle control point flattening of nested hit objects	2021-09-10 17:29:09 +09:00
Dan Balasescu	f4b1d8b9d1	Merge pull request #14704 from peppy/modicon-imod-support ... Update `LeaderboardModSelector` to avoid creating mod instances	2021-09-10 16:43:32 +09:00
Davran Dilshat	acb181ff2b	rename alreadyJoinedChannel -> privateChannel	2021-09-10 08:15:43 +01:00
rednir	5ec615c783	display user in error message ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-09-10 08:02:15 +01:00
rednir	84c152e7b6	break when already found user ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-09-10 08:01:38 +01:00
Dean Herbert	cd227213e6	Ensure time of HitObject related ControlPoints are kept in sync with the hitobject	2021-09-10 15:59:30 +09:00
Dean Herbert	714f55b6bc	Clone control points when copying to HitObjects	2021-09-10 14:36:39 +09:00
Dean Herbert	34f875187c	Copy time between ControlPoints	2021-09-10 14:36:38 +09:00
Dean Herbert	309460e505	Merge pull request #14675 from ekrctb/featured-artist-markers ... Add featured artist markers to beatmap listing and overlay	2021-09-10 14:30:33 +09:00
Jamie Taylor	8d1e43423e	Update calls to use new variable name	2021-09-10 14:18:40 +09:00
Dean Herbert	63116a8889	Merge pull request #14703 from gagahpangeran/supporter-bg ... Fix supporter promo background colour	2021-09-10 14:11:01 +09:00
Dan Balasescu	2d2c63dde7	Merge branch 'master' into modicon-imod-support	2021-09-10 13:30:05 +09:00
Dan Balasescu	78a83e0903	Merge pull request #14698 from peppy/fix-beatmap-overlay-hide ... Fix beatmap listing overlay not hiding via keyboard control when scrolled	2021-09-10 13:18:37 +09:00
Dan Balasescu	1d9ad9478e	Merge pull request #14683 from peppy/use-decoupled-clock-triangles-intro ... Use a decoupled clock for triangles intro to avoid startup freezes on broken audio device	2021-09-10 13:15:58 +09:00
Gagah Pangeran Rosfatiputra	110f495345	move internal children to bdl	2021-09-10 11:11:55 +07:00
Jamie Taylor	85b699182e	Rename variable to be more descriptive	2021-09-10 13:01:54 +09:00
Gagah Pangeran Rosfatiputra	e636692596	change background to background 5	2021-09-10 11:00:55 +07:00
Dean Herbert	212c3c699c	Reword xmldoc slightly	2021-09-10 12:58:12 +09:00
Dan Balasescu	80f49ec5fd	Merge branch 'master' into cached-all-mods	2021-09-10 12:47:22 +09:00
Dean Herbert	28e9329136	Update LeaderboardModSelector to avoid creating mod instances	2021-09-10 12:43:21 +09:00
Dean Herbert	464797fecf	Allow ModIcon to be constructed using an IMod	2021-09-10 12:43:12 +09:00
Dean Herbert	c3531e1361	Move more specification from Mod to IMod	2021-09-10 12:42:53 +09:00
Jamie Taylor	2838a3a961	Rewrite conditional to be more 'balanced'	2021-09-10 12:25:41 +09:00
Gagah Pangeran Rosfatiputra	8acf82944f	use hex colour directly instead of transparency	2021-09-10 10:17:10 +07:00
Dean Herbert	719392de39	Change CreateInstance to use Activator.CreateInstance instead of clone	2021-09-10 12:05:10 +09:00
Gagah Pangeran Rosfatiputra	f329973798	fix supporter promo background colour	2021-09-10 09:37:27 +07:00
Dean Herbert	76e877f160	Disable APIMod/Mod cross equality support	2021-09-10 11:24:56 +09:00
Dean Herbert	cf633973a9	Refactor exposed mod retrieval methods for better safety	2021-09-10 11:09:13 +09:00
Dean Herbert	ce6b022a90	Remove unused IMod specification from APIMod	2021-09-10 10:59:30 +09:00
sh0ckR6	bde092f816	Clear UR bar display on seek with mouse	2021-09-09 20:08:16 -04:00
sh0ckR6	bf0150bab4	Clear UR bar display on keyboard input	2021-09-09 16:21:51 -04:00
Dean Herbert	344bf2ab7c	Allow popovers to be closed via back button press ... Closes https://github.com/ppy/osu/issues/14669.	2021-09-10 02:15:37 +09:00
Dean Herbert	46599540b6	Merge pull request #14666 from bdach/fix-score-panel-list-keyboard-nav ... Fix incorrect keyboard navigation order in score panel list	2021-09-10 02:07:06 +09:00
Dean Herbert	c101d1f205	Fix beatmap listing overlay not hiding via keyboard control when scrolled ... Closes https://github.com/ppy/osu/issues/14684.	2021-09-10 01:57:57 +09:00
Dean Herbert	1c3c32b724	Add test ensuring converter doesn't modify original beatmap	2021-09-10 00:00:12 +09:00
Dean Herbert	6c18df24ec	Change how UsingThemedIntro is set to improve clarity	2021-09-09 22:04:16 +09:00
Dean Herbert	99b6f0352c	Always start decoupled clock regardless of track source	2021-09-09 22:04:00 +09:00
ekrctb	29f947fa07	Revert ExplicitContentBeatmapPill, don't try to reuse common code	2021-09-09 19:25:30 +09:00
Dean Herbert	9b34ffc302	Undo big oopsie	2021-09-09 17:12:38 +09:00
Dean Herbert	2edb851008	Add ability to lookup mod from a type specification	2021-09-09 16:50:59 +09:00
Dean Herbert	4d0530ca9d	Add new methods to ruleset for quicker mod lookups	2021-09-09 16:46:14 +09:00
Dean Herbert	e66d76d26e	Avoid settings copy if there are no settings	2021-09-09 15:43:55 +09:00
Jamie Taylor	b01cf5c937	Don't play hover/select sounds for UpdatableAvatar unless it's interactable	2021-09-09 15:33:47 +09:00
Dean Herbert	38f4b0ced2	Merge branch 'master' into cache-setting-source	2021-09-09 15:15:21 +09:00
Dean Herbert	41a2e6eeeb	Fix cache not actually caching anything	2021-09-09 14:56:39 +09:00
Dan Balasescu	f36bebd1a4	Merge branch 'master' into custom-style-link-flow-container	2021-09-09 13:31:55 +09:00
ekrctb	52bb02baed	Prefer composite over inheritance for drawable parts	2021-09-09 12:53:39 +09:00
Dan Balasescu	88dd83f6ca	Merge pull request #14686 from Joehuu/volume-meter-select-on-hover ... Fix volume meter not being highlighted when hovering before show	2021-09-09 12:13:13 +09:00
Dean Herbert	199f5235a3	Merge branch 'master' into fix-score-panel-list-keyboard-nav	2021-09-09 12:12:16 +09:00
Emil Olesen	2888623bdb	Extended the width of the ResetSectionButton to be equal to Content.Width. Fixes #14685	2021-09-08 22:02:24 +02:00
Joseph Madamba	9b05bf3a2c	Fix volume meter not being highlighted when hovering before show	2021-09-08 11:43:59 -07:00
Dean Herbert	ba99a808af	Use a decoupled clock for triangles intro to avoid startup freezes on broken audio device	2021-09-09 01:21:19 +09:00
Dean Herbert	6fc46792d3	Fix test regressions	2021-09-09 00:39:54 +09:00
Dean Herbert	a622a0b660	Use a more traditional method of caching	2021-09-08 23:18:17 +09:00
Dean Herbert	136573982c	Add fade in and fix incorrect wrapper bounds	2021-09-08 20:52:14 +09:00
Dean Herbert	7941240a00	Revert "Load DrawableLoungRooms asynchronously" ... This reverts commit 0b55bb6913fbf05ebb8ecadfe711084d6797efe0.	2021-09-08 20:52:14 +09:00
Dean Herbert	3e41d8b32e	Reduce initial fade transforms	2021-09-08 20:52:14 +09:00
Dean Herbert	bebb9d7e67	Wrap main content of DrawableRoom	2021-09-08 20:52:14 +09:00
Dean Herbert	037b9cfb59	Load DrawableLoungRooms asynchronously	2021-09-08 20:52:14 +09:00
ekrctb	d417f03a39	Simplify link style customization code	2021-09-08 15:52:54 +09:00
ekrctb	9637326f0c	Allow customizing link style by override in LinkFlowContainer	2021-09-08 15:52:54 +09:00
Jamie Taylor	217ca754ae	Add sound for team swaps	2021-09-08 13:45:05 +09:00
ekrctb	f96be2cab8	Add featured artist marker to beatmap set listing and overlay	2021-09-08 13:27:20 +09:00
Dean Herbert	81c9d831f4	Cache reflection portion of SettingSource lookups ... Fixes the mod-related overhead portion of https://github.com/ppy/osu/issues/14638. There's still a significant performance issue that will be addressed separately.	2021-09-08 13:26:11 +09:00
ekrctb	7543f9dfb0	Add featured artist track ID online info	2021-09-08 12:21:24 +09:00
sh0ckR6	b1f91596a7	Give user feedback on password attempt fail ... Shake the popover Set the input box's color to red and set the placeholder text to "incorrect password"	2021-09-07 20:05:24 -04:00
sh0ckR6	b8a1ebb786	Hide Popover after failed password attempt ... Instead of throwing an error, just close the popover and let the user continue	2021-09-07 16:54:21 -04:00
Ethan Ng	d8fe98fe12	Fixed grammatical error in ChangelogSupporterPromo	2021-09-07 14:06:23 -06:00
Bartłomiej Dach	8cc444df5f	Fix incorrect keyboard navigation order in score panel list	2021-09-07 21:14:38 +02:00
Davran Dilshat	255f8a9769	add alias "/msg" (also a command in stable)	2021-09-07 17:25:47 +01:00
Davran Dilshat	b1c89f7618	ignore case when search for already joined channel	2021-09-07 17:22:59 +01:00
Davran Dilshat	be9540e535	fix "key" having wrong url parameter name	2021-09-07 17:17:10 +01:00
rednir	f209222812	Merge branch 'master' into chat-command	2021-09-07 17:09:46 +01:00
Davran Dilshat	f54d5675db	check if user joined requested channel already	2021-09-07 17:06:12 +01:00
Dan Balasescu	87434333d2	Merge pull request #14659 from peppy/update-framework ... Update framework	2021-09-07 21:03:37 +09:00
Dean Herbert	c43ac8c946	Merge pull request #14660 from ekrctb/search-featured-artists ... Add "featured artists" filter to beatmap listing	2021-09-07 20:58:13 +09:00
Dean Herbert	fa62c846c5	Merge pull request #14603 from smoogipoo/score-ordering ... Fix scores not being ordered correctly on leaderboards	2021-09-07 19:18:37 +09:00
Dean Herbert	3d8faea4b0	Simplify nesting of OrderByTotalScoreAsync	2021-09-07 18:52:25 +09:00
Dean Herbert	92f59c10f5	Remove redundant this. in assignment	2021-09-07 17:45:39 +09:00
Dean Herbert	1aa95de530	Merge branch 'master' into score-ordering	2021-09-07 17:45:38 +09:00
ekrctb	5ab2f4b386	Give an orange colour to "featured artists" filter to match web	2021-09-07 17:32:12 +09:00
Dean Herbert	ff87ad6efc	Merge branch 'master' into editor-new-change-diff	2021-09-07 17:13:14 +09:00
Dean Herbert	a42527b8f5	Update framework	2021-09-07 16:46:40 +09:00
Dean Herbert	d922210d2f	Fix TestSceneDeleteLocalScore not properly comparing post-delete scores	2021-09-07 16:46:27 +09:00
Dan Balasescu	49b0998132	Merge branch 'master' into improve-background-screen-ownership-code-quality	2021-09-07 16:46:20 +09:00
ekrctb	b6c80f04b0	Add "featured artists" filter to beatmap search	2021-09-07 16:44:45 +09:00
Dan Balasescu	79fd2d46f6	Merge branch 'master' into test-efficiency	2021-09-07 16:14:12 +09:00
Dan Balasescu	2e0839d880	Merge branch 'master' into update-resources	2021-09-07 15:49:32 +09:00
Dean Herbert	44b1af5ae4	Update resources	2021-09-07 15:28:52 +09:00
Dean Herbert	5b13b566b5	Reduce startup overhead during default key binding handling	2021-09-07 15:19:23 +09:00
smoogipoo	4658577b1d	Factor in total score calculation time in results screen load	2021-09-07 15:19:09 +09:00
Dean Herbert	93da531d13	Improve code around background screen handling to read better	2021-09-07 14:35:33 +09:00
Dean Herbert	9edd010b1d	Fix unnecessary background screen transition	2021-09-07 14:34:54 +09:00
Dean Herbert	7921ad4516	Add loading spinner in case load takes longer than expected	2021-09-07 14:34:47 +09:00
Dean Herbert	ddaa95a1ca	Fix pushEditor function running twice on returning to loader	2021-09-07 14:34:18 +09:00
Dean Herbert	59aa4dabfd	Improve code around background screen handling to read better	2021-09-07 14:33:58 +09:00
smoogipoo	c9325cc419	Fix results screen test scene	2021-09-07 14:15:23 +09:00
Bartłomiej Dach	d13e00ed42	Merge branch 'master' into editor-new-change-diff	2021-09-06 21:42:32 +02:00
Bartłomiej Dach	5b9f37702b	Remove unnecessary delay before pushing editor from loader	2021-09-06 21:32:23 +02:00
Bartłomiej Dach	2d59008f52	Move screen management logic to EditorLoader	2021-09-06 21:30:50 +02:00
Bartłomiej Dach	bd7d6dd35d	Rename method	2021-09-06 21:27:17 +02:00
Bartłomiej Dach	73f742509a	Merge branch 'master' into tablet-area-validity-fix	2021-09-06 21:15:17 +02:00
Dean Herbert	2a5b857f10	Avoid loading unnecessary fonts in headless testing	2021-09-07 00:45:53 +09:00
Dean Herbert	eabca016d4	Throw rather than ignore on invalid control point addition	2021-09-06 22:04:37 +09:00
Dean Herbert	ce197b6322	Fix missing attribute text (and give slightly more space for "10.00x" cases	2021-09-06 21:40:30 +09:00
Dean Herbert	693ecdf62a	Refactor some incorrect/outdated terminology	2021-09-06 21:32:43 +09:00
Dean Herbert	3c7a34bdbd	Move mania-specific conversion to converter	2021-09-06 21:06:13 +09:00
Dean Herbert	52b6b05883	Update terminology in timing screen for now	2021-09-06 21:06:13 +09:00
Dean Herbert	766d789845	Rename ApproachRate to ScrollSpeed for now (to reduce complexity/confusion)	2021-09-06 21:06:13 +09:00
Dean Herbert	0500cd578a	Merge branch 'master' into no-more-difficulty-control-points-info	2021-09-06 21:06:12 +09:00
smoogipoo	20100b8894	Fix a few test failures	2021-09-06 20:20:52 +09:00
smoogipoo	401d38fc05	Fix possible nullref	2021-09-06 19:07:37 +09:00
Dean Herbert	1c4a3c584a	Use correct lookup type to ensure username based lookups always prefer username	2021-09-06 15:04:27 +09:00
Dean Herbert	458cde832d	Avoid using SSDQ for validity computation	2021-09-06 14:11:13 +09:00
Davran Dilshat	5c385e84ea	wrong command name in query message	2021-09-05 21:20:19 +01:00
Davran Dilshat	cb6cee9aea	add /query as alias of /chat	2021-09-05 21:10:08 +01:00
Bartłomiej Dach	d6a47fd99c	Sort difficulties by ruleset and star rating in menu	2021-09-05 21:48:11 +02:00
Bartłomiej Dach	7012a1d934	Fix issues with main menu -> editor loader transition	2021-09-05 21:48:11 +02:00
Bartłomiej Dach	382269b362	Test staying on same difficulty due to unsaved changes	2021-09-05 21:48:10 +02:00
Bartłomiej Dach	c72523bc14	Add basic test for difficulty switching	2021-09-05 21:48:10 +02:00
Bartłomiej Dach	a9403b65b3	Eliminate dependency on OsuGame	2021-09-05 21:48:10 +02:00
Bartłomiej Dach	c397cc2027	Restructure proof of concept	2021-09-05 21:48:09 +02:00
Bartłomiej Dach	fe2520c599	Add intermediary screen to avoid going back to menus	2021-09-05 21:48:09 +02:00
Bartłomiej Dach	7befd030df	Minimal working example of switching difficulties	2021-09-05 21:48:09 +02:00
Bartłomiej Dach	90f0b6874f	Highlight current difficulty in switcher	2021-09-05 21:48:08 +02:00
Bartłomiej Dach	e8fb5d2e66	Add non-functional difficulty switcher to menu	2021-09-05 21:48:08 +02:00
Davran Dilshat	59ca69e41f	add /chat command	2021-09-05 18:16:57 +01:00
Dean Herbert	7c60c6a733	Merge pull request #14571 from rednir/get-user-from-username ... Add ability to open user profile links with username instead of user ID	2021-09-06 00:15:09 +09:00
Dean Herbert	0e48ae76cb	Merge pull request #14630 from bdach/mode-specific-settings ... Add ruleset-specific sections to setup screen	2021-09-05 23:58:24 +09:00
Davran Dilshat	b1a995e0bb	revert changes	2021-09-05 15:49:48 +01:00
Davran Dilshat	e78dc1bb4c	more code quality :/	2021-09-05 15:27:28 +01:00
Davran Dilshat	f7369e0d68	create UserIdLookupCache ... to get user ID when importing scores	2021-09-05 14:47:46 +01:00
Davran Dilshat	e5f886a315	revert unnecessary change	2021-09-05 10:45:38 +01:00
Davran Dilshat	e409f2dc6d	add xmldoc	2021-09-05 10:42:38 +01:00
Davran Dilshat	9aa1564e0d	revert ChannelManager changes	2021-09-05 10:19:04 +01:00
Dean Herbert	e0ee2a5533	Change section title to read better	2021-09-05 13:34:57 +09:00
Dean Herbert	25420af078	Rename method to drop redundant ruleset suffix	2021-09-05 13:34:23 +09:00
Dean Herbert	ab1c64591f	Move sample playback debounce time to central const	2021-09-05 13:25:10 +09:00
Dean Herbert	473e15e8f3	Add debounce to notification sample playback logic	2021-09-05 13:22:37 +09:00
Dean Herbert	1d23ac0f2d	Initial clean up pass on notification logic	2021-09-05 12:54:21 +09:00
Davran Dilshat	ea3be927d7	convert to method group	2021-09-04 20:02:10 +01:00
Davran Dilshat	4c006333e0	add /chat command	2021-09-04 19:42:14 +01:00
Bartłomiej Dach	1a90fb1ef3	Fix cached property being assigned twice	2021-09-04 19:52:42 +02:00
Dean Herbert	4fb3a1d641	Update check to inflate in the correct direct ... Also handles previously unhandled edge cases by comparing all four corners, instead of only two.	2021-09-05 00:46:29 +09:00
Dean Herbert	66daa553de	Fix bounds check running too early causing tablet area to show incorrect validity	2021-09-04 19:34:55 +09:00
Dean Herbert	16beb2c90c	Expose more pieces of TabletSettings	2021-09-04 15:35:46 +09:00
Dean Herbert	f42131ff89	Add back editor functionality for now	2021-09-03 19:08:23 +09:00
Dean Herbert	0e6660da30	Replace todo with permanent comment	2021-09-03 17:11:12 +09:00
Dean Herbert	6894ed3426	Fix new ordering of retrieval meaning EndTime is not available in time	2021-09-03 17:11:12 +09:00
Dean Herbert	8f24ea54ee	Change SamplePoints to be SortedList for conformity	2021-09-03 17:11:12 +09:00
Dean Herbert	74f385bad8	Assign default control points earlier in HitObject construction	2021-09-03 17:11:12 +09:00
Dean Herbert	2b9157987e	Fix regression in SampleControlPoint add logic	2021-09-03 17:11:12 +09:00
Dean Herbert	1aff4c2238	Ensure all hitobject level control points are populated before calling virtual defaults application	2021-09-03 17:11:12 +09:00
Dean Herbert	d587dc6203	Populate new approach rate where required	2021-09-03 17:11:12 +09:00
Dean Herbert	d4e5a612ea	Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time ... This allows fetching the correct `DifficultyControlPoint` from the hitobject. Nothing more.	2021-09-03 17:11:12 +09:00
Dean Herbert	a3d9ab1e2e	Move approach rate to EffectControlPoint	2021-09-03 16:58:16 +09:00
Dean Herbert	4eb09ea1a9	Update decoder to also extract DifficultyControlPoints from HitObjects	2021-09-03 16:58:16 +09:00
Dean Herbert	071c56e90b	Update usages of DifficultyPointAt	2021-09-03 16:58:16 +09:00
Dean Herbert	db3fc1d4af	Move DifficultyControlPoints list to LegacyControlPointInfo	2021-09-03 16:58:16 +09:00
Dean Herbert	b41b1e2394	Write out DifficultyControlPoints into HitObjects	2021-09-03 16:58:16 +09:00
Bartłomiej Dach	ce1912781e	Add extension point for ruleset-specific beatmap setup sections	2021-09-02 23:29:14 +02:00
Dean Herbert	7688ea7057	Merge branch 'master' into score-ordering	2021-09-02 19:19:52 +09:00
Dean Herbert	cdd0262ca1	Merge pull request #14598 from smoogipoo/adjust-classic-scoring ... Make classic scoring a constant multiple of standardised scoring	2021-09-02 19:18:03 +09:00
Dan Balasescu	6c649b7bbe	Merge branch 'master' into no-more-sample-control-points-info	2021-09-02 18:09:05 +09:00
smoogipoo	e2f7aaeb71	Fix 0 score with bonus-only maps	2021-09-02 17:00:13 +09:00
Dean Herbert	b907c2f4f6	Fix osu! judgements getting scaled twice over different durations	2021-09-02 16:31:43 +09:00
smoogipoo	31433c4b89	Apply @spaceman_atlas' quadratic factor	2021-09-02 16:26:17 +09:00
Dean Herbert	f223be0760	Merge branch 'master' into score-ordering	2021-09-02 14:45:59 +09:00
Dan Balasescu	aadef41182	Merge pull request #14601 from peppy/fix-editor-setup-screen-pixel-leakage ... Fix pixels poking out of the top edge of editor setup screen	2021-09-02 14:03:37 +09:00
Dean Herbert	315bbbea4f	Merge pull request #14612 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.9 ... Bump Microsoft.AspNetCore.SignalR.Client from 5.0.8 to 5.0.9	2021-09-02 13:10:50 +09:00
Dean Herbert	d1e5602a79	Merge pull request #14608 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.9 ... Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson from 5.0.8 to 5.0.9	2021-09-02 13:10:46 +09:00
dependabot[bot]	e176babb25	Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.8 to 5.0.9. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.8...v5.0.9) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-02 02:34:24 +00:00
dependabot[bot]	be379051f2	Bump Microsoft.AspNetCore.SignalR.Client from 5.0.8 to 5.0.9 ... Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.8 to 5.0.9. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.8...v5.0.9) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Client dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-02 02:34:19 +00:00
dependabot[bot]	8ba00f6737	Bump HtmlAgilityPack from 1.11.34 to 1.11.36 ... Bumps [HtmlAgilityPack](https://github.com/zzzprojects/html-agility-pack) from 1.11.34 to 1.11.36. - [Release notes](https://github.com/zzzprojects/html-agility-pack/releases) - [Commits](https://github.com/zzzprojects/html-agility-pack/compare/v1.11.34...v1.11.36) --- updated-dependencies: - dependency-name: HtmlAgilityPack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-02 02:33:56 +00:00
smoogipoo	f14d66aafc	Commit missed line	2021-09-02 10:35:00 +09:00
Dean Herbert	9f13e11c7a	Merge pull request #14607 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.9 ... Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack from 5.0.8 to 5.0.9	2021-09-02 03:16:34 +09:00
dependabot[bot]	6f0d1b394d	Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.8 to 5.0.9. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.8...v5.0.9) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-01 17:01:53 +00:00
dependabot[bot]	492209fe13	Bump Sentry from 3.8.3 to 3.9.0 ... Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.8.3 to 3.9.0. - [Release notes](https://github.com/getsentry/sentry-dotnet/releases) - [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.8.3...3.9.0) --- updated-dependencies: - dependency-name: Sentry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-01 17:01:49 +00:00
smoogipoo	df7480e68c	Fix bindable implementation being synchronous	2021-09-01 20:56:23 +09:00
smoogipoo	f7c1177cc9	Fix ScorePanelList nullref when scores are added too soon	2021-09-01 20:35:06 +09:00
smoogipoo	ab538dc3dd	Fix param not passed through	2021-09-01 20:30:26 +09:00
Dean Herbert	ef64c05af8	Merge pull request #14533 from frenzibyte/move-incompatibility-icon ... Move mod incompatibility logic to "local player" mod select overlays	2021-09-01 18:12:27 +09:00
Dean Herbert	9e21f5a59c	Rename LocalPlayer to User in mod select prefixes	2021-09-01 17:22:52 +09:00
Dean Herbert	fb5f3fb9af	Rename button to be more descriptive of its purpose	2021-09-01 17:19:38 +09:00
Dean Herbert	2251bf3bcb	Use lambda spec for method	2021-09-01 17:08:20 +09:00
Dean Herbert	cb66ecdbeb	Merge branch 'master' into simplify-user-graph-tooltips	2021-09-01 17:04:21 +09:00
Dean Herbert	f0b128b6ec	Merge pull request #14592 from frenzibyte/cleanup-tooltips ... Update remaining tooltip implementations to use generics	2021-09-01 17:03:59 +09:00
Dean Herbert	0319177c5c	Fix pixels poking out of the top edge of editor setup screen	2021-09-01 16:46:19 +09:00
smoogipoo	88fc53200e	Refactor	2021-09-01 15:41:52 +09:00
Dean Herbert	edf29e405b	Merge pull request #14581 from bdach/setup-screen-countdown-settings ... Add countdown settings to setup screen	2021-09-01 15:35:46 +09:00
smoogipoo	2de076a74b	Merge branch 'adjust-classic-scoring' into score-ordering	2021-09-01 15:06:55 +09:00
Dean Herbert	c70ac5e5c2	Merge branch 'master' into privatise-toolbar-offset	2021-09-01 14:54:15 +09:00
smoogipoo	bd0f385cdb	Make classic scoring a constant multiple of standardised scoring	2021-09-01 14:53:11 +09:00
Dan Balasescu	e715b21ca7	Merge pull request #14586 from peppy/remove-ijsonserializable ... Remove IJsonSerializable interface	2021-09-01 14:17:32 +09:00
Joseph Madamba	a773a22726	Fix toolbar hiding when clicking home button	2021-08-31 14:29:16 -07:00
Bartłomiej Dach	1e4fa87648	Merge branch 'master' into setup-screen-countdown-settings	2021-08-31 22:43:18 +02:00
Bartłomiej Dach	5dc938cc9f	Update tests to match expectations	2021-08-31 22:41:47 +02:00
Bartłomiej Dach	04773b51bb	Remove countdown toggle transition for now ... Tricky to get right and the design isn't final as is anyway, so leaving *something* functioning as a best-effort for now.	2021-08-31 22:41:40 +02:00
Joseph Madamba	7e4ad7d7cf	Fix toolbar blocking scroll input	2021-08-31 13:40:13 -07:00
Joseph Madamba	da3fa9304a	Make toolbar inherit overlay container	2021-08-31 12:39:18 -07:00
Bartłomiej Dach	c246ff141e	Merge branch 'master' into avoid-exception-on-failed-lookup	2021-08-31 21:14:34 +02:00
Bartłomiej Dach	b969398e2d	Merge branch 'master' into adjust-triangle-speed	2021-08-31 20:44:09 +02:00
Salman Ahmed	505824d8ea	Constrain difficulty icon tooltip to internal accessibility" ... This reverts the reverted commit cd356b8eae. Sorry for the revert-unrevert, rushly pushed without realizing it doesn't even build.	2021-08-31 21:16:17 +03:00
Salman Ahmed	b0d7104650	Convert to class to allow not displaying tooltips ... With `struct` content, it is never possible to not show a tooltip.	2021-08-31 21:13:24 +03:00
Salman Ahmed	cd356b8eae	Revert "Constrain difficulty icon tooltip to internal accessibility" ... This reverts commit 4a590a041c.	2021-08-31 20:57:47 +03:00
Salman Ahmed	4a590a041c	Constrain difficulty icon tooltip to internal accessibility	2021-08-31 20:57:36 +03:00
Salman Ahmed	3969350c9a	Convert to readonly struct and replace with constructor temporarily	2021-08-31 20:45:32 +03:00
Salman Ahmed	69c23a2371	Explicitly implement tooltips on date drawables to avoid "convert to auto-property" inspections	2021-08-31 20:06:34 +03:00
Salman Ahmed	da7ff4b160	Update remaining tooltip implementations to use generics	2021-08-31 20:01:13 +03:00
Salman Ahmed	208f66cc76	Simplify user graph tooltips logic ... The same tooltip can be used for the rank graph, the play history graph, and the replay history graph. The only difference between those three is the displayed label, which has now been included as part of the `TooltipContent`, rather than unnecessarily recreating tooltips just for different sprite texts.	2021-08-31 19:59:38 +03:00
Salman Ahmed	a190801291	Revert no longer required tooltip content changes	2021-08-31 19:36:27 +03:00
Salman Ahmed	9afc482598	Merge branch 'master' into move-incompatibility-icon	2021-08-31 19:27:43 +03:00
Davran Dilshat	9288ca1191	handle api is null	2021-08-31 14:34:45 +01:00
Davran Dilshat	0a87b461d7	fix code quality issues	2021-08-31 14:11:37 +01:00
Davran Dilshat	79f71e5181	get user id when importing scores	2021-08-31 13:56:44 +01:00
smoogipoo	999386da29	Cleanup	2021-08-31 21:47:49 +09:00
smoogipoo	fee94236de	Fix update-thread pauses	2021-08-31 21:36:31 +09:00
smoogipoo	cfcf3d7507	Use synchronous total score retrieval for bindable	2021-08-31 20:43:50 +09:00
smoogipoo	bfcadcc4ac	Revert some changes	2021-08-31 19:18:01 +09:00
smoogipoo	90768a86a6	Adjust classic scoring as a constant multiple over standardised scoring	2021-08-31 18:54:16 +09:00
Dean Herbert	a254624373	Avoid performing beatmap metadata lookups when entering the editor ... If none of the lookup parameters are available, skip the lookup completely.	2021-08-31 17:18:05 +09:00
Dean Herbert	d988aa1680	Actually serialise SampleControlPoints along with HitObjects	2021-08-31 15:14:03 +09:00
Dean Herbert	448c58c35d	Remove unnecessary variable discard ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-08-31 15:08:07 +09:00
Dean Herbert	9fa8bee094	Remove outdated TODO	2021-08-31 14:51:19 +09:00
Dean Herbert	ce0d7cce2d	Merge branch 'remove-ijsonserializable' into no-more-sample-control-points-info	2021-08-31 14:40:54 +09:00
Dean Herbert	c25ab6835c	Remove IJsonSerializable interface ... Was pretty pointless and made it hard to use the custom serialisation terms arbitrarily in tests.	2021-08-31 14:39:20 +09:00
Dean Herbert	529a9a6ff8	Adjust minimum triangle movement speed to avoid "static" triangles in logo ... Closes #14584.	2021-08-31 14:08:23 +09:00
Joseph Madamba	570d36fde7	Make toolbar handle mouse events instead	2021-08-30 20:53:43 -07:00
Bartłomiej Dach	ddf9d2aa6c	Add test coverage	2021-08-30 22:55:58 +02:00
Bartłomiej Dach	b43ee2d61c	Add descriptions to enum members	2021-08-30 22:51:42 +02:00
Bartłomiej Dach	eec9f6d191	Add countdown settings to design section	2021-08-30 22:51:41 +02:00
Bartłomiej Dach	48e56adcfe	Add labelled number box control	2021-08-30 21:52:24 +02:00
Bartłomiej Dach	a6d09b0bb0	Add labelled enum dropdown variant	2021-08-30 21:37:14 +02:00
Bartłomiej Dach	acf38c723a	Move labelled dropdown from tournament to main game	2021-08-30 21:37:08 +02:00
Dean Herbert	a2cff75fc0	Fix editor not cloning control points as expected	2021-08-30 21:55:08 +09:00
Salman Ahmed	6154642075	Merge branch 'master' into local-popover-containers	2021-08-30 15:44:29 +03:00
rednir	8104b15874	remove braces ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-08-30 13:23:33 +01:00
rednir	c789163d01	use user ID overload when its supposed to be used ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-08-30 13:22:12 +01:00
Dan Balasescu	b95da3ca27	Merge pull request #14576 from peppy/update-framework ... Update framework	2021-08-30 21:09:58 +09:00
Dan Balasescu	c1f77cfa1e	Merge pull request #14577 from Henry-YSLin/status-criteria-parsing ... Parse partially typed status names in song select filter query	2021-08-30 19:59:41 +09:00
smoogipoo	caa797cbf4	Attempt to reorder score panel list	2021-08-30 19:58:35 +09:00
smoogipoo	e19d81c88c	Fix potential incorrect ordering	2021-08-30 19:41:44 +09:00
smoogipoo	4ebb11472d	Update Leaderboard to reorder scores based on scoring mode	2021-08-30 19:34:34 +09:00
smoogipoo	458ce250f0	Use new ScoreManager method in ScoreTable	2021-08-30 19:34:12 +09:00
smoogipoo	d03950fb37	Move score calculation to ScoreManager	2021-08-30 19:33:09 +09:00
Henry Lin	8137eee527	Reuse value to save enum name ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-08-30 18:05:47 +08:00
smoogipoo	b217dd1a65	Order scores by score	2021-08-30 19:03:16 +09:00
smoogipoo	47061c0210	Trigger refresh on scoring mode change	2021-08-30 18:57:30 +09:00
Henry Lin	04bf667d0d	Parse partially typed enum names in filter query	2021-08-30 17:49:18 +08:00
Dan Balasescu	c4da966ad9	Merge pull request #14575 from peppy/add-legacy-convert-encode-stability-tests ... Fix multiple conversions of a beatmap to taiko ruleset applying speed multiplier multiple times	2021-08-30 18:47:09 +09:00
Dean Herbert	1aaea7011a	Fix early return causing event loss in case of multiple control points in group	2021-08-30 18:33:05 +09:00
Dean Herbert	015df282fe	Simplify copy operations	2021-08-30 18:32:55 +09:00
Davran Dilshat	1aeae2b8c8	reverse ternary operator	2021-08-30 10:11:41 +01:00
Dean Herbert	4da2dca339	Apply the default SampleControlPoint if not externally provided ... This is mostly to handle tests for now, as generally this should be provided by an external source in all other cases.	2021-08-30 17:21:07 +09:00
Dean Herbert	d35c4da906	Add new control point to legacy regeneration logic	2021-08-30 17:14:53 +09:00
Dean Herbert	6ee4a6526c	Don't block sample points from still being added to ControlPointInfo	2021-08-30 17:14:53 +09:00
Dean Herbert	6fd24a5d92	Remove redundant null coalesce	2021-08-30 17:14:53 +09:00
Dean Herbert	ccacf56dd8	Move to legacy namespace	2021-08-30 17:14:53 +09:00
Dean Herbert	7257aae7f2	Move samples to LegacyControlPointInfo	2021-08-30 17:14:53 +09:00
Dean Herbert	da7a871afa	Update inline comment to point to new variable location ... Co-authored-by: PercyDan <50285552+PercyDan54@users.noreply.github.com>	2021-08-30 16:27:24 +09:00
Dean Herbert	678386f5c4	Fix missed null coalesce	2021-08-30 16:05:56 +09:00
Dean Herbert	fa2bf42188	Update tooltip implementations	2021-08-30 16:05:00 +09:00
Dean Herbert	f64efdc4a9	Merge branch 'update-extension-usages' into update-framework	2021-08-30 16:00:09 +09:00
Dean Herbert	58a052ea1f	Update framework	2021-08-30 16:00:07 +09:00
Dean Herbert	6a6dac609c	Fix instability of taiko double conversion ... Until now, the taiko speed multiplier was potentially applied more than once if conversion was run multiple times.	2021-08-30 15:30:18 +09:00
Dean Herbert	ee49305cad	Move taiko legacy speed multiplier to osu.Game project ... Allows it to be used in local case in `LegacyBeatmapEncoder`.	2021-08-30 15:13:31 +09:00
Dean Herbert	4dd60e3299	Merge branch 'master' into taiko-drum-refacor	2021-08-30 14:12:52 +09:00
Dan Balasescu	7be825f470	Merge pull request #14488 from frenzibyte/multi-spectator-player-leaving ... Gray out and stop player instances who quit during multi-spectator sessions	2021-08-30 12:04:19 +09:00
Davran Dilshat	90c313e2ad	add methods to get a user from their username	2021-08-29 19:19:55 +01:00
Salman Ahmed	6dc11543ad	Handle (null?) PP in PerformanceTable	2021-08-29 17:20:33 +03:00
Salman Ahmed	6aaef7b0be	Handle null PP during score set in TopScoreStatisticsSection ... Supersedes #14562 Closes #14541	2021-08-29 17:19:17 +03:00
Salman Ahmed	8f3416d853	Assert PP not null when showPerformancePoints is true	2021-08-29 16:03:39 +03:00
Salman Ahmed	e374ef163d	Update localisable formattable extensions usages inline with framework change	2021-08-29 15:00:28 +03:00
Joseph Madamba	9a5445bded	Fix overlays closing when clicking any empty area of the toolbar instead	2021-08-28 22:25:13 -07:00
Joseph Madamba	38912bfc16	Fix floating overlays not closing when clicking some empty area of the toolbar	2021-08-28 20:38:35 -07:00
Bartłomiej Dach	2efe82a18d	Remove popover container from manual input manager test scene	2021-08-28 20:20:42 +02:00
Bartłomiej Dach	d9db1ecee9	Remove game-global popover container	2021-08-28 20:05:59 +02:00
Bartłomiej Dach	fcc3e57d5d	Move overlay colour provider up to editor screen	2021-08-28 20:05:58 +02:00
Bartłomiej Dach	e94d96f250	Add local popover container to editor screens	2021-08-28 20:05:58 +02:00
Bartłomiej Dach	7457480b50	Add local popover container to lounge subscreen	2021-08-28 20:05:58 +02:00
Salman Ahmed	589f2863ca	Move incompatibility tooltip logic to local player mod select overlays ... This one turned out to be a bit more involved, due to tooltips being shared and having the potential of being used somewhere where it shouldn't be, due to the same content type matching. That's the reason I've defined a protected `TargetContentType`, to be able to separate "local player mod tooltips" and regular mod tooltips apart. Definitely unsure about the solution, but that's as far as I can think of right now.	2021-08-28 02:38:46 +03:00
Salman Ahmed	e527bfd4bf	Move incompatibility icon logic to local player mod select overlays	2021-08-28 02:37:46 +03:00
Dean Herbert	681a87d4ec	Update framework	2021-08-28 07:08:06 +09:00
Dean Herbert	804ca88d63	Update framework	2021-08-27 19:52:45 +09:00
Salman Ahmed	378734a7f8	Separate solo spectator player and "exit on restart" logic to own class	2021-08-27 13:24:37 +03:00
Dean Herbert	2b06dacd0e	Change debounce back to using scheduler ... Should better allow for adjusting in the future, as well.	2021-08-27 18:57:19 +09:00
Dean Herbert	33aa48bcf6	Merge branch 'master' into lobby-sounds	2021-08-27 18:46:12 +09:00
Dean Herbert	7d9bae4507	Update resources	2021-08-27 18:29:49 +09:00
Dan Balasescu	a28bc9f6b2	Merge branch 'master' into path-control-point-bindable-removal	2021-08-27 09:37:37 +09:00
Bartłomiej Dach	2ef2af17eb	Merge branch 'master' into alternative-difficulty-bindable	2021-08-26 23:07:52 +02:00
Bartłomiej Dach	d71dff4340	Merge branch 'master' into skip-overlay-optimisations	2021-08-26 22:38:17 +02:00
Bartłomiej Dach	875ef3e68f	Merge branch 'master' into fix-mania-editor	2021-08-26 21:00:20 +02:00
Dean Herbert	15aa0458bc	Use PausableSkinnableSound instead	2021-08-26 17:15:36 +09:00
Dean Herbert	ec85d7f356	Remove unused helper method	2021-08-26 17:15:23 +09:00
Dean Herbert	982c4eff14	Merge branch 'master' into taiko-drum-refacor	2021-08-26 17:13:14 +09:00
Salman Ahmed	2f26d270a3	Merge branch 'master' into score-processor-enum-getvalue-overhead-reduction	2021-08-26 09:55:09 +03:00
Salman Ahmed	15812520bd	Replace global editor test case with mania compose screen test scene	2021-08-26 09:45:01 +03:00
Jamie Taylor	56baecdde4	Add missing interaction sfx to MatchTypePicker	2021-08-26 15:30:20 +09:00
Jamie Taylor	e341f471b0	Add lobby sfx for join/leave/kick/ready/unready events	2021-08-26 15:29:22 +09:00
Dean Herbert	e633b2716d	Fix regression in outro skip handling logic	2021-08-26 13:58:45 +09:00
Dean Herbert	e32933eb54	Avoid Enum.GetValues in each score population pass	2021-08-26 13:37:53 +09:00
Dean Herbert	f4199958d9	Avoid unnecessary array/LINQ operations when replay frames have no action changes	2021-08-26 13:03:50 +09:00
Dean Herbert	6dcd9427ac	Remove bindable usage in PathControlPoint ... This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class. I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.	2021-08-26 12:33:53 +09:00
Dean Herbert	b1a261c902	Avoid using scheduled delegates at all for skip overload input handling	2021-08-26 12:25:37 +09:00
Dean Herbert	956e3c554b	Avoid skip overlay attempting to show when it is already invalid	2021-08-26 12:25:37 +09:00
Salman Ahmed	b4d6495f99	Fix editor skin providing container not providing playable beatmap	2021-08-25 17:52:36 +03:00
Salman Ahmed	f9b25a0159	Add test case for switching to each screen in editor test scenes	2021-08-25 17:52:35 +03:00
Salman Ahmed	3ad0b529fb	Make EditorScreen inherit from VisibilityContainer rather than unsafe transforms	2021-08-25 17:14:52 +03:00
Salman Ahmed	196c74fce8	Gray out and remove player clock when users stop playing	2021-08-25 11:31:02 +03:00
Salman Ahmed	599145b46a	Stop clocks when removing them from sync manager	2021-08-25 11:31:02 +03:00
Dean Herbert	fd78d0440b	Update missed conditional	2021-08-25 17:00:32 +09:00
Dean Herbert	ccfff50c6f	Apply fixes in line with issues found during testing ... I was trying to be too smart with caching, but if the `Play` method was not called often enough it would have a recent reference. Unfortunately this requires a separate query to `Entries`, but is also a special case (no future hitobjects). This also removes the time-based checks (result status alone should be all we care about).	2021-08-25 16:56:44 +09:00
Dean Herbert	ef2b5e1c51	Tidy up variable names and unused resolved properties	2021-08-25 16:56:44 +09:00
Dean Herbert	a1936b141b	Refactor base class to allow correct usage in taiko drum	2021-08-25 16:56:44 +09:00
Dean Herbert	681215e5b5	Rewrite object lookup to use previous entry regardless ... This changes the fallback logic to always prefer the previous resolved lifetime entry rather than fallback to the first entry ever. I think this is more correct in all cases. Also rewrites the inline comments to hopefully be easier to parse.	2021-08-25 16:56:44 +09:00
Dean Herbert	4a294d4de4	Optimise fallback logic to reduce lookups to bare minimum	2021-08-25 16:56:44 +09:00
Dean Herbert	6aa894e55e	Split out separate component	2021-08-25 16:56:44 +09:00
Dan Balasescu	351015357c	Merge branch 'master' into user-events-in-participant-list	2021-08-25 14:39:26 +09:00
Dean Herbert	e1ab3434ed	Add ability to handle user join/leave/kick events in MultiplayerComposites	2021-08-25 14:37:14 +09:00
Salman Ahmed	ca527262e3	Merge branch 'master' into countdown-beatmap-info	2021-08-25 08:30:27 +03:00
Salman Ahmed	84637b59ef	Define DifficultyBindableWithCurrent and use in SliderControl	2021-08-25 07:40:41 +03:00
Dean Herbert	414457ba57	Add basic xmldoc explaining CountdownOffset	2021-08-25 13:24:52 +09:00
Bartłomiej Dach	a6c2cbd2e5	Add countdown settings to beatmap info model	2021-08-24 21:55:10 +02:00
Bartłomiej Dach	e503182a8d	Merge branch 'master' into activity-on-multiplayer-screens	2021-08-24 18:50:55 +02:00
Dean Herbert	568a8ee97e	Merge branch 'master' into fix-hud-test-failure-2	2021-08-24 16:54:48 +09:00
Dean Herbert	3f0f820653	Add comment explaining reasoning for override	2021-08-24 16:54:19 +09:00
Dean Herbert	08f757a584	Merge pull request #14474 from smoogipoo/fix-multi-crash ... Fix crash when entering multiplayer gameplay	2021-08-24 16:20:18 +09:00
Dan Balasescu	6a916a264f	Merge pull request #14441 from Henry-YSLin/mod-incompatibility-ui ... Show mods that are incompatible with the current selection	2021-08-24 16:16:35 +09:00
Dan Balasescu	ea98ce1b39	Merge pull request #14465 from peppy/improve-stable-skin-import ... Improve skin stable import behaviour to better handle similar skins	2021-08-24 16:08:15 +09:00
smoogipoo	9f17c38e36	Fix hud overlay components being blocked from load	2021-08-24 15:18:27 +09:00
Dean Herbert	a5f6c287ea	Split out pinned comment content to only be constructed when required	2021-08-24 14:43:28 +09:00
Dean Herbert	8cd972a9fe	Merge branch 'master' into pinned-comment	2021-08-24 14:37:31 +09:00
smoogipoo	16ddbcd208	Don't bind to RoomId where it's expected to be constant	2021-08-24 14:25:40 +09:00
Dean Herbert	c3b7ce0b05	Remove stray newline	2021-08-24 14:02:50 +09:00
Dean Herbert	afd01d22d6	Adjust visuals of incompatible icon and move to own class	2021-08-24 14:01:49 +09:00
Salman Ahmed	847726547a	Move mod value change callback inside wedge info text component	2021-08-24 07:53:49 +03:00
Dean Herbert	bf0a1167ec	Improve update flow and ensure selected mods is read from local context	2021-08-24 13:35:39 +09:00
smoogipoo	de0de451fe	Refactor to remove resolved dependency	2021-08-24 13:29:19 +09:00
smoogipoo	df170afbc4	Fix multiplayer crashing when entering gameplay	2021-08-24 13:22:06 +09:00
smoogipoo	956c1cc216	Merge branch 'master' into activity-on-multiplayer-screens	2021-08-24 12:33:34 +09:00
Dan Balasescu	dfd61e413a	Merge branch 'master' into difficulty-cache-difficulty-adjust	2021-08-24 12:08:52 +09:00
Dean Herbert	3c9718339c	Merge pull request #14444 from frenzibyte/decouple-ruleset-bindables ... Decouple rankings overlay's ruleset selector from the game-wide ruleset bindable	2021-08-24 11:58:13 +09:00
Henry Lin	b8fe03b77f	Use Mod.Equals for comparison	2021-08-24 09:50:09 +08:00
Henry Lin	6e3d05c7ce	Display an icon to signify incompatibility instead of a red tint	2021-08-24 09:42:53 +08:00
Salman Ahmed	13a24ed36f	Merge branch 'master' into update-section-selection-childcount	2021-08-23 20:43:46 +03:00
Bartłomiej Dach	ccf337bdc2	Merge branch 'master' into editor-setup-file-selector-popovers	2021-08-23 18:28:44 +02:00
Davran Dilshat	6bea744e34	invalidate scroll position	2021-08-23 17:13:25 +01:00
Davran Dilshat	20222f09c4	oops redundant default value	2021-08-23 16:55:31 +01:00
Davran Dilshat	9a507ed273	update selected section on children count change	2021-08-23 16:27:29 +01:00
Salman Ahmed	bd42d7aada	Hide popover on file selection	2021-08-23 18:01:01 +03:00
Dean Herbert	a2484692b3	Change brackets to square	2021-08-23 20:37:19 +09:00
Dean Herbert	7b3f7cc7c1	Change skin import to also include directory names in the skin name where appropriate	2021-08-23 20:24:00 +09:00
Dean Herbert	fed0e15cea	Fix typo in ArchiveModelManager	2021-08-23 20:23:46 +09:00
Salman Ahmed	f8a7e0bdb6	Update rankings overlay ruleset bindable with parent on initial display	2021-08-23 13:50:39 +03:00
Salman Ahmed	d3958eb3fb	Revert initial ruleset value logic	2021-08-23 13:28:21 +03:00
Salman Ahmed	f4b69ceb8a	Remove unused using embedded in reverted changes	2021-08-23 12:40:20 +03:00
Salman Ahmed	257934a144	Revert "Revert ruleset when not applied filters (includes scope change)" ... This reverts commit 9fa39cd34e.	2021-08-23 12:38:30 +03:00
Salman Ahmed	eeeaefbd7d	Revert "Store default ruleset value for ability to revert" ... This reverts commit cb7c2f713b.	2021-08-23 12:38:24 +03:00
Dean Herbert	34b51100ff	Merge pull request #14448 from bdach/basic-design-settings ... Add basic design settings to editor setup screen	2021-08-23 18:19:58 +09:00
Dean Herbert	c2c9a93e2c	Show editor file choosers in a popover rather than inline ... Supersedes and closes #14370. Closes #14367.	2021-08-23 18:12:36 +09:00
Dean Herbert	2f6b95da39	Add descriptions for the remaining settings	2021-08-23 17:41:03 +09:00
Dean Herbert	d17f7b5c8b	Side WidescreenStoryboard to on by default for new beatmaps	2021-08-23 17:40:41 +09:00
Dean Herbert	1de84e1c98	Change description to include mention of video ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2021-08-23 17:34:19 +09:00
Dean Herbert	eaa4d479ac	Merge pull request #14408 from smoogipoo/remove-current-room ... Remove the global "selected room" from online screens	2021-08-23 17:29:31 +09:00
Salman Ahmed	9fa39cd34e	Revert ruleset when not applied filters (includes scope change)	2021-08-23 11:11:06 +03:00
Salman Ahmed	cb7c2f713b	Store default ruleset value for ability to revert	2021-08-23 11:09:26 +03:00
Salman Ahmed	1d89d757af	Fix beatmap ruleset selector selecting initial ruleset	2021-08-23 09:57:05 +03:00
Dean Herbert	99bb3032a5	Move gradient to be part of the background for now	2021-08-23 15:27:32 +09:00
Salman Ahmed	2ba88923b6	Select user preferred ruleset on overlay ruleset selectors initially	2021-08-23 08:58:54 +03:00
Dean Herbert	58fb0c042b	Remove background scale altogether ... I'm not sure why this is required. Seems like something which was meant to exist to handle parallax, but that is already handled elsewhere now.	2021-08-23 14:34:27 +09:00
smoogipoo	4f3a5fbad5	Fix test failure	2021-08-23 14:29:15 +09:00
Dan Balasescu	ead1b47e0e	Merge branch 'master' into localise-beatmap-set-overlay	2021-08-23 13:22:52 +09:00
Dan Balasescu	2ad5914fec	Merge branch 'master' into decouple-ruleset-bindables	2021-08-23 12:40:57 +09:00
Bartłomiej Dach	2e80e2be51	Reword epilepsy warning description text	2021-08-22 21:47:37 +02:00
Bartłomiej Dach	9538a32b5e	Explicitly update beatmap info wedge on mod change ... This used to already be the case prior to b419ea7, but in a very roundabout way. Changes to the value of the star difficulty bindable - including indirect changes via the set of active mods changing - would trigger the wedge display to regenerate and load asynchronously. b419ea7 accidentally broke this by moving down the bindable retrieval to a lower level, at which point `WedgeInfoText` would only receive the set of mods selected at the time at which a given beatmap was selected, and not receive any further updates, breaking the BPM display updating in real time (as `WedgeInfoText` could not be aware that rate-changing mods were even in effect). To resolve, explicitly reload the wedge's contents on mod changes.	2021-08-22 19:16:46 +02:00
Bartłomiej Dach	e4a8f72167	Add failing test case	2021-08-22 19:16:43 +02:00
Bartłomiej Dach	d602dc9d90	Enable epilepsy warning setting persistence in encoder	2021-08-22 17:43:20 +02:00
Bartłomiej Dach	9816af688e	Add basic design settings to setup screen	2021-08-22 17:43:20 +02:00
Salman Ahmed	45b8bd175c	Decouple rankings overlay's ruleset bindable from game-wide bindable	2021-08-22 16:25:35 +03:00
Salman Ahmed	d164529be8	Fix ruleset selector not updating to the first ruleset item until after LoadComplete() ... This fixes the whole issue behind `Ruleset.Value` being null, by updating `Current` on BDL rather than waiting for the base logic which executes at `LoadComplete`. This seems like something that should happen at the base `TabControl` class itself, by switching `Current` right after the first added tab item, rather than doing it on `LoadComplete`, but I'm not sure about changing framework logic outright, so fixing this locally until it occurs on other places.	2021-08-22 16:25:34 +03:00
Dean Herbert	81e3c9d40f	Update resources	2021-08-22 19:13:21 +09:00
Salman Ahmed	956112eb10	Reword comment and remove brackets	2021-08-22 12:40:41 +03:00
Salman Ahmed	9b1720bd6c	Merge branch 'master' into localise-beatmap-set-overlay	2021-08-22 10:53:31 +03:00
Michael Malloy	9cd0a182f6	Add null check for Android ruleset loading	2021-08-22 00:38:48 -05:00
Henry Lin	3795030ebb	Merge branch 'master' into mod-incompatibility-ui	2021-08-22 11:14:24 +08:00
Henry Lin	0bbddd297c	Remove unused code	2021-08-22 11:05:53 +08:00
Henry Lin	e213562b2a	Add a red tint on mods incompatible with the current selection	2021-08-22 11:01:17 +08:00
Henry Lin	ef6faf04be	Use FirstOrDefault in TooltipContent	2021-08-22 10:22:18 +08:00
Henry Lin	3d402d9e78	List incompatible mods in tooltip of mod button	2021-08-22 10:13:34 +08:00
Nathan Alo	2877b43824	split multiplayer and playlist activity	2021-08-22 09:54:07 +08:00
Bartłomiej Dach	7ab12959a0	Merge branch 'master' into editor-regex	2021-08-21 19:57:26 +02:00
Dean Herbert	77f3668751	Merge branch 'master' into fix-screen-offsetting-on-scaling	2021-08-22 02:28:06 +09:00
Bartłomiej Dach	995338029c	Fix difficulty cache lookups sharing underlying mod instances ... `DifficultyCacheLookup`s were storing raw `Mod` instances into their `OrderedMods` field. This could cause the cache lookups to wrongly succeed in cases of mods with settings. The particular case that triggered this fix was Difficulty Adjust. Because the difficulty cache is backed by a dictionary, there are two stages to the lookup; first `GetHashCode()` is used to find the appropriate hash bucket to look in, and then items from that hash bucket are compared against the key being searched for via the implementation of `Equals()`. As it turns out, the first hashing step ended up being the saving grace in most cases, as the hash computation included the values of the mod settings. But the Difficulty Adjust failure case was triggered by the quirk that `GetHashCode(0) == GetHashCode(null) == 0`. In such a case, the `Equals()` fallback was used. But as it turns out, because the `Mod` instance stored to lookups was not cloned and therefore potentially externally mutable, it could be polluted after being stored to the dictionary, and therefore breaking the equality check. Even though all of the setting values were compared, the hash bucket didn't match the actual contents of the lookup anymore (because they were mutated externally, e.g. by the user changing the mod setting values in the mod settings overlay). To resolve, clone out the mod structure before creating all difficulty lookups.	2021-08-21 15:50:33 +02:00
Salman Ahmed	9a6ff29951	Reword comment ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-08-21 15:39:57 +03:00
Salman Ahmed	1729d43cec	Add explanatory comment	2021-08-21 15:18:03 +03:00
Salman Ahmed	df5354eba6	Merge branch 'master' into fix-setting-section-clickability	2021-08-21 14:25:28 +03:00
Salman Ahmed	216ff07497	Merge branch 'master' into fix-setting-section-clickability	2021-08-21 14:11:55 +03:00
Salman Ahmed	76e1d88028	Merge branch 'master' into gameplay-chat-mouse-cursor	2021-08-21 14:01:30 +03:00
Dean Herbert	ae47c5cdb3	Fix bottom area of a settings section not being clickable	2021-08-21 15:08:42 +09:00
Dean Herbert	15d443f6b7	Use the UI mouse cursor when hovering gameplay chat in an interactive state	2021-08-21 14:44:54 +09:00
Dean Herbert	36352d1de4	Improve highlighted chat username shadow effect	2021-08-21 14:34:35 +09:00