h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-14 04:02:59 +08:00
Code Issues Releases Wiki Activity

Convert to readonly struct and replace with constructor temporarily

Browse Source
This commit is contained in:
Salman Ahmed 2021-08-31 20:45:32 +03:00
parent 208f66cc76
commit 3969350c9a
3 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game/Overlays/Profile/Header/Components/RankGraph.cs
View File

@ -64,12 +64,10 @@ namespace osu.Game.Overlays.Profile.Header.Components
{
var days = ranked_days - index + 1;
return new UserGraphTooltipContent
{
Name = UsersStrings.ShowRankGlobalSimple,
Count = rank.ToLocalisableString("\\##,##0"),
Time = days == 0 ? "now" : $"{"day".ToQuantity(days)} ago"
};
return new UserGraphTooltipContent(
UsersStrings.ShowRankGlobalSimple,
rank.ToLocalisableString("\\##,##0"),
days == 0 ? "now" : $"{"day".ToQuantity(days)} ago");
}
}
}

11
osu.Game/Overlays/Profile/Sections/Historical/UserHistoryGraph.cs
View File

@ -28,11 +28,12 @@ namespace osu.Game.Overlays.Profile.Sections.Historical
protected override float GetDataPointHeight(long playCount) => playCount;
protected override UserGraphTooltipContent GetTooltipContent(DateTime date, long playCount) => new UserGraphTooltipContent
protected override UserGraphTooltipContent GetTooltipContent(DateTime date, long playCount)
{
Name = tooltipCounterName,
Count = playCount.ToLocalisableString("N0"),
Time = date.ToLocalisableString("MMMM yyyy")
};
return new UserGraphTooltipContent(
tooltipCounterName,
playCount.ToLocalisableString("N0"),
date.ToLocalisableString("MMMM yyyy"));
}
}
}

17
osu.Game/Overlays/Profile/UserGraph.cs
View File

@ -295,11 +295,18 @@ namespace osu.Game.Overlays.Profile
}
}
public class UserGraphTooltipContent
public readonly struct UserGraphTooltipContent
{
// todo: change to init-only on C# 9
public LocalisableString Name { get; set; }
public LocalisableString Count { get; set; }
public LocalisableString Time { get; set; }
// todo: could use init-only properties on C# 9 which read better than a constructor.
public LocalisableString Name { get; }
public LocalisableString Count { get; }
public LocalisableString Time { get; }
public UserGraphTooltipContent(LocalisableString name, LocalisableString count, LocalisableString time)
{
Name = name;
Count = count;
Time = time;
}
}
}