Dean Herbert
e35623df22
Update to use new Filter method and remove silly ForcedSearchTerm
2023-05-30 13:40:59 +09:00
Cootz
22c6d6c526
Prevent checkbox from toggle on when column have no valid panels
2023-05-29 14:22:40 +03:00
Cootz
e43c233b48
Reword ForcedSearchTerm xmldoc
2023-05-28 13:21:41 +03:00
Cootz
0e5c99b760
Fix search bar showing incorrectly
2023-05-28 13:12:57 +03:00
Cootz
5ff023113f
Update xmldoc for ForcedSearchTerm
2023-05-28 10:04:26 +03:00
Bartłomiej Dach
6392c2007c
Merge pull request #23637 from peppy/add-shadow-settings-notifications
...
Add shadow to notifications and settings overlays to better distinguish from other overlays
2023-05-24 21:34:14 +02:00
Dean Herbert
e5451d1d79
Centralise definition of overlay shadow opacity and reduce slightly
2023-05-24 12:40:35 +09:00
Dean Herbert
02d8e3a11e
Mark FullscreenOverlay's shadow effect as Hollow to save on shader overhead
2023-05-23 18:50:14 +09:00
Dean Herbert
6f4e2b37ed
Add shadow to notifications and settings overlays to better distinguish from other overlays
2023-05-23 18:50:14 +09:00
Dean Herbert
adf9a596b5
Fix weird state when attempting to enter gameplay skin editor scene from multiplayer
...
Closes https://github.com/ppy/osu/issues/23626 .
2023-05-23 17:58:44 +09:00
Cootz
c3f06ad2db
Merge branch 'master' into add-mod-search-option
2023-05-23 08:55:57 +03:00
Dean Herbert
09c66bea8f
Merge pull request #23606 from Joehuu/fix-news-sidebar-link-clicking-area
...
Fix clicking area of news sidebar post links
2023-05-22 14:17:08 +09:00
Joseph Madamba
7392109bce
Apply same behavioral changes to NewsCard
2023-05-21 19:28:12 -07:00
Joseph Madamba
2279aad360
Apply NRT to NewsCard
2023-05-21 19:27:20 -07:00
Dean Herbert
b3527b92b6
Handle case in tests where current display becomes null
2023-05-22 09:25:44 +09:00
Bartłomiej Dach
6df1d29862
Merge branch 'master' into use-atomic-ReplaceRange
2023-05-21 20:32:59 +02:00
Joseph Madamba
88c112612f
Remove hardcoded website url
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-05-21 10:35:22 -07:00
Cootz
67bf1b4dfe
Select/deselect first visible mod when GlobalAction.Select is triggered
2023-05-21 11:05:01 +03:00
Joseph Madamba
8aefb62532
Rename PostButton to PostLink
2023-05-20 16:38:56 -07:00
Joseph Madamba
ec5f0bbf42
Fix clicking area of news sidebar post links
...
Side effect is that the hover color is yellow and pressing it opens an external dialog, but those are temporary (pending implementation of link underline to make `Light1` hover more readable and set at a higher level and news pages).
2023-05-20 16:32:04 -07:00
Dean Herbert
79e1d978e7
Ensure scroll-to-top button is displayed above all overlay content
2023-05-17 15:42:38 +09:00
Susko3
fec47fa690
Merge branch 'master' into use-atomic-ReplaceRange
...
This reverts 0dcf1b540e
2023-05-17 06:56:54 +02:00
Susko3
2d7fe68311
Prevent feedback by using atomic .ReplaceRange()
...
`display.NewValue` will never be null, checked on SDL + osuTK/Android.
On Android it's a 0x0 display, importantly not null.
2023-05-16 21:57:31 +02:00
Bartłomiej Dach
0dcf1b540e
Attempt to preserve old resolution when switching displays
2023-05-16 21:14:09 +02:00
Bartłomiej Dach
88ce627c8e
Avoid bindable/event feedback when changing resolution
2023-05-16 21:02:23 +02:00
Cootz
6647d95ea7
Kill search focus when clicking on ModColumn
2023-05-14 18:32:16 +03:00
Dean Herbert
c0f869e685
Fix some tablet settings being hidden when searching using "area" keyword
...
As discussed in https://github.com/ppy/osu/discussions/23504 .
2023-05-12 14:57:56 +09:00
tsrk
2d45d602a5
feat(settings): more keyword for first run setup
2023-05-11 15:03:42 +01:00
tsrk
c1a85658b7
feat(settings): add "import" as keywords for first run setup
2023-05-11 14:58:17 +01:00
Cootz
ca68850730
fix formatting
2023-05-10 19:43:58 +03:00
Cootz
2467813d81
Block deselect all short key when using the search box
2023-05-09 16:14:42 +03:00
Bartłomiej Dach
2177dbf42a
Merge pull request #23436 from peppy/fix-wiki-error-return-to-main
...
Fix "Return to main page" link not working on wiki after error
2023-05-08 21:56:29 +02:00
Dan Balasescu
d2380bd840
Remove usages of [ExcludeFromDynamicCompile]
2023-05-08 18:12:56 +09:00
Dean Herbert
715b735131
Fix "Return to main page" link not working on wiki after error
2023-05-08 15:29:05 +09:00
Cootz
60bad35145
Remove weird update usage when 'deselect all' pressed
2023-05-07 15:34:01 +03:00
Cootz
4d235105d1
Convert ModSearchContainer to block-scoped namespace
2023-05-07 15:14:49 +03:00
Bartłomiej Dach
65b4b198a4
Merge branch 'master' into export
2023-05-06 20:12:53 +02:00
Bartłomiej Dach
3942281d13
Fix back-to-front logic
2023-05-06 15:34:55 +02:00
Bartłomiej Dach
80ac8abaa6
Merge branch 'master' into chat-report
2023-05-06 15:30:44 +02:00
Bartłomiej Dach
1da5e69d5a
Fix API success callback scheduling to dead drawable
2023-05-06 15:27:27 +02:00
Bartłomiej Dach
6b4050ea52
Remove invalid report reason (and add osu-web references)
2023-05-06 15:01:57 +02:00
Bartłomiej Dach
52e5835be6
Document and retouch ReportPopover
2023-05-06 14:52:38 +02:00
Cootz
cbb9f0100e
Update PopIn and PopOut filtering. Expose SearchTerm
2023-05-06 11:27:06 +03:00
Cootz
a226caff56
Fix testing
2023-05-06 11:09:44 +03:00
Cootz
7422b5285c
Fix wrong filtering in testing
2023-05-05 22:41:30 +03:00
Cootz
ab94b4dce1
Update ModPresetPanel.FilterTerms to account mod names and acronyms
2023-05-05 09:52:09 +03:00
Cootz
54757df51f
Fix mod deselect button not working properly when search applied
2023-05-05 09:31:27 +03:00
Dean Herbert
8391e2a538
Move reporting code out of DrawableChatUsername into more correct locations
2023-05-05 14:03:42 +09:00
Bartłomiej Dach
bdd96caaa9
Merge branch 'master' into edit-mods-preset
2023-05-04 18:59:47 +02:00
Cootz
1ac9d900e1
Clear search on ModSelectOverlay.Hide
2023-05-04 19:24:37 +03:00
Dean Herbert
0034124d79
Remove unnecessary content clear
2023-05-04 11:25:10 +09:00
Dean Herbert
26b8c5b852
Fix mod list display not updating after clicking "use current"
...
This is not a regression from my changes. It was broken before them.
2023-05-04 11:23:51 +09:00
Dean Herbert
49fb5da1a2
Stop passing preset panel to popover
2023-05-04 11:19:09 +09:00
Dean Herbert
b12d139317
Remove dead code
2023-05-04 11:16:52 +09:00
Dean Herbert
99d2616c34
Move drawable construction to load for simplicity
2023-05-04 11:14:51 +09:00
Dean Herbert
be995f1359
Add localisation support for new button string
2023-05-04 11:11:19 +09:00
Dean Herbert
b7abab6d8a
More variable improvements
2023-05-04 11:10:05 +09:00
Dean Herbert
0a584f0652
Simplify check logic and improve variable naming
2023-05-04 11:07:09 +09:00
Bartłomiej Dach
59ece64d25
Merge branch 'master' into skin-editor-change-handler-improvement
2023-05-03 19:42:42 +02:00
Bartłomiej Dach
1d4d31e35c
Trim comments
...
Leaving only the ones that add anything useful and do not restate the
code verbatim.
2023-05-03 19:22:52 +02:00
Bartłomiej Dach
27fabd99fb
Rename variables for legibility
...
Having `typedComponents` and `typeComponents` next to each other is
asking for trouble.
2023-05-03 19:21:16 +02:00
cdwcgt
4549a865d9
Merge branch 'master' into export
2023-05-04 00:18:01 +09:00
cdwcgt
967e801f9c
code inspect
2023-05-03 23:26:58 +09:00
cdwcgt
debbd376bd
move scrollContent update logic to updateActiveState()
2023-05-03 23:24:14 +09:00
cdwcgt
f4b1264cc9
use button Enable status to ensure preset name is not null
2023-05-03 23:22:46 +09:00
cdwcgt
aa5a026c67
remove local button handle
2023-05-03 23:14:24 +09:00
cdwcgt
c609e6345c
remove Use Current Mods menu item
2023-05-03 23:02:50 +09:00
Cootz
152d2678d5
Fix ModSelectColumn completely disappear from ModSelectOverlay
2023-05-03 14:00:46 +03:00
Dean Herbert
be15d07b17
Tidy up various implementation details
2023-05-03 18:59:39 +09:00
Dean Herbert
b932e4d986
Rename DrawableUsername to DrawableChatUsername and only pass message ID
2023-05-03 18:53:22 +09:00
Dean Herbert
4f55afb60d
Merge branch 'master' into chat-report
2023-05-03 18:50:38 +09:00
Joseph Madamba
1c74f6e8ea
Fix regressed button hover fade in
2023-05-02 22:54:42 -07:00
Joseph Madamba
bede1292de
Fix overlay scroll back button not absorbing hover from behind
2023-05-02 22:40:37 -07:00
Dean Herbert
e394b487e0
Merge branch 'master' into edit-mods-preset
2023-05-03 12:06:16 +09:00
Cootz
a6ca049739
Manually implement @bdach prototype
2023-05-02 14:15:33 +03:00
Dean Herbert
4a97c2c105
Merge pull request #23038 from cdwcgt/scale-background-dim
...
Add feature to adjust `ScalingContainer` background dim
2023-05-02 15:36:52 +09:00
Dean Herbert
ce4a6c38a0
Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight
...
Fix now playing playlist not highlighting selected item on initial open
2023-05-02 15:36:34 +09:00
Dean Herbert
ab4f66fad3
Minor readability refactors
2023-05-02 14:31:39 +09:00
Dean Herbert
7a840e1d82
Remove unnecessary TransferValue spec
2023-05-02 14:29:26 +09:00
Dean Herbert
7efaa299bd
Merge branch 'master' into scale-background-dim
2023-05-02 14:24:54 +09:00
Dean Herbert
736be6a73b
Refactor slightly for readability
2023-05-02 14:11:16 +09:00
Dean Herbert
e808e7316b
Mark delegate value unused and add comment to avoid future regression
2023-05-02 13:29:30 +09:00
Terochi
4d52ce769b
Revert SaveState() calling on initialization
2023-05-01 12:53:58 +02:00
Bartłomiej Dach
7cedbca9be
Merge branch 'master' into multiplier-doesnt-update-with-preset-mod
2023-04-30 17:36:00 +02:00
Bartłomiej Dach
2e3daf0a54
Fix leak of ModSettingChangeTracker instances
...
The `SelectedMods.BindValueChanged()` callback in `ModSelectOverlay` can
in some instances run recursively. This is most heavily leaned on in
scenarios where `SelectedMods` is updated by an external component. In
such cases, the mod select overlay needs to replace the mod instances
received externally with mod instances which it owns, so that the changes
made on the overlay can propagate outwards.
This in particular means that prior to this commit, it was possible to
encounter the following scenario:
modSettingChangeTracker?.Dispose();
updateFromExternalSelection(); // mutates SelectedMods to perform the replacement
// therefore causing a recursive call
modSettingChangeTracker?.Dispose();
// inner call continues
modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);
// outer call continues
modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);
This leaks one `modSettingChangeTracker` instance from the inner call,
which is never disposed.
To avoid this, move the disposal to the same side of the recursion that
the creation happens on, changing the call pattern to:
updateFromExternalSelection(); // mutates SelectedMods to perform the replacement
// therefore causing a recursive call
modSettingChangeTracker?.Dispose();
// inner call continues
modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);
modSettingChangeTracker?.Dispose();
// outer call continues
modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);
which, while slightly wasteful, does not cause any leaks.
The solution is definitely suboptimal, but addressing this properly
would entail a major rewrite of the mod instance management in the mods
overlay, which is probably not the wisest move to make right now.
2023-04-30 17:31:41 +02:00
Terochi
fb4b681cc5
Use Queue instead of Stack
2023-04-30 16:36:01 +02:00
Terochi
8f02bd80f9
Addressed changes
2023-04-30 16:11:52 +02:00
Terochi
949dc1c0f9
Improved logic
2023-04-30 12:05:55 +02:00
Terochi
8ec2154965
Fixed ApplyStateChange to happen in correct order
2023-04-30 02:01:18 +02:00
Terochi
17e4b75dfd
Save first state when editing
2023-04-29 20:54:19 +02:00
Terochi
3b0ba4b38b
Improved logic for ApplyStateChange for skin editor
2023-04-29 19:52:22 +02:00
Bartłomiej Dach
646d4965b9
Merge branch 'master' into fix-exclusive-fullscreen-detection
2023-04-29 14:39:34 +02:00
_ltn
2d6c0d2900
use of Child instead of Children
2023-04-28 19:24:07 +03:00
Dean Herbert
6929be49b7
Change condition for exclusive fullscreen notice to only show when using the correct renderer
...
This avoids the notice showing when running on windows, but using the
newer renderers (where the underlying logic hasn't been tested properly
and can result in false-positives).
Supersedes https://github.com/ppy/osu-framework/pull/5759 as a more
correct implementation.
2023-04-28 22:36:30 +09:00
Ethan
ae85e2a3ff
Update LoginForm.cs
2023-04-28 19:51:10 +08:00
_ltn
4b0ee392f6
add OsuHoverContainer
2023-04-28 05:48:54 +03:00
_ltn
17730f05bc
remove UpdateableCountryText
2023-04-28 05:47:05 +03:00
_ltn
4d144cd5b5
clearing the code
2023-04-28 02:06:13 +03:00
_ltn
092377fdaa
moving UpdateableCountryText
2023-04-28 01:47:14 +03:00
_ltn
e9843f2066
replace country text object
2023-04-28 01:16:50 +03:00
Cootz
b795e8ac5a
Use ModSearch in ModeSelectOverlay
2023-04-27 17:26:35 +03:00
Cootz
3c6141f233
Add ModSearch
2023-04-27 17:08:29 +03:00
Hy0tic
56ab029a58
fix issue where multipler does not update when adjusting speed for preset mod
2023-04-22 13:30:08 -04:00
Joseph Madamba
776c4cfaad
Ensure selected field is correct in updateSelectionState()
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-04-19 18:34:35 -07:00
Dean Herbert
52c4703261
Merge pull request #23103 from Joehuu/normalise-overlay-padding
...
Normalise horizontal padding on overlays
2023-04-10 23:48:59 +09:00
Bartłomiej Dach
1f2c96c8e8
Merge branch 'master' into gd-onlinesetoverlay
2023-04-10 15:35:03 +02:00
Bartłomiej Dach
11fd93a2ba
Inline disturbing getGuestMapper() method
...
Disturbing because name suggests pure method, but it is in fact `void`
and also performs side effects by about the most confusing means
possible.
2023-04-10 15:20:43 +02:00
cdwcgt
ce6a87b4a3
Merge remote-tracking branch 'upstream/master' into export
2023-04-09 15:02:47 +09:00
cdwcgt
de21b4a2f7
use Live<TModel>
...
Use RealmAccess only when needed
2023-04-09 22:21:15 +09:00
Joseph Madamba
a86a968fac
Use public BeatmapSet to match other usages
2023-04-07 21:16:36 -07:00
Joseph Madamba
ed208ef127
Fix more typos and adjust font size to match web
2023-04-07 21:10:37 -07:00
Bartłomiej Dach
b5d9284de2
Merge pull request #23108 from peppy/fix-overlay-toggles-during-disclaimer
...
Fix attempting to show overlay during game intro playing hide sound effects
2023-04-03 20:48:03 +02:00
cdwcgt
9dd30e4b4c
condition fix
2023-04-03 20:24:38 +09:00
cdwcgt
735b48679e
use LinkFlowContainer directly
2023-04-03 20:09:49 +09:00
cdwcgt
41c01d3929
nullable condition
2023-04-03 20:07:21 +09:00
cdwcgt
51240ed46b
typo
2023-04-03 19:51:22 +09:00
Dean Herbert
43d7386623
Merge pull request #22926 from Joehuu/fix-sort-direction-not-resetting
...
Fix beatmap listing sort direction not resetting when changing criteria
2023-04-03 15:32:10 +09:00
Dean Herbert
e4eb736622
Merge pull request #22929 from Joehuu/fix-loading-blocking-overlay-headers
...
Fix beatmap listing filter control being blocked by loading layer
2023-04-03 15:29:38 +09:00
Dean Herbert
a097433cb1
Fix overlay toggle keys working during disabled activation modes
...
Closes #23104 .
2023-04-03 15:03:47 +09:00
Joseph Madamba
247d426c8a
Add horizontal padding to currently playing search textbox
2023-04-02 20:50:18 -07:00
Joseph Madamba
436f1e4ae4
Replace other hardcoded horizontal padding with const
...
- Also add overlay stream item padding const and account for it
2023-04-02 20:50:18 -07:00
Joseph Madamba
af389b1107
Replace all hardcoded 50 horizontal padding with const
2023-04-02 20:50:18 -07:00
Joseph Madamba
7a0edabd5d
Normalise overlay horizontal padding const
2023-04-02 20:24:13 -07:00
Joseph Madamba
63ea17f10e
Update comment vote pill in line with web
2023-04-02 18:17:40 -07:00
Susko3
c3a6a58169
Fix window mode dropdown not showing
2023-04-02 19:23:18 +02:00
cdwcgt
d949ef3ca4
make guestMapperContainer private
...
tests don't use it
2023-04-02 22:53:15 +09:00
cdwcgt
2cf8636366
show guest diff author in BeatmapPicker
2023-04-02 22:25:58 +09:00
Dean Herbert
4c2b7e7788
Fix random inspection showing up only in CI
2023-04-02 21:05:20 +09:00
Dean Herbert
cf5acbf66e
Update usage of SupportedWindowModes
2023-04-02 20:16:14 +09:00
cdwcgt
5d395e6d37
move to ctor
2023-03-29 22:59:54 +09:00
cdwcgt
e85c28031e
change weird name
2023-03-29 22:55:25 +09:00
cdwcgt
46ede27869
add feature to adjust ScalingContainer background dim
2023-03-28 22:41:24 +09:00
cdwcgt
31df626f0e
disable button when select other reason
2023-03-28 21:32:28 +09:00
cdwcgt
899860dd77
Merge branch 'master' into chat-report
2023-03-28 21:14:11 +09:00
Dean Herbert
8c1df3c8d9
Fix web account registration not bypassing the URL warning
2023-03-28 15:38:19 +09:00
cdwcgt
b065689cf8
Limit the area of popover to DrawableChannel
...
popover may be blocked by textBar
2023-03-27 23:04:45 +09:00
Dean Herbert
898717231b
Hide vulkan renderer option for now
...
We'll bring it back when it's more stable.
2023-03-27 02:00:10 +09:00
Bartłomiej Dach
292486c25a
Use more resilient restore method
2023-03-26 14:35:00 +02:00
Bartłomiej Dach
f3c174a7f2
Fix test errors due to missing dependencies
2023-03-26 13:52:26 +02:00
Dean Herbert
bab93bed17
Fix string interpolation and use GetDescription on renderer value
2023-03-26 20:43:28 +09:00
Dean Herbert
ba078e8357
Show "automatic" resolved renderer inline in dropdown instead
2023-03-26 20:29:30 +09:00
Dean Herbert
764361b3d3
Add special case to hide definitely non-working renderers on android
2023-03-26 20:14:33 +09:00
Dean Herbert
e346b02ebf
Add display of current renderer
2023-03-26 20:09:35 +09:00
Joseph Madamba
eaef5ff2a3
Fix now playing playlist not highlighting selected item on initial open
2023-03-25 22:13:51 -07:00
Joseph Madamba
450c5cef07
Add comment explaining loading container padding
2023-03-24 18:42:34 -07:00
Dean Herbert
ab6cfea5c7
Revert old value instead of always using default
...
Co-authored-by: cdwcgt <loginchen@outlook.com>
2023-03-23 11:27:05 +09:00
cdwcgt
85a924f078
why
...
merge problem?
2023-03-23 01:02:17 +09:00
cdwcgt
8518d15b8d
use endpoint
2023-03-23 01:00:38 +09:00
Dean Herbert
3050a16bf8
Don't require a restart when selecting Automatic and startup setting was also automatic
2023-03-22 16:56:36 +09:00
Dean Herbert
aabe86dc26
Limit renderers to those available for the current platform
2023-03-22 16:49:29 +09:00
Dean Herbert
956fabb445
Show restart notice when changing renderer
2023-03-22 16:49:29 +09:00
Dean Herbert
13be709718
Add basic renderer selection
2023-03-22 16:49:29 +09:00
Dean Herbert
db227b1798
Merge branch 'master' into chat-report
2023-03-22 16:26:28 +09:00
Joseph Madamba
6f3bb85eaa
Always show down arrow on inactive sort buttons
2023-03-22 00:19:23 -07:00
Joseph Madamba
d9571b6fc9
Move filter control property setters to load()
2023-03-21 21:31:35 -07:00
Joseph Madamba
74a15d7424
Fix overlay headers being blocked by loading layer
2023-03-21 20:32:26 -07:00
Joseph Madamba
e1fb63e1f3
Move beatmap listing filter control to header
2023-03-21 20:32:26 -07:00
Joseph Madamba
3cd01ee621
Fix beatmap listing sort direction not resetting when changing criteria
2023-03-21 15:08:37 -07:00
Joseph Madamba
df3ccdff9f
Add failing beatmap listing sort direction on criteria change test
2023-03-21 15:08:37 -07:00
Bartłomiej Dach
9ff9cd3b7f
Merge branch 'master' into skin-editor-cyclic-selection
2023-03-21 19:49:55 +01:00
Joseph Madamba
970df5d88a
Update profile kudosu section in line with web
2023-03-18 19:49:30 -07:00
cdwcgt
d025c441ca
delay mod save after click save or not popover hidden
2023-03-16 19:48:45 +09:00
cdwcgt
42bcc8bafc
revert mod store
2023-03-16 19:38:15 +09:00
Dean Herbert
f8e773ab8e
Merge branch 'master' into fix-overlay-sidebar-scroll
2023-03-15 15:30:50 +09:00
Dean Herbert
6546f5968a
Merge branch 'master' into skin-editor-cyclic-selection
2023-03-14 20:43:56 +09:00
Joseph Madamba
6e5b1280b7
Fix multiple notice boxes having no spacing
2023-03-11 21:36:29 -08:00
Joseph Madamba
ea88aee41f
Display stub notice in marked wiki articles
2023-03-11 21:36:28 -08:00
Joseph Madamba
0cf69a1084
Make yaml line strings verbatim
2023-03-11 21:36:23 -08:00
cdwcgt
15f11bb1e8
scorll container and save mod after popover hidden
...
Requires manual handling of many visual effects
2023-03-11 12:31:33 +09:00
cdwcgt
1cd565193e
public CheckCurrentModCanBeSave
2023-03-11 11:39:35 +09:00
cdwcgt
8b0f127ff2
split ModPresetRow
2023-03-11 11:25:52 +09:00
cdwcgt
f4e2620402
fix test
2023-03-10 00:56:22 +09:00
cdwcgt
ca416175bb
remove useless property
2023-03-09 22:58:44 +09:00
cdwcgt
3d746e8dfb
content Menu
2023-03-09 22:49:33 +09:00
cdwcgt
5a1316f0e5
split save logic
2023-03-09 22:43:06 +09:00
Bartłomiej Dach
5213bfa5c9
Merge branch 'master' into make_skin_reset_dangerous
2023-03-07 21:06:44 +01:00
Bartłomiej Dach
cfafa8af8c
Merge branch 'master' into hud/player-components
2023-03-07 19:44:12 +01:00
Bartłomiej Dach
7ade525eef
Display corner radius setting as percentage
2023-03-07 19:43:52 +01:00
cdwcgt
54564e0557
new design
2023-03-07 21:13:35 +09:00
Dean Herbert
97bee4db89
Fix localisations
2023-03-07 18:07:53 +09:00
Dean Herbert
26ef7c2637
Rename confirmation dialog class to mention revert not reset
2023-03-07 18:07:46 +09:00
Dean Herbert
55467fcbe3
Update xmldoc for DangerousActionDialog to match new behaviour
2023-03-07 18:07:46 +09:00
Dean Herbert
21bdbb20e6
Add optional support for cyclic selection to BlueprintContainer
2023-03-07 14:22:12 +09:00
cdwcgt
4858d3fd42
Added ability to edit mod presets
2023-03-07 02:00:40 +09:00
mk56-spn
908651cc11
make ResetConfirmDialog properly utilise its parent's logic
...
Adjust name of `DeleteAction` to `DangerousAction`
2023-03-05 20:57:26 +01:00
Bartłomiej Dach
60cdd3c070
Clear components sidebar unconditionally on every target change
...
Fixes the working layer dropdown lingering after exiting from a
skinnable screen to a non-skinnable one.
2023-03-04 14:10:05 +01:00
Bartłomiej Dach
d233f3a3ab
Show non-skinnable screen placeholder at higher level
2023-03-04 13:49:10 +01:00
Bartłomiej Dach
49e298e304
Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer
...
An end result of #22674 is that `SkinBlueprintContainer`s are only ever
created by supplying a `SkinComponentsContainer` to them. However,
`SkinBlueprintContainer` still contained remnants of code that suggested
it was designed to handle cases where more than the drawable supplied to
it contained more than one `ISerialisableDrawableContainer`, or even
zero.
The zero path is totally dead right now (because every
`SkinComponentsContainer` is *by necessity* an
`ISerialisableDrawableContainer`), and the more-than-one path is dead
*for now* (and potentially forever?). Therefore, just hard-couple
`SkinBlueprintContainer` to receive a single target container.
2023-03-04 13:33:21 +01:00
Bartłomiej Dach
2f25fb4083
Move NonSkinnableScreenPlaceholder to outer scope
2023-03-04 13:22:43 +01:00
Bartłomiej Dach
15409b9c15
Fix skin selection not clearing on exit to non-skinnable screen
2023-03-04 13:18:34 +01:00
mk56-spn
2b7111867c
Adjust reversion header text naming.
2023-03-03 15:12:20 +01:00
Joseph Madamba
af540de69b
Fix "talking with" text overflowing when usernames are too long
2023-03-01 22:10:15 -08:00
Joseph Madamba
bb5791a714
Fix overlay sidebars not scrolling to end due to parent scroll view
2023-03-01 21:41:01 -08:00
Dean Herbert
bd11d5d29a
Merge pull request #22743 from Joehuu/scroll-back-to-previous
...
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
mk56-spn
90227a6496
Rename DeleteConfirmationDialog.cs into DangerousActionDialog.cs
2023-02-27 21:57:59 +01:00
mk56-spn
00a00ead22
Make ResetConfirmDialog inherit from DeleteConfirmationDialog
2023-02-27 21:50:27 +01:00
mk56-spn
1239de6f41
Upper case web using alias
2023-02-27 21:34:07 +01:00
mk56-spn
bf1897a98f
Adjust warning text slightly.
2023-02-27 16:08:14 +01:00
Joseph Madamba
fa710ae1b0
Rename ScrollToTopButton to ScrollBackButton
2023-02-26 14:39:34 -08:00
Joseph Madamba
dc00905f8d
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-02-26 14:38:51 -08:00
mk56-spn
ff0d1aa9f7
Make reverting changes to a given skin into a "dangerous action"
2023-02-26 20:38:50 +01:00
Dean Herbert
dc3c1150b8
Set better defaults for SkinBlueprint transforms
2023-02-23 21:10:15 +09:00
Dean Herbert
c48aceb055
Fix undo history not being batched correctly for depth change operations
2023-02-23 20:03:36 +09:00
Dean Herbert
16c8a392a1
Add ability to send selected skin components to front or back
2023-02-22 18:17:20 +09:00
Bartłomiej Dach
051eb18b33
Merge branch 'master' into skin-editor-layer-select
2023-02-21 21:38:51 +01:00
Bartłomiej Dach
ec1bf7b0b2
Merge branch 'master' into skin-editor-clipboard
2023-02-21 19:35:58 +01:00
Dean Herbert
af062e7a68
Change placeComponent to only add to selection, not clear an existing selection
2023-02-21 14:11:18 +09:00
Dean Herbert
0d229d959b
Remove unnecessary TriggerChange call
2023-02-21 13:50:19 +09:00
Bartłomiej Dach
6799492596
Merge branch 'master' into skin-editor-layer-select
2023-02-20 21:33:48 +01:00
Dean Herbert
6382314af1
Merge pull request #22697 from ggliv/tablet-area-drag
...
Allow tablet area to be dragged
2023-02-20 23:37:25 +09:00
Dean Herbert
43d33d45ca
Only add valid placed components to selected collection on paste
2023-02-20 20:02:43 +09:00
Dean Herbert
b68562b033
Make placeComponent resilient to missing dependencies
2023-02-20 20:00:12 +09:00
Dean Herbert
a9c7edd087
Remove copy pasted comment
2023-02-20 19:57:16 +09:00
Dean Herbert
7a585e1fa1
Merge pull request #22669 from EVAST9919/mod-overlay-triangles
...
Add triangles animation to mod select overlay headers
2023-02-20 19:54:21 +09:00
Gabe Livengood
c86c1a9029
allow tablet area to be dragged
2023-02-20 00:06:20 -05:00
Bartłomiej Dach
1ba1298850
Merge branch 'master' into blueprint-improve-visuals
2023-02-19 15:55:30 +01:00
Dean Herbert
d7381b762c
Also tween origin position
2023-02-19 23:52:21 +09:00
Bartłomiej Dach
ea04c487f2
Merge branch 'master' into blueprint-labels-while-hovering
2023-02-18 15:57:30 +01:00
Bartłomiej Dach
15d209d17e
Merge branch 'master' into CompletionText-LocalisableString
2023-02-18 13:50:58 +01:00
Bartłomiej Dach
fbea3e312f
Merge branch 'master' into skin-editor-improve-toolbox-hover
2023-02-18 10:02:02 +01:00
Bartłomiej Dach
2aa4481f68
Fix toolbox items spontaneously contracting after briefly losing hover
...
Reproduction scenario:
1. Hover a toolbox item
2. Unhover the item, but do not hover any other item (can be done by
exiting the toolbox completely to the right)
3. Come back to the item hovered in step (1)
4. The item would spontaneously contract after a second
2023-02-17 22:54:11 +01:00
Bartłomiej Dach
b390fdb8cc
Remove unused field
2023-02-17 21:51:19 +01:00
Andrei Zavatski
ffcca9fd89
Remove awkward width specification
2023-02-17 23:23:58 +03:00
cdwcgt
dbb366e279
CompletionText can be a LocalisableString
...
I can't find a reason for not doing this, probably this was forgotten in https://github.com/ppy/osu/pull/15440
2023-02-17 22:32:03 +09:00
cdwcgt
e84e011d5d
Merge branch 'master' into export
2023-02-17 22:15:19 +09:00
Andrei Zavatski
51940133df
Adjust width and add comment
2023-02-17 15:18:45 +03:00
Andrei Zavatski
0838fa636f
Make triangles slower
2023-02-17 15:16:00 +03:00
Dean Herbert
0a018514e1
Make skin editor focus only one layer at a time
2023-02-17 19:27:16 +09:00
Dean Herbert
00fcee0c5a
Add per-ruleset component toolbox and placement support
2023-02-17 19:27:16 +09:00
Dean Herbert
ba5a87ca04
Add basic target layer selection in skin editor
2023-02-17 19:27:16 +09:00
Dean Herbert
5ed038fbb3
Improve the feel of hovering toolbox component items
2023-02-17 19:26:03 +09:00
Dean Herbert
814080d982
Only show blueprint labels when hovering or selected
2023-02-17 19:23:52 +09:00
Dean Herbert
6c61c5f4a8
Fix selection on the edge of blueprints (in the new inflation area) failing
2023-02-17 18:19:46 +09:00
Dean Herbert
16d94b4ea2
Improve visuals of skin blueprint
2023-02-17 18:19:46 +09:00
Andrei Zavatski
a84f20bf32
Add triangles to ModSelectColumn
2023-02-17 03:09:32 +03:00
Dean Herbert
925deb7ca5
Make skin editor clipboard shared between screens and skins to allow moving elements over
2023-02-15 19:35:37 +09:00
Dean Herbert
bc83b0c264
Fix clipboard changes not batching as undo steps
2023-02-15 19:35:22 +09:00
Dean Herbert
bcf2555545
Fix components having incorrect default positions
2023-02-15 19:34:42 +09:00
Dean Herbert
d653335b6f
Add basic skin editor clipboard implementation
2023-02-15 19:28:42 +09:00
Dean Herbert
a92e42bb84
Rename SkinnableTargetContainer to SkinComponentsContainer
...
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
Dean Herbert
b1cf6d83d8
Move extension methods closer to serialisation classes
2023-02-15 18:37:41 +09:00
Dean Herbert
e61d2d571c
Move the lookup type out of ISserialisableDrawableContainer
2023-02-15 18:37:41 +09:00
Dean Herbert
a7b47f6503
Rename ISkinnableTarget to ISerialisableDrawableContainer
2023-02-15 18:37:41 +09:00
Dean Herbert
d159d6b970
Rename ISkinnableDrawable to ISerialisableDrawable
2023-02-15 18:37:41 +09:00
Dean Herbert
856efd9fd9
Rename SkinnableDrawableInfo to SerialisedDrawableInfo
2023-02-15 18:23:19 +09:00
Dean Herbert
9e651a7ca2
Rename SkinnableInfo to SkinnableDrawableInfo
2023-02-15 18:23:17 +09:00
Dean Herbert
6010dde86e
Move SkinnableInfo to better namespace
2023-02-15 18:23:10 +09:00
Dean Herbert
679df9bf8b
Merge pull request #22604 from Joehuu/abort-dangerous-dialog-button-on-hover-lost
...
Add ability to abort dangerous dialog button on hover lost
2023-02-13 20:40:14 +09:00
Joseph Madamba
8d9245c1d4
Make AbortConfirm() virtual and override with filter logic
2023-02-11 12:54:16 -08:00
Joseph Madamba
94d6ab1ec7
Continue confirming when rehovering if mouse is still down
2023-02-10 19:09:30 -08:00
Joseph Madamba
bfd83768c1
Fix skin component previews on toolbox buttons having incorrect size for one frame
2023-02-10 17:58:34 -08:00
Joseph Madamba
d30d054b4c
Add ability to abort dangerous dialog button on hover lost
2023-02-10 14:41:44 -08:00
Dean Herbert
28897b6e18
Merge pull request #22566 from Joehuu/profile-tournament-banner
...
Display tournament banner on user profile
2023-02-09 16:06:36 +09:00
Joseph Madamba
f1decb667e
Address todos relating to init-only usages
2023-02-08 17:51:28 -08:00
Joseph Madamba
3b5d573db1
Display tournament banner on user profile
2023-02-08 17:16:09 -08:00
Bartłomiej Dach
0a5c4e04bf
Merge branch 'master' into skin-editor-undo-support
2023-02-08 18:43:59 +01:00
Joseph Madamba
0156ff732f
Fix beatmap cards not showing context menu on user profile
2023-02-07 22:56:09 -08:00
Dean Herbert
17ca26ebee
Remove unnecessary null check on targetScreen
2023-02-08 15:44:24 +09:00
Dean Herbert
3a3c2e78a1
Merge branch 'master' into skin-editor-undo-support
2023-02-08 15:41:58 +09:00
Dean Herbert
78eae171ed
Merge pull request #22507 from Joehuu/fix-comment-padding
...
Fix comments having too much padding at the bottom
2023-02-08 15:01:05 +09:00
Dean Herbert
b6809e156b
Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii
...
Implement a sheared slider for the updated design
2023-02-08 15:01:00 +09:00
Joseph Madamba
277f71d36a
Expire reply editor instead of clearing container
2023-02-07 15:15:51 -08:00
Dean Herbert
0320ba770f
Handle component changes via ISkinnableTarget.Components rather than inside SkinEditor directly
...
Seems saner? Maybe?
2023-02-07 16:23:25 +09:00
Dean Herbert
dad348111d
Fix holding a selection while changing screens causing a crash
2023-02-07 16:07:33 +09:00
Dean Herbert
71eef238c4
Make OnStateChange non-implemented rather than wrong
2023-02-07 16:04:31 +09:00
Bartłomiej Dach
179db09075
Merge pull request #22531 from peppy/apply-future-rider-inspection
...
Apply single inspection from newer inspectcode versions
2023-02-06 20:05:49 +01:00
Dean Herbert
c691a0d3af
Merge branch 'master' into sheared_slider_implementation_clean_ii
2023-02-06 17:49:33 +09:00
Dean Herbert
c078d3a344
Merge pull request #22357 from EXtremeExploit/groups-probationary-badges
...
Make probationary groups a bit transparent
2023-02-06 17:43:57 +09:00
Dean Herbert
4c868372a2
Correctly handle anchor/origin changes as undo states
2023-02-06 15:05:05 +09:00
Dean Herbert
7445814fc6
Handle changes to SettingSource skin element settings
2023-02-06 14:42:59 +09:00
Dean Herbert
701d21c26f
Apply single inspection from newer inspectcode verisons
...
As found in rider EAPs. Appears as a warning and is annoying me
occasionally.
2023-02-06 13:52:27 +09:00
Dean Herbert
10ab4d572a
Merge branch 'master' into skin-editor-undo-support
2023-02-06 13:46:50 +09:00
Joseph Madamba
cb8458cceb
Use linq and alpha instead
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-04 20:11:29 -08:00
Joseph Madamba
4192388b20
Fix expanded beatmap cards getting cut off at the end of profile sections
2023-02-03 21:29:01 -08:00
Bartłomiej Dach
4bd43171e8
Merge branch 'master' into fix-skin-editor-padding-weirdness
2023-02-03 20:28:47 +01:00
Bartłomiej Dach
59656a7286
Merge branch 'master' into skin-editor-dont-show-save-on-no-change
2023-02-03 19:08:33 +01:00
EXtremeExploit
f9809c9481
the comment
2023-02-03 11:48:11 -03:00
Joseph Madamba
461b5c5375
Fix comment cancel button not behaving the same as reply text toggle
...
- Removed the fading animation as it is awkward right now (needs resizing)
2023-02-03 02:04:19 -08:00
Dean Herbert
2cda277c09
Add a basic change handler to the skin editor
2023-02-03 18:57:50 +09:00
Joseph Madamba
94d2799b90
Fix comments having too much padding at the bottom
2023-02-03 00:47:10 -08:00
Dean Herbert
b19047b90b
Fix skin editor component list having uneven padding
2023-02-03 16:55:51 +09:00
Dean Herbert
32207dc9dd
Merge branch 'master' into locale/skin-editor-components
2023-02-03 15:24:00 +09:00
Dean Herbert
5ca5f04794
Add parameter hint for optional bool value
2023-02-03 15:18:40 +09:00
Bartłomiej Dach
e937022b09
Merge branch 'master' into middle-click-replay-pause
2023-02-02 20:52:03 +01:00
Bartłomiej Dach
4d46a8f32d
Merge branch 'master' into skin-editor-dont-show-save-on-no-change
2023-02-02 19:36:23 +01:00
Bartłomiej Dach
f7fa9e3927
Remove outdated comment
2023-02-02 18:41:35 +01:00
mk56-spn
3f0ce75bf5
Rename NormalSliderBar.cs to RoundedSliderBar.cs
2023-02-02 17:24:45 +01:00
Dean Herbert
015f4f2b38
Avoid showing skin save message when changing scenes after making no changes
2023-02-02 18:42:37 +09:00
Dean Herbert
9b6d95b3d6
Adjust skin editor pop in/out to be more snappy
2023-02-02 18:33:45 +09:00
Dean Herbert
26efb8e842
Replace white box legacy placeholder with something that visually fits
2023-02-02 18:33:31 +09:00
Dean Herbert
659b78058f
Move replay specific key bindings to their own section
2023-02-02 15:25:52 +09:00
Dean Herbert
8dc2e6872e
Move skin editor to overlays namespace
2023-02-02 14:00:31 +09:00
Dean Herbert
d54db8de64
Merge branch 'master' into fix-clicking-metadata-relevance-sort
2023-02-01 19:39:13 +09:00
Dean Herbert
524aa9162d
Store search parameters as tuple
2023-02-01 19:38:47 +09:00
Joseph Madamba
1a152452f1
Fix incorrect naming of badge header container
2023-01-31 15:16:29 -08:00
Joseph Madamba
0366a8e348
Only call Reset() if lastCategory and lastHasQuery is null
2023-01-31 12:44:44 -08:00
Dean Herbert
5d22f3d879
Improve inline comment
2023-01-31 17:17:21 +09:00
Cootz
b18652b25f
CreateSubDirectory removed. Fixes the empty root issue
2023-01-31 10:14:21 +03:00
Cootz
54d5d4e7c6
Fix for the issue
2023-01-31 07:06:26 +03:00
Joseph Madamba
610d2f9dc7
Fix beatmap listing potentially not sorting by relevance when searching via metadata
2023-01-28 12:14:35 -08:00
mk56-spn
091cc155d3
Fix nub naming in OsuCheckbox.cs and associated classes
2023-01-26 16:10:02 +01:00
EXtremeExploit
1de0bed83d
fix comment
2023-01-26 11:09:16 -03:00
mk56-spn
374c3b56f6
Rename Nub.cs to NormalNub.cs
2023-01-26 15:03:11 +01:00
mk56-spn
3988131475
Rename OsuSliderBar.cs as NormalSliderBar.cs
2023-01-26 12:12:56 +01:00
EXtremeExploit
0eaebfd40a
Use Alpha instead of opacity on bg color
2023-01-25 10:22:42 -03:00
Dean Herbert
5c888e0c68
Merge branch 'master' into beatmapSelectionBlur
2023-01-25 16:37:19 +09:00
Dean Herbert
01e280eb6b
Add classic default for song select blur setting
2023-01-25 16:32:00 +09:00
Dean Herbert
e333e12b2e
Fix typo in settings enum (seriously)
2023-01-25 16:32:00 +09:00
Dean Herbert
3faab66f39
Merge branch 'master' into beatmapSelectionBlur
2023-01-25 16:32:00 +09:00
Dean Herbert
6bf7773532
Increase duration of expansion transition
2023-01-25 14:28:25 +09:00
Dean Herbert
3e91dd2a16
Update spacing along with expanded state
2023-01-25 14:28:25 +09:00
Bartłomiej Dach
f2df36e6a5
Persist cover visibility to user settings
...
Follows web precedent, wherein the setting is saved to local storage.
2023-01-24 23:30:12 +01:00
Bartłomiej Dach
33e91cf512
Implement cover toggling
2023-01-24 23:06:49 +01:00
Bartłomiej Dach
e74176e5bd
Add cover toggle button
2023-01-24 23:06:46 +01:00
Bartłomiej Dach
ef7812412b
Update top header container appearance
2023-01-24 23:06:44 +01:00
Bartłomiej Dach
ff22a91d52
Move user cover lower down
2023-01-24 23:06:37 +01:00
Bartłomiej Dach
edb9c76edf
Merge pull request #22385 from peppy/touchscreen-settings-keyword
...
Fix touch input handler settings not matching search for "touchscreen"
2023-01-24 20:50:53 +01:00
Jérémiah DÉCOMBE
acb42f7d12
reusing gameplay background blur loc song select background blur
2023-01-24 10:18:00 +01:00
Dean Herbert
b9291cb116
Change some order and assert for positive visibility before scheduling an operation in changelog overlay
2023-01-24 17:59:25 +09:00
Jérémiah DÉCOMBE
e0a7559d85
variable naming + loc
2023-01-24 09:55:08 +01:00
Joseph Madamba
c6bf755e68
Remove IsPresent override from ChangelogOverlay
2023-01-24 00:22:29 -08:00
Joseph Madamba
df895c4fd6
Always make settings footer build display clickable
2023-01-24 00:21:39 -08:00
Jérémiah DÉCOMBE
7ca2a431e6
changing song select background blur setting to boolean
2023-01-24 09:19:53 +01:00
Dean Herbert
fc558278cc
Fix touch input handler settings not matching search for "touchscreen"
2023-01-24 13:37:12 +09:00
Jeremiah DECOMBE
b573e42cc2
BeatmapSelectionBackgroundBlurLevel renamed to SongSelectBackgroundBlurLevel
2023-01-24 00:08:11 +01:00
Jeremiah DECOMBE
f13a5465ba
variable naming and loc modifications
2023-01-23 23:07:50 +01:00
Bartłomiej Dach
9f2ed853eb
Merge pull request #22371 from peppy/more-settings-keywords
...
Add more keywords to settings based on feedback
2023-01-23 20:19:53 +01:00
Jérémiah DÉCOMBE
6daa364779
adding setting to adjust blur of the background of the song select screen
2023-01-23 13:53:31 +01:00
Dean Herbert
432e0a6a37
Merge branch 'master' into level-badge-colour
2023-01-23 15:46:15 +09:00
Dean Herbert
9c2494383f
Rename fetch method to be non-plural to match all others
2023-01-23 15:43:52 +09:00
Dean Herbert
7ebd31d42f
Add more keywords to settings based on feedback
2023-01-23 15:14:16 +09:00
Dean Herbert
2ed9fe3747
Add support for externally specified keywords in SettingsButtons
2023-01-23 15:10:26 +09:00
EXtremeExploit
8d4889d5ce
Cleanup
2023-01-22 17:42:53 -03:00
EXtremeExploit
e60a089f1a
Set alpha on container instead of children
2023-01-22 15:02:02 -03:00
EXtremeExploit
de5eb63ceb
Fix codefactor
2023-01-22 13:38:13 -03:00
EXtremeExploit
933fc8cc83
Fix comment
2023-01-22 13:33:36 -03:00
EXtremeExploit
64c9654910
Make probationary groups a bit transparent
2023-01-22 13:32:05 -03:00
Bartłomiej Dach
e1acf85bb3
Merge branch 'master' into groups-modes
2023-01-22 10:09:34 +01:00
Bartłomiej Dach
9bde1ef9bf
Privatise setter
2023-01-22 10:09:08 +01:00
Bartłomiej Dach
b98da506c1
Fix code quality inspection
2023-01-22 10:07:47 +01:00
Bartłomiej Dach
88d58e8476
Merge pull request #22337 from Joehuu/fix-comment-editor-sounds
...
Fix comment editor text boxes not having sound feedback
2023-01-22 09:10:20 +01:00
Dean Herbert
7040743249
Add search keywords for screen scaling sub-settings
2023-01-22 13:47:31 +09:00
EXtremeExploit
2f3971b6fb
Move code to already existing if block
2023-01-22 01:40:00 -03:00
EXtremeExploit
8c208da324
Cleanup
2023-01-22 01:39:01 -03:00
EXtremeExploit
05f77d2cab
Add modes text to groups tooltip
2023-01-22 01:36:53 -03:00
Joseph Madamba
da03abc812
Fix comment editor text boxes not having sound feedback
2023-01-21 17:32:42 -08:00
Dean Herbert
4916a742d5
Immediately focus the textbox when clicking to reply to a comment
2023-01-19 16:08:27 +09:00
Dean Herbert
81e6c3792c
Remove unused method
2023-01-19 16:03:46 +09:00
Dean Herbert
07af18b8a7
Remove ReplyCommentEditor into its own class
2023-01-19 16:01:37 +09:00
ansel
77bc4fbf70
Integrate editor into comment
2023-01-18 20:50:07 +03:00
ansel
0d91277ea5
Add ability to change number on replies button
2023-01-18 20:49:30 +03:00
ansel
c74500b4b4
Add reply editor
2023-01-18 20:49:07 +03:00
ansel
0f2ca5d5ed
Expose method for drawable comment creation
2023-01-18 18:10:35 +03:00
ansel
18baf3dd5d
Log delete failure
2023-01-18 17:30:34 +03:00
StanR
24ed84aad0
Add tiered level badge colouring
2023-01-18 16:25:11 +03:00
Dean Herbert
39ac7615ec
Merge branch 'master' into registration-loc
2023-01-18 13:41:53 +09:00
Dean Herbert
f7c4199a77
Merge pull request #22262 from Joehuu/chat-mention-user
...
Add ability to easily mention users in chat by right clicking username
2023-01-18 13:30:02 +09:00
Dean Herbert
0a47dc733f
Merge pull request #22268 from Feodor0090/comments-margin
...
Reduce padding for too nested comments
2023-01-18 11:45:41 +09:00
ansel
ca3be71381
Track comment's nesting and reduce padding for too nested
2023-01-18 02:11:07 +03:00
ansel
12544c16ea
Remove canBeNull
2023-01-18 02:10:02 +03:00
Joseph Madamba
dfea42fd16
Add space after username mention
2023-01-17 14:13:50 -08:00
Joseph Madamba
254c881ded
Also check null for bindable channel value
2023-01-17 14:12:48 -08:00
Bartłomiej Dach
f7c942ac10
Move user stats into detail header container
2023-01-17 22:32:24 +01:00
Bartłomiej Dach
7a475d9cf8
Move out stats from top header container
2023-01-17 22:32:15 +01:00
Bartłomiej Dach
350cce1315
Move contents of detail header to separate component
2023-01-17 22:32:12 +01:00
Bartłomiej Dach
f5459909f9
Merge branch 'master' into comment-editor-3
2023-01-17 21:31:08 +01:00
Bartłomiej Dach
3640342805
Add logging on comment post failure
2023-01-17 21:30:46 +01:00
Joseph Madamba
97bd76efc6
Add ability to easily mention users in chat by right clicking username
2023-01-17 10:01:07 -08:00
Feodor0090
99c65af6cd
Merge branch 'master' into registration-loc
2023-01-17 13:38:05 +03:00
ansel
df74bccaaa
Replace 2 strings with one formattable
2023-01-17 13:31:03 +03:00
Dean Herbert
c799375ae0
Merge pull request #20709 from Domilz/toolbar-localisation
...
Localise toolbar home button and ruleset description tooltips
2023-01-17 17:28:34 +09:00
Dean Herbert
a02556d2fa
Move hover logic to SettingsToolboxGroup to avoid expanded state clash
2023-01-17 14:43:22 +09:00
Dean Herbert
1f47def3c4
Merge branch 'master' into skin-editor-loc
2023-01-17 11:53:08 +09:00
Bartłomiej Dach
0c5a436754
Merge pull request #22241 from stanriders/refactor-levelbadge
...
Refactor `LevelBadge` to use `LevelInfo`
2023-01-16 23:33:03 +01:00
Bartłomiej Dach
f79037cefb
Move to LoadComplete() better
2023-01-16 21:47:31 +01:00
StanR
3f75506552
Move binding to LoadComplete
2023-01-16 23:42:07 +03:00
StanR
c5d09c0e2c
Rename variable
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-01-16 23:36:50 +03:00
StanR
6207a96a29
Refactor LevelBadge to use LevelInfo
2023-01-16 23:24:09 +03:00
Bartłomiej Dach
bf58fe21ce
Merge branch 'master' into beatmap-set-converted-beatmaps
2023-01-16 20:46:41 +01:00
ansel
bb3668c769
Reuse existing
2023-01-16 22:24:03 +03:00
ansel
4c341db33f
Localise registration window
2023-01-16 21:31:01 +03:00
ansel
ff5a12fcb4
Localise login form
2023-01-16 20:39:38 +03:00
ansel
26f3b1dbfe
Localise "revert to default" tooltip
2023-01-16 19:37:47 +03:00
Joseph Madamba
0ff143d4c8
Add argument for play some ruleset string
2023-01-15 15:23:26 -08:00
Joseph Madamba
ae49e724e4
Move converted beatmap icons logic locally
2023-01-15 15:09:25 -08:00
Joseph Madamba
b733f46c6f
Apply NRT to BeatmapPicker
2023-01-15 15:09:25 -08:00
Joseph Madamba
27671f0401
Merge remote-tracking branch 'upstream/master' into pr/20709
2023-01-15 15:08:11 -08:00
Joseph Madamba
85c1932851
Mark Converts as nullable
2023-01-15 12:46:41 -08:00
Joseph Madamba
627d1725c3
Fix kudosu wiki link from user profile not linking to in-game overlay
2023-01-14 19:56:51 -08:00
ansel
1480c691ae
Explain empty string in editor's footer
2023-01-14 23:42:56 +03:00
ansel
c36922dd2c
Use clock to obtain a position for comment insertion
2023-01-14 22:57:51 +03:00
ansel
c2bb0949f5
Take type and id from container directly on submit
2023-01-14 22:57:23 +03:00
ansel
cdf3aafddd
Add check for any drawables in content before looking for placeholder
2023-01-14 22:37:05 +03:00
Joseph Madamba
e7ab543799
Add ability to view converted beatmaps on beatmap set overlay
2023-01-14 10:26:21 -08:00
ansel
88c3eef8e1
Add test case with no existing comments
2023-01-14 20:59:13 +03:00
Bartłomiej Dach
67a3ea2c59
Fix wrong date colour of kudosu history items
2023-01-14 17:50:18 +01:00
Bartłomiej Dach
bfca75395b
Adjust colour of top header container
2023-01-14 17:37:33 +01:00
Bartłomiej Dach
6a9d842660
Adjust user profile header detail appearance
2023-01-14 17:37:31 +01:00
Bartłomiej Dach
de077403e9
Adjust visual appearance of profile value displays
2023-01-14 17:37:28 +01:00
Bartłomiej Dach
f80dddbb5e
Rearrange and adjust header components where simple
2023-01-14 17:17:28 +01:00
Bartłomiej Dach
e39eb089ce
Update colouring of some profile section elements
2023-01-14 17:17:26 +01:00
Bartłomiej Dach
5b1111c6b1
Adjust appearance of user profile sections
2023-01-14 17:17:24 +01:00
Bartłomiej Dach
3f81f173fb
Adjust appearance of section navigation
2023-01-14 17:17:21 +01:00
Bartłomiej Dach
49e08c06a6
Adjust general appearance of user profile overlay
2023-01-14 16:59:51 +01:00
Bartłomiej Dach
5e1ea8b34f
Merge branch 'master' into move-overlay-ruleset-selectors
2023-01-14 15:22:14 +01:00
Dean Herbert
2f2ab445c9
Merge pull request #22182 from stanriders/status-icon
...
Update status icon design
2023-01-14 21:05:44 +09:00
Dean Herbert
cfc8fd0aa1
Merge pull request #22188 from Feodor0090/nofs-locale
...
Localise some notifications
2023-01-14 18:12:54 +09:00
StanR
e07c0c7c1f
Using
2023-01-14 02:58:18 +03:00
ansel
bb8bcd7248
Move avatar update bind to LoadComplete
2023-01-14 02:50:30 +03:00
ansel
c95d8645f3
Revert "Use existing string"
...
This reverts commit f950b624ae
2023-01-14 02:42:04 +03:00
ansel
9e7ecbf4a1
Adapt to changes in base class
2023-01-14 02:41:11 +03:00
ansel
e9995410e8
Merge branch 'master' into comment-editor-3
2023-01-14 02:32:06 +03:00
StanR
cb4f32e7bd
Use StatusIcon in UserDropdown
2023-01-14 02:31:27 +03:00
StanR
e2d6e31314
Using
2023-01-14 02:26:26 +03:00
StanR
660bf748d5
Fix GroupBadge crashing on null group colour
2023-01-14 02:23:08 +03:00
Bartłomiej Dach
ab3d39a940
Merge branch 'master' into comment-editor-1
2023-01-13 22:41:41 +01:00
ansel
f950b624ae
Use existing string
2023-01-14 00:26:35 +03:00
Joseph Madamba
5750d82c0a
Move overlay ruleset selectors to tab control
2023-01-13 12:50:35 -08:00
ansel
c62d416680
Add localisation for notification overlay
2023-01-13 22:54:38 +03:00
Dean Herbert
11f630d49d
Prefill username and email
2023-01-13 15:42:34 +09:00
Dean Herbert
4d58e6d8d2
Add UI support for redirecting the user to web registration
2023-01-13 15:36:45 +09:00
Dean Herbert
6daa37bd3e
Merge pull request #22168 from Joehuu/fix-mute-button-closing-overlays
...
Fix mute button not blocking outside overlay closing presses
2023-01-13 12:35:03 +09:00
Joseph Madamba
5a38abe679
Add comment highlighting reason for blocking mouse down
2023-01-12 19:32:53 -08:00
Dean Herbert
55f1c7c49d
Merge pull request #22160 from EVAST9919/ruleset-selector-online
...
Don't display custom rulesets in online overlays
2023-01-13 12:16:42 +09:00
Dean Herbert
464c5eaa2f
Fix grammar
2023-01-13 12:16:35 +09:00
ansel
c554a34eaf
Add "fps" keyword to frame limiter dropdown
2023-01-13 02:11:05 +03:00
Joseph Madamba
a16050534d
Fix mute button not blocking outside overlay closing presses
2023-01-12 14:20:16 -08:00
Andrei Zavatski
d74a5ef9e6
Use property instead of ctor parameter
2023-01-12 23:26:29 +03:00
Andrei Zavatski
a7ac31fa34
Use IsLegacyRuleset extension method
2023-01-12 23:21:33 +03:00
Andrei Zavatski
1dae1149cb
Don't display non-legacy rulesets in beatmap listing
2023-01-12 22:52:45 +03:00
Andrei Zavatski
a9915d6a64
Make OverlayRulesetSelector display only legacy rulesets
2023-01-12 22:44:41 +03:00
ansel
0bd1c46c74
Undo sizing changes
2023-01-12 19:48:11 +03:00
Dean Herbert
7cf58190a9
Merge pull request #22006 from bdach/user-profile/ruleset-switching
...
Add ruleset switching to user profile overlay
2023-01-12 13:54:13 +09:00
Joseph Madamba
2076f9fd08
Fix lookup type being incorrect when fetching beatmap set
2023-01-11 19:08:11 -08:00
Bartłomiej Dach
52eabbf224
Merge branch 'master' into user-profile/ruleset-switching
2023-01-11 19:11:40 +01:00
Dean Herbert
08ca62205a
Merge pull request #22123 from stanriders/group-badges
...
Implement user group badges
2023-01-11 18:42:50 +09:00
Dean Herbert
2dcc61caf5
Add extra level of nullabiliy checking because NRT is not present
2023-01-11 17:38:08 +09:00
Dean Herbert
3b55153609
Merge pull request #22122 from Stedoss/beatmapsetoverlay-fetch-on-login
...
Fix `BeatmapSetOverlay` not showing a pending request after logging in
2023-01-11 16:51:52 +09:00
Dean Herbert
b1a13286a3
Remove some redundancies
2023-01-11 16:50:37 +09:00
Dean Herbert
318867f486
Fix previous badges potentially not being cleared if new user has no badges
2023-01-11 16:48:47 +09:00
Dean Herbert
e0d58d51b6
Split out classes into own files and rename GroupInfoContainer to a flow
2023-01-11 16:47:29 +09:00
Dean Herbert
b710f86d75
Refactor to use tuples and de-duplicate request code
2023-01-11 16:15:28 +09:00
StanR
5441c02a1a
Implement user group badges
2023-01-11 07:11:38 +03:00
Stedoss
44de24f153
BeatmapSetOverlay fetch on login state change
2023-01-10 23:30:09 +00:00
ansel
b38cf8c56c
Use empty string as default
2023-01-11 02:26:25 +03:00
Bartłomiej Dach
62e12277d8
Rename things yet again
2023-01-10 19:30:01 +01:00
Bartłomiej Dach
502478614a
Merge branch 'master' into user-profile/decouple-from-api-user
2023-01-10 19:13:33 +01:00
Dean Herbert
23a78e6fad
Combine commit button enabled handling
2023-01-10 23:59:17 +09:00
ansel
23e4cfb469
Show spinner next to buttons and get rid of EditorCommitButton
2023-01-09 23:37:36 +03:00
Salman Ahmed
dbc19777e0
Move stable import buttons under "debug" section
2023-01-09 21:22:21 +03:00
Bartłomiej Dach
6027e7cc4e
Fix one more missed related symbol
2023-01-09 18:22:49 +01:00
Bartłomiej Dach
0026861bd4
Merge branch 'master' into user-profile/decouple-from-api-user
2023-01-09 17:47:59 +01:00
Bartłomiej Dach
4dec3cae57
Rename UserProfileData-related symbols
2023-01-09 17:46:08 +01:00
Bartłomiej Dach
fdf0d4bd62
Rename UserProfile{ -> Data}
2023-01-09 17:37:28 +01:00
Endrik Tombak
44e9fb638c
Merge branch 'master' of https://github.com/ppy/osu into songs-folder-check
2023-01-09 14:53:40 +02:00
Endrik Tombak
f5c8ba420c
Revert message change
2023-01-09 14:53:16 +02:00
Dean Herbert
07dae7dc21
Merge branch 'master' into overlay-panels-context-menu
2023-01-09 19:04:56 +09:00
Endrik Tombak
15eebd1f50
Only show message about Songs folder
2023-01-09 11:47:13 +02:00
Dean Herbert
13b00928c8
Rename loading spinner bool to reflect that it has a setter
2023-01-09 15:52:18 +09:00
Dean Herbert
d2f4ffcc5b
Merge branch 'master' into comment-editor-1
2023-01-09 15:52:17 +09:00
Joseph Madamba
f6b1dfc7b0
Fix channel listing items overflowing at high ui scaling
2023-01-08 13:27:10 -08:00
Joseph Madamba
0f6735564e
Move and rename nomination response model to singular
2023-01-07 10:54:48 -08:00
ansel
927773d565
Display submitted comments locally
2023-01-07 04:15:43 +03:00
ansel
32e90829e3
Integrate comment editor into container
2023-01-07 02:59:24 +03:00
ansel
387326db0d
Make commit action abstract
2023-01-06 22:51:57 +03:00
Joseph Madamba
7f970f3cd8
Display nominators on beatmap set overlay
2023-01-06 11:33:39 -08:00
Salman Ahmed
3862184f9c
Merge branch 'master' into improve-filter-tab-item-ux
2023-01-06 15:37:21 +03:00
Salman Ahmed
0ade4d92d1
Fix multiple highlighting issues with beatmap listing tab items
2023-01-06 15:13:31 +03:00
Salman Ahmed
3d053ac758
Merge branch 'master' into filter-tab-item-bold
2023-01-06 15:11:57 +03:00
Dean Herbert
0ab1418aa6
Merge pull request #22034 from frenzibyte/fix-toolbox-group-animation
...
Fix settings toolbox group not animating on expansion
2023-01-06 19:59:31 +08:00
Dean Herbert
4319937bc7
Also add an underline to better accent current filters
2023-01-06 20:36:10 +09:00
Dean Herbert
3c74d27deb
Also add an underline to better accent current filters
2023-01-06 20:35:58 +09:00
Dean Herbert
458fe382ed
Make selected tab items more bold
2023-01-06 20:06:41 +09:00
Dean Herbert
464f251c0c
Merge branch 'master' into beatmap-set-link-genre-language
2023-01-06 17:09:06 +08:00
Salman Ahmed
7d8aff8f7e
Fix settings toolbox group not animating on expansion
2023-01-05 14:35:57 +03:00
Bartłomiej Dach
a124c967df
Add proper offline & loading state handling to user profile overlay
2023-01-02 17:23:09 +01:00
Bartłomiej Dach
c759b743dc
Add support for switching rulesets on profile overlay
2023-01-02 17:23:06 +01:00
Bartłomiej Dach
a2e726502f
Add ruleset selector to profile overlay
2023-01-02 17:23:04 +01:00
Bartłomiej Dach
7683ab68b0
Use UserProfile in profile ruleset selector
2023-01-02 17:23:01 +01:00
Bartłomiej Dach
1722f3a125
Add ruleset to UserProfile
2023-01-02 17:22:55 +01:00
Bartłomiej Dach
4dd7727f71
Remove test-specific workaround in overlay
2023-01-02 17:21:14 +01:00
Bartłomiej Dach
d7294ac3e6
Substitute APIUser for UserProfile in overlay
2023-01-02 17:21:09 +01:00
Bartłomiej Dach
608d8ee7d4
Add UserProfile model to be used in user profile overlay
...
As `APIUser` implements `IEquatable`, attempting to replace an `APIUser`
with another `APIUser` with the same online ID has no effect on the user
profile overlay. This is a significant hurdle in implementing support
for viewing the profile for different rulesets, as in that case the
profile is basically reloaded for the same user, but slightly different
data.
To facilitate this, wrap `APIUser` in a new `UserProfile` class. This
will mean that the equality rules can be changed locally to the user
profile overlay without impacting other components that depend on the
`APIUser` equality rules. The ruleset that the user profile is being
displayed with will eventually be added to `UserProfile`, too.
2023-01-02 17:21:00 +01:00
Bartłomiej Dach
88e90d5fa0
Enable NRT in user profile overlay
2023-01-01 23:49:11 +01:00
Bartłomiej Dach
2698d58c46
Merge branch 'master' into remember-chat-textbox-per-channel
2023-01-01 17:29:38 +01:00
Dean Herbert
9a4f0cad2c
Fix incorrect domain root being used for recent activity entries on profile overlay
...
Closes https://github.com/ppy/osu/issues/21980 .
2023-01-01 17:48:05 +08:00
Dean Herbert
87250ad847
Add search keywords for beatmap colours / hitsound overrides
2023-01-01 14:32:28 +08:00
Bartłomiej Dach
0d70f2c0fd
Use alternative workaround
2022-12-30 09:08:17 +01:00
Bartłomiej Dach
f625c5d744
Fix gradient showing when toggling toolbar with mouse above window
2022-12-29 23:35:45 +01:00
Bartłomiej Dach
bf975eb48a
Fix toolbar gradient not showing when mouse is hovered over buttons
2022-12-29 23:03:53 +01:00
Dean Herbert
ccf713c885
Fix incorrect hard link validity check in stable import screen
2022-12-29 23:18:12 +08:00
Dean Herbert
f9f6918fc3
Merge branch 'master' into add_linux_hardlink
2022-12-29 21:29:57 +08:00
Bartłomiej Dach
c5f7da9a4e
Fix hover propagating through toolbar buttons
...
Closes #21920 .
Weirdly enough this was semeingly fixed once before in ancient times in
3891f467a3566e09083f#9447 .
2022-12-29 13:19:14 +01:00
Joseph Madamba
c326745f96
Save / sync chat text box messages per channel
2022-12-28 16:09:40 -08:00
Joseph Madamba
b40d114e76
Remove context menu from news card for now
2022-12-28 15:00:57 -08:00
Bartłomiej Dach
10c11e974d
Fix broken spacing
2022-12-28 22:24:21 +01:00
Bartłomiej Dach
49b0ec9ddb
Fix broken condition
2022-12-28 22:24:18 +01:00
Bartłomiej Dach
d4b3965967
Change warning message about file duplication
...
- It was being glued in an ugly way that would have prevented sanely
localising it.
- Even on Linux, the filesystem (whichever one the user has chosen out
of the multitude available) still needs to support hard links for them
to have a chance of working.
2022-12-28 22:04:08 +01:00
BlauFx
d63be3ff17
Change name of variable
2022-12-28 15:02:44 +01:00
BlauFx
f32564652b
Mention the filesystem should be NTFS on Windows
2022-12-28 14:33:38 +01:00
Feodor0090
930cd15649
Merge branch 'master' into comment-editor-1
2022-12-28 17:46:01 +05:00
BlauFx
b2aa2e1602
Add hardlink support for Linux
2022-12-28 13:32:49 +01:00
Salman Ahmed
b4c5e18da0
Add keywords to ease search of "first object visibility" setting
2022-12-28 13:23:50 +03:00
Dean Herbert
61029b126d
Add link to hard link explanation wiki page
2022-12-27 17:56:23 +08:00
Joseph Madamba
bb58976838
Merge remote-tracking branch 'upstream/master' into overlay-panels-context-menu
2022-12-26 17:54:15 -08:00
Joseph Madamba
8bc8b0d0af
Remove redundant context menu container
2022-12-26 15:38:07 -08:00
Joseph Madamba
84e3858a86
Move context menu / popover container one level to account for header
2022-12-26 15:37:46 -08:00
Berkan Diler
c7ca4bbba5
Use generic Enum methods
2022-12-26 20:36:39 +01:00
Salman Ahmed
ee77b8cad3
Merge branch 'master' into fix-parameters-inspection
2022-12-26 05:17:40 +03:00
Joseph Madamba
973fd90af2
Fix parameters with the same default value inspection
2022-12-25 16:15:02 -08:00
Joseph Madamba
f959b02dc8
Use empty drawables for spacing badges instead
2022-12-25 16:05:59 -08:00
Joseph Madamba
b9dfb8b602
Add localisation for context menu strings
2022-12-25 10:12:02 -08:00
Joseph Madamba
2c2f347e25
Add context menus to overlay panels/cards
2022-12-25 09:57:42 -08:00
Joseph Madamba
b871d6f078
Remove unused fields
2022-12-24 13:35:17 -08:00
Joseph Madamba
ae967e08b0
Add badges when needed instead of using alpha
2022-12-24 13:27:46 -08:00
Joseph Madamba
4f6b3644f3
Fix title/artist overflowing to right side
2022-12-24 12:40:32 -08:00
Joseph Madamba
df645ef3cb
Change title/artist idle colour to white
2022-12-24 11:42:05 -08:00
Joseph Madamba
9d073f4228
Link beatmap set title and artist to listing search
2022-12-24 11:26:09 -08:00
Bartłomiej Dach
301eb71e22
Fix wrong member names
2022-12-24 10:39:05 +01:00
Dean Herbert
2c060ac8d4
Add localisation support for new button's strings
2022-12-24 17:32:04 +08:00
Dean Herbert
91bde14fb3
Add button to settings to show lazer upgrade guide
2022-12-24 15:42:24 +08:00
Joseph Madamba
2dbcf05fe4
Use enum values as ids in fallback instead
2022-12-23 11:13:27 -08:00
Joseph Madamba
494886ef92
Rename Text to Metadata
2022-12-23 11:11:15 -08:00
Bartłomiej Dach
9a2cc04361
Fix wrong path being used in fail handler
2022-12-23 16:44:03 +01:00
Dean Herbert
a677c8be06
Change path on error
2022-12-23 21:17:42 +08:00
Dean Herbert
5eccafe190
Fix wiki overlay showing error message when load is cancelled
2022-12-23 16:45:40 +08:00
Berkan Diler
08d2fbeb8e
Use new ArgumentNullException.ThrowIfNull throw-helper API
2022-12-22 21:27:59 +01:00
Salman Ahmed
28fc2f34b5
Merge branch 'master' into restore-default-button-hit-area
2022-12-22 13:32:57 +03:00
Joseph Madamba
e1e6d76f30
Check id for genre/language instead and fallback to name if not defined
2022-12-21 11:02:04 -08:00
Bartłomiej Dach
3ec31a5f51
Fix language selector in first run dialog not updating after changing language in settings
2022-12-21 19:30:21 +01:00
Joseph Madamba
1d39e8d0ce
Refactor MetadataSection to use generics and inheritance
2022-12-21 10:18:47 -08:00
Dean Herbert
19f66c806e
Fix language dropdown in settings not updating after changing language in first run dialog
...
Closes #21744 .
2022-12-21 16:31:55 +08:00
Bartłomiej Dach
cebd5f6dc2
Fix restore default button having a minuscule hit area
...
Another casualty of edc78205d5
2022-12-20 20:47:58 +01:00
Bartłomiej Dach
378486cbe0
Merge branch 'master' into argon-pro-skin
2022-12-20 19:34:56 +01:00
Bartłomiej Dach
bf074adb13
Remove unused using directive
2022-12-20 18:24:26 +01:00
Bartłomiej Dach
8ead606065
Merge branch 'master' into ui-scale-only-show-one-screen
2022-12-20 18:23:37 +01:00
cdwcgt
ffa32307c3
abstract ReportPopover
2022-12-21 01:37:16 +09:00
cdwcgt
b37f1cce3f
Added ability to report chat
2022-12-20 23:46:05 +09:00
Dean Herbert
2f0c772dcb
Add argon pro skin
2022-12-20 21:18:51 +09:00
wiskerz76
439b8ac56a
Fix file select popup getting stuck when switching first run screens while selecting
...
Closes #21663
Supersedes #21724
2022-12-20 17:59:23 +09:00
Dean Herbert
c119d41a2d
Only show song select for now at ui scale adjust first run screen
...
Having both was a bit too much. Still not happy with this but it's a bit
less sensory overload.
I think while it's cool being able to show nested screens like this, it
needs more thought to actually be a good experience.
2022-12-20 17:52:56 +09:00
Joseph Madamba
01f09529a8
Link beatmap set genre and language to listing filters
2022-12-19 22:54:33 -08:00
Bartłomiej Dach
64a45aa0e0
Merge branch 'master' into wiki-heading-id-attributes
2022-12-20 06:34:47 +01:00
Bartłomiej Dach
7c282d9def
Enable generic attribute support for wiki markdown containers
2022-12-19 21:32:38 +01:00
Bartłomiej Dach
db1380a346
Refactor markdown extension management
2022-12-19 20:19:51 +01:00
Bartłomiej Dach
186ccc64fd
Fix welcome screen language buttons not working
2022-12-19 18:19:26 +01:00
Dean Herbert
b64a5cbda6
Merge branch 'master' into guard-url-protocols
2022-12-19 15:46:45 +09:00
Joseph Madamba
6e62033bc4
Fix some comment actions not being lowercased
2022-12-18 20:20:15 -08:00
Dean Herbert
ba54551313
Merge branch 'master' into guard-url-protocols
2022-12-16 18:23:16 +09:00
Dean Herbert
27c497145f
Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
2022-12-16 18:16:26 +09:00
Dan Balasescu
cbee72897a
Merge pull request #21654 from Susko3/use-localisable-strings-for-dates-and-times
...
Use `LocalisableString`s for date and time formats
2022-12-16 16:17:14 +09:00
Dean Herbert
232f590ba3
Merge pull request #21628 from peppy/go-hard-file-writes
...
Use hard links on windows when importing beatmaps from a legacy osu! install
2022-12-16 14:52:57 +09:00
Susko3
0f34d908c7
Use LocalisableStrings for date and time formats
2022-12-16 00:05:47 +01:00
Dean Herbert
9813bc9544
Reword disclaimer and fix translation keys
2022-12-15 22:46:31 +09:00
cdwcgt
6ef5b2733f
Export instead of ExportCurrentSkin
2022-12-15 21:41:15 +09:00
Dean Herbert
d2b98b803d
Turn on featured artist filter by default and add disclaimer when toggling for the first time
2022-12-15 18:42:47 +09:00
Dean Herbert
0763b86236
Add more padding around text in dialog popups
2022-12-15 17:32:27 +09:00
Dean Herbert
78bc94d3cb
Set featured artists filter to enabled by default
2022-12-15 16:57:39 +09:00
Dean Herbert
a7f3e13946
Fix MultipleSelectionFilter not correctly handling initial selection
2022-12-15 16:56:09 +09:00
Dean Herbert
f4316a9827
Fix incorrect grammar in hard link explanation text
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-14 11:30:01 +09:00
Dean Herbert
b8904fe747
Move ImportParameters to better home
2022-12-13 21:41:26 +09:00
Dean Herbert
cb16d62700
Hook up ImportParameter flow with IModelImporter caller methods
2022-12-13 21:29:32 +09:00
Andrei Zavatski
15bd82add8
Fix DrawableUsername being affected
2022-12-12 18:24:49 +03:00
Dean Herbert
02b3bbf0d3
Merge pull request #21616 from Joehuu/changelog-build-masking
...
Fix changelog single build dates disappearing before being off screen
2022-12-12 18:28:48 +09:00
Dean Herbert
05b5949810
Use explicit casts
2022-12-12 17:38:39 +09:00
Dean Herbert
e2d8909e73
Add link to change folder location if it isn't on the same drive as import path
2022-12-12 13:44:09 +09:00
Dean Herbert
726943cb14
Add information attempting to explain hard links to the end user
2022-12-12 13:44:09 +09:00
Dean Herbert
d8de99bbe4
Check for hard link support in first run overlay
2022-12-12 13:44:09 +09:00
Dean Herbert
731184eb39
Revert "Merge pull request #21614 from EVAST9919/button-fix"
...
This reverts commit 4bd196684fa1d22ef77a
2022-12-12 13:43:01 +09:00
Joseph Madamba
e76c56b03b
Fix changelog single build dates disappearing before being off screen
2022-12-11 20:10:06 -08:00
Andrei Zavatski
1332568796
Fix SettingsButton receiving input at padded area
2022-12-12 03:10:13 +03:00
cdwcgt
e02b8cb199
Group export methods into their respective managers
2022-12-11 18:30:24 +09:00
cdwcgt
a1fc33668c
Merge branch 'master' into export
2022-12-09 23:40:26 +09:00
Bartłomiej Dach
5857471915
Merge branch 'master' into nominated-ranked-beatmaps
2022-12-07 23:54:25 +01:00
Dean Herbert
62b0436bcf
Reverse depth of profile sections to allow for overflowing expanded beatmap cards
...
Closes #21554 .
2022-12-07 16:38:17 +09:00
Joseph Madamba
56e94e49a3
Display nominated ranked beatmaps in user profile
2022-12-06 23:36:11 -08:00
Dean Herbert
49f5ac57b8
Fix first run beatmap screen button colours looking incorrect with new triangle effect
...
Addresses #21500 .
2022-12-03 18:48:54 +09:00
ansel
1763618488
Fix spinner presense check & field click
2022-11-30 13:58:03 +03:00
ansel
43628903a7
Make spinner bigger
2022-11-30 13:57:09 +03:00
ansel
1cc7ffce39
Keep button's text
2022-11-30 13:40:47 +03:00
ansel
bedc771e99
Remove useless check
2022-11-30 13:32:01 +03:00
ansel
a8422961dc
Rename button spinner prop again
2022-11-30 13:30:57 +03:00
ansel
5ea824534b
Use default button
2022-11-30 13:25:59 +03:00
ansel
642e0ac718
Increase footer height to look better with default buttons
2022-11-30 13:25:18 +03:00
ansel
956acbc86f
Use fixed width
2022-11-30 13:11:54 +03:00
Dean Herbert
4a747182b4
Merge branch 'master' into comment-editor-1
2022-11-30 17:22:59 +09:00
Dean Herbert
f7b7b58718
Adjust colour and tween to feel better
2022-11-30 16:20:01 +09:00
Dean Herbert
24ee363563
Only hover when hovering actual text
2022-11-30 16:18:36 +09:00
Dean Herbert
80b0e4a99d
Rename Colour to avoid conflict with Drawable.Colour
2022-11-30 16:15:50 +09:00
Dean Herbert
7fca5ee28d
Move DrawableUsername into own file
...
It's too large at this point to be a nested class.
2022-11-30 16:15:50 +09:00
Dean Herbert
6524914dbd
Merge branch 'master' into chat-profile-highlight-v2
2022-11-30 16:00:52 +09:00
ansel
e30d97c94e
Comments
2022-11-29 14:39:59 +03:00
ansel
84aaf5fedf
Change ways to access submit button state
2022-11-29 14:37:35 +03:00
ansel
6c126f5223
Remove useless local actions on click
2022-11-29 14:25:51 +03:00
Dean Herbert
61c702c02e
Add new IDependencyInjectionCandidate interface to non-drawable cached classes
2022-11-29 14:45:26 +09:00
Bartłomiej Dach
8f78d6179b
Fix multiple issues with settings items unhiding on search
2022-11-29 14:41:49 +09:00
Bartłomiej Dach
24deb5f5f4
Remove all unnecessary usage of IHasFilterableChildren
2022-11-29 14:40:52 +09:00
ansel
16962d9a57
Localize deleted string
2022-11-29 07:02:02 +03:00
ansel
a4819e5c9c
Localize actions
2022-11-29 07:01:52 +03:00
ansel
472d9274b6
Reorder members
2022-11-29 06:23:25 +03:00
ansel
af0ee9dbd6
Make spinner a little bigger
2022-11-29 06:19:54 +03:00
ansel
894fb98fa2
Rebase CommitButton to RoundedButton
2022-11-29 06:17:02 +03:00
ansel
a874345da0
Rebase CancelButton to RoundedButton
2022-11-29 05:46:30 +03:00
ansel
d20dc3668e
Enable nullability
2022-11-29 05:17:44 +03:00
ansel
8b033bf9f7
Allow localisable strings
2022-11-29 05:13:54 +03:00
Alden Wu
8ec4dd046e
Fix InspectCode errors
2022-11-28 18:06:44 -08:00
Alden Wu
0cb7c94c21
Merge branch 'master' of https://github.com/ppy/osu into chat-profile-highlight-v2
2022-11-28 17:59:15 -08:00
Alden Wu
c2d8ffc225
Refactor ChatLine username drawable creation
2022-11-28 17:50:12 -08:00
Bartłomiej Dach
894ef15e79
Merge branch 'master' into update-framework
2022-11-26 16:19:36 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
2b2beadd06
Merge branch 'master' into update-framework
2022-11-25 01:00:08 +09:00
Dean Herbert
53b03df93d
Combine TriangleButton and RoundedButton classes
2022-11-24 16:26:57 +09:00
Dean Herbert
bea2acc60e
Remove local specifications of triangle colouring
2022-11-24 16:18:15 +09:00
Dean Herbert
40f706155f
Update RoundedButton to have new triangles design
2022-11-24 16:18:15 +09:00
Bartłomiej Dach
2f67199b1c
Merge branch 'master' into fix-missing-day-separator
2022-11-23 18:40:44 +01:00
Dean Herbert
b381b4fd2d
Merge branch 'master' into update-framework
2022-11-24 01:27:58 +09:00
Dean Herbert
5467097387
Fix adjacent day separators potentially being left behind after pending message resolution
2022-11-23 18:49:51 +09:00
Dean Herbert
172e798847
Merge pull request #21228 from Terochi/recent-messages-implementation
...
Add ability to view chat send history in input box
2022-11-23 14:58:42 +09:00
Bartłomiej Dach
76bb529cfa
Add test for local echo adding day separator
2022-11-22 16:46:21 +01:00
Alden Wu
a2b505f4c0
Use a direct Lighten instead of >1f Color4 values
2022-11-22 00:31:22 -08:00
Alden Wu
4084a2b066
Highlight ChatLine username on hover
2022-11-21 18:57:59 -08:00
Bartłomiej Dach
8dbe31a172
Merge branch 'master' into higher-aspect-ratio-max
2022-11-21 19:51:39 +01:00
cdwcgt
c509c5be40
impossible null
2022-11-21 19:45:30 +09:00
cdwcgt
e37d30a373
refactor based on reviews
...
removed LegacyExportManager
Separated the method of CreateZip method and the default export method
2022-11-21 18:58:01 +09:00
Dean Herbert
981264b011
Avoid crashing when a system audio device provides a null name
2022-11-21 14:51:41 +09:00
Dean Herbert
e53b4321ff
Ensure two day separators are not added in a row
2022-11-21 14:01:10 +09:00
Dean Herbert
fa7b45dfb1
Fix chat day separator not being added on pending message resolution
...
Closes #21316 .
2022-11-21 13:52:14 +09:00
Dean Herbert
c7ae837687
Increase maximum aspect ratio for tablet settings to 23:9 / 2.55
2022-11-21 12:45:54 +09:00
Dean Herbert
92aea22cd3
Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup
...
Added PreferOriginalMetadataLanguage to FirstRunSetup
2022-11-21 12:16:56 +09:00
vegguid
a431b793b9
Added PreferOriginalMetadataLanguage to FirstRunSetup
2022-11-20 23:18:19 +01:00
Bartłomiej Dach
0c671a2a82
Merge branch 'master' into fix-tablet-aspect-ratio-values
2022-11-19 14:32:24 +01:00
cdwcgt
4e457871f3
impossible null and remove storage
2022-11-19 01:03:22 +09:00
cdwcgt
4b29941b47
add LegacyExportManager
2022-11-18 20:00:00 +09:00
Dean Herbert
06ce8130c2
Apply changes in line with framework NRT updates
2022-11-18 18:13:15 +09:00
Dan Balasescu
e4fc14faee
Merge pull request #21270 from peppy/auto-advance-bindings
...
Auto-advance binding for ruleset key bindings
2022-11-18 16:19:54 +09:00
Dean Herbert
e658efbefa
Fix being able to bind two non-modifier keys to the same binding
2022-11-18 15:34:41 +09:00
Dan Balasescu
1b1fed723d
Merge pull request #21269 from peppy/fix-key-bindings-keyword
...
Move "keybindings" keyword to correct section
2022-11-18 14:05:08 +09:00
Dan Balasescu
551192b413
Refactor a bit for readability
2022-11-18 13:55:37 +09:00
Dan Balasescu
a776622ce0
Merge pull request #21284 from peppy/now-playing-overlay-texture-reduction
...
Fix `NowPlayingOverlay` loading background texture too early (and permanently)
2022-11-18 12:09:16 +09:00
Dan Balasescu
baa4fd56e2
Merge pull request #21279 from peppy/news-load-unload
...
Fix news post images never unloading from memory after first display
2022-11-18 11:56:13 +09:00
Dan Balasescu
13fe0d3491
Merge pull request #21278 from peppy/overlay-header-texture-reduction
...
Avoid loading overlay headers until first open
2022-11-18 11:53:46 +09:00
Dean Herbert
b53f9baf6a
Fix NowPlayingOverlay loading background texture too early (and permanently)
2022-11-18 11:21:12 +09:00
Dean Herbert
93c2280754
Fix supporter filters text not being set correctly
2022-11-18 10:35:05 +09:00
Dean Herbert
b37e9c0266
Fix news post images never unloading from memory after first display
2022-11-18 00:01:53 +09:00
Dean Herbert
73e4827d36
Avoid loading overlay headers until first open
...
Also switches them to use non-atlased target as they won't benefit much
from atlasing.
2022-11-17 23:55:43 +09:00
Dean Herbert
63c1855511
Avoid loading beatmap listing placeholders until required
2022-11-17 23:42:21 +09:00
Dean Herbert
a3e8cc1663
Mark beatmap listing placeholder textures as large
2022-11-17 23:41:35 +09:00
Terochi
3d4962e181
Added functioning tests.
2022-11-17 13:07:06 +01:00
Terochi
6d83af01e2
Moved and renamed MessageHistoryTextBox.cs for better fit.
2022-11-17 13:07:06 +01:00
Dragon
b9590320b7
Moved implementation to ChatRecentTextBox.cs and derived ChatTextBox.cs and StandAloneChatDisplay.cs from it.
2022-11-17 13:07:06 +01:00
Dragon
a1af663682
Implemented previous messages lookup in the ChatTextBox.cs
2022-11-17 13:07:06 +01:00
Dean Herbert
d1b2116400
Auto-advance binding for ruleset key bindings
2022-11-17 15:23:20 +09:00
Dean Herbert
bd2e0dc82b
Move "keybindings" keyword to correct section
...
Without this, things like tablet settings would show when searching for
bindings, even though these settings have nothing to do with key
bindings.
2022-11-17 15:09:42 +09:00
cdwcgt
e1a21e0cf9
create a task to export to avoid block main thread
...
Code quality and remove some #nullable disable
2022-11-17 01:08:06 +09:00
Dean Herbert
bb762d8131
Fix "reset to full area" button not always working correctly
2022-11-16 15:45:26 +09:00
Samaoo
4ff17cb4bd
remove unused using directive
2022-11-12 08:52:33 +01:00
Samaoo
7a860fb460
address reviews
2022-11-12 08:49:03 +01:00
Samaoo
268011be9e
use MathF
2022-11-11 17:56:50 +01:00
Samaoo
173f557376
fix tablet aspect ratio values
2022-11-11 17:14:34 +01:00
Dan Balasescu
db25e9e9c8
Merge branch 'master' into combo-colour-brightness-limit
2022-11-11 15:31:28 +09:00
Susko3
5b1e39abd5
Fix parsing of Language when using default system locale
2022-11-10 22:56:24 +01:00
Samaoo
be81c658af
move tablet area calculations to functions
2022-11-09 20:14:01 +01:00
Samaoo
533a2db5ea
fix inaccurate tablet area dimensions when applying aspect ratio
2022-11-09 18:48:47 +01:00
Joseph Madamba
76df61504f
Remove unnecessary timestamp update
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-11-06 19:45:59 -08:00
Joseph Madamba
61ec0ba566
Make chat line timestamp adjust to 24-hour time setting
2022-11-06 19:28:01 -08:00
Joseph Madamba
b977fc8181
Use autosize instead of max width on fixed width timestamps
2022-11-06 19:28:01 -08:00
Dean Herbert
ee68f33e3c
Merge pull request #21109 from frenzibyte/fix-beatmap-duplicating-again
...
Fix beatmap cards still potentially showing twice in listing
2022-11-06 18:46:31 +09:00
Bartłomiej Dach
84179fb087
Merge branch 'master' into combo-colour-brightness-limit
2022-11-05 16:48:56 +01:00
Salman Ahmed
ee6f036c44
Add note about using ExceptBy once it's available
2022-11-04 19:35:24 +03:00
Salman Ahmed
ce5aacb760
Filter out duplicated cards using custom equality comparer instead
2022-11-04 19:27:35 +03:00
Joseph Madamba
e11d44d14f
Add url clicking support to profile badges
2022-11-03 18:12:32 -07:00
Dean Herbert
f6c376c090
Minor refactoring
2022-11-03 20:29:27 +09:00
Dean Herbert
1edde8f73c
Merge branch 'master' into disabled-button-sfx
2022-11-03 20:27:41 +09:00
Jamie Taylor
59bbd9c460
Fix some components using wrong sample set
2022-11-03 17:47:49 +09:00
Jamie Taylor
f1c17129eb
Add support for 'disabled' sample variation to HoverClickSounds
2022-11-03 17:47:49 +09:00
Dean Herbert
56ef519cc2
Move PopoverContainer into OnlineOverlay to ensure correct colours
2022-11-03 15:43:06 +09:00
Dean Herbert
e6c45b8ab5
Merge branch 'master' into comment-report
2022-11-03 15:35:42 +09:00
Dean Herbert
3ec9686e58
Fix test failures and rename configuration value to match better
2022-11-02 18:15:18 +09:00
Dan Balasescu
db34f238c0
Fix inverted condition
2022-11-02 15:47:30 +09:00
Dan Balasescu
e5f53b1ad8
Use Interlocked.Exhange() instead
...
Increment isn't correct since it returns the post-incremented value. It
also always increments.
2022-11-02 15:18:48 +09:00
Dean Herbert
e761c0395d
Fix multiple notifications arriving for imports in edge cases
2022-11-02 14:47:56 +09:00
Dean Herbert
50b6fe4acb
Localise new label
2022-11-02 14:01:03 +09:00
Dean Herbert
99ba7c29dd
Change range to 0-100% and rename to "normalisation"
2022-11-02 13:47:11 +09:00
Dean Herbert
2f3c80f884
Remove toggle and change method of application to blend with original colour
2022-11-02 13:08:29 +09:00
Dean Herbert
27af91003b
Merge branch 'master' into combo-colour-brightness-limit
2022-11-01 17:50:26 +09:00
Joseph Madamba
d56786b5ff
Fix toolbar visual bug when toggling clock displays
2022-10-29 15:25:16 -07:00
ansel
9df96aab38
Remove local popover containers
2022-10-28 22:17:45 +03:00
Dean Herbert
f46a9d683a
Fix null reference in headless tests
2022-10-28 18:07:25 +09:00
Dean Herbert
f9d2c30c3e
Add user toggle for application of safe areas
2022-10-28 14:05:45 +09:00
Dean Herbert
14c7cbde38
Fix toggle mute (and volume meter traversal) handling repeat key presses
...
Closes #20953 .
2022-10-27 11:41:00 +09:00
Joseph Madamba
8505848b1a
Scroll beatmap listing to top when searching via tags/source
2022-10-25 18:06:49 -07:00
Salman Ahmed
b0a4cd4f30
Inline content creation in base add method
2022-10-22 03:43:14 +03:00
Salman Ahmed
6c82bc36ed
Encapsulate report logic inside button implementation
...
Avoids complicating the `DrawableComment` class, and allows for isolated
testability.
2022-10-22 02:48:27 +03:00
Salman Ahmed
9b5e35d599
Remove dependency on DrawableComment from report popover and simplify logic
...
Allows for testing the button and popover in isolation.
2022-10-22 02:47:33 +03:00
Salman Ahmed
081cf1cc47
Adjust comment report popover design
2022-10-22 02:45:31 +03:00
ansel
15aeb4a137
Display text in buttons flow instead of toast
2022-10-21 17:25:41 +03:00
Dean Herbert
447d420c99
Fix adjusting volume via settings playing tick samples twice
2022-10-21 21:03:39 +09:00
Jamie Taylor
7b1edff2b3
Add unique hover/select samples to settings sidebar buttons
2022-10-21 18:06:38 +09:00
ansel
81bdf716ef
Change test
2022-10-20 19:56:00 +03:00
ansel
0ef903230c
Make report button a separate component
2022-10-20 18:47:42 +03:00
ansel
da4f04ace7
Make dropdown not resize
2022-10-20 18:22:55 +03:00
ansel
635900085c
Disable button when there is no text
2022-10-20 18:12:20 +03:00
ansel
ed39481932
Use another string for title
2022-10-20 18:11:35 +03:00
ansel
57320074a0
Fix accidental breakage of changelog layout
2022-10-20 01:24:36 +03:00
Dean Herbert
6b42f1931a
Remove autosize easing in SettingsToolboxGroup
...
It just feels like unnecessary motion.
2022-10-18 15:01:26 +09:00
ansel
3258a41ca3
Merge branch 'comment-report' of https://github.com/Feodor0090/osu into comment-report
2022-10-17 20:41:46 +03:00
ansel
cd77ae062e
Localize the button
2022-10-17 20:41:23 +03:00
ansel
797acf334f
Show username in popup
2022-10-17 20:41:13 +03:00
Feodor0090
6efe7b5334
Merge branch 'master' into comment-report
2022-10-17 16:08:13 +03:00
ansel
ceb4d624b5
Delete wip form
2022-10-17 13:43:35 +03:00
ansel
ffa22d8a68
Update popover not to use labelled drawables
2022-10-17 13:42:17 +03:00
ansel
d7e5bcbd3c
Add popover containers to overlays
2022-10-17 13:41:46 +03:00
ansel
7ed26369a3
Make a new report form, closer to web
2022-10-17 12:41:57 +03:00
Bartłomiej Dach
d0a495717e
Merge branch 'master' into comment-copy-link
2022-10-16 19:56:06 +02:00
ansel
4a8d976cb4
Use api's endpoint
2022-10-16 20:20:34 +03:00
ansel
ba595ab8fa
Display toast instead of notification
2022-10-16 19:57:21 +03:00
ansel
9822a092c4
Add localization for enum
2022-10-16 19:50:55 +03:00
Aki
91358f4a6a
Implement tablet button bindings
2022-10-15 15:16:14 +08:00
Feodor0090
fb046e31c1
Merge branch 'master' into comment-report
2022-10-14 16:57:23 +03:00
ansel
dc0aa2295a
Add test
2022-10-14 16:51:48 +03:00
ansel
3e9fd4c08c
Implement reporting flow
2022-10-14 16:26:25 +03:00
ansel
c65a8a83f3
Add basic UI for reporting
2022-10-14 15:52:09 +03:00
Dean Herbert
32c3e35762
Change background colour to a lighter tint to avoid clash with slider bars
2022-10-14 19:38:27 +09:00
Dean Herbert
2404bb42b9
Use 10% alpha rather than 0% when toolbox is not hovered
2022-10-14 19:33:49 +09:00
Dan Balasescu
8a88339e78
Allow combo colour normalisation to be disabled
2022-10-14 14:37:24 +09:00
ansel
8a47628fe1
Use spacer drawable instead of spacing on links container
2022-10-14 00:04:13 +03:00
ansel
295e6f5a68
Move toast to it's namespace
2022-10-13 23:57:25 +03:00
ansel
34ff072a9b
Change text
2022-10-13 22:47:48 +03:00
ansel
a0cca391f6
Add copy link button to comments
2022-10-13 22:18:26 +03:00
Dean Herbert
a93c350ca8
Start settings panels without background visible
2022-10-13 17:11:56 +09:00
Dean Herbert
6608ada925
Fix test failures due to missing colour provider dependency
2022-10-13 17:05:11 +09:00
Dean Herbert
0f4a2a6059
Improve feel of settings toolbox group
2022-10-13 16:36:19 +09:00
Dan Balasescu
4149235e63
Limit minimum brightness of combo colours
2022-10-13 14:05:33 +09:00
Dean Herbert
e43c8e84b0
Use Show instead of Alpha=1
2022-10-12 15:48:42 +09:00
Dean Herbert
47fe4eb0bd
Merge branch 'master' into comment-deletion
2022-10-12 15:48:26 +09:00
Dean Herbert
195ece02c6
Merge branch 'master' into update-displays-in-setting
2022-10-12 14:37:49 +09:00
Daniel Källberg
63e651130a
Grouped localisation strings
2022-10-11 10:59:07 +02:00
Daniel Källberg
9c611019b3
Toolbar localisation
2022-10-11 09:30:32 +02:00
Dean Herbert
6f6290a21a
Use async flow for storing key binding changes to realm
2022-10-11 15:37:22 +09:00
Salman Ahmed
a9aba74351
Add markdown country flag support
2022-10-08 21:50:25 +03:00
ansel
c384093802
Update main test and add failure scenario test
2022-10-08 18:53:41 +03:00
ansel
b697200460
Properly modify comment visual state on deletion
2022-10-08 18:41:08 +03:00
ansel
4e7c30504f
Schedule action buttons visibility changes
2022-10-08 17:15:10 +03:00
ansel
abf56c27a1
Do not requere dialog overlay
2022-10-08 17:11:09 +03:00
Joseph Madamba
b27e70ca47
Fix language settings dropdown not updating when changing language in first run setup
2022-10-06 21:11:00 -07:00
Dean Herbert
e9ab465da6
Merge branch 'master' into localisation-settings
2022-10-06 13:22:08 +09:00
Dean Herbert
4f084664ac
Merge branch 'master' into comment-deletion
2022-10-05 14:34:50 +09:00
Dean Herbert
75b9bf2cf9
Merge branch 'master' into intel-exclusive-warning
2022-10-04 19:02:01 +09:00
Susko3
efc9bed4f0
Use IWindow.DisplaysChanged to update displays
2022-10-03 23:52:04 +02:00
Susko3
31fefc1ee2
Add nullable annotation to LayoutSettings
2022-10-03 23:23:02 +02:00
Susko3
e98b4b4fbd
Make updateDisplayModeDropdowns regular method
2022-10-03 23:14:21 +02:00
ansel
85adfc2df7
Fix DI type
2022-09-28 18:26:36 +03:00
ansel
636befb499
Add visual feedback for deleting process
2022-09-28 17:49:37 +03:00
ansel
ae0d62838b
Move API and DO to fields
2022-09-27 22:46:23 +03:00
ansel
58d9509ce6
Apply NRT to Comment
2022-09-27 22:45:05 +03:00
ansel
60ee813e45
Implement delete button
2022-09-27 18:33:16 +03:00
ansel
31a7ba3f91
Add delete button
2022-09-27 18:23:15 +03:00
Dan Balasescu
ec30050f2c
Merge pull request #20502 from peppy/forward-toasts-on-gameplay
...
Flush toast tray on entering gameplay
2022-09-27 18:35:54 +09:00
Dan Balasescu
5a28174448
Merge pull request #20488 from nanashi-1/toggle-score-overlay
...
Add toggle for solo gameplay leaderboard
2022-09-27 18:09:55 +09:00
Dean Herbert
461ba64bfa
Flush toast tray on entering a no-notification section
2022-09-27 17:32:53 +09:00
Dean Herbert
c61f5403ab
Increase delay back slightly on notifications posting after disabled period
2022-09-27 17:32:30 +09:00
Dean Herbert
bac3108aea
Remove unnecessary keywords
2022-09-27 14:29:59 +09:00
Dan Balasescu
aa3956cfbb
Merge pull request #20495 from Feodor0090/playlist-overflow-fix
...
Fix playlist overlay overflowing at high UI scales
2022-09-27 13:53:14 +09:00
nanashi-1
dc051a8b79
add gameplay leaderboard config
2022-09-26 20:08:58 +08:00
Dan Balasescu
e5894ccd6f
Merge pull request #20478 from peppy/fix-progress-notification-fling
...
Fix progress notifications being able to be flung (and cancelled)
2022-09-26 18:21:12 +09:00
Dan Balasescu
f2eed881bd
Merge pull request #20480 from peppy/fix-drawable-mutation-tablet-settings
...
Fix potential crash from incorrect drawable mutation in tablet settings display
2022-09-26 18:16:52 +09:00
Dan Balasescu
525de8c140
Merge pull request #20479 from peppy/fix-drawable-mutation-misc
...
Fix potential crash on game exit due to incorrect scheduling of realm change handler
2022-09-26 18:02:28 +09:00
Dean Herbert
4e9b25d8b0
Move MusicController binds to LoadComplete for added thread safety
2022-09-26 15:42:37 +09:00
Dean Herbert
43c16cb613
Fix potential crash from incorrect drawable mutation in tablet settings display
2022-09-26 15:10:02 +09:00
Dean Herbert
4bd96108c0
Fix crash on game exit due to incorrect scheduling of realm change handler
2022-09-26 14:45:17 +09:00
Dean Herbert
b6dd8168d2
Fix progress notifications being able to be flung
2022-09-26 14:33:12 +09:00
ansel
5d0b2d34c9
Make playlist to always be in screen bounds
2022-09-24 23:35:06 +03:00
ansel
6c8e587344
Move margin value to constant
2022-09-24 21:52:16 +03:00
Dean Herbert
8a7526aaa3
Merge pull request #20344 from frenzibyte/better-tablet-notifications
...
Improve tablet error/warning notifications messaging
2022-09-22 22:45:27 +09:00
Dan Balasescu
6a0047b7a2
Update location of FullscreenCapability bindable
2022-09-22 21:01:23 +09:00
Dan Balasescu
70bab81282
Merge pull request #20377 from peppy/argon-skin
...
Add new default "argon" skin
2022-09-22 14:50:43 +09:00
Dan Balasescu
2b8b138079
Add "keybindings" search term to settings
2022-09-21 18:46:28 +09:00
Dean Herbert
4492a26b59
Merge branch 'master' into argon-skin
2022-09-21 13:00:16 +09:00
Dan Balasescu
8bf196d561
Merge pull request #20354 from peppy/default-skin-refactor
...
Rename default skin to make way for new version
2022-09-21 11:48:38 +09:00
Salman Ahmed
dcfb6a2f06
Fix progress notifications no longer blocking close on click
2022-09-21 00:15:50 +03:00
アズタケ
d22d009fb3
fix review points. items not included in this localization were reverted.
2022-09-20 14:02:11 +09:00
Dean Herbert
bd28c6f96d
Merge branch 'master' into localisation-settings
2022-09-19 23:37:26 +09:00
Dean Herbert
0f7b38f4c3
Add new default skin "argon"
2022-09-19 23:16:46 +09:00
Salman Ahmed
a413c7a3e6
Merge branch 'master' into fix-notification-count
2022-09-19 02:08:20 +03:00
Dean Herbert
41e69fbca6
Remove "default" prefix from naming
2022-09-18 00:15:26 +09:00
Dean Herbert
1c4e02fae8
Explicitly order default skins in dropdown to get correct order
2022-09-18 00:12:43 +09:00
Salman Ahmed
877165eb98
Allow specifying icon colour on simple notifications
2022-09-16 16:21:43 +03:00
アズタケ
81d582c051
fix review points and fine tuning
2022-09-16 21:08:25 +09:00
Dan Balasescu
e95983cdb4
Merge branch 'master' into fix-skin-flow
2022-09-16 20:15:51 +09:00
アズタケ
c0e2ba419e
Localize non-localizable setting items
2022-09-16 18:31:02 +09:00
Dean Herbert
38d8d457d9
Add back second completion post attempt for case when notification overlay isn't loaded yet
2022-09-16 17:54:44 +09:00
Dean Herbert
0d24fda4b9
Fire Notification.Closed immediately to ensure off-screen notifications are closed
2022-09-16 16:36:56 +09:00
Dan Balasescu
f86bbaae30
Merge branch 'master' into mods-effect-displays
2022-09-15 21:17:58 +09:00
Salman Ahmed
efebe55d22
Display certain sort criterias based on selected category and query
2022-09-15 04:30:09 +03:00
Salman Ahmed
de7dd29d79
Add "Nominations" and "Updated" sorting criteria in beatmap listing
2022-09-15 03:57:05 +03:00
Joseph Madamba
85e3a681b1
Fix notification overlay toast tray background absorbing input from behind
2022-09-13 21:07:30 -07:00
Dan Balasescu
ef6d60ffe9
Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards
...
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-14 10:25:24 +09:00
Salman Ahmed
04dbb6fc1b
Add inline comment
2022-09-14 00:49:02 +03:00
Dean Herbert
d368f37c3a
Remove redundant second Current set operation
2022-09-13 13:50:59 +09:00
Salman Ahmed
07f577a0c6
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-13 01:39:21 +03:00
ansel
8cbc0502ae
Inline CalculateEffect
2022-09-12 15:51:18 +03:00
Dean Herbert
88107108ee
Add ability to flick notifications to the right to store for later
2022-09-12 20:20:57 +09:00
Dean Herbert
802c5629c0
Merge branch 'master' into notification-fling
2022-09-12 20:09:21 +09:00
Dean Herbert
f31deaef7c
Simplify skin bindable flow
...
Now, nothing touches the configuration apart from `OsuGame`, making
everything else flow better and avoid weird cyclic set bugs.
Closes https://github.com/ppy/osu/issues/20234 .
2022-09-12 19:51:50 +09:00
Dan Balasescu
5bd0be14ed
Merge pull request #20259 from peppy/fix-changelog-crash
...
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 19:47:21 +09:00
Dean Herbert
cb6d02ec3a
Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset
...
Remove the nullable disable annotation in the ruleset class
2022-09-12 19:07:23 +09:00
Dean Herbert
d92e000fe6
Fix flinging a notification not correctly running Close
2022-09-12 19:00:03 +09:00
Dean Herbert
4ee3e8f087
Don't play fling animation when activating a notification
2022-09-12 18:57:18 +09:00
Dean Herbert
58c1ea0321
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 17:51:15 +09:00
Dean Herbert
d561fcb126
Don't trigger fling animation when Close is triggered by non-user action
2022-09-12 16:54:25 +09:00
Dean Herbert
5a02e1e713
Use padding instead of FillFlow.Spacing to avoid artifact during animation
2022-09-12 16:46:45 +09:00
Dean Herbert
a506178571
Make bounding box shrink faster to allow for rapid flinging
2022-09-12 16:39:46 +09:00
Dan Balasescu
bcbc867694
Merge branch 'master' into mods-effect-displays
2022-09-12 16:35:28 +09:00
Dean Herbert
931049aec1
Merge branch 'master' into notification-dismiss
2022-09-12 16:27:41 +09:00
Dean Herbert
bd3673baa9
Fix being able to drag after already closing a notification
2022-09-12 16:25:32 +09:00
Dean Herbert
8e6b2796eb
Merge branch 'master' into notification-fling
2022-09-12 16:19:36 +09:00
Dean Herbert
2476cf8fb3
Adjust movement to look less sudden when snapping back to Y=0
2022-09-12 15:37:48 +09:00
Dean Herbert
e06a0f7300
Fix dragged state not being exposed correctly
2022-09-12 15:21:01 +09:00
Dean Herbert
92beb6cbe7
Hide notification read light when in a toast state
...
Also adds test coverage of read state and light.
2022-09-12 15:17:45 +09:00
Dean Herbert
60b0b909a5
Move update icon to background to avoid colour collission with progress spinner
2022-09-12 14:58:46 +09:00
Dean Herbert
9ef23c79ce
Disallow forwarding during a drag operation
2022-09-11 22:05:44 +09:00
Dean Herbert
a56cadcf90
Ensure drag position is reset when transferred to tray
2022-09-11 22:03:29 +09:00
Dean Herbert
b5a2f7003e
Disallow flinging when not in toast state
2022-09-11 21:47:45 +09:00
Dean Herbert
d6f90e3b9f
Add basic fling-to-dismiss support
2022-09-11 21:32:22 +09:00
ansel
324a3723a5
Rewrite DMD
2022-09-10 23:23:04 +03:00
ansel
3f93ec8538
Expose counter to inheritors
2022-09-10 23:20:28 +03:00
ansel
667854b034
Make effect display have a built-in counter
2022-09-10 23:18:48 +03:00
Dean Herbert
a9094c6b03
Add test coverage of clicking close button to dismiss
2022-09-10 15:18:32 +09:00
Dean Herbert
efe3b1aa7b
Allow dismissing notifications without performing action using middle / right click
2022-09-10 15:10:37 +09:00
ansel
b056cac10a
Remove generic and add default implementation for CalculateEffect
2022-09-10 08:34:29 +03:00
andy840119
1398a7e11e
Property should accept the nullable state.
2022-09-10 10:46:40 +08:00
Salman Ahmed
5e4e3dfc2c
Fix markdown container not rendering certain text correctly
2022-09-10 02:55:20 +03:00
Dean Herbert
6e52dbb266
Update IsDisplayingToasts to check the flow count directly
2022-09-06 17:30:24 +09:00
Dean Herbert
9e3228aa65
Fix completion notification not being posted if completion occurs during NotificationOverlay load
2022-09-06 04:07:49 +09:00
Dean Herbert
510972e3ad
Avoid reference counting by using height calculation for IsPresent instead
...
The reference counting was to guarantee performance (zero allocations)
when the notification overlay was not required, but adds extra
complexity.
Instead, the toast tray now uses its ongoing height calculation as a
metric for presence.
2022-09-05 19:38:09 +09:00
Dean Herbert
0514c96191
Fix incorrect count tracking when notification is manually disposed
2022-09-05 19:26:40 +09:00
Dean Herbert
229e1a8ef7
Fix notification overlay being present when it doesn't need to
2022-09-05 19:13:58 +09:00
Dean Herbert
f754686521
Remove necessity of AlwaysPresent for ProgressUpdate completion posting
2022-09-05 19:13:58 +09:00
Dean Herbert
0d4ee6bd80
Centralise ability to fetch all toast tray notifications (including animating ones)
2022-09-05 18:42:20 +09:00
Dean Herbert
eca7b8f988
Fix completion notifications not always showing as toasts
2022-09-05 18:39:11 +09:00
Dean Herbert
4fa6707bf0
Set all progress notifications to non-important
2022-09-05 18:29:35 +09:00
Dean Herbert
7eaa4c5ccd
Update new usages of Remove / RemoveInternal
2022-09-01 23:05:34 +09:00
Dean Herbert
6a35b233e5
Merge branch 'master' into remove-dispose-updates
2022-09-01 23:03:19 +09:00
Dan Balasescu
afe2862df4
Merge branch 'master' into toast-notification-tray
2022-08-31 16:07:11 +09:00
Dan Balasescu
ccc08b816c
Merge pull request #20030 from peppy/notification-design-update
...
Update notification overlay design
2022-08-31 16:06:59 +09:00
Dean Herbert
8b9ccc66b7
Update ProgressNotification font spec to match other notifications
2022-08-31 12:49:28 +09:00
Dean Herbert
85442fe032
Adjust dismiss button background colour to avoid conflict with background
2022-08-31 12:48:30 +09:00
Dean Herbert
7c72c6b43f
Fix unread count potentially missing notifications in a transforming state
2022-08-31 12:46:43 +09:00
Dean Herbert
0558dae917
Mark toasts as read when closing the overlay for added safety
...
I'm not sure how the read status will play out going forward so I'm just
adding this to keep things conforming for now.
2022-08-31 12:46:04 +09:00
Dean Herbert
9eb615f942
Fix remaining test failures by strengthening PlayerLoader tests
...
- Click using `TriggerClick` as notifications move around quite a bit.
- Ensure any notifications from a previous test method are cleaned up.
2022-08-31 01:40:30 +09:00
Dean Herbert
31a9980686
Update remaining test expectations with new behaviour
2022-08-31 00:57:30 +09:00
Dean Herbert
a62ba9e0d9
Remove notification blocking behaviour of first run setup
2022-08-31 00:57:18 +09:00
Dean Herbert
ed11b1ba6f
Improve forwarding flow to not use piling delegates
2022-08-31 00:40:53 +09:00
Dean Herbert
224ab29ef4
Don't dismiss toasts while hovered (and adjust timings slightly)
2022-08-30 21:19:51 +09:00
Dean Herbert
403fc18976
Fix notification completion events not being run when overlay not visible
2022-08-30 21:13:43 +09:00
Dean Herbert
a7110666a0
Play notification appear sample immediately
2022-08-30 21:13:43 +09:00
Dean Herbert
95ce78a50c
Reduce notification post delay now that it's less important
2022-08-30 21:13:43 +09:00
Dean Herbert
b8300ae60a
Add toast notification tray
2022-08-30 21:13:43 +09:00
Dean Herbert
7b006f1f22
Add flash when a new notification is displayed to draw attention
2022-08-30 20:34:27 +09:00
Dean Herbert
60413e3e7b
Enable masking for main content to avoid underlap with close button on word wrap failure.
2022-08-30 19:17:41 +09:00
Dean Herbert
6b71b4656d
Remove ProgressNotification vertical movement and delay
2022-08-30 19:16:59 +09:00
Dean Herbert
d600058c98
Assert non-null in ProfileHeader to appease r#
2022-08-30 18:09:10 +09:00
Dean Herbert
c846bf20a7
Add background hover and adjust remaining metrics
2022-08-30 18:06:48 +09:00
Dean Herbert
bea12ab3c2
Rename NotificationContent to MainContent
2022-08-30 18:06:48 +09:00
Dean Herbert
09aa3e065d
Move colouring to full icon content rather than background
2022-08-30 18:06:48 +09:00
Dean Herbert
0f203531d9
Allow customising the "close" button icon
2022-08-30 18:06:48 +09:00
Dean Herbert
1484ae19f0
Initial design update pass
2022-08-30 18:06:48 +09:00
Dean Herbert
b8fda1a16f
Apply NRT to notification classes
...
and tidy things up a bit.
2022-08-30 15:57:10 +09:00
ansel
545e0bbcef
Adjust inheritors and test
2022-08-29 22:49:25 +03:00
ansel
5343c26452
Control colour via Current bindable
2022-08-29 22:48:27 +03:00
ansel
7faeed88b0
Add ability to override width of value area
2022-08-29 22:08:43 +03:00
Dean Herbert
a215d009fe
Update Remove/RemoveRange/RemoveAll calls in line with framework changes
2022-08-29 15:57:40 +09:00
Dan Balasescu
423f6f90f2
Remove async calls from ScoreManager
2022-08-29 15:34:08 +09:00
ansel
039f009562
Inherit difficulty multiplier display from ModsEffectDiplay
2022-08-27 20:26:05 +03:00
ansel
3e828c3416
Move base layout from DifficultyMultiplierDisplay to another class
2022-08-27 20:11:38 +03:00
Dean Herbert
6dc859973b
Merge branch 'master' into fix-playlist-overlay-test-failures
2022-08-26 20:25:53 +09:00
Bartłomiej Dach
968f656585
Merge branch 'master' into copyexternalurl-dialog
2022-08-24 21:21:11 +02:00
Dean Herbert
6a0d23cf96
Nest dialog class and apply NRT
2022-08-24 17:39:22 +09:00
Dean Herbert
9f9deef438
Reword slightly
2022-08-24 17:37:41 +09:00
Andrew Hong
9ee26c575d
Made button blue
2022-08-24 04:04:44 -04:00
Andrew Hong
b24513038c
Add popupdialog button to copy url
2022-08-24 03:35:19 -04:00
Andrew Hong
edd50dc05b
Add profile url context menu to user container
2022-08-24 03:07:03 -04:00
Dean Herbert
c840977acb
Fix filtering potentially not running after new items added
2022-08-23 20:42:20 +09:00
Dean Herbert
058d67f8e8
Merge pull request #19695 from naoei/ruleset-localization
...
Change most ruleset-accessible string types to Localisable strings
2022-08-22 16:13:23 +09:00
Dan Balasescu
0815b01b75
Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation
...
Fix selecting preset containing Difficulty Adjust automatically opening customisation panel
2022-08-22 15:44:00 +09:00
Dean Herbert
d199b3b100
Update GetVariantName to also support localisation
2022-08-22 14:51:00 +09:00
Dan Balasescu
e1fa959f0b
Fix language change removing mod column bold text
2022-08-22 13:00:47 +09:00
Bartłomiej Dach
aa15e84bea
Adjust rounding in mod select difficulty multiplier to match song select footer
...
The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would
cause the difficulty multiplier to use a different midpoint rounding
strategy than `double.ToString()`, which is the one that the song select
footer relies on. For example, a value of 0.015 would be rounded down
to 0.01 by `double.ToString()`, but rounded up to 0.02
by `BindableDouble`.
Fix the discrepancy by just deleting the `Precision` spec. Since the
value of the bindable would go through `ToLocalisableString(@"N2")`
anyway, it was redundant as is.
Fixes #19889 .
2022-08-21 23:15:49 +02:00
Bartłomiej Dach
3d14b14cfe
Use alternative method for checking panel readiness to eliminate bool flag
2022-08-17 21:56:11 +02:00
Bartłomiej Dach
3109066e34
Rename {Requires -> Pending}Configuration
2022-08-16 22:45:24 +02:00
Bartłomiej Dach
6bfdfeb153
Refactor mod panel selection logic to avoid overwriting
2022-08-16 22:41:35 +02:00
Bartłomiej Dach
10daac6752
Only open mod customisation panel on explicit selection of single mod
2022-08-15 20:38:23 +02:00
Bartłomiej Dach
f860bc11ee
Fix several schedule-related issues arising from new column addition
2022-08-15 20:38:16 +02:00
Bartłomiej Dach
5ff2e41a55
Add preset column to mod select test scene
2022-08-15 18:38:37 +02:00
Nao
c940f5abcb
Merge branch 'master' into ruleset-localization
2022-08-14 15:17:44 -04:00
naoei
45e9eda9e7
Localise hit result name
2022-08-14 14:57:02 -04:00
basseX
383afe04f3
Remove not needed override
2022-08-14 15:15:36 +02:00
basseX
932becc4b2
Remove CommentMarkdownTextFlowContainer and rather use base-class OsuMarkdownTextFlowContainer
2022-08-14 10:11:49 +02:00
basseX
b05acb0073
Make CommentMarkdownTextFlowContainer render images
2022-08-13 21:32:24 +02:00
Dean Herbert
b76e5757e1
Fix InSelectedCollection not being applied to newly imported beatmaps
2022-08-12 15:06:34 +09:00
Dean Herbert
5111bad86c
Refactor TestScenePlaylistOverlay to use realm for testing
...
Removes the dual-purpose flow which existed only for testing.
2022-08-12 15:06:34 +09:00
Dan Balasescu
1721a91168
Merge pull request #19661 from peppy/overlay-key-binding-organisation
...
Reorganise global bindings and split out overlay bindings to make things easier to find
2022-08-10 21:18:28 +09:00
Dan Balasescu
76fea25668
Merge pull request #19646 from its5Q/settings-localisation
...
Add missing localisation for settings enums
2022-08-10 18:51:52 +09:00
Dan Balasescu
888c4c8e08
Merge pull request #19662 from peppy/startup-correct-username
...
Use a placeholder user with the correct username during login process
2022-08-10 13:09:37 +09:00
its5Q
abca3d1b2a
Prefix common strings for context
2022-08-10 00:35:19 +10:00
Dean Herbert
beb3d41f0c
Fix unsafe usage of APIAccess.LocalUser in BeatmapListingOverlay
2022-08-09 17:11:44 +09:00
Dean Herbert
a71c2bbe28
Split overlay toggles into own section in key bindings
...
Things were getting hard to find..
2022-08-09 17:01:38 +09:00
Dean Herbert
32852e5b21
Fix potentially thread-unsafe LocalUser usage
2022-08-09 16:01:04 +09:00
Dean Herbert
5d8bd1de28
Share localised strings with expanded display message
2022-08-09 15:57:16 +09:00
Dean Herbert
3f8cedff3a
Add tooltips showing current connecting status
2022-08-09 15:51:27 +09:00
Dean Herbert
c35b4ef914
Display connecting / failing states on toolbar user display
2022-08-09 15:51:10 +09:00
Bartłomiej Dach
f74fb3491e
Use alternative implementation of preset panel cleanup
2022-08-08 21:08:54 +02:00
Bartłomiej Dach
a0a6e1faee
Fix spurious sample playbacks from already-removed panels
2022-08-08 20:30:55 +02:00
Bartłomiej Dach
f21a51aa24
Simplify mirror copy of task logic in ModColumn
2022-08-08 19:20:50 +02:00
Bartłomiej Dach
00333fb0d2
Change ?? false test to == true for legibility
2022-08-08 19:19:13 +02:00
its5Q
5080d62e77
Add missing localisation for settings enums
2022-08-08 21:51:23 +10:00
Dean Herbert
070d156e89
Simplify task logic in ModPresetColumn
2022-08-08 16:13:52 +09:00
Bartłomiej Dach
7d6efaebbe
Add maintenance settings section for mod presets
2022-08-07 16:20:31 +02:00
Bartłomiej Dach
839409d7ac
Add preset column to solo mod select overlay
2022-08-07 16:20:31 +02:00
Bartłomiej Dach
b318bbd5e6
Allow non-homogenous column types in mod select overlay
2022-08-07 16:20:31 +02:00
Bartłomiej Dach
0287c49ca8
Implement user selection logic for mod presets
2022-08-07 16:20:20 +02:00
Bartłomiej Dach
b1dcd7821c
Automatically toggle preset panels if selected mods match
2022-08-07 15:30:20 +02:00
Dean Herbert
4a95638756
Merge branch 'master' into mod-overlay/delete-preset
2022-08-07 12:34:25 +09:00
Dean Herbert
5946124278
Merge pull request #19612 from bdach/mod-overlay/common-delete-dialog
...
Unify implementations of deletion dialogs
2022-08-07 12:18:03 +09:00
Bartłomiej Dach
9b3183b2b4
Implement mod preset deletion flow
2022-08-06 21:58:55 +02:00
Bartłomiej Dach
a0d093be5c
Extract common implementation of delete dialog
2022-08-06 21:04:12 +02:00
Bartłomiej Dach
ab1b38242f
Reorder enum cases to match web order
2022-08-06 18:34:30 +02:00
Bartłomiej Dach
6a9c30c47a
Fix some more wrong icon colours
2022-08-06 18:34:00 +02:00
Bartłomiej Dach
2ba127b6fc
Fix wrong icon for approval event
2022-08-06 18:30:49 +02:00
Bartłomiej Dach
f1e0dd2da3
Match approval type-dependent icon appearance with web
2022-08-06 18:29:24 +02:00
Bartłomiej Dach
f3ecd73e0b
Add references to web source in recent activity icon
2022-08-06 18:23:15 +02:00
LukynkaCZE
3000d9b9c6
Inline everything in RecentActivityIcon
2022-08-06 07:16:34 +02:00
LukynkaCZE
bd27995c71
Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section
2022-08-06 05:55:51 +02:00
Dean Herbert
6823282604
Fix PlayButton potentially not disposing an unused PreviewTrack during load
2022-08-05 14:15:27 +09:00
Bartłomiej Dach
ca1b4689cb
Automatically focus name textbox upon add preset popover open
2022-08-03 21:26:35 +02:00
Bartłomiej Dach
159d3b032c
Rename locals for legibility
2022-08-03 21:23:31 +02:00
Bartłomiej Dach
82d3fbd51b
Split AddPresetPopover to separate file
2022-08-03 21:22:55 +02:00
Bartłomiej Dach
add2971eb4
Implement preset creation flow with test coverage
2022-08-02 22:05:54 +02:00
Bartłomiej Dach
7251389e43
Add localisations for add preset button
2022-08-02 22:05:34 +02:00
Bartłomiej Dach
059a465fe8
Add border to popover for better visual contrast
2022-08-02 22:03:33 +02:00
Bartłomiej Dach
1b3074d098
Implement popover for creating mod presets
2022-08-02 22:03:33 +02:00
Bartłomiej Dach
085080576a
Add button for creating new mod presets
2022-08-02 22:03:32 +02:00
Dean Herbert
34ffc51c51
Avoid clearing chat overlay textbox when pressing "back" key binding
...
Generally this is expected behaviour for usages of focused text boxes
(ie. to clear search content), but not so much here.
Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395 .
2022-08-02 13:56:03 +09:00
notmyname
6686b09549
Hide F rank from beatmap overlay
2022-08-01 18:54:00 +02:00
Salman Ahmed
2a127c6ef8
Merge branch 'master' into fix-tags-overflow
2022-08-01 12:40:43 +03:00
Gutyina Gergő
c65747d1b8
Use masking instead of scrollable container to prevent tags overflow
2022-08-01 10:36:53 +02:00
Dean Herbert
2f60f91a0e
Fix editor potentially using a track post-disposal
...
This changes the editor to track the current track as it is *loaded* by
`MusicController`, rather than haphazardly following the current global
`WorkingBeatmap` (with a potentially unloaded track) or relying on local
immediate-load behaviour (as implemented in `ResourcesSection`).
2022-08-01 16:53:49 +09:00
Bartłomiej Dach
85f77abee1
Fix code quality inspection about ambiguous equality
2022-07-31 23:53:46 +02:00
Bartłomiej Dach
345f103119
Migrate mod preset column to use realm
2022-07-31 23:53:45 +02:00
Gutyina Gergő
98214beb6c
Prevent overflow on beatmap info using scrollable container
2022-07-31 21:24:41 +02:00
Dan Balasescu
aa03df905f
Merge pull request #19441 from peppy/test-working-beatmap-unfuck
...
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
Dean Herbert
a21aee4e9c
Reduce calls to LoadTrack by implicitly running on test/dummy classes
2022-07-28 18:11:40 +09:00
Dean Herbert
ca68574473
Make NotificationOverlay dependency optional in CollectionSettings
2022-07-28 14:35:27 +09:00
Dean Herbert
ad482b8afc
Tidy up naming of collection dropdowns
2022-07-28 13:57:21 +09:00
Dean Herbert
438067a18b
Convert realm data propagation to more correctly use Live<T>
...
wip
2022-07-27 19:35:09 +09:00
Dean Herbert
41393616d8
Replace BeatmapCollection with RealmBeatmapCollection
2022-07-27 19:35:09 +09:00
Dean Herbert
9c543fef48
Remove CollectionManager
2022-07-27 18:45:33 +09:00
Dean Herbert
c30e8047ab
Merge pull request #19375 from novialriptide/contextmenu-external-beatmap
...
Add ContextMenu to beatmap external link
2022-07-26 19:06:10 +09:00
Dean Herbert
1539fa704b
Always allow selecting the top-most button using the select binding
2022-07-26 17:46:23 +09:00
Andrew Hong
003aec86ae
Rearrange sizeaxes
2022-07-26 04:27:22 -04:00
Dean Herbert
ee0c67e114
Add ability to make cursor show even during touch input
...
I completely disagree with this from a UX perspective, but it's come up
so often that I figure we should just let users bone themselves.
2022-07-26 14:08:00 +09:00
Andrew Hong
a8e315abf0
Refactor
2022-07-25 17:16:33 -04:00
LukynkaCZE
a7c92fe5d6
Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section
2022-07-25 14:56:00 +02:00
Andrew Hong
fcf767e28b
Add contextmenu to beatmap external link
2022-07-25 04:07:33 -04:00
Salman Ahmed
4d90e6bbac
Flip method to read better
2022-07-25 10:03:06 +03:00
Salman Ahmed
e402e919ab
Display placeholder for user profile scores
2022-07-25 09:40:20 +03:00
Salman Ahmed
f54cee0270
Display placeholder for leaderboard top scores
2022-07-25 09:18:04 +03:00
Salman Ahmed
91d1c9686c
Separate unprocessed PP placeholder to own class
2022-07-25 09:07:51 +03:00
Salman Ahmed
54eb2b98a9
Display exclamation triangle on scores with unprocessed PP
2022-07-25 07:30:57 +03:00
Salman Ahmed
3beb1da3de
Merge branch 'master' into beatmap-overlay-null-pp
2022-07-25 07:18:03 +03:00
Bartłomiej Dach
446485f804
Move localisation string to common location
2022-07-24 23:30:52 +02:00
Bartłomiej Dach
8af9cfbe40
Add readonly modifier
2022-07-24 23:29:18 +02:00
Bartłomiej Dach
6a67d76d7c
Add basic mod preset column implementation
2022-07-24 16:39:04 +02:00
Bartłomiej Dach
b2f8934117
Extract base mod select column presentation logic
2022-07-24 16:39:03 +02:00
Salman Ahmed
7c477e6f22
Fix beatmap overlay leaderboard not handling null PP scores properly
2022-07-24 04:20:49 +03:00
LukynkaCZE
1aa0d49d81
Code Quality
2022-07-23 12:27:24 +02:00
LukynkaCZE
9db06fafd0
Fix code formatting
2022-07-23 12:16:11 +02:00
LukynkaCZE
33b442d5d0
Add missing icons to UserProfileRecentSection
2022-07-23 12:06:30 +02:00
Salman Ahmed
2829a7e836
Merge branch 'master' into beatmap-overlay-modded-stats
2022-07-23 10:38:13 +03:00
Salman Ahmed
661c79baf6
Add explanatory comment
2022-07-23 10:16:11 +03:00
Adam Baker
06462c13dd
Overwrite IBindable<ReadOnlyList<Mod>> cache in BeatmapSetOverlay
...
Implement fix as suggested
2022-07-22 23:15:24 -05:00
Adam Baker
d451bc8fda
Revert commits
...
This reverts commit 28586c704dd9d35bb847
2022-07-22 22:25:49 -05:00
Bartłomiej Dach
f3ceabc53f
Rename ModSelect{Overlay -> }Panel
2022-07-22 19:17:22 +02:00
Adam Baker
d9d35bb847
Set BeatmapSetHeaderContent details to not show modded values
2022-07-22 05:43:56 -05:00
Bartłomiej Dach
a3090003de
Add tooltip showing contents of mod preset
2022-07-21 23:29:21 +02:00
Bartłomiej Dach
bdff7f1ef4
Implement basic appearance of mod preset panels
2022-07-21 23:29:21 +02:00
Bartłomiej Dach
6cd18fad99
Fix code inspections after base panel class extraction
2022-07-21 23:29:08 +02:00
Bartłomiej Dach
d796b7d53c
Extract base mod select overlay panel presentation logic
2022-07-21 22:37:00 +02:00
Dan Balasescu
7dfc18a0e3
Merge pull request #19208 from frenzibyte/remove-score-multiplier-on-custom-mod-settings
...
Remove score multiplier on difficulty-increasing mods with customised settings
2022-07-20 20:12:59 +09:00
Dean Herbert
62133fa069
Merge pull request #19246 from frenzibyte/fix-wiki-navigation
...
Fix wiki overlay not handling path redirection properly
2022-07-20 20:08:11 +09:00
Salman Ahmed
5e933cb466
Improve comment wording
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-07-20 09:43:32 +03:00
Salman Ahmed
474c1a8a7a
Fix wiki overlay not handling path redirection properly
2022-07-20 09:06:11 +03:00
Salman Ahmed
6ce6f6f7df
Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings
2022-07-20 08:57:43 +03:00
Salman Ahmed
1270abdf42
Highlight perfect slider tick/end values in beatmap info leaderboards
2022-07-20 00:53:10 +03:00
Salman Ahmed
4210ec6502
Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings
2022-07-19 19:21:26 +03:00
Salman Ahmed
89653b74c7
Only add setting tracker when customisation is permitted
2022-07-19 19:21:16 +03:00
Salman Ahmed
b5c7d07ba8
Merge branch 'master' into fix-user-profile-overlay
2022-07-18 10:27:33 +03:00
Dean Herbert
a7f19cc796
Merge pull request #19137 from frenzibyte/country-enum
...
Replace `Country` class with enumeration
2022-07-18 16:12:24 +09:00
Salman Ahmed
e4d11febc5
Remove no longer necessary fallback
2022-07-18 09:47:40 +03:00
Salman Ahmed
84c1c26a7f
Merge branch 'master' into fix-user-profile-overlay
2022-07-18 09:45:25 +03:00
Salman Ahmed
018da74fe8
Replace default with CountryCode.Unknown
2022-07-18 08:54:35 +03:00
Salman Ahmed
100c53f9ef
Country -> CountryCode
2022-07-18 08:40:34 +03:00
Salman Ahmed
eddae7b143
Fix mod overlay and footer not updating multiplayer on settings change
2022-07-18 07:38:56 +03:00
Salman Ahmed
b33f8aa0fc
Fix "Start Chat" on multiplayer/playlist chat not opening overlay
2022-07-18 06:45:00 +03:00
Salman Ahmed
7e4ce89981
Include mod settings in profile score mod icons
2022-07-18 04:03:18 +03:00
tsunyoku
a5d7075ef1
simplify beatmap metadata logic in DrawableProfileScore
2022-07-17 18:10:47 +01:00
Dean Herbert
4e8bf1da52
Don't sent ruleset configuration failures to sentry
2022-07-18 01:23:46 +09:00
tsunyoku
7a6666996f
rename item to model in CreateDrawableItem
2022-07-17 14:50:53 +01:00
tsunyoku
486fbd2531
create instance of BeatmapInfo for use in ScoreBeatmapMetadataContainer
2022-07-17 14:47:04 +01:00
tsunyoku
7135329c8c
remove `PaginatedProfileScoreSubsectio, revert profile score drawables
2022-07-17 14:22:27 +01:00
tsunyoku
3a8b5d48b9
update PaginatedScoreContainer to use new class and format
2022-07-17 14:09:14 +01:00
tsunyoku
ef4237c4ac
create special subsection class for paginated profile scores
2022-07-17 14:08:31 +01:00
tsunyoku
e8d88e29c6
change DrawableProfileScore and DrawableProfileWeightedScore to take SoloScoreInfo and APIBeatmap instead of APIScore
2022-07-17 14:08:04 +01:00
Salman Ahmed
4968859e69
Rename placeholder display flag property to make sense
2022-07-16 06:07:53 +03:00
Salman Ahmed
e62049f4a9
Update various usages of Country inline with new enum
2022-07-16 05:04:24 +03:00
Salman Ahmed
838e9ec12e
Merge branch 'master' into placeholder-fixes
2022-07-15 20:22:25 +03:00
Dean Herbert
cf38b15332
Merge pull request #19124 from frenzibyte/song-select-metadata-search
...
Change clicking source/tags on song select to filter instead of searching online
2022-07-15 19:16:31 +09:00
Dean Herbert
437e01427c
Fix beatmap listing not entering correct search mode when arriving before LoadComplete
2022-07-15 17:53:44 +09:00
Dan Balasescu
c1dd1cfead
Merge pull request #19082 from peppy/api-solo-score-model
...
Add and consume `SoloScoreInfo`
2022-07-15 15:20:18 +09:00
Salman Ahmed
eafa11555a
Allow specifying custom search action to metadata sections
2022-07-15 06:41:03 +03:00
Dean Herbert
cd085cbd97
Merge pull request #19114 from frenzibyte/fix-potential-dialog-test-failure
...
Fix dialog overlay potentially pushing dialog while not loaded
2022-07-15 12:34:19 +09:00
Salman Ahmed
aea786ea0c
Fix minor typo
2022-07-15 05:56:49 +03:00
Dean Herbert
08396ba486
Adjust colouring to avoid weird banding during transition period
2022-07-14 14:47:25 +09:00
Dean Herbert
5dff48a1e0
Fix button selection animation not playing smoothly when new glyphs are loaded
2022-07-14 14:40:25 +09:00
Dean Herbert
5c6b4e498d
Protect against a potential early call to LanguageButton.Selected
2022-07-14 14:31:59 +09:00
Dean Herbert
227871e8df
Refactor hide logic a touch for better readability
2022-07-14 14:00:33 +09:00
Salman Ahmed
dccd81dbc7
Use BindValueChanged to handle changes between push time and schedule execution
2022-07-14 07:07:32 +03:00
Salman Ahmed
b96faedbe6
Fix dialog overlay hiding early-pushed dialog on initial PopOut call
2022-07-14 07:06:57 +03:00
Salman Ahmed
c59784c49f
Always schedule popup dialog push
2022-07-14 07:06:03 +03:00
Salman Ahmed
1222123541
Rename method and parameter
2022-07-14 07:05:19 +03:00
Salman Ahmed
3def8428aa
Make scheduling more legible
2022-07-14 06:06:58 +03:00
Salman Ahmed
f83d413b33
Fix dialog overlay potentially pushing dialog while not loaded
2022-07-14 06:05:03 +03:00
Dean Herbert
3b554140db
Use grid container to avoid layout changes when changing language
2022-07-13 23:22:55 +09:00
Dean Herbert
0db1caf591
Add language selection to first run overlay
2022-07-13 23:22:55 +09:00
Dean Herbert
f956955d4d
Combine ScoreInfo construction helper methods
2022-07-12 18:00:25 +09:00
Dean Herbert
1bef2d7b39
Add and consume SoloScoreInfo
2022-07-12 18:00:25 +09:00
Dan Balasescu
7086779cf4
Merge pull request #19026 from peppy/async-track-operations
...
Use fire-and-forget async operations on global track
2022-07-07 19:45:03 +09:00
Dean Herbert
d88fd8a5b0
Allow searching for "skins" to find current skin setting
2022-07-07 18:26:04 +09:00
Dean Herbert
7ef03dd2cb
Use fire-and-forget async operations on global track
...
This avoids any blocking overhead caused by a backlogged audio thread.
Test seem to pass so might be okay?
Note that order is still guaranteed due to the `ensureUpdateThread`
queueing system framework-side.
2022-07-07 17:15:45 +09:00
Dean Herbert
6fb00d84f9
Apply NRT to LoginForm and remove nullability of IAPIProvider
2022-07-06 01:29:00 +09:00
Dean Herbert
3a68f386a8
Add forgotten password link to login form
2022-07-06 01:25:04 +09:00
Dan Balasescu
9bf91835b6
Merge pull request #18962 from peppy/slider-range-control
...
Move star difficulty filter to song select
2022-07-03 21:58:00 +09:00
Salman Ahmed
9b833524c0
Merge branch 'master' into add-realm-blocking-logging
2022-07-02 12:41:36 +03:00
Dean Herbert
a03abc747b
Tidy up comments and simplify bounding box centre logic
2022-07-02 12:58:34 +09:00
Dean Herbert
4fd47b5fa0
Add more verbose logging to realm blocking process
2022-07-02 12:36:56 +09:00
Jamie Taylor
9d28d5f8ee
Update SFX for mod overlay show/hide
2022-07-01 20:43:12 +09:00
Salman Ahmed
5880b824d0
Simplify description logic for overlay tab items
2022-07-01 11:30:51 +03:00
Salman Ahmed
7f9ef6c23f
Merge branch 'master' into fix-overlay-header-tab-item-localisable-string
2022-07-01 11:27:00 +03:00
Dean Herbert
d54f7fc728
Move slider range control to song select
2022-07-01 14:41:36 +09:00
Salman Ahmed
87e3b44181
Ensure icon is loaded inside try-catch
2022-06-29 13:37:42 +03:00
Dean Herbert
6c64cea057
Catch a second location
2022-06-29 18:56:15 +09:00
Dean Herbert
569fde4b47
Add messages to all InvalidOperationExceptions
...
Without this, they can be very non-descript and hard to track down
2022-06-28 01:34:25 +09:00
Dan Balasescu
6c6de9ce53
Fix typo
2022-06-27 20:40:02 +09:00
Dean Herbert
50c1c066de
Add various logging of global WorkingBeatmap state changes
2022-06-27 18:41:31 +09:00
Dean Herbert
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
Dean Herbert
30eebf3511
Merge branch 'master' into c-sharp-10
2022-06-24 21:22:33 +09:00
Bartłomiej Dach
26c5b59f6d
Replace usages of string.To{Lower,Upper}()
2022-06-24 11:57:45 +02:00
Dean Herbert
f71f6302fd
Remove unnecessary null casts
2022-06-24 14:50:11 +09:00
Dean Herbert
d9c1a9d71f
Use new property to specify no tooltip, rather than passing only ruleset
2022-06-24 14:06:18 +09:00
Dean Herbert
7dec530ca5
Split out simple DifficultyIcon with no calculation overhead and update usages
2022-06-23 19:27:35 +09:00
Dean Herbert
b660119de7
Merge pull request #18796 from bdach/mod-overlay/legacy-key-bindings
...
Add setting option to toggle between mod overlay hotkey styles
2022-06-22 20:28:18 +09:00
Dan Balasescu
b81c7c7951
Merge pull request #18804 from Joehuu/online-view-chat-overlay
...
Add back online view container to chat overlay
2022-06-22 14:41:06 +09:00
Dan Balasescu
ff440fc1a4
Fix too many buttons inside condition
2022-06-22 13:44:41 +09:00
Dan Balasescu
321920bc85
Remove one more nullable disable
2022-06-22 13:44:41 +09:00
Dan Balasescu
1018c9852d
Cleanup nullability
2022-06-22 13:44:41 +09:00
Dan Balasescu
23254d2ff2
Fix broken files
2022-06-22 13:44:41 +09:00
Joseph Madamba
07e0cd53a4
Add back online view container to chat overlay
2022-06-21 19:23:16 -07:00
Joseph Madamba
50728f3fbc
Fix overlay header tab item not working with localisable string
2022-06-21 18:31:09 -07:00
Supersonicboss1
4aa86b0a80
fixed duplicates and cleaned up code
2022-06-21 23:41:25 +01:00
Supersonicboss1
e4931f977c
improved UI of maintenance section in settings
2022-06-21 23:00:03 +01:00
Bartłomiej Dach
7013909322
Remove unnecessary protected virtual
2022-06-21 16:43:04 +02:00
Bartłomiej Dach
f564ed589f
Alter sequential hotkey style to always use visible index
...
Previous behaviour was once mentioned off-hand as unintuitive.
2022-06-21 15:22:18 +02:00
Bartłomiej Dach
9e5cc89edb
Fix classic hotkeys toggling filtered mods
2022-06-21 15:01:33 +02:00
Bartłomiej Dach
da1814e7c3
Restructure everything to fix free mod overlay issue
2022-06-21 14:48:41 +02:00
Bartłomiej Dach
7b7b8c1892
Implement behaviour for classic selection style
2022-06-21 14:24:30 +02:00
Bartłomiej Dach
234120ff43
Forward entire event to IModHotkeyHandler
...
Required for shift handling in the classic implementation.
2022-06-21 13:37:17 +02:00
Bartłomiej Dach
658f5341c7
Set up flow for switching between hotkey styles
2022-06-21 13:34:58 +02:00
Bartłomiej Dach
5abd8a07d2
Add setting for changing mod select hotkey style
2022-06-21 13:33:17 +02:00
Bartłomiej Dach
73124d2b1f
Encapsulate mod hotkey selection logic in strategy pattern
2022-06-21 12:49:01 +02:00
Bartłomiej Dach
ee96d84ffa
Merge branch 'master' into input-settings
2022-06-20 22:55:43 +02:00
Dean Herbert
6515b249ec
Change data migration to do an immediate exit, rather than attempted exit
2022-06-19 12:39:58 +09:00
Dean Herbert
50e40756c4
Rename GracefullyExit to AttemptExit
2022-06-19 12:34:44 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Salman Ahmed
e4ddf03ad6
Fix toolbar music button handling keys while not hovered
2022-06-16 20:22:57 +03:00
Bartłomiej Dach
9c4f6d2ce0
Merge branch 'master' into first-run-setup-notification-interruption
2022-06-16 15:14:40 +02:00
Dean Herbert
251923c106
Convert NotificationOverlay to NRT
2022-06-16 17:28:08 +09:00
Dean Herbert
6b30ee0950
Tidy up DI and binding logic
2022-06-16 17:26:43 +09:00
Bartłomiej Dach
f88c568c8d
Update flag sizes after switch to twemoji assets
...
The old flags used a size of 150x100, while the new assets based on
twemoji use a size of 150x108. Update existing usages to match this new
aspect ratio better.
2022-06-15 21:45:47 +02:00
Salman Ahmed
e7dcbddbeb
Fix potential null reference
2022-06-15 18:53:49 +03:00
Salman Ahmed
026bad7fc4
Use notification processing mode logic instead
2022-06-15 18:13:24 +03:00
Dean Herbert
7571ab6c63
Merge branch 'master' into new-dialog-sfx
2022-06-15 19:47:00 +09:00
Dean Herbert
584345a97e
Merge pull request #18693 from frenzibyte/toolbar-volume-control
...
Add basic volume control support in toolbar music button
2022-06-15 17:50:10 +09:00
Dean Herbert
b3aa4fcf02
Adjust a channel rather than the overall sample
2022-06-15 17:33:07 +09:00
Dean Herbert
94aa2248ca
Move filter reset to more appropriate location
2022-06-15 17:32:21 +09:00
Dean Herbert
1f1633ddc2
Remove Update method processing of samples in PopupDialogDangerousButton
2022-06-15 16:50:23 +09:00
Salman Ahmed
583619b915
Use GlobalAction.DecreaseVolume instead
2022-06-15 10:21:27 +03:00
Dean Herbert
873806c2ea
Add keyboard adjustment support
2022-06-15 15:58:22 +09:00
Dean Herbert
3df9d7c9e1
Add a bit more animation when adjusting
2022-06-15 15:56:59 +09:00
Dean Herbert
5eb56ab814
Ensure Master volume is updated when scrolling on toolbar button
2022-06-15 15:41:40 +09:00
Jamie Taylor
af87722be8
Add audio feedback for 'Dangerous' dialog buttons
2022-06-15 15:41:27 +09:00
