9296 Commits

Author	SHA1	Message	Date
Dean Herbert	aff32b0d19	Merge branch 'master' into skin-components-list	2021-05-06 14:17:33 +09:00
Salman Ahmed	2a67361dc0	OnOperation -> TriggerOperation	2021-05-05 21:50:16 +03:00
Bartłomiej Dach	3cac837acf	Merge branch 'master' into skin-bindables	2021-05-05 20:16:27 +02:00
Dean Herbert	cb8bda2248	Merge pull request #12503 from Denrage/split-BufferedWedgeInfo	2021-05-06 03:16:16 +09:00
Dean Herbert	cffeb8641f	Make setters private for protected containers	2021-05-06 02:14:57 +09:00
Dean Herbert	fe9ade6754	Rename Container to DisplayedContent	2021-05-06 02:14:04 +09:00
Denrage	b6b9a69601	Removed unnecessary class for wrapping	2021-05-05 18:50:49 +02:00
Denrage	bb385f4255	Reverted difficulty and mod updates	2021-05-05 18:15:59 +02:00
Denrage	2797507758	Reorganized elements for readability	2021-05-05 17:56:07 +02:00
Denrage	88506a51dd	reduced complexity	2021-05-05 17:51:29 +02:00
Denrage	5049e2fbf9	Refactored out changes in DifficultyColourBar	2021-05-05 15:28:33 +02:00
Dean Herbert	4ef901d08d	Remove unnecessary redirection property to Container.Info	2021-05-05 21:07:49 +09:00
Denrage	cf6ed7a7cf	Refactored out changes in StarRatingDisplay	2021-05-05 13:13:37 +02:00
Dean Herbert	377af38d94	Remove unnecessary pixelSnapping parameter ... This was only required because there was text being rendered to the `BufferedContainer` content until now. Removing this should allow for better resolution in the background display (due to using a better minify scale mode).	2021-05-05 17:59:51 +09:00
Dean Herbert	805ef621e9	Merge branch 'master' into play-storyboard-outro	2021-05-05 17:51:16 +09:00
Dean Herbert	9ec3255c50	Fix SkipOverlay's FadeContent not getting correct state from parent	2021-05-05 17:50:25 +09:00
Salman Ahmed	eeeb001d62	Refactor combo colour retrieval logic to request skin lookups instead	2021-05-05 07:17:27 +03:00
Christine Chen	1472960319	Hide and disable skip outro overlay on rewind	2021-05-04 21:35:36 -04:00
Salman Ahmed	1ac80d42f9	Merge branch 'master' into corner-rotation-controls	2021-05-04 23:53:23 +03:00
Bartłomiej Dach	4185053120	Merge branch 'master' into fix-selection-handler-visibility	2021-05-04 20:21:05 +02:00
Dean Herbert	b380be7169	Add xmldoc for updateCompletionState	2021-05-04 16:43:51 +09:00
Dean Herbert	4c7a4239f8	Fix AllowGameplayOverlays potentially not working for outro skip overlay	2021-05-04 16:36:07 +09:00
Dean Herbert	b30145de40	Specify explicit primitive type	2021-05-04 16:35:50 +09:00
Dean Herbert	bb9fa1a25e	Merge branch 'master' into play-storyboard-outro	2021-05-04 14:01:34 +09:00
Salman Ahmed	8abff4881b	Hide the corresponding rotation handle when holding scale handle	2021-05-04 07:31:55 +03:00
Dean Herbert	4f12ae2711	Merge branch 'master' into split-BufferedWedgeInfo	2021-05-04 13:28:42 +09:00
Salman Ahmed	b2a0c2b563	Consider drag handles active using mouse down instead of when dragged	2021-05-04 06:41:26 +03:00
Salman Ahmed	5f33c3514e	Move selection box control internal events to drag handles	2021-05-04 06:37:22 +03:00
Salman Ahmed	fd7a6b3a7c	Finish transforms on controls load complete	2021-05-04 06:37:20 +03:00
Dean Herbert	ca4b860920	Move BindValueChanged call to LoadComplete	2021-05-03 20:11:24 +09:00
Dean Herbert	b28e1569ca	Remove no-longer-relevant matching comment	2021-05-03 20:09:50 +09:00
Salman Ahmed	840c22a3b1	Add back mis-removed fade transform	2021-05-03 12:16:40 +03:00
Dean Herbert	4f8240f19a	Merge branch 'master' into corner-rotation-controls	2021-05-03 18:02:23 +09:00
Dean Herbert	625890381f	Update ComboCounter components to use DI to attach data source	2021-05-03 17:43:00 +09:00
Dean Herbert	fdd0713988	Merge branch 'fix-selection-handler-visibility' into skin-bindables	2021-05-03 17:40:03 +09:00
Dean Herbert	3268a75f05	Remove intermediate container to fix tests	2021-05-03 17:35:56 +09:00
Dean Herbert	839ac968a9	Fix tooltips displaying for hidden SelectionHandler content	2021-05-03 17:28:24 +09:00
Dean Herbert	4cfa858dc4	Fix tooltips displaying for hidden SelectionHandler content	2021-05-03 15:37:15 +09:00
Dean Herbert	01984de9c7	Use existing GetStateFromSelection helper function	2021-05-03 15:13:32 +09:00
Dean Herbert	54abf8f6f6	Vertically centre leaderboard for now	2021-05-03 14:48:04 +09:00
Dean Herbert	b1a19b6dd6	Add xmldoc for PlayerIsolationContainer	2021-05-03 14:41:55 +09:00
Dean Herbert	2aa21e2aff	Adjust documentation in CatchUpSyncManager	2021-05-03 14:37:11 +09:00
Dean Herbert	8c9cfb6301	Remove unsafe access to Composer.HitObjects	2021-05-03 14:28:35 +09:00
Dean Herbert	c065092e72	Fix weird access to userIds in MultiplayerSpectatorScreen	2021-05-03 14:25:52 +09:00
Dean Herbert	dc5ee31d94	Use switch for screen construction	2021-05-03 14:04:20 +09:00
Dean Herbert	66ae6e58d1	Reword comment regarding LoadRequested special case to be easier to understand context	2021-05-03 14:01:10 +09:00
Dean Herbert	6da4105da6	Remove Sync namespace (feels unnecessary)	2021-05-03 13:38:53 +09:00
Dean Herbert	e0c129ca85	Merge branch 'master' into multiplayer-spectator-screen	2021-05-03 13:08:14 +09:00
Salman Ahmed	b83aa0bd76	Avoid LINQ in update	2021-05-02 06:21:14 +03:00
Salman Ahmed	0aa17e7c95	Rewrite selection box computation logic with RectangleF's helper methods	2021-05-02 02:51:06 +03:00
Salman Ahmed	07fe99025f	Use bounding box of blueprint for computing selection box area	2021-05-02 02:36:40 +03:00
Bartłomiej Dach	eef135f8dc	Merge branch 'master' into remove-unused-triangles	2021-04-30 21:51:23 +02:00
Salman Ahmed	b145f46a0a	Merge branch 'master' into skin-components-list	2021-04-30 21:10:55 +03:00
Dan Balasescu	e6eea73b8b	Merge branch 'master' into basic-compose-checks	2021-04-30 23:41:46 +09:00
Dean Herbert	e4f895b490	Fix editor buttons inheriting from TriangleButton when they have no need to	2021-04-30 14:48:37 +09:00
Dean Herbert	8b82a07914	Move skin-related interfaces out of HUD namespace	2021-04-30 13:10:42 +09:00
Dean Herbert	5585a7d438	Add basic interfaces for skinnable target containers	2021-04-30 13:10:42 +09:00
Dean Herbert	6442fb819f	Split out component from test scene and fix SongProgress	2021-04-30 13:10:42 +09:00
Dean Herbert	434e63d629	Add skin customisation support to song progress display	2021-04-29 16:12:15 +09:00
Dean Herbert	fd587a82ff	Replace abstract class with interface, attached to the actual components (not skinnable wrapper)	2021-04-29 16:12:15 +09:00
Dean Herbert	defa350aa7	Set defaults on SkinnableHUDComponent to cancel out relative size default ... Specifying locally on each HUD component looks to make more sense.	2021-04-29 16:12:15 +09:00
Dean Herbert	2540d6029c	Use AutoSize for SkinnableHudComponents	2021-04-29 16:12:15 +09:00
Dean Herbert	59339aa4fd	Add support for x/y position and scale back in	2021-04-29 16:12:15 +09:00
Dean Herbert	1cb8fc9a24	Extract editor classes out of test namespace and add anchor support	2021-04-29 16:12:15 +09:00
Dean Herbert	74fb7cd180	Extract storable attributes to bindables	2021-04-29 16:12:15 +09:00
Dean Herbert	fca173225a	Refactor editor selection/blueprint components to be generic	2021-04-29 16:12:14 +09:00
Dean Herbert	2d17219c8f	Setup basic test and classes for scale adjustment	2021-04-29 16:12:14 +09:00
Dean Herbert	9c62c90cfc	Refactor SelectionBlueprint and MoveSelectionEvent to work in screen-space coordinates ... Until now, the implementation of the overrides in `SelectionBlueprint` have been confusing to the point where I would just implement by trial-and-error (or copying from an existing implementation). This was due to a combination of using "object" space coordinates (ie. the thing the `Blueprint` is operating on) and screen-space coordinates. This change switches all event related coordinates to screen-space, which is how we already handle rotation/scale operations. With the introduction of other editor types where the related objects are drawables, this also makes a lot more sense.	2021-04-29 16:10:42 +09:00
Dean Herbert	f3c7694eeb	Rename methods to match generally how these find-methods are named elsewhere	2021-04-28 16:57:52 +09:00
Dean Herbert	48d6c9ac4b	Move snap/divisor helper methods to inside ControlPointInfo	2021-04-28 16:47:30 +09:00
Dean Herbert	e0906daebf	Change one remaining instance of incorrect terminology in xmldoc	2021-04-28 13:49:41 +09:00
Dean Herbert	4c9e94da2b	Move context menu logic to base class	2021-04-28 13:43:16 +09:00
Dean Herbert	532ec40395	Remove unnecessary newline	2021-04-28 12:04:48 +09:00
Dean Herbert	43772f4303	Remove duplicated call to initially select blueprint	2021-04-28 12:03:41 +09:00
Dean Herbert	e4f2e0131c	Rename AllowDeselection to better match use case	2021-04-28 12:02:55 +09:00
Dean Herbert	a9a5809e94	Fix incorrect xmldoc in MoveSelectionEvent	2021-04-28 11:46:52 +09:00
Dean Herbert	d0be8f9fb3	Remove one more out-of-date comment	2021-04-28 11:45:36 +09:00
Dean Herbert	bc455005a5	Fix incorrect coordinate space mention in xmldoc	2021-04-28 11:44:50 +09:00
Dean Herbert	61d4eb1777	Remove unnecessary and out-of-place xmldoc	2021-04-28 11:44:19 +09:00
Dean Herbert	aa1cb65eaa	Rename region to be more inclusive	2021-04-28 11:42:22 +09:00
Dean Herbert	42255f8d33	Rename and xmldoc selection completed method	2021-04-27 19:01:29 +09:00
Dean Herbert	7ec5ea1eb5	Remove hitobject terminology from base classes	2021-04-27 19:01:29 +09:00
Dean Herbert	ff06a27a12	Revert changes to OnBlueprint methods and handle select-on-addition locally	2021-04-27 19:01:29 +09:00
Dean Herbert	f97b14a20a	Fix binding direction of selected items	2021-04-27 19:01:29 +09:00
Dean Herbert	dd3d8e5d03	Make SelectionHandler abstract to ensure things get implemented	2021-04-27 19:01:29 +09:00
Dean Herbert	32416e4e31	Move model selection handling to base SelectionHandler class	2021-04-27 19:01:29 +09:00
Dean Herbert	eac139ca0e	Allow BlueprintContainer to perform movement without an ISnapProvider	2021-04-27 19:01:29 +09:00
Dean Herbert	f2e56bd306	Refactor editor selection/blueprint components to be generic	2021-04-27 19:01:29 +09:00
Naxess	7b9ed924be	Rename snapping methods ... Further separates them from `IBeatSnapProvider`'s `SnapTime`, and groups them together more, to prevent confusion between the two interfaces. Also changes the xmldoc of the reference time to that of `IBeatSnapProvider` for consistency.	2021-04-26 16:07:30 +02:00
smoogipoo	630a6dc46a	Fix missing dependency	2021-04-26 22:23:44 +09:00
smoogipoo	ed93e26e52	Use single method for starting/restarting spectator screen	2021-04-26 21:56:15 +09:00
smoogipoo	7e11d520d5	Remove finished players from multi spectator screen	2021-04-26 21:25:46 +09:00
smoogipoo	94d0b06493	Expose mute adjustment instead	2021-04-26 19:01:30 +09:00
smoogipoo	d7618b63fa	Fix test failure	2021-04-26 17:35:13 +09:00
smoogipoo	6626e70c95	Pass in master clock instead of slave clock	2021-04-26 17:30:27 +09:00
smoogipoo	5b4cb71cc7	Change terminology from "slave" to "player clock"	2021-04-26 17:19:44 +09:00
Dean Herbert	aa99c192d0	Fix type in inline comment	2021-04-26 16:21:12 +09:00
Dean Herbert	3b876a43c2	Merge branch 'master' into multiplayer-spectator-screen	2021-04-26 14:12:35 +09:00
Naxess	049e42fa85	Move snapping responsibility to IBeatmap ... Seems `EditorBeatmap` already implements a different kind of `SnapTime` from `IBeatSnapProvider`, so method names here aren't great. This is very similar to what https://github.com/ppy/osu/pull/12558 is doing, so may need to do some duplicate resolution later, especially surrounding `ClosestBeatSnapDivisor`. Worth noting that this change makes 1/7, 1/5, etc unsupported for now, as we now rely on `BindableBeatDivisor.VALID_DIVISORS`.	2021-04-26 05:07:24 +02:00
Salman Ahmed	485da47d89	Revert "Inherit VisibilityContainer and make duration constant protected" ... This reverts commit c58ef4230d. Uhh, how did I push this..	2021-04-26 01:41:42 +03:00
Salman Ahmed	b252485e1a	Remove protected expose of HandlingMouse setter ... Regardless of `OnDragEnd()`, `OnMouseUp()` will still be called resetting the value of that state back.	2021-04-25 20:13:23 +03:00
Salman Ahmed	7390a12e4b	SelectionBoxDragHandleDisplay -> SelectionBoxDragHandleContainer	2021-04-25 20:03:15 +03:00
Salman Ahmed	c58ef4230d	Inherit VisibilityContainer and make duration constant protected	2021-04-25 20:03:15 +03:00
Salman Ahmed	79e2b232d8	Improve English ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-04-25 19:26:53 +03:00
Salman Ahmed	a8c460f7df	Replace separated top-centered rotation button with rotation drag handles	2021-04-25 10:17:36 +03:00
Salman Ahmed	77f7d4c963	Add composite managing display of selection box drag handles	2021-04-25 10:17:36 +03:00
Salman Ahmed	ab71782674	Use colour fade transform for selection box controls ... To become harminous with the fade transforms of the rotation control	2021-04-25 10:14:31 +03:00
Salman Ahmed	62bcc5f76d	Add property for tracking whether control is during operation	2021-04-25 10:14:31 +03:00
Bartłomiej Dach	e937b778f6	Fix potential failure in ensureSourceClockSet() ... `ensureSourceClockSet()` was intended to only run when the adjustable source hasn't been set at all yet. As it turns out permitting it to run unconditionally can break the state of the underlying interpolated clock. This is caused by the following factors: * While the decoupleable clock is running, its `CurrentTime` does not come from either the source clock, or the internal stopwatch; it is instead calculated using the base `InterpolatingFramedClock` logic. * A source change of a decoupleable clock seeks the provided source clock to the decoupleable's current time. * When an interpolating clock is seeked (decoupleable clock is also an interpolating one), its interpolation state (`{Last,Current}InterpolatedTime`) are reset to 0. * If the interpolating clock determines that its current time is too far away from the source's time (which was set when the source is changed), it will ignore the source and instead continue to use its current time until the source clock has caught up. Overall, the source change is not really necessary if a source is already there. The only reason to ensure it was set was to make sure the first seek of the gameplay clock wasn't performed in decoupled mode. Therefore, add a guard to make sure the source is only set if there isn't one already.	2021-04-24 14:19:39 +02:00
Denrage	59ae5ab913	Added transition in StarRatingDisplay	2021-04-24 13:25:29 +02:00
Salman Ahmed	206fc94b8c	Add rotation drag handle component	2021-04-24 08:00:36 +03:00
Salman Ahmed	4bfa9cd6b6	Change inheritance of selection box buttons to base control instead	2021-04-24 08:00:29 +03:00
Salman Ahmed	decd8803bc	Abstract base appearence and hover update from drag handles	2021-04-24 07:45:53 +03:00
Bartłomiej Dach	fdb5490e51	Attempt to explain source initialisation better	2021-04-23 21:56:08 +02:00
smoogipoo	63a9484255	Expose WaitingOnFrames as mutable bindable	2021-04-23 19:11:47 +09:00
smoogipoo	575ec7c528	Document + refactor max player limitation	2021-04-23 19:11:35 +09:00
smoogipoo	ae2fd2f2e1	Ensure source is set on reset	2021-04-23 18:46:59 +09:00
Denrage	713344ebad	Reorganize methods	2021-04-23 10:31:49 +02:00
smoogipoo	90ecda91af	Fix exception	2021-04-23 00:06:54 +09:00
smoogipoo	4f0857f946	Xmldocs and general refactorings	2021-04-22 23:52:22 +09:00
smoogipoo	ee25949751	Rename classes	2021-04-22 23:39:02 +09:00
smoogipoo	8a0ba3a055	Merge GameplayIsolationContainer into PlayerInstance, remove track	2021-04-22 23:38:51 +09:00
smoogipoo	4aceb75eb2	Disable spectate button on closed rooms ... Doesn't have an effect normally - only for safety purposes in case we allow entering the match subscreen after a match has finished in the future.	2021-04-22 23:37:45 +09:00
smoogipoo	fd0b030cf4	Refactor gameplay screen creation	2021-04-22 23:37:33 +09:00
smoogipoo	f8f9cf9412	Merge branch 'fix-initial-playingusers' into multiplayer-spectator-screen	2021-04-22 23:25:25 +09:00
smoogipoo	64579d50ac	Use only single PlayerInstance for hit sample playback	2021-04-22 22:59:47 +09:00
smoogipoo	6588859c32	Remove loggings	2021-04-22 22:29:18 +09:00
Dan Balasescu	93b53f54fa	Merge pull request #12531 from peppy/editor-add-nudge-shortcuts ... Add simple key based time nudging support to editor	2021-04-22 21:14:51 +09:00
Dan Balasescu	50f37ef09c	Merge pull request #12519 from peppy/editor-hit-animation-toggle ... Add editor hit animation toggle	2021-04-22 20:49:21 +09:00
smoogipoo	6df23f1301	Merge branch 'master' into multiplayer-spectator-screen	2021-04-22 20:29:24 +09:00
Dean Herbert	a5364b224f	Add simple key based time nudging support to editor	2021-04-22 18:47:04 +09:00
Dean Herbert	1884c18a2c	Ignore movement operations which have no offset	2021-04-22 18:12:03 +09:00
Dean Herbert	daafa41dc1	Merge branch 'master' into fix-initial-spectator-state-callback	2021-04-22 16:22:04 +09:00
smoogipoo	1ca2152e61	Privatise + rename to SlaveGameplayClockContainer	2021-04-21 23:22:36 +09:00
smoogipoo	2bea625613	Fix initial playback states not being correct	2021-04-21 23:22:11 +09:00
Denrage	56a69ed956	Codestyle fixes	2021-04-21 15:53:28 +02:00
Denrage	0dfd0bb59d	Refactored background of BeatmapInfoWedge	2021-04-21 15:46:11 +02:00
Denrage	d6928e91fd	Removed BeatmapInfo in StarRatingDisplay	2021-04-21 15:43:48 +02:00
Denrage	9fba87f67a	Moved Info and Background into own container	2021-04-21 15:43:29 +02:00
Denrage	de04caeace	Fixed race condition in StarRatingDisplay	2021-04-21 13:53:08 +02:00
Dean Herbert	9d8f0c854d	Setup configuration item for editor hit animations	2021-04-21 18:05:40 +09:00
Dean Herbert	c6c91cd9a5	Refactor WaveformOpacityMenuItem to not receive whole config	2021-04-21 18:05:26 +09:00
smoogipoo	f32d00c0d9	Fix post-merge errors	2021-04-21 17:13:01 +09:00
smoogipoo	e78ef05fcf	Merge branch 'gcc-abstraction' into multiplayer-spectator-screen	2021-04-21 17:11:14 +09:00
smoogipoo	31c5fb350f	Merge branch 'master' into gcc-abstraction	2021-04-21 16:33:36 +09:00
smoogipoo	fb848f7544	Rename to MasterGameplayClock	2021-04-21 16:33:14 +09:00
Dean Herbert	26430e3cb5	Merge pull request #12492 from Naxesss/bg-audio-quality-checks ... Add background and audio checks	2021-04-21 00:10:32 +09:00
Denrage	e9571b72cf	Fixed InspectCode	2021-04-20 14:53:35 +02:00
Denrage	583754b22a	Removed unnecessary whitespaces	2021-04-20 14:29:53 +02:00
Denrage	df29e61147	Fix CodeFactor error	2021-04-20 14:22:49 +02:00
smoogipoo	a9e4a0ed50	Fix potentially starting play when finished ... The UserFinishedPlaying event may trigger before the event is subscribed to by SpectatorScreen. For such cases, an extra check is done to make sure the user is _actually_ playing.	2021-04-20 21:19:08 +09:00
Denrage	f799a6e733	Removed StarDifficulty binding passthrough	2021-04-20 14:18:41 +02:00
smoogipoo	156a518068	Merge branch 'master' into fix-initial-spectator-state-callback	2021-04-20 21:16:05 +09:00
Naxess	3e1b6b3b34	Simplify verifier run call args ... Uses the resolved working beatmap instead of resolving it every time. Also uses the EditorBeatmap itself as playable beatmap, as it is of type `IBeatmap` already, and `.PlayableBeatmap` forwards everything anyway.	2021-04-20 13:34:12 +02:00
Denrage	c5d35ab787	removed mods binding passthrough	2021-04-20 12:40:22 +02:00
Denrage	4e6cd8082e	WIP refresh BPM-Label on mod change	2021-04-20 12:00:04 +02:00
smoogipoo	ec080fcb32	Move seekOffset back to MasterGameplayClockContainer	2021-04-20 18:25:46 +09:00
smoogipoo	a683e5ec34	Seek using local method	2021-04-20 17:40:11 +09:00
Denrage	6e72ee5f76	Added bindable stardifficulty to StarRatingDisplay	2021-04-20 10:37:53 +02:00
Denrage	505a117862	splitted updateable part of wedge	2021-04-20 10:37:52 +02:00
smoogipoo	97fb90d9f4	Move clock processing to base.Seek()	2021-04-20 17:35:59 +09:00
Dean Herbert	60acd824cb	Add two sample implementations	2021-04-20 17:30:40 +09:00
smoogipoo	80473a356e	Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction	2021-04-20 17:27:01 +09:00
smoogipoo	3d6d26039a	Remove unused usings	2021-04-20 14:09:54 +09:00
smoogipoo	88ded95e75	Ensure clock is set in GCC.Start()	2021-04-20 13:56:13 +09:00
smoogipoo	8dd9134e3d	Move source clock adjustment application to Start()	2021-04-20 13:09:49 +09:00
smoogipoo	a92ae8ce76	Fix Reset() potentially not resetting to the intended start position	2021-04-20 13:01:42 +09:00
Naxess	496df411a7	Remove now unused import	2021-04-20 02:39:11 +02:00
Naxess	0e6b66f457	Merge branch 'master' into bg-audio-quality-checks	2021-04-20 02:36:13 +02:00
Naxess	8656176ab8	Add the playable beatmap as check argument ... This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor. So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`. This should be preferred over `workingBeatmap.Beatmap`.	2021-04-20 01:31:51 +02:00
Denrage	6bf6084ae9	fixed according to suggestions	2021-04-19 19:24:46 +02:00
Bartłomiej Dach	d5829fe638	Merge branch 'master' into playlist-unicode	2021-04-19 19:24:04 +02:00
Bartłomiej Dach	0825fc57a9	Move foreground colour helper into OsuColour	2021-04-19 18:24:48 +02:00
Bartłomiej Dach	97573fb11d	Merge branch 'master' into combo-colours-display	2021-04-19 18:21:57 +02:00
Denrage	9f24cdb355	Added Author Link in BeatmapInfoWedge	2021-04-19 16:54:09 +02:00
smoogipoo	acbf4580a4	Only set initial source in Reset()	2021-04-19 19:57:00 +09:00
smoogipoo	c7183f92f7	Rename Restart() -> Reset()	2021-04-19 19:57:00 +09:00
Dean Herbert	a40dcd4b8d	Add a touch more space in the timing column	2021-04-19 18:53:06 +09:00
Dean Herbert	097a347533	Adjust Add different background colour for timing area	2021-04-19 18:25:30 +09:00
Dean Herbert	5bce5d2057	Update design logic	2021-04-19 18:25:20 +09:00
smoogipoo	5397f4faba	Merge branch 'master' into fix-initial-spectator-state-callback	2021-04-19 16:49:06 +09:00
smoogipoo	c50b526ba0	Remove local state dictionary from SpectatorScreen	2021-04-19 16:48:55 +09:00
Dean Herbert	1ebc5ac5cc	Remove unused legacy class	2021-04-19 16:36:00 +09:00
Dean Herbert	8da561a2a6	Soften colours and adjust padding slightly	2021-04-19 16:35:36 +09:00
Dean Herbert	f8b20ca8aa	Add new display for effect row attribute	2021-04-19 16:35:36 +09:00
Dean Herbert	ec249a0edb	Add new display for sample row attribute	2021-04-19 16:23:28 +09:00
Dean Herbert	6465a72060	Add bubbled word class for use in attribute rows	2021-04-19 16:23:28 +09:00
Dean Herbert	3aad0a8b9c	Add new display for difficulty row attribute	2021-04-19 16:23:06 +09:00
Dean Herbert	d3cebfb6fb	Use explicit label	2021-04-19 16:23:06 +09:00
Dean Herbert	a10a8680d0	Add new display for timing row attributes	2021-04-19 16:23:06 +09:00
smoogipoo	ef3801b5dd	Add helper method supporting RomanisableString	2021-04-19 15:29:26 +09:00
Christine Chen	abfa6aec87	Remove completionState parameter	2021-04-19 01:58:19 -04:00
Dean Herbert	f4baff9e04	Make TimingScreen use rounded screen and adjust spacing/padding	2021-04-19 14:35:35 +09:00
Dean Herbert	e143afb598	Split out rounded content screen from SetupScreen for use in other places	2021-04-19 14:28:32 +09:00
Christine Chen	0b36dd9bce	Skip outro overlay and PerformExit() call updateCompletionState() instead of scheduleCompletion() ... Co-Authored-By: Marlina José <marlina@umich.edu>	2021-04-19 01:23:21 -04:00
Dean Herbert	513e470b52	Adjust grid spacing to allow attributes to use more width	2021-04-19 13:24:53 +09:00
Dean Herbert	0c918410d0	Make "add" button more visible	2021-04-19 13:15:24 +09:00
Dean Herbert	658c23c925	Give more space to the parameter adjustment area	2021-04-19 13:15:17 +09:00
Christine Chen	99fab456b5	Storyboard completion calls updateCompletionState ... - If the storyboard ends after the beatmap, call updateCompletionState as if the score processor has completed at that time. (completionProgressDelegate is null here since earlier when the score processor actually completed, updateCompletionState returned after showing the skip overlay.) - If the storyboard ends before the beatmap does, updateCompletionState simply returns and waits until the score processor is completed. - If the storyboard and beatmap end at the exact same time, make sure updateCompletionState() is called only once by the score processor completion. Co-Authored-By: Marlina José <marlina@umich.edu>	2021-04-18 23:25:20 -04:00
Bartłomiej Dach	6f2ebb20a7	Fix test failing due to null beatmap skin ... Also annotate the field on `EditorBeatmap` as nullable for future travelers.	2021-04-18 20:46:42 +02:00
Bartłomiej Dach	07a00cd681	Add colours section with combo colour display	2021-04-18 20:46:42 +02:00
Bartłomiej Dach	a8027d87b6	Fix unreadable colour hex code text due to low contrast ... Logic is shared with the timeline blueprints which also have the same problem of displaying text on top of a combo colour. Slightly modified the formula. Seems to yield better results on a subjective check.	2021-04-18 20:44:55 +02:00
PercyDan54	488001d570	Support SpriteText for LinkFlowContainer	2021-04-18 20:58:08 +08:00
Dean Herbert	cfc7664094	Use full path	2021-04-18 21:05:23 +09:00
Dean Herbert	e76565dbc5	Fix selection box not displaying after pasting a selection in the editor ... Closes #12471.	2021-04-18 20:28:39 +09:00
Salman Ahmed	f45aed1259	Remove new line between skip overlay fields	2021-04-18 07:25:52 +03:00
Salman Ahmed	f6a09be62d	Add further xmldoc	2021-04-18 07:25:49 +03:00
Salman Ahmed	a73bae7a66	Schedule completion when storyboard has actually ended	2021-04-18 07:25:33 +03:00
Salman Ahmed	2847dd7e05	Merge branch 'master' into play-storyboard-outro	2021-04-18 06:40:22 +03:00
PercyDan54	646403b826	Fix CI errors	2021-04-18 10:54:42 +08:00
PercyDan54	1339c126a4	Remove unused using	2021-04-18 09:54:50 +08:00
PercyDan54	cfaaf2e83e	Add ToRomanisableString()	2021-04-18 09:52:25 +08:00
Christine Chen	c77f838fb0	HasStoryboardEnded doesn't trigger updateCompletionState() ... Scores won't be shown prematurely if the storyboard ends before the playable portion of the beatmap.	2021-04-17 21:49:07 -04:00
Naxess	ef65c8910f	Fix resolved fields	2021-04-18 01:15:13 +02:00
Christine Chen	97bacbdc76	Show score after the end of the storyboard after it was toggled	2021-04-17 18:10:21 -04:00
Christine Chen	fdcb5e924c	Initialize skipOutroOverlay with alpha 0, other small changes	2021-04-17 17:45:38 -04:00
Christine Chen	81be562379	Read StoryboardEndTime directly from Beatmap	2021-04-17 12:28:31 -04:00
PercyDan54	512cec3458	Use unicode for playlists	2021-04-18 00:10:01 +08:00
Naxess	400f8b3938	Add GetStream to IWorkingBeatmap ... This is necessary to obtain the filesize of the audio and background files.	2021-04-17 17:47:13 +02:00
Naxess	448574e7e6	Use WorkingBeatmap instead of IBeatmap ... This lets us access things like the background, track, etc. which are necessary for quality and filesize checks. Also improves the structure of the `CheckBackgroundTest` class in the process.	2021-04-17 17:33:53 +02:00
smoogipoo	724fe3d378	Remove unnecessary method	2021-04-16 22:57:34 +09:00
smoogipoo	72ebcb157f	Dispose track on dispose	2021-04-16 22:57:27 +09:00
smoogipoo	4c5d4752b1	Rename classes to reduce redundant naming	2021-04-16 22:47:52 +09:00
smoogipoo	7d5d7088cd	Remove now unnecessary override	2021-04-16 20:51:07 +09:00
smoogipoo	c8d38f9983	Merge branch 'gcc-abstraction' into multiplayer-spectator-screen	2021-04-16 20:51:00 +09:00
smoogipoo	314b1646bd	Add xmldoc to MasterGameplayClockContainer	2021-04-16 20:47:09 +09:00
smoogipoo	3a78c19f96	More refactoring/xmldocs	2021-04-16 20:33:29 +09:00
smoogipoo	6301111fa3	Remove ClockToProcess, always process underlying clock	2021-04-16 20:17:21 +09:00
smoogipoo	a7aa3cb263	Merge branch 'gcc-abstraction' into multiplayer-spectator-screen	2021-04-16 20:16:26 +09:00
smoogipoo	f98ffbb1b3	Remove ClockToProcess, always process underlying clock	2021-04-16 20:15:42 +09:00
smoogipoo	5e82f40d67	Merge branch 'master' into gcc-abstraction	2021-04-16 20:14:53 +09:00
smoogipoo	65a6f9f8a4	Merge branch 'fix-initial-spectator-state-callback' into multiplayer-spectator-screen	2021-04-16 18:26:46 +09:00
smoogipoo	274e33184b	Fix SpectatorScreen potentially missing user playing callbacks	2021-04-16 18:22:22 +09:00
Dean Herbert	d9d50f0e88	Add border showing selected blueprints in timeline	2021-04-16 18:16:22 +09:00
Dan Balasescu	3c8e2b8b32	Merge branch 'master' into fix-potential-deselection-crash	2021-04-16 16:27:47 +09:00
Dan Balasescu	d3acbcced7	Merge pull request #12437 from peppy/fix-editor-placement-commit-false ... Fix placement blueprints not being correctly removed after a rolled back placement	2021-04-16 16:25:05 +09:00
Dean Herbert	c59906e925	Fix an occasional crash when deleting a HitObject via internal means	2021-04-16 15:55:33 +09:00
Dean Herbert	119c9b4294	Fix placement blueprints not being correctly removed after a rolled back placement	2021-04-16 14:11:33 +09:00
Christine Chen	33a665224e	Clean up skipOutroOverlay if skipping is disabled	2021-04-16 01:03:15 -04:00
Christine Chen	b15838b220	Move storyboard outro logic to DrawableStoryboard	2021-04-16 00:59:10 -04:00
Dean Herbert	42c066e6f2	Fix slider not displaying in timeline during zero-duration placement	2021-04-16 13:38:55 +09:00
smoogipoo	1c086d99de	Add loading spinner	2021-04-16 13:28:32 +09:00
smoogipoo	5ac0eb02cd	Always add player instances at first, populate later	2021-04-16 12:25:29 +09:00
Christine Chen	45c2b72a25	Merge branch 'master' into play-storyboard-outro	2021-04-15 15:11:35 -04:00
Christine Chen	25b8c2f257	Allow skipping storyboard outro ... Reuses SkipOverlay by calculating the endtime of the storyboard and using that as a "start point". Upon skipping the outro the score is instantly shown. When the end of the storyboard is reached the score screen automatically shows up. If the player holds ESC (pause) during the outro, the score is displayed The storyboard endtime is calculated by getting the latest endtime of the storyboard's elements, or simply returning 0 if there is no storyboard. Co-Authored-By: Marlina José <marlina@umich.edu>	2021-04-15 13:20:40 -04:00
Dean Herbert	c2340f1fe8	Move zoom settings back to run in a non-loaded state	2021-04-16 01:01:03 +09:00
Dean Herbert	15d48a924b	Set the timeline's height to a sane non-zero default ... This isn't required but makes the initial appearance animation nicer.	2021-04-16 00:58:32 +09:00
Dan Balasescu	a19f3bac35	Merge pull request #12408 from peppy/hide-top-right-elements-as-part-of-hud ... Hide top-right HUD overlay elements as part of HUD visibility	2021-04-15 23:29:55 +09:00
Dean Herbert	7cf15fe729	Merge pull request #12412 from peppy/timeline-adjustments ... Update timeline control point display	2021-04-15 22:43:26 +09:00
Andrei Zavatski	71b06d7e61	Simplify ExtendableCircle even more	2021-04-15 15:53:21 +03:00
Dan Balasescu	7beaf0ce55	Merge branch 'master' into timeline-adjustments	2021-04-15 21:51:00 +09:00
Dean Herbert	ad671ee07a	Merge branch 'master' into timeline-adjustments	2021-04-15 20:42:38 +09:00
Dan Balasescu	e3bf5f1bbb	Merge branch 'master' into summary-timeline-kiai-display	2021-04-15 20:41:31 +09:00
Dan Balasescu	6f17c19a48	Merge branch 'master' into summary-timeline-design-refactors	2021-04-15 20:11:39 +09:00
Dan Balasescu	b70dae7cf1	Merge pull request #12420 from peppy/round-timeline-ticks ... Add rounded corners to timeline ticks display	2021-04-15 20:11:20 +09:00
smoogipoo	b391a8f94e	Properly bind WaitingOnFrames	2021-04-15 19:37:45 +09:00
smoogipoo	33cc5c5cb3	A few more xmldocs	2021-04-15 19:35:57 +09:00
smoogipoo	82fcabb8f0	More refactorings/renamespacings/xmldocs	2021-04-15 19:32:55 +09:00
Dean Herbert	5b06a68b93	Merge pull request #12330 from Cublibre/master ... Send a warning notification if device is unplugged and at low battery	2021-04-15 19:21:04 +09:00
smoogipoo	df4fce2c57	Rename classes	2021-04-15 19:16:00 +09:00
smoogipoo	1705d472b5	Reimplement multiplayer syncing using new master/slave clocks	2021-04-15 19:12:52 +09:00
smoogipoo	fe3ba2b80e	Implement IAdjustableClock on GameplayClockContainer	2021-04-15 19:07:25 +09:00
Dean Herbert	0dc1577f68	Split out control point visualisation logic and add special kiai duration handling	2021-04-15 18:42:30 +09:00
Dean Herbert	153ee25510	Update base specifications to a more sane default	2021-04-15 18:42:07 +09:00
Dean Herbert	bf5af3310a	Update break colour to not look like kiai time	2021-04-15 17:04:11 +09:00
Dean Herbert	18e8682f39	Remove unused using statements	2021-04-15 17:01:25 +09:00
smoogipoo	33ad7850cb	Remove LastFrameTime	2021-04-15 16:45:59 +09:00
Dean Herbert	757475e6d4	Use correct representation colours	2021-04-15 16:39:20 +09:00
Dean Herbert	da6f9060fa	Centre end circles to avoid visual gaps	2021-04-15 16:39:20 +09:00
Dean Herbert	73821beb1d	Fix break display looking bad on very long beatmaps due to fixed corner radius	2021-04-15 16:39:20 +09:00
smoogipoo	6fc7488a67	Reimplement syncing logic as a new component	2021-04-15 16:33:59 +09:00
Dean Herbert	bc3b2af39d	Add rounded corners to timeline ticks display	2021-04-15 15:29:22 +09:00
smoogipoo	7993c2b880	Merge branch 'gcc-abstraction' into multiplayer-spectator-screen	2021-04-15 14:23:12 +09:00
Salman Ahmed	6c5234f8da	Move default IgnoreUserSettings value to construction	2021-04-15 08:04:03 +03:00
Salman Ahmed	92fd34cea9	Revert "Inverse ignore user settings bindable to "apply user settings" instead" ... This reverts commit 175b8da2b2.	2021-04-15 08:02:12 +03:00
Salman Ahmed	175b8da2b2	Inverse ignore user settings bindable to "apply user settings" instead	2021-04-15 07:34:20 +03:00
Salman Ahmed	a5fa14ac4a	Ignore user settings on background screen beatmap by default	2021-04-14 23:35:42 +03:00
smoogipoo	f56125bd68	Update clock from base class	2021-04-14 21:15:14 +09:00
Dean Herbert	d1c68cb92b	Simplify content creation of Timeline / TimelineArea	2021-04-14 21:03:52 +09:00
Dean Herbert	be08b9d1ef	Combine logic of Difficulty and Timing pieces where feasible	2021-04-14 20:55:34 +09:00
Dean Herbert	afbb674e52	TopLeft align check buttons so they don't move while interacting with them	2021-04-14 20:54:35 +09:00
Dean Herbert	99f05253fd	Adjust timeline sizing to closer match designs (but not 1:1 yet)	2021-04-14 20:54:35 +09:00
Dean Herbert	f9b1b7fe25	Update SamplePointPiece design	2021-04-14 20:54:35 +09:00
smoogipoo	774cca38c4	Make spectating instances use custom GCC	2021-04-14 20:39:14 +09:00
Dean Herbert	a8df2388eb	Update design for TimingControlPoint	2021-04-14 20:11:47 +09:00
Dean Herbert	1209c9fa32	Allow timeline to expand in height when control points are to be displayed	2021-04-14 20:10:50 +09:00
smoogipoo	54643f53e3	Merge branch 'gcc-abstraction' into multiplayer-spectator-screen	2021-04-14 19:56:58 +09:00
smoogipoo	18c69cdaf7	Split out files	2021-04-14 19:50:22 +09:00
smoogipoo	b53b30c1a9	Fix incorrect offset due to another intermediate Decoupleable clock	2021-04-14 19:33:55 +09:00
smoogipoo	2935f87e70	Fix IsPaused not being bound	2021-04-14 18:29:34 +09:00
Dean Herbert	26110cd777	Fix timeline not receiving input (being eaten by composer)	2021-04-14 18:17:27 +09:00
Dean Herbert	a314f90d37	Allow timeline to govern the size of the rest of the editor content	2021-04-14 18:17:27 +09:00
smoogipoo	1aa36818df	Abstractify GameplayClockContainer	2021-04-14 17:47:11 +09:00
Dean Herbert	e543db9bee	Use additive blending for background box ... Doesn't make a huge difference but this was intended.	2021-04-14 14:56:28 +09:00
Dean Herbert	b7d2821b55	Display the centre marker above the waveform ... Gives it a bit more visibility. This is where it was meant to sit, but didn't consider using a proxy drawable to make it work previously.	2021-04-14 14:52:48 +09:00
Dean Herbert	7654df94f6	Merge pull request #12395 from frenzibyte/fix-cinema-ignore-settings ... Fix beatmap background displayed if storyboard is hidden on "Cinema" mod	2021-04-14 14:31:03 +09:00
Dean Herbert	6044083cf7	Speed up the fade of the HUD a touch	2021-04-14 14:25:16 +09:00
Dean Herbert	65a1270f9a	Hide top-right HUD overlay elements as part of HUD visibility	2021-04-14 14:16:18 +09:00
smoogipoo	69b01e7270	Add some debugging	2021-04-14 00:58:03 +09:00
smoogipoo	77830527e7	Fix spectate button being disabled during play	2021-04-13 23:57:16 +09:00
Dean Herbert	21e8e5fbca	Move common table layout logic into EditorTable abstract class	2021-04-13 23:26:19 +09:00
smoogipoo	d49b90877e	Fix operation remaining in progress	2021-04-13 23:21:48 +09:00
Dean Herbert	0edc1a850d	Split out common EditorTable base class	2021-04-13 23:05:58 +09:00
Dean Herbert	1ff4e2076f	Merge branch 'master' into verify-tab	2021-04-13 23:05:48 +09:00
smoogipoo	3039b7b0f9	Make tests a bit more resilient	2021-04-13 22:40:24 +09:00
smoogipoo	20823abb30	Make resyncing a bit more resilient	2021-04-13 22:10:35 +09:00
Andrei Zavatski	e601141be2	Simplify ExtendableCircle component	2021-04-13 14:57:02 +03:00
smoogipoo	627dd960b0	Disable player input for now	2021-04-13 20:52:20 +09:00
Dan Balasescu	1505a38164	Merge pull request #12396 from peppy/update-timeline-slider-apperance ... Update timeline slider/spinner apperance	2021-04-13 20:47:44 +09:00
Dan Balasescu	b2aa46690d	Merge pull request #12389 from peppy/fix-editor-ctrl-drag-deselection ... Fix ctrl-dragging on an existing selection unexpectedly causing deselection	2021-04-13 20:38:29 +09:00
smoogipoo	5b53a2b211	Merge branch 'master' into multiplayer-spectator-screen	2021-04-13 20:07:56 +09:00
Dean Herbert	464fc02875	Fix some styling issues with the verify screen layout	2021-04-13 19:55:17 +09:00
Dean Herbert	03ba04e8ce	Split out general checks into its own verifier class (and remove static usage)	2021-04-13 19:50:22 +09:00
Dean Herbert	2c1f20a38f	Merge branch 'master' into fix-editor-alt-scroll	2021-04-13 19:36:25 +09:00
Dean Herbert	e7b0042a60	Remove unnecessary hover / shadow logic	2021-04-13 19:30:20 +09:00
Dean Herbert	b2c17979de	Update colours of all overlay components in one swoop (based off combo colour)	2021-04-13 19:26:20 +09:00
Dean Herbert	495fdd8d65	Update drag area display to match new design logic	2021-04-13 19:26:20 +09:00
Dean Herbert	109ee395bf	Fix input and remove outdated hover logic	2021-04-13 19:26:20 +09:00
Dean Herbert	00f235760d	Update visual appearance of timeline blueprints to close match new designs	2021-04-13 19:26:20 +09:00
Dean Herbert	2884ed3ab9	Merge pull request #12350 from smoogipoo/multiplayer-spectator-player-grid ... Add the multiplayer spectator player grid	2021-04-13 19:25:32 +09:00
Dan Balasescu	fd32c7d7df	Merge pull request #12393 from peppy/update-timeline-design-a-bit ... Update timeline tick display to differentiate tick type using width	2021-04-13 18:14:58 +09:00
Salman Ahmed	7c53bebfd4	Fix beatmap background not hiding when user settings ignored and storyboard replaces background	2021-04-13 12:00:13 +03:00
Naxess	60c2494b31	Make BeatmapVerifier an interface	2021-04-13 10:40:56 +02:00
Salman Ahmed	36510309d1	Merge EnableUserDim and IgnoreUserSettings to one bindable	2021-04-13 10:58:56 +03:00
Dean Herbert	27e851c2ee	Also adjust height	2021-04-13 16:43:29 +09:00
Dean Herbert	ebf97ff48f	Update timeline ticks to use width as a differentiation method, rather than height	2021-04-13 16:29:35 +09:00
Dean Herbert	273099d53c	Don't store online IDs from score submission responses for now ... Closes remaining portion of https://github.com/ppy/osu/issues/12372.	2021-04-13 14:31:44 +09:00
Dean Herbert	66e74da2b7	Fix regression in quick delete mouse action blocking	2021-04-13 13:03:14 +09:00
Christine Chen	f66306a81a	Remove IsLowBattery	2021-04-12 11:15:24 -04:00
Christine Chen	43b97fe0ad	Refactor PowerStatus (now called BatteryInfo)	2021-04-12 10:52:52 -04:00
Naxess	008dbc7dd6	Reverse IssueType ordering ... Reversed both in the enum and where it's displayed, so ends up the same in the end.	2021-04-12 15:49:13 +02:00
Naxess	1c69829ad4	Fix Template.Origin -> Check	2021-04-12 15:47:58 +02:00
smoogipoo	c531e38a36	Rework to create a derived tracked user data instead	2021-04-12 22:00:27 +09:00
smoogipoo	27660265b5	Merge branch 'master' into multiplayer-spectator-leaderboard	2021-04-12 21:02:18 +09:00
Dean Herbert	cc2acf5e54	Fix ctrl-dragging on an existing selection causing deselection of the hovered object	2021-04-12 19:05:23 +09:00
Dean Herbert	b5954a55ad	Remove empty <returns> xmldoc	2021-04-12 17:46:14 +09:00
Naxess	a2fc9c398f	Rename CreateChecker -> CreateBeatmapVerifier	2021-04-12 10:08:30 +02:00
Naxess	65ebdd8f7a	Move check origin from IssueTemplate to Issue ... As a result we can also make check an interface, and need to provide the check itself when constructing an issue.	2021-04-12 10:08:08 +02:00
Dean Herbert	0eab9daf13	Update existing overlay containers to not block scroll input	2021-04-12 16:41:36 +09:00
Dean Herbert	8bf85d737c	Change Metadata into a get property	2021-04-12 15:52:29 +09:00
Dean Herbert	3551322f1d	Fix formatting of colour getter	2021-04-12 15:52:18 +09:00
Dean Herbert	1c553b5d48	Checker -> BeatmapVerifier	2021-04-12 15:29:05 +09:00
Dean Herbert	14bd5bdc77	Merge branch 'master' into verify-tab	2021-04-12 15:14:37 +09:00
Dean Herbert	dd1925aaed	Remove temporary input ignore	2021-04-12 14:29:27 +09:00
Dean Herbert	9be3163592	Merge branch 'master' into multiplayer-spectator-player-grid	2021-04-12 14:14:13 +09:00
Salman Ahmed	1fd4cb8963	Merge branch 'master' into master	2021-04-11 10:19:16 +03:00
Naxess	7d40b01722	Remove old todo	2021-04-10 15:18:15 +02:00
Naxess	747e0f00dc	Improve table formatting	2021-04-10 13:10:05 +02:00
Naxess	3a4f2e3d7e	Show table even if no issues	2021-04-10 13:09:16 +02:00
Naxess	c995eca029	Remove todo ... Doesn't really matter in the end, as only one checker will run at a time in this case.	2021-04-10 13:05:24 +02:00
Naxess	6d3cf78e4a	Add issue selection ... This mainly helps with keeping track of which issue was clicked, since doing so switches tab.	2021-04-10 13:04:39 +02:00
Naxess	d1007ff26a	Move components to more appropriate spot	2021-04-10 13:02:22 +02:00
Naxess	43174b708c	Remove visibility settings ... Can look into this later, not really important for a first iteration.	2021-04-10 12:58:40 +02:00
Christine Chen	08311abc5e	Remove setters, cache CreatePowerStatus() and use a dummy LocalPowerStatus class in test scene	2021-04-10 00:00:21 -04:00
Dean Herbert	dfe3240b45	Merge pull request #12353 from nekodex/songselect-hoversamples ... Add a hover sample type for SongSelect buttons	2021-04-10 01:45:47 +09:00
Jamie Taylor	ffacd38e57	Reduce the randomised pitch range of hover sounds	2021-04-09 23:03:14 +09:00
Jamie Taylor	8a0da06e89	Add a hover sample type for SongSelect buttons	2021-04-09 23:00:40 +09:00
smoogipoo	4409c1a36f	Increase sync offset to prevent constant catchups	2021-04-09 22:01:21 +09:00
smoogipoo	6eddc6c59e	Enable spectating multiplayer matches	2021-04-09 21:03:50 +09:00
smoogipoo	3e46d6401e	Remove some unnecessary code	2021-04-09 20:23:11 +09:00
smoogipoo	eccd269cce	Implement maximum start delay	2021-04-09 20:17:57 +09:00
smoogipoo	49b7519c53	Refactor gameplay starting logic	2021-04-09 20:03:34 +09:00
smoogipoo	c93ce73123	Move catchup logic inside PlayerInstance, fixup some edge cases	2021-04-09 19:59:34 +09:00
smoogipoo	f8dfb9544b	Merge branch 'multiplayer-spectator-leaderboard' into multiplayer-spectator-screen	2021-04-09 18:42:04 +09:00
smoogipoo	d2c37e6cf8	Remove unnecessary parameter	2021-04-09 18:41:58 +09:00
smoogipoo	4fa51d5ec8	Add leaderboard to multiplayer spectate screen	2021-04-09 18:41:48 +09:00
smoogipoo	8005f146a9	Fix inspection	2021-04-09 18:37:11 +09:00
smoogipoo	950e4e05ef	Merge branch 'multiplayer-spectator-leaderboard' into multiplayer-spectator-screen	2021-04-09 18:30:21 +09:00
smoogipoo	7cbc8f2695	Add some xmldocs	2021-04-09 18:29:02 +09:00
smoogipoo	90e243eea5	Rename methods	2021-04-09 18:15:27 +09:00
smoogipoo	3b86f0eb2f	Fix exception with 0 frames	2021-04-09 18:15:23 +09:00
smoogipoo	bb15baf118	Add initial multiplayer spectator leaderboard	2021-04-09 17:31:14 +09:00
Dean Herbert	51fee79ef1	Fix scores not being accepted due to missing ruleset ID	2021-04-09 15:18:02 +09:00
Christine Chen	59d13b0dd3	Fixed indentation ... sorry about the style fixes... I'm using JetBrains Rider from now on.	2021-04-08 21:53:42 -04:00
Christine Chen	493c095535	Fixed code style	2021-04-08 20:28:23 -04:00
Christine Chen	6bccb3aab6	Use DI to implement battery detection, add BatteryCutoff property ... - Removed the Xamarin.Essentials package from osu.Game and added it to osu.iOS and osu.Android only. - iOS and Android implementations use Xamarin.Essentials.Battery, while the Desktop implementation only returns 100% battery for now. - Added a BatteryCutoff property to PowerStatus so it can be different for each platform (default 20%, 25% on iOS)	2021-04-08 19:55:11 -04:00
smoogipoo	ecd0b84d94	Use max_sync_offset constant	2021-04-08 22:15:07 +09:00
smoogipoo	1b5679b0d7	Refactor ctor	2021-04-08 22:14:26 +09:00
smoogipoo	7d276144b8	Fix player sizing + masking	2021-04-08 22:13:54 +09:00
smoogipoo	709016f0d6	Add initial multiplayer screen implementation	2021-04-08 22:07:00 +09:00
smoogipoo	d64b236f86	Add a container that provides an isolated gameplay context	2021-04-08 21:27:16 +09:00
smoogipoo	125358158b	Merge branch 'master' into multiplayer-spectator-screen	2021-04-08 21:13:37 +09:00
Dean Herbert	1e23f671fa	Merge pull request #12321 from smoogipoo/add-spectate-button-and-state ... Add multiplayer spectating user state and button	2021-04-08 19:48:58 +09:00
smoogipoo	fd2a14a0bf	Only set button state once	2021-04-08 16:31:40 +09:00
Dean Herbert	a55e62188e	Change state icon to binoculars so the eye isn't staring at me	2021-04-08 15:54:58 +09:00
Dean Herbert	b73860cb5f	Slightly alter button colour scheme to make text more legible and reduce saturation	2021-04-08 15:47:55 +09:00
Christine Chen	0a6baf670e	Send a warning notification if device is unplugged and low battery ... - Uses Xamarin.Essentials in osu.Game.PlayerLoader to check battery level - Encapsulated battery checking in the public BatteryManager class so battery level and plugged in status can be accessed and edited in TestPlayerLoader - When checking battery level, catch NotImplementedException thrown by Xamarin.Essentials.Battery on non-mobile platforms - Added visual unit tests for battery notification To mock battery status and level, we had to define a batteryManager object in TestPlayerLoader and add a new function ResetPlayerWithBattery() Co-Authored-By: Marlina José <marlina@umich.edu>	2021-04-07 15:56:50 -04:00
smoogipoo	72a42ceaf7	Merge branch 'multiplayer-spectator-player-grid' into multiplayer-spectator-screen	2021-04-08 00:19:00 +09:00
smoogipoo	5dc939c2f3	More documentation	2021-04-08 00:12:21 +09:00
smoogipoo	024adb699c	Add test and fix several issues	2021-04-08 00:12:21 +09:00
smoogipoo	648a9d5258	Add multiplayer spectator player grid	2021-04-08 00:12:21 +09:00
smoogipoo	65014d9596	Merge branch 'apply-screen-suspension-changes' into multiplayer-spectator-screen	2021-04-07 22:28:44 +09:00
smoogipoo	99bee73ac1	Merge branch 'master' into add-spectate-button-and-state	2021-04-07 22:07:52 +09:00
Naxess	bab36e529a	Update UI with new components	2021-04-07 14:38:43 +02:00
Naxess	b24ce66a0d	Add check/issue classes	2021-04-07 14:35:33 +02:00
smoogipoo	1f4c17b8f8	Apply changes to AllowScreenSuspension bindable	2021-04-07 21:20:44 +09:00
Dan Balasescu	6eb809f4c4	Merge pull request #9194 from boswelja/rebind-song-select ... Allow rebinding Song Select mods/random/options keys	2021-04-07 20:55:45 +09:00
smoogipoo	93c5935ebc	Add match subscreen support + test	2021-04-07 20:46:30 +09:00
Dean Herbert	0f2c03d54b	Add back "rewind" text, showing temporarily after a rewind occurs	2021-04-07 18:29:45 +09:00
smoogipoo	abd637ffaa	Add button to footer	2021-04-07 17:35:18 +09:00
Dean Herbert	afc745f999	Merge branch 'master' into rebind-song-select	2021-04-07 17:13:25 +09:00
smoogipoo	56c13148f1	Fix typo in class name	2021-04-07 16:45:10 +09:00
smoogipoo	c744f77cfa	Add participant panel state	2021-04-07 16:40:24 +09:00
smoogipoo	6be9c9f0f4	Link up ready button to spectate state	2021-04-07 16:35:50 +09:00
smoogipoo	6de91d7b6b	Add spectate button + test	2021-04-06 21:37:27 +09:00
Dean Herbert	d4c55070e7	Merge pull request #12283 from bdach/setup-screen-design-refresh ... Refresh setup screen appearance to be closer to design	2021-04-06 18:33:34 +09:00
Dan Balasescu	ba3689b5b9	Merge pull request #12269 from PercyDan54/beatmap-details ... Use OnlineViewContainer for BeatmapDetails	2021-04-06 17:52:32 +09:00
Dean Herbert	3113eefcf6	Don't attempt to load content when not online	2021-04-06 17:12:00 +09:00
Dean Herbert	899d708dac	Move loading layer up one level to correct padding	2021-04-06 17:09:51 +09:00
Dean Herbert	1934e8e1fe	Fix loading layer being in the wrong place	2021-04-06 16:30:47 +09:00
Dean Herbert	59e6c46644	Remove unnecessary online state logic	2021-04-06 16:23:27 +09:00
Dean Herbert	dafa8bbe4e	Refactor BeatmapDetails to use GridContainer to keep a consistent layout	2021-04-06 16:21:20 +09:00
Dean Herbert	9d0839be8f	Remove no longer necessary FinishTranforms call	2021-04-06 15:35:07 +09:00
Dean Herbert	316a557a99	Split select area background into own class to reduce hover state complexity	2021-04-06 15:34:34 +09:00
Dean Herbert	7d301a6336	Improve timeline hover display before time zero with a gradient fade	2021-04-06 14:34:16 +09:00
Dean Herbert	35dd1c68aa	Fix drag/selection events not propagating correctly to TimelineBlueprintContainer when before time zero	2021-04-06 14:34:16 +09:00
Dean Herbert	8ff13845d1	Add marker showing where 00:00:000 is	2021-04-06 14:24:22 +09:00
Bartłomiej Dach	0a1417bc67	Swap order of background/audio track changing methods ... Mostly for quality of reviewing (restores previous order) and more consistency overall.	2021-04-04 13:10:12 +02:00
Bartłomiej Dach	a0f0ae7979	Adjust spacings in resources section	2021-04-04 12:53:51 +02:00
Bartłomiej Dach	f2d4ca7676	Add background chooser text box	2021-04-04 12:50:50 +02:00
Bartłomiej Dach	9394af32f5	Move drag & drop support logic to chooser component	2021-04-04 12:34:52 +02:00
Bartłomiej Dach	294d911426	Move background chooser to header	2021-04-03 20:53:07 +02:00
Bartłomiej Dach	61f9eb51c4	Split background chooser to own component	2021-04-03 20:36:30 +02:00
Bartłomiej Dach	3572178bdc	Add tab control to setup screen header	2021-04-03 20:13:20 +02:00
Bartłomiej Dach	95d7e6c74b	Explicitly associate setup sections with titles	2021-04-03 19:58:49 +02:00
Bartłomiej Dach	bdd1072dce	Adjust colours and spacing to be closer to design	2021-04-03 18:52:50 +02:00
Bartłomiej Dach	4df7ff21c7	Fix editor arrow seek snapping not updating after control point changes ... The editor clock, which is responsible for performing the seek, was not aware of changes in control points due to reading from the wrong beatmap. `loadableBeatmap` is not actually changed by any of the editor components; `playableBeatmap` and `editorBeatmap` are. For now this is changed to use `playableBeatmap`. A better follow-up would be to use `editorBeatmap`, but it would probably be best to move the beat snap bindable into `EditorBeatmap` first.	2021-04-03 14:02:46 +02:00
Dean Herbert	eb1e850f99	Merge pull request #12254 from smoogipoo/spectator-refactor ... Move frame-handling spectator logic into abstract base class	2021-04-03 17:23:33 +09:00
hbnrmx	824fb9f398	reopen FileSelector in the directory of the previous selection	2021-04-02 18:01:26 +02:00
hbnrmx	438f3e6349	move fallback text to PlaceholderText	2021-04-02 17:57:21 +02:00
PercyDan54	a5a19319cc	Fix code style	2021-04-02 21:15:28 +08:00
smoogipoo	cd53074941	Schedule spectator callbacks	2021-04-02 21:27:20 +09:00
PercyDan54	1ff77754fd	Use OnlineViewContainer	2021-04-02 20:14:31 +08:00
smoogipoo	d2950105fb	Add comment explaining use of lock	2021-04-02 20:31:34 +09:00
Dean Herbert	45d16fb916	Rename event parameter for clarity	2021-04-02 16:56:47 +09:00
smoogipoo	9bc2a486e0	Make SoloSpectator use the new SpectatorScreen class	2021-04-01 22:10:17 +09:00
smoogipoo	9e95441aa6	Rename Spectator -> SoloSpectator	2021-04-01 22:08:52 +09:00
smoogipoo	af478fb2eb	Add abstract spectator screen class	2021-04-01 22:02:32 +09:00
Dan Balasescu	f8c1dfe57f	Merge branch 'master' into editor-fix-speed-multiplier-precision	2021-03-31 17:17:25 +09:00
Dean Herbert	0c53b4eb93	Fix wrong counting and add test	2021-03-31 14:09:39 +09:00
Dean Herbert	e0c61f4dc5	Fix retry count not updating correctly ... Regressed with changes to player reference retention logic. Could add a test but the logic is so local now it seems quite redundant.	2021-03-31 13:57:58 +09:00
Dean Herbert	90c75a64cf	Fix legacy control point precision having an adverse effect on the editor	2021-03-30 15:24:11 +09:00
Dan Balasescu	d2ef0ba644	Merge branch 'master' into add-editor-nudging-support	2021-03-30 14:34:43 +09:00
Dan Balasescu	1bb9f018a0	Merge branch 'master' into fix-timeline-depth-ordering	2021-03-29 20:47:47 +09:00
Dan Balasescu	3cf6a3f56d	Merge pull request #12076 from peppy/add-timeline-stacking-support ... Implement editor timeline stacking support	2021-03-29 20:44:52 +09:00
Dean Herbert	690debe507	Merge pull request #12030 from LeNitrous/editor-platform-clipboard-copy	2021-03-29 19:31:16 +09:00
Dean Herbert	3909eda095	Avoid using a StringBuilder	2021-03-29 18:51:28 +09:00
Dean Herbert	90ab765cf5	Reorder methods and surround with region	2021-03-29 18:46:32 +09:00
Dan Balasescu	4a5fc82388	Merge branch 'master' into add-timeline-stacking-support	2021-03-29 18:42:59 +09:00
Nathan Alo	cdb779f764	move copy logic inside ComposeScreen	2021-03-29 17:30:23 +08:00
Naxess	d58ef5310b	Add verify tab ... Currently empty, but works.	2021-03-28 17:36:22 +02:00
Dean Herbert	16e184e531	Merge pull request #12183 from frenzibyte/legacy-sprite-text-fonts ... Improve code quality of constructing legacy sprite texts	2021-03-27 20:39:33 +09:00
Nathan Alo	21398e25b5	null check composer and ensure the correct start time from selected hit objects	2021-03-27 10:02:21 +08:00
Nathan Alo	c96321206a	fix appveyor complaints	2021-03-26 16:17:24 +08:00
Nathan Alo	71a0616861	remove extra semi colons	2021-03-26 15:34:45 +08:00
Nathan Alo	374f8c5e22	move to compose namespace and add license header	2021-03-26 15:33:28 +08:00
Dean Herbert	cb48e5f158	Fix timeline not visually ordering hitobjects in a stable way	2021-03-26 16:33:18 +09:00
Nathan Alo	b8b7eb4c4b	refactor logic to its own component and handle hit object to string conversion to its ruleset-specific composers	2021-03-26 15:25:20 +08:00
Nathan Alo	2bea69456e	remove implementations	2021-03-26 15:24:33 +08:00
Dean Herbert	77969bb223	Merge branch 'master' into add-timeline-stacking-support	2021-03-26 16:17:10 +09:00
Dean Herbert	6a4157d193	Remove unused using statement	2021-03-26 16:13:43 +09:00
Dean Herbert	7faca766e4	Fix crash on attempting to join lobby using key press during a pending join ... Closes https://github.com/ppy/osu/issues/12040.	2021-03-26 14:49:05 +09:00
Salman Ahmed	6aa0c9d8fd	Merge branch 'master' into legacy-sprite-text-fonts	2021-03-25 14:52:01 +03:00
Dean Herbert	f6647de769	Add support for nudging objects in the editor using ctrl+arrow keys ... Closes #12042.	2021-03-25 19:56:28 +09:00
Dean Herbert	8d4ff867bf	Fix barlines showing up in the osu!mania editor's timeline	2021-03-25 16:30:31 +09:00
Dean Herbert	9fdd23b134	Fix various issues with stacking	2021-03-25 16:28:30 +09:00
Dean Herbert	bdc783b55f	Merge branch 'master' into add-timeline-stacking-support	2021-03-25 15:28:30 +09:00
Dean Herbert	7b3336783f	Stabilise ordering instead of simple reversing ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-03-25 15:24:59 +09:00
Dean Herbert	4269cb7124	Extract majority of token retrieval code out of LoadComponentAsync for legibility	2021-03-25 13:48:41 +09:00
Dean Herbert	d55324585d	Change RoomSubmittingPlayer's request implementation to return null on RoomID missing, rather than silently succeeding	2021-03-24 13:23:23 +09:00
Dean Herbert	84b2f9a848	Make token private	2021-03-24 13:20:44 +09:00
Dean Herbert	a0c6c4da35	Rename and refactor token request process to be easier to understand	2021-03-24 13:17:29 +09:00
Dean Herbert	e372e355ef	Reorder overrides in SoloPlayer to better follow chronological request order	2021-03-24 13:12:51 +09:00
Dean Herbert	8bed7748d6	Rename token request method to avoid double Request terminology	2021-03-24 13:02:37 +09:00
Dean Herbert	a1c35677ef	Add more xmldoc	2021-03-24 13:02:17 +09:00
Dean Herbert	e649a330a4	Implement SoloPlayer's request construction	2021-03-23 18:23:25 +09:00
Dean Herbert	242b847516	Add flow for allowing gameplay to continue even when an error occurs with token retrieval	2021-03-23 18:23:25 +09:00
Dean Herbert	3cd8bf2d7f	Move token request construction to LoadAsyncComplete to better allow DI usage	2021-03-23 18:20:55 +09:00
Dean Herbert	571124669d	Remove all references to "score submission" from Player	2021-03-23 18:20:55 +09:00
Dean Herbert	194b2d05d3	Update SoloPlayer to derive SubmittingPlayer	2021-03-23 18:20:55 +09:00
Dean Herbert	12f050264a	Further split out a player class which submits to "rooms"	2021-03-23 18:20:55 +09:00
Dean Herbert	7045fce555	Move score submission logic in general out to its own Player type	2021-03-23 18:20:55 +09:00
Dean Herbert	6cb14e91c9	Make Player abstract and introduce SoloPlayer	2021-03-23 18:18:49 +09:00
Dean Herbert	9c690f9545	Fix second usage	2021-03-23 14:08:00 +09:00
Bartłomiej Dach	dd48b68f8a	Ensure selected blueprints are given selection priority	2021-03-19 22:44:33 +01:00
Dean Herbert	71a361337d	Add comment regarding usage of Reverse() ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-03-19 21:57:48 +09:00
Dan Balasescu	e72205eea2	Merge pull request #12080 from peppy/add-25-playback-editor ... Change editor speed adjust to adjust frequency (and restore 25% option)	2021-03-19 21:04:12 +09:00
Dean Herbert	8955071703	Change editor speed adjust to adjust frequency	2021-03-19 20:01:45 +09:00
Dean Herbert	9be7981e0d	Adjust timeline ticks to be more visible	2021-03-19 19:45:00 +09:00
Dean Herbert	563a0584d5	Implement editor timeline stacking support	2021-03-19 18:48:51 +09:00
Dean Herbert	32c571fc94	Adjust keyboard step to be something sensible	2021-03-19 17:13:30 +09:00
Dean Herbert	711d895a04	Merge pull request #8238 from voidedWarranties/editor-song-end	2021-03-19 16:32:23 +09:00
voidedWarranties	b9761c8196	Further simplify logic	2021-03-18 16:20:31 -07:00
voidedWarranties	df6570ebf5	Improve logic and add previously failing test ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-03-17 15:48:55 -07:00
Bartłomiej Dach	2e63c2ce20	Fix selection box operation hotkeys not registering in change handler ... Could lead to crashes after reversing a note cluster and playing it back. The root cause of the crash was that the hotkey operations were not ran inside of an editor change handler operation. This, in turn, caused the autoplay replay to not be regenerated after flipping an object cluster, therefore finally manifesting as a hard crash due to negative time offsets appearing in judgement results, which interfered with the default implementation of note lock. Note that this incidentally also fixes the fact that selection box hotkey operations (reverse and flip) did not handle undo/redo.	2021-03-17 22:17:42 +01:00
Bartłomiej Dach	a691291ae8	Merge branch 'master' into editor-song-end	2021-03-17 18:18:19 +01:00
Dan Balasescu	5a7e416495	Merge pull request #12027 from peppy/new-beatmap-empty-fields ... Don't fill beatmap metadata with template values on creating a new beatmap	2021-03-17 19:36:21 +09:00
Nathan Alo	51e0304c54	properly format strings per ruleset	2021-03-17 18:31:09 +08:00
Nathan Alo	133ff085a5	refactor code	2021-03-17 18:06:40 +08:00
Nathan Alo	8046b5a818	set text to platform clipboard on copy	2021-03-17 17:35:49 +08:00
Dean Herbert	d0e61e5b4d	Put back the label	2021-03-17 17:14:04 +09:00
Dean Herbert	3b6a1180b6	Remove non-accessed field	2021-03-17 17:02:11 +09:00
Dean Herbert	5adc675862	Focus artist textbox on entering song setup if fields are empty	2021-03-17 16:57:14 +09:00
Dean Herbert	eda891223c	Start the editor with empty artist/creator/difficulty name fields	2021-03-17 16:47:12 +09:00
Dean Herbert	c7740d1181	Fix opening the editor occasionally causing a hard crash due to incorrect threading logic ... Setting one of the global screen `Bindable`s (in this case, `Beatmap`) is not valid from anywhere but the update thread. This changes the order in which things happen during the editor startup process to ensure correctness. Closes #11968.	2021-03-17 15:52:25 +09:00
Salman Ahmed	43c1e1d217	Update existing usages ... Resolve post-conflict issues	2021-03-13 06:09:07 +03:00
Dean Herbert	9b5d11f2a5	Merge pull request #11958 from bdach/ruleset-filter-v3 ... Allow rulesets to specify custom song select filtering criteria	2021-03-08 23:23:24 +09:00
Dan Balasescu	ff2327ffac	Merge branch 'master' into configure-await-false	2021-03-08 22:24:29 +09:00
Dean Herbert	b1cd01ceb8	Apply ConfigureAwait changes to game side	2021-03-08 14:36:35 +09:00
Dean Herbert	765cc5cf37	Remove iOS multiplayer blocking code	2021-03-08 14:35:22 +09:00
Dean Herbert	f46880f68a	Merge branch 'master' into intro-triangles-background-access	2021-03-08 13:31:09 +09:00
Dean Herbert	74fc5d5b8c	Fix potential cross-thread drawable mutation in IntroTriangles	2021-03-08 13:30:07 +09:00
Dean Herbert	503f29609a	Also set additive mode to match stable	2021-03-07 23:40:09 +09:00
Joehu	3e4dfdb675	Fix pop out count being above displayed count on legacy combo counter	2021-03-06 20:37:27 -08:00
Bartłomiej Dach	12b7d9e06d	Simplify custom filter criteria retrieval	2021-03-06 12:16:01 +01:00
Bartłomiej Dach	f00089846b	Merge branch 'master' into ruleset-filter-v3	2021-03-06 12:14:53 +01:00
Bartłomiej Dach	f733d1ec1f	Expose and document query parser and helpers	2021-03-03 22:03:01 +01:00
Bartłomiej Dach	f9148eec20	Refactor filter query parsing helper methods ... In preparation for exposition as public.	2021-03-03 21:34:14 +01:00
Dean Herbert	23a46819dc	Merge branch 'master' into multiplayer-confirm-on-exit	2021-03-03 20:35:31 +09:00
Dean Herbert	0f5bce70ad	Split confirmation dialog classes apart	2021-03-03 20:34:37 +09:00
smoogipoo	012b48dbe5	Remove explicit public definition ... Interface members are public by default.	2021-03-03 19:03:45 +09:00
Dean Herbert	0ede28da2f	Fix test failures due to missing dependency	2021-03-03 15:24:55 +09:00
Dean Herbert	cb4c3503a0	Confirm exiting a multiplayer match	2021-03-03 14:54:18 +09:00
Dean Herbert	d332fd2414	Handle case where local user tries to change beatmap while not the host	2021-03-03 14:53:47 +09:00
Dean Herbert	7dce9b04fa	Add a more basic ConfirmDialog implementation	2021-03-03 14:50:45 +09:00
Dean Herbert	fcea900a53	Move main menu (song select) presentation logic to a local implementation ... Reduces cross-dependencies between OsuGame and MainMenu.	2021-03-03 14:13:51 +09:00
Dean Herbert	36e1fb6da8	Add flow to allow MatchSubScreen to handle beatmap presentation locally	2021-03-03 14:13:51 +09:00
Dean Herbert	6e75ebbb06	Add interface to handle local beatmap presentation logic	2021-03-03 14:13:48 +09:00
Bartłomiej Dach	42c3309d49	Use ruleset criteria in parsing and filtering	2021-03-02 20:11:21 +01:00
Bartłomiej Dach	c375be6b07	Instantiate ruleset criteria	2021-03-02 20:10:03 +01:00
Bartłomiej Dach	e46543a4a9	Constrain operator parsing better	2021-03-02 19:56:36 +01:00
Bartłomiej Dach	26736d990f	Enable filter parsing extensibility	2021-03-02 19:42:47 +01:00
Dean Herbert	4fd8501c86	Remove unnecessary using (underlying enumerator change)	2021-02-26 20:03:03 +09:00
Dean Herbert	cd1c1bf534	Centralise cases of performing actions on the current selection ... By moving this to a central location, we can avoid invoking the EditorChangeHandler when there is no selection made. This helps alleviate the issue pointed out in https://github.com/ppy/osu/issues/11901, but not fix it completely.	2021-02-26 14:15:13 +09:00
Bartłomiej Dach	d0decc73be	Merge branch 'master' into beatmap-difficulty-cache-nullable	2021-02-25 19:40:38 +01:00
Dean Herbert	a792c3f13c	Merge pull request #11900 from peppy/update-bpm-with-mods ... Update the displayed BPM at song select with rate adjust mods	2021-02-26 00:25:55 +09:00
smoogipoo	01a4815412	Make labels disappear on null beatmap/no hitobjects	2021-02-25 23:36:02 +09:00
Dan Balasescu	46ea0f44eb	Merge branch 'master' into beatmap-difficulty-cache-nullable	2021-02-25 22:52:15 +09:00
smoogipoo	c1f27ba938	Merge branch 'master' into fix-song-select-star-rating-display-zero-flashing	2021-02-25 22:13:48 +09:00
smoogipoo	c3eb44137b	Move ValueChanged bind back to load()	2021-02-25 22:09:41 +09:00
smoogipoo	649ce20e35	Fix up super weird and super wrong DI	2021-02-25 22:01:53 +09:00
smoogipoo	b090a82b35	Merge branch 'master' into update-bpm-with-mods	2021-02-25 21:58:54 +09:00
smoogipoo	de417a660d	Make BPM update with changes in mod settings	2021-02-25 21:51:32 +09:00
smoogipoo	98313a98bf	DI mods in parent class and pass them down	2021-02-25 21:48:02 +09:00
Dean Herbert	90e8308716	Merge branch 'master' into localisation-refactor-framework	2021-02-25 17:28:55 +09:00
Dean Herbert	2db4b793d7	Also handle most common BPM display	2021-02-25 17:05:00 +09:00
Dean Herbert	31c52bd585	Update the displayed BPM at song select with rate adjust mods ... This only covers constant rate rate adjust mods. Mods like wind up/wind down will need a more complex implementation which we haven't really planned yet.	2021-02-25 17:00:44 +09:00
Dean Herbert	03771ce8ec	Allow determining a BeatmapDifficultyCache's bindable return's completion state via nullability	2021-02-25 16:19:01 +09:00
Dean Herbert	9f3ceb99eb	Fix the star rating display at song select flashing to zero when changing mods ... Due to the use of bindable flow provided by `BeatmapDifficultyCache` in this usage, the display would briefly flash to zero while difficulty calculation was still running (as there is no way for a consumer of the provided bindable to know whether the returned 0 is an actual 0 SR or a "pending" calculation). While I hope to fix this by making the bindable flow return nullable values, I think this particular use case works better with non-bindable flow so have switched across to that.	2021-02-25 16:05:13 +09:00
Dean Herbert	e82eaffaed	Flip order back to original for romanisable strings	2021-02-25 14:14:07 +09:00
Dean Herbert	a362382d38	Add back more correct null checks	2021-02-25 14:06:21 +09:00
Dan Balasescu	a7d10630e0	Merge pull request #11893 from peppy/fix-request-queue-reference-holding ... Fix requests being indefinitely queued when user is offline	2021-02-24 23:07:02 +09:00
Dean Herbert	fa6d797adf	Remove redundant prefix	2021-02-24 20:30:17 +09:00
Dean Herbert	5dc0aefb2b	Cancel request on leaving results screen	2021-02-24 19:54:52 +09:00
Dan Balasescu	c0f21c8cbe	Merge branch 'master' into fix-selecting-incompatible-freemods	2021-02-24 15:10:48 +09:00
Dan Balasescu	cfea4c7d4d	Merge pull request #11881 from peppy/disable-hub-connections-on-ios ... Disable multiplayer/spectator on iOS until it can be supported again	2021-02-24 13:09:03 +09:00
Dean Herbert	e1f71038e3	Remove unncessary action	2021-02-24 12:13:55 +09:00
Dean Herbert	71182347d6	Also add a notifiation when trying to enter the multiplayer screen ... Turns out the only check required to get into this screen was that the API was online, which it always is even if the multiplayer component isn't. This provides a better end-user experience.	2021-02-24 11:30:14 +09:00
Dean Herbert	6a5c6febc5	Add inline comment explaining the retry loop	2021-02-23 13:23:32 +09:00
Salman Ahmed	5493c55da7	Fix silly mistake	2021-02-22 16:59:35 +03:00
Salman Ahmed	5e9040c291	Use "pausing supported" conditional instead	2021-02-22 16:26:35 +03:00
Dean Herbert	8a97e2e28d	Update LocalisedString usages to RomanisedString	2021-02-22 19:01:42 +09:00
Dean Herbert	1fd76ea3fb	Apply changes to UI components overriding functions with changing signatures	2021-02-22 19:01:42 +09:00
Salman Ahmed	6bac83964a	Merge branch 'master' into fix-pofl-on-cooldown	2021-02-22 10:03:27 +03:00
smoogipoo	ccb83ef3a3	Fix checkbox not being updated	2021-02-22 15:47:47 +09:00
smoogipoo	8d463987dd	Fix being able to select incompatible freemods	2021-02-22 13:24:24 +09:00
Dan Balasescu	8037b101cb	Merge branch 'master' into perform-from-subscreen-support	2021-02-22 11:55:51 +09:00
Dean Herbert	38a2124921	Support instant exit if pausing is not allowed in the current game mode	2021-02-20 14:26:50 +09:00
Dan Balasescu	52372fe50d	Merge pull request #11713 from peppy/fix-error-exit-during-results-transition ... Fix a potential crash when exiting play during the results screen transition	2021-02-19 18:39:21 +09:00
Dan Balasescu	9fc57b2145	Merge pull request #11832 from peppy/leaderboard-compact-mode ... Show compact leaderboard during gameplay to reduce distractions	2021-02-19 18:17:46 +09:00
Dean Herbert	362e4802f7	Add the ability for PerformFromMenuRunner to inspect nested screen stacks	2021-02-19 17:58:04 +09:00
Salman Ahmed	0771154dd2	Make PauseCooldownActive protected and expose on test class	2021-02-19 11:42:30 +03:00
Salman Ahmed	ddd1dcff88	Attempt pausing every single frame	2021-02-19 11:33:26 +03:00
Dean Herbert	82cc06ca57	Fix new logic not considering fail overlay correctly	2021-02-19 17:26:54 +09:00
Dean Herbert	4c214b74ce	Merge branch 'master' into fix-error-exit-during-results-transition	2021-02-19 17:13:55 +09:00
Dean Herbert	b8c1e8ed7a	Merge pull request #11708 from frenzibyte/multiplayer-participant-rank ... Display user global rank for multiplayer room participants	2021-02-19 16:57:30 +09:00
Dean Herbert	9d02f589fe	Compact leaderboard during gameplay	2021-02-19 16:51:39 +09:00
Salman Ahmed	4436585aa4	Keep attempting to pause gameplay while window not active	2021-02-19 10:46:32 +03:00
Salman Ahmed	772471a6d8	Add failing test case	2021-02-19 10:46:31 +03:00
Dean Herbert	691cfa5bc3	Add expanded/compact display modes for GameplayLeaderboard	2021-02-19 16:46:30 +09:00
Dean Herbert	ee9e6fff40	Add bindable flow for expanded leaderboard state	2021-02-19 15:09:41 +09:00
Dean Herbert	484968d797	Fix weird bool check ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-02-19 14:46:10 +09:00
Dean Herbert	4504023a23	Merge branch 'master' into playlists-freemod-support	2021-02-19 14:43:59 +09:00
Dean Herbert	39059ed82d	Remove unnecessary null coalesce check	2021-02-19 14:36:51 +09:00
Dean Herbert	df05c57f44	Merge branch 'master' into playlists-freemod-support	2021-02-19 14:35:20 +09:00
Dean Herbert	a2aec6bcdc	Merge pull request #11808 from smoogipoo/multiplayer-no-playlist-mangling ... Rework multiplayer playlist handling to support multiple items	2021-02-19 14:33:53 +09:00
smoogipoo	bc10fcafae	Remove now unnecessary schedule	2021-02-19 13:23:51 +09:00
Dean Herbert	b68dbbceff	Merge branch 'master' into multiplayer-participant-rank	2021-02-19 13:16:44 +09:00
Dan Balasescu	6240d3964c	Merge pull request #11817 from peppy/fix-collection-dropdown-cross-thread-manipulation ... Fix potential crash from cross-thread drawable manipulation in CollectionFilterDropdown	2021-02-19 10:06:42 +09:00
Salman Ahmed	e14a59f272	Fix creating ruleset instances per LINQ select	2021-02-18 15:26:59 +03:00
Dan Balasescu	46b67dd7bc	Merge pull request #11821 from peppy/fix-carousel-border-additive-alplha ... Fix carousel items' borders getting blown out when selected and hovered	2021-02-18 17:45:58 +09:00
Dean Herbert	b713eb2eae	Make field readonly	2021-02-18 17:13:48 +09:00
Dean Herbert	c3a98b6ad1	Fix carousel items' borders getting blown out when selected and hovered ... I tried restructuring the hierarchy to avoid needing this added property (moving the hover layer out of the border container) but this leads to some subpixel leakage outside the borders which looks even worse. Closes #6915.	2021-02-18 16:59:44 +09:00
smoogipoo	e911760318	Split OnlinePlayComposite to remove if-statement	2021-02-18 15:47:33 +09:00
Dean Herbert	421cdb6650	Consume new method in existing usages (and remove some unnecessary set/unset code)	2021-02-18 15:01:11 +09:00
Dean Herbert	49589b64c3	Intro track should not restart from preview point	2021-02-18 14:55:15 +09:00
Dean Herbert	90dce52042	Fix potential crash from cross-thread drawable manipulation in CollectionFilterDropdown	2021-02-18 14:10:28 +09:00
Dan Balasescu	e30fb72ee2	Merge pull request #11811 from peppy/fix-mod-display-thread-safety ... Fix ModDisplay potentially being operated on before loaded completely	2021-02-18 00:05:31 +09:00
Dean Herbert	3208b2c5bf	Fix potential nullref if mods are never set	2021-02-17 23:13:51 +09:00
smoogipoo	6ef235c4c5	Fix beatmap panel flickering multiple times	2021-02-17 21:54:43 +09:00
smoogipoo	2a1bb2f578	Fix selected item potentially changing during gameplay	2021-02-17 21:40:21 +09:00
Dean Herbert	403536ef80	Fix ModDisplay potentially being operated on before loaded completely ... Closes https://github.com/ppy/osu/issues/11810.	2021-02-17 21:11:46 +09:00
Dean Herbert	9c298fac4a	Merge pull request #11801 from peppy/fix-import-always-importing ... Fix intro beatmap always being imported even if already in a good state	2021-02-17 20:59:33 +09:00
smoogipoo	8930ff4465	Merge branch 'master' into multiplayer-no-playlist-mangling	2021-02-17 19:29:01 +09:00
Dean Herbert	c1620ce21b	Fix intro beatmap always being imported even if already in a good state	2021-02-17 19:19:49 +09:00
smoogipoo	604add04e4	Fix song select mods being reset incorrectly	2021-02-17 19:06:37 +09:00
smoogipoo	70a995919c	Update comments	2021-02-17 17:58:24 +09:00
Dan Balasescu	57ede6eb37	Merge branch 'master' into fix-multiplayer-mod-propagation-race	2021-02-17 16:22:51 +09:00
Dean Herbert	86faa7f465	Merge pull request #11798 from smoogipoo/multiplayer-long-types ... Use long type where required in multiplayer	2021-02-17 15:50:12 +09:00
Salman Ahmed	a845e96b7a	Replace Ranks.Global completely with a GlobalRank property	2021-02-17 08:52:04 +03:00
Salman Ahmed	d7c91a7c6f	Merge branch 'fix-tournament-user-population' into multiplayer-participant-rank	2021-02-17 08:42:59 +03:00
Bartłomiej Dach	8f72631c31	Fix typo in comment	2021-02-16 21:48:19 +01:00
smoogipoo	100097d78f	Fix playlist not being handled correctly for non-joined cases	2021-02-16 21:32:35 +09:00
Dan Balasescu	bef0e5cfa1	Merge pull request #11790 from peppy/playlists-show-remaining-attempts ... Display remaining attempts for playlist rooms with room-level attempt limits	2021-02-16 21:10:19 +09:00
Dan Balasescu	ffa90c1a23	Remove whitespace	2021-02-16 20:23:19 +09:00
Dan Balasescu	8e077c2857	Merge pull request #11791 from peppy/rooms-container-fix-click-deselection ... Add the ability to deselect the currently selected room via clicking away	2021-02-16 20:22:24 +09:00
smoogipoo	379393fe10	Merge branch 'multiplayer-long-types' into multiplayer-no-playlist-mangling	2021-02-16 19:37:55 +09:00
smoogipoo	3e802531d3	Use long type where required in multiplayer	2021-02-16 19:34:01 +09:00
smoogipoo	e24a5949c5	Fix resolve	2021-02-16 19:26:51 +09:00
smoogipoo	2a1096a3c8	Make BeatmapSelectionControl use the selected item	2021-02-16 19:02:16 +09:00
smoogipoo	3ff9e14e35	Make StatefulMultiplayerClient control current playlist item	2021-02-16 18:56:13 +09:00
smoogipoo	855d24dce7	Cache selected item bindable from RoomSubScreen	2021-02-16 17:38:33 +09:00
smoogipoo	f25b5147ef	Select last playlist item in match subscreen	2021-02-16 15:37:45 +09:00
Dean Herbert	fdcb6384cb	Add user mod selection to playlists room screen	2021-02-16 15:14:56 +09:00
Dean Herbert	97a7572cb8	Move UserModSelectOverlay to RoomSubScreen for Playlists consumption	2021-02-16 15:14:48 +09:00
Dean Herbert	fff1cb0b35	Fix allowed mods not being copied when populating playlist items	2021-02-16 15:14:21 +09:00
Dean Herbert	da42c6d282	Expose FreeMods from OnlinePlaySongSelect	2021-02-16 15:14:21 +09:00
Dean Herbert	52e544aa67	Revert "Remove redundant double call to ValueChanged on UserMods change" ... This reverts commit 9ed45ce1ca.	2021-02-16 14:42:31 +09:00
Dean Herbert	9ed45ce1ca	Remove redundant double call to ValueChanged on UserMods change	2021-02-16 14:31:00 +09:00
Dean Herbert	0ca747b39f	Merge branch 'master' into fix-multiplayer-mod-propagation-race	2021-02-16 14:25:27 +09:00
Dean Herbert	31a5cdd8ac	Fix current selection not updating visually after creating a new playlist	2021-02-16 14:02:21 +09:00
Dean Herbert	e969ca8974	Remove unused using statement that rider could not identify	2021-02-16 13:52:42 +09:00
Dean Herbert	e82922f8c5	Add the ability to deselect the currently selected room via clicking away ... Always felt wrong that you couldn't do this until now.	2021-02-16 13:44:37 +09:00
Salman Ahmed	0e7f52b5cc	Always use JSON property global_rank for global ranks instead	2021-02-16 07:33:16 +03:00
Salman Ahmed	5b4999e8af	Update user statistics retrieval with API changes	2021-02-16 07:33:13 +03:00
Dean Herbert	02417697e9	Display remaining attempts for playlist rooms with room-level attempt limits	2021-02-16 13:32:14 +09:00
Salman Ahmed	d15ffff9a5	Simplifiy user statistics retrieval to one-time on deserialization	2021-02-16 04:48:36 +03:00
Salman Ahmed	a1496cd8f3	Remove necessity of using CurrentModeRank as a fallback	2021-02-16 04:48:36 +03:00
Salman Ahmed	90aa6256d7	Merge branch 'master' into multiplayer-participant-rank	2021-02-16 04:44:57 +03:00
Dean Herbert	2e646882fa	Merge branch 'master' into non-concurrent-sample-playback	2021-02-15 21:22:21 +09:00
Dan Balasescu	6bfc7da671	Fix sample potentially playing at the wrong frequency ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2021-02-15 18:10:45 +09:00
Dean Herbert	de52b8a5ba	Fix test failures in PerformFromScreen tests	2021-02-15 17:14:41 +09:00
Dean Herbert	9cba350337	Refactor again to better cover cases where the pause dialog should definitely be shown	2021-02-15 15:57:36 +09:00
Dean Herbert	1aea840504	Add missing return in early exit scenario (MakeCurrent isn't compatible with the following Exit)	2021-02-15 15:03:12 +09:00
smoogipoo	c6ed3efa4a	Merge branch 'master' into non-concurrent-sample-playback	2021-02-15 14:47:32 +09:00
Dean Herbert	2b69c7b325	Fix incorrect order of operation in pause blocking logic	2021-02-15 14:24:08 +09:00
Joehu	b28a906197	Fix extra mod settings overflowing from screen	2021-02-12 10:29:29 -08:00
Joehu	52975c5185	Remove hardcoded padding from main content	2021-02-12 10:23:33 -08:00
smoogipoo	d3f0c0730d	Merge branch 'master' into non-concurrent-sample-playback	2021-02-12 17:22:15 +09:00
Dean Herbert	4ab16694d1	Fix classic "welcome" intro not looping as expected	2021-02-12 16:22:19 +09:00
Dan Balasescu	cb4d119f23	Merge pull request #11740 from peppy/editor-fix-slider-samples-new-placement ... Fix newly placed sliders in the editor not playing hitsounds	2021-02-12 13:31:00 +09:00
Dean Herbert	cd01591dda	Consume new debounce logic in carousel header	2021-02-12 12:22:35 +09:00
Dean Herbert	e9730d4782	Move default sample addition to inside PlacementBlueprint ... This isn't actually required to fix the behaviour but it does feel like a better place to put this logic.	2021-02-11 17:16:18 +09:00
Dean Herbert	98c5b0220c	Merge pull request #11725 from smoogipoo/freemods-user-settings ... Add local user customisation for freemod mod settings	2021-02-11 16:02:24 +09:00
Dean Herbert	889a99c49c	Use AddOnce everywhere to reduce potential call count	2021-02-11 16:00:52 +09:00
Dean Herbert	549e7520c5	Move scheduler logic to client callback rather than inside the update method	2021-02-11 16:00:52 +09:00
Dean Herbert	21f66a19fd	Make server authoritative in which mods the client should be using when gameplay starts	2021-02-11 15:55:18 +09:00
Dean Herbert	3344e9f27f	Merge pull request #11720 from nekodex/new-buttonsystem-edit-sound ... Use unique sample for edit button click (ButtonSystem)	2021-02-11 15:10:35 +09:00
Dean Herbert	eaa7b4cb93	Rename second usage variable name to match	2021-02-11 14:54:50 +09:00
Dean Herbert	2afea88a25	Merge branch 'new-carousel-sounds' into update-resources	2021-02-11 14:20:20 +09:00
smoogipoo	86682cdb34	Add client/room null check	2021-02-10 20:16:26 +09:00
smoogipoo	6fff7c39da	Ensure tracker is disposed	2021-02-10 20:09:45 +09:00
smoogipoo	822c66033f	Add local-user freemod configuration	2021-02-10 19:56:59 +09:00
smoogipoo	393cd6c74a	Add helper class for tracking changes to mod settings	2021-02-10 19:40:07 +09:00
Jamie Taylor	996f1098f6	Use alternate sample on the downbeat while hovering OsuLogo	2021-02-10 18:17:48 +09:00
Jamie Taylor	bc7f4a4f88	Use a single sample for CarouselHeader on-hover with randomised pitch instead of multiple samples	2021-02-10 17:53:47 +09:00
Jamie Taylor	22995c216d	Use unique sample for edit button click (ButtonSystem)	2021-02-10 17:23:55 +09:00
Dan Balasescu	92599aa02b	Merge branch 'master' into user-beatmap-downloading-states-2	2021-02-09 21:06:09 +09:00
Dean Herbert	2c052d70e8	Only trigger pause cooldown on pause (not exit)	2021-02-09 17:29:18 +09:00
Dean Herbert	cba116ff09	Fix incorrect call parameter for quick exit	2021-02-09 17:28:57 +09:00
Dean Herbert	61b9539864	Fix regression in quick exit logic	2021-02-09 17:14:16 +09:00
Dean Herbert	5bd4f74ddf	Fix a potential crash when exiting play during the results screen transition	2021-02-09 16:24:29 +09:00
smoogipoo	3ce605b5e5	Small refactoring to use .Trim() instead	2021-02-09 12:00:03 +09:00
Salman Ahmed	d101add159	Display user global rank for selected ruleset in participants panel	2021-02-08 21:25:50 +03:00
Joehu	414e05affd	Fix editor effect attribute tooltip having unnecessary whitespace when only one is enabled	2021-02-08 10:16:16 -08:00
Dean Herbert	2cac373365	Merge pull request #11706 from smoogipoo/fix-failing-test ... Fix failing test	2021-02-08 20:57:38 +09:00
Dean Herbert	0dd1b1026c	Merge pull request #11495 from smoogipoo/more-accurate-most-common-bpm ... Make most common BPM more accurate	2021-02-08 20:08:58 +09:00
Dean Herbert	156f5bd5df	Add newline between statements	2021-02-08 20:05:16 +09:00
smoogipoo	19368f87fb	Fix failing test	2021-02-08 19:59:07 +09:00
Dan Balasescu	7bc6010d90	Merge pull request #11703 from Joehuu/fix-timing-editor-attribute-column ... Fix attributes header not being aligned with content in editor timing mode	2021-02-08 19:38:59 +09:00
Dean Herbert	5fbed05d04	Merge pull request #11551 from smoogipoo/fix-leave-room-race-2 ... Fix client potentially not leaving a room on exiting multiplayer	2021-02-08 19:23:14 +09:00
smoogipoo	a08c51f213	Remove duplicate code	2021-02-08 19:23:10 +09:00
smoogipoo	6e34e7d750	Merge branch 'master' into user-beatmap-downloading-states-2	2021-02-08 19:08:53 +09:00
smoogipoo	69ca440ae5	Merge branch 'master' into more-accurate-most-common-bpm	2021-02-08 18:40:58 +09:00
Joehu	5e7823b289	Fix attributes content being zero size and disappearing after being half off-screen	2021-02-08 01:37:34 -08:00
Joehu	6b26a18a23	Fix attributes header not being aligned with content in editor timing mode	2021-02-08 01:34:32 -08:00
Dean Herbert	59dc148a48	Merge pull request #11680 from frenzibyte/instant-pause-on-focus-loss ... Make pausing on window focus loss instantaneous	2021-02-08 17:00:17 +09:00
Dean Herbert	9e0724b138	Remove unnecessary double resolution of OsuGame	2021-02-08 15:58:41 +09:00
Dan Balasescu	e8f08b09dc	Merge pull request #11552 from vmaggioli/zero-spinner-slider ... Fix being able to set zero or negative hitobject duration via timeline	2021-02-08 14:52:35 +09:00
Dean Herbert	93f1a3c1bf	Merge branch 'master' into instant-pause-on-focus-loss	2021-02-08 14:31:40 +09:00
Joehu	d74a1437be	Fix player loader metadata not being centred	2021-02-07 15:14:08 -08:00
Salman Ahmed	d0ca2b99a8	Remove unnecessary injected dependency	2021-02-06 20:57:01 +03:00
Salman Ahmed	40ddccf0c7	Do not consider replays for "pause on focus lost" ... Replays are not pausable as can be seen in the `canPause` check.	2021-02-06 20:56:08 +03:00
Salman Ahmed	c9db0bf886	Call break time update when loaded	2021-02-06 20:54:13 +03:00
Salman Ahmed	f29938e15d	Make last binding game activity more sensible	2021-02-05 20:39:57 +03:00
Dean Herbert	34a1918d03	Merge branch 'master' into user-beatmap-downloading-states-2	2021-02-06 00:27:55 +09:00
Vincent Maggioli	96652e07cd	Merge branch 'master' into zero-spinner-slider	2021-02-05 09:40:55 -05:00
Dean Herbert	dd4207cb4e	Merge pull request #11661 from peppy/playlist-max-room-attempts ... Add support for setting the maximum attempt count for a playlist	2021-02-05 23:40:38 +09:00
vmaggioli	5061231e59	Switch to beat length	2021-02-05 09:39:14 -05:00
Dean Herbert	7f82a06a61	Remove no longer used using directive	2021-02-05 23:08:31 +09:00
Dean Herbert	0679901e4d	Update error handling	2021-02-05 22:53:40 +09:00
Dean Herbert	3ca64a1cb2	Merge branch 'master' into playlist-max-room-attempts	2021-02-05 22:13:13 +09:00
smoogipoo	95ad7ea8f7	Fix mods on participant panels flashing when changed	2021-02-05 18:44:33 +09:00
Dean Herbert	f338fa114b	Merge branch 'master' into user-beatmap-downloading-states-2	2021-02-05 18:02:40 +09:00
Dean Herbert	791cbb7f03	Don't reset ready state if the map is locally available	2021-02-05 17:17:29 +09:00
Dean Herbert	3e750feaa4	Subclass LocalPlayerModSelectOverlay to correctly deselect incompatible mods on free mod selection	2021-02-05 16:42:35 +09:00
Salman Ahmed	8d18c7e929	Fix BreakTracker.IsBreakTime not updated properly on breaks set ... Causes a pause from focus lose when playing a beatmap that has a break section at the beginning, due to `IsBreakTime` incorrectly set to `false`	2021-02-05 10:28:35 +03:00
Salman Ahmed	e1789c29b1	Use Pause() instead of performUserRequestedExit() to avoid unexpected operations	2021-02-05 10:28:13 +03:00
Dean Herbert	be91f54349	Add back edge case with comment	2021-02-05 16:19:45 +09:00
Dean Herbert	9ba5ae3db7	Remove lots of unnecessary client side logic	2021-02-05 16:17:02 +09:00
Dean Herbert	1b6a052798	Refactor logic to suck a bit less	2021-02-05 15:46:03 +09:00
Dean Herbert	d1f9aa52a4	Inline variable	2021-02-05 15:33:48 +09:00
Dean Herbert	9e9e382bee	Merge branch 'master' into user-beatmap-downloading-states-2	2021-02-05 15:27:17 +09:00
Dean Herbert	2fc3a97f56	Merge pull request #11516 from frenzibyte/ready-button-clean-up ... Replace ready button beatmap logic with using `MultiplayerBeatmapTracker` instead	2021-02-05 15:09:25 +09:00
Salman Ahmed	730e66f0ee	Make pausing on window focus lose instant	2021-02-05 09:07:59 +03:00
Dean Herbert	de8724b1f6	Use AddRangeInternal for simplicity, but disallow ClearInternal for safety	2021-02-05 14:39:25 +09:00
Dean Herbert	fc37d8b7df	Refactor content redirection logic to be easier to parse	2021-02-05 14:25:19 +09:00
Dean Herbert	9258836f10	Merge pull request #11641 from smoogipoo/freemods ... Add support for optional per-user mods in multiplayer (aka freemod)	2021-02-05 13:59:30 +09:00
Salman Ahmed	78ea2d50bb	Merge branch 'master' into ready-button-clean-up	2021-02-05 07:23:11 +03:00
smoogipoo	df2da5950f	Add back vertical spacer	2021-02-05 13:09:13 +09:00
smoogipoo	2e85ce5b82	Rename UserMods -> Mods for MultiplayerRoomUser	2021-02-05 12:40:16 +09:00
Dan Balasescu	a71d6a4c97	Merge branch 'master' into multiplayer-beatmap-tracker	2021-02-05 12:25:36 +09:00
smoogipoo	a2fdba3e51	Rename to OnlinePlayBeatmapAvailabilityTracker	2021-02-05 12:24:38 +09:00
smoogipoo	cf5233c6ab	Merge branch 'master' into freemods	2021-02-05 00:27:14 +09:00
Dean Herbert	f23ca7c7cf	Centralise selection animation logic	2021-02-04 18:10:55 +09:00
Dean Herbert	daf7ab9422	Apply the expected font to the checkbox's label	2021-02-04 16:58:15 +09:00
Dean Herbert	48a58e790e	Don't specify arbitrary width	2021-02-04 16:57:39 +09:00
Bartłomiej Dach	cb87da2bb8	Merge branch 'master' into freemod-select-overlay	2021-02-03 22:19:35 +01:00
Dean Herbert	b06f4ee124	Merge branch 'master' into solo-mod-select-overlay	2021-02-03 23:44:08 +09:00
Dean Herbert	17072a5dda	Merge pull request #11664 from smoogipoo/modselect-dynamic-isvalid ... Make it possible to change IsValidMod in mod selection	2021-02-03 23:43:36 +09:00
Dean Herbert	2a52851e68	Merge branch 'master' into modselect-dynamic-isvalid	2021-02-03 22:11:33 +09:00
Dean Herbert	9d7164816c	Add reverse binding for max attempts (currently unused but good for safety)	2021-02-03 22:02:40 +09:00
Dean Herbert	3fe190cfbe	Show original error message on web exceptions (or is no message is returned)	2021-02-03 22:00:16 +09:00
Dan Balasescu	f24a6178bc	Merge branch 'master' into ongoing-tracker-fix-more	2021-02-03 21:00:45 +09:00
smoogipoo	21d5f842fc	Re-layout to reduce movement	2021-02-03 14:53:55 +09:00
Dan Balasescu	2a4488c11b	Merge branch 'master' into freemods	2021-02-03 14:12:39 +09:00
Bartłomiej Dach	fc84ec1313	Move anchor specification to central place	2021-02-02 22:18:14 +01:00
Bartłomiej Dach	181d2c672b	Fix outdated comment	2021-02-02 22:05:25 +01:00
Bartłomiej Dach	fe7f4f7222	Merge branch 'master' into playlists-item-visual-improvements	2021-02-02 21:26:16 +01:00
Salman Ahmed	50d57a3931	Move tracker loading into BDL	2021-02-02 17:22:48 +03:00
smoogipoo	aeb3ed8bb3	Renamespace footer button	2021-02-02 21:46:22 +09:00
smoogipoo	6453367a9c	Merge branch 'freemod-select-overlay' into freemods	2021-02-02 21:43:35 +09:00
smoogipoo	097ce37e96	Merge branch 'fix-mod-icon' into freemods	2021-02-02 21:37:24 +09:00
smoogipoo	6ff8e8dd37	Disable a few mods by default	2021-02-02 21:29:08 +09:00
smoogipoo	5a56e2ba4b	Fix sound duplication due to checkbox	2021-02-02 21:29:00 +09:00
smoogipoo	643c0605d8	Implement the freemod selection overlay	2021-02-02 21:14:38 +09:00
smoogipoo	e58ece9e10	Make ModSelectOverlay abstract	2021-02-02 21:06:04 +09:00
smoogipoo	10ceddf3ff	Make IsValidMod adjustable	2021-02-02 20:47:50 +09:00
smoogipoo	a2e3b1c0e4	Move Mods reset code to OnlinePlaySongSelect	2021-02-02 19:02:39 +09:00
Dean Herbert	fc3adaf612	Show maximum attempt count in room display (when not unlimited)	2021-02-02 18:45:05 +09:00