1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 04:07:25 +08:00

Rename AllowDeselection to better match use case

This commit is contained in:
Dean Herbert 2021-04-28 12:02:55 +09:00
parent a9a5809e94
commit e4f2e0131c
2 changed files with 4 additions and 4 deletions

View File

@ -76,9 +76,9 @@ namespace osu.Game.Screens.Edit.Compose.Components
protected virtual DragBox CreateDragBox(Action<RectangleF> performSelect) => new DragBox(performSelect);
/// <summary>
/// Whether this component is in a state where deselection should be allowed. If false, selection will only be added to.
/// Whether this component is in a state where items outside a drag selection should be deselected. If false, selection will only be added to.
/// </summary>
protected virtual bool AllowDeselection => true;
protected virtual bool AllowDeselectionDuringDrag => true;
protected override bool OnMouseDown(MouseDownEvent e)
{
@ -354,7 +354,7 @@ namespace osu.Game.Screens.Edit.Compose.Components
break;
case SelectionState.Selected:
if (AllowDeselection && !isValidForSelection())
if (AllowDeselectionDuringDrag && !isValidForSelection())
blueprint.Deselect();
break;
}

View File

@ -81,7 +81,7 @@ namespace osu.Game.Screens.Edit.Compose.Components
protected override IEnumerable<SelectionBlueprint<HitObject>> SortForMovement(IReadOnlyList<SelectionBlueprint<HitObject>> blueprints)
=> blueprints.OrderBy(b => b.Item.StartTime);
protected override bool AllowDeselection => !EditorClock.IsRunning;
protected override bool AllowDeselectionDuringDrag => !EditorClock.IsRunning;
protected override bool ApplySnapResult(SelectionBlueprint<HitObject>[] blueprints, SnapResult result)
{