h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-15 10:02:59 +08:00
Code Issues Releases Wiki Activity

removed mods binding passthrough

Browse Source
This commit is contained in:
Denrage 2021-04-20 12:35:31 +02:00
parent 4e6cd8082e
commit c5d35ab787
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
osu.Game/Screens/Select/BeatmapInfoWedge.cs
View File

@ -41,9 +41,6 @@ namespace osu.Game.Screens.Select
[Resolved]
private IBindable<RulesetInfo> ruleset { get; set; }
[Resolved]
private IBindable<IReadOnlyList<Mod>> mods { get; set; }
[Resolved]
private BeatmapDifficultyCache difficultyCache { get; set; }
@ -150,7 +147,7 @@ namespace osu.Game.Screens.Select
removeOldInfo();
Add(Background = loaded);
Add(Info = new WedgeInfoText(beatmap, ruleset.Value, mods, beatmapDifficulty)
Add(Info = new WedgeInfoText(beatmap, ruleset.Value, beatmapDifficulty)
{
Shear = -Shear
});
@ -172,6 +169,9 @@ namespace osu.Game.Screens.Select
public OsuSpriteText VersionLabel { get; private set; }
public BeatmapSetOnlineStatusPill StatusPill { get; private set; }
[Resolved]
private IBindable<IReadOnlyList<Mod>> mods { get; set; }
private ILocalisedBindableString titleBinding;
private ILocalisedBindableString artistBinding;
private FillFlowContainer infoLabelContainer;
@ -181,14 +181,12 @@ namespace osu.Game.Screens.Select
private readonly WorkingBeatmap beatmap;
private readonly RulesetInfo ruleset;
private readonly IBindable<IReadOnlyList<Mod>> mods;
private readonly IBindable<StarDifficulty?> starDifficulty;
public WedgeInfoText(WorkingBeatmap beatmap, RulesetInfo userRuleset, IBindable<IReadOnlyList<Mod>> mods, IBindable<StarDifficulty?> difficulty)
public WedgeInfoText(WorkingBeatmap beatmap, RulesetInfo userRuleset, IBindable<StarDifficulty?> difficulty)
{
this.beatmap = beatmap;
ruleset = userRuleset ?? beatmap.BeatmapInfo.Ruleset;
this.mods = mods;
starDifficulty = difficulty;
}
@ -409,7 +407,6 @@ namespace osu.Game.Screens.Select
}
};
// this is currently not triggering when a mod gets (de)selected
mods.BindValueChanged(mods => refreshModInformation(mods), true);
}
@ -418,7 +415,7 @@ namespace osu.Game.Screens.Select
settingChangeTracker?.Dispose();
settingChangeTracker = new ModSettingChangeTracker(modsChangedEvent.NewValue);
settingChangeTracker.SettingChanged += _ => refreshBPMLabel(modsChangedEvent.NewValue);
refreshBPMLabel(mods.Value);
refreshBPMLabel(modsChangedEvent.NewValue);
}
private OsuSpriteText[] getMapper(BeatmapMetadata metadata)