11075 Commits

Author	SHA1	Message	Date
Dean Herbert	9ff9611296	Merge branch 'master' into realm-stable-subscriptions	2022-01-24 18:25:47 +09:00
Dean Herbert	d7db6fa918	Merge branch 'master' into custom-meter	2022-01-24 15:46:44 +09:00
Dean Herbert	40aa873190	Rename register methods to better explain their purpose	2022-01-24 14:37:36 +09:00
Bartłomiej Dach	bd748686fa	Adjust spacing of time signature numerator input box	2022-01-23 15:21:32 +01:00
Dean Herbert	e9e3e024a1	Update all usages of QueryAsyncWithNotifications to use new Register pathway	2022-01-23 20:28:04 +09:00
Dean Herbert	61cef42be9	Proof of concept realm subscriptions via Register	2022-01-23 20:28:04 +09:00
Dean Herbert	a5493ce0d1	Fix incorrect nesting of statements causing completely broken logic	2022-01-23 17:51:32 +09:00
Salman Ahmed	e4758c9dbb	Mark LabelledTimeSignature as public	2022-01-23 10:14:37 +03:00
Salman Ahmed	326f12f847	Add IExpandable support for SettingsToolboxGroup	2022-01-23 05:41:16 +03:00
Bartłomiej Dach	54f7b1b8d0	Use new time signature control on timing screen	2022-01-22 20:50:32 +01:00
Bartłomiej Dach	f39f2c93b5	Add control for arbitrary-numerator time signatures	2022-01-22 20:50:31 +01:00
Bartłomiej Dach	735414bc49	Replace TimeSignatures enum with struct for storage of arbitrary meter	2022-01-22 20:50:31 +01:00
Dean Herbert	33d3a10708	Merge branch 'master' into fix-intro-realm-usage	2022-01-22 23:28:43 +09:00
Bartłomiej Dach	1ce0b18003	Merge branch 'master' into display-performance-attributes	2022-01-22 14:12:57 +01:00
Bartłomiej Dach	1b2cca4a0d	Merge branch 'master' into realm-migration-ui	2022-01-22 13:52:19 +01:00
Dean Herbert	9946003069	Update osu.Game/Screens/Menu/IntroScreen.cs ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-01-22 05:09:40 +09:00
Dean Herbert	1f157d729d	Update existing subscriptions to new style ... Fix missing detach calls in `MusicController`	2022-01-21 20:05:03 +09:00
Dean Herbert	2006620a2c	Fix IntroScreen retrieving and iterating all realm beatmap sets	2022-01-21 18:03:16 +09:00
Dean Herbert	8f1dfa33a2	Merge branch 'master' into realm-context-use-update-when-feasible	2022-01-21 18:03:09 +09:00
Dean Herbert	114c9e8c1f	Update all usages of CreateContext to use either Run or Write	2022-01-21 17:27:08 +09:00
Dean Herbert	3bcdce128c	Use dictionary add for safety	2022-01-21 15:29:21 +09:00
Dean Herbert	ff4f40db8a	Merge branch 'master' into carousel-performance-n	2022-01-21 15:27:42 +09:00
Dan Balasescu	c4f24ef96c	Merge pull request #16542 from peppy/carousel-search-performance-less-simple ... Avoid performing full filter when updating carousel beatmap sets	2022-01-21 15:05:30 +09:00
Dean Herbert	5622d2ba4f	Show realm migration progress at Loader	2022-01-21 14:56:49 +09:00
Dean Herbert	bed7b69464	Apply NRT to CarouselGroup	2022-01-21 13:26:29 +09:00
Dean Herbert	5b24800b0e	Avoid applying filter in UpdateBeatmapSet flow	2022-01-21 13:26:25 +09:00
Dean Herbert	45bf35c425	Avoid performing keyword filtering at song select unless keywords are specified	2022-01-21 12:26:24 +09:00
Henry Lin	e0fe8af365	Schedule setPerformanceValue	2022-01-21 08:54:08 +08:00
Dean Herbert	ba31ddee01	Revert beatmapSets reference to fix tests ... New version changed order.	2022-01-21 00:34:12 +09:00
Dean Herbert	80f3a67876	Use for instead of foreach to avoid enumerator overhead	2022-01-20 22:21:00 +09:00
Dean Herbert	0b93f3c88f	Add <Guid,CarouselBeatmapSet> dictionary to speed up update operations in carousel	2022-01-20 22:12:49 +09:00
Dean Herbert	9a864267d2	Fix CarouselGroupEagerSelect not invoking subclassed AddChild from AddChildren calls	2022-01-20 21:57:16 +09:00
Dean Herbert	a8ce2c5edf	Detach before sending BeatmapSetInfo to any handling method	2022-01-20 21:14:10 +09:00
Dean Herbert	b1cf3befa6	Fix incorrect query in comment	2022-01-20 18:36:20 +09:00
Dean Herbert	3ba712703b	Add a note about hidden beatmap check	2022-01-20 17:50:17 +09:00
Dean Herbert	1dabf6c8a5	Fix BeatmapCarousel signalling it is finished loading before catching up on realm changes	2022-01-20 16:39:42 +09:00
Henry Lin	261fae6873	Move checks out of PopIn()	2022-01-20 08:39:33 +08:00
Dean Herbert	6c46fd6931	Fix some failing tests due to realm beatmaps overwriting test beatmaps	2022-01-20 00:19:16 +09:00
Dean Herbert	2789986699	Use asynchronous loading for beatmap carousel again	2022-01-19 18:15:43 +09:00
Dean Herbert	200fcb6f83	Detach beatmap set before checking hidden state	2022-01-19 16:59:49 +09:00
Henry Lin	0d708efb73	Split off PerformanceBreakdown and its own calculation logic	2022-01-19 15:33:33 +08:00
Dan Balasescu	9920ff51a6	Merge pull request #16446 from peppy/summary-timeline-control-point-optimisation ... Reduce number of redundant control points displayed on summary timeline	2022-01-19 15:51:20 +09:00
Dan Balasescu	2475a62f2d	Merge pull request #16518 from nekodex/participantlist-cleanup ... Remove unused BDL parameter in `ParticipantList`	2022-01-19 14:59:40 +09:00
Dean Herbert	5f5765d6a2	Reduce redundancy time range to create a bit more visual blending on the timeline	2022-01-19 14:57:01 +09:00
Dean Herbert	03ac91a3ee	Consider all points in a group to meet redundancy check	2022-01-19 14:56:44 +09:00
Dean Herbert	93cd07f7fb	Merge branch 'master' into summary-timeline-control-point-optimisation	2022-01-19 14:50:45 +09:00
Dan Balasescu	581873f944	Merge pull request #16497 from peppy/top-local-rank-optimisation ... Rewrite `TopLocalRank` to use realm subscriptions	2022-01-19 14:22:12 +09:00
Jamie Taylor	493a970ed5	Remove unused AudioManager	2022-01-19 14:08:21 +09:00
Dan Balasescu	3e5d29ed00	Merge pull request #16505 from peppy/remove-base-difficulty-usage ... Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)	2022-01-19 13:53:55 +09:00
Dean Herbert	9be5bf38c6	Simplify binding/invalidation in TopLocalRank	2022-01-19 13:20:52 +09:00
Dean Herbert	e60fd358d0	Merge branch 'master' into top-local-rank-optimisation	2022-01-19 13:04:14 +09:00
Dean Herbert	67bf95bc91	Remove all usage of AuthorString	2022-01-18 23:30:40 +09:00
Henry Lin	31e03e99cd	Improve display of "total PP"	2022-01-18 22:11:43 +08:00
Henry Lin	a5b53c01c8	Add comments and tidy up	2022-01-18 21:59:51 +08:00
Dean Herbert	7f65f3a47f	Remove all usage of BaseDifficulty (and access Difficulty instead)	2022-01-18 22:57:39 +09:00
Henry Lin	43e5bd731c	Compare performance to a perfect play	2022-01-18 21:57:12 +08:00
Dean Herbert	f5b8653491	Add spaces to query string	2022-01-18 19:28:09 +09:00
Dean Herbert	27ea37c690	Rewrite TopLocalRank to use realm subscriptions ... This addresses the number one performance concern with realm (when entering song select). Previous logic was causing instantiation and property reads of every score in the database due to the `AsEnumerable` specfication.	2022-01-18 18:17:53 +09:00
Dean Herbert	d10d657073	Merge pull request #16421 from Susko3/textbox-AllowIme-false ... Add `AllowIme => false` to text boxes where applicable	2022-01-18 18:02:47 +09:00
Dean Herbert	39c9c4985b	Merge branch 'master' into textbox-AllowIme-false	2022-01-18 17:03:51 +09:00
Henry Lin	83387cb00b	Add a comment	2022-01-17 21:41:17 +08:00
Henry Lin	eddf453294	Fix code quality issues	2022-01-17 21:32:13 +08:00
Henry Lin	c49cd60487	Add bar chart to tooltip	2022-01-17 21:26:55 +08:00
Henry Lin	85c60bfc2d	Improve tooltip design	2022-01-17 20:36:18 +08:00
Henry Lin	511a607599	Display performance breakdown in a tooltip	2022-01-17 18:28:17 +08:00
Dean Herbert	11ca1b6e7b	Remove one more usage of IsManaged which could potentially go wrong	2022-01-17 13:40:27 +09:00
Dean Herbert	5601f6f1fe	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-17 12:29:02 +09:00
Dean Herbert	566d341b1e	Split conditions out for readability	2022-01-16 22:04:29 +09:00
Dean Herbert	565611ee00	Fix typo in inline comment	2022-01-15 23:57:20 +09:00
Dean Herbert	236fa6da7e	Rename ControlPointVisualisation interface type to be less specific	2022-01-15 23:56:00 +09:00
Dean Herbert	c5cae4e3ee	Rename methods and add xmldoc	2022-01-15 23:55:11 +09:00
Dean Herbert	4ca2822d40	Merge pull request #16447 from nekodex/mp-host-changed-sfx ... Add audio feedback for host change in multiplayer rooms	2022-01-15 23:43:35 +09:00
Bartłomiej Dach	03e4ec4214	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-15 14:45:42 +01:00
Dean Herbert	671a3d47b8	Move bindable binding to LoadComplete and remove unnecessary unbind	2022-01-15 21:20:27 +09:00
Dean Herbert	ea8e49c543	Reorder private/protected methods	2022-01-15 21:19:02 +09:00
Dean Herbert	64c499d9d6	Revert unintended temporary commenting (was used during benchmarking)	2022-01-15 15:24:30 +09:00
Susko3	19467e58c1	Remove unused params from BDL methods	2022-01-15 01:06:39 +01:00
Dean Herbert	7acd1b545f	Remove unnecessary Live conversion in IntroScreen (handled by GetWorkingBeatmap)	2022-01-14 19:55:09 +09:00
Dean Herbert	34dbde6023	Only copy across Hash and ID so statistics aren't lost	2022-01-14 18:22:52 +09:00
Jamie Taylor	7e9b5dd150	Add audio feedback for host change in multiplayer	2022-01-14 18:11:00 +09:00
Dean Herbert	916b591b1b	Fix watch replay button not working immediately after playing	2022-01-14 18:03:06 +09:00
Dean Herbert	c64a919a9d	Reduce number of redundant control points displayed on summary timeline ... As pointed out in https://github.com/ppy/osu/discussions/16435, beatmaps with too many control points (usually added via external automation apps) could cause the lazer editor to grind to a halt. The overheads here are mostly from the GL side. An eventual goal would be to render this in a smarter way, rather than using thousands of drawables. Until that, this optimisation should help reduce the overhead by omitting control points in close proximity that are redundant for display purposes. I've tried to contain this in the display logic directly, with the goal that it can be ripped out as fast as it was added. Certainly required more changes than I hoped for, but I don't think it's too ugly.	2022-01-14 17:13:26 +09:00
Dean Herbert	54804ebfbd	Fix delete/clear scores buttons not working	2022-01-13 18:38:38 +09:00
Jamie Taylor	c6ae255326	Add volume dip to track during fail sequence	2022-01-13 18:31:32 +09:00
Dean Herbert	069d6d2954	Remove pointless compatibility parameter BeatmapSetInfoID	2022-01-13 18:02:10 +09:00
Dean Herbert	6025fe325d	Fix filter criteria not being applied after carousel loads new beatmap sets	2022-01-13 15:08:51 +09:00
Dean Herbert	0a133c7e97	Fix typo in comment in IntroScreen	2022-01-13 13:47:23 +09:00
Dean Herbert	b2d09b7b10	Fix further warnings	2022-01-12 23:42:12 +09:00
Dean Herbert	51251e3204	Fix CI reported warnings	2022-01-12 22:39:00 +09:00
Dean Herbert	ef0f794fd6	Remove stay newline	2022-01-12 18:13:14 +09:00
Dean Herbert	eb70a1eeb7	Replace compatibility properties with direct references	2022-01-12 18:13:14 +09:00
Dean Herbert	482cf29e28	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-12 17:57:14 +09:00
Dean Herbert	34aa1bf21d	Sanitise and remove some usages of Detach which are no longer required	2022-01-12 17:49:11 +09:00
Dean Herbert	dc3730f334	Fix song select import popup not always showing	2022-01-12 17:49:11 +09:00
Dean Herbert	0aff1c232b	Fix deleted/hidden carousel queries	2022-01-12 17:49:11 +09:00
Dean Herbert	46e92c3b60	Clean up BeatmapManager query methods	2022-01-12 17:49:11 +09:00
Dean Herbert	e8dcbaf29a	Fix intro screen hitting null reference if intro beatmap is unavailable	2022-01-12 17:49:11 +09:00
Dean Herbert	7dba3c3551	Fix most remaining test issues	2022-01-12 17:49:11 +09:00
Dean Herbert	80eee6d7b0	Make RealmArchiveModelManager.Update work using automapper	2022-01-12 17:49:11 +09:00
Dean Herbert	7509a9ff8f	Update BeatmapModelManager.Save to work for editor scenarios	2022-01-12 17:49:11 +09:00
Dean Herbert	58f8aae731	Fix one missed instance of GetResultSafely	2022-01-12 17:49:11 +09:00
Dean Herbert	02d0ca2741	Fix protected beatmaps showing up in the song select carousel	2022-01-12 17:49:10 +09:00
Dean Herbert	41d90cd0b5	Fix beatmap carousel test failures	2022-01-12 17:49:10 +09:00
Dean Herbert	f4a1fa85a1	Fix incorrect conditional for deciding whether scores can be deleted from UI	2022-01-12 17:49:10 +09:00
Dan Balasescu	52e240230b	Merge branch 'master' into mouse-button-disable-disables-touch	2022-01-12 17:14:39 +09:00
Dean Herbert	5dd0bb1218	Ensure Score created by GameplayState has a valid ruleset	2022-01-12 17:00:17 +09:00
Dean Herbert	e74a5022c9	Fix multiple tests via null checks and changing ToLive to Detach ... flow	2022-01-12 17:00:17 +09:00
Dean Herbert	6919df18fa	Fix incorrect ordering and grouping of difficulties at song select	2022-01-12 17:00:17 +09:00
Dean Herbert	2b8706b6ce	Detach and reattach scores to make work	2022-01-12 17:00:16 +09:00
Dean Herbert	60d2de8a3b	Fix potential nullref when song select filters to no results	2022-01-12 17:00:16 +09:00
Dean Herbert	de3a338d02	Update realm queries to use Filter to allow for indirect property filtering	2022-01-12 17:00:16 +09:00
Dean Herbert	8461eaab46	BeatmapSetInfo detach support	2022-01-12 17:00:16 +09:00
Dean Herbert	de076678fe	Fix some remaining test failures	2022-01-12 17:00:16 +09:00
Dean Herbert	3811bd8520	Fix some null inspections	2022-01-12 17:00:16 +09:00
Dean Herbert	33060990b7	Temporarily disable WorkingBeatmapCache and fix multiple invalid data flows	2022-01-12 17:00:16 +09:00
Dean Herbert	4295815c7d	Fix invalid equality comparison in BeatmapLeaderboard	2022-01-12 17:00:16 +09:00
Dean Herbert	86ce2256be	Replace SpectatorScreen event flow with realm subscriptions	2022-01-12 17:00:16 +09:00
Dean Herbert	6d60aa7d9c	Replace TopLocalRank event flow with realm subscriptions	2022-01-12 17:00:16 +09:00
Dean Herbert	c9257e9ecc	Fix missing disposal of realm subscriptions in BeatmapCarousel	2022-01-12 17:00:16 +09:00
Dean Herbert	5dc497e949	Replace BeatmapLeaderboard event flow with realm subscriptions	2022-01-12 17:00:16 +09:00
Dean Herbert	1f9318265e	Update ToLive usages in line with recent changes	2022-01-12 17:00:16 +09:00
Dean Herbert	db05727ec4	Remove unused includeProtected parameter	2022-01-12 17:00:16 +09:00
Dean Herbert	a3276758b8	Remove unnecessary re-query of beatmap set in editor menu construction	2022-01-12 17:00:16 +09:00
Dean Herbert	1d536fd0bc	Start introducing ILive	2022-01-12 17:00:16 +09:00
Dean Herbert	3152d2d8a0	"Update" BeatmapCarousel	2022-01-12 17:00:16 +09:00
Dean Herbert	8696f82627	Fix intro screen ... Fix things	2022-01-12 17:00:16 +09:00
Dean Herbert	00e3af3366	Update model manager and many related classes to get things compiling again	2022-01-12 17:00:00 +09:00
Dean Herbert	4f6a05ce3d	Reimplement all query methods	2022-01-12 16:57:27 +09:00
Dean Herbert	53792811b2	more fixes (almost compiles, except ruleset and manager)	2022-01-12 16:57:27 +09:00
Dean Herbert	2a4bee61dd	Update many score-related classes to move closer to being able to persist to realm	2022-01-12 16:57:27 +09:00
Dean Herbert	b8cd3cdbbc	Various updates to ruleset and primary key usages to move closer to realm support	2022-01-12 16:57:13 +09:00
Dean Herbert	83cbee39de	Mark cases where BeatmapSet is generally guaranteed to be non-null	2022-01-12 16:39:36 +09:00
Dean Herbert	e6fdd0e969	Miscellaneous fixes that don't fit elsewhere	2022-01-12 16:39:36 +09:00
Dean Herbert	213d89b479	Update null fallback cases involving OnlineID	2022-01-12 16:39:36 +09:00
Susko3	a0842838e7	Add AllowIme => false where applicable ... Also adds `AllowWordNavigation => false` to password text box.	2022-01-12 00:15:17 +01:00
Dean Herbert	e333831c45	Merge pull request #16371 from bdach/angle-of-rotation-display ... Add tooltip with relative rotation in degrees to rotation handles	2022-01-10 22:19:50 +09:00
Dan Balasescu	af9fad00c3	Merge branch 'master' into async-deadlock-safety	2022-01-10 16:11:09 +09:00
Dan Balasescu	928023fabb	Merge pull request #16362 from bdach/multiplayer-wrong-ruleset ... Fix multiplayer starting gameplay using last picked item ruleset rather than actual current item ruleset	2022-01-10 15:10:27 +09:00
Dean Herbert	02d8a6359a	Update FilterMatchingTest and filter code to use ruleset's OnlineID ... The tests were relying on the `RulesetID` being set to 0 in the example beatmap, even though the ruleset *instance* was set to ID 5. This explicitly adds that 0 value to show intent, and also removes the incorrect specification of 5 (which would cause the convert filter tests to fail). Also updates the filter code to use `OnlineID`, which is required in realm changes.	2022-01-10 12:30:34 +09:00
Bartłomiej Dach	d76c674abc	Add tooltip with relative rotation in degrees to rotation handles	2022-01-08 20:24:15 +01:00
Bartłomiej Dach	24d377fddb	Move implementation of drag handle operations to concrete classes	2022-01-08 20:24:00 +01:00
Bartłomiej Dach	9370e84460	Fix effect point multiplier text box displaying too much decimal digits	2022-01-08 16:12:52 +01:00
Bartłomiej Dach	c5ac996e3f	Restore ruleset using current playlist item on resuming room sub screen ... Ensures that the ruleset selected at the multiplayer song selection screen does not overwrite the current playlist item's ruleset.	2022-01-08 14:56:01 +01:00
Dean Herbert	0698ef6330	Fix one missed rename	2022-01-07 17:36:29 +09:00
Dean Herbert	2ef791069c	Fix typon on AdvancedStats	2022-01-07 17:33:38 +09:00
Dean Herbert	3cd996eb4a	Merge branch 'master' into async-deadlock-safety	2022-01-07 17:28:59 +09:00
Dan Balasescu	bf328dc9e0	Merge pull request #16291 from peppy/fix-mods-mutated-outside-lease ... Fix `MultiplayerMatchSubScreen` mutating mods outside of bindable lease	2022-01-07 17:12:12 +09:00
Bartłomiej Dach	f5742d3d2a	Merge branch 'master' into editor-toolbox-expand	2022-01-06 19:01:02 +01:00
Dean Herbert	00177a3ae1	Update usages to new naming	2022-01-06 22:54:43 +09:00
Dean Herbert	3ea7588a91	Update continuation usages to use GetCompletedResult	2022-01-06 22:53:07 +09:00
Dean Herbert	5baaf356aa	Split out SettingsToolboxGroup from PlayerSettingsGroup	2022-01-06 21:05:00 +09:00
Dean Herbert	df6a755c36	Update player loader screen mouse disable text to use localised version	2022-01-05 18:29:09 +09:00
Dean Herbert	6779503e57	Refactor logic to avoid TimelineSelectionHandler having to block base calls	2022-01-05 16:56:54 +09:00
Dean Herbert	866ae3472b	Add global flip hotkeys	2022-01-05 16:48:07 +09:00
Dean Herbert	13cce50fa7	Remove existing handling of flip hotkeys	2022-01-05 16:30:42 +09:00
Dean Herbert	73b40e6833	Replace usage of .Result with .WaitSafelyForResult	2022-01-04 11:51:41 +09:00
Dean Herbert	031a40af6a	Replace usages of Wait with WaitSafely	2022-01-04 11:51:41 +09:00
Dean Herbert	675bdd3213	Fix MultiplayerMatchSubScreen mutating mods outside of bindable lease ... As seen at https://github.com/peppy/osu/runs/4674501626?check_suite_focus=true.	2022-01-01 12:13:59 +09:00
Joseph Madamba	7de43e3aba	Fix most open compound words in identifiers being closed	2021-12-27 20:26:28 -08:00
Joseph Madamba	98524d60a4	Fix clear identifier typos	2021-12-27 20:26:28 -08:00
Bartłomiej Dach	5a591713ae	Fix legacy combo counter not fully hiding for rulesets that implement their own	2021-12-26 16:49:20 +01:00
Dan Balasescu	a43cc20ae2	Apply changes to GameplayCompleted from reviews	2021-12-24 21:58:20 +09:00
Dan Balasescu	c6854b37c8	Unbind event on disposal	2021-12-24 21:58:09 +09:00
Dan Balasescu	727335dcad	Improve reliability of exiting gameplay	2021-12-24 14:23:09 +09:00
Dan Balasescu	67e6b50c12	Merge pull request #16135 from stanriders/refactor-diffcalc ... Slightly refactor difficulty and pp calculators	2021-12-22 19:44:02 +09:00
Dean Herbert	5b3a154431	Fix potential errors thrown during beatmap leaderboard display due to incorrect beatmap reference ... Specifically, the global `BeatmapInfo` is referenced inside the web request's success callback, and used to attempt population via methods which expect non-null beatmap inputs. Closes #16211.	2021-12-22 17:24:48 +09:00
Dean Herbert	a88800c99a	Merge pull request #16198 from smoogipoo/fix-current-item-before-population ... Fix delete button showing on current item before beatmap retrieval	2021-12-22 13:15:07 +09:00
Dan Balasescu	98f044881e	Merge branch 'master' into refactor-diffcalc	2021-12-22 12:31:28 +09:00
Bartłomiej Dach	7ab1c0c99d	Improve contrast of timeline blueprint foreground content for pastel combo colours	2021-12-21 12:54:17 +01:00
StanR	cca02a8016	Create PerformanceAttributes	2021-12-21 13:08:31 +03:00
Dean Herbert	0bda7892f7	Merge pull request #16197 from bdach/beatmap-card/renames ... Rename beatmap card-related classes	2021-12-21 18:51:34 +09:00
Dan Balasescu	4ce61d4260	Directly bind to room updates ... Currently doesn't really cause any difference, however it may in the future if we decide the queueing algorithm shouldn't update PlaylistOrder when an item has been played.	2021-12-21 18:40:29 +09:00
Dan Balasescu	a34d24fb20	Disallow expired items from showing delete button ... This isn't possible in practice since expired items are removed from the queue list, but this helps out in tests.	2021-12-21 18:37:42 +09:00
Dan Balasescu	4ba5a939db	Merge pull request #16178 from bdach/lounge-background-screen-correct ... Fix lounge screen showing information sourced from wrong playlist item	2021-12-21 17:36:23 +09:00
Dan Balasescu	51b7e920c0	Fix delete button being able to show on current item	2021-12-21 16:57:58 +09:00
Dan Balasescu	32fbaf47c0	Merge pull request #16192 from peppy/add-room-lost-logging ... Add logging of `MultiplayerMatchSubScreen` exiting from room loss	2021-12-21 16:37:08 +09:00
Bartłomiej Dach	88d4e95ad8	Rename BeatmapCard{ => Normal}	2021-12-21 08:26:21 +01:00
Dean Herbert	d08b66a5ff	Also add logging to OnlinePlayScreen	2021-12-21 15:07:06 +09:00
Dean Herbert	ddadf3c4b5	Add logging of MultiplayerMatchSubScreen exiting from room loss	2021-12-21 14:53:24 +09:00
Dean Herbert	edcbd4de6d	Fix incorrect event unbind logic	2021-12-21 13:05:26 +09:00
Dean Herbert	52db7b36fc	Move Schedule call to base implementation of error meter for extra safety	2021-12-21 12:55:21 +09:00
Dean Herbert	28d6ff5d9c	Fix potential wrong thread mutation in ColourHitErrorMeter	2021-12-21 12:36:04 +09:00
Bartłomiej Dach	a5a9922f81	Fix lounge screen content not matching current room playlist item	2021-12-20 13:32:42 +01:00
Dean Herbert	6907a9a3cc	Name some screen stacks for better logging context	2021-12-20 18:24:14 +09:00
Bartłomiej Dach	cbb65e1e07	Merge branch 'master' into beatmap-card-expanded-state-fix	2021-12-15 22:20:30 +01:00
Dean Herbert	cd8dfac625	Merge pull request #16097 from smoogipoo/forego-resetting-spectate-state ... Don't reset spectating state if spectator exited after gameplay finishes	2021-12-15 22:30:41 +09:00
Dean Herbert	33cf4ba7f6	Merge pull request #16075 from smoogipoo/prevent-idle-transition-during-load ... Add AbortGameplay() to fix state transition race conditions during multiplayer load	2021-12-15 19:59:19 +09:00
Dean Herbert	9e82a3e79a	Merge branch 'master' into forego-resetting-spectate-state	2021-12-15 18:05:06 +09:00
Dan Balasescu	18d7b79207	Don't reset spectating state if gameplay is finished	2021-12-15 17:40:30 +09:00
Dan Balasescu	740a6f16c7	Fix exception when updating the room's visual playlist	2021-12-15 16:53:25 +09:00
Dean Herbert	ef4ab74565	Also only expose Expanded state of BeatmapCard as read-only	2021-12-15 16:26:19 +09:00
Dan Balasescu	9ade8069a1	Rename to AbortGameplay() and handle additional states	2021-12-15 06:40:28 +09:00
Dan Balasescu	4c81fd8b7c	Merge pull request #16068 from peppy/fix-fail-animation-background-dim ... Improve appearance of player-wide background after failing with low background dim	2021-12-15 06:32:02 +09:00
Bartłomiej Dach	00154fe86d	Merge branch 'master' into fix-menu-background-desync	2021-12-14 21:31:10 +01:00
Dean Herbert	8c6f50ddb1	Fix BackgroundScreenDefault incorrectly updating current background after being inactive ... If the beatmap was changed but then reverted to the previously displayed map, the background may have displayed incorrectly on resuming. Closes #15804.	2021-12-14 16:40:50 +09:00
Dean Herbert	b6a272e31a	Add failing test coverage of BackgroundScreeNDefault's beatmap background tracking when active/non-active	2021-12-14 16:40:34 +09:00
Dean Herbert	7e576ae9d3	Add note about how the background colour is restored	2021-12-14 13:25:19 +09:00
Dan Balasescu	2f1dc91211	Add AbortLoad() method to abort gameplay loads	2021-12-14 11:30:42 +09:00
Dan Balasescu	70045494ba	Re-simplify code by removing BeatmapManager event instead	2021-12-13 16:09:54 +09:00
Dean Herbert	cac684c044	Improve appearance of player-wide background after failing with low background dim	2021-12-13 14:53:11 +09:00
Dean Herbert	c097dc8048	Add note about reasoning behind MultiplayerClient.GetAPIBeatmap call	2021-12-13 13:39:32 +09:00
Dean Herbert	3ea07b426b	Merge branch 'master' into multiplayer-local-beatmap-query	2021-12-13 13:27:34 +09:00
Dan Balasescu	2cd2b10ce1	Fix results sometimes showing incorrect score position	2021-12-13 06:54:57 +09:00
Dan Balasescu	bf3abb2455	Merge branch 'master' into multiplayer-local-beatmap-query	2021-12-12 16:37:41 +09:00
Dan Balasescu	a6e77f172d	Add some comments	2021-12-12 16:30:37 +09:00
Dan Balasescu	d6c08fae48	Fix incorrect global beatmap with availability changes	2021-12-11 23:08:21 +09:00
Dan Balasescu	ece2cddb7f	Fix DrawableRoomPlaylistItem lookup interfering with tests	2021-12-11 22:51:20 +09:00
Dan Balasescu	25b274c323	Fix starting gameplay too early after import	2021-12-11 22:47:50 +09:00
Dan Balasescu	1aac978a7b	Merge pull request #16029 from peppy/editor-mod-reset ... Fix editor not resetting mods when entering	2021-12-11 20:20:11 +09:00
Dan Balasescu	63a017bc8e	Use Array.Empty instead	2021-12-11 19:33:37 +09:00
Dan Balasescu	cdb8237a4b	Merge branch 'master' into pre-realm-score-tidy	2021-12-11 19:25:39 +09:00
Dan Balasescu	6057037e35	Move playlist item beatmap population to MatchSubScreen	2021-12-10 20:08:59 +09:00
Dean Herbert	c1b3ee6bb2	Fix editor not resetting mods when entering ... Would leave the user potentially in a test mode that is in a weird state (ie. if cinema mod was enabled). Eventually we'll add the ability to choose mods for test play, but that will be done in a saner way. Closes #15870.	2021-12-10 18:57:45 +09:00
Dean Herbert	f7c5a3f506	Use similar method of consuming OnlineID as done in beatmap classes	2021-12-10 18:34:31 +09:00
Dan Balasescu	e98060ac37	Remove unused using	2021-12-10 17:55:18 +09:00
Dean Herbert	970a9ae074	Add update thread asserts to RoomManager methods	2021-12-10 17:22:24 +09:00
Dean Herbert	3633494509	Merge pull request #16020 from smoogipoo/host-enqueue-2 ... Add support for enqueueing items in host-only mode, and changing arbitrary playlist items	2021-12-10 16:23:48 +09:00
Dean Herbert	dbb08f7d46	Use OnlineID for set operations	2021-12-10 16:11:48 +09:00
Dean Herbert	bf1418bafc	Use OnlineID instead of legacy IDs for equality and lookups	2021-12-10 16:11:48 +09:00
Dan Balasescu	4e6286920c	Merge pull request #16017 from peppy/fix-child-set-after-disposal ... Fix potential crash due to children being mutated after disposal	2021-12-10 15:38:34 +09:00
Dan Balasescu	de0f37b08d	Separate editing and adding playlist items	2021-12-10 15:26:48 +09:00
Dean Herbert	88670c3b01	Document OpenSongSelection and mark null param	2021-12-10 14:14:22 +09:00
Dean Herbert	50bf2f368d	Merge branch 'master' into host-enqueue-2	2021-12-10 14:09:19 +09:00
Dean Herbert	9ac8e6c81c	Add missing null check before attempting to populate bpm info	2021-12-10 13:53:48 +09:00
Dean Herbert	612f47bb9f	Add the ability to create playlists of 2 weeks ~ 3 months in duration	2021-12-10 13:45:29 +09:00
Dean Herbert	1952819db2	Merge pull request #16019 from smoogipoo/cleanup-playlist-item-buttons ... Cleanup duplicated classes in DrawableRoomPlaylistItem	2021-12-10 12:01:26 +09:00
Dan Balasescu	35a208a478	Merge pull request #15999 from peppy/restore-user-volume-muted-notification ... Fix the unmute notification potentially overwriting user's volume levels unnecessarily	2021-12-10 02:58:59 +09:00
Dan Balasescu	671582a925	Allow host to enqeue items and items to be edited	2021-12-10 01:15:19 +09:00
Dan Balasescu	048a495115	Add edit button to DrawableRoomPlaylistItem	2021-12-10 01:08:54 +09:00
Dan Balasescu	05aa9635a8	Privatise button again	2021-12-10 00:38:18 +09:00
Dan Balasescu	f9af239ed9	Cleanup duplicated classes in DrawableRoomPlaylistItem	2021-12-09 23:56:49 +09:00
Dean Herbert	538a822760	Merge branch 'master' into multiplayer-playlist-deletion	2021-12-09 19:04:06 +09:00
Dean Herbert	a3b53ac2f6	Change comparison to match in all locations	2021-12-09 18:58:47 +09:00
Dean Herbert	b393f83028	Merge pull request #16009 from smoogipoo/cleanup-drawable-playlist ... Cleanup DrawableRoomPlaylist and DrawableRoomPlaylistItem	2021-12-09 18:54:16 +09:00
Dean Herbert	e7e61cd9ab	Fix potential crash due to children being mutated after disposal ... This is a bit of an unfortunate edge case where the unbind-on-disposal doesn't help, since the binding is happening in BDL, and the usage is in a nested `LoadComponentAsync` call. Combine those and you have a recipe for disaster.	2021-12-09 18:52:00 +09:00
Dean Herbert	dfe19f3509	Minor code reformatting	2021-12-09 17:53:40 +09:00
Dan Balasescu	0963b00453	Disallow item selection in playlists song select	2021-12-09 17:33:59 +09:00
Dan Balasescu	17d676200b	Xmldoc fixes from code review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-12-09 17:33:36 +09:00
Dan Balasescu	1a0945daba	Siplify condition, allow host to always remove items	2021-12-09 14:33:50 +09:00
Dan Balasescu	8398f86440	Don't consider expired items in visibility check	2021-12-09 04:02:16 +09:00
Dan Balasescu	c34c580ad4	Add client-side + interface implementation	2021-12-09 03:08:59 +09:00
Dan Balasescu	23332995d1	Invert naming of exposed actions	2021-12-09 01:52:59 +09:00
Dan Balasescu	273042aa16	Add virtual method for creating different DrawablePlaylistItem types	2021-12-09 01:49:34 +09:00
Dan Balasescu	3b4833ca8e	A bit of cleanup + xmldocs on classes/members	2021-12-09 01:40:16 +09:00
Dan Balasescu	be2dbf42c3	Flatten DrawableRoomPlaylistWithResults into base class	2021-12-09 01:40:16 +09:00
Dan Balasescu	26f6c5e5a5	Remove ctor params from PlaylistsRoomPlaylist	2021-12-09 01:16:37 +09:00
Dan Balasescu	3be4d8b68d	Remove ctor params from DrawableRoomPlaylist/DrawablePlaylistItem	2021-12-09 01:04:56 +09:00
Dean Herbert	8d9c37a825	Merge branch 'master' into primary-key-consistency	2021-12-08 21:34:38 +09:00
Dan Balasescu	beb5d61a42	Separate playlist item deletion to Playlists-specific class	2021-12-08 20:50:25 +09:00
Dan Balasescu	65a09692da	Merge pull request #16001 from peppy/fix-own-rank-results-panel-in-multiplayer ... Fix the local user's rank not showing on multiplayer/playlist results screen	2021-12-08 16:34:36 +09:00
Dean Herbert	872e0884c0	Fix the local user's rank not showing on multiplayer/playlist results screen ... Applying the simple solution for now. Not sure how this will evolve over time, but seems sane enough.	2021-12-08 15:22:10 +09:00
Dean Herbert	6ec3f41839	Fix LegacyComboCounter not handling non-default anchor/origin specifications correctly	2021-12-08 15:07:15 +09:00
Dean Herbert	0775053a18	Fix the unmute notification potentially overwriting user's volume levels unnecessarily ... I've also changed the cutoffs to 5% rather than zero, as this seems like a saner method of showing this dialog. With levels 5% or less, the game is basically inaudible. Arguably, the cutoff can be increased to 10%.	2021-12-08 13:38:43 +09:00
Bartłomiej Dach	10dd64e07c	Fix being able to paste objects while composer is loading ... Would lead to exceptions due to modification of `Beatmap.HitObjects` during its enumeration by `DrawableRuleset`, which was happening as an async load via `EditorScreenWithTimeline.CreateMainContent()`.	2021-12-07 21:00:25 +01:00
Dan Balasescu	86eacfdbd8	Merge pull request #15879 from peppy/multiplayer-delayed-playlist-load-broken ... Load playlist panels on demand to reduce initial load time when joining a room	2021-12-08 00:42:20 +09:00
Dean Herbert	d6e68feadc	Merge pull request #15948 from bdach/beatmap-card/difficulty-dropdown ... Add difficulty dropdown to beatmap card	2021-12-07 23:40:06 +09:00
Dan Balasescu	7e236c3a41	Remove unused dependency	2021-12-07 23:36:48 +09:00
Dan Balasescu	52230a6f00	Merge branch 'master' into multiplayer-delayed-playlist-load-broken	2021-12-07 22:45:05 +09:00
Dean Herbert	a8c20368c0	Merge pull request #15976 from smoogipoo/add-modes-to-room-panels ... Add match type and queue mode to multiplayer room panels	2021-12-07 22:08:30 +09:00
Dan Balasescu	4683193f09	Move implementation to base class	2021-12-07 20:36:39 +09:00
Dan Balasescu	5ffe702dd6	Add match type and queue mode to multiplayer room panels	2021-12-07 18:57:13 +09:00
Dean Herbert	dea7f2308c	Fix participant panels potentially keeping a reference to an old user ... If a user leave and then rejoins a multiplayer match while another user is not at the lobby screen, there is a potential the `ParticipantPanel` tracking the user will not correctly be recreated to reference the new instance of the `MultiplayerUser`. This happens because the `OnRoomUpdated` call is scheduled, which means it is not running in the background, coupled with the local logic that relies on `IEquatable(MultiplayerRoomUser)` (which in turn falls back to a UserID comparison). Changing this to a reference comparison is the easiest way to resolve this. Whether we change the `IEquatable` implementation is up for discussion. Closes https://github.com/ppy/osu/issues/15970.	2021-12-07 17:24:04 +09:00
Dean Herbert	0ea7a69084	Ensure user is returned to the RoomSubScreen before gameplay is started ... This covers the scenario where a user may be at the song select screen while another user (the room host) starts the match. This was only made possible with the new queue modes, so is quite a recent regression.	2021-12-06 14:03:52 +09:00
Dean Herbert	a76cfbea21	Add test coverage of incorrect beatmap being used in multiplayer when match started from song select	2021-12-06 14:03:33 +09:00
Bartłomiej Dach	af35652b8b	Disable beatmap card expansion on solo spectator screen	2021-12-05 20:07:58 +01:00
Dean Herbert	e1897f9998	Don't debounce MultiplayerRoomComposite events ... This avoids accidental usage which could result in data being lost or ignored (as only the last `user` in a single frame would arrive). This was added specifically to debounce sample playback, but given that it's only debouncing on a single frame (hardly noticeable) I'm not going to add back support for that yet. It should be handled by sample playback concurrency or something more local to the usage.	2021-12-05 01:38:39 +09:00
Bartłomiej Dach	38702beabf	Merge branch 'master' into i-ruleset-store	2021-12-04 15:05:39 +01:00
Bartłomiej Dach	53a6ef22ce	Add null check to resolve inspection	2021-12-04 14:55:35 +01:00
Bartłomiej Dach	b3b239c9a1	Fix test failures due to beatmap lookup logic being active even when model is populated	2021-12-04 13:59:01 +01:00
Dean Herbert	517a344bcc	Merge branch 'master' into new-multiplayer-playlist	2021-12-04 13:16:09 +09:00
Dan Balasescu	d5803e541b	Give playlist items a PlayedAt date	2021-12-03 20:25:51 +09:00
Dan Balasescu	4145a16d5b	Merge pull request #15920 from peppy/clean-up-unused-resolves ... Clean up unused resolved properties	2021-12-03 20:08:48 +09:00
Dean Herbert	1eed2436e6	Clean up unused resolved properties	2021-12-03 18:49:49 +09:00
Dean Herbert	2acf46154a	Remove many unused resolutions of RulesetStore	2021-12-03 18:16:29 +09:00
Dean Herbert	e75e209053	Cache and consume IRulesetStore where feasible	2021-12-03 18:16:01 +09:00
Dean Herbert	6b73672403	Stop Player from blocking volume adjust when Alt it held ... Similar case to what we already have in `OsuScrollContainer`, so there is precedent for handling this locally in this fashion.	2021-12-03 17:18:07 +09:00
Dan Balasescu	487a71312e	Split out code so base methods aren't called	2021-12-03 16:40:20 +09:00
Dan Balasescu	0a1304b92a	Remove gameplay_order, use existing playlist_order	2021-12-03 15:45:13 +09:00
Dan Balasescu	b75a5b778e	Update history list to also sort by gameplay order	2021-12-03 15:05:56 +09:00
Dan Balasescu	933fd49cff	Fix missed callbacks due to AddOnce() schedules	2021-12-02 22:33:14 +09:00
Dan Balasescu	9760a2b087	Update MultiplayerQueueList to take advantage of GameplayOrder	2021-12-02 22:33:14 +09:00
Dean Herbert	512818648f	Add some more breathing room between tab control and queue content	2021-12-02 16:56:30 +09:00
Dean Herbert	a8e17cb3a5	Add relative size specs so partially on-screen panels still start loading ... Without this, panels at the top of the list but not fully on-screen wouldn't begin their metadata loading process.	2021-12-01 22:46:38 +09:00
Dean Herbert	d262baefad	Only query for the owner user metadata in the case it is actually required	2021-12-01 22:43:32 +09:00
Dean Herbert	a0ff86f5e8	Ensure all read and write operations on APIRoom are done on the update thread	2021-12-01 22:43:03 +09:00
Dan Balasescu	e5e2ae8ab4	Fix dangling line post-rebase	2021-12-01 21:36:25 +09:00
Dan Balasescu	e87b0003fb	Fix queue mode not being bound to in all cases	2021-12-01 21:35:23 +09:00
Dan Balasescu	ad35f3434b	Fix queue list not considering expired items	2021-12-01 21:35:23 +09:00
Dan Balasescu	e2f289eeff	Xmldocs	2021-12-01 21:35:23 +09:00
Dan Balasescu	93a7726f4a	Remove now-unused parameter	2021-12-01 21:35:23 +09:00
Dan Balasescu	d70355237d	Fix selected item not bound	2021-12-01 21:35:23 +09:00
Dan Balasescu	c3dfe10a8a	Add new list to match subscreen	2021-12-01 21:35:22 +09:00
Dan Balasescu	1152c4e8e9	Fix tests	2021-12-01 21:35:22 +09:00
Dan Balasescu	7847ce6253	Redesign with tab control	2021-12-01 21:35:22 +09:00
Dan Balasescu	95050d6597	Extract class to file	2021-12-01 21:35:22 +09:00
Dan Balasescu	fc8c8685b8	Add playlist queue tests	2021-12-01 21:35:22 +09:00
Dan Balasescu	e0ca1af9b8	Remove ctor params	2021-12-01 21:35:22 +09:00
Dan Balasescu	bfd2dc28c8	Rename QueueList -> MultiplayerQueueList	2021-12-01 21:35:22 +09:00
Dan Balasescu	6b198ce112	Document simulation	2021-12-01 21:35:22 +09:00
Dan Balasescu	ef170471f0	Merge branch 'master' into new-multiplayer-playlist	2021-12-01 21:35:22 +09:00
Dan Balasescu	9806c75743	Implement better round robin algorithm	2021-12-01 21:35:12 +09:00
Dan Balasescu	68bb49fc1e	Add QueueList tests	2021-12-01 21:33:48 +09:00
Dan Balasescu	0cb35e8b18	Separate out QueueList	2021-12-01 21:33:48 +09:00
Dan Balasescu	17bc0b51aa	Merge branch 'playlist-item-add-owner' into new-multiplayer-playlist	2021-12-01 21:33:48 +09:00
Dan Balasescu	942e48ffbd	Merge branch 'master' into new-multiplayer-playlist	2021-12-01 21:33:11 +09:00
Dan Balasescu	c38537a51a	Initial implementation of MultiplayerPlaylist	2021-12-01 21:32:56 +09:00
Dean Herbert	e4ba66877d	Improve transitions when loading new data into a playlist panel	2021-11-30 19:54:26 +09:00
Dean Herbert	fe119da044	Add fetching of beatmap and user data when playlist panels come on screen	2021-11-30 19:52:36 +09:00
Bartłomiej Dach	95373649a4	Skip null items in star rating range display	2021-11-30 19:44:50 +09:00
Bartłomiej Dach	695167a749	Add support for null item display in DrawableRoomPlaylistItem	2021-11-30 19:44:50 +09:00
Dean Herbert	a7e4e7be3a	Remove the ability to specify a filename in ReplaceFile	2021-11-29 18:11:51 +09:00
Bartłomiej Dach	05f7ea6b6d	Remove mentions of "panel" and "direct" from names of old download buttons	2021-11-27 15:08:03 +01:00
Bartłomiej Dach	a043d1e427	Move old beatmap download button to more general namespace	2021-11-27 15:06:57 +01:00
Dean Herbert	b8a47755fa	Don't show loading tooltip for now ... Should probably be replaced with a loading spinner in the future, don't really like "loading" tooltips.	2021-11-26 22:54:11 +09:00
Dan Balasescu	e1445dcb05	Only show owner in match subscreen	2021-11-26 17:40:45 +09:00
Dan Balasescu	8be2defd09	Right-align avatar	2021-11-26 17:17:06 +09:00
Dan Balasescu	8541db1e85	Merge branch 'master' into playlist-item-add-owner	2021-11-26 17:13:23 +09:00
Bartłomiej Dach	a188d6662f	Use beatmap card in solo spectator screen	2021-11-25 22:31:02 +01:00
Dan Balasescu	1f5d95666e	Add owner avatar to multiplayer items	2021-11-25 23:15:29 +09:00
Dean Herbert	7a3c69544b	Merge pull request #15799 from smoogipoo/fix-songselect-test-failures-2 ... Fix SongSelect-related test failures	2021-11-25 23:01:06 +09:00
Dan Balasescu	09dd054283	Fix SongSelect-related test failures	2021-11-25 21:11:13 +09:00
Dan Balasescu	f712aeee01	Merge pull request #15795 from peppy/realm-integration/separate-download-flow ... Split out download logic from main manager classes	2021-11-25 20:59:23 +09:00
Dan Balasescu	d3a4890c31	Merge branch 'master' into realm-integration/stable-export-flow	2021-11-25 19:06:18 +09:00
Dean Herbert	e2ebcf7a26	Remove unnecessary manager parameter ... Confused why I added this in the first place..	2021-11-25 18:36:03 +09:00
Dean Herbert	a2ab9f457d	Move score download logic out of ScoreManager	2021-11-25 17:33:04 +09:00
Dean Herbert	716543b5b3	Move beatmap download logic out of BeatmapManager	2021-11-25 17:29:41 +09:00
Dean Herbert	79459c1aeb	Fix typo in class and variable names	2021-11-25 17:12:15 +09:00
Dean Herbert	cc1b91e4bd	Split out legacy model export logic into LegacyModelExporter classes	2021-11-25 16:41:12 +09:00
Dean Herbert	9dcb20a821	Rename Stable to Legacy and add xmldoc	2021-11-25 15:39:05 +09:00
Dan Balasescu	132bb59203	Update working beatmap when returning to match	2021-11-24 19:56:02 +09:00
Dean Herbert	183b95cbc2	Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus ... This variable is used at more than just a set level.	2021-11-24 18:42:49 +09:00
Dean Herbert	bbd3ea5b77	Update all actual usages of RulesetInfo.ID to use OnlineID instead	2021-11-24 15:50:26 +09:00
Dan Balasescu	6183d1cd46	Merge pull request #15769 from peppy/model-equality-consistency ... Update cases where equality can be used instead of primary key equality	2021-11-24 13:45:57 +09:00
Dan Balasescu	6ffba8a546	Merge pull request #15768 from peppy/standardise-ruleset-create-instance ... Remove nullability of `Ruleset.CreateInstance`	2021-11-24 13:43:23 +09:00
Dean Herbert	729f681938	Update cases where equality can be used instead of primary key equality	2021-11-24 12:49:57 +09:00
Dean Herbert	0eea026afb	Remove null checks on CreateInstance() calls	2021-11-24 12:23:09 +09:00
Dan Balasescu	6363833fb3	Revert unnecessary changes	2021-11-23 16:17:09 +09:00
Dan Balasescu	1f13669636	Don't poll while in room ... Fixes timeout in `TestJoinRoomWithoutPassword`, because the 'server' returns out-of-date data while the `MatchSubScreen` has possible not been entered yet (and thus hasn't disabled polling itself yet). Can be tested by adding a `Task.Delay(3000);` at the end of the `MultiplayerClient.JoinRoom()` task.	2021-11-23 16:14:01 +09:00
Dan Balasescu	69a9fc9732	Fix a few more multiplayer test timeouts ... These can be tested by adding a `Task.Delay(3000);` at the end of the `MultiplayerClient.JoinRoom` task. The reason is typically that `Client.Room` becomes not-null but the join task still hasn't completed yet, so e.g. the ready button is still disabled.	2021-11-23 16:07:03 +09:00
Dan Balasescu	4b498c7bd6	Merge branch 'master' into multi-queueing-modes	2021-11-22 07:46:45 +09:00
Bartłomiej Dach	6100bf66a6	Clean up cancellation handling in WorkingBeatmap ... After the recent changes introducing cancellation support to `WorkingBeatmap`, it turned out that if the cancellation support was used, `GetPlayableBeatmap()` would raise timeout exceptions rather than the expected `OperationCanceledException`. To that end, split off a separate overload for the typical usage, that catches `OperationCanceledException` and converts them to beatmap load timeout exceptions, and use normal `OperationCanceledException`s in the overload that requires a cancellation token to work.	2021-11-20 17:23:55 +01:00
Bartłomiej Dach	15feb17da8	Change difficulty cache storage type to nullable ... The recent changes related to adding support for working beatmap load cancellation exposed a flaw in the beatmap difficulty cache. With the way the difficulty computation logic was written, any error in the calculation process (including beatmap load timeout, or cancellation) would result in a 0.00 star rating being permanently cached in memory for the given beatmap. To resolve, change the difficulty cache's return type to nullable. In failure scenarios, `null` is returned, rather than `default(StarDifficulty)` as done previously.	2021-11-20 17:00:50 +01:00
Dean Herbert	83b4625bd5	Replace existing cases with new helper method	2021-11-19 22:15:41 +09:00
Dan Balasescu	d397524878	Merge pull request #15676 from peppy/multiplayer-incorrect-beatmap-error ... Show better error message when selecting an unavailable beatmap during multiplayer room creation	2021-11-19 18:59:46 +09:00
Dan Balasescu	de0e8ad822	Merge branch 'master' into multi-queueing-modes	2021-11-19 18:58:15 +09:00
Dan Balasescu	4c8c34b43f	Use full name for round robin	2021-11-19 18:42:34 +09:00
Dan Balasescu	4e625b78e2	Update queue mode names	2021-11-19 18:28:43 +09:00
Dan Balasescu	12e1142b07	Rename settings section	2021-11-19 15:47:40 +09:00
Dan Balasescu	a922ce2fd9	Remove unnecessary nameofs	2021-11-19 15:45:45 +09:00
Dean Herbert	0c289bf8e5	Remove pointless namespace	2021-11-19 14:46:53 +09:00
Dean Herbert	284e554cbf	Only show user displayable portion of server errors when seleting a song in multiplayer	2021-11-19 13:58:03 +09:00
Dean Herbert	c901a4fd7e	Show better error message when selecting an unavailable beatmap during multiplayer room creation	2021-11-19 13:28:42 +09:00
Dean Herbert	cb2547a6be	Merge branch 'master' into multi-queueing-modes	2021-11-19 13:20:57 +09:00
Dan Balasescu	6ebe54b183	Merge pull request #15494 from Tollii/beatmap-cancellation-token ... Add support for cancellation tokens for beatmap difficulty calculation	2021-11-19 10:54:32 +09:00
Joseph Madamba	a09589f833	Fix score panels sometimes jumping when toggling statistics fast	2021-11-17 23:15:51 -08:00
Dan Balasescu	1dacc50ecb	Merge branch 'master' into multi-queueing-modes	2021-11-18 15:16:27 +09:00
Dean Herbert	66c307e0ee	Remove usage of key repeat helper method	2021-11-18 13:13:36 +09:00
Dean Herbert	7599efac30	Update editor cases where repeat should not be handled	2021-11-18 13:13:36 +09:00
Dean Herbert	3de8125eac	Update UI cases where repeat should not be handled	2021-11-18 13:13:36 +09:00
Bartłomiej Dach	8b134914cf	Merge branch 'master' into beatmap-cancellation-token	2021-11-17 21:52:30 +01:00
Dan Balasescu	e4aec3f519	Merge pull request #15648 from peppy/playlist-show-invalid-beatmaps ... Highlight invalid playlist items during room creation	2021-11-17 22:24:22 +09:00
Dean Herbert	214705f1e5	Adjust error message, take 2	2021-11-17 21:11:37 +09:00
Dan Balasescu	5fb5baa4c9	Adjust error message	2021-11-17 21:06:33 +09:00
Dean Herbert	7c2e79f911	Update all simple cases of switching to IWorkingBeatmap	2021-11-17 20:56:57 +09:00
Dean Herbert	96e983bbad	Disallow playlist item selection at playlist room creation screen ... Wasn't being used for anything, confusing that it's even possible.	2021-11-17 14:40:07 +09:00
Dean Herbert	8e9b55ef6d	Disallow selection of invalid items	2021-11-17 11:28:43 +09:00
Dean Herbert	0715d40ea0	Merge branch 'master' into beatmap-cancellation-token	2021-11-17 11:16:10 +09:00
Dean Herbert	13f3e2eea9	Add back default timeout to GetPlayableBeatmap	2021-11-17 11:06:31 +09:00
Dan Balasescu	843b0f9641	Merge pull request #15649 from peppy/fix-leaderboard-cancellation-failure ... Fix song select leaderboard potentially displaying outdated or incorrect content	2021-11-16 19:10:48 +09:00
Dan Balasescu	f9e3d9bb92	Merge branch 'master' into i-working-beatmap/difficulty-calculator	2021-11-16 17:46:38 +09:00
Dean Herbert	2dd721f760	Fix incorrect CancellationToken being used for inner check during leaderboard updates	2021-11-16 17:41:16 +09:00
Dean Herbert	6dd684588a	Merge branch 'master' into playlist-show-invalid-beatmaps	2021-11-16 17:25:33 +09:00
Dean Herbert	2d125893fc	Add tests and disable selection on invalid items	2021-11-16 17:23:52 +09:00
Dean Herbert	6f82e6351f	Parse osu-web error text to present invalid items to the user in a more approachable format	2021-11-16 17:14:15 +09:00
Dean Herbert	e78c5d0858	Show loadingLayer before calling CreateRoom ... This fixes `TestScenePlaylistsMatchSettingsOverlay` incorrectly leaving the loading layer visible.	2021-11-16 17:14:15 +09:00
Dean Herbert	aa188d5a52	Add ability for playlist items to be marked as invalid	2021-11-16 17:01:24 +09:00
Dean Herbert	49cdcffa30	Simplify schedule logic in DrawableRoomPlaylistItem	2021-11-16 16:58:44 +09:00
Dan Balasescu	ddf2fade1a	Merge branch 'master' into playlist-item-iruleset	2021-11-16 16:19:10 +09:00
Dean Herbert	726a0cc091	Merge branch 'master' into beatmap-collection-inteface-types	2021-11-16 15:31:10 +09:00
Dan Balasescu	29d0d5badf	Rename QueueModes -> QueueMode	2021-11-16 14:53:10 +09:00
Dan Balasescu	5c3141d16a	Fix ready button tooltip showing when locally available	2021-11-16 14:48:52 +09:00
Dean Herbert	6cca657a2d	Standardise naming of CancellationToken parameters	2021-11-16 14:45:51 +09:00
Dean Herbert	53c0682a08	Merge branch 'master' into beatmap-cancellation-token	2021-11-16 14:43:13 +09:00
Dan Balasescu	459e819a5d	Update todo	2021-11-16 00:50:23 +09:00
Dan Balasescu	d27edb3a25	Fix another potential crash from async load	2021-11-16 00:31:46 +09:00
Dan Balasescu	b9e38269e3	Prevent playlist mangling selection if not allowed	2021-11-16 00:31:46 +09:00
Dan Balasescu	8e014ca17a	Reverse in-match playlist	2021-11-16 00:31:46 +09:00
Dan Balasescu	eb983ed548	Fix potential crash from playlist updating during async load	2021-11-16 00:02:38 +09:00
Dan Balasescu	f743a3647f	Rename APIPlaylistItem -> MultiplayerPlaylistItem	2021-11-15 23:14:27 +09:00
Dean Herbert	369b4ba789	Update DifficultyCalculator to take an IRulesetInfo	2021-11-15 19:16:48 +09:00
Dean Herbert	960cecf3db	Merge branch 'beatmap-collection-inteface-types' into i-working-beatmap/difficulty-calculator	2021-11-15 19:16:47 +09:00
Dean Herbert	5489b19c57	Update PlaylistItem to use IRulesetInfo	2021-11-15 16:13:03 +09:00
Dean Herbert	1988b263c6	One more missed usage..	2021-11-15 16:02:08 +09:00
Dean Herbert	73cb80d8a4	Update one more missed usage	2021-11-15 16:00:45 +09:00
Dan Balasescu	5e2ccd5c85	Merge branch 'master' into multi-queueing-modes	2021-11-15 15:26:34 +09:00
Dean Herbert	285b161da7	Update other usages of online ID comparisons to use new extension method	2021-11-15 14:44:08 +09:00
Dean Herbert	5471994450	Merge branch 'master' into sample-point-multiple	2021-11-15 14:13:58 +09:00
Dean Herbert	fdbb59fd1d	Merge branch 'master' into gameplay-test/share-clock-state	2021-11-15 13:49:17 +09:00
Dean Herbert	a4aa008793	Fix frequency ramping a second time incorrectly after fail	2021-11-14 14:41:17 +09:00
Bartłomiej Dach	6b4b6de554	Fix test gameplay starting in a hidden state	2021-11-13 22:11:00 +01:00
Bartłomiej Dach	2562412125	Propagate clock state from gameplay test back to editor	2021-11-13 22:11:00 +01:00
Bartłomiej Dach	d2ddc25ab3	Propagate clock state from editor to gameplay test	2021-11-13 22:10:59 +01:00
Bartłomiej Dach	9a19a516f9	Adjust spacings on sample point piece popover	2021-11-13 21:59:45 +01:00
Bartłomiej Dach	73ca1d39a2	Improve sample bank text box UX in case of multiple selection	2021-11-13 21:59:44 +01:00
Bartłomiej Dach	3fee6b0938	Add support for setting sample bank & volume for multiple objects at once	2021-11-13 21:24:59 +01:00
Bartłomiej Dach	9800cd4903	Add test coverage for sample control point piece operation	2021-11-13 18:14:50 +01:00
Dean Herbert	983d5a6cb8	Merge branch 'master' into difficulty-point-multiple	2021-11-13 23:47:12 +09:00
Bartłomiej Dach	5f2a789a6d	Ensure editor clock is stopped before testing gameplay	2021-11-13 14:01:00 +01:00
Bartłomiej Dach	eb8c5292d5	Ensure editor background is dimmed after return from gameplay test	2021-11-13 13:50:57 +01:00
Bartłomiej Dach	b47c0b63f4	Tweak loader transition when testing gameplay in editor	2021-11-13 13:39:18 +01:00
Bartłomiej Dach	a5ba3bd012	Move gameplay test pieces to own namespace	2021-11-13 13:39:17 +01:00
Bartłomiej Dach	e1c28ddd76	Adjust difficulty point popover content spacing	2021-11-12 23:32:12 +01:00
Bartłomiej Dach	d567d2be97	Fix multiple issues with textbox content display ... - Sometimes would display too many decimal digits due to floating point representation errors. - Placeholder would also look wrong if text was removed during a multiple (but determinate) selection.	2021-11-12 23:32:12 +01:00
Bartłomiej Dach	e55e2a1697	Allow to adjust slider velocity on multiple objects simultaneously	2021-11-12 23:32:11 +01:00
Bartłomiej Dach	7ba93aac27	Add test coverage for difficulty point piece operation	2021-11-12 22:16:09 +01:00
Dan Balasescu	3b24ec3643	Merge branch 'master' into multi-queueing-modes	2021-11-12 22:16:04 +09:00
Dean Herbert	d2d66766d4	Merge branch 'master' into songselect-audio-improvements	2021-11-12 19:40:04 +09:00
Dean Herbert	338e5a78b8	Adjust easing of logo to better match the sound ... I'm sure we can come up with something better, but giving it a bit more speed definitely feels closer to what the sound is portraying.	2021-11-12 19:30:35 +09:00
Dean Herbert	692e846acd	Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface	2021-11-12 17:52:44 +09:00
Dean Herbert	6a098a8634	Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface	2021-11-12 17:46:24 +09:00
Bartłomiej Dach	759450502f	Merge branch 'master' into pp-counter-fixed-width	2021-11-12 08:05:56 +01:00
Dean Herbert	54ae307a3d	Trigger test via button click when using keyboard shortcut	2021-11-12 14:42:33 +09:00
Jamie Taylor	113c95f3f5	Only apply high-pass temporarily	2021-11-12 14:22:43 +09:00
Dean Herbert	62600f1390	Merge branch 'master' into editor-gameplay-test	2021-11-12 14:14:06 +09:00
Dean Herbert	e891c0ce53	Add keyboard shortcut to start test mode in editor	2021-11-12 14:13:11 +09:00
Dean Herbert	321aa456a7	Adjust button size slightly	2021-11-12 14:04:34 +09:00
Dean Herbert	b9f9c27770	Standardise spacing and padding between UR and PP counters	2021-11-12 13:59:22 +09:00
Dean Herbert	e31ea49dd4	Use fixed width font for performance points counter ... Matches all other display counters for in-game metrics. As mentioned in https://github.com/ppy/osu/discussions/15584.	2021-11-12 13:18:47 +09:00
Bartłomiej Dach	c465bcb821	Ensure track is stopped on player completion	2021-11-11 20:54:36 +01:00
Bartłomiej Dach	385df51b06	Ensure editor test player is exited on completion	2021-11-11 20:54:36 +01:00
Bartłomiej Dach	59727ce836	Add minimal implementation of gameplay testing from editor	2021-11-11 20:54:35 +01:00
Bartłomiej Dach	b66758dac7	Fix missing unsubscribe from JudgementReverted	2021-11-11 18:11:18 +01:00
Bartłomiej Dach	32b5a736c8	Add preview gameplay button to bottom editor bar	2021-11-11 17:12:21 +01:00
Bartłomiej Dach	2e3acffd1d	Perform initial update of PP counter value on load complete	2021-11-11 16:33:33 +01:00
Dan Balasescu	07a7b4bcdc	Merge branch 'master' into multi-queueing-modes	2021-11-11 22:19:30 +09:00
Bartłomiej Dach	576417947e	Round unstable rate in counter rather than truncating	2021-11-11 13:36:06 +01:00
Bartłomiej Dach	69809390d3	Fix HUD unstable rate counter not including judgements before load complete ... Also unifies UR calculation logic with the results screen statistic item to reduce duplication.	2021-11-11 13:36:05 +01:00
Jamie Taylor	069ee6980f	Add debounce to sample playback	2021-11-11 19:20:50 +09:00
Dan Balasescu	4db2ad1cb3	Merge branch 'master' into rename-ef-model-properties	2021-11-11 19:12:54 +09:00
Dean Herbert	51a353e12d	Rename BeatmapInfo.Version to DifficultyName to match underlying interface	2021-11-11 17:20:53 +09:00
Dean Herbert	ebe58cee11	Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface	2021-11-11 17:19:46 +09:00
Bartłomiej Dach	9664b9a97c	Fix being able to switch own team by clicking other players' team indicators	2021-11-11 09:01:50 +01:00
Jamie Taylor	e33c1f9a41	Lower filter cutoff frequency	2021-11-11 11:00:55 +09:00
Dean Herbert	8371307709	Merge branch 'master' into editor-clipboard-refactor	2021-11-11 01:09:39 +09:00
Bartłomiej Dach	30efc589d1	Fix logo sample always playing in main menu when initially logged out	2021-11-10 14:03:34 +01:00
Bartłomiej Dach	b25ad8dfcb	Copy editor timestamp to OS clipboard even when triggered via menu bar ... Would only work when triggered via Ctrl+C before, and not work at all for Ctrl+X.	2021-11-10 12:49:10 +01:00
Bartłomiej Dach	5e31e890ae	Extract class for clipboard contents for DI purposes	2021-11-10 12:36:23 +01:00
Dan Balasescu	aad4b8ff80	Fix ready button remaining enabled for expired items	2021-11-10 18:42:46 +09:00
Dan Balasescu	02efe24e39	Fix checksum not passed to AddPlaylistItem	2021-11-10 18:36:55 +09:00
Dan Balasescu	c7381b4df0	Fix host check ... Although the underlying issue is that the host user is not populated. Not sure whether this should be fixed at all.	2021-11-10 18:36:22 +09:00
Jamie Taylor	b13d020a49	Don't re-use confim-selection sample for the skip intro button	2021-11-10 17:15:08 +09:00
Jamie Taylor	5f462b6441	Move beatmap/difficulty change sample playback to outside of debounce	2021-11-10 17:15:08 +09:00
Jamie Taylor	8d0f5b0d82	Add high-pass filter when song selection is confirmed	2021-11-10 17:15:08 +09:00
Jamie Taylor	6dc13ef396	Use default hover sample instead of song-ping (they're the same sample anyway)	2021-11-10 17:14:20 +09:00
smoogipoo	35a5182ebf	Merge branch 'master' into multi-queueing-modes	2021-11-10 15:01:13 +09:00
Dean Herbert	328c72c358	Fix TeamDisplay not showing after changing to team versus	2021-11-10 13:44:31 +09:00
Dean Herbert	52c740b377	Add failing test showing team display display failure	2021-11-10 13:44:31 +09:00
Bartłomiej Dach	042b05a250	Move clipboard action availability logic down to editor screens	2021-11-09 19:54:37 +01:00
Bartłomiej Dach	286754f6f7	Move clipboard operation implementation down to current screen	2021-11-09 19:54:37 +01:00
Bartłomiej Dach	74c37e248d	Merge branch 'master' into master	2021-11-09 08:40:52 +01:00
Chinmay Patil	d5ad776c33	Remove decimal part of UR Counter and rename methods	2021-11-08 06:27:25 -07:00
smoogipoo	c716051530	Merge branch 'master' into multi-queueing-modes	2021-11-08 19:19:50 +09:00
Dean Herbert	97345ac9e6	Remove unnecessary TimeSpan timeout parameter (CancellationToken can now be used)	2021-11-08 14:33:32 +09:00
Dean Herbert	e338340c6a	Merge branch 'master' into beatmap-cancellation-token	2021-11-08 14:32:56 +09:00
Dean Herbert	78aef9ce86	Merge branch 'master' into remove-stupid-weak-reference-bindable-events	2021-11-08 13:35:49 +09:00
Dan Balasescu	da0d9726f5	Merge pull request #15466 from peppy/user-class-cleanup ... Clean up `User` class	2021-11-08 13:27:26 +09:00
Dean Herbert	8dbe69dec5	Merge pull request #15515 from Joehuu/fix-statistics-loading-spinner ... Fix loading spinner potentially showing on statistics unavailable message	2021-11-08 13:02:39 +09:00
Dean Herbert	62600b47b1	Merge branch 'master' into user-class-cleanup	2021-11-08 12:51:12 +09:00
Joseph Madamba	9e13c20bd4	Move spinner hiding before newScore null check	2021-11-07 19:35:30 -08:00
Joseph Madamba	ac5d9853d3	Fix loading spinner potentially showing on statistics unavailable message	2021-11-07 17:25:33 -08:00
Chinmay Patil	a8c9ad73c1	Make UR Counter isValid into a bindable boolean	2021-11-07 18:06:13 -07:00
Chinmay Patil	cc0bcf6b2c	Clean up judgement checks and clean up setter/getter for UR counter Text	2021-11-07 17:44:50 -07:00
Bartłomiej Dach	6d30248cef	Merge branch 'master' into use-class-rename	2021-11-07 15:41:00 +01:00
Dean Herbert	0ecf5f201c	Rename User to APIUser and move to correct namespace	2021-11-07 11:26:01 +09:00
Tollii	cf0b757b16	Fix PR comments. ... Nitpick, more cancellation token checks.	2021-11-06 16:03:53 +01:00
Tollii	f0caa10066	Add support for a provided cancellation token for GetPlayableBeatmap()	2021-11-05 23:53:48 +01:00
Chinmay Patil	77e853ce25	Optimized UR Counter and removed redundant code	2021-11-05 12:16:58 -06:00
Dean Herbert	54f72d68ca	Revert weird event flow in model manager/importers	2021-11-05 19:12:49 +09:00
smoogipoo	e6deb0c873	Merge branch 'master' into multi-queueing-modes	2021-11-05 15:57:25 +09:00
Dean Herbert	6399c695e8	Update usages of BufferedContainer in line with framework changes	2021-11-05 15:54:49 +09:00
Chinmay Patil	8bfcb89221	Fixed issue where UR counter was always invalid	2021-11-04 21:24:25 -06:00
Chinmay Patil	0ffd41bb70	Slight logical error in the setValid method	2021-11-04 14:32:28 -06:00
Chinmay Patil	8923561b05	Removed Unnessicary class in the Test file, and optimized UR counter	2021-11-04 14:27:48 -06:00
Dean Herbert	7049d0de66	Merge branch 'master' into beatmap-refactor/remove-online-info	2021-11-05 01:16:11 +09:00
Chinmay Patil	a76878e053	A bit more formatting	2021-11-04 09:52:16 -06:00
Chinmay Patil	c568888500	Edited to remove unessicary blank lines	2021-11-04 09:47:52 -06:00
Dean Herbert	ed07ee8c61	Update all existing usages of AuthorString/AuthorId ... Unfortunately the getters need to be left in place else EF breaks.	2021-11-04 18:59:37 +09:00
Dan Balasescu	45dcf187b9	Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended	2021-11-04 18:59:04 +09:00
Dean Herbert	86540d1fb6	Update existing usages of Author as string to access Username directly	2021-11-04 18:57:54 +09:00
Dean Herbert	b9983add15	Rename User to APIUser and move to correct namespace	2021-11-04 18:21:31 +09:00
Dean Herbert	df3c3a32ce	Fix unintentionally broken background update logic	2021-11-04 18:07:39 +09:00
Dean Herbert	d2831b1152	Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2	2021-11-04 17:09:50 +09:00
Dean Herbert	c820d445ad	Merge pull request #15461 from peppy/fix-more-computationally-expensive ... Fix a few more "maybe null" inspections	2021-11-04 16:49:38 +09:00
Dean Herbert	317506d4d7	Fix a few more "maybe null" inspections	2021-11-04 16:11:23 +09:00
Dean Herbert	09701d0af1	Use explicit primitive type specification	2021-11-04 16:02:37 +09:00
Dean Herbert	0f4f1349db	Merge branch 'master' into editor-context-menu-on-select	2021-11-04 15:59:06 +09:00
Dean Herbert	a5a7181915	Fix unintentionally broken background update logic	2021-11-04 15:35:32 +09:00
Dean Herbert	9c926e5514	Remove BeatmapSetInfo.OnlineInfo and all usages	2021-11-04 15:23:04 +09:00
Dean Herbert	0d0eab90bc	Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/remove-online-info	2021-11-04 15:23:02 +09:00
Dean Herbert	d1e6d1cb98	Update some other missed incorrect null/empty usages	2021-11-04 14:50:43 +09:00
Dean Herbert	a49366ff84	Remove nullability from IBeatmapInfo.Metadata	2021-11-04 14:28:39 +09:00
Dean Herbert	67d9590a79	Fix new inspections	2021-11-04 14:02:09 +09:00
Dean Herbert	0df339d0b8	Fix incorrect invocation of download method in SoloSpectator	2021-11-04 13:50:04 +09:00
Dean Herbert	9f9c960fe3	Revert PlaylistItem.APIBeatmap to be private	2021-11-04 13:36:32 +09:00
Dean Herbert	05f1fd4bc9	Remove unnecessary properties and parameters	2021-11-04 13:33:54 +09:00
Chinmay Patil	9aa3021bbc	Added Unstable Rate Counter as a skinable element	2021-11-03 22:22:44 -06:00
Dean Herbert	3453160a8b	Change PlaylistItem.Beatmap to be an IBeatmapInfo	2021-11-04 13:16:56 +09:00
Dean Herbert	6fdeb66dc1	Use APIBeatmap instead of BeatmapInfo in playlist display classes where feasible	2021-11-04 11:55:50 +09:00
Bartłomiej Dach	098fa181b4	Fix text flow wrapping incorrectly in multiplayer usages	2021-11-03 18:36:43 +01:00
Bartłomiej Dach	ed00cd9fc5	Remove simple localisable .ToString() calls	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	11de924704	Use LocalisableStrings where possible to leverage localisable text flow	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	ad98ab0a26	Fix drawable room playlist item assuming single sprite text	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	b95c95527e	Accept LocalisableStrings in LinkFlowContainer	2021-11-02 21:42:01 +01:00
Bartłomiej Dach	98367fc482	Update usages of GetLocalised{-> Bindable}String	2021-11-02 21:42:01 +01:00
Dean Herbert	6efd3d3115	Don't perform background difficulty calculation for multiplayer panels ... There are cases these are shown in a long list. They shouldn't be running calculations.	2021-11-03 03:12:52 +09:00
smoogipoo	3db199292f	Fix queue mode not passed from room to settings overlay	2021-11-01 18:52:57 +09:00
smoogipoo	65b920e4c1	Merge branch 'master' into multi-queueing-modes	2021-11-01 18:37:16 +09:00
Dean Herbert	b21e0e7efb	Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays	2021-11-01 18:07:51 +09:00
Dean Herbert	b98faf6159	Merge branch 'master' into score-refactor/isolated-serialisation	2021-11-01 15:49:25 +09:00
Dan Balasescu	9e633a1b17	Merge pull request #15321 from peppy/beatmap-refactor/download-tracker ... Replace `DownloadTrackingComposite` with instantiable `DownloadTracker` components	2021-11-01 15:48:12 +09:00
Dean Herbert	123b10f647	Fix playlist item download button being clickable when it shouldn't	2021-11-01 15:10:32 +09:00
Dean Herbert	19feae4a8e	Merge branch 'master' into beatmap-refactor/download-tracker	2021-11-01 13:15:36 +09:00
Dean Herbert	02e69626e3	Reduce fail animation tint slightly	2021-11-01 13:06:26 +09:00
Bartłomiej Dach	914e5c0f9d	Fix star rating not updating for some mods on details tab in song select ... `AdvancedStats` was locally assuming that the only changes in mods that are relevant to it are if the mods are `IApplicableToDifficulty`. This is not true, as other mods (such as `IApplicableToRate` mods, or more recently, Flashlight) can also affect star difficulty, which is shown on one of the bars in `AdvancedStats`.	2021-10-31 18:58:17 +01:00
Bartłomiej Dach	8053b2c320	Merge branch 'master' into score-refactor/isolated-serialisation	2021-10-30 15:07:34 +02:00
Dean Herbert	5311fe2d02	Merge branch 'master' into beatmap-refactor/beatmap-overlays	2021-10-29 22:37:29 +09:00
Dean Herbert	a16c8f1ebc	Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet	2021-10-29 18:50:55 +09:00
Dean Herbert	8ad33d43d0	Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays	2021-10-29 18:01:17 +09:00
smoogipoo	e667ef4eea	Add basic tests	2021-10-29 15:44:48 +09:00
Dean Herbert	3f030cebf4	Remove local score copying in GetScoresRequest to allow APIScoreInfo.Beatmap to be APIBeatmap	2021-10-29 14:14:25 +09:00
Dean Herbert	1944c255a7	Implement score interfaces	2021-10-29 13:49:30 +09:00
Bartłomiej Dach	6f863ca204	Adjust game-side text flow containers to part-based model	2021-10-29 06:34:08 +02:00
Dean Herbert	414d920ca2	Revert to previous exposure of RoomSubScreen.BeatmapAvailability	2021-10-29 12:02:10 +09:00
Dean Herbert	b252b176d4	Seal implementation and add comment about LoadComplete execution order	2021-10-29 11:59:07 +09:00
Dean Herbert	3b095e1626	Merge branch 'master' into beatmap-refactor/download-tracker	2021-10-29 11:50:54 +09:00
smoogipoo	f076b72fbe	Merge branch 'master' into multi-queueing-modes	2021-10-29 10:48:16 +09:00
Dean Herbert	6f5040722a	Merge branch 'master' into beatmap-refactor/uncontested	2021-10-28 16:37:26 +09:00
Dean Herbert	a9208838a9	Merge pull request #15307 from peppy/playlist-remaining-attempt-display ... Show remaining attempts again on playlist screen	2021-10-28 05:28:20 +09:00
Dean Herbert	746d6a4c16	Fix some oversights and test failures	2021-10-27 23:42:27 +09:00
Dean Herbert	f014ceaead	Update remaining usages of download tracking	2021-10-27 21:00:46 +09:00
Dean Herbert	f268363924	Update UpdateableBeatmapBackgroundSprite to accept IBeatmapInfo	2021-10-27 16:38:48 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Jason Won	c633e2e952	only propagate unmodified right click	2021-10-26 16:24:53 -04:00
Jason Won	f64fa65fd5	right click on unselected object shows context menu	2021-10-26 14:52:15 -04:00
Dean Herbert	c15bfb2cf4	Handle bindable changes to fix new playlist creation not showing correct details	2021-10-26 18:19:05 +09:00
Dean Herbert	42d8d4fd38	Add tooltips to start button to explain why it's not clickable	2021-10-26 18:06:08 +09:00
Dean Herbert	1c578f285a	Disable playlist start button when attempts have been exhausted	2021-10-26 18:06:08 +09:00
Dean Herbert	bffd9162ba	Tint attempt count red when no attempts remain	2021-10-26 18:06:08 +09:00
Dean Herbert	708d40931b	Add back remaining attempt display on playlist room screen	2021-10-26 18:06:08 +09:00
Dean Herbert	ea55ba7ba9	Remove unused using statement	2021-10-26 16:08:21 +09:00
Dan Balasescu	7b8982c87c	Merge pull request #15302 from peppy/fix-multiplayer-chat-escape-focus ... Fix gameplay chat display not losing focus on escape key press	2021-10-26 15:34:05 +09:00
Dan Balasescu	efe6763226	Merge branch 'master' into move-online-beatmap-metrics	2021-10-26 14:24:40 +09:00
Dean Herbert	6c38028d06	Fix gameplay chat display not losing focus on escape key press ... Closes #15293.	2021-10-26 13:55:08 +09:00
Bartłomiej Dach	6802e9ec10	Remove FixedWidth and add AutoSizeAxes specs to all usages	2021-10-25 20:24:48 +02:00
Dean Herbert	2c308f3008	Rename BeatmapMetrics to APIFailTimes	2021-10-25 15:34:41 +09:00
Dean Herbert	20baae9094	Move online metrics out of BeatmapInfo model	2021-10-25 15:32:18 +09:00
Dean Herbert	045dd94a6e	Move online metrics out of BeatmapSetInfo model	2021-10-25 15:12:39 +09:00
Dan Balasescu	c6ca0e5895	Merge branch 'master' into fix-password-popover-focus	2021-10-22 22:52:46 +09:00
smoogipoo	04b0529a7f	Fix list overflowing subscreen background	2021-10-22 22:17:26 +09:00
smoogipoo	d7a98097a1	Make DrawableRoomPlaylist handle expired items	2021-10-22 21:04:52 +09:00
smoogipoo	95ab82fb58	Remove BeatmapSelectionControl and inline at usage sites	2021-10-22 19:41:36 +09:00
Dean Herbert	90477e3788	Remove unused BeatmapTypeInfo class ... Helps reduce the scope of upcoming changes.	2021-10-22 19:13:50 +09:00
Dean Herbert	91cc77407d	Fix low-pass filter continuing to take effect after fail animation has already ended	2021-10-22 17:02:02 +09:00
smoogipoo	db87e42d47	Remove beatmap/ruleset/etc from MultiplayerRoomSettings	2021-10-22 16:48:28 +09:00
Dean Herbert	c580ec865f	APIBeatmapSet.Covers is never null	2021-10-21 19:34:01 +09:00
Dean Herbert	69e7810dad	Enable nullable and switch classes to structs	2021-10-21 18:54:36 +09:00
smoogipoo	f41cf822b0	Rename request	2021-10-21 17:02:11 +09:00
Dean Herbert	0706ad70fb	Move BeatmapSetOnlineInfo to an interface type	2021-10-21 16:58:42 +09:00
Bartłomiej Dach	9ad9465020	Remove online-screen-local textbox recolours	2021-10-20 22:49:25 +02:00
smoogipoo	691e414acb	Add request to add a new playlist item	2021-10-20 21:08:58 +09:00
smoogipoo	67090fc598	Re-namespace enum	2021-10-20 20:52:16 +09:00
smoogipoo	599867a3b1	Add implementation to settings overlay	2021-10-20 20:29:06 +09:00
smoogipoo	0e446105fb	Rename to "picking mode" as simpler english	2021-10-20 17:52:51 +09:00
smoogipoo	bc57190fb4	Make dropdown not move the selection control	2021-10-20 17:52:05 +09:00
smoogipoo	116ce09e49	Merge branch 'master' into multi-queueing-modes	2021-10-20 17:27:25 +09:00
smoogipoo	ea9c070e59	Add setting for queue mode	2021-10-20 14:51:59 +09:00
Dean Herbert	7cf4395875	Merge branch 'master' into default-value-indicator	2021-10-19 16:23:02 +09:00
Dean Herbert	480dc57102	Schedule joinFailed callback for added safety	2021-10-19 15:54:12 +09:00
Dean Herbert	da524261c0	Fix focus potentially being transferred too far up when password is being verified	2021-10-19 15:53:29 +09:00
Dean Herbert	a589964dc7	Centralise join logic	2021-10-19 15:53:29 +09:00
Dean Herbert	8944b1dd78	Add basic test coverage of DrawableLoungeRoom	2021-10-19 15:36:27 +09:00
Dean Herbert	473459d191	Add layout duration to PasswordEntryPopover to make error text look a bit smoother	2021-10-19 15:36:27 +09:00
Dean Herbert	d35fe5493a	Change default value of DrawableLoungeRoom.matchingFilter so they display by default	2021-10-19 15:36:27 +09:00
sh0ckR6	e7b280fc81	Comment out RankDisplay ... Commented out as it may be revisited at a later time. Also currently unused.	2021-10-18 23:12:33 -04:00
Bartłomiej Dach	8db2fc439d	Change ruleset ID assert in player to null-check	2021-10-18 23:45:06 +02:00
Bartłomiej Dach	6d9d85685f	Fix settings item having zero height	2021-10-18 23:30:38 +02:00
Dan Balasescu	8643c725cc	Merge pull request #15175 from peppy/fail-animation-flash-controlled-by-setting ... Don't flash screen red on fail if the user has disabled red tinting	2021-10-18 15:27:10 +09:00
Dean Herbert	762949f49f	Don't flash screen red on fail if the user has disabled red tinting	2021-10-18 14:20:38 +09:00
Dean Herbert	59dc04017e	Fix epilepsy warning not being faded out on an early exit from PlayerLoader	2021-10-18 13:30:37 +09:00
5ln	3529f34c98	Multi: Hide mods when spectating or Beatmap isn't Locally Available. ... Signed-off-by: 5ln <xnafumie@gmail.com>	2021-10-18 02:01:50 +08:00
Bartłomiej Dach	874decb3cd	Replace spectator-local fix for wrong ruleset ID with player-global consistency check	2021-10-16 16:10:42 +02:00
Dean Herbert	7a5a612896	Move retry and exit hotkey overlays to same depth / container	2021-10-16 02:29:45 +09:00
Dean Herbert	e9f50179ab	Merge branch 'master' into fail-animation-update	2021-10-15 23:32:10 +09:00
Dean Herbert	91754450b2	Remove dispose method completely	2021-10-15 21:27:44 +09:00
Dean Herbert	6f947cacbd	Fix test failures	2021-10-15 21:22:38 +09:00
smoogipoo	2fd101ad50	Reorder elements to follow designs	2021-10-15 20:25:32 +09:00
smoogipoo	a70d7e4feb	Remove unnecessary extra GridContainer	2021-10-15 20:18:25 +09:00
Dean Herbert	c47497923a	Schedule drag events for now	2021-10-15 19:52:44 +09:00
Dean Herbert	30c3fcb4ea	Merge branch 'master' into slider-timeline-velcotiy-adjust-v2	2021-10-15 19:45:04 +09:00
Dean Herbert	3909fd8caa	Fix wonkiness when dragging slider end at high input refresh rates	2021-10-15 19:43:57 +09:00
Dean Herbert	b9fd1f52df	Tweak animation slightly	2021-10-15 19:37:22 +09:00
Dean Herbert	b08743342b	Fix incorrect nesting	2021-10-15 19:35:08 +09:00
Dean Herbert	66f3370a19	Add new fail animation to better match new sound effects	2021-10-15 19:14:59 +09:00
Dean Herbert	a59ee9ec1f	Merge pull request #15121 from nekodex/fail-highpass ... Add high-pass filter to gameplay fail sequence	2021-10-15 19:14:44 +09:00
Jamie Taylor	8d6d7fcdbe	Add high-pass filter to gameplay fail sequence	2021-10-15 17:03:37 +09:00
Dan Balasescu	3604a762d0	Merge branch 'master' into fix-editor-difficulty-name-update	2021-10-15 16:58:01 +09:00
Dean Herbert	f73e505ee6	Further adjustments to glow to be less bright on settings overlay	2021-10-15 12:35:19 +09:00
Dean Herbert	3a25bdaf3d	Merge branch 'master' into slider-timeline-velcotiy-adjust-v2	2021-10-15 11:18:37 +09:00
Dean Herbert	874d722820	Merge branch 'master' into fix-editor-difficulty-name-update	2021-10-15 11:14:45 +09:00
Dean Herbert	ad0732484f	Just wait for metadata section to be loaded	2021-10-14 22:12:38 +09:00
Dean Herbert	9d54285b2e	Merge branch 'master' into fix-multiplayer-sounds-during-gameplay	2021-10-14 21:34:04 +09:00
Dean Herbert	06249c4ab2	Fix incorrect usages of Scheduler.AddOnce	2021-10-14 17:52:19 +09:00
Dean Herbert	0d86dab80a	Fix multiplayer components updating when not alive ... Should close https://github.com/ppy/osu/issues/15092. - [ ] Depends on https://github.com/ppy/osu-framework/pull/4826.	2021-10-14 17:37:10 +09:00
smoogipoo	901f107b2e	Merge branch 'master' into slider-timeline-velcotiy-adjust-v2	2021-10-14 17:25:51 +09:00
Dan Balasescu	fb9c3fe72e	Merge pull request #14619 from peppy/no-more-difficulty-control-points-info ... Move `DifficultyControlPoint`s to be specified at a per-`HitObject` level	2021-10-14 17:24:32 +09:00
Dean Herbert	1212b08672	Fix gameplay audio ramping down in frequency a second time at the end of the fail sequence	2021-10-14 16:45:34 +09:00
Dean Herbert	e0babe4b79	Add global logging of WorkingBeatmap changes	2021-10-14 14:07:43 +09:00
Dean Herbert	09536cd733	Add logging of WorkingBeatmapCache.Invalidate calls	2021-10-14 14:05:33 +09:00
smoogipoo	aa380a11c1	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-14 12:02:10 +09:00
Dean Herbert	8d479bbe56	Merge branch 'master' into fix-editor-difficulty-name-update	2021-10-14 10:17:01 +09:00
Bartłomiej Dach	d2115824fa	Merge branch 'master' into dropdown-refresh	2021-10-13 23:53:14 +02:00
Bartłomiej Dach	f3647eb94e	Recolour room settings screens to match dropdown theming	2021-10-13 22:50:19 +02:00
Bartłomiej Dach	d067159435	Recolour elements of editor setup screen to match dropdown theming	2021-10-13 22:32:54 +02:00
smoogipoo	fdf7142711	Remove Room.Position	2021-10-13 21:24:54 +09:00
Dan Balasescu	e49f1f6e6b	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-13 20:17:57 +09:00
Dan Balasescu	d88daf0cc2	Merge pull request #15073 from peppy/fix-player-loader-low-pass ... Improve `PlayerLoader` audio and visual transitions	2021-10-13 17:01:49 +09:00
Dean Herbert	02689a1b60	Use actual BeatmapInfo rather than PlayableBeatmap.BeatmapInfo for editor writes	2021-10-13 14:50:12 +09:00
Dean Herbert	26a1e40d24	Fix storyboard outro during fail test not being lenient enough	2021-10-13 13:48:57 +09:00
Dean Herbert	ae4dcbd829	Improve PlayerLoader audio and visual transitions	2021-10-13 13:26:20 +09:00
Dean Herbert	3d6602b8df	Ensure FailAnimation is disposed synchronously to avoid test failures	2021-10-11 14:05:31 +09:00
Dean Herbert	794b4c46cf	Split score counter class into two distinct classes to simplify usages	2021-10-10 17:56:32 +09:00
Dean Herbert	06cce0119c	Use localisable format string for comma separator mode	2021-10-10 17:41:16 +09:00
Dean Herbert	446f091d32	Use comma separator for tournament score displays	2021-10-10 16:06:12 +09:00
smoogipoo	bc37cb6f43	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-08 18:41:17 +09:00
Dean Herbert	436ead421a	Move low pass fail effect to FailAnimation	2021-10-08 12:27:04 +09:00
Dean Herbert	da96cc73d8	Fix dual specification of SuspensionHandler and move fields around slightly	2021-10-07 23:40:47 +09:00
Dean Herbert	310d7965b6	Merge branch 'master' into more-filter-effects	2021-10-07 20:52:38 +09:00
Dan Balasescu	f8e50731b7	Merge pull request #14991 from peppy/intro-tests-no-menu-load ... Allow intro screens to be created without loading a `MainMenu`	2021-10-07 20:48:54 +09:00
Dean Herbert	ef64c64f0b	Merge branch 'master' into popup-filter-effect	2021-10-07 18:56:07 +09:00
Dan Balasescu	bece807857	Merge pull request #14980 from peppy/difficulty-move-to-beatmap ... Copy `BaseDifficulty` to `Beatmap<T>` and move the majority of write operations across	2021-10-07 18:43:44 +09:00
Dean Herbert	f98dd1b811	Merge branch 'master' into popup-filter-effect	2021-10-07 18:40:21 +09:00
Jamie Taylor	cc209f0f2d	Add filter effect to fail sequence	2021-10-07 17:55:30 +09:00
Jamie Taylor	5c48340520	Add filter effect to beatmap loading	2021-10-07 17:55:21 +09:00
Dean Herbert	0df409c050	Move difficulty copy to BeatmapModelManager.Save	2021-10-07 17:16:45 +09:00
Dan Balasescu	d50443fdf2	Merge branch 'master' into difficulty-move-to-beatmap	2021-10-07 16:50:10 +09:00
Dean Herbert	f88d898960	Allow intro screens to be created without loading a MainMenu	2021-10-07 16:38:22 +09:00
Dean Herbert	5f129ae33c	Remove local overridden storage of Mods in Player ... Not required and only causing headaches. Accessing mods should now be done via `GameplayState`. Closes #14912.	2021-10-07 14:53:39 +09:00
Dean Herbert	9705c7b546	Use cloned mods in one more place	2021-10-06 21:30:30 +09:00
Dean Herbert	433e7cd403	Fix rate mods not working if pp counter is displayed	2021-10-06 21:26:30 +09:00
Dean Herbert	4ca97bc60a	Merge branch 'master' into difficulty-move-to-beatmap	2021-10-06 16:14:21 +09:00
Dean Herbert	222997f2b9	Copy difficulty settings back out to BeatmapInfo on editor changes	2021-10-06 15:19:26 +09:00
Dean Herbert	b339c149d8	Copy BaseDifficulty to Beatmap<T> and move all write operations across	2021-10-06 15:10:45 +09:00
Dan Balasescu	e6aa05a4a4	Merge pull request #14978 from peppy/fix-editor-file-selector-textbox-drags ... Fix dragging on an editor file selection text box causing repeated popover display	2021-10-06 13:52:08 +09:00
Dean Herbert	d9849bcf49	Fix dragging on an editor file selection text box causing repeated popover display ... Local fix and no tests as this is a pretty weird usage of `TextBox`. We'll probably want to change it to not use a textbox eventually. Closes #14969.	2021-10-06 13:15:05 +09:00
Dan Balasescu	e837a3511d	Merge branch 'master' into beatmap-difficulty-more-interface-usage	2021-10-06 12:18:51 +09:00
Dan Balasescu	4bbff2ebf7	Merge branch 'master' into new-interfaces	2021-10-06 11:38:17 +09:00
Dan Balasescu	9491e5a547	Merge pull request #14954 from peppy/rename-result-response ... Rename `APIRequest.Result` to `Response`	2021-10-06 10:52:33 +09:00
Dean Herbert	5a4474e1b2	Fix incorrect DI retrieval in ReplayDownloadButton	2021-10-06 05:29:00 +09:00
Dean Herbert	98fef6ece2	Handle judgement reverts with actual display updates	2021-10-05 19:08:30 +09:00
Dean Herbert	bd84a8b749	Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage	2021-10-05 18:21:21 +09:00
Dean Herbert	0859c336de	Also dim counter during initial calculation phase	2021-10-05 17:24:36 +09:00
Dean Herbert	f64226ded6	Fix display not displaying correctly after initial load	2021-10-05 17:10:32 +09:00
Dean Herbert	599d82e383	Avoid returning a live IEnumerable	2021-10-05 17:01:07 +09:00
Dean Herbert	fa7f11d906	Add easing to rolling counter value	2021-10-05 16:51:49 +09:00
Dean Herbert	565e888f58	Tidy up attribute retrieval code	2021-10-05 16:40:07 +09:00
smoogipoo	45b63cbad9	Remove unnecessary dependency	2021-10-05 16:03:25 +09:00
Dean Herbert	676df55a0e	Fade display out during rewind (as the value displayed is no longer valid)	2021-10-05 15:39:29 +09:00
Dean Herbert	81a13566bc	Adjust default location slightly, fix alignment of "pp" subtext	2021-10-05 15:28:03 +09:00
Dean Herbert	b6af93d434	Apply some code quality refactoring	2021-10-05 15:14:49 +09:00
Dean Herbert	7176dc95e5	Revert Player.Score to protected	2021-10-05 14:55:40 +09:00
Dean Herbert	e19be8ebe4	Make GameplayState.Score immutable	2021-10-05 14:55:40 +09:00
Dean Herbert	d3b9660148	Move common interface implementations to extension methods	2021-10-05 14:41:14 +09:00
Dean Herbert	b41fa41c85	Rename APIRequest.Result to Response	2021-10-05 14:28:56 +09:00
smoogipoo	5624dd9af6	Fix incorrect CancellationToken usage ... Apparently I wrote the BDL system and don't know how this works. I believe you need `CancellationToken?` or CanBeNull=true, however that doesn't actually play well when actually using the token in code...	2021-10-05 12:07:41 +09:00
smoogipoo	593da79bbc	Further asyncify load process	2021-10-05 11:26:13 +09:00
smoogipoo	d120678e30	Fix redundant default value	2021-10-04 21:13:14 +09:00
smoogipoo	d1e7191f94	Pass score into GameplayState	2021-10-04 20:59:51 +09:00
smoogipoo	0b0316e27e	Fix missing CanBeNull	2021-10-04 20:59:31 +09:00
smoogipoo	1837e1bf3c	Share rounding with PerformanceStatistic	2021-10-04 20:35:53 +09:00
smoogipoo	fb63e5ed87	Add todo	2021-10-04 20:35:26 +09:00
smoogipoo	221cc1747c	Drop "default" prefix	2021-10-04 20:34:28 +09:00
smoogipoo	5aae673240	Use GameplayState	2021-10-04 20:33:54 +09:00
smoogipoo	2e3450b3f5	Make Mods readonly	2021-10-04 20:20:24 +09:00
smoogipoo	031c5a441e	Merge branch 'master' into realtime-pp-display	2021-10-04 20:19:37 +09:00
Dan Balasescu	4bd1083388	Merge pull request #14903 from peppy/importer-returns-live ... Add `ILive<T>` and use as return type of `Import` methods	2021-10-04 20:16:32 +09:00
smoogipoo	4871db2f86	Merge branch 'master' into importer-returns-live	2021-10-04 19:42:36 +09:00
Dean Herbert	853cf6feaa	Rename last remaining BeatmapInfo Beatmap usage	2021-10-04 17:35:53 +09:00
Dean Herbert	916342c837	Merge branch 'master' into importer-returns-live	2021-10-04 16:24:26 +09:00
smoogipoo	69c2b7dc59	Merge branch 'master' into rename-beatmap-info-beatmap-fields	2021-10-04 16:03:22 +09:00
Dan Balasescu	aa1bfc16d2	Merge pull request #14929 from peppy/gameplay-state ... Replace `GameplayBeatmap` with `GameplayState`	2021-10-04 15:56:44 +09:00
Bartłomiej Dach	017756cbca	Use Torus alternates on online play screens as per design	2021-10-04 00:26:41 +02:00
Dean Herbert	ec61c3c5ee	Rename all remaining cases	2021-10-03 00:55:29 +09:00
Dean Herbert	973c31132b	Rename BeatmapInfo variables which were named beatmap for clarity	2021-10-02 12:45:34 +09:00
Dean Herbert	7e009f6168	Add full xmldoc	2021-10-02 02:31:41 +09:00
Dean Herbert	32afd3f426	Replace all basic usages	2021-10-02 02:22:23 +09:00
Dean Herbert	05ca3aec4f	Rename GameplayState to SpectatorGameplayState	2021-10-02 02:10:11 +09:00
smoogipoo	0ee148b53f	Extra guard against no attributes	2021-10-01 21:31:26 +09:00
smoogipoo	a1f880a36a	Split classes	2021-10-01 21:00:39 +09:00
smoogipoo	d0081908c5	Make Score internal	2021-10-01 20:52:48 +09:00
smoogipoo	5820a71652	Fix mania difficulty calculator crashing	2021-10-01 19:57:45 +09:00