1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 06:57:39 +08:00
osu-lazer/osu.Game/Screens
Bartłomiej Dach 15feb17da8
Change difficulty cache storage type to nullable
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
2021-11-20 17:00:50 +01:00
..
Backgrounds Rename User to APIUser and move to correct namespace 2021-11-07 11:26:01 +09:00
Edit Update editor cases where repeat should not be handled 2021-11-18 13:13:36 +09:00
Import Remove unnecessary AllowTrackAdjustments overrides, add true to SongSelect 2021-09-15 13:12:57 +03:00
Menu Update UI cases where repeat should not be handled 2021-11-18 13:13:36 +09:00
OnlinePlay Merge pull request #15676 from peppy/multiplayer-incorrect-beatmap-error 2021-11-19 18:59:46 +09:00
Play Merge pull request #15494 from Tollii/beatmap-cancellation-token 2021-11-19 10:54:32 +09:00
Ranking Change difficulty cache storage type to nullable 2021-11-20 17:00:50 +01:00
Select Change difficulty cache storage type to nullable 2021-11-20 17:00:50 +01:00
Spectate Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
BackgroundScreen.cs Fix background overflows 2021-08-20 17:50:49 +09:00
BackgroundScreenStack.cs Improve code around background screen handling to read better 2021-09-07 14:35:33 +09:00
IHandlePresentBeatmap.cs Remove explicit public definition 2021-03-03 19:03:45 +09:00
IHasSubScreenStack.cs Add the ability for PerformFromMenuRunner to inspect nested screen stacks 2021-02-19 17:58:04 +09:00
IOsuScreen.cs Move MusicController adjustment set to inside OsuScreen itself (and result nullable) 2021-09-16 16:08:09 +09:00
Loader.cs Allow intro screens to be created without loading a MainMenu 2021-10-07 16:38:22 +09:00
OsuScreen.cs Handle potential for OnResuming call without an OnSuspending first 2021-09-16 16:31:41 +09:00
OsuScreenDependencies.cs
OsuScreenStack.cs Fix the default background parallax being set incorrectly when no screen is present 2021-09-17 18:14:39 +09:00
ScorePresentType.cs Update class exclusion for dynamic compilation 2020-09-04 20:41:08 +09:00
ScreenWhiteBox.cs Remove redundant arguments 2021-07-05 23:52:39 +08:00
StartupScreen.cs Remove unnecessary AllowTrackAdjustments overrides, add true to SongSelect 2021-09-15 13:12:57 +03:00