29694 Commits

Author	SHA1	Message	Date
Dan Balasescu	e5a7589859	Merge pull request #15317 from peppy/beatmap-refactor/uncontested ... Update `UpdateableBeatmapBackgroundSprite` to accept `IBeatmapInfo`	2021-10-28 17:24:49 +09:00
Dean Herbert	b096bf6cd1	Ensure all test beatmaps have unique OnlineIDs to avoid import conflicts ... The order of operation of imports means that the already-imported instances are considered most correct (they have usually been populated using an online source, although that is skipped in tests), so on two consecutive test imports in a test scene, the second will lose its online IDs completely. This aims to ensure that all test beatmaps will have online IDs, which is the general expected behaviour.	2021-10-28 16:56:31 +09:00
smoogipoo	bacaa9d201	Fix playlists test crash	2021-10-28 16:48:17 +09:00
Dean Herbert	6f5040722a	Merge branch 'master' into beatmap-refactor/uncontested	2021-10-28 16:37:26 +09:00
Dean Herbert	1e1f8c472a	Add icons to various progress notification states	2021-10-28 16:34:12 +09:00
Dan Balasescu	44ba4419a2	Merge branch 'master' into beatmap-refactor/tournament	2021-10-28 15:25:34 +09:00
smoogipoo	0e293471c2	Clean up multiplayer-screen tests by removing intermediate screen	2021-10-28 14:29:49 +09:00
Dean Herbert	5c7623e68e	Merge pull request #15255 from goodtrailer/node-samples-ilist ... Change IHasRepeats.NodeSamples to IList from List	2021-10-28 14:24:26 +09:00
Dean Herbert	aaabaaa5dd	Merge pull request #15320 from smoogipoo/fix-online-play-request-handling ... Fix online play request handling in tests	2021-10-28 14:24:00 +09:00
Dean Herbert	3905ecd18b	Use retrieval of bindable and tidy up code slightly	2021-10-28 13:09:03 +09:00
Dean Herbert	ad1bd4e48e	Merge branch 'master' into ui-scaling-keybind	2021-10-28 13:03:21 +09:00
Dean Herbert	add39fbd4f	Merge branch 'master' into fix-skin-layout-editor-crash	2021-10-28 06:24:24 +09:00
Dean Herbert	65a7b6776e	Add note regarding OnlineInfo being temporary	2021-10-28 05:50:22 +09:00
Dean Herbert	a9208838a9	Merge pull request #15307 from peppy/playlist-remaining-attempt-display ... Show remaining attempts again on playlist screen	2021-10-28 05:28:20 +09:00
Dean Herbert	290f583ae0	Fix incorrect initial state	2021-10-28 00:59:48 +09:00
Dean Herbert	7245baba69	Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases	2021-10-28 00:50:45 +09:00
Dean Herbert	746d6a4c16	Fix some oversights and test failures	2021-10-27 23:42:27 +09:00
Dean Herbert	f014ceaead	Update remaining usages of download tracking	2021-10-27 21:00:46 +09:00
Dean Herbert	dd06c617b1	Update OnlinePlayBeatmapAvailabilityTracker in line with new download tracker ... The structure here has changed a bit - rather than deriving from the donwload tracker I moved the additional logic into the callbacks. I think this feels better?	2021-10-27 21:00:46 +09:00
Dean Herbert	6339064dbd	Remove old versions of DownloadTrackingComposite	2021-10-27 21:00:46 +09:00
Dean Herbert	692db9a9ec	Remove unnecessary verification flow from score download tracking	2021-10-27 21:00:46 +09:00
Dean Herbert	617e6febb6	Refactor ModelDownloader to allow for different OnlineID matching	2021-10-27 21:00:46 +09:00
Dean Herbert	9015ac6ba8	Implement new version of download tracker	2021-10-27 21:00:46 +09:00
smoogipoo	f3dba49aae	Rename room managers	2021-10-27 19:36:32 +09:00
Dean Herbert	db6343c44c	Correctly redirect BPM from API to interface	2021-10-27 17:09:51 +09:00
Dean Herbert	40d963fc8a	Allow setting of APIBeatmap.Length (and don't serialise twice)	2021-10-27 16:44:21 +09:00
Dean Herbert	f268363924	Update UpdateableBeatmapBackgroundSprite to accept IBeatmapInfo	2021-10-27 16:38:48 +09:00
smoogipoo	85b21174dd	Fix online play test request handling	2021-10-27 14:49:50 +09:00
Dean Herbert	95837990f3	Apply some second-pass inspections that appeared after previous changes	2021-10-27 13:09:30 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Bartłomiej Dach	3de994449d	Add support for changing dimensions of difficulty spectrum display	2021-10-26 23:06:52 +02:00
Bartłomiej Dach	1a77e98537	Implement difficulty spectrum display	2021-10-26 23:06:52 +02:00
Jason Won	c633e2e952	only propagate unmodified right click	2021-10-26 16:24:53 -04:00
Jason Won	f64fa65fd5	right click on unselected object shows context menu	2021-10-26 14:52:15 -04:00
Dean Herbert	70f432805e	Merge branch 'master' into ui-scaling-keybind	2021-10-27 01:06:14 +09:00
Dean Herbert	411586bac3	Update resources	2021-10-26 22:12:56 +09:00
Dean Herbert	c15bfb2cf4	Handle bindable changes to fix new playlist creation not showing correct details	2021-10-26 18:19:05 +09:00
Dean Herbert	42d8d4fd38	Add tooltips to start button to explain why it's not clickable	2021-10-26 18:06:08 +09:00
Dean Herbert	1c578f285a	Disable playlist start button when attempts have been exhausted	2021-10-26 18:06:08 +09:00
Dean Herbert	bffd9162ba	Tint attempt count red when no attempts remain	2021-10-26 18:06:08 +09:00
Dean Herbert	708d40931b	Add back remaining attempt display on playlist room screen	2021-10-26 18:06:08 +09:00
Dean Herbert	d5b4c68d3a	Merge branch 'master' into fix-slider-path-extension-incorrectness	2021-10-26 17:36:50 +09:00
Dean Herbert	e92def0ba2	Fix LegacyBeatmapEncoder using incorrect path length value	2021-10-26 17:34:52 +09:00
Dan Balasescu	6a6d3a5e8a	Merge pull request #15304 from peppy/fix-editor-new-beatmap-sample-change-crash ... Fix editor crash when attempting to change sample/velocity from timeline on new beatmap	2021-10-26 17:13:56 +09:00
Dean Herbert	4cef86dd12	Merge pull request #15301 from jaswon/reverse-slider-symmetric ... Fix slider shape not always being maintained when reversing	2021-10-26 16:17:29 +09:00
Dean Herbert	ea55ba7ba9	Remove unused using statement	2021-10-26 16:08:21 +09:00
Dean Herbert	dae7cdc4c5	Ensure HitObject-local control points are non-default after ApplyDefaults ... We will probably want to make this whole flow more efficient in the future, but this should suffice for now.	2021-10-26 16:06:03 +09:00
Dean Herbert	5e5b86a1f4	Merge pull request #15156 from Susko3/use-ShowFileInNativeExplorer ... Update usages of `OpenInNativeExplorer` to use `PresentFileExternally` / `PresentExternally`	2021-10-26 15:53:03 +09:00
Dean Herbert	81fee02c2b	Fix slider paths being extended even when the last two points are equal	2021-10-26 15:47:59 +09:00
Dan Balasescu	f687ed8599	Merge pull request #15283 from peppy/test-api-beatmap-set ... Add ability to make test `APIBeatmapSet`s from test scenes	2021-10-26 15:34:19 +09:00
Dan Balasescu	7b8982c87c	Merge pull request #15302 from peppy/fix-multiplayer-chat-escape-focus ... Fix gameplay chat display not losing focus on escape key press	2021-10-26 15:34:05 +09:00
Dan Balasescu	efe6763226	Merge branch 'master' into move-online-beatmap-metrics	2021-10-26 14:24:40 +09:00
Dean Herbert	370775af68	Fix some surrounding code formatting	2021-10-26 14:05:07 +09:00
Dean Herbert	53ff0802cb	Merge branch 'master' into use-ShowFileInNativeExplorer	2021-10-26 13:58:30 +09:00
Dean Herbert	26fb9af021	Update framework	2021-10-26 13:58:07 +09:00
Dean Herbert	6c38028d06	Fix gameplay chat display not losing focus on escape key press ... Closes #15293.	2021-10-26 13:55:08 +09:00
Dan Balasescu	1e3c84b34b	Merge branch 'master' into use-beatmap-interfaces-more-uncontested	2021-10-26 13:51:55 +09:00
Dan Balasescu	676e7ff2a6	Merge pull request #15287 from peppy/get-beatmap-request-via-interface ... Allow API beatmap requests using interface type	2021-10-26 13:50:46 +09:00
Jason Won	a582976851	reversing slider maintains shape	2021-10-26 00:05:46 -04:00
Dean Herbert	d7ac94038a	Update GetBeatmapRequest to use AddParameter	2021-10-26 12:05:31 +09:00
Dean Herbert	5d1170aaf4	Remove unnecessary null check	2021-10-26 11:57:51 +09:00
Bartłomiej Dach	a49a1f41cb	Merge branch 'master' into move-online-beatmap-metrics	2021-10-25 20:33:49 +02:00
Bartłomiej Dach	5a03e1736e	Merge branch 'master' into update-beatmap-set-status-pill-appearance	2021-10-25 20:26:49 +02:00
Bartłomiej Dach	6802e9ec10	Remove FixedWidth and add AutoSizeAxes specs to all usages	2021-10-25 20:24:48 +02:00
Dean Herbert	b65d199f6a	Fix incorrect length when calling APIBeatmap.ToBeatmapInfo	2021-10-25 17:01:47 +09:00
Dean Herbert	6adb0f068b	Fix multiple issues with json serialisation of online info (causing tournament failures)	2021-10-25 16:52:50 +09:00
Dean Herbert	67ef1c40e6	Allow API beatmap requests using interface type	2021-10-25 15:59:40 +09:00
Dean Herbert	2c308f3008	Rename BeatmapMetrics to APIFailTimes	2021-10-25 15:34:41 +09:00
Dean Herbert	4969ab0599	Add forgotten JsonIgnore rules on interface types ... Just to avoid them getting serialised as part of the "new" .osu serialisation format.	2021-10-25 15:32:18 +09:00
Dean Herbert	20baae9094	Move online metrics out of BeatmapInfo model	2021-10-25 15:32:18 +09:00
Dean Herbert	045dd94a6e	Move online metrics out of BeatmapSetInfo model	2021-10-25 15:12:39 +09:00
Dean Herbert	94175bfb4a	Update PreviewTrackManager to use IBeatmapSetInfo	2021-10-25 14:25:01 +09:00
Dean Herbert	19312435d0	Add ability to make test APIBeatmaps from test scenes ... Allow tests to create a sample `APIBeatmapSet` One step towards removing calls to `ToBeatmap` / `ToBeatmapSet`.	2021-10-25 14:18:13 +09:00
Dean Herbert	78edc7554e	Fix BeatmapSetInfo's Status value being marked as non-databased	2021-10-25 12:05:34 +09:00
Bartłomiej Dach	feedd53a53	Add support for setting fixed size of status pill	2021-10-24 21:37:00 +02:00
Bartłomiej Dach	5ab3337a10	Update beatmap set status pill appearance	2021-10-24 20:40:34 +02:00
Dean Herbert	26cf5370c3	Remove unused reader parameter	2021-10-24 23:48:46 +09:00
Dean Herbert	5303cae044	Add mention of stream close logic	2021-10-24 23:43:37 +09:00
Susko3	51c5d0aec7	Update to be in line with framework changes	2021-10-24 13:21:41 +02:00
Bartłomiej Dach	d24fbc6ade	Merge branch 'master' into fix-skin-layout-editor-crash	2021-10-24 12:58:56 +02:00
Bartłomiej Dach	051cc2cd92	Update reference to configuration population process in comment	2021-10-24 12:47:17 +02:00
goodtrailer	0affe7b79d	Remove unnecessary using	2021-10-23 02:25:20 -07:00
goodtrailer	4440b9ca11	Change IHasRepeats.NodeSamples to IList from List	2021-10-23 01:59:07 -07:00
Susko3	4a425b5c3e	Merge remote-tracking branch 'upstream/master' into use-ShowFileInNativeExplorer	2021-10-23 10:01:24 +02:00
Joseph Madamba	1ae6621c85	Fix a missed toast shortcut string not localising correctly	2021-10-22 15:45:48 -07:00
Dan Balasescu	c6ca0e5895	Merge branch 'master' into fix-password-popover-focus	2021-10-22 22:52:46 +09:00
Dan Balasescu	9bb0d32fda	Merge pull request #15247 from peppy/beatmap-metadata-container-interface ... Refactor `BeatmapMetadataContainer` and usages to use interface types	2021-10-22 22:42:23 +09:00
smoogipoo	7d910ebb57	Add SignalR binding for PlaylistItemChanged	2021-10-22 22:37:08 +09:00
Dan Balasescu	e8fbb19c63	Merge branch 'master' into remove-unused-classes	2021-10-22 22:25:22 +09:00
smoogipoo	04b0529a7f	Fix list overflowing subscreen background	2021-10-22 22:17:26 +09:00
smoogipoo	a4397ee68c	Add playlist continuation flow	2021-10-22 22:07:41 +09:00
smoogipoo	76eff7f6b1	Fix incorrect indexing	2021-10-22 21:57:29 +09:00
Dean Herbert	c701579c69	Refactor BeatmapMetadataContainer and usages to use interface types	2021-10-22 21:38:50 +09:00
smoogipoo	6775151c30	Add Expired bool to APIPlaylistItem	2021-10-22 21:36:36 +09:00
smoogipoo	1b4be61ed1	Fix finished-play state not handled correctly	2021-10-22 21:16:10 +09:00
Dean Herbert	28d8820976	Merge pull request #15224 from peppy/no-more-beatmap-metadata-base ... Remove `BeatmapMetadata` base class from API classes	2021-10-22 21:07:29 +09:00
smoogipoo	d7a98097a1	Make DrawableRoomPlaylist handle expired items	2021-10-22 21:04:52 +09:00
smoogipoo	ec02e16c81	Add playlist item change event	2021-10-22 20:53:45 +09:00
smoogipoo	4e6a02bde9	Fix missing QueueMode copies	2021-10-22 20:14:04 +09:00
smoogipoo	95ab82fb58	Remove BeatmapSelectionControl and inline at usage sites	2021-10-22 19:41:36 +09:00
Dean Herbert	90477e3788	Remove unused BeatmapTypeInfo class ... Helps reduce the scope of upcoming changes.	2021-10-22 19:13:50 +09:00
Dan Balasescu	14a7b00f58	Merge pull request #15242 from peppy/fix-low-pass-sticking-after-fail ... Fix low-pass filter continuing to take effect after fail animation has already ended	2021-10-22 19:04:03 +09:00
Dean Herbert	cc1d759290	Remove unnecessary setters from IBeatmapSetOnlineInfo interface	2021-10-22 17:48:09 +09:00
Dean Herbert	91cc77407d	Fix low-pass filter continuing to take effect after fail animation has already ended	2021-10-22 17:02:02 +09:00
smoogipoo	db87e42d47	Remove beatmap/ruleset/etc from MultiplayerRoomSettings	2021-10-22 16:48:28 +09:00
Dean Herbert	ea473428e8	Fix incorrect length mapping in APIBeatmap	2021-10-22 15:54:40 +09:00
Dean Herbert	de33b2f45a	Return set metadata if available before falling back to empty object	2021-10-22 15:00:31 +09:00
Dean Herbert	eef9949a0a	Remove unnecessary branching around EF logic	2021-10-22 14:48:20 +09:00
Dean Herbert	93482414d6	Remove SkinConfiguration subclasses and allow configuration parsing for all skin types	2021-10-22 14:42:23 +09:00
Dean Herbert	82d0a6515f	Fix incorrect conditional for checking whether import (would fail for default skin)	2021-10-22 14:08:12 +09:00
Dean Herbert	9cdc1ba592	Fix default legacy skin not being able to read from stored skin.ini	2021-10-22 13:43:45 +09:00
Dean Herbert	e5b73f25cd	Ensure newly created skin.ini files are set to latest version	2021-10-22 12:56:05 +09:00
smoogipoo	a1c9b56083	Rename modes	2021-10-22 12:55:37 +09:00
Dean Herbert	fb7cf35481	Remove BeatmapMetadata base class from APIBeatmap	2021-10-21 21:48:14 +09:00
Dean Herbert	6dd54a417f	Remove BeatmapMetadata base class from APIBeatmapSet	2021-10-21 21:32:07 +09:00
Dean Herbert	9e0d839ef3	Merge branch 'master' into fix-skin-layout-editor-crash	2021-10-21 20:33:47 +09:00
Dean Herbert	c580ec865f	APIBeatmapSet.Covers is never null	2021-10-21 19:34:01 +09:00
Dean Herbert	0fe0b5dc09	APIBeatmap implements IBeatmapInfo	2021-10-21 19:14:31 +09:00
Dean Herbert	40a176e86e	APIBeatmapSet implements IBeatmapSetInfo	2021-10-21 19:14:19 +09:00
Dean Herbert	69e7810dad	Enable nullable and switch classes to structs	2021-10-21 18:54:36 +09:00
Dan Balasescu	8ae05ee8f7	Merge branch 'master' into online-info-as-interface	2021-10-21 17:14:57 +09:00
Dean Herbert	0335ed6f27	Add missing licence header	2021-10-21 17:14:29 +09:00
smoogipoo	f41cf822b0	Rename request	2021-10-21 17:02:11 +09:00
Dean Herbert	ff674ca913	Remove unnecessary access modifiers from interface	2021-10-21 17:01:57 +09:00
Dean Herbert	b73bd54ab2	Split out individual pieces into own files	2021-10-21 16:58:42 +09:00
Dean Herbert	32d01f022f	Rename usages which rely on online backing	2021-10-21 16:58:42 +09:00
Dean Herbert	0706ad70fb	Move BeatmapSetOnlineInfo to an interface type	2021-10-21 16:58:42 +09:00
Dean Herbert	a5c155bc87	Remove APIPlaylistBeatmap subclass	2021-10-21 16:43:46 +09:00
Dean Herbert	a5088cac27	Fix default metadata propagation when no files are present	2021-10-21 13:43:42 +09:00
Dean Herbert	59b7210efa	Revert disallowing imports with no files ... While it is logical that we want this, from a testing perspective this is a bit of a nightmare to fix. Let's revisit at a later point in time.	2021-10-21 13:43:42 +09:00
Dean Herbert	7bc8f5cd5c	Change selection colour to also match the colour provider scheme	2021-10-21 13:01:13 +09:00
Bartłomiej Dach	9ad9465020	Remove online-screen-local textbox recolours	2021-10-20 22:49:25 +02:00
Bartłomiej Dach	1ec881ce1d	Recolour focused text box variant	2021-10-20 22:49:25 +02:00
Bartłomiej Dach	addcef4f5d	Recolour text box using OverlayColourProvider	2021-10-20 22:49:25 +02:00
smoogipoo	691e414acb	Add request to add a new playlist item	2021-10-20 21:08:58 +09:00
smoogipoo	67090fc598	Re-namespace enum	2021-10-20 20:52:16 +09:00
smoogipoo	599867a3b1	Add implementation to settings overlay	2021-10-20 20:29:06 +09:00
Dean Herbert	68c01fc204	Fix infinite loop on default skin (it can't have a skin.ini)	2021-10-20 17:56:45 +09:00
Dean Herbert	9e6e41d7c0	Add migration to reset and repopulate existing skin hashes	2021-10-20 17:56:45 +09:00
Dean Herbert	602303e947	Add test coverage for skin.ini contents	2021-10-20 17:56:45 +09:00
Dean Herbert	a95c754fd3	Fix multiple issues and make metadata fallback process more logical	2021-10-20 17:56:45 +09:00
smoogipoo	0e446105fb	Rename to "picking mode" as simpler english	2021-10-20 17:52:51 +09:00
smoogipoo	bc57190fb4	Make dropdown not move the selection control	2021-10-20 17:52:05 +09:00
smoogipoo	0b8edb0812	Add english descriptions	2021-10-20 17:50:02 +09:00
Dean Herbert	439e90fce3	Disallow archive imports with no hashable files	2021-10-20 17:45:06 +09:00
Dean Herbert	fa542f2547	Include json files in skin hashing ... This covers the new layout storage we are doing.	2021-10-20 17:45:06 +09:00
Dean Herbert	789c715f13	Add skin.ini write support to allow for more correct hashing	2021-10-20 17:45:06 +09:00
smoogipoo	116ce09e49	Merge branch 'master' into multi-queueing-modes	2021-10-20 17:27:25 +09:00
Dan Balasescu	08f3bc3f44	Merge pull request #15120 from peppy/realm-importer ... Implement realm beatmap importer	2021-10-20 16:44:16 +09:00
Dean Herbert	da750a74fc	Add xmldoc mention of valid OnlineID values	2021-10-20 15:24:27 +09:00
smoogipoo	c8cdc38efd	Always compare OnlineIds by >0	2021-10-20 15:20:34 +09:00
smoogipoo	2c979d6420	Merge branch 'master' into localise-toasts	2021-10-20 15:04:07 +09:00
smoogipoo	a06f624a4a	Fix possible exception with "invalid" key ... Triggered by toggling Shift+Tab during gameplay.	2021-10-20 15:03:16 +09:00
smoogipoo	ea9c070e59	Add setting for queue mode	2021-10-20 14:51:59 +09:00
Dean Herbert	4b2eb7736c	Move helper method to bottom of file	2021-10-20 12:52:38 +09:00
Dean Herbert	37841ca3aa	Remove incorrect ToString calls causing localisation to not actually apply	2021-10-20 10:41:34 +09:00
Bartłomiej Dach	f29eb08d93	Improve contrast in default OverlayColourProvider-themed appearance	2021-10-19 22:55:49 +02:00
Bartłomiej Dach	80da153697	Recolour a few other existing dropdowns with same hover & selection colours	2021-10-19 22:47:18 +02:00
Bartłomiej Dach	61127a389c	Fix tab dropdown receiving accent colour too early	2021-10-19 22:09:51 +02:00
Bartłomiej Dach	ef03787fe0	Split dropdown accent colour into hover and selection colours	2021-10-19 22:09:51 +02:00
Dean Herbert	8672b3325a	Fix a couple more weird variable names	2021-10-19 17:22:50 +09:00
Dean Herbert	61670a70b6	Tidy up tracked settings code syntax and fix remaining issue	2021-10-19 17:21:07 +09:00
Dean Herbert	192cfe8717	Replace unnecessary ToString call ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-19 16:42:07 +09:00
Dean Herbert	c97cfdd978	Merge branch 'master' into localise-toasts	2021-10-19 16:37:14 +09:00
Dean Herbert	7cf4395875	Merge branch 'master' into default-value-indicator	2021-10-19 16:23:02 +09:00
Dean Herbert	480dc57102	Schedule joinFailed callback for added safety	2021-10-19 15:54:12 +09:00
Dean Herbert	da524261c0	Fix focus potentially being transferred too far up when password is being verified	2021-10-19 15:53:29 +09:00
Dean Herbert	a589964dc7	Centralise join logic	2021-10-19 15:53:29 +09:00
Dean Herbert	8944b1dd78	Add basic test coverage of DrawableLoungeRoom	2021-10-19 15:36:27 +09:00
Dean Herbert	473459d191	Add layout duration to PasswordEntryPopover to make error text look a bit smoother	2021-10-19 15:36:27 +09:00
Dean Herbert	d35fe5493a	Change default value of DrawableLoungeRoom.matchingFilter so they display by default	2021-10-19 15:36:27 +09:00
Dean Herbert	d3ab45084d	Fix realm migration potentially failing from older releases	2021-10-19 14:19:58 +09:00
sh0ckR6	e7b280fc81	Comment out RankDisplay ... Commented out as it may be revisited at a later time. Also currently unused.	2021-10-18 23:12:33 -04:00
Dean Herbert	ff2eae4597	Rename confusing variable	2021-10-19 11:37:46 +09:00
Dan Balasescu	30af27e561	Merge branch 'master' into realm-importer	2021-10-19 11:06:11 +09:00
Dan Balasescu	4fcdeffbd9	Merge pull request #15176 from peppy/realm-indexed-online-id ... Change `OnlineID` to non-nullable to allow for indexing in Realm	2021-10-19 11:05:34 +09:00
Bartłomiej Dach	8db2fc439d	Change ruleset ID assert in player to null-check	2021-10-18 23:45:06 +02:00
Bartłomiej Dach	6d9d85685f	Fix settings item having zero height	2021-10-18 23:30:38 +02:00
Bartłomiej Dach	cc9727ec11	Merge branch 'master' into default-value-indicator	2021-10-18 22:07:58 +02:00
Bartłomiej Dach	88a1b31fae	Remove grid usage in SettingsItem	2021-10-18 22:07:32 +02:00
Bartłomiej Dach	6c3637a62a	Remove grid usage in KeyBindingRow	2021-10-18 22:07:30 +02:00
Bartłomiej Dach	830f49bca6	Remove doubled-up opacity specification	2021-10-18 19:43:48 +02:00
Dean Herbert	b3219bb592	Update usages of OnlineID	2021-10-18 16:16:36 +09:00
Dean Herbert	6904938dc1	Merge branch 'realm-indexed-online-id' into realm-importer	2021-10-18 16:14:37 +09:00
Dean Herbert	88a575462c	Work around weird null inspection	2021-10-18 16:11:55 +09:00
Dean Herbert	2c5ba1d8e2	Change OnlineID to non-nullable to allow for indexing in Realm	2021-10-18 15:53:40 +09:00
Dan Balasescu	8643c725cc	Merge pull request #15175 from peppy/fail-animation-flash-controlled-by-setting ... Don't flash screen red on fail if the user has disabled red tinting	2021-10-18 15:27:10 +09:00
Dan Balasescu	f2f9872718	Merge pull request #15173 from peppy/fix-epilepsy-warning-fade-out ... Fix epilepsy warning not being faded out on an early exit during gameplay load	2021-10-18 15:18:38 +09:00
Dean Herbert	b2f9f8b8da	Update logic surrounding removal of previous OnlineIDs when running a new import	2021-10-18 15:14:13 +09:00
Dean Herbert	264fa703f2	Remove some forgotten temporary code from BeatmapImporter ... And make the online queue not `dynamic`, at very least.	2021-10-18 14:43:50 +09:00
Dean Herbert	75bfa705cf	Remove unused method for now	2021-10-18 14:32:38 +09:00
Dean Herbert	ad112cbbc5	Fix intendation in a way it doesn't regress with older inspectcode	2021-10-18 14:28:29 +09:00
Dean Herbert	3c4c9ab7a7	Move ICanAcceptFiles specification to IModelImporter<TModel>	2021-10-18 14:25:51 +09:00
Dean Herbert	762949f49f	Don't flash screen red on fail if the user has disabled red tinting	2021-10-18 14:20:38 +09:00
Dean Herbert	6d6eed61aa	Fix new indentation inspections	2021-10-18 14:00:35 +09:00
Dean Herbert	59dc04017e	Fix epilepsy warning not being faded out on an early exit from PlayerLoader	2021-10-18 13:30:37 +09:00
Bartłomiej Dach	2a41e8bd1f	Remove unneeded extra padding from settings number box	2021-10-17 21:50:04 +02:00
Bartłomiej Dach	552fc1dc8a	Adjust key binding rows to accommodate new default value indicator	2021-10-17 21:50:04 +02:00
Bartłomiej Dach	f422ebb281	Adjust SettingsItem to accommodate new default value indicator	2021-10-17 21:50:03 +02:00
Bartłomiej Dach	818f35c35f	Restyle default value indicator	2021-10-17 21:50:03 +02:00
5ln	3529f34c98	Multi: Hide mods when spectating or Beatmap isn't Locally Available. ... Signed-off-by: 5ln <xnafumie@gmail.com>	2021-10-18 02:01:50 +08:00
Susko3	25f172fae8	Update usages of OpenInNativeExplorer to use ShowFileInNativeExplorer ... Also updates WrappedStorage to override ShowFileInNativeExplorer.	2021-10-17 12:56:29 +02:00
Bartłomiej Dach	874decb3cd	Replace spectator-local fix for wrong ruleset ID with player-global consistency check	2021-10-16 16:10:42 +02:00
Bartłomiej Dach	e57d6e930e	Source spectator state sent to server from gameplay state	2021-10-16 13:48:49 +02:00
Dean Herbert	7a5a612896	Move retry and exit hotkey overlays to same depth / container	2021-10-16 02:29:45 +09:00
Dean Herbert	e9f50179ab	Merge branch 'master' into fail-animation-update	2021-10-15 23:32:10 +09:00
Dean Herbert	91754450b2	Remove dispose method completely	2021-10-15 21:27:44 +09:00
Dean Herbert	6f947cacbd	Fix test failures	2021-10-15 21:22:38 +09:00
smoogipoo	2fd101ad50	Reorder elements to follow designs	2021-10-15 20:25:32 +09:00
smoogipoo	a70d7e4feb	Remove unnecessary extra GridContainer	2021-10-15 20:18:25 +09:00
smoogipoo	6f89e30f56	Add QueueingMode to MultiplayerRoomSettings	2021-10-15 20:17:19 +09:00
Dean Herbert	c47497923a	Schedule drag events for now	2021-10-15 19:52:44 +09:00
Dean Herbert	30c3fcb4ea	Merge branch 'master' into slider-timeline-velcotiy-adjust-v2	2021-10-15 19:45:04 +09:00
Dean Herbert	3909fd8caa	Fix wonkiness when dragging slider end at high input refresh rates	2021-10-15 19:43:57 +09:00
Dean Herbert	b9fd1f52df	Tweak animation slightly	2021-10-15 19:37:22 +09:00
Dean Herbert	b08743342b	Fix incorrect nesting	2021-10-15 19:35:08 +09:00
Dean Herbert	66f3370a19	Add new fail animation to better match new sound effects	2021-10-15 19:14:59 +09:00
Dean Herbert	a59ee9ec1f	Merge pull request #15121 from nekodex/fail-highpass ... Add high-pass filter to gameplay fail sequence	2021-10-15 19:14:44 +09:00
Dean Herbert	ae33b7b87f	Update resources	2021-10-15 18:27:01 +09:00
Dan Balasescu	8d11f4ce48	Merge pull request #15075 from peppy/fix-editor-difficulty-name-update ... Use actual `BeatmapInfo` rather than `PlayableBeatmap.BeatmapInfo` for editor writes	2021-10-15 18:12:12 +09:00
Dan Balasescu	3d314dad9f	Merge pull request #15115 from peppy/fix-realm-config-save-overhead ... Fix changing osu!mania scroll speed causing game-wide lag	2021-10-15 17:33:42 +09:00
Dean Herbert	0e1f144bf4	Rename ArchiveModelImporter with Realm prefix to avoid confusion	2021-10-15 17:08:43 +09:00
Dean Herbert	cd64faa4f9	Tidy up importer difficulty creation code	2021-10-15 17:07:34 +09:00
Dean Herbert	49969ac328	Add beatmap import and file store tests	2021-10-15 17:07:34 +09:00
Jamie Taylor	8d6d7fcdbe	Add high-pass filter to gameplay fail sequence	2021-10-15 17:03:37 +09:00
Dean Herbert	d95a62fa56	Add models and stores for beatmap manager requirements	2021-10-15 16:58:41 +09:00
Dan Balasescu	3604a762d0	Merge branch 'master' into fix-editor-difficulty-name-update	2021-10-15 16:58:01 +09:00
Dan Balasescu	05150b34e5	Merge pull request #15117 from peppy/update-present-import-post-import ... Update one missed instance of `PresentImport`	2021-10-15 16:57:47 +09:00
Dan Balasescu	56758435ee	Merge pull request #15043 from peppy/realm-ruleset-store ... Add realm `RulesetStore`	2021-10-15 16:49:48 +09:00
Dean Herbert	8fb9aec730	Fix threaded realm usage not disposing context fast enough	2021-10-15 16:39:53 +09:00
Dan Balasescu	34d60b9e10	Merge branch 'master' into fix-realm-config-save-overhead	2021-10-15 16:30:39 +09:00
Dean Herbert	e9c3d09e0e	Remove redundant specs	2021-10-15 16:27:16 +09:00
Dean Herbert	fdb734ac91	Also add spec directly to IModelImporter	2021-10-15 16:24:40 +09:00
Dean Herbert	2eb1170c0c	Use AsNonNull instead	2021-10-15 16:15:34 +09:00
Dean Herbert	efaed4cba4	Revert "Attempt bumping inspectcode to fix remaining inspection" ... This reverts commit e018a6d6a5.	2021-10-15 16:14:57 +09:00
Dean Herbert	a90f40e831	Update one missed instance of PresentImport	2021-10-15 16:00:09 +09:00
Dan Balasescu	745f319c7d	Merge branch 'master' into fix-realm-disposal-order	2021-10-15 15:44:14 +09:00
Dean Herbert	e018a6d6a5	Attempt bumping inspectcode to fix remaining inspection	2021-10-15 14:08:25 +09:00
Dan Balasescu	48a9ab9e89	Merge branch 'master' into fix-multiplayer-tests	2021-10-15 14:04:27 +09:00
Dean Herbert	e38eb31fd4	Merge branch 'fix-realm-disposal-order' into fix-realm-config-save-overhead	2021-10-15 14:00:31 +09:00
Dean Herbert	818fac6ac8	Make realm a non-drawable component to better order disposal ... Until now, the `RealmContextFactory` would be disposed as part of the drawable hierarchy. This is too early, as it may be being used by higher level components (like `ConfigManager`s, see #15115) that perform final operations after the drawables have been disposed. Seems to make sense moving this out of the drawable hierarchy and in line with how we were doing things with EF.	2021-10-15 13:58:16 +09:00
Dan Balasescu	1e15b5a5a0	Merge pull request #15113 from peppy/rounded-button-colour-provider ... Change `RoundedButton` to source from overlay colour provider	2021-10-15 13:52:52 +09:00
Dean Herbert	e47ccbd08a	Fix realm transactional overhead when rapidly changing RulesetConfigManager values	2021-10-15 13:50:26 +09:00
smoogipoo	80dfd11c90	Remove unnecessary extra task ... Further testing shows continuations also run before the .Wait() returns.	2021-10-15 13:28:02 +09:00
Dean Herbert	7ab028576e	Change RoundedButton to source from overlay colour provider	2021-10-15 12:54:19 +09:00
Dean Herbert	f73e505ee6	Further adjustments to glow to be less bright on settings overlay	2021-10-15 12:35:19 +09:00
Dean Herbert	e1ac5fbed9	Remove externally exposed Expanded state and change behaviour and visuals surrounding it	2021-10-15 12:13:42 +09:00
Dean Herbert	35d776078c	Ensure sliderbar nub stays glowing while dragging an adjustment	2021-10-15 11:51:08 +09:00
Dean Herbert	be3b88a5c3	Adjust glow to look good	2021-10-15 11:48:19 +09:00
Dean Herbert	3a25bdaf3d	Merge branch 'master' into slider-timeline-velcotiy-adjust-v2	2021-10-15 11:18:37 +09:00
Dean Herbert	874d722820	Merge branch 'master' into fix-editor-difficulty-name-update	2021-10-15 11:14:45 +09:00
Bartłomiej Dach	ed2f9dd443	Adjust settings slider spacings	2021-10-15 00:31:06 +02:00
Bartłomiej Dach	a10a7e7903	Refresh nub/slider appearance and use overlay theming	2021-10-15 00:31:05 +02:00
smoogipoo	eed8fa8d69	Expand comment a bit	2021-10-15 00:20:45 +09:00
smoogipoo	e6ee360511	Fix intermittent multiplayer tests	2021-10-15 00:10:39 +09:00
Dean Herbert	ad0732484f	Just wait for metadata section to be loaded	2021-10-14 22:12:38 +09:00
Dean Herbert	9d54285b2e	Merge branch 'master' into fix-multiplayer-sounds-during-gameplay	2021-10-14 21:34:04 +09:00
Dean Herbert	a31f5ca326	Update framework	2021-10-14 20:13:55 +09:00
Dean Herbert	06249c4ab2	Fix incorrect usages of Scheduler.AddOnce	2021-10-14 17:52:19 +09:00
Dean Herbert	0d86dab80a	Fix multiplayer components updating when not alive ... Should close https://github.com/ppy/osu/issues/15092. - [ ] Depends on https://github.com/ppy/osu-framework/pull/4826.	2021-10-14 17:37:10 +09:00
smoogipoo	901f107b2e	Merge branch 'master' into slider-timeline-velcotiy-adjust-v2	2021-10-14 17:25:51 +09:00
Dan Balasescu	fb9c3fe72e	Merge pull request #14619 from peppy/no-more-difficulty-control-points-info ... Move `DifficultyControlPoint`s to be specified at a per-`HitObject` level	2021-10-14 17:24:32 +09:00
Dean Herbert	1212b08672	Fix gameplay audio ramping down in frequency a second time at the end of the fail sequence	2021-10-14 16:45:34 +09:00
smoogipoo	2784ba1423	Add queueing modes	2021-10-14 16:34:23 +09:00
Dean Herbert	8a4c0c0ac8	Lock one more case of usage	2021-10-14 16:22:43 +09:00
Dean Herbert	060bb1afbd	Add locking around async beatmap (task) retrieval	2021-10-14 15:39:53 +09:00
Dean Herbert	4ed794e434	Throw and log instead of silently failing on type/instance creation failure	2021-10-14 14:24:36 +09:00
Dean Herbert	364fa068b3	Add non-null check to appease inspection	2021-10-14 14:20:34 +09:00
Dean Herbert	ccc8012fd4	Mark non-localisable strings	2021-10-14 14:16:39 +09:00
Dean Herbert	e0babe4b79	Add global logging of WorkingBeatmap changes	2021-10-14 14:07:43 +09:00
Dean Herbert	09536cd733	Add logging of WorkingBeatmapCache.Invalidate calls	2021-10-14 14:05:33 +09:00
Dean Herbert	b1fc870130	Adjust item selection and chevron animation slightly	2021-10-14 13:34:08 +09:00
Dean Herbert	bf1000000e	Merge branch 'master' into dropdown-refresh	2021-10-14 12:48:56 +09:00
smoogipoo	aa380a11c1	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-14 12:02:10 +09:00
Dean Herbert	8d479bbe56	Merge branch 'master' into fix-editor-difficulty-name-update	2021-10-14 10:17:01 +09:00
Bartłomiej Dach	c7db286b94	Merge branch 'master' into file-sanity-checks	2021-10-14 00:17:29 +02:00
Bartłomiej Dach	d2115824fa	Merge branch 'master' into dropdown-refresh	2021-10-13 23:53:14 +02:00
Bartłomiej Dach	d8450a7375	Recolour "slim dropdown" in online lounge screens	2021-10-13 22:57:37 +02:00
Bartłomiej Dach	f3647eb94e	Recolour room settings screens to match dropdown theming	2021-10-13 22:50:19 +02:00
Bartłomiej Dach	d067159435	Recolour elements of editor setup screen to match dropdown theming	2021-10-13 22:32:54 +02:00
Bartłomiej Dach	a6c2848460	Fix hovered dropdown item chevron not using OverlayColourProvider	2021-10-13 22:08:23 +02:00
Bartłomiej Dach	7e7b747755	Always use OverlayColourProvider in scroll containers if available	2021-10-13 22:05:48 +02:00
Bartłomiej Dach	d4e3460912	Always use OverlayColourProvider in dropdowns if available	2021-10-13 22:04:48 +02:00
Bartłomiej Dach	d205483a36	Revert ThemedDropdown-related changes	2021-10-13 21:57:50 +02:00
Dean Herbert	f7a5879fa6	Merge pull request #15056 from smoogipoo/fix-gamehost-tests ... Fix GameHosts being run on TPL threads	2021-10-13 23:06:26 +09:00
smoogipoo	fdf7142711	Remove Room.Position	2021-10-13 21:24:54 +09:00
Dan Balasescu	e49f1f6e6b	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-13 20:17:57 +09:00
Dean Herbert	2af1e6acc7	Update framework	2021-10-13 18:02:22 +09:00
Dan Balasescu	d88daf0cc2	Merge pull request #15073 from peppy/fix-player-loader-low-pass ... Improve `PlayerLoader` audio and visual transitions	2021-10-13 17:01:49 +09:00
Dean Herbert	93d7cdc509	Don't check whether the source realm was closed or not ... Based on what we now know, this is not required, as long as there is another realm context open on the same thread.	2021-10-13 15:50:06 +09:00
Dean Herbert	2fb5c85377	Merge branch 'master' into realm-ruleset-store	2021-10-13 15:25:18 +09:00
Dean Herbert	f5f0486e18	Merge branch 'master' into realm-live	2021-10-13 15:24:34 +09:00
Dean Herbert	29dfe33465	Rewrite AudioFilter to be easier to follow (and fix tests)	2021-10-13 15:17:20 +09:00
Dean Herbert	02689a1b60	Use actual BeatmapInfo rather than PlayableBeatmap.BeatmapInfo for editor writes	2021-10-13 14:50:12 +09:00
Dan Balasescu	3445d915b9	Merge pull request #15074 from peppy/fix-storyboard-fail-test-fails ... Fix storyboard outro during fail test not being lenient enough	2021-10-13 14:16:26 +09:00
Dan Balasescu	df5a76ad9d	Merge pull request #15041 from peppy/realm-file-store ... Add realm `FileStore`	2021-10-13 13:54:56 +09:00
Dean Herbert	26a1e40d24	Fix storyboard outro during fail test not being lenient enough	2021-10-13 13:48:57 +09:00
Dean Herbert	ae4dcbd829	Improve PlayerLoader audio and visual transitions	2021-10-13 13:26:20 +09:00
Dean Herbert	b37096f440	Avoid using bindable for AudioFilter cutoff ... It doesn't play nicely with screen exiting, as it is automatically unbound during the exit process. Easiest to just avoid using this for now.	2021-10-13 13:25:55 +09:00
smoogipoo	cf10239e70	Add a few nullabilities and DCC excludes	2021-10-13 12:51:46 +09:00
Dean Herbert	f69a56a26a	Add test coverage of startup import sequence	2021-10-13 12:19:10 +09:00
Dean Herbert	94de24075e	Ensure startup imports trigger notifications	2021-10-13 12:18:56 +09:00
Bartłomiej Dach	7c5bd2db7b	Allow using ThemedDropdown even if OverlayColourProvider not available ... This is to accommodate `SettingsDropdown` usages without an available `OverlayColourProvider`, such as mod settings controls and tournament client usages.	2021-10-12 23:12:16 +02:00
Bartłomiej Dach	7139c832b0	Add support for changing scrollbar accent colour & use in themed dropdown	2021-10-12 22:20:07 +02:00
Bartłomiej Dach	a2f3a7cba8	Add "themed" dropdown variant and use in settings sidebar	2021-10-12 21:58:43 +02:00
Bartłomiej Dach	1fba932e84	Adjust settings dropdown spacings	2021-10-12 21:41:33 +02:00
Bartłomiej Dach	5ddb7f74e2	Adjust default dropdown dimensions & spacings	2021-10-12 21:41:29 +02:00
Bartłomiej Dach	3ceee176e6	Merge branch 'master' into frame-stability-container-direction-flip	2021-10-12 18:34:04 +02:00
Dean Herbert	e468bfb31c	Merge branch 'master' into realm-file-store	2021-10-12 23:11:02 +09:00
Dan Balasescu	cabbb1697a	Merge pull request #15054 from peppy/settings-ordering ... Initial settings usability pass	2021-10-12 22:00:30 +09:00
Dan Balasescu	60ba1987ba	Merge pull request #15050 from peppy/fix-cross-thread-list-manipulation-skin-source-provider ... Fix cross-thread list manipulation in `SkinProvidingContainer`	2021-10-12 21:59:49 +09:00
Dan Balasescu	7bb401b974	Merge pull request #15040 from peppy/realm-test-game-host ... Update realm tests to run inside a `GameHost` to allow running on update thread	2021-10-12 21:16:06 +09:00
Dan Balasescu	f76b58e843	Merge pull request #15055 from peppy/fix-taiko-convert-woes ... Fix `BeatmapConverter` not cloning deeply enough	2021-10-12 21:07:39 +09:00
Dan Balasescu	f01e995cd9	Merge branch 'master' into fix-cross-thread-list-manipulation-skin-source-provider	2021-10-12 20:59:17 +09:00
Dean Herbert	427bf4ef0a	Merge branch 'master' into fix-audio-filter-test-failures	2021-10-12 19:42:18 +09:00
Dean Herbert	e6cd0a8371	Remove unused using statements	2021-10-12 17:17:40 +09:00
Dean Herbert	1373cc02d7	Shallow clone BeatmapInfo during conversion process to avoid overwriting fields	2021-10-12 16:43:56 +09:00
Bartłomiej Dach	b79cf0b58b	Add failing coverage for conversion not altering original beatmap	2021-10-12 16:43:56 +09:00
Dean Herbert	6fec821a17	Update framework	2021-10-12 16:20:13 +09:00
Dean Herbert	c66e50ac55	Remove temporary logging	2021-10-12 16:19:58 +09:00
Dean Herbert	76c64751de	Remove RealmBeatmap.Clone for the time being (incorrectly implemented)	2021-10-12 16:18:12 +09:00
Dean Herbert	0df9ab3eec	Fix migration blocking code running on the wrong thread	2021-10-12 16:04:09 +09:00
Dean Herbert	ce128476ae	Remove public setter of RealmFileStore.Storage	2021-10-12 15:46:32 +09:00
Dean Herbert	129416835f	Remove stray string.Empty specification ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-12 15:40:12 +09:00
Dean Herbert	24b87cf655	Change some icons to be more descriptive (still placeholder)	2021-10-12 15:09:59 +09:00
Dean Herbert	59202d27c7	Add some missing labels	2021-10-12 15:09:59 +09:00
Dean Herbert	5ca1d1d12c	Reorder graphics settings and move gameplay related pieces out	2021-10-12 15:09:59 +09:00
Dean Herbert	c4347de57e	Move ruleset settings to own section	2021-10-12 14:58:43 +09:00
Dean Herbert	8285f065c2	Reorganise gameplay settings into more sections	2021-10-12 14:58:43 +09:00
Dan Balasescu	8291d74b68	Merge pull request #15053 from peppy/remove-button-drop-shadow ... Remove drop shadow from `RoundedButton`	2021-10-12 14:04:41 +09:00
Dean Herbert	1d3d67c5f1	Move gameplay cursor settings to gameplay section	2021-10-12 13:56:10 +09:00
Dean Herbert	a986870a99	Reorder sections to be more in line with how often they are adjusted	2021-10-12 13:41:35 +09:00
Dean Herbert	e982f485c7	Remove drop shadow from RoundedButton ... As per @arflyte's spec, this should not have been there in the first place.	2021-10-12 13:17:49 +09:00
Dean Herbert	d7cbacc5a0	Rename OnSourceChanged and expand on xmldoc to mention that it doesn't fire SourceChanged	2021-10-12 13:04:48 +09:00
Dean Herbert	a849e7343e	Add lock to ensure no threading shenanigans	2021-10-12 13:04:24 +09:00
Dean Herbert	077dcf5cd9	Add missing documentation for SourceChanged	2021-10-12 12:50:28 +09:00
Dean Herbert	e058214346	Merge branch 'master' into fix-audio-filter-test-failures	2021-10-12 12:06:12 +09:00
Gagah Pangeran Rosfatiputra	81246a110c	add OpenChangelog in OsuGame.HandleLink	2021-10-12 09:57:47 +07:00
Gagah Pangeran Rosfatiputra	6c84cf6658	add ShowChangelogListing and ShowChangelogBuild	2021-10-12 09:57:47 +07:00
Gagah Pangeran Rosfatiputra	80722c7dc7	change changelogOverlay to field in OsuGame	2021-10-12 09:57:47 +07:00
Gagah Pangeran Rosfatiputra	47c7701e47	handle changelog link in message formatter	2021-10-12 09:57:47 +07:00
Dean Herbert	39a3482458	Replace Add/Reset methods with single Set method	2021-10-12 11:55:07 +09:00
Gagah Pangeran Rosfatiputra	e0c54e3207	add OpenChangelog link action	2021-10-12 09:37:11 +07:00
Dean Herbert	df83f0db08	Fix cross-thread list manipulation in SkinProvidingContainer	2021-10-12 11:28:11 +09:00
Dean Herbert	1550a3b470	Rethrow exception after logging to make tracking on CI easier	2021-10-12 11:11:55 +09:00
Dean Herbert	82f7f99f37	Refactor to use scoped using (and also correctly dispose TagLib portion)	2021-10-12 10:46:26 +09:00
Dan Balasescu	696193198a	Merge pull request #15049 from bdach/settings-panel-rounded-buttons ... Update appearance of buttons in settings sidebar	2021-10-12 09:32:52 +09:00
Naxesss	f2f97602f2	Dispose of video resource later ... We need the Stream to stay open here because `StreamFileAbstraction` uses it later in the block.	2021-10-12 00:40:39 +02:00
Naxesss	d4779f06cf	Rework CloseStream	2021-10-12 00:30:00 +02:00
Naxesss	47b4d03145	Dispose of Streams when used	2021-10-12 00:13:38 +02:00
Naxesss	ce69dd3588	Use Prescan flag for audio length check	2021-10-11 23:57:23 +02:00
Bartłomiej Dach	ff382259ca	Use rounded buttons in tablet rotation preset settings	2021-10-11 23:17:09 +02:00
Bartłomiej Dach	56eae703fe	Avoid changing frame stable clock direction if time hasn't changed between frames	2021-10-11 21:39:48 +02:00
Naxesss	8f093b9a11	Use TagLib instead of ManagedBass	2021-10-11 13:56:26 +02:00
Naxesss	f0cd18a721	Only check each video file once	2021-10-11 13:55:50 +02:00
Naxesss	6aa054b5fa	Change to non-BASS error template	2021-10-11 13:53:23 +02:00
Dean Herbert	22e90076fb	Add temporary logging	2021-10-11 18:05:45 +09:00
Joseph Madamba	e0557e849b	Join combinations with "/" instead	2021-10-11 01:11:41 -07:00
Joseph Madamba	4fc84e71cd	Localise more toast related strings	2021-10-11 01:02:26 -07:00
Dan Balasescu	7c21190b35	Merge branch 'master' into fix-audio-filter-test-failures	2021-10-11 16:43:17 +09:00
Dan Balasescu	c251a3016e	Merge pull request #15039 from peppy/manager-code-quality ... Fix a couple of code quality issues with new manager interface usage	2021-10-11 16:42:04 +09:00
Dean Herbert	484a95229e	Update toast implementations temporarily to expedite getting tests back in line	2021-10-11 16:36:04 +09:00
Dean Herbert	b4092549c0	Update framework	2021-10-11 16:35:36 +09:00
Dean Herbert	bae404f742	Update framework	2021-10-11 16:17:15 +09:00
Dean Herbert	68078bd5bd	Merge branch 'master' into localise-toasts	2021-10-11 16:17:10 +09:00
Dean Herbert	43aacb3831	Fix two different skins displaying at the same time when rapidly switching	2021-10-11 16:11:15 +09:00
Dean Herbert	0daa836ecc	Add realm RulesetStore ... Not yet used in game.	2021-10-11 15:57:33 +09:00
Dean Herbert	b01d82b3fd	Add RealmLive implementation	2021-10-11 15:36:41 +09:00
Dean Herbert	03bf88ae81	Add realm FileStore and test coverage	2021-10-11 15:26:16 +09:00
Dean Herbert	6ca415da9f	Add basic realm models ... Only the file related ones are really required outside of tests, but seems like as good an opportunity as ever to get the rest of the models into the game project.	2021-10-11 15:25:04 +09:00
Dean Herbert	f43badabf4	Add back update thread verification in RealmContextFactory	2021-10-11 15:20:12 +09:00
Dean Herbert	c7675be3ef	Fix typo in IModelImporter's xmldoc	2021-10-11 15:12:51 +09:00
Dean Herbert	6b35ccae95	Fix some cases where interface specifications can be used but weren't	2021-10-11 15:06:24 +09:00
Dean Herbert	3d6602b8df	Ensure FailAnimation is disposed synchronously to avoid test failures	2021-10-11 14:05:31 +09:00
Joseph Madamba	4b01c23c11	Track ui scale setting	2021-10-10 19:55:02 -07:00
Joseph Madamba	af9bb6f277	Fix padding of shortcut in toast when widest	2021-10-10 19:37:46 -07:00
Joseph Madamba	7b37b15976	Localise some music action toasts	2021-10-10 19:36:50 -07:00
Joseph Madamba	545cfc7bf1	Localise tracked setting toasts	2021-10-10 19:35:25 -07:00
Joseph Madamba	cce4a41c5d	Add "disabled" common string	2021-10-10 19:33:45 -07:00
Dean Herbert	a16ffd2976	Merge pull request #14999 from smoogipoo/fix-score-async ... Fix intermittent playlist results screen test failures	2021-10-11 10:44:04 +09:00
Dean Herbert	2eb29ed0de	Merge pull request #15021 from peppy/tournament-comma-separators ... Use comma separator for tournament score displays	2021-10-11 10:43:34 +09:00
Joehu	ce864011f2	Add ability to change ui scaling via keyboard	2021-10-10 13:13:26 -07:00
Bartłomiej Dach	b30dd2d4ed	Use rounded button in settings sidebar	2021-10-10 21:45:41 +02:00
Bartłomiej Dach	21ee24ea6d	Add rounded button variant	2021-10-10 21:45:41 +02:00
Dean Herbert	794b4c46cf	Split score counter class into two distinct classes to simplify usages	2021-10-10 17:56:32 +09:00
Dean Herbert	06cce0119c	Use localisable format string for comma separator mode	2021-10-10 17:41:16 +09:00
Dean Herbert	6d6de5b677	Remove redundant tuple naming	2021-10-10 16:50:55 +09:00
Dean Herbert	446f091d32	Use comma separator for tournament score displays	2021-10-10 16:06:12 +09:00
Dean Herbert	49a878dc20	Fix comma separator support not actually working	2021-10-10 16:06:05 +09:00
Dan Balasescu	8884091422	Merge pull request #15014 from joseph-ireland/remove-initial-strain ... Change initial strain value in skills from 1 to 0	2021-10-10 15:56:20 +09:00
smoogipoo	4475697a9c	Add score id key	2021-10-10 15:47:39 +09:00
smoogipoo	c49d0a5013	Rewrite query to be easier to understand	2021-10-10 15:43:24 +09:00
Dean Herbert	49b341daff	Remove HoverTarget shared state update path ... Felt quite convoluted to follow. Have just duplicated the single shared line instead.	2021-10-10 11:55:47 +09:00
Dean Herbert	ccc6d8ff40	Improve the animation of the active indicator	2021-10-10 11:34:01 +09:00
Bartłomiej Dach	fe26d8e8df	Share sidebar colouring logic by splitting out SidebarIconButton	2021-10-10 00:34:12 +02:00
Bartłomiej Dach	b8616bf910	Adjust appearance of keybinding subpanel	2021-10-10 00:34:12 +02:00
Bartłomiej Dach	855a74b8a0	Adjust vertical spacings in individual subsections	2021-10-10 00:34:11 +02:00
Bartłomiej Dach	e23a54f1e6	Adjust setting section appearance & spacings	2021-10-10 00:31:01 +02:00
Bartłomiej Dach	4c293b637f	Restyle settings panel header	2021-10-09 23:40:15 +02:00
Bartłomiej Dach	315581f4c8	Adjust horizontal spacing in settings panel	2021-10-09 23:40:15 +02:00
Bartłomiej Dach	f6df93f013	Introduce basic parts of colour scheme to settings sidebar	2021-10-09 23:40:14 +02:00
smoogipoo	bc37cb6f43	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-08 18:41:17 +09:00
Dan Balasescu	9be56829c9	Merge pull request #14935 from Susko3/fix-SettingsTextBox-using-null-as-default ... Fix usages of `SettingsTextBox` having `null` as the default	2021-10-08 18:36:02 +09:00
Dan Balasescu	67cfe3412e	Merge branch 'master' into random-seed-max-input-length	2021-10-08 15:38:42 +09:00
smoogipoo	b82ed3f167	Fix potential blocking operation on OrderByTotalScoreAsync() ... In reality this wouldn't be a long process, but the blocking is really noticeable if you add a Task.Delay(1000) in GetTotalScoreAsync().	2021-10-08 14:23:54 +09:00
Dean Herbert	9dc035757f	Fix weird textbox behaviour when entering a random mod seed overflowing int backing	2021-10-08 14:01:36 +09:00
Dean Herbert	2856aef4eb	Add exception to catch any incorrect defaults of Bindable<string>	2021-10-08 13:52:38 +09:00
Dean Herbert	436ead421a	Move low pass fail effect to FailAnimation	2021-10-08 12:27:04 +09:00
Dean Herbert	da96cc73d8	Fix dual specification of SuspensionHandler and move fields around slightly	2021-10-07 23:40:47 +09:00
Dean Herbert	9bf29503fb	Rename remaining usage	2021-10-07 20:57:14 +09:00
Dean Herbert	310d7965b6	Merge branch 'master' into more-filter-effects	2021-10-07 20:52:38 +09:00
Dan Balasescu	f8e50731b7	Merge pull request #14991 from peppy/intro-tests-no-menu-load ... Allow intro screens to be created without loading a `MainMenu`	2021-10-07 20:48:54 +09:00
Dean Herbert	ef64c64f0b	Merge branch 'master' into popup-filter-effect	2021-10-07 18:56:07 +09:00
Dean Herbert	e578046b20	Rename Filter -> AudioFilter	2021-10-07 18:50:08 +09:00
Dean Herbert	0348c6c7e5	Apply some renaming and code quality fixes	2021-10-07 18:49:22 +09:00
Dan Balasescu	bece807857	Merge pull request #14980 from peppy/difficulty-move-to-beatmap ... Copy `BaseDifficulty` to `Beatmap<T>` and move the majority of write operations across	2021-10-07 18:43:44 +09:00
Dean Herbert	f98dd1b811	Merge branch 'master' into popup-filter-effect	2021-10-07 18:40:21 +09:00
Jamie Taylor	f6458aa26d	Add filter effect to collection management dialog	2021-10-07 17:56:11 +09:00
Jamie Taylor	cc209f0f2d	Add filter effect to fail sequence	2021-10-07 17:55:30 +09:00
Jamie Taylor	5c48340520	Add filter effect to beatmap loading	2021-10-07 17:55:21 +09:00
Dean Herbert	ee66414e4f	Move difficulty copy inside context retrieval	2021-10-07 17:49:13 +09:00
Dan Balasescu	0e0779e45b	Merge pull request #14988 from peppy/remove-gameplay-mod-bindable-storage ... Remove local overridden storage of `Mods` in `Player`	2021-10-07 17:36:23 +09:00
Joseph Ireland	185bb9c122	change initial strain from 1 to 0 to allow simpler implementations	2021-10-07 09:30:18 +01:00
Dean Herbert	d3efec3c04	Remove unnecessary clone operations	2021-10-07 17:22:10 +09:00
Dean Herbert	7dd7d35fc8	Remove unnecessary difficulty copy operation	2021-10-07 17:19:34 +09:00
Dean Herbert	0df409c050	Move difficulty copy to BeatmapModelManager.Save	2021-10-07 17:16:45 +09:00
Dan Balasescu	d50443fdf2	Merge branch 'master' into difficulty-move-to-beatmap	2021-10-07 16:50:10 +09:00
Dean Herbert	d0001f760d	Group applicable comment above new addition	2021-10-07 16:50:05 +09:00
Dean Herbert	f88d898960	Allow intro screens to be created without loading a MainMenu	2021-10-07 16:38:22 +09:00
Dean Herbert	290c9755e2	Always use circles intro for OsuGame tests ... The triangles intro tracks video time, which is not adjusted based on the game's playback rate (ie. it runs in realtime even for headless tests). Maybe we want to make the triangles video adjust its rate along with tests?	2021-10-07 15:55:29 +09:00
Dean Herbert	a57b080f10	Avoid showing the disclaimer in game tests ... No real performance gain, but this is handy to bypass when actually using one of these tests to test something.	2021-10-07 15:55:15 +09:00
Dean Herbert	5f129ae33c	Remove local overridden storage of Mods in Player ... Not required and only causing headaches. Accessing mods should now be done via `GameplayState`. Closes #14912.	2021-10-07 14:53:39 +09:00
Dean Herbert	9705c7b546	Use cloned mods in one more place	2021-10-06 21:30:30 +09:00
Dean Herbert	433e7cd403	Fix rate mods not working if pp counter is displayed	2021-10-06 21:26:30 +09:00
Jamie Taylor	99fb86878e	Only detach filter on disposal if attached	2021-10-06 18:31:56 +09:00
Jamie Taylor	bd0c986144	Add asserts to ensure correct state when attaching/detaching the filter	2021-10-06 17:34:24 +09:00
Dean Herbert	4ca97bc60a	Merge branch 'master' into difficulty-move-to-beatmap	2021-10-06 16:14:21 +09:00
Dean Herbert	3803f2f462	Fix leaderboard potentially displaying the wrong scores ... Closes #14762. This class is ugly. I think the whole process should be clened up once we have correctly-scheduled `SynchronizationContext`s. There's not much saving it as long as all these interdispersed `Schedule`s around required.	2021-10-06 16:07:29 +09:00
Dean Herbert	222997f2b9	Copy difficulty settings back out to BeatmapInfo on editor changes	2021-10-06 15:19:26 +09:00
Dean Herbert	0ab8dcc2a0	Fix taiko weird difficulty multiplier failing on double convert	2021-10-06 15:18:06 +09:00
Dean Herbert	b339c149d8	Copy BaseDifficulty to Beatmap<T> and move all write operations across	2021-10-06 15:10:45 +09:00
Dan Balasescu	e6aa05a4a4	Merge pull request #14978 from peppy/fix-editor-file-selector-textbox-drags ... Fix dragging on an editor file selection text box causing repeated popover display	2021-10-06 13:52:08 +09:00
Dan Balasescu	80c8612630	Merge pull request #14977 from peppy/fix-working-beatmap-cache-invalidation ... Fix changes not being reflected immediately after exiting the editor	2021-10-06 13:51:21 +09:00
Dean Herbert	d9849bcf49	Fix dragging on an editor file selection text box causing repeated popover display ... Local fix and no tests as this is a pretty weird usage of `TextBox`. We'll probably want to change it to not use a textbox eventually. Closes #14969.	2021-10-06 13:15:05 +09:00
Dean Herbert	90fdaf18c0	Fix PushAndConfirm potentially failing if new screen quickly pushes a child screen	2021-10-06 12:55:04 +09:00
Dean Herbert	8ffaa491e7	Fix BeatmapModelManager not receiving WorkingBeatmapCache	2021-10-06 12:55:04 +09:00
Dean Herbert	007b33cd88	Add missing methods to interfaces	2021-10-06 12:55:04 +09:00
Dean Herbert	ffbb7a9b1a	Remove incorrect csproj change ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-10-06 12:22:32 +09:00
Dan Balasescu	e837a3511d	Merge branch 'master' into beatmap-difficulty-more-interface-usage	2021-10-06 12:18:51 +09:00
Jamie Taylor	266e62794e	Tweak cutoff effect for new Q value	2021-10-06 11:52:05 +09:00
Dan Balasescu	4bbff2ebf7	Merge branch 'master' into new-interfaces	2021-10-06 11:38:17 +09:00
Jamie Taylor	df182ba92b	Set fQ to recommended value from BASS developer to prevent filter calculations from overflowing when approaching nyquist	2021-10-06 11:29:03 +09:00
Dan Balasescu	9491e5a547	Merge pull request #14954 from peppy/rename-result-response ... Rename `APIRequest.Result` to `Response`	2021-10-06 10:52:33 +09:00
Dan Balasescu	007e5f174c	Merge pull request #14959 from peppy/add-screen-test-debug ... Add various logging output in an atttempt to figure multiplayer test failure	2021-10-06 10:11:50 +09:00
Dean Herbert	4f59fc15a5	Mark BeatmapSet as nullable for the time being	2021-10-06 05:54:37 +09:00
Dean Herbert	4d5696959b	Remove unnecessary access modifier in interface ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-10-06 05:52:28 +09:00
Dean Herbert	1f6a31355c	Remove unused using statement ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-06 05:30:49 +09:00
Dean Herbert	5a4474e1b2	Fix incorrect DI retrieval in ReplayDownloadButton	2021-10-06 05:29:00 +09:00
Dean Herbert	c23acb8f05	Merge pull request #14967 from bdach/fix-accidental-json-property-rename ... Fix "most played beatmap" request breakage after property rename	2021-10-06 05:00:12 +09:00
Bartłomiej Dach	baa8baaa1e	Fix "most played beatmap" request breakage after property rename	2021-10-05 21:17:19 +02:00
Bartłomiej Dach	a5b07ce4fe	Fix backwards containment check in chat channel load callback	2021-10-05 20:53:06 +02:00
Bartłomiej Dach	12da27cde7	Add test coverage for loading process on channel join	2021-10-05 20:52:40 +02:00
Dean Herbert	6f7b8293af	Merge pull request #14919 from smoogipoo/realtime-pp-display ... Implement real-time PP counter	2021-10-05 20:50:03 +09:00
Dean Herbert	98fef6ece2	Handle judgement reverts with actual display updates	2021-10-05 19:08:30 +09:00
Dean Herbert	5c62d3b6cb	Merge pull request #14907 from peppy/remove-local-realm-thread-switch-handling ... Remove local handling of realm when switching thread modes	2021-10-05 19:00:19 +09:00
Dean Herbert	e6efdae7c9	Add various logging output in an atttempt to figure multiplayer test failure	2021-10-05 18:53:20 +09:00
Dean Herbert	bd84a8b749	Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage	2021-10-05 18:21:21 +09:00
Dean Herbert	2be44188ef	Add missing null checks	2021-10-05 17:59:38 +09:00
Dean Herbert	0859c336de	Also dim counter during initial calculation phase	2021-10-05 17:24:36 +09:00
Dean Herbert	1e4da81120	Fix import notifications not showing correct text	2021-10-05 17:14:09 +09:00
Dean Herbert	f64226ded6	Fix display not displaying correctly after initial load	2021-10-05 17:10:32 +09:00
Dean Herbert	599d82e383	Avoid returning a live IEnumerable	2021-10-05 17:01:07 +09:00
Dean Herbert	fa7f11d906	Add easing to rolling counter value	2021-10-05 16:51:49 +09:00
Dean Herbert	565e888f58	Tidy up attribute retrieval code	2021-10-05 16:40:07 +09:00
smoogipoo	45b63cbad9	Remove unnecessary dependency	2021-10-05 16:03:25 +09:00
Dean Herbert	676df55a0e	Fade display out during rewind (as the value displayed is no longer valid)	2021-10-05 15:39:29 +09:00
Dean Herbert	81a13566bc	Adjust default location slightly, fix alignment of "pp" subtext	2021-10-05 15:28:03 +09:00
Dean Herbert	b6af93d434	Apply some code quality refactoring	2021-10-05 15:14:49 +09:00
Dean Herbert	7176dc95e5	Revert Player.Score to protected	2021-10-05 14:55:40 +09:00
Dean Herbert	e19be8ebe4	Make GameplayState.Score immutable	2021-10-05 14:55:40 +09:00
Dean Herbert	a5aa32811a	Remove null check suppression and add non-null fallback	2021-10-05 14:49:59 +09:00
Dean Herbert	d3b9660148	Move common interface implementations to extension methods	2021-10-05 14:41:14 +09:00
Dean Herbert	b41fa41c85	Rename APIRequest.Result to Response	2021-10-05 14:28:56 +09:00
smoogipoo	5624dd9af6	Fix incorrect CancellationToken usage ... Apparently I wrote the BDL system and don't know how this works. I believe you need `CancellationToken?` or CanBeNull=true, however that doesn't actually play well when actually using the token in code...	2021-10-05 12:07:41 +09:00
smoogipoo	593da79bbc	Further asyncify load process	2021-10-05 11:26:13 +09:00
smoogipoo	d120678e30	Fix redundant default value	2021-10-04 21:13:14 +09:00
smoogipoo	d1e7191f94	Pass score into GameplayState	2021-10-04 20:59:51 +09:00
smoogipoo	0b0316e27e	Fix missing CanBeNull	2021-10-04 20:59:31 +09:00
Dean Herbert	57c5be39d3	Merge branch 'master' into remove-local-realm-thread-switch-handling	2021-10-04 20:52:44 +09:00
Dean Herbert	1d99bc280f	Merge branch 'master' into new-interfaces	2021-10-04 20:42:40 +09:00
smoogipoo	1837e1bf3c	Share rounding with PerformanceStatistic	2021-10-04 20:35:53 +09:00
smoogipoo	fb63e5ed87	Add todo	2021-10-04 20:35:26 +09:00
smoogipoo	221cc1747c	Drop "default" prefix	2021-10-04 20:34:28 +09:00
smoogipoo	5aae673240	Use GameplayState	2021-10-04 20:33:54 +09:00
smoogipoo	2e3450b3f5	Make Mods readonly	2021-10-04 20:20:24 +09:00
smoogipoo	031c5a441e	Merge branch 'master' into realtime-pp-display	2021-10-04 20:19:37 +09:00
Dan Balasescu	4bd1083388	Merge pull request #14903 from peppy/importer-returns-live ... Add `ILive<T>` and use as return type of `Import` methods	2021-10-04 20:16:32 +09:00
smoogipoo	4871db2f86	Merge branch 'master' into importer-returns-live	2021-10-04 19:42:36 +09:00
Dean Herbert	853cf6feaa	Rename last remaining BeatmapInfo Beatmap usage	2021-10-04 17:35:53 +09:00
Dan Balasescu	5937a93e2d	Merge pull request #14949 from peppy/login-error-display ... Show login failure messages on login form	2021-10-04 17:23:11 +09:00
Dan Balasescu	c1540c137a	Merge pull request #14932 from peppy/rename-beatmap-info-beatmap-fields ... Rename `BeatmapInfo` variables which were named `beatmap` for clarity	2021-10-04 17:22:06 +09:00
Dean Herbert	6ac0601d2c	Fix incorrect csproj merge	2021-10-04 17:18:08 +09:00
Dean Herbert	ae5d1e8ac0	Merge branch 'master' into remove-local-realm-thread-switch-handling	2021-10-04 17:17:10 +09:00
Dean Herbert	95f1cc85d4	Update framework	2021-10-04 17:12:40 +09:00
Dean Herbert	f293e008d9	Move BeatmapInfo's SearchableTerms implementation to interface	2021-10-04 17:01:02 +09:00
Dean Herbert	51b7dce16f	Remove reference to osu-web-10	2021-10-04 16:55:51 +09:00
Dean Herbert	fd6b10656c	Add TODO reminder about ruleset reference transfer quirk	2021-10-04 16:55:16 +09:00
Dean Herbert	4df5f93152	Inline single usage of StoryboardFile to avoid interface default method woes	2021-10-04 16:55:02 +09:00
Dean Herbert	8bfdfe3672	Add literal string marker ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-04 16:54:00 +09:00
Dean Herbert	63f0b0c932	Rename out of place interface name	2021-10-04 16:35:55 +09:00
Dean Herbert	e631653f4b	Remove incorrectly committed FodyWeavers file	2021-10-04 16:30:12 +09:00
Dean Herbert	857000b756	Mark IPresentImports as covariant	2021-10-04 16:29:46 +09:00
Dean Herbert	3c15ef720f	Remove setter from IHasGuidPrimaryKey interface	2021-10-04 16:26:28 +09:00
Dean Herbert	916342c837	Merge branch 'master' into importer-returns-live	2021-10-04 16:24:26 +09:00
Dan Balasescu	aca2f0c12d	Merge pull request #14901 from peppy/model-importer-split ... Split importer interface out of `IModelManager`	2021-10-04 16:22:29 +09:00
Dean Herbert	3a0b7ba8ff	Add fallback to use Message when Hint is not available	2021-10-04 16:18:55 +09:00
smoogipoo	69c2b7dc59	Merge branch 'master' into rename-beatmap-info-beatmap-fields	2021-10-04 16:03:22 +09:00
Dan Balasescu	fd002da469	Merge pull request #14948 from peppy/fix-drawable-channel-ci-failures ... Ensure a `DrawableChannel` is not attempted to be added after disposal	2021-10-04 16:03:13 +09:00
smoogipoo	4e1322effa	Fix typo	2021-10-04 16:02:45 +09:00
Dan Balasescu	aa1bfc16d2	Merge pull request #14929 from peppy/gameplay-state ... Replace `GameplayBeatmap` with `GameplayState`	2021-10-04 15:56:44 +09:00
Dan Balasescu	d82829fad3	Merge pull request #14909 from peppy/realm-context-factory-safer-blocking ... Ensure realm blocks until all threaded usages are completed	2021-10-04 15:52:45 +09:00
Dean Herbert	266b4c7124	Expose login errors from IAPIProvider and show on the login form	2021-10-04 15:40:24 +09:00
Dean Herbert	5aaafce597	Make AuthenticateWithLogin throw instead of return a bool success status	2021-10-04 15:40:00 +09:00
smoogipoo	bc984dff4f	Fix typo	2021-10-04 15:35:28 +09:00
Dean Herbert	c19c2335ec	Remove added schedule due to changing flow	2021-10-04 14:58:54 +09:00
Dean Herbert	c6aba3e78b	Ensure a DrawableChannel is not attempted to be added after disposal	2021-10-04 14:44:16 +09:00
Dean Herbert	3d71576fbe	Merge pull request #14920 from smoogipoo/guard-skin-exception ... Guard against exception in skin deserialisation	2021-10-04 14:07:49 +09:00
Dean Herbert	c8419ebedb	Merge pull request #14946 from bdach/torus-alternate ... Add alternate Torus font	2021-10-04 11:47:11 +09:00
Dean Herbert	11e9c16b92	Update resources	2021-10-04 11:13:46 +09:00
Bartłomiej Dach	017756cbca	Use Torus alternates on online play screens as per design	2021-10-04 00:26:41 +02:00
Bartłomiej Dach	86240cc8ec	Add alternate Torus font	2021-10-03 23:36:39 +02:00
Bartłomiej Dach	83fa1be713	Merge branch 'master' into fix-keybinds-reset-search	2021-10-03 13:54:57 +02:00
Susko3	3e403cfe03	Add comment explaining the purpose of the empty FilterTerms	2021-10-02 19:16:46 +02:00
Bartłomiej Dach	f03cf87872	Merge branch 'master' into storyboard-fixes	2021-10-02 18:41:01 +02:00
Dean Herbert	ec61c3c5ee	Rename all remaining cases	2021-10-03 00:55:29 +09:00
Susko3	d55836c0b2	Make ResetButton no longer part of search filtering ... The button will now appear if and only if all the bindings in its section are visible (not filtered out by the search)	2021-10-02 15:10:30 +02:00
Dean Herbert	20e3f7fec4	Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage	2021-10-02 13:08:02 +09:00
Dean Herbert	973c31132b	Rename BeatmapInfo variables which were named beatmap for clarity	2021-10-02 12:45:34 +09:00
Dean Herbert	1be96b4292	Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.10'	2021-10-02 11:04:00 +09:00
Dean Herbert	fb6426d68d	Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.10'	2021-10-02 11:03:30 +09:00
dependabot[bot]	cb8165ca50	Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.9 to 5.0.10. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.9...v5.0.10) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-02 00:59:32 +00:00
dependabot[bot]	f60f712bcc	Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.9 to 5.0.10. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.9...v5.0.10) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-02 00:59:32 +00:00
dependabot[bot]	9517d69f21	Bump MessagePack from 2.3.75 to 2.3.85 ... Bumps [MessagePack](https://github.com/neuecc/MessagePack-CSharp) from 2.3.75 to 2.3.85. - [Release notes](https://github.com/neuecc/MessagePack-CSharp/releases) - [Changelog](https://github.com/neuecc/MessagePack-CSharp/blob/master/prepare_release.ps1) - [Commits](https://github.com/neuecc/MessagePack-CSharp/compare/v2.3.75...v2.3.85) --- updated-dependencies: - dependency-name: MessagePack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-02 00:59:31 +00:00
dependabot[bot]	5ea51f4a9f	Bump Sentry from 3.9.0 to 3.9.4 ... Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.9.0 to 3.9.4. - [Release notes](https://github.com/getsentry/sentry-dotnet/releases) - [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.9.0...3.9.4) --- updated-dependencies: - dependency-name: Sentry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-01 18:15:07 +00:00
Dean Herbert	bea310007f	Merge pull request #14922 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.10 ... Bump Microsoft.AspNetCore.SignalR.Client from 5.0.9 to 5.0.10	2021-10-02 03:12:14 +09:00
Dean Herbert	ea1e09837e	Merge pull request #14923 from ppy/dependabot/nuget/HtmlAgilityPack-1.11.37 ... Bump HtmlAgilityPack from 1.11.36 to 1.11.37	2021-10-02 03:11:52 +09:00
Dean Herbert	dcd7d7a709	Add JsonIgnore rule for StoryboardFile ... Not sure why this is required, doesn't make much sense.	2021-10-02 03:05:06 +09:00
Dean Herbert	7e009f6168	Add full xmldoc	2021-10-02 02:31:41 +09:00
Dean Herbert	32afd3f426	Replace all basic usages	2021-10-02 02:22:23 +09:00
Dean Herbert	05ca3aec4f	Rename GameplayState to SpectatorGameplayState	2021-10-02 02:10:11 +09:00
dependabot[bot]	6de4e981dd	Bump Realm from 10.5.0 to 10.6.0 ... Bumps [Realm](https://github.com/realm/realm-dotnet) from 10.5.0 to 10.6.0. - [Release notes](https://github.com/realm/realm-dotnet/releases) - [Changelog](https://github.com/realm/realm-dotnet/blob/master/CHANGELOG.md) - [Commits](https://github.com/realm/realm-dotnet/compare/10.5.0...10.6.0) --- updated-dependencies: - dependency-name: Realm dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-01 17:01:37 +00:00
dependabot[bot]	323a9a748d	Bump HtmlAgilityPack from 1.11.36 to 1.11.37 ... Bumps [HtmlAgilityPack](https://github.com/zzzprojects/html-agility-pack) from 1.11.36 to 1.11.37. - [Release notes](https://github.com/zzzprojects/html-agility-pack/releases) - [Commits](https://github.com/zzzprojects/html-agility-pack/compare/v1.11.36...v1.11.37) --- updated-dependencies: - dependency-name: HtmlAgilityPack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-01 17:01:32 +00:00
dependabot[bot]	1eb67dc594	Bump Microsoft.AspNetCore.SignalR.Client from 5.0.9 to 5.0.10 ... Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.9 to 5.0.10. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.9...v5.0.10) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Client dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-10-01 17:01:28 +00:00
Jamie Taylor	2a4a376b87	Refactor Filter to behave closer to a Transformable	2021-10-02 01:32:47 +09:00
Dean Herbert	d6dbdc911f	Merge branch 'master' into storyboard-fixes	2021-10-02 00:35:51 +09:00
Dean Herbert	682fe5be78	Merge branch 'master' into realm-context-factory-safer-blocking	2021-10-02 00:30:09 +09:00
Dean Herbert	b1f9bbdc69	Merge branch 'master' into model-importer-split	2021-10-02 00:29:29 +09:00
Dan Balasescu	a620b55d55	Merge pull request #14900 from peppy/model-downloader-split ... Split `ArchiveModelManager` into two pieces	2021-10-01 23:16:09 +09:00
Dan Balasescu	d24f89fead	Merge pull request #14906 from peppy/update-realm-context-factory ... Refine `RealmContext` implementation	2021-10-01 22:57:03 +09:00
Dan Balasescu	6a172d54d5	Merge branch 'master' into model-downloader-split	2021-10-01 22:34:39 +09:00
Dean Herbert	a32f5d44e2	Improve clarity of xmldoc ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-10-01 22:23:51 +09:00
smoogipoo	adff418fd2	Guard against exception in skin deserialisation	2021-10-01 22:17:38 +09:00
Dan Balasescu	154c412f34	Merge branch 'master' into beatmap-manager-split	2021-10-01 21:46:27 +09:00
smoogipoo	0ee148b53f	Extra guard against no attributes	2021-10-01 21:31:26 +09:00
smoogipoo	a1f880a36a	Split classes	2021-10-01 21:00:39 +09:00
smoogipoo	d0081908c5	Make Score internal	2021-10-01 20:52:48 +09:00
smoogipoo	98badd644f	Add xmldocs	2021-10-01 20:09:39 +09:00
smoogipoo	5820a71652	Fix mania difficulty calculator crashing	2021-10-01 19:57:45 +09:00
Dean Herbert	4c28749d73	Fix incorrect legacy decoder usage	2021-10-01 19:05:08 +09:00
Dean Herbert	3faafd7200	Rename parameter to repeatCount and add guards	2021-10-01 18:26:29 +09:00
Dean Herbert	59bd13c154	Merge branch 'master' into slider-timeline-velcotiy-adjust-v2	2021-10-01 17:47:00 +09:00
Dean Herbert	ac471a0ec1	Merge branch 'no-more-difficulty-control-points-info' into slider-timeline-velcotiy-adjust-v2	2021-10-01 17:46:58 +09:00
Dean Herbert	0daf8937e3	Add missing xmldoc	2021-10-01 17:36:44 +09:00
Dean Herbert	d6618a99a3	Redirect more methods to interface implementations	2021-10-01 17:36:44 +09:00
Dean Herbert	9dae92e78c	Add missing backlink to BeatmapSet from Beatmap and fix non-explicit implementations	2021-10-01 17:22:25 +09:00
Dean Herbert	00e33a1da7	Fix incorrect OnlineID mappings	2021-10-01 17:06:09 +09:00
Dean Herbert	05996cc2e9	Add changes that got forgotted in branch surgery	2021-10-01 17:04:53 +09:00
Dean Herbert	a92d499d7a	Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo	2021-10-01 16:55:50 +09:00
Dean Herbert	8595eb2d11	Switch BeatmapDifficulty usages to use interface type	2021-10-01 16:55:50 +09:00
Dean Herbert	d309636460	Update all EF based models to implement new read only interfaces	2021-10-01 16:55:50 +09:00
Dean Herbert	619dfe0690	Add new interface base types for models	2021-10-01 16:55:47 +09:00
smoogipoo	36be041846	Merge branch 'master' into realtime-pp-display	2021-10-01 13:28:38 +09:00
Dean Herbert	74841cf1a9	Merge branch 'update-realm-context-factory' into realm-context-factory-safer-blocking	2021-10-01 03:54:31 +09:00
Dean Herbert	b51fd00ba3	Guard against disposal in all context retrievals	2021-10-01 03:46:53 +09:00
Dean Herbert	8557530cd5	Add back main context locking	2021-10-01 03:45:00 +09:00
Dean Herbert	c71cf1e220	Fix incomplete xmldoc	2021-10-01 01:51:31 +09:00
Dean Herbert	3ddb348252	Merge branch 'online-lookup-cache-separation' into beatmap-manager-split	2021-10-01 01:49:31 +09:00
Dean Herbert	2ed28f625a	Pass whole queue in rather than function	2021-10-01 01:46:37 +09:00
Dean Herbert	428c7830d9	Pass online lookup queue in as a whole, rather than function	2021-10-01 01:45:21 +09:00
Dean Herbert	27c4f2b06e	Add missing disposal	2021-10-01 01:38:50 +09:00
Dean Herbert	dde19f2e81	Fix unbalanced brackets ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-01 01:37:51 +09:00
Dean Herbert	cfd3bdf888	Ensure realm blocks until all threaded usages are completed	2021-10-01 01:34:35 +09:00
Dean Herbert	38cd383aaf	Remove local handling of realm when switching thread modes	2021-10-01 00:27:54 +09:00
Dean Herbert	9fa901f6aa	Refine RealmContext implementation API	2021-09-30 23:56:38 +09:00
Dean Herbert	a2e61883e3	Initial push to use ILive in import process	2021-09-30 22:55:25 +09:00
Dean Herbert	66409147dc	Remove duplicate interface specification	2021-09-30 19:25:08 +09:00
Dean Herbert	c05a8fc4a2	Split importer interface out of IModelManager	2021-09-30 18:52:09 +09:00
Dean Herbert	3e3b9bc963	Split out IModelDownloader and also split apart ScoreManager	2021-09-30 18:25:20 +09:00
Dean Herbert	0a00bc7795	Split out IPostNotifications into an interface	2021-09-30 18:21:34 +09:00
Dean Herbert	fd13142a15	Add missing interface to BeatmapManager	2021-09-30 18:21:24 +09:00
smoogipoo	fab0d531be	Add counter to HUD	2021-09-30 17:55:00 +09:00
smoogipoo	4d8418e072	Fix possible nullrefs	2021-09-30 17:54:56 +09:00
smoogipoo	d2a8f35b4c	Update styling	2021-09-30 17:54:52 +09:00
Dean Herbert	7a72747d88	Add back optional online lookups	2021-09-30 17:18:39 +09:00
Dean Herbert	90225f2082	Hook up all required interfaces to new BeatmapManager	2021-09-30 17:18:39 +09:00
smoogipoo	84bddf0885	Initial PP counter implementation	2021-09-30 17:00:24 +09:00
Dean Herbert	5618c9933b	Expose more pieces of ArchiveModelManager via interfaces	2021-09-30 16:44:39 +09:00
Dean Herbert	d21139b03e	Split out database portion from BeatmapManager	2021-09-30 15:43:49 +09:00
Dean Herbert	e7e0473323	Split out WorkingBeatmapCache from BeatmapManager	2021-09-30 15:40:41 +09:00
Jamie Taylor	968826c9e7	Fix typo	2021-09-30 15:17:39 +09:00
Dean Herbert	8a6501fa58	Add basic component level xmldoc	2021-09-30 14:46:07 +09:00
Dean Herbert	6ffd9fdcfa	Split out BeatmapOnlineLookupQueue from BeatmapManager	2021-09-30 14:46:01 +09:00
Dean Herbert	b8b61a196f	Merge pull request #14891 from smoogipoo/mp-currently-playing-map ... Add currently playing map to multiplayer lounge	2021-09-30 14:22:07 +09:00
smoogipoo	816018edb7	Move hosted by text into nullcheck	2021-09-30 12:04:30 +09:00
smoogipoo	202a602d2f	Change default status to "ready to play"	2021-09-30 12:03:44 +09:00
smoogipoo	ea30445efc	Remove verbatim string	2021-09-30 12:03:34 +09:00
smoogipoo	619a907c47	Fix zero height grid	2021-09-30 12:01:26 +09:00
smoogipoo	56b3c8aa9a	Remove forgotten text	2021-09-30 11:52:14 +09:00
Jamie Taylor	f55c4ac640	IsLoaded check no longer required	2021-09-29 21:05:46 +09:00
smoogipoo	c83dd7d2b6	Merge OnlinePlayComposite and RoomSubScreenComposite	2021-09-29 20:55:20 +09:00
Jamie Taylor	4d91204faf	Pause Editor sample playback while popup dialog is shown	2021-09-29 20:46:41 +09:00
smoogipoo	c9c2d20544	Limit max size	2021-09-29 20:44:38 +09:00
Jamie Taylor	2608d193a9	Refactor Filter component to be more re-usable	2021-09-29 20:30:01 +09:00
Jamie Taylor	94e2dbd7e7	Add a low-pass filter effect to music when certain popup dialogs are shown	2021-09-29 20:30:00 +09:00
smoogipoo	67d847fbd3	Add room status text to DrawableRoom	2021-09-29 20:24:49 +09:00
smoogipoo	5f921c7836	Change SelectedItem to show the last item by default	2021-09-29 20:24:32 +09:00
smoogipoo	d89577b2e7	Add host to DrawableRoomParticipantsList	2021-09-29 19:34:40 +09:00
smoogipoo	73ee82ee2b	Rename RecentParticipantsList -> DrawableRoomParticipantsList	2021-09-29 19:15:58 +09:00
Dean Herbert	7914daaef0	Remove unused using	2021-09-29 19:09:48 +09:00
Dean Herbert	4fd19cbb0d	Use null check instead of assert in Hide() due to public exposure	2021-09-29 18:58:43 +09:00
Dean Herbert	c5b7e97bd9	Fix skin editor potentially crashing during close process ... As reported at https://github.com/ppy/osu/discussions/14850#discussioncomment-1399382.	2021-09-29 18:53:49 +09:00
Dan Balasescu	754c56d7ae	Merge branch 'master' into move-startup-concurrency-check	2021-09-29 17:20:20 +09:00
Dan Balasescu	ce3cf72a77	Merge pull request #14888 from peppy/rename-json-key-resolver ... Rename JSON key resolver to better expose what it's doing	2021-09-29 16:58:42 +09:00
Dean Herbert	dcf87e97c2	Update framework	2021-09-29 14:03:41 +09:00
Dean Herbert	117d47bf7f	Rename JSON key resolver to better expose what it's doing	2021-09-29 11:26:37 +09:00
Sebastian Krajewski	f148fbcc94	Cap LoopCount to at least 1	2021-09-29 00:59:08 +02:00
Dan Balasescu	625711e6d2	Merge pull request #14776 from peppy/fix-pause-with-audio-offset ... Avoid accounting for the pause pitch adjust effect when "fixing" hardware offset adjustments	2021-09-28 18:44:22 +09:00
Dean Herbert	46bafb6252	Merge branch 'master' into no-more-difficulty-control-points-info	2021-09-28 13:53:56 +09:00
Bartłomiej Dach	ca6cbca04a	Fix range selection crashing after non-mouse selection	2021-09-27 20:54:29 +02:00
Dean Herbert	bcdbffbca0	Update framework	2021-09-27 20:56:54 +09:00
Dean Herbert	d4310f5d9a	Move database connection string operations local ... In line with framework changes in https://github.com/ppy/osu-framework/pull/4793.	2021-09-27 17:32:41 +09:00
Dean Herbert	df85092426	Resolve inner items early in process and rename variable	2021-09-27 14:24:17 +09:00
Dean Herbert	41fb3371e5	Merge branch 'master' into blueprint-container-sorting	2021-09-27 14:12:09 +09:00
Dean Herbert	5466fb08fd	Merge branch 'master' into timeline-shift-click-selection	2021-09-27 13:40:39 +09:00
Bartłomiej Dach	d3203f83dd	Add implementation of range selection	2021-09-26 20:12:26 +02:00
Bartłomiej Dach	81d160c85a	Add test covering expected UX of range selection	2021-09-26 19:27:47 +02:00
Bartłomiej Dach	6dc3e66c93	Include combo information when determining ordering if available	2021-09-26 15:52:25 +02:00
Bartłomiej Dach	a86b9893ac	Always re-sort blueprints before adding/removing one	2021-09-26 15:48:56 +02:00
Bartłomiej Dach	a66d48dbad	Merge branch 'master' into diffcalc-optimisations	2021-09-26 14:46:50 +02:00
Joseph Madamba	9b9c30c8a1	Fix text overflowing on dropdown headers	2021-09-24 22:04:45 -07:00
Dean Herbert	ad6c4e3878	Update framework	2021-09-24 12:46:46 +09:00
Dean Herbert	6b698047ab	Fix DialogOverlay potentially not expiring dialogs as soon as it should	2021-09-23 19:19:03 +09:00
Dean Herbert	60c9e9f704	Merge pull request #14805 from bdach/rectangular-snap-grid ... Add rectangular snap grid to osu! editor composer	2021-09-22 00:12:03 +09:00
Dean Herbert	3b174a71a3	Move startup concurrency check to higher level ... Makes more sense to perform this check outside of the game itself now that we can.	2021-09-21 18:00:55 +09:00
Dan Balasescu	ffdaf23329	Merge pull request #14814 from peppy/fix-key-counter-masking ... Fix `KeyCounterDisplay` potentially getting stuck invisible due to autosize masking	2021-09-21 16:21:38 +09:00
smoogipoo	6246bbc262	Also add to ParticleExplosion	2021-09-21 14:37:09 +09:00
smoogipoo	bad3f0b1e9	Disable FtB pass for particle spewer	2021-09-21 14:25:44 +09:00
Dean Herbert	8584c0b6da	Merge branch 'master' into diffcalc-optimisations	2021-09-21 14:22:42 +09:00
Dean Herbert	add8aac6d5	Merge pull request #14815 from ppy/dependabot/nuget/osu.Game/SharpCompress-0.29.0 ... Bump SharpCompress from 0.28.3 to 0.29.0 in /osu.Game	2021-09-21 14:05:21 +09:00
Bartłomiej Dach	761548e533	Merge branch 'master' into 14470-ur-not-updating	2021-09-20 22:07:33 +02:00
dependabot[bot]	b715b89edc	Bump SharpCompress from 0.28.3 to 0.29.0 in /osu.Game ... Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.28.3 to 0.29.0. - [Release notes](https://github.com/adamhathcock/sharpcompress/releases) - [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.28.3...0.29) --- updated-dependencies: - dependency-name: SharpCompress dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-20 19:54:05 +00:00
sh0ckR6	fb416c79e9	Fully revert Player	2021-09-20 15:01:03 -04:00
Dean Herbert	a3464c98a7	Fix KeyCounterDisplay potentially getting stuck invisible due to autosize masking ... Closes #14793.	2021-09-20 23:52:01 +09:00
sh0ckR6	9a1db04920	Resolve GameplayClockContainer instead of Player	2021-09-20 10:28:58 -04:00
sh0ckR6	36a20ab0b3	Resolve failed test compilation	2021-09-20 10:26:07 -04:00
sh0ckR6	10fe2382b0	Address most issues	2021-09-20 10:07:42 -04:00
Dean Herbert	7812c33ddd	Merge branch 'master' into add-legacy-star-particles	2021-09-20 18:15:12 +09:00
Dean Herbert	cdef6d0cf5	Add key binding support for grid mode cycle	2021-09-20 16:43:15 +09:00
Dean Herbert	d96d1b3e47	Update framework	2021-09-20 15:09:27 +09:00
Dean Herbert	16e60eed56	Reduce NestedHitObject enumerator overhead ... This was especially bad due to it allocating on any and every start time change, even the first (see usage in `HitObject.ctor`).	2021-09-20 15:09:27 +09:00
Bartłomiej Dach	ab213e2010	Add missing licence headers	2021-09-19 21:09:03 +02:00
Bartłomiej Dach	4e094b2127	Implement grid size toggling matching stable	2021-09-19 20:26:02 +02:00
Bartłomiej Dach	56e80a0706	Add rectangular position snap grid	2021-09-19 18:07:19 +02:00
Opelkuh	9c90dd539f	Use Interpolation.Lerp	2021-09-19 15:06:15 +02:00
Opelkuh	0b593fac5c	Scope down DrawNode's source parameter	2021-09-19 14:49:09 +02:00
Opelkuh	d5a10e9221	Fix particles not spawning if Time.Current is negative	2021-09-19 14:47:20 +02:00
Opelkuh	761da45f6a	Revert af4c3727d77a16e2534df9bbf452336b5c544342	2021-09-19 14:00:56 +02:00
Opelkuh	1d7d779f66	Merge branch 'master' into add-legacy-star-particles	2021-09-19 04:34:35 +02:00
Opelkuh	3f8454cb76	Remove abstract from ParticleSpewer	2021-09-19 03:19:16 +02:00
Opelkuh	ef530ed87c	Normalize particle velocity based on max duration	2021-09-18 23:45:58 +02:00
Opelkuh	846cde53b3	Add RelativePositionAxes support	2021-09-18 22:54:12 +02:00
sh0ckR6	04715a5471	Add null-check when invoking OnSeek	2021-09-18 12:20:36 -04:00
sh0ckR6	f6e279baa1	Add xmldoc to HitErrorMeter.Clear ... Explains how the method is called and what inheritors should do when implementing it.	2021-09-18 12:18:11 -04:00
sh0ckR6	12cc16c598	Remove unused property in SongProgress	2021-09-18 12:05:06 -04:00
Bartłomiej Dach	80197bae48	Revert not decoding legacy difficulty points on scrolling rulesets for now	2021-09-18 15:32:08 +02:00
Bartłomiej Dach	76ccdd1340	Collect and sort points from nested objects before extracting	2021-09-18 14:38:38 +02:00
Bartłomiej Dach	8026968939	Move difficulty -> effect point conversion back to decoder	2021-09-18 14:38:38 +02:00
Dean Herbert	801bee7c47	Merge pull request #14785 from nekodex/wrong-password ... Add audio feedback for incorrect multiplayer room password	2021-09-18 12:02:33 +09:00
sh0ckR6	b2b3108afa	Resolve addressed issues ... + Stopped using testing methods in non-testing classes + Resolve Player and add OnSeek event + Take bindings away from BarHitErrorMeter + Add support for ColourHitErrorMeter	2021-09-17 16:19:41 -04:00
Dean Herbert	cc11532d9b	Update resources	2021-09-18 03:08:42 +09:00
Jamie Taylor	f868feae44	Remove unnecessary Schedule	2021-09-17 21:12:39 +09:00
Jamie Taylor	9485323a13	Add audio feedback for incorrect MP room password	2021-09-17 20:52:13 +09:00
Dean Herbert	7ea55b2cee	Merge branch 'master' into fix-taiko-fl	2021-09-17 19:15:20 +09:00
Dean Herbert	a743a3f306	Change combo bind logic to be non-weird	2021-09-17 19:15:14 +09:00
Dan Balasescu	90f1592d15	Merge pull request #14783 from peppy/login-feedback ... Move login panel related files to own namespace and tidy up class nesting	2021-09-17 19:02:23 +09:00
Dan Balasescu	a591fffdbd	Merge pull request #14782 from peppy/refocus-textbox-on-failed-password ... Refocus the multiplayer password entry textbox on failed join	2021-09-17 18:59:09 +09:00
smoogipoo	2d39131202	Refactor taiko flashlight a bit	2021-09-17 18:41:03 +09:00
Dean Herbert	50f155e4b9	Move login panel related files to own namespace and tidy up class nesting	2021-09-17 18:34:16 +09:00
Dean Herbert	027912d4f6	Refocus the multiplayer password entry textbox on failed join	2021-09-17 18:25:25 +09:00
Dean Herbert	1c8e17cf11	Fix the default background parallax being set incorrectly when no screen is present	2021-09-17 18:14:39 +09:00
Dean Herbert	5f27f1c099	Avoid accounting for the pause pitch adjust effect when "fixing" hardware offset adjustments ... Bit of an unfortunate one. Because we are applying the pitch adjustment to the lowest level (`Track`), it's hard to filter out in parent clock calculations. Tried a few solutions but this feels the best. Note that we can't just undo the `pauseFreqAdjust` adjustment as it will div-by-zero. Closes https://github.com/ppy/osu/issues/14773.	2021-09-17 15:43:38 +09:00
Dan Balasescu	24105debce	Merge branch 'master' into fix-skin-editor-masking	2021-09-17 13:54:24 +09:00
Dean Herbert	1b13b74740	Fix skin editor potentially leaving game-wide masking in the wrong state ... Just going with the simplest way to solve this. Closes https://github.com/ppy/osu/issues/14769.	2021-09-17 13:48:20 +09:00
Dean Herbert	f524e913e1	Move AllowTrackAdjustments specification to RoomSubScreen	2021-09-17 13:24:01 +09:00
Dean Herbert	cd4ba71a6b	Revert "Merge pull request #14772 from Joehuu/lounge-disallow-track-adj" ... This reverts commit 06ff4838fb, reversing changes made to 5453ea0ce9.	2021-09-17 13:22:39 +09:00
Joseph Madamba	55feb47e61	Disallow track adjustments on playlists / multi lounge	2021-09-16 20:17:21 -07:00
Joseph Madamba	2983d54682	Fix wiki main page blurb overflowing at higher ui scale	2021-09-16 17:32:23 -07:00
Dean Herbert	6b43e955be	Merge branch 'limit-max-triangles' into update-framework	2021-09-16 22:49:50 +09:00
Dean Herbert	fde7c88999	Merge branch 'master' into update-framework	2021-09-16 22:49:02 +09:00
Dean Herbert	edb1230111	Fix potential nullref throw on failed startup	2021-09-16 22:48:09 +09:00
Dean Herbert	b399f910e4	Merge branch 'fix-osu-game-test-scene' into update-framework	2021-09-16 22:46:52 +09:00
Dean Herbert	a1d33c1a46	Update framework	2021-09-16 22:38:19 +09:00
Dean Herbert	df786afb24	Merge pull request #14763 from kj415j45/localisation-settings-GlobalAction ... Add localisation for Settings-KeyBindings-GlobalActions	2021-09-16 21:08:00 +09:00
kj415j45	a18fed0da4	Remove unused using	2021-09-16 17:38:33 +08:00
smoogipoo	4b5857c876	Merge branch 'baseline-changes-update' into update-framework	2021-09-16 18:34:22 +09:00
smoogipoo	e8dea0138c	Fix one more issue	2021-09-16 18:34:13 +09:00
smoogipoo	f9d5abff8a	Update with keybinding changes	2021-09-16 18:26:12 +09:00
kj415j45	e323f10cd5	Remove unused [Description]	2021-09-16 17:10:29 +08:00
kj415j45	51997fa533	Add localisation for GlobalActions	2021-09-16 16:02:04 +08:00
Dean Herbert	9127a706ac	Use private for internally used property	2021-09-16 16:54:56 +09:00
Dean Herbert	2df4073946	SpawnParticle -> CreateParticle (and set time outside of virtual call) ... Allows easier overriding (no need to call the `base.CreateParticle` call and worry about overwriting the time value.	2021-09-16 16:52:46 +09:00
Dean Herbert	da0667365b	Merge branch 'master' into inheritable-allow-track-adjust	2021-09-16 16:35:11 +09:00
Dean Herbert	6f2d818b64	Merge pull request #14740 from smoogipoo/mania-note-animations ... Add animation support for mania notes	2021-09-16 16:34:53 +09:00
Dean Herbert	3495fae519	Handle potential for OnResuming call without an OnSuspending first	2021-09-16 16:31:41 +09:00
Dean Herbert	b58415fe19	Make suspend stored state nullable to ensure we don't break it	2021-09-16 16:12:14 +09:00
Dean Herbert	fa693bb8a8	Move MusicController adjustment set to inside OsuScreen itself (and result nullable)	2021-09-16 16:08:09 +09:00
Dan Balasescu	43379a2eaa	Merge pull request #14752 from peppy/realm-settings ... Move (ruleset) settings to realm	2021-09-16 14:05:41 +09:00
Dean Herbert	4d4a9b86c1	Merge branch 'master' into mania-note-animations	2021-09-16 11:12:07 +09:00
AbstractQbit	318f0941ca	Move all the "inherit previous AllowTrackAdjustments" logic into OsuScreen	2021-09-15 21:25:39 +03:00
Dean Herbert	931e873a7e	Merge branch 'master' into inheritable-allow-track-adjust	2021-09-15 22:26:13 +09:00
AbstractQbit	f0439ef50b	Remove unnecessary AllowTrackAdjustments overrides, add true to SongSelect	2021-09-15 13:12:57 +03:00
Dean Herbert	8acfefed1b	Merge pull request #14741 from smoogipoo/fix-lounge-beatmaps-counter ... Fix incorrect beatmap count and SR range in multi lounge	2021-09-15 18:51:52 +09:00
Dean Herbert	07fec268c0	Limit maximum triangles to avoid GL buffer overflow	2021-09-15 18:32:59 +09:00
AbstractQbit	1181317c72	Fix issues found by code quality ci	2021-09-15 12:01:56 +03:00
Dean Herbert	4f1db5af40	Attach migration memo to DatabasedSetting class for visibility	2021-09-15 17:25:07 +09:00
Dean Herbert	a1d325cb22	Mark key and value non-nullable (at realm end) and simplify Value logic	2021-09-15 17:16:05 +09:00
Dean Herbert	a150fb2996	Add nullability directive and make variant non-nullable	2021-09-15 17:16:05 +09:00
Dean Herbert	15e3f95c87	Remove remnants of DatabasedSetting from SkinInfo ... This was never used	2021-09-15 17:12:04 +09:00
Dean Herbert	dcfe9c67e3	Make ruleset id non-nullable	2021-09-15 17:12:04 +09:00
Dean Herbert	80ecf81be3	Rename all databased setting classes to be specific to rulesets for now	2021-09-15 17:12:04 +09:00
Dean Herbert	520e550764	Bring back SettingsStore to avoid changing ruleset API for now ... Also fixes some remaining test failures due to locally constructed rulesets that are not being tracked by the game.	2021-09-15 17:12:02 +09:00
Dean Herbert	c36a67d06e	Fix some tests failing due to using a locally constructed ruleset	2021-09-15 17:04:38 +09:00
Dean Herbert	5bb741b4e8	Remove migration of key bindings	2021-09-15 17:04:38 +09:00
smoogipoo	f54d554d30	Extract removal to method	2021-09-15 17:03:28 +09:00
AbstractQbit	48cf98ef93	Rephrase null meaning in IOsuScreen.AllowTrackAdjustments ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-09-15 11:00:49 +03:00
AbstractQbit	b87af3dd68	Move the inherited AllowTrackAdjustments into OsuScreen	2021-09-15 10:55:16 +03:00
Dean Herbert	2bcb3fd304	Add migration of existing settings	2021-09-15 16:31:13 +09:00
Dean Herbert	ac377a2e3c	Remove unused SettingsStore	2021-09-15 16:31:13 +09:00
Dean Herbert	a2f1752344	Make settings works with current caching structure ... Will likely pull out that `RulesetConfigCache` next, but this is an "everything works" state.	2021-09-15 16:31:13 +09:00
Dean Herbert	14314476f0	Update realm to latest version	2021-09-15 16:22:14 +09:00
Dean Herbert	187c557ea8	Begin migrating settings implementation across to realm	2021-09-15 16:22:14 +09:00
Salman Ahmed	8217b90b1c	Consider legacy glyph texture heights as the baselines for simplicity ... Mixing `LegacySpriteText` with legitment fonts should never be the case, so it's fine to consuder the height as the baseline, since there's really no other way around it.	2021-09-15 09:14:47 +03:00
Dean Herbert	623377772c	Merge branch 'master' into fix-spectator-random-mod	2021-09-15 13:55:28 +09:00
Dean Herbert	1ba716d9f1	Merge pull request #14737 from bdach/editor-difficulty-switch-shared-state ... Preserve current time and clipboard contents when switching between difficulties	2021-09-15 12:38:56 +09:00
Dan Balasescu	5ea1924c30	Merge branch 'master' into display-sr-changes	2021-09-15 10:22:11 +09:00
Bartłomiej Dach	7b9e501fa0	Merge branch 'master' into 14421-multi-password-error-handling	2021-09-14 22:58:20 +02:00
Bartłomiej Dach	baf9961934	Amend xmldoc of shake extension method	2021-09-14 22:50:45 +02:00
AbstractQbit	bd18c581c1	Replace allowTrackAdjustmentsStack with a Dictionary	2021-09-14 21:14:24 +03:00
AbstractQbit	01d2f4f17a	Make allowTrackAdjustmentsStack readonly	2021-09-14 18:04:43 +03:00
Dean Herbert	13f88cbc4e	Fix EditorClock retaining a reference to potentially outdated ControlPointInfo	2021-09-14 23:56:57 +09:00
AbstractQbit	b9193aae6d	Make IOsuScreen.AllowTrackAdjustments nullable ... Allows for inheriting value from the previous screen if undefined	2021-09-14 17:37:57 +03:00
Dean Herbert	57f8ccca16	Remove nullability from EditorState properties ... Also update the xmldoc to not be specific to difficulty switching	2021-09-14 23:36:28 +09:00
Dean Herbert	f8bdca542d	Make restoring state a public call on Editor	2021-09-14 23:36:17 +09:00
Dean Herbert	2a894e7a3f	Make EditorLoader state private	2021-09-14 23:26:02 +09:00
Dean Herbert	563bf92529	Also update the full object on sample changes to make them apply immediately	2021-09-14 19:21:23 +09:00
Dean Herbert	d825da3983	Add note about a better way to adjust velocity	2021-09-14 18:54:29 +09:00
Dean Herbert	e4dd59aee2	Add popovers to adjust SV and samples from the timeline	2021-09-14 18:51:22 +09:00
Dean Herbert	9d17f84681	Adjust timeline height to account for less global control points	2021-09-14 18:51:11 +09:00
Dean Herbert	9551e77553	Remove difficulty and sample sections from timing screen	2021-09-14 18:51:11 +09:00
Dean Herbert	87cfcf706e	Add ability to change slider velocity with shift-drag	2021-09-14 18:26:17 +09:00
Dean Herbert	b19dc5e41f	Remove all legacy ControlPoints when entering the editor	2021-09-14 18:26:16 +09:00
Dean Herbert	6015b5037a	Display difficulty and sample control points associated with hitobjects	2021-09-14 18:26:16 +09:00
smoogipoo	a775915338	Fix incorrect beatmap count and SR range in multi lounge	2021-09-14 18:20:28 +09:00
smoogipoo	63aa3ddcba	Add animation support for mania notes	2021-09-14 17:45:23 +09:00
smoogipoo	b807c161b4	Remove now-unused DI params	2021-09-14 17:25:57 +09:00
smoogipoo	6cffbee592	Fix random/target mods not working in spectator	2021-09-14 17:22:58 +09:00
Dean Herbert	a7ae3cc03e	Change SampleControlPoint time to use leniency in bindable changed event too	2021-09-14 16:24:55 +09:00
Dean Herbert	5058f28504	Remove breaking padding	2021-09-14 14:52:50 +09:00
Dean Herbert	8865e3cab8	Add back shake and tweak transform of text	2021-09-14 14:44:32 +09:00
Dean Herbert	e17b800470	Move shake logic into extension method	2021-09-14 14:44:23 +09:00
Dean Herbert	7bd749d0eb	Remove weird shaking	2021-09-14 14:19:55 +09:00
Dean Herbert	e3c56f9ebd	Show error message in popover	2021-09-14 14:14:06 +09:00
Dean Herbert	eaac2bad3d	Fix incorrect child margin specifications	2021-09-14 13:49:02 +09:00
smoogipoo	3df4cbca2c	Reduce precision of difficulty calculator tests	2021-09-14 13:45:10 +09:00
Opelkuh	9fd616c578	Tiny refactor	2021-09-14 00:16:42 +02:00
Opelkuh	224244801f	Remove Particles namespace	2021-09-13 21:44:27 +02:00
Opelkuh	cfcb46034c	Remove ParticleJet	2021-09-13 21:44:23 +02:00
Opelkuh	99eff4f41f	Move cursor particles under OsuCursorContainer	2021-09-13 21:44:22 +02:00
Opelkuh	c2f7b01ca4	Change particle AngularVelocity into StartAngle and EndAngle	2021-09-13 21:44:21 +02:00
Opelkuh	6d68da8ff0	Remove StartScale from ParticleSpewer particles	2021-09-13 21:44:20 +02:00
Opelkuh	db662f8c5c	Add ParticleParent option to ParticleSpewer	2021-09-13 21:44:20 +02:00
Opelkuh	328c9a5dd0	Change ParticleSpewer.Active to a Bindable	2021-09-13 21:44:18 +02:00
Opelkuh	4c753420d3	Fix ParticleSpewer gravity calculation	2021-09-13 21:44:17 +02:00
Opelkuh	714cf33aac	Change ParticleSpewer to use screen space	2021-09-13 21:44:17 +02:00
Opelkuh	1a60ce164e	Add ParticleJet	2021-09-13 21:44:16 +02:00
Bartłomiej Dach	35ee889e5b	Restore clipboard content after difficulty switch	2021-09-13 21:04:27 +02:00
Bartłomiej Dach	79d0f4835e	Add failing tests for preserving clipboard content	2021-09-13 21:03:30 +02:00
Bartłomiej Dach	3fc72271f1	Restore editor clock time after difficulty switch	2021-09-13 20:59:31 +02:00
AbstractQbit	3c75094f43	Move BarHitErrorMeter's icon reorintation to Update()	2021-09-13 19:41:55 +03:00
AbstractQbit	7267602b95	Fix icon orientation for horizontal bar hit error meter	2021-09-13 17:14:39 +03:00